1. 27 Jun, 2007 28 commits
    • weinig's avatar
      Reviewed by Maciej. · 8db24bf4
      weinig authored
              2nd patch for http://bugs.webkit.org/show_bug.cgi?id=14111
              Autogenerate Event JS binding
      
              - Cleanup kjs_events
      
              * bindings/js/kjs_events.cpp:
              (WebCore::JSAbstractEventListener::JSAbstractEventListener):
              (WebCore::JSAbstractEventListener::handleEvent):
              (WebCore::JSAbstractEventListener::isHTMLEventListener):
              (WebCore::JSUnprotectedEventListener::JSUnprotectedEventListener):
              (WebCore::JSUnprotectedEventListener::~JSUnprotectedEventListener):
              (WebCore::JSUnprotectedEventListener::listenerObj):
              (WebCore::JSUnprotectedEventListener::windowObj):
              (WebCore::JSUnprotectedEventListener::clearWindowObj):
              (WebCore::JSUnprotectedEventListener::mark):
              (WebCore::JSEventListener::JSEventListener):
              (WebCore::JSEventListener::~JSEventListener):
              (WebCore::JSEventListener::listenerObj):
              (WebCore::JSEventListener::windowObj):
              (WebCore::JSEventListener::clearWindowObj):
              (WebCore::JSLazyEventListener::JSLazyEventListener):
              (WebCore::JSLazyEventListener::listenerObj):
              (WebCore::JSLazyEventListener::parseCode):
              (WebCore::getNodeEventListener):
              (WebCore::JSClipboard::JSClipboard):
              (WebCore::JSClipboard::getValueProperty):
              (WebCore::JSClipboard::putValueProperty):
              (WebCore::JSClipboardPrototypeFunction::callAsFunction):
              (WebCore::toJS):
              (WebCore::toClipboard):
              * bindings/js/kjs_events.h:
              (WebCore::JSClipboard::classInfo):
              (WebCore::JSClipboard::impl):
              * bindings/js/kjs_window.h:
              * ksvg2/events/JSSVGLazyEventListener.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23841 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8db24bf4
    • weinig's avatar
      LayoutTests: · ee3cb525
      weinig authored
              Reviewed by Adam Roben.
      
              Tests for http://bugs.webkit.org/show_bug.cgi?id=12045
              Crash under gmalloc at WTF::RefPtr<WebCore::HTMLSliderThumbElement>::operator->
              <rdar://problem/5286670>
      
              * fast/forms/thumbslider-crash-expected.checksum: Added.
              * fast/forms/thumbslider-crash-expected.png: Added.
              * fast/forms/thumbslider-crash-expected.txt: Added.
              * fast/forms/thumbslider-crash.html: Added.
              * fast/forms/thumbslider-no-parent-slider-expected.checksum: Added.
              * fast/forms/thumbslider-no-parent-slider-expected.png: Added.
              * fast/forms/thumbslider-no-parent-slider-expected.txt: Added.
              * fast/forms/thumbslider-no-parent-slider.html: Added.
      
      WebCore:
      
              Reviewed by Adam Roben.
      
              Patch for http://bugs.webkit.org/show_bug.cgi?id=12045
              Crash under gmalloc at WTF::RefPtr<WebCore::HTMLSliderThumbElement>::operator->
              <rdar://problem/5286670>
      
              Test: fast/forms/thumbslider-no-parent-slider.html
              Test: fast/forms/thumbslider-crash.html
      
              * rendering/RenderObject.h:
              (WebCore::RenderObject::isSlider):
              * rendering/RenderSlider.h:
              (WebCore::RenderSlider::isSlider):
              * rendering/RenderTheme.cpp:
              (WebCore::RenderTheme::paint): Only paint thumbslider
              if the parent renderer is a RenderSlider.
              * rendering/RenderThemeMac.mm:
              (WebCore::RenderThemeMac::paintSliderThumb):
              * rendering/RenderThemeSafari.cpp:
              (WebCore::RenderThemeSafari::paintSliderThumb):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23840 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ee3cb525
    • staikos's avatar
      Missed this file as part of #23832 · b0352f14
      staikos authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23839 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b0352f14
    • staikos's avatar
      Make Qt builds link when XSLT is disabled · 9e442628
      staikos authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23838 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9e442628
    • sfalken's avatar
      Turn on static code analysis (Windows only). · e699fb5f
      sfalken authored
              Affects only folks that have Visual Studio Team Suite installed,
              or who have replaced their compiler with the version shipping in the
              Vista SDK.
              
              Reviewed by Oliver.
      
              * WebCore.vcproj/WebCore.vcproj:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23837 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e699fb5f
    • staikos's avatar
      Remove files that no longer exist (were commented out) · 8ce5bad9
      staikos authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23836 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8ce5bad9
    • staikos's avatar
      revert IDL change until the code generator is fixed · 7dc098b1
      staikos authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23835 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7dc098b1
    • justing's avatar
      LayoutTests: · 49ae9609
      justing authored
              Reviewed by John.
              
              <rdar://problem/5247341> REGRESSION: Pasting sometimes loses trailing newline
              
              Demonstrates the bug:
              * editing/pasteboard/5247341-expected.checksum: Added.
              * editing/pasteboard/5247341-expected.png: Added.
              * editing/pasteboard/5247341-expected.txt: Added.
              * editing/pasteboard/5247341.html: Added.
              
              The changes in this patch exposed three bugs (5296964, 5296977, and 5299425).
              Added FIXMES for them.  Also removed tabs in them:
              * editing/pasteboard/paste-table-003-expected.checksum:
              * editing/pasteboard/paste-table-003-expected.png:
              * editing/pasteboard/paste-table-003-expected.txt:
              * editing/pasteboard/paste-table-003.html:
              * fast/forms/textarea-paste-newline.html:
              
              Equivalent trees:
              * editing/pasteboard/paste-text-016-expected.txt:
              * editing/pasteboard/paste-text-017-expected.txt:
      
      WebCore:
      
              Reviewed by John.
      
              <rdar://problem/5247341> REGRESSION: Pasting sometimes leaves out trailing newline
              
              Pasting with a trailing interchange newline doesn't work when pasting
              into an empty line.  Code that handles removing brs at the insertion
              position tries to also handle trailing interchange newlines by re-using
              those brs and fails.  Removed that code and handle all interchange
              newlines with code later in doApply().
      
              * editing/ReplaceSelectionCommand.cpp:
              (WebCore::ReplaceSelectionCommand::doApply): Don't try to re-use the
              endBR when there's a trailing interchange newline.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23834 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      49ae9609
    • staikos's avatar
      Use the proper macros so that it builds with !SVG and !XPATH · 97d6f9c3
      staikos authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23833 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      97d6f9c3
    • staikos's avatar
      Fix compilation with various Qt configurations · 46a4731f
      staikos authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23832 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      46a4731f
    • sfalken's avatar
      Fix ChangeLog. · 145c42cf
      sfalken authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23831 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      145c42cf
    • sfalken's avatar
      Turn on static code analysis. · e28e67b3
      sfalken authored
              Reviewed by Oliver.
              
              Effects only folks that have Visual Studio Team Suite installed,
              or who have replaced their compiler with the version shipping in the
              Vista SDK.
      
              * CodeAnalysisConfig.h: Added.
              * WebKit.vcproj/WebKit.vcproj:
              * WebLocalizableStrings.cpp:
              (createWebKitBundle):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23830 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e28e67b3
    • sfalken's avatar
      Prefast: Remove variable redefinitions in inner scopes. · 9595f956
      sfalken authored
              
              Reviewed by Ada.
      
              * WebDownload.cpp:
              (WebDownload::didFinish):
              * WebNotificationCenter.cpp:
              (WebNotificationCenter::postNotificationInternal):
              (WebNotificationCenter::removeObserver):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23829 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9595f956
    • sfalken's avatar
      Remove SEH block from around history plist read, since the underlying bug has been fixed. · 76c1152a
      sfalken authored
              
              Reviewed by Darin.
      
              * WebHistory.cpp:
              (createHistoryListFromStream):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23828 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      76c1152a
    • andersca's avatar
      Reviewed by Oliver. · f6887523
      andersca authored
              <rdar://problem/5253950>
              When Shockwave plugin has been loaded, exiting crashes Safari
              
              Add a "load count" for plugin packages. When the load count is zero, unload the plugin.
              
              * plugins/win/PluginPackageWin.cpp:
              (WebCore::PluginPackageWin::PluginPackageWin):
              (WebCore::PluginPackageWin::load):
              (WebCore::PluginPackageWin::unload):
              (WebCore::PluginPackageWin::unloadWithoutShutdown):
              * plugins/win/PluginPackageWin.h:
              
              * plugins/win/PluginViewWin.cpp:
              (WebCore::PluginViewWin::~PluginViewWin):
              Make sure to unload the plugin package and clear any references to plugin script objects.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23827 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f6887523
    • staikos's avatar
      We were compiling purely out of luck, but if qmake sets up the build order · cd48d7bd
      staikos authored
      slightly differently it fails.  This forces a dependency to generate HTMLNames.h
      in time.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23826 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cd48d7bd
    • staikos's avatar
      Patch from Eli Fidler to compile when QT_NO_IMAGE_TEXT is defined. · c729dcd2
      staikos authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23825 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c729dcd2
    • staikos's avatar
      Patch from Eli Fidler to remove QT3_SUPPORT dependency in ICO handler. · 073436bc
      staikos authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23824 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      073436bc
    • justing's avatar
      LayoutTests: · 66bf5f6e
      justing authored
              Reviewed by John.
              
              <rdar://problem/4580583> Breaking blockquoted list should not automatically renumber the second list
      
              Splits a quoted list w/o splitting a list item:
              * editing/execCommand/4580583-1-expected.checksum: Added.
              * editing/execCommand/4580583-1-expected.png: Added.
              * editing/execCommand/4580583-1-expected.txt: Added.
              * editing/execCommand/4580583-1.html: Added.
              
              Split a quoted list item:
              * editing/execCommand/4580583-2-expected.checksum: Added.
              * editing/execCommand/4580583-2-expected.png: Added.
              * editing/execCommand/4580583-2-expected.txt: Added.
              * editing/execCommand/4580583-2.html: Added.
      
      WebCore:
      
              Reviewed by John.
      
              <rdar://problem/4580583> Breaking blockquoted list should not automatically renumber the second list
              
              When a quoted numbered list is broken in half, it's cloned
              to make the second list. That second list needs its start attribute
              set so that the numbers of the list items in it will be preserved.
      
              * editing/BreakBlockquoteCommand.cpp:
              (WebCore::BreakBlockquoteCommand::doApply): Set the start attribute
              of a cloned list to be the original number of the first list item in it.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23823 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      66bf5f6e
    • sfalken's avatar
      Prefast: Fix misplaced parenthesis. · 1bdd6033
      sfalken authored
              
              Reviewed by Darin.
      
              * WebView.cpp:
              (core):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23822 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1bdd6033
    • ap's avatar
      Reviewed by Geoff. · 73eb5106
      ap authored
              http://bugs.webkit.org/show_bug.cgi?id=14413
              GIF animation throttling is different from MSIE
      
              * platform/graphics/cg/ImageSourceCG.cpp:
              (WebCore::ImageSource::frameDurationAtIndex):
              Change the cut-off value to 50ms to match MSIE.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23821 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      73eb5106
    • sullivan's avatar
      Reviewed by Darin · 181fad97
      sullivan authored
              
              - WebKit support for displaying multiple text matches in PDF views (<rdar://problem/4601967>)
      
              * WebView/WebPDFView.h:
              new ivars textMatches and lastScrollPosition; now conforms to WebMultipleTextMatches protocol
              
              * WebView/WebPDFView.mm:
              (-[WebPDFView dealloc]):
              release textMatches
              (-[WebPDFView viewDidMoveToWindow]):
              start observing bounds changes in the PDF document's enclosing clip view, so we can notice when
              scrolling takes place
              (-[WebPDFView viewWillMoveToWindow:]):
              stop observing bounds changes in the PDF document's enclosing clip view
              (-[WebPDFView searchFor:direction:caseSensitive:wrap:startInSelection:]):
              most of the code here has been moved into the new method _nextMatchFor::::, which this now calls
              (-[WebPDFView setMarkedTextMatchesAreHighlighted:]):
              implementation of WebMultipleTextMatches protocol method, does nothing useful here because we don't
              support inline highlighting of matches in PDF documents
              (-[WebPDFView markedTextMatchesAreHighlighted]):
              implementation of WebMultipleTextMatches protocol method
              (-[WebPDFView markAllMatchesForText:caseSensitive:limit:]):
              implementation of WebMultipleTextMatches protocol method; calls _nextMatchFor:::: in a loop until
              entire document is searched or limit is hit; records results by saving PDFSelections in textMatches ivar
              (-[WebPDFView unmarkAllTextMatches]):
              implementation of WebMultipleTextMatches protocol method; clears saved textMatches
              (-[WebPDFView rectsForTextMatches]):
              implementation of WebMultipleTextMatches protocol method; converts saved PDFSelections into NSValue 
              objects that represent NSRects
              (-[WebPDFView _clipViewForPDFDocumentView]):
              new helper method to find the clip view whose bounds determine the current scroll position
              (-[WebPDFView _nextMatchFor:direction:caseSensitive:wrap:fromSelection:startInSelection:]):
              new helper method, extracted from searchFor:::::
              (-[WebPDFView _PDFDocumentViewMightHaveScrolled:]):
              new notification callback; tells webView's delegate when document has scrolled
              (-[WebPDFView _setTextMatches:]):
              new helper method, stores value in ivar
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23820 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      181fad97
    • sfalken's avatar
      Prefast: Add null check prior to writing into allocated BSTR. · 44fd9356
      sfalken authored
              
              Reviewed by Darin.
      
              * MarshallingHelpers.cpp:
              (MarshallingHelpers::CFStringRefToBSTR):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23819 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      44fd9356
    • sfalken's avatar
      Prefast: Add error handling for SysAllocStringLen where the string... · d23f2ed6
      sfalken authored
              Prefast: Add error handling for SysAllocStringLen where the string length is determined by website content.
      
              Reviewed by Sam, Darin.
                      
              Allocation failure will result in a null dereference in this case,
              so it isn't exploitable.
      
              * DefaultDownloadDelegate.cpp:
              (DefaultDownloadDelegate::decideDestinationWithSuggestedFilename):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23818 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d23f2ed6
    • ap's avatar
      Forgot to commit this file with r23815. · fedb7160
      ap authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23817 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fedb7160
    • weinig's avatar
      JavaScriptCore: · 7be0a71d
      weinig authored
              Reviewed by Darin.
      
              First pass at fixing implicit 64-32 bit conversion errors.
              <rdar://problem/5292262>
      
              - Add 'f' suffix where necessary.
      
              * kjs/testkjs.cpp:
              (StopWatch::getElapsedMS):
      
      WebCore:
      
              Reviewed by Darin.
      
              First pass at fixing implicit 64-32 bit conversion errors.
              <rdar://problem/5292262>
      
              - Add 'f' suffix where necessary.
      
              * bridge/mac/WebCoreAXObject.mm:
              (-[WebCoreAXObject accessibilityAttributeValue:forParameter:]):
              * css/csshelper.h:
              * css/cssstyleselector.cpp:
              (WebCore::):
              (WebCore::CSSStyleSelector::largerFontSize):
              (WebCore::CSSStyleSelector::smallerFontSize):
              * html/CanvasGradient.cpp:
              (WebCore::CanvasGradient::addColorStop):
              * html/CanvasPattern.cpp:
              (WebCore::CanvasPattern::createPattern):
              * ksvg2/css/SVGCSSStyleSelector.cpp:
              (WebCore::CSSStyleSelector::applySVGProperty):
              * ksvg2/css/SVGRenderStyle.h:
              * ksvg2/events/SVGZoomEvent.cpp:
              (WebCore::SVGZoomEvent::SVGZoomEvent):
              * ksvg2/svg/SVGLength.cpp:
              (WebCore::SVGLength::SVGLength):
              (WebCore::SVGLength::value):
              (WebCore::SVGLength::setValue):
              (WebCore::SVGLength::valueAsPercentage):
              (WebCore::SVGLength::PercentageOfViewport):
              * ksvg2/svg/SVGSVGElement.cpp:
              (WebCore::SVGSVGElement::pixelUnitToMillimeterX):
              (WebCore::SVGSVGElement::pixelUnitToMillimeterY):
              (WebCore::SVGSVGElement::getScreenCTM):
              * ksvg2/svg/SVGTextContentElement.cpp:
              (WebCore::SVGTextContentElement::getComputedTextLength):
              (WebCore::SVGTextContentElement::getSubStringLength):
              (WebCore::SVGTextContentElement::getRotationOfChar):
              * ksvg2/svg/SVGTransformDistance.cpp:
              (WebCore::SVGTransformDistance::SVGTransformDistance):
              (WebCore::SVGTransformDistance::distance):
              * page/InspectorController.cpp:
              (WebCore::InspectorResource::InspectorResource):
              * platform/graphics/FloatPoint3D.cpp:
              (WebCore::FloatPoint3D::normalize):
              * platform/graphics/Path.cpp:
              (WebCore::pathLengthApplierFunction):
              (WebCore::Path::createRoundedRectangle):
              * platform/graphics/cg/GraphicsContextCG.cpp:
              (WebCore::GraphicsContext::drawLine):
              (WebCore::GraphicsContext::strokeArc):
              * platform/graphics/cg/ImageCG.cpp:
              (WebCore::FrameData::clear):
              * platform/graphics/cg/ImageSourceCG.cpp:
              (WebCore::ImageSource::frameDurationAtIndex):
              * platform/graphics/cg/PDFDocumentImage.cpp:
              (WebCore::PDFDocumentImage::setCurrentPage):
              * platform/graphics/svg/SVGPaintServerPattern.cpp:
              (WebCore::SVGPaintServerPattern::externalRepresentation):
              * platform/graphics/svg/SVGPaintServerRadialGradient.cpp:
              (WebCore::SVGPaintServerRadialGradient::SVGPaintServerRadialGradient):
              * platform/graphics/svg/cg/SVGPaintServerGradientCg.cpp:
              (WebCore::cgGradientCallback):
              (WebCore::CGShadingRefForRadialGradient):
              (WebCore::SVGPaintServerGradient::updateQuartzGradientStopsCache):
              * platform/mac/FontDataMac.mm:
              (WebCore::webFallbackFontFamily):
              * platform/mac/PopupMenuMac.mm:
              (WebCore::PopupMenu::show):
              * rendering/InlineFlowBox.cpp:
              (WebCore::InlineFlowBox::placeBoxesHorizontally):
              * rendering/RenderSlider.cpp:
              (WebCore::RenderSlider::setValueForPosition):
              (WebCore::RenderSlider::setPositionFromValue):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23816 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7be0a71d
    • ap's avatar
      Reviewed by Geoff. · b6f73683
      ap authored
              http://bugs.webkit.org/show_bug.cgi?id=14288
              XMLHttpRequest doesn't use a correct content type for file:// URLs
      
              Test: fast/dom/xmlhttprequest-html-response-encoding.html
      
              * xml/xmlhttprequest.cpp:
              (WebCore::XMLHttpRequest::responseMIMEType): Use MIME type provided by
              the network layer, since it provides it even for non-HTTP responses.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23815 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b6f73683
    • oliver's avatar
      Reviewed by Maciej. · 2245768a
      oliver authored
              Hopefully fix remainder of the IME issues on Mac.  
              We now assume that the IME silently consumes any event given
              to it during text composition, and only override this assumption
              if the NSTextInput or NSResponder callbacks are made.
      
              This prevents us from treating those events that the IME has 
              consumed internally (eg. candidate window navigation) as unhandled
              events that should be bubbled.
      
              This fixes:
                <rdar://problem/5107538> Major problems handling key press event with non-english Input Methods
                <rdar://problem/4196249> REGRESSION: Mail: Inputting space (U+0020) with IM deletes subsequent line breaks on Mail.app
                <rdar://problem/5015544> REGRESSION: Reverse conversion keyboard command does not work in Safari.
                <rdar://problem/5045121> REGRESSION: Inline is confirmed after press left/right arrow keys, happens in Mail but not in TextEdit.
                <rdar://problem/5076807> REGRESSION: Can't undo conversion of inline text (by hitting ESC)
                <rdar://problem/5085781> REGRESSION: Active input area lost "selected" highlight
                <rdar://problem/5094200> space key pressed to close the associated words candidate window gets inserted as text
                <rdar://problem/5228294> Candidate item for character matrix is sometimes skipped
      
              * WebKit.xcodeproj/project.pbxproj:
              * WebView/WebHTMLView.mm:
              (-[WebHTMLView launchKeyEvent:]):
              (-[WebHTMLView keyDown:]):
              (-[WebHTMLView keyUp:]):
              (-[WebHTMLView _interceptEditingKeyEvent:shouldSaveCommand:]):
              (-[WebHTMLView unmarkText]):
              (-[WebHTMLView setMarkedText:selectedRange:]):
              (-[WebHTMLView doCommandBySelector:]):
              (-[WebHTMLView insertText:]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23813 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2245768a
  2. 26 Jun, 2007 12 commits
    • bdash's avatar
      2007-06-26 Alp Toker <alp.toker@collabora.co.uk> · 4c240434
      bdash authored
              Reviewed by Sam Weinig.
      
              http://bugs.webkit.org/show_bug.cgi?id=14061
              Implement more of FrameLoaderClientGdk
      
              Make FrameLoaderClientGdk work properly when the MIME type is set.
      
              * loader/gdk/FrameLoaderClientGdk.cpp:
              (WebCore::FrameLoaderClientGdk::objectContentType):
              (WebCore::FrameLoaderClientGdk::canShowMIMEType):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23812 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4c240434
    • bdash's avatar
      2007-06-26 Alp Toker <alp.toker@collabora.co.uk> · 5a06e1d4
      bdash authored
              Reviewed by Maciej.
      
              http://bugs.webkit.org/show_bug.cgi?id=14058
              Gdk font backend cleanup
      
              * platform/FontData.h: Remove obsolete function.
              * platform/gdk/FontDataGdk.cpp:
              (WebCore::FontData::containsCharacters): Lock/unlock only once.
              (WebCore::FontData::platformWidthForGlyph): Remove needless cast.
              * platform/gdk/FontPlatformData.h: Remove obsolete function.
              * platform/gdk/FontPlatformDataGdk.cpp:
              (WebCore::FontPlatformData::FontPlatformData): Pass the actual size,
              not the pixel size.
              (WebCore::FontPlatformData::~FontPlatformData): Free m_fontMatrix.
              * platform/gdk/GlyphPageTreeNodeGdk.cpp:
              (WebCore::GlyphPage::fill): Lock/unlock only once.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23811 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5a06e1d4
    • bdash's avatar
      2007-06-26 Mitz Pettel <mitz@webkit.org> · 5676a879
      bdash authored
              Reviewed by Hyatt.
      
              - fix http://bugs.webkit.org/show_bug.cgi?id=14406
                <colgroup>'s borders are ignored when it has <col> children
      
              Covered by existing tests.
      
              * rendering/RenderTableCell.cpp:
              (WebCore::RenderTableCell::collapsedLeftBorder):
              (WebCore::RenderTableCell::collapsedRightBorder):
              (WebCore::RenderTableCell::collapsedTopBorder):
              (WebCore::RenderTableCell::collapsedBottomBorder):
      
      2007-06-26  Mitz Pettel  <mitz@webkit.org>
      
              Reviewed by Hyatt.
      
              - updated results for http://bugs.webkit.org/show_bug.cgi?id=14406
                <colgroup>'s borders are ignored when it has <col> children
      
              * tables/mozilla/core/table_rules-expected.checksum: Added.
              * tables/mozilla/core/table_rules-expected.png: Added.
              * tables/mozilla/core/table_rules-expected.txt: Added.
              * tables/mozilla/core/table_rules.html: Copied from LayoutTests/tables/mozilla_expected_failures/core/table_rules.html.
              * tables/mozilla/marvin/x_table_rules_groups-expected.checksum: Added.
              * tables/mozilla/marvin/x_table_rules_groups-expected.png: Added.
              * tables/mozilla/marvin/x_table_rules_groups-expected.txt: Added.
              * tables/mozilla/marvin/x_table_rules_groups.xml: Copied from LayoutTests/tables/mozilla_expected_failures/marvin/x_table_rules_groups.xml.
              * tables/mozilla_expected_failures/core/table_rules-expected.checksum: Removed.
              * tables/mozilla_expected_failures/core/table_rules-expected.png: Removed.
              * tables/mozilla_expected_failures/core/table_rules-expected.txt: Removed.
              * tables/mozilla_expected_failures/core/table_rules.html: Removed.
              * tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.checksum:
              * tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.txt:
              * tables/mozilla_expected_failures/marvin/x_table_rules_groups-expected.checksum: Removed.
              * tables/mozilla_expected_failures/marvin/x_table_rules_groups-expected.png: Removed.
              * tables/mozilla_expected_failures/marvin/x_table_rules_groups-expected.txt: Removed.
              * tables/mozilla_expected_failures/marvin/x_table_rules_groups.xml: Removed.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23810 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5676a879
    • bdash's avatar
      2007-06-26 Mitz Pettel <mitz@webkit.org> · 1620c33c
      bdash authored
              Reviewed by Oliver.
      
              - fix http://bugs.webkit.org/show_bug.cgi?id=14329
                REGRESSION: TEXTAREA - cannot drag-and-drop text at en.wikipedia.org/
      
              Test: fast/repaint/text-selection-rect-in-overflow-2.html
      
              * rendering/RenderObject.cpp:
              (WebCore::RenderObject::computeAbsoluteRepaintRect): Added code to account
              for overflow scroll and columns.
              * rendering/RenderText.cpp:
              (WebCore::RenderText::selectionRect): Adjust for columns only in the
              non-clipped case, since RenderObject::absolutePosition() does not.
      
      2007-06-26  Mitz Pettel  <mitz@webkit.org>
      
              Reviewed by Oliver.
      
              - repaint test for http://bugs.webkit.org/show_bug.cgi?id=14329
                REGRESSION: TEXTAREA - cannot drag-and-drop text at en.wikipedia.org/
      
              * fast/repaint/resources/text-selection-rect-in-overflow-frame.html: Added.
              * fast/repaint/text-selection-rect-in-overflow-2-expected.checksum: Added.
              * fast/repaint/text-selection-rect-in-overflow-2-expected.png: Added.
              * fast/repaint/text-selection-rect-in-overflow-2-expected.txt: Added.
              * fast/repaint/text-selection-rect-in-overflow-2.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23809 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1620c33c
    • bdash's avatar
      2007-06-26 Mitz Pettel <mitz@webkit.org> · af191524
      bdash authored
              Reviewed by Sam.
      
              - http://bugs.webkit.org/show_bug.cgi?id=14415
                Remove the unused method RenderObject::setTable()
      
              * rendering/RenderObject.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23808 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      af191524
    • aroben's avatar
      Touching config.h to force WebCore to rebuild after r23806 · 808a0025
      aroben authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23807 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      808a0025
    • bdash's avatar
      2007-06-26 MorganL <morganl.webkit@yahoo.com> · 8a3fea5f
      bdash authored
              Reviewed by Maciej.
      
              Implement http://bugs.webkit.org/show_bug.cgi?id=14225
              Bug 14225: Make it possible to define platform-specific ResourceRequest without #ifdefs
      
              This change moves the bulk of ResourceRequest into a base class named
              ResourceRequestBase with all platform-specific bits pushed into
              ResourceRequest.  This allows ports to easily add new members to a
              ResourceRequest without having to #ifdef the code that is shared
              between ports.
      
              * WebCore.exp:
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * platform/network/ResourceRequest.cpp: Removed.
              * platform/network/ResourceRequest.h: Removed.
              * platform/network/ResourceRequestBase.cpp: Added.
              (WebCore::ResourceRequestBase::asResourceRequest):
              (WebCore::ResourceRequestBase::isEmpty):
              (WebCore::ResourceRequestBase::isNull):
              (WebCore::ResourceRequestBase::url):
              (WebCore::ResourceRequestBase::setURL):
              (WebCore::ResourceRequestBase::cachePolicy):
              (WebCore::ResourceRequestBase::setCachePolicy):
              (WebCore::ResourceRequestBase::timeoutInterval):
              (WebCore::ResourceRequestBase::setTimeoutInterval):
              (WebCore::ResourceRequestBase::mainDocumentURL):
              (WebCore::ResourceRequestBase::setMainDocumentURL):
              (WebCore::ResourceRequestBase::httpMethod):
              (WebCore::ResourceRequestBase::setHTTPMethod):
              (WebCore::ResourceRequestBase::httpHeaderFields):
              (WebCore::ResourceRequestBase::httpHeaderField):
              (WebCore::ResourceRequestBase::setHTTPHeaderField):
              (WebCore::ResourceRequestBase::httpBody):
              (WebCore::ResourceRequestBase::setHTTPBody):
              (WebCore::ResourceRequestBase::allowHTTPCookies):
              (WebCore::ResourceRequestBase::setAllowHTTPCookies):
              (WebCore::ResourceRequestBase::addHTTPHeaderField):
              (WebCore::ResourceRequestBase::addHTTPHeaderFields):
              (WebCore::operator==):
              (WebCore::ResourceRequestBase::isConditional):
              (WebCore::ResourceRequestBase::updatePlatformRequest):
              (WebCore::ResourceRequestBase::updateResourceRequest):
              * platform/network/ResourceRequestBase.h: Added.
              (WebCore::):
              (WebCore::ResourceRequestBase::httpContentType):
              (WebCore::ResourceRequestBase::setHTTPContentType):
              (WebCore::ResourceRequestBase::httpReferrer):
              (WebCore::ResourceRequestBase::setHTTPReferrer):
              (WebCore::ResourceRequestBase::clearHTTPReferrer):
              (WebCore::ResourceRequestBase::httpUserAgent):
              (WebCore::ResourceRequestBase::setHTTPUserAgent):
              (WebCore::ResourceRequestBase::httpAccept):
              (WebCore::ResourceRequestBase::setHTTPAccept):
              (WebCore::ResourceRequestBase::ResourceRequestBase):
              (WebCore::operator!=):
              * platform/network/cf/ResourceRequest.h: Added.
              (WebCore::ResourceRequest::ResourceRequest):
              * platform/network/curl/ResourceRequest.h: Added.
              (WebCore::ResourceRequest::ResourceRequest):
              (WebCore::ResourceRequest::doUpdatePlatformRequest):
              (WebCore::ResourceRequest::doUpdateResourceRequest):
              * platform/network/mac/ResourceRequest.h: Added.
              (WebCore::ResourceRequest::ResourceRequest):
              * platform/network/qt/ResourceRequest.h: Added.
              (WebCore::ResourceRequest::ResourceRequest):
              (WebCore::ResourceRequest::doUpdatePlatformRequest):
              (WebCore::ResourceRequest::doUpdateResourceRequest):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23806 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8a3fea5f
    • bdash's avatar
      2007-06-26 Jim Correia <jim.correia@pobox.com> · c6b07b6a
      bdash authored
              Reviewed by Darin.
      
              Fix http://bugs.webkit.org/show_bug.cgi?id=14411
              Bug 14411: WebNetscapePluginPackage overagressively sets CurApRefNum, which affects shipping versions of BBEdit.
              <rdar://problem/5297268>
      
              * Plugins/WebNetscapePluginPackage.m:
              (+[WebNetscapePluginPackage initialize]): Force the Resource Manager to
              lazy initialize, and only set CurApRefNum to the system file if
              CurApRefNum is still -1 after that forced lazy initialization.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23805 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c6b07b6a
    • aroben's avatar
      Add ChangeLog entries from the Windows merge. · db3837c5
      aroben authored
      Reviewed by Maciej.
      
      * ChangeLog:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23804 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      db3837c5
    • weinig's avatar
      LayoutTests: · f8e2e224
      weinig authored
              Reviewed by Maciej.
      
              Make sure not to enumerate the toString() function.
              <rdar://problem/5297118>
      
              * fast/dom/Window/window-appendages-cleared-expected.txt:
              * fast/dom/Window/window-properties-expected.txt:
              * fast/js/toString-dontEnum-expected.txt: Added.
              * fast/js/toString-dontEnum.html: Added.
      
      WebCore:
      
              Reviewed by Maciej.
      
              Make sure not to enumerate the toString() function.
              <rdar://problem/5297118>
      
              * bindings/js/kjs_window.cpp:
              * bindings/scripts/CodeGeneratorJS.pm: Add support for [DontEnum].
              * html/HTMLAnchorElement.idl:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23803 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f8e2e224
    • ggaren's avatar
      Reviewed by Maciej Stachowiak. · c60a257a
      ggaren authored
              
              Fixed <rdar://problem/5296627> JSGarbageCollect headerdoc suggests that 
              using JavaScriptCore requires leaking memory
      
              * API/JSBase.h: Changed documentation to explain that you can pass NULL
              to JSGarbageCollect.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23802 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c60a257a
    • andersca's avatar
      Reviewed by Mitz, landed by Anders. · 1465970a
      andersca authored
              http://bugs.webkit.org/show_bug.cgi?id=14421
              Implement GraphicsContext::clearRect()
      
              * platform/graphics/cairo/GraphicsContextCairo.cpp:
              (WebCore::GraphicsContext::clearRect):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@23801 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1465970a