1. 09 Nov, 2008 4 commits
  2. 08 Nov, 2008 8 commits
    • antti@apple.com's avatar
      WebCore: · 58f7c694
      antti@apple.com authored
      2008-11-08  Antti Koivisto  <antti@apple.com>
      
              Reviewed by Sam Weinig.
              
              Fix https://bugs.webkit.org/show_bug.cgi?id=22141
              REGRESSION: Safari error page is not fully styled when loaded from cache
              
              Reset text decoder on flush so it does not pass through the BOM when it is reused.
      
              Test: fast/encoding/css-cached-bom.html
      
              * loader/TextResourceDecoder.cpp:
              (WebCore::TextResourceDecoder::flush):
      
      LayoutTests:
      
      2008-11-08  Antti Koivisto  <antti@apple.com>
      
              Reviewed by Sam Weinig.
              
              Test for https://bugs.webkit.org/show_bug.cgi?id=22141
              REGRESSION: Safari error page is not fully styled when loaded from cache
      
              * fast/encoding/css-cached-bom.html: Added.
              * fast/encoding/css-cached-bom-expected.txt: Added.
              * fast/encoding/resources/css-cached-bom-frame.html: Added.
              * fast/encoding/resources/utf-16-little-endian.css: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38240 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      58f7c694
    • kevino@webkit.org's avatar
      Reviewed by Mark Rowe. · 2cba33ba
      kevino@webkit.org authored
      Send URL errors to stderr rather than stdout. While debugging wx DumpRenderTree,
      it was causing these errors to end up in the page's text representation.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38239 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2cba33ba
    • kevino@webkit.org's avatar
      dbcd4add
    • simon.fraser@apple.com's avatar
      2008-11-08 Simon Fraser <simon.fraser@apple.com> · 1839efcf
      simon.fraser@apple.com authored
              Reviewed by Dan Bernstein
      
              https://bugs.webkit.org/show_bug.cgi?id=21906
      
              Override addFocusRingRects() in RenderTextControl to avoid
              the RenderFlow behavior of recursing on descendent renderers.
              RenderTextControl should only ever need a simple focus rect.
      
              This fixes focus ring issues with transforms on text controls.
      
              Test: fast/transforms/transformed-focused-text-input.html
      
              * rendering/RenderTextControl.cpp:
              (WebCore::RenderTextControl::addFocusRingRects):
              * rendering/RenderTextControl.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38237 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1839efcf
    • timothy@apple.com's avatar
      Make sure the icon thumbnail width/height is at least 1px in · cded56b0
      timothy@apple.com authored
              the Web Inspector's resource panel.
      
              <rdar://problem/5988888>
      
              Reviewed by Tim Hatcher.
      
              * inspector/front-end/inspector.css:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38236 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cded56b0
    • ddkilzer@apple.com's avatar
      Bug 22137: PLATFORM(MAC) build broken with HAVE(ACCESSIBILITY) disabled · e17e0dcc
      ddkilzer@apple.com authored
              <https://bugs.webkit.org/show_bug.cgi?id=22137>
      
              Reviewed by Darin Adler.
      
      WebCore:
      
              * page/AccessibilityObject.h:
              (WebCore::AccessibilityObject::accessibilityIgnoreAttachment):
              Provide a default implementation when HAVE(ACCESSIBILITY) is false.
              * page/mac/AXObjectCacheMac.mm: Added HAVE(ACCESSIBILITY) guard.
              * page/mac/AccessibilityObjectMac.mm: Ditto.
              * page/mac/AccessibilityObjectWrapper.mm: Ditto.
      
      WebKit/mac:
      
              * WebView/WebFrame.mm:
              (-[WebFrame _accessibilityTree]): Return nil if HAVE(ACCESSIBILITY)
              is false.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38235 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e17e0dcc
    • mitz@apple.com's avatar
      WebCore: · c278ea20
      mitz@apple.com authored
              Reviewed by Darin Adler.
      
              - WebCore part of adding WebPreferences for controlling databases and local storage
      
              * WebCore.base.exp: Exported Settings::setDatabasesEnabled() and
              Settings::setLocalStorageEnabled().
              * page/DOMWindow.cpp:
              (WebCore::DOMWindow::localStorage): Changed to return 0 if local storage
              is disabled in settings.
              (WebCore::DOMWindow::openDatabase): Changed to return 0 if databases
              are disabled in settings.
              * page/Settings.cpp:
              (WebCore::Settings::Settings): Initialize m_databasesEnabled and
              m_localStorageEnabled.
              (WebCore::Settings::setDatabasesEnabled): Added.
              (WebCore::Settings::setLocalStorageEnabled): Added.
              * page/Settings.h:
              (WebCore::Settings::databasesEnabled): Added.
              (WebCore::Settings::localStorageEnabled): Added.
      
      WebKit/mac:
      
              Reviewed by Darin Adler.
      
              - WebKit/mac part of adding WebPreferences for controlling databases and local storage
      
              * WebView/WebPreferenceKeysPrivate.h: Added
              WebKitDatabasesEnabledPreferenceKey and
              WebKitLocalStorageEnabledPreferenceKey.
              * WebView/WebPreferences.mm:
              (+[WebPreferences initialize]): Made databases and local storage enabled
              by default.
              (-[WebPreferences databasesEnabled]): Added.
              (-[WebPreferences setDatabasesEnabled:]): Added.
              (-[WebPreferences localStorageEnabled]): Added.
              (-[WebPreferences setLocalStorageEnabled:]): Added.
              * WebView/WebPreferencesPrivate.h:
              * WebView/WebView.mm:
              (-[WebView _preferencesChangedNotification:]): Transfer the databases
              and local storage preferences to WebCore settings.
      
      WebKit/win:
      
              Reviewed by Darin Adler.
      
              - WebKit/win part of adding WebPreferences for controlling databases and local storage
      
              * Interfaces/IWebPreferencesPrivate.idl: Declared setDatabasesEnabled,
              databasesEnabled, setLocalStorageEnabled and localStorageEnabled.
              * WebPreferenceKeysPrivate.h: Added WebKitDatabasesEnabledPreferenceKey
              and WebKitLocalStorageEnabledPreferenceKey.
              * WebPreferences.cpp:
              (WebPreferences::initializeDefaultSettings): Made databases and local
              storage enabled by default.
              (WebPreferences::setDatabasesEnabled): Added.
              (WebPreferences::databasesEnabled): Added.
              (WebPreferences::setLocalStorageEnabled): Added.
              (WebPreferences::localStorageEnabled): Added.
              * WebPreferences.h:
              * WebView.cpp:
              (WebView::notifyPreferencesChanged): Transfer the databases and local
              storage preferences to WebCore settings.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38234 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c278ea20
    • staikos@webkit.org's avatar
      Just adjusting email address in changelog. · 2fe21acf
      staikos@webkit.org authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38233 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2fe21acf
  3. 07 Nov, 2008 20 commits
  4. 06 Nov, 2008 8 commits
    • ap@webkit.org's avatar
      Reviewed by Darin Adler. · 6169aa2f
      ap@webkit.org authored
              https://bugs.webkit.org/show_bug.cgi?id=22097
              Expose MessageEvent constructor on WorkerContext
      
              * bindings/js/JSWorkerContext.cpp:
              (WebCore::jsWorkerContextMessageEvent):
              (WebCore::setJSWorkerContextMessageEvent):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38212 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6169aa2f
    • ap@webkit.org's avatar
      Reviewed by Darin Adler. · d9634612
      ap@webkit.org authored
              https://bugs.webkit.org/show_bug.cgi?id=21107
              <rdar://problem/6264219> New access key combination conflicts with VoiceOver
      
              * page/EventHandler.h:
              * page/gtk/EventHandlerGtk.cpp:
              (WebCore::EventHandler::accessKeyModifiers):
              * page/qt/EventHandlerQt.cpp:
              (WebCore::EventHandler::accessKeyModifiers):
              * page/win/EventHandlerWin.cpp:
              (WebCore::EventHandler::accessKeyModifiers):
              * page/wx/EventHandlerWx.cpp:
              (WebCore::EventHandler::accessKeyModifiers):
              Access access key modifiers via a function, not a static variable.
      
              * page/mac/EventHandlerMac.mm: (WebCore::EventHandler::accessKeyModifiers):
              Use Ctrl when VoiceOver is enabled, because a conflict with Emacs-style key bindings is
              less troublesome than one with VO keys.
      
              * page/EventHandler.cpp: (WebCore::EventHandler::handleAccessKey):
              Also fix an access key matching bug introduced in r32424 - Any superset of specified
              modifier set invoked access keys. We can use simple equality comparison instead because
              CapsLock is not part of modifiers(), so it doesn't need to be ignored explicitly.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38211 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d9634612
    • andersca@apple.com's avatar
      WebCore: · 1f7f4ee0
      andersca@apple.com authored
      2008-11-06  Anders Carlsson  <andersca@apple.com>
      
              Reviewed by Kevin Decker.
      
              https://bugs.webkit.org/show_bug.cgi?id=22115
              NPN_HasPropertyUPP and NPN_HasMethodUPP entries in NPNetscapeFuncs are NULL
      
              Export _NPN_HasMethod and _NPN_HasProperty.
              
              * WebCore.NPAPI.exp:
      
      WebKit/mac:
      
      2008-11-06  Anders Carlsson  <andersca@apple.com>
      
              Reviewed by Kevin Decker.
      
              https://bugs.webkit.org/show_bug.cgi?id=22115
              NPN_HasPropertyUPP and NPN_HasMethodUPP entries in NPNetscapeFuncs are NULL
              
              Initialize the browser funcs correctly.
              
              * Plugins/WebNetscapePluginPackage.m:
              (-[WebNetscapePluginPackage load]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38210 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1f7f4ee0
    • barraclough@apple.com's avatar
      2008-11-06 Gavin Barraclough barraclough@apple.com · 52eea529
      barraclough@apple.com authored
              Reviewed by Oliver Hunt.
      
              Do not make a cti_* call to perform an op_call unless either:
              (1) The codeblock for the function body has not been generated.
              (2) The number of arguments passed does not match the callee arity.
      
              ~1% progression on sunspider --v8
      
              * VM/CTI.cpp:
              (JSC::CTI::compileOpCallInitializeCallFrame):
              (JSC::CTI::compileOpCall):
              (JSC::CTI::privateCompileSlowCases):
              * VM/CTI.h:
              * VM/Machine.cpp:
              (JSC::Machine::cti_op_call_JSFunction):
              (JSC::Machine::cti_op_call_arityCheck):
              (JSC::Machine::cti_op_construct_JSConstruct):
              * VM/Machine.h:
              * kjs/nodes.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38209 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      52eea529
    • simon.fraser@apple.com's avatar
      2008-11-06 Simon Fraser <simon.fraser@apple.com> · a80e3173
      simon.fraser@apple.com authored
              Reviewed by Antti Koivisto
      
              https://bugs.webkit.org/show_bug.cgi?id=15678
      
              Fix transformed menu selects to show the popup in the correct
              location.
      
              * rendering/RenderMenuList.cpp:
              (WebCore::RenderMenuList::showPopup):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38208 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a80e3173
    • ddkilzer@apple.com's avatar
      BUILD FIX: Backed out r38189 (and r38203) for Xcode 3.0. · 58912bd4
      ddkilzer@apple.com authored
      WebCore:
      
              BUILD FIX: Backed out r38189 (and r38203) for Xcode 3.0.
      
              Apparently older versions of gcc have issues with this patch.
              Backing out a second time until the issues are resolved.
      
      WebKit/mac:
      
              BUILD FIX: Backed out r38189 (and r38203) for Xcode 3.0.
      
              Apparently older versions of gcc have issues with this patch.
              Backing out a second time until the issues are resolved.
      
      WebKitTools:
      
              BUILD FIX: Backed out r38189 (and r38203) for Xcode 3.0.
      
              Apparently older versions of gcc have issues with this patch.
              Backing out a second time until the issues are resolved.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38207 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      58912bd4
    • jchaffraix@webkit.org's avatar
      2008-11-06 Julien Chaffraix <jchaffraix@pleyo.com> · 95833728
      jchaffraix@webkit.org authored
              Reviewed by Maciej Stachowiak.
      
              Bug 21106: .in format discussed changes
              https://bugs.webkit.org/show_bug.cgi?id=21106
      
              Include the namespace into the interfaceName.
      
              * dom/make_names.pl: Do not append the namespace when
              using the interfaceName.
              * html/HTMLTagNames.in: Added namespace prefix for custom
              interfaceName.
              * svg/svgtags.in: Ditto.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38206 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      95833728
    • cwzwarich@webkit.org's avatar
      2008-11-06 Cameron Zwarich <zwarich@apple.com> · 3ff0e6a7
      cwzwarich@webkit.org authored
              Reviewed by Geoff Garen.
      
              Move the remaining files in the kjs subdirectory of JavaScriptCore to
              a new parser subdirectory, and remove the kjs subdirectory entirely.
      
              JavaScriptCore:
      
              * AllInOneFile.cpp:
              * DerivedSources.make:
              * GNUmakefile.am:
              * JavaScriptCore.pri:
              * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
              * JavaScriptCore.vcproj/WTF/WTF.vcproj:
              * JavaScriptCore.vcproj/jsc/jsc.vcproj:
              * JavaScriptCore.xcodeproj/project.pbxproj:
              * JavaScriptCoreSources.bkl:
              * VM/CodeBlock.h:
              * VM/ExceptionHelpers.cpp:
              * VM/SamplingTool.h:
              * bytecompiler/CodeGenerator.h:
              * jsc.pro:
              * jscore.bkl:
              * kjs: Removed.
              * kjs/NodeInfo.h: Removed.
              * kjs/Parser.cpp: Removed.
              * kjs/Parser.h: Removed.
              * kjs/ResultType.h: Removed.
              * kjs/SourceCode.h: Removed.
              * kjs/SourceProvider.h: Removed.
              * kjs/grammar.y: Removed.
              * kjs/keywords.table: Removed.
              * kjs/lexer.cpp: Removed.
              * kjs/lexer.h: Removed.
              * kjs/nodes.cpp: Removed.
              * kjs/nodes.h: Removed.
              * kjs/nodes2string.cpp: Removed.
              * parser: Added.
              * parser/Grammar.y: Copied from kjs/grammar.y.
              * parser/Keywords.table: Copied from kjs/keywords.table.
              * parser/Lexer.cpp: Copied from kjs/lexer.cpp.
              * parser/Lexer.h: Copied from kjs/lexer.h.
              * parser/NodeInfo.h: Copied from kjs/NodeInfo.h.
              * parser/Nodes.cpp: Copied from kjs/nodes.cpp.
              * parser/Nodes.h: Copied from kjs/nodes.h.
              * parser/Parser.cpp: Copied from kjs/Parser.cpp.
              * parser/Parser.h: Copied from kjs/Parser.h.
              * parser/ResultType.h: Copied from kjs/ResultType.h.
              * parser/SourceCode.h: Copied from kjs/SourceCode.h.
              * parser/SourceProvider.h: Copied from kjs/SourceProvider.h.
              * parser/nodes2string.cpp: Copied from kjs/nodes2string.cpp.
              * pcre/pcre.pri:
              * pcre/pcre_exec.cpp:
              * runtime/FunctionConstructor.cpp:
              * runtime/JSActivation.h:
              * runtime/JSFunction.h:
              * runtime/JSGlobalData.cpp:
              * runtime/JSGlobalObjectFunctions.cpp:
              * runtime/JSObject.cpp:
              (JSC::JSObject::toNumber):
              * runtime/RegExp.cpp:
      
              WebCore:
      
              * ForwardingHeaders/kjs: Removed.
              * ForwardingHeaders/kjs/Parser.h: Removed.
              * ForwardingHeaders/kjs/SavedBuiltins.h: Removed.
              * ForwardingHeaders/kjs/SourceCode.h: Removed.
              * ForwardingHeaders/kjs/SourceProvider.h: Removed.
              * ForwardingHeaders/parser: Added.
              * ForwardingHeaders/parser/Parser.h: Copied from ForwardingHeaders/kjs/Parser.h.
              * ForwardingHeaders/parser/SourceCode.h: Copied from ForwardingHeaders/kjs/SourceCode.h.
              * ForwardingHeaders/parser/SourceProvider.h: Copied from ForwardingHeaders/kjs/SourceProvider.h.
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * bindings/js/StringSourceProvider.h:
              * bindings/js/WorkerScriptController.cpp:
              * bridge/NP_jsobject.cpp:
              * bridge/jni/jni_jsobject.mm:
              * bridge/testbindings.pro:
              * inspector/JavaScriptDebugServer.cpp:
      
              WebKit/mac:
      
              * ForwardingHeaders/kjs: Removed.
              * ForwardingHeaders/kjs/SavedBuiltins.h: Removed.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38205 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3ff0e6a7