1. 08 Apr, 2011 14 commits
    • rniwa@webkit.org's avatar
      2011-04-08 Ryosuke Niwa <rniwa@webkit.org> · 8d2e1c50
      rniwa@webkit.org authored
              Reviewed by Tony Chang.
      
              dump-as-markup conversion: editing/pasteboard/5065605.html and display-block-on-spans.html
              https://bugs.webkit.org/show_bug.cgi?id=58074
      
              Converted 5065605.html and display-block-on-spans.html to dump-as-markup tests.
      
              * editing/pasteboard/5065605-expected.txt: Added.
              * editing/pasteboard/5065605.html:
              * editing/pasteboard/display-block-on-spans-expected.txt: Added.
              * editing/pasteboard/display-block-on-spans.html:
              * platform/chromium-linux/editing/pasteboard/5065605-expected.checksum: Removed.
              * platform/chromium-linux/editing/pasteboard/5065605-expected.png: Removed.
              * platform/chromium-linux/editing/pasteboard/display-block-on-spans-expected.checksum: Removed.
              * platform/chromium-linux/editing/pasteboard/display-block-on-spans-expected.png: Removed.
              * platform/chromium-win/editing/pasteboard/5065605-expected.checksum: Removed.
              * platform/chromium-win/editing/pasteboard/5065605-expected.png: Removed.
              * platform/chromium-win/editing/pasteboard/5065605-expected.txt: Removed.
              * platform/chromium-win/editing/pasteboard/display-block-on-spans-expected.checksum: Removed.
              * platform/chromium-win/editing/pasteboard/display-block-on-spans-expected.png: Removed.
              * platform/chromium-win/editing/pasteboard/display-block-on-spans-expected.txt: Removed.
              * platform/gtk/editing/pasteboard/5065605-expected.checksum: Removed.
              * platform/gtk/editing/pasteboard/5065605-expected.png: Removed.
              * platform/gtk/editing/pasteboard/5065605-expected.txt: Removed.
              * platform/gtk/editing/pasteboard/display-block-on-spans-expected.checksum: Removed.
              * platform/gtk/editing/pasteboard/display-block-on-spans-expected.png: Removed.
              * platform/gtk/editing/pasteboard/display-block-on-spans-expected.txt: Removed.
              * platform/mac-leopard/editing/pasteboard/5065605-expected.checksum: Removed.
              * platform/mac-leopard/editing/pasteboard/5065605-expected.png: Removed.
              * platform/mac-leopard/editing/pasteboard/display-block-on-spans-expected.checksum: Removed.
              * platform/mac-leopard/editing/pasteboard/display-block-on-spans-expected.png: Removed.
              * platform/mac/editing/pasteboard/5065605-expected.checksum: Removed.
              * platform/mac/editing/pasteboard/5065605-expected.png: Removed.
              * platform/mac/editing/pasteboard/5065605-expected.txt: Removed.
              * platform/mac/editing/pasteboard/display-block-on-spans-expected.checksum: Removed.
              * platform/mac/editing/pasteboard/display-block-on-spans-expected.png: Removed.
              * platform/mac/editing/pasteboard/display-block-on-spans-expected.txt: Removed.
              * platform/qt/editing/pasteboard/5065605-expected.txt: Removed.
              * platform/qt/editing/pasteboard/display-block-on-spans-expected.txt: Removed.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83268 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8d2e1c50
    • ossy@webkit.org's avatar
      [Qt] Add platform specific expected file after r83235. · 4072bea9
      ossy@webkit.org authored
      * platform/qt/http/tests/security/contentSecurityPolicy: Added.
      * platform/qt/http/tests/security/contentSecurityPolicy/xsl-allowed-expected.txt: Copied from LayoutTests/http/tests/security/contentSecurityPolicy/xsl-allowed-expected.txt.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83267 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4072bea9
    • tkent@chromium.org's avatar
      2011-04-08 Kent Tamura <tkent@chromium.org> · 1b64daa1
      tkent@chromium.org authored
              [Chromium] Update expectations for r82899 and r83253.
      
              * platform/chromium-mac-leopard/fast/borders/border-radius-huge-assert-expected.checksum: Removed.
              * platform/chromium-mac-leopard/fast/borders/border-radius-huge-assert-expected.png:
              * platform/chromium-mac-leopard/fast/box-shadow/border-radius-big-expected.png: Added.
              * platform/chromium-mac-leopard/fast/box-shadow/spread-multiple-inset-expected.png:
              * platform/chromium-mac/fast/borders/border-radius-circle-expected.png: Added.
              * platform/chromium-mac/fast/borders/border-radius-huge-assert-expected.png: Added.
              * platform/chromium-mac/fast/box-shadow/border-radius-big-expected.png: Added.
              * platform/chromium-mac/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.png: Added.
              * platform/chromium-mac/fast/box-shadow/spread-expected.png: Added.
              * platform/chromium-mac/fast/box-shadow/spread-multiple-inset-expected.png: Added.
              * platform/chromium-mac/fast/box-shadow/spread-multiple-normal-expected.png: Added.
              * platform/chromium-win/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.txt:
              * platform/chromium-win/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.txt:
              * platform/chromium-win/fast/dom/HTMLMeterElement/meter-boundary-values-expected.txt:
              * platform/chromium-win/fast/dom/HTMLMeterElement/meter-optimums-expected.txt:
              * platform/chromium-win/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.txt:
              * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83266 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1b64daa1
    • ossy@webkit.org's avatar
      Flaky Test: fast/events/tabindex-focus-blur-all.html · 33fb4ee5
      ossy@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=52115
      
      * platform/qt/Skipped: Add fast/events/tabindex-focus-blur-all.html.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83265 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      33fb4ee5
    • abarth@webkit.org's avatar
      2011-04-08 Adam Barth <abarth@webkit.org> · a1b677c8
      abarth@webkit.org authored
              Attempt to fix the Qt build.
      
              * css/CSSStyleApplyProperty.cpp:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83264 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a1b677c8
    • abarth@webkit.org's avatar
      2011-04-07 Adam Barth <abarth@webkit.org> · 1f7a5939
      abarth@webkit.org authored
              Reviewed by Eric Seidel.
      
              Refactor WebCore/GNUMakefile.am to separate list of files
              https://bugs.webkit.org/show_bug.cgi?id=58116
      
              This change is similar to the cooresponding to change to
              JavaScriptCore.  We hope to generate GNUmakefile.list.am automatically
              using GYP.
      
              * GNUmakefile.am:
              * GNUmakefile.list.am: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83263 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1f7a5939
    • rniwa@webkit.org's avatar
      2011-04-07 Ryosuke Niwa <rniwa@webkit.org> · 2823d79d
      rniwa@webkit.org authored
              Chromium rebaseline after r83246.
      
              * platform/chromium-win/editing/pasteboard/paste-text-011-expected.txt: Added.
              * platform/chromium/test_expectations.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83262 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2823d79d
    • ggaren@apple.com's avatar
      Not reviewed. · 17075df5
      ggaren@apple.com authored
      Rolled out some accidentally-committed changes in my last commit.
      
      * dom/EventTarget.cpp:
      (WebCore::EventTarget::addEventListener):
      (WebCore::EventTarget::removeEventListener):
      * dom/EventTarget.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83261 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      17075df5
    • commit-queue@webkit.org's avatar
      2011-04-07 Julien Chaffraix <jchaffraix@codeaurora.org> · 9d3fc5b1
      commit-queue@webkit.org authored
              Reviewed by Alexey Proskuryakov.
      
              EventSource should only accept UTF-8 charset
              https://bugs.webkit.org/show_bug.cgi?id=56942
      
              * ChangeLog-2011-02-16: Corrected previous commit message. Pointed out by Alexey.
      
              * http/tests/eventsource/eventsource-bad-mime-type-expected.txt: Updated with the new console message.
      
              * http/tests/eventsource/eventsource-content-type-charset-expected.txt:
              * http/tests/eventsource/eventsource-content-type-charset.html: Beefed up this test and merged
              the following test into it. The new tests check that we dispatch a console error if the charset is
              wrong.
      
              * http/tests/eventsource/eventsource-content-type-text-event-stream-foobar-expected.txt: Removed.
              * http/tests/eventsource/eventsource-content-type-text-event-stream-foobar.html: Removed.
      
              * http/tests/eventsource/resources/response-content-type-charset.php: Return the charset passed
              in the URL. Also added PHP's magic quotes handling as this would make the test fail on Mac.
      
              * http/tests/eventsource/resources/response-content-type-event-stream-foobar.php: Removed.
      2011-04-07  Julien Chaffraix  <jchaffraix@codeaurora.org>
      
              Reviewed by Alexey Proskuryakov.
      
              EventSource should only accept UTF-8 charset
              https://bugs.webkit.org/show_bug.cgi?id=56942
      
              Following the discussion on bug 45372, this change implements the recommended
              way of handling "charset". We only accept UTF-8 but no other encoding. This matches
              the encoding of the EventSource and also may fix TomCat that automatically send this
              charset.
      
              * page/EventSource.cpp:
              (WebCore::EventSource::didReceiveResponse): We now check the charset attribute and if it is
              not UTF-8, abort the connection and log the error to the console. Also we log if the MIME type
              is wrong to the console to help debugging (only in the case of an HTTP 200 response though).
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83260 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9d3fc5b1
    • ggaren@apple.com's avatar
      2011-04-07 Geoffrey Garen <ggaren@apple.com> · 264f9e28
      ggaren@apple.com authored
              Reviewed by Maciej Stachowiak.
      
              Some Handle<T> cleanup
              https://bugs.webkit.org/show_bug.cgi?id=58109
      
              * bytecode/SamplingTool.h: Sorted alphabetically because that's the
              WebKit style. Added a Global.h #include that was previously missing
              but harmless.
      
              * collector/handles/Global.h:
              (JSC::Global::Global): Added a null constructor. No need for a special
              tag, and the tag is incompatible with some data structures.
              
              (JSC::Global::isHashTableDeletedValue):
              (JSC::Global::~Global):
              (JSC::Global::set):
              (JSC::Global::operator=):
              (JSC::Global::clear):
              (JSC::Global::hashTableDeletedValue): Reordered constructors to be near
              each other.
      
              (JSC::Global::setWithWriteBarrier): Renamed internalSet to
              setWithWriteBarrier for clarity, and funneled more code into using set
              and setWithWriteBarrier to reduce duplication.
      
              * collector/handles/Handle.h:
              (JSC::HandleBase::operator!):
              (JSC::HandleBase::HandleBase): Removed isEmpty(), since we already have
              boolean and ! operators.
      
              (JSC::HandleBase::slot):
              (JSC::HandleBase::setSlot):
              (JSC::Handle::Handle): Added general support for null Handles. This was
              previously outlawed by ASSERTs, but our code has grown to support and
              rely on null Handles.
              
              * collector/handles/HandleHeap.cpp:
              (JSC::HandleHeap::markWeakHandles):
              (JSC::HandleHeap::finalizeWeakHandles):
              (JSC::HandleHeap::isValidWeakNode): Migrated from isValidWeakHandle,
              and beefed this up a bit.
      
              * collector/handles/HandleHeap.h:
              (JSC::HandleHeap::globalData): Added accessor, used by some new set functions.
      
              * collector/handles/Local.h: Moved hash traits to the bottom of the file,
              since this file is about the Local class, not the traits.
      
              (JSC::::Local): Updated for removal of invalidate().
      
              (JSC::::operator): Deployed "using" to avoid a lot of this->
              template funny business.
      
              (JSC::::setWithSlotCheck): Renamed from internalSet, more specific now.
      
              * interpreter/RegisterFile.h:
              (JSC::RegisterFile::RegisterFile): Updated to use null constructor.
      
              * jit/JITStubs.cpp:
              (JSC::JITThunks::hostFunctionStub):
      
              * runtime/JSPropertyNameIterator.h:
              (JSC::Structure::setEnumerationCache):
              * runtime/Structure.h: Removed clearEnumerationCache
              because it was an unused holdover from when the enumeration cache was
              not a handle.
      
              * runtime/WeakGCMap.h:
              (JSC::WeakGCMap::set): Finish initializing our handle before putting it
              in the table. This seemed more logical, and at one point was required
              to avoid triggering an ASSERT.
      
              * runtime/WeakGCPtr.h: Inherit from Handle instead of rolling our own
              handle-like behavior, to avoid duplication.
      
              (JSC::WeakGCPtr::WeakGCPtr):
              (JSC::WeakGCPtr::~WeakGCPtr):
              (JSC::WeakGCPtr::get):
              (JSC::WeakGCPtr::clear):
              (JSC::WeakGCPtr::set):
              (JSC::WeakGCPtr::setWithWriteBarrier): Removed duplicate code and
              standardized on Handle idioms.
      2011-04-07  Geoffrey Garen  <ggaren@apple.com>
      
              Reviewed by Maciej Stachowiak.
      
              Some Handle<T> cleanup
              https://bugs.webkit.org/show_bug.cgi?id=58109
      
              * JSRun.h:
              * JSValueWrapper.h: #include a file that was missing before, but was
              harmlessly so until now.
      2011-04-07  Geoffrey Garen  <ggaren@apple.com>
      
              Reviewed by Maciej Stachowiak.
      
              Some Handle<T> cleanup
              https://bugs.webkit.org/show_bug.cgi?id=58109
      
              * bindings/js/ScriptValue.h:
              (WebCore::ScriptValue::ScriptValue): Updated for new null constructor.
              (WebCore::ScriptValue::hasNoValue): Updated for removal of isEmpty().
      2011-04-07  Geoffrey Garen  <ggaren@apple.com>
      
              Some Handle<T> cleanup
              https://bugs.webkit.org/show_bug.cgi?id=58109
      
              * WebProcess/Plugins/Netscape/NPJSObject.cpp:
              (WebKit::NPJSObject::NPJSObject): Updated for new null constructor.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83259 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      264f9e28
    • kinuko@chromium.org's avatar
      2011-04-07 Kinuko Yasuda <kinuko@chromium.org> · 8f74be2d
      kinuko@chromium.org authored
              Reviewed by Darin Fisher.
      
              [Chromium] Add WebKit API to query and request unified offline-storage quota
              https://bugs.webkit.org/show_bug.cgi?id=57849
              Just adding the API, this does not do anything yet.
      
              The API is based on the public discussion for unified quota API:
              http://lists.w3.org/Archives/Public/public-webapps/2011JanMar/0346.html
              (The detail is not yet fully specified and might be subject to change.)
      
              * public/WebFrameClient.h:
              (WebKit::WebFrameClient::queryStorageUsageAndQuota): Added.
              (WebKit::WebFrameClient::requestStorageQuota): Added.
              * public/WebStorageQuotaCallbacks.h: Added.
              (WebKit::WebStorageQuotaCallbacks::~WebStorageQuotaCallbacks):
              * public/WebStorageQuotaType.h: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83258 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8f74be2d
    • tkent@chromium.org's avatar
      2011-04-07 Kent Tamura <tkent@chromium.org> · 67d4cd87
      tkent@chromium.org authored
              [Chromium] Update expectations for xsl-blocked.php and pate-text-011.html.
      
              * platform/chromium/http/tests/security/contentSecurityPolicy/xsl-blocked-expected.png: Added.
              * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83257 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      67d4cd87
    • tkent@chromium.org's avatar
      2011-04-07 Dominic Cooney <dominicc@google.com> · 553b1729
      tkent@chromium.org authored
              Reviewed by Dimitri Glazkov.
      
              Let shadow DOM have a list of nodes at the top level of a shadow.
              https://bugs.webkit.org/show_bug.cgi?id=57813
      
              * fast/dom/HTMLKeygenElement/keygen-expected.txt: shadow DOM changed
              * fast/dom/HTMLKeygenElement/keygen.html: added assertion on shadow
      2011-04-07  Dominic Cooney  <dominicc@google.com>
      
              Reviewed by Dimitri Glazkov.
      
              Let shadow DOM have a list of nodes at the top level of a shadow.
              https://bugs.webkit.org/show_bug.cgi?id=57813
      
              Adds ShadowRoot, a list of nodes, to be a parent for top-level
              shadow children. Forwards rendering through the root and into the
              host's renderer.
      
              Covered by existing tests of elements that use this style of shadow.
      
              * Android.mk: add ShadowRoot.h/cpp
              * CMakeLists.txt:
              * GNUmakefile.am:
              * WebCore.exp.in:
              * WebCore.gypi:
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * css/CSSStyleSelector.cpp:
              (WebCore::CSSStyleSelector::initForStyleResolve): proxy style to host
              * dom/ContainerNode.cpp: parent nodes that are shadow roots are alive
              (WebCore::ContainerNode::insertBefore):
              (WebCore::ContainerNode::replaceChild):
              (WebCore::ContainerNode::removeChild):
              (WebCore::ContainerNode::appendChild):
              * dom/DocumentFragment.cpp:
              (WebCore::DocumentFragment::DocumentFragment):
              * dom/DocumentFragment.h:
              * dom/Element.cpp:
              (WebCore::Element::recalcStyle): look through ShadowRoots for host's style
              (WebCore::Element::shadowRoot): should be const
              (WebCore::Element::ensureShadowRoot): simpler than setShadowRoot
              * dom/Element.h:
              * dom/ElementRareData.h:
              * dom/Node.cpp:
              (WebCore::Node::parentNodeForRenderingAndStyle): indirection so
                ShadowRoot can forward to the host's renderer
              (WebCore::Node::createRendererAndStyle):
              (WebCore::Node::createRendererIfNeeded):
              * dom/Node.h:
              (WebCore::Node::isShadowBoundary): temporary, to differentiate
                old- and new-style, until all roots are ShadowRoot instances
              * dom/ShadowRoot.cpp: Added.
              (WebCore::ShadowRoot::ShadowRoot):
              (WebCore::ShadowRoot::recalcStyle): forward recalc to children
              * dom/ShadowRoot.h: Added.
              (WebCore::ShadowRoot::isShadowBoundary):
              (WebCore::ShadowRoot::create):
              * html/HTMLKeygenElement.cpp: use ensureShadowRoot
              (WebCore::HTMLKeygenElement::HTMLKeygenElement):
              (WebCore::HTMLKeygenElement::parseMappedAttribute):
              (WebCore::HTMLKeygenElement::appendFormData):
              (WebCore::HTMLKeygenElement::reset):
              (WebCore::HTMLKeygenElement::shadowSelect):
              * html/HTMLKeygenElement.h:
              * html/HTMLMeterElement.cpp: use ensureShadowRoot
              (WebCore::HTMLMeterElement::createShadowSubtree):
              * html/HTMLProgressElement.cpp: use ensureShadowRoot
              (WebCore::HTMLProgressElement::createShadowSubtree):
              * html/InputType.cpp: use ensureShadowRoot
              (WebCore::InputType::destroyShadowSubtree):
              * html/RangeInputType.cpp: use ensureShadowRoot
              (WebCore::RangeInputType::handleMouseDownEvent):
              (WebCore::RangeInputType::createShadowSubtree):
              (WebCore::RangeInputType::valueChanged):
              (WebCore::RangeInputType::shadowSliderThumb):
              * html/RangeInputType.h:
              * html/ValidationMessage.cpp: use ensureShadowRoot
              (WebCore::ValidationMessage::buildBubbleTree):
              (WebCore::ValidationMessage::deleteBubbleTree):
              * html/shadow/SliderThumbElement.cpp:
              (WebCore::SliderThumbElement::setPositionFromPoint):
              (WebCore::SliderThumbElement::hostInput):
              * html/shadow/SliderThumbElement.h:
              * rendering/MediaControlElements.cpp: use ensureShadowRoot
              (WebCore::MediaControlInputElement::attach):
              (WebCore::MediaControlInputElement::updateStyle):
              * rendering/RenderSlider.cpp: use ensureShadowRoot
              (WebCore::RenderSlider::thumbRect):
              (WebCore::RenderSlider::layout):
              (WebCore::RenderSlider::shadowSliderThumb):
              (WebCore::RenderSlider::inDragMode):
              * rendering/RenderSlider.h:
      2011-04-07  Dominic Cooney  <dominicc@google.com>
      
              Reviewed by Dimitri Glazkov.
      
              Let shadow DOM have a list of nodes at the top level of a shadow.
              https://bugs.webkit.org/show_bug.cgi?id=57813
      
              * src/WebElement.cpp:
              (WebKit::WebElement::shadowRoot): shadow roots are ContainerNodes now
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83256 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      553b1729
    • mjs@apple.com's avatar
      2011-04-07 Maciej Stachowiak <mjs@apple.com> · 2fcfc485
      mjs@apple.com authored
              Reviewed by Simon Fraser.
      
              REGRESSION (r80871): Crash when visiting http://broadband.biglobe.ne.jp/
              https://bugs.webkit.org/show_bug.cgi?id=56297
              <rdar://problem/9131597>
      
              Test: fast/css-generated-content/table-row-after-no-crash.html
      
              * rendering/RenderTableRow.cpp:
              (WebCore::RenderTableRow::styleDidChange): Factor out generation of before/after
              content, and only do it if the row already has a parent. For construction of
              anonymous cells to work correctly, the row needs to already have a parent, so
              in that case wait a bit.
              (WebCore::RenderTableRow::updateBeforeAndAfterContent): Factored out to here.
              * rendering/RenderTableRow.h:
              * rendering/RenderTableSection.cpp:
              (WebCore::RenderTableSection::addChild): When adding a row, update its
              before/after content, in case it had any.
      2011-04-07  Maciej Stachowiak  <mjs@apple.com>
      
              Reviewed by Simon Fraser.
      
              REGRESSION (r80871): Crash when visiting http://broadband.biglobe.ne.jp/
              https://bugs.webkit.org/show_bug.cgi?id=56297
              <rdar://problem/9131597>
      
              * fast/css-generated-content/table-row-after-no-crash-expected.txt: Added.
              * fast/css-generated-content/table-row-after-no-crash.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83255 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2fcfc485
  2. 07 Apr, 2011 26 commits
    • bdakin@apple.com's avatar
      Probable fix for <rdar://problem/9251443> Crashing on exception: - · 6dfbb417
      bdakin@apple.com authored
      [ScrollAnimationHelperDelegate _pixelAlignProposedScrollPosition:]: unrecognized 
      selector sent to instance ADDRESS.
      
      Reviewed by Simon Fraser.
      
             Need to implement new delegate method.
      * platform/mac/ScrollAnimatorMac.mm:
      (-[ScrollAnimationHelperDelegate _pixelAlignProposedScrollPosition:]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83254 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6dfbb417
    • commit-queue@webkit.org's avatar
      2011-04-07 Ian Henderson <ianh@apple.com> · c0295d8f
      commit-queue@webkit.org authored
              Reviewed by Simon Fraser.
      
              Optimize filling rounded rects that are actually ellipses
              https://bugs.webkit.org/show_bug.cgi?id=58098
      
              In CG, drawing an ellipse directly is faster than constructing and
              filling a rounded rect path.  Detect when the given rounded rect is
              actually an ellipse and draw it directly in this case.
      
              * platform/graphics/cg/GraphicsContextCG.cpp:
              (WebCore::GraphicsContext::fillRoundedRect):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83253 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c0295d8f
    • commit-queue@webkit.org's avatar
      2011-04-07 Magnus Danielsson <public@fuzzac.com> · 10e834e1
      commit-queue@webkit.org authored
              Reviewed by Darin Fisher.
      
              [chromium] WebPageSerializerImpl doesn't serialize sub-frames correctly
              https://bugs.webkit.org/show_bug.cgi?id=53897
      
              When serializing a web page using 'save page as', sub-frames and resources gets
              saved in a sub-directory. However, frame elements didn't get updated to reference
              these saved sub-frames, but were still referencing the original url. So when opening
              a saved web page, any sub-frames would get pulled in from the original url rather than
              what was saved.
      
              In addition to this, sub-frames in the sub-directory erroneously had the name of the
              sub-directory prepended to the path of resources located in the same sub-directory.
      
              * src/WebPageSerializerImpl.cpp:
              (WebKit::WebPageSerializerImpl::openTagToStrne: Fixed resource paths in sub-frames.
              Also made sure sub-frames are referenced correctly from parent frame.
              (WebKit::WebPageSerializerImpl::endTagToString): Removed constness from argument.
              (WebKit::WebPageSerializerImpl::buildContentForNode): Ditto.
              * src/WebPageSerializerImpl.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83252 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      10e834e1
    • commit-queue@webkit.org's avatar
      2011-04-07 Ned Holbrook <nholbrook@apple.com> · 4c749b2e
      commit-queue@webkit.org authored
              Reviewed by Dan Bernstein.
      
              CTLine objects should outlive their CTRuns
              https://bugs.webkit.org/show_bug.cgi?id=58063
      
              * platform/graphics/mac/ComplexTextController.h: Add m_coreTextLines, to be destroyed after m_complexTextRuns.
              * platform/graphics/mac/ComplexTextControllerCoreText.cpp:
              (WebCore::ComplexTextController::ComplexTextRun::ComplexTextRun): Moot m_coreTextRun.
              (WebCore::ComplexTextController::collectComplexTextRunsForCharactersCoreText): Append line to m_coreTextLines.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83251 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4c749b2e
    • dpranke@chromium.org's avatar
      2011-04-07 Dirk Pranke <dpranke@chromium.org> · 1a7210bc
      dpranke@chromium.org authored
              Reviewed by Mihai Parparita.
      
              Change reference port for Mac GPU baselines from
              Leopard to SnowLeopard, XP to Win7, and Linux-x86
              to Linux x86-64.
      
              https://bugs.webkit.org/show_bug.cgi?id=58099
      
              * Scripts/webkitpy/layout_tests/port/chromium.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83250 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1a7210bc
    • commit-queue@webkit.org's avatar
      2011-04-07 Nat Duca <nduca@chromium.org> · 118a5518
      commit-queue@webkit.org authored
              Reviewed by David Levin.
      
              [chromium] Compositor thread infrastructure
              https://bugs.webkit.org/show_bug.cgi?id=56131
      
              Introduce chrome compositor thread and related
              infrastructure.
      
              * WebCore.gypi:
              * platform/graphics/chromium/cc/CCMainThread.cpp: Added.
              (WebCore::CCMainThread::performTask):
              (WebCore::CCMainThread::postTask):
              * platform/graphics/chromium/cc/CCMainThread.h: Added.
              (WebCore::CCMainThread::Task::~Task):
              (WebCore::CCMainThread::Task::instance):
              (WebCore::CCMainThread::Task::Task):
              * platform/graphics/chromium/cc/CCMainThreadTask.h: Added.
              (WebCore::MainThreadTask0::create):
              (WebCore::MainThreadTask0::MainThreadTask0):
              (WebCore::MainThreadTask0::performTask):
              (WebCore::MainThreadTask1::create):
              (WebCore::MainThreadTask1::MainThreadTask1):
              (WebCore::MainThreadTask1::performTask):
              (WebCore::MainThreadTask2::create):
              (WebCore::MainThreadTask2::MainThreadTask2):
              (WebCore::MainThreadTask2::performTask):
              (WebCore::MainThreadTask3::create):
              (WebCore::MainThreadTask3::MainThreadTask3):
              (WebCore::MainThreadTask3::performTask):
              (WebCore::createMainThreadTask):
              * platform/graphics/chromium/cc/CCThread.cpp: Added.
              (WebCore::CCThread::create):
              (WebCore::CCThread::CCThread):
              (WebCore::CCThread::~CCThread):
              (WebCore::CCThread::postTask):
              (WebCore::CCThread::compositorThreadStart):
              (WebCore::CCThread::runLoop):
              * platform/graphics/chromium/cc/CCThread.h: Added.
              (WebCore::CCThread::Task::~Task):
              (WebCore::CCThread::Task::instance):
              (WebCore::CCThread::Task::Task):
              (WebCore::CCThread::threadID):
              (WebCore::CCCompletionEvent::CCCompletionEvent):
              (WebCore::CCCompletionEvent::~CCCompletionEvent):
              (WebCore::CCCompletionEvent::wait):
              (WebCore::CCCompletionEvent::signal):
              * platform/graphics/chromium/cc/CCThreadTask.h: Added.
              (WebCore::CCThreadTask0::create):
              (WebCore::CCThreadTask0::CCThreadTask0):
              (WebCore::CCThreadTask0::performTask):
              (WebCore::CCThreadTask1::create):
              (WebCore::CCThreadTask1::CCThreadTask1):
              (WebCore::CCThreadTask1::performTask):
              (WebCore::CCThreadTask2::create):
              (WebCore::CCThreadTask2::CCThreadTask2):
              (WebCore::CCThreadTask2::performTask):
              (WebCore::CCThreadTask3::create):
              (WebCore::CCThreadTask3::CCThreadTask3):
              (WebCore::CCThreadTask3::performTask):
              (WebCore::createCCThreadTask):
      2011-04-07  Nat Duca  <nduca@chromium.org>
      
              Reviewed by David Levin.
      
              [chromium] Compositor thread infrastructure
              https://bugs.webkit.org/show_bug.cgi?id=56131
      
              Tests for chrome compositor thread and related infrastructure.
      
              * WebKit.gyp:
              * WebKit.gypi:
              * tests/CCThreadTaskTest.cpp: Added.
              (WebCore::TEST):
              * tests/CCThreadTest.cpp: Added.
              (WebCore::TEST):
              (WebCore::PingPongUsingCondition::ping):
              (WebCore::PingPongTestUsingTasks::ping):
              (WebCore::PingPongTestUsingTasks::pong):
              * tests/RunAllTests.cpp:
              (main):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83249 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      118a5518
    • abarth@webkit.org's avatar
      2011-04-07 Adam Barth <abarth@webkit.org> · a388b25d
      abarth@webkit.org authored
              Reviewed by Martin Robinson.
      
              Refactor Gtk build system to separate list of files
              https://bugs.webkit.org/show_bug.cgi?id=58090
      
              This is the first step towards generating part of the GTK build system
              using GYP.  In the first iteration, our plan is to just generate the
              list of files.  This patch is the first step, which is to separate out
              the part of JavaScriptCore build system that we intend to generate from
              the rest of the build system.
      
              * GNUmakefile.am:
              * GNUmakefile.list.am: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83248 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a388b25d
    • rniwa@webkit.org's avatar
      2011-04-07 Ryosuke Niwa <rniwa@webkit.org> · 5614540c
      rniwa@webkit.org authored
              Reviewed by Darin Adler.
      
              REGRESSION (r46914, r48764): When typing in Mail, line wrapping frequently occurs in the middle of words
              https://bugs.webkit.org/show_bug.cgi?id=57872
      
              Added tests to ensure WebKit inserts a paragraph separator properly around tab span.
      
              * editing/inserting/insert-div-021-expected.txt: No longer duplicates span[id="test"] incorrectly.
              * editing/inserting/insert-paragraph-after-tab-span-and-text-expected.txt: Added.
              * editing/inserting/insert-paragraph-after-tab-span-and-text.html: Added.
              * editing/inserting/insert-paragraph-separator-tab-span-expected.txt: Added.
              * editing/inserting/insert-paragraph-separator-tab-span.html: Added.
              * editing/inserting/insert-paragraph-at-end-of-line-expected.txt: No longer duplicates a[id="anchor"] incorrectly.
      2011-04-07  Ryosuke Niwa  <rniwa@webkit.org>
      
              Reviewed by Eric Seidel.
      
              REGRESSION (r46914, r48764): When typing in Mail, line wrapping frequently occurs in the middle of words
              https://bugs.webkit.org/show_bug.cgi?id=57872
      
              r46914 initially introduced a regression by replacing calls to styleAtPosition by editingStyleAtPosition
              because editingStyleAtPosition did not avoid tab span to obtain the computed style unlike styleAtPosition.
      
              r46914 also introduced a regression by cloning hierarchy under new block at the insertion position without
              avoiding the tab span.
      
              Fixed the both regressions by avoiding tab spans when computing the editing style and when cloning hierarchy.
              Also reverted r46914 for the general code path because re-creating node hierarchy duplicates nodes when
              we're moving nodes after the paragraph separator. Instead, we now split the tree up until the start block
              before moving the nodes.
      
              Tests: editing/inserting/insert-paragraph-after-tab-span-and-text.html
                     editing/inserting/insert-paragraph-separator-tab-span.html
      
              * editing/DeleteSelectionCommand.cpp:
              (WebCore::DeleteSelectionCommand::saveTypingStyleState): Since EditingStyle's constructor avoids a tab span,
              no longer calls positionBeforeTabSpan on the position passed to EditingStyle's constructor.
              * editing/EditingStyle.cpp:
              (WebCore::EditingStyle::init): Always avoid a tab span when computing the editing style.
              * editing/InsertParagraphSeparatorCommand.cpp:
              (WebCore::InsertParagraphSeparatorCommand::doApply): Avoid cloning tab spans and inserting a paragraph
              separator into a paragraph separator.
              * editing/htmlediting.cpp:
              (WebCore::positionOutsideTabSpan): Renamed from positionBeforeTabSpan. Also returns the position in the parent
              node after the tab span if the position was at the end of the tab span.
              * editing/htmlediting.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83247 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5614540c
    • rniwa@webkit.org's avatar
      2011-04-07 Ryosuke Niwa <rniwa@webkit.org> · 6683441a
      rniwa@webkit.org authored
              Reviewed by Eric Seidel.
      
              dump-as-markup conversion: editing/pasteboard/paste-text-001.html and paste-text-011.html
              https://bugs.webkit.org/show_bug.cgi?id=58078
      
              Converted the tests.
      
              * editing/pasteboard/paste-text-001-expected.txt: Added.
              * editing/pasteboard/paste-text-001.html:
              * editing/pasteboard/paste-text-011-expected.txt: Added.
              * editing/pasteboard/paste-text-011.html:
              * platform/chromium-linux/editing/pasteboard/paste-text-001-expected.checksum: Removed.
              * platform/chromium-linux/editing/pasteboard/paste-text-001-expected.png: Removed.
              * platform/chromium-linux/editing/pasteboard/paste-text-011-expected.checksum: Removed.
              * platform/chromium-linux/editing/pasteboard/paste-text-011-expected.png: Removed.
              * platform/chromium-win/editing/pasteboard/paste-text-001-expected.checksum: Removed.
              * platform/chromium-win/editing/pasteboard/paste-text-001-expected.png: Removed.
              * platform/chromium-win/editing/pasteboard/paste-text-001-expected.txt: Removed.
              * platform/chromium-win/editing/pasteboard/paste-text-011-expected.checksum: Removed.
              * platform/chromium-win/editing/pasteboard/paste-text-011-expected.png: Removed.
              * platform/chromium-win/editing/pasteboard/paste-text-011-expected.txt: Removed.
              * platform/gtk/editing/pasteboard/paste-text-001-expected.txt: Removed.
              * platform/gtk/editing/pasteboard/paste-text-011-expected.checksum: Removed.
              * platform/gtk/editing/pasteboard/paste-text-011-expected.png: Removed.
              * platform/gtk/editing/pasteboard/paste-text-011-expected.txt: Removed.
              * platform/mac-leopard/editing/pasteboard/paste-text-011-expected.checksum: Removed.
              * platform/mac-leopard/editing/pasteboard/paste-text-011-expected.png: Removed.
              * platform/mac/editing/pasteboard/paste-text-001-expected.checksum: Removed.
              * platform/mac/editing/pasteboard/paste-text-001-expected.png: Removed.
              * platform/mac/editing/pasteboard/paste-text-001-expected.txt: Removed.
              * platform/mac/editing/pasteboard/paste-text-011-expected.checksum: Removed.
              * platform/mac/editing/pasteboard/paste-text-011-expected.png: Removed.
              * platform/mac/editing/pasteboard/paste-text-011-expected.txt: Removed.
              * platform/qt/editing/pasteboard/paste-text-011-expected.checksum: Removed.
              * platform/qt/editing/pasteboard/paste-text-011-expected.png: Removed.
              * platform/qt/editing/pasteboard/paste-text-011-expected.txt: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83246 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6683441a
    • commit-queue@webkit.org's avatar
      2011-04-07 Jia Pu <jpu@apple.com> · 6aedb680
      commit-queue@webkit.org authored
              Reviewed by Darin Adler.
      
              [Mac] Editor::setComposition() should not trigger correction panel timer.
              https://bugs.webkit.org/show_bug.cgi?id=58049
               <rdar://problem/9226305>
      
              On Mac OS X that supports autocorrection panel, typing unconfirmed composition (i.e. unconfirmed Japanese or Chinese input)
              should not start autocorrection timer. We added a member variable, m_shouldPreventSpellChecking, to TypingCommand.
              When this value is true, markMisspellingsAfterTyping() will not be called in TypingCommand::typingAddedToOpenCommand().
              m_shouldPreventSpellChecking is set to true in the TypingCommand objects created by Editor::setComposition().
      
              No new tests. No deterministically reproducible test case. Patch is based on static code analysis. Testing this also requires firing
              autocorrection panel timer, which can not be easily done in automated fashion.
      
              * editing/Editor.cpp:
              (WebCore::Editor::deleteWithDirection):
              (WebCore::Editor::insertTextWithoutSendingTextEvent):
              (WebCore::Editor::confirmComposition):
              (WebCore::Editor::setComposition):
              * editing/EditorCommand.cpp:
              (WebCore::executeDelete):
              * editing/TypingCommand.cpp:
              (WebCore::TypingCommand::TypingCommand):
              (WebCore::TypingCommand::deleteSelection):
              (WebCore::TypingCommand::deleteKeyPressed):
              (WebCore::TypingCommand::forwardDeleteKeyPressed):
              (WebCore::TypingCommand::insertText):
              (WebCore::TypingCommand::insertLineBreak):
              (WebCore::TypingCommand::insertParagraphSeparator):
              (WebCore::TypingCommand::typingAddedToOpenCommand):
              * editing/TypingCommand.h:
              (WebCore::TypingCommand::create):
              (WebCore::TypingCommand::setShouldPreventSpellChecking):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83245 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6aedb680
    • tkent@chromium.org's avatar
      2011-04-07 Kent Tamura <tkent@chromium.org> · 399c854f
      tkent@chromium.org authored
              [Chromium] Update expectations for r83216 and r83235.
      
              * platform/chromium-linux/svg/custom/foreign-object-skew-expected.png: Added.
              * platform/chromium-linux/svg/custom/foreign-object-skew-expected.txt: Copied from LayoutTests/platform/chromium-win/svg/custom/foreign-object-skew-expected.txt.
              * platform/chromium-mac-leopard/svg/custom/foreign-object-skew-expected.checksum: Removed.
              * platform/chromium-mac-leopard/svg/custom/foreign-object-skew-expected.png:
              * platform/chromium-mac/svg/custom/foreign-object-skew-expected.checksum: Removed.
              * platform/chromium-mac/svg/custom/foreign-object-skew-expected.png:
              * platform/chromium-mac/svg/zoom/text/zoom-foreignObject-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/custom/foreign-object-skew-expected.png.
              * platform/chromium-win-vista/svg/custom/foreign-object-skew-expected.checksum: Removed.
              * platform/chromium-win-vista/svg/custom/foreign-object-skew-expected.png:
              * platform/chromium-win/svg/custom/foreign-object-skew-expected.checksum: Removed.
              * platform/chromium-win/svg/custom/foreign-object-skew-expected.png:
              * platform/chromium-win/svg/custom/foreign-object-skew-expected.txt:
              * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83244 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      399c854f
    • jchaffraix@webkit.org's avatar
      2011-04-07 Julien Chaffraix <jchaffraix@webkit.org> · 445179b5
      jchaffraix@webkit.org authored
              Reviewed by Eric Seidel.
      
              Test for Bug 51465 - chrome.dll!WebCore::RenderLayer::currentTransform
              ReadAV@NULL (8968fc97874fa23b6799ff8f09c142e4)
      
              Forgot to add them to the original patch.
      
              * fast/css/webkit-empty-transform-preserve3d-crash-expected.txt: Added.
              * fast/css/webkit-empty-transform-preserve3d-crash.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83243 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      445179b5
    • commit-queue@webkit.org's avatar
      2011-04-07 John Bauman <jbauman@chromium.org> · f12d168a
      commit-queue@webkit.org authored
              Reviewed by Kenneth Russell.
      
              clearIfComposited call is really slow
              https://bugs.webkit.org/show_bug.cgi?id=57999
      
              Move getContextAttributes call after the if, so it isn't called nearly as often.
      
              No new tests.
      
              * html/canvas/WebGLRenderingContext.cpp:
              (WebCore::WebGLRenderingContext::clearIfComposited):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83242 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f12d168a
    • commit-queue@webkit.org's avatar
      2011-04-07 Luke Macpherson <macpherson@chromium.org> · 16204d14
      commit-queue@webkit.org authored
              Reviewed by Dimitri Glazkov.
      
              Implement Backgroun and Mask properties in CSSStyleApplyProperty
              https://bugs.webkit.org/show_bug.cgi?id=57922
      
              No tests added as no behavioral changes.
      
              * css/CSSStyleApplyProperty.cpp:
              Added ApplyPropertyFillLayer test to handle Background and Mask CSS Properties.
              (WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
              Added constructor calls to set up:
                CSSPropertyBackgroundAttachment
                CSSPropertyBackgroundClip
                CSSPropertyWebkitBackgroundClip
                CSSPropertyWebkitBackgroundComposite
                CSSPropertyBackgroundOrigin
                CSSPropertyWebkitBackgroundOrigin
                CSSPropertyBackgroundSize
                CSSPropertyWebkitBackgroundSize
                CSSPropertyWebkitMaskAttachment
                CSSPropertyWebkitMaskClip
                CSSPropertyWebkitMaskComposite
                CSSPropertyWebkitMaskOrigin
                CSSPropertyWebkitMaskSize
              * css/CSSStyleApplyProperty.h:
              (WebCore::CSSStyleApplyProperty::setPropertyValue):
              Add function to specify an equivalent property value in the lookup table.
              * css/CSSStyleSelector.cpp:
              (WebCore::CSSStyleSelector::applyProperty):
              Remove sections now implemented by CSSStyleApplyProperty.
              * css/CSSStyleSelector.h:
              Make CSSStyleApplyProperty a friend class so that the mapFill* functions are accessible.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83241 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      16204d14
    • eric@webkit.org's avatar
      2011-04-04 Eric Seidel <eric@webkit.org> · 5bee2940
      eric@webkit.org authored
              Reviewed by Ryosuke Niwa.
      
              Split run storage out from BidiResolver into a new BidiRunList class
              https://bugs.webkit.org/show_bug.cgi?id=57764
      
              Part of what makes BidiResolver and InlineIterator so difficult to understand
              (and bug 50912 so difficult to fix) is that BidiResolver is both a state machine
              for the Unicode Bidi Algorithm (UBA) as well as storage for the resulting
              BidiRuns from the algorithm.  This patch breaks the storage aspect off
              into its own class BidiRunList.
      
              This patch is only a start.  It does not actually fix the problematic ownership
              relationship, but it does make it possible to fix such in a second patch.
      
              The run pointers and addRun/prependRun, etc. were already a tightly coupled
              logical subset of the BidiResolver class, so moving them into their own class
              was both obvious and easy.  The only piece of logic I had to move was that
              deleteRuns() had a side-effect of setting the m_emptyRun bit on the resolver.
      
              I believe this deleteRuns side-effect was only ever used for one place
              (right after findNextLineBreak) and that it's only needed because
              findNextLineBreak can sometimes create bidi runs.  Run creation appears to be
              an unintentional side-effect of how InlineIterator calls through to BidiResolver
              as part of bidiNext and not a desired effect of the code.  I have added the call
              to markCurrentRunEmpty to both places deleteRuns was called (where the resolver
              could get re-used) as a safety precaution.  We could replace both with ASSERTs
              in a later patch.
      
              I suspect there may be a small performance win from further refactoring so that
              findNextLineBreak does not need to create BidiRuns.
      
              As I commented in the code, callers should own their own BidiRunList which they
              pass to BidiResolver::createBidiRunsForLine.  I attempted to implement that in
              an earlier version of this patch, but it was too complicated with the current
              twisted dependencies between InlineIterator/bidiNext and InlineBidiResolver.
              raise/lowerExplicitEmbeddingLevel are called unconditionally
              from commitExplicitEmbedding (which is called by bidiNext) and expect to have
              access to a runs list even in cases where we don't want any runs (findNextLineBreak).
      
              I also cleaned up some of the callers to pass around BidiRunList objects instead
              of InlineBidiResolvers now that they're separate objects.
      
              * GNUmakefile.am:
              * WebCore.gypi:
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * platform/graphics/GraphicsContext.cpp:
              (WebCore::GraphicsContext::drawBidiText):
              * platform/text/BidiResolver.h:
              (WebCore::BidiResolver::BidiResolver):
              (WebCore::BidiResolver::runs):
              (WebCore::BidiResolver::markCurrentRunEmpty):
              (WebCore::::appendRun):
              (WebCore::::lowerExplicitEmbeddingLevel):
              (WebCore::::raiseExplicitEmbeddingLevel):
              (WebCore::::reorderRunsFromLevels):
              (WebCore::::createBidiRunsForLine):
              * rendering/InlineIterator.h:
              (WebCore::InlineBidiResolver::appendRun):
              * rendering/RenderBlock.h:
              * rendering/RenderBlockLineLayout.cpp:
              (WebCore::createRun):
              (WebCore::RenderBlock::appendRunsForObject):
              (WebCore::reachedEndOfTextRenderer):
              (WebCore::RenderBlock::handleTrailingSpaces):
              (WebCore::RenderBlock::layoutInlineChildren):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83240 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5bee2940
    • enne@google.com's avatar
      2011-04-07 Adrienne Walker <enne@google.com> · 90e26174
      enne@google.com authored
              [chromium] Unreviewed, add baseline pixel images for decorations-transformed.
      
              * platform/chromium-mac/fast/text/decorations-transformed-expected.png: Added.
              * platform/chromium-win/fast/text/decorations-transformed-expected.png: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83239 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      90e26174
    • jberlin@webkit.org's avatar
      Max build fix. · 212318b2
      jberlin@webkit.org authored
      * WebProcess/WebCoreSupport/WebEditorClient.cpp:
      (WebKit::WebEditorClient::checkSpellingOfString):
      Do not risk an overflow.
      (WebKit::WebEditorClient::checkGrammarOfString):
      Ditto.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83238 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      212318b2
    • commit-queue@webkit.org's avatar
      2011-04-07 Naoki Takano <takano.naoki@gmail.com> · 2ff922bf
      commit-queue@webkit.org authored
              Reviewed by Adam Barth.
      
              [Chromium] Fix relocation problem of popup window which introduces autofill popup sometimes moves to screen's top left corner.
              https://bugs.webkit.org/show_bug.cgi?id=57911
              http://code.google.com/p/chromium/issues/detail?id=78073
      
              Manual test added: manual-tests/autofill-popup-location.html
      
              Originally only height is checked so that it introduces the bug.
              So I changed it to check both width and height as size.
      
              * manual-tests/autofill-popup-location.html: Added.
              * platform/chromium/PopupMenuChromium.cpp:
              (WebCore::PopupContainer::refresh): Check window size between original and new before calling setFrameRect().
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83237 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2ff922bf
    • lforschler@apple.com's avatar
      Versioning. · 0d12048d
      lforschler@apple.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83236 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0d12048d
    • abarth@webkit.org's avatar
      2011-04-07 Adam Barth <abarth@webkit.org> · 75a72fe0
      abarth@webkit.org authored
              Reviewed by Eric Seidel.
      
              Implement img-src style-src and font-src
              https://bugs.webkit.org/show_bug.cgi?id=58018
      
              Test a bunch of allow/block tests for these new directives.
      
              * http/tests/security/contentSecurityPolicy/image-allowed-expected.txt: Added.
              * http/tests/security/contentSecurityPolicy/image-allowed.html: Added.
              * http/tests/security/contentSecurityPolicy/image-blocked-expected.txt: Added.
              * http/tests/security/contentSecurityPolicy/image-blocked.html: Added.
              * http/tests/security/contentSecurityPolicy/resources/blue.css: Added.
              * http/tests/security/contentSecurityPolicy/resources/style.xsl: Added.
              * http/tests/security/contentSecurityPolicy/style-allowed-expected.txt: Added.
              * http/tests/security/contentSecurityPolicy/style-allowed.html: Added.
              * http/tests/security/contentSecurityPolicy/style-blocked-expected.txt: Added.
              * http/tests/security/contentSecurityPolicy/style-blocked.html: Added.
              * http/tests/security/contentSecurityPolicy/xsl-allowed.php: Added.
              * http/tests/security/contentSecurityPolicy/xsl-blocked-expected.txt: Added.
              * http/tests/security/contentSecurityPolicy/xsl-blocked.php: Added.
      2011-04-07  Adam Barth  <abarth@webkit.org>
      
              Reviewed by Eric Seidel.
      
              Implement img-src style-src and font-src
              https://bugs.webkit.org/show_bug.cgi?id=58018
      
              These are pretty straight forward given the rest of the infrastructure
              we've built so far.
      
              Tests: http/tests/security/contentSecurityPolicy/image-allowed.html
                     http/tests/security/contentSecurityPolicy/image-blocked.html
                     http/tests/security/contentSecurityPolicy/style-allowed.html
                     http/tests/security/contentSecurityPolicy/style-blocked.html
                     http/tests/security/contentSecurityPolicy/xsl-allowed.php
                     http/tests/security/contentSecurityPolicy/xsl-blocked.php
      
              * loader/cache/CachedResourceLoader.cpp:
              (WebCore::CachedResourceLoader::canRequest):
              * page/ContentSecurityPolicy.cpp:
              (WebCore::ContentSecurityPolicy::allowImageFromSource):
              (WebCore::ContentSecurityPolicy::allowStyleFromSource):
              (WebCore::ContentSecurityPolicy::allowFontFromSource):
              (WebCore::ContentSecurityPolicy::addDirective):
              * page/ContentSecurityPolicy.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83235 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      75a72fe0
    • levin@chromium.org's avatar
      Make IconSnapshot and PageURLRecord member variables private. · e0bc5507
      levin@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=58080
      
      Reviewed by Darin Adler.
      
      No change in functionality so no new tests.
      
      * loader/icon/IconDatabase.cpp:
      (WebCore::IconDatabase::writeToDatabase): Changed to used the accessor functions.
      (WebCore::IconDatabase::writeIconSnapshotToSQLDatabase): Ditto.
      * loader/icon/IconRecord.h:
      (WebCore::IconSnapshot::IconSnapshot): Changed to use the new member variable names.
      (WebCore::IconSnapshot::iconURL): Expose the property.
      (WebCore::IconSnapshot::timestamp): Ditto.
      (WebCore::IconSnapshot::data): Ditto.
      * loader/icon/PageURLRecord.h:
      (WebCore::PageURLSnapshot::PageURLSnapshot): Changed to use the new member variable names.
      (WebCore::PageURLSnapshot::pageURL): Expose the property.
      (WebCore::PageURLSnapshot::iconURL): Ditto.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83234 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e0bc5507
    • enrica@apple.com's avatar
      Unreviewed. Updated comment in skipped list to · 90e62946
      enrica@apple.com authored
      include the bug that tracks the changes required
      in WebKitTestRunner.
      
      * platform/win-wk2/Skipped:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83233 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      90e62946
    • jberlin@webkit.org's avatar
      WebKit2: Implement TextChecker on Windows · 756e20b2
      jberlin@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=57862
      
      Reviewed by Brian Weinstein.
      
      Part 4: Implement checkGrammarOfString.
      
      * Scripts/webkit2/messages.py:
      The generated files should include TextCheckerClient.h for WebCore::GrammarDetail.
      
      * Shared/API/c/win/WKBaseWin.h:
      * Shared/APIObject.h:
      * UIProcess/API/C/win/WKAPICastWin.h:
      
      * UIProcess/API/C/win/WKGrammarDetail.cpp: Added.
      (WKGrammarDetailGetTypeID):
      (WKGrammarDetailCreate):
      * UIProcess/API/C/win/WKGrammarDetail.h: Added.
      
      * UIProcess/API/C/win/WKTextChecker.h:
      Add the checkGrammarOfString WKTextCheckerClient function.
      
      * UIProcess/WebPageProxy.cpp:
      (WebKit::WebPageProxy::checkGrammarOfString):
      * UIProcess/WebPageProxy.h:
      * UIProcess/WebPageProxy.messages.in:
      
      * UIProcess/TextChecker.h:
      * UIProcess/win/TextCheckerWin.cpp:
      (WebKit::TextChecker::checkGrammarOfString):
      Call the TextCheckerClient.
      * UIProcess/mac/TextCheckerMac.mm:
      (WebKit::TextChecker::checkSpellingOfString):
      Add a comment about this not being used on Mac.
      (WebKit::TextChecker::checkGrammarOfString):
      Ditto, and call notImplemented.
      * UIProcess/gtk/TextCheckerGtk.cpp:
      (WebKit::TextChecker::checkGrammarOfString):
      Call notImplemented.
      * UIProcess/qt/TextCheckerQt.cpp:
      (WebKit::TextChecker::checkGrammarOfString):
      Ditto.
      
      * UIProcess/win/WebGrammarDetail.cpp: Added.
      (WebKit::WebGrammarDetail::create):
      (WebKit::WebGrammarDetail::WebGrammarDetail):
      Initialize the underlying WebCore::GrammarDetail.
      * UIProcess/win/WebGrammarDetail.h: Added.
      (WebKit::WebGrammarDetail::grammarDetail):
      (WebKit::WebGrammarDetail::type):
      
      * UIProcess/win/WebTextCheckerClient.cpp:
      (WebKit::WebTextCheckerClient::checkGrammarOfString):
      Populate the Vector of WebCore::GrammarDetails with the WebGrammarDetails.
      * UIProcess/win/WebTextCheckerClient.h:
      
      * WebProcess/WebCoreSupport/WebEditorClient.cpp:
      (WebKit::WebEditorClient::checkSpellingOfString):
      Use WTF::notFound as the initial value for resultLocation.
      (WebKit::WebEditorClient::checkGrammarOfString):
      Send a sync message to the UI Process (similar to checkSpellingOfString and checkTextOfParagraph).
      
      * win/WebKit2.vcproj:
      Add WKGrammarDetail.h/.cpp and WebGrammarDetail.h/.cpp.
      * win/WebKit2Generated.make:
      Copy over WKGrammarDetail.h.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83232 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      756e20b2
    • barraclough@apple.com's avatar
      Mapping booleans the same way as integers · 5139edc1
      barraclough@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=56913
      
      Patch by Zoltan Herczeg <zherczeg@webkit.org> on 2011-04-07
      Reviewed by Gavin Barraclough.
      
      Instead of having a seperate tag field for booleans,
      the logical values are stored in the payload field
      (for JSValue32_64 representation).
      
      1.007x speedup on SunSpider.
      
      * jit/JIT.h:
      * jit/JITInlineMethods.h:
      (JSC::JIT::emitStoreBool):
      * jit/JITOpcodes32_64.cpp:
      (JSC::JIT::emit_op_instanceof):
      (JSC::JIT::emit_op_not):
      (JSC::JIT::emit_op_jfalse):
      (JSC::JIT::emitSlow_op_jfalse):
      (JSC::JIT::emit_op_jtrue):
      (JSC::JIT::emitSlow_op_jtrue):
      (JSC::JIT::emit_op_jeq_null):
      (JSC::JIT::emit_op_jneq_null):
      (JSC::JIT::emit_op_eq):
      (JSC::JIT::emitSlow_op_eq):
      (JSC::JIT::emit_op_neq):
      (JSC::JIT::emitSlow_op_neq):
      (JSC::JIT::compileOpStrictEq):
      (JSC::JIT::emit_op_eq_null):
      (JSC::JIT::emit_op_neq_null):
      * jit/JSInterfaceJIT.h:
      * runtime/JSValue.h:
      (JSC::JSValue::JSValue):
      (JSC::JSValue::isTrue):
      (JSC::JSValue::isFalse):
      (JSC::JSValue::getBoolean):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83230 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5139edc1
    • enrica@apple.com's avatar
      REGRESSION(WebKit2): execCommand('undo') doesn't work (Windows). · d5a6064e
      enrica@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=58056
      <rdar://problem/8862023>
              
      Reviewed by Oliver Hunt.
      
      Adding support for execCommand('undo') and execCommand('redo')
      in WebKit2 for Windows.
      
      * UIProcess/API/C/win/WKView.h:
      * UIProcess/win/WebUndoClient.cpp:
      (WebKit::WebUndoClient::canUndoRedo):
      (WebKit::WebUndoClient::executeUndoRedo):
      * UIProcess/win/WebUndoClient.h:
      * UIProcess/win/WebView.cpp:
      (WebKit::WebView::canUndoRedo):
      (WebKit::WebView::executeUndoRedo):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83229 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d5a6064e
    • dbates@webkit.org's avatar
      2011-04-07 Daniel Bates <dbates@rim.com> · 6e34f5e0
      dbates@webkit.org authored
              Reviewed by Darin Adler.
      
              Add a layout test to ensure that mousemove is fired from a subframe
              https://bugs.webkit.org/show_bug.cgi?id=58094
      
              * fast/events/iframe-onmousemove-expected.txt: Added.
              * fast/events/iframe-onmousemove.html: Added.
              * fast/events/resources/iframe-onmousemove.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83228 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6e34f5e0