1. 23 Feb, 2008 2 commits
    • ap@webkit.org's avatar
      Reviewed by Darin. · 8c7fd040
      ap@webkit.org authored
              A few tweaks to PCRE-based regex test suite.
      
              * fast/regex/pcre-test-runner.js: Added support for global regexes. Emulate PCRE test runner
              more precisely by trimming trailing whitespace from some lines.
      
              * fast/regex/test1-expected.txt:
              * fast/regex/test4-expected.txt:
              * fast/regex/testinput1:
              * fast/regex/testinput4:
              * fast/regex/testoutput1:
              * fast/regex/testoutput4:
              Updated to PCRE 7.6.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30517 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8c7fd040
    • mitz@apple.com's avatar
      - update Tiger expected results following r30431 · 6e79eca6
      mitz@apple.com authored
              * platform/mac-tiger/svg/W3C-SVG-1.1/text-tselect-02-f-expected.txt:
              * platform/mac-tiger/svg/custom/foreignObject-crash-on-hover-expected.txt:
              * platform/mac-tiger/svg/custom/text-dom-01-f-expected.txt:
              * platform/mac-tiger/svg/custom/text-hit-test-expected.txt:
              * platform/mac-tiger/svg/text/text-align-01-b-expected.txt:
              * platform/mac-tiger/svg/text/text-align-02-b-expected.txt:
              * platform/mac-tiger/svg/text/text-align-03-b-expected.txt:
              * platform/mac-tiger/svg/text/text-align-04-b-expected.txt:
              * platform/mac-tiger/svg/text/text-align-05-b-expected.txt:
              * platform/mac-tiger/svg/text/text-align-06-b-expected.txt:
              * platform/mac-tiger/svg/text/text-altglyph-01-b-expected.txt:
              * platform/mac-tiger/svg/text/text-deco-01-b-expected.txt:
              * platform/mac-tiger/svg/text/text-fonts-01-t-expected.txt:
              * platform/mac-tiger/svg/text/text-fonts-02-t-expected.txt:
              * platform/mac-tiger/svg/text/text-path-01-b-expected.txt:
              * platform/mac-tiger/svg/text/text-spacing-01-b-expected.txt:
              * platform/mac-tiger/svg/text/text-text-01-b-expected.txt:
              * platform/mac-tiger/svg/text/text-text-03-b-expected.txt:
              * platform/mac-tiger/svg/text/text-text-04-t-expected.txt:
              * platform/mac-tiger/svg/text/text-text-05-t-expected.txt:
              * platform/mac-tiger/svg/text/text-text-06-t-expected.txt:
              * platform/mac-tiger/svg/text/text-text-07-t-expected.txt:
              * platform/mac-tiger/svg/text/text-text-08-b-expected.txt:
              * platform/mac-tiger/svg/text/text-tref-01-b-expected.txt:
              * platform/mac-tiger/svg/text/text-tselect-01-b-expected.txt:
              * platform/mac-tiger/svg/text/text-tselect-02-f-expected.txt:
              * platform/mac-tiger/svg/text/text-tspan-01-b-expected.txt:
              * platform/mac-tiger/svg/text/text-ws-01-t-expected.txt:
              * platform/mac-tiger/svg/text/text-ws-02-t-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30516 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6e79eca6
  2. 22 Feb, 2008 29 commits
    • justin.garcia@apple.com's avatar
      WebCore: · ec7649f8
      justin.garcia@apple.com authored
              Reviewed by Anders Carlsson.
      
              <rdar://problem/5714333> Add document.getSelection()
              
              Add a synonym for window.getSelection() that FF supports.  There were requests in
              this bugs dupes to also support the IE only document.selection, but IE's Selection
              object is too different than ours currently for that to be safe (specifically, we
              don't support enough of IE's TextRange methods on our DOM Range object yet). I
              filed <rdar://problem/5761233> to cover that.
      
              * dom/Document.cpp:
              (WebCore::Document::getSelection): Added.
              * dom/Document.h:
              * dom/Document.idl: Ditto.  JS only since this is about web compatibility.
      
      LayoutTests:
      
              Reviewed by Anders.
              
              <rdar://problem/5714333> Add document.getSelection()
      
              * editing/selection/5714333-expected.txt: Added.
              * editing/selection/5714333.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30515 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ec7649f8
    • oliver@apple.com's avatar
      WX build fixes · fe7bb18b
      oliver@apple.com authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30514 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fe7bb18b
    • mrowe@apple.com's avatar
      Roll out r30500 as it breaks non-Windows use of Cairo. · d1af88a9
      mrowe@apple.com authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30513 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d1af88a9
    • oliver@apple.com's avatar
      Once more with the cairo/qt/wx build fixing · 5bd2a510
      oliver@apple.com authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30512 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5bd2a510
    • mrowe@apple.com's avatar
    • mrowe@apple.com's avatar
      Speculative Windows build fix. Add missing include of DeprecatedCString.h and... · 9c33810e
      mrowe@apple.com authored
      Speculative Windows build fix.  Add missing include of DeprecatedCString.h and sort existing includes.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30510 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9c33810e
    • oliver@apple.com's avatar
      Build fix for windows, wx and qt · 62f96d7d
      oliver@apple.com authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30509 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      62f96d7d
    • oliver@apple.com's avatar
      Reviewed by NOBODY (build fix). · 01e8511a
      oliver@apple.com authored
              Unbreak windows vcproj
      
              * WebCore.vcproj/WebCore.vcproj:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30508 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      01e8511a
    • weinig@apple.com's avatar
      Fix Qt build. · 5b38e1a0
      weinig@apple.com authored
              * Api/qwebhistoryinterface.cpp:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30507 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5b38e1a0
    • oliver@apple.com's avatar
      Bug 17486: Support HTML5 Canvas.getImageData API · ae996a97
      oliver@apple.com authored
      Support Canvas.getImageData and Canvas.createImageData
      
      Reviewed by Sam W.
      
      This patch adds support for all the pixel reading portions
      of the HTML5 Canvas spec.  There are two new types ImageData
      and CanvasPixelArray which are used to provide the HTML5
      ImageData object, and the required semantics for assignment
      to the ImageData data array.
      
      We only implement the CG version of ImageBuffer::getImageData,
      but the logic is null safe, so this will not introduce any
      crashes into other platforms, unfortunately it will result in
      JS Object detection "lying" on non-CG platforms.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30506 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ae996a97
    • weinig@apple.com's avatar
      WebCore: · ac324818
      weinig@apple.com authored
              Rubber-stamped by Adam Roben.
      
              Rid the project of the Devil known as DeprecatedString!
      
              * GNUmakefile.am:
              * WebCore.base.exp:
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * WebCoreSources.bkl:
              * dom/Node.h:
              * html/HTMLFormElement.cpp:
              * platform/DeprecatedString.cpp: Removed.
              * platform/DeprecatedString.h: Removed.
              * platform/graphics/qt/IconQt.cpp:
              * platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:
              * platform/gtk/CookieJarGtk.cpp:
              * platform/gtk/CursorGtk.cpp:
              * platform/gtk/KeyEventGtk.cpp:
              * platform/mac/DeprecatedStringMac.mm: Removed.
              * platform/network/qt/ResourceHandleQt.cpp:
              * platform/network/win/CookieJarWin.cpp:
              (WebCore::cookies):
              * platform/qt/ClipboardQt.cpp:
              * platform/qt/CookieJarQt.cpp:
              * platform/qt/CursorQt.cpp:
              * platform/symbian/DeprecatedStringSymbian.cpp: Removed.
              * platform/text/AtomicString.cpp:
              * platform/text/AtomicString.h:
              * platform/text/PlatformString.h:
              * platform/text/String.cpp:
              * platform/text/StringImpl.cpp:
              * platform/text/qt/StringQt.cpp:
              (WebCore::String::String):
              * platform/text/wx/StringWx.cpp:
              * platform/win/BString.cpp:
              * platform/win/BString.h:
              * platform/win/PasteboardWin.cpp:
      
      WebKit/qt:
      
              Rubber-stamped by Adam Roben.
      
              Rid the project of the Devil known as DeprecatedString!
      
              * Api/qwebhistory.cpp:
              * Api/qwebhistoryinterface.cpp:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30501 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ac324818
    • pewtermoose@webkit.org's avatar
      2008-02-22 Brent Fulgham <bfulgham@gmail.com> · 397df0d5
      pewtermoose@webkit.org authored
              Reviewed by Adam Roben.
      
              http://bugs.webkit.org/show_bug.cgi?id=17442
              Correct the Windows Cairo implementation of GraphicsContext so
              that Windows 'WorldTransform' is kept in sync with the Cairo
              transformations.
      
              Also corrects an uninitialized variable in the Cairo Windows
              image drag handler.
      
              * platform/graphics/cairo/GraphicsContextCairo.cpp:  Modify
                methods to call GraphicsContextPlatformPrivate calls, just
                as is done for the CoreGraphics version.  These calls are
                nop's for everything but Windows.
              (WebCore::GraphicsContext::savePlatformState):
              (WebCore::GraphicsContext::restorePlatformState):
              (WebCore::GraphicsContext::clip):
              (WebCore::GraphicsContext::drawLineForMisspellingOrBadGrammar):
              (WebCore::GraphicsContext::translate):
              (WebCore::GraphicsContext::concatCTM): Re-enable for Windows
              (WebCore::GraphicsContext::beginTransparencyLayer):
              (WebCore::GraphicsContext::endTransparencyLayer):
              (WebCore::GraphicsContext::rotate):
              (WebCore::GraphicsContext::scale):
              * platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h:
              * platform/graphics/win/GraphicsContextCGWin.cpp:  Move common
                code for handling WorldTransform calls to parent class.
              * platform/graphics/win/GraphicsContextCairoWin.cpp:  Add common
                code for handling WorldTransform calls.
                (WebCore::GraphicsContextPlatformPrivate::concatCTM):  Change
                implementation so that it only handles WorldTransform.  The
                Cairo update is done in GraphicsContextCairo.cpp
              * platform/graphics/win/GraphicsContextWin.cpp:  Call platform-private
                methods to keep WorldTransform in sync.
              (WebCore::GraphicsContextPlatformPrivate::save):
              (WebCore::GraphicsContextPlatformPrivate::restore):
              (WebCore::GraphicsContextPlatformPrivate::clip):
              (WebCore::GraphicsContextPlatformPrivate::scale):
              (WebCore::GraphicsContextPlatformPrivate::rotate):
              (WebCore::GraphicsContextPlatformPrivate::translate):
              * platform/win/DragImageCairoWin.cpp:
              (WebCore::createDragImageFromImage):  Correct uninitialized value
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30500 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      397df0d5
    • weinig@apple.com's avatar
      Reviewed by Geoff Garen. · 241b7eae
      weinig@apple.com authored
              - Remove use of DeprecatedString in CSSStyleSelector.
      
              * css/CSSStyleSelector.cpp:
              (WebCore::findHash): Removed.  Use find instead.
              (WebCore::findSlashDotDotSlash): Changed to take a UChar* and a length.
              (WebCore::findSlashSlash): Ditto.
              (WebCore::findSlashDotSlash): Ditto.
              (WebCore::containsColonSlashSlash): Ditto.
              (WebCore::cleanPath): Change to operate on a String.
              (WebCore::checkPseudoState): Changed to use a Vector as a buffer.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30499 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      241b7eae
    • ggaren@apple.com's avatar
      Reviewed by Sam Weinig. · 8633d14e
      ggaren@apple.com authored
              
              Fixed <rdar://problem/5057509> Repro leak of JSXMLHttpRequest and
              associated objects @ www.viamichelin.it, which was probably an underlying
              cause of <rdar://problem/5744037> Gmail out of memory (17455)
              
              If SubresourceLoader::create returned NULL, we would ref() / gcProtect()
              the XMLHttpRequest but think we hadn't, therefore never
              calling deref() / gcUnprotect().
              
              This could happen at gmail.com, since gmail.com attempts to send
              XMLHttpRequests from unload handlers in order to gather usage statistics.
              (According to comments in the code, SubresourceLoader::create returns
              NULL when called from an unload handler.)
      
              The solution is to ref() / gcProtect() only if SubresourceLoader::create
              doesn't return NULL. This make sense, since we only need to protect the
              request as long as it has an outstanding network transaction.
              
              * xml/XMLHttpRequest.cpp:
              (WebCore::XMLHttpRequest::XMLHttpRequest):
              (WebCore::XMLHttpRequest::send):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30493 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8633d14e
    • ggaren@apple.com's avatar
      JavaScriptCore: · 5ffdb7b1
      ggaren@apple.com authored
              Reviewed by Sam Weinig.
              
              Partial fix for <rdar://problem/5744037> Gmail out of memory (17455)
              
              I'm removing KJS_MEM_LIMIT for the following reasons:
              
              - We have a few reports of KJS_MEM_LIMIT breaking important web
              applications, like GMail and Google Reader. (For example, if you
              simply open 12 GMail tabs, tab #12 will hit the limit.)
      
              - Firefox has no discernable JS object count limit, so any limit, even
              a large one, is a potential compatibility problem.
              
              - KJS_MEM_LIMIT does not protect against malicious memory allocation,
              since there are many ways to maliciously allocate memory without
              increasing the JS object count.
              
              - KJS_MEM_LIMIT is already mostly broken, since it only aborts the
              script that breaches the limit, not any subsequent scripts.
              
              - We've never gotten bug reports about websites that would have
              benefited from an unbroken KJS_MEM_LIMIT. The initial check-in of
              KJS_MEM_LIMIT (KJS revision 80061) doesn't mention a website that
              needed it.
              
              - Any website that brings you anywhere close to crashing due to the
              number of live JS objects will almost certainly put up the "slow
              script" dialog at least 20 times beforehand.
      
              * kjs/collector.cpp:
              (KJS::Collector::collect):
              * kjs/collector.h:
              * kjs/nodes.cpp:
              (KJS::TryNode::execute):
      
      LayoutTests:
      
              Reviewed by Sam Weinig.
              
              Removing the test for KJS_MEM_LIMIT, since I removed KJS_MEM_LIMIT.
      
              * fast/js/out-of-memory-expected.txt: Removed.
              * fast/js/out-of-memory.html: Removed.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30492 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5ffdb7b1
    • weinig@apple.com's avatar
      Reviewed, tweaked and landed by Sam. · 5ca5e8bd
      weinig@apple.com authored
              - Make RegularExpression operate on Strings instead of DeprecatedStrings.
      
              * dom/DOMImplementation.cpp:
              (WebCore::DOMImplementation::isXMLMIMEType): Use string instead of DeprecatedString
              to build up the RegularExpression.
              * page/Frame.cpp:
              (WebCore::createRegExpForLabels): Use String instead of DeprecatedString.
              (WebCore::Frame::searchForLabelsAboveCell): Ditto.
              (WebCore::Frame::searchForLabelsBeforeElement): Ditto.
              (WebCore::Frame::matchLabelsAgainstElement): Ditto.
              * page/Frame.h:
              * page/mac/FrameMac.mm:
              (WebCore::regExpForLabels): Ditto.
              (WebCore::Frame::searchForNSLabelsAboveCell): Ditto.
              (WebCore::Frame::searchForLabelsBeforeElement): Ditto.
              (WebCore::Frame::matchLabelsAgainstElement): Ditto.
      
              * platform/text/RegularExpression.cpp:
              (WebCore::RegularExpression::Private::Private):
              (WebCore::RegularExpression::Private::compile):
              (WebCore::RegularExpression::RegularExpression):
              (WebCore::RegularExpression::operator=):
              (WebCore::RegularExpression::pattern):
              (WebCore::RegularExpression::match):
              (WebCore::RegularExpression::search):
              (WebCore::RegularExpression::searchRev):
              (WebCore::replace): Added.
              * platform/text/RegularExpression.h:
              Change functions to take Strings as input instead of DeprecatedStrings and
              reduce the complexity of the class by removing unneeded globbing support.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30490 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5ca5e8bd
    • jhoneycutt@apple.com's avatar
      2008-02-22 Jon Honeycutt <jhoneycutt@apple.com> · b29db6f1
      jhoneycutt@apple.com authored
              Reviewed by Anders.
      
              <rdar://problem/5760360> REGRESSION(r30376): Crash loading plugin page
              during stress test (after only 5 min) - null dereference
      
              Full-frame plug-ins create PluginStream objects without loaders, as the
              PluginView receives the loading callbacks. We were trying to call
              setDefersLoading on these null pointers.
      
              * plugins/PluginStream.cpp:
              (WebCore::PluginStream::startStream): Add null check.
              (WebCore::PluginStream::destroyStream): Same.
              (WebCore::PluginStream::deliverData): Same.
      
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30489 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b29db6f1
    • weinig@apple.com's avatar
      Reviewed and tweaked by Jon Honeycutt. Reviewed and landed by Sam. · f6b41fa6
      weinig@apple.com authored
              - Remove uses of DeprecatedString in Windows plugin code.
      
              * plugins/win/PluginPackageWin.cpp:
              (WebCore::getVersionInfo): Cleanup formatting.
              (WebCore::PluginPackage::freeLibraryTimerFired): Remove un-needed variable name.
              (WebCore::PluginPackage::storeFileVersion): Move casts.
              (WebCore::PluginPackage::fetchInfo): Use OwnArrayPtr and switch to more efficient
              use of Vectors.
              (WebCore::PluginPackage::load): Fix whitespace.
              (WebCore::PluginPackage::hash): Make the hashCodes const
              * plugins/win/PluginViewWin.cpp:
              (WebCore::makeURL): Use String instead of DeprecatedString.
              (WebCore::parseRFC822HeaderFields): Ditto.
              (WebCore::PluginView::handlePost): Ditto.
              (WebCore::PluginView::status): Ditto.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30488 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f6b41fa6
    • weinig@apple.com's avatar
      Reviewed, tweaked and landed by Sam. · 6b0ef9e9
      weinig@apple.com authored
              - Don't use DeprecatedString in HTMLTokenizer.
      
              * html/HTMLTokenizer.cpp:
              (WebCore::HTMLTokenizer::finish):
              * platform/text/PlatformString.h:
              (WebCore::find):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30486 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6b0ef9e9
    • aroben@apple.com's avatar
      Move hasWebView to WebFrameLoaderClient · 740c8cc2
      aroben@apple.com authored
               I added an m_webFrame member to WebFrameLoaderClient. This is slightly
               strange because WebFrame inherits from WebFrameLoaderClient, but this
               member will be needed once we remove the inheritance, so we might as
               well prepare for that now.
      
               Reviewed by Anders.
      
               * WebCoreSupport/WebFrameLoaderClient.cpp:
               (WebFrameLoaderClient::WebFrameLoaderClient): Changed to take a
               WebFrame* parameter.
               (WebFrameLoaderClient::hasWebView): Moved here from WebFrame.cpp.
               * WebCoreSupport/WebFrameLoaderClient.h: Added an m_webFrame
               parameter.
               * WebFrame.cpp: Removed hasWebView.
               (WebFrame::WebFrame): Updated for WebFrameLoaderClient constructor
               change.
               * WebFrame.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30485 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      740c8cc2
    • andersca@apple.com's avatar
      Reviewed by Adam. · 61114eac
      andersca@apple.com authored
              <rdar://problem/5748781> 
              https://bugs.webkit.org/show_bug.cgi?id=17413
              REGRESSION: Latest Nightly doesn't load Java plugin w/Safari 3.1b
              
              Copy the Java plug-in over to the new location.
              
              * FindSafari/FindSafari.cpp:
              (_tmain):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30482 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      61114eac
    • aroben@apple.com's avatar
      Start to move FrameLoaderClient methods off WebFrame onto a separate class · e9d38bb7
      aroben@apple.com authored
              WebFrame now inherits from a new WebFrameLoaderClient class, which
              will gradually assume all FrameLoaderClient responsibilities. Once
              that process is complete, WebFrame will no longer inherit from
              WebFrameLoaderClient.
      
              In this first patch, I've only moved createDocumentLoader up to the
              WebFrameLoaderClient class.
      
              Reviewed by Anders.
      
              * WebCoreSupport/WebFrameLoaderClient.cpp: Added.
              (WebFrameLoaderClient::WebFrameLoaderClient):
              (WebFrameLoaderClient::~WebFrameLoaderClient):
              (WebFrameLoaderClient::createDocumentLoader): Moved here from
              WebFrame.cpp.
              * WebCoreSupport/WebFrameLoaderClient.h: Added.
              * WebFrame.cpp: Removed createDocumentLoader implementation.
              * WebFrame.h: Changed to inherit from WebFrameLoaderClient.
              * WebKit.vcproj/WebKit.vcproj: Added new files to the project.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30481 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e9d38bb7
    • andersca@apple.com's avatar
      Reviewed by Adam. · 7a9dee07
      andersca@apple.com authored
              <rdar://problem/5747325> REGRESSION: HTTP layout tests hang
              
              * DumpRenderTree/win/DumpRenderTree.cpp:
              (runTest):
              Init the URL request with the correct timeout.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30480 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7a9dee07
    • aroben@apple.com's avatar
      Move FormValuesPropertyBag into its own files · 914d36b1
      aroben@apple.com authored
               Reviewed by Sam.
      
               * WebCoreSupport/FormValuesPropertyBag.cpp: Added.
               (FormValuesPropertyBag::QueryInterface):
               (FormValuesPropertyBag::AddRef):
               (FormValuesPropertyBag::Release):
               (FormValuesPropertyBag::Read):
               (FormValuesPropertyBag::Write):
               (FormValuesPropertyBag::CountProperties):
               (FormValuesPropertyBag::GetPropertyInfo):
               (FormValuesPropertyBag::LoadObject):
               * WebCoreSupport/FormValuesPropertyBag.h: Added.
               (FormValuesPropertyBag::FormValuesPropertyBag):
               * WebFrame.cpp: Deleted FormValuesPropertyBag code.
               * WebKit.vcproj/WebKit.vcproj: Added new files to the project.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30479 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      914d36b1
    • aroben@apple.com's avatar
      Remove some unused WebFrame methods · 344bc28b
      aroben@apple.com authored
               FrameWinClient was deleted back in r22965, but these methods were
               never deleted.
      
               Reviewed by Sam.
      
               * WebFrame.cpp:
               * WebFrame.h: Made one createFrame overload protected, since it's only
               called internally by WebFrame.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30478 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      344bc28b
    • aroben@apple.com's avatar
      Move Client implementations into a WebCoreSupport directory · d34d0028
      aroben@apple.com authored
               Reviewed by Anders.
      
               * WebKit.vcproj/WebKit.vcproj: Updated file paths, and added
               WebCoreSupport directory to the include path.
               * WebCoreSupport/WebChromeClient.cpp: Renamed from WebKit/win/WebChromeClient.cpp.
               * WebCoreSupport/WebChromeClient.h: Renamed from WebKit/win/WebChromeClient.h.
               * WebCoreSupport/WebContextMenuClient.cpp: Renamed from WebKit/win/WebContextMenuClient.cpp.
               * WebCoreSupport/WebContextMenuClient.h: Renamed from WebKit/win/WebContextMenuClient.h.
               * WebCoreSupport/WebDragClient.cpp: Renamed from WebKit/win/WebDragClient.cpp.
               * WebCoreSupport/WebDragClient.h: Renamed from WebKit/win/WebDragClient.h.
               * WebCoreSupport/WebEditorClient.cpp: Renamed from WebKit/win/WebEditorClient.cpp.
               * WebCoreSupport/WebEditorClient.h: Renamed from WebKit/win/WebEditorClient.h.
               * WebCoreSupport/WebInspectorClient.cpp: Renamed from WebKit/win/WebInspectorClient.cpp.
               * WebCoreSupport/WebInspectorClient.h: Renamed from WebKit/win/WebInspectorClient.h.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30477 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d34d0028
    • sullivan@apple.com's avatar
      Reviewed by Adam Roben · 624dcba7
      sullivan@apple.com authored
              
              Reverted the changed from yesterday to add pasteAndMatchStyle:, as the existing
              pasteAsPlainText: has the same behavior.
      
              * WebView/WebHTMLView.mm:
              (-[WebHTMLView _pasteWithPasteboard:allowPlainText:]):
              (-[WebHTMLView readSelectionFromPasteboard:]):
              (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]):
              (-[WebHTMLView pasteAsRichText:]):
              (-[WebHTMLView paste:]):
              * WebView/WebView.mm:
              * WebView/WebViewPrivate.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30476 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      624dcba7
    • oliver@apple.com's avatar
      <rdar://problem/5759327> REGRESSION: while(NaN) acts like while(true) · 9c3b3ab0
      oliver@apple.com authored
      Reviewed by Alexey P.
      
      Fix yet another case where we incorrectly relied on implicit double
      to bool coercion.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30475 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9c3b3ab0
    • hyatt@apple.com's avatar
      Add null check to fix crash in media query code I checked in. · 8f5f84a2
      hyatt@apple.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30474 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8f5f84a2
  3. 21 Feb, 2008 9 commits
    • alp@webkit.org's avatar
      2008-02-21 Alp Toker <alp@atoker.com> · 52b8366a
      alp@webkit.org authored
              Fix a configure script typo.
      
              * configure.ac:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30473 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      52b8366a
    • weinig@apple.com's avatar
      WebCore: · 7e9640a4
      weinig@apple.com authored
              Reviewed by Anders Carlsson.
      
              Fix for <rdar://problem/5757946>
      
              - Parse URLs before checking whether they are javascript: urls
                (which require security checks).
      
              * bindings/js/JSAttrCustom.cpp:
              (WebCore::JSAttr::setValue):
              * bindings/js/JSElementCustom.cpp:
              (WebCore::allowSettingSrcToJavascriptURL):
              * bindings/js/JSHTMLFrameElementCustom.cpp:
              (WebCore::allowSettingJavascriptURL):
              * bindings/js/JSHTMLIFrameElementCustom.cpp:
              (WebCore::JSHTMLIFrameElement::setSrc):
      
      LayoutTests:
      
              Reviewed by Anders Carlsson.
      
              Update tests and results for <rdar://problem/5757946>
      
              * http/tests/security/javascriptURL/javascriptURL-execution-context-frame-location-htmldom-expected.txt:
              * http/tests/security/javascriptURL/javascriptURL-execution-context-frame-location-htmldom.html:
              * http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-getAttribute-value-expected.txt:
              * http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-getAttribute-value.html:
              * http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-htmldom-expected.txt:
              * http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-htmldom.html:
              * http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttribute-expected.txt:
              * http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttribute.html:
              * http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNS-expected.txt:
              * http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNS.html:
              * http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNode-expected.txt:
              * http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNode.html:
              * http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNodeNS-expected.txt:
              * http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNodeNS.html:
              * http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-getAttribute-value-expected.txt:
              * http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-getAttribute-value.html:
              * http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-htmldom-expected.txt:
              * http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-htmldom.html:
              * http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttribute-expected.txt:
              * http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttribute.html:
              * http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNS-expected.txt:
              * http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNS.html:
              * http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNode-expected.txt:
              * http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNode.html:
              * http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNodeNS-expected.txt:
              * http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNodeNS.html:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30472 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7e9640a4
    • adachan@apple.com's avatar
      <rdar://problem/5757873> Buffer overrun in DeprecatedCString::find() in WebCore · b035e72f
      adachan@apple.com authored
              We could get a buffer overrun in DeprecatedCString::find() if the end of the
              string matches a beginning portion of the substring, for example, if string is
              "a" but the substring is "ab".
              The code as is also will not match things correctly under certain situations
              since the inner while loop increments the index. For example, we wouldn't find
              a match if the string is "aab..." and the substring is "ab".  Changed the 
              inner while loop to increment a temporary index into str.
              
              Test: fast/loader/charset-parse.html
      
              Reviewed by Dan Berstein.
      
              * platform/DeprecatedCString.cpp:
              (WebCore::DeprecatedCString::find):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30468 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b035e72f
    • hyatt@apple.com's avatar
      Add test case for viewport media queries. · c93d9bf0
      hyatt@apple.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30467 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c93d9bf0
    • hyatt@apple.com's avatar
      Fix for bug 17301. CSS media queries need to use the correct viewport · 27bb5d77
      hyatt@apple.com authored
              when contained in documents inside iframes (rather than always using the
              top-level document's viewport).  CSS media queries based on the viewport
              also needed to be dynamic and update as you resize the window (this is
              a HOT feature). :)
      
              This patch gets Acid3 up to 86/100 with 3 colored boxes filled in.
      
              Reviewed by olliej
      
              Added fast/media/viewport-media-query.html
      
              * css/CSSStyleSelector.cpp:
              (WebCore::CSSStyleSelector::CSSStyleSelector):
              (WebCore::CSSStyleSelector::addViewportDependentMediaQueryResult):
              (WebCore::CSSStyleSelector::affectedByViewportChange):
              * css/CSSStyleSelector.h:
              (WebCore::MediaQueryResult::MediaQueryResult):
              * css/MediaQueryEvaluator.cpp:
              (WebCore::MediaQueryEvaluator::MediaQueryEvaluator):
              (WebCore::MediaQueryEvaluator):
              (WebCore::MediaQueryEvaluator::eval):
              (WebCore::colorMediaFeatureEval):
              (WebCore::monochromeMediaFeatureEval):
              (WebCore::device_aspect_ratioMediaFeatureEval):
              (WebCore::device_pixel_ratioMediaFeatureEval):
              (WebCore::gridMediaFeatureEval):
              (WebCore::device_heightMediaFeatureEval):
              (WebCore::device_widthMediaFeatureEval):
              (WebCore::heightMediaFeatureEval):
              (WebCore::widthMediaFeatureEval):
              (WebCore::min_colorMediaFeatureEval):
              (WebCore::max_colorMediaFeatureEval):
              (WebCore::min_monochromeMediaFeatureEval):
              (WebCore::max_monochromeMediaFeatureEval):
              (WebCore::min_device_aspect_ratioMediaFeatureEval):
              (WebCore::max_device_aspect_ratioMediaFeatureEval):
              (WebCore::min_device_pixel_ratioMediaFeatureEval):
              (WebCore::max_device_pixel_ratioMediaFeatureEval):
              (WebCore::min_heightMediaFeatureEval):
              (WebCore::max_heightMediaFeatureEval):
              (WebCore::min_widthMediaFeatureEval):
              (WebCore::max_widthMediaFeatureEval):
              (WebCore::min_device_heightMediaFeatureEval):
              (WebCore::max_device_heightMediaFeatureEval):
              (WebCore::min_device_widthMediaFeatureEval):
              (WebCore::max_device_widthMediaFeatureEval):
              * css/MediaQueryEvaluator.h:
              * css/MediaQueryExp.cpp:
              (WebCore::MediaQueryExp::~MediaQueryExp):
              * css/MediaQueryExp.h:
              (WebCore::MediaQueryExp::value):
              (WebCore::MediaQueryExp::isViewportDependent):
              * html/HTMLMediaElement.cpp:
              (WebCore::HTMLMediaElement::pickMedia):
              * page/FrameView.cpp:
              (WebCore::FrameView::layout):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30466 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      27bb5d77
    • andersca@apple.com's avatar
      WebCore: · 6cdfdf41
      andersca@apple.com authored
              Reviewed by Sam.
      
              Make more classes start out with a refcount of 1.
      
              * dom/QualifiedName.cpp:
              (WebCore::QNameComponentsTranslator::translate):
              (WebCore::QualifiedName::QualifiedName):
              * dom/QualifiedName.h:
              (WebCore::QualifiedName::QualifiedNameImpl::create):
              (WebCore::QualifiedName::QualifiedNameImpl::QualifiedNameImpl):
              * history/BackForwardList.cpp:
              (WebCore::BackForwardList::BackForwardList):
              * history/BackForwardList.h:
              (WebCore::BackForwardList::create):
              * page/Page.cpp:
              (WebCore::Page::Page):
              * platform/text/CString.cpp:
              (WebCore::CString::init):
              (WebCore::CString::newUninitialized):
              (WebCore::CString::copyBufferIfNeeded):
              * platform/text/CString.h:
              (WebCore::CStringBuffer::create):
              (WebCore::CStringBuffer::CStringBuffer):
      
      WebKit/mac:
      
              Reviewed by Sam.
      
              Use BackForwardList::create instead.
              
              * History/WebBackForwardList.mm:
              (-[WebBackForwardList init]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30465 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6cdfdf41
    • kevino@webkit.org's avatar
      wx build fix for the domString() -> string() rename in r30443. · 01cd9fac
      kevino@webkit.org authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30464 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      01cd9fac
    • sullivan@apple.com's avatar
      Reviewed by Jessica Kahn · b936ccfc
      sullivan@apple.com authored
              
              support for pasteAndMatchStyle: command (see <rdar://problem/5723952>)
      
              * WebView/WebHTMLView.mm:
              (-[WebHTMLView _pasteWithPasteboard:allowPlainText:matchStyle:]):
              added matchStyle parameter, passed along to bridge (formerly always passed NO to bridge)
              (-[WebHTMLView readSelectionFromPasteboard:]):
              pass NO for new matchStyle parameter to match old behavior
              (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]):
              validate pasteAndMatchStyle the same way as pasteAsRichText
              (-[WebHTMLView pasteAndMatchStyle:]):
              just like pasteAsRichText but passes YES for matchStyle
              (-[WebHTMLView pasteAsRichText:]):
              pass NO for new matchStyle parameter to match old behavior
              (-[WebHTMLView paste:]):
              ditto
              
              * WebView/WebView.mm:
              added macro(pasteAndMatchStyle)
              
              * WebView/WebViewPrivate.h:
              added pasteAndMatchStyle: to WebViewEditingActionsPendingPublic category
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30463 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b936ccfc
    • alp@webkit.org's avatar
      2008-02-21 Alp Toker <alp@atoker.com> · 80dd112e
      alp@webkit.org authored
              GTK+/autotools SVG experimental build fix
      
              Don't enable SVG filters in --enable-svg-experimental.
      
              This feature isn't supported at all yet. Developers can enable it
              explicitly by passing --enable-svg-filters if needed.
      
              * configure.ac:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30462 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      80dd112e