- 18 Mar, 2009 2 commits
-
-
andersca@apple.com authored
Reviewed by Oliver Hunt. WebKit side of <rdar://problem/6688244>. Try reinitializing the vendor port if it's invalid. * Plugins/Hosted/NetscapePluginHostManager.mm: (WebKit::NetscapePluginHostManager::spawnPluginHost): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41820 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
andersca@apple.com authored
2009-03-18 Anders Carlsson <andersca@apple.com> Reviewed by Darin Adler. <rdar://problem/6504776> CrashTracer: [USER] 188 crashes in Safari at com.apple.WebCore ⢠WTF::HashTableIterator<WTF::RefPtr<WebCore::ResourceLoader>, ... Return early in case calling the client ends up spinning the run loop and completing/cancelling the load. * loader/NetscapePlugInStreamLoader.cpp: (WebCore::NetscapePlugInStreamLoader::didCancel): WebKit/mac: 2009-03-18 Anders Carlsson <andersca@apple.com> Reviewed by Darin Adler. <rdar://problem/6504776> CrashTracer: [USER] 188 crashes in Safari at com.apple.WebCore ⢠WTF::HashTableIterator<WTF::RefPtr<WebCore::ResourceLoader>, ... If the m_pluginView member was zeroed out as a result of making a call into the plug-in, the pluginFunctionCallDepth would be off causing the plug-in never to be stopped. Simplify the code by using a RAII object. * Plugins/WebBaseNetscapePluginStream.mm: (PluginStopDeferrer::PluginStopDeferrer): (PluginStopDeferrer::~PluginStopDeferrer): (WebNetscapePluginStream::startStream): (WebNetscapePluginStream::wantsAllStreams): (WebNetscapePluginStream::destroyStream): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41813 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
- 17 Mar, 2009 7 commits
-
-
darin@apple.com authored
2009-03-17 Darin Adler <darin@apple.com> Reviewed by Adele Peterson. <rdar://problem/6687005> Need support for new move-left/right selectors. * editing/EditorCommand.cpp: (WebCore::executeMoveToLeftEndOfLine): Added. (WebCore::executeMoveToLeftEndOfLineAndModifySelection): Added. (WebCore::executeMoveToRightEndOfLine): Added. (WebCore::executeMoveToRightEndOfLineAndModifySelection): Added. Added command entries for the functions above. WebKit/mac: 2009-03-17 Darin Adler <darin@apple.com> Reviewed by Adele Peterson. <rdar://problem/6687005> Need support for new move-left/right selectors. * WebView/WebHTMLView.mm: Added the four new selectors to the command-forwarding list. * WebView/WebView.mm: Ditto. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41794 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
darin@apple.com authored
Reviewed by Adele Peterson. Bug 24477: REGRESSION (r41467): Page Down key scrolls two pages https://bugs.webkit.org/show_bug.cgi?id=24477 rdar://problem/6674184 * WebView/WebHTMLView.mm: (responderChainRespondsToSelector): Added. (-[WebHTMLView doCommandBySelector:]): Set eventWasHandled based on whether we can find a responder that responds to this selector rather than always assuming the selector will not be handled. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41793 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
mrowe@apple.com authored
* Plugins/Hosted/HostedNetscapePluginStream.mm: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41787 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ddkilzer@apple.com authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41784 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ddkilzer@apple.com authored
Reviewed by Darin Adler. WebKit r30323 added -_webcore_MIMEType to fix issues with incorrect MIME types in NS[HTTP]URLResponse objects. However, uses of -[NSURLResponse MIMEType] still persist in WebKit that should be switched to use -_webcore_MIMEType. Note that -[WebDataSource _responseMIMEType] calls back into WebCore to get the MIME type from the ResourceResponse object, which has already retrieved it via -_webcore_MIMEType. * Plugins/Hosted/HostedNetscapePluginStream.mm: (WebKit::HostedNetscapePluginStream::didReceiveResponse): Use -_webcore_MIMEType. * Plugins/WebBaseNetscapePluginStream.mm: (WebNetscapePluginStream::didReceiveResponse): Ditto. * Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView pluginView:receivedData:]): Ditto. * Plugins/WebPluginController.mm: (-[WebPluginController pluginView:receivedResponse:]): Ditto. * WebView/WebHTMLRepresentation.mm: (-[WebHTMLRepresentation _isDisplayingWebArchive]): Use -[WebDataSource _responseMIMEType] instead. * WebView/WebPDFRepresentation.m: (-[WebPDFRepresentation finishedLoadingWithDataSource:]): Ditto. * WebView/WebPDFView.mm: (-[WebPDFView menuForEvent:]): Ditto. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41783 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
simon.fraser@apple.com authored
Reviewed by Darin Adler https://bugs.webkit.org/show_bug.cgi?id=24396 * config.h: Add WTF_USE_ACCELERATED_COMPOSITING, defined to 0 for now, and add some comments to make the #ifdefs more readable. * css/CSSComputedStyleDeclaration.cpp: (WebCore::computedTransform): Add a comment to mention that we don't flatten the matrix. * css/MediaQueryEvaluator.cpp: (WebCore::transform_3dMediaFeatureEval): Have the 'transform-3d' media query evaluate to 'true' if 3d-rendering is supported. * platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::GraphicsLayerCA::animateTransform): No need for the #ifdef here. If we don't support 3d, we will have already flattened the matrix. * platform/graphics/transforms/TransformationMatrix.cpp: (WebCore::TransformationMatrix::makeAffine): * platform/graphics/transforms/TransformationMatrix.h: New method to convert the matrix to an affine matrix by throwing a way the non-affine parts. * rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateTransform): (WebCore::RenderLayer::currentTransform): * rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::updateLayerTransform): If 3d rendering is not supported, convert the matrix to an affine matrix which can be rendered, and used for hit testing. * rendering/RenderLayerCompositor.cpp: Change the name of the exported symbol that webkitdirs.pm uses to know if 3d rendering is supported. There is no other 3d-rendering-specific symbol we can sniff. * rendering/RenderObject.cpp: (WebCore::RenderObject::transformFromContainer): Only take perspective into account if 3d rendering is supported. * rendering/RenderObject.h: (WebCore::makeMatrixRenderable): Utility method that flattens a matrix if 3d rendering is not supported. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41780 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
kevino@webkit.org authored
Move BUILDING_ON_* defines into Platform.h to make them available to other ports. Also tweak the defines so that they work with the default values set by AvailabilityMacros.h. https://bugs.webkit.org/show_bug.cgi?id=24630 git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41764 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
- 16 Mar, 2009 4 commits
-
-
darin@apple.com authored
2009-03-16 Darin Adler <darin@apple.com> Reviewed by Dan Bernstein. * English.lproj/Localizable.strings: Updated. * StringsNotToBeLocalized.txt: Updated for recent changes. WebKit/mac: 2009-03-16 Darin Adler <darin@apple.com> Reviewed by Dan Bernstein. <rdar://problem/6577174> Rename the text directionality submenus to “Paragraph Direction” and “Selection Direction” * WebCoreSupport/WebViewFactory.mm: (-[WebViewFactory contextMenuItemTagParagraphDirectionMenu]): Changed string here, but only post-Leopard, since we want this to match the Mac OS X menu on Tiger and Leopard. (-[WebViewFactory contextMenuItemTagSelectionDirectionMenu]): Changed string here. WebKit/win: 2009-03-16 Darin Adler <darin@apple.com> Reviewed by Dan Bernstein. <rdar://problem/6577174> Rename the text directionality submenus to “Paragraph Direction” and “Selection Direction” For now, change only the localized strings, not the terminology in the code. * WebCoreLocalizedStrings.cpp: (WebCore::contextMenuItemTagWritingDirectionMenu): Changed string here. (WebCore::contextMenuItemTagTextDirectionMenu): And here. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41750 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
andersca@apple.com authored
Reviewed by Oliver Hunt. Don't mig_deallocate random data in case an instance proxy method returns false. * Plugins/Hosted/NetscapePluginHostProxy.mm: (WKPCEvaluate): (WKPCInvoke): (WKPCInvokeDefault): (WKPCGetProperty): (WKPCEnumerate): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41744 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
andersca@apple.com authored
Reviewed by Oliver Hunt. <rdar://problem/6633944> REGRESSION (Safari 4 PB): Many crashes in Flip4Mac involving loading the plugin Defer loading while calling webPlugInInitialize since it can end up spinning the run loop. * Plugins/WebPluginController.mm: (-[WebPluginController addPlugin:]): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41739 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
andersca@apple.com authored
Reviewed by Sam Weinig. Fix <rdar://problem/6622601> Make sure to update both the window frame and the plug-in frame. * Plugins/Hosted/WebHostedNetscapePluginView.mm: (-[WebHostedNetscapePluginView addWindowObservers]): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41735 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
- 15 Mar, 2009 1 commit
-
-
mitz@apple.com authored
- fix <rdar://problem/6607773> WebKit should support the "Default" paragraph writing direction -- or at least validate the menu item appropriately Made WebHTMLView validate user interface items with the selector -makeBaseWritingDirectionNatural: by returning NO and, if the item is a menu item, setting its state to "off". Strictly speaking, since -makeBaseWritingDirectionNatural: is never valid for WebViews, WebHTMLView should not need to respond to it and validate it, however because other responders respond to all three -makeBaseWritingDirection*: messages and set the menu item state, having WebHTMLView do the same makes application developers' lives easier. * WebView/WebHTMLView.mm: (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]): (-[WebHTMLView makeBaseWritingDirectionNatural:]): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41712 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
- 14 Mar, 2009 1 commit
-
-
mrowe@apple.com authored
architecture. Rubber-stamped by Dan Bernstein. * Configurations/DebugRelease.xcconfig: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41698 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
- 13 Mar, 2009 6 commits
-
-
andersca@apple.com authored
Reviewed by Kevin Decker and Geoffrey Garen. <rdar://problem/6590384> REGRESSION (Safari 3-4): Tiger-only Crash occurs at WebView hostWindow () after reloading a set of tabs then quitting When we're doing fast teardown, plug-in views can be destroyed from -[WebView dealloc]'s [super dealloc] call, and thus calling -[WebView hostWindow] will crash since _private is nil. * WebView/WebView.mm: (-[WebView hostWindow]): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41688 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
andersca@apple.com authored
And yet another attempt... * Plugins/WebNetscapePluginEventHandlerCocoa.h: (WebNetscapePluginEventHandlerCocoa::installKeyEventHandler): (WebNetscapePluginEventHandlerCocoa::removeKeyEventHandler): * Plugins/WebNetscapePluginEventHandlerCocoa.mm: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41681 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
andersca@apple.com authored
Another attempt at fixing the build. * Plugins/WebNetscapePluginEventHandlerCocoa.mm: (WebNetscapePluginEventHandlerCocoa::WebNetscapePluginEventHandlerCocoa): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41680 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
andersca@apple.com authored
Try to fix the SL build. * Plugins/WebNetscapePluginEventHandlerCocoa.h: * Plugins/WebNetscapePluginEventHandlerCocoa.mm: (WebNetscapePluginEventHandlerCocoa::keyDown): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41679 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
bolsinga@apple.com authored
Reviewed by Simon Fraser. Update Geolocation perimission dialogs to be asynchronous. https://bugs.webkit.org/show_bug.cgi?id=24505 WebGeolocation is a wrapper around WebCore::Geolocation. It mimics the coding style set by WebSecurityOrigin. WebChromeClient now calls the private UI delegate method -webView:frame:requestGeolocationPermission:securityOrigin: * WebCoreSupport/WebChromeClient.h: * WebCoreSupport/WebChromeClient.mm: (WebChromeClient::requestGeolocationPermissionForFrame): * WebCoreSupport/WebGeolocation.mm: Added. (WebCore::if): (-[WebGeolocation shouldClearCache]): (-[WebGeolocation setIsAllowed:]): (-[WebGeolocation dealloc]): * WebCoreSupport/WebGeolocationInternal.h: Added. * WebCoreSupport/WebGeolocationPrivate.h: Added. * WebView/WebUIDelegatePrivate.h: 2009-03-13 Greg Bolsinga <bolsinga@apple.com> Reviewed by Simon Fraser. Update Geolocation perimission dialogs to be asynchronous. https://bugs.webkit.org/show_bug.cgi?id=24505 Add WebGeolocation, a wrapper around WebCore::Geolocation. It mimics the coding style set by WebSecurityOrigin. * WebKit.xcodeproj/project.pbxproj: 2009-03-13 Greg Bolsinga <bolsinga@apple.com> Reviewed by Simon Fraser. Update Geolocation perimission dialogs to be asynchronous. https://bugs.webkit.org/show_bug.cgi?id=24505 Geolocation now requests permission from the Chrome asynchronously. The Chrome is passed the Geolocation object, and the Chrome sets the permission on the Geolocation. Geolocation also tracks if the Chrome should clear its cache of SecurityOrigins with geolocation permission. This is so that the GeolocationService can inform the Chrome of its request, and the Chrome is also free to implement its own policy. * WebCore.base.exp: * WebCore.xcodeproj/project.pbxproj: * page/Chrome.cpp: (WebCore::Chrome::requestGeolocationPermissionForFrame): * page/Chrome.h: * page/ChromeClient.h: (WebCore::ChromeClient::requestGeolocationPermissionForFrame): * page/Geolocation.cpp: (WebCore::Geolocation::Geolocation): (WebCore::Geolocation::getCurrentPosition): (WebCore::Geolocation::watchPosition): (WebCore::Geolocation::setIsAllowed): (WebCore::Geolocation::displayChallengeIfNecessary): (WebCore::Geolocation::geolocationServicePositionChanged): * page/Geolocation.h: (WebCore::Geolocation::isAllowed): (WebCore::Geolocation::setShouldClearCache): (WebCore::Geolocation::shouldClearCache): (WebCore::Geolocation::): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41675 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
andersca@apple.com authored
2009-03-13 Anders Carlsson <andersca@apple.com> Reviewed by Dan Bernstein. <rdar://problem/6610666> Revise the Cocoa event model text API Add a NPCocoaEventTextInput event type. Remove the text input variables. * bridge/npapi.h: (_NPCocoaEvent::): WebKit: 2009-03-13 Anders Carlsson <andersca@apple.com> Reviewed by Dan Bernstein. <rdar://problem/6610666> Revise the Cocoa event model text API Remove nptextinput.h * WebKit.xcodeproj/project.pbxproj: WebKit/mac: 2009-03-13 Anders Carlsson <andersca@apple.com> Reviewed by Dan Bernstein. <rdar://problem/6610666> Revise the Cocoa event model text API Replace the text input API with a simpler API that uses a separate text input window. * Plugins/WebNetscapePluginEventHandlerCocoa.h: * Plugins/WebNetscapePluginEventHandlerCocoa.mm: (WebNetscapePluginEventHandlerCocoa::WebNetsc...
-
- 12 Mar, 2009 6 commits
-
-
andersca@apple.com authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41655 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
andersca@apple.com authored
Reviewed by Mike Thole. Fix <rdar://problem/6624105>. Make sure to process incoming messages for the NSEventTrackingRunLoopMode as well. * Plugins/Hosted/NetscapePluginHostProxy.mm: (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41654 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
andersca@apple.com authored
Reviewed by Geoffrey Garen. WebKit side of <rdar://problem/6607801> * Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::destroy): Pass a requestID to _WKPCDestroyPluginInstance and wait until we get a reply back. * Plugins/Hosted/WebKitPluginHost.defs: Add requestID parameter. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41641 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
kdecker@apple.com authored
* Plugins/WebNetscapePluginPackage.mm: (-[WebNetscapePluginPackage _unloadWithShutdown:]): Simply a small SUPPORT_CFM code block. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41635 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
kdecker@apple.com authored
Fixed: <rdar://problem/5815862> Opening a subclassed NSWindow from a Safari plugin causes Safari to crash on Quit This fix addresses crashes in both Silverlight and ChemDraw. This type of crash would occur because AppKit still had a reference to open windows that the plugin created (which no longer exist). * Plugins/WebNetscapePluginPackage.mm: (-[WebNetscapePluginPackage _unloadWithShutdown:]): Do not unload the plug-in bundle on browser shutdown. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41634 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ddkilzer@apple.com authored
Rubber-stamped by Mark Rowe. * WebView/WebView.mm: Remove duplicate #include <runtime/InitializeThreading.h>. Also realphabetized lowercase #include statements. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41614 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
- 11 Mar, 2009 3 commits
-
-
ddkilzer@apple.com authored
Rubber-stamped by Mark Rowe. JavaScriptCore: * Configurations/JavaScriptCore.xcconfig: Added warning about the consequences when FEATURE_DEFINES are not kept in sync. WebCore: * Configurations/WebCore.xcconfig: Added warning about the consequences when FEATURE_DEFINES are not kept in sync. WebKit/mac: * Configurations/WebKit.xcconfig: Added warning about the consequences when FEATURE_DEFINES are not kept in sync. WebKitTools: * Scripts/build-webkit: Added warning about keeping FEATURE_DEFINES in order and the consequences when they are not. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41613 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
andersca@apple.com authored
Reviewed by Sam Weinig. WebKit side of <rdar://problem/6656147>. * Plugins/Hosted/NetscapePluginHostManager.mm: (WebKit::NetscapePluginHostManager::instantiatePlugin): Pass the requestID to _WKPHInstantiatePlugin. * Plugins/Hosted/NetscapePluginHostProxy.mm: Pass the requestID to setCurrentReply. * Plugins/Hosted/NetscapePluginInstanceProxy.h: (WebKit::NetscapePluginInstanceProxy::setCurrentReply): Store the reply in a map with the requestID as the key. (WebKit::NetscapePluginInstanceProxy::waitForReply): Wait for a reply that matches the given requestID. * Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::NetscapePluginInstanceProxy): Initialize member variables. (WebKit::NetscapePluginInstanceProxy::~NetscapePluginInstanceProxy): Delete all requests. (WebKit::NetscapePluginInstanceProxy::print): Pass the requestID to _WKPHPluginInstancePrint. (WebKit::NetscapePluginInstanceProxy::loadRequest): Rename m_currentRequestID to m_currentURLRequestID. (WebKit::NetscapePluginInstanceProxy::processRequestsAndWaitForReply): Process requests until we find a reply with the right requestID. (WebKit::NetscapePluginInstanceProxy::createBindingsInstance): Pass a requestID to the _WKPH function. (WebKit::NetscapePluginInstanceProxy::nextRequestID): Ditto. * Plugins/Hosted/ProxyInstance.mm: Pass a requestID to the _WKPH functions. * Plugins/Hosted/WebKitPluginClient.defs: * Plugins/Hosted/WebKitPluginHost.defs: Add requestID parameters. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41597 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
andersca@apple.com authored
Reviewed by Darin Adler. Fix <rdar://problem/6620064>. * Plugins/WebPluginContainerPrivate.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41592 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
- 10 Mar, 2009 1 commit
-
-
xan@webkit.org authored
2009-03-10 Xan Lopez <xlopez@igalia.com> Build fix, no review. * WebView/WebFrame.mm: (-[WebFrame _smartDeleteRangeForProposedRange:]): WebKit/qt: 2009-03-10 Xan Lopez <xlopez@igalia.com> Build fix, no review. * Api/qwebpage.cpp: (QWebPage::inputMethodQuery): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41557 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
- 09 Mar, 2009 2 commits
-
-
andersca@apple.com authored
Reviewed by Kevin Decker. WebKit side of <rdar://problem/6530007> * Plugins/Hosted/NetscapePluginHostProxy.mm: (WKPCEnumerate): Call NetscapePluginInstanceProxy::enumerate. * Plugins/Hosted/NetscapePluginInstanceProxy.h: * Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::enumerate): Enumerate the JS object and serialize its values. * Plugins/Hosted/ProxyInstance.h: * Plugins/Hosted/ProxyInstance.mm: (WebKit::ProxyInstance::getPropertyNames): Ask the plug-in host to get the property names and deserialize them. * Plugins/Hosted/WebKitPluginClient.defs: * Plugins/Hosted/WebKitPluginHost.defs: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41532 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
simon.fraser@apple.com authored
Reviewed by Oliver Hunt and Cameron Zwarich https://bugs.webkit.org/show_bug.cgi?id=24440 The sublayer added to WebHTMLView to host accelerated compositing layers needs to be a subclass of NSView which allows context menu clicks through. * WebView/WebHTMLView.mm: (-[WebLayerHostingView rightMouseDown:]): (-[WebHTMLView attachRootLayer:]): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41529 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
- 08 Mar, 2009 1 commit
-
-
mrowe@apple.com authored
Frame.h no longer needs to include it. This cuts the size of the symbols for a debug build by around 3%. Reviewed by Oliver Hunt. * dom/Element.cpp: (WebCore::Element::scrollIntoView): (WebCore::Element::scrollIntoViewIfNeeded): * editing/Editor.cpp: (WebCore::Editor::insertTextWithoutSendingTextEvent): (WebCore::Editor::revealSelectionAfterEditingOperation): * editing/SelectionController.cpp: (WebCore::SelectionController::setSelection): * loader/FrameLoader.cpp: (WebCore::FrameLoader::gotoAnchor): * page/ContextMenuController.cpp: (WebCore::ContextMenuController::contextMenuItemSelected): * page/Frame.cpp: (WebCore::Frame::revealSelection): (WebCore::Frame::revealCaret): * page/Frame.h: * rendering/RenderLayer.cpp: (WebCore::RenderLayer::getRectToExpose): (WebCore::RenderLayer::autoscroll): * rendering/RenderLayer.h: * rendering/ScrollBehavior.cpp: Added. (WebCore::): * rendering/ScrollBehavior.h: Added. (WebCore::): (WebCore::ScrollAlignment::getVisibleBehavior): (WebCore::ScrollAlignment::getPartialBehavior): (WebCore::ScrollAlignment::getHiddenBehavior): Add the new files to the build systems: * GNUmakefile.am: * WebCore.base.exp: * WebCore.pro: * WebCore.scons: * WebCore.vcproj/WebCore.vcproj: * WebCore.xcodeproj/project.pbxproj: * WebCoreSources.bkl: Add includes that were previously pulled in by way of RenderLayer.h from Frame.h: * dom/Clipboard.cpp: * editing/EditorCommand.cpp: * editing/InsertLineBreakCommand.cpp: * editing/TypingCommand.cpp: * html/HTMLFormControlElement.cpp: * loader/archive/cf/LegacyWebArchive.cpp: * loader/icon/IconLoader.cpp: * page/animation/AnimationController.cpp: * rendering/RenderSlider.cpp: * rendering/RenderTextControl.cpp: WebKit/mac: * Plugins/WebNetscapePluginView.mm: * WebView/WebFrame.mm: (-[WebFrame _scrollDOMRangeToVisible:]): (-[WebFrame _insertParagraphSeparatorInQuotedContent]): (-[WebFrame _replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]): * WebView/WebHTMLView.mm: (-[WebHTMLView jumpToSelection:]): (-[WebHTMLView centerSelectionInVisibleArea:]): WebKit/win: * WebView.cpp: (WebView::centerSelectionInVisibleArea): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41525 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
- 07 Mar, 2009 1 commit
-
-
mitz@apple.com authored
- fix a bug where debug builds were clearing the HTML5 application cache on application termination * WebView/WebView.mm: (-[WebView _close]): Call -[WebCache setDisabled:YES] instead of -[WebCache empty]. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41512 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
- 06 Mar, 2009 1 commit
-
-
justin.garcia@apple.com authored
2009-03-06 Douglas R. Davidson <ddavidso@apple.com> Reviewed by Justin Garcia. https://bugs.webkit.org/show_bug.cgi?id=24108 Update spelling and grammar checking to use the new combined text checking (with automatic language identification) on Snow Leopard. Tested manually in Mail and Safari; automated tests to come later. * editing/Editor.cpp: (WebCore::findFirstMisspellingOrBadGrammarInRange): (WebCore::Editor::advanceToNextMisspelling): (WebCore::guessesForMisspelledOrUngrammaticalRange): (WebCore::Editor::guessesForMisspelledOrUngrammaticalSelection): (WebCore::Editor::markMisspellingsAfterTypingToPosition): (WebCore::markAllMisspellingsAndBadGrammarInRanges): (WebCore::Editor::markMisspellingsAndBadGrammar): * editing/Editor.h: * loader/EmptyClients.h: (WebCore::EmptyEditorClient::checkSpellingAndGrammarOfParagraph): * page/EditorClient.h: * page/Frame.cpp: (WebCore::Frame::respondToChangedSelection): * platform/ContextMenu.cpp: (WebCore::ContextMenu::populate): WebKit/mac: 2009-03-06 Douglas R. Davidson <ddavidso@apple.com> Reviewed by Justin Garcia. https://bugs.webkit.org/show_bug.cgi?id=24108 Update spelling and grammar checking to use the new combined text checking (with automatic language identification) on Snow Leopard. * WebCoreSupport/WebEditorClient.h: * WebCoreSupport/WebEditorClient.mm: (WebEditorClient::checkSpellingAndGrammarOfParagraph): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41496 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
- 05 Mar, 2009 2 commits
-
-
adele@apple.com authored
Reviewed by Darin Adler. Fix for https://bugs.webkit.org/show_bug.cgi?id=24079 <rdar://problem/6611233> REGRESSION (r39549): Page loads cannot be interrupted with Command-. or Escape <rdar://problem/6636563> Ctrl-tab shortcut doesn't switch tabs when focus is in text field * WebView/WebHTMLView.mm: (-[WebHTMLView doCommandBySelector:]): If WebKit does not support the command, we need to pass the selector to super. In this case, we'll consider the event not to be handled. This is not perfect because in theory, [super doCommandBySelector:] can do some action that would cause WebKit to need to consider the event handled. But in practice, I've found no example of that happening and causing broken behavior. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41467 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
rdar://problem/6206172mrowe@apple.com authored
Reviewed by Dan Bernstein. * WebView/WebHTMLView.mm: (-[WebHTMLView _lookUpInDictionaryFromMenu:]): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41444 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
- 04 Mar, 2009 1 commit
-
-
abarth@webkit.org authored
2009-03-04 Adam Barth <abath@webkit.org> Reviewed by Alexey Proskuryakov. https://bugs.webkit.org/show_bug.cgi?id=24356 Fix WebKit style for allowUniversalAccessFromFileURLs. * WebCore.base.exp: * dom/Document.cpp: (WebCore::Document::initSecurityContext): * page/Settings.cpp: (WebCore::Settings::Settings): (WebCore::Settings::setAllowUniversalAccessFromFileURLs): * page/Settings.h: (WebCore::Settings::allowUniversalAccessFromFileURLs): WebKit/mac: 2009-03-04 Adam Barth <abath@webkit.org> Reviewed by Alexey Proskuryakov. https://bugs.webkit.org/show_bug.cgi?id=24356 Fix WebKit style for allowUniversalAccessFromFileURLs. * WebView/WebPreferenceKeysPrivate.h: * WebView/WebPreferences.mm: (+[WebPreferences initialize]): (-[WebPreferences allowUniversalAccessFromFileURLs]): (-[WebPreferences setAllowUniversalAccessFromFileURLs:]): * WebView/WebPreferencesPrivate.h: * WebView/WebView.mm: (-[WebView _preferencesChangedNotification:]): WebKit/qt: 2009-03-04 Adam Barth <abath@webkit.org> Reviewed by Alexey Proskuryakov. https://bugs.webkit.org/show_bug.cgi?id=24356 Fix WebKit style for allowUniversalAccessFromFileURLs. * Api/qwebsettings.cpp: (QWebSettingsPrivate::apply): WebKit/win: 2009-03-04 Adam Barth <abath@webkit.org> Reviewed by Alexey Proskuryakov. https://bugs.webkit.org/show_bug.cgi?id=24356 Fix WebKit style for allowUniversalAccessFromFileURLs. * Interfaces/IWebPreferencesPrivate.idl: * WebPreferenceKeysPrivate.h: * WebPreferences.cpp: (WebPreferences::initializeDefaultSettings): (WebPreferences::allowUniversalAccessFromFileURLs): (WebPreferences::setAllowUniversalAccessFromFileURLs): * WebPreferences.h: * WebView.cpp: (WebView::notifyPreferencesChanged): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41426 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
- 03 Mar, 2009 1 commit
-
-
rdar://problem/6581203ddkilzer@apple.com authored
<rdar://problem/6581203> WebCore and WebKit should install the same set of headers during installhdrs phase as build phase Reviewed by Mark Rowe. JavaScriptCore: * Configurations/Base.xcconfig: Defined REAL_PLATFORM_NAME based on PLATFORM_NAME to work around the missing definition on Tiger. Updated HAVE_DTRACE to use REAL_PLATFORM_NAME. WebCore: The fix is to add INSTALLHDRS_COPY_PHASE = YES and INSTALLHDRS_SCRIPT_PHASE = YES to WebCore.xcconfig, then to make sure various build phase scripts work with the installhdrs build phase. * Configurations/Base.xcconfig: Defined REAL_PLATFORM_NAME based on PLATFORM_NAME to work around the missing definition on Tiger. * Configurations/WebCore.xcconfig: Added JAVASCRIPTCORE_PRIVATE_HEADERS_DIR variable to simplify logic in the "Generate Derived Sources" script. Added INSTALLHDRS_COPY_PHASE = YES and INSTALLHDRS_SCRIPT_PHASE = YES. ...
-