Skip to content
GitLab
Switch branch/tag
  1. 18 Mar, 2009 16 commits
  3. 17 Mar, 2009 24 commits
    • mrowe@apple.com's avatar
      Use the normal search rules for tests inside the platform directory. · b6e00be5
      mrowe@apple.com authored 
      Reviewed by Oliver Hunt.

This allows tests inside the platform directory to have different results
on different versions of Mac OS X.

* Scripts/run-webkit-tests:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41804 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b6e00be5
    • mrowe@apple.com's avatar
      Update layout test to avoid depending on formatting of -[NSAttributedString description]. · 18d6aa98
      mrowe@apple.com authored 
      Rubber-stamped by Dan Bernstein.

The attributes aren't important to the test.

* platform/mac/fast/text/attributed-substring-from-range-001-expected.txt:
* platform/mac/fast/text/attributed-substring-from-range-001.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41803 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      18d6aa98
    • mrowe@apple.com's avatar
      Land updated results for tests involving Geeza Pro. · a44f9da2
      mrowe@apple.com authored 
      Rubber-stamped by Dan Bernstein.

* platform/mac-leopard/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.checksum: Renamed from LayoutTests/platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.checksum.
* platform/mac-leopard/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.png: Renamed from LayoutTests/platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.png.
* platform/mac-leopard/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.txt: Copied from LayoutTests/platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.txt.
* platform/mac-leopard/fast/text/international/bidi-AN-after-L-expected.checksum: Renamed from LayoutTests/platform/mac/fast/text/international/bidi-AN-after-L-expected.checksum.
* platform/mac-leopard/fast/text/international/bidi-AN-after-L-expected.png: Renamed from LayoutTests/platform/mac/fast/text/international/bidi-AN-after-L-expected.png.
* platform/mac-leopard/fast/text/international/bidi-AN-after-L-expected.txt: Copied from LayoutTests/platform/mac/fast/text/international/bidi-AN-after-L-expected.txt.
* platform/mac-leopard/fast/text/international/bidi-AN-after-empty-run-expected.checksum: Renamed from LayoutTests/platform/mac/fast/text/international/bidi-AN-after-empty-run-expected.checksum.
* platform/mac-leopard/fast/text/international/bidi-AN-after-empty-run-expected.png: Renamed from LayoutTests/platform/mac/fast/text/international/bidi-AN-after-empty-run-expected.png.
* platform/mac-leopard/fast/text/international/bidi-AN-after-empty-run-expected.txt: Copied from LayoutTests/platform/mac/fast/text/international/bidi-AN-after-empty-run-expected.txt.
* platform/mac-leopard/fast/text/international/bidi-CS-after-AN-expected.checksum: Renamed from LayoutTests/platform/mac/fast/text/international/bidi-CS-after-AN-expected.checksum.
* platform/mac-leopard/fast/text/international/bidi-CS-after-AN-expected.png: Renamed from LayoutTests/platform/mac/fast/text/international/bidi-CS-after-AN-expected.png.
* platform/mac-leopard/fast/text/international/bidi-CS-after-AN-expected.txt: Copied from LayoutTests/platform/mac/fast/text/international/bidi-CS-after-AN-expected.txt.
* platform/mac-leopard/fast/text/international/bidi-neutral-run-expected.checksum: Renamed from LayoutTests/platform/mac/fast/text/international/bidi-neutral-run-expected.checksum.
* platform/mac-leopard/fast/text/international/bidi-neutral-run-expected.png: Renamed from LayoutTests/platform/mac/fast/text/international/bidi-neutral-run-expected.png.
* platform/mac-leopard/fast/text/international/bidi-neutral-run-expected.txt: Copied from LayoutTests/platform/mac/fast/text/international/bidi-neutral-run-expected.txt.
* platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.txt:
* platform/mac/fast/text/international/bidi-AN-after-L-expected.txt:
* platform/mac/fast/text/international/bidi-AN-after-empty-run-expected.txt:
* platform/mac/fast/text/international/bidi-CS-after-AN-expected.txt:
* platform/mac/fast/text/international/bidi-neutral-run-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41802 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a44f9da2
    • mrowe@apple.com's avatar
      Move the results out of platform/mac since they're a cross-platform progression, · 8ef857c5
      mrowe@apple.com authored 
      and non-Mac platforms are already skipping the tests.

Rubber-stamped by Dan Bernstein.

* fast/dom/Window/window-properties-expected.txt:
* fast/dom/navigator-detached-no-crash-expected.txt:
* platform/mac/fast/dom/Window/window-properties-expected.txt: Removed.
* platform/mac/fast/dom/navigator-detached-no-crash-expected.txt: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41801 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8ef857c5
    • mrowe@apple.com's avatar
      Update layout test results now that the test passes. · 9237ae74
      mrowe@apple.com authored 
      Rubber-stamped by Sam Weinig.

* fast/xsl/mozilla-tests-expected.txt:
* platform/mac-leopard/fast/xsl/mozilla-tests-expected.txt: Copied from LayoutTests/fast/xsl/mozilla-tests-expected.txt.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41800 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9237ae74
    • mrowe@apple.com's avatar
      Add platform-specific layout test results to accommodate geolocation. · 8a236fe5
      mrowe@apple.com authored 
      Reviewed by Sam Weinig.

* platform/mac-leopard/fast/dom/Window/window-properties-expected.txt: Copied from LayoutTests/fast/dom/Window/window-properties-expected.txt.
* platform/mac-leopard/fast/dom/navigator-detached-no-crash-expected.txt: Copied from LayoutTests/fast/dom/navigator-detached-no-crash-expected.txt.
* platform/mac/fast/dom/Window/window-properties-expected.txt: Copied from LayoutTests/fast/dom/Window/window-properties-expected.txt.
* platform/mac/fast/dom/navigator-detached-no-crash-expected.txt: Copied from LayoutTests/fast/dom/navigator-detached-no-crash-expected.txt.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41799 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8a236fe5
    • mrowe@apple.com's avatar
      Remove geolocation-not-implemented.html. · 448b635a
      mrowe@apple.com authored 
      Reviewed by Sam Weinig.

* geolocation/geolocation-not-implemented-expected.txt: Removed.
* geolocation/geolocation-not-implemented.html: Removed.
* geolocation/geolocation-test.js: Removed.
* platform/gtk/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41798 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      448b635a
    • mrowe@apple.com's avatar
      Update layout test results to accommodate the updated Unicode text segmentation rules. · 9ab85a3e
      mrowe@apple.com authored 
      Rubber-stamped by Sam Weinig.

* platform/mac-leopard/css1/text_properties/text_transform-expected.checksum: Renamed from LayoutTests/platform/mac/css1/text_properties/text_transform-expected.checksum.
* platform/mac-leopard/css1/text_properties/text_transform-expected.png: Renamed from LayoutTests/platform/mac/css1/text_properties/text_transform-expected.png.
* platform/mac-leopard/css1/text_properties/text_transform-expected.txt: Copied from LayoutTests/platform/mac/css1/text_properties/text_transform-expected.txt.
* platform/mac-leopard/css2.1/t1605-c545-txttrans-00-b-ag-expected.checksum: Renamed from LayoutTests/platform/mac/css2.1/t1605-c545-txttrans-00-b-ag-expected.checksum.
* platform/mac-leopard/css2.1/t1605-c545-txttrans-00-b-ag-expected.png: Renamed from LayoutTests/platform/mac/css2.1/t1605-c545-txttrans-00-b-ag-expected.png.
* platform/mac-leopard/css2.1/t1605-c545-txttrans-00-b-ag-expected.txt: Copied from LayoutTests/platform/mac/css2.1/t1605-c545-txttrans-00-b-ag-expected.txt.
* platform/mac/css1/text_properties/text_transform-expected.txt:
* platform/mac/css2.1/t1605-c545-txttrans-00-b-ag-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41797 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9ab85a3e
    • ddkilzer@apple.com's avatar
      2009-03-17 David Carson <dacarson@apple.com> · d8e4e16e
      ddkilzer@apple.com authored 
              Reviewed by David Hyatt.

        Add anchor elements to the simple style sheet so that applications that
        are using WebKit just for simple text and links will also take advantage
        of the fast path.

        * css/CSSStyleSelector.cpp:
        (WebCore::elementCanUseSimpleDefaultStyle):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41796 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d8e4e16e
    • ddkilzer@apple.com's avatar
      resolve-ChangeLogs should not die on unmerged non-ChangeLog files · b42e95fb
      ddkilzer@apple.com authored 
              Reviewed by Adam Roben.

        Fixes the following bug in resolve-ChangeLogs:

            Use of uninitialized value in -e at ./WebKitTools/Scripts/resolve-ChangeLogs line 132.
            Died at ./WebKitTools/Scripts/resolve-ChangeLogs line 164.

        * Scripts/resolve-ChangeLogs:
        (findUnmergedChangeLogs): Check the result of findChangeLog() to
        make sure we don't add undef values to the list of files being
        returned.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41795 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b42e95fb
    • darin@apple.com's avatar
      WebCore: · 741e6e19
      darin@apple.com authored 
      2009-03-17  Darin Adler  <darin@apple.com>

        Reviewed by Adele Peterson.

        <rdar://problem/6687005> Need support for new move-left/right selectors.

        * editing/EditorCommand.cpp:
        (WebCore::executeMoveToLeftEndOfLine): Added.
        (WebCore::executeMoveToLeftEndOfLineAndModifySelection): Added.
        (WebCore::executeMoveToRightEndOfLine): Added.
        (WebCore::executeMoveToRightEndOfLineAndModifySelection): Added.
        Added command entries for the functions above.

WebKit/mac:

2009-03-17  Darin Adler  <darin@apple.com>

        Reviewed by Adele Peterson.

        <rdar://problem/6687005> Need support for new move-left/right selectors.

        * WebView/WebHTMLView.mm: Added the four new selectors to the command-forwarding list.
        * WebView/WebView.mm: Ditto.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41794 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      741e6e19
    • darin@apple.com's avatar
      2009-03-17 Darin Adler <darin@apple.com> · 30ec13c9
      darin@apple.com authored 
              Reviewed by Adele Peterson.

        Bug 24477: REGRESSION (r41467): Page Down key scrolls two pages
        https://bugs.webkit.org/show_bug.cgi?id=24477
        rdar://problem/6674184

        * WebView/WebHTMLView.mm:
        (responderChainRespondsToSelector): Added.
        (-[WebHTMLView doCommandBySelector:]): Set eventWasHandled based on whether we
        can find a responder that responds to this selector rather than always assuming
        the selector will not be handled.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41793 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      30ec13c9
    • eric@webkit.org's avatar
      2009-03-17 Ojan Vafai <ojan@chromium.org> · d2bb5a0a
      eric@webkit.org authored 
              Reviewed by Adele Peterson.

        Put the padding inside scrollbars on textareas.
        https://bugs.webkit.org/show_bug.cgi?id=24370

        Put the padding inside the scrollbars on textareas. This is done by moving the
        overflow from the shadowNode to the RenderTextControlMultiline. As a result,
        all of the scroll handing methods that RenderTextControl overrides can be moved
        down into RenderTextControlSingleLine since RenderTextControlMultiline can now
        just use RenderBlock's versions. This also allows RenderTextControlMultiLine to
        no longer need a custom layout method since the shadowNode can now just size
        like a regular DIV.

        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::adjustRenderStyle):
        * rendering/RenderTextControl.cpp:
        (WebCore::RenderTextControl::styleDidChange):
        (WebCore::RenderTextControl::selection):
        (WebCore::RenderTextControl::calcHeight):
        (WebCore::RenderTextControl::hitInnerTextElement):
        * rendering/RenderTextControl.h:
        * rendering/RenderTextControlMultiLine.cpp:
        (WebCore::RenderTextControlMultiLine::nodeAtPoint):
        (WebCore::RenderTextControlMultiLine::createInnerTextStyle):
        * rendering/RenderTextControlMultiLine.h:
        * rendering/RenderTextControlSingleLine.cpp:
        (WebCore::RenderTextControlSingleLine::styleDidChange):
        (WebCore::RenderTextControlSingleLine::autoscroll):
        (WebCore::RenderTextControlSingleLine::scrollWidth):
        (WebCore::RenderTextControlSingleLine::scrollHeight):
        (WebCore::RenderTextControlSingleLine::scrollLeft):
        (WebCore::RenderTextControlSingleLine::scrollTop):
        (WebCore::RenderTextControlSingleLine::setScrollLeft):
        (WebCore::RenderTextControlSingleLine::setScrollTop):
        (WebCore::RenderTextControlSingleLine::scroll):
        * rendering/RenderTextControlSingleLine.h:
        * rendering/TextControlInnerElements.cpp:
        (WebCore::RenderTextControlInnerBlock::RenderTextControlInnerBlock):
        (WebCore::RenderTextControlInnerBlock::positionForPoint):
        (WebCore::TextControlInnerTextElement::createRenderer):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41792 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d2bb5a0a
    • darin@apple.com's avatar
      2009-03-17 Darin Adler <darin@apple.com> · d551e2fb
      darin@apple.com authored 
              Reviewed by David Hyatt.

        Bug 24517: REGRESSION (r41552): innerHTML does an updateLayout -- unneeded and can be slow
        https://bugs.webkit.org/show_bug.cgi?id=24517

        * editing/DeleteButtonController.cpp:
        (WebCore::DeleteButtonController::enable): Added a call to updateRendering, since
        determining whether to display the delete button involves style and updateRendering
        also updates style (should probably be named updateStyle, in fact). Not needed to fix
        this bug, but would have prevented the crash that led to this bug in the first place.

        * editing/EditCommand.cpp:
        (WebCore::EditCommand::EditCommand): Get rid of unneeded null check. All frames have
        delete button controllers.
        * editing/Editor.cpp:
        (WebCore::Editor::rangeForPoint): Ditto.

        * editing/markup.cpp:
        (WebCore::appendStartMarkup): Changed a "&" to a "&&" so that generating markup
        doesn't depend on renderers at all when the convertBlocksToInlines boolean is false.
        This allows us to omit the call to updateLayoutIgnorePendingStylesheets in the
        createMarkup function that's called by innerHTML.
        (WebCore::MarkupAccumulator::appendMarkup): Turned this into a class with a member
        function. Added a feature where the accumulator will skip a node. Moved arguments
        that don't change during recursion into an object. This function still is a bit
        inefficient, since it creates a new HashMap at every level as it recurses, but for now
        I did not tackle that. Also replaced the onlyIncludeChildren boolean with EChildrenOnly
        for consistency and clarity.
        (WebCore::createMarkup): Removed the call to updateLayoutIgnorePendingStylesheets.
        Instead of calling disable/enable on the delete button controller's container element,
        pass it in to the markup accumulator as a node to skip.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41791 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d551e2fb
    • kov@webkit.org's avatar
      2009-03-17 Gustavo Noronha Silva <gns@gnome.org> · c71ca11a
      kov@webkit.org authored 
              Reviewed by Simon Fraser.

        Fix the usage of the $architecture variable for non-Apple-Mac
        ports.

        * Scripts/webkitdirs.pm:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41790 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c71ca11a
    • eric@webkit.org's avatar
      2009-03-17 Scott Violet <sky@google.com> · 0ba58880
      eric@webkit.org authored 
              Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=24651
        Skia does not always render text fill/stroke pattern/gradient/color correctly

        Changes Skia's font rendering to only render gradient/pattern if current
        color space indicates the gradient/pattern should be used.
        This is covered by LayoutTests/fast/canvas/canvas-text-alignment.html .

        * platform/graphics/GraphicsContext.cpp:
        (WebCore::GraphicsContext::strokeColorSpace):
        (WebCore::GraphicsContext::fillColorSpace):
        * platform/graphics/GraphicsContext.h:
        (WebCore::):
        * platform/graphics/GraphicsContextPrivate.h:
        * platform/graphics/skia/SkiaFontWin.cpp:
        (WebCore::paintSkiaText):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41789 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0ba58880
    • adele@apple.com's avatar
      WebCore: · 0677d680
      adele@apple.com authored 
      2009-03-17  Adele Peterson  <adele@apple.com>

        Reviewed by Darin Adler.

        Fix for https://bugs.webkit.org/show_bug.cgi?id=24655
        <rdar://problem/6633727> Hitting return at the end of a line with an anchor jumps me to the bottom of the message

        Test: editing/inserting/6633727.html

        This changes does a few things:
        1) Renames pos to insertionPosition.
        2) Eliminates "startNode".  It doesn't work well to consider the node separately from the insertionPosition.  
           The insertionPosition gets updated at various times, and it seems likely that startNode can get out of sync.
        3) Before building up a list of ancestors to move around when we insert the new block, make sure to use the deepest
           representation of the insertionPosition, so all ancestor nodes are correctly included.

        * editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::doApply):

LayoutTests:

2009-03-17  Adele Peterson  <adele@apple.com>

        Reviewed by Darin Adler.

        Test for https://bugs.webkit.org/show_bug.cgi?id=24655
        <rdar://problem/6633727> Hitting return at the end of a line with an anchor jumps me to the bottom of the message

        * editing/inserting/6633727.html: Added.
        * platform/mac/editing/inserting/6633727-expected.checksum: Added.
        * platform/mac/editing/inserting/6633727-expected.png: Added.
        * platform/mac/editing/inserting/6633727-expected.txt: Added.

        Updated results.  The behavior for these tests doesn't change, but the render tree is slightly different.

        * platform/mac/editing/inserting/insert-div-021-expected.txt:
        * platform/mac/editing/style/block-styles-007-expected.txt:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41788 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0677d680
    • mrowe@apple.com's avatar
      Fix the build. · 496d3973
      mrowe@apple.com authored 
      * Plugins/Hosted/HostedNetscapePluginStream.mm:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41787 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      496d3973
    • kevino@webkit.org's avatar
      Reviewed by Kevin Ollivier. · 21ea7a4c
      kevino@webkit.org authored 
      https://bugs.webkit.org/show_bug.cgi?id=24115
Introduce platform independent stubs for plugins.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41786 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      21ea7a4c
    • ddkilzer@apple.com's avatar
      Bug 24645: bisect-builds script doesn't work with Safari 4 Public Beta (version string) · f9f96aa7
      ddkilzer@apple.com authored 
              <https://bugs.webkit.org/show_bug.cgi?id=24645>

        Reviewed by Mark Rowe.

        * Scripts/bisect-builds:
        (makeNightlyList): Added checks for Safari 4 Public Beta on
        Tiger and Leopard.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41785 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f9f96aa7
    • ddkilzer@apple.com's avatar
      Fixed ChangeLog date. · 66895d05
      ddkilzer@apple.com authored 
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41784 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      66895d05
    • ddkilzer@apple.com's avatar
      Use -[NSURLResponse(WebCoreURLResponse) _webcore_MIMEType] consistently · ce5672e8
      ddkilzer@apple.com authored 
              Reviewed by Darin Adler.

        WebKit r30323 added -_webcore_MIMEType to fix issues with
        incorrect MIME types in NS[HTTP]URLResponse objects.  However,
        uses of -[NSURLResponse MIMEType] still persist in WebKit that
        should be switched to use -_webcore_MIMEType.  Note that
        -[WebDataSource _responseMIMEType] calls back into WebCore to
        get the MIME type from the ResourceResponse object, which has
        already retrieved it via -_webcore_MIMEType.

        * Plugins/Hosted/HostedNetscapePluginStream.mm:
        (WebKit::HostedNetscapePluginStream::didReceiveResponse): Use
        -_webcore_MIMEType.
        * Plugins/WebBaseNetscapePluginStream.mm:
        (WebNetscapePluginStream::didReceiveResponse): Ditto.
        * Plugins/WebNetscapePluginView.mm:
        (-[WebNetscapePluginView pluginView:receivedData:]): Ditto.
        * Plugins/WebPluginController.mm:
        (-[WebPluginController pluginView:receivedResponse:]): Ditto.
        * WebView/WebHTMLRepresentation.mm:
        (-[WebHTMLRepresentation _isDisplayingWebArchive]): Use
        -[WebDataSource _responseMIMEType] instead.
        * WebView/WebPDFRepresentation.m:
        (-[WebPDFRepresentation finishedLoadingWithDataSource:]): Ditto.
        * WebView/WebPDFView.mm:
        (-[WebPDFView menuForEvent:]): Ditto.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41783 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ce5672e8
    • simon.fraser@apple.com's avatar
      2009-03-17 Simon Fraser <simon.fraser@apple.com> · 6b59a909
      simon.fraser@apple.com authored 
              Reviewed by Dave Hyatt

        https://bugs.webkit.org/show_bug.cgi?id=24632

        Fix repaint issues when composited layers come and go (only applies
        when ACCELERATED_COMPOSITING is turned on).

        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::RenderLayer):
        * rendering/RenderLayer.h:
        (WebCore::RenderLayer::mustOverlayCompositedLayers):
        (WebCore::RenderLayer::setMustOverlayCompositedLayers):
        * rendering/RenderLayerBacking.cpp:
        (WebCore::RenderLayerBacking::RenderLayerBacking):
        * rendering/RenderLayerBacking.h:

        Move what used to be the 'forceCompositingLayer' flag from RenderLayerBacking
        to RenderLayer, because we don't want the side-effects of creating RenderLayerBacking
        when setting this flag.

        * rendering/RenderLayerCompositor.cpp:
        (WebCore::RenderLayerCompositor::updateLayerCompositingState):
        When a RenderLayer flips into or out of compositing mode, compute a repaint
        rect relative to the containerForRepaint, and repaint it.

        (WebCore::RenderLayerCompositor::computeCompositingRequirements):
        Call layer->setMustOverlayCompositedLayers() rather than setForcedCompositingLayer().

        (WebCore::RenderLayerCompositor::needsToBeComposited):
        (WebCore::RenderLayerCompositor::requiresCompositingLayer):
        (WebCore::RenderLayerCompositor::requiresCompositingForTransform):
        (WebCore::RenderLayerCompositor::requiresCompositingForAnimation):
        * rendering/RenderLayerCompositor.h:

        Rename requiresCompositingLayerForTransform() to requiresCompositingForTransform()
        and make it a class static method to match requiresCompositingForAnimation(). Both
        now take RenderObjects, rathern than RenderLayers.

        * rendering/style/RenderStyle.h:
        (WebCore::InheritedFlags::hasTransformRelatedProperty):
        Minor tidyup using convenience methods added in an earlier commit.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41782 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6b59a909
    • darin@apple.com's avatar
      2009-03-17 Darin Adler <darin@apple.com> · 91317b53
      darin@apple.com authored 
              Earlier version reviewed by Adele Peterson.

        Bug 24304: REGRESSION (r39864): Hitting the space bar to select an <input type=radio>
        or push an <input type=button> or <button> causes the page to scroll down.

        Would be best to add a regression test for Windows eventually; tested that this has
        no effect on the Mac OS X platform.

        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::defaultEventHandler): Added FIXMEs and tweaked formatting.
        Use the code that calls the base class's defaultEventHandler early only in the cases
        where it's needed: keydown and keypress events in text fields. In other cases, do the
        more typical thing and call the default handler only at the end of the function.
        This function already had code to make sure the keypress event for space never gets
        through, but it was running too late since the scrolling code was moved into the
        base class d...
      91317b53