1. 18 Jun, 2013 7 commits
  2. 17 Jun, 2013 31 commits
    • bfulgham@apple.com's avatar
      [Windows] Unreviewed AX gardening of windows-specific results. · 52727a4f
      bfulgham@apple.com authored
      * platform/win/accessibility/aria-combobox-expected.txt: Added.
      * platform/win/aria-labelledby-on-input-expected.txt: Added.
      * platform/win/aria-menubar-menuitems-expected.txt: Added.
      * platform/win/aria-roles-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@151667 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      52727a4f
    • commit-queue@webkit.org's avatar
      [EFL] Remove unneeded WebCore namespace in FrameLoaderClientEfl · 6775b089
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=117718
      
      Patch by Seokju Kwon <seokju.kwon@gmail.com> on 2013-06-17
      Reviewed by Christophe Dumez.
      
      * WebCoreSupport/FrameLoaderClientEfl.cpp: Remove 'using namespace WebCore'.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@151666 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6775b089
    • bfulgham@apple.com's avatar
      AX: Correct accessibility role when -webkit-box:display is used. · 835c496d
      bfulgham@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=117706
      
      Reviewed by Chris Fleizach.
      
      Source/WebCore: 
      
      accessibility/box-styled-lists.html
      
      * accessibility/AccessibilityRenderObject.cpp:
      (WebCore::AccessibilityRenderObject::determineAccessibilityRole): If HTML token is
      of the list element type, treat it as a ListItemRole accessibility role, regardless
      of what specific renderer is being used.
      
      LayoutTests: 
      
      * accessibility/box-styled-lists.html: Added.
      * platform/efl/TestExpectations:
      * platform/gtk/TestExpectations:
      * platform/mac/accessibility/box-styled-lists-expected.txt: Added.
      * platform/win/TestExpectations:
      * platform/win/accessibility/box-styled-lists-expected.txt: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@151665 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      835c496d
    • rniwa@webkit.org's avatar
      Mac rebaseline. · abb1e156
      rniwa@webkit.org authored
      * fast/repaint/table-cell-collapsed-border-scroll-expected.png:
      * fast/repaint/table-cell-collapsed-border-scroll-expected.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@151664 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      abb1e156
    • rniwa@webkit.org's avatar
      Initialize AtomicStringTable in WTFThreadData's constructor · e32f3e7d
      rniwa@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=117671
      
      Reviewed by Geoffrey Garen.
      
      Extracted AtomicStringTable from AtomicString.cpp into AtomicStringTable.h/cpp
      and made WTFThreadDada::WTFThreadData create the atomic string table for the thread.
      
      This eliminates a branch from stringTable() in AtomicString.cpp.
      
      * GNUmakefile.list.am:
      * WTF.pro:
      * WTF.vcxproj/WTF.vcxproj:
      * WTF.vcxproj/WTF.vcxproj.filters:
      * WTF.xcodeproj/project.pbxproj:
      * wtf/CMakeLists.txt:
      * wtf/WTFThreadData.cpp:
      (WTF::WTFThreadData::WTFThreadData):
      * wtf/text/AtomicString.cpp:
      (WTF::stringTable):
      * wtf/text/AtomicStringTable.cpp: Added.
      (WTF::AtomicStringTable::create):
      (WTF::AtomicStringTable::destroy):
      * wtf/text/AtomicStringTable.h: Added.
      (WTF::AtomicStringTable::table):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@151663 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e32f3e7d
    • roger_fong@apple.com's avatar
      Add some UNUSED_PARAMs to RenderBlock.cpp so that it builds properly if CSS_EXCLUSIONS is disabled. · 30756939
      roger_fong@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=117722.
      Rubberstamped by Jon Lee.
      * rendering/RenderBlock.cpp:
      (WebCore::RenderBlock::updateRegionsAndExclusionsAfterChildLayout):
      (WebCore::RenderBlock::logicalLeftOffsetForLine):
      (WebCore::RenderBlock::logicalRightOffsetForLine):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@151662 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      30756939
    • bdakin@apple.com's avatar
      PageBanners appear over HTML5 video when media element is in full screen mode · 9f7cd09a
      bdakin@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=117721
      -and corresponding-
      <rdar://problem/13686998>
      
      Reviewed by Sam Weinig.
      
      Source/WebCore: 
      
      Update the scrolling tree when a header/footer has been removed.
      * rendering/RenderLayerCompositor.cpp:
      (WebCore::RenderLayerCompositor::updateLayerForHeader):
      (WebCore::RenderLayerCompositor::updateLayerForFooter):
      
      Source/WebKit2: 
      
      When an element enters fullscreen, hide the banners. Show them again when the 
      element exits fullscreen.
      * WebProcess/FullScreen/WebFullScreenManager.cpp:
      (WebKit::WebFullScreenManager::willEnterFullScreen):
      (WebKit::WebFullScreenManager::willExitFullScreen):
      
      Handle hiding and showing by removing or re-creating a parent layer for m_layer.
      * WebProcess/WebPage/PageBanner.cpp:
      (WebKit::PageBanner::hide):
      (WebKit::PageBanner::showIfHidden):
      * WebProcess/WebPage/PageBanner.h:
      * WebProcess/WebPage/mac/PageBannerMac.mm:
      (WebKit::PageBanner::PageBanner):
      (WebKit::PageBanner::hide):
      (WebKit::PageBanner::showIfHidden):
      (WebKit::PageBanner::mouseEvent):
      * WebProcess/WebPage/WebPage.cpp:
      (WebKit::WebPage::hidePageBanners):
      (WebKit::WebPage::showPageBanners):
      * WebProcess/WebPage/WebPage.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@151661 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9f7cd09a
    • roger_fong@apple.com's avatar
      Modify Windows makefiles to copy some bin output into Program Files. · 030574bc
      roger_fong@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=117714.
      <rdar://problem/14179054>
      
      Reviewed by Brent Fulgham.
      
      * WTF.vcxproj/WTF.make:
      * JavaScriptCore.vcxproj/JavaScriptCore.make:
      * WebCore.vcxproj/WebCore.make:
      * WebKit.vcxproj/WebKit.make:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@151660 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      030574bc
    • mvujovic@adobe.com's avatar
      Crash in loadPendingShaders · 15396b38
      mvujovic@adobe.com authored
      https://bugs.webkit.org/show_bug.cgi?id=117665
      
      Reviewed by Dean Jackson.
      
      Speculative fix because the crash reports do not contain a test case.
      
      Rearrange the conditions to check m_state.hasPendingShaders() first. Additionally, check if
      m_state.style() is non-null.
      
      No new tests. We don't know how to reproduce this crash yet.
      
      * css/StyleResolver.cpp:
      (WebCore::StyleResolver::loadPendingShaders):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@151657 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      15396b38
    • commit-queue@webkit.org's avatar
      REGRESSION: Important controls are missing from <video> element UI, when compared to QuickTime · bfadee5c
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=20599
      
      Add a "Download Video"/"Download Audio" context menu item to download media
      elements.
      
      Patch by Ruth Fong <ruth_fong@apple.com> on 2013-06-17
      Reviewed by Beth Dakin.
      
      Source/WebCore:
      
      No new tests. media/context-menu-action.html,
      which has been disabled by bug 116651, is used to test context menus.
      
      * English.lproj/Localizable.strings: Updated to
      include localizable strings for "Download Video" and "Download Audio".
      
      * page/ContextMenuController.cpp: Updated to
      include and handle a "Download Video/Audio" context menu item.
      
      * platform/ContextMenuItem.h:
      
      * platform/LocalizedStrings.cpp:
      * platform/LocalizedStrings.h:
      * platform/efl/LocalizedStringsEfl.cpp:
      * platform/gtk/LocalizedStringsGtk.cpp:
      * platform/qt/LocalizedStringsQt.cpp:
      Updated to include localizable strings for "Download Video" and "Download Audio".
      
      Source/WebKit/efl:
      
      * WebCoreSupport/AssertMatchingEnums.cpp:
      * ewk/ewk_contextmenu.h:
      Updated to include new EWK enum type for "Download Video/Audio" context menu item.
      
      Source/WebKit2:
      
      * Shared/API/c/WKContextMenuItemTypes.h: Updated to include
      an enum type for the "Download Video/Audio" context menu item.
      
      * Shared/API/c/WKSharedAPICast.h: Updated to associate
      the enums in WebKit and WebCore that handle the "Download Video/Audio"
      context menu item.
      
      * UIProcess/API/efl/ewk_context_menu.cpp:
      * UIProcess/API/efl/ewk_context_menu_item.cpp:
      * UIProcess/API/efl/ewk_context_menu_item.h:
      Updated to include new EWK enum type for "Download Video/Audio" context menu item.
      
      * UIProcess/WebPageProxy.cpp: Updated to
      handle the "Download Video/Audio" context menu item mouse click
      and download the media item in the UI process.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@151656 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bfadee5c
    • commit-queue@webkit.org's avatar
      [CoordinatedGraphics][CSS Shaders] Use forwarding header for TextureMapperPlatformCompiledProgram.h · aeefa61e
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=117712
      
      Patch by Ralph Thomas <ralpht@gmail.com> on 2013-06-17
      Reviewed by Noam Rosenthal.
      
      * Shared/CoordinatedGraphics/WebCustomFilterProgramProxy.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@151653 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      aeefa61e
    • zoltan@webkit.org's avatar
      [CSS Shapes] Consider bottom borders when calculating the position of the overflow · 3a337baa
      zoltan@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=117663
      
      Reviewed by Alexandru Chiculita.
      
      When you have a shape and the content overflows from the shape we need to push the overflow below the content box,
      not below the border box. We didn't consider the bottom borders of the content box, now I fixed it too and the overflow
      just starts after the content box. I added a new helper function called pushShapeContentOverflowBelowTheContentBox. Now
      both the shape in flow thread and the shape overflow use the same function. I added a new test and modified the existing
      tests to cover all the affected cases.
      
      Source/WebCore:
      
      Test: fast/exclusions/shape-inside/shape-inside-overflow-fixed-dimensions-block-content.html
      Existing overflow tests also modified to test the behavior:
            fast/exclusions/shape-inside/shape-inside-empty-expected.html
            fast/exclusions/shape-inside/shape-inside-overflow-fixed-dimensions-block-content-expected.html
            fast/exclusions/shape-inside/shape-inside-overflow-fixed-dimensions-block-content.html
            fast/exclusions/shape-inside/shape-inside-overflow-fixed-dimensions-expected.html
            fast/exclusions/shape-inside/shape-inside-overflow-fixed-dimensions.html
            fast/regions/shape-inside/shape-inside-on-regions-block-content-overflow-multiple-shapes-expected.html
            fast/regions/shape-inside/shape-inside-on-regions-block-content-overflow-multiple-shapes.html
      
      * rendering/RenderBlockLineLayout.cpp:
      (WebCore::pushShapeContentOverflowBelowTheContentBox):
      (WebCore::RenderBlock::updateShapeAndSegmentsForCurrentLine):
      (WebCore::RenderBlock::updateShapeAndSegmentsForCurrentLineInFlowThread):
      
      LayoutTests:
      
      * fast/exclusions/shape-inside/shape-inside-empty-expected.html:
      * fast/exclusions/shape-inside/shape-inside-overflow-fixed-dimensions-block-content-expected.html: Copied from LayoutTests/fast/exclusions/shape-inside/shape-inside-overflow-fixed-dimensions-expected.html.
      * fast/exclusions/shape-inside/shape-inside-overflow-fixed-dimensions-block-content.html: Copied from LayoutTests/fast/exclusions/shape-inside/shape-inside-overflow-fixed-dimensions.html.
      * fast/exclusions/shape-inside/shape-inside-overflow-fixed-dimensions-expected.html:
      * fast/exclusions/shape-inside/shape-inside-overflow-fixed-dimensions.html:
      * fast/regions/shape-inside/shape-inside-on-regions-block-content-overflow-multiple-shapes-expected.html:
      * fast/regions/shape-inside/shape-inside-on-regions-block-content-overflow-multiple-shapes.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@151652 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3a337baa
    • betravis@adobe.com's avatar
      [CSS Exclusions] Implement text alignment for shape-inside · 7fa6ab2a
      betravis@adobe.com authored
      https://bugs.webkit.org/show_bug.cgi?id=101086
      
      Reviewed by Alexandru Chiculita.
      
      Adding tests to make sure that shape-inside layout correctly supports
      the different values of text-align.
      
      * fast/exclusions/resources/multi-segment-polygon.js:
      (createOrInsert):
      * fast/exclusions/shape-inside/shape-inside-text-align-expected.html: Added.
      * fast/exclusions/shape-inside/shape-inside-text-align.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@151650 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7fa6ab2a
    • commit-queue@webkit.org's avatar
      Cache FatFinger Text Result. · 385b7a13
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=107403.
      
      Patch by Tiancheng Jiang <tijiang@rim.com> on 2013-06-17
      Reviewed by Rob Buis.
      
      Internally Reviewed by Genevieve Mak.
      Cache the FatFinger text result for later use in TouchEventHandler.
      
      * Api/WebPage.cpp:
      (BlackBerry::WebKit::WebPagePrivate::contextNode):
      * WebKitSupport/SelectionHandler.cpp:
      (BlackBerry::WebKit::SelectionHandler::selectAtPoint):
      * WebKitSupport/TouchEventHandler.h:
      (BlackBerry::WebKit::TouchEventHandler::cacheTextResult):
      (TouchEventHandler):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@151648 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      385b7a13
    • igor.o@sisa.samsung.com's avatar
      [CSS Regions] ::before and ::after pseudo-elements are not displayed for regions · 07fc76ad
      igor.o@sisa.samsung.com authored
      https://bugs.webkit.org/show_bug.cgi?id=80163
      
      Source/WebCore:
      
      When the implementation of the before/after was moved to the DOM, before/after generated
      content stoppped to work with css regions. The problem happens when:
      1. RenderRegion can not have children and when the PseudoElement::attach tries to create a renderer for the
      generated content, it fails.
      2. RenderRegion::canHaveGeneratedChildren should not be false because regions can have generated content.
      
      Reviewed by David Hyatt.
      
      Tests: fast/regions/region-dynamic-after-before.html
             fast/regions/region-generated-content-before-after.html
      
      * dom/NodeRenderingContext.cpp:
      (WebCore::NodeRenderingContext::shouldCreateRenderer):
      * rendering/RenderRegion.h:
      
      LayoutTests:
      
      Add two simple tests verifying if region works with before/after generated content.
      
      Reviewed by David Hyatt.
      
      * fast/regions/region-dynamic-after-before.html: Added.
      * fast/regions/region-generated-content-before-after.html: Added.
      * platform/mac/fast/regions/region-dynamic-after-before-expected.png: Added.
      * platform/mac/fast/regions/region-dynamic-after-before-expected.txt: Added.
      * platform/mac/fast/regions/region-generated-content-before-after-expected.png: Added.
      * platform/mac/fast/regions/region-generated-content-before-after-expected.txt: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@151647 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      07fc76ad
    • mrowe@apple.com's avatar
      <rdar://problem/13145014> Allow CoreIPC messages to transmit importance boosts · c4b45c96
      mrowe@apple.com authored
      Transmitting the importance boost from the UI process to the web process is particularly
      important when disabling process suppression on a web process, as it will minimize the
      delays that can occur before the message instructing process suppression to be disabled
      is processed by the web process.
      
      We keep the importance boost alive for the duration of the CoreIPC message handler. We
      achieve this by having an ImportanceAssertion object that owns the assertion, and whose
      lifetime is tied to that of the MessageDecoder.
      
      Reviewed by Anders Carlsson.
      
      * Platform/CoreIPC/MessageDecoder.cpp:
      (CoreIPC::MessageDecoder::setImportanceAssertion): Associate an importance assertion
      with this message.
      * Platform/CoreIPC/MessageDecoder.h:
      * Platform/CoreIPC/mac/ConnectionMac.cpp:
      (CoreIPC::Connection::open): Mark our receive port as allowing importance boosts to be received.
      (CoreIPC::Connection::receiveSourceEventHandler):
      * Platform/CoreIPC/mac/ImportanceAssertion.h:
      (CoreIPC::ImportanceAssertion::create):
      (CoreIPC::ImportanceAssertion::~ImportanceAssertion): Release the assertion.
      (CoreIPC::ImportanceAssertion::ImportanceAssertion): Take an assertion if a boost was present in
      the Mach message.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@151646 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c4b45c96
    • mrowe@apple.com's avatar
      <rdar://problem/14051357> Web processes sometimes remain in a suppressed · b3dbabb9
      mrowe@apple.com authored
      state after their window is unoccluded.
      
      The code in WKView that responds to occlusion notifications was incorrectly
      treating the window's occlusion state as being an enum rather than the set of
      flags that it is.
      
      Reviewed by Oliver Hunt.
      
      * UIProcess/API/mac/WKView.mm:
      (-[WKView _windowDidChangeOcclusionState:]): Test only the visibility state.
      (-[WKView setWindowOcclusionDetectionEnabled:]): Ditto.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@151645 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b3dbabb9
    • michael.bruning@digia.com's avatar
      [Mac] Remove unmaintained GStreamer specific video code. · a7224373
      michael.bruning@digia.com authored
      https://bugs.webkit.org/show_bug.cgi?id=117694
      
      Reviewed by Philippe Normand.
      
      No new tests, no behaviour change.
      
      * platform/mac/WebVideoFullscreenController.mm:
      (-[WebVideoFullscreenController setupVideoOverlay:]):
      (-[WebVideoFullscreenController windowDidLoad]):
      (-[WebVideoFullscreenController setMediaElement:]):
      (-[WebVideoFullscreenController windowDidExitFullscreen]):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@151643 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a7224373
    • michael.bruning@digia.com's avatar
      [Qt] Remove Qt specific QTKIT flagged code. · f9bd3447
      michael.bruning@digia.com authored
      https://bugs.webkit.org/show_bug.cgi?id=117635
      
      Reviewed by Simon Hausmann.
      
      Due to disabling QTKIT for Qt in r151546, the
      code the flags that are not taken into account
      anymore and the code that has been rendered
      unreachable by this are removed.
      
      .:
      
      * Source/widgetsapi.pri:
      
      Source/WebCore:
      
      No new tests, no behavioural change.
      
      * Target.pri:
      * WebCore.exp.in:
      * page/Settings.cpp:
      * page/Settings.h:
      * platform/KURL.h:
      * platform/SharedBuffer.h:
      * platform/cf/KURLCFNet.cpp:
      (WebCore::KURL::fileSystemPath):
      * platform/cf/SharedBufferCF.cpp:
      * platform/graphics/FloatSize.h:
      * platform/graphics/IntRect.h:
      * platform/graphics/IntSize.h:
      * platform/graphics/MediaPlayer.cpp:
      (WebCore::installedMediaEngines):
      * platform/graphics/cg/FloatSizeCG.cpp:
      * platform/graphics/cg/IntRectCG.cpp:
      * platform/graphics/mac/MediaPlayerPrivateQTKit.h:
      * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
      (WebCore::MediaPlayerPrivateQTKit::createQTMovieLayer):
      (WebCore::MediaPlayerPrivateQTKit::preferredRenderingMode):
      (WebCore::MediaPlayerPrivateQTKit::paint):
      (-[WebCoreMovieObserver layerHostChanged:]):
      * platform/mac/SharedBufferMac.mm:
      (+[WebCoreSharedBufferData initialize]):
      (WebCore::SharedBuffer::createWithContentsOfFile):
      
      Source/WebKit:
      
      * WebKit1.pro:
      
      Source/WebKit/mac:
      
      * WebView/WebView.mm:
      (-[WebView _preferencesChanged:]):
      
      Source/WebKit/qt:
      
      * WebCoreSupport/ChromeClientQt.cpp:
      (WebCore::ChromeClientQt::ChromeClientQt):
      (WebCore::ChromeClientQt::~ChromeClientQt):
      * WebCoreSupport/ChromeClientQt.h:
      * WebCoreSupport/FullScreenVideoQt.cpp:
      (WebCore::FullScreenVideoQt::FullScreenVideoQt):
      (WebCore::FullScreenVideoQt::~FullScreenVideoQt):
      (WebCore::FullScreenVideoQt::enterFullScreenForNode):
      (WebCore::FullScreenVideoQt::exitFullScreenForNode):
      (WebCore::FullScreenVideoQt::isValid):
      * WebCoreSupport/FullScreenVideoQt.h:
      * WebCoreSupport/InitWebCoreQt.cpp:
      (WebCore::initializeWebCoreQt):
      * WebCoreSupport/QTKitFullScreenVideoHandler.h: Removed.
      * WebCoreSupport/QTKitFullScreenVideoHandler.mm: Removed.
      * WebCoreSupport/WebSystemInterface.h: Removed.
      * WebCoreSupport/WebSystemInterface.mm: Removed.
      
      Source/WebKit2:
      
      * Target.pri:
      * UIProcess/qt/WebContextQt.cpp:
      (WebKit::WebContext::platformInitializeWebProcess):
      * WebProcess/WebCoreSupport/qt/WebSystemInterface.h: Removed.
      * WebProcess/WebCoreSupport/qt/WebSystemInterface.mm: Removed.
      * WebProcess/WebPage/WebPage.cpp:
      (WebKit::WebPage::updatePreferences):
      * WebProcess/qt/WebProcessMainQt.cpp:
      (WebKit::WebProcessMainQt):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@151642 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f9bd3447
    • sergio@webkit.org's avatar
      Remove invalid checks from block-cursor-overtype-mode.html · e2e270b4
      sergio@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=117587
      
      Reviewed by Darin Adler.
      
      The test uses an array of ">" "<" symbols to perform comparisons
      between consecutive positions of the block cursor. Since those
      checks are done for each pair of consecutive characters the total
      amount of checks is lengthOfTheWord - 1. We were adding an extra
      symbol that was not used at all in the test.
      
      * editing/selection/block-cursor-overtype-mode.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@151641 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e2e270b4
    • allan.jensen@digia.com's avatar
      REGRESSSION(r151632) : Build error on ASSERT(WTF_USE_GRAMMAR_CHECKING) · def42fbd
      allan.jensen@digia.com authored
      https://bugs.webkit.org/show_bug.cgi?id=117692
      
      Reviewed by Jocelyn Turcotte.
      
      Ifdef the feature-depending code and fix the assertions to check runtime conditions.
      
      * editing/Editor.cpp:
      (WebCore::Editor::advanceToNextMisspelling):
      (WebCore::Editor::markMisspellingsOrBadGrammar):
      (WebCore::Editor::markBadGrammar):
      * editing/TextCheckingHelper.cpp:
      (WebCore::findBadGrammars):
      (WebCore::TextCheckingHelper::findFirstGrammarDetail):
      (WebCore::TextCheckingHelper::findFirstBadGrammar):
      (WebCore::TextCheckingHelper::isUngrammatical):
      (WebCore::TextCheckingHelper::markAllBadGrammar):
      (WebCore::checkTextOfParagraph):
      * editing/TextCheckingHelper.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@151640 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      def42fbd
    • kangil.han@samsung.com's avatar
      Unreviewed. Add my email to a DOM watchlist. · 66ba092f
      kangil.han@samsung.com authored
      * Scripts/webkitpy/common/config/watchlist:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@151639 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      66ba092f
    • g.czajkowski@samsung.com's avatar
      Unreviewed, rolling out r151632. · 7e0d38d7
      g.czajkowski@samsung.com authored
      http://trac.webkit.org/changeset/151632
      https://bugs.webkit.org/show_bug.cgi?id=117585
      
      Debug build error ASSERT(WTF_USE_GRAMMAR_CHECKING) for non MAC
      platforms
      
      Source/WebCore:
      
      * page/ContextMenuController.cpp:
      (WebCore::ContextMenuController::contextMenuItemSelected):
      (WebCore::ContextMenuController::createAndAppendSpellingAndGrammarSubMenu):
      (WebCore::ContextMenuController::populate):
      (WebCore::ContextMenuController::checkOrEnableIfNeeded):
      * platform/LocalizedStrings.cpp:
      (WebCore::contextMenuItemTagSpellingMenu):
      (WebCore::contextMenuItemTagShowSpellingPanel):
      (WebCore::contextMenuItemTagCheckGrammarWithSpelling):
      * platform/LocalizedStrings.h:
      * platform/efl/LocalizedStringsEfl.cpp:
      (WebCore::contextMenuItemTagSpellingMenu):
      (WebCore::contextMenuItemTagShowSpellingPanel):
      (WebCore::contextMenuItemTagCheckGrammarWithSpelling):
      * platform/gtk/LocalizedStringsGtk.cpp:
      (WebCore::contextMenuItemTagSpellingMenu):
      (WebCore::contextMenuItemTagShowSpellingPanel):
      (WebCore::contextMenuItemTagCheckGrammarWithSpelling):
      * platform/qt/LocalizedStringsQt.cpp:
      (WebCore::contextMenuItemTagSpellingMenu):
      (WebCore::contextMenuItemTagShowSpellingPanel):
      (WebCore::contextMenuItemTagCheckGrammarWithSpelling):
      
      Source/WebKit/gtk:
      
      * webkit/webkitglobals.cpp:
      (webkit_context_menu_item_get_action):
      
      Source/WebKit/mac:
      
      * WebCoreSupport/WebContextMenuClient.mm:
      (fixMenusReceivedFromOldClients):
      
      Source/WebKit2:
      
      * Shared/API/c/WKSharedAPICast.h:
      (WebKit::toAPI):
      (WebKit::toImpl):
      * UIProcess/API/efl/ewk_context_menu_item.cpp:
      (getEwkActionFromWKTag):
      * UIProcess/API/efl/tests/test_ewk2_text_checker.cpp:
      (onContextMenuShow):
      (TEST_F):
      * UIProcess/API/gtk/WebKitContextMenuActions.cpp:
      (webkitContextMenuActionGetActionTag):
      (webkitContextMenuActionGetForContextMenuItem):
      (webkitContextMenuActionGetLabel):
      * UIProcess/WebPageProxy.cpp:
      (WebKit::WebPageProxy::contextMenuItemSelected):
      
      Source/WTF:
      
      * wtf/Platform.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@151638 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7e0d38d7
    • carlosgc@webkit.org's avatar
      Unreviewed. Fix make distcheck. · 84dbb64c
      carlosgc@webkit.org authored
      * GNUmakefile.list.am: Remove non existent files from compilation
      and add a missing header file.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@151637 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      84dbb64c
    • zarvai@inf.u-szeged.hu's avatar
      [Qt] Unreviewed gardening. Correcting rebaselining after r151634. · 727e31c5
      zarvai@inf.u-szeged.hu authored
      * platform/qt-5.0-wk2/compositing/repaint/fixed-background-scroll-expected.txt: Renamed from LayoutTests/platform/qt-5.0-wk2/fast/repaint/fixed-background-scroll-expected.txt.
      * platform/qt-5.0-wk2/compositing/repaint/positioned-movement-expected.txt: Renamed from LayoutTests/platform/qt-5.0-wk2/fast/repaint/positioned-movement-expected.txt.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@151636 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      727e31c5
    • carlosgc@webkit.org's avatar
      Unreviewed. Rename gobject_introspection_required variable. · 537a836d
      carlosgc@webkit.org authored
      As gobject_introspection_required_version for consistency with all
      other required_version variables.
      
      * Source/autotools/FindDependencies.m4:
      * Source/autotools/Versions.m4:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@151635 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      537a836d
    • zarvai@inf.u-szeged.hu's avatar
      [Qt] Unreviewed gardening. Rebaselining repaint tests, see bug 115372. · 297345e4
      zarvai@inf.u-szeged.hu authored
      * platform/qt-5.0-wk2/fast/repaint/change-overflow-and-display-of-relative-expected.txt: Rebaselining after r151549.
      * platform/qt-5.0-wk2/fast/repaint/fixed-background-scroll-expected.txt: Rebaselining after r151624.
      * platform/qt-5.0-wk2/fast/repaint/positioned-movement-expected.txt: Rebaselining after r151622.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@151634 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      297345e4
    • zandobersek@gmail.com's avatar
      Unreviewed GTK gardening. · 3a0d3edb
      zandobersek@gmail.com authored
      * Scripts/run-gtk-tests:
      (TestRunner): Skip three WebKit2APITests suites that are currently timing out.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@151633 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3a0d3edb
    • g.czajkowski@samsung.com's avatar
      Context menu grammar checking items are available when GRAMMAR_CHECKING macro is off · 9facbdb9
      g.czajkowski@samsung.com authored
      https://bugs.webkit.org/show_bug.cgi?id=117585
      
      Reviewed by Anders Carlsson.
      
      Source/WebCore:
      
      Do not add "Check Grammar With Spelling" and "Ignore Grammar" to the context menu
      when GRAMMAR_CHECKING is off.
      Replace "Spelling and Grammar" with "Spelling" as the sub menu title and "Show/Hide Spelling
      and Grammar" with "Show/Hide Spelling" when GRAMMAR_CHECKING is off.
      
      Additionally, guard grammar checking in context menu code to not necessarily
      compile it.
      
      No new layout tests because every port has a different way of showing
      spelling/grammar context menu items.
      
      * page/ContextMenuController.cpp:
      (WebCore::ContextMenuController::contextMenuItemSelected):
      (WebCore::ContextMenuController::createAndAppendSpellingAndGrammarSubMenu):
      (WebCore::ContextMenuController::populate):
      (WebCore::ContextMenuController::checkOrEnableIfNeeded):
      * platform/LocalizedStrings.cpp:
      (WebCore::contextMenuItemTagCheckGrammarWithSpelling):
      (WebCore::contextMenuItemTagSpellingMenu):
      (WebCore::contextMenuItemTagShowSpellingPanel):
      * platform/LocalizedStrings.h:
      * platform/efl/LocalizedStringsEfl.cpp:
      (WebCore::contextMenuItemTagCheckGrammarWithSpelling):
      (WebCore::contextMenuItemTagSpellingMenu):
      (WebCore::contextMenuItemTagShowSpellingPanel):
      * platform/gtk/LocalizedStringsGtk.cpp:
      (WebCore::contextMenuItemTagCheckGrammarWithSpelling):
      (WebCore::contextMenuItemTagSpellingMenu):
      (WebCore::contextMenuItemTagShowSpellingPanel):
      * platform/qt/LocalizedStringsQt.cpp:
      (WebCore::contextMenuItemTagCheckGrammarWithSpelling):
      (WebCore::contextMenuItemTagSpellingMenu):
      (WebCore::contextMenuItemTagShowSpellingPanel):
      
      Source/WebKit/gtk:
      
      Add GRAMMAR_CHECKING guard to the context menu grammar items.
      
      * webkit/webkitglobals.cpp:
      (webkit_context_menu_item_get_action):
      
      Source/WebKit/mac:
      
      Add GRAMMAR_CHECKING guard to the context menu grammar items.
      
      * WebCoreSupport/WebContextMenuClient.mm:
      (fixMenusReceivedFromOldClients):
      
      Source/WebKit2:
      
      Add GRAMMAR_CHECKING guard to the context menu grammar items.
      
      * Shared/API/c/WKSharedAPICast.h:
      (WebKit::toAPI):
      (WebKit::toImpl):
      * UIProcess/API/efl/ewk_context_menu_item.cpp:
      (getEwkActionFromWKTag):
      * UIProcess/API/efl/tests/test_ewk2_text_checker.cpp:
      (checkSpellingItemsAvailability):
      Change callback name, to be consistent with a newly added.
      
      (checkSpellingAndGrammarSubmenuAvailability):
      (checkGrammarWithSpellingItemAvailability):
      Add two unit tests for EFL to check whether context menu grammar items are
      available only when GRAMMAR_CHECKING macro is enabled.
      
      * UIProcess/API/gtk/WebKitContextMenuActions.cpp:
      (webkitContextMenuActionGetActionTag):
      (webkitContextMenuActionGetForContextMenuItem):
      (webkitContextMenuActionGetLabel):
      * UIProcess/WebPageProxy.cpp:
      (WebKit::WebPageProxy::contextMenuItemSelected):
      
      Source/WTF:
      
      Enable GRAMMAR_CHECKING for WebKit ports that use/implement it.
      
      * wtf/Platform.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@151632 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9facbdb9
    • zandobersek@gmail.com's avatar
      Unreviewed GTK gardening. · 005498dc
      zandobersek@gmail.com authored
      * platform/gtk-wk1/TestExpectations: Add a crashing expectation for a test that most likely regressed with r151021.
      * platform/gtk/TestExpectations: Add failure expectations for a couple of tests failing due to stack size misbehavior.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@151631 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      005498dc
    • commit-queue@webkit.org's avatar
      [CSS Blending] Update the background-blend-mode-image-color-dynamic test to... · 3b491b61
      commit-queue@webkit.org authored
      [CSS Blending] Update the background-blend-mode-image-color-dynamic test to use the repaint test logic
      
      Updating testcase verifying if background blend modes are updated dynamically from script. This now
      properly uses the repaint test mechanism. Also, the background image resource is addded.
      
      https://bugs.webkit.org/show_bug.cgi?id=117686
      
      Patch by Mihai Tica <mitica@adobe.com> on 2013-06-16
      Reviewed by Dean Jackson.
      
      * fast/repaint/background-blend-mode-image-color-dynamic-expected.html:
      * fast/repaint/background-blend-mode-image-color-dynamic.html:
      * fast/repaint/resources/ducky.png: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@151630 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3b491b61
  3. 16 Jun, 2013 2 commits