Commits · 8c5918e629341fc547737edd2fc09cf4eca8ac15 · App_Technologies / webkit

01 Dec, 2009 40 commits

https://bugs.webkit.org/show_bug.cgi?id=21288 · 8c5918e6

abarth@webkit.org authored Dec 02, 2009

Reviewed by Darin Adler.

Add sneaky test that has tabs.

* fast/frames/sandboxed-iframe-attribute-parsing-expected.txt: Added.
* fast/frames/sandboxed-iframe-attribute-parsing.html: Added.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51579 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8c5918e6

Change unsigned to int to fix the Windows build. · 18d381ea
bweinstein@apple.com authored Dec 02, 2009
```
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51578 268f45cc-cd09-0410-ab3c-d52691b4dbfc
```
18d381ea

2009-12-01 Patrik Persson <patrik.j.persson@ericsson.com> · b8a10552

abarth@webkit.org authored Dec 02, 2009

        Reviewed by Darin Adler.

        Implement HTML5 sandbox attribute for iframes.
        http://www.w3.org/TR/html5/text-level-semantics.html#attr-iframe-sandbox
        https://bugs.webkit.org/show_bug.cgi?id=21288

        * fast/frames/resources/non-sandboxed-iframe-navigation.html: Added.
        * fast/frames/resources/sandboxed-iframe-attribute-parsing-allowed.html: Added.
        * fast/frames/resources/sandboxed-iframe-attribute-parsing-disallowed.html: Added.
        * fast/frames/resources/sandboxed-iframe-form-allowed.html: Added.
        * fast/frames/resources/sandboxed-iframe-form-disallowed.html: Added.
        * fast/frames/resources/sandboxed-iframe-navigated.html: Added.
        * fast/frames/resources/sandboxed-iframe-navigation-child.html: Added.
        * fast/frames/resources/sandboxed-iframe-navigation-navigated.html: Added.
        * fast/frames/resources/sandboxed-iframe-navigation-parent.html: Added.
        * fa...

b8a10552

ARIA: support a way to create a static text object · bd43f07d

cfleizach@apple.com authored Dec 02, 2009

https://bugs.webkit.org/show_bug.cgi?id=32030

Reviewed by David Kilzer.

WebCore: 

Test: accessibility/aria-text-role.html

* accessibility/AccessibilityObject.cpp:
(WebCore::createARIARoleMap):
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::stringValue):
(WebCore::AccessibilityRenderObject::isDescendantOfBarrenParent):
(WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
(WebCore::AccessibilityRenderObject::text):
* accessibility/AccessibilityRenderObject.h:

LayoutTests: 

* accessibility/aria-text-role-expected.txt: Added.
* accessibility/aria-text-role.html: Added.
* platform/gtk/Skipped:
* platform/win/Skipped:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51576 268f45cc-cd09-0410-ab3c-d52691b4dbfc

bd43f07d

Not reviewed. GTK DRT try 2. · 0067edb7

zimmermann@webkit.org authored Dec 02, 2009


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51575 268f45cc-cd09-0410-ab3c-d52691b4dbfc

0067edb7

Not reviewed. Try to fix gtk DRT build. · 03e0a333

zimmermann@webkit.org authored Dec 02, 2009


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51574 268f45cc-cd09-0410-ab3c-d52691b4dbfc

03e0a333

Touch WebKit.idl to rebuild Interfaces and fix the Windows build. · 16df50a8
bweinstein@apple.com authored Dec 02, 2009
```
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51573 268f45cc-cd09-0410-ab3c-d52691b4dbfc
```
16df50a8

Inspector crashes when collecting on every allocation · ff7890e1

oliver@apple.com authored Dec 02, 2009

https://bugs.webkit.org/show_bug.cgi?id=32044

Reviewed by Maciej Stachowiak.

The crash is caused by the prototype wrapper object getting collected
when allocating the object that is going to use it as a prototype.
Because the only reference to the prototype wrapper is through the
new object's Structure it does not get marked automatically.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51572 268f45cc-cd09-0410-ab3c-d52691b4dbfc

ff7890e1

Build fix by using DOMNode::node() to go from a DOMNode to a node, and · 7abd0d56

bweinstein@apple.com authored Dec 02, 2009

added svg/animation in the WebCore.vcproj list of headers to be copied
over on build.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51571 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7abd0d56

check-webkit-style does not understand (Prefix)Foo(Custom|Gtk|CG|Mac).cpp including Foo.h · 1e35af71

levin@chromium.org authored Dec 02, 2009

https://bugs.webkit.org/show_bug.cgi?id=32033

Reviewed by Eric Seidel.

* Scripts/modules/cpp_style.py: Changed check for a possible primary header to use find
                                instead of startswith.
* Scripts/modules/cpp_style_unittest.py: Added a unit test for the new behavior.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51570 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1e35af71

Not reviewed. Qt build almost fixed, DumpRenderTree should compile now as well. · adf4e19f
zimmermann@webkit.org authored Dec 02, 2009
```
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51569 268f45cc-cd09-0410-ab3c-d52691b4dbfc
```
adf4e19f

Not reviewed. Try to fix qt/win builds. · 8e195f83

zimmermann@webkit.org authored Dec 02, 2009


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51568 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8e195f83

2009-12-01 Nikolas Zimmermann <nzimmermann@rim.com> · 840d1766

zimmermann@webkit.org authored Dec 02, 2009

        Reviewed by Simon Fraser.

        Add SVG animation test framework with 'snapshot' functionality
        https://bugs.webkit.org/show_bug.cgi?id=31897

        Add API used by the new 'sampleSVGAnimationForElementAtTime' DRT method,
        forwarding the call to SVGDocumentExtensions, if SVG is enabled.

        Implemented just like the existing pauseAnimation* methods for CSS animations.

        * Api/qwebframe.cpp:
        (qt_drt_pauseSVGAnimation):
2009-12-01  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Simon Fraser.

        Add SVG animation test framework with 'snapshot' functionality
        https://bugs.webkit.org/show_bug.cgi?id=31897

        Add API used by the new 'sampleSVGAnimationForElementAtTime' DRT method,
        forwarding the call to SVGDocumentExtensions, if SVG is enabled.

        Implemented just like the existing pauseAnimation* methods for CSS animations.

        * webkit/webkitprivate.h:
        * webkit/webkitwebframe.cpp:
        (webkit_web_frame_pause_svg_animation):
2009-12-01  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Simon Fraser.

        Add SVG animation test framework with 'snapshot' functionality
        https://bugs.webkit.org/show_bug.cgi?id=31897

        Add API used by the new 'sampleSVGAnimationForElementAtTime' DRT method,
        forwarding the call to SVGDocumentExtensions, if SVG is enabled.

        Implemented just like the existing pauseAnimation* methods for CSS animations.

        * Interfaces/IWebFramePrivate.idl:
        * WebFrame.cpp:
        (WebFrame::pauseSVGAnimation):
        * WebFrame.h:
2009-12-01  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Simon Fraser.

        Add SVG animation test framework with 'snapshot' functionality
        https://bugs.webkit.org/show_bug.cgi?id=31897

        Add API used by the new 'sampleSVGAnimationForElementAtTime' DRT method,
        forwarding the call to SVGDocumentExtensions, if SVG is enabled.

        Implemented just like the existing pauseAnimation* methods for CSS animations.

        * WebView/WebFrame.mm:
        (-[WebFrame _pauseSVGAnimation:onSMILNode:atTime:]):
        * WebView/WebFramePrivate.h:
2009-12-01  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Simon Fraser.

        Add SVG animation test framework with 'snapshot' functionality
        https://bugs.webkit.org/show_bug.cgi?id=31897

        Add 'sampleSVGAnimationForElementAtTime' method to the LayoutTestController,
        for the use within the new SVG animation test framework (LayoutTests/svg/animations/)

        layoutTestController.sampleAnimationAtTime(<svg animation id>, <absolute time>, <svg element id>);
        to sample a svg animateMotion/animateColor/animate/set element at certain times.

        After the desired SVG animation starts and calling the method above, it's immediately forwarded to
        the desired sampling time. After JS returns from the 'sampleSVGAnimationForElementAtTime' method
        a callback is fired used to sample the animation value at the target time. It's modelled similar
        to the CSS animation/transition testing framework, inspired by
        LayoutTests/animations/animation-test-helpers.js.

        Though it has been extended to integrate within the fast/js/js-test-* framework, that's used for
        the SVG dynamic-updates tests, to simplify test creation, by utilizing script-tests/* only.

        Adding a simple testcase testing the DRT methods, it will soon be extended to test animVal/baseVal
        interaction, while animating.

        Test: svg/animations/animVal-basics.html

        * WebCore.base.exp:
        * WebCore.xcodeproj/project.pbxproj:
        * svg/SVGDocumentExtensions.cpp:
        (WebCore::SVGDocumentExtensions::sampleAnimationAtTime):
        * svg/SVGDocumentExtensions.h:
        * svg/animation/SMILTimeContainer.cpp:
        (WebCore::SMILTimeContainer::SMILTimeContainer):
        (WebCore::SMILTimeContainer::sampleAnimationAtTime):
        (WebCore::SMILTimeContainer::updateAnimations):
        * svg/animation/SMILTimeContainer.h:
2009-12-01  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Simon Fraser.

        Add SVG animation test framework with 'snapshot' functionality
        https://bugs.webkit.org/show_bug.cgi?id=31897

        Add LayoutTests/svg/animations directory, containing a new
        framework for SVG animation test with sampling at certain times.

        Added one example test, which will be extended soon to cover animVal
        support, once basic support has been implemented.

        * svg/animations: Added.
        * svg/animations/animVal-basics-expected.txt: Added.
        * svg/animations/animVal-basics.html: Added.
        * svg/animations/resources: Added.
        * svg/animations/resources/SVGAnimationTestCase.js: Added.
        (isCloseEnough):
        (moveAnimationTimelineAndSample):
        (startTest):
        (sampleAnimation):
        (runAnimationTest):
        * svg/animations/script-tests: Added.
        * svg/animations/script-tests/TEMPLATE.html: Added.
        * svg/animations/script-tests/animVal-basics.js: Added.
        (sample1):
        (sample2):
        (sample3):
        (executeTest):
2009-12-01  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Simon Fraser.

        Add SVG animation test framework with 'snapshot' functionality
        https://bugs.webkit.org/show_bug.cgi?id=31897

        Add new 'sampleSVGAnimationForElementAtTime' DRT method,
        used by the new SVG animation testing framework, implemented
        for qt/gtk/win/mac.

        * DumpRenderTree/LayoutTestController.cpp:
        (sampleSVGAnimationForElementAtTimeCallback):
        (LayoutTestController::staticFunctions):
        * DumpRenderTree/LayoutTestController.h:
        * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
        (LayoutTestController::sampleSVGAnimationForElementAtTime):
        * DumpRenderTree/mac/LayoutTestControllerMac.mm:
        (LayoutTestController::sampleSVGAnimationForElementAtTime):
        * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
        (LayoutTestController::sampleSVGAnimationForElementAtTime):
        * DumpRenderTree/qt/LayoutTestControllerQt.h:
        * DumpRenderTree/win/LayoutTestControllerWin.cpp:
        (LayoutTestController::sampleSVGAnimationForElementAtTime):
        * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
        (LayoutTestController::sampleSVGAnimationForElementAtTime):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51567 268f45cc-cd09-0410-ab3c-d52691b4dbfc

840d1766

JavaScriptCore: Added variants of find/contains/add that allow a foreign key type to be used. · bc3c1476

snej@chromium.org authored Dec 02, 2009

This will allow AtomicString-keyed maps to be queried by C string without
having to create a temporary AtomicString (see HTTPHeaderMap.)
The code for this is adapted from the equivalent in HashSet.h.

WebCore: Add convenience methods to Element and QualifiedName that take
char* instead of AtomicString, in preparation for removing the
implicit conversion between the two types (30187).
https://bugs.webkit.org/show_bug.cgi?id=31749

Reviewed by Darin Adler.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51566 268f45cc-cd09-0410-ab3c-d52691b4dbfc

bc3c1476

More Windows build fix. · 9c19a120

ap@apple.com authored Dec 01, 2009

        * platform/network/cf/CredentialStorageCFNet.cpp:
        (WebCore::CredentialStorage::getFromPersistentStorage):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51565 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9c19a120

Windows build fix. · b565dd45

ap@apple.com authored Dec 01, 2009

        * platform/network/cf/CredentialStorageCFNet.cpp: Include RetainPtr.h.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51564 268f45cc-cd09-0410-ab3c-d52691b4dbfc

b565dd45

Skip more tests that fail with specific versions of CFNetwork on Windows · 64b696b1

aroben@apple.com authored Dec 01, 2009

Rubber-stamped in advance by Brady Eidson.

* platform/win/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51563 268f45cc-cd09-0410-ab3c-d52691b4dbfc

64b696b1

Simplify [WebView userAgentForURL:]. No need to call into helper function. · 02c9476f

weinig@apple.com authored Dec 01, 2009

Reviewed by Mark Rowe.

* WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::userAgent):
* WebView/WebView.mm:
(-[WebView userAgentForURL:]):
* WebView/WebViewInternal.h:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51562 268f45cc-cd09-0410-ab3c-d52691b4dbfc

02c9476f

Reviewed by Darin Adler. · aeb999ad

ap@apple.com authored Dec 01, 2009

https://bugs.webkit.org/show_bug.cgi?id=32036
Implement CredentialStorage::getFromPersistentStorage for CFNetwork

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51561 268f45cc-cd09-0410-ab3c-d52691b4dbfc

aeb999ad

[Chromium] Simplify zoom-related APIs and add a zoom level getter, · 7fbcd16a

pkasting@chromium.org authored Dec 01, 2009

part one: Add new APIs.  (Old APIs will be removed in a second pass.)
https://bugs.webkit.org/show_bug.cgi?id=31893

Reviewed by Darin Fisher.

* public/WebView.h:
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::zoomLevel):
(WebKit::WebViewImpl::setZoomLevel):
* src/WebViewImpl.h:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51560 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7fbcd16a

2009-12-01 Daniel Bates <dbates@webkit.org> · f06a4d76

eric@webkit.org authored Dec 01, 2009

        Reviewed by Pavel Feldman.

        https://bugs.webkit.org/show_bug.cgi?id=32001

        Updated layout test to reflect change to localized string and
        rebased the result.

        * inspector/elements-img-tooltip-expected.txt:
        * inspector/elements-img-tooltip.html:
2009-12-01  Daniel Bates  <dbates@webkit.org>

        Reviewed by Pavel Feldman.

        https://bugs.webkit.org/show_bug.cgi?id=32001

        Added missing localized strings (that I left out of the patch for bug #21554):
        %d × %d pixels
        %d × %d pixels (Natural: %d × %d pixels)

        Also, changed formatting of these stings to conform with existing ones (added
        a space on both sides of the multiply sign).

        * English.lproj/localizedStrings.js: Added stings.
        * inspector/front-end/ElementsTreeOutline.js:
        (WebInspector.ElementsTreeElement.prototype.createTooltipForImageNode):

git-svn-id: http://svn.webkit.org/repository/we...

f06a4d76

2009-12-01 Daniel Bates <dbates@webkit.org> · a82ec714

eric@webkit.org authored Dec 01, 2009

        Reviewed by Kenneth Rohde Christiansen.

        https://bugs.webkit.org/show_bug.cgi?id=31898

        Makes QtLauncher default to the http scheme for URLs.

        * QtLauncher/main.cpp:
        (MainWindow::MainWindow):
        (MainWindow::changeLocation):
        (main):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51558 268f45cc-cd09-0410-ab3c-d52691b4dbfc

a82ec714

Skip a test that fails with some versions of CFNetwork on Windows · a15fb1ea

aroben@apple.com authored Dec 01, 2009

Rubber-stamped by Brady Eidson.

* platform/win/Skipped: Skip http/tests/plugins/post-url-file.html.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51557 268f45cc-cd09-0410-ab3c-d52691b4dbfc

a15fb1ea

Fix for bug 32032, empty namespaces should be allowed in @namespace directives in CSS. · 6e4e9856

hyatt@apple.com authored Dec 01, 2009

Reviewed by Simon Fraser.

Added fast/css/namespaces/namespaces-empty.xml

* css/CSSStyleSheet.cpp:
(WebCore::CSSStyleSheet::addNamespace):
(WebCore::CSSStyleSheet::determineNamespace):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51556 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6e4e9856

Revert 51551 because it broke GTK+. · 197accca

kov@webkit.org authored Dec 01, 2009

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51555 268f45cc-cd09-0410-ab3c-d52691b4dbfc

197accca

Remove user content before running each test on Windows · 73ca6e7e

aroben@apple.com authored Dec 01, 2009

Fixes <http://webkit.org/b/31479> Make websocket tests work on Windows

Reviewed by Alexey Proskuryakov.

* DumpRenderTree/win/DumpRenderTree.cpp:
(resetWebViewToConsistentStateBeforeTesting): Remove all user content
before each test, which matches Mac.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51554 268f45cc-cd09-0410-ab3c-d52691b4dbfc

73ca6e7e

2009-12-01 Joseph Pecoraro <joepeck@webkit.org> · 02237f75

joepeck@webkit.org authored Dec 01, 2009

        Reviewed by Timothy Hatcher.

        Web Inspector: Escape key in the Search Field should be more User Friendly
        https://bugs.webkit.org/show_bug.cgi?id=32005

        * inspector/front-end/inspector.js:
        (WebInspector.loaded): add mousedown listener on the search field
        (WebInspector.searchFieldManualFocus): user clicked to focus on the search field
        (WebInspector.searchKeyDown): handle escape

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51553 268f45cc-cd09-0410-ab3c-d52691b4dbfc

02237f75

Enabling WebSocket tests on Windows again - let's see what errors get logged. · 9d4a04bb

ap@apple.com authored Dec 01, 2009

        * platform/win/Skipped:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51552 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9d4a04bb

2009-12-01 Laszlo Gombos <laszlo.1.gombos@nokia.com> · 823bfaf1

eric@webkit.org authored Dec 01, 2009

        Reviewed by Eric Seidel.

        PLATFORM(CAIRO) should be defined by WIN_CAIRO define
        https://bugs.webkit.org/show_bug.cgi?id=22250

        * wtf/Platform.h: Remove WTF_PLATFORM_CAIRO as it is
        already define in config.h

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51551 268f45cc-cd09-0410-ab3c-d52691b4dbfc

823bfaf1

2009-12-01 Yuzo Fujishima <yuzo@google.com> · 97479bbf

ap@apple.com authored Dec 01, 2009

        Reviewed by Alexey Proskuryakov.

        Make pywebsocket log errors to a file
        https://bugs.webkit.org/show_bug.cgi?id=31604

        * Scripts/run-webkit-tests: Log output to a pywebsocket_log.txt file in results directory
        (by passing the path to the server via a recently added -l option).



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51550 268f45cc-cd09-0410-ab3c-d52691b4dbfc

97479bbf

@namespace directives need to use "maybe_space" in the "maybe_ns_prefix"... · 5ccf9a12

hyatt@apple.com authored Dec 01, 2009

@namespace directives need to use "maybe_space" in the "maybe_ns_prefix" portion of the grammar to match
the spec.  Not doing so prevent comments from being used immmediately after the namespace prefix.

Reviewed by David Kilzer.

Added fast/css/namespaces-comments.xml

* css/CSSGrammar.y:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51549 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5ccf9a12

2009-12-01 Xiyuan Xia <xiyuan@chromium.org> · e6dd2557

eric@webkit.org authored Dec 01, 2009

        Reviewed by Darin Fisher.

        Only fire start/stop events when main frame is not loading.

        https://bugs.webkit.org/show_bug.cgi?id=31838

        * src/FrameLoaderClientImpl.cpp:
        (WebKit::FrameLoaderClientImpl::dispatchDidChangeLocationWithinPage):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51548 268f45cc-cd09-0410-ab3c-d52691b4dbfc

e6dd2557

Add a timing-out test to the Skipped file on Windows · c4d65298

aroben@apple.com authored Dec 01, 2009

Rubber-stamped by Ada Chan.

* platform/win/Skipped: Added
fast/dom/Window/window-postmessage-clone.html, which was timing out
due to eventSender.beginDragFiles being unimplemented.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51547 268f45cc-cd09-0410-ab3c-d52691b4dbfc

c4d65298

Fix tests that use the TestNetscapePlugin in Debug_Internal builds · a6a81b06

aroben@apple.com authored Dec 01, 2009

Reviewed by Ada Chan.

Fixes <http://webkit.org/b/32027> REGRESSION (r49705): Tests that use
TestNetscapePlugin fail in Debug_Internal builds

* DumpRenderTree/win/DumpRenderTree.cpp: Use the "_Debug" plugin
directory in Debug and Debug_All builds, but not in Debug_Internal
builds.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51546 268f45cc-cd09-0410-ab3c-d52691b4dbfc

a6a81b06

Re-enable DRT's watchdog timer on Windows · 06cd711f

aroben@apple.com authored Dec 01, 2009

It was accidentally disabled in r50907.

* DumpRenderTree/win/LayoutTestControllerWin.cpp:
(LayoutTestController::setWaitToDump): Remove a "false &&" that snuck
into an if condition.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51545 268f45cc-cd09-0410-ab3c-d52691b4dbfc

06cd711f

2009-12-01 Yael Aharon <yael.aharon@nokia.com> · 0c9118b2

eric@webkit.org authored Dec 01, 2009

        Reviewed by Timothy Hatcher.

        Reloading WebInspector from context menu is closing it instead of reloading.
        https://bugs.webkit.org/show_bug.cgi?id=32004

        When reloading WebInspector, don't delete its m_page.

        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::close):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51544 268f45cc-cd09-0410-ab3c-d52691b4dbfc

0c9118b2

Add expected Windows failure results for tests that use textInputController · 84857548

aroben@apple.com authored Dec 01, 2009

<http://webkit.org/b/32021> covers fixing these tests.

Rubber-stamped by Sam Weinig.

* platform/win/Skipped: Removed tests that use textInputController.

* platform/win/editing/selection/5825350-1-expected.txt: Added.
* platform/win/editing/selection/5825350-2-expected.txt: Added.
* platform/win/editing/selection/mixed-editability-10-expected.txt: Added.
* platform/win/fast/events/ime-composition-events-001-expected.txt: Added.
* platform/win/fast/forms/input-maxlength-ime-completed-expected.txt: Added.
* platform/win/fast/forms/input-maxlength-ime-preedit-expected.txt: Added.
* platform/win/fast/text/international/thai-cursor-position-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51543 268f45cc-cd09-0410-ab3c-d52691b4dbfc

84857548

[Qt] Put test into skiplist because of missing layoutTestController.evaluateInWebInspector(). · c6da41d1

ossy@webkit.org authored Dec 01, 2009

* platform/qt/Skipped: inspector/timeline-network-resource.html added.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51542 268f45cc-cd09-0410-ab3c-d52691b4dbfc

c6da41d1

2009-12-01 Adam Barth <abarth@webkit.org> · 890ae715

abarth@webkit.org authored Dec 01, 2009

        Reviewed by Eric Seidel.

        check-webkit-style complains about #imports with / in them
        https://bugs.webkit.org/show_bug.cgi?id=32022

        We need to exclude #import directives in addition to #include from the
        binary operator whitespace checks.

        * Scripts/modules/cpp_style.py:
        * Scripts/modules/cpp_style_unittest.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51541 268f45cc-cd09-0410-ab3c-d52691b4dbfc

890ae715

2009-12-01 Steve Block <steveblock@google.com> · bc2e427e

eric@webkit.org authored Dec 01, 2009

        Reviewed by Dimitri Glazkov.

        Adds V8 bindings for Geolocation.
        https://bugs.webkit.org/show_bug.cgi?id=30206

        Also adds Geolocation files to Chrome build files.

        * WebCore.gyp/WebCore.gyp: Modified. Corrects list of Geolocation IDL files.
        * WebCore.gypi: Modified. Adds Geolocation files.
        * bindings/v8/DOMObjectsInclude.h: Modified. Adds Geolocation includes.
        * bindings/v8/DerivedSourcesAllInOne.cpp: Modified. Adds Geolocation files.
        * bindings/v8/V8Index.cpp: Modified. Includes Geolocation generated headers.
        * bindings/v8/V8Index.h: Modified. Adds Geolocation types to DOM_OBJECT_TYPES.
        * bindings/v8/custom/V8CoordinatesCustom.cpp: Added. Handles optional properties.
        * bindings/v8/custom/V8CustomBinding.h: Modified. Declares callbacks and getters.
        * bindings/v8/custom/V8CustomPositionCallback.cpp: Added.
        (WebCore::V8CustomPositionCallback::V8CustomPositionCallback): Added. Constructor.
        (WebCore::V8CustomPositionCallback::~V8CustomPositionCallback): Added. Destructor.
        (WebCore::V8CustomPositionCallback::handleEvent): Added. Invokes callback.
        * bindings/v8/custom/V8CustomPositionCallback.h: Added.
        (WebCore::V8CustomPositionCallback::create): Added. Factory method.
        * bindings/v8/custom/V8CustomPositionErrorCallback.cpp: Added.
        (WebCore::V8CustomPositionErrorCallback::V8CustomPositionErrorCallback): Added. Constructor.
        (WebCore::V8CustomPositionErrorCallback::~V8CustomPositionErrorCallback): Added. Destructor.
        (WebCore::V8CustomPositionErrorCallback::handleEvent): Added. Invokes callback.
        * bindings/v8/custom/V8CustomPositionErrorCallback.h: Added.
        (WebCore::V8CustomPositionErrorCallback::create): Added. Factory method.
        * bindings/v8/custom/V8GeolocationCustom.cpp: Added.
        (WebCore::throwTypeMismatchException): Added. Throws a type mismatch error.
        (WebCore::createPositionCallback): Added. Handles type checking for successCallback argument.
        (WebCore::createPositionErrorCallback): Added. Handles type checking for errorCallback argument.
        (WebCore::createPositionOptions): Added. Handles type checking for positionOptions argument.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51540 268f45cc-cd09-0410-ab3c-d52691b4dbfc

bc2e427e