1. 12 Jul, 2007 9 commits
    • weinig's avatar
      LayoutTests: · 8c392cc4
      weinig authored
              Reviewed by Maciej.
      
              Test for <rdar://problem/5329841>
              Calling window.closed on a closed window causes Safari to crash
      
              * fast/dom/Window/window-closed-crash-expected.txt: Added.
              * fast/dom/Window/window-closed-crash.html: Added.
      
      WebCore:
      
              Reviewed by Maciej.
      
              Patch for <rdar://problem/5329841>
              Calling window.closed on a closed window causes Safari to crash
      
              - Replaces the Frame member variable in KJS::Window for more appropriate DOMWindow
              - Adds additional new null checks as necessary
              - Removes bogus toBoolean method
              - Removes unused scheduleClose method
      
              Test: fast/dom/Window/window-closed-crash.html
      
              * bindings/js/JSCustomXPathNSResolver.cpp:
              (WebCore::JSCustomXPathNSResolver::create):
              * bindings/js/JSDOMWindowCustom.cpp:
              (WebCore::JSDOMWindow::customGetOwnPropertySlot):
              (WebCore::JSDOMWindow::customPut):
              * bindings/js/JSXMLHttpRequest.cpp:
              (KJS::JSXMLHttpRequestPrototypeFunction::callAsFunction):
              * bindings/js/kjs_events.cpp:
              (WebCore::JSAbstractEventListener::handleEvent):
              (WebCore::JSLazyEventListener::parseCode):
              * bindings/js/kjs_window.cpp:
              (KJS::Window::Window):
              (KJS::Window::impl):
              (KJS::Window::interpreter):
              (KJS::Window::location):
              (KJS::Window::find):
              (KJS::allowPopUp):
              (KJS::createWindow):
              (KJS::canShowModalDialog):
              (KJS::canShowModalDialogNow):
              (KJS::showModalDialog):
              (KJS::Window::getValueProperty):
              (KJS::Window::childFrameGetter):
              (KJS::Window::indexGetter):
              (KJS::Window::namedItemGetter):
              (KJS::Window::getOwnPropertySlot):
              (KJS::Window::put):
              (KJS::Window::isSafeScript):
              (KJS::Window::setListener):
              (KJS::Window::getListener):
              (KJS::Window::clear):
              (KJS::WindowFunc::callAsFunction):
              (KJS::Window::updateLayout):
              (KJS::ScheduledAction::execute):
              (KJS::Window::disconnectFrame):
              (KJS::Location::put):
              (KJS::LocationFunc::callAsFunction):
              * bindings/js/kjs_window.h:
              * page/mac/WebCoreFrameBridge.mm:
              (updateRenderingForBindings):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24241 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8c392cc4
    • bdash's avatar
      2007-07-12 Mitz Pettel <mitz@webkit.org> · 970f5625
      bdash authored
              Reviewed by Mark Rowe.
      
              - try to fix hang seen on buildbot after the last fix
      
              * fast/history/resources/history_reload_window.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24240 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      970f5625
    • bdash's avatar
      2007-07-12 Mitz Pettel <mitz@webkit.org> · 4a3d1702
      bdash authored
              Reviewed by Mark Rowe.
      
              - fix an assertion failure in DumpRenderTree when running fast/history/resources/history_reload_window.html
      
              * fast/history/resources/history_reload_window.html: Delay notifyDone() until
              after the window actually closes.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24239 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4a3d1702
    • bdash's avatar
      2007-07-12 Mark Rowe <mrowe@apple.com> · c4bd53a9
      bdash authored
              Reviewed by Ada.
      
              <rdar://problem/5329877> REGRESSION: Document::setTransformSource leaks an xmlDocPtr if called more than once per document
      
              * dom/Document.cpp:
              (WebCore::Document::setTransformSource): Free any existing m_transformSource before overwriting it, rather than simply leaking it.
              * dom/Document.h:
      
      2007-07-12  Mark Rowe  <mrowe@apple.com>
      
              Reviewed by Ada.
      
              Remove leak suppression for xmlDocPtrForString now that <rdar://problem/5329877> is fixed.
      
              * Scripts/run-webkit-tests:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24238 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c4bd53a9
    • bdash's avatar
      2007-07-12 Maxime Britto <mbritto@pleyo.com> · 7eb292ce
      bdash authored
              Reviewed by Mark Rowe.
      
              Update the expected results now that they match what the test describes as the correct rendering.
      
              * svg/custom/invalid-fill-hex-expected.txt:
              * svg/custom/invalid-fill-hex-expected.png:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24237 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7eb292ce
    • bdash's avatar
      2007-07-12 Holger Hans Peter Freyther <zecke@selfish.org> · 7551a5d7
      bdash authored
              Reviewed by Mark Rowe.
      
              Fix compilation of the CURL backend after the removing of accessors from ResourceHandle in r24202
      
              * platform/network/curl/ResourceHandleManager.cpp:
              (WebCore::ResourceHandleManager::setupPOST):
              (WebCore::ResourceHandleManager::startJob):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24236 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7551a5d7
    • ggaren's avatar
      Reviewed by Oliver Hunt. · a839520e
      ggaren authored
              
              Made the leaks tests pass on Leopard.
      
              * Scripts/run-webkit-tests: Added some leaks to exclude on Leopard.
              * Scripts/run-leaks: Updated parser for slight change in text output.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24235 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a839520e
    • bdash's avatar
      2007-07-12 Mark Rowe <mrowe@apple.com> · 99605cb0
      bdash authored
              Reviewed by Darin.
      
              <rdar://problem/5327189> Logic error in DeprecatedString::to{,U}Int{,64} can lead to reading past end of buffer
      
              The fix for reading past the end of the buffer is to verify we are not at the end of the string before checking
              for a leading '+' character.  Rather than fixing the logic error in four nearly-identical functions I chose to
              extract the common functionality into the toIntegralType helper function which the four functions call through to.
      
              * platform/DeprecatedString.cpp:
              (WebCore::isCharacterAllowedInBase):
              (WebCore::toIntegralType):
              (WebCore::DeprecatedString::toInt):
              (WebCore::DeprecatedString::toInt64):
              (WebCore::DeprecatedString::toUInt):
              (WebCore::DeprecatedString::toUInt64):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24234 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      99605cb0
    • sfalken's avatar
      Bump version for submit · 7d5c391e
      sfalken authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24232 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7d5c391e
  2. 11 Jul, 2007 29 commits
    • staikos's avatar
      remove two unused variables and fix combobox rendering · 0605a4a6
      staikos authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24229 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0605a4a6
    • oliver's avatar
      Reviewed by Maciej · dbea067d
      oliver authored
              Fix for <rdar://problem/5329712> GMail crash when trying to compose new message
      
              * platform/win/FontDataWin.cpp:
              (WebCore::FontData::containsCharacters):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24228 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dbea067d
    • ap's avatar
      Reviewed by Darin. · 822a1a90
      ap authored
              http://bugs.webkit.org/show_bug.cgi?id=14584
              XMLHttpRequest treats null login/password incorrectly
      
              Test: http/tests/xmlhttprequest/null-auth.php
      
              * xml/xmlhttprequest.cpp:
              (WebCore::XMLHttpRequest::open):
              * xml/xmlhttprequest.h:
              Split the open() method into three to distinguish between missing and null credentials.
      
              * bindings/js/JSXMLHttpRequest.cpp:
              (KJS::JSXMLHttpRequestPrototypeFunction::callAsFunction): Call the appropriate open().
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24227 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      822a1a90
    • staikos's avatar
      Fix build in debug mode · ba198e1c
      staikos authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24226 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ba198e1c
    • ddkilzer's avatar
      2007-07-11 David Kilzer <ddkilzer@apple.com> · ea959e1d
      ddkilzer authored
              Reviewed by Maciej.
      
              Update the iExploder list of CSS properties after box-sizing was renamed to
              -webkit-box-sizing in r21026 to fix <rdar://problem/4667227>.
      
              * iExploder/htdocs/cssproperties.in:  Added -webkit-box-sizing.  Both box-sizing and
              -moz-box-sizing remain.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24225 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ea959e1d
    • staikos's avatar
      Make it compile · 41fe20b9
      staikos authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24224 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      41fe20b9
    • oliver's avatar
      Build fix for windows · 12bd29be
      oliver authored
              * page/Frame.cpp:
              (WebCore::Frame::firstRectForRange):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24223 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      12bd29be
    • oliver's avatar
      Reviewed by Maciej. · f15ee260
      oliver authored
              Fix <rdar://problem/5329481> Character range rect code for IME support needs to be crossplatform
      
              Move -[WebCoreFrameBridge firstRectForDOMRange:] to Frame::firstRectForRange
      
              * page/Frame.cpp:
              (WebCore::Frame::firstRectForRange):
              * page/Frame.h:
              * page/mac/WebCoreFrameBridge.mm:
              (-[WebCoreFrameBridge firstRectForDOMRange:]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24222 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f15ee260
    • thatcher's avatar
      Reviewed by Oliver. · e85b910b
      thatcher authored
              <rdar://problem/5108789> WEBVIEW: Drawing artifacts when dragging in IB
      
              Interface Builder 3 is relying on KVO notifications for frameOrigin and frameSize,
              among other standard NSView keys. Change automaticallyNotifiesObserversForKey to 
              return NO only for keys WebView manually fires notifications for.
      
              * WebView/WebView.mm:
              (+[WebView automaticallyNotifiesObserversForKey:]): Selectivly return NO for keys we manually fire.
              (-[WebView _declaredKeys]): Code clean up.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24216 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e85b910b
    • sfalken's avatar
      Static analysis build fix. · 9f4a91fc
      sfalken authored
              
              Only specify /analyze (PREfast) if it is available.
              Prevents entire project from rebuilding each time.        
      
              Reviewed by Hyatt.
      
              * WebKit.vcproj/WebKit.vcproj:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24215 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9f4a91fc
    • sfalken's avatar
      Static analysis build fix. · 4ce8179d
      sfalken authored
              
              Only specify /analyze (PREfast) if it is available.
              Prevents entire project from rebuilding each time.        
      
              Reviewed by Hyatt.
      
              * WebCore.vcproj/WebCore.vcproj:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24214 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4ce8179d
    • staikos's avatar
      Make comboboxes update when the current item is changed. · ab6fa908
      staikos authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24213 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ab6fa908
    • staikos's avatar
      b57f184f
    • staikos's avatar
      Fix build with assertions. · 07be2970
      staikos authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24211 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      07be2970
    • darin's avatar
      top level: · 0284cafd
      darin authored
              Reviewed by Darin.
      
              As of http://bugs.webkit.org/show_bug.cgi?id=14527 move the
              WebCore/ForwardingHeader/JavaScriptCore to JavaScriptCore
      
              * WebKit.pri: Adjust INCLUDEPATH
      
      JavaScriptCore:
      
              Reviewed by Darin.
      
              As of http://bugs.webkit.org/show_bug.cgi?id=14527 move the
              WebCore/ForwardingHeader/JavaScriptCore to JavaScriptCore
      
              * ForwardingHeaders: Added.
              * ForwardingHeaders/JavaScriptCore: Copied from WebCore/ForwardingHeaders/JavaScriptCore.
      
      WebCore:
      
              Reviewed by Darin.
      
              As of http://bugs.webkit.org/show_bug.cgi?id=14527 move the
              WebCore/ForwardingHeader/JavaScriptCore to JavaScriptCore
      
              * ForwardingHeaders/JavaScriptCore: Removed.
              * ForwardingHeaders/JavaScriptCore/APICast.h: Removed.
              * ForwardingHeaders/JavaScriptCore/JSBase.h: Removed.
              * ForwardingHeaders/JavaScriptCore/JSContextRef.h: Removed.
              * ForwardingHeaders/JavaScriptCore/JSLock.h: Removed.
              * ForwardingHeaders/JavaScriptCore/JSObjectRef.h: Removed.
              * ForwardingHeaders/JavaScriptCore/JSStringRef.h: Removed.
              * ForwardingHeaders/JavaScriptCore/JSStringRefCF.h: Removed.
              * ForwardingHeaders/JavaScriptCore/JSValueRef.h: Removed.
              * ForwardingHeaders/JavaScriptCore/JavaScriptCore.h: Removed.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24210 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0284cafd
    • andersca's avatar
      Fix build. · 012c7799
      andersca authored
              
              * platform/network/cf/ResourceHandleCFNet.cpp:
              (WebCore::willSendRequest):
              (WebCore::didReceiveResponse):
              (WebCore::didReceiveData):
              (WebCore::didFinishLoading):
              (WebCore::didFail):
              (WebCore::didReceiveChallenge):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24209 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      012c7799
    • staikos's avatar
      Another build fix. · 128c1c28
      staikos authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24208 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      128c1c28
    • staikos's avatar
      Repair the build. · 49eda87c
      staikos authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24207 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      49eda87c
    • adele's avatar
      Reviewed by Darin. · 81ade7d5
      adele authored
              Fix for <rdar://problem/5230188> REGRESSION: Active/inactive marked text is not distinguished in textfields and textareas
      
              We were previously trying to leave room for 1px of space between the text and the underline.
              This change removes that requirement so that if we don't have room for the extra space, we still draw the thick underline
              touching the text.
      
              * rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paintMarkedTextUnderline):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24206 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      81ade7d5
    • andersca's avatar
      Reviewed by Darin and Geoff. · b0a00ff2
      andersca authored
              <rdar://problem/5313508>
              REGRESSION (Leopard): http/tests/xmlhttprequest/basic-auth.html hangs
              
              Leopard Foundation now ignores credentials passed in as part of the URL so we need to pass them ourselves.
              
              For the asynchronous case, we simply keep track of the URL and if it has a user name and password, we
              pass those if we're asked to authenticate.
                      
              For the synchronous case, implement a new connection delegate and run it in a separate mode so 
              no other sources will fire.
      
              * platform/network/mac/ResourceHandleMac.mm:
              (WebCore::ResourceHandle::loadResourceSynchronously):
              (-[WebCoreResourceHandleAsDelegate dealloc]):
              (-[WebCoreResourceHandleAsDelegate connection:willSendRequest:redirectResponse:]):
              (-[WebCoreResourceHandleAsDelegate connection:didReceiveAuthenticationChallenge:]):
              (-[WebCoreSynchronousLoader _isDone]):
              (-[WebCoreSynchronousLoader dealloc]):
              (-[WebCoreSynchronousLoader connection:willSendRequest:redirectResponse:]):
              (-[WebCoreSynchronousLoader connection:didReceiveAuthenticationChallenge:]):
              (-[WebCoreSynchronousLoader connection:didReceiveResponse:]):
              (-[WebCoreSynchronousLoader connection:didReceiveData:]):
              (-[WebCoreSynchronousLoader connectionDidFinishLoading:]):
              (-[WebCoreSynchronousLoader connection:didFailWithError:]):
              (-[WebCoreSynchronousLoader _data]):
              (-[WebCoreSynchronousLoader _response]):
              (-[WebCoreSynchronousLoader _error]):
              (+[WebCoreSynchronousLoader loadRequest:returningResponse:error:]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24205 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b0a00ff2
    • andersca's avatar
      Reviewed by Geoff. · 6f9db516
      andersca authored
              Create the lock file in a writable directory.
              
              * http/conf/apache2-httpd.conf:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24204 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6f9db516
    • darin's avatar
      Reviewed by Sam Weinig. · 9ac7411b
      darin authored
              - fix <rdar://problem/5315265> REGRESSION: Leopard launch time -
                there are about 190 stats of icudt36b files during launch
      
              * platform/TextEncodingRegistry.cpp: (WebCore::atomicCanonicalTextEncodingName):
              Add a special case for the empty string so we don't load the extended text
              encodings just so we can return 0 for that case.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24203 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9ac7411b
    • andersca's avatar
      Reviewed by Darin. · 77bc1b3e
      andersca authored
              Remove a bunch of unneeded accessors from ResourceHandle.
              
              * loader/icon/IconLoader.cpp:
              (WebCore::IconLoader::didReceiveResponse):
              (WebCore::IconLoader::didFail):
              (WebCore::IconLoader::didFinishLoading):
              * platform/network/ResourceHandle.cpp:
              * platform/network/ResourceHandle.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24202 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      77bc1b3e
    • zimmermann's avatar
      Reviewed by Mark. · 7305d1c0
      zimmermann authored
      Forwardport the hash table fix from CodeGeneratorJS.pm to create_hash_table.
      Reran run-jsc-tests, couldn't find any regressions. Suggested by Darin.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24198 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7305d1c0
    • justing's avatar
      LayoutTests: · 11881d29
      justing authored
              Reviewed by Darin.
              
              <rdar://problem/5234383> REGRESSION: Sentence breaker method returning entire document length
      
              * editing/selection/5234383-1-expected.checksum: Added.
              * editing/selection/5234383-1-expected.png: Added.
              * editing/selection/5234383-1-expected.txt: Added.
              * editing/selection/5234383-1.html: Added.
              * editing/selection/5234383-2-expected.checksum: Added.
              * editing/selection/5234383-2-expected.png: Added.
              * editing/selection/5234383-2-expected.txt: Added.
              * editing/selection/5234383-2.html: Added.
      
      WebCore:
      
              Reviewed by Darin.
              
              <rdar://problem/5234383> REGRESSION: Sentence breaker method returning entire document length
              
              The functions for moving the caret to the next/previous sentence boundary
              were in many cases moving to the beginning/end of the document.  The functions that 
              should move the caret to an equivalent position in the next/previous sentence behaved
              like the aforementioned functions ought to.  Put the code from the second two functions
              in the first and made sure that the second two are properly FIXMEd.  They're rarely 
              used (filed 5323691).
              
              * editing/SelectionController.cpp:
              (WebCore::SelectionController::modify): Added an option for sentenceBoundary granularity,
              so that we can test the functions that were broken from JS.
              * editing/visible_units.cpp:
              (WebCore::startOfSentence): Removed the FIXME about 5234383.
              (WebCore::endSentenceBoundary): Make this function do what nextSentencePositionBoundary
              current does.
              (WebCore::endOfSentence): Removed the FIXME about 5234383.
              (WebCore::previousSentencePosition): Removed an incorrect FIXME.
              (WebCore::nextSentencePositionBoundary): Tweaked FIXME.  This function is
              identical, not close to endSentenceBoundary.
              (WebCore::nextSentencePosition): Removed an incorrect FIXME.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24187 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      11881d29
    • antti's avatar
      Reviewed by John. · 7ea93654
      antti authored
              
              Fix <rdar://problem/4570550>
              Hang in layout/layoutBlock/layoutBlockChildren preparing to print certain Mail messages
              
              When printing from Mail, WebHTMLView is a subview of the view that is actually printed and does not 
              receive calls that would set it to printing mode. Method adjustPageHeightNew is called repeatedly (for each page) during
              printing and it enables printing mode temporarily for each call. This triggers two full style recalcs and layouts
              each time making printing at least O(n^2). 
      
              Instead of enabling printing mode and resetting it back immediatly do the resetting asynchronously, after
              all adjustPageHeightNew calls are done. Normal Safari printing is not affected as adjustPageHeightNew is only
              called in case WebHTMLView is embedded in the view that is being printed.
              
              No automatic test possible, requires printing and non-Safari client.
              
              * WebView/WebHTMLView.mm:
              (-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24186 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7ea93654
    • rwlbuis's avatar
      Reviewed by Darin. · 8c3ac3cc
      rwlbuis authored
              http://bugs.webkit.org/show_bug.cgi?id=14453
              REGRESSION: www.nzherald.co.nz almost all the formating is gone
      
              Be less strict for the hex color definition.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24185 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8c3ac3cc
    • rwlbuis's avatar
      Reviewed by Oliver. · 7272ff19
      rwlbuis authored
              Forgot to commit this as part of commit r24146. Now we are sure
              createElement creates elements in the xhtml namespace only.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24184 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7272ff19
    • ggaren's avatar
      Reviewed by Maciej Stachowiak. · 61b51b49
      ggaren authored
              - Fixed <rdar://problem/5049509> REGRESSION(10.4.9-9A377a): REAP Suite 
              installer shows empty modal alert window (hangs) if user cancels during
              "installing shared components" phase
              
              Added Adobe installers to the family of apps that need a data load
              loading quirk.
              
              Added a linked-on-or-after check because this code is no longer 
              Tiger-only.
              
              I tested this code on Tiger and Leopard.
      
              * Misc/WebKitVersionChecks.h:
              * WebKit.xcodeproj/project.pbxproj:
              * WebView/WebDocumentLoaderMac.mm:
              (needsDataLoadWorkaround):
              (WebDocumentLoaderMac::setDataSource):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24183 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      61b51b49
  3. 10 Jul, 2007 2 commits
    • weinig's avatar
      LayoutTests: · 48fa9303
      weinig authored
              Reviewed by Oliver.
      
              * fast/dom/Window/get-set-properties-expected.txt: Added.
              * fast/dom/Window/get-set-properties.html: Added.
      
      WebCore:
      
              Reviewed by Oliver.
      
              Move more attributes from the pure JS bindings in KJS::Window
              to the implementation in DOMWindow and autogenerate the new bindings
      
              Test: fast/dom/Window/get-set-properties.html
      
              * bindings/js/JSDOMWindowCustom.cpp:
              (WebCore::JSDOMWindow::customGetOwnPropertySlot): Change to use propHashTable in
              JSDOMWindow instead of KJS::Window
              * bindings/js/kjs_window.cpp:
              (KJS::Window::getValueProperty):
              (KJS::Window::put):
              * bindings/js/kjs_window.h:
              (KJS::Window::):
              * bindings/scripts/CodeGeneratorJS.pm: Cleanup getValueProperty and put generation
              to reduce code duplication. 
              * page/DOMWindow.cpp:
              (WebCore::DOMWindow::closed):
              (WebCore::DOMWindow::length):
              (WebCore::DOMWindow::name):
              (WebCore::DOMWindow::setName):
              (WebCore::DOMWindow::status):
              (WebCore::DOMWindow::setStatus):
              (WebCore::DOMWindow::defaultStatus):
              (WebCore::DOMWindow::setDefaultStatus):
              * page/DOMWindow.h:
              (WebCore::DOMWindow::defaultstatus):
              (WebCore::DOMWindow::setDefaultstatus):
              * page/DOMWindow.idl:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24182 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      48fa9303
    • weinig's avatar
      LayoutTests: · 76781f60
      weinig authored
              Reviewed by Geoff.
      
              Tests for <rdar://problem/5326791>
      
              * http/tests/security/cross-frame-access-expected.txt:
              * http/tests/security/cross-frame-access-put-expected.txt: Added.
              * http/tests/security/cross-frame-access-put.html: Added.
              * http/tests/security/resources/cross-frame-iframe-for-put-test.html: Added.
      
      WebCore:
      
              Reviewed by Geoff.
      
              Fix for <rdar://problem/5326791> XSS vulnerability: ability to set window.defaultStatus,
              window.defaultstatus and window.status cross domains
      
              Test: http/tests/security/cross-frame-access-put.html
      
              * bindings/js/kjs_window.cpp:
              (KJS::Window::put): Adds isSafeScript check for defaultStatus,
              defaultstatus and status cases.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24181 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      76781f60