1. 27 Apr, 2009 24 commits
    • ddkilzer@apple.com's avatar
      Consolidate runtime application checks for Apple Mail and Safari · 8b32f3f1
      ddkilzer@apple.com authored
              Reviewed by Mark Rowe and Darin Adler.
      
      WebCore:
      
              * WebCore.base.exp: Added exports.
              * WebCore.xcodeproj/project.pbxproj: Added
              RuntimeApplicationChecks.{h|mm} source files to the project.
              * page/mac/EventHandlerMac.mm:
              (WebCore::EventHandler::needsKeyboardEventDisambiguationQuirks):
              Removed local checkedSafari and isSafari variables and switched
              to use applicationIsSafari().
              * platform/mac/RuntimeApplicationChecks.h: Added.
              * platform/mac/RuntimeApplicationChecks.mm: Added.
              (WebCore::applicationIsAppleMail): Runtime application check for
              Apple Mail.
              (WebCore::applicationIsSafari): Runtime application check for
              Safari.
      
      WebKit:
      
              * WebCoreSupport/WebContextMenuClient.mm:
              (isAppleMail): Removed.
              (fixMenusToSendToOldClients): Switched to use
              applicationIsAppleMail().
              * WebView/WebFrame.mm:
              (-[WebFrame reload]): Switched to use applicationIsSafari().
              * WebView/WebPDFView.mm:
              (-[WebPDFView menuForEvent:]): Ditto.
              * WebView/WebResource.mm:
              (+[WebResource _needMailThreadWorkaroundIfCalledOffMainThread]):
              Switched to use applicationIsAppleMail().
              * WebView/WebView.mm:
              (runningLeopardMail): Ditto.
              (runningTigerMail): Ditto.
              (-[WebView _needsKeyboardEventDisambiguationQuirks]): Switched
              to use applicationIsSafari().
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@42909 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8b32f3f1
    • cfleizach@apple.com's avatar
      Bug 25374: AX: No AXValue change sent when text is auto-inserted · 79d75143
      cfleizach@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=25374
      
      Updated to fix regression test failures
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@42908 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      79d75143
    • xan@webkit.org's avatar
      2009-04-16 Xan Lopez <xlopez@igalia.com> · 0ea2f73e
      xan@webkit.org authored
              Reviewed by Gustavo Noronha.
      
              https://bugs.webkit.org/show_bug.cgi?id=21546
              [GTK] ATK accessibility enhancements
      
              Based on a patch by Alp Toker.
      
              Cover more WebCore role -> ATK role conversions.
      
              * page/gtk/AccessibilityObjectWrapperAtk.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@42907 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0ea2f73e
    • xan@webkit.org's avatar
      2009-04-18 Xan Lopez <xlopez@igalia.com> · 8591e072
      xan@webkit.org authored
              Reviewed by Gustavo Noronha.
      
              https://bugs.webkit.org/show_bug.cgi?id=21546
              [GTK] ATK accessibility enhancements
      
              Do not call ATK setters in the getters, just return the
              value. Among other things calling the setter will emit the notify
              signal, which is wrong.
      
              * page/gtk/AccessibilityObjectWrapperAtk.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@42906 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8591e072
    • xan@webkit.org's avatar
      2009-04-16 Xan Lopez <xlopez@igalia.com> · e43e70bd
      xan@webkit.org authored
              Reviewed by Gustavo Noronha.
      
              https://bugs.webkit.org/show_bug.cgi?id=21546
              [GTK] ATK accessibility enhancements
      
              Based on a patch by Alp Toker.
      
              Implement AtkImage interface.
      
              * page/gtk/AccessibilityObjectWrapperAtk.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@42905 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e43e70bd
    • kov@webkit.org's avatar
      2009-04-27 Gustavo Noronha Silva <gns@gnome.org> · 1e0c42e9
      kov@webkit.org authored
              Unreviewed debug build fix.
      
              * platform/gtk/gtk2drawing.c:
              (moz_gtk_toggle_paint):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@42904 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1e0c42e9
    • dglazkov@chromium.org's avatar
      2009-04-27 Dimitri Glazkov <dglazkov@chromium.org> · 9fedfc29
      dglazkov@chromium.org authored
              Build fix.
      
              https://bugs.webkit.org/show_bug.cgi?id=25382
              Remove direct reference to CallFrame.h include to pacify Win build.
      
              * bindings/js/JSDOMBinding.h: Removed ScriptState.h include.
              * bindings/js/ScriptState.h: Replaced CallFrame.h with JSDOMBinding.h
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@42903 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9fedfc29
    • cfleizach@apple.com's avatar
    • dglazkov@chromium.org's avatar
      2009-04-27 Dimitri Glazkov <dglazkov@chromium.org> · 9611152f
      dglazkov@chromium.org authored
              Reviewed by Eric Seidel.
      
              https://bugs.webkit.org/show_bug.cgi?id=25382
              Move scriptStateFromNode to ScriptState.
      
              * bindings/js/JSDOMBinding.cpp: Moved scriptStateFromNode to ScriptState.
              * bindings/js/JSDOMBinding.h: Ditto.
              * bindings/js/ScriptState.cpp:
              (WebCore::scriptStateFromNode): Added.
              * bindings/js/ScriptState.h: Ditto.
              * bindings/v8/ScriptState.cpp:
              (WebCore::scriptStateFromNode): Added.
              * bindings/v8/ScriptState.h: Ditto.
              * dom/NodeFilter.h: Removed JSDOMBinding header include.
              * dom/NodeIterator.h: Ditto.
              * dom/TreeWalker.h: Ditto.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@42901 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9611152f
    • cfleizach@apple.com's avatar
      Bug 25428: 5 crashes in DumpRenderTree at com.apple.WebCore •... · 03136a68
      cfleizach@apple.com authored
      Bug 25428: 5 crashes in DumpRenderTree at com.apple.WebCore • -[AccessibilityObjectWrapper accessibilityAttributeValue:] + 830
      https://bugs.webkit.org/show_bug.cgi?id=25428
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@42900 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      03136a68
    • andersca@apple.com's avatar
      2009-04-27 Anders Carlsson <andersca@apple.com> · 69587b8f
      andersca@apple.com authored
              Reviewed by Adam Roben.
      
              Update the example plug-in for new changes to the Cocoa event model.
              
              * NetscapeCocoaPlugin/main.m:
              (handleDraw):
              (handleMouseEvent):
              (NPP_HandleEvent):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@42899 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      69587b8f
    • kdecker@apple.com's avatar
      Fix the Tiger build. · f5178c8e
      kdecker@apple.com authored
              
              * Plugins/WebNetscapePluginView.mm: The base class of WebNetscapePluginView.mm, WebBaseNetscapePluginView, already implemented 
              the two methods below. But the Tiger compiler didn't know that. 
              (-[WebNetscapePluginView webView]): 
              (-[WebNetscapePluginView webFrame]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@42898 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f5178c8e
    • kdecker@apple.com's avatar
      Reviewed by Anders Carlsson. · 20b1d1fb
      kdecker@apple.com authored
              <rdar://problem/6352982>
              
              * Plugins/WebBaseNetscapePluginView.mm: Removed checkIfAllowedToLoadURL:frame:callbackFunc, cancelCheckIfAllowedToLoadURL, and 
              _webPluginContainerCancelCheckIfAllowedToLoadRequest from the base class. These methods now exist in the subclass WebNetscapePluginView.
              
              Added WebNetscapeContainerCheckContextInfo, which is used as a "contextInfo" object in 
              -[WebNetscapePluginView checkIfAllowedToLoadURL:frame:callbackFunc:]
              * Plugins/WebNetscapeContainerCheckContextInfo.h: Added.
              * Plugins/WebNetscapeContainerCheckContextInfo.mm: Added.
              (-[WebNetscapeContainerCheckContextInfo initWithCheckRequestID:callbackFunc:]): Added desiginated initializer.
              (-[WebNetscapeContainerCheckContextInfo checkRequestID]): Added. Returns the checkRequestID.
              (-[WebNetscapeContainerCheckContextInfo callback]): Added. Returns the callback.
              
              * Plugins/WebNetscapePluginView.h: Added two new ivars: _containerChecksInProgress and _currentContainerCheckRequestID.
              * Plugins/WebNetscapePluginView.mm: #import both WebPluginContainerCheck.h and WebNetscapeContainerCheckContextInfo.h
              
              (-[WebNetscapePluginView checkIfAllowedToLoadURL:frame:callbackFunc:]): Added. This is the implementation of WKN_CheckIfAllowedToLoadURL.
              Here, we increment the request ID and start the container check.
              
              (-[WebNetscapePluginView _containerCheckResult:contextInfo:]): Added. This is a callback method for WebPluginContainerCheck.
              It's where we actually call into the plug-in and provide the allow-or-deny result.
          
              (-[WebNetscapePluginView cancelCheckIfAllowedToLoadURL:]): Added. This is the implementation of WKN_CancelCheckIfAllowedToLoadURL. 
              Here we lookup the check, cancel it, and remove it from _containerChecksInProgress.
              
              (-[WebNetscapePluginView _webPluginContainerCancelCheckIfAllowedToLoadRequest:]): Added. WebPluginContainerCheck automatically calls
              this method after invoking our _containerCheckResult: selector. It works this way because calling -[WebPluginContainerCheck cancel] allows
              it to do it's teardown process.
              
              (-[WebNetscapePluginView fini]): Release _containerChecksInProgress ivar.
              
              * Plugins/WebPluginContainerCheck.h: Removed initWithRequest: method from header; no client was using this method directly.
              * Plugins/WebPluginContainerCheck.mm: 
              (+[WebPluginContainerCheck checkWithRequest:target:resultObject:selector:controller:contextInfo:]): Added optional contextInfo parameter.
              (-[WebPluginContainerCheck _continueWithPolicy:]): If there's a contextInfo object, pass it as a parameter to resultSelector.
              (-[WebPluginContainerCheck cancel]): Release _contextInfo ivar.
              (-[WebPluginContainerCheck contextInfo]): Added new method. Returns the contextInfo object, if one so exists.
              * Plugins/WebPluginController.mm:
              (-[WebPluginController _webPluginContainerCheckIfAllowedToLoadRequest:inFrame:resultObject:selector:]): Pass nil for contextInfo. WebKit-style
              plug-ins do not need additional context information.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@42897 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      20b1d1fb
    • ap@webkit.org's avatar
      Reviewed by Darin Adler. · 50189dd5
      ap@webkit.org authored
              https://bugs.webkit.org/show_bug.cgi?id=25399
              <rdar://problem/6633943> REGRESSION: Many crashes reported accessing Lexis/Nexis database,
              beneath WebCore::Cache::evict
      
              The crash happened because a cached resource handle was removed from a document's cached
              resources map twice recursively, so a destructor was called for a value in a deleted bucket.
              The first call was from Cache::evict, and when destroying CachedResourceHandle destroyed
              CachedResource, DocLoader::removeCachedResource() was called again, with HashMap being in
              an inconsistent state.
      
              I couldn't fully reconstruct the loading sequence to make a test.
      
              * loader/Cache.cpp:
              (WebCore::Cache::revalidateResource): Assert that the resource being revalidated is in cache
              (it makes no sense to revalidate one that isn't).
              (WebCore::Cache::evict): Don't remove the resource from document's map. Removing a resource
              from the cache in no way implies that documents no longer use the old version. This fixes the
              crash, and also fixes many cases of resource content being unavailable in Web Inspector.
      
              * loader/CachedResource.h:
              (WebCore::CachedResource::setInCache): When bringing a revalidated resource back to cache,
              reset m_isBeingRevalidated to maintain the invariant of resources being revalidated never
              being in cache. This fixes another assertion I saw on LexisNexis search: in rare cases,
              switchClientsToRevalidatedResource() results in the same resource being requested again,
              but we were only enforcing CachedResource invariants after calling this function.
              (WebCore::CachedResource::unregisterHandle): Assert that the counter doesn't underflow.
      
              * loader/DocLoader.cpp: (WebCore::DocLoader::removeCachedResource): Assert that the passed
              resource is removed, not some other resource that happens to have the same URL (this used to
              fail on LexisNexis search before this patch).
      
              * loader/ImageDocument.cpp: (WebCore::ImageTokenizer::write): Replaced ASSERT_NOT_REACHED
              with notImplemented(). This method can be legally called via document.write(), and should
              work. LexisNexis takes this code path, but apparently has a fallback for Safari, so it
              doesn't affect site functionality.
      
              * loader/CachedResource.cpp:
              (WebCore::CachedResource::clearResourceToRevalidate): Don't assert that m_resourceToRevalidate
              is being revalidated - this may no longer be true, because we now reset this member in
              CachedResource::setInCache().
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@42896 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      50189dd5
    • mitz@apple.com's avatar
      Reviewed by Sam Weinig. · 45d9e103
      mitz@apple.com authored
              - make BidiContext a RefCounted class, starting with a refcount of 1,
                and share the root BidiContexts.
      
              * platform/graphics/GraphicsContext.cpp:
              (WebCore::GraphicsContext::drawBidiText): Use BidiContext::create().
              * platform/text/BidiContext.cpp:
              (WebCore::BidiContext::create): Added. For the four "root" contexts,
              returns a reference to a shared static BidiContext.
              * platform/text/BidiContext.h:
              (WebCore::BidiContext::BidiContext):
              * platform/text/BidiResolver.h:
              (WebCore::::commitExplicitEmbedding): Use BidiContext::create().
              * rendering/bidi.cpp:
              (WebCore::RenderBlock::determineStartPosition): Ditto.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@42895 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      45d9e103
    • jmalonzo@webkit.org's avatar
      2009-04-27 Jan Michael Alonzo <jmalonzo@webkit.org> · 4dc3913d
      jmalonzo@webkit.org authored
              Rubber-stamped by Gustavo Noronha.
      
              Build fix for r42893: change GDK_exclaim to GDK_exclam
      
              * platform/chromium/KeyCodeConversionGtk.cpp:
              (WebCore::windowsKeyCodeForKeyEvent):
              * platform/gtk/KeyEventGtk.cpp:
              (WebCore::windowsKeyCodeForKeyEvent):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@42894 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4dc3913d
    • jmalonzo@webkit.org's avatar
      2009-04-27 Fumitoshi Ukai <ukai@google.com> · b32abb7d
      jmalonzo@webkit.org authored
              Reviewed by Xan Lopez.
      
              Fix wrong key code conversion.
      
              Missing conversion for GDK_exlaim ('!').
              Parens are opposite: GDK_parenleft is open paren '('
              and GDK_parenright is close paren ')'.
              https://bugs.webkit.org/show_bug.cgi?id=25367
      
              * platform/chromium/KeyCodeConversionGtk.cpp:
              (WebCore::windowsKeyCodeForKeyEvent):
              * platform/gtk/KeyEventGtk.cpp:
              (WebCore::windowsKeyCodeForKeyEvent):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@42893 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b32abb7d
    • jmalonzo@webkit.org's avatar
      2009-04-27 Jan Michael Alonzo <jmalonzo@webkit.org> · db45e8e9
      jmalonzo@webkit.org authored
              Reviewed by Gustavo Noronha.
      
              [Gtk] gtkdrawing update
              https://bugs.webkit.org/show_bug.cgi?id=25408
      
              Update to the 25 Apr 2009 version of gtk2drawing.c and
              gtkdrawing.h from Mozilla (http://hg.mozilla.org/mozilla-central)
      
              * platform/gtk/gtk2drawing.c:
              (setup_widget_prototype):
              (moz_gtk_get_combo_box_entry_arrow):
              (ensure_toolbar_widget):
              (ensure_tree_header_cell_widget):
              (moz_gtk_init):
              (moz_gtk_button_get_inner_border):
              (moz_gtk_toggle_paint):
              (moz_gtk_caret_paint):
              (moz_gtk_entry_paint):
              (moz_gtk_tree_header_cell_paint):
              (moz_gtk_combo_box_paint):
              (moz_gtk_toolbar_separator_paint):
              (moz_gtk_menu_separator_paint):
              (moz_gtk_get_widget_border):
              (moz_gtk_get_tab_scroll_arrow_size):
              (moz_gtk_get_toolbar_separator_width):
              (moz_gtk_get_menu_separator_height):
              (moz_gtk_widget_paint):
              (moz_gtk_shutdown):
              * platform/gtk/gtkdrawing.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@42892 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      db45e8e9
    • jmalonzo@webkit.org's avatar
      2009-04-27 Jan Michael Alonzo <jmalonzo@webkit.org> · e4e4f8ad
      jmalonzo@webkit.org authored
              Reviewed by Gustavo Noronha.
      
              [GTK] Make layout tests / jsc tests usable without build-webkit
              https://bugs.webkit.org/show_bug.cgi?id=21784
      
              This requires WEBKITOUTPUTDIR to be set to the build directory.
              Set the location of the product dir to the location pointed to by
              WEBKITOUTPUTDIR.
      
              * Scripts/webkitdirs.pm:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@42891 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e4e4f8ad
    • kov@webkit.org's avatar
      2009-04-27 Gustavo Noronha Silva <gns@gnome.org> · 1150cca3
      kov@webkit.org authored
              Reviewed by Adam Roben.
      
              Use libsoup's facilities to resolve relative URLs, instead, since
              it is a more robust method.
      
              * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
              (LayoutTestController::queueLoad):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@42890 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1150cca3
    • kov@webkit.org's avatar
      2009-04-27 Gustavo Noronha Silva <gns@gnome.org> · 8614785e
      kov@webkit.org authored
              Reviewed by Xan Lopez.
      
              https://bugs.webkit.org/show_bug.cgi?id=25409
              [GTK] incorrectly fallsback on cancellation
      
              Check whether we should fallback also on didFailLoad, so that we
              don't get error pages showing up in parts of the content of some
              sites because of, for instance, location changes.
      
              * WebCoreSupport/FrameLoaderClientGtk.cpp:
              (WebKit::FrameLoaderClient::dispatchDidFailLoad):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@42889 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8614785e
    • kov@webkit.org's avatar
      2009-04-27 Gustavo Noronha Silva <gns@gnome.org> · 8f89dab3
      kov@webkit.org authored
              Reviewed by Xan Lopez.
      
              https://bugs.webkit.org/show_bug.cgi?id=25409
              [GTK] incorrectly fallsback on cancellation
      
              Correctly handle cancellation and frame loading interruption
              caused by policy change.  This also fixes
              fast/frames/location-change.html.
      
              * WebCoreSupport/FrameLoaderClientGtk.cpp:
              (WebKit::FrameLoaderClient::shouldFallBack):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@42888 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8f89dab3
    • ariya@webkit.org's avatar
      2009-04-27 Ariya Hidayat <ariya.hidayat@nokia.com> · 6cdca762
      ariya@webkit.org authored
              Reviewed by Tor Arne Vestbø.
      
              https://bugs.webkit.org/show_bug.cgi?id=18475
      
              [Qt] Widget painting should follow the layout direction (LTR, RTL)
              of the element style, not the application layout direction.
      
              * platform/qt/RenderThemeQt.cpp:
              (WebCore::RenderThemeQt::applyTheme):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@42887 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6cdca762
    • aroben@apple.com's avatar
      Windows Debug build fix · 7aa13b9e
      aroben@apple.com authored
              Not sure why the buildbots weren't affected by this problem.
      
              * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Let VS
              re-order the file list, and added JavaScriptCore[_debug].def to the
              project. This was not necessary for the fix, but made making the fix
              easier.
      
              * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
              Removed a function that no longer exists.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@42886 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7aa13b9e
  2. 26 Apr, 2009 11 commits
  3. 25 Apr, 2009 5 commits
    • kov@webkit.org's avatar
      2009-04-25 Gustavo Noronha Silva <gns@gnome.org> · 1c537be6
      kov@webkit.org authored
              Go back to disabling accessibility tests as a whole, since we have
              no real way of checking them, and no accessibilityController
              implementation.
      
              * platform/gtk/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@42874 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1c537be6
    • kov@webkit.org's avatar
      2009-04-25 Gustavo Noronha Silva <gns@gnome.org> · 90076202
      kov@webkit.org authored
              Disable tests that need eventSender, not yet implemented in our
              DumpRenderTree.
      
              * platform/gtk/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@42873 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      90076202
    • simon.fraser@apple.com's avatar
      2009-04-24 Simon Fraser <simon.fraser@apple.com> · d6af9987
      simon.fraser@apple.com authored
              Reviewed by Darin Adler
      
              https://bugs.webkit.org/show_bug.cgi?id=25390
      
              Fix point mapping and hit testing through transforms and perspective
              with ENABLE_3D_RENDERING. Previously the code did the more efficient
              move(), rather than getTransformFromContainer(), when the object had
              no transform. However, this skipped the application of perspective
              when the immediate child of the perspective element had no transform
              itself.
      
              Test: transforms/3d/point-mapping/3d-point-mapping-3.html
      
              * rendering/RenderBox.cpp:
              (WebCore::RenderBox::mapLocalToContainer):
              (WebCore::RenderBox::mapAbsoluteToLocalPoint):
              * rendering/RenderLayer.cpp:
              (WebCore::RenderLayer::createLocalTransformState):
              Call shouldUseTransformFromContainer() to determine if we need to
              go through the more expensive getTransformFromContainer() code
              path.
      
              * rendering/RenderObject.h:
              * rendering/RenderObject.cpp:
              (WebCore::RenderObject::shouldUseTransformFromContainer):
              New method that indicates whether we need use getTransformFromContainer()
              when mapping points through renderers, and hit testing.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@42872 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d6af9987
    • beidson@apple.com's avatar
      2009-04-25 Brady Eidson <beidson@apple.com> · e619dd96
      beidson@apple.com authored
              Reviewed by Sam Weinig
      
              Some *obvious* style cleanup in my last patch.
      
              * History/WebBackForwardList.mm:
              (bumperCarBackForwardHackNeeded):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@42871 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e619dd96
    • beidson@apple.com's avatar
      2009-04-25 Brady Eidson <beidson@apple.com> · 4584de39
      beidson@apple.com authored
              Reviewed by Oliver Hunt
      
              <rdar://problem/6817607> BumperCar 2.2 crashes going back (invalid WebHistoryItem)
      
              BumperCar was holding a pointer to a WebHistoryItem they never retain, then later
              tried to go to it.  In some cases it would be dealloc'ed first.
              When WebHistoryItems were pure Objective-C they probably got away with this more often.
              With the WebCore/Obj-C mixed WebHistoryItems it's more likely to crash.
      
              * History/WebBackForwardList.mm:
              (bumperCarBackForwardHackNeeded):
              (-[WebBackForwardList backListWithLimit:]):  If this is BumperCar, hang on to the
                NSArray of WebHistoryItems until the next time this method is called.
              (-[WebBackForwardList forwardListWithLimit:]):  Ditto.
      
              * Misc/WebKitVersionChecks.h: Added WEBKIT_FIRST_VERSION_WITHOUT_BUMPERCAR_BACK_FORWARD_QUIRK.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@42870 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4584de39