1. 16 Mar, 2006 17 commits
    • darin's avatar
      Reviewed by Eric. · 8a2a58fd
      darin authored
              - removed KWQWindowWidget
              - changed most event handling to use references instead of pointers
              - chagned PageMac to no longer be a subclass of Page
      
              Yes, I know there's no detail in this ChangeLog entry.
              No, I don't plan to make a habit of doing things this way.
              Yes, this will probably break the Windows build again.
      
              * WebCore.xcodeproj/project.pbxproj:
              * bridge/mac/BrowserExtensionMac.mm:
              (WebCore::BrowserExtensionMac::createNewWindow):
              * bridge/mac/FrameViewMac.mm:
              * bridge/mac/MacFrame.h:
              * bridge/mac/MacFrame.mm:
              (WebCore::MacFrame::MacFrame):
              (WebCore::MacFrame::~MacFrame):
              (WebCore::MacFrame::wheelEvent):
              (WebCore::MacFrame::keyEvent):
              (WebCore::MacFrame::khtmlMousePressEvent):
              (WebCore::MacFrame::khtmlMouseMoveEvent):
              (WebCore::MacFrame::khtmlMouseReleaseEvent):
              (WebCore::MacFrame::mouseDown):
              (WebCore::MacFrame::mouseDragged):
              (WebCore::MacFrame::mouseUp):
              (WebCore::MacFrame::mouseMoved):
              (WebCore::MacFrame::sendContextMenuEvent):
              (WebCore::MacFrame::setBridge):
              (WebCore::MacFrame::dragSourceMovedTo):
              (WebCore::MacFrame::dragSourceEndedAt):
              (WebCore::MacFrame::dispatchDragSrcEvent):
              * bridge/mac/PageMac.h: Removed.
              * bridge/mac/PageMac.mm: Added.
              (WebCore::Page::Page):
              (WebCore::Page::windowRect):
              (WebCore::Page::setWindowRect):
              * bridge/mac/WebCoreFrameBridge.h:
              * bridge/mac/WebCoreFrameBridge.mm:
              (-[WebCoreFrameBridge page]):
              (-[WebCoreFrameBridge initializeSettings:]):
              (globalPoint):
              (createMouseEventFromDraggingInfo):
              (-[WebCoreFrameBridge dragOperationForDraggingInfo:]):
              (-[WebCoreFrameBridge dragExitedWithDraggingInfo:]):
              (-[WebCoreFrameBridge concludeDragForDraggingInfo:]):
              (-[WebCoreFrameBridge dragSourceMovedTo:]):
              (-[WebCoreFrameBridge dragSourceEndedAt:operation:]):
              * bridge/mac/WebCoreFrameNamespaces.mm:
              (WebCore::):
              * bridge/mac/WebCorePageBridge.h:
              * bridge/mac/WebCorePageBridge.mm:
              (-[WebCorePageBridge init]):
              * dom/DocumentImpl.cpp:
              (WebCore::DocumentImpl::prepareMouseEvent):
              (WebCore::DocumentImpl::defaultEventHandler):
              * dom/DocumentImpl.h:
              * dom/NodeImpl.cpp:
              (WebCore::NodeImpl::dispatchMouseEvent):
              (WebCore::NodeImpl::dispatchKeyEvent):
              (WebCore::NodeImpl::dispatchWheelEvent):
              * dom/NodeImpl.h:
              * dom/dom2_eventsimpl.cpp:
              (WebCore::KeyboardEventImpl::KeyboardEventImpl):
              * dom/dom2_eventsimpl.h:
              (WebCore::KeyboardEventImpl::keyEvent):
              * khtml/ecma/kjs_window.cpp:
              (KJS::Window::getValueProperty):
              (KJS::WindowFunc::callAsFunction):
              * khtml/html/html_inlineimpl.cpp:
              (WebCore::HTMLAnchorElementImpl::defaultEventHandler):
              * ksvg2/svg/SVGDocumentImpl.cpp:
              * ksvg2/svg/SVGDocumentImpl.h:
              * kwq/KWQWindowWidget.h:
              * kwq/KWQWindowWidget.mm: Removed.
              * page/Frame.cpp:
              (WebCore::Frame::selectClosestWordFromMouseEvent):
              (WebCore::Frame::handleMousePressEventDoubleClick):
              (WebCore::Frame::handleMousePressEventTripleClick):
              (WebCore::Frame::handleMousePressEventSingleClick):
              (WebCore::Frame::khtmlMousePressEvent):
              (WebCore::Frame::handleMouseMoveEventSelection):
              (WebCore::Frame::khtmlMouseMoveEvent):
              (WebCore::Frame::khtmlMouseReleaseEvent):
              (WebCore::Frame::khtmlMouseDoubleClickEvent):
              (WebCore::Frame::passWidgetMouseDownEventToWidget):
              * page/Frame.h:
              * page/FrameView.cpp:
              (WebCore::FrameView::viewportMousePressEvent):
              (WebCore::FrameView::viewportMouseDoubleClickEvent):
              (WebCore::FrameView::viewportMouseMoveEvent):
              (WebCore::FrameView::viewportMouseReleaseEvent):
              (WebCore::FrameView::dispatchDragEvent):
              (WebCore::FrameView::updateDragAndDrop):
              (WebCore::FrameView::cancelDragAndDrop):
              (WebCore::FrameView::performDragAndDrop):
              (WebCore::FrameView::dispatchMouseEvent):
              (WebCore::FrameView::viewportWheelEvent):
              * page/FrameView.h:
              * page/MouseEventWithHitTestResults.h:
              (WebCore::MouseEventWithHitTestResults::MouseEventWithHitTestResults):
              (WebCore::MouseEventWithHitTestResults::event):
              * page/Page.cpp:
              (WebCore::Page::init):
              * page/Page.h:
              (WebCore::Page::bridge):
              * platform/KeyEvent.h:
              (WebCore::KeyEvent::isAutoRepeat):
              * platform/MouseEvent.h:
              (WebCore::MouseEvent::MouseEvent):
              * platform/mac/KeyEventMac.mm:
              (WebCore::KeyEvent::KeyEvent):
              * platform/win/TemporaryLinkStubs.cpp:
              (FrameView::isFrameView):
              * rendering/render_form.cpp:
              (WebCore::RenderFormElement::clicked):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@13342 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8a2a58fd
    • bdakin's avatar
      Rubber stamped by Geoff. · 2776d5a9
      bdakin authored
              Another round of Mozilla table tests.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@13341 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2776d5a9
    • eseidel's avatar
      2006-03-16 Eric Seidel <eseidel@apple.com> · f825ec04
      eseidel authored
              Reviewed by darin.
      
              Add additional hackish Font, focusring and caret code.
              http://bugzilla.opendarwin.org/show_bug.cgi?id=7803
      
              * WebCore.vcproj/WebCore/WebCore.vcproj:
              * WebCore.vcproj/WebCore/build-generated-files.sh:
              * bindings/js/JSCanvasRenderingContext2DBase.cpp:
              * bridge/win/FrameWin.cpp:
              (WebCore::FrameWin::keyPress):
              * bridge/win/FrameWin.h:
              * html/CanvasRenderingContext2D.h:
              * platform/IntSize.h:
              * platform/KeyEvent.h:
              * platform/cairo/GraphicsContextCairo.cpp:
              (WebCore::GraphicsContext::drawArc):
              (WebCore::GraphicsContext::drawFocusRing):
              * platform/win/FontWin.cpp:
              (WebCore::hackishExtentForString):
              (WebCore::Font::floatWidth):
              (WebCore::convertRange):
              (WebCore::Font::drawText):
              (WebCore::Font::drawHighlightForText):
              (WebCore::Font::selectionRectForText):
              (WebCore::Font::checkSelectionPoint):
              (WebCore::Font::drawLineForText):
              (WebCore::Font::misspellingLineThickness):
              * platform/win/IntSizeWin.cpp: Added.
              (WebCore::IntSize::IntSize):
              (WebCore::IntSize::operator SIZE):
              * platform/win/ScrollViewWin.cpp:
              (WebCore::ScrollView::visibleContentRect):
              * platform/win/TemporaryLinkStubs.cpp:
              (Widget::disableFlushDrawing):
              (GraphicsContext::GraphicsContext):
              (QListBox::setSelected):
              (QListBox::sizeForNumberOfLines):
              (QListBox::isSelected):
              (QListBox::appendItem):
              (QListBox::doneAppendingItems):
              (FrameWin::locationbarVisible):
              (FrameWin::canUndo):
              (FrameWin::mimeTypeForFileName):
              (FrameWin::issueTransposeCommand):
              (RenderCanvasImage::setNeedsImageUpdate):
              (FrameWin::shouldChangeSelection):
              (FrameWin::respondToChangedSelection):
              (FrameWin::clearRecordedFormValues):
              (FrameWin::recordFormValue):
              (BrowserExtensionWin::getHistoryLength):
              (Widget::setIsSelected):
              (GraphicsContext::selectedTextBackgroundColor):
              (GraphicsContext::addRoundedRectClip):
              (QScrollBar::QScrollBar):
              (QScrollBar::~QScrollBar):
              (QScrollBar::setSteps):
              (QScrollBar::scroll):
              (QScrollBar::setValue):
              (QScrollBar::setKnobProportion):
              (QListBox::QListBox):
              (QListBox::~QListBox):
              (QListBox::setSelectionMode):
              (QListBox::setFont):
              * rendering/render_canvasimage.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@13340 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f825ec04
    • mjs's avatar
      Reviewed by Darin. · 5ba376a2
      mjs authored
              
              - tweaks to my change to redo KJS::Node refcounting
      
              * kjs/nodes.cpp:
              (Node::ref):
              (Node::deref):
              (Node::refcount):
              (Node::clearNewNodes):
              * kjs/nodes.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@13339 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5ba376a2
    • eseidel's avatar
      2006-03-16 Eric Seidel <eseidel@apple.com> · 3968b2b8
      eseidel authored
              Reviewed by darin.
      
              Add resize, scroll event support.
      
              * Spinneret/Spinneret/WebView.cpp:
              (WebKit::WebView::mouseMoved):
              (WebKit::WebView::mouseDown):
              (WebKit::WebView::mouseUp):
              (WebKit::WebView::mouseDoubleClick):
              (WebKit::WebView::keyPress):
              (WebKit::WebViewWndProc):
              * Spinneret/Spinneret/WebView.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@13338 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3968b2b8
    • mjs's avatar
      Reviewed by Eric. · 24636cc8
      mjs authored
              - renamed URLArgs to ResourceRequest, split it into its own header
              - moved methods to get and set ResourceRequest to Frame
      
              * WebCore.xcodeproj/project.pbxproj:
              * bridge/BrowserExtension.h:
              * bridge/mac/BrowserExtensionMac.h:
              * bridge/mac/BrowserExtensionMac.mm:
              (WebCore::BrowserExtensionMac::openURLRequest):
              (WebCore::BrowserExtensionMac::createNewWindow):
              * bridge/mac/MacFrame.h:
              * bridge/mac/MacFrame.mm:
              (WebCore::MacFrame::openURLRequest):
              (WebCore::MacFrame::submitForm):
              (WebCore::MacFrame::urlSelected):
              * bridge/mac/WebCoreFrameBridge.mm:
              (-[WebCoreFrameBridge openURL:reload:contentType:refresh:lastModified:pageCache:]):
              * khtml/ecma/kjs_window.cpp:
              (KJS::createNewWindow):
              (KJS::WindowFunc::callAsFunction):
              * page/Frame.cpp:
              (WebCore::Frame::didOpenURL):
              (WebCore::Frame::receivedFirstData):
              (WebCore::Frame::setResourceRequest):
              (WebCore::Frame::resourceRequest):
              (WebCore::Frame::begin):
              (WebCore::Frame::changeLocation):
              (WebCore::Frame::urlSelected):
              (WebCore::Frame::requestFrame):
              (WebCore::Frame::submitForm):
              * page/Frame.h:
              * page/FramePrivate.h:
              * page/ResourceRequest.h: Added.
              (WebCore::ResourceRequest::ResourceRequest):
              (WebCore::ResourceRequest::contentType):
              (WebCore::ResourceRequest::setContentType):
              (WebCore::ResourceRequest::doPost):
              (WebCore::ResourceRequest::setDoPost):
              (WebCore::ResourceRequest::lockHistory):
              (WebCore::ResourceRequest::setLockHistory):
              (WebCore::ResourceRequest::metaData):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@13337 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      24636cc8
    • bdakin's avatar
      Rubber stamped by Geoff. · 68cb0e9b
      bdakin authored
              Still adding more mozilla table tests.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@13336 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      68cb0e9b
    • bdakin's avatar
      Rubber stamped by Geoff. · 2d87698c
      bdakin authored
              Adding more mozilla table tests.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@13335 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2d87698c
    • darin's avatar
      - need to touch one more file to fix the build · 942dc768
      darin authored
                (Darn the lack of dependencies for autogenerated bindings!)
      
              * dom/Element.idl: Touch. (Really this time.)
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@13334 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      942dc768
    • eseidel's avatar
      2006-03-16 Eric Seidel <eseidel@apple.com> · c65eaba1
      eseidel authored
              Reviewed by darin.
      
              Make build-webkit print correctly to stdout on windows.
      
              * Scripts/webkitdirs.pm: Fix to use devenv.com instead of devenv.exe
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@13333 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c65eaba1
    • darin's avatar
      - need to touch one more file to fix the build · f27f2a31
      darin authored
                (Darn the lack of dependencies for autogenerated bindings!)
      
              * dom/Element.idl: Touch.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@13332 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f27f2a31
    • eseidel's avatar
      2006-03-16 Eric Seidel <eseidel@apple.com> · ab3915f2
      eseidel authored
              Reviewed by darin.
      
              Pushed focus ring handling down into GraphicsContext.cpp
      
              * bridge/mac/MacFrame.mm:
              (WebCore::MacFrame::mouseDown):
              * platform/GraphicsContext.cpp:
              (WebCore::GraphicsContext::initFocusRing):
              (WebCore::GraphicsContext::clearFocusRing):
              (WebCore::GraphicsContext::addFocusRingRect):
              * platform/GraphicsContext.h:
              * platform/mac/GraphicsContextMac.mm:
              (WebCore::GraphicsContextPrivate::GraphicsContextPrivate):
              (WebCore::GraphicsContextPrivate::~GraphicsContextPrivate):
              (WebCore::GraphicsContext::GraphicsContext):
              (WebCore::GraphicsContext::drawFocusRing):
              * rendering/render_flow.cpp:
              (WebCore::RenderFlow::addFocusRingRects):
              * rendering/render_object.cpp:
              (WebCore::RenderObject::addFocusRingRects):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@13331 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ab3915f2
    • darin's avatar
      Oops, these files were supposed to go in. · ecc95eb8
      darin authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@13330 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ecc95eb8
    • darin's avatar
      Reviewed by Hyatt. · 991c938e
      darin authored
              - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7749
                canvas should be in DOM, not implemented in the JS bindings
      
              * WebCore.xcodeproj/project.pbxproj: Added new files.
              Changed bindings-generation code to work on the new html directory
              as well as the dom one.
      
              * bindings/js/JSCanvasRenderingContext2DBase.cpp: Added.
              * bindings/js/JSCanvasRenderingContext2DBase.h: Added.
              * bindings/js/JSDOMHTML.cpp: Added.
              * html: Added.
              * html/CanvasGradient.cpp: Added.
              * html/CanvasGradient.h: Added.
              * html/CanvasGradient.idl: Added.
              * html/CanvasPattern.cpp: Added.
              * html/CanvasPattern.h: Added.
              * html/CanvasPattern.idl: Added.
              * html/CanvasRenderingContext2D.cpp: Added.
              * html/CanvasRenderingContext2D.h: Added.
              * html/CanvasRenderingContext2D.idl: Added.
              * html/CanvasStyle.cpp: Added.
              * html/CanvasStyle.h: Added.
      
              * bindings/js/JSDOMCore.cpp: Touched so that it will recompile.
              * bindings/js/JSDOMEvents.cpp: Ditto.
              * dom/Attr.idl: Ditto.
              * dom/DOMImplementation.idl: Ditto.
              * dom/DocumentType.idl: Ditto.
              * dom/MutationEvent.idl: Ditto.
              * dom/ProcessingInstruction.idl: Ditto.
              * dom/Text.idl: Ditto.
      
              * khtml/ecma/kjs_binding.h: (KJS::toJS): Added. Template so that you can call
              toJS on a PassRefPtr as well as on a raw pointer.
      
              * bindings/scripts/CodeGeneratorJS.pm: Fixed handling of a class that has only
              a legacy parent, no conventional parents. Added JSCanvasRenderingContext2DBase
              as a legacy parent, and html as a legacy module. Added CanvasRenderingContext2D,
              CanvasGradient, and CanvasPattern to the "waht to include". Added a special
              case for strings beginning with Canvas to not add an "Impl" suffix. Made the
              generated impl() function be a const member function. Made m_mimpl be private
              instead of protected. Generate a toJS function for each class. Added flaot as
              a type. Generate String, not DOMString. Made the HashTable const.
      
              * bindings/scripts/IDLParser.pm: Fix a couple small things. I had started to
              try to make a missing semicolon trigger an error, but ended up giving up on
              that for now.
      
              * khtml/html/html_canvasimpl.h:
              * khtml/html/html_canvasimpl.cpp:
              (WebCore::HTMLCanvasElementImpl::HTMLCanvasElementImpl): Set m_2DContext to 0.
              (WebCore::HTMLCanvasElementImpl::~HTMLCanvasElementImpl): Call detachCanvas
              on m_2DContext, if any.
              (WebCore::HTMLCanvasElementImpl::detach): Call reset on m_2DContext, if any.
              (WebCore::HTMLCanvasElementImpl::getContext): Added.
              (WebCore::HTMLCanvasElementImpl::size): Added.
              (WebCore::HTMLCanvasElementImpl::createPlatformImage): Added.
      
              * platform/Image.h:
              * platform/Image.cpp: (WebCore::Image::compositeOperatorFromString):
              Changed to take a String instead of a const char*.
      
              * khtml/html/html_imageimpl.h:
              * khtml/html/html_imageimpl.cpp: (WebCore::HTMLMapElementImpl::areas):
              Tweaked formatting. Changed to use PassRefPtr.
      
              * bindings/objc/DOMInternal.mm: (-[WebScriptObject _initializeScriptDOMNodeImp]):
              * khtml/ecma/JSXMLHttpRequest.cpp: (KJS::JSXMLHttpRequest::getValueProperty):
              * khtml/ecma/XSLTProcessor.cpp: (KJS::XSLTProcessorProtoFunc::callAsFunction):
              * khtml/ecma/domparser.cpp: (KJS::DOMParserProtoFunc::callAsFunction):
              * khtml/ecma/kjs_css.cpp:
              (KJS::DOMCSSStyleDeclaration::getValueProperty):
              (KJS::DOMCSSStyleDeclarationProtoFunc::callAsFunction):
              (KJS::toJS):
              (KJS::DOMStyleSheet::getValueProperty):
              (KJS::DOMStyleSheetList::indexGetter):
              (KJS::DOMStyleSheetList::nameGetter):
              (KJS::DOMStyleSheetListFunc::callAsFunction):
              (KJS::DOMCSSStyleSheet::getValueProperty):
              (KJS::DOMCSSRuleList::indexGetter):
              (KJS::DOMCSSRuleListFunc::callAsFunction):
              (KJS::DOMCSSRule::getValueProperty):
              (KJS::DOMCSSPrimitiveValueProtoFunc::callAsFunction):
              (KJS::DOMCSSValueList::indexGetter):
              (KJS::DOMCSSValueListFunc::callAsFunction):
              (KJS::DOMRect::getValueProperty):
              * khtml/ecma/kjs_css.h:
              * khtml/ecma/kjs_dom.cpp:
              (KJS::DOMNode::getValueProperty):
              (KJS::DOMNodeProtoFunc::callAsFunction):
              (KJS::DOMNodeList::indexGetter):
              (KJS::DOMNodeList::nameGetter):
              (KJS::DOMNodeList::callAsFunction):
              (KJS::DOMNodeListFunc::callAsFunction):
              (KJS::DOMDocument::getValueProperty):
              (KJS::DOMDocumentProtoFunc::callAsFunction):
              (KJS::DOMNamedNodeMap::indexGetter):
              (KJS::DOMNamedNodeMap::nameGetter):
              (KJS::DOMNamedNodeMapProtoFunc::callAsFunction):
              (KJS::toJS):
              (KJS::DOMNamedNodesCollection::indexGetter):
              * khtml/ecma/kjs_dom.h:
              * khtml/ecma/kjs_events.cpp:
              (KJS::JSAbstractEventListener::handleEvent):
              (KJS::JSLazyEventListener::parseCode):
              (KJS::DOMEvent::getValueProperty):
              (KJS::toJS):
              (KJS::DOMUIEvent::getValueProperty):
              (KJS::DOMMouseEvent::getValueProperty):
              * khtml/ecma/kjs_events.h:
              * khtml/ecma/kjs_html.cpp:
              (KJS::HTMLDocFunction::callAsFunction):
              (KJS::HTMLDocument::namedItemGetter):
              (KJS::HTMLDocument::getValueProperty):
              (KJS::HTMLDocument::put):
              (KJS::HTMLDocument::putValueProperty):
              (KJS::HTMLElement::classInfo):
              (KJS::HTMLElement::formIndexGetter):
              (KJS::HTMLElement::selectIndexGetter):
              (KJS::HTMLElement::implementsCall):
              (KJS::HTMLElement::callAsFunction):
              (KJS::HTMLElement::linkGetter):
              (KJS::HTMLElement::isIndexGetter):
              (KJS::HTMLElement::styleGetter):
              (KJS::HTMLElement::selectGetter):
              (KJS::HTMLElement::optionGetter):
              (KJS::HTMLElement::inputGetter):
              (KJS::HTMLElement::textAreaGetter):
              (KJS::HTMLElement::buttonGetter):
              (KJS::HTMLElement::labelGetter):
              (KJS::HTMLElement::fieldSetGetter):
              (KJS::HTMLElement::legendGetter):
              (KJS::HTMLElement::objectGetter):
              (KJS::HTMLElement::tableGetter):
              (KJS::HTMLElement::frameGetter):
              (KJS::HTMLElement::iFrameGetter):
              (KJS::HTMLElement::getValueProperty):
              (KJS::HTMLElement::toString):
              (KJS::HTMLElement::pushEventHandlerScope):
              (KJS::toJS):
              (KJS::HTMLElementFunction::callAsFunction):
              (KJS::HTMLElement::put):
              (KJS::HTMLCollection::indexGetter):
              (KJS::HTMLCollection::callAsFunction):
              (KJS::HTMLCollection::getNamedItems):
              (KJS::HTMLCollectionProtoFunc::callAsFunction):
              (KJS::HTMLSelectCollection::put):
              (KJS::OptionConstructorImp::construct):
              (KJS::ImageConstructorImp::construct):
              * khtml/ecma/kjs_html.h:
              * khtml/ecma/kjs_proxy.cpp: (WebCore::KJSProxyImpl::evaluate):
              * khtml/ecma/kjs_range.cpp:
              (KJS::DOMRange::getValueProperty):
              (KJS::DOMRangeProtoFunc::callAsFunction):
              (KJS::toJS):
              * khtml/ecma/kjs_range.h:
              * khtml/ecma/kjs_traversal.cpp:
              (KJS::DOMNodeIterator::getValueProperty):
              (KJS::DOMNodeIteratorProtoFunc::callAsFunction):
              (KJS::toJS):
              (KJS::DOMTreeWalker::getValueProperty):
              (KJS::DOMTreeWalkerProtoFunc::callAsFunction):
              (KJS::JSNodeFilterCondition::acceptNode):
              * khtml/ecma/kjs_traversal.h:
              * khtml/ecma/kjs_views.cpp:
              (KJS::DOMAbstractView::getValueProperty):
              (KJS::DOMAbstractViewProtoFunc::callAsFunction):
              (KJS::toJS):
              * khtml/ecma/kjs_views.h:
              * khtml/ecma/kjs_window.cpp:
              (KJS::Window::getValueProperty):
              (KJS::Window::namedItemGetter):
              (KJS::Selection::getValueProperty):
              (KJS::SelectionFunc::callAsFunction):
              Rename uses and definitions of all the various converstions to JavaScript
              wrappers to the new common overloaded name: "toJS".
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@13329 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      991c938e
    • darin's avatar
      Reviewed by Maciej. · d56b090f
      darin authored
              - fixed Vector so that you can pass a reference to something in the vector
                to the append or insert functions
      
              * kxmlcore/Vector.h:
              (KXMLCore::Vector::expandCapacity): Added new overloads that take a pointer to adjust
              and return the adjusted value of the pointer.
              (KXMLCore::Vector::append): Pass a pointer when expanding the vector, and use it when
              adding the new element. Makes the case where the element moves when the vector
              is expanded work.
              (KXMLCore::Vector::insert): Ditto.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@13328 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d56b090f
    • eseidel's avatar
      2006-03-15 Eric Seidel <eseidel@apple.com> · c79c10b2
      eseidel authored
              Reviewed by darin.
      
              Push more of MacFrame down into Frame.
              Add visibleContentRect method to ScrollView.
      
              * bridge/mac/MacFrame.h:
              * bridge/mac/MacFrame.mm:
              (WebCore::MacFrame::imageFromRect):
              (WebCore::MacFrame::setDisplaysWithFocusAttributes):
              (WebCore::MacFrame::bodyBackgroundColor):
              * bridge/mac/WebCoreFrameBridge.mm:
              * page/Frame.cpp:
              (WebCore::Frame::visibleSelectionRect):
              (WebCore::Frame::setDisplaysWithFocusAttributes):
              * page/Frame.h:
              * platform/ScrollView.h:
              * platform/mac/ScrollViewMac.mm:
              (WebCore::ScrollView::visibleWidth):
              (WebCore::ScrollView::visibleHeight):
              (WebCore::ScrollView::visibleContentRect):
              (WebCore::ScrollView::contentsWidth):
              (WebCore::ScrollView::contentsHeight):
              (WebCore::ScrollView::contentsX):
              (WebCore::ScrollView::contentsY):
              (WebCore::ScrollView::scrollXOffset):
              (WebCore::ScrollView::scrollYOffset):
              (WebCore::ScrollView::inWindow):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@13327 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c79c10b2
    • eseidel's avatar
      2006-03-15 Eric Seidel <eseidel@apple.com> · 877ee17a
      eseidel authored
              Reviewed by darin.
      
              Remove unused code and clean-up style.
      
              * bridge/mac/MacFrame.mm:
              (WebCore::MacFrame::advanceToNextMisspelling):
              (WebCore::MacFrame::wheelEvent):
              (WebCore::MacFrame::nextKeyViewInFrame):
              (WebCore::MacFrame::nextKeyViewInFrameHierarchy):
              (WebCore::MacFrame::nextKeyView):
              * page/Frame.cpp:
              * page/Frame.h:
              * page/FrameView.cpp:
              (WebCore::FrameView::dispatchMouseEvent):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@13326 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      877ee17a
  2. 15 Mar, 2006 23 commits
    • eseidel's avatar
      2006-03-15 Eric Seidel <eseidel@apple.com> · 44effa7e
      eseidel authored
              Reviewed by mjs.
      
              http://bugzilla.opendarwin.org/show_bug.cgi?id=7790
              addEventListener does not work with "dblclick" event.
              Renamed khtmlDblclickEvent to dblclickEvent to fix.
      
              Test: fast/events/dblclick-addEventListener.html
      
              * WebCore.xcodeproj/project.pbxproj:
              * bridge/mac/MacFrame.mm:
              (WebCore::MacFrame::mouseUp):
              (WebCore::MacFrame::mouseMoved):
              (WebCore::MacFrame::shouldDragAutoNode):
              (WebCore::MacFrame::sendContextMenuEvent):
              * dom/EventNames.h:
              * dom/NodeImpl.cpp:
              (WebCore::NodeImpl::dispatchMouseEvent):
              * dom/NodeImpl.h:
              * khtml/ecma/kjs_binding.cpp:
              (KJS::ScriptInterpreter::wasRunByUserGesture):
              * khtml/ecma/kjs_dom.cpp:
              (KJS::DOMNode::getValueProperty):
              (KJS::DOMNode::putValueProperty):
              * khtml/ecma/kjs_window.cpp:
              (KJS::Window::getValueProperty):
              (KJS::Window::put):
              * khtml/html/HTMLElementImpl.cpp:
              (WebCore::HTMLElementImpl::parseMappedAttribute):
              * page/FrameView.cpp:
              (WebCore::FrameView::dispatchMouseEvent):
              * page/FrameView.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@13325 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      44effa7e
    • ap's avatar
      Reviewed by Maciej. · 345ee334
      ap authored
              - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=4395
               REGRESSION: document.open doesn't clear the document
      
              Test: fast/dom/Document/document-reopen.html
              Test: fast/dom/Document/doc-open-while-parsing.html
      
              * dom/DocumentImpl.cpp:
              (WebCore::DocumentImpl::open): Only ignore open() while the frame is still loading the main resource.
              * page/Frame.cpp:
              (WebCore::Frame::isComplete): Added const specifier.
              (WebCore::Frame::isLoadingMainResource): New function.
              * page/Frame.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@13324 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      345ee334
    • darin's avatar
      Reviewed by Maciej. · 9645bc22
      darin authored
              * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Fix path
              that had a lowercase "i" in it so this builds on case-sensitive
              file systems.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@13323 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9645bc22
    • darin's avatar
      Removed a few stray .cvsignore files that crept in. · 7eb6e4bc
      darin authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@13322 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7eb6e4bc
    • bdakin's avatar
      Rubber stamped by Geoff. · 802f95f6
      bdakin authored
              even more mozilla table tests.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@13321 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      802f95f6
    • ggaren's avatar
      Reviewed by Eric. · 9740434e
      ggaren authored
              Added run-testkjs and compare-timing-files scripts, to support super
              accurate JS iBench.
      
              * Scripts/compare-timing-files: Added.
              * Scripts/run-testkjs: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@13320 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9740434e
    • darin's avatar
      Fix by Patrick Beard, reviewed by me. · 7b613ae8
      darin authored
              - fix <rdar://problem/4478181> WebPluginController leaks NSArray and NSMutableSet objects
      
              * Plugins/WebPluginController.m:
              (-[WebPluginController initWithDocumentView:]): Call CFMakeCollectable on the CFSet
              so we can act like it's an NSSet.
              (-[WebPluginController dealloc]): Release _views and _checksInProgress.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@13319 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7b613ae8
    • eseidel's avatar
      2006-03-15 Eric Seidel <eseidel@apple.com> · 4c10a322
      eseidel authored
              Reviewed by adele.
      
              Build fix.
      
              * kjs/date_object.cpp:
              (KJS::DateProtoFunc::callAsFunction): use size() not "len()"
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@13318 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4c10a322
    • adele's avatar
      Reviewed by Eric. · 6f3ebf67
      adele authored
              - Fixes win32 build.
      
              * page/Frame.cpp: (WebCore::Frame::autoscrollTimerFired): Calls isMouseButtonDown instead of CG function.
              * platform/MouseEvent.h: Added isMouseButtonDown
              * platform/mac/MouseEventMac.mm: (WebCore::MouseEvent::isMouseButtonDown): Calls CG function to get state of mouse button.
              * platform/win/TemporaryLinkStubs.cpp: (MouseEvent::isMouseButtonDown): Added stub.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@13317 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6f3ebf67
    • bdakin's avatar
      Rubber stamped by Geoff. · 7b907f8c
      bdakin authored
              Even more Mozilla tables tests.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@13316 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7b907f8c
    • bdakin's avatar
      Rubber stamped by Geoff · 89a9c350
      bdakin authored
              More Mozilla table tests.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@13315 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      89a9c350
    • bdakin's avatar
      Rubber stamped by Geoff. · 343280fb
      bdakin authored
              First round of committing Mozilla table tests to our tree.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@13314 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      343280fb
    • aliceli1's avatar
      forgot to change the date · 6cab7452
      aliceli1 authored
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@13313 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6cab7452
    • eseidel's avatar
      2006-03-15 Eric Seidel <eseidel@apple.com> · ac23632d
      eseidel authored
              Reviewed by geoff.
      
              * platform/KeyEvent.h: Fix #define from QEvent_H to KeyEvent_H
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@13312 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ac23632d
    • eseidel's avatar
      2006-03-15 Eric Seidel <eseidel@apple.com> · b3ff6077
      eseidel authored
              Reviewed by mjs.
      
              Fix CString copy constructor, fixes Date.parse("") on Win32.
      
              * kjs/date_object.cpp:
              (KJS::DateProtoFunc::callAsFunction):
              * kjs/ustring.cpp:
              (KJS::CString::CString):
              (KJS::CString::operator=):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@13311 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b3ff6077
    • aliceli1's avatar
      added www.live.com to list and reordered by bug number. · 8a8729da
      aliceli1 authored
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@13310 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8a8729da
    • ggaren's avatar
      Reviewed by TimH. · daf2e2fd
      ggaren authored
              * projects/compat/hitlist.html: Moved delta.com to the alumni list,
              added description of alumni list.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@13309 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      daf2e2fd
    • hyatt's avatar
      Check in updated results for fast/box-sizing/percentage-height.html. All... · 059c5b03
      hyatt authored
      Check in updated results for fast/box-sizing/percentage-height.html.   All results for this test are wrong, but only in DumpRenderTree.  Safari renders it correctly.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@13308 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      059c5b03
    • hyatt's avatar
      Fix the box-sizing layout test by stopping integer overflowing from · 38078235
      hyatt authored
              occurring in the flexbox code.
      
              Reviewed by beth
      
              * rendering/render_flexbox.cpp:
              (khtml::RenderFlexibleBox::allowedChildFlex):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@13307 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      38078235
    • bdakin's avatar
      Reviewed by Eric · 121b8868
      bdakin authored
              Fix for some leaks and intermittent broken pipes in the layout 
              tests after check-in for http://bugzilla.opendarwin.org/
              show_bug.cgi?id=4171.  
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@13306 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      121b8868
    • darin's avatar
      Update information about when a bug was fixed. · dbb1a17e
      darin authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@13305 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dbb1a17e
    • mjs's avatar
      Reviewed by Anders. · a84805f1
      mjs authored
              
              - KJS::Node and KJS::StatementNode are bigger than they need to be
              http://bugzilla.opendarwin.org/show_bug.cgi?id=7775
      
              The memory usage of Node was reduced by 2 machine words per node:
      
              - sourceURL was removed and only kept on FunctionBodyNode. The
              source URL can only be distinct per function or top-level program node, 
              and you always have one.
              
              - refcount was removed and kept in a separate hashtable when
              greater than 1. newNodes set represents floating nodes with
              refcount of 0. This helps because almost all nodes have a refcount of 1
              for almost all of their lifetime.
              
              * bindings/runtime_method.cpp:
              (RuntimeMethod::RuntimeMethod): Pass null body, added FIXME.
              * kjs/Parser.cpp:
              (KJS::clearNewNodes): New nodes are tracked in nodes.cpp now, but still clear
              them at the appropriate time.
              * kjs/context.h:
              (KJS::ContextImp::currentBody): added; used to retrieve source URL and sid
              for current code.
              (KJS::ContextImp::pushIteration): moved here from LabelStack
              (KJS::ContextImp::popIteration): ditto
              (KJS::ContextImp::inIteration): ditto
              (KJS::ContextImp::pushSwitch): ditto
              (KJS::ContextImp::popSwitch): ditto
              (KJS::ContextImp::inSwitch): ditto
              * kjs/function.cpp:
              (KJS::FunctionImp::FunctionImp): Add FunctionBodyNode* parameter.
              (KJS::FunctionImp::callAsFunction): Pass body to ContextImp.
              (KJS::FunctionImp::argumentsGetter): _context renamed to m_context.
              (KJS::DeclaredFunctionImp::DeclaredFunctionImp): Pass body to superclass
              constructor.
              (KJS::GlobalFuncImp::callAsFunction): Pass progNode as body for ContextImp in
              eval.
              * kjs/function.h: Move body field from DeclaredFunctionImp to
              FunctionImp.
              * kjs/grammar.y: Change DBG; statements no longer have a sourceid.
              * kjs/internal.cpp:
              (KJS::ContextImp::ContextImp): Initialize new m_currentBody, m_iterationDepth
              and m_switchDepth data members. New FunctionBodyNode* parameter - the
              function body provides source URL and SourceId.
              (KJS::InterpreterImp::mark): Use exception() function, not _exception directly.
              (KJS::InterpreterImp::evaluate): Pass progNode to ContextImp constructor
              to use as the body.
              * kjs/internal.h:
              (KJS::LabelStack::LabelStack): Remove iteration depth and switch depth;
              statement label stacks don't need these and it bloats their size. Put them
              in the ContextImp instead.
              * kjs/interpreter.cpp:
              (KJS::ExecState::lexicalInterpreter): Renamed _context to m_context.
              * kjs/interpreter.h:
              (KJS::ExecState::dynamicInterpreter): Renamed _context to m_context.
              (KJS::ExecState::context): ditto
              (KJS::ExecState::setException): Renamed _exception to m_exception
              (KJS::ExecState::clearException): ditto
              (KJS::ExecState::exception): ditto
              (KJS::ExecState::hadException): ditto
              (KJS::ExecState::ExecState): ditto both above renames
              * kjs/nodes.cpp:
              (Node::Node): Removed initialization of line, source URL and refcount. Add to
              local newNodes set instead of involving parser.
              (Node::ref): Instead of managing refcount directly, story refcount over 1 in a
              HashCountedSet, and keep a separate HashSet of "floating" nodes with refcount
              0.
              (Node::deref): ditto
              (Node::refcount): ditto
              (Node::clearNewNodes): Destroy anything left in the new nodes set.
              (currentSourceId): Inline helper to get sourceId from function body via context.
              (currentSourceURL): ditto for sourceURL.
              (Node::createErrorCompletion): use new helper
              (Node::throwError): ditto
              (Node::setExceptionDetailsIfNeeded): ditto
              (StatementNode::StatementNode): remove initialization of l0 and sid, rename
              l1 to m_lastLine.
              (StatementNode::setLoc): Set own m_lastLine and Node's m_line.
              (StatementNode::hitStatement): Get sid, first line, last line in the proper new ways.
              (StatListNode::StatListNode): updated for setLoc changes
              (BlockNode::BlockNode): ditto
              (DoWhileNode::execute): excpect iteraton counts on ContextImp, not LabelStack
              (WhileNode::execute): ditto
              (ForNode::execute): ditto
              (ForInNode::execute): ditto
              (ContinueNode::execute): excpect inIteration on ContextImp, not LabelStack
              (BreakNode::execute): excpect inIteration and inSwitch on ContextImp, not LabelStack
              (SwitchNode::execute): expect switch counts on ContextImp, not LabelStack
              (FunctionBodyNode::FunctionBodyNode): update for new setLoc
              (FunctionBodyNode::processFuncDecl): reindent
              (SourceElementsNode::SourceElementsNode): update for new setLoc
              * kjs/nodes.h:
              (KJS::Node::lineNo): Renamed _line to m_line
              (KJS::StatementNode::firstLine): Use lineNo()
              (KJS::StatementNode::lastLine): Renamed l1 to m_lastLine
              (KJS::FunctionBodyNode::sourceId): added
              (KJS::FunctionBodyNode::sourceURL): added
              * kjs/testkjs.cpp:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@13304 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a84805f1
    • adele's avatar
      Reviewed by Maciej. · 3a9a1263
      adele authored
             Followup fix for previous checkin.
             http://bugzilla.opendarwin.org/show_bug.cgi?id=7114
             <rdar://problem/3695120> dragging to scroll doesn't work with overflow:auto/scroll/overlay areas 
      
             Many of the bugs related to the Radar bug have to do with autoscrolling in the RSS View.  
             This fix walks the layer tree to find the first scrollable layer, so that autoscrolling will 
             also work with nested layers, like those in the RSS View.
      
             * bridge/mac/MacFrame.mm: (WebCore::MacFrame::khtmlMouseMoveEvent):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@13303 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3a9a1263