1. 18 Mar, 2013 40 commits
    • roger_fong@apple.com's avatar
      AppleWin VS2010 Debug configuration build fix.. · 89b0a9a9
      roger_fong@apple.com authored
      * JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
      * WebCore.vcxproj/WebCore.vcxproj:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146131 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      89b0a9a9
    • ap@apple.com's avatar
      https://bugs.webkit.org/show_bug.cgi?id=112627 · ad5420c1
      ap@apple.com authored
      MessagePort::disentangle() takes an ExceptionCode argument without any need
      
      Reviewed by Geoffrey Garen.
      
      MessagePort::disentangle() is called in two places. One has ASSERT_NO_EXCEPTION,
      and another fails to check the exception, but clearly cannot get one.
      
      This function is also not exposed to bindings.
      
      * dom/MessagePort.cpp:
      (WebCore::MessagePort::disentangle):
      (WebCore::MessagePort::disentanglePorts):
      * dom/MessagePort.h:
      * workers/SharedWorker.cpp:
      (WebCore::SharedWorker::create):
      Also removed some unhelpful comments.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146130 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ad5420c1
    • wangxianzhu@chromium.org's avatar
      Variant of non-primary fell-back SVGFont causes crash. · 1430de0e
      wangxianzhu@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=112367
      
      Reviewed by Stephen Chenney.
      
      Source/WebCore:
      
      Don't go to PlatformFontData path for SimpleFontData::createScaledFontData()
      for SVG fonts.
      
      Test: svg/css/font-face-variant-crash.html
      
      * platform/graphics/SimpleFontData.cpp:
      (WebCore::SimpleFontData::~SimpleFontData):
      (WebCore::SimpleFontData::createScaledFontData): Don't go to PlatformFontData path for SVG fonts.
      (WebCore):
      * platform/graphics/SimpleFontData.h:
      (SimpleFontData): Added createScaledFontData and renamed the original createScaledFontData to platformCreateScaledFontData.
                        BTW, Removed unreferenced commonInit.
      * platform/graphics/blackberry/SimpleFontDataBlackBerry.cpp:
      (WebCore::SimpleFontData::platformCreateScaledFontData): Renamed from createScaledFontData.
      * platform/graphics/chromium/SimpleFontDataChromiumWin.cpp:
      (WebCore::SimpleFontData::platformCreateScaledFontData): Ditto.
      * platform/graphics/freetype/SimpleFontDataFreeType.cpp:
      (WebCore::SimpleFontData::platformCreateScaledFontData): Ditto.
      * platform/graphics/mac/SimpleFontDataMac.mm:
      (WebCore::SimpleFontData::platformCreateScaledFontData): Ditto.
      * platform/graphics/qt/SimpleFontDataQt.cpp:
      (WebCore::SimpleFontData::platformCreateScaledFontData): Ditto.
      * platform/graphics/skia/SimpleFontDataSkia.cpp:
      (WebCore::SimpleFontData::platformCreateScaledFontData): Ditto.
      * platform/graphics/win/SimpleFontDataWin.cpp:
      (WebCore::SimpleFontData::platformCreateScaledFontData): Ditto.
      * platform/graphics/wince/SimpleFontDataWinCE.cpp:
      (WebCore::SimpleFontData::platformCreateScaledFontData): Ditto.
      * platform/graphics/wx/SimpleFontDataWx.cpp:
      (WebCore::SimpleFontData::platformCreateScaledFontData): Ditto.
      
      LayoutTests:
      
      * resources/SpaceOnly.otf: Added. A font containing only the space glyph for testing font fallback.
      * svg/css/font-face-variant-crash-expected.txt: Added.
      * svg/css/font-face-variant-crash.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146129 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1430de0e
    • vcarbune@chromium.org's avatar
      Determine text direction for rendering a TextTrackCue · 770dc028
      vcarbune@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=79749
      
      Reviewed by Levi Weintraub.
      
      Source/WebCore:
      
      The rendering rules for WebVTT cues are slightly different
      depending on the directionality determined from the characters
      of the cue text. This patch implements the preliminary step
      to be able to take directionality into account.
      
      It iterates through the cue characters and setting the CSS
      directionality to the one of the first strong directional character.
      
      Test: media/track/track-cue-rendering-rtl.html
      
      * html/track/TextTrackCue.cpp:
      (WebCore::TextTrackCueBox::applyCSSProperties): Applies the determined
      direction.
      (WebCore::TextTrackCue::TextTrackCue): Sets the default value for the
      display direction.
      (WebCore::isCueParagraphSeparator): Tests for explicit unicode characters
      that are paragraph separators.
      (WebCore):
      (WebCore::TextTrackCue::determineTextDirection): Determined the direction
      by the first strong directional character found.
      (WebCore::TextTrackCue::calculateDisplayParameters): Updated.
      (WebCore::TextTrackCue::getCSSWritingDirection): Return the determined CSS
      writing direction.
      * html/track/TextTrackCue.h:
      (TextTrackCue):
      
      LayoutTests:
      
      * media/track/captions-webvtt/captions-rtl.vtt: Added.
      * media/track/track-cue-rendering-rtl-expected.txt: Added.
      * media/track/track-cue-rendering-rtl.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146128 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      770dc028
    • jparent@chromium.org's avatar
      Cleanup: Move js for treemap and aggregate_results into own js files. · 0f9d72fc
      jparent@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=112618
      
      Reviewed by Dirk Pranke.
      
      No functional changes, just moving the code into separate js file
      rather than inlined in the html, so we can test it, make it more
      modular, etc.  Other dashboard types are already done this way.
      
      * TestResultServer/static-dashboards/aggregate_results.html:
      * TestResultServer/static-dashboards/aggregate_results.js: Copied from Tools/TestResultServer/static-dashboards/aggregate_results.html.
      (generatePage):
      (handleValidHashParameter):
      (htmlForBuilder):
      (rawValuesHTML):
      (chartHTML):
      (filteredValues):
      (chart):
      (htmlForRevisionRows):
      (wrapHTMLInTable):
      (htmlForSummaryTable):
      (valuesPerExpectation):
      (htmlForTestType):
      (htmlForTableRow):
      (extendedEncode):
      * TestResultServer/static-dashboards/treemap.html:
      * TestResultServer/static-dashboards/treemap.js: Copied from Tools/TestResultServer/static-dashboards/treemap.html.
      (humanReadableTime):
      (convertToWebTreemapFormat):
      (reverseSortByAverage):
      (generatePage):
      (focusPath):
      (.switch.return):
      (handleQueryParameterChange):
      (extractName):
      (fullName):
      (handleFocus.):
      (handleFocus):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146127 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0f9d72fc
    • kbr@google.com's avatar
      Unreviewed gardening. Marked flaky tests, removed obsolete · 804459bd
      kbr@google.com authored
      expectations, and fixed flaky test fast/innerHTML/innerHTML-iframe.html .
      https://bugs.webkit.org/show_bug.cgi?id=97816
      https://bugs.webkit.org/show_bug.cgi?id=112306
      https://bugs.webkit.org/show_bug.cgi?id=112621
      
      * fast/innerHTML/innerHTML-iframe.html:
      * platform/chromium-android/platform/chromium/compositing/filters/background-filter-blur-expected.png: Removed.
      * platform/chromium-android/platform/chromium/compositing/filters/background-filter-blur-off-axis-expected.png: Removed.
      * platform/chromium-android/platform/chromium/compositing/filters/background-filter-blur-outsets-expected.png: Removed.
      * platform/chromium-linux/platform/chromium/compositing/filters/background-filter-blur-expected.png: Removed.
      * platform/chromium-linux/platform/chromium/compositing/filters/background-filter-blur-off-axis-expected.png: Removed.
      * platform/chromium-linux/platform/chromium/compositing/filters/background-filter-blur-outsets-expected.png: Removed.
      * platform/chromium-mac/platform/chromium/compositing/filters/background-filter-blur-expected.png: Removed.
      * platform/chromium-mac/platform/chromium/compositing/filters/background-filter-blur-off-axis-expected.png: Removed.
      * platform/chromium-mac/platform/chromium/compositing/filters/background-filter-blur-outsets-expected.png: Removed.
      * platform/chromium-win/platform/chromium/compositing/filters/background-filter-blur-expected.png: Removed.
      * platform/chromium-win/platform/chromium/compositing/filters/background-filter-blur-off-axis-expected.png: Removed.
      * platform/chromium-win/platform/chromium/compositing/filters/background-filter-blur-outsets-expected.png: Removed.
      * platform/chromium/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146126 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      804459bd
    • zandobersek@gmail.com's avatar
      [webkitpy] '/usr/bin/interdiff' output while running test-webkitpy · 4221c621
      zandobersek@gmail.com authored
      https://bugs.webkit.org/show_bug.cgi?id=112622
      
      Reviewed by Dirk Pranke.
      
      * Scripts/webkitpy/tool/steps/haslanded_unittest.py:
      (HasLandedTest): Pipe the stdout and stderr output of the subprocess call to subprocess.PIPE, eliminating unnecessary output.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146125 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4221c621
    • zandobersek@gmail.com's avatar
      [NRWT][GTK] Add gtk-wk1 directory to the list of baseline search paths when using DumpRenderTree · f8335149
      zandobersek@gmail.com authored
      https://bugs.webkit.org/show_bug.cgi?id=112619
      
      Reviewed by Dirk Pranke.
      
      When using DumpRenderTree on the Gtk port, NRWT should look for baselines first in the LayoutTests/platform/gtk-wk1
      directory and then fall back to the generic LayoutTests/platform/gtk directory.
      
      * Scripts/webkitpy/layout_tests/port/gtk.py:
      (GtkPort.default_baseline_search_path): Implement the method on the GtkPort class, mapping every search path to the
      Port._webkit_baseline_path method.
      * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
      (GtkPortTest.test_default_baseline_search_path): Add a test for the changes that are being introduced.
      (GtkPortTest.test_port_specific_expectations_files): Wrap a couple of long lines.
      * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
      (TestRebaselineTest.test_baseline_directory): Enhance one and add an additional test case for baseline directories
      that are expected based on the builder name.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146124 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f8335149
    • bfulgham@webkit.org's avatar
      [WinCairo] Get build working under VS2010. · 711a0945
      bfulgham@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=112604
      
      Reviewed by Tim Horton.
      
      * JavaScriptCore.vcxproj/JavaScriptCore.vcxproj: Add build targets for
      Debug_WinCairo and Release_WinCairo using CFLite.
      * JavaScriptCore.vcxproj/JavaScriptCoreCFLite.props: Added.
      * JavaScriptCore.vcxproj/JavaScriptCoreDebugCFLite.props: Added.
      * JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExportGenerator.vcxproj:
      Add Debug_WinCairo and Release_WinCairo build targets to
      make sure headers are copied to proper build folder.
      * JavaScriptCore.vcxproj/JavaScriptCoreGenerated.vcxproj: Ditto.
      * JavaScriptCore.vcxproj/JavaScriptCoreReleaseCFLite.props: Added.
      * JavaScriptCore.vcxproj/LLInt/LLIntAssembly/LLIntAssembly.vcxproj:
      Add Debug_WinCairo and Release_WinCairo build targets to
      make sure headers are copied to proper build folder.
      * JavaScriptCore.vcxproj/LLInt/LLIntDesiredOffsets/LLIntDesiredOffsets.vcxproj:
      Ditto.
      * JavaScriptCore.vcxproj/LLInt/LLIntOffsetsExtractor/LLIntOffsetsExtractor.vcxproj:
      Ditto.
      * JavaScriptCore.vcxproj/jsc/jsc.vcxproj: Ditto.
      * JavaScriptCore.vcxproj/testRegExp/testRegExp.vcxproj: Ditto.
      * JavaScriptCore.vcxproj/testapi/testapi.vcxproj: Ditto.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146123 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      711a0945
    • simon.fraser@apple.com's avatar
      Skip some tests on Windows. · b5a55b82
      simon.fraser@apple.com authored
      * platform/win/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146122 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b5a55b82
    • bfulgham@webkit.org's avatar
      [WinCairo] Get build working under VS2010. · c6c500a0
      bfulgham@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=112604
      
      Reviewed by Tim Horton.
      
      * WTF.vcxproj/WTF.vcxproj: Add Debug_WinCairo and Release_WinCairo
      targets so headers get copied to appropriate build folder.
      * WTF.vcxproj/WTFGenerated.vcxproj: Ditto.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146121 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c6c500a0
    • bfulgham@webkit.org's avatar
      [WinCairo] Build WinCairo port under VS2010 · 10dca391
      bfulgham@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=112604
      
      Reviewed by Tim Horton.
      
      * WebKit.vcxproj/WebKit.sln: Add Debug_WinCairo and Release_WinCairo
      build targets. No other changes in this patch.
      * WebKit.vcxproj/FeatureDefinesCairo.props: Add parallel property
      sheet for WinCairo version of build.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146120 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      10dca391
    • simon.fraser@apple.com's avatar
      06b1731b
    • simon.fraser@apple.com's avatar
    • hans@chromium.org's avatar
      Fix GridTrackSize::operator== · 276e90d2
      hans@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=112501
      
      Reviewed by Eric Seidel.
      
      Source/WebCore:
      
      There was a missing "other." in the function.
      
      This was found by experimenting with a potential new Clang warning.
      
      Test: fast/css-grid-layout/grid-dynamic-updates-relayout.html
      
      * rendering/style/GridTrackSize.h:
      (WebCore::GridTrackSize::operator==):
      
      LayoutTests:
      
      Add a test to check that style changes cause relayout correctly.
      
      * fast/css-grid-layout/grid-dynamic-updates-relayout-expected.txt: Added.
      * fast/css-grid-layout/grid-dynamic-updates-relayout.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146117 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      276e90d2
    • alecflett@chromium.org's avatar
      Inspector: [Chromium] http/tests/inspector/indexeddb/database-data.html ASSERT... · 0aa24de4
      alecflett@chromium.org authored
      Inspector: [Chromium] http/tests/inspector/indexeddb/database-data.html ASSERT on Win7 following r133855
      https://bugs.webkit.org/show_bug.cgi?id=101618
      
      Deactivate transactions created by the inspector, before
      they are reactivated by IndexedDB. This puts transactions
      in an identical state as when they are created by scripts.
      
      Reviewed by Vsevolod Vlasov.
      
      Test: http/tests/inspector/indexeddb/database-data.html
      
      * inspector/InspectorIndexedDBAgent.cpp: Make transactions inactive upon leaving the inspector code.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146116 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0aa24de4
    • jpfau@apple.com's avatar
      Allow blocking of application cache in third-party contexts · 398b1b59
      jpfau@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=112288
      
      Reviewed by Adam Barth.
      
      Source/WebCore:
      
      Return early if we can't access the application cache due to security
      restrictions.
      
      Tests: http/tests/security/cross-origin-appcache-allowed.html
             http/tests/security/cross-origin-appcache.html
             http/tests/security/same-origin-appcache-blocked.html
      
      * loader/appcache/ApplicationCacheGroup.cpp:
      (WebCore::ApplicationCacheGroup::selectCache):
      (WebCore::ApplicationCacheGroup::selectCacheWithoutManifestURL):
      * page/SecurityOrigin.h:
      (WebCore::SecurityOrigin::canAccessApplicationCache):
      
      LayoutTests:
      
      * http/tests/security/cross-origin-appcache-allowed-expected.txt: Added.
      * http/tests/security/cross-origin-appcache-allowed.html: Added.
      * http/tests/security/cross-origin-appcache-expected.txt: Added.
      * http/tests/security/cross-origin-appcache.html: Added.
      * http/tests/security/resources/cross-origin-iframe-for-appcache-allowed.html: Added.
      * http/tests/security/resources/cross-origin-iframe-for-appcache.html: Added.
      * http/tests/security/resources/manifest-for-appcache-allowed.manifest: Added.
      * http/tests/security/resources/manifest-for-appcache-blocked.manifest: Added.
      * http/tests/security/resources/manifest-for-appcache.manifest: Added.
      * http/tests/security/resources/same-origin-iframe-for-appcache-blocked.html: Added.
      * http/tests/security/same-origin-appcache-blocked-expected.txt: Added.
      * http/tests/security/same-origin-appcache-blocked.html: Added.
      * platform/chromium/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146115 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      398b1b59
    • simon.fraser@apple.com's avatar
      plugins/plugin-clip-subframe.html is flakey · 6b804da3
      simon.fraser@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=112616
      
      * platform/mac/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146114 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6b804da3
    • vsevik@chromium.org's avatar
      Web Inspector: Script should know nothing about disabled source mappings. · 56e39b1d
      vsevik@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=112580
      
      Reviewed by Pavel Feldman.
      
      Source/WebCore:
      
      ResourceScriptMapping handles diverged uiSourceCodes internally now.
      
      Tested in inspector/debugger/live-edit-breakpoints.html already.
      
      * inspector/front-end/ResourceScriptMapping.js:
      (WebInspector.ResourceScriptMapping.prototype.rawLocationToUILocation):
      (WebInspector.ResourceScriptMapping.prototype._hasMergedToVM):
      (WebInspector.ResourceScriptMapping.prototype._hasDivergedFromVM):
      * inspector/front-end/Script.js:
      (WebInspector.Script.prototype.rawLocationToUILocation):
      
      LayoutTests:
      
      * inspector/debugger/breakpoint-manager.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146112 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      56e39b1d
    • pilgrim@chromium.org's avatar
      [Chromium] Create WebFileSystemType enum to allow easier filesystem refactoring · e97e459b
      pilgrim@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=112571
      
      Reviewed by Adam Barth.
      
      Source/Platform:
      
      New top-level enum (not tied to WebFileSystem class) will allow
      easier refactoring of filesystem methods within the Platform/
      directory. (All changes are behind an #ifdef so we can sync
      required changes in embedders.)
      
      * chromium/public/WebFileSystemType.h: new file
      (WebKit):
      
      * Platform.gypi:
      * chromium/public/WebFileSystem.h:
      * chromium/public/WebFileSystemType.h: Copied from Source/WebKit/chromium/public/WebCommonWorkerClient.h.
      (WebKit):
      
      Source/WebKit/chromium:
      
      Update function declarations for new WebFileSystemType enum. (All
      changes are behind an #ifdef so we can sync required changes in embedders.)
      
      * public/WebCommonWorkerClient.h:
      (WebCommonWorkerClient):
      (WebKit::WebCommonWorkerClient::openFileSystem):
      * public/WebFrame.h:
      (WebFrame):
      * public/WebFrameClient.h:
      (WebFrameClient):
      (WebKit::WebFrameClient::openFileSystem):
      (WebKit::WebFrameClient::deleteFileSystem):
      * src/LocalFileSystemChromium.cpp:
      (WebCore):
      (WebCore::openFileSystemHelper):
      (WebCore::LocalFileSystem::deleteFileSystem):
      * src/WebFrameImpl.cpp:
      (WebKit):
      (WebKit::WebFrameImpl::createFileSystem):
      (WebKit::WebFrameImpl::createSerializableFileSystem):
      (WebKit::WebFrameImpl::createFileEntry):
      * src/WebFrameImpl.h:
      (WebFrameImpl):
      * src/WebWorkerClientImpl.cpp:
      (WebKit):
      (WebKit::WebWorkerClientImpl::openFileSystem):
      * src/WebWorkerClientImpl.h:
      * src/WorkerFileSystemCallbacksBridge.cpp:
      (WebKit):
      (WebKit::WorkerFileSystemCallbacksBridge::postOpenFileSystemToMainThread):
      (WebKit::WorkerFileSystemCallbacksBridge::openFileSystemOnMainThread):
      * src/WorkerFileSystemCallbacksBridge.h:
      (WorkerFileSystemCallbacksBridge):
      
      Tools:
      
      Update function declarations for new WebFileSystemType enum. (All
      changes are behind an #ifdef so we can sync required changes in embedders.)
      
      * DumpRenderTree/chromium/WebViewHost.cpp:
      (WebViewHost::openFileSystem):
      (WebViewHost::deleteFileSystem):
      * DumpRenderTree/chromium/WebViewHost.h:
      (WebViewHost):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146111 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e97e459b
    • ap@apple.com's avatar
      Update MessagePort terminology to match HTML5 · d2a6ad0a
      ap@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=112611
      
      Reviewed by Anders Carlsson.
      
      Transferable objects are "neutered" when transfered. Cloning is a different operation.
      
      * dom/MessagePort.cpp:
      (WebCore::MessagePort::disentanglePorts):
      * dom/MessagePort.h:
      (WebCore::MessagePort::isEntangled):
      (WebCore::MessagePort::isNeutered):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146110 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d2a6ad0a
    • roger_fong@apple.com's avatar
      AppleWin VS2010 build fix. · 2fc3d13a
      roger_fong@apple.com authored
      * WebCore.vcxproj/WebCore.vcxproj:
      * WebCore.vcxproj/WebCore.vcxproj.filters:
      * WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146109 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2fc3d13a
    • simon.fraser@apple.com's avatar
      Another asserting test. · f23c8ad7
      simon.fraser@apple.com authored
      * platform/mac/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146108 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f23c8ad7
    • simon.fraser@apple.com's avatar
      Mark a couple of asserty tests as such. · 9f1ce107
      simon.fraser@apple.com authored
      * platform/mac-wk2/TestExpectations:
      * platform/mac/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146107 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9f1ce107
    • jparent@chromium.org's avatar
      Cleanup: Move timeline_exporer js out of html file into js. · b2b98f4a
      jparent@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=112188
      
      Reviewed by Dirk Pranke.
      
      Moves the javascript out of the html file and into a new js file.
      This follows the format of flakiness_dashboard.{html|js}.
      
      Also moves code from dashboard_base that is used only by this one
      dashboard, and makes it private to the dashboard.
      
      * TestResultServer/static-dashboards/dashboard_base.js:
      * TestResultServer/static-dashboards/timeline_explorer.html:
      * TestResultServer/static-dashboards/timeline_explorer.js: Copied from Tools/TestResultServer/static-dashboards/timeline_explorer.html.
      (generatePage):
      (initCurrentBuilderTestResults):
      (shouldShowWebKitRevisionsOnly):
      (updateTimelineForBuilder.):
      (updateTimelineForBuilder):
      (selectBuild):
      (updateBuildIndicator):
      (.addRow):
      (.addNumberRow):
      (.inspectorNode.getElementsByTagName.0.onclick):
      (.inspectorNode.getElementsByTagName.1.onclick):
      (.inspectorNode.getElementsByTagName.2.onclick):
      (updateBuildInspector):
      (showResultsDelta):
      (decompressResults.addFlakyDelta):
      (decompressResults):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146106 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b2b98f4a
    • kbr@google.com's avatar
      Unreviewed gardening. Added expectation for failing test. · c3239e30
      kbr@google.com authored
      https://bugs.webkit.org/show_bug.cgi?id=112610
      
      * platform/chromium/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146105 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c3239e30
    • commit-queue@webkit.org's avatar
      [css3-text] Add rendering support for -webkit-text-underline-position · ba7c7004
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=102795
      
      Patch by Lamarque V. Souza <Lamarque.Souza@basyskom.com> on 2013-03-18
      Reviewed by Levi Weintraub.
      
      Source/WebCore:
      
      This patch implements rendering support for values [ auto | alphabetic | under ]
      of CSS3 property text-underline-position. We don't fully match the specification
      as we don't support [ left | right ] and this is left for another implementation
      as the rendering will need to be added.
      
      Tests: fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-all.html
             fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-alphabetic.html
             fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-auto.html
             fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-under-out-of-flow.html
             fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-under.html
      
      * rendering/InlineFlowBox.cpp:
      (WebCore::InlineFlowBox::computeMaxLogicalTop): Added method to compute maximal logical top among all chidren of
      this InlineTextBox.
      * rendering/InlineFlowBox.h:
      (InlineFlowBox):
      * rendering/InlineTextBox.cpp:
      (WebCore::computeUnderlineOffset): Added method to compute offset for text-underline-position property.
      (WebCore::InlineTextBox::paintDecoration): Paint decoration at position calculated using computeUnderlineOffset().
      * rendering/RootInlineBox.cpp:
      (WebCore::RootInlineBox::RootInlineBox):
      (WebCore::RootInlineBox::alignBoxesInBlockDirection): Call method to compute maximal logical top among all
      children of this RootInlineBox.
      * rendering/RootInlineBox.h:
      (RootInlineBox):
      (WebCore::RootInlineBox::maxLogicalTop): Added getter for m_maxLogicalTop class member.
      * rendering/style/RenderStyle.h: Added the usual getter / setter / initial methods for text-underline-position
      property
      
      LayoutTests:
      
      Added text-underline-position tests for 'text-underline-position' CSS3
      property, with 'webkit' prefix.
      
      * fast/css3-text/css3-text-decoration/text-underline-position/style.css: Added.
      * fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-all-expected.txt: Added.
      * fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-all.html: Added.
      * fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-alphabetic-expected.txt: Added.
      * fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-alphabetic.html: Added.
      * fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-auto-expected.txt: Added.
      * fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-auto.html: Added.
      * fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-under-expected.txt: Added.
      * fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-under-out-of-flow-expected.txt: Added.
      * fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-under-out-of-flow.html: Added.
      * fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-under.html: Added.
      * platform/chromium-linux/fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-all-expected.png: Added.
      * platform/chromium-linux/fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-alphabetic-expected.png: Added.
      * platform/chromium-linux/fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-auto-expected.png: Added.
      * platform/chromium-linux/fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-under-expected.png: Added.
      * platform/chromium-linux/fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-under-out-of-flow-expected.png: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146104 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ba7c7004
    • commit-queue@webkit.org's avatar
      Convert old flexbox uses in html.css to new flexbox (non-<select>) · d52f5ae3
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=110837
      
      Patch by Christian Biesinger <cbiesinger@chromium.org> on 2013-03-18
      Reviewed by Ojan Vafai.
      
      No new tests (No change in behaviour)
      
      * css/html.css:
      (input::-webkit-clear-button):
      Missed this one in the original patch.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146103 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d52f5ae3
    • james.wei@intel.com's avatar
      AudioBasicProcessorNode need to check for deferred updating of output channels · 6a1c5a90
      james.wei@intel.com authored
      https://bugs.webkit.org/show_bug.cgi?id=112544
      
      There can in rare cases be a slight delay before the output
      bus is updated to the new number of channels because of tryLocks() in the
      context's updating system but the processor already updated to the new
      number of channels, so need to check the channel number before processing.
      
      Reviewed by Chris Rogers.
      
      * Modules/webaudio/AudioBasicProcessorNode.cpp:
      (WebCore::AudioBasicProcessorNode::process):
      * Modules/webaudio/WaveShaperProcessor.cpp:
      (WebCore::WaveShaperProcessor::process):
      * platform/audio/AudioDSPKernelProcessor.cpp:
      (WebCore::AudioDSPKernelProcessor::AudioDSPKernelProcessor):
      * platform/audio/AudioDSPKernelProcessor.h:
      (WebCore::AudioDSPKernelProcessor::numberOfChannels):
      (AudioDSPKernelProcessor):
      * platform/audio/AudioProcessor.h:
      (WebCore::AudioProcessor::AudioProcessor):
      (AudioProcessor):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146102 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6a1c5a90
    • dpranke@chromium.org's avatar
      Unreviewed, rolling out r145272. · 97ecb968
      dpranke@chromium.org authored
      http://trac.webkit.org/changeset/145272
      https://bugs.webkit.org/show_bug.cgi?id=111884
      
      Turns out the ASAN build is still broken; possibly there's
      something still setting LD_LIBRARY_PATH, or possibly there's
      something else wrong. In the meantime, we need it to work again.
      
      * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146101 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      97ecb968
    • msaboff@apple.com's avatar
      Potentially unsafe register allocations in DFG code generation · 4bf9c30e
      msaboff@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=112477
      
      Reviewed by Geoffrey Garen.
      
      Source/JavaScriptCore: 
      
      Moved allocation of temporary GPRs to be before any generated branches in the functions below.
      
      * dfg/DFGSpeculativeJIT32_64.cpp:
      (JSC::DFG::SpeculativeJIT::compileObjectToObjectOrOtherEquality):
      (JSC::DFG::SpeculativeJIT::compilePeepHoleObjectToObjectOrOtherEquality):
      (JSC::DFG::SpeculativeJIT::compileObjectOrOtherLogicalNot):
      * dfg/DFGSpeculativeJIT64.cpp:
      (JSC::DFG::SpeculativeJIT::compileObjectToObjectOrOtherEquality):
      (JSC::DFG::SpeculativeJIT::compilePeepHoleObjectToObjectOrOtherEquality):
      (JSC::DFG::SpeculativeJIT::compileObjectOrOtherLogicalNot):
      
      LayoutTests: 
      
      New tests added to verify proper operation of
      SpeculativeJIT::compileObjectToObjectOrOtherEquality,
      SpeculativeJIT::compilePeepHoleObjectToObjectOrOtherEquality
      and SpeculativeJIT::compileObjectOrOtherLogicalNot.
      
      * fast/js/dfg-compare-final-object-to-final-object-or-other-expected.txt: Added.
      * fast/js/dfg-compare-final-object-to-final-object-or-other.html: Added.
      * fast/js/dfg-logical-not-final-object-or-other-expected.txt: Added.
      * fast/js/dfg-logical-not-final-object-or-other.html: Added.
      * fast/js/dfg-peephole-compare-final-object-to-final-object-or-other-expected.txt: Added.
      * fast/js/dfg-peephole-compare-final-object-to-final-object-or-other.html: Added.
      * fast/js/script-tests/dfg-compare-final-object-to-final-object-or-other.js: Added.
      * fast/js/script-tests/dfg-logical-not-final-object-or-other.js: Added.
      * fast/js/script-tests/dfg-peephole-compare-final-object-to-final-object-or-other.js: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146100 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4bf9c30e
    • jchaffraix@webkit.org's avatar
      [CSS Grid Layout] Fix StyleGridData::operator== · 0fc3953a
      jchaffraix@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=112574
      
      Reviewed by Ojan Vafai.
      
      Source/WebCore:
      
      Test: fast/css-grid-layout/grid-auto-flow-update.html
      
      * rendering/style/StyleGridData.h:
      (WebCore::StyleGridData::operator==):
      Fixed a bad comparison that would make us ignore grid-auto-flow changes.
      
      LayoutTests:
      
      * fast/css-grid-layout/grid-auto-flow-update-expected.txt: Added.
      * fast/css-grid-layout/grid-auto-flow-update.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146098 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0fc3953a
    • roger_fong@apple.com's avatar
      Fix typo on Windows following r145849 that was causing DRT to crash 100% of the time. · 7ec59dc0
      roger_fong@apple.com authored
      * WebView.cpp:
      (WebView::setSmartInsertDeleteEnabled):
      (WebView::setSelectTrailingWhitespaceEnabled):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146097 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7ec59dc0
    • kbr@google.com's avatar
    • beidson@apple.com's avatar
      Mac build fix after http://trac.webkit.org/changeset/146088 · 5d53ee16
      beidson@apple.com authored
      * NetworkProcess/mac/NetworkResourceLoaderMac.mm:
      (WebKit::NetworkResourceLoader::platformDidReceiveResponse):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146095 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5d53ee16
    • rafaelw@chromium.org's avatar
      [HTMLTemplateElement] parseError check in processTemplateEndTag should use... · bd9cd618
      rafaelw@chromium.org authored
      [HTMLTemplateElement] parseError check in processTemplateEndTag should use hasTagName, not hasLocalName
      https://bugs.webkit.org/show_bug.cgi?id=112591
      
      Reviewed by Adam Barth.
      
      No tests needed, change is unobservable.
      
      * html/parser/HTMLTreeBuilder.cpp:
      (WebCore::HTMLTreeBuilder::processTemplateEndTag):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146094 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bd9cd618
    • rniwa@webkit.org's avatar
      delete-stale-build-files is too aggressive · 2c9f7be4
      rniwa@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=112595
      
      Reviewed by Tim Horton.
      
      It appears that whitelisting file extensions to keep is not a good idea.
      Blacklist files to delete instead, and only delete .o files for now.
      We can add more file extensions as needed.
      
      * BuildSlaveSupport/delete-stale-build-files:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146093 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2c9f7be4
    • commit-queue@webkit.org's avatar
      [BlackBerry] Prevent text selection inside Colour and Date/Time input fields · ad53ad4a
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=111733
      
      Patch by Alberto Garcia <agarcia@igalia.com> on 2013-03-18
      Reviewed by Rob Buis.
      
      Fix missing brace.
      
      * WebKitSupport/SelectionHandler.cpp:
      (BlackBerry::WebKit::SelectionHandler::selectionPositionChanged):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146092 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ad53ad4a
    • jknotten@chromium.org's avatar
      [Chromium] Compositor is applying scroll offset using 'programmatic' API · 5942d437
      jknotten@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=109712
      
      Reviewed by James Robinson.
      
      Ensure that the compositor uses non-programmatic APIs to scroll and
      scale.
      
      * src/WebViewImpl.cpp:
      (WebKit::WebViewImpl::setPageScaleFactor):
      (WebKit::WebViewImpl::updateMainFrameScrollPosition):
      (WebKit):
      (WebKit::WebViewImpl::applyScrollAndScale):
      * src/WebViewImpl.h:
      (WebViewImpl):
      * tests/WebFrameTest.cpp:
      * tests/WebViewTest.cpp:
      * tests/data/long_scroll.html: Added.
      * tests/data/short_scroll.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146091 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5942d437
    • commit-queue@webkit.org's avatar
      [BlackBerry] Add Proximity Detector. · 4e1f683f
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=112278
      
      Patch by Alberto Garcia <agarcia@igalia.com> on 2013-03-18
      Reviewed by Rob Buis.
      
      Fix variable names so they actually match the function
      declarations.
      
      Fix call to rectForPoint(), which was moved from HitTestResult to
      HitTestLocation in r117091 and r126859.
      
      * WebKitSupport/ProximityDetector.cpp:
      (BlackBerry::WebKit::ProximityDetector::findBestPoint):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146090 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4e1f683f