1. 29 Sep, 2006 23 commits
    • adele's avatar
      Fixing accidental include. · 897ffad4
      adele authored
              * rendering/RenderListBox.cpp:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16666 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      897ffad4
    • adele's avatar
      Adding RenderListBox files. · f520b80e
      adele authored
       
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16665 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f520b80e
    • bdakin's avatar
      Fixing typo. No problem in the ned. Just the end. · 4f09628e
      bdakin authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16664 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4f09628e
    • adele's avatar
      Reviewed by Adam. · f989049f
      adele authored
              Initial implementation of engine-based list box control.
      
              * WebCore.xcodeproj/project.pbxproj: Added RenderListBox.h and RenderListBox.cpp
      
              * bridge/mac/FrameMac.h: Added _mouseDownMayStartAutoscroll.
              * bridge/mac/FrameMac.mm: Updated autoscroll code to use renderers instead of layers, so any renderer that implements autoscroll will work.
              (WebCore::FrameMac::FrameMac):
              (WebCore::FrameMac::handleMousePressEvent):
              (WebCore::FrameMac::handleMouseMoveEvent):
              (WebCore::FrameMac::mouseDown):
      
              * page/Frame.cpp:
              (WebCore::Frame::handleMouseMoveEvent):
              (WebCore::Frame::scrollOverflow): Don't scroll list box here- this would cause arrow keys to scroll instead of select.
              (WebCore::Frame::handleAutoscroll): Updated to use a renderer instead of a layer when setting up autoscroll.
              (WebCore::Frame::autoscrollTimerFired): ditto.
              (WebCore::Frame::stopAutoscrollTimer): ditto.
              (WebCore::Frame::passWidgetMouseDownEventToWidget): Updated to check for list box's scroll bar.
              * page/Frame.h:
              * page/FramePrivate.h: (WebCore::FramePrivate::FramePrivate): Updated to use renderer unstead of layer for autoscroll.
      
              * page/FrameView.cpp: Keep track of current mouse position so this can be used for list box autoscroll.
              (WebCore::FrameViewPrivate::reset):
              (WebCore::FrameView::currentMousePosition):
              (WebCore::FrameView::handleMousePressEvent):
              (WebCore::FrameView::handleMouseDoubleClickEvent):
              (WebCore::selectCursor):
              (WebCore::FrameView::handleMouseMoveEvent):
              (WebCore::FrameView::handleMouseReleaseEvent):
              * page/FrameView.h:
      
              * platform/ScrollBar.cpp: (WebCore::ScrollBar::ScrollBar): Added controlSize argument.  The list box will use a smaller scroll bar size.
              * platform/ScrollBar.h:
              (WebCore::):
              (WebCore::ScrollBar::controlSize):
              * platform/mac/PlatformScrollBar.h:
              * platform/mac/PlatformScrollBarMac.mm:
              (NSControlSizeForScrollBarControlSize):
              (-[WebCoreScrollBar initWithPlatformScrollBar:]):
              (WebCore::PlatformScrollBar::PlatformScrollBar):
      
              * rendering/RenderBlock.h:
              * rendering/RenderLayer.cpp: (WebCore::RenderLayer::createScrollbar): Updated to pass regular control size to scrollbar constructor.
              * rendering/RenderLayer.h:
              * rendering/RenderObject.cpp:
              (WebCore::RenderObject::shouldAutoscroll):
              (WebCore::RenderObject::autoscroll):
              * rendering/RenderObject.h: (WebCore::RenderObject::isListBox):
      
              * css/html4.css: Added properties for new list boxes.
      
              * html/HTMLOptionElement.cpp:
              (WebCore::HTMLOptionElement::setSelected): Doesn't allow selection to be changed here if the option is disabled.
              (WebCore::HTMLOptionElement::disabled): Added. Checks the parent's disabled status.
              * html/HTMLOptionElement.h: Added disabled method.
      
              * html/HTMLSelectElement.cpp: Added appearance switch for new list box implementation.
              (WebCore::HTMLSelectElement::recalcStyle):
              (WebCore::HTMLSelectElement::lastSelectedListIndex):
              (WebCore::HTMLSelectElement::deselectItems):
              (WebCore::HTMLSelectElement::setSelectedIndex):
              (WebCore::HTMLSelectElement::isKeyboardFocusable):
              (WebCore::HTMLSelectElement::isMouseFocusable):
              (WebCore::HTMLSelectElement::createRenderer):
              (WebCore::HTMLSelectElement::recalcListItems):
              (WebCore::HTMLSelectElement::setRecalcListItems):
              (WebCore::HTMLSelectElement::reset):
              (WebCore::HTMLSelectElement::notifyOptionSelected):
              (WebCore::HTMLSelectElement::defaultEventHandler): Added code to select options for list box when clicking and using arrow keys.
              (WebCore::HTMLSelectElement::nextSelectableListIndex):
              (WebCore::HTMLSelectElement::previousSelectableListIndex):
              * html/HTMLSelectElement.h:
      
              * rendering/RenderTheme.cpp: Added support for ListBoxAppearance
              (WebCore::RenderTheme::paint):
              (WebCore::RenderTheme::paintBorderOnly):
              (WebCore::RenderTheme::paintDecorations):
              (WebCore::RenderTheme::activeListBoxSelectionBackgroundColor):
              (WebCore::RenderTheme::activeListBoxSelectionForegroundColor):
              (WebCore::RenderTheme::inactiveListBoxSelectionBackgroundColor):
              (WebCore::RenderTheme::inactiveListBoxSelectionForegroundColor):
              (WebCore::RenderTheme::isControlStyled):
              (WebCore::RenderTheme::supportsFocusRing):
              * rendering/RenderTheme.h:
              * rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::isControlStyled):
      
              * rendering/RenderListBox.cpp: Added.
              (WebCore::RenderListBox::RenderListBox):
              (WebCore::RenderListBox::~RenderListBox):
              (WebCore::RenderListBox::setStyle):
              (WebCore::RenderListBox::updateFromElement):
              (WebCore::RenderListBox::calcMinMaxWidth):
              (WebCore::RenderListBox::size):
              (WebCore::RenderListBox::numItems):
              (WebCore::RenderListBox::calcHeight):
              (WebCore::RenderListBox::baselinePosition):
              (WebCore::RenderListBox::itemBoundingBoxRect):
              (WebCore::RenderListBox::paintObject):
              (WebCore::RenderListBox::paintScrollbar):
              (WebCore::RenderListBox::paintItemForeground):
              (WebCore::RenderListBox::paintItemBackground):
              (WebCore::RenderListBox::scrollBarTarget):
              (WebCore::RenderListBox::isPointInScrollbar):
              (WebCore::RenderListBox::optionAtPoint):
              (WebCore::RenderListBox::autoscroll):
              (WebCore::RenderListBox::scrollToRevealElementAtListIndex):
              (WebCore::RenderListBox::scroll):
              (WebCore::RenderListBox::valueChanged):
              * rendering/RenderListBox.h: Added.
              (WebCore::RenderListBox::isListBox):
              (WebCore::RenderListBox::selectionChanged):
              (WebCore::RenderListBox::setSelectionChanged):
              (WebCore::RenderListBox::canHaveChildren):
              (WebCore::RenderListBox::renderName):
              (WebCore::RenderListBox::setOptionsChanged):
              (WebCore::RenderListBox::shouldAutoscroll):
              (WebCore::RenderListBox::listIndexIsVisible):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16663 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f989049f
    • bdakin's avatar
      Reviewed by Darin. · 9d05e15f
      bdakin authored
              We had a bug where html4.css was ignoring Media Queries. In the ned 
              the problem was that we were trying to send a char* to the 
              MediaQueryEvaluator constructor that expects a String, but the 
              char* got interpreted as a bool, the wrong constructor was called, 
              and the media type was never set.
      
              No test case possible since this only affects html4.css
      
              * css/MediaQueryEvaluator.cpp: New constructor that expects takes a 
              char*
              (WebCore::MediaQueryEvaluator):
              * css/MediaQueryEvaluator.h: Same.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16662 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9d05e15f
    • ggaren's avatar
      LayoutTests: · eb140e63
      ggaren authored
              Reviewed by John, Maciej.
              
              Added test for whether a frame element reports its src attribute as a
              complete, rather than relative, URL.
      
              * fast/frames/frame-src-attribute-expected.txt: Added.
              * fast/frames/frame-src-attribute.html: Added.
              * fast/frames/resources/frame-src-attribute-subframe.html: Added.
      
      WebCore:
      
              Reviewed by John, Maciej.
              
              Integrated some frame and iframe code. I'm trying to fix up frame ownership
              and loading. Reducing the number of different code paths involved
              seemed like a good first step.
              
              As a side effect, I fixed a bug where FRAME elements would report their
              src attributes as relative, rather than compelete, URLs. (IFRAME elements
              had the correct complete URL behavior.)
      
              * html/HTMLFrameElement.cpp:
              (WebCore::HTMLFrameElement::isURLAllowed): Fixed comment typo
              (WebCore::HTMLFrameElement::openURL):
                  (1) Removed checks that requestFrame does for us
                  (2) Added isURLAllowed check, to have one clear bottleneck for it
                  (3) Added viewsource check, to have one clear bottleneck for it
              (WebCore::HTMLFrameElement::close): Changed to use the common contentFrame()
              method, instead of finding our content frame in our own unique way.
              (WebCore::HTMLFrameElement::setLocation): Removed isURLAllowed check,
              since openURL does this for us now.
              (WebCore::HTMLFrameElement::src): Return complete URL instead of relative.
              This is what FF does, and it made no sense to have different behaviors
              for FRAME and IFRAME elements.
              * html/HTMLIFrameElement.cpp:
              (WebCore::HTMLIFrameElement::HTMLIFrameElement): Removed duplicate init
              code.
              * html/HTMLIFrameElement.h: Removed src() and openURL() methods, since
              HTMLFrameElement now does everything we need.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16661 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      eb140e63
    • rwlbuis's avatar
      Reviewed by Hyatt. · 3fbe04f4
      rwlbuis authored
              Fix Qt/Linux build.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16660 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3fbe04f4
    • thatcher's avatar
      Replace bugzilla.opendarwin.org with bugs.webkit.org. · 61b29d73
      thatcher authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16658 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      61b29d73
    • thatcher's avatar
      Replace bugzilla.opendarwin.org with bugs.webkit.org. · 7cc4d159
      thatcher authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16656 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7cc4d159
    • thatcher's avatar
      Replace bugzilla.opendarwin.org with bugs.webkit.org. · 555f3307
      thatcher authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16655 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      555f3307
    • thatcher's avatar
      Replace bugzilla.opendarwin.org with bugs.webkit.org. · 96b589aa
      thatcher authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16654 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      96b589aa
    • thatcher's avatar
      Replace bugzilla.opendarwin.org with bugs.webkit.org. · e728c26e
      thatcher authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16653 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e728c26e
    • thatcher's avatar
      Replace bugzilla.opendarwin.org with bugs.webkit.org. · 6722778b
      thatcher authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16652 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6722778b
    • thatcher's avatar
      Replace bugzilla.opendarwin.org with bugs.webkit.org. · 3d5cee55
      thatcher authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16651 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3d5cee55
    • thatcher's avatar
      Replace bugzilla.opendarwin.org with bugs.webkit.org. · d8c1b5e8
      thatcher authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16650 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d8c1b5e8
    • thatcher's avatar
      Replace bugzilla.opendarwin.org with bugs.webkit.org. · 2d370ce0
      thatcher authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16649 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2d370ce0
    • thatcher's avatar
      Replace bugzilla.opendarwin.org with bugs.webkit.org. · 5c038c28
      thatcher authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16648 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5c038c28
    • weinig's avatar
      Reviewed by Tim H. · ac93628e
      weinig authored
              Patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=11082
              Simplify Internal methods for the auto-generated Objective-C DOM code
      
              - Auto-generate the internal methods for more Objective-C classes.
      
              * WebCore.xcodeproj/project.pbxproj:
              * bindings/objc/DOM.mm:
              * bindings/objc/DOMCSS.mm:
              (-[DOMStyleSheet WebCore::]):
              (+[DOMStyleSheet _styleSheetWith:WebCore::]):
              (-[DOMCSSRule WebCore::]):
              (-[DOMCSSRule _initWithCSSRule:WebCore::]):
              (+[DOMCSSRule _CSSRuleWith:WebCore::]):
              (-[DOMCSSValue WebCore::]):
              (-[DOMCSSValue _initWithCSSValue:WebCore::]):
              (+[DOMCSSValue _CSSValueWith:WebCore::]):
              * bindings/objc/DOMHTMLAppletElement.mm:
              (-[DOMHTMLAppletElement WebCore::]):
              (+[DOMHTMLAppletElement _HTMLOptionElementWith:WebCore::]):
              * bindings/objc/DOMHTMLEmbedElement.mm:
              (-[DOMHTMLEmbedElement WebCore::]):
              (+[DOMHTMLEmbedElement _HTMLEmbedElementWith:WebCore::]):
              * bindings/objc/DOMInternal.h:
              * bindings/objc/DOMInternal.mm:
              * bindings/scripts/CodeGeneratorObjC.pm:
              * css/CSSCharsetRule.idl:
              * css/CSSFontFaceRule.idl:
              * css/CSSImportRule.idl:
              * css/CSSMediaRule.idl:
              * css/CSSPageRule.idl:
              * css/CSSPrimitiveValue.idl:
              * css/CSSStyleRule.idl:
              * css/CSSStyleSheet.idl:
              * css/CSSUnknownRule.idl:
              * css/CSSValueList.idl:
              * dom/KeyboardEvent.idl:
              * dom/MouseEvent.idl:
              * dom/MutationEvent.idl:
              * dom/NodeIterator.idl:
              * dom/OverflowEvent.idl:
              * dom/UIEvent.idl:
              * dom/WheelEvent.idl:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16645 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ac93628e
    • harrison's avatar
      LayoutTests: · 43f6c9d0
      harrison authored
              Reviewed by John Sullivan.
      
              <rdar://problem/4663772> REGRESSION: Cannot type in Japanese after replying to a particular message
              <rdar://problem/4673293> REGRESSION: Can't enter the Japanese characters in Mail or Blot
      
              * fast/text/attributed-substring-from-range-001-expected.txt: Added.
              * fast/text/attributed-substring-from-range-001.html: Added.
              
              Check attributed string results when starting or ending at a br element.
      
      WebCore:
      
              Reviewed by John Sullivan.
      
              <rdar://problem/4663772> REGRESSION: Cannot type in Japanese after replying to a particular message
              <rdar://problem/4673293> REGRESSION: Can't enter the Japanese characters in Mail or Blot
      
              Test added
              * fast/text/attributed-substring-from-range-001.html
      
              * bridge/mac/FrameMac.mm:
              (WebCore::FrameMac::attributedString):
              Handle non-zero offsets when start and/or end node is a container. Offset used to be ignored in this case.
              Also, add validation of the range.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16642 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      43f6c9d0
    • thatcher's avatar
      Reviewed by Maciej. · ba8aa975
      thatcher authored
              Switch the inspector over to use border-image with styled buttons and selects.
      
              * WebInspector/WebInspector.m:
              (-[NSWindow window]):
              (-[NSWindow setWebFrame:]):
              (-[WebInspector _updateRoot]):
              * WebInspector/webInspector/Images/button.png: Added.
              * WebInspector/webInspector/Images/buttonDivider.png: Added.
              * WebInspector/webInspector/Images/buttonPressed.png: Added.
              * WebInspector/webInspector/Images/popup.png: Added.
              * WebInspector/webInspector/Images/popupFill.png: Removed.
              * WebInspector/webInspector/Images/popupFillPressed.png: Removed.
              * WebInspector/webInspector/Images/popupLeft.png: Removed.
              * WebInspector/webInspector/Images/popupLeftPressed.png: Removed.
              * WebInspector/webInspector/Images/popupPressed.png: Added.
              * WebInspector/webInspector/Images/popupRight.png: Removed.
              * WebInspector/webInspector/Images/popupRightPressed.png: Removed.
              * WebInspector/webInspector/Images/squareButtonRight.png: Removed.
              * WebInspector/webInspector/Images/squareButtonRightPressed.png: Removed.
              * WebInspector/webInspector/inspector.css:
              * WebInspector/webInspector/inspector.html:
              * WebInspector/webInspector/inspector.js:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16641 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ba8aa975
    • rwlbuis's avatar
      I commited old expected results, this one is correct. · 040adbfb
      rwlbuis authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16637 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      040adbfb
    • hyatt's avatar
      Add the ability to set the click count after the fact on a mouse event. · 5d33875b
      hyatt authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16634 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5d33875b
    • rwlbuis's avatar
      Reviewed by Maciej. · eb9f6717
      rwlbuis authored
              http://bugzilla.opendarwin.org/show_bug.cgi?id=10893
              InsertRule can not handle @import statements
      
              Allow @import as part of a css rule.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16633 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      eb9f6717
  2. 28 Sep, 2006 17 commits
    • sfalken's avatar
      2006-09-28 Steve Falkenburg <sfalken@apple.com> · abd152d8
      sfalken authored
              Reviewed by Maciej.
              
              Use $(ConfigSuffix) set via vsprops files to add _debug
              to end of debug filenames.
      
              * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
              * JavaScriptCore.vcproj/debug.vsprops: Added.
              * JavaScriptCore.vcproj/dftables/dftables.vcproj:
              * JavaScriptCore.vcproj/release.vsprops: Added.
              * JavaScriptCore.vcproj/testkjs/testkjs.vcproj:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16632 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      abd152d8
    • hyatt's avatar
      Switch over the Mac-specific uses of viewportToContents/contentsToViewport. · 80a6a30d
      hyatt authored
              * bridge/mac/FrameMac.mm:
              (WebCore::FrameMac::eventMayStartDrag):
              (WebCore::FrameMac::dragHysteresisExceeded):
              (WebCore::FrameMac::mouseDown):
              (WebCore::FrameMac::shouldDragAutoNode):
              (WebCore::FrameMac::sendContextMenuEvent):
              * bridge/mac/WebCoreFrameBridge.mm:
              (-[WebCoreFrameBridge _visiblePositionForPoint:]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16631 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      80a6a30d
    • hyatt's avatar
      Eliminate viewportToContents and contentsToViewport · 97c694f0
      hyatt authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16630 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      97c694f0
    • aliceli1's avatar
      Build fix by adding missing files for CommandByName · 82b0749c
      aliceli1 authored
              * WebCore.xcodeproj/project.pbxproj:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16629 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      82b0749c
    • aliceli1's avatar
      Adding CommandByName files to the vcproj · 42f98123
      aliceli1 authored
              * WebCore.vcproj/WebCore/WebCore.vcproj:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16628 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      42f98123
    • aliceli1's avatar
      fixing the windows build · b1f0fbe5
      aliceli1 authored
              * COM/WebView.cpp:
              (WebView::mouseMoved):
              (WebView::mouseDown):
              (WebView::mouseUp):
              (WebView::mouseDoubleClick):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16627 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b1f0fbe5
    • aliceli1's avatar
      · 0da5e09a
      aliceli1 authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16626 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0da5e09a
    • aroben's avatar
      Reviewed by Adele. · 5b965904
      aroben authored
              Remove no-longer-used PopUpButton.
      
              * WebCore.vcproj/WebCore/WebCore.vcproj: Remove PopUpButton.h
              * WebCore.xcodeproj/project.pbxproj: Remove PopUpButton.h,
      	PopUpButtonMac.mm
              * platform/PopUpButton.h: Removed.
              * platform/mac/PopUpButtonMac.mm: Removed.
              * platform/win/TemporaryLinkStubs.cpp: Remove PopUpButton:: methods
              * rendering/DeprecatedRenderSelect.cpp: Change #include of
      	PopUpButton.h to ListBox.h
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16624 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5b965904
    • harrison's avatar
      Suggested by Darin. · f40ae62c
      harrison authored
              
              Moved an extern declaration from inside a method to the top of the file.
      
              * DumpRenderTree/EventSendingController.m:
              (-[EventSendingController clearKillRing]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16623 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f40ae62c
    • darin's avatar
      JavaScriptCore: · 6138a1eb
      darin authored
              Reviewed by Alice.
      
              - support for change that should fix <rdar://problem/4733044>
                REGRESSION: XML iBench shows 10% perf. regression (copying
                strings while decoding)
      
              * wtf/Vector.h: Changed VectorBuffer so that the general case
              contains an instance of the 0 case, since deriving from it
              was violating the Liskov Substitution Principle.
              (WTF::VectorBuffer::releaseBuffer): Added. Releases the buffer so it can
              be adopted by another data structure that uses the FastMalloc.h allocator.
              Returns 0 if the internal buffer was being used.
              (WTF::Vector::releaseBuffer): Added. Releases the buffer as above or creates
              a new one in the case where the internal buffer was being used.
      
      WebCore:
      
              Reviewed by Alice.
      
              - change that should fix <rdar://problem/4733044> REGRESSION: XML iBench shows
                10% perf. regression (copying strings while decoding)
      
              Use Vector<UChar> instead of String when building up the decoded string in
              the ICU and Mac decoders. Using String leads to O(n^2) behavior because
              String grows the buffer every single time that append is called. Using
              Vector::append instead of String::append also avoids constructing a string
              each time just to append and a questionable copy that is done inside the
              String::append function which also contributed to the slowness.
      
              * platform/PlatformString.h:
              * platform/String.cpp: (WebCore::String::adopt): Added. Makes a String from a
              Vector<UChar>, adopting the buffer from the vector to avoid copying and memory
              allocation.
              * platform/StringImpl.h:
              * platform/StringImpl.cpp: (WebCore::StringImpl::adopt): Ditto.
      
              * platform/StreamingTextDecoder.h:
              * platform/StreamingTextDecoder.cpp: (WebCore::TextCodec::appendOmittingBOM):
              Change to use a Vector<UChar> instead of a String, since vectors have better
              resizing performance (they store a separate capacity).
      
              * platform/StreamingTextDecoderICU.cpp: (WebCore::TextCodecICU::decode):
              * platform/mac/StreamingTextDecoderMac.cpp: (WebCore::TextCodecMac::decode):
              Change to use Vector<UChar> instead of String and then create a string at
              the end of the process using the new adopt function.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16622 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6138a1eb
    • thatcher's avatar
      Explicitly specify stabs for Debug and Production. · 0ed964cc
      thatcher authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16621 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0ed964cc
    • harrison's avatar
      LayoutTests: · a353c8cb
      harrison authored
              Reviewed by Justin.
      
              Call clearKillRing() so we are guaranteed to start with empty kill ring.
      
              * editing/pasteboard/emacs-cntl-y-001.html:
      
      WebKitTools:
      
              Reviewed by Justin.
              
              Add clearKillRing so we can test emacs support with empty kill ring.
      
              * DumpRenderTree/EventSendingController.m:
              (+[EventSendingController isSelectorExcludedFromWebScript:]):
              (+[EventSendingController webScriptNameForSelector:]):
              (-[EventSendingController clearKillRing]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16620 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a353c8cb
    • weinig's avatar
      Reviewed by Tim H. · f64d1354
      weinig authored
              Patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=11057
              Auto-generate more SVG Objective-C bindings
      
              - Auto-generates DOMSVGAnimatedAngle, DOMSVGAnimatedBoolean, 
                DOMSVGAnimatedEnumeration, DOMSVGAnimatedInteger, DOMSVGAnimatedLength,
                DOMSVGAnimatedLengthList, DOMSVGAnimatedNumber, DOMSVGAnimatedString,
                DOMSVGAnimatedTransformList, DOMSVGExternalResourcesRequired,
                DOMSVGLangSpace, DOMSVGLocatable, DOMSVGMetadataElement, DOMSVGRectElement,
                DOMSVGStringList, DOMSVGStylable, DOMSVGStyleElement, DOMSVGTests, 
                and DOMSVGTransformable.
      
              - Adds ability to CodeGeneratorObjC.pm to handle interfaces with mulitple
                parent interfaces and the SVG animated classes.
      
              - Corrects CodeGenerator.pm to only skip the first parent for the main 
                interface.
      
              * DerivedSources.make:
              * WebCore.xcodeproj/project.pbxproj:
              * bindings/objc/DOMInternal.h:
              * bindings/objc/DOMSVG.h:
              * bindings/scripts/CodeGenerator.pm:
              * bindings/scripts/CodeGeneratorObjC.pm:
              * ksvg2/svg/SVGAnimatedAngle.idl:
              * ksvg2/svg/SVGAnimatedBoolean.idl:
              * ksvg2/svg/SVGAnimatedEnumeration.idl:
              * ksvg2/svg/SVGAnimatedInteger.idl:
              * ksvg2/svg/SVGAnimatedLength.idl:
              * ksvg2/svg/SVGAnimatedLengthList.idl:
              * ksvg2/svg/SVGAnimatedNumber.idl:
              * ksvg2/svg/SVGAnimatedPathData.idl:
              * ksvg2/svg/SVGAnimatedString.idl:
              * ksvg2/svg/SVGAnimatedTransformList.idl:
              * ksvg2/svg/SVGExternalResourcesRequired.idl:
              * ksvg2/svg/SVGFilterPrimitiveStandardAttributes.idl:
              * ksvg2/svg/SVGFitToViewBox.idl:
              * ksvg2/svg/SVGLangSpace.idl:
              * ksvg2/svg/SVGLocatable.idl:
              * ksvg2/svg/SVGMetadataElement.idl:
              * ksvg2/svg/SVGStringList.idl:
              * ksvg2/svg/SVGStylable.idl:
              * ksvg2/svg/SVGStyleElement.idl:
              * ksvg2/svg/SVGTests.idl:
              * ksvg2/svg/SVGTransformable.idl:
              * ksvg2/svg/SVGURIReference.idl:
              * ksvg2/svg/SVGUnitTypes.idl:
              * ksvg2/svg/SVGZoomAndPan.idl:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16616 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f64d1354
    • beidson's avatar
      Reviewed by Mitz Pettel!!! · a31d0ecf
      beidson authored
              Change the error code check for common functions from SQLResultOk to SQLResultDone 
      
              * loader/icon/IconDatabase.cpp:
              (WebCore::IconDatabase::forgetPageURLQuery):
              (WebCore::IconDatabase::setIconIDForPageURLQuery):
              (WebCore::IconDatabase::addIconForIconURLQuery):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16615 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a31d0ecf
    • mjs's avatar
      Reviewed by Geoff. · 8b09e507
      mjs authored
              
              - change garbage collection to happen at increments proportional to number of live objects, not always
              every 1000 allocations
      
              * kjs/collector.cpp:
              (KJS::Collector::allocate):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16614 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8b09e507
    • mjs's avatar
      Reviewed by Mitz. · f1623c9f
      mjs authored
              - fixed REGRESSION (r16606): javascriptCore Crash on website load
              
              Plus style fixes.
              
                  - fixed some possible off-by-one bugs
                  - use indexing, not iterators, for Vectors
                  - store Vector by pointer instead of by value to avoid blowing out FunctionImp size
              
              * kjs/function.cpp:
              (KJS::FunctionImp::addParameter):
              (KJS::FunctionImp::parameterString):
              (KJS::FunctionImp::processParameters):
              (KJS::FunctionImp::lengthGetter):
              (KJS::FunctionImp::getParameterName):
              * kjs/function.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16613 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f1623c9f
    • hyatt's avatar
      Dump the use of MapWindowPoints on Win32 and just let the outermost HWND be... · 18d2f317
      hyatt authored
      Dump the use of MapWindowPoints on Win32 and just let the outermost HWND be the viewport point of reference for events and such.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16612 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      18d2f317