- 28 Apr, 2010 35 commits
-
-
evan@chromium.org authored
Reviewed by Darin Adler. fast/text/international/bold-bengali needs baselines https://bugs.webkit.org/show_bug.cgi?id=38273 * platform/chromium-win/fast/text/international/bold-bengali-expected.checksum: Added. * platform/chromium-win/fast/text/international/bold-bengali-expected.png: Added. * platform/mac/fast/text/international/bold-bengali-expected.checksum: Added. * platform/mac/fast/text/international/bold-bengali-expected.png: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58416 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
xji@chromium.org authored
Reviewed by Dimitri Glazkov Rebaseline Webkit Mac pixel results and chromium pixel results caused by http://trac.webkit.org/changeset/58191 Webkit Mac pixel results failed with --tolerance=0 https://bugs.webkit.org/show_bug.cgi?id=38104 * platform/chromium-linux/editing/deleting/4845371-expected.checksum: * platform/chromium-linux/editing/deleting/4845371-expected.png: Removed. * platform/chromium-linux/editing/deleting/5126166-expected.checksum: * platform/chromium-linux/editing/deleting/5126166-expected.png: * platform/chromium-linux/editing/deleting/5483370-expected.checksum: * platform/chromium-linux/editing/deleting/5483370-expected.png: * platform/chromium-linux/editing/deleting/table-cells-expected.checksum: * platform/chromium-linux/editing/deleting/table-cells-expected.png: Removed. * platform/chromium-linux/editing/inserting/4875189-2-expected.checksum: * platform/chromium-linux/editing/inserting/4875189-2-expected.png: * platform/chromium-linux/editing/pasteboard/5387578-expected.checksum: * platform/chromium-linux/editing/pasteboard/5387578-expected.png: * platform/chromium-linux/editing/pasteboard/paste-4039777-fix-expected.checksum: * platform/chromium-linux/editing/pasteboard/paste-4039777-fix-expected.png: * platform/chromium-linux/editing/pasteboard/paste-table-001-expected.checksum: * platform/chromium-linux/editing/pasteboard/paste-table-001-expected.png: Removed. * platform/chromium-linux/editing/pasteboard/paste-table-cells-expected.checksum: * platform/chromium-linux/editing/pasteboard/paste-table-cells-expected.png: Removed. * platform/chromium-linux/editing/selection/move-past-trailing-space-expected.checksum: * platform/chromium-linux/editing/selection/move-past-trailing-space-expected.png: Removed. * platform/chromium-linux/fast/inline-block/14498-positionForCoordinates-expected.checksum: * platform/chromium-linux/fast/inline-block/14498-positionForCoordinates-expected.png: Removed. * platform/chromium-linux/fast/repaint/caret-outside-block-expected.checksum: * platform/chromium-linux/fast/repaint/caret-outside-block-expected.png: Removed. * platform/chromium-mac/editing/deleting/4845371-expected.checksum: Added. * platform/chromium-mac/editing/deleting/5126166-expected.checksum: Added. * platform/chromium-mac/editing/deleting/5483370-expected.checksum: Added. * platform/chromium-mac/editing/deleting/table-cells-expected.checksum: Added. * platform/chromium-mac/editing/inserting/4875189-2-expected.checksum: Added. * platform/chromium-mac/editing/pasteboard/5387578-expected.checksum: Added. * platform/chromium-mac/editing/pasteboard/paste-4039777-fix-expected.checksum: Added. * platform/chromium-mac/editing/pasteboard/paste-table-001-expected.checksum: Added. * platform/chromium-mac/editing/pasteboard/paste-table-cells-expected.checksum: Added. * platform/chromium-mac/editing/selection/move-past-trailing-space-expected.checksum: Added. * platform/chromium-mac/fast/inline-block/14498-positionForCoordinates-expected.checksum: Added. * platform/chromium-mac/fast/repaint/caret-outside-block-expected.checksum: Added. * platform/chromium-mac/fast/repaint/caret-outside-block-expected.png: Added. * platform/chromium-win/editing/deleting/4845371-expected.checksum: * platform/chromium-win/editing/deleting/4845371-expected.png: * platform/chromium-win/editing/deleting/5126166-expected.checksum: * platform/chromium-win/editing/deleting/5126166-expected.png: * platform/chromium-win/editing/deleting/5483370-expected.checksum: * platform/chromium-win/editing/deleting/5483370-expected.png: * platform/chromium-win/editing/deleting/table-cells-expected.checksum: * platform/chromium-win/editing/deleting/table-cells-expected.png: * platform/chromium-win/editing/inserting/4875189-2-expected.checksum: * platform/chromium-win/editing/inserting/4875189-2-expected.png: * platform/chromium-win/editing/pasteboard/5387578-expected.checksum: * platform/chromium-win/editing/pasteboard/5387578-expected.png: * platform/chromium-win/editing/pasteboard/paste-4039777-fix-expected.checksum: * platform/chromium-win/editing/pasteboard/paste-4039777-fix-expected.png: * platform/chromium-win/editing/pasteboard/paste-table-001-expected.checksum: * platform/chromium-win/editing/pasteboard/paste-table-001-expected.png: * platform/chromium-win/editing/pasteboard/paste-table-cells-expected.checksum: * platform/chromium-win/editing/pasteboard/paste-table-cells-expected.png: * platform/chromium-win/editing/selection/move-past-trailing-space-expected.checksum: * platform/chromium-win/editing/selection/move-past-trailing-space-expected.png: * platform/chromium-win/fast/inline-block/14498-positionForCoordinates-expected.checksum: * platform/chromium-win/fast/inline-block/14498-positionForCoordinates-expected.png: * platform/chromium-win/fast/repaint/caret-outside-block-expected.checksum: * platform/chromium-win/fast/repaint/caret-outside-block-expected.png: * platform/chromium/test_expectations.txt: * platform/mac/editing/deleting/4845371-expected.png: * platform/mac/editing/deleting/5126166-expected.png: * platform/mac/editing/deleting/5483370-expected.png: * platform/mac/editing/deleting/table-cells-expected.png: * platform/mac/editing/inserting/4875189-2-expected.png: * platform/mac/editing/pasteboard/5387578-expected.png: * platform/mac/editing/pasteboard/paste-4039777-fix-expected.png: * platform/mac/editing/pasteboard/paste-table-001-expected.png: * platform/mac/editing/pasteboard/paste-table-cells-expected.png: * platform/mac/editing/selection/move-past-trailing-space-expected.png: * platform/mac/fast/inline-block/14498-positionForCoordinates-expected.png: * platform/mac/fast/repaint/caret-outside-block-expected.png: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58415 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
xji@chromium.org authored
Reviewed by Dimitri Glazkov Rebaseline Webkit Mac pixel results and chromium pixel results caused by http://trac.webkit.org/changeset/58191 Webkit Mac pixel results failed with --tolerance=0 * platform/chromium-linux/editing/deleting/4845371-expected.checksum: * platform/chromium-linux/editing/deleting/4845371-expected.png: Removed. * platform/chromium-linux/editing/deleting/5126166-expected.checksum: * platform/chromium-linux/editing/deleting/5126166-expected.png: * platform/chromium-linux/editing/deleting/5483370-expected.checksum: * platform/chromium-linux/editing/deleting/5483370-expected.png: * platform/chromium-linux/editing/deleting/table-cells-expected.checksum: * platform/chromium-linux/editing/deleting/table-cells-expected.png: Removed. * platform/chromium-linux/editing/inserting/4875189-2-expected.checksum: * platform/chromium-linux/editing/inserting/4875189-2-expected.png: * platform/chromium-linux/editing/pasteboard/5387578-expected.checksum: * platform/chromium-linux/editing/pasteboard/5387578-expected.png: * platform/chromium-linux/editing/pasteboard/paste-4039777-fix-expected.checksum: * platform/chromium-linux/editing/pasteboard/paste-4039777-fix-expected.png: * platform/chromium-linux/editing/pasteboard/paste-table-001-expected.checksum: * platform/chromium-linux/editing/pasteboard/paste-table-001-expected.png: Removed. * platform/chromium-linux/editing/pasteboard/paste-table-cells-expected.checksum: * platform/chromium-linux/editing/pasteboard/paste-table-cells-expected.png: Removed. * platform/chromium-linux/editing/selection/move-past-trailing-space-expected.checksum: * platform/chromium-linux/editing/selection/move-past-trailing-space-expected.png: Removed. * platform/chromium-linux/fast/inline-block/14498-positionForCoordinates-expected.checksum: * platform/chromium-linux/fast/inline-block/14498-positionForCoordinates-expected.png: Removed. * platform/chromium-linux/fast/repaint/caret-outside-block-expected.checksum: * platform/chromium-linux/fast/repaint/caret-outside-block-expected.png: Removed. * platform/chromium-mac/editing/deleting/4845371-expected.checksum: Added. * platform/chromium-mac/editing/deleting/5126166-expected.checksum: Added. * platform/chromium-mac/editing/deleting/5483370-expected.checksum: Added. * platform/chromium-mac/editing/deleting/table-cells-expected.checksum: Added. * platform/chromium-mac/editing/inserting/4875189-2-expected.checksum: Added. * platform/chromium-mac/editing/pasteboard/5387578-expected.checksum: Added. * platform/chromium-mac/editing/pasteboard/paste-4039777-fix-expected.checksum: Added. * platform/chromium-mac/editing/pasteboard/paste-table-001-expected.checksum: Added. * platform/chromium-mac/editing/pasteboard/paste-table-cells-expected.checksum: Added. * platform/chromium-mac/editing/selection/move-past-trailing-space-expected.checksum: Added. * platform/chromium-mac/fast/inline-block/14498-positionForCoordinates-expected.checksum: Added. * platform/chromium-mac/fast/repaint/caret-outside-block-expected.checksum: Added. * platform/chromium-mac/fast/repaint/caret-outside-block-expected.png: Added. * platform/chromium-win/editing/deleting/4845371-expected.checksum: * platform/chromium-win/editing/deleting/4845371-expected.png: * platform/chromium-win/editing/deleting/5126166-expected.checksum: * platform/chromium-win/editing/deleting/5126166-expected.png: * platform/chromium-win/editing/deleting/5483370-expected.checksum: * platform/chromium-win/editing/deleting/5483370-expected.png: * platform/chromium-win/editing/deleting/table-cells-expected.checksum: * platform/chromium-win/editing/deleting/table-cells-expected.png: * platform/chromium-win/editing/inserting/4875189-2-expected.checksum: * platform/chromium-win/editing/inserting/4875189-2-expected.png: * platform/chromium-win/editing/pasteboard/5387578-expected.checksum: * platform/chromium-win/editing/pasteboard/5387578-expected.png: * platform/chromium-win/editing/pasteboard/paste-4039777-fix-expected.checksum: * platform/chromium-win/editing/pasteboard/paste-4039777-fix-expected.png: * platform/chromium-win/editing/pasteboard/paste-table-001-expected.checksum: * platform/chromium-win/editing/pasteboard/paste-table-001-expected.png: * platform/chromium-win/editing/pasteboard/paste-table-cells-expected.checksum: * platform/chromium-win/editing/pasteboard/paste-table-cells-expected.png: * platform/chromium-win/editing/selection/move-past-trailing-space-expected.checksum: * platform/chromium-win/editing/selection/move-past-trailing-space-expected.png: * platform/chromium-win/fast/inline-block/14498-positionForCoordinates-expected.checksum: * platform/chromium-win/fast/inline-block/14498-positionForCoordinates-expected.png: * platform/chromium-win/fast/repaint/caret-outside-block-expected.checksum: * platform/chromium-win/fast/repaint/caret-outside-block-expected.png: * platform/chromium/test_expectations.txt: * platform/mac/editing/deleting/4845371-expected.png: * platform/mac/editing/deleting/5126166-expected.png: * platform/mac/editing/deleting/5483370-expected.png: * platform/mac/editing/deleting/table-cells-expected.png: * platform/mac/editing/inserting/4875189-2-expected.png: * platform/mac/editing/pasteboard/5387578-expected.png: * platform/mac/editing/pasteboard/paste-4039777-fix-expected.png: * platform/mac/editing/pasteboard/paste-table-001-expected.png: * platform/mac/editing/pasteboard/paste-table-cells-expected.png: * platform/mac/editing/selection/move-past-trailing-space-expected.png: * platform/mac/fast/inline-block/14498-positionForCoordinates-expected.png: * platform/mac/fast/repaint/caret-outside-block-expected.png: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58414 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
pfeldman@chromium.org authored
Reviewed by Pavel Feldman. Fixed passing breakpoints to V8. https://bugs.webkit.org/show_bug.cgi?id=38266 * src/js/InspectorControllerImpl.js: (.devtools.InspectorBackendImpl.prototype.setBreakpoint): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58413 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
pfeldman@chromium.org authored
Reviewed by Timothy Hatcher. Web Inspector: Linkify node and function in the event listeners panel. https://bugs.webkit.org/show_bug.cgi?id=38251 * bindings/js/ScriptEventListener.cpp: (WebCore::eventListenerHandlerBody): (WebCore::eventListenerHandlerLocation): * bindings/js/ScriptEventListener.h: * bindings/v8/ScriptEventListener.cpp: (WebCore::eventListenerHandlerBody): (WebCore::eventListenerHandlerLocation): * bindings/v8/ScriptEventListener.h: * inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::buildObjectForEventListener): * inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype.linkifyNodeReference): (WebInspector.ElementsPanel.prototype.linkifyNodeReference.preventDefault): * inspector/front-end/EventListenersSidebarPane.js: (WebInspector.EventListenersSidebarPane.prototype.update.callback): (WebInspector.EventListenersSidebarPane.prototype.update): (): * inspector/front-end/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.prototype._rebuildSectionsForStyleRules): * inspector/front-end/inspector.css: (.node-link): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58412 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
darin@apple.com authored
* Scripts/webkitpy/style: Modified property svn:ignore. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58411 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
darin@apple.com authored
argument checking. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58410 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
jchaffraix@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=37781 <rdar://problem/7905150> Reviewed by Alexey Proskuryakov. WebCore: Tests: http/tests/xmlhttprequest/access-control-preflight-credential-async.html http/tests/xmlhttprequest/access-control-preflight-credential-sync.html Rolling the patch in as I could not reproduce Qt results locally. * loader/DocumentThreadableLoader.cpp: (WebCore::DocumentThreadableLoader::DocumentThreadableLoader): Now we remove the credential from the request here to avoid forgetting to do so in the different code path. (WebCore::DocumentThreadableLoader::makeSimpleCrossOriginAccessRequest): Just add the "Origin" header. (WebCore::DocumentThreadableLoader::loadRequest): Check here the the credential have been removed so that we don't leak them. Also tweaked a comment to make it clear that the URL check has issue when credential is involved. LayoutTests: Test that doing a cross-origin request with a preflight check does not raise a NETWORK_ERR exception and does not send the credentials. * http/tests/xmlhttprequest/access-control-preflight-credential-async-expected.txt: Added. * http/tests/xmlhttprequest/access-control-preflight-credential-async.html: Added. * http/tests/xmlhttprequest/access-control-preflight-credential-sync-expected.txt: Added. * http/tests/xmlhttprequest/access-control-preflight-credential-sync.html: Added. * http/tests/xmlhttprequest/resources/basic-auth/access-control-auth-basic.php: Added. * platform/mac-tiger/Skipped: * platform/qt/Skipped: Added those 2 tests to the Skipped lists. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58409 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
eric@webkit.org authored
Reviewed by Kenneth Rohde Christiansen. [Qt] GraphicsLayer: preserves-3d and backface visibility https://bugs.webkit.org/show_bug.cgi?id=35312 Implement preserves-3d by maintaining the 3D transformation heirarchy inside GraphicsLayerQt, and extrapolating the relative QTransform. When the extrapolation fails (un-invertible matrix) we ignore the transformation change. WebKitSite/blog-files/3d-transforms test now work with Qt. * platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::GraphicsLayerQtImpl::updateTransform): (WebCore::GraphicsLayerQtImpl::opaqueArea): (WebCore::GraphicsLayerQtImpl::boundingRect): (WebCore::GraphicsLayerQtImpl::paint): (WebCore::GraphicsLayerQtImpl::flushChanges): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58408 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
eric@webkit.org authored
Reviewed by Jeremy Orlow. [chromium] Rebaseline svg-background-partial-redraw, node-iterator-prototype, and upstream test expectations for fast/text/international/bold-bengali.html https://bugs.webkit.org/show_bug.cgi?id=38259 * platform/chromium-linux/fast/images/svg-background-partial-redraw-expected.checksum: Added. * platform/chromium-linux/fast/images/svg-background-partial-redraw-expected.png: Added. * platform/chromium-mac/fast/images: Added. * platform/chromium-mac/fast/images/svg-background-partial-redraw-expected.checksum: Added. * platform/chromium-mac/fast/images/svg-background-partial-redraw-expected.png: Added. * platform/chromium-mac/traversal: Added. * platform/chromium-mac/traversal/node-iterator-prototype-expected.txt: Added. * platform/chromium-win/fast/images/svg-background-partial-redraw-expected.checksum: Added. * platform/chromium-win/fast/images/svg-background-partial-redraw-expected.png: Added. * platform/chromium-win/fast/images/svg-background-partial-redraw-expected.txt: Added. * platform/chromium-win/traversal: Added. * platform/chromium-win/traversal/node-iterator-prototype-expected.txt: Added. * platform/chromium/test_expectations.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58407 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
eric@webkit.org authored
Reviewed by Yury Semikhatsky. Web Inspector: View frame selector for Timeline overview panel is redesigned a bit. Now it is possible to adjust view frame by resizer bars and by click-n-drag in overview pane. https://bugs.webkit.org/show_bug.cgi?id=38251 * inspector/front-end/TimelineOverviewPane.js: (WebInspector.TimelineOverviewPane): (WebInspector.TimelineOverviewPane.prototype.reset): (WebInspector.TimelineOverviewPane.prototype._dragWindow): (WebInspector.TimelineOverviewPane.prototype._windowSelectorDragging): (WebInspector.TimelineOverviewPane.prototype._endWindowSelectorDragging): (WebInspector.TimelineOverviewPane.prototype._resizeWindowLeft): (WebInspector.TimelineOverviewPane.prototype._resizeWindowRight): (WebInspector.TimelineOverviewPane.prototype._setWindowPosition): (WebInspector.TimelinePanel.WindowSelector): (WebInspector.TimelinePanel.WindowSelector.prototype._createSelectorElement): (WebInspector.TimelinePanel.WindowSelector.prototype._close): (WebInspector.TimelinePanel.WindowSelector.prototype._updatePosition): * inspector/front-end/inspector.css: (#timeline-overview-grid): (.timeline-window-selector): (#timeline-overview-window): (.timeline-overview-dividers-background): (.timeline-overview-window-rulers): (.timeline-window-resizer): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58406 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
eric@webkit.org authored
Reviewed by Kenneth Rohde Christiansen. [Qt] QWebPage viewMode property https://bugs.webkit.org/show_bug.cgi?id=38119 Replacing method qt_wrt_setViewMode by wrt_viewMode property. * Api/qwebpage.cpp: (QWebPagePrivate::dynamicPropertyChangeEvent): (QWebPage::event): * Api/qwebpage_p.h: * tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::wrt_viewModes): 2010-04-28 Luiz Agostini <luiz.agostini@openbossa.org> Reviewed by Kenneth Rohde Christiansen. [Qt] QWebPage viewMode property https://bugs.webkit.org/show_bug.cgi?id=38119 Replacing method qt_wrt_setViewMode by wrt_viewMode property. * DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::setViewModeMediaFeature): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58405 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
eric@webkit.org authored
Reviewed by Jeremy Orlow. Reverts 58340 (https://bugs.webkit.org/show_bug.cgi?id=38158) due to regression on fast/text/international/khmer-selection.html https://bugs.webkit.org/show_bug.cgi?id=38254 * platform/graphics/chromium/FontLinux.cpp: (WebCore::adjustTextRenderMode): (WebCore::TextRunWalker::getTextRun): (WebCore::TextRunWalker::getNormalizedTextRun): (WebCore::TextRunWalker::setGlyphXPositions): (WebCore::glyphIndexForXPositionInScriptRun): (WebCore::Font::offsetForPositionForComplexText): (WebCore::Font::selectionRectForComplexText): * platform/graphics/chromium/FontPlatformDataLinux.cpp: (WebCore::FontPlatformData::setupPaint): * platform/graphics/chromium/HarfbuzzSkia.cpp: (WebCore::getOutlinePoint): * platform/graphics/skia/GraphicsContext3DSkia.cpp: (WebCore::GraphicsContext3D::getImageData): * platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::isCoordinateSkiaSafe): (WebCore::GraphicsContext::fillRect): (WebCore::GraphicsContext::strokePath): (WebCore::GraphicsContext::strokeRect): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58404 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
eric@webkit.org authored
Reviewed by Yury Semikhatsky. Log error message to inspector console if a resource fails to load. Moved console-tests.js to http tests. Added support for sorting console messages, in case order may vary. https://bugs.webkit.org/show_bug.cgi?id=37215 * http/tests/inspector/console-resource-errors-expected.txt: Added. * http/tests/inspector/console-resource-errors.html: Added. * http/tests/inspector/console-tests.js: Added. (dumpConsoleMessages.callback): (dumpConsoleMessages): (dumpConsoleMessagesWithClasses.callback): (dumpConsoleMessagesWithClasses): (frontend_dumpConsoleMessages): * inspector/console-clear.html: * inspector/console-dir.html: * inspector/console-dirxml.html: * inspector/console-format-collections-expected.txt: * inspector/console-format-collections.html: * inspector/console-format.html: * inspector/console-log-before-inspector-open.html: * inspector/console-tests.html: * inspector/console-tests.js: Removed. * platform/mac-tiger/http/tests/inspector: Added. * platform/mac-tiger/http/tests/inspector/console-resource-errors-expected.txt: Added. 2010-04-28 Andrey Kosyakov <caseq@chromium.org> Reviewed by Yury Semikhatsky. Log error message to inspector console if a resource fails to load. Disable checking of mime-type consistency for failed resources. https://bugs.webkit.org/show_bug.cgi?id=37215 Test: http/tests/inspector/console-resource-errors.html * inspector/InspectorController.cpp: (WebCore::InspectorController::didReceiveResponse): (WebCore::InspectorController::didFailLoading): * inspector/front-end/Resource.js: (WebInspector.Resource.prototype._mimeTypeIsConsistentWithType): * inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.recreateViewForResourceIfNeeded): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58403 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
eric@webkit.org authored
Reviewed by Pavel Feldman. Support pause on exceptions in v8 implementation of ScriptDebugServer. https://bugs.webkit.org/show_bug.cgi?id=38205 * bindings/v8/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::addListener): (WebCore::ScriptDebugServer::pauseOnExceptionsState): (WebCore::ScriptDebugServer::setPauseOnExceptionsState): (WebCore::ScriptDebugServer::currentCallFrame): (WebCore::ScriptDebugServer::handleV8DebugMessage): (WebCore::ScriptDebugServer::dispatchDidParseSource): * bindings/v8/ScriptDebugServer.h: 2010-04-28 Yury Semikhatsky <yurys@chromium.org> Reviewed by Pavel Feldman. Support pause on exceptions in v8 implementation of ScriptDebugServer. https://bugs.webkit.org/show_bug.cgi?id=38205 * src/js/DebuggerScript.js: (debuggerScriptConstructor.DebuggerScript.getScripts): (debuggerScriptConstructor.DebuggerScript.pauseOnExceptionsState): (debuggerScriptConstructor.DebuggerScript.setPauseOnExceptionsState): (debuggerScriptConstructor.DebuggerScript._v8ToWebkitLineNumber): (debuggerScriptConstructor): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58402 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
eric@webkit.org authored
Reviewed by Shinichiro Hamaji. Adjusted check-webkit-style so that files with file type NONE are automatically skipped without warning. https://bugs.webkit.org/show_bug.cgi?id=38197 This change simplifies configuring which files to skip. It also addresses an issue whereby check-webkit-style was unintentionally checking .vcproj files for carriage returns. * Scripts/webkitpy/style/checker.py: - Moved the C++, Python, and text file extensions to new module-level configuration variables. - Removed .pyc from the _SKIPPED_FILES_WITHOUT_WARNING configuration variable. - Changed the numeric values of the FileType enum so that FileType.NONE evaluates to False. - For ProcessorDispatcher.should_skip_without_warning(): - Changed the method to return True for FileType.NONE files. - Made ChangeLog files an exception to getting skipped. - Changed the StyleProcessor.process() method to raise an exception if given a file path that should not be processed. * Scripts/webkitpy/style/checker_unittest.py: - Updated the unit tests and added more test cases as necessary. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58401 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
jorlow@chromium.org authored
Unreviewed, rolling out r58313. http://trac.webkit.org/changeset/58313 https://bugs.webkit.org/show_bug.cgi?id=38253 Regression evident in pixel tests: the search icon is always clipped at the bottom. (Requested by jorlow on #webkit). * rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::controlClipRect): * rendering/RenderTextControl.h: (WebCore::RenderTextControl::hasControlClip): * rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::paint): * rendering/RenderTextControlSingleLine.h: 2010-04-28 Sheriff Bot <webkit.review.bot@gmail.com> Unreviewed, rolling out r58313. http://trac.webkit.org/changeset/58313 https://bugs.webkit.org/show_bug.cgi?id=38253 Regression evident in pixel tests: the search icon is always clipped at the bottom. (Requested by jorlow on #webkit). * fast/css/input-search-padding.html: Removed. * platform/mac/fast/css/input-search-padding-expected.checksum: Removed. * platform/mac/fast/css/input-search-padding-expected.png: Removed. * platform/mac/fast/css/input-search-padding-expected.txt: Removed. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58400 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
hausmann@webkit.org authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58399 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
hamaji@chromium.org authored
Unreviewed. Disable printing/media-queries-print for now. Add layoutTestController.setPrinting() https://bugs.webkit.org/show_bug.cgi?id=37203 * platform/mac/Skipped: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58398 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ukai@chromium.org authored
Reviewed by Jeremy Orlow. webkitpy: ScriptError('Failed to run "[u\'taskkill.exe\', u\'/f\', u\'/im\', u\'httpd.exe\']" exit_code: 128',) https://bugs.webkit.org/show_bug.cgi?id=38248 The previous code did not check the return code of taskkill. When I moved that callsite from using subprocess.call to Executive.run_command having a non-zero return code became an error. In this change I've centralized our killall handling in executive, and added tests for it to make sure it works. Currently kill_process and kill_all swallow exceptions in the cases where the process(es) to be killed do(es) not exist. * Scripts/webkitpy/common/system/executive.py: * Scripts/webkitpy/common/system/executive_unittest.py: * Scripts/webkitpy/layout_tests/port/chromium_linux.py: * Scripts/webkitpy/layout_tests/port/chromium_mac.py: * Scripts/webkitpy/layout_tests/port/chromium_win.py: * Scripts/webkitpy/layout_tests/port/gtk.py: * Scripts/webkitpy/layout_tests/port/mac.py: * Scripts/webkitpy/layout_tests/port/qt.py: * Scripts/webkitpy/layout_tests/port/win.py: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58397 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
hamaji@chromium.org authored
Unreviewed. Added missing expectation files missed in r58386. Add layoutTestController.setPrinting() https://bugs.webkit.org/show_bug.cgi?id=37203 * platform/mac/printing/media-queries-print-expected.checksum: Added. * platform/mac/printing/media-queries-print-expected.png: Added. * platform/mac/printing/media-queries-print-expected.txt: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58396 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
eric@webkit.org authored
Reviewed by Shinichiro Hamaji. wdiff_text throws ScriptError because wdiff returns non-zero when files differ https://bugs.webkit.org/show_bug.cgi?id=38246 wdiff returns 0 when files are the same, 1 when they differ. run_command by default raises ScriptError if the return code is non-zero. Fixed this by adding a custom error handler which only raises if the return code is not 1. I broke up the huge wdiff_text() method into little pieces for easier unit testing. There is only one functional change here and that is the addition of the custom error handler. * Scripts/webkitpy/layout_tests/port/base.py: * Scripts/webkitpy/layout_tests/port/base_unittest.py: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58395 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ukai@chromium.org authored
* DumpRenderTree/chromium/TestShell.cpp: (TestShell::dumpImage): format '%u' expects type 'unsigned int', but argument 2 has type 'size_t'. * DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::willSendRequest): too few arguments for format. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58394 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
hausmann@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=37195 Patch by Simon Hausmann <simon.hausmann@nokia.com>, Kent Hansen <kent.hansen@nokia.com> on 2010-04-28 Reviewed by Darin Adler. This function needs to be reentrant to avoid memory corruption on platforms where the implementation uses global variables. This patch adds a mutex lock where necessary and makes the Symbian implementation reentrant. * runtime/Collector.cpp: (JSC::currentThreadStackBaseMutex): (JSC::currentThreadStackBase): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58393 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
hausmann@webkit.org authored
Patch by Thiago Macieira <thiago.macieira@nokia.com> on 2010-04-28 Reviewed by Simon Hausmann. AtomicStringImpl.h:29: error: base `WebCore::StringImpl' with only non-default constructor in class without a constructor * wtf/text/AtomicStringImpl.h: (WebCore::AtomicStringImpl::AtomicStringImpl): Provide a default constructor. * wtf/text/StringImpl.h: Allow AtomicStringImpl to call a StringImpl constructor through a friend declaration. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58392 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
hausmann@webkit.org authored
Patch by Janne Koskinen <janne.p.koskinen@digia.com> on 2010-04-28 Reviewed by Simon Hausmann <simon.hausmann@nokia.com> Updated WINSCW def file with added and removed symbols. * symbian/bwins/QtWebKitu.def: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58391 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
hausmann@webkit.org authored
Patch by Justin McPherson <justin.mcpherson@nokia.com> on 2010-04-28 Reviewed by Simon Hausmann. QtMultimedia has been split into an additional media services library, which we're using. mediaservices depends on multimedia. * WebCore.pro: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58390 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
hamaji@chromium.org authored
Unreviewed attempt to fix the chromium build. Add layoutTestController.setPrinting() https://bugs.webkit.org/show_bug.cgi?id=37203 * rendering/RenderTreeAsText.cpp: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58389 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
dbates@webkit.org authored
Unreviewed, rebase expected result of failing test. Rebasing Qt expected result for selection-gap-overflow-scroll-2.html. Following the landing of bug #37686, this test started failing despite being unrelated to this bug. From looking at the diff of the result, which shows a 1 pixel shift in widths, and based on Csaba Osztrogonac's comment, we have decided to rebase this result. * platform/qt/fast/repaint/selection-gap-overflow-scroll-2-expected.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58388 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
sfalken@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=38245 <rdar://problem/7916101> REGRESSION (r58067): All loaded pages fail to display after running iBench HTML test (intermittent) Reviewed by Maciej Stachowiak. * WebView.cpp: (WebView::updateBackingStore): Add null check for m_backingStoreDirtyRegion. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58387 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
hamaji@chromium.org authored
Reviewed by Darin Adler and Eric Seidel. Add layoutTestController.setPrinting() https://bugs.webkit.org/show_bug.cgi?id=37203 Now we can test media queries with the new function because the render tree has the color information of the box. Note that the pixel test is currently failing. We'll need another patch to enable printing mode for pixel tests. * platform/mac/Skipped: * platform/mac/printing/media-queries-print-expected.checksum: Added. * platform/mac/printing/media-queries-print-expected.png: Added. * platform/mac/printing/media-queries-print-expected.txt: Added. * printing/media-queries-print.html: 2010-04-27 Shinichiro Hamaji <hamaji@chromium.org> Reviewed by Darin Adler and Eric Seidel. Add layoutTestController.setPrinting() https://bugs.webkit.org/show_bug.cgi?id=37203 Added RenderAsTextPrintingMode as a behavior of externalRepresentation. Now ~PrintContext() calls end() automatically. * page/PrintContext.cpp: (WebCore::PrintContext::~PrintContext): * rendering/RenderTreeAsText.cpp: (WebCore::externalRepresentation): * rendering/RenderTreeAsText.h: (WebCore::): 2010-04-27 Shinichiro Hamaji <hamaji@chromium.org> Reviewed by Darin Adler and Eric Seidel. Add layoutTestController.setPrinting() https://bugs.webkit.org/show_bug.cgi?id=37203 * Misc/WebCoreStatistics.h: * Misc/WebCoreStatistics.mm: (-[WebFrame renderTreeAsExternalRepresentationForPrinting:]): 2010-04-27 Shinichiro Hamaji <hamaji@chromium.org> Reviewed by Darin Adler and Eric Seidel. Add layoutTestController.setPrinting() https://bugs.webkit.org/show_bug.cgi?id=37203 * DumpRenderTree/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (setPrintingCallback): (LayoutTestController::staticFunctions): * DumpRenderTree/LayoutTestController.h: (LayoutTestController::isPrinting): (LayoutTestController::setIsPrinting): * DumpRenderTree/mac/DumpRenderTree.mm: (dump): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58386 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
yuzo@google.com authored
Reviewed by Eric Seidel. Enhance CSS parser for Paged Media (Iteration 4) Implement page property parsing as specified at http://dev.w3.org/csswg/css3-page/#using-named-pages. https://bugs.webkit.org/show_bug.cgi?id=35853 * printing/page-rule-css-text-expected.txt: * printing/page-rule-css-text.html: 2010-04-27 Yuzo Fujishima <yuzo@google.com> Reviewed by Eric Seidel. Enhance CSS parser for Paged Media (Iteration 4) Implement page property parsing as specified at http://dev.w3.org/csswg/css3-page/#using-named-pages. https://bugs.webkit.org/show_bug.cgi?id=35853 * css/CSSParser.cpp: (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parsePage): * css/CSSParser.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58385 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
yuzo@google.com authored
Reviewed by Dimitri Glazkov. Enhance CSS parser for Paged Media (Iteration 3) Implement size parameter parsing for Paged Media. https://bugs.webkit.org/show_bug.cgi?id=35851 * printing/page-rule-css-text-expected.txt: * printing/page-rule-css-text.html: 2010-04-27 Yuzo Fujishima <yuzo@google.com> Reviewed by Dimitri Glazkov. Enhance CSS parser for Paged Media (Iteration 3) Implement size parameter parsing for Paged Media. https://bugs.webkit.org/show_bug.cgi?id=35851 I believe size property hasn't been used so far because (1) it hasn't been properly parsed and (2) a comment in CSSComputedStyleDeclaration::getPropertyCSSValue says so. Changing the way of parsing it should not cause any regressions -- no existing tests fail because of this change. * css/CSSParser.cpp: (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseSize): (WebCore::CSSParser::parseSizeParameter): * css/CSSParser.h: (WebCore::CSSParser::): * css/CSSValueKeywords.in: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58384 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
yuzo@google.com authored
Reviewed by Eric Seidel. Enhance CSS parser for Paged Media (Iteration 2) Parse and hold paged media rules in CSSStyleSelector. fast/dom/script-tests/prototype-inheritance-2.js is rebaselined because it assumes @page is ignored. https://bugs.webkit.org/show_bug.cgi?id=35782 * fast/dom/prototype-inheritance-2-expected.txt: * fast/dom/script-tests/prototype-inheritance-2.js: * printing/page-rule-css-text-expected.txt: Added. * printing/page-rule-css-text.html: Added. 2010-04-27 Yuzo Fujishima <yuzo@google.com> Reviewed by Eric Seidel. Enhance CSS parser for Paged Media (Iteration 2) Parse and hold paged media rules in CSSStyleSelector. https://bugs.webkit.org/show_bug.cgi?id=35782 Test: printing/page-rule-css-text.html * css/CSSGrammar.y: * css/CSSPageRule.cpp: (WebCore::CSSPageRule::CSSPageRule): (WebCore::CSSPageRule::selectorText): * css/CSSPageRule.h: (WebCore::CSSPageRule::create): (WebCore::CSSPageRule::isPageRule): * css/CSSParser.cpp: (WebCore::CSSParser::createPageRule): * css/CSSStyleRule.h: * css/CSSStyleSelector.cpp: (WebCore::CSSRuleSet::getPageRules): (WebCore::CSSRuleSet::CSSRuleSet): (WebCore::CSSRuleSet::~CSSRuleSet): (WebCore::CSSRuleSet::addPageRule): (WebCore::CSSRuleSet::addRulesFromSheet): * css/CSSStyleSelector.h: * css/StyleBase.h: (WebCore::StyleBase::isPageRule): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58383 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
eric@webkit.org authored
Reviewed by Eric Seidel. [chromium] Fix bug that prevents autosave of forms without action attribute https://bugs.webkit.org/show_bug.cgi?id=38014 Change is in the Chromium WebKit API so it can't be tested with a JS-based layout test. It needs a native unit test, which would go in the Chromium repo, not WebKit. * src/WebPasswordFormData.cpp: (WebKit::WebPasswordFormData::WebPasswordFormData): Set correct URL if action is NULL git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58382 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
- 27 Apr, 2010 5 commits
-
-
dbates@webkit.org authored
Reviewed by Oliver Hunt. https://bugs.webkit.org/show_bug.cgi?id=37686 Fixes an issue where the canvas method strokeRect will stroke a rectangle whose dimensions are 0 when lineWidth > 1. As per the definition of strokeRect in the HTML Canvas 2D Context spec. <http://www.w3.org/TR/2dcontext/#dom-context-2d-strokerect>, this method should have no effect when both the height and width are zero. Tests: fast/canvas/canvas-clearRect.html fast/canvas/canvas-fillRect.html * html/canvas/CanvasRenderingContext2D.cpp: (WebCore::validateRectForCanvas): Return false if height, width == 0. 2010-04-27 Daniel Bates <dbates@rim.com> Reviewed by Oliver Hunt. https://bugs.webkit.org/show_bug.cgi?id=37686 Tests that strokeRect does not paint any artifacts when the specified rectangle has height, width = 0 and lineWidth > 1. Also tests that clearRect, fillRect, and rect are ignored when height, width = 0. * fast/canvas/canvas-clearRect-expected.txt: Added. * fast/canvas/canvas-clearRect.html: Added. * fast/canvas/canvas-fillRect-expected.txt: Added. * fast/canvas/canvas-fillRect.html: Added. * fast/canvas/canvas-modify-emptyPath-expected.txt: * fast/canvas/canvas-strokeRect-expected.txt: Updated results. * fast/canvas/script-tests/canvas-clearRect.js: Added. * fast/canvas/script-tests/canvas-fillRect.js: Added. * fast/canvas/script-tests/canvas-modify-emptyPath.js: Added test case. * fast/canvas/script-tests/canvas-strokeRect.js: Ditto. Also, added debug statements so as to distinguish the results for each test. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58381 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
eric@webkit.org authored
Reviewed by Dmitry Titov. [Chromium] Add two things to the webkit API to support appcaches in workers. 1) WebURLRequest TargetTypes for worker and shared worker main resources. 2) Factory method on class WebCommonWorkerClient to createApplicationCacheHost() for the associated worker. https://bugs.webkit.org/show_bug.cgi?id=38147 * public/WebCommonWorkerClient.h: add the factory method * public/WebURLRequest.h: add the TargetTypes * src/WebWorkerBase.cpp: call the embedder's factory when needed (WebKit::WebWorkerBase::didCreateDataSource) (WebKit::WebWorkerBase::createApplicationCacheHost) * src/WebWorkerBase.h: ditto * src/WebWorkerClientImpl.h: add a stub impl of the factory method (WebKit::WebWorkerClientImpl::createApplicationCacheHost): 2010-04-27 Michael Nordman <michaeln@google.com> Reviewed by Dmitry Titov. [Chromium] Add two things to the webkit API to support appcaches in workers. 1) WebURLRequest TargetTypes for worker and shared worker main resources. 2) Factory method on class WebCommonWorkerClient to createApplicationCacheHost() for the associated worker. https://bugs.webkit.org/show_bug.cgi?id=38147 * DumpRenderTree/chromium/TestWebWorker.h add a stub impl of the factory method (TestWebWorker::createApplicationCacheHost): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58380 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
eric@webkit.org authored
Reviewed by Eric Seidel. Remove obsolete custom bindings file https://bugs.webkit.org/show_bug.cgi?id=38223 We don't need these files anymore because they are empty. * Android.jscbindings.mk: * GNUmakefile.am: * WebCore.pro: * WebCore.vcproj/WebCore.vcproj: * WebCore.xcodeproj/project.pbxproj: * bindings/js/JSAbstractWorkerCustom.cpp: Removed. * bindings/js/JSBindingsAllInOne.cpp: * bindings/js/JSDocumentFragmentCustom.cpp: Removed. * bindings/js/JSEventSourceCustom.cpp: Removed. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58379 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
eric@webkit.org authored
Reviewed by Jian Li. [Chromium] Filter out URLs with a file scheme from text/uri-list when dragging. https://bugs.webkit.org/show_bug.cgi?id=38227 Unfortunately, the simple fix of not populating the drag data with file URLs doesn't work since the default drop handling uses the drag data URL to navigate to dropped files/URLs. For now, we hack around the problem in the Chromium platform, but the proper long term solution is to change DragController::performDrag to check dragData::asFilenames(). No new tests. * platform/chromium/ClipboardChromium.cpp: (WebCore::ClipboardChromium::getData): (WebCore::ClipboardChromium::types): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58378 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
tkent@chromium.org authored
Reviewed by Shinichiro Hamaji. [DRT/Chromium] Enable Windows project generation https://bugs.webkit.org/show_bug.cgi?id=38103 - Avoid platform.system(), which causes a crash with python.exe in depot_tools. Use sys.platform instead. - Process DumpRenderTree.gyp on all platforms. * gyp_webkit: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58377 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-