1. 16 Apr, 2011 9 commits
    • commit-queue@webkit.org's avatar
      2011-04-16 Leo Yang <leoyang.webkit@gmail.com> · 89223918
      commit-queue@webkit.org authored
              Reviewed by Nikolas Zimmermann.
      
              ASSERT failure when svg <use> element changes href
              https://bugs.webkit.org/show_bug.cgi?id=58726
      
              Test case to verify assertion at line 509 of SVGUseElement.cpp.
              Test passes if no crash occurs in debug mode.
      
              * svg/custom/use-crash-when-href-change-expected.txt: Added.
              * svg/custom/use-crash-when-href-change.svg: Added.
      2011-04-16  Leo Yang  <leoyang.webkit@gmail.com>
      
              Reviewed by Nikolas Zimmermann.
      
              ASSERT failure when svg <use> element changes href
              https://bugs.webkit.org/show_bug.cgi?id=58726
      
              m_resourceId was not empty after the pending resource
              becomes available. This will trigger the assertion at
              line 509 of SVGUseElement.cpp when the <use> element's
              href becomes empty or invalid.
      
              This patch makes m_resourceId be empty after the pending
              resource becomes available to avoid assertion failure.
      
              Test: svg/custom/use-crash-when-href-change.svg
      
              * svg/SVGUseElement.cpp:
              (WebCore::SVGUseElement::buildPendingResource):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84090 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      89223918
    • paroga@webkit.org's avatar
      2011-04-16 Patrick Gansterer <paroga@webkit.org> · 21e42cf8
      paroga@webkit.org authored
              Reviewed by Eric Seidel.
      
              Rename PLATFORM(CAIRO) to USE(CAIRO)
              https://bugs.webkit.org/show_bug.cgi?id=55192
      
              * Source/cmake/OptionsEfl.cmake:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84089 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      21e42cf8
    • paroga@webkit.org's avatar
      2011-04-16 Patrick Gansterer <paroga@webkit.org> · 411b4767
      paroga@webkit.org authored
              Reviewed by Eric Seidel.
      
              Rename PLATFORM(CAIRO) to USE(CAIRO)
              https://bugs.webkit.org/show_bug.cgi?id=55192
      
              * wtf/Platform.h:
              * wtf/gobject/GTypedefs.h:
      2011-04-16  Patrick Gansterer  <paroga@webkit.org>
      
              Reviewed by Eric Seidel.
      
              Rename PLATFORM(CAIRO) to USE(CAIRO)
              https://bugs.webkit.org/show_bug.cgi?id=55192
      
              * CMakeListsEfl.txt:
              * config.h:
              * platform/MIMETypeRegistry.cpp:
              (WebCore::initializeSupportedImageMIMETypesForEncoding):
              * platform/graphics/ContextShadow.h:
              * platform/graphics/DashArray.h:
              * platform/graphics/FloatRect.h:
              * platform/graphics/FontPlatformData.h:
              (WebCore::FontPlatformData::FontPlatformData):
              (WebCore::FontPlatformData::hash):
              (WebCore::FontPlatformData::isHashTableDeletedValue):
              * platform/graphics/GlyphBuffer.h:
              (WebCore::GlyphBuffer::glyphAt):
              (WebCore::GlyphBuffer::add):
              * platform/graphics/Gradient.cpp:
              * platform/graphics/Gradient.h:
              * platform/graphics/GraphicsContext.cpp:
              * platform/graphics/GraphicsContext.h:
              (WebCore::GraphicsContextState::GraphicsContextState):
              * platform/graphics/GraphicsContext3D.h:
              * platform/graphics/ImageBufferData.h:
              * platform/graphics/ImageSource.h:
              * platform/graphics/Path.h:
              * platform/graphics/Pattern.h:
              * platform/graphics/SimpleFontData.h:
              * platform/graphics/cairo/DrawErrorUnderline.h:
              * platform/graphics/cairo/GraphicsContextCairo.cpp:
              * platform/graphics/cairo/ImageCairo.cpp:
              * platform/graphics/gstreamer/ImageGStreamer.h:
              * platform/graphics/transforms/AffineTransform.h:
              * platform/graphics/transforms/TransformationMatrix.h:
              * platform/graphics/win/FontCacheWin.cpp:
              (WebCore::createGDIFont):
              (WebCore::FontCache::createFontPlatformData):
              * platform/graphics/win/FontPlatformDataWin.cpp:
              (WebCore::FontPlatformData::FontPlatformData):
              * platform/graphics/win/GraphicsContextWin.cpp:
              * plugins/win/PluginViewWin.cpp:
              (WebCore::PluginView::paintWindowedPluginIntoContext):
              * rendering/RenderObject.h:
      2011-04-16  Patrick Gansterer  <paroga@webkit.org>
      
              Reviewed by Eric Seidel.
      
              Rename PLATFORM(CAIRO) to USE(CAIRO)
              https://bugs.webkit.org/show_bug.cgi?id=55192
      
              * WebFrame.cpp:
              (WebFrame::spoolPages):
              * WebFrame.h:
      2011-04-16  Patrick Gansterer  <paroga@webkit.org>
      
              Reviewed by Eric Seidel.
      
              Rename PLATFORM(CAIRO) to USE(CAIRO)
              https://bugs.webkit.org/show_bug.cgi?id=55192
      
              * DumpRenderTree/PixelDumpSupport.cpp:
              * DumpRenderTree/config.h:
              * DumpRenderTree/win/PixelDumpSupportWin.cpp:
              (createBitmapContextFromWebView):
              * WebKitTestRunner/config.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84088 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      411b4767
    • paroga@webkit.org's avatar
      2011-04-16 Patrick Gansterer <paroga@webkit.org> · 545d83aa
      paroga@webkit.org authored
              Unreviewed WinCE build fix for r84033.
      
              * platform/win/LocalizedStringsWin.cpp:
              (WebCore::localizedString):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84087 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      545d83aa
    • ojan@chromium.org's avatar
      2011-04-16 Ojan Vafai <ojan@chromium.org> · dcaa6570
      ojan@chromium.org authored
              Reviewed by Eric Seidel.
      
              show diffs+test inline in the results page
              https://bugs.webkit.org/show_bug.cgi?id=58723
      
              Put each row in it's own tbody and sort based on tbodies. That way
              we can append the results to the tbody inline as another table row.
      
              * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84086 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dcaa6570
    • inferno@chromium.org's avatar
      2011-04-16 Abhishek Arya <inferno@chromium.org> · 4e46b00c
      inferno@chromium.org authored
              Reviewed by Nikolas Zimmermann.
      
              Tests that we do not crash when adding a list item block child
              as a before child to svg text.
              https://bugs.webkit.org/show_bug.cgi?id=58678
      
              * svg/text/text-block-child-crash-expected.txt: Added.
              * svg/text/text-block-child-crash.xhtml: Added.
      2011-04-16  Abhishek Arya  <inferno@chromium.org>
      
              Reviewed by Nikolas Zimmermann.
      
              Only allow inline child for SVG text since we cannot
              handle block childs.
              https://bugs.webkit.org/show_bug.cgi?id=58678
      
              Test: svg/text/text-block-child-crash.xhtml
      
              * rendering/svg/RenderSVGText.cpp:
              (WebCore::RenderSVGText::isChildAllowed):
              * rendering/svg/RenderSVGText.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84085 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4e46b00c
    • sergio@webkit.org's avatar
      2011-04-16 Sergio Villar Senin <svillar@igalia.com> · cc67b42e
      sergio@webkit.org authored
              Unreviewed, new GTK+ test expectations after r84039.
      
              * platform/gtk/fast/html/details-add-summary-1-and-click-expected.txt:
              * platform/gtk/fast/html/details-add-summary-1-expected.txt:
              * platform/gtk/fast/html/details-add-summary-10-and-click-expected.txt:
              * platform/gtk/fast/html/details-add-summary-10-expected.txt:
              * platform/gtk/fast/html/details-add-summary-2-and-click-expected.txt:
              * platform/gtk/fast/html/details-add-summary-2-expected.txt:
              * platform/gtk/fast/html/details-add-summary-3-and-click-expected.txt:
              * platform/gtk/fast/html/details-add-summary-3-expected.txt:
              * platform/gtk/fast/html/details-add-summary-4-and-click-expected.txt:
              * platform/gtk/fast/html/details-add-summary-4-expected.txt:
              * platform/gtk/fast/html/details-add-summary-5-and-click-expected.txt:
              * platform/gtk/fast/html/details-add-summary-5-expected.txt:
              * platform/gtk/fast/html/details-add-summary-6-and-click-expected.txt:
              * platform/gtk/fast/html/details-add-summary-6-expected.txt:
              * platform/gtk/fast/html/details-add-summary-7-and-click-expected.txt:
              * platform/gtk/fast/html/details-add-summary-7-expected.txt:
              * platform/gtk/fast/html/details-add-summary-8-and-click-expected.txt:
              * platform/gtk/fast/html/details-add-summary-8-expected.txt:
              * platform/gtk/fast/html/details-add-summary-9-and-click-expected.txt:
              * platform/gtk/fast/html/details-add-summary-9-expected.txt:
              * platform/gtk/fast/html/details-no-summary1-expected.txt:
              * platform/gtk/fast/html/details-no-summary2-expected.txt:
              * platform/gtk/fast/html/details-no-summary3-expected.txt:
              * platform/gtk/fast/html/details-no-summary4-expected.txt:
              * platform/gtk/fast/html/details-open-javascript-expected.txt:
              * platform/gtk/fast/html/details-open1-expected.txt:
              * platform/gtk/fast/html/details-open2-expected.txt:
              * platform/gtk/fast/html/details-open3-expected.txt:
              * platform/gtk/fast/html/details-open4-expected.txt:
              * platform/gtk/fast/html/details-open5-expected.txt:
              * platform/gtk/fast/html/details-open6-expected.txt:
              * platform/gtk/fast/html/details-position-expected.txt:
              * platform/gtk/fast/html/details-remove-summary-1-and-click-expected.txt:
              * platform/gtk/fast/html/details-remove-summary-1-expected.txt:
              * platform/gtk/fast/html/details-remove-summary-2-and-click-expected.txt:
              * platform/gtk/fast/html/details-remove-summary-2-expected.txt:
              * platform/gtk/fast/html/details-remove-summary-3-and-click-expected.txt:
              * platform/gtk/fast/html/details-remove-summary-3-expected.txt:
              * platform/gtk/fast/html/details-remove-summary-4-and-click-expected.txt:
              * platform/gtk/fast/html/details-remove-summary-4-expected.txt:
              * platform/gtk/fast/html/details-remove-summary-5-and-click-expected.txt:
              * platform/gtk/fast/html/details-remove-summary-5-expected.txt:
              * platform/gtk/fast/html/details-remove-summary-6-and-click-expected.txt:
              * platform/gtk/fast/html/details-remove-summary-6-expected.txt:
              * platform/gtk/fast/html/details-writing-mode-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84084 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cc67b42e
    • ojan@chromium.org's avatar
      2011-04-16 Ojan Vafai <ojan@chromium.org> · 19903a38
      ojan@chromium.org authored
              Reviewed by Eric Seidel.
      
              handle new tests in the new results html file
              https://bugs.webkit.org/show_bug.cgi?id=58715
      
              * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84083 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      19903a38
    • dbates@webkit.org's avatar
      2011-04-15 Daniel Bates <dbates@webkit.org> · b9d245fd
      dbates@webkit.org authored
              Attempt to fix the Qt Linux Release build after changeset 84064 <http://trac.webkit.org/changeset/84064>
              (https://bugs.webkit.org/show_bug.cgi?id=58686).
      
              * UIProcess/API/qt/qwkpage_p.h: Remove takeFocus().
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84082 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b9d245fd
  2. 15 Apr, 2011 31 commits