1. 16 Apr, 2011 36 commits
    • commit-queue@webkit.org's avatar
      2011-04-16 Leo Yang <leoyang.webkit@gmail.com> · 89223918
      commit-queue@webkit.org authored
              Reviewed by Nikolas Zimmermann.
      
              ASSERT failure when svg <use> element changes href
              https://bugs.webkit.org/show_bug.cgi?id=58726
      
              Test case to verify assertion at line 509 of SVGUseElement.cpp.
              Test passes if no crash occurs in debug mode.
      
              * svg/custom/use-crash-when-href-change-expected.txt: Added.
              * svg/custom/use-crash-when-href-change.svg: Added.
      2011-04-16  Leo Yang  <leoyang.webkit@gmail.com>
      
              Reviewed by Nikolas Zimmermann.
      
              ASSERT failure when svg <use> element changes href
              https://bugs.webkit.org/show_bug.cgi?id=58726
      
              m_resourceId was not empty after the pending resource
              becomes available. This will trigger the assertion at
              line 509 of SVGUseElement.cpp when the <use> element's
              href becomes empty or invalid.
      
              This patch makes m_resourceId be empty after the pending
              resource becomes available to avoid assertion failure.
      
              Test: svg/custom/use-crash-when-href-change.svg
      
              * svg/SVGUseElement.cpp:
              (WebCore::SVGUseElement::buildPendingResource):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84090 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      89223918
    • paroga@webkit.org's avatar
      2011-04-16 Patrick Gansterer <paroga@webkit.org> · 21e42cf8
      paroga@webkit.org authored
              Reviewed by Eric Seidel.
      
              Rename PLATFORM(CAIRO) to USE(CAIRO)
              https://bugs.webkit.org/show_bug.cgi?id=55192
      
              * Source/cmake/OptionsEfl.cmake:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84089 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      21e42cf8
    • paroga@webkit.org's avatar
      2011-04-16 Patrick Gansterer <paroga@webkit.org> · 411b4767
      paroga@webkit.org authored
              Reviewed by Eric Seidel.
      
              Rename PLATFORM(CAIRO) to USE(CAIRO)
              https://bugs.webkit.org/show_bug.cgi?id=55192
      
              * wtf/Platform.h:
              * wtf/gobject/GTypedefs.h:
      2011-04-16  Patrick Gansterer  <paroga@webkit.org>
      
              Reviewed by Eric Seidel.
      
              Rename PLATFORM(CAIRO) to USE(CAIRO)
              https://bugs.webkit.org/show_bug.cgi?id=55192
      
              * CMakeListsEfl.txt:
              * config.h:
              * platform/MIMETypeRegistry.cpp:
              (WebCore::initializeSupportedImageMIMETypesForEncoding):
              * platform/graphics/ContextShadow.h:
              * platform/graphics/DashArray.h:
              * platform/graphics/FloatRect.h:
              * platform/graphics/FontPlatformData.h:
              (WebCore::FontPlatformData::FontPlatformData):
              (WebCore::FontPlatformData::hash):
              (WebCore::FontPlatformData::isHashTableDeletedValue):
              * platform/graphics/GlyphBuffer.h:
              (WebCore::GlyphBuffer::glyphAt):
              (WebCore::GlyphBuffer::add):
              * platform/graphics/Gradient.cpp:
              * platform/graphics/Gradient.h:
              * platform/graphics/GraphicsContext.cpp:
              * platform/graphics/GraphicsContext.h:
              (WebCore::GraphicsContextState::GraphicsContextState):
              * platform/graphics/GraphicsContext3D.h:
              * platform/graphics/ImageBufferData.h:
              * platform/graphics/ImageSource.h:
              * platform/graphics/Path.h:
              * platform/graphics/Pattern.h:
              * platform/graphics/SimpleFontData.h:
              * platform/graphics/cairo/DrawErrorUnderline.h:
              * platform/graphics/cairo/GraphicsContextCairo.cpp:
              * platform/graphics/cairo/ImageCairo.cpp:
              * platform/graphics/gstreamer/ImageGStreamer.h:
              * platform/graphics/transforms/AffineTransform.h:
              * platform/graphics/transforms/TransformationMatrix.h:
              * platform/graphics/win/FontCacheWin.cpp:
              (WebCore::createGDIFont):
              (WebCore::FontCache::createFontPlatformData):
              * platform/graphics/win/FontPlatformDataWin.cpp:
              (WebCore::FontPlatformData::FontPlatformData):
              * platform/graphics/win/GraphicsContextWin.cpp:
              * plugins/win/PluginViewWin.cpp:
              (WebCore::PluginView::paintWindowedPluginIntoContext):
              * rendering/RenderObject.h:
      2011-04-16  Patrick Gansterer  <paroga@webkit.org>
      
              Reviewed by Eric Seidel.
      
              Rename PLATFORM(CAIRO) to USE(CAIRO)
              https://bugs.webkit.org/show_bug.cgi?id=55192
      
              * WebFrame.cpp:
              (WebFrame::spoolPages):
              * WebFrame.h:
      2011-04-16  Patrick Gansterer  <paroga@webkit.org>
      
              Reviewed by Eric Seidel.
      
              Rename PLATFORM(CAIRO) to USE(CAIRO)
              https://bugs.webkit.org/show_bug.cgi?id=55192
      
              * DumpRenderTree/PixelDumpSupport.cpp:
              * DumpRenderTree/config.h:
              * DumpRenderTree/win/PixelDumpSupportWin.cpp:
              (createBitmapContextFromWebView):
              * WebKitTestRunner/config.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84088 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      411b4767
    • paroga@webkit.org's avatar
      2011-04-16 Patrick Gansterer <paroga@webkit.org> · 545d83aa
      paroga@webkit.org authored
              Unreviewed WinCE build fix for r84033.
      
              * platform/win/LocalizedStringsWin.cpp:
              (WebCore::localizedString):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84087 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      545d83aa
    • ojan@chromium.org's avatar
      2011-04-16 Ojan Vafai <ojan@chromium.org> · dcaa6570
      ojan@chromium.org authored
              Reviewed by Eric Seidel.
      
              show diffs+test inline in the results page
              https://bugs.webkit.org/show_bug.cgi?id=58723
      
              Put each row in it's own tbody and sort based on tbodies. That way
              we can append the results to the tbody inline as another table row.
      
              * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84086 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dcaa6570
    • inferno@chromium.org's avatar
      2011-04-16 Abhishek Arya <inferno@chromium.org> · 4e46b00c
      inferno@chromium.org authored
              Reviewed by Nikolas Zimmermann.
      
              Tests that we do not crash when adding a list item block child
              as a before child to svg text.
              https://bugs.webkit.org/show_bug.cgi?id=58678
      
              * svg/text/text-block-child-crash-expected.txt: Added.
              * svg/text/text-block-child-crash.xhtml: Added.
      2011-04-16  Abhishek Arya  <inferno@chromium.org>
      
              Reviewed by Nikolas Zimmermann.
      
              Only allow inline child for SVG text since we cannot
              handle block childs.
              https://bugs.webkit.org/show_bug.cgi?id=58678
      
              Test: svg/text/text-block-child-crash.xhtml
      
              * rendering/svg/RenderSVGText.cpp:
              (WebCore::RenderSVGText::isChildAllowed):
              * rendering/svg/RenderSVGText.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84085 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4e46b00c
    • sergio@webkit.org's avatar
      2011-04-16 Sergio Villar Senin <svillar@igalia.com> · cc67b42e
      sergio@webkit.org authored
              Unreviewed, new GTK+ test expectations after r84039.
      
              * platform/gtk/fast/html/details-add-summary-1-and-click-expected.txt:
              * platform/gtk/fast/html/details-add-summary-1-expected.txt:
              * platform/gtk/fast/html/details-add-summary-10-and-click-expected.txt:
              * platform/gtk/fast/html/details-add-summary-10-expected.txt:
              * platform/gtk/fast/html/details-add-summary-2-and-click-expected.txt:
              * platform/gtk/fast/html/details-add-summary-2-expected.txt:
              * platform/gtk/fast/html/details-add-summary-3-and-click-expected.txt:
              * platform/gtk/fast/html/details-add-summary-3-expected.txt:
              * platform/gtk/fast/html/details-add-summary-4-and-click-expected.txt:
              * platform/gtk/fast/html/details-add-summary-4-expected.txt:
              * platform/gtk/fast/html/details-add-summary-5-and-click-expected.txt:
              * platform/gtk/fast/html/details-add-summary-5-expected.txt:
              * platform/gtk/fast/html/details-add-summary-6-and-click-expected.txt:
              * platform/gtk/fast/html/details-add-summary-6-expected.txt:
              * platform/gtk/fast/html/details-add-summary-7-and-click-expected.txt:
              * platform/gtk/fast/html/details-add-summary-7-expected.txt:
              * platform/gtk/fast/html/details-add-summary-8-and-click-expected.txt:
              * platform/gtk/fast/html/details-add-summary-8-expected.txt:
              * platform/gtk/fast/html/details-add-summary-9-and-click-expected.txt:
              * platform/gtk/fast/html/details-add-summary-9-expected.txt:
              * platform/gtk/fast/html/details-no-summary1-expected.txt:
              * platform/gtk/fast/html/details-no-summary2-expected.txt:
              * platform/gtk/fast/html/details-no-summary3-expected.txt:
              * platform/gtk/fast/html/details-no-summary4-expected.txt:
              * platform/gtk/fast/html/details-open-javascript-expected.txt:
              * platform/gtk/fast/html/details-open1-expected.txt:
              * platform/gtk/fast/html/details-open2-expected.txt:
              * platform/gtk/fast/html/details-open3-expected.txt:
              * platform/gtk/fast/html/details-open4-expected.txt:
              * platform/gtk/fast/html/details-open5-expected.txt:
              * platform/gtk/fast/html/details-open6-expected.txt:
              * platform/gtk/fast/html/details-position-expected.txt:
              * platform/gtk/fast/html/details-remove-summary-1-and-click-expected.txt:
              * platform/gtk/fast/html/details-remove-summary-1-expected.txt:
              * platform/gtk/fast/html/details-remove-summary-2-and-click-expected.txt:
              * platform/gtk/fast/html/details-remove-summary-2-expected.txt:
              * platform/gtk/fast/html/details-remove-summary-3-and-click-expected.txt:
              * platform/gtk/fast/html/details-remove-summary-3-expected.txt:
              * platform/gtk/fast/html/details-remove-summary-4-and-click-expected.txt:
              * platform/gtk/fast/html/details-remove-summary-4-expected.txt:
              * platform/gtk/fast/html/details-remove-summary-5-and-click-expected.txt:
              * platform/gtk/fast/html/details-remove-summary-5-expected.txt:
              * platform/gtk/fast/html/details-remove-summary-6-and-click-expected.txt:
              * platform/gtk/fast/html/details-remove-summary-6-expected.txt:
              * platform/gtk/fast/html/details-writing-mode-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84084 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cc67b42e
    • ojan@chromium.org's avatar
      2011-04-16 Ojan Vafai <ojan@chromium.org> · 19903a38
      ojan@chromium.org authored
              Reviewed by Eric Seidel.
      
              handle new tests in the new results html file
              https://bugs.webkit.org/show_bug.cgi?id=58715
      
              * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84083 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      19903a38
    • dbates@webkit.org's avatar
      2011-04-15 Daniel Bates <dbates@webkit.org> · b9d245fd
      dbates@webkit.org authored
              Attempt to fix the Qt Linux Release build after changeset 84064 <http://trac.webkit.org/changeset/84064>
              (https://bugs.webkit.org/show_bug.cgi?id=58686).
      
              * UIProcess/API/qt/qwkpage_p.h: Remove takeFocus().
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84082 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b9d245fd
    • loislo@chromium.org's avatar
      2011-04-15 Sheriff Bot <webkit.review.bot@gmail.com> · 1164809b
      loislo@chromium.org authored
              Unreviewed, rolling out r84067.
              http://trac.webkit.org/changeset/84067
              https://bugs.webkit.org/show_bug.cgi?id=58724
      
              qt build are failing. (Requested by loislo2 on #webkit).
      
              * heap/MarkStack.h:
              (JSC::MarkStack::append):
              * runtime/JSValue.h:
              * runtime/WriteBarrier.h:
              (JSC::DeprecatedPtr::DeprecatedPtr):
              (JSC::DeprecatedPtr::get):
              (JSC::DeprecatedPtr::operator*):
              (JSC::DeprecatedPtr::operator->):
              (JSC::DeprecatedPtr::slot):
              (JSC::DeprecatedPtr::operator UnspecifiedBoolType*):
              (JSC::DeprecatedPtr::operator!):
              (JSC::operator==):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84081 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1164809b
    • loislo@chromium.org's avatar
      2011-04-15 Ilya Tikhonovsky <loislo@chromium.org> · 3fa6f060
      loislo@chromium.org authored
              Reviewed by Pavel Feldman.
      
              Web Inspector: The list of Database entries is empty if the page opens a database just before Web Inspector.
              https://bugs.webkit.org/show_bug.cgi?id=57833
      
              * http/tests/inspector-enabled/database-open.html:
      2011-04-15  Ilya Tikhonovsky  <loislo@chromium.org>
      
              Reviewed by Pavel Feldman.
      
              Web Inspector: The list of Database entries is empty if the page opens a database just before Web Inspector.
              https://bugs.webkit.org/show_bug.cgi?id=57833
      
              * inspector/Inspector.json:
              * inspector/InspectorDatabaseAgent.cpp:
              (WebCore::InspectorDatabaseAgent::didOpenDatabase):
              (WebCore::InspectorDatabaseAgent::InspectorDatabaseAgent):
              (WebCore::InspectorDatabaseAgent::setFrontend):
              (WebCore::InspectorDatabaseAgent::clearFrontend):
              (WebCore::InspectorDatabaseAgent::enable):
              (WebCore::InspectorDatabaseAgent::disable):
              (WebCore::InspectorDatabaseAgent::getDatabaseTableNames):
              (WebCore::InspectorDatabaseAgent::executeSQL):
              * inspector/InspectorDatabaseAgent.h:
              * inspector/front-end/inspector.js:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84080 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3fa6f060
    • commit-queue@webkit.org's avatar
      2011-04-15 John Bates <jbates@google.com> · f1c6e45f
      commit-queue@webkit.org authored
              Reviewed by Kenneth Russell.
      
              Change WebGraphicsContext3D virtuals to pure virtuals as intended
              https://bugs.webkit.org/show_bug.cgi?id=58479
      
              * public/WebGraphicsContext3D.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84079 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f1c6e45f
    • commit-queue@webkit.org's avatar
      2011-04-15 Jia Pu <jpu@apple.com> · 5a5bca3c
      commit-queue@webkit.org authored
              Reviewed by Dan Bernstein.
      
              [Mac] WebKit needs to convert the bounding box of autocorrected word to view coordinate.
              https://bugs.webkit.org/show_bug.cgi?id=58717
      
              Convert the bounding box from window coordinate to view coordinate, which is expected by NSCorrectionPanel.
      
              * WebCoreSupport/CorrectionPanel.mm:
              (CorrectionPanel::show):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84078 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5a5bca3c
    • abarth@webkit.org's avatar
      2011-04-15 Adam Barth <abarth@webkit.org> · e8802e98
      abarth@webkit.org authored
              Reviewed by Eric Seidel.
      
              CSP media-src is missing
              https://bugs.webkit.org/show_bug.cgi?id=58642
      
              These tests are adapted from the other media loading tests.
      
              * http/tests/security/contentSecurityPolicy/media-src-allowed-expected.txt: Added.
              * http/tests/security/contentSecurityPolicy/media-src-allowed.html: Added.
              * http/tests/security/contentSecurityPolicy/media-src-blocked-expected.txt: Added.
              * http/tests/security/contentSecurityPolicy/media-src-blocked.html: Added.
      2011-04-15  Adam Barth  <abarth@webkit.org>
      
              Reviewed by Eric Seidel.
      
              CSP media-src is missing
              https://bugs.webkit.org/show_bug.cgi?id=58642
      
              Yay HTMLMediaElement for having the exact hook we need!
      
              Tests: http/tests/security/contentSecurityPolicy/media-src-allowed.html
                     http/tests/security/contentSecurityPolicy/media-src-blocked.html
      
              * html/HTMLMediaElement.cpp:
              (WebCore::HTMLMediaElement::isSafeToLoadURL):
                  - Although it's tempting to add this branch to the previous
                    if-block, that results in the wrong error message being logged to
                    the console (covered by the "blocked" test).
              * page/ContentSecurityPolicy.cpp:
              (WebCore::ContentSecurityPolicy::allowMediaFromSource):
              (WebCore::ContentSecurityPolicy::addDirective):
              * page/ContentSecurityPolicy.h:
                  - These changes are routine.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84077 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e8802e98
    • dpranke@chromium.org's avatar
      2011-04-15 Dirk Pranke <dpranke@chromium.org> · bde85bd5
      dpranke@chromium.org authored
              Reviewed by Ojan Vafai.
      
              old-run-webkit-tests: save the list of tests actually run to a file
              https://bugs.webkit.org/show_bug.cgi?id=58692
      
              * Scripts/old-run-webkit-tests:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84076 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bde85bd5
    • dpranke@chromium.org's avatar
      2011-04-15 Dirk Pranke <dpranke@chromium.org> · 5082d3b0
      dpranke@chromium.org authored
              Reviewed by Ojan Vafai.
      
              fix MockFileSystem.abspath() on windows
              https://bugs.webkit.org/show_bug.cgi?id=58713
      
              The existing code was borked on Windows if a path was passed
              in using a drive letter (e.g., "d:\foo.txt"), and would go
              into an infinite recursive loop. While win paths shouldn't
              normally be passed into the mock filesystem, this just
              bulletproofs things a bit (note that "/foo.txt" is considered
              an absolute path on windows python as well.
      
              * Scripts/webkitpy/common/system/filesystem_mock.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84075 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5082d3b0
    • ojan@chromium.org's avatar
      2011-04-15 Ojan Vafai <ojan@chromium.org> · c8ba4c10
      ojan@chromium.org authored
              Reviewed by Eric Seidel.
      
              show stderr files and httpd log files
              https://bugs.webkit.org/show_bug.cgi?id=58714
      
              * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
              * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84074 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c8ba4c10
    • abarth@webkit.org's avatar
      2011-04-15 Adam Barth <abarth@webkit.org> · a51b999f
      abarth@webkit.org authored
              Reviewed by Eric Seidel.
      
              CSP should block string arguments to setTimeout and setInterval unless options eval-script
              https://bugs.webkit.org/show_bug.cgi?id=58610
      
              Herein lies a four-way testing matrix.
      
              * http/tests/security/contentSecurityPolicy/eval-scripts-setInterval-allowed-expected.txt: Added.
              * http/tests/security/contentSecurityPolicy/eval-scripts-setInterval-allowed.html: Added.
              * http/tests/security/contentSecurityPolicy/eval-scripts-setInterval-blocked-expected.txt: Added.
              * http/tests/security/contentSecurityPolicy/eval-scripts-setInterval-blocked.html: Added.
              * http/tests/security/contentSecurityPolicy/eval-scripts-setTimeout-allowed-expected.txt: Added.
              * http/tests/security/contentSecurityPolicy/eval-scripts-setTimeout-allowed.html: Added.
              * http/tests/security/contentSecurityPolicy/eval-scripts-setTimeout-blocked-expected.txt: Added.
              * http/tests/security/contentSecurityPolicy/eval-scripts-setTimeout-blocked.html: Added.
      2011-04-15  Adam Barth  <abarth@webkit.org>
      
              Reviewed by Eric Seidel.
      
              CSP should block string arguments to setTimeout and setInterval unless options eval-script
              https://bugs.webkit.org/show_bug.cgi?id=58610
      
              It's somewhat sadness that the JSC and V8 code for setTimeout and
              setInterval are so different.  I struggled for a while with how to
              handle the worker case, but I decided to punt on it for now.
      
              Tests: http/tests/security/contentSecurityPolicy/eval-scripts-setInterval-allowed.html
                     http/tests/security/contentSecurityPolicy/eval-scripts-setInterval-blocked.html
                     http/tests/security/contentSecurityPolicy/eval-scripts-setTimeout-allowed.html
                     http/tests/security/contentSecurityPolicy/eval-scripts-setTimeout-blocked.html
      
              * bindings/js/JSDOMWindowCustom.cpp:
              (WebCore::JSDOMWindow::setTimeout):
              (WebCore::JSDOMWindow::setInterval):
              * bindings/js/JSWorkerContextCustom.cpp:
              (WebCore::JSWorkerContext::setTimeout):
              (WebCore::JSWorkerContext::setInterval):
              * bindings/js/ScheduledAction.cpp:
              (WebCore::ScheduledAction::create):
              * bindings/js/ScheduledAction.h:
              * bindings/v8/custom/V8DOMWindowCustom.cpp:
              (WebCore::WindowSetTimeoutImpl):
              * page/ContentSecurityPolicy.cpp:
              (WebCore::ContentSecurityPolicy::allowEval):
              * page/ContentSecurityPolicy.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84073 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a51b999f
    • commit-queue@webkit.org's avatar
      2011-04-15 Shishir Agrawal <shishir@chromium.org> · 2f0affca
      commit-queue@webkit.org authored
              Reviewed by James Robinson.
      
              Add a flag to guard Page Visibility API changes.
              https://bugs.webkit.org/show_bug.cgi?id=58464
      
              Initial draft at:
              http://lists.w3.org/Archives/Public/public-webapps/2011JanMar/0175.html
      
              * configure.ac:
      2011-04-15  Shishir Agrawal  <shishir@chromium.org>
      
              Reviewed by James Robinson.
      
              Add a flag to guard Page Visibility API changes.
              https://bugs.webkit.org/show_bug.cgi?id=58464
      
              * Configurations/FeatureDefines.xcconfig:
      2011-04-15  Shishir Agrawal  <shishir@chromium.org>
      
              Reviewed by James Robinson.
      
              Add a flag to guard Page Visibility API changes.
              https://bugs.webkit.org/show_bug.cgi?id=58464
      
              * Configurations/FeatureDefines.xcconfig:
      2011-04-15  Shishir Agrawal  <shishir@chromium.org>
      
              Reviewed by James Robinson.
      
              Add a flag to guard Page Visibility API changes.
              https://bugs.webkit.org/show_bug.cgi?id=58464
      
              * features.gypi:
      2011-04-15  Shishir Agrawal  <shishir@chromium.org>
      
              Reviewed by James Robinson.
      
              Add a flag to guard Page Visibility API changes.
              https://bugs.webkit.org/show_bug.cgi?id=58464
      
              * Configurations/FeatureDefines.xcconfig:
      2011-04-15  Shishir Agrawal  <shishir@chromium.org>
      
              Reviewed by James Robinson.
      
              Add a flag to guard Page Visibility API changes.
              https://bugs.webkit.org/show_bug.cgi?id=58464
      
              * Configurations/FeatureDefines.xcconfig:
      2011-04-15  Shishir Agrawal  <shishir@chromium.org>
      
              Reviewed by James Robinson.
      
              Add a flag to guard Page Visibility API changes.
              https://bugs.webkit.org/show_bug.cgi?id=58464
      
              * Scripts/build-webkit:
      2011-04-15  Shishir Agrawal  <shishir@chromium.org>
      
              Reviewed by James Robinson.
      
              Add a flag to guard Page Visibility API changes.
              https://bugs.webkit.org/show_bug.cgi?id=58464
      
              * win/tools/vsprops/FeatureDefines.vsprops:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84072 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2f0affca
    • commit-queue@webkit.org's avatar
      2011-04-15 Fridrich Strba <fridrich.strba@bluewin.ch> · 1f18f072
      commit-queue@webkit.org authored
              Reviewed by Martin Robinson.
      
              Make plugins compile during WebKit GTK Windows build.
              Ifdef properly relevant parts so that the PluginViewGtk compiles on Windows.
              https://bugs.webkit.org/show_bug.cgi?id=58580
      
              * plugins/PluginView.cpp:
              (WebCore::PluginView::stop):
              * plugins/PluginView.h:
              * plugins/gtk/PluginViewGtk.cpp:
              (WebCore::PluginView::platformGetValue):
              (WebCore::PluginView::platformStart):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84071 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1f18f072
    • commit-queue@webkit.org's avatar
      2011-04-15 Chang Shu <cshu@webkit.org> · 8596752e
      commit-queue@webkit.org authored
              Reviewed by Alexey Proskuryakov.
      
              When a message with url embedded is added to console, the "file:" scheme
              and path should be stripped.
              https://bugs.webkit.org/show_bug.cgi?id=58665
      
              Unskip passed tests.
      
              * platform/mac-wk2/Skipped:
              * platform/qt-wk2/Skipped:
      2011-04-15  Chang Shu  <cshu@webkit.org>
      
              Reviewed by Alexey Proskuryakov.
      
              When a message with url embedded is added to console, the "file:" scheme
              and path should be stripped.
              https://bugs.webkit.org/show_bug.cgi?id=58665
      
              * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
              (WTR::lastFileURLPathComponent):
              (WTR::InjectedBundlePage::willAddMessageToConsole):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84070 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8596752e
    • barraclough@apple.com's avatar
      Errrk! - build fix from !x86-64. · 74213b41
      barraclough@apple.com authored
      * dfg/DFGNode.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84069 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      74213b41
    • levin@chromium.org's avatar
      Revert of r83974. · a546100f
      levin@chromium.org authored
      JavaScriptCore shouldn't depend on ../ThirdParty/gtest/xcode/gtest.xcodeproj
      https://bugs.webkit.org/show_bug.cgi?id=58716
      
      * JavaScriptCore.xcodeproj/project.pbxproj:
      * wtf/tests/RunAllWtfTests.cpp: Removed.
      * wtf/tests/StringTests.cpp: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84068 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a546100f
    • oliver@apple.com's avatar
      2011-04-15 Oliver Hunt <oliver@apple.com> · 9301c23a
      oliver@apple.com authored
              Reviewed by Gavin Barraclough.
      
              Remove DeprecatedPtr
              https://bugs.webkit.org/show_bug.cgi?id=58718
      
              As simple as it sounds.
      
              * heap/MarkStack.h:
              (JSC::MarkStack::append):
              * runtime/JSValue.h:
              * runtime/WriteBarrier.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84067 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9301c23a
    • morrita@google.com's avatar
      2011-04-15 MORITA Hajime <morrita@google.com> · ad6e8b97
      morrita@google.com authored
              Reviewed by Simon Fraser.
      
              Calls to WebCore::Document::mayCauseFlashOfUnstyledContent make frequently-run drawing methods slower
              https://bugs.webkit.org/show_bug.cgi?id=58512
      
              Manually rolled out r72367 at which mayCauseFlashOfUnstyledContent() was introduced.
              This change keeps an small refactoring on
              FrameView::shouldUpdate(), which doesn't affect on the behavior.
      
              * dom/Document.cpp:
              * dom/Document.h:
              * page/FrameView.cpp:
              (WebCore::FrameView::invalidateRect):
              (WebCore::FrameView::shouldUpdate):
              * rendering/RenderBlock.cpp:
              (WebCore::RenderBlock::paintContents):
              * rendering/RenderLayer.cpp:
              (WebCore::RenderLayer::paintLayer):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84066 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ad6e8b97
    • crogers@google.com's avatar
      2011-04-15 Chris Rogers <crogers@google.com> · c0bc498c
      crogers@google.com authored
              Reviewed by Kenneth Russell.
      
              Reduce default kernel size of SincResampler to favor better speed over quality
              https://bugs.webkit.org/show_bug.cgi?id=58710
      
              No new tests since audio API is not yet implemented.
      
              * platform/audio/SincResampler.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84065 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c0bc498c
    • jeffm@apple.com's avatar
      2011-04-15 Jeff Miller <jeffm@apple.com> · 7fd4c75f
      jeffm@apple.com authored
              Reviewed by Sam Weinig.
      
              Add takeFocus callback to WKPageUIClient
              https://bugs.webkit.org/show_bug.cgi?id=58686
      
              On Windows, we need to handle moving focus out of the web view in the client, so add a takeFocus callback to WKPageUIClient
              and stop handling taking focus in the framework in WKView.mm on the Mac.
      
              * UIProcess/API/C/WKPage.h: Added WKFocusDirection enum and takeFocus to WKPageUIClient.
              * UIProcess/API/mac/PageClientImpl.h: Removed takeFocus().
              * UIProcess/API/mac/PageClientImpl.mm: Removed takeFocus().
              * UIProcess/API/mac/WKView.mm: Removed _takeFocus().
              * UIProcess/API/mac/WKViewInternal.h: Removed _takeFocus().
              * UIProcess/API/qt/ClientImpl.cpp:
              (qt_wk_takeFocus): Added.
              * UIProcess/API/qt/ClientImpl.h: Added qt_wk_takeFocus.
              * UIProcess/API/qt/qwkpage.cpp: Remove takeFocus().
              (QWKPage::QWKPage): Added takeFocus() callback.
              * UIProcess/PageClient.h: Removed takeFocus().
              * UIProcess/WebPageProxy.cpp:
              (WebKit::WebPageProxy::takeFocus): Call m_uiClient to take focus.
              * UIProcess/WebPageProxy.h: Pass FocusDirection as a uint32_t to takeFocus().
              * UIProcess/WebPageProxy.messages.in: Pass FocusDirection as a uint32_t in TakeFocus message.
              * UIProcess/WebUIClient.cpp:
              (WebKit::WebUIClient::takeFocus): Added.
              * UIProcess/WebUIClient.h: Added takeFocus().
              * UIProcess/win/WebView.cpp: Removed takeFocus(), which was never implemented on Windows.
              * UIProcess/win/WebView.h: Removed takeFocus().
              * WebProcess/WebCoreSupport/WebChromeClient.cpp:
              (WebKit::WebChromeClient::takeFocus): Pass FocusDirection as a uint32_t in TakeFocus message.
      2011-04-15  Jeff Miller  <jeffm@apple.com>
      
              Reviewed by Sam Weinig.
      
              Add takeFocus callback to WKPageUIClient
              https://bugs.webkit.org/show_bug.cgi?id=58686
      
              Add empty WKPageUIClient entries for the takeFocus callback in the MiniBrowser and WebKitTestRunner.
      
              * MiniBrowser/mac/BrowserWindowController.m:
              (-[BrowserWindowController awakeFromNib]): Added empty takeFocus entry.
              * MiniBrowser/win/BrowserView.cpp:
              (BrowserView::create): Added empty takeFocus entry.
              * WebKitTestRunner/TestController.cpp:
              (WTR::TestController::createOtherPage): Added empty takeFocus entry.
              (WTR::TestController::initialize): Added empty takeFocus entry.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84064 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7fd4c75f
    • barraclough@apple.com's avatar
      Add a simple tool to gather statistics on whether functions · ea276f73
      barraclough@apple.com authored
      are completed through the new or old JIT.
      
      Reviewed by Oliver Hunt.
      
      * dfg/DFGNode.h:
      * dfg/DFGNonSpeculativeJIT.cpp:
      (JSC::DFG::NonSpeculativeJIT::compile):
      * dfg/DFGSpeculativeJIT.cpp:
      (JSC::DFG::SpeculativeJIT::compile):
      * jit/JIT.cpp:
      (JSC::JIT::privateCompile):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84063 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ea276f73
    • ap@apple.com's avatar
      Reviewed by Sam Weinig. · 3786b4f7
      ap@apple.com authored
              WebKit2: Stop using deprecated NSInputManager
              https://bugs.webkit.org/show_bug.cgi?id=58709
      
              Changed all mouse related functions to give NSInputContext a chance to handle the event,
              added logging. Removed -rightMouseMoved: method, which was added by accident.
      
              * UIProcess/API/mac/WKView.mm:
              (-[WKView mouseMoved:]):
              (-[WKView mouseDown:]):
              (-[WKView mouseUp:]):
              (-[WKView mouseDragged:]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84062 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3786b4f7
    • commit-queue@webkit.org's avatar
      2011-04-15 Fridrich Strba <fridrich.strba@bluewin.ch> · 4ccad325
      commit-queue@webkit.org authored
              Reviewed by Martin Robinson.
      
              Expand the ntohs, ntohl, htons and htonl defines for OS(WINDOWS)
              These have to be defined for Windows in general, since win32 API
              does not provide them.
              https://bugs.webkit.org/show_bug.cgi?id=58582
      
              * platform/graphics/WOFFFileFormat.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84061 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4ccad325
    • commit-queue@webkit.org's avatar
      2011-04-15 Vsevolod Vlasov <vsevik@chromium.org> · e458ee01
      commit-queue@webkit.org authored
              Reviewed by Adam Barth.
      
              Show a console message when X-Frame-Options blocks a load
              https://bugs.webkit.org/show_bug.cgi?id=39087
      
              Added console message when X-Frame-Options headers block resource loading
      
              * http/tests/inspector/network/x-frame-options-deny-expected.txt:
              * http/tests/security/XFrameOptions/x-frame-options-deny-expected.txt:
              * http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny-expected.txt:
      2011-04-15  Vsevolod Vlasov  <vsevik@chromium.org>
      
              Reviewed by Adam Barth.
      
              Show a console message when X-Frame-Options blocks a load
              https://bugs.webkit.org/show_bug.cgi?id=39087
      
              Added console message when X-Frame-Options headers block resource loading
      
              * loader/MainResourceLoader.cpp:
              (WebCore::MainResourceLoader::didReceiveResponse):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84060 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e458ee01
    • commit-queue@webkit.org's avatar
      2011-04-15 Fridrich Strba <fridrich.strba@bluewin.ch> · 5b10fc6f
      commit-queue@webkit.org authored
              Reviewed by Martin Robinson.
      
              Evaluate PLATFORM(GTK) before the all-encompassing OS(WINDOWS)
              test. This allows Windows build of WebKit GTK to chose the right
              path.
              https://bugs.webkit.org/show_bug.cgi?id=58576
      
              * platform/FileSystem.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84059 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5b10fc6f
    • jhoneycutt@apple.com's avatar
      Potential crash getting a JS wrapper. · 2f42241f
      jhoneycutt@apple.com authored
      <rdar://problem/8988741>
      
      Reviewed by Brian Weinstein.
      
      * WebProcess/WebPage/WebFrame.cpp:
      (WebKit::WebFrame::jsWrapperForWorld):
      Ensure that we have a valid m_coreFrame, because it can be cleared by
      invalidate().
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84058 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2f42241f
    • luiz@webkit.org's avatar
      [Qt] QWebPage MIME type handling inconsistency with other web browsers · 37a183b5
      luiz@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=46968
      
      Source/WebCore:
      
      Reviewed by Kenneth Rohde Christiansen.
      
      Implementing mime type sniffing based on
      http://tools.ietf.org/html/draft-abarth-mime-sniff-06.
      
      * WebCore.pro:
      * platform/network/MIMESniffing.cpp: Added.
      (MagicNumbers::dataSizeNeededForImageSniffing):
      (MagicNumbers::maskedCompare):
      (MagicNumbers::checkSpaceOrBracket):
      (MagicNumbers::compare):
      (MagicNumbers::findMIMEType):
      (MagicNumbers::findSimpleMIMEType):
      (MagicNumbers::textOrBinaryTypeSniffingProcedure):
      (MagicNumbers::unknownTypeSniffingProcedure):
      (MagicNumbers::imageTypeSniffingProcedure):
      (MagicNumbers::checkText):
      (MagicNumbers::checkRDF):
      (MagicNumbers::skipTag):
      (MagicNumbers::feedTypeSniffingProcedure):
      (MIMESniffer::MIMESniffer):
      * platform/network/MIMESniffing.h: Added.
      (MIMESniffer::dataSize):
      (MIMESniffer::sniff):
      (MIMESniffer::isValid):
      * platform/network/NetworkingContext.h:
      * platform/network/qt/QNetworkReplyHandler.cpp:
      (WebCore::QNetworkReplyWrapper::QNetworkReplyWrapper):
      (WebCore::QNetworkReplyWrapper::release):
      (WebCore::QNetworkReplyWrapper::receiveMetaData):
      (WebCore::QNetworkReplyWrapper::receiveSniffedMIMEType):
      (WebCore::QNetworkReplyWrapper::emitMetaDataChanged):
      (WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
      (WebCore::QNetworkReplyHandler::sendNetworkRequest):
      (WebCore::QNetworkReplyHandler::start):
      * platform/network/qt/QNetworkReplyHandler.h:
      (WebCore::QNetworkReplyWrapper::advertisedMIMEType):
      (WebCore::QNetworkReplyWrapper::mimeType):
      * platform/network/qt/QtMIMETypeSniffer.cpp: Added.
      (QtMIMETypeSniffer::QtMIMETypeSniffer):
      (QtMIMETypeSniffer::sniff):
      (QtMIMETypeSniffer::trySniffing):
      * platform/network/qt/QtMIMETypeSniffer.h: Added.
      (QtMIMETypeSniffer::mimeType):
      (QtMIMETypeSniffer::isFinished):
      
      Source/WebKit/qt:
      
      Reviewed by Kenneth Rohde Christiansen.
      
      Implementing mime type sniffing based on
      http://tools.ietf.org/html/draft-abarth-mime-sniff-06.
      
      * WebCoreSupport/FrameLoaderClientQt.cpp:
      (WebCore::FrameLoaderClientQt::createNetworkingContext):
      * WebCoreSupport/FrameNetworkingContextQt.cpp:
      (WebCore::FrameNetworkingContextQt::FrameNetworkingContextQt):
      (WebCore::FrameNetworkingContextQt::create):
      (WebCore::FrameNetworkingContextQt::MIMESniffingEnabled):
      * WebCoreSupport/FrameNetworkingContextQt.h:
      * tests/MIMESniffing/MIMESniffing.pro: Added.
      * tests/MIMESniffing/TestData.h: Added.
      * tests/MIMESniffing/resources.qrc: Added.
      * tests/MIMESniffing/resources/application_atom+xml: Added.
      * tests/MIMESniffing/resources/application_ogg: Added.
      * tests/MIMESniffing/resources/application_pdf: Added.
      * tests/MIMESniffing/resources/application_postscript: Added.
      * tests/MIMESniffing/resources/application_rdf+xml: Added.
      * tests/MIMESniffing/resources/application_rss+xml: Added.
      * tests/MIMESniffing/resources/application_x-gzip: Added.
      * tests/MIMESniffing/resources/application_x-rar-compressed: Added.
      * tests/MIMESniffing/resources/application_zip: Added.
      * tests/MIMESniffing/resources/audio_x-wave: Added.
      * tests/MIMESniffing/resources/image_bmp: Added.
      * tests/MIMESniffing/resources/image_gif: Added.
      * tests/MIMESniffing/resources/image_jpeg: Added.
      * tests/MIMESniffing/resources/image_png: Added.
      * tests/MIMESniffing/resources/image_vnd.microsoft.icon: Added.
      * tests/MIMESniffing/resources/image_webp: Added.
      * tests/MIMESniffing/resources/text_html: Added.
      * tests/MIMESniffing/resources/text_xml: Added.
      * tests/MIMESniffing/resources/video_webm: Added.
      * tests/MIMESniffing/tst_MIMESniffing.cpp: Added.
      (tst_MIMESniffing::tst_MIMESniffing):
      (errorText):
      (tst_MIMESniffing::testCase1):
      * tests/tests.pro:
      
      Source/WebKit2:
      
      Reviewed by Kenneth Rohde Christiansen.
      
      Implementing mime type sniffing based on
      http://tools.ietf.org/html/draft-abarth-mime-sniff-06.
      
      * WebProcess/WebCoreSupport/qt/WebFrameNetworkingContext.cpp:
      (WebCore::WebFrameNetworkingContext::WebFrameNetworkingContext):
      (WebCore::WebFrameNetworkingContext::MIMESniffingEnabled):
      * WebProcess/WebCoreSupport/qt/WebFrameNetworkingContext.h:
      
      LayoutTests:
      
      Rubberstamped by Andreas Kling.
      
      Unskipping http/tests/loading/text-content-type-with-binary-extension.html.
      
      * platform/qt/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84057 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      37a183b5
    • eae@chromium.org's avatar
      2011-04-15 Emil A Eklund <eae@chromium.org> · 66e5ded8
      eae@chromium.org authored
              Reviewed by Dimitri Glazkov.
      
              input field with focus makes appendChild operation ~42x slower
              https://bugs.webkit.org/show_bug.cgi?id=57059
      
              Add performance test for cloneNode when an input field has focus.
      
              * perf/clone-with-focus-expected.txt: Added.
              * perf/clone-with-focus.html: Added.
      2011-04-15  Emil A Eklund  <eae@chromium.org>
      
              Reviewed by Dimitri Glazkov.
      
              input field with focus makes appendChild operation ~42x slower
              https://bugs.webkit.org/show_bug.cgi?id=57059
      
              Change ContainerNode::cloneChildNodes to only disable the
              deleteButtonController if the container itself (or any of its children)
              is being edited. Thus avoiding a reflow in cases where it's not.
      
              Test: perf/clone-with-focus.html
      
              * dom/ContainerNode.cpp:
              (WebCore::ContainerNode::cloneChildNodes):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84056 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      66e5ded8
    • commit-queue@webkit.org's avatar
      2011-04-15 Charlie Reis <creis@chromium.org> · e1aebace
      commit-queue@webkit.org authored
              Reviewed by Darin Fisher.
      
              [Chromium] fast/events/popup-allowed-from-gesture-initiated-form-submit.html causing debug ASSERT
              https://bugs.webkit.org/show_bug.cgi?id=44079
      
              Remove an assert whose invariant doesn't hold.
      
              * platform/chromium/test_expectations.txt: Re-enable test.
      2011-04-15  Charlie Reis  <creis@chromium.org>
      
              Reviewed by Darin Fisher.
      
              [Chromium] fast/events/popup-allowed-from-gesture-initiated-form-submit.html causing debug ASSERT
              https://bugs.webkit.org/show_bug.cgi?id=44079
      
              Remove an assert whose invariant doesn't hold.
      
              * src/FrameLoaderClientImpl.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@84055 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e1aebace
  2. 15 Apr, 2011 4 commits