1. 04 Dec, 2013 31 commits
    • fpizlo@apple.com's avatar
      Infer constant closure variables · 88fedde1
      fpizlo@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=124630
      
      Source/JavaScriptCore: 
      
      Reviewed by Geoffrey Garen.
              
      Captured variables that are assigned once (not counting op_enter's Undefined
      initialization) and that are contained within a function that has thus far only been
      entered once are now constant folded. It's pretty awesome.
              
      This involves a watchpoint on the assignment to variables and a watchpoint on entry
      into the function. The former is reused from global variable constant inference and the
      latter is reused from one-time closure inference.
      
      * GNUmakefile.list.am:
      * JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
      * JavaScriptCore.xcodeproj/project.pbxproj:
      * bytecode/CodeBlock.cpp:
      (JSC::CodeBlock::dumpBytecode):
      (JSC::CodeBlock::CodeBlock):
      * bytecode/Instruction.h:
      (JSC::Instruction::Instruction):
      * bytecode/Opcode.h:
      (JSC::padOpcodeName):
      * bytecode/UnlinkedCodeBlock.h:
      (JSC::UnlinkedInstruction::UnlinkedInstruction):
      * bytecode/VariableWatchpointSet.h:
      (JSC::VariableWatchpointSet::invalidate):
      * bytecode/Watchpoint.h:
      (JSC::WatchpointSet::invalidate):
      * bytecompiler/BytecodeGenerator.cpp:
      (JSC::BytecodeGenerator::addVar):
      (JSC::BytecodeGenerator::BytecodeGenerator):
      (JSC::BytecodeGenerator::emitInitLazyRegister):
      (JSC::BytecodeGenerator::emitMove):
      (JSC::BytecodeGenerator::emitNewFunctionInternal):
      (JSC::BytecodeGenerator::createArgumentsIfNecessary):
      * bytecompiler/BytecodeGenerator.h:
      (JSC::BytecodeGenerator::addVar):
      (JSC::BytecodeGenerator::watchableVariable):
      * dfg/DFGByteCodeParser.cpp:
      (JSC::DFG::ByteCodeParser::getLocal):
      (JSC::DFG::ByteCodeParser::inferredConstant):
      (JSC::DFG::ByteCodeParser::parseBlock):
      (JSC::DFG::ByteCodeParser::parse):
      * dfg/DFGGraph.cpp:
      (JSC::DFG::Graph::tryGetActivation):
      (JSC::DFG::Graph::tryGetRegisters):
      * dfg/DFGGraph.h:
      * jit/JIT.cpp:
      (JSC::JIT::privateCompileMainPass):
      (JSC::JIT::privateCompileSlowCases):
      * jit/JIT.h:
      * jit/JITOpcodes.cpp:
      (JSC::JIT::emit_op_mov):
      (JSC::JIT::emit_op_captured_mov):
      (JSC::JIT::emit_op_new_captured_func):
      (JSC::JIT::emitSlow_op_captured_mov):
      * jit/JITOpcodes32_64.cpp:
      (JSC::JIT::emit_op_mov):
      (JSC::JIT::emit_op_captured_mov):
      * llint/LowLevelInterpreter32_64.asm:
      * llint/LowLevelInterpreter64.asm:
      * runtime/CommonSlowPaths.cpp:
      (JSC::SLOW_PATH_DECL):
      * runtime/CommonSlowPaths.h:
      * runtime/ConstantMode.h: Added.
      * runtime/JSGlobalObject.h:
      * runtime/JSScope.cpp:
      (JSC::abstractAccess):
      * runtime/SymbolTable.cpp:
      (JSC::SymbolTableEntry::prepareToWatch):
      
      LayoutTests: 
      
      Reviewed by Geoffrey Garen.
              
      This adds both correctness and performance tests for constant closure variable
      inference.
      
      * js/regress/infer-closure-const-then-mov-expected.txt: Added.
      * js/regress/infer-closure-const-then-mov-no-inline-expected.txt: Added.
      * js/regress/infer-closure-const-then-mov-no-inline.html: Added.
      * js/regress/infer-closure-const-then-mov.html: Added.
      * js/regress/infer-closure-const-then-put-to-scope-expected.txt: Added.
      * js/regress/infer-closure-const-then-put-to-scope-no-inline-expected.txt: Added.
      * js/regress/infer-closure-const-then-put-to-scope-no-inline.html: Added.
      * js/regress/infer-closure-const-then-put-to-scope.html: Added.
      * js/regress/infer-closure-const-then-reenter-expected.txt: Added.
      * js/regress/infer-closure-const-then-reenter-no-inline-expected.txt: Added.
      * js/regress/infer-closure-const-then-reenter-no-inline.html: Added.
      * js/regress/infer-closure-const-then-reenter.html: Added.
      * js/regress/script-tests/infer-closure-const-then-mov-no-inline.js: Added.
      * js/regress/script-tests/infer-closure-const-then-mov.js: Added.
      * js/regress/script-tests/infer-closure-const-then-put-to-scope-no-inline.js: Added.
      (thingy.):
      (thingy):
      * js/regress/script-tests/infer-closure-const-then-put-to-scope.js: Added.
      (thingy.):
      (thingy):
      * js/regress/script-tests/infer-closure-const-then-reenter-no-inline.js: Added.
      (.return.foo):
      (foo):
      * js/regress/script-tests/infer-closure-const-then-reenter.js: Added.
      (.return.foo):
      (foo):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160109 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      88fedde1
    • mhahnenberg@apple.com's avatar
      run-jsc-stress-tests can only run locally · 07923100
      mhahnenberg@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=124551
      
      Reviewed by Filip Pizlo.
      
      * Scripts/jsc-stress-test-helpers/shell-runner.sh: Fixed a couple issues. One was if the script was
      killed before the lock directory was removed, future executions wouldn't make any progress. Also
      added a couple more signals to handle gracefully at shutdown.
      * Scripts/run-javascriptcore-tests: Pass through the --remote argument to run-jsc-stress-tests.
      * Scripts/run-jsc-stress-tests: Added support for the --remote flag. It accepts a hostname, user, and port.
      The script then generates the test bundle, tars it up, and copies it to the remote host via ssh where
      it then untars the bundle and executes the shell-based test runner. Also refactored some of the logic
      toward the end of the script to make it easier to tell which of the various modes do what.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160108 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      07923100
    • ossy@webkit.org's avatar
      [EFL][WK2] Buildfix after r160104 · 84b1cde8
      ossy@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=125233
      
      Reviewed by Anders Carlsson.
      
      Source/WebKit2:
      
      * UIProcess/API/efl/ewk_cookie_manager.cpp:
      (EwkCookieManager::EwkCookieManager):
      * UIProcess/API/efl/ewk_favicon_database.cpp:
      (EwkFaviconDatabase::EwkFaviconDatabase):
      * UIProcess/efl/ContextHistoryClientEfl.cpp:
      (WebKit::ContextHistoryClientEfl::ContextHistoryClientEfl):
      * UIProcess/efl/ContextMenuClientEfl.cpp:
      (ContextMenuClientEfl::ContextMenuClientEfl):
      * UIProcess/efl/DownloadManagerEfl.cpp:
      (WebKit::DownloadManagerEfl::DownloadManagerEfl):
      * UIProcess/efl/FindClientEfl.cpp:
      (WebKit::FindClientEfl::FindClientEfl):
      * UIProcess/efl/FormClientEfl.cpp:
      (WebKit::FormClientEfl::FormClientEfl):
      * UIProcess/efl/PageLoadClientEfl.cpp:
      (WebKit::PageLoadClientEfl::PageLoadClientEfl):
      * UIProcess/efl/PagePolicyClientEfl.cpp:
      (WebKit::PagePolicyClientEfl::PagePolicyClientEfl):
      * UIProcess/efl/PageUIClientEfl.cpp:
      (WebKit::PageUIClientEfl::PageUIClientEfl):
      
      Tools:
      
      * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive.cpp:
      (TestWebKitAPI::TEST):
      * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
      (TestWebKitAPI::setPageLoaderClient):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160107 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      84b1cde8
    • aestes@apple.com's avatar
      [iOS] Upstream build fixes in Source/WebKit/ios/ · d41c6fc9
      aestes@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=125230
      
      Reviewed by Sam Weinig.
      
      * DefaultDelegates/WebDefaultUIKitDelegate.m:
      (-[WebDefaultUIKitDelegate webViewDidReceiveMobileDocType:]):
      * Misc/WebNSStringDrawing.mm:
      (needsBidiLayout):
      (-[NSString __web_drawAtPoint:forWidth:withFont:ellipsis:letterSpacing:includeEmoji:measureOnly:renderedStringOut:drawUnderline:]):
      (-[NSString __web_drawInRect:withFont:ellipsis:alignment:letterSpacing:lineSpacing:includeEmoji:truncationRect:measureOnly:renderedStringOut:drawUnderline:]):
      * Misc/WebUIKitSupport.mm:
      (WebKitInitialize):
      * WebCoreSupport/WebChromeClientIOS.h:
      * WebCoreSupport/WebChromeClientIOS.mm:
      (WebChromeClientIOS::didReceiveMobileDocType):
      (WebChromeClientIOS::focusedElementChanged):
      * WebCoreSupport/WebFrameIOS.mm:
      (-[WebFrame clearSelection]):
      (-[WebFrame selectionState]):
      (-[WebFrame collapseSelection]):
      (-[WebFrame extendSelection:]):
      (-[WebFrame selectionRects]):
      (-[WebFrame setRangedSelectionWithExtentPoint:]):
      (-[WebFrame setRangedSelectionExtentPoint:baseIsStart:allowFlipping:]):
      (-[WebFrame setSelectionWithBasePoint:extentPoint:baseIsStart:allowFlipping:]):
      (-[WebFrame setSelectionWithFirstPoint:secondPoint:]):
      (-[WebFrame ensureRangedSelectionContainsInitialStartPoint:initialEndPoint:]):
      (-[WebFrame aggressivelyExpandSelectionToWordContainingCaretSelection]):
      (-[WebFrame expandSelectionToSentence]):
      (-[WebFrame setBaseWritingDirection:]):
      (-[WebFrame moveSelectionToStart]):
      (-[WebFrame moveSelectionToEnd]):
      (-[WebFrame moveSelectionToPoint:]):
      (-[WebFrame setSelectionGranularity:]):
      (-[WebFrame smartExtendRangedSelection:]):
      (-[WebFrame previousUnperturbedDictationResultBoundaryFromPosition:]):
      (-[WebFrame nextUnperturbedDictationResultBoundaryFromPosition:]):
      * WebCoreSupport/WebInspectorClientIOS.mm:
      (WebInspectorClient::WebInspectorClient):
      (WebInspectorClient::didSetSearchingForNode):
      (WebInspectorClient::setupRemoteConnection):
      (WebInspectorClient::teardownRemoteConnection):
      * WebCoreSupport/WebVisiblePosition.mm:
      (-[WebVisiblePosition enclosingRangeWithDictationPhraseAlternatives:]):
      (-[WebVisiblePosition enclosingRangeWithCorrectionIndicator]):
      (-[DOMHTMLInputElement startPosition]):
      (-[DOMHTMLInputElement endPosition]):
      (-[DOMHTMLTextAreaElement startPosition]):
      (-[DOMHTMLTextAreaElement endPosition]):
      * WebView/WebPDFViewIOS.mm:
      (+[WebPDFView shadowColor]):
      (+[WebPDFView backgroundColor]):
      (-[WebPDFView _checkPDFTitle]):
      * WebView/WebPDFViewPlaceholder.mm:
      (-[WebPDFViewPlaceholder simulateClickOnLinkToURL:]):
      * WebView/WebUIKitDelegate.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160106 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d41c6fc9
    • bfulgham@apple.com's avatar
      [Win] Unreviewed project file gardening. · 8b15ff35
      bfulgham@apple.com authored
      * JavaScriptCore.vcxproj/JavaScriptCore.vcxproj: Remove deleted files from project.
      * JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters: Put files in proper directory
      folders to match the directory structure of the source code.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160105 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8b15ff35
    • andersca@apple.com's avatar
      Deprecate all unversioned client structs in favor of having explicit versioned structs · a899664e
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=125203
      
      Reviewed by Dan Bernstein.
      
      Source/WebKit2:
      
      Deprecate all the "current version" enums and unversioned client structs.
      
      * Shared/API/c/WKConnectionRef.cpp:
      (WKConnectionSetConnectionClient):
      * Shared/API/c/WKConnectionRef.h:
      * UIProcess/API/C/WKContext.cpp:
      (WKContextSetClient):
      (WKContextSetInjectedBundleClient):
      (WKContextSetHistoryClient):
      (WKContextSetDownloadClient):
      (WKContextSetConnectionClient):
      * UIProcess/API/C/WKContext.h:
      * UIProcess/API/C/WKContextConnectionClient.h:
      * UIProcess/API/C/WKContextDownloadClient.h:
      * UIProcess/API/C/WKContextHistoryClient.h:
      * UIProcess/API/C/WKContextInjectedBundleClient.h:
      * UIProcess/API/C/WKCookieManager.cpp:
      (WKCookieManagerSetClient):
      * UIProcess/API/C/WKCookieManager.h:
      * UIProcess/API/C/WKDatabaseManager.cpp:
      (WKDatabaseManagerSetClient):
      * UIProcess/API/C/WKDatabaseManager.h:
      * UIProcess/API/C/WKGeolocationManager.cpp:
      (WKGeolocationManagerSetProvider):
      * UIProcess/API/C/WKGeolocationManager.h:
      * UIProcess/API/C/WKIconDatabase.cpp:
      (WKIconDatabaseSetIconDatabaseClient):
      * UIProcess/API/C/WKIconDatabase.h:
      * UIProcess/API/C/WKOriginDataManager.cpp:
      (WKOriginDataManagerSetChangeClient):
      * UIProcess/API/C/WKOriginDataManager.h:
      * UIProcess/API/C/WKPage.cpp:
      (WKPageSetPageContextMenuClient):
      (WKPageSetPageFindClient):
      (WKPageSetPageFindMatchesClient):
      (WKPageSetPageFormClient):
      (WKPageSetPageLoaderClient):
      (WKPageSetPagePolicyClient):
      (WKPageSetPageUIClient):
      * UIProcess/API/C/WKPage.h:
      * UIProcess/API/C/WKPageContextMenuClient.h:
      * UIProcess/API/C/WKPageFindClient.h:
      * UIProcess/API/C/WKPageFindMatchesClient.h:
      * UIProcess/API/C/WKPageFormClient.h:
      * UIProcess/API/C/WKPageLoaderClient.h:
      * UIProcess/API/C/WKPagePolicyClient.h:
      * UIProcess/API/C/WKPageUIClient.h:
      * UIProcess/API/Cocoa/WKBrowsingContextController.mm:
      (setUpPagePolicyClient):
      * UIProcess/API/Cocoa/WKConnection.mm:
      (setUpClient):
      * UIProcess/API/Cocoa/WKProcessGroup.mm:
      (setUpConnectionClient):
      (setUpInectedBundleClient):
      (setUpHistoryClient):
      * UIProcess/WebInspectorProxy.cpp:
      (WebKit::WebInspectorProxy::createInspectorPage):
      * UIProcess/WebUIClient.cpp:
      (WebKit::WebUIClient::createNewPage):
      (WebKit::WebUIClient::mouseDidMoveOverElement):
      * UIProcess/mac/WebInspectorProxyMac.mm:
      (WebKit::WebInspectorProxy::platformCreateInspectorPage):
      * WebProcess/InjectedBundle/API/c/WKBundle.cpp:
      (WKBundleSetClient):
      * WebProcess/InjectedBundle/API/c/WKBundle.h:
      * WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
      (WKBundlePageSetContextMenuClient):
      (WKBundlePageSetEditorClient):
      (WKBundlePageSetFormClient):
      (WKBundlePageSetPageLoaderClient):
      (WKBundlePageSetResourceLoadClient):
      (WKBundlePageSetPolicyClient):
      (WKBundlePageSetUIClient):
      (WKBundlePageSetFullScreenClient):
      (WKBundlePageSetDiagnosticLoggingClient):
      * WebProcess/InjectedBundle/API/c/WKBundlePage.h:
      * WebProcess/InjectedBundle/API/c/WKBundlePageBanner.h:
      * WebProcess/InjectedBundle/API/c/WKBundlePageContextMenuClient.h:
      * WebProcess/InjectedBundle/API/c/WKBundlePageDiagnosticLoggingClient.h:
      * WebProcess/InjectedBundle/API/c/WKBundlePageEditorClient.h:
      * WebProcess/InjectedBundle/API/c/WKBundlePageFormClient.h:
      * WebProcess/InjectedBundle/API/c/WKBundlePageFullScreenClient.h:
      * WebProcess/InjectedBundle/API/c/WKBundlePageLoaderClient.h:
      * WebProcess/InjectedBundle/API/c/WKBundlePageOverlay.cpp:
      (WKBundlePageOverlayCreate):
      (WKBundlePageOverlaySetAccessibilityClient):
      * WebProcess/InjectedBundle/API/c/WKBundlePageOverlay.h:
      * WebProcess/InjectedBundle/API/c/WKBundlePagePolicyClient.h:
      * WebProcess/InjectedBundle/API/c/WKBundlePageResourceLoadClient.h:
      * WebProcess/InjectedBundle/API/c/WKBundlePageUIClient.h:
      * WebProcess/InjectedBundle/API/c/mac/WKBundlePageBannerMac.h:
      * WebProcess/InjectedBundle/API/c/mac/WKBundlePageBannerMac.mm:
      (WKBundlePageBannerCreateBannerWithCALayer):
      * WebProcess/InjectedBundle/API/mac/WKWebProcessPlugIn.mm:
      (setUpBundleClient):
      
      Tools:
      
      Update for WebKit2 API changes.
      
      * MiniBrowser/mac/AppDelegate.m:
      (-[BrowserAppDelegate init]):
      * MiniBrowser/mac/WK2BrowserWindowController.m:
      (-[WK2BrowserWindowController awakeFromNib]):
      * TestWebKitAPI/InjectedBundleController.cpp:
      (TestWebKitAPI::InjectedBundleController::initialize):
      * TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp:
      (TestWebKitAPI::TEST):
      * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp:
      (TestWebKitAPI::setInjectedBundleClient):
      * TestWebKitAPI/Tests/WebKit2/CloseThenTerminate.cpp:
      (TestWebKitAPI::TEST):
      * TestWebKitAPI/Tests/WebKit2/CookieManager.cpp:
      (TestWebKitAPI::TEST):
      * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic.cpp:
      (TestWebKitAPI::TEST):
      * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp:
      (TestWebKitAPI::DOMWindowExtensionBasic::didCreatePage):
      * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache.cpp:
      (TestWebKitAPI::TEST):
      * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache_Bundle.cpp:
      (TestWebKitAPI::DOMWindowExtensionNoCache::didCreatePage):
      * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls.cpp:
      (TestWebKitAPI::setInjectedBundleClient):
      * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls_Bundle.cpp:
      (TestWebKitAPI::DidAssociateFormControlsTest::didCreatePage):
      * TestWebKitAPI/Tests/WebKit2/DidNotHandleKeyDown.cpp:
      (TestWebKitAPI::TEST):
      * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
      (TestWebKitAPI::TEST):
      * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp:
      (TestWebKitAPI::setContextDownloadClient):
      (TestWebKitAPI::setPagePolicyClient):
      * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
      (TestWebKitAPI::TEST):
      * TestWebKitAPI/Tests/WebKit2/Find.cpp:
      (TestWebKitAPI::TEST):
      * TestWebKitAPI/Tests/WebKit2/FindMatches.mm:
      (TestWebKitAPI::TEST):
      * TestWebKitAPI/Tests/WebKit2/ForceRepaint.cpp:
      (TestWebKitAPI::TEST):
      * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
      (TestWebKitAPI::TEST):
      * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
      (TestWebKitAPI::TEST):
      * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
      (TestWebKitAPI::setupGeolocationProvider):
      (TestWebKitAPI::setupView):
      (TestWebKitAPI::TEST):
      * TestWebKitAPI/Tests/WebKit2/GetInjectedBundleInitializationUserDataCallback.cpp:
      (TestWebKitAPI::TEST):
      * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle.cpp:
      (TestWebKitAPI::setPageLoaderClient):
      (TestWebKitAPI::setInjectedBundleClient):
      * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle_Bundle.cpp:
      (TestWebKitAPI::HitTestResultNodeHandleTest::didCreatePage):
      * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
      (TestWebKitAPI::TEST):
      * TestWebKitAPI/Tests/WebKit2/InjectedBundleFrameHitTest.cpp:
      (TestWebKitAPI::setInjectedBundleClient):
      * TestWebKitAPI/Tests/WebKit2/InjectedBundleFrameHitTest_Bundle.cpp:
      (TestWebKitAPI::InjectedBundleFrameHitTestTest::didCreatePage):
      * TestWebKitAPI/Tests/WebKit2/InjectedBundleInitializationUserDataCallbackWins.cpp:
      (TestWebKitAPI::TEST):
      * TestWebKitAPI/Tests/WebKit2/LayoutMilestonesWithAllContentInFrame.cpp:
      (TestWebKitAPI::TEST):
      * TestWebKitAPI/Tests/WebKit2/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
      (TestWebKitAPI::TEST):
      * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback.cpp:
      (TestWebKitAPI::TEST):
      * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback_Bundle.cpp:
      (TestWebKitAPI::LoadCanceledNoServerRedirectCallbackTest::didCreatePage):
      * TestWebKitAPI/Tests/WebKit2/LoadPageOnCrash.cpp:
      (TestWebKitAPI::WebKit2CrashLoader::WebKit2CrashLoader):
      * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
      (TestWebKitAPI::setPageLoaderClient):
      * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout.cpp:
      (TestWebKitAPI::setPageLoaderClient):
      * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails.cpp:
      (TestWebKitAPI::setPageLoaderClient):
      * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutForImages.cpp:
      (TestWebKitAPI::setPageLoaderClient):
      * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames.cpp:
      (TestWebKitAPI::setPageLoaderClient):
      * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
      (TestWebKitAPI::TEST):
      * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
      (TestWebKitAPI::TEST):
      * TestWebKitAPI/Tests/WebKit2/ParentFrame.cpp:
      (TestWebKitAPI::setInjectedBundleClient):
      * TestWebKitAPI/Tests/WebKit2/ParentFrame_Bundle.cpp:
      (TestWebKitAPI::ParentFrameTest::didCreatePage):
      * TestWebKitAPI/Tests/WebKit2/PasteboardNotifications.mm:
      (TestWebKitAPI::setInjectedBundleClient):
      * TestWebKitAPI/Tests/WebKit2/PasteboardNotifications_Bundle.cpp:
      (TestWebKitAPI::PasteboardNotificationsTest::didCreatePage):
      * TestWebKitAPI/Tests/WebKit2/PrivateBrowsingPushStateNoHistoryCallback.cpp:
      (TestWebKitAPI::TEST):
      * TestWebKitAPI/Tests/WebKit2/ReloadPageAfterCrash.cpp:
      (TestWebKitAPI::TEST):
      * TestWebKitAPI/Tests/WebKit2/ResizeReversePaginatedWebView.cpp:
      (TestWebKitAPI::TEST):
      * TestWebKitAPI/Tests/WebKit2/ResizeWindowAfterCrash.cpp:
      (TestWebKitAPI::TEST):
      * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly.cpp:
      (TestWebKitAPI::setInjectedBundleClient):
      (TestWebKitAPI::setPageLoaderClient):
      * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp:
      (TestWebKitAPI::setPageLoaderClient):
      * TestWebKitAPI/Tests/WebKit2/ScrollPinningBehaviors.cpp:
      (TestWebKitAPI::TEST):
      * TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem.cpp:
      (TestWebKitAPI::setPageLoaderClient):
      * TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem_Bundle.cpp:
      (TestWebKitAPI::ShouldGoToBackForwardListItemTest::didCreatePage):
      * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
      (TestWebKitAPI::TEST):
      * TestWebKitAPI/Tests/WebKit2/TerminateTwice.cpp:
      (TestWebKitAPI::TEST):
      * TestWebKitAPI/Tests/WebKit2/UserMessage.cpp:
      (TestWebKitAPI::WebKit2UserMessageRoundTripTest::setInjectedBundleClient):
      (TestWebKitAPI::WebKit2UserMessageRoundTripTest::setPageLoaderClient):
      * TestWebKitAPI/Tests/WebKit2/WKConnection.cpp:
      (TestWebKitAPI::TEST):
      * TestWebKitAPI/Tests/WebKit2/WKConnection_Bundle.cpp:
      (TestWebKitAPI::WKConnectionTest::initialize):
      * TestWebKitAPI/Tests/WebKit2/WKPageGetScaleFactorNotZero.cpp:
      (TestWebKitAPI::setPageLoaderClient):
      * TestWebKitAPI/Tests/WebKit2/WebArchive.cpp:
      (TestWebKitAPI::setInjectedBundleClient):
      (TestWebKitAPI::TEST):
      * TestWebKitAPI/Tests/WebKit2/WillLoad.cpp:
      (TestWebKitAPI::WebKit2WillLoadTest::setInjectedBundleClient):
      * TestWebKitAPI/Tests/WebKit2/WillLoad_Bundle.cpp:
      * TestWebKitAPI/Tests/WebKit2/WillSendSubmitEvent.cpp:
      (TestWebKitAPI::setInjectedBundleClient):
      * TestWebKitAPI/Tests/WebKit2/WillSendSubmitEvent_Bundle.cpp:
      (TestWebKitAPI::WillSendSubmitEventTest::didCreatePage):
      * TestWebKitAPI/Tests/WebKit2/mac/EditorCommands.mm:
      (TestWebKitAPI::TEST):
      * TestWebKitAPI/Tests/WebKit2/mac/GetBackingScaleFactor.mm:
      (TestWebKitAPI::setInjectedBundleClient):
      * TestWebKitAPI/Tests/WebKit2/mac/GetPIDAfterAbortedProcessLaunch.cpp:
      (TestWebKitAPI::TEST):
      * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme_Bundle.cpp:
      * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing_Bundle.cpp:
      (TestWebKitAPI::DenyWillSendRequestTest::didCreatePage):
      * TestWebKitAPI/Tests/WebKit2ObjC/WKRemoteObjectRegistry.mm:
      (TestWebKitAPI::didCreateConnection):
      (TestWebKitAPI::TEST):
      * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
      (TestWebKitAPI::PageVisibilityStateWithWindowChanges::initializeView):
      * TestWebKitAPI/Tests/mac/WKRemoteObjectRegistry_Bundle.mm:
      * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
      (TestWebKitAPI::setPageLoaderClient):
      * WebKitTestRunner/GeolocationProviderMock.cpp:
      (WTR::GeolocationProviderMock::GeolocationProviderMock):
      * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
      (WTR::InjectedBundle::initialize):
      * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
      (WTR::InjectedBundlePage::InjectedBundlePage):
      * WebKitTestRunner/TestController.cpp:
      (WTR::TestController::createOtherPage):
      (WTR::TestController::initialize):
      (WTR::TestController::createWebViewWithOptions):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160104 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a899664e
    • joepeck@webkit.org's avatar
      Unreviewed Windows build fix attempt 2 after r160099. · 13972079
      joepeck@webkit.org authored
      * JavaScriptCore.vcxproj/copy-files.cmd:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160103 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      13972079
    • joepeck@webkit.org's avatar
      Unreviewed Windows build fix attempt after r160099. · 11e25122
      joepeck@webkit.org authored
      * WebCore.vcxproj/WebCore.vcxproj.filters:
      * WebCore.vcxproj/copyForwardingHeaders.cmd:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160102 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      11e25122
    • commit-queue@webkit.org's avatar
      Fix build warnings in DownloadAuthenticationClient.cpp · 490934ed
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=124920
      
      Patch by Tamas Gergely <tgergely.u-szeged@partner.samsung.com> on 2013-12-04
      Reviewed by Alexey Proskuryakov.
      
      Fix unused parameter warnings in DownloadAuthenticationClient.cpp
      
      * Shared/Downloads/DownloadAuthenticationClient.cpp:
      (WebKit::DownloadAuthenticationClient::receivedCredential):
      (WebKit::DownloadAuthenticationClient::receivedRequestToContinueWithoutCredential):
      (WebKit::DownloadAuthenticationClient::receivedCancellation):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160101 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      490934ed
    • commit-queue@webkit.org's avatar
      REGRESSION (r160094): Fix lots of crashes for sh4 architecture. · efebe0f1
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=125227
      
      Patch by Julien Brianceau <jbriance@cisco.com> on 2013-12-04
      Reviewed by Michael Saboff.
      
      * llint/LowLevelInterpreter32_64.asm: Do not use t4 and t5 as they match a0 and a1.
      * offlineasm/registers.rb: Add t7, t8 and t9 in register list for sh4 port.
      * offlineasm/sh4.rb: Rearrange RegisterID list and add the missing ones.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160100 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      efebe0f1
    • joepeck@webkit.org's avatar
      Web Inspector: Push Remote Inspector debugging connection management into JavaScriptCore · d2ecf37f
      joepeck@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=124613
      
      Reviewed by Timothy Hatcher.
      
      Source/JavaScriptCore:
      
      Move the ENABLE(REMOTE_INSPECTOR) remote debugger connection management
      into JavaScriptCore (originally from WebKit/mac). Include enhancements:
      
        * allow for different types of remote debuggable targets,
          eventually at least a JSContext, WebView, WKView.
        * allow debuggables to be registered and debugged on any thread. Unlike
          WebViews, JSContexts may be run entirely off of the main thread.
        * move the remote connection (XPC connection) itself off of the main thread,
          it doesn't need to be on the main thread.
      
      Make JSContext @class and JavaScriptCore::JSContextRef
      "JavaScript" Remote Debuggables.
      
      * inspector/remote/RemoteInspectorDebuggable.h: Added.
      * inspector/remote/RemoteInspectorDebuggable.cpp: Added.
      (Inspector::RemoteInspectorDebuggable::RemoteInspectorDebuggable):
      (Inspector::RemoteInspectorDebuggable::~RemoteInspectorDebuggable):
      (Inspector::RemoteInspectorDebuggable::init):
      (Inspector::RemoteInspectorDebuggable::update):
      (Inspector::RemoteInspectorDebuggable::setRemoteDebuggingAllowed):
      (Inspector::RemoteInspectorDebuggable::info):
      RemoteInspectorDebuggable defines a debuggable target. As long as
      something creates a debuggable and is set to allow remote inspection
      it will be listed in remote debuggers. For the different types of
      debuggables (JavaScript and Web) there is different basic information
      that may be listed.
      
      * inspector/InspectorFrontendChannel.h: Added.
      (Inspector::InspectorFrontendChannel::~InspectorFrontendChannel):
      The only thing a debuggable needs for remote debugging is an
      InspectorFrontendChannel a way to send messages to a remote frontend.
      This class provides that method, and is vended to the
      RemoteInspectorDebuggable when a remote connection is setup.
      
      * inspector/remote/RemoteInspector.h: Added.
      * inspector/remote/RemoteInspector.mm: Added.
      Singleton, created at least when the first Debuggable is created.
      This class manages the list of debuggables, any connection to a
      remote debugger proxy (XPC service "com.apple.webinspector").
      
      (Inspector::dispatchAsyncOnQueueSafeForAnyDebuggable):
      (Inspector::RemoteInspector::shared):
      (Inspector::RemoteInspector::RemoteInspector):
      (Inspector::RemoteInspector::nextAvailableIdentifier):
      (Inspector::RemoteInspector::registerDebuggable):
      (Inspector::RemoteInspector::unregisterDebuggable):
      (Inspector::RemoteInspector::updateDebuggable):
      Debuggable management. When debuggables are added, removed, or updated
      we stash a copy of the debuggable information and push an update to
      debuggers. Stashing a copy of the information in the RemoteInspector
      is a thread safe way to avoid walking over all debuggables to gather
      the information when it is needed.
      
      (Inspector::RemoteInspector::start):
      (Inspector::RemoteInspector::stop):
      Runtime API to enable / disable the feature.
      
      (Inspector::RemoteInspector::listingForDebuggable):
      (Inspector::RemoteInspector::pushListingNow):
      (Inspector::RemoteInspector::pushListingSoon):
      Pushing a listing to remote debuggers.
      
      (Inspector::RemoteInspector::sendMessageToRemoteFrontend):
      (Inspector::RemoteInspector::setupXPCConnectionIfNeeded):
      (Inspector::RemoteInspector::xpcConnectionReceivedMessage):
      (Inspector::RemoteInspector::xpcConnectionFailed):
      (Inspector::RemoteInspector::xpcConnectionUnhandledMessage):
      XPC setup, send, and receive handling.
      
      (Inspector::RemoteInspector::updateHasActiveDebugSession):
      Applications being debugged may want to know when a debug
      session is active. This provides that notification.
      
      (Inspector::RemoteInspector::receivedSetupMessage):
      (Inspector::RemoteInspector::receivedDataMessage):
      (Inspector::RemoteInspector::receivedDidCloseMessage):
      (Inspector::RemoteInspector::receivedGetListingMessage):
      (Inspector::RemoteInspector::receivedIndicateMessage):
      (Inspector::RemoteInspector::receivedConnectionDiedMessage):
      Dispatching incoming remote debugging protocol messages.
      These are wrapping above the inspector protocol messages.
      
      * inspector/remote/RemoteInspectorConstants.h: Added.
      Protocol messages and dictionary keys inside the messages.
      
      (Inspector::RemoteInspectorDebuggableInfo::RemoteInspectorDebuggableInfo):
      * inspector/remote/RemoteInspectorDebuggableConnection.h: Added.
      * inspector/remote/RemoteInspectorDebuggableConnection.mm: Added.
      This is a connection between the RemoteInspector singleton and a RemoteInspectorDebuggable.
      
      (Inspector::RemoteInspectorDebuggableConnection::RemoteInspectorDebuggableConnection):
      (Inspector::RemoteInspectorDebuggableConnection::~RemoteInspectorDebuggableConnection):
      Allow for dispatching messages on JavaScript debuggables on a dispatch_queue
      instead of the main queue.
      
      (Inspector::RemoteInspectorDebuggableConnection::destination):
      (Inspector::RemoteInspectorDebuggableConnection::connectionIdentifier):
      Needed in the remote debugging protocol to identify the remote debugger.
      
      (Inspector::RemoteInspectorDebuggableConnection::dispatchSyncOnDebuggable):
      (Inspector::RemoteInspectorDebuggableConnection::dispatchAsyncOnDebuggable):
      (Inspector::RemoteInspectorDebuggableConnection::setup):
      (Inspector::RemoteInspectorDebuggableConnection::closeFromDebuggable):
      (Inspector::RemoteInspectorDebuggableConnection::close):
      (Inspector::RemoteInspectorDebuggableConnection::sendMessageToBackend):
      (Inspector::RemoteInspectorDebuggableConnection::sendMessageToFrontend):
      The connection is a thin channel between the two sides that can be closed
      from either side, so there is some logic around multi-threaded access.
      
      * inspector/remote/RemoteInspectorXPCConnection.h: Added.
      (Inspector::RemoteInspectorXPCConnection::Client::~Client):
      * inspector/remote/RemoteInspectorXPCConnection.mm: Added.
      (Inspector::RemoteInspectorXPCConnection::RemoteInspectorXPCConnection):
      (Inspector::RemoteInspectorXPCConnection::~RemoteInspectorXPCConnection):
      (Inspector::RemoteInspectorXPCConnection::close):
      (Inspector::RemoteInspectorXPCConnection::deserializeMessage):
      (Inspector::RemoteInspectorXPCConnection::handleEvent):
      (Inspector::RemoteInspectorXPCConnection::sendMessage):
      This is a connection between the RemoteInspector singleton and an XPC service
      named "com.apple.webinspector". This handles serialization of the dictionary
      messages to and from the service. The receiving is done on a non-main queue.
      
      * API/JSContext.h:
      * API/JSContext.mm:
      (-[JSContext name]):
      (-[JSContext setName:]):
      ObjC API to enable/disable JSContext remote inspection and give a name.
      
      * API/JSContextRef.h:
      * API/JSContextRef.cpp:
      (JSGlobalContextGetName):
      (JSGlobalContextSetName):
      C API to give a JSContext a name.
      
      * runtime/JSGlobalObject.cpp:
      (JSC::JSGlobalObject::setName):
      * runtime/JSGlobalObject.h:
      (JSC::JSGlobalObject::name):
      Shared handling of the APIs above.
      
      * runtime/JSGlobalObjectDebuggable.cpp: Added.
      (JSC::JSGlobalObjectDebuggable::JSGlobalObjectDebuggable):
      (JSC::JSGlobalObjectDebuggable::name):
      (JSC::JSGlobalObjectDebuggable::connect):
      (JSC::JSGlobalObjectDebuggable::disconnect):
      (JSC::JSGlobalObjectDebuggable::dispatchMessageFromRemoteFrontend):
      * runtime/JSGlobalObjectDebuggable.h: Added.
      Stub for the actual remote debugging implementation. We will push
      down the appropriate WebCore/inspector peices suitable for debugging
      just a JavaScript context.
      
      * CMakeLists.txt:
      * JavaScriptCore.xcodeproj/project.pbxproj:
      * GNUmakefile.am:
      * GNUmakefile.list.am:
      * JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
      * JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
      Update build files.
      
      Source/WebCore:
      
      Make a WebCore::Page a "Web" Remote Debuggable.
      
      * bindings/js/JSDOMGlobalObject.cpp:
      Disable JavaScript context inspection on JSGlobalObjects inside WebCore::Page's.
      
      * page/Page.cpp:
      (WebCore::Page::Page):
      (WebCore::Page::remoteInspectionAllowed):
      (WebCore::Page::setRemoteInspectionAllowed):
      (WebCore::Page::remoteInspectorInformationDidChange):
      * page/Page.h:
      * page/PageDebuggable.h:
      * page/PageDebuggable.cpp: Added.
      (WebCore::PageDebuggable::PageDebuggable):
      (WebCore::PageDebuggable::name):
      (WebCore::PageDebuggable::url):
      (WebCore::PageDebuggable::hasLocalDebugger):
      (WebCore::PageDebuggable::connect):
      (WebCore::PageDebuggable::disconnect):
      (WebCore::PageDebuggable::dispatchMessageFromRemoteFrontend):
      (WebCore::PageDebuggable::setIndicating):
      Make a page a "Web" debuggable.
      
      * GNUmakefile.list.am:
      * WebCore.exp.in:
      * WebCore.vcxproj/WebCore.vcxproj:
      * WebCore.vcxproj/WebCore.vcxproj.filters:
      * WebCore.xcodeproj/project.pbxproj:
      Misc.
      
      * inspector/InspectorClient.h:
      (WebCore::InspectorClient::indicate):
      (WebCore::InspectorClient::hideIndicate):
      Forward indicate methods to WebKit clients.
      
      * loader/FrameLoader.cpp:
      (WebCore::FrameLoader::didChangeTitle):
      (WebCore::FrameLoader::dispatchDidCommitLoad):
      Push updates when remote debuggable information like the Page's
      URL or title change.
      
      * ForwardingHeaders/inspector/InspectorFrontendChannel.h:
      * inspector/InspectorForwarding.h:
      Re-export Inspector::InspectorFrontendChannel as WebCore::InspectorFrontendChannel
      to avoid needlessly updating code all over the place.
      
      * inspector/CodeGeneratorInspectorStrings.py:
      * inspector/InspectorWorkerAgent.cpp:
      * inspector/WorkerInspectorController.cpp:
      * testing/Internals.cpp:
      Update include names.
      
      * page/ContextMenuController.cpp:
      (WebCore::ContextMenuController::populate):
      Make the "Inspect Element" context menu work correctly when there is a
      remote inspector instead of a local inspector.
      
      Source/WebKit:
      
      * WebKit.xcodeproj/project.pbxproj:
      
      Source/WebKit/blackberry:
      
      * WebCoreSupport/InspectorClientBlackBerry.h:
      
      Source/WebKit/cf:
      
      * WebCoreSupport/WebInspectorClientCF.cpp:
      (WebInspectorClient::sendMessageToFrontend):
      
      Source/WebKit/efl:
      
      * WebCoreSupport/InspectorClientEfl.h:
      
      Source/WebKit/gtk:
      
      * WebCoreSupport/InspectorClientGtk.h:
      
      Source/WebKit/ios:
      
      * WebCoreSupport/WebInspectorClientIOS.mm:
      (WebInspectorClient::WebInspectorClient):
      (WebInspectorClient::inspectorDestroyed):
      
      Source/WebKit/mac:
      
      Remove the old ENABLE(REMOTE_INSPECTOR) connection management implementation.
      
      * WebCoreSupport/WebInspectorClient.h:
      * WebCoreSupport/WebInspectorClient.mm:
      (WebInspectorClient::indicate):
      (WebInspectorClient::hideIndicate):
      Hook up WebView indication through this new path.
      
      * WebCoreSupport/WebFrameLoaderClient.mm:
      (WebFrameLoaderClient::dispatchDidReceiveTitle):
      * WebCoreSupport/WebInspectorClient.h:
      * WebCoreSupport/WebInspectorClient.mm:
      (WebInspectorClient::WebInspectorClient):
      (WebInspectorClient::inspectorDestroyed):
      * WebInspector/remote/WebInspectorClientRegistry.h: Removed.
      * WebInspector/remote/WebInspectorClientRegistry.mm: Removed.
      * WebInspector/remote/WebInspectorRelayDefinitions.h: Removed.
      * WebInspector/remote/WebInspectorRemoteChannel.h: Removed.
      * WebInspector/remote/WebInspectorRemoteChannel.mm: Removed.
      * WebInspector/remote/WebInspectorServer.h: Removed.
      * WebInspector/remote/WebInspectorServer.mm: Removed.
      * WebInspector/remote/WebInspectorServerWebViewConnection.h: Removed.
      * WebInspector/remote/WebInspectorServerWebViewConnection.mm: Removed.
      * WebInspector/remote/WebInspectorServerWebViewConnectionController.h: Removed.
      * WebInspector/remote/WebInspectorServerWebViewConnectionController.mm: Removed.
      * WebInspector/remote/WebInspectorXPCWrapper.h: Removed.
      * WebInspector/remote/WebInspectorXPCWrapper.m: Removed.
      * WebKit.exp:
      * WebView/WebView.mm:
      (-[WebView _commonInitializationWithFrameName:groupName:]):
      (+[WebView _enableRemoteInspector]):
      (+[WebView _disableRemoteInspector]):
      (+[WebView _disableAutoStartRemoteInspector]):
      (+[WebView _isRemoteInspectorEnabled]):
      (+[WebView _hasRemoteInspectorSession]):
      (-[WebView allowsRemoteInspection]):
      (-[WebView setAllowsRemoteInspection:]):
      (-[WebView setIndicatingForRemoteInspector:]):
      (-[WebView setHostApplicationBundleId:name:]):
      (-[WebView _didCommitLoadForFrame:]):
      * WebView/WebViewData.h:
      * WebView/WebViewData.mm:
      (-[WebViewPrivate init]):
      (-[WebViewPrivate dealloc]):
      * WebView/WebViewInternal.h:
      * WebView/WebViewPrivate.h:
      Remove old REMOTE_INSPECTOR.
      
      Source/WebKit/win:
      
      * WebCoreSupport/WebInspectorClient.h:
      
      Source/WebKit/wince:
      
      * WebCoreSupport/InspectorClientWinCE.h:
      
      Source/WebKit2:
      
      * WebProcess/WebPage/WebPage.cpp:
      (WebKit::WebPage::WebPage):
      * WebProcess/com.apple.WebProcess.sb.in:
      Allow the WebProcess to access the "com.apple.webinspector" named
      XPC service to expose its WebCore::Page's to remote debuggers.
      
      Source/WTF:
      
      * wtf/ios/WebCoreThread.cpp:
      * wtf/ios/WebCoreThread.h:
      Expose WebThreadRun/WebThreadRunSync iOS methods defined in WebCore through
      WTF so that JavaScriptCore can use it. Another such method already existed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160099 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d2ecf37f
    • joepeck@webkit.org's avatar
      Web Inspector: Add missing folders and files to Xcode project · 2607c676
      joepeck@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=124802
      
      Reviewed by Timothy Hatcher.
      
      * WebCore.xcodeproj/project.pbxproj:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160098 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2607c676
    • dfarler@apple.com's avatar
      Use All-iOS target when building WK2 on iOS · e7d2f698
      dfarler@apple.com authored
      <rdar://problem/15574494>
      
      Reviewed by David Kilzer.
      
      * Makefile:
      Add -target All-iOS to OTHER_OPTIONS if iphoneos or iphonesimulator
      is in the SDKROOT make option.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160097 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e7d2f698
    • commit-queue@webkit.org's avatar
      [texmap] Borders on rotating images are hidden/wrongly rendered with edge distance antialiasing · 26a7a629
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=124653
      
      Patch by José Dapena Paz <jdapena@igalia.com> on 2013-12-04
      Reviewed by Noam Rosenthal.
      
      Texture mapper edge distance antialiasing texture sampling was causing
      borders to be shaded (and made them almost disappear in some cases).
      This was because calculation of sampling happened on vertex shader, so
      the border of the texture would go to the border of the inflation area.
      
      What algorithm should do is sampling the border pixel for all the
      inflation area (it is the closest pixel to all the samples in
      inflation area), and then use the standard sampling for the other
      parts of the texture.
      
      No new test because this is already covered by test
      transforms/3d/point-mapping/3d-point-mapping.html
      
      * platform/graphics/texmap/TextureMapperShaderProgram.cpp: fix edge
      distance antialiasing texture sampling.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160096 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      26a7a629
    • mario.prada@samsung.com's avatar
      Unreviewed GTK gardening. Updated expectations for GTK and share them with EFL. · 60bce5a7
      mario.prada@samsung.com authored
      * accessibility/multiselect-list-reports-active-option-expected.txt: Renamed from LayoutTests/platform/efl/multiselect-list-reports-active-option-expected.txt.
      * platform/gtk/accessibility/multiselect-list-reports-active-option-expected.txt: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160095 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      60bce5a7
    • msaboff@apple.com's avatar
      Move the setting up of callee's callFrame from pushFrame to callToJavaScript thunk · 6f0b31aa
      msaboff@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=123999
      
      Reviewed by Filip Pizlo.
      
      Changed LLInt and/or JIT enabled ports to allocate the stack frame in the
      callToJavaScript stub.  Added an additional stub, callToNativeFunction that
      allocates a stack frame in a similar way for calling native entry points
      that take a single ExecState* argument.  These stubs are implemented
      using common macros in LowLevelInterpreter{32_64,64}.asm.  There are also
      Windows X86 and X86-64 versions in the corresponding JitStubsXX.h.
      The stubs allocate and create a sentinel frame, then create the callee's
      frame, populating  the header and arguments from the passed in ProtoCallFrame*.
      It is assumed that the caller of either stub does a check for enough stack space
      via JSStack::entryCheck().
      
      For ports using the C-Loop interpreter, the prior method for allocating stack
      frame and invoking functions is used, namely with JSStack::pushFrame() and
      ::popFrame().
      
      Made spelling changes "sentinal" -> "sentinel".
      
      * CMakeLists.txt:
      * GNUmakefile.list.am:
      * JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
      * JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
      * JavaScriptCore.xcodeproj/project.pbxproj:
      * interpreter/CachedCall.h:
      (JSC::CachedCall::CachedCall):
      (JSC::CachedCall::setThis):
      (JSC::CachedCall::setArgument):
      * interpreter/CallFrameClosure.h:
      (JSC::CallFrameClosure::resetCallFrame):
      * interpreter/Interpreter.cpp:
      (JSC::Interpreter::execute):
      (JSC::Interpreter::executeCall):
      (JSC::Interpreter::executeConstruct):
      (JSC::Interpreter::prepareForRepeatCall):
      * interpreter/Interpreter.h:
      * interpreter/JSStack.h:
      * interpreter/JSStackInlines.h:
      (JSC::JSStack::entryCheck):
      (JSC::JSStack::pushFrame):
      (JSC::JSStack::popFrame):
      * interpreter/ProtoCallFrame.cpp: Added.
      (JSC::ProtoCallFrame::init):
      * interpreter/ProtoCallFrame.h: Added.
      (JSC::ProtoCallFrame::codeBlock):
      (JSC::ProtoCallFrame::setCodeBlock):
      (JSC::ProtoCallFrame::setScope):
      (JSC::ProtoCallFrame::setCallee):
      (JSC::ProtoCallFrame::argumentCountIncludingThis):
      (JSC::ProtoCallFrame::argumentCount):
      (JSC::ProtoCallFrame::setArgumentCountIncludingThis):
      (JSC::ProtoCallFrame::setPaddedArgsCount):
      (JSC::ProtoCallFrame::clearCurrentVPC):
      (JSC::ProtoCallFrame::setThisValue):
      (JSC::ProtoCallFrame::setArgument):
      * jit/JITCode.cpp:
      (JSC::JITCode::execute):
      * jit/JITCode.h:
      * jit/JITOperations.cpp:
      * jit/JITStubs.h:
      * jit/JITStubsMSVC64.asm:
      * jit/JITStubsX86.h:
      * llint/LLIntOffsetsExtractor.cpp:
      * llint/LLIntThunks.h:
      * llint/LowLevelInterpreter.asm:
      * llint/LowLevelInterpreter32_64.asm:
      * llint/LowLevelInterpreter64.asm:
      * runtime/ArgList.h:
      (JSC::ArgList::data):
      * runtime/JSArray.cpp:
      (JSC::AVLTreeAbstractorForArrayCompare::compare_key_key):
      * runtime/StringPrototype.cpp:
      (JSC::replaceUsingRegExpSearch):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160094 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6f0b31aa
    • commit-queue@webkit.org's avatar
      Style checker for .messages.in files (WTF:: prefix) · 3edd28b6
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=125142
      
      Patch by Tamas Gergely <tgergely.u-szeged@partner.samsung.com> on 2013-12-04
      Reviewed by Anders Carlsson.
      
      A new style checker for .messages.in files, that checks for the use of WTF::
      prefix in these files. (Also checks for tabs as these files were previously
      handled as text files.)
      
      * Scripts/webkitpy/style/checker.py:
      (CheckerDispatcher._create_checker):
        New checker is returned for .messages.in files.
      * Scripts/webkitpy/style/checkers/messagesin.py: Added.
        The new style checker class.
      (MessagesInChecker):
      (MessagesInChecker.__init__):
      (MessagesInChecker.check):
      (MessagesInChecker.check_WTF_prefix):
      * Scripts/webkitpy/style/checkers/messagesin_unittest.py: Added.
        Unit test for the new style  checker class.
      (MessagesInCheckerStyleTestCase):
      (test_checker):
      (test_checker.error_handler_for_test):
      (MessagesInCheckerTestCase):
      (MessagesInCheckerTestCase.test_init):
      (MessagesInCheckerTestCase.test_init.error_handler_for_test):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160093 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3edd28b6
    • commit-queue@webkit.org's avatar
      Remove stdio.h from JSC files. · 422331b0
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=125220
      
      Patch by László Langó <lango@inf.u-szeged.hu> on 2013-12-04
      Reviewed by Michael Saboff.
      
      * interpreter/VMInspector.cpp:
      * jit/JITArithmetic.cpp:
      * jit/JITArithmetic32_64.cpp:
      * jit/JITCall.cpp:
      * jit/JITCall32_64.cpp:
      * jit/JITPropertyAccess.cpp:
      * jit/JITPropertyAccess32_64.cpp:
      * runtime/Completion.cpp:
      * runtime/IndexingType.cpp:
      * runtime/Lookup.h:
      * runtime/Operations.cpp:
      * runtime/Options.cpp:
      * runtime/RegExp.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160092 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      422331b0
    • commit-queue@webkit.org's avatar
      Avoid to add zero offset in BaseIndex. · 31f47d0a
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=125215
      
      Patch by László Langó <lango@inf.u-szeged.hu> on 2013-12-04
      Reviewed by Michael Saboff.
      
      When using cloop do not generate offsets additions for BaseIndex if the offset is zero.
      
      * offlineasm/cloop.rb:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160091 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      31f47d0a
    • commit-queue@webkit.org's avatar
      Style checker requires alphabetical ordering in cmake lists even it contains variable. · 2b3238e7
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=124918
      
      Patch by Gergo Balogh <geryxyz@inf.u-szeged.hu> on 2013-12-04
      Reviewed by Csaba Osztrogonác.
      
      * Scripts/webkitpy/style/checkers/cmake_unittest.py:
      (CMakeCheckerTest.test_check):
      * Scripts/webkitpy/style/checkers/cmake.py:
      (CMakeChecker._check_list_order):
      This will ignore lines with variable substitution.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160090 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2b3238e7
    • commit-queue@webkit.org's avatar
      Allow --cloop option to work correctly in case of EFL. · 9ac336ea
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=125217
      
      Patch by László Langó <lango@inf.u-szeged.hu> on 2013-12-04
      Reviewed by Zoltan Herczeg.
      
      * Source/cmake/OptionsEfl.cmake:
      * Source/cmake/WebKitFeatures.cmake:
      * Source/cmakeconfig.h.cmake:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160089 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9ac336ea
    • commit-queue@webkit.org's avatar
      check-webkit-style is wrong about expected format parameter pack rvalue reference arguments · fa985af8
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=124731
      
      Patch by László Langó <lango@inf.u-szeged.hu> on 2013-12-04
      Reviewed by Zoltan Herczeg.
      
      * Scripts/webkitpy/style/checkers/cpp.py:
      (check_spacing):
      * Scripts/webkitpy/style/checkers/cpp_unittest.py:
      (Cpp11StyleTest.test_rvaule_reference_in_parameter_pack):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160086 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fa985af8
    • commit-queue@webkit.org's avatar
      Remove codecs and os dependencies from filereader.py in webkitpy/style. · e6dd5d46
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=124719
      
      Although TextFileReader requires a FileSystem it circumvents it in two places!
      We should use the FileSystem only and remove codecs and os imports.
      
      Patch by László Langó <lango@inf.u-szeged.hu> on 2013-12-04
      Reviewed by Zoltan Herczeg.
      
      * Scripts/webkitpy/common/system/filesystem.py:
      (FileSystem.open_stdin): Moved from TextFileReader
      * Scripts/webkitpy/style/filereader.py:
      (TextFileReader._read_lines): use FileSystem instead of calling codecs.open directly
      (TextFileReader._process_directory): use FileSystem instead of calling os.walk directly
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160085 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e6dd5d46
    • commit-queue@webkit.org's avatar
      check-webkit-style should check member initialization indentation. · 8ef4242f
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=124820
      
      Patch by László Langó <lango@inf.u-szeged.hu> on 2013-12-04
      Reviewed by Zoltan Herczeg.
      
      check-webkit-style should check member initialization indentation
      belongs to webkit coding style:
      http://www.webkit.org/coding/coding-style.html#punctuation-member-init
      
      * Scripts/webkitpy/style/checkers/cpp.py:
      (check_member_initialization_list): Add new method to check member
      initialization list.
      (check_style): Add the call of the new method.
      (check_language): Move self initialization checking into the new method.
      (CppChecker): Add a new category for initialization list.
      * Scripts/webkitpy/style/checkers/cpp_unittest.py:
      (CppStyleTest.test_runtime_selfinit):
      (CppStyleTest.test_deprecated_cast):
      (WebKitStyleTest.test_member_initialization_list): Add new testcases for
      the new feature.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160084 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8ef4242f
    • commit-queue@webkit.org's avatar
      style-bot should reject Committer additions to committers.py · 3bd4d0ce
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=107574
      
      Patch by Tamas Gergely <gertom@inf.u-szeged.hu> on 2013-12-04
      Reviewed by Zoltan Herczeg.
      
      The style check when executed in non-interactive mode (probably by a
      bot) will raise an additional error if the contributors.json file is
      modified. Non-interactive mode information is propagated to the
      Dispatcher, which creates a special JSON checker for the
      contributors.json file.
      
      * Scripts/webkitpy/style/checker.py:
      (check_webkit_style_configuration):
      (CheckerDispatcher._create_checker):
      (CheckerDispatcher.dispatch):
      (StyleProcessorConfiguration.__init__):
      (StyleProcessor.process):
      * Scripts/webkitpy/style/checker_unittest.py:
      (CheckerDispatcherSkipTest._assert_should_skip_without_warning):
      (CheckerDispatcherDispatchTest.dispatch):
      (StyleProcessorConfigurationTest._style_checker_configuration):
      (StyleProcessor_EndToEndTest.test_init):
      (StyleProcessor_EndToEndTest.test_process):
      (StyleProcessor_CodeCoverageTest.MockDispatcher.dispatch):
      (StyleProcessor_CodeCoverageTest.setUp):
      * Scripts/webkitpy/style/checkers/jsonchecker.py:
      (JSONChecker.line_number_from_json_exception):
      (JSONContributorsChecker):
      (JSONContributorsChecker.check):
      * Scripts/webkitpy/style/error_handlers_unittest.py:
      (DefaultStyleErrorHandlerTest._style_checker_configuration):
      * Scripts/webkitpy/style/optparser.py:
      (CommandOptionValues.__init__):
      (ArgumentParser._create_option_parser):
      (ArgumentParser.parse):
      * Scripts/webkitpy/tool/commands/upload_unittest.py:
      (test_post):
      (test_upload):
      * Scripts/webkitpy/tool/steps/checkstyle.py:
      (CheckStyle.run):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160083 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3bd4d0ce
    • commit-queue@webkit.org's avatar
      Fix !ENABLE(JAVASCRIPT_DEBUGGER) build. · 2585f3b2
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=125083
      
      Patch by Peter Molnar <pmolnar.u-szeged@partner.samsung.com> on 2013-12-04
      Reviewed by Mark Lam.
      
      * debugger/Debugger.cpp:
      * debugger/Debugger.h:
      (JSC::Debugger::Debugger):
      (JSC::Debugger::needsOpDebugCallbacks):
      (JSC::Debugger::needsExceptionCallbacks):
      (JSC::Debugger::detach):
      (JSC::Debugger::sourceParsed):
      (JSC::Debugger::exception):
      (JSC::Debugger::atStatement):
      (JSC::Debugger::callEvent):
      (JSC::Debugger::returnEvent):
      (JSC::Debugger::willExecuteProgram):
      (JSC::Debugger::didExecuteProgram):
      (JSC::Debugger::didReachBreakpoint):
      * debugger/DebuggerPrimitives.h:
      * jit/JITOpcodes.cpp:
      (JSC::JIT::emit_op_debug):
      * jit/JITOpcodes32_64.cpp:
      (JSC::JIT::emit_op_debug):
      * llint/LLIntOfflineAsmConfig.h:
      * llint/LowLevelInterpreter.asm:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160082 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2585f3b2
    • ossy@webkit.org's avatar
      Typo fix after r160074 to fix debug builds. · 6cf53183
      ossy@webkit.org authored
      Patch by László Langó <lango@inf.u-szeged.hu> on 2013-12-04
      Reviewed by Csaba Osztrogonác.
      
      * platform/text/BidiResolver.h:
      (WebCore::MidpointState::stopIgnoringSpaces):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160076 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6cf53183
    • ossy@webkit.org's avatar
      [EFL][WK2] Fix build after API::Client changes · df098db7
      ossy@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=125206
      
      Patch by Nick Diego Yamane <nick.yamane@openbossa.org> on 2013-12-04
      Reviewed by Csaba Osztrogonác.
      
      Source/WebKit2:
      
      * CMakeLists.txt:
      * GNUmakefile.list.am:
      * Shared/API/c/WKDeclarationSpecifiers.h:
      * UIProcess/API/C/CoordinatedGraphics/WKView.cpp:
      (WKViewSetViewClient):
      * UIProcess/API/C/CoordinatedGraphics/WKView.h:
      * UIProcess/API/C/WKBatteryManager.cpp:
      (WKBatteryManagerSetProvider):
      * UIProcess/API/C/WKBatteryManager.h:
      * UIProcess/API/C/WKNetworkInfoManager.cpp:
      (WKNetworkInfoManagerSetProvider):
      * UIProcess/API/C/WKNetworkInfoManager.h:
      * UIProcess/API/C/WKTextChecker.cpp:
      (WKTextCheckerSetClient):
      * UIProcess/API/C/WKTextChecker.h:
      * UIProcess/API/C/WKVibration.cpp:
      (WKVibrationSetProvider):
      * UIProcess/API/C/WKVibration.h:
      * UIProcess/API/C/efl/WKPageEfl.cpp:
      (WKPageSetUIPopupMenuClient):
      * UIProcess/API/C/efl/WKPageEfl.h:
      * UIProcess/API/C/gtk/WKFullScreenClientGtk.cpp:
      (WKViewSetFullScreenClientGtk):
      * UIProcess/API/C/gtk/WKFullScreenClientGtk.h:
      * UIProcess/API/C/gtk/WKInspectorClientGtk.cpp:
      (WKInspectorSetInspectorClientGtk):
      * UIProcess/API/C/gtk/WKInspectorClientGtk.h:
      * UIProcess/API/C/soup/WKSoupRequestManager.cpp:
      (WKSoupRequestManagerSetClient):
      * UIProcess/API/C/soup/WKSoupRequestManager.h:
      * UIProcess/API/gtk/WebKitFullscreenClient.cpp:
      (attachFullScreenClientToView):
      * UIProcess/API/gtk/WebKitRequestManagerClient.cpp:
      (attachRequestManagerClientToContext):
      * UIProcess/API/gtk/WebKitTextChecker.cpp:
      (WebKitTextChecker::WebKitTextChecker):
      * UIProcess/API/gtk/WebKitWebInspector.cpp:
      (webkitWebInspectorCreate):
      * UIProcess/API/gtk/WebKitWebViewBase.cpp:
      (webkitWebViewBaseInitializeFullScreenClient):
      * UIProcess/API/gtk/WebKitWebViewBasePrivate.h:
      * UIProcess/CoordinatedGraphics/WebView.cpp:
      (WebKit::WebView::initializeClient):
      * UIProcess/CoordinatedGraphics/WebView.h:
      * UIProcess/CoordinatedGraphics/WebViewClient.cpp:
      (WebKit::WebViewClient::viewNeedsDisplay):
      (WebKit::WebViewClient::didChangeContentsSize):
      (WebKit::WebViewClient::webProcessCrashed):
      (WebKit::WebViewClient::webProcessDidRelaunch):
      (WebKit::WebViewClient::didChangeContentsPosition):
      (WebKit::WebViewClient::didRenderFrame):
      (WebKit::WebViewClient::didCompletePageTransition):
      (WebKit::WebViewClient::didChangeViewportAttributes):
      (WebKit::WebViewClient::didChangeTooltip):
      (WebKit::WebViewClient::didFindZoomableArea):
      (WebKit::WebViewClient::doneWithTouchEvent):
      * UIProcess/CoordinatedGraphics/WebViewClient.h:
      * UIProcess/WebBatteryManagerProxy.cpp:
      (WebKit::WebBatteryManagerProxy::initializeProvider):
      * UIProcess/WebBatteryManagerProxy.h:
      * UIProcess/WebBatteryProvider.cpp:
      (WebKit::WebBatteryProvider::startUpdating):
      (WebKit::WebBatteryProvider::stopUpdating):
      * UIProcess/WebBatteryProvider.h:
      * UIProcess/WebInspectorProxy.h:
      * UIProcess/WebNetworkInfoManagerProxy.cpp:
      (WebKit::WebNetworkInfoManagerProxy::initializeProvider):
      * UIProcess/WebNetworkInfoManagerProxy.h:
      * UIProcess/WebNetworkInfoProvider.cpp:
      (WebKit::WebNetworkInfoProvider::startUpdating):
      (WebKit::WebNetworkInfoProvider::stopUpdating):
      (WebKit::WebNetworkInfoProvider::bandwidth):
      (WebKit::WebNetworkInfoProvider::isMetered):
      * UIProcess/WebNetworkInfoProvider.h:
      * UIProcess/WebPageProxy.h:
      * UIProcess/WebTextChecker.cpp:
      (WebKit::WebTextChecker::setClient):
      * UIProcess/WebTextChecker.h:
      * UIProcess/WebTextCheckerClient.cpp:
      (WebKit::WebTextCheckerClient::continuousSpellCheckingAllowed):
      (WebKit::WebTextCheckerClient::continuousSpellCheckingEnabled):
      (WebKit::WebTextCheckerClient::setContinuousSpellCheckingEnabled):
      (WebKit::WebTextCheckerClient::grammarCheckingEnabled):
      (WebKit::WebTextCheckerClient::setGrammarCheckingEnabled):
      (WebKit::WebTextCheckerClient::uniqueSpellDocumentTag):
      (WebKit::WebTextCheckerClient::closeSpellDocumentWithTag):
      (WebKit::WebTextCheckerClient::checkSpellingOfString):
      (WebKit::WebTextCheckerClient::checkGrammarOfString):
      (WebKit::WebTextCheckerClient::spellingUIIsShowing):
      (WebKit::WebTextCheckerClient::toggleSpellingUIIsShowing):
      (WebKit::WebTextCheckerClient::updateSpellingUIWithMisspelledWord):
      (WebKit::WebTextCheckerClient::updateSpellingUIWithGrammarString):
      (WebKit::WebTextCheckerClient::guessesForWord):
      (WebKit::WebTextCheckerClient::learnWord):
      (WebKit::WebTextCheckerClient::ignoreWord):
      * UIProcess/WebTextCheckerClient.h:
      * UIProcess/WebVibrationProvider.cpp:
      (WebKit::WebVibrationProvider::vibrate):
      (WebKit::WebVibrationProvider::cancelVibration):
      * UIProcess/WebVibrationProvider.h:
      * UIProcess/WebVibrationProxy.cpp:
      (WebKit::WebVibrationProxy::initializeProvider):
      * UIProcess/WebVibrationProxy.h:
      * UIProcess/efl/BatteryProvider.cpp:
      (BatteryProvider::BatteryProvider):
      * UIProcess/efl/NetworkInfoProvider.cpp:
      (NetworkInfoProvider::NetworkInfoProvider):
      * UIProcess/efl/PageUIClientEfl.cpp:
      (WebKit::PageUIClientEfl::PageUIClientEfl):
      * UIProcess/efl/RequestManagerClientEfl.cpp:
      (WebKit::RequestManagerClientEfl::RequestManagerClientEfl):
      * UIProcess/efl/TextCheckerClientEfl.cpp:
      (TextCheckerClientEfl::TextCheckerClientEfl):
      * UIProcess/efl/VibrationClientEfl.cpp:
      (VibrationClientEfl::VibrationClientEfl):
      * UIProcess/efl/ViewClientEfl.cpp:
      (WebKit::ViewClientEfl::ViewClientEfl):
      * UIProcess/efl/WebPageProxyEfl.cpp:
      (WebKit::WebPageProxy::initializeUIPopupMenuClient):
      * UIProcess/efl/WebUIPopupMenuClient.cpp:
      (WebUIPopupMenuClient::showPopupMenu):
      (WebUIPopupMenuClient::hidePopupMenu):
      * UIProcess/efl/WebUIPopupMenuClient.h:
      * UIProcess/gtk/WebFullScreenClientGtk.cpp:
      (WebKit::WebFullScreenClientGtk::willEnterFullScreen):
      (WebKit::WebFullScreenClientGtk::willExitFullScreen):
      * UIProcess/gtk/WebFullScreenClientGtk.h:
      * UIProcess/gtk/WebInspectorClientGtk.cpp:
      (WebKit::WebInspectorClientGtk::openWindow):
      (WebKit::WebInspectorClientGtk::didClose):
      (WebKit::WebInspectorClientGtk::bringToFront):
      (WebKit::WebInspectorClientGtk::inspectedURLChanged):
      (WebKit::WebInspectorClientGtk::attach):
      (WebKit::WebInspectorClientGtk::detach):
      (WebKit::WebInspectorClientGtk::didChangeAttachedHeight):
      * UIProcess/gtk/WebInspectorClientGtk.h:
      * UIProcess/gtk/WebInspectorProxyGtk.cpp:
      (WebKit::WebInspectorProxy::initializeInspectorClientGtk):
      * UIProcess/soup/WebSoupRequestManagerClient.cpp:
      (WebKit::WebSoupRequestManagerClient::didReceiveURIRequest):
      (WebKit::WebSoupRequestManagerClient::didFailToLoadURIRequest):
      * UIProcess/soup/WebSoupRequestManagerClient.h:
      * UIProcess/soup/WebSoupRequestManagerProxy.cpp:
      (WebKit::WebSoupRequestManagerProxy::initializeClient):
      * UIProcess/soup/WebSoupRequestManagerProxy.h:
      
      Tools:
      
      * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive.cpp:
      (TestWebKitAPI::TEST):
      * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
      (TestWebKitAPI::setViewClient):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160075 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      df098db7
    • zoltan@webkit.org's avatar
      Move space-ignoring inline functions into MidpointState · b041160a
      zoltan@webkit.org authored
      <https://webkit.org/b/124957>
      
      Reviewed by David Hyatt.
      
      Since:
       - The following inline functions were used only with a mandatory LineMidpointState argument:
         startIgnoringSpaces, stopIgnoringSpaces, ensureLineBoxInsideIgnoredSpaces, deprecatedAddMidpoint.
       - TrailingObjects class uses these functions. Since they're inline in BreakingContextInlineHeaders.h,
         it's hard to separate TrailingObjects into it's own file. (blocks bug #124956)
       I made these functions as a member of LineMidpointState, and I also updated the call sites.
      
      No new tests, no behavior change.
      
      * platform/text/BidiResolver.h:
      (WebCore::MidpointState::startIgnoringSpaces):
      (WebCore::MidpointState::stopIgnoringSpaces):
      (WebCore::MidpointState::ensureLineBoxInsideIgnoredSpaces):
      (WebCore::MidpointState::deprecatedAddMidpoint):
      * rendering/RenderBlock.h:
      * rendering/line/BreakingContextInlineHeaders.h:
      (WebCore::TrailingObjects::updateMidpointsForTrailingBoxes):
      (WebCore::BreakingContext::handleBR):
      (WebCore::BreakingContext::handleOutOfFlowPositioned):
      (WebCore::shouldSkipWhitespaceAfterStartObject):
      (WebCore::BreakingContext::handleEmptyInline):
      (WebCore::BreakingContext::handleReplaced):
      (WebCore::ensureCharacterGetsLineBox):
      (WebCore::BreakingContext::handleText):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160074 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b041160a
    • zoltan@webkit.org's avatar
      Remove BreakingContext's friendship from RenderBlockFlow · fca9e342
      zoltan@webkit.org authored
      <https://webkit.org/b/124958>
      
      Reviewed by David Hyatt.
      
      BreakingContext uses only 2 functions from RenderBlockFlow: insertFloatingObject/positionNewFloatOnLine. I added helper
      functions to LineBreaker, what is already a friend of RenderBlockFlow, so BreakingContext doesn't need to be anymore.
      
      No new tests, no behavior change.
      
      * rendering/RenderBlockFlow.h:
      * rendering/line/BreakingContextInlineHeaders.h:
      (WebCore::BreakingContext::handleFloat):
      * rendering/line/LineBreaker.h:
      (WebCore::LineBreaker::insertFloatingObject):
      (WebCore::LineBreaker::positionNewFloatOnLine):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160073 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fca9e342
    • rniwa@webkit.org's avatar
      bgColor, setBgColor, alinkColor, setAlinkColor, and etc... on HTMLBodyElement are useless · d7a3b3ab
      rniwa@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=125208
      
      Reviewed by Antti Koivisto.
      
      Merge https://chromium.googlesource.com/chromium/blink/+/49b1eeabbbf573d5271288c66d2b566cf33a09cf
      
      These member functions of HTMLBodyElement were only used by corresponding functions in HTMLDocument
      since they had the Reflect option specified in HTMLBodyElement.idl.
      
      Removed the functions and directly called getAttribute and setAttribute in relevant functions in
      HTMLDocument. The optimization to avoid assignment is no longer needed here since we've added that
      optimization to setAttributeInternal a while ago.
      
      * html/HTMLBodyElement.cpp:
      * html/HTMLBodyElement.h:
      * html/HTMLDocument.cpp:
      (WebCore::HTMLDocument::bgColor):
      (WebCore::HTMLDocument::setBgColor):
      (WebCore::HTMLDocument::fgColor):
      (WebCore::HTMLDocument::setFgColor):
      (WebCore::HTMLDocument::alinkColor):
      (WebCore::HTMLDocument::setAlinkColor):
      (WebCore::HTMLDocument::linkColor):
      (WebCore::HTMLDocument::setLinkColor):
      (WebCore::HTMLDocument::vlinkColor):
      (WebCore::HTMLDocument::setVlinkColor):
      * html/HTMLDocument.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160072 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d7a3b3ab
  2. 03 Dec, 2013 9 commits