1. 13 May, 2008 1 commit
  2. 12 May, 2008 1 commit
    • andersca@apple.com's avatar
      WebCore: · 8990786b
      andersca@apple.com authored
      2008-05-12  Anders Carlsson  <andersca@apple.com>
      
              Reviewed by Alexey.
      
              Add ApplicationCacheStorage::empty() method which will empty
              the application cache database.
              
              * WebCore.base.exp:
              * loader/appcache/ApplicationCache.cpp:
              (WebCore::ApplicationCache::clearStorageID):
              * loader/appcache/ApplicationCache.h:
              * loader/appcache/ApplicationCacheGroup.cpp:
              (WebCore::ApplicationCacheGroup::clearStorageID):
              * loader/appcache/ApplicationCacheGroup.h:
              * loader/appcache/ApplicationCacheResource.h:
              (WebCore::ApplicationCacheResource::clearStorageID):
              * loader/appcache/ApplicationCacheStorage.cpp:
              (WebCore::ApplicationCacheStorage::empty):
              * loader/appcache/ApplicationCacheStorage.h:
      
      WebKit/mac:
      
      2008-05-12  Anders Carlsson  <andersca@apple.com>
      
              Reviewed by Alexey.
      
              Empty the application cache when changing the cache model.
              
              * WebView/WebView.mm:
              (+[WebView _setCacheModel:]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@33051 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8990786b
  3. 06 May, 2008 1 commit
    • beidson@apple.com's avatar
      WebCore: · 18ed1cdf
      beidson@apple.com authored
      2008-05-06  Brady Eidson  <beidson@apple.com>
      
              Reviewed by Darin Adler
      
              Preparation for upcoming work making LocalStorage persistent.
      
              When the application terminates, all pending local storage writes need to be
              sync'ed out to disk.
              This works n combination with platform specific code in WebKit that calls it.
      
              * WebCore.base.exp:
      
              * page/PageGroup.cpp:
              (WebCore::PageGroup::closeLocalStorage): Close all open LocalStorage objects
              * page/PageGroup.h:
      
              * storage/LocalStorage.cpp:
              (WebCore::LocalStorage::close): Placeholder for what will sync and terminate the
                local storage thread in the future.
              * storage/LocalStorage.h:
      
      WebKit/mac:
      
      2008-05-06  Brady Eidson  <beidson@apple.com>
      
              Reviewed by Darin Adler
      
              Preparation for upcoming work making LocalStorage persistent.
      
              When the application terminates, all LocalStorage areas must be sync'ed out to disk first.
      
              * WebView/WebView.mm:
              (+[WebView _applicationWillTerminate]):  Close all LocalStorage areas before quitting.
      
      WebKit/win:
      
      2008-05-06  Brady Eidson  <beidson@apple.com>
      
              Reviewed by Darin Adler
      
              Preparation for upcoming work making LocalStorage persistent.
      
              When the application terminates, all LocalStorage areas must be sync'ed out to disk first.
      
              * WebKitDLL.cpp:
              (shutDownWebKit): Close all LocalStorage areas before quitting.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32906 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      18ed1cdf
  4. 05 May, 2008 2 commits
    • justin.garcia@apple.com's avatar
      WebCore: · 692743d4
      justin.garcia@apple.com authored
      2008-05-05  Justin Garcia  <justin.garcia@apple.com>
      
              Reviewed by Darin.
      
              <rdar://problem/5865171> REGRESSION: Creating a new quote places caret at beginning of quote instead of the end
              
              Disable Range mutation on document modifications in Tiger and Leopard Mail,
              since they do their own mutation which interferes with ours.
      
              * WebCore.base.exp:
              * dom/Document.cpp:
              (WebCore::Document::nodeChildrenChanged):
              (WebCore::Document::nodeWillBeRemoved):
              (WebCore::Document::textInserted):
              (WebCore::Document::textRemoved):
              (WebCore::Document::textNodesMerged):
              (WebCore::Document::textNodeSplit):
              * page/Settings.cpp:
              (WebCore::Settings::Settings):
              (WebCore::Settings::disableRangeMutationForOldAppleMail):
              * page/Settings.h:
              (WebCore::Settings::rangeMutationDisabledForOldAppleMail):
      
      WebKit/mac:
      
      2008-05-05  Justin Garcia  <justin.garcia@apple.com>
      
              Reviewed by Darin.
              
              <rdar://problem/5865171> REGRESSION: Creating a new quote places caret at beginning of quote instead of the end
      
              * WebView/WebView.mm:
              (-[WebView _updateSettingsFromPreferences:]): Disable Range mutation on changes to
              the document for Tiger and Leopard Mail.  There is code in Mail that does it, and
              the two interfere.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32883 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      692743d4
    • darin@apple.com's avatar
      2008-05-05 Darin Adler <darin@apple.com> · eb1d25fa
      darin@apple.com authored
              Reviewed by Mitz.
      
              - https://bugs.webkit.org/show_bug.cgi?id=18789
                fix some shouldCloseWithWindow edge cases
      
              * WebView/WebView.mm:
              (-[WebView viewWillMoveToWindow:]): Fix bug where we would stop observing the
              NSWindowWillCloseNotification if the view was moved out of the window but still
              had that window set as the host window. Also make sure this function doesn't do
              anything if the WebView is already closed.
              (-[WebView setHostWindow:]): Ditto.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32874 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      eb1d25fa
  5. 30 Apr, 2008 2 commits
  6. 29 Apr, 2008 2 commits
    • ddkilzer@apple.com's avatar
      JavaScriptCore: · 8fe65866
      ddkilzer@apple.com authored
      2008-04-29  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin.
      
              Wrapped Dashboard code with ENABLE(DASHBOARD_SUPPORT)
      
              * wtf/Platform.h:
      
      WebCore:
      
      2008-04-29  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin.
      
              Wrapped Dashboard code with ENABLE(DASHBOARD_SUPPORT)
      
              * DerivedSources.make:
              * WebCore.DashboardSupport.exp: Added.
              * WebCore.base.exp:
              * WebCore.xcodeproj/project.pbxproj:
              * bindings/js/JSDOMWindowCustom.cpp:
              (WebCore::JSDOMWindow::setLocation):
              * css/CSSComputedStyleDeclaration.cpp:
              (WebCore::):
              (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
              * css/CSSParser.cpp:
              (WebCore::CSSParser::parseValue):
              * css/CSSPrimitiveValue.cpp:
              (WebCore::CSSPrimitiveValue::cleanup):
              (WebCore::CSSPrimitiveValue::cssText):
              * css/CSSPropertyNames.in:
              * css/CSSStyleSelector.cpp:
              (WebCore::CSSStyleSelector::applyProperty):
              * css/DashboardRegion.h:
              * css/DashboardSupportCSSPropertyNames.in: Added.
              * dom/DOMImplementation.cpp:
              (WebCore::DOMImplementation::createDocument):
              * dom/Document.cpp:
              (WebCore::Document::Document):
              (WebCore::Document::importNode):
              * dom/Document.h:
              * html/CanvasRenderingContext2D.cpp:
              (WebCore::CanvasRenderingContext2D::fill):
              (WebCore::CanvasRenderingContext2D::stroke):
              (WebCore::CanvasRenderingContext2D::clip):
              * html/CanvasRenderingContext2D.h:
              * html/HTMLCanvasElement.cpp:
              * html/HTMLCanvasElement.h:
              * page/Chrome.cpp:
              * page/ChromeClient.h:
              * page/Frame.cpp:
              (WebCore::Frame::paint):
              * page/Frame.h:
              * page/FrameView.cpp:
              (WebCore::FrameView::layout):
              * page/FrameView.h:
              * page/Settings.cpp:
              (WebCore::Settings::Settings):
              * page/Settings.h:
              * page/mac/EventHandlerMac.mm:
              (WebCore::EventHandler::needsKeyboardEventDisambiguationQuirks):
              * page/mac/FrameMac.mm:
              * page/mac/WebDashboardRegion.h:
              * page/mac/WebDashboardRegion.m:
              * rendering/RenderLayer.cpp:
              (WebCore::RenderLayer::scrollToOffset):
              (WebCore::RenderLayer::setHasHorizontalScrollbar):
              (WebCore::RenderLayer::setHasVerticalScrollbar):
              (WebCore::RenderLayer::updateScrollInfoAfterLayout):
              * rendering/RenderObject.cpp:
              (WebCore::RenderObject::setStyle):
              * rendering/RenderObject.h:
              * rendering/RenderStyle.cpp:
              (WebCore::StyleRareNonInheritedData::operator==):
              (WebCore::RenderStyle::diff):
              * rendering/RenderStyle.h:
              * xml/XMLHttpRequest.cpp:
              (WebCore::XMLHttpRequest::send):
              (WebCore::XMLHttpRequest::setRequestHeader):
      
      WebKit/mac:
      
      2008-04-29  Greg Bolsinga  <bolsinga@apple.com>
      
              Reviewed by Darin.
      
              Wrapped Dashboard code with ENABLE(DASHBOARD_SUPPORT)
      
              * WebCoreSupport/WebChromeClient.h:
              * WebCoreSupport/WebChromeClient.mm:
              * WebView/WebClipView.m:
              (-[WebClipView scrollWheel:]):
              * WebView/WebHTMLView.mm:
              (-[WebHTMLView addMouseMovedObserver]):
              (-[WebHTMLView removeMouseMovedObserver]):
              (-[WebHTMLView acceptsFirstMouse:]):
              * WebView/WebUIDelegatePrivate.h:
              * WebView/WebView.mm:
              (-[WebViewPrivate init]):
              * WebView/WebViewPrivate.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32700 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8fe65866
    • rwlbuis@webkit.org's avatar
      Reviewed by Maciej. · 7bd5cb94
      rwlbuis@webkit.org authored
              Build fix for Tiger.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32672 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7bd5cb94
  7. 28 Apr, 2008 2 commits
    • andersca@apple.com's avatar
      WebCore: · 321e25f7
      andersca@apple.com authored
      2008-04-28  Anders Carlsson  <andersca@apple.com>
      
              Reviewed by Sam, Mark, Adele and Darin.
      
              Add a (currently not called) method for opening the application cache database.
              
              * WebCore.base.exp:
              * loader/appcache/ApplicationCacheStorage.cpp:
              (WebCore::ApplicationCacheStorage::setCacheDirectory):
              (WebCore::ApplicationCacheStorage::openDatabase):
              * loader/appcache/ApplicationCacheStorage.h:
      
      WebKit/mac:
      
      2008-04-28  Anders Carlsson  <andersca@apple.com>
      
              Reviewed by Sam, Mark, Adele and Darin.
      
              Initialize the application cache path.
              
              * WebView/WebView.mm:
              (WebKitInitializeApplicationCachePathIfNecessary):
              (-[WebView _commonInitializationWithFrameName:groupName:]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32665 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      321e25f7
    • ap@webkit.org's avatar
      Reviewed by Darin. · fb85140b
      ap@webkit.org authored
              Fix run-webkit-tests --threading
              and provisionally fix <https://bugs.webkit.org/show_bug.cgi?id=18661>
              Proxy server issue in Sunday's Nightly
      
              Changed ClassInfo objects for built-in objects to hold a getter function returning
              a per-thread instance. This makes it safe to share these ClassInfo objects between threads -
              and these are the only ones that need to be shared.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32652 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fb85140b
  8. 25 Apr, 2008 1 commit
    • andersca@apple.com's avatar
      WebCore: · c3a561b4
      andersca@apple.com authored
      2008-04-25  Anders Carlsson  <andersca@apple.com>
      
              Reviewed by Sam.
      
              Add and honor offlineWebApplicationCacheEnabled setting.
              
              * WebCore.base.exp:
              * loader/DocumentLoader.cpp:
              (WebCore::DocumentLoader::scheduleApplicationCacheLoad):
              * loader/MainResourceLoader.cpp:
              (WebCore::MainResourceLoader::load):
              * loader/appcache/ApplicationCacheGroup.cpp:
              (WebCore::ApplicationCacheGroup::selectCache):
              (WebCore::ApplicationCacheGroup::selectCacheWithoutManifestURL):
              * page/Settings.cpp:
              (WebCore::Settings::Settings):
              (WebCore::Settings::setOfflineWebApplicationCacheEnabled):
              * page/Settings.h:
              (WebCore::Settings::offlineWebApplicationCacheEnabled):
      
      WebKit/mac:
      
      2008-04-25  Anders Carlsson  <andersca@apple.com>
      
              Reviewed by Sam.
      
              Add offlineWebApplicationCacheEnabled preference.
              
              * WebView/WebPreferenceKeysPrivate.h:
              * WebView/WebPreferences.m:
              (+[WebPreferences initialize]):
              (-[WebPreferences offlineWebApplicationCacheEnabled]):
              (-[WebPreferences setOfflineWebApplicationCacheEnabled:]):
              * WebView/WebPreferencesPrivate.h:
              * WebView/WebView.mm:
              (-[WebView _updateSettingsFromPreferences:]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32581 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c3a561b4
  9. 24 Apr, 2008 3 commits
    • beidson@apple.com's avatar
      2008-04-24 Brady Eidson <beidson@apple.com> · d8d918a9
      beidson@apple.com authored
              Reviewed by Darin
      
              Fix layout test regressions from my earlier preferences/settings tweak.
      
              * WebView/WebView.mm:
              (-[WebView _commonInitializationWithFrameName:groupName:]): Even if we're not posting
                the notification to update the settings, each WebView still needs to register for the
                notification - restore that behavior.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32518 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d8d918a9
    • beidson@apple.com's avatar
      ../mac: · c79612e4
      beidson@apple.com authored
      2008-04-24  Brady Eidson  <beidson@apple.com>
      
              Reviewed by Darin
      
              Rework the Settings population again.
      
              * WebView/WebView.mm:
              (-[WebView _updateSettingsFromPreferences:]): This method is called both from _preferencesChangedNotification
                and directly from WebView's common init function.
              (-[WebView _preferencesChangedNotification:]):
              (-[WebView _commonInitializationWithFrameName:groupName:]): Call _updateSettingsFromPreferences immediately
                after creating the new Page
      
      ../win:
      
      2008-04-24  Brady Eidson  <beidson@apple.com>
      
              Reviewed by Darin
      
              Revert my previous change to WebKit/Win until I can make it act more like the new Mac code
      
              * WebView.cpp:
              (WebView::initWithFrame):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32505 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c79612e4
    • beidson@apple.com's avatar
      ../mac: · 3328a4eb
      beidson@apple.com authored
      2008-04-23  Brady Eidson  <beidson@apple.com>
      
              Reviewed by Sam Weinig
      
              In some current work I noticed that when a new Page is created, it is possible that it requires info from its Settings
              object before the Settings object is initialized.  It seems quite prudent to post the preferences changed notification,
              thereby populating the Settings object, immediately after the Page is created.
      
              * WebView/WebView.mm:
              (-[WebView _commonInitializationWithFrameName:groupName:]): Post the notification right after the Page is created
      
      ../win:
      
      2008-04-23  Brady Eidson  <beidson@apple.com>
      
              Reviewed by Sam Weinig
      
              In some current work I noticed that when a new Page is created, it is possible that it requires info from its Settings
              object before the Settings object is initialized.  It seems quite prudent to post the preferences changed notification,
              thereby populating the Settings object, immediately after the Page is created.
      
              * WebView.cpp:
              (WebView::initWithFrame): Post the notification right after the Page is created
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32491 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3328a4eb
  10. 20 Apr, 2008 1 commit
  11. 19 Apr, 2008 1 commit
    • beidson@apple.com's avatar
      WebCore: · b2da40e5
      beidson@apple.com authored
      2008-04-19  Brady Eidson  <beidson@apple.com>
      
              Reviewed by Tim Hatcher
      
              Add LocalStorageDatabasePath to the settings for the location of persistent local storage.
      
              * WebCore.base.exp:
      
              * page/Settings.cpp:
              (WebCore::Settings::setLocalStorageDatabasePath):
              * page/Settings.h:
              (WebCore::Settings::localStorageDatabasePath):
      
      WebKit/mac:
      
      2008-04-19  Brady Eidson  <beidson@apple.com>
      
              Reviewed by Tim Hatcher
      
              Add a WebPreference for the path of the local storage persistent store.
      
              * WebView/WebPreferenceKeysPrivate.h:
      
              * WebView/WebPreferences.m:
              (-[WebPreferences _localStorageDatabasePath]):
              (-[WebPreferences _setLocalStorageDatabasePath:]):
              * WebView/WebPreferencesPrivate.h:
      
              * WebView/WebView.mm:
              (-[WebView _preferencesChangedNotification:]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32261 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b2da40e5
  12. 18 Apr, 2008 1 commit
    • beidson@apple.com's avatar
      WebKit/mac: · 4f2ba97f
      beidson@apple.com authored
      2008-04-18  Brady Eidson  <beidson@apple.com>
      
              Reviewed by Sam Weinig
      
              Don't clear the PageGroup on _close, as the WebCore::Page destructor already does this.
              No reason to do the work twice...
      
              * WebView/WebView.mm:
              (-[WebView _close]):
      
      WebKit/win:
      
      2008-04-18  Brady Eidson  <beidson@apple.com>
      
              Reviewed by Sam Weinig
      
              Don't clear the PageGroup on _close, as the WebCore::Page destructor already does this.
              No reason to do the work twice...
      
              * WebView.cpp:
              (WebView::close):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32241 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4f2ba97f
  13. 15 Apr, 2008 1 commit
    • beidson@apple.com's avatar
      2008-04-15 Brady Eidson <beidson@apple.com> · 69fa075b
      beidson@apple.com authored
              Reviewed by John Sullivan
      
              Do a more complete job adding the "WebArchiveDebugMode" pref
      
              * WebView/WebPreferences.m: Add both getter *and* setter
              (-[WebPreferences webArchiveDebugModeEnabled]):
              (-[WebPreferences setWebArchiveDebugModeEnabled:]):
              * WebView/WebPreferencesPrivate.h:
      
              * WebView/WebView.mm:
              (-[WebView _preferencesChangedNotification:]): Call the renamed getter
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31911 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      69fa075b
  14. 14 Apr, 2008 1 commit
    • beidson@apple.com's avatar
      WebCore: · af2e011f
      beidson@apple.com authored
      2008-04-14  Brady Eidson  <beidson@apple.com>
      
              Reviewed by Anders
      
              Add a hidden pref to debug WebArchive loading.  With this pref on, when loading a WebArchive,
              if the resource isn't in the ArchiveResourceCollection, the loader will not fall back to the 
              network and will instead fail the load as "cancelled."
      
              * loader/ResourceLoader.cpp:
              (WebCore::ResourceLoader::load): Do the check here.
      
              * page/Settings.cpp:
              (WebCore::Settings::Settings):
              (WebCore::Settings::setWebArchiveDebugModeEnabled):
              * page/Settings.h:
              (WebCore::Settings::webArchiveDebugModeEnabled):
      
      WebKit/mac:
      
      2008-04-14  Brady Eidson  <beidson@apple.com>
      
              Reviewed by Anders
      
              Add a hidden pref to debug WebArchive loading.  With this pref on, when loading a WebArchive,
              if the resource isn't in the ArchiveResourceCollection, the loader will not fall back to the 
              network and will instead fail the load as "cancelled."
      
              * WebView/WebPreferenceKeysPrivate.h:
      
              * WebView/WebPreferences.m:
              (+[WebPreferences initialize]):
              (-[WebPreferences _webArchiveDebugModeEnabled]):
              * WebView/WebPreferencesPrivate.h:
      
              * WebView/WebView.mm:
              (-[WebView _preferencesChangedNotification:]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31892 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      af2e011f
  15. 18 Mar, 2008 1 commit
    • hyatt@apple.com's avatar
      2008-03-18 David Hyatt <hyatt@apple.com> · 7b76efe9
      hyatt@apple.com authored
              Add support for a preference in WebKit that can be used in nightly builds to test full page
              zoom.
      
              Reviewed by Antti
      
              * WebView/WebPreferenceKeysPrivate.h:
              * WebView/WebView.mm:
              (-[WebView setTextSizeMultiplier:]):
              (-[WebView canMakeTextSmaller]):
              (-[WebView makeTextSmaller:]):
              (-[WebView canMakeTextLarger]):
              (-[WebView makeTextLarger:]):
              (-[WebView canMakeTextStandardSize]):
              (-[WebView makeTextStandardSize:]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31134 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7b76efe9
  16. 13 Mar, 2008 1 commit
    • darin@apple.com's avatar
      Reviewed by John Sullivan. · 3a57fbbd
      darin@apple.com authored
              - cleanup after removing the bridge
      
              * DOM/WebDOMOperations.mm:
              (-[DOMDocument URLWithAttributeString:]): Call computeURL directly.
      
              * Misc/WebCoreStatistics.mm:
              (-[WebFrame renderTreeAsExternalRepresentation]): Call externalRepresentation directly.
      
              * Plugins/WebBaseNetscapePluginView.mm:
              (-[WebBaseNetscapePluginView loadPluginRequest:]): Use core function instead of
              _frameLoader method.
              (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
              Ditto.
              * Plugins/WebPluginController.mm:
              (-[WebPluginController webPlugInContainerLoadRequest:inFrame:]): Ditto.
      
              * WebCoreSupport/WebFrameLoaderClient.mm:
              (WebFrameLoaderClient::frameLoaderDestroyed): Added a call to the new _clearCoreFrame
              method. Without this we could leave a stale frame pointer around.
              (WebFrameLoaderClient::dispatchDidReceiveIcon): Rewrote assertion so it's not the single
              caller of the _isMainFrame method.
              (WebFrameLoaderClient::transitionToCommittedForNewPage): Use core function instead of
              _frameLoader method.
              (WebFrameLoaderClient::createFrame): Moved code here from _addChild.
      
              * WebView/WebFrame.mm: Removed lots of methods. Some were moved elsewhere, others
              turned out to be unused.
              (core): Added overload for DocumentFragment.
              (kit): Ditto.
              (-[WebFrame _loadURL:referrer:intoChild:]): Get to Frame using _private->coreFrame and
              to FrameLoader with _private->coreFrame->loader().
              (-[WebFrame _attachScriptDebugger]): Ditto.
              (-[WebFrame _clearCoreFrame]): Added.
              (-[WebFrame _updateBackground]): More of the same.
              (-[WebFrame _unmarkAllBadGrammar]): Ditto.
              (-[WebFrame _unmarkAllMisspellings]): Ditto.
              (-[WebFrame _hasSelection]): Ditto.
              (-[WebFrame _atMostOneFrameHasSelection]): Ditto.
              (-[WebFrame _findFrameWithSelection]): Ditto.
              (-[WebFrame _dataSource]): Ditto.
              (-[WebFrame _addData:]): Streamlined code a bit.
              (-[WebFrame _replaceSelectionWithText:selectReplacement:smartReplace:]): Ditto.
              (-[WebFrame _receivedData:textEncodingName:]): Ditto.
              (-[WebFrame _isDescendantOfFrame:]): Ditto.
              (-[WebFrame _bodyBackgroundColor]): Ditto.
              (-[WebFrame _isFrameSet]): Ditto.
              (-[WebFrame _firstLayoutDone]): Ditto.
              (-[WebFrame _loadType]): Ditto.
              (-[WebFrame _isDisplayingStandaloneImage]): Ditto.
              (-[WebFrame name]): Ditto.
              (-[WebFrame DOMDocument]): Ditto.
              (-[WebFrame frameElement]): Ditto.
              (-[WebFrame provisionalDataSource]): Ditto.
              (-[WebFrame dataSource]): Ditto.
              (-[WebFrame loadRequest:]): Ditto.
              (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]): Ditto.
              (-[WebFrame loadArchive:]): Ditto.
              (-[WebFrame stopLoading]): Ditto.
              (-[WebFrame reload]): Ditto.
              (-[WebFrame findFrameNamed:]): Ditto.
              (-[WebFrame parentFrame]): Ditto.
              (-[WebFrame childFrames]): Ditto.
              (-[WebFrame windowObject]): Ditto.
              (-[WebFrame globalContext]): Ditto.
      
              * WebView/WebFrameInternal.h: Added overloads of core and kit.
              Removed method declarations.
      
              * WebView/WebHTMLRepresentation.mm:
              (-[WebHTMLRepresentation documentSource]): Moved code here from WebFrame.
              (formElementFromDOMElement): Ditto.
              (-[WebHTMLRepresentation elementWithName:inForm:]): Ditto.
              (inputElementFromDOMElement): Ditto.
              (-[WebHTMLRepresentation elementDoesAutoComplete:]): Ditto.
              (-[WebHTMLRepresentation elementIsPassword:]): Ditto.
              (-[WebHTMLRepresentation formForElement:]): Ditto.
              (-[WebHTMLRepresentation currentForm]): Ditto.
              (-[WebHTMLRepresentation controlsInForm:]): Ditto.
              (-[WebHTMLRepresentation searchForLabels:beforeElement:]): Ditto.
              (-[WebHTMLRepresentation matchLabels:againstElement:]): Ditto.
      
              * WebView/WebHTMLView.mm:
              (-[WebHTMLView _frameOrBoundsChanged]): Moved sendScrollEvent code here from WebFrame.
              (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
              Call createFragmentFromText directly instead of via WebFrame.
              (-[WebHTMLView layoutToMinimumPageWidth:maximumPageWidth:adjustingViewSize:]):
              Moved layout calls here from WebFrame.
              (-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]): Ditto.
              (-[WebHTMLView _updateFontPanel]): Ditto, but with fontForSelection.
              (-[WebHTMLView _canSmartCopyOrDelete]): Ditto, but with selectionGranularity.
              (-[WebHTMLView markedRange]): Moved code here from _markedTextNSRange.
              (-[WebHTMLView attributedSubstringFromRange:]): Tweaked code a bit.
              (-[WebHTMLView searchFor:direction:caseSensitive:wrap:startInSelection:]):
              Moved code here from WebFrame.
              (-[WebHTMLView elementAtPoint:allowShadowContent:]): Ditto.
              (-[WebHTMLView markAllMatchesForText:caseSensitive:limit:]): Ditto.
              (-[WebHTMLView setMarkedTextMatchesAreHighlighted:]): Ditto.
              (-[WebHTMLView markedTextMatchesAreHighlighted]): Ditto.
              (-[WebHTMLView unmarkAllTextMatches]): Ditto.
              (-[WebHTMLView rectsForTextMatches]): Ditto.
      
              * WebView/WebHTMLViewInternal.h: Removed unused method declarations.
      
              * WebView/WebPDFView.mm:
              (-[WebPDFView PDFViewWillClickOnLink:withURL:]): Use core function instead of
              _frameLoader method.
      
              * WebView/WebRenderNode.mm:
              (copyRenderNode): Moved code here from WebFrame.
              (-[WebRenderNode initWithWebFrameView:]): Ditto.
      
              * WebView/WebResource.mm:
              (-[WebResource _stringValue]): Moved code here from WebFrame.
      
              * WebView/WebView.mm:
              (-[WebView _close]): Use core function intsead of _frameLoader method.
              (-[WebView setCustomTextEncodingName:]): Ditto.
              (-[WebView setHostWindow:]): Moved code here from WebFrame.
              (aeDescFromJSValue): Moved this here from WebFrame.
              (-[WebView aeDescByEvaluatingJavaScriptFromString:]): Moved code here from WebFrame.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31028 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3a57fbbd
  17. 12 Mar, 2008 3 commits
    • darin@apple.com's avatar
      WebCore: · b46f9fdd
      darin@apple.com authored
              Reviewed by Anders.
      
              - http://bugs.webkit.org/show_bug.cgi?id=17640
                eliminate WebCoreFrameBridge
      
              * WebCore.base.exp: Added more exports, needed by code moved from WebCoreFrameBridge
              to WebFrame in WebKit.
              * WebCore.xcodeproj/project.pbxproj: Added more headers, same reason. Also deleted
              WebCoreFrameBridge.h and WebCoreFrameBridge.mm.
      
              * page/Frame.cpp:
              (WebCore::Frame::Frame): Added call to initJavaJSBindings(), formerly handled by
              the WebCoreFrameBridge.
              * page/Frame.h: Added initJavaJSBindings function.
      
              * page/mac/FrameMac.mm:
              (WebCore::updateRenderingForBindings): Moved here from WebCoreFrameBridge.
              (WebCore::Frame::initJavaJSBindings): Ditto; code was in the init function.
      
              * page/mac/WebCoreFrameBridge.h: Removed.
              * page/mac/WebCoreFrameBridge.mm: Removed.
      
      WebKit:
      
              Reviewed by Anders.
      
              - http://bugs.webkit.org/show_bug.cgi?id=17640
                eliminate WebCoreFrameBridge
      
              * StringsNotToBeLocalized.txt: Updated for recent changes.
              * WebKit.xcodeproj/project.pbxproj: Removed WebFrameBridge.h and WebFrameBridge.mm.
      
      WebKit/mac:
      
              Reviewed by Anders.
      
              - http://bugs.webkit.org/show_bug.cgi?id=17640
                eliminate WebCoreFrameBridge
      
              Moved all the code from the bridge into WebFrame. This need not be the final
              home of these methods -- they can be moved closer to their callers and improved
              further -- but it eliminates the bridge without requiring a rewrite of the code.
              It's a fairly mechanical process (just adding underscores to method names really).
      
              There's even a chance that some of the methods are unused. Those we can remove
              after checking if that's so.
      
              * DOM/WebDOMOperations.mm:
              (-[DOMNode markupString]): Use WebFrame rather than bridge.
              (-[DOMDocument webFrame]): Changed to use the core and kit functions
              instead of using the bridge.
              (-[DOMDocument URLWithAttributeString:]): Use WebFrame rather than bridge.
              (-[DOMRange markupString]): Ditto.
              * DOM/WebDOMOperationsPrivate.h: Removed _bridge methods.
      
              * DefaultDelegates/WebDefaultContextMenuDelegate.mm: Removed unneeded import.
              * History/WebHistoryItem.mm: Ditto.
      
              * MigrateHeaders.make: Added DOMDocumentFragmentInternal.h.
              * Misc/WebCoreStatistics.mm:
              (-[WebFrame renderTreeAsExternalRepresentation]): Use WebFrame rather than bridge.
      
              * Misc/WebElementDictionary.mm: Removed unneeded import.
      
              * Misc/WebKitStatistics.m:
              (+[WebKitStatistics bridgeCount]): Removed WebBridgeCount and just return 0.
              * Misc/WebKitStatisticsPrivate.h: Ditto.
      
              * Misc/WebNSAttributedStringExtras.mm: Removed unneeded import.
              * Misc/WebNSPasteboardExtras.mm: Ditto.
      
              * Plugins/WebBaseNetscapePluginView.mm:
              (-[WebBaseNetscapePluginView evaluateJavaScriptPluginRequest:]): Use WebFrame
              rather than bridge.
      
              * Plugins/WebNetscapePluginEmbeddedView.mm: Removed unneeded import.
              * Plugins/WebNetscapePluginStream.mm: Ditto.
      
              * Plugins/WebPluginContainerCheck.mm:
              (-[WebPluginContainerCheck _isForbiddenFileLoad]): Use WebFrame rather than
              bridge to get to the WebCore::Frame.
      
              * Plugins/WebPluginController.h: Declare webFrame method and remove bridge method.
              * Plugins/WebPluginController.mm:
              (-[WebPluginController webPlugInContainerLoadRequest:inFrame:]): Use WebFrame
              rather than bridge.
      
              * WebCoreSupport/WebEditorClient.mm:
              (selectorForKeyEvent): Tweaked comment.
      
              * WebCoreSupport/WebFrameBridge.h: Removed.
              * WebCoreSupport/WebFrameBridge.mm: Removed.
      
              * WebCoreSupport/WebFrameLoaderClient.mm:
              (WebFrameLoaderClient::frameLoaderDestroyed): Removed bridge assertion.
              (WebFrameLoaderClient::detachedFromParent4): Removed bridge teardown code.
              I could remove this function entirely, but it looks like the Qt port is using it.
      
              * WebCoreSupport/WebViewFactory.mm: Removed unneeded import.
      
              * WebView/WebArchiver.mm:
              (+[WebArchiver archiveRange:]): Use WebFrame rather than bridge.
              (+[WebArchiver archiveNode:]): Ditto.
              (+[WebArchiver archiveSelectionInFrame:]): Ditto.
      
              * WebView/WebDataSource.mm:
              (-[WebDataSource _replaceSelectionWithArchive:selectReplacement:]): Ditto.
              (-[WebDataSource _documentFragmentWithArchive:]): Ditto.
              (-[WebDataSource subresources]): Ditto.
              (-[WebDataSource subresourceForURL:]): Ditto.
      
              * WebView/WebDataSourceInternal.h: Removed _bridge method.
      
              * WebView/WebFrame.mm:
              (-[WebFramePrivate dealloc]): Removed code to release the bridge.
              (core): Go directly to the core frame, not via the bridge.
              (+[WebFrame _createFrameWithPage:frameName:frameView:ownerElement:]):
              Remove the code to deal with the bridge.
              (-[WebFrame _initWithWebFrameView:webView:]): Ditto. Also added code to set the
              shouldCreateRenderers flag, formerly on the bridge.
              (-[WebFrame _updateBackground]): Change to call mehods on self, not bridge.
              (aeDescFromJSValue): Moved here from bridge.
              (-[WebFrame _domain]): Ditto.
              (-[WebFrame _addData:]): Ditto.
              (-[WebFrame _stringWithDocumentTypeStringAndMarkupString:]): Ditto.
              (-[WebFrame _nodesFromList:]): Ditto.
              (-[WebFrame _markupStringFromNode:nodes:]): Ditto.
              (-[WebFrame _markupStringFromRange:nodes:]): Ditto.
              (-[WebFrame _selectedString]): Ditto.
              (-[WebFrame _stringForRange:]): Ditto.
              (-[WebFrame _forceLayoutAdjustingViewSize:]): Ditto.
              (-[WebFrame _forceLayoutWithMinimumPageWidth:maximumPageWidth:adjustingViewSize:]): Ditto.
              (-[WebFrame _sendScrollEvent]): Ditto.
              (-[WebFrame _drawRect:]): Ditto.
              (-[WebFrame _computePageRectsWithPrintWidthScaleFactor:printHeight:]): Ditto.
              (-[WebFrame _adjustPageHeightNew:top:bottom:limit:]): Ditto.
              (-[WebFrame _copyRenderNode:copier:]): Ditto.
              (-[WebFrame _copyRenderTree:]): Ditto.
              (inputElementFromDOMElement): Ditto.
              (formElementFromDOMElement): Ditto.
              (-[WebFrame _elementWithName:inForm:]): Ditto.
              (-[WebFrame _elementDoesAutoComplete:]): Ditto.
              (-[WebFrame _elementIsPassword:]): Ditto.
              (-[WebFrame _formForElement:]): Ditto.
              (-[WebFrame _currentForm]): Ditto.
              (-[WebFrame _controlsInForm:]): Ditto.
              (-[WebFrame _searchForLabels:beforeElement:]): Ditto.
              (-[WebFrame _matchLabels:againstElement:]): Ditto.
              (-[WebFrame _URLWithAttributeString:]): Ditto.
              (-[WebFrame _searchFor:direction:caseSensitive:wrap:startInSelection:]): Ditto.
              (-[WebFrame _markAllMatchesForText:caseSensitive:limit:]): Ditto.
              (-[WebFrame _markedTextMatchesAreHighlighted]): Ditto.
              (-[WebFrame _setMarkedTextMatchesAreHighlighted:]): Ditto.
              (-[WebFrame _unmarkAllTextMatches]): Ditto.
              (-[WebFrame _rectsForTextMatches]): Ditto.
              (-[WebFrame _stringByEvaluatingJavaScriptFromString:]): Ditto.
              (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]): Ditto.
              (-[WebFrame _aeDescByEvaluatingJavaScriptFromString:]): Ditto.
              (-[WebFrame _caretRectAtNode:offset:affinity:]): Ditto.
              (-[WebFrame _firstRectForDOMRange:]): Ditto.
              (-[WebFrame _scrollDOMRangeToVisible:]): Ditto.
              (-[WebFrame _baseURL]): Ditto.
              (-[WebFrame _stringWithData:]): Ditto.
              (+[WebFrame _stringWithData:textEncodingName:]): Ditto.
              (-[WebFrame _needsLayout]): Ditto.
              (-[WebFrame _renderTreeAsExternalRepresentation]): Ditto.
              (-[WebFrame _accessibilityTree]): Ditto.
              (-[WebFrame _setBaseBackgroundColor:]): Ditto.
              (-[WebFrame _setDrawsBackground:]): Ditto.
              (-[WebFrame _rangeByAlteringCurrentSelection:SelectionController::direction:SelectionController::granularity:]):
              Ditto.
              (-[WebFrame _selectionGranularity]): Ditto.
              (-[WebFrame _convertToNSRange:]): Ditto.
              (-[WebFrame _convertToDOMRange:]): Ditto.
              (-[WebFrame _convertNSRangeToDOMRange:]): Ditto.
              (-[WebFrame _convertDOMRangeToNSRange:]): Ditto.
              (-[WebFrame _markDOMRange]): Ditto.
              (-[WebFrame _markedTextNSRange]): Ditto.
              (-[WebFrame _smartDeleteRangeForProposedRange:]): Ditto.
              (-[WebFrame _smartInsertForString:replacingRange:beforeString:afterString:]): Ditto.
              (-[WebFrame _documentFragmentWithMarkupString:baseURLString:]): Ditto.
              (-[WebFrame _documentFragmentWithText:inContext:]): Ditto.
              (-[WebFrame _documentFragmentWithNodesAsParagraphs:]): Ditto.
              (-[WebFrame _replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]): Ditto.
              (-[WebFrame _replaceSelectionWithNode:selectReplacement:smartReplace:matchStyle:]): Ditto.
              (-[WebFrame _replaceSelectionWithMarkupString:baseURLString:selectReplacement:smartReplace:]): Ditto.
              (-[WebFrame _replaceSelectionWithText:selectReplacement:smartReplace:]): Ditto.
              (-[WebFrame _insertParagraphSeparatorInQuotedContent]): Ditto.
              (-[WebFrame _visiblePositionForPoint:]): Ditto.
              (-[WebFrame _characterRangeAtPoint:]): Ditto.
              (-[WebFrame _typingStyle]): Ditto.
              (-[WebFrame _setTypingStyle:withUndoAction:]): Ditto.
              (-[WebFrame _fontForSelection:]): Ditto.
              (-[WebFrame _dragSourceMovedTo:]): Ditto.
              (-[WebFrame _dragSourceEndedAt:operation:]): Ditto.
              (-[WebFrame _getData:andResponse:forURL:]): Ditto.
              (-[WebFrame _getAllResourceDatas:andResponses:]): Ditto.
              (-[WebFrame _canProvideDocumentSource]): Ditto.
              (-[WebFrame _canSaveAsWebArchive]): Ditto.
              (-[WebFrame _receivedData:textEncodingName:]): Ditto.
              (-[WebFrame _setShouldCreateRenderers:]): Put the code from the bridge in this preexisting
              function. Couldn't just keep the bridge method because this was already here with the same name.
              (-[WebFrame _selectedNSRange]): Ditto.
              (-[WebFrame _selectNSRange:]): Ditto.
              (-[WebFrame dealloc]): Remove bridge-related code.
              (-[WebFrame finalize]): Ditto.
      
              * WebView/WebFrameInternal.h: Added all the method declarations from the bridge.
              Removed the bridge parameter from the init method. Removed the #if blocks that
              tried to make this header work in non-C++ ObjC files -- they were broken and unused.
              Removed the _bridge method.
      
              * WebView/WebFrameView.mm: Removed the _bridge method.
      
              * WebView/WebHTMLRepresentation.mm:
              (-[WebHTMLRepresentation setDataSource:]): Removed the code to set up the bridge
              field.
              (-[WebHTMLRepresentation receivedData:withDataSource:]): Use WebFrame instead of bridge.
              (-[WebHTMLRepresentation finishedLoadingWithDataSource:]): Ditto.
              (-[WebHTMLRepresentation canProvideDocumentSource]): Ditto.
              (-[WebHTMLRepresentation canSaveAsWebArchive]): Ditto.
              (-[WebHTMLRepresentation documentSource]): Ditto.
              (-[WebHTMLRepresentation DOMDocument]): Ditto.
              (-[WebHTMLRepresentation elementWithName:inForm:]): Ditto.
              (-[WebHTMLRepresentation elementDoesAutoComplete:]): Ditto.
              (-[WebHTMLRepresentation elementIsPassword:]): Ditto.
              (-[WebHTMLRepresentation formForElement:]): Ditto.
              (-[WebHTMLRepresentation currentForm]): Ditto.
              (-[WebHTMLRepresentation controlsInForm:]): Ditto.
              (-[WebHTMLRepresentation searchForLabels:beforeElement:]): Ditto.
              (-[WebHTMLRepresentation matchLabels:againstElement:]): Ditto.
      
              * WebView/WebHTMLRepresentationPrivate.h: Removed the _bridge method.
      
              * WebView/WebHTMLView.mm:
              (-[WebHTMLView _documentFragmentWithPaths:]): Use WebFrame instead of bridge.
              (-[WebHTMLView _pasteWithPasteboard:allowPlainText:]): Ditto.
              (-[WebHTMLView _pasteAsPlainTextWithPasteboard:]): Ditto.
              (-[WebHTMLView _updateTextSizeMultiplier]): Ditto.
              (-[WebHTMLView _frameOrBoundsChanged]): Ditto.
              (-[WebHTMLView _smartInsertForString:replacingRange:beforeString:afterString:]): Ditto.
              (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]): Ditto.
              (-[WebHTMLView layoutToMinimumPageWidth:maximumPageWidth:adjustingViewSize:]): Ditto.
              (-[WebHTMLView drawSingleRect:]): Ditto.
              (-[WebHTMLView draggedImage:movedTo:]): Ditto.
              (-[WebHTMLView draggedImage:endedAt:operation:]): Ditto.
              (-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]): Ditto.
              (-[WebHTMLView knowsPageRange:]): Ditto.
              (-[WebHTMLView accessibilityAttributeValue:]): Ditto.
              (-[WebHTMLView accessibilityFocusedUIElement]): Ditto.
              (-[WebHTMLView accessibilityHitTest:]): Ditto.
              (-[WebHTMLView _accessibilityParentForSubview:]): Ditto.
              (-[WebHTMLView changeDocumentBackgroundColor:]): Ditto.
              (-[WebHTMLView _changeWordCaseWithSelector:]): Ditto.
              (-[WebHTMLView _changeSpellingToWord:]): Ditto.
              (-[WebHTMLView startSpeaking:]): Ditto.
              (-[WebHTMLView _updateFontPanel]): Ditto.
              (-[WebHTMLView _canSmartCopyOrDelete]): Ditto.
              (-[WebHTMLView _layoutIfNeeded]): Ditto.
              (-[WebHTMLView characterIndexForPoint:]): Ditto.
              (-[WebHTMLView firstRectForCharacterRange:]): Ditto.
              (-[WebHTMLView selectedRange]): Ditto.
              (-[WebHTMLView markedRange]): Ditto.
              (-[WebHTMLView attributedSubstringFromRange:]): Ditto.
              (-[WebHTMLView setMarkedText:selectedRange:]): Ditto.
              (-[WebHTMLView insertText:]): Ditto.
              (-[WebTextCompleteController _insertMatch:]): Ditto.
              (-[WebTextCompleteController doCompletion]): Ditto.
              (-[WebTextCompleteController endRevertingChange:moveLeft:]): Ditto.
              (-[WebHTMLView string]): Ditto.
              (-[WebHTMLView selectedString]): Ditto.
              (-[WebHTMLView searchFor:direction:caseSensitive:wrap:startInSelection:]): Ditto.
              (-[WebHTMLView markAllMatchesForText:caseSensitive:limit:]): Ditto.
              (-[WebHTMLView setMarkedTextMatchesAreHighlighted:]): Ditto.
              (-[WebHTMLView markedTextMatchesAreHighlighted]): Ditto.
              (-[WebHTMLView unmarkAllTextMatches]): Ditto.
              (-[WebHTMLView rectsForTextMatches]): Ditto.
              * WebView/WebRenderNode.mm:
              (-[WebRenderNode initWithWebFrameView:]): Ditto.
              * WebView/WebResource.mm:
              (-[WebResource _stringValue]): Ditto.
      
              * WebView/WebScriptDebugDelegate.mm: Removed unneeded include.
      
              * WebView/WebView.mm:
              (-[WebView _dashboardRegions]): Use WebFrame instead of bridge.
              (-[WebView setProhibitsMainFrameScrolling:]): Ditto.
              (-[WebView _setInViewSourceMode:]): Ditto.
              (-[WebView _inViewSourceMode]): Ditto.
              (-[WebView _executeCoreCommandByName:value:]): Ditto.
              (-[WebView stringByEvaluatingJavaScriptFromString:]): Ditto.
              (-[WebView aeDescByEvaluatingJavaScriptFromString:]): Ditto.
              (-[WebView scrollDOMRangeToVisible:]): Ditto.
              (-[WebView setSelectedDOMRange:affinity:]): Ditto.
              (-[WebView setEditable:]): Ditto.
              (-[WebView setTypingStyle:]): Ditto.
              (-[WebView typingStyle]): Ditto.
              (-[WebView replaceSelectionWithNode:]): Ditto.
              (-[WebView replaceSelectionWithText:]): Ditto.
              (-[WebView replaceSelectionWithMarkupString:]): Ditto.
              (-[WebView replaceSelectionWithArchive:]): Ditto.
              (-[WebView _insertNewlineInQuotedContent]): Ditto.
              (-[WebView _replaceSelectionWithNode:matchStyle:]): Ditto.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31014 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b46f9fdd
    • hyatt@apple.com's avatar
      WebCore: · 29be35f6
      hyatt@apple.com authored
              Make the zoom factor a float and not a percent.
      
              Reviewed by antti
      
              * WebCore.base.exp:
              * css/CSSStyleSelector.cpp:
              (WebCore::CSSStyleSelector::applyProperty):
              (WebCore::CSSStyleSelector::getComputedSizeFromSpecifiedSize):
              * page/Frame.cpp:
              (WebCore::Frame::zoomFactor):
              (WebCore::Frame::setZoomFactor):
              * page/Frame.h:
              * page/FramePrivate.h:
              * svg/SVGSVGElement.cpp:
              (WebCore::SVGSVGElement::currentScale):
              (WebCore::SVGSVGElement::setCurrentScale):
      
      WebKit/mac:
      
              Make the zoom factor a float and not a percent.
      
              Reviewed by antti
      
              * WebView/WebView.mm:
              (-[WebView _setZoomMultiplier:isTextOnly:]):
      
      WebKit/win:
      
              Make the zoom factor a float and not a percent.
      
              Reviewed by antti
      
              * WebFrame.cpp:
              (WebFrame::setTextSizeMultiplier):
      
      WebKit/wx:
      
              Make the zoom factor a float and not a percent.
      
              Reviewed by antti
      
              * WebView.cpp:
              (wxWebView::IncreaseTextSize):
              (wxWebView::DecreaseTextSize):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31003 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      29be35f6
    • hyatt@apple.com's avatar
      WebCore: · 410f7e72
      hyatt@apple.com authored
              Eliminate setTextMultiplier from the bridge.  Make Webkit just call setZoomFactor on the frame directly.
      
              Reviewed by Tim H.
      
              * WebCore.base.exp:
              * page/mac/WebCoreFrameBridge.h:
              * page/mac/WebCoreFrameBridge.mm:
      
      WebKit/mac:
      
              This patch prepares Mac WebKit to handle two different zooming modes (full page zoom and text only zoom).
              New API is added that is parallel to the text zoom public API.  You can get/set a pageSizeMultiplier and you
              can zoom the page in, out or reset it to the standard size.
      
              In the implementation only one zoom factor is stored, and setting one multiplier will shift you into that mode
              and set the common zoom factor.  In other words you can't combine text zoom and page zoom.  One will always
              win.
      
              Reviewed by Tim H.
      
              * WebCoreSupport/WebFrameBridge.mm:
              (-[WebFrameBridge finishInitializingWithPage:frameName:WebCore::frameView:ownerElement:]):
              * WebView/WebDocumentInternal.h:
              * WebView/WebHTMLView.mm:
              (-[WebHTMLView viewDidMoveToSuperview]):
              * WebView/WebPDFView.h:
              * WebView/WebPDFView.mm:
              (-[WebPDFView _zoomOut:]):
              (-[WebPDFView _zoomIn:]):
              (-[WebPDFView _resetZoom:]):
              (-[WebPDFView _canZoomOut]):
              (-[WebPDFView _canZoomIn]):
              (-[WebPDFView _canResetZoom]):
              * WebView/WebView.mm:
              (-[WebViewPrivate init]):
              (-[WebView setTextSizeMultiplier:]):
              (-[WebView textSizeMultiplier]):
              (-[WebView _setZoomMultiplier:isTextOnly:]):
              (-[WebView _zoomMultiplier:]):
              (-[WebView _realZoomMultiplier]):
              (-[WebView _realZoomMultiplierIsTextOnly]):
              (-[WebView _canZoomOut:]):
              (-[WebView _canZoomIn:]):
              (-[WebView _zoomOut:isTextOnly:]):
              (-[WebView _zoomIn:isTextOnly:]):
              (-[WebView _canResetZoom:]):
              (-[WebView _resetZoom:isTextOnly:]):
              (-[WebView canMakeTextSmaller]):
              (-[WebView makeTextSmaller:]):
              (-[WebView canMakeTextLarger]):
              (-[WebView makeTextLarger:]):
              (-[WebView canMakeTextStandardSize]):
              (-[WebView makeTextStandardSize:]):
              (-[WebView setPageSizeMultiplier:]):
              (-[WebView pageSizeMultiplier]):
              (-[WebView canZoomPageIn]):
              (-[WebView zoomPageIn:]):
              (-[WebView canZoomPageOut]):
              (-[WebView zoomPageOut:]):
              (-[WebView canResetPageZoom]):
              (-[WebView resetPageZoom:]):
              (-[WebView _searchWithSpotlightFromMenu:]):
              * WebView/WebViewInternal.h:
              * WebView/WebViewPrivate.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30998 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      410f7e72
  18. 11 Mar, 2008 2 commits
    • darin@apple.com's avatar
      WebCore: · 5670fde4
      darin@apple.com authored
              Reviewed by Sam.
      
              - remove all bridge-related things from WebCore except the bridge itself
      
              * WebCore.base.exp: Removed the bridge and setBridge functions.
      
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::detachFromParent): Removed call to the bridge's
              close method.
      
              * page/Frame.cpp:
              (WebCore::Frame::~Frame): Removed call to setBridge(0).
              (WebCore::FramePrivate::FramePrivate): Removed initialization of m_bridge.
              * page/Frame.h: Removed setBridge and bridge functions.
              * page/FramePrivate.h: Removed m_bridge pointer.
              * page/mac/FrameMac.mm: Removed setBridge and bridge functions.
      
              * page/mac/WebCoreFrameBridge.h: Added setWebCoreFrame: method.
              Removed bridgeForDOMDocument: and clearFrame methods.
              * page/mac/WebCoreFrameBridge.mm: Ditto.
              (-[WebCoreFrameBridge close]): Changed to set m_frame to 0 directly.
              (-[WebCoreFrameBridge setWebCoreFrame:]): Added.
      
      WebKit/mac:
      
              Reviewed by Sam.
      
              - remove all bridge-related things from WebCore except the bridge itself
      
              * DOM/WebDOMOperations.mm:
              (-[DOMNode _bridge]): Reimplemented to not use the bridgeForDOMDocument: method.
      
              * DefaultDelegates/WebDefaultContextMenuDelegate.mm: Removed unneeded include.
      
              * Plugins/WebPluginController.mm: Ditto.
      
              * WebCoreSupport/WebFrameBridge.h: Removed unneeded things, including the
              init and close methods. Added a setWebFrame: method.
      
              * WebCoreSupport/WebFrameBridge.mm:
              (-[WebFrameBridge setWebFrame:]): Added.
      
              * WebCoreSupport/WebFrameLoaderClient.mm:
              (WebFrameLoaderClient::frameLoaderDestroyed): Added an assertion.
              (WebFrameLoaderClient::detachedFromParent4): Moved the call to close on the
              bridge here. Soon we will be able to remove this entirely!
              (WebFrameLoaderClient::createFrame): Rewrote this to use the method moved
              into WebFrame from the bridge.
      
              * WebView/WebFrame.mm:
              (-[WebFramePrivate dealloc]): Added code to release the bridge, because it's
              now owned by the frame.
              (-[WebFramePrivate finalize]): Added this missing method. We'd leak the script
              debugger under GC without this!
              (kit): Rewrote the function that maps from a WebCore::Frame to a WebFrame to
              use WebFrameLoaderClient instead of the bridge.
              (+[WebFrame _createFrameWithPage:frameName:frameView:ownerElement:]): Added.
              This is code that used to live in the bridge's init function.
              (+[WebFrame _createMainFrameWithPage:frameName:frameView:]): Ditto.
              (+[WebFrame WebCore::_createSubframeWithOwnerElement:frameName:frameView:]): Ditto.
              (-[WebFrame _initWithWebFrameView:webView:bridge:]): Retain the bridge, since
              the WebView is now the bridge's owner.
              (-[WebFrame _updateBackground]): Changed this one call site that was calling the
              WebCore::Frame::bridge function directly to use the kit function instead.
              (-[WebFrame dealloc]): Added code to clear the WebFrame pointer in the bridge.
              This code won't last long -- we're eliminating the bridge soon.
              (-[WebFrame finalize]): Ditto.
      
              * WebView/WebFrameInternal.h: Added a coreFrame backpointer and two new methods
              for creating frames.
      
              * WebView/WebView.mm:
              (-[WebView _commonInitializationWithFrameName:groupName:]): Rewrote this to use
              the method moved into WebFrame from the bridge. Gets rid of the unpleasant idiom
              where we have to allocate a WebFrameBridge and then immediately release it.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30980 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5670fde4
    • darin@apple.com's avatar
      WebCore: · 8ae505a0
      darin@apple.com authored
              Reviewed by Anders.
      
              - simplify Mac code for ScrollView, since it's used only for FrameView
                and not in two different modes like it was historically
              - remove code depending on the bridge to get from an NSView to a WebCore::Frame
      
              * bindings/objc/DOMHTML.mm:
              (-[DOMHTMLInputElement _rectOnScreen]): getDocumentView -> documentView.
      
              * bridge/jni/jni_jsobject.cpp:
              (createRootObject): Instead of using WebCoreViewFactory to find the frame given
              and NSView, use the WebCoreFrameView interface to do it.
      
              * editing/mac/EditorMac.mm:
              (WebCore::Editor::paste): getDocumentView -> documentView.
              * editing/mac/SelectionControllerMac.mm:
              (WebCore::SelectionController::notifyAccessibilityForSelectionChange): Ditto.
      
              * page/FrameView.h: Fixed comment.
      
              * page/InspectorController.cpp:
              (WebCore::InspectorController::drawNodeHighlight): Removed uneeded typecasts
              to ScrollView* since FrameView is derived from ScrollView.
      
              * page/mac/EventHandlerMac.mm:
              (WebCore::EventHandler::focusDocumentView): getDocumentView -> documentView.
              * page/mac/FrameMac.mm:
              (WebCore::Frame::imageFromRect): Ditto.
              * page/mac/WebCoreAXObject.mm:
              (-[WebCoreAXObject position]): Ditto.
              (-[WebCoreAXObject doAXTextMarkerForPosition:]): Ditto.
              (-[WebCoreAXObject rendererForView:]): Updated code that used to use
              WebCoreBridgeHolder to use WebCoreFrameView instead.
      
              * page/mac/WebCoreFrameBridge.mm:
              (-[WebCoreFrameBridge computePageRectsWithPrintWidthScaleFactor:printHeight:]):
              getDocumentView -> documentView.
      
              * page/mac/WebCoreFrameView.h: Removed the WebCoreScrollbarMode type; we just
              use WebCore::ScrollbarMode directly. Renamed the WebCoreFrameView protocol to
              WebCoreFrameScrollView, since it's a protocol for the scroll view, not the
              frame view itself. Replaced WebCoreBridgeHolder protocol with WebCoreFrameView
              protocol, which returns a WebCore::Frame directly rather than a bridge.
      
              * page/mac/WebCoreViewFactory.h: Eliminated the bridgeForView method.
      
              * platform/ScrollView.h: Moved the constructor and destructor out of the
              class-specific #if blocks. Renamed Mac-specific function that gets the
              NSView for from getDocumentView to documentView and a scrollView function
              that returns an appropriately classed NSScrollView.
      
              * platform/graphics/MediaPlayer.h: Changed type of parentWidget to FrameView
              instead of Widget.
              * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
              (WebCore::MediaPlayerPrivate::createQTMovieView): Removed unnecessary cast.
      
              * platform/mac/PopupMenuMac.mm:
              (WebCore::PopupMenu::show): getDocumentView -> documentView.
              * platform/mac/ScrollViewMac.mm:
              (WebCore::ScrollView::ScrollView): Added.
              (WebCore::ScrollView::~ScrollView): Added.
              (WebCore::ScrollView::scrollView): Added.
              (WebCore::ScrollView::visibleWidth): Removed unused non-NSScrollView case.
              (WebCore::ScrollView::visibleHeight): Ditto.
              (WebCore::ScrollView::visibleContentRect): Ditto.
              (WebCore::ScrollView::visibleContentRectConsideringExternalScrollers): Ditto.
              (WebCore::ScrollView::contentsWidth): Ditto.
              (WebCore::ScrollView::contentsHeight): Ditto.
              (WebCore::ScrollView::contentsX): Ditto.
              (WebCore::ScrollView::contentsY): Ditto.
              (WebCore::ScrollView::scrollOffset): Ditto.
              (WebCore::ScrollView::scrollRectIntoViewRecursively): Ditto.
              (WebCore::ScrollView::setContentsPos): Ditto.
              (WebCore::ScrollView::setVScrollbarMode): Ditto.
              (WebCore::ScrollView::setHScrollbarMode): Ditto.
              (WebCore::ScrollView::setScrollbarsMode): Ditto.
              (WebCore::ScrollView::vScrollbarMode): Ditto.
              (WebCore::ScrollView::hScrollbarMode): Ditto.
              (WebCore::ScrollView::suppressScrollbars): Ditto.
              (WebCore::ScrollView::addChild): Ditto.
              (WebCore::ScrollView::resizeContents): Ditto.
              (WebCore::ScrollView::updateContents): Ditto.
              (WebCore::ScrollView::contentsToWindow): Ditto.
              (WebCore::ScrollView::windowToContents): Ditto.
              (WebCore::ScrollView::setStaticBackground): Ditto.
              (WebCore::ScrollView::documentView): Renamed and removed unused case.
              (WebCore::ScrollView::scrollbarUnderMouse): Removed incorrect comment.
      
              * platform/mac/WidgetMac.mm:
              (WebCore::Widget::getOuterView): Update for protocol name change.
      
              * rendering/RenderThemeMac.mm:
              (WebCore::RenderThemeMac::paintCheckbox): getDocumentView -> documentView.
              (WebCore::RenderThemeMac::paintRadio): Ditto.
              (WebCore::RenderThemeMac::paintButton): Ditto.
              (WebCore::RenderThemeMac::paintMenuList): Ditto.
              (WebCore::RenderThemeMac::paintSliderThumb): Ditto.
              (WebCore::RenderThemeMac::paintSearchField): Ditto.
              (WebCore::RenderThemeMac::paintSearchFieldCancelButton): Ditto.
              (WebCore::RenderThemeMac::paintSearchFieldResultsDecoration): Ditto.
              (WebCore::RenderThemeMac::paintSearchFieldResultsButton): Ditto.
      
      WebKit:
      
              Reviewed by Anders.
      
              * WebKit.xcodeproj/project.pbxproj: Change WebDynamicScrollBarsView.m to be Obj-C++.
              We can rename the file later.
      
      WebKit/mac:
      
              Reviewed by Anders.
      
              - remove code depending on the bridge to get from an NSView to a WebCore::Frame
      
              * WebCoreSupport/WebFrameLoaderClient.mm:
              (WebFrameLoaderClient::transitionToCommittedForNewPage): Remove incorrect call
              to setView. A couple lines later, there is a call to _install, which sets the
              view to the scroll view.
      
              * WebCoreSupport/WebViewFactory.mm: Removed bridgeForView method.
      
              * WebView/WebDynamicScrollBarsView.h: Moved most of the declarations out of
              this file, since it's used by Safari.
              * WebView/WebDynamicScrollBarsViewInternal.h: Added.
              * WebView/WebDynamicScrollBarsView.m:
              (-[WebDynamicScrollBarsView updateScrollers]): Ditto.
              (-[WebDynamicScrollBarsView setAllowsScrolling:]): Ditto.
              (-[WebDynamicScrollBarsView allowsScrolling]): Ditto.
              (-[WebDynamicScrollBarsView setAllowsHorizontalScrolling:]): Ditto.
              (-[WebDynamicScrollBarsView setAllowsVerticalScrolling:]): Ditto.
              (-[WebDynamicScrollBarsView allowsHorizontalScrolling]): Ditto.
              (-[WebDynamicScrollBarsView allowsVerticalScrolling]): Ditto.
              (-[WebDynamicScrollBarsView horizontalScrollingMode]): Ditto.
              (-[WebDynamicScrollBarsView verticalScrollingMode]): Ditto.
              (-[WebDynamicScrollBarsView setHorizontalScrollingMode:]): Ditto.
              (-[WebDynamicScrollBarsView setHorizontalScrollingMode:andLock:]): Ditto.
              (-[WebDynamicScrollBarsView setVerticalScrollingMode:]): Ditto.
              (-[WebDynamicScrollBarsView setVerticalScrollingMode:andLock:]): Ditto.
              (-[WebDynamicScrollBarsView setScrollingMode:]): Ditto.
              (-[WebDynamicScrollBarsView setScrollingMode:andLock:]): Ditto.
      
              * WebView/WebFrameView.mm:
              (-[WebFrameView _web_frame]): Added. Replaces the webCoreBridge method.
      
              * WebView/WebView.mm:
              (-[WebView setAlwaysShowVerticalScroller:]): Updated for changes to WebCoreFrameView.h.
              (-[WebView alwaysShowVerticalScroller]): Ditto.
              (-[WebView setAlwaysShowHorizontalScroller:]): Ditto.
              (-[WebView alwaysShowHorizontalScroller]): Ditto.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30976 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8ae505a0
  19. 10 Mar, 2008 2 commits
    • darin@apple.com's avatar
      WebCore: · 1454202e
      darin@apple.com authored
              Reviewed by Sam.
      
              - eliminate keyboard UI mode method from WebCoreFrameBridge
      
              * page/ChromeClient.h: Added keyboardUIMode function.
              (WebCore::ChromeClient::keyboardUIMode): Ditto.
              * page/mac/EventHandlerMac.mm:
              (WebCore::EventHandler::tabsToAllControls): Call chrome client function instead
              of bridge function.
              * page/mac/WebCoreFrameBridge.h: Removed keyboardUIMode method, and other unused
              ones.
      
              * WebCore.xcodeproj/project.pbxproj: Allowed Xcode to change the project.
              Do not try to fight the Xcode.
      
      WebKit/mac:
      
              Reviewed by Sam.
      
              - eliminate keyboard UI mode method from WebCoreFrameBridge
      
              * WebCoreSupport/WebChromeClient.h: Added keyboardUIMode function.
              * WebCoreSupport/WebChromeClient.mm:
              (WebChromeClient::keyboardUIMode): Ditto. Calls WebView.
              * WebCoreSupport/WebFrameBridge.h: Removed unused things, including the
              fields for keyboard UI mode.
              * WebCoreSupport/WebFrameBridge.mm:
              (-[WebFrameBridge dealloc]): Removed unneeded code; eliminated the fini
              method.
              (-[WebFrameBridge finalize]): Ditto.
              * WebView/WebView.mm: Moved the keyboard mode code in here.
              (-[WebView _close]): Remove observer from the distributed notification
              center as well as the normal one.
              (-[WebView _retrieveKeyboardUIModeFromPreferences:]): Added. Code moved
              here from the bridge.
              (-[WebView _keyboardUIMode]): Ditto.
              * WebView/WebViewInternal.h: Added _keyboardUIMode method.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30939 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1454202e
    • hausmann@webkit.org's avatar
      2008-03-07 Simon Hausmann <hausmann@webkit.org> · 9999bb88
      hausmann@webkit.org authored
              http://bugs.webkit.org/show_bug.cgi?id=16815
      
              Reviewed by Darin.
      
              Done with Lars.
      
      WebCore:
      
              Ported the manually written JS bindings of window.navigator,
              window.navigator.plugins and window.navigator.mimeTypes to
              auto-generated bindings.
      
              Moved the globally cached plugin and mimetype information to a
              per WebCore::Page shared PluginData structure.
      
              Implemented window.navigator.plugins.refresh() in a
              platform-independent way.
      
      LayoutTests:
      
              Added a testcase for http://bugs.webkit.org/show_bug.cgi?id=16815
      
      WebKit/qt:
      
              Replaced the QWebObjectPlugin interfaces with QWebPluginFactory.
      
      WebKit/mac:
      
              Simplified WebViewFactory's refreshPlugins method to only refresh the
              plugins and not reload the frames anymore since that's now done in a
              platform independent manner by WebCore::Page.
      
              Also removed the now unused pluginNameForMIMEType and
       ...
      9999bb88
  20. 06 Mar, 2008 1 commit
    • aroben@apple.com's avatar
      Remove WebScriptDebugger · 03bbeb6b
      aroben@apple.com authored
      WebKit:
      
              Remove WebScriptDebugger
      
              Reviewed by Kevin M.
      
              * WebKit.xcodeproj/project.pbxproj: Remove
              WebScriptDebugDelegatePrivate.h from the project.
      
      WebKit/mac:
      
              Remove WebScriptDebugger
      
              Uses of WebScriptDebugger have been replaced with
              WebCoreScriptDebuggerImp.
      
              Reviewed by Kevin M.
      
              * WebView/WebFrame.mm:
              (-[WebFramePrivate dealloc]): Use delete instead of release since
              WebCoreScriptDebuggerImp is a C++ class.
              (-[WebFrame _attachScriptDebugger]): Updated to use early returns and
              WebCoreScriptDebuggerImp.
              (-[WebFrame _detachScriptDebugger]): Ditto.
              * WebView/WebFrameInternal.h:
              * WebView/WebScriptDebugDelegate.mm: Removed WebScriptDebugger
              * WebView/WebScriptDebugDelegatePrivate.h: Removed.
              * WebView/WebView.mm:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30836 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      03bbeb6b
  21. 04 Mar, 2008 2 commits
    • timothy@apple.com's avatar
      Fix the Tiger build. · be0b020e
      timothy@apple.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30786 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      be0b020e
    • timothy@apple.com's avatar
      WebCore: · d919f802
      timothy@apple.com authored
              Reviewed by Darin Adler.
      
              <rdar://problem/5720160> Browser windows "do nothing" while modal
              dialog or menu is up due to run loop modes (or while scrolling)
      
              Adds a new SchedulePair object that holds a runloop and the mode to use.
              A HashSet of SchedulePairs is tracked by Page so it can be used for resource
              loading and, in the future, maybe SharedTimerMac.
      
              * WebCore.base.exp: Add new exports for WebKit.
              * WebCore.xcodeproj/project.pbxproj: Add new files.
              * loader/mac/DocumentLoaderMac.cpp: Added.
              (WebCore::scheduleAll): Call schedule all the ResourceLoader handles.
              (WebCore::unscheduleAll): Call unschedule all the ResourceLoader handles.
              (WebCore::DocumentLoader::schedule): Schedule all the ResourceLoaders owned by the DocumentLoader.
              (WebCore::DocumentLoader::unschedule): Unschedule all the ResourceLoaders owned by the DocumentLoader.
              * loader/DocumentLoader.h:
              * page/Page.h:
              (WebCore::Page::scheduledRunLoopPairs): Return m_scheduledRunLoopPairs.
              * page/mac/PageMac.cpp:
              (WebCore::Page::addSchedulePair): Add a SchedulePair to m_scheduledRunLoopPairs.
              (WebCore::Page::removeSchedulePair): Removes a SchedulePair from m_scheduledRunLoopPairs.
              * platform/cf/SchedulePair.cpp: Added.
              * platform/cf/SchedulePair.h: Added.
              * platform/mac/SchedulePairMac.mm: Added.
              * platform/network/ResourceHandle.h:
              * platform/network/mac/FormDataStreamMac.mm:
              (WebCore::advanceCurrentStream): Use the new SchedulePair.
              (WebCore::formCreate): Ditto.
              (WebCore::formFinalize): Ditto.
              (WebCore::formSchedule): Ditto.
              (WebCore::formUnschedule): Ditto.
              * platform/network/mac/ResourceHandleMac.mm:
              (WebCore::ResourceHandle::start): Schedule the connection with all the SchedulePairs
              that Page holds. If Page has no SchedulePairs, schedule with the current runloop, and
              pick the mode based on ResourceHandle::loadsDuringCommonRunLoopModes.
              (WebCore::ResourceHandle::schedule):
              (WebCore::ResourceHandle::unschedule):
      
      WebKit/mac:
      
              Reviewed by Darin Adler.
      
              <rdar://problem/5720160> Browser windows "do nothing" while modal
              dialog or menu is up due to run loop modes (or while scrolling)
      
              Add new API that lets a WebView be scheduled with multiple runloops and modes.
              This lets loading continue when in a nested runloop or in a different mode.
      
              * Misc/WebKitVersionChecks.h: Add a new version define:
              WEBKIT_FIRST_VERSION_WITH_LOADING_DURING_COMMON_RUNLOOP_MODES.
              * WebView/WebView.mm:
              (-[WebView _commonInitializationWithFrameName:groupName:]): Schedule in the main runloop and with
              the default runloop mode if we are linked on an earlier WebKit version, use common modes otherwise.
              (-[WebView scheduleInRunLoop:forMode:]): New API, that calls through to Page.
              (-[WebView unscheduleFromRunLoop:forMode:]): Ditto.
              * WebView/WebViewPrivate.h: Add the new pending API methods.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30778 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d919f802
  22. 29 Feb, 2008 1 commit
    • mrowe@apple.com's avatar
      2008-02-29 Mark Rowe <mrowe@apple.com> · be150f9f
      mrowe@apple.com authored
              Reviewed by Oliver Hunt.
      
              Remove obsolete code that had been left intact to support users running WebKit with older versions of Safari.
      
              * Misc/WebNSViewExtras.m:  Remove _web_superviewOfClass:stoppingAtClass:.
              * Misc/WebNSWindowExtras.m:  Remove _webkit_displayThrottledWindows.
              * Misc/WebSearchableTextView.m:  Remove selectionImageForcingWhiteText:.
              * WebCoreSupport/WebImageRendererFactory.m:  Update comment to mention the last version of Safari that
              requires this class.
              * WebInspector/WebInspector.mm:  Remove sharedWebInspector and update comments to mention the last version
              of Safari that calls other obsolete methods.
              * WebView/WebDocumentPrivate.h:  Remove selectionImageForcingWhiteText:.
              * WebView/WebHTMLView.mm:  Ditto.
              * WebView/WebPDFView.mm:  Ditto.
              * WebView/WebView.mm:  Update comment to mentoin the last version of Safari that requires the obsolete method.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30660 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      be150f9f
  23. 22 Feb, 2008 1 commit
    • sullivan@apple.com's avatar
      Reviewed by Adam Roben · 624dcba7
      sullivan@apple.com authored
              
              Reverted the changed from yesterday to add pasteAndMatchStyle:, as the existing
              pasteAsPlainText: has the same behavior.
      
              * WebView/WebHTMLView.mm:
              (-[WebHTMLView _pasteWithPasteboard:allowPlainText:]):
              (-[WebHTMLView readSelectionFromPasteboard:]):
              (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]):
              (-[WebHTMLView pasteAsRichText:]):
              (-[WebHTMLView paste:]):
              * WebView/WebView.mm:
              * WebView/WebViewPrivate.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30476 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      624dcba7
  24. 21 Feb, 2008 1 commit
    • sullivan@apple.com's avatar
      Reviewed by Jessica Kahn · b936ccfc
      sullivan@apple.com authored
              
              support for pasteAndMatchStyle: command (see <rdar://problem/5723952>)
      
              * WebView/WebHTMLView.mm:
              (-[WebHTMLView _pasteWithPasteboard:allowPlainText:matchStyle:]):
              added matchStyle parameter, passed along to bridge (formerly always passed NO to bridge)
              (-[WebHTMLView readSelectionFromPasteboard:]):
              pass NO for new matchStyle parameter to match old behavior
              (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]):
              validate pasteAndMatchStyle the same way as pasteAsRichText
              (-[WebHTMLView pasteAndMatchStyle:]):
              just like pasteAsRichText but passes YES for matchStyle
              (-[WebHTMLView pasteAsRichText:]):
              pass NO for new matchStyle parameter to match old behavior
              (-[WebHTMLView paste:]):
              ditto
              
              * WebView/WebView.mm:
              added macro(pasteAndMatchStyle)
              
              * WebView/WebViewPrivate.h:
              added pasteAndMatchStyle: to WebViewEditingActionsPendingPublic category
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30463 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b936ccfc
  25. 20 Feb, 2008 1 commit
    • weinig@apple.com's avatar
      WebCore: · 04346b10
      weinig@apple.com authored
              Reviewed by Darin and Geoff.
      
              - <rdar://problem/5754378> work around missing video on YouTube front page with a site-specific hack
      
              * WebCore.base.exp: Updated.
      
              * bindings/js/kjs_navigator.cpp:
              (WebCore::needsYouTubeQuirk): Added. Return true on Windows only when the quirk is needed.
              (WebCore::Navigator::getValueProperty): For the appVersion property, if needsYouTubeQuirk
              return true, then return the empty string.
      
              * page/Settings.cpp:
              (WebCore::Settings::Settings): Set m_needsSiteSpecificQuirks to false.
              (WebCore::Settings::setNeedsSiteSpecificQuirks): Added.
              * page/Settings.h: Added m_needsSiteSpecificQuirks.
              (WebCore::Settings::needsSiteSpecificQuirks): Added.
      
      WebKit/mac:
      
              Reviewed by Darin and Geoff.
      
              - WebKit part of <rdar://problem/5754378> work around missing video on YouTube front page with a site-specific hack
      
              * WebView/WebView.mm:
              (-[WebView _preferencesChangedNotification:]): Added a call to Settings::setNeedsSiteSpecificQuirks.
              There are currently no site-specific quirks on Mac, but we will propagate the state
              to WebCore to avoid possible mistakes later.
      
      WebKit/win:
      
              Reviewed by Darin and Geoff.
      
              - WebKit part of <rdar://problem/5754378> work around missing video on YouTube front page with a site-specific hack
      
              * WebView.cpp:
              (WebView::notifyPreferencesChanged): Added a call to Settings::setNeedsSiteSpecificQuirks.
              (WebView::setAllowSiteSpecificHacks): Added a comment about the problem Darin noticed, where
              after you disable the site-specific hacks they persist until you open a new window or tweak
              some other preference.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30433 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      04346b10
  26. 13 Feb, 2008 1 commit
    • darin@apple.com's avatar
      WebCore: · e64e20a6
      darin@apple.com authored
              - roll out fix for <rdar://problem/5726016> REGRESSION: Xcode News window renders
                incorrectly due to visibility fix
      
              Removed the Xcode-specific quirk at the request of some folks on the Xcode team.
      
              * WebCore.base.exp: Rolled out change.
              * css/CSSMutableStyleDeclaration.cpp:
              (WebCore::CSSMutableStyleDeclaration::setProperty): Ditto.
              * page/Settings.cpp:
              (WebCore::Settings::Settings): Ditto. But keep the initialization of
              m_fontRenderingMode.
              (WebCore::Settings::setNeedsXcodeVisibilityQuirk): Removed.
              * page/Settings.h:
              (WebCore::Settings::needsXcodeVisibilityQuirk): Removed.
      
      WebKit/mac:
      
              - roll out fix for <rdar://problem/5726016> REGRESSION: Xcode News window renders
                incorrectly due to visibility fix
      
              Removed the Xcode-specific quirk at the request of some folks on the Xcode team.
      
              * Misc/WebKitVersionChecks.h: Removed the constant.
      
              * WebView/WebView.mm:
              (-[WebView _needsXcodeVisibilityQuirk]): Removed.
              (-[WebView _preferencesChangedNotification:]): Removed call to
              setNeedsXcodeVisibilityQuirk.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30196 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e64e20a6
  27. 11 Feb, 2008 1 commit
    • darin@apple.com's avatar
      WebCore: · 44dfaca7
      darin@apple.com authored
              Reviewed by Mitz.
      
              - fix <rdar://problem/5726016> REGRESSION: Xcode News window renders
                incorrectly due to visibility fix
      
              Added an Xcode-specific quirk.
      
              * WebCore.base.exp: Added export for new Settings function.
              * css/CSSMutableStyleDeclaration.cpp:
              (WebCore::CSSMutableStyleDeclaration::setProperty): Here's the crazy quirk.
              If you try to change the visibilty on a node with the class name tab_content,
              instead it will use display:none.
              * page/Settings.cpp:
              (WebCore::Settings::Settings): Initialize m_needsXcodeVisibilityQuirk. Also
              initialize m_fontRenderingMode! This seems like it was a bug before, but we
              probably were getting lucky and always getting 0 on Windows, which is the
              only place the setting matters.
              (WebCore::Settings::setNeedsXcodeVisibilityQuirk): Added.
              * page/Settings.h:
              (WebCore::Settings::needsXcodeVisibilityQuirk): Added.
      
      WebKit/mac:
      
              Reviewed by Mitz.
      
              - fix <rdar://problem/5726016> REGRESSION: Xcode News window renders
                incorrectly due to visibility fix
      
              Added an Xcode-specific quirk.
      
              * Misc/WebKitVersionChecks.h: Added a constant for the "linked on or after"
              part of the check.
      
              * WebView/WebView.mm:
              (-[WebView _needsXcodeVisibilityQuirk]): Added.
              (-[WebView _preferencesChangedNotification:]): Added a call to
              setNeedsXcodeVisibilityQuirk based on _needsXcodeVisibilityQuirk.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30156 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      44dfaca7
  28. 10 Feb, 2008 2 commits