1. 07 Oct, 2012 15 commits
    • ggaren@apple.com's avatar
      REGRESSION (r130584): Crashes in JSC::MarkedAllocator::allocateSlowCase,... · 88bd02e5
      ggaren@apple.com authored
      REGRESSION (r130584): Crashes in JSC::MarkedAllocator::allocateSlowCase, failing fast/dom/gc-dom-tree-lifetime.html
      https://bugs.webkit.org/show_bug.cgi?id=98612
      
      Reviewed by Darin Adler.
      
      Since DOM modification can happen outside of JS, calls into JS due to
      DOM modification need to take the JS lock.
      
      * bindings/js/JSNodeCustom.cpp:
      (WebCore::willCreatePossiblyOrphanedTreeByRemovalSlowCase): Take the JS
      lock before doing a JS allocation, since this may be a JS entrypoint.
      
      * bindings/js/JSNodeCustom.h:
      (WebCore::willCreatePossiblyOrphanedTreeByRemoval): Split out a slow case
      to help the inliner.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130611 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      88bd02e5
    • commit-queue@webkit.org's avatar
      [chromium] Crash in WebCore::GraphicsLayerChromium::setContentsToImage · 5333ba81
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=98456
      
      Patch by Nick Carter <nick@chromium.org> on 2012-10-07
      Reviewed by James Robinson.
      
      Source/WebCore:
      
      Handle null return of nativeImageForCurrentFrame.
      
      Test: compositing/images/truncated-direct-png-image.html
      
      * platform/graphics/chromium/GraphicsLayerChromium.cpp:
      (WebCore::GraphicsLayerChromium::setContentsToImage):
      
      LayoutTests:
      
      New tests exercising a broken image on its own layer.
      
      * compositing/images/truncated-direct-png-image-expected.html: Added.
      * compositing/images/truncated-direct-png-image.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130610 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5333ba81
    • benjamin@webkit.org's avatar
      WTFURL: implement URL port removal for HTMLAnchorElement · 8c271917
      benjamin@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=98604
      
      Reviewed by Adam Barth.
      
      Source/WebCore:
      
      * platform/KURLWTFURL.cpp:
      (WebCore::KURL::hasPort):
      (WebCore::KURL::removePort):
      (WebCore::KURL::isHierarchical):
      Implement those methods to pass the port removal test of HTMLAnchorElement.
      
      Source/WTF:
      
      Add hasStandardScheme() (similar to isStandard from Google URL),
      hasPort() and removePort() to implement the port removal of KURL.
      
      * wtf/url/api/ParsedURL.cpp:
      (WTF::ParsedURL::hasStandardScheme):
      (WTF::ParsedURL::hasPort):
      (WTF::ParsedURL::removePort):
      * wtf/url/api/ParsedURL.h:
      (ParsedURL):
      * wtf/url/src/URLComponent.h:
      (WTF::URLComponent::move):
      * wtf/url/src/URLSegments.cpp:
      (WTF::URLSegments::moveComponentsAfter):
      * wtf/url/src/URLSegments.h:
      (URLSegments):
      * wtf/url/src/URLUtil.cpp:
      (URLUtilities):
      (WTF::URLUtilities::isStandard):
      * wtf/url/src/URLUtil.h:
      (URLUtilities):
      Remove LowerCaseEqualsASCII() from the interface, make it an internal template.
      
      (WTF::URLUtilities::isStandard):
      Since in WebKit, LChar is a superset of char, expose LChar and cast char* to LChar*.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130609 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8c271917
    • mitz@apple.com's avatar
      Web process XPC services don't have correct version information in their Info.plist files · d4f928a5
      mitz@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=98619
      
      Reviewed by Anders Carlsson.
      
      * WebProcessService/Info.plist: Added CFBundleGetInfoString, and changed
      CFBundleShortVersionString and CFBundleVersion to report the source version.
      * WebProcessServiceForWebKitDevelopment/Info.plist: Ditto.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130608 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d4f928a5
    • rakuco@webkit.org's avatar
      [EFL] Mark media/video-controls-rendering.html as flaky. · 0d15af91
      rakuco@webkit.org authored
      * platform/efl/TestExpectations:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130607 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0d15af91
    • rakuco@webkit.org's avatar
      [EFL] Unskip svg/W3C-SVG-1.1-SE and add expectations for it. · 2fba4efd
      rakuco@webkit.org authored
      All pixel tests look OK (compared to the ones in mac/), and all
      tests seem to pass.
      
      * platform/efl/TestExpectations:
      * platform/efl/svg/W3C-SVG-1.1-SE/color-prop-05-t-expected.png: Added.
      * platform/efl/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.png: Added.
      * platform/efl/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.txt: Added.
      * platform/efl/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.png: Added.
      * platform/efl/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.txt: Added.
      * platform/efl/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.png: Added.
      * platform/efl/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.txt: Added.
      * platform/efl/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.png: Added.
      * platform/efl/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.txt: Added.
      * platform/efl/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.png: Added.
      * platform/efl/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.txt: Added.
      * platform/efl/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.png: Added.
      * platform/efl/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.txt: Added.
      * platform/efl/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.png: Added.
      * platform/efl/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.png: Added.
      * platform/efl/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.txt: Added.
      * platform/efl/svg/W3C-SVG-1.1-SE/interact-pointer-03-t-expected.png: Added.
      * platform/efl/svg/W3C-SVG-1.1-SE/interact-pointer-03-t-expected.txt: Added.
      * platform/efl/svg/W3C-SVG-1.1-SE/linking-uri-01-b-expected.png: Added.
      * platform/efl/svg/W3C-SVG-1.1-SE/linking-uri-01-b-expected.txt: Added.
      * platform/efl/svg/W3C-SVG-1.1-SE/painting-control-04-f-expected.png: Added.
      * platform/efl/svg/W3C-SVG-1.1-SE/painting-marker-07-f-expected.png: Added.
      * platform/efl/svg/W3C-SVG-1.1-SE/painting-marker-07-f-expected.txt: Added.
      * platform/efl/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.png: Added.
      * platform/efl/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.txt: Added.
      * platform/efl/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.png: Added.
      * platform/efl/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.txt: Added.
      * platform/efl/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.png: Added.
      * platform/efl/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.txt: Added.
      * platform/efl/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.png: Added.
      * platform/efl/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.png: Added.
      * platform/efl/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.txt: Added.
      * platform/efl/svg/W3C-SVG-1.1-SE/struct-dom-11-f-expected.png: Added.
      * platform/efl/svg/W3C-SVG-1.1-SE/struct-dom-11-f-expected.txt: Added.
      * platform/efl/svg/W3C-SVG-1.1-SE/struct-use-11-f-expected.png: Added.
      * platform/efl/svg/W3C-SVG-1.1-SE/struct-use-11-f-expected.txt: Added.
      * platform/efl/svg/W3C-SVG-1.1-SE/struct-use-14-f-expected.png: Added.
      * platform/efl/svg/W3C-SVG-1.1-SE/styling-css-04-f-expected.png: Added.
      * platform/efl/svg/W3C-SVG-1.1-SE/styling-css-04-f-expected.txt: Added.
      * platform/efl/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.png: Added.
      * platform/efl/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.txt: Added.
      * platform/efl/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.png: Added.
      * platform/efl/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt: Added.
      * platform/efl/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.png: Added.
      * platform/efl/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.txt: Added.
      * platform/efl/svg/W3C-SVG-1.1-SE/text-tref-03-b-expected.png: Added.
      * platform/efl/svg/W3C-SVG-1.1-SE/text-tref-03-b-expected.txt: Added.
      * platform/efl/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.png: Added.
      * platform/efl/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.txt: Added.
      * platform/efl/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.png: Added.
      * platform/efl/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.txt: Added.
      * platform/efl/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.png: Added.
      * platform/efl/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.txt: Added.
      * platform/efl/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.png: Added.
      * platform/efl/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.txt: Added.
      * platform/efl/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.png: Added.
      * platform/efl/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.txt: Added.
      * platform/efl/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.png: Added.
      * platform/efl/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.png: Added.
      * platform/efl/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.txt: Added.
      * platform/efl/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.png: Added.
      * platform/efl/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.txt: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130605 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2fba4efd
    • rakuco@webkit.org's avatar
      [EFL] Unskip passing test. · 5272499a
      rakuco@webkit.org authored
      * platform/efl/TestExpectations:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130602 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5272499a
    • rakuco@webkit.org's avatar
      [EFL] Finish rebaselining the SVG tests after r130599. · ffead378
      rakuco@webkit.org authored
      * platform/efl/TestExpectations:
      * platform/efl/svg/W3C-SVG-1.1: Added.
      * platform/efl/svg/W3C-SVG-1.1-SE: Added.
      * platform/efl/svg/W3C-SVG-1.1-SE/styling-pres-02-f-expected.png: Added.
      * platform/efl/svg/W3C-SVG-1.1-SE/styling-pres-02-f-expected.txt: Added.
      * platform/efl/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.png: Added.
      * platform/efl/svg/W3C-SVG-1.1/coords-units-01-b-expected.png: Added.
      * platform/efl/svg/W3C-SVG-1.1/coords-units-01-b-expected.txt: Added.
      * platform/efl/svg/W3C-SVG-1.1/pservers-grad-02-b-expected.png: Added.
      * platform/efl/svg/W3C-SVG-1.1/pservers-grad-02-b-expected.txt: Added.
      * platform/efl/svg/W3C-SVG-1.1/pservers-grad-04-b-expected.png: Added.
      * platform/efl/svg/W3C-SVG-1.1/pservers-grad-04-b-expected.txt: Added.
      * platform/efl/svg/W3C-SVG-1.1/pservers-grad-05-b-expected.png: Added.
      * platform/efl/svg/W3C-SVG-1.1/pservers-grad-05-b-expected.txt: Added.
      * platform/efl/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.png: Added.
      * platform/efl/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.txt: Added.
      * platform/efl/svg/W3C-SVG-1.1/pservers-grad-11-b-expected.png: Added.
      * platform/efl/svg/W3C-SVG-1.1/pservers-grad-11-b-expected.txt: Added.
      * platform/efl/svg/W3C-SVG-1.1/pservers-grad-12-b-expected.png: Added.
      * platform/efl/svg/W3C-SVG-1.1/pservers-grad-12-b-expected.txt: Added.
      * platform/efl/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.png: Added.
      * platform/efl/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.txt: Added.
      * platform/efl/svg/W3C-SVG-1.1/pservers-grad-14-b-expected.png: Added.
      * platform/efl/svg/W3C-SVG-1.1/pservers-grad-14-b-expected.txt: Added.
      * platform/efl/svg/W3C-SVG-1.1/pservers-grad-15-b-expected.png: Added.
      * platform/efl/svg/W3C-SVG-1.1/pservers-grad-15-b-expected.txt: Added.
      * platform/efl/svg/W3C-SVG-1.1/struct-use-05-b-expected.png: Added.
      * platform/efl/svg/W3C-SVG-1.1/struct-use-05-b-expected.txt: Added.
      * platform/efl/svg/W3C-SVG-1.1/styling-inherit-01-b-expected.png: Added.
      * platform/efl/svg/W3C-SVG-1.1/styling-inherit-01-b-expected.txt: Added.
      * platform/efl/svg/batik/paints/patternRegions-expected.txt:
      * platform/efl/svg/batik/paints/patternRegions-positioned-objects-expected.txt:
      * platform/efl/svg/batik/text/textEffect-expected.txt: Added.
      * platform/efl/svg/batik/text/textEffect3-expected.txt: Added.
      * platform/efl/svg/custom: Added.
      * platform/efl/svg/custom/clip-mask-negative-scale-expected.png: Added.
      * platform/efl/svg/custom/clip-mask-negative-scale-expected.txt: Added.
      * platform/efl/svg/custom/gradient-deep-referencing-expected.png: Added.
      * platform/efl/svg/custom/gradient-deep-referencing-expected.txt: Added.
      * platform/efl/svg/custom/gradient-with-1d-boundingbox-expected.png: Added.
      * platform/efl/svg/custom/gradient-with-1d-boundingbox-expected.txt: Added.
      * platform/efl/svg/custom/radial-gradient-with-outstanding-focalPoint-expected.png: Added.
      * platform/efl/svg/custom/radialGradient-focal-radius-expected.png: Added.
      * platform/efl/svg/custom/radialGradient-focal-radius-expected.txt: Added.
      * platform/efl/svg/custom/recursive-gradient-expected.png: Added.
      * platform/efl/svg/custom/recursive-gradient-expected.txt: Added.
      * platform/efl/svg/custom/relative-sized-content-with-resources-expected.png: Added.
      * platform/efl/svg/custom/relative-sized-content-with-resources-expected.txt: Added.
      * platform/efl/svg/custom/stroked-pattern-expected.png: Added.
      * platform/efl/svg/custom/stroked-pattern-expected.txt: Added.
      * platform/efl/svg/hixie/perf/006-expected.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130601 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ffead378
    • dbates@webkit.org's avatar
      Update expected results for SVG tests on EFL, GTK, and Qt after... · b52caaf5
      dbates@webkit.org authored
      Update expected results for SVG tests on EFL, GTK, and Qt after <http://trac.webkit.org/changeset/130599>
      https://bugs.webkit.org/show_bug.cgi?id=97986
      
      * platform/efl/svg/filters/feDisplacementMap-expected.txt:
      * platform/efl/svg/filters/filterRes-expected.txt:
      * platform/gtk/svg/custom/gradient-attr-update-expected.txt:
      * platform/gtk/svg/custom/gradient-rotated-bbox-expected.txt:
      * platform/gtk/svg/custom/gradient-userSpaceOnUse-with-percentage-expected.txt:
      * platform/gtk/svg/custom/large-bounding-box-percents-expected.txt:
      * platform/gtk/svg/filters/feDisplacementMap-expected.txt:
      * platform/gtk/svg/filters/filterRes-expected.txt:
      * platform/qt/svg/custom/gradient-attr-update-expected.txt:
      * platform/qt/svg/custom/gradient-rotated-bbox-expected.txt:
      * platform/qt/svg/custom/gradient-userSpaceOnUse-with-percentage-expected.txt:
      * platform/qt/svg/custom/large-bounding-box-percents-expected.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130600 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b52caaf5
    • krit@webkit.org's avatar
      SVG radialGradient should support 'fr' for focal radius (just like Canvas) · c021e2bf
      krit@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=97986
      
      Reviewed by Daniel Bates.
      
      Source/WebCore:
      
      Update SVGRadialGradient to the changed behavior in SVG2: http://www.w3.org/TR/SVG2/pservers.html#RadialGradients
      SVG2 adds the focal radius for radial gradients. Color stops will start from the edge of
      the focal radius.
      The new specification does not limit the focal point to be inside the radial gradients radius.
      This makes SVGRadialGradient consistent with the radial gradient on Canvas.
      
      Test: svg/custom/radialGradient-focal-radius.svg
      
      * rendering/svg/RenderSVGResourceRadialGradient.cpp:
          Remove checks for position of focal point. The focal point
          can be placed every where outside the radius of the gradient now.
      (WebCore::RenderSVGResourceRadialGradient::focalRadius):
          Add new method to get the focal radius from SVGRadialGradientElement.
      (WebCore::RenderSVGResourceRadialGradient::buildGradient):
      * rendering/svg/RenderSVGResourceRadialGradient.h:
      (RenderSVGResourceRadialGradient):
      * rendering/svg/SVGRenderTreeAsText.cpp:
      (WebCore::writeSVGResourceContainer):
          Modify DRT output to include the focal radius.
      * svg/RadialGradientAttributes.h:
      (WebCore::RadialGradientAttributes::RadialGradientAttributes):
      (WebCore::RadialGradientAttributes::fr):
      (WebCore::RadialGradientAttributes::setFr):
      (WebCore::RadialGradientAttributes::hasFr):
      (RadialGradientAttributes):
          New setters and getters for focal radius.
      * svg/SVGRadialGradientElement.cpp:
      (WebCore):
      (WebCore::SVGRadialGradientElement::SVGRadialGradientElement):
      (WebCore::SVGRadialGradientElement::isSupportedAttribute):
      (WebCore::SVGRadialGradientElement::parseAttribute):
      (WebCore::SVGRadialGradientElement::collectGradientAttributes):
      (WebCore::SVGRadialGradientElement::selfHasRelativeLengths):
          Ditto.
      * svg/SVGRadialGradientElement.h:
      (SVGRadialGradientElement):
      * svg/SVGRadialGradientElement.idl:
      * svg/svgattrs.in:
          Add 'fr' as new attribute to the SVG attribute list.
      
      LayoutTests:
      
      DRT changed the output to reflect the new added focal radius. A bunch of tests need
      a rebaseline on DRT.
      Added a new test for focal radius and changed behavior of focal point.
      
      * platform/chromium/TestExpectations:
      * platform/efl/TestExpectations:
      * platform/gtk/TestExpectations:
      * platform/qt/TestExpectations:
      * platform/mac/svg/W3C-SVG-1.1-SE/styling-pres-02-f-expected.txt:
      * platform/mac/svg/W3C-SVG-1.1/coords-units-01-b-expected.txt:
      * platform/mac/svg/W3C-SVG-1.1/pservers-grad-02-b-expected.txt:
      * platform/mac/svg/W3C-SVG-1.1/pservers-grad-04-b-expected.txt:
      * platform/mac/svg/W3C-SVG-1.1/pservers-grad-05-b-expected.txt:
      * platform/mac/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.txt:
      * platform/mac/svg/W3C-SVG-1.1/pservers-grad-11-b-expected.txt:
      * platform/mac/svg/W3C-SVG-1.1/pservers-grad-12-b-expected.txt:
      * platform/mac/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.txt:
      * platform/mac/svg/W3C-SVG-1.1/pservers-grad-14-b-expected.txt:
      * platform/mac/svg/W3C-SVG-1.1/pservers-grad-15-b-expected.txt:
      * platform/mac/svg/W3C-SVG-1.1/struct-use-05-b-expected.txt:
      * platform/mac/svg/W3C-SVG-1.1/styling-inherit-01-b-expected.txt:
      * platform/mac/svg/batik/paints/gradientLimit-expected.txt:
      * platform/mac/svg/batik/paints/patternRegions-expected.txt:
      * platform/mac/svg/batik/paints/patternRegions-positioned-objects-expected.txt:
      * platform/mac/svg/batik/text/textEffect-expected.txt:
      * platform/mac/svg/batik/text/textEffect3-expected.txt:
      * platform/mac/svg/custom/gradient-attr-update-expected.txt:
      * platform/mac/svg/custom/gradient-deep-referencing-expected.txt:
      * platform/mac/svg/custom/gradient-rotated-bbox-expected.txt:
      * platform/mac/svg/custom/gradient-userSpaceOnUse-with-percentage-expected.txt:
      * platform/mac/svg/custom/gradient-with-1d-boundingbox-expected.txt:
      * platform/mac/svg/custom/large-bounding-box-percents-expected.txt:
      * platform/mac/svg/custom/radialGradient-focal-radius-expected.png: Added.
      * platform/mac/svg/custom/radialGradient-focal-radius-expected.txt: Added.
      * platform/mac/svg/custom/recursive-gradient-expected.txt:
      * platform/mac/svg/custom/relative-sized-content-with-resources-expected.txt:
      * platform/mac/svg/custom/stroked-pattern-expected.txt:
      * platform/mac/svg/filters/feDisplacementMap-expected.txt:
      * platform/mac/svg/filters/filterRes-expected.txt:
      * platform/mac/svg/hixie/perf/006-expected.txt:
      * svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.txt:
      * svg/custom/gradient-stroke-width-expected.txt:
      * svg/custom/radial-gradient-with-outstanding-focalPoint-expected.txt:
      * svg/custom/radialGradient-focal-radius.svg: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130599 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c021e2bf
    • commit-queue@webkit.org's avatar
      Use start instead of -webkit-auto in default and quirks mode stylesheets. · b8da3e7c
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=98609
      
      Patch by Glenn Adams <glenn@skynav.com> on 2012-10-07
      Reviewed by Antti Koivisto.
      
      Change text-align use of legacy '-webkit-auto' to 'start' in the few places where it is used
      in default/quirks stylesheets.
      
      No new tests. No change of rendering/styling behavior. No performance impact.
      
      * css/html.css:
      (input, textarea, keygen, select, button, isindex):
      (ruby > rt):
      * css/quirks.css:
      (table):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130598 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b8da3e7c
    • commit-queue@webkit.org's avatar
      Unreviewed, rolling out r130596. · 345f46ef
      commit-queue@webkit.org authored
      http://trac.webkit.org/changeset/130596
      https://bugs.webkit.org/show_bug.cgi?id=98616
      
      Broke build bots without IPV6 support
      
      Patch by Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> on 2012-10-07
      
      Tools:
      
      * Scripts/webkitpy/common/system/platforminfo_mock.py:
      (MockPlatformInfo.is_cygwin):
      * Scripts/webkitpy/layout_tests/port/base.py:
      (Port.baseline_version_dir):
      (Port.to.start_websocket_server):
      * Scripts/webkitpy/layout_tests/port/base_unittest.py:
      (PortTest.test_operating_system):
      (PortTest.test_build_path):
      * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
      (LayoutTestApacheHttpd):
      (LayoutTestApacheHttpd.__init__):
      
      LayoutTests:
      
      * http/conf/apache2-debian-httpd.conf:
      * http/conf/apache2-httpd.conf:
      * http/conf/cygwin-httpd.conf:
      * http/conf/fedora-httpd.conf:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130597 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      345f46ef
    • rakuco@webkit.org's avatar
      webkitpy: Pass the `Listen' Apache directive from Apache, not the httpd.conf files. · e1f08160
      rakuco@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=98602
      
      Reviewed by Eric Seidel.
      
      Tools: 
      
      Unify all the different `Listen' directives present in the several
      httpd.conf files we have in LayoutTests/http/conf. For one, we
      were already passing `Listen 127.0.0.1:8000' via webkitpy before,
      and opening the other ports from the conf files.
      
      The configuration files differed mostly in the way they handled
      IPV6 ports. Some of them did not listen to IPV6 ports because the
      systems which used them sometimes did not have IPV6 support. The
      `http_server_supports_ipv6' method has been added to Port to
      address that. cygwin, on its turn, still seems to use Apache 1.3,
      which does not support IPV6 at all; the newly-added method has a
      special case for that.
      
      * Scripts/webkitpy/common/system/platforminfo_mock.py:
      (MockPlatformInfo.is_cygwin):
      * Scripts/webkitpy/layout_tests/port/base.py:
      (Port.baseline_version_dir):
      (Port.to.start_websocket_server):
      (Port.to):
      (Port.to.http_server_supports_ipv6):
      * Scripts/webkitpy/layout_tests/port/base_unittest.py:
      (PortTest.test_http_server_supports_ipv6):
      (PortTest.test_build_path):
      * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
      (LayoutTestApacheHttpd):
      (LayoutTestApacheHttpd.__init__):
      
      LayoutTests: 
      
      * http/conf/apache2-debian-httpd.conf: Remove the `Listen'
      directive and related comments, it is passed to httpd by webkitpy
      now.
      * http/conf/apache2-httpd.conf: Ditto.
      * http/conf/cygwin-httpd.conf: Ditto.
      * http/conf/fedora-httpd.conf: Ditto.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130596 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e1f08160
    • commit-queue@webkit.org's avatar
      [EFL] Skip css3/masking tests added in r130592 · 4bd3ae3e
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=98614
      
      Unreviewed EFL gardening.
      
      Skip the two css3/masking ref tests added in r130592 since
      they fail for EFL port and GTK port.
      
      Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-10-07
      
      * platform/efl/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130595 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4bd3ae3e
    • zandobersek@gmail.com's avatar
      Unreviewed GTK gardening. · 224b2552
      zandobersek@gmail.com authored
      Adding crash and failure expectations for regressions introduced through r130584.
      Adding image mismatch expectations for two new tests introduced in r130592.
      
      * platform/gtk/TestExpectations:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130594 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      224b2552
  2. 06 Oct, 2012 19 commits
    • tkent@chromium.org's avatar
      Update test expectation · f66de7e0
      tkent@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=98479
      
      Skip tests in fast/forms/date-multiple-fields/ because it needs
      ENABLE_INPUT_MULTIPLE_FIELDS_UI.
      
      * platform/chromium-android/TestExpectations:
      * platform/efl/TestExpectations:
      * platform/gtk/TestExpectations:
      * platform/mac/TestExpectations:
      * platform/qt/TestExpectations:
      * platform/win/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130593 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f66de7e0
    • krit@webkit.org's avatar
      -webkit-clip-path should parse IRIs · de10ea72
      krit@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=96381
      
      Patch by Raul Hudea <rhudea@adobe.com> on 2012-10-06
      Reviewed by Andreas Kling.
      
      Source/WebCore:
      
      Implemented the clipping via referencing a SVG clipPath. Currently it works only if the clipPath is defined
      before using it on an HTML element. The forward reference issue is tracked via https://bugs.webkit.org/show_bug.cgi?id=90405.
      
      Tests: css3/masking/clip-path-reference-userSpaceOnUse.html
             css3/masking/clip-path-reference.html
             fast/masking/parsing-clip-path-iri.html
      
      * css/CSSComputedStyleDeclaration.cpp:
      (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Add handling for SVG clipPath references.
      * css/CSSParser.cpp:
      (WebCore::CSSParser::parseValue): Add handling for SVG clipPath references.
      * css/StyleBuilder.cpp:
      (WebCore::ApplyPropertyClipPath::applyValue): Add handling for SVG references.
      * rendering/ClipPathOperation.h:
      (ReferenceClipPathOperation): Added a new class corresponding to SVG referenced clipPath.
      (WebCore::ReferenceClipPathOperation::create):
      (WebCore::ReferenceClipPathOperation::url):
      (WebCore::ReferenceClipPathOperation::fragment):
      (WebCore::ReferenceClipPathOperation::operator==):
      (WebCore::ReferenceClipPathOperation::ReferenceClipPathOperation):
      (WebCore):
      * rendering/RenderLayer.cpp:
      (WebCore::RenderLayer::paintLayerContents): Add handling for ReferenceClipPathOperation.
      * rendering/svg/RenderSVGResourceClipper.h:
      (RenderSVGResourceClipper): Made applyClippingToContext public as it needs to be called directly for HTML elements.
      
      LayoutTests:
      
      Tests for SVG referenced clipPath with both types of clipPathUnits: "userSpaceOnUse" and "objectBoundingBox".
      
      * css3/masking/clip-path-reference-expected.html: Added.
      * css3/masking/clip-path-reference-userSpaceOnUse-expected.html: Added.
      * css3/masking/clip-path-reference-userSpaceOnUse.html: Added.
      * css3/masking/clip-path-reference.html: Added.
      * fast/masking/parsing-clip-path-iri-expected.txt: Added.
      * fast/masking/parsing-clip-path-iri.html: Added.
      * platform/chromium/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130592 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      de10ea72
    • psolanki@apple.com's avatar
      Reduce calls to CGImageSourceCopyPropertiesAtIndex from frameSizeAtIndex · 175321de
      psolanki@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=98607
      
      Reviewed by Dan Bernstein.
      
      Refactor code so that we avoid a second call to CGImageSourceCopyPropertiesAtIndex under
      ImageSource::frameSizeAtIndex().
      
      No new tests because no functional change.
      
      * platform/graphics/cg/ImageSourceCG.cpp:
      (WebCore::orientationFromProperties):
      (WebCore):
      (WebCore::ImageSource::frameSizeAtIndex):
      (WebCore::ImageSource::orientationAtIndex):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130591 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      175321de
    • mrowe@apple.com's avatar
      Build fix. · c93969b0
      mrowe@apple.com authored
      Stop calling -[NSSliderCell setTitle:]. It's never done anything on OS X.
      
      * rendering/RenderThemeMac.mm:
      (WebCore::RenderThemeMac::sliderThumbHorizontal):
      (WebCore::RenderThemeMac::sliderThumbVertical):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130590 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c93969b0
    • rakuco@webkit.org's avatar
      [EFL] Mark media/audio-garbage-collect.html as flaky on WK2. · 3d1cb3c1
      rakuco@webkit.org authored
      * platform/efl-wk2/TestExpectations:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130589 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3d1cb3c1
    • kling@webkit.org's avatar
      Clipboard::types() should return an ordered collection. · 5bbe9a8c
      kling@webkit.org authored
      <http://webkit.org/b/98547>
      
      Reviewed by Darin Adler.
      
      Let Clipboard::types() return a ListHashSet<String> instead of a HashSet<String> to make sure
      it retains the order in which type strings are added.
      
      No test, this fixes an issue that was uncovered when lowering the default table size of WTF
      hash tables, causing the HashSet<String> to rehash and reorder itself.
      
      * bindings/js/JSClipboardCustom.cpp:
      (WebCore::JSClipboard::types):
      * bindings/v8/custom/V8ClipboardCustom.cpp:
      (WebCore::V8Clipboard::typesAccessorGetter):
      * dom/Clipboard.h:
      (Clipboard):
      * platform/blackberry/ClipboardBlackBerry.cpp:
      (WebCore::ClipboardBlackBerry::types):
      * platform/blackberry/ClipboardBlackBerry.h:
      (ClipboardBlackBerry):
      * platform/chromium/ChromiumDataObject.cpp:
      (WebCore::ChromiumDataObject::types):
      * platform/chromium/ChromiumDataObject.h:
      (ChromiumDataObject):
      * platform/chromium/ClipboardChromium.cpp:
      (WebCore::ClipboardChromium::types):
      * platform/chromium/ClipboardChromium.h:
      (ClipboardChromium):
      * platform/efl/ClipboardEfl.cpp:
      (WebCore::ClipboardEfl::types):
      * platform/efl/ClipboardEfl.h:
      (ClipboardEfl):
      * platform/gtk/ClipboardGtk.cpp:
      (WebCore::ClipboardGtk::types):
      * platform/gtk/ClipboardGtk.h:
      (ClipboardGtk):
      * platform/mac/ClipboardMac.h:
      (ClipboardMac):
      * platform/mac/ClipboardMac.mm:
      (WebCore::addHTMLClipboardTypesForCocoaType):
      (WebCore::ClipboardMac::types):
      * platform/qt/ClipboardQt.cpp:
      (WebCore::ClipboardQt::types):
      * platform/qt/ClipboardQt.h:
      (ClipboardQt):
      * platform/win/ClipboardWin.cpp:
      (WebCore::addMimeTypesForFormat):
      (WebCore::ClipboardWin::types):
      * platform/win/ClipboardWin.h:
      (ClipboardWin):
      * platform/wx/ClipboardWx.cpp:
      (WebCore::ClipboardWx::types):
      * platform/wx/ClipboardWx.h:
      (ClipboardWx):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130588 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5bbe9a8c
    • ggaren@apple.com's avatar
      If Node X is reachable from JavaScript, all Nodes in the same tree should be kept alive · 0d4406d5
      ggaren@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=88834
      
      Reviewed by Gavin Barraclough.
      
      Follow-up patch to address some comments by Darin Adler.
      
      * bindings/js/JSNodeCustom.h:
      (WebCore::willCreatePossiblyOrphanedTreeByRemoval): Save some space by
      collapsing comment lines. Use Node::hasChildNodes() for brevity.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130587 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0d4406d5
    • benjamin@webkit.org's avatar
      Fix weird use of KURL's protocolIs · 1b97cb98
      benjamin@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=98584
      
      Reviewed by Adam Barth.
      
      Converting a KURL to string is a bad idea.
      
      Invalid URLs can return a string that pass the tests, while an
      invalid URL will fail protocolIs().
      
      * loader/cache/CachedResource.cpp:
      (WebCore::CachedResource::removeClient):
      * platform/graphics/MediaPlayer.cpp:
      (WebCore::MediaPlayer::load):
      * platform/network/DataURL.cpp:
      (WebCore::handleDataURL):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130586 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1b97cb98
    • mitz@apple.com's avatar
      Source/WebCore: WebCore part of <rdar://problem/12446507> [mac] WebKit clients... · 708bc63b
      mitz@apple.com authored
      Source/WebCore: WebCore part of <rdar://problem/12446507> [mac] WebKit clients cannot change the behavior of text-rendering: auto
      https://bugs.webkit.org/show_bug.cgi?id=98601
      
      Reviewed by Darin Adler.
      
      * WebCore.exp.in: Exported Font::setDefaultTypesettingFeatures().
      * platform/graphics/Font.cpp:
      (WebCore::Font::s_defaultTypesettingFeatures): Defined this static.
      (WebCore::Font::setDefaultTypesettingFeatures): Added this setter.
      (WebCore::Font::defaultTypesettingFeatures): Added this getter.
      * platform/graphics/Font.h:
      (WebCore::Font::typesettingFeatures): Changed to use the value of the new static member
      s_defaultTypesettingFeatures, rather than 0, if text-redering is set to auto.
      
      Source/WebKit/mac: WebKit/mac part of <rdar://problem/12446507> [mac] WebKit clients cannot change the behavior of text-rendering: auto
      https://bugs.webkit.org/show_bug.cgi?id=98601
      
      Reviewed by Darin Adler.
      
      * WebView/WebView.mm:
      (+[WebView initialize]): Added a call to Font::setDefaultTypesettingFeatures() to enable
      kerning and ligatures if the WebKitKerningAndLigaturesEnabledByDefault user default key has
      the value YES.
      
      Source/WebKit2: WebKit2 part of <rdar://problem/12446507> [mac] WebKit clients cannot change the behavior of text-rendering: auto
      https://bugs.webkit.org/show_bug.cgi?id=98601
      
      Reviewed by Darin Adler.
      
      * Shared/WebProcessCreationParameters.cpp:
      (WebKit::WebProcessCreationParameters::WebProcessCreationParameters): Added initializer for
      to shouldEnableKerningAndLigaturesByDefault. The initial value is false.
      (WebKit::WebProcessCreationParameters::encode): Added encoding of
      shouldEnableKerningAndLigaturesByDefault.
      (WebKit::WebProcessCreationParameters::decode): Added decoding of
      shouldEnableKerningAndLigaturesByDefault.
      * Shared/WebProcessCreationParameters.h:
      (WebProcessCreationParameters): Added shouldEnableKerningAndLigaturesByDefault boolean
      member variable.
      * UIProcess/mac/WebContextMac.mm:
      (WebKit::WebContext::platformInitializeWebProcess): Changed to set
      shouldEnableKerningAndLigaturesByDefault in the process creation parameters according to
      the value of the WebKitKerningAndLigaturesEnabledByDefault user defaults key.
      * WebProcess/mac/WebProcessMac.mm:
      (WebKit::WebProcess::platformInitializeWebProcess): Added a call to
      Font::setDefaultTypesettingFeatures() to enable kerning and ligatures if requested in the
      process creation parameters.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130585 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      708bc63b
    • ggaren@apple.com's avatar
      If Node X is reachable from JavaScript, all Nodes in the same tree should be kept alive · e0fc2216
      ggaren@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=88834
      
      Reviewed by Gavin Barraclough.
      
      Source/WebCore: 
      
      * bindings/js/JSNodeCustom.cpp:
      (WebCore::isObservable): Clarified this comment, since it seems to have
      misled some folks. 
      
      * bindings/js/JSNodeCustom.h:
      (WebCore::willCreatePossiblyOrphanedTreeByRemoval): New helper function
      to ensure that a disconnected tree is visible to JavaScript.
      
      * bindings/js/ScriptState.cpp:
      (WebCore::mainWorldScriptState): Need to check for null because a document's
      frame can be null.
      
      * dom/ContainerNode.cpp:
      (WebCore::dispatchChildRemovalEvents): When we remove a subtree from the
      document, we sever the reference that JavaScript previously held by
      referencing its root. So, we give JavaScript an opportunity to establish
      a reference to the new root.
      
      LayoutTests: 
      
      * fast/dom/gc-12-expected.txt: Added.
      * fast/dom/gc-12.html: Added. Test case matches an example cited by
      Kentaro Hara <haraken@chromium.org> in bugzilla.
      
      * fast/dom/gc-3-expected.txt:
      * fast/dom/gc-3.html:
      * fast/dom/gc-5-expected.txt:
      * fast/dom/gc-5.html: Updated these tests to reflect new expected behavior.
      We've decided that disconnected trees should persist in memory. This risks
      a programmer accidentally retaining more memory than expected, but it
      also makes the API more obvious.
      
      * fast/dom/gc-dom-tree-lifetime-expected.txt: Added.
      * fast/dom/gc-dom-tree-lifetime.html: Added. Test case written by
      Kentaro Hara <haraken@chromium.org>.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130584 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e0fc2216
    • rakuco@webkit.org's avatar
      [EFL] Gardening. · 32bec245
      rakuco@webkit.org authored
      Skip fast/selectors/unqualified-hover-strict.html because it seems
      to be flaky.
      
      While here, correct its pixel expectation and fix its
      svn:mime-type property.
      
      * platform/efl/fast/selectors/unqualified-hover-strict-expected.png: Modified property svn:mime-type.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130583 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      32bec245
    • commit-queue@webkit.org's avatar
      Fix build warning : -Wunused-parameter. · 08b8abef
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=98583
      
      Patch by Byungwoo Lee <bw80.lee@samsung.com> on 2012-10-06
      Reviewed by Kentaro Hara.
      
      Use ASSERT_UNUSED() macro to remove build warning.
      
      * plugins/PluginStream.cpp:
      (WebCore::PluginStream::delayDeliveryTimerFired):
      (WebCore::PluginStream::didReceiveResponse):
      (WebCore::PluginStream::didReceiveData):
      (WebCore::PluginStream::didFail):
      (WebCore::PluginStream::didFinishLoading):
      * plugins/PluginView.cpp:
      (WebCore::PluginView::requestTimerFired):
      (WebCore::PluginView::invalidateTimerFired):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130582 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      08b8abef
    • loislo@chromium.org's avatar
      Web Inspector: NMI fix String instrumentation the way it was discussed in WK97964 · ad00355f
      loislo@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=98500
      
      Reviewed by Benjamin Poulain.
      
      Current instrumentation incorrectly covers the case when StringImpl object has been created via StringImpl::createWithTerminatingNullCharacter().
      Looks like the only way to detect the strings that has been created from literals is to compare the addresses of buffer and stringImpl + 1.
      
      Source/WebKit/chromium:
      
      * tests/MemoryInstrumentationTest.cpp:
      
      Source/WTF:
      
      * wtf/MemoryInstrumentationString.h:
      (WTF::reportMemoryUsage):
      * wtf/text/StringImpl.h:
      (WTF::StringImpl::hasInternalBuffer):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130581 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ad00355f
    • commit-queue@webkit.org's avatar
      [EFL] Gardening to make the bots green · 378144c1
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=98590
      
      Unreviewed EFL gardening.
      
      Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2012-10-06
      
      * platform/efl/TestExpectations: Skip
      fast/writing-mode/vertical-subst-font-vert-no-dflt.html after r130570.
      * platform/efl/http/tests/misc/acid3-expected.txt: Update baselines
      after r130555.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130580 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      378144c1
    • commit-queue@webkit.org's avatar
      [EFL] Add baselines for the tests which are missing expected results · 5c1a8758
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=98576
      
      Unreviewed EFL gardening.
      
      Add platform-specific baselines after r130443 and r130489.
      
      Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2012-10-06
      
      * platform/efl/TestExpectations:
      * platform/efl/fast/repaint/box-shadow-inset-repaint-expected.png: Added.
      * platform/efl/fast/repaint/box-shadow-inset-repaint-expected.txt: Added.
      * platform/efl/fast/text/vertical-rl-rtl-linebreak-expected.png: Added.
      * platform/efl/fast/text/vertical-rl-rtl-linebreak-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130579 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5c1a8758
    • commit-queue@webkit.org's avatar
      [EFL] Gardening of the WK2 Debug Bot failing tests · a40f55f9
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=98575
      
      Unreviewed EFL gardening.
      
      Skip failing tests in order to make the bots green.
      
      Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2012-10-06
      
      * platform/efl-wk1/TestExpectations:
      * platform/efl-wk2/TestExpectations:
      * platform/efl/fast/replaced/object-with-embed-url-param-expected.txt: Removed. Current results
      matches the base expectations on WK2.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130578 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a40f55f9
    • benjamin@webkit.org's avatar
      Fix build of WTFURL after r130187 · d1f331e3
      benjamin@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=98588
      
      Reviewed by Kentaro Hara.
      
      * wtf/MemoryInstrumentationParsedURL.h:
      (WTF::reportMemoryUsage):
      * wtf/url/api/ParsedURL.h:
      (WTF::ParsedURL::spec):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130577 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d1f331e3
    • zandobersek@gmail.com's avatar
      Unreviewed GTK gardening. · b187b3a5
      zandobersek@gmail.com authored
      Adding reftest failure expectations for a couple of tests that
      were introduced in r130557 and r130570.
      
      * platform/gtk/TestExpectations:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130576 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b187b3a5
    • tkent@chromium.org's avatar
      [Chromium] Rebaseline for recent INPUT_MULTIPLE_FIELDS_UI changes · 7db49554
      tkent@chromium.org authored
      * platform/chromium-linux-x86/fast/forms/date/calendar-picker-appearance-expected.png:
      * platform/chromium-linux/fast/forms/date-multiple-fields/date-multiple-fields-appearance-basic-expected.png: Added.
      * platform/chromium-linux/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-classes-expected.png: Added.
      * platform/chromium-linux/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.png: Added.
      * platform/chromium-linux/fast/forms/date-multiple-fields/date-multiple-fields-appearance-style-expected.png: Added.
      * platform/chromium-linux/fast/forms/date/calendar-picker-appearance-expected.png:
      * platform/chromium-linux/fast/forms/month-multiple-fields/month-multiple-fields-appearance-basic-expected.png:
      * platform/chromium-linux/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-classes-expected.png:
      * platform/chromium-linux/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.png:
      * platform/chromium-linux/fast/forms/month-multiple-fields/month-multiple-fields-appearance-style-expected.png:
      * platform/chromium-linux/fast/forms/week-multiple-fields/week-multiple-fields-appearance-basic-expected.png:
      * platform/chromium-linux/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-classes-expected.png:
      * platform/chromium-linux/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.png:
      * platform/chromium-linux/fast/forms/week-multiple-fields/week-multiple-fields-appearance-style-expected.png:
      * platform/chromium-linux/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-expected.png:
      * platform/chromium-linux/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-rtl-expected.png:
      * platform/chromium-linux/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-with-scroll-bar-expected.png:
      * platform/chromium-linux/platform/chromium/fast/forms/time/time-suggestion-picker-appearance-expected.png:
      * platform/chromium-linux/platform/chromium/fast/forms/time/time-suggestion-picker-appearance-rtl-expected.png:
      * platform/chromium-linux/platform/chromium/fast/forms/time/time-suggestion-picker-appearance-with-scroll-bar-expected.png:
      * platform/chromium-mac-snowleopard/fast/forms/date-multiple-fields/date-multiple-fields-appearance-basic-expected.png: Added.
      * platform/chromium-mac-snowleopard/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-classes-expected.png: Added.
      * platform/chromium-mac-snowleopard/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.png: Added.
      * platform/chromium-mac-snowleopard/fast/forms/date-multiple-fields/date-multiple-fields-appearance-style-expected.png: Added.
      * platform/chromium-mac-snowleopard/fast/forms/date/calendar-picker-appearance-expected.png:
      * platform/chromium-mac-snowleopard/fast/forms/month-multiple-fields/month-multiple-fields-appearance-basic-expected.png:
      * platform/chromium-mac-snowleopard/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-classes-expected.png:
      * platform/chromium-mac-snowleopard/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.png:
      * platform/chromium-mac-snowleopard/fast/forms/month-multiple-fields/month-multiple-fields-appearance-style-expected.png:
      * platform/chromium-mac-snowleopard/fast/forms/week-multiple-fields/week-multiple-fields-appearance-basic-expected.png:
      * platform/chromium-mac-snowleopard/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-classes-expected.png:
      * platform/chromium-mac-snowleopard/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.png:
      * platform/chromium-mac-snowleopard/fast/forms/week-multiple-fields/week-multiple-fields-appearance-style-expected.png:
      * platform/chromium-mac-snowleopard/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-expected.png:
      * platform/chromium-mac-snowleopard/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-rtl-expected.png:
      * platform/chromium-mac-snowleopard/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-with-scroll-bar-expected.png:
      * platform/chromium-mac-snowleopard/platform/chromium/fast/forms/time/time-suggestion-picker-appearance-expected.png: Added.
      * platform/chromium-mac-snowleopard/platform/chromium/fast/forms/time/time-suggestion-picker-appearance-rtl-expected.png: Added.
      * platform/chromium-mac-snowleopard/platform/chromium/fast/forms/time/time-suggestion-picker-appearance-with-scroll-bar-expected.png: Added.
      * platform/chromium-mac/fast/forms/date-multiple-fields/date-multiple-fields-appearance-basic-expected.png:
      * platform/chromium-mac/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-classes-expected.png:
      * platform/chromium-mac/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.png:
      * platform/chromium-mac/fast/forms/date-multiple-fields/date-multiple-fields-appearance-style-expected.png:
      * platform/chromium-mac/fast/forms/date/calendar-picker-appearance-expected.png:
      * platform/chromium-mac/fast/forms/month-multiple-fields/month-multiple-fields-appearance-basic-expected.png:
      * platform/chromium-mac/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-classes-expected.png:
      * platform/chromium-mac/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.png:
      * platform/chromium-mac/fast/forms/month-multiple-fields/month-multiple-fields-appearance-style-expected.png:
      * platform/chromium-mac/fast/forms/week-multiple-fields/week-multiple-fields-appearance-basic-expected.png:
      * platform/chromium-mac/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-classes-expected.png:
      * platform/chromium-mac/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.png:
      * platform/chromium-mac/fast/forms/week-multiple-fields/week-multiple-fields-appearance-style-expected.png:
      * platform/chromium-mac/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-expected.png:
      * platform/chromium-mac/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-rtl-expected.png:
      * platform/chromium-mac/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-with-scroll-bar-expected.png:
      * platform/chromium-mac/platform/chromium/fast/forms/time/time-suggestion-picker-appearance-expected.png:
      * platform/chromium-mac/platform/chromium/fast/forms/time/time-suggestion-picker-appearance-rtl-expected.png:
      * platform/chromium-mac/platform/chromium/fast/forms/time/time-suggestion-picker-appearance-with-scroll-bar-expected.png:
      * platform/chromium-win-xp/fast/forms/date/calendar-picker-appearance-expected.png:
      * platform/chromium-win/fast/forms/date-multiple-fields/date-multiple-fields-appearance-basic-expected.png: Added.
      * platform/chromium-win/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-classes-expected.png: Added.
      * platform/chromium-win/fast/forms/date-multiple-fields/date-multiple-fields-appearance-pseudo-elements-expected.png: Added.
      * platform/chromium-win/fast/forms/date-multiple-fields/date-multiple-fields-appearance-style-expected.png: Added.
      * platform/chromium-win/fast/forms/date/calendar-picker-appearance-expected.png:
      * platform/chromium-win/fast/forms/month-multiple-fields/month-multiple-fields-appearance-basic-expected.png:
      * platform/chromium-win/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-classes-expected.png:
      * platform/chromium-win/fast/forms/month-multiple-fields/month-multiple-fields-appearance-pseudo-elements-expected.png:
      * platform/chromium-win/fast/forms/month-multiple-fields/month-multiple-fields-appearance-style-expected.png:
      * platform/chromium-win/fast/forms/week-multiple-fields/week-multiple-fields-appearance-basic-expected.png:
      * platform/chromium-win/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-classes-expected.png:
      * platform/chromium-win/fast/forms/week-multiple-fields/week-multiple-fields-appearance-pseudo-elements-expected.png:
      * platform/chromium-win/fast/forms/week-multiple-fields/week-multiple-fields-appearance-style-expected.png:
      * platform/chromium-win/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-expected.png:
      * platform/chromium-win/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-rtl-expected.png:
      * platform/chromium-win/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-with-scroll-bar-expected.png:
      * platform/chromium-win/platform/chromium/fast/forms/time/time-suggestion-picker-appearance-expected.png:
      * platform/chromium-win/platform/chromium/fast/forms/time/time-suggestion-picker-appearance-rtl-expected.png:
      * platform/chromium-win/platform/chromium/fast/forms/time/time-suggestion-picker-appearance-with-scroll-bar-expected.png:
      * platform/chromium/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130575 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7db49554
  3. 05 Oct, 2012 6 commits
    • abarth@webkit.org's avatar
      [V8] toV8(Node*, ...) does more work than needed (6% faster on dom-traverse) · 95b545dd
      abarth@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=98567
      
      Reviewed by Kentaro Hara.
      
      This patch introduces toV8Fast for Node*. This function works a
      differently from the existing toV8 function in two ways:
      
      1) It uses the inline wrapper cache in Node to determine if we're
         executing in the main world. This is faster both in the case when
         isolated worlds exist because we don't need to retrieve any state
         for the current context.
      
      2) It doesn't attempt to inline the hash table lookup used to find the
         wrapper in the isolated world. There isn't a big need to inline this
         code since performance in the isolated world case is dominated by
         the hash table lookup.
      
      Because of these two changes, toV8Fast is small enough to inline into
      each attribute getter profitably. Over time, I would like to convert
      all the performance critical uses of toV8(Node*) to toV8Fast. At that
      point, we can delete toV8 and rename toV8Slow to toV8.
      
      * bindings/scripts/CodeGeneratorV8.pm:
      (GenerateHeader):
      (GenerateNormalAttrGetter):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130574 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      95b545dd
    • commit-queue@webkit.org's avatar
      [mac] REGRESSION (r122215): Animated GIF outside the viewport doesn't play when scrolled into view. · 9ddc3909
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=94874
      
      Patch by Huang Dongsung <luxtella@company100.net> on 2012-10-05
      Reviewed by Simon Fraser.
      
      Rollback previous patch because this patch caused two problems.
      1. GIF animation is occasionally paused when tiled scrolling is enabled.
      2. This change regressed Apple's Membuster benchmark by ~20% (80MB.)
      
      * loader/cache/CachedImage.cpp:
      (WebCore::CachedImage::shouldPauseAnimation):
      * loader/cache/CachedImage.h:
      (CachedImage):
      * loader/cache/CachedResource.h:
      * loader/cache/MemoryCache.cpp:
      (WebCore::MemoryCache::pruneLiveResourcesToSize):
      * rendering/RenderObject.cpp:
      (WebCore::RenderObject::willRenderImage):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130573 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9ddc3909
    • simon.fraser@apple.com's avatar
      Attempt to fix the SnowLeopard build to making the implementation of · f7954061
      simon.fraser@apple.com authored
      -isPaginated come before its use.
      
      * MiniBrowser/mac/WK1BrowserWindowController.m:
      (-[WK1BrowserWindowController reload:]):
      (-[WK1BrowserWindowController forceRepaint:]):
      (-[WK1BrowserWindowController goBack:]):
      (-[WK1BrowserWindowController goForward:]):
      (-[WK1BrowserWindowController isPaginated]):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130572 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f7954061
    • simon.fraser@apple.com's avatar
      Provide a way to run WebKit1 · 16dd2de2
      simon.fraser@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=98568
      
      Reviewed by Tim Horton.
      
      Make it possible to create both WebKit1 and WebKit2 windows in MiniBrowser.
      
      Turn BrowserWindowController into a base class; subclassed by
      WK1BrowserWindowController and WK2BrowserWindowController, each of
      which implement the BrowserController protocol.
      
      Use Command-N to get a WebKit1 window, and Command-Option-N to
      get a WK2 window. Also add "Open Location" to focus the URL bar,
      and code to add an http:// if missing.
      
      Hook up window title callbacks; append " [WK1/2]" to window title
      as appropriate.
      
      * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
      * MiniBrowser/mac/AppDelegate.m:
      (-[BrowserAppDelegate newWindow:]):
      (-[BrowserAppDelegate openPanelDidEnd:returnCode:contextInfo:]):
      * MiniBrowser/mac/BrowserWindowController.h:
      * MiniBrowser/mac/BrowserWindowController.m:
      (-[BrowserWindowController initWithWindow:]):
      (-[BrowserWindowController windowDidLoad]):
      (-[BrowserWindowController openLocation:]):
      (-[BrowserWindowController loadURLString:]):
      (-[BrowserWindowController applicationTerminating]):
      (-[BrowserWindowController addProtocolIfNecessary:]):
      * MiniBrowser/mac/MainMenu.xib:
      * MiniBrowser/mac/WK1BrowserWindowController.h: Copied from Tools/MiniBrowser/mac/BrowserWindowController.h.
      (WebView):
      * MiniBrowser/mac/WK1BrowserWindowController.m: Added.
      (-[WK1BrowserWindowController awakeFromNib]):
      (-[WK1BrowserWindowController dealloc]):
      (-[WK1BrowserWindowController loadURLString:]):
      (-[WK1BrowserWindowController fetch:]):
      (-[WK1BrowserWindowController showHideWebView:]):
      (-[WK1BrowserWindowController removeReinsertWebView:]):
      (-[WK1BrowserWindowController validateMenuItem:]):
      (-[WK1BrowserWindowController reload:]):
      (-[WK1BrowserWindowController forceRepaint:]):
      (-[WK1BrowserWindowController goBack:]):
      (-[WK1BrowserWindowController goForward:]):
      (-[WK1BrowserWindowController validateUserInterfaceItem:]):
      (-[WK1BrowserWindowController validateToolbar]):
      (-[WK1BrowserWindowController windowShouldClose:]):
      (-[WK1BrowserWindowController windowWillClose:]):
      (-[WK1BrowserWindowController applicationTerminating]):
      (-[WK1BrowserWindowController currentZoomFactor]):
      (-[WK1BrowserWindowController canZoomIn]):
      (-[WK1BrowserWindowController zoomIn:]):
      (-[WK1BrowserWindowController canZoomOut]):
      (-[WK1BrowserWindowController zoomOut:]):
      (-[WK1BrowserWindowController canResetZoom]):
      (-[WK1BrowserWindowController resetZoom:]):
      (-[WK1BrowserWindowController toggleZoomMode:]):
      (-[WK1BrowserWindowController isPaginated]):
      (-[WK1BrowserWindowController togglePaginationMode:]):
      (-[WK1BrowserWindowController find:]):
      (-[WK1BrowserWindowController dumpSourceToConsole:]):
      (-[WK1BrowserWindowController webView:didStartProvisionalLoadForFrame:]):
      (-[WK1BrowserWindowController webView:didReceiveTitle:forFrame:]):
      * MiniBrowser/mac/WK2BrowserWindowController.h: Copied from Tools/MiniBrowser/mac/BrowserWindowController.h.
      * MiniBrowser/mac/WK2BrowserWindowController.m: Copied from Tools/MiniBrowser/mac/BrowserWindowController.m.
      (-[WK2BrowserWindowController initWithContext:pageGroup:]):
      (-[WK2BrowserWindowController dealloc]):
      (-[WK2BrowserWindowController fetch:]):
      (-[WK2BrowserWindowController showHideWebView:]):
      (-[WK2BrowserWindowController removeReinsertWebView:]):
      (-[WK2BrowserWindowController validateMenuItem:]):
      (-[WK2BrowserWindowController reload:]):
      (-[WK2BrowserWindowController forceRepaint:]):
      (-[WK2BrowserWindowController goBack:]):
      (-[WK2BrowserWindowController goForward:]):
      (-[WK2BrowserWindowController validateUserInterfaceItem:]):
      (-[WK2BrowserWindowController validateToolbar]):
      (-[WK2BrowserWindowController windowShouldClose:]):
      (-[WK2BrowserWindowController windowWillClose:]):
      (-[WK2BrowserWindowController applicationTerminating]):
      (-[WK2BrowserWindowController currentZoomFactor]):
      (-[WK2BrowserWindowController setCurrentZoomFactor:]):
      (-[WK2BrowserWindowController canZoomIn]):
      (-[WK2BrowserWindowController zoomIn:]):
      (-[WK2BrowserWindowController canZoomOut]):
      (-[WK2BrowserWindowController zoomOut:]):
      (-[WK2BrowserWindowController canResetZoom]):
      (-[WK2BrowserWindowController resetZoom:]):
      (-[WK2BrowserWindowController toggleZoomMode:]):
      (-[WK2BrowserWindowController isPaginated]):
      (-[WK2BrowserWindowController togglePaginationMode:]):
      (-[WK2BrowserWindowController dumpSourceToConsole:]):
      (didStartProvisionalLoadForFrame):
      (didReceiveServerRedirectForProvisionalLoadForFrame):
      (didFailProvisionalLoadWithErrorForFrame):
      (didCommitLoadForFrame):
      (didFinishDocumentLoadForFrame):
      (didFinishLoadForFrame):
      (didFailLoadWithErrorForFrame):
      (didSameDocumentNavigationForFrame):
      (didReceiveTitleForFrame):
      (didFirstLayoutForFrame):
      (didFirstVisuallyNonEmptyLayoutForFrame):
      (didRemoveFrameFromHierarchy):
      (didDisplayInsecureContentForFrame):
      (didRunInsecureContentForFrame):
      (didDetectXSSForFrame):
      (didStartProgress):
      (didChangeProgress):
      (didFinishProgress):
      (didBecomeUnresponsive):
      (didBecomeResponsive):
      (processDidExit):
      (didChangeBackForwardList):
      (decidePolicyForNavigationAction):
      (decidePolicyForNewWindowAction):
      (decidePolicyForResponse):
      (createNewPage):
      (showPage):
      (closePage):
      (runJavaScriptAlert):
      (runJavaScriptConfirm):
      (runJavaScriptPrompt):
      (setStatusText):
      (mouseDidMoveOverElement):
      (getWindowFrame):
      (setWindowFrame):
      (runBeforeUnloadConfirmPanel):
      (runOpenPanel):
      (-[WK2BrowserWindowController awakeFromNib]):
      (-[WK2BrowserWindowController didStartProgress]):
      (-[WK2BrowserWindowController didChangeProgress:]):
      (-[WK2BrowserWindowController didFinishProgress]):
      (-[WK2BrowserWindowController updateProvisionalURLForFrame:]):
      (-[WK2BrowserWindowController didStartProvisionalLoadForFrame:]):
      (-[WK2BrowserWindowController didReceiveServerRedirectForProvisionalLoadForFrame:]):
      (-[WK2BrowserWindowController didFailProvisionalLoadWithErrorForFrame:]):
      (-[WK2BrowserWindowController didFailLoadWithErrorForFrame:]):
      (-[WK2BrowserWindowController didSameDocumentNavigationForFrame:]):
      (-[WK2BrowserWindowController didCommitLoadForFrame:]):
      (-[WK2BrowserWindowController loadURLString:]):
      (-[WK2BrowserWindowController performFindPanelAction:]):
      (-[WK2BrowserWindowController find:]):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130571 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      16dd2de2
    • wangxianzhu@chromium.org's avatar
      OpenTypeVerticalData issue with DroidSansFallback.ttf on chromium-android and chromium-linux · 61985f74
      wangxianzhu@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=97824
      
      Reviewed by Tony Chang.
      
      Source/WebCore:
      
      The issue occurred when a font that contains vert GSUB table but doesn't have
      a DFLT script and the first script doesn't have vert feature. Added logic to
      handle the case.
      
      Test: fast/writing-mode/vertical-subst-font-vert-no-dflt.html
      
      * platform/graphics/opentype/OpenTypeVerticalData.cpp:
      (FeatureList):
      (WebCore::OpenType::FeatureList::findFeature): Added to find the matching feature in FeatureList.
      (WebCore::OpenType::GSUBTable::feature): Added logic to handle the case of no DFLT script and no vert feature under the first script.
      
      LayoutTests:
      
      Ref test for the change. The punctuations in the vertical text are expected to
      be substituted with the corresponding vertical forms.
      
      * fast/writing-mode/vertical-subst-font-vert-no-dflt-expected.html: Added.
      * fast/writing-mode/vertical-subst-font-vert-no-dflt.html: Added.
      * platform/mac/TestExpectations: Added the new test as it fails on Mac because of https://bugs.webkit.org/show_bug.cgi?id=98560.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130570 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      61985f74
    • tony@chromium.org's avatar
      Form controls should always be horizontal · c3459ef9
      tony@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=98563
      
      Reviewed by Ojan Vafai.
      
      Source/WebCore:
      
      Fix a regression where we didn't force form controls to be horizontal.
      
      Tests: fast/dom/HTMLMeterElement/meter-writing-mode.html
             fast/dom/HTMLProgressElement/progress-writing-mode.html
             fast/table/colspanMinWidth-vertical.html
      
      * css/html.css:
      (input, textarea, keygen, select, button, isindex, meter, progress):
      
      LayoutTests:
      
      Convert fast/dom/HTMLMeterElement/meter-writing-mode.html and
      fast/dom/HTMLProgressElement/progress-writing-mode.html to be ref tests.
      Also rebaseline fast/table/colspanMinWidth-vertical.html and mark the
      test as needing a rebaseline on platforms other than Chromium Linux.
      
      * fast/dom/HTMLMeterElement/meter-writing-mode-expected.html: Added.
      * fast/dom/HTMLMeterElement/meter-writing-mode-expected.txt: Removed.
      * fast/dom/HTMLProgressElement/progress-writing-mode-expected.html: Added.
      * fast/dom/HTMLProgressElement/progress-writing-mode-expected.png: Removed.
      * fast/dom/HTMLProgressElement/progress-writing-mode-expected.txt: Removed.
      * platform/chromium-linux/fast/table/colspanMinWidth-vertical-expected.png:
      * platform/chromium-mac/fast/dom/HTMLMeterElement/meter-writing-mode-expected.png: Removed.
      * platform/chromium-mac/fast/dom/HTMLMeterElement/meter-writing-mode-expected.txt: Removed.
      * platform/chromium-mac/fast/dom/HTMLProgressElement/progress-writing-mode-expected.txt: Removed.
      * platform/chromium-win/fast/dom/HTMLMeterElement/meter-writing-mode-expected.png: Removed.
      * platform/chromium-win/fast/dom/HTMLMeterElement/meter-writing-mode-expected.txt: Removed.
      * platform/chromium-win/fast/dom/HTMLProgressElement/progress-writing-mode-expected.txt: Removed.
      * platform/chromium-win/fast/table/colspanMinWidth-vertical-expected.txt:
      * platform/chromium/TestExpectations:
      * platform/chromium/fast/dom/HTMLProgressElement/progress-writing-mode-expected.png: Removed.
      * platform/efl/TestExpectations:
      * platform/efl/fast/dom/HTMLMeterElement/meter-writing-mode-expected.png: Removed.
      * platform/efl/fast/dom/HTMLMeterElement/meter-writing-mode-expected.txt: Removed.
      * platform/efl/fast/dom/HTMLProgressElement/progress-writing-mode-expected.txt: Removed.
      * platform/gtk/TestExpectations:
      * platform/gtk/fast/dom/HTMLMeterElement/meter-writing-mode-expected.png: Removed.
      * platform/gtk/fast/dom/HTMLMeterElement/meter-writing-mode-expected.txt: Removed.
      * platform/gtk/fast/dom/HTMLProgressElement/progress-writing-mode-expected.txt: Removed.
      * platform/mac/TestExpectations:
      * platform/mac/fast/dom/HTMLMeterElement/meter-writing-mode-expected.png: Removed.
      * platform/mac/fast/dom/HTMLMeterElement/meter-writing-mode-expected.txt: Removed.
      * platform/mac/fast/dom/HTMLProgressElement/progress-writing-mode-expected.png: Removed.
      * platform/mac/fast/dom/HTMLProgressElement/progress-writing-mode-expected.txt: Removed.
      * platform/qt-5.0/fast/dom/HTMLProgressElement/progress-writing-mode-expected.txt: Removed.
      * platform/qt/TestExpectations:
      * platform/qt/fast/dom/HTMLMeterElement/meter-writing-mode-expected.png: Removed.
      * platform/qt/fast/dom/HTMLMeterElement/meter-writing-mode-expected.txt: Removed.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130569 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c3459ef9