1. 22 Aug, 2013 5 commits
  2. 21 Aug, 2013 23 commits
    • commit-queue@webkit.org's avatar
      Unreviewed, rolling out r154416. · 4ef33f9a
      commit-queue@webkit.org authored
      http://trac.webkit.org/changeset/154416
      https://bugs.webkit.org/show_bug.cgi?id=120147
      
      Broke Windows builds (Requested by rniwa on #webkit).
      
      Source/JavaScriptCore:
      
      * JavaScriptCore.vcxproj/JavaScriptCoreGenerated.make:
      * JavaScriptCore.vcxproj/LLInt/LLIntAssembly/LLIntAssembly.make:
      * JavaScriptCore.vcxproj/LLInt/LLIntAssembly/build-LLIntAssembly.sh:
      * JavaScriptCore.vcxproj/LLInt/LLIntDesiredOffsets/LLIntDesiredOffsets.make:
      * JavaScriptCore.vcxproj/LLInt/LLIntDesiredOffsets/build-LLIntDesiredOffsets.sh:
      * JavaScriptCore.vcxproj/build-generated-files.sh:
      
      Source/WebCore:
      
      * WebCore.vcxproj/WebCoreGenerated.make:
      * WebCore.vcxproj/WebCoreGeneratedWinCairo.make:
      * WebCore.vcxproj/WebCoreGeneratedWinCairoCommon.props:
      * WebCore.vcxproj/build-generated-files.sh:
      * WebCore.vcxproj/copyForwardingHeaders.cmd:
      * WebCore.vcxproj/copyWebCoreResourceFiles.cmd:
      
      Source/WebKit:
      
      * WebKit.vcxproj/WebKit/WebKitPostBuild.cmd:
      * WebKit.vcxproj/WebKitExportGenerator/WebKitExportGeneratorBuildCmd.cmd:
      * WebKit.vcxproj/WebKitExportGenerator/WebKitExportGeneratorPostBuild.cmd:
      * WebKit.vcxproj/WebKitExportGenerator/WebKitExportGeneratorPreBuild.cmd:
      
      Source/WTF:
      
      * WTF.vcxproj/WTFGenerated.make:
      * WTF.vcxproj/build-generated-files.sh:
      
      WebKitLibraries:
      
      * win/tools/vsprops/common.props:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154436 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4ef33f9a
    • ryuan.choi@samsung.com's avatar
      [EFL] Unreviewed build fix after r154430. · 1403dc33
      ryuan.choi@samsung.com authored
      * rendering/style/StyleRareNonInheritedData.cpp:
      (WebCore::StyleRareNonInheritedData::hasFilters): Added CSS_FILTERS guard.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154435 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1403dc33
    • simon.fraser@apple.com's avatar
      Setting -webkit-filter: in :active selector causes failure to redraw · 3d54f8b4
      simon.fraser@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=120135
      
      Source/WebCore:
      
      Reviewed by Jer Noble.
      
      When removing a filter on an inline child of a compositing layer,
      the inline loses its RenderLayer and compositing layer, but we fail to
      repaint the compositing layer that the inline is now painting into.
      
      This worked correctly for opacity, because opacity toggles cause
      layouts (which then paint the correct layer), so do the same for filters.
      
      Test: css3/filters/remove-filter-repaint.html
      
      * rendering/style/RenderStyle.cpp:
      (WebCore::RenderStyle::changeRequiresLayout): Return true if we toggled
      between having filters and not. Drive-by cleanup, making use of new convenience
      function for hasOpacity().
      * rendering/style/StyleRareNonInheritedData.cpp:
      (WebCore::StyleRareNonInheritedData::hasFilters): Returns true if we have any
      filters.
      * rendering/style/StyleRareNonInheritedData.h:
      (WebCore::StyleRareNonInheritedData::hasOpacity): Convenience function that
      returns true if opacity is < 1.
      
      LayoutTests:
      
      Reviewed by Jer Noble.
      
      Ref test for removing a filter on an inline.
      
      * css3/filters/remove-filter-repaint-expected.html: Added.
      * css3/filters/remove-filter-repaint.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154430 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3d54f8b4
    • barraclough@apple.com's avatar
      https://bugs.webkit.org/show_bug.cgi?id=120139 · 61ff98cd
      barraclough@apple.com authored
      PropertyDescriptor argument to define methods should be const
      
      Rubber stamped by Sam Weinig.
      
      This should never be modified, and this way we can use rvalues.
      
      Source/JavaScriptCore: 
      
      * debugger/DebuggerActivation.cpp:
      (JSC::DebuggerActivation::defineOwnProperty):
      * debugger/DebuggerActivation.h:
      * runtime/Arguments.cpp:
      (JSC::Arguments::defineOwnProperty):
      * runtime/Arguments.h:
      * runtime/ClassInfo.h:
      * runtime/JSArray.cpp:
      (JSC::JSArray::defineOwnProperty):
      * runtime/JSArray.h:
      * runtime/JSArrayBuffer.cpp:
      (JSC::JSArrayBuffer::defineOwnProperty):
      * runtime/JSArrayBuffer.h:
      * runtime/JSArrayBufferView.cpp:
      (JSC::JSArrayBufferView::defineOwnProperty):
      * runtime/JSArrayBufferView.h:
      * runtime/JSCell.cpp:
      (JSC::JSCell::defineOwnProperty):
      * runtime/JSCell.h:
      * runtime/JSFunction.cpp:
      (JSC::JSFunction::defineOwnProperty):
      * runtime/JSFunction.h:
      * runtime/JSGenericTypedArrayView.h:
      * runtime/JSGenericTypedArrayViewInlines.h:
      (JSC::::defineOwnProperty):
      * runtime/JSGlobalObject.cpp:
      (JSC::JSGlobalObject::defineOwnProperty):
      * runtime/JSGlobalObject.h:
      * runtime/JSObject.cpp:
      (JSC::JSObject::putIndexedDescriptor):
      (JSC::JSObject::defineOwnIndexedProperty):
      (JSC::putDescriptor):
      (JSC::JSObject::defineOwnNonIndexProperty):
      (JSC::JSObject::defineOwnProperty):
      * runtime/JSObject.h:
      * runtime/JSProxy.cpp:
      (JSC::JSProxy::defineOwnProperty):
      * runtime/JSProxy.h:
      * runtime/RegExpMatchesArray.h:
      (JSC::RegExpMatchesArray::defineOwnProperty):
      * runtime/RegExpObject.cpp:
      (JSC::RegExpObject::defineOwnProperty):
      * runtime/RegExpObject.h:
      * runtime/StringObject.cpp:
      (JSC::StringObject::defineOwnProperty):
      * runtime/StringObject.h:
          - make PropertyDescriptor const
      
      Source/WebCore: 
      
      * bindings/js/JSDOMWindowCustom.cpp:
      (WebCore::JSDOMWindow::defineOwnProperty):
      * bindings/js/JSLocationCustom.cpp:
      (WebCore::JSLocation::defineOwnProperty):
      (WebCore::JSLocationPrototype::defineOwnProperty):
      * bindings/scripts/CodeGeneratorJS.pm:
      (GenerateHeader):
          - make PropertyDescriptor const
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154422 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      61ff98cd
    • zhajiang@rim.com's avatar
      <https://webkit.org/b/120123> [BlackBerry] Incorrect origin of indexOfTile in... · 99b26bb2
      zhajiang@rim.com authored
      <https://webkit.org/b/120123> [BlackBerry] Incorrect origin of indexOfTile in LayerTiler can cause unnecessary texture jobs and waste memory
      
      Patch by Jacky Jiang <zhajiang@blackberry.com> on 2013-08-21
      Reviewed by Yong Li.
      Internally reviewed by Arvid Nilsson.
      
      JIRA 481356
      The origin of indexOfTile(origin) is incorrect in these two places. For
      example, if the maxXMaxYCorner of the rect is (768, 768), there can be
      three other redundant indexOfTile (0, 1), (1, 0), (1, 1) which can cause
      unnecessary texture jobs and waste memory.
      The origin should be the top left of the bottom right pixel of a rect.
      
      * platform/graphics/blackberry/LayerTiler.cpp:
      (WebCore::LayerTiler::updateTextureContentsIfNeeded):
      (WebCore::LayerTiler::processTextureJob):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154418 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      99b26bb2
    • simon.fraser@apple.com's avatar
      <https://webkit.org/b/116901> ASSERTION FAILED: !m_visibleDescendantStatusDirty on twitter · 115580e1
      simon.fraser@apple.com authored
      Reviewed by Beth Dakin.
      
      In order to make decisions about compositing, the m_hasVisibleDescendant bit on RenderLayers
      needs to be up-to-date when RenderLayerCompositor::computeCompositingRequirements is recursing
      over the RenderLayer tree.
      
      However, was possible for computeCompositingRequirements() to hit a layer whose m_visibleDescendantStatusDirty
      bit was set; we only clear this bit from collectLayers() (when updating z-order lists), and from styleChanged()
      which requires that style changed on the layer itself.
      
      Fix by always calling updateDescendantDependentFlags() from computeCompositingRequirements().
      
      Wasn't able to easily get a reduced testcase.
      
      * rendering/RenderLayerCompositor.cpp:
      (WebCore::RenderLayerCompositor::computeCompositingRequirements):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154417 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      115580e1
    • achristensen@apple.com's avatar
      <https://webkit.org/b/120137> Separating Win32 and Win64 builds. · 23db3941
      achristensen@apple.com authored
      Reviewed by Brent Fulgham.
      
      Source/JavaScriptCore: 
      
      * JavaScriptCore.vcxproj/JavaScriptCoreGenerated.make:
      * JavaScriptCore.vcxproj/LLInt/LLIntAssembly/LLIntAssembly.make:
      * JavaScriptCore.vcxproj/LLInt/LLIntDesiredOffsets/LLIntDesiredOffsets.make:
      Pass PlatformArchitecture as a command line parameter to bash scripts.
      * JavaScriptCore.vcxproj/LLInt/LLIntAssembly/build-LLIntAssembly.sh:
      * JavaScriptCore.vcxproj/LLInt/LLIntDesiredOffsets/build-LLIntDesiredOffsets.sh:
      * JavaScriptCore.vcxproj/build-generated-files.sh:
      Use PlatformArchitecture from command line to determine which object directory to use (obj32 or obj64).
      
      Source/WebCore: 
      
      * WebCore.vcxproj/WebCoreGenerated.make:
      * WebCore.vcxproj/WebCoreGeneratedWinCairo.make:
      Pass PlatformArchitecture as a command line parameter to bash scripts
      and use PlatformArchitecture to determine which directory to delete
      while cleaning (obj32 or obj64).
      * WebCore.vcxproj/WebCoreGeneratedWinCairoCommon.props:
      Export PlatformArchitecture to be used by make and cmd scripts.
      * WebCore.vcxproj/build-generated-files.sh:
      Use PlatformArchitecture from command line to determine which object directory to use (obj32 or obj64).
      * WebCore.vcxproj/copyForwardingHeaders.cmd:
      * WebCore.vcxproj/copyWebCoreResourceFiles.cmd:
      Use PlatformArchitecture to determine which directory to copy to (obj32 or obj64).
      
      Source/WebKit: 
      
      * WebKit.vcxproj/WebKit/WebKitPostBuild.cmd:
      * WebKit.vcxproj/WebKitExportGenerator/WebKitExportGeneratorBuildCmd.cmd:
      * WebKit.vcxproj/WebKitExportGenerator/WebKitExportGeneratorPostBuild.cmd:
      * WebKit.vcxproj/WebKitExportGenerator/WebKitExportGeneratorPreBuild.cmd:
      Use PlatformArchitecture to determine correct object directory (obj32 or obj64).
      
      Source/WTF: 
      
      * WTF.vcxproj/WTFGenerated.make:
      Pass PlatformArchitecture as a command line parameter to bash scripts.
      * WTF.vcxproj/build-generated-files.sh:
      Use PlatformArchitecture from command line to determine which object directory to use (obj32 or obj64).
      
      WebKitLibraries: 
      
      * win/tools/vsprops/common.props:
      Export PlatformArchitecture to be used by make and cmd scripts.
      Use PlatformArchitecture to determine correct build directory
      (lib32/bin32/obj32 or lib64/bin64/obj64).
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154416 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      23db3941
    • timothy_horton@apple.com's avatar
      revalidateTiles and ensureTilesForRect can share a lot of code · c34a712b
      timothy_horton@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=119282
      
      Missed the review comments, whoops.
      
      * platform/graphics/ca/mac/TileController.h:
      * platform/graphics/ca/mac/TileController.mm:
      (WebCore::TileController::prepopulateRect):
      (WebCore::TileController::revalidateTiles):
      (WebCore::TileController::ensureTilesForRect):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154415 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c34a712b
    • akling@apple.com's avatar
      <https://webkit.org/b/120115> SVG elements always have custom style resolve callbacks. · 98ebb807
      akling@apple.com authored
      Reviewed by Antti Koivisto.
      
      Simplify SVGElement construction by making them opt in to custom style resolve callbacks
      by default, and removing the ability to pass a custom ConstructionType to some subclass
      constructors.
      
      * dom/Node.h:
      
          Add HasCustomStyleResolveCallbacksFlag to the CreateSVGElement mask.
      
      * svg/SVGElement.cpp:
      (WebCore::SVGElement::SVGElement):
      * svg/SVGElement.h:
      * svg/SVGGElement.cpp:
      (WebCore::SVGGElement::SVGGElement):
      * svg/SVGGElement.h:
      * svg/SVGGraphicsElement.cpp:
      (WebCore::SVGGraphicsElement::SVGGraphicsElement):
      * svg/SVGGraphicsElement.h:
      * svg/SVGImageElement.cpp:
      (WebCore::SVGImageElement::SVGImageElement):
      * svg/SVGStyledElement.cpp:
      (WebCore::SVGStyledElement::SVGStyledElement):
      * svg/SVGStyledElement.h:
      
          Remove calls to setHasCustomStyleResolveCallbacks() in SVGElement and subclasses.
          Also remove unnecessary ConstructionType argument from subclasses since nobody
          overrides it and everyone just uses CreateSVGElement.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154414 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      98ebb807
    • timothy_horton@apple.com's avatar
      revalidateTiles and ensureTilesForRect can share a lot of code · 30200348
      timothy_horton@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=119282
      
      Reviewed by Simon Fraser.
      
      No new tests, just a refactoring.
      
      The bodies of ensureTilesForRect and revalidateTiles are nearly equivalent.
      
      * platform/graphics/ca/mac/TileController.h:
      Add an enum, NewTileType, to note whether the tiles created by ensureTilesForRect will
      be primary coverage tiles or secondary out-of-view tiles.
      
      * platform/graphics/ca/mac/TileController.mm:
      (WebCore::TileController::prepopulateRect):
      Move the code to see if we already have the requisite tiles in the
      primary coverage rect, as well as our call to updateTileCoverageMap,
      out into prepopulateRect, to generalize ensureTilesForRect.
      
      (WebCore::TileController::revalidateTiles):
      Make use of ensureTilesForRect. The platformCALayerDidCreateTiles call will happen there, now.
      
      (WebCore::TileController::ensureTilesForRect):
      Make ensureTilesForRect return the rect that it created tiles for, and only put
      tiles in a cohort if we're creating secondary tiles.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154413 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      30200348
    • timothy_horton@apple.com's avatar
      isReplacementObscured is wrong when the indicator is clipped by an iframe · 2d405bad
      timothy_horton@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=120031
      <rdar://problem/14606819>
      
      Reviewed by Simon Fraser.
      
      Hit-test for plugin obscurity in the root document. To do this, we also need
      to convert the indicator rectangle into root view coordinates before
      hit testing its edges.
      
      This resolves the case where an iframe which clips its content was reporting
      the indicator as not obscured, despite the fact that it was obscured from the
      point of view of the user.
      
      Updated test plugins/unavailable-plugin-indicator-obscurity.html
      
      * rendering/RenderEmbeddedObject.cpp:
      (WebCore::RenderEmbeddedObject::isReplacementObscured):
      
      Update the unavailable plugin indicator test to also ensure that plugins are
      correctly known to be obscured when contained within and clipped by an <iframe>.
      
      * plugins/unavailable-plugin-indicator-obscurity-expected.txt:
      * plugins/unavailable-plugin-indicator-obscurity.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154412 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2d405bad
    • akling@apple.com's avatar
      <https://webkit.org/b/120132> Frame::navigationScheduler() should return a reference. · 9ce995f2
      akling@apple.com authored
      Reviewed by Anders Carlzon.
      
      Frame::m_navigationScheduler is an inline member, not a pointer.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154409 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9ce995f2
    • timothy_horton@apple.com's avatar
      REGRESSION(r154399): broke Mac ML debug WK1 tests > 50 crashes (Requested by thorton on #webkit). · eefba76d
      timothy_horton@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=120129
      
      Rolling out http://trac.webkit.org/changeset/154399.
      
      * rendering/RenderBlock.cpp:
      * rendering/RenderBlock.h:
      * rendering/RenderBlockLineLayout.cpp:
      (WebCore::RenderBlock::LineBreaker::skipLeadingWhitespace):
      * rendering/RenderBox.h:
      
      * fast/block/margin-collapse/self-collapsing-block-with-float-descendant-expected.html: Removed.
      * fast/block/margin-collapse/self-collapsing-block-with-float-descendant.html: Removed.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154404 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      eefba76d
    • akling@apple.com's avatar
      <https://webkit.org/b/120118> Frame::animation() should return a reference. · 7c2be783
      akling@apple.com authored
      Reviewed by Anders Carlsson.
      
      Frame::m_animationController is never null.
      Also changed RenderObject::animation() to return a reference since it's just a wrapper
      around RenderObject::frame()->animation() with no null checking of frame().
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154401 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7c2be783
    • simon.fraser@apple.com's avatar
      Allow opacity to apply to custom scrollbars · 7c818704
      simon.fraser@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=120104
      
      Source/WebCore:
      
      Reviewed by David Hyatt.
      
      Opacity was ignored custom scrollbar pseudoelements because custom scrollbar
      renderers never create layers, and opacity is normally handled by the RenderLayer code.
      
      Fix by having RenderScrollbarTheme and RenderScrollbarPart do the transparency
      layers necessary for opacity. RenderScrollbarPart handles opacity for individual
      parts.
      
      Because ScrollbarThemeComposite::paint() renders the parts on after another (with
      no nesting), opacity handling for the entire scrollbar needs special-casing.
      This is done by willPaintScrollbar()/didPaintScrollbar() on the theme.
      RenderScrollbarTheme consults the opacity the scrollbar (which we get from
      the ScrollbarBGPart renderer) to decide whether to set up a transparency layer.
      
      Test: scrollbars/scrollbar-parts-opacity.html
      
      * platform/ScrollbarThemeComposite.cpp:
      (WebCore::ScrollbarThemeComposite::paint):
      * platform/ScrollbarThemeComposite.h:
      (WebCore::ScrollbarThemeComposite::willPaintScrollbar):
      (WebCore::ScrollbarThemeComposite::didPaintScrollbar):
      * rendering/RenderScrollbar.cpp:
      (WebCore::RenderScrollbar::opacity):
      * rendering/RenderScrollbar.h:
      * rendering/RenderScrollbarPart.cpp:
      (WebCore::RenderScrollbarPart::paintIntoRect):
      * rendering/RenderScrollbarTheme.cpp:
      (WebCore::RenderScrollbarTheme::willPaintScrollbar):
      (WebCore::RenderScrollbarTheme::didPaintScrollbar):
      * rendering/RenderScrollbarTheme.h:
      
      LayoutTests:
      
      Reviewed by David Hyatt.
      
      Ref test for custom scrollbars with opacity on the bar itself,
      and on the thumb.
      
      * scrollbars/scrollbar-parts-opacity-expected.html: Added.
      * scrollbars/scrollbar-parts-opacity.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154400 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7c818704
    • robert@webkit.org's avatar
      REGRESSION(r127163): Respect clearance set on ancestors when placing floats · a10ca744
      robert@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=119979
      
      Reviewed by David Hyatt.
      
      Source/WebCore:
      
      If a float has a self-collapsing ancestor with clearance then it needs to respect
      that clearance when placing itself on the line.
      
      Test: fast/block/margin-collapse/self-collapsing-block-with-float-descendant.html
      
      * rendering/RenderBlock.cpp:
      (WebCore::RenderBlock::marginOffsetForSelfCollapsingBlock):
      * rendering/RenderBlock.h:
      * rendering/RenderBlockLineLayout.cpp:
      (WebCore::RenderBlock::LineBreaker::skipLeadingWhitespace):
      * rendering/RenderBox.h:
      (WebCore::RenderBox::previousInFlowSiblingBox):
      
      LayoutTests:
      
      * fast/block/margin-collapse/self-collapsing-block-with-float-descendant-expected.html: Added.
      * fast/block/margin-collapse/self-collapsing-block-with-float-descendant.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154399 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a10ca744
    • bfulgham@apple.com's avatar
      <https://webkit.org/b/120113> [Windows] Enable CSS_IMAGE_SET · f491c1f8
      bfulgham@apple.com authored
      Reviewed by Anders Carlsson.
      
      We can now activate:
      fast/css/image-set-parsing.html
      fast/css/image-set-parsing-invalid.html
      
      * WebCore.vcxproj/WebCore.vcxproj: Add missing image set implementation files.
      * WebCore.vcxproj/WebCore.vcxproj.filters: Ditto.
      * css/CSSAllInOne.cpp: Add missing CSSImageSetValue.cpp
      * rendering/style/StyleAllInOne.cpp: Add missing StyeCachedImageSet.cpp
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154391 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f491c1f8
    • robert@webkit.org's avatar
      In RenderTableCell::paintCollapsedBorders() check surrounding cells using... · b31a601a
      robert@webkit.org authored
      In RenderTableCell::paintCollapsedBorders() check surrounding cells using physical rather than logical direction
      https://bugs.webkit.org/show_bug.cgi?id=120074
      
      Reviewed by David Hyatt.
      
      No new tests, covered by existing tests.
      
      The functions cellAbove(), cellBelow() etc. check the logical rather than the physical direction but they're being
      used to decide the painting of the physical borders of the cell. As we paint all four sides of every cell, and
      the borders of adjoining cells twice over, this has no impact on painting currently but making the check consistent
      in its treatment of physical and logical direction will help with webkit.org/b/119759 and make the code less confusing
      to the next guy.
      
      * rendering/RenderTableCell.cpp:
      (WebCore::RenderTableCell::cellAtLeft):
      (WebCore::RenderTableCell::cellAtRight):
      (WebCore::RenderTableCell::cellAtTop):
      (WebCore::RenderTableCell::cellAtBottom):
      (WebCore::RenderTableCell::paintCollapsedBorders):
      * rendering/RenderTableCell.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154389 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b31a601a
    • commit-queue@webkit.org's avatar
      <https://webkit.org/b/120109> [curl] only include WebCoreBundleWin on Windows · ccffabc9
      commit-queue@webkit.org authored
      Patch by Róbert Sipka <sipka@inf.u-szeged.hu> on 2013-08-21
      Reviewed by Brent Fulgham.
      
      The WebCoreBundleWin is a windows specific file, it is only needed on Windows.
      
      * platform/network/curl/ResourceHandleManager.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154386 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ccffabc9
    • commit-queue@webkit.org's avatar
      [Qt] Remove unused code path in PluginView · eaf80124
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113173
      
      Patch by Jae Hyun Park <jae.park@company100.net> on 2013-08-21
      Reviewed by Anders Carlsson.
      
      m_platformLayer in PluginView has been removed in r121710, but there are
      still some leftover code path related to m_platformLayer. This patch
      removes unused code path.
      
      No new tests, removing unused code paths.
      
      * plugins/PluginView.h:
      (PluginView):
      * plugins/qt/PluginViewQt.cpp:
      (WebCore::PluginView::updatePluginWidget):
      (WebCore::PluginView::paint):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154385 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      eaf80124
    • allan.jensen@digia.com's avatar
      Font’s fast code path doesn’t handle partial runs correctly when kerning or ligatures are enabled · 52ea0c9f
      allan.jensen@digia.com authored
      https://bugs.webkit.org/show_bug.cgi?id=100050
      
      Reviewed by Antti Koivisto.
      
      Source/WebCore:
      
      Always let WidthIterator iterate over an entire TextRun to avoid problems
      with pixel rounding or shaping on partial runs.
      
      This fix is necessary for Qt because the complex font-path can not disable
      shaping, leading to the complex path painting slighly different from the
      fast path, which messes up selection painting.
      
      No change in functionality, no new tests.
      
      * platform/graphics/Font.cpp:
      (WebCore::Font::drawText):
      (WebCore::Font::drawEmphasisMarks):
      (WebCore::Font::selectionRectForText):
      (WebCore::Font::offsetForPosition):
      * platform/graphics/FontFastPath.cpp:
      (WebCore::Font::getGlyphsAndAdvancesForSimpleText):
      (WebCore::Font::selectionRectForSimpleText):
      (WebCore::Font::offsetForPositionForSimpleText):
      * platform/graphics/GlyphBuffer.h:
      (WebCore::GlyphBuffer::add):
      (GlyphBuffer):
      * platform/graphics/WidthIterator.cpp:
      (WebCore::WidthIterator::advanceInternal):
      * platform/graphics/WidthIterator.h:
      (WidthIterator): Removed now unused advanceOneCharacter method.
      
      LayoutTests:
      
      * fast/text/resources/PTS55F-webfont.ttf: Added.
      * fast/text/partial-textruns-expected.html: Added.
      * fast/text/partial-textruns.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154384 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      52ea0c9f
    • tonikitoo@webkit.org's avatar
      Harden RenderBox::canBeScrolledAndHasScrollableArea logic... · 1bf1cb62
      tonikitoo@webkit.org authored
      Harden RenderBox::canBeScrolledAndHasScrollableArea logic https://bugs.webkit.org/show_bug.cgi?id=104373
      
      Reviewed by Simon Fraser.
      Patch by Antonio Gomes <a1.gomes@sisa.samsung.com>
      
      Source/WebCore:
      
      Previously if a say div has a overflown content on 'y' but is
      styled as "overflow-x: auto; overflow-y: hidden", RenderBox::canBeProgramaticallyScrolled
      would still return true. It interfers, among other things, with the way
      autoscroll works.
      
      Patch fixes it by adding two helper methods to RenderBox class in order to verify a box'
      scrollability in a given axis (x or y); They are used when checking if a given box is in
      fact programatically scrollable.
      
      Test: fast/events/autoscroll-overflow-hidden-longhands.html
      
      WebKit autoscroll behavior now matches Firefox and Opera12 (pre-blink)
      in that sense.
      
      * rendering/RenderBox.cpp:
      (WebCore::RenderBox::canBeProgramaticallyScrolled):
      * rendering/RenderBox.h:
      (WebCore::RenderBox::hasScrollableOverflowX):
      (WebCore::RenderBox::hasScrollableOverflowY):
      
      LayoutTests:
      
      Patch adds a test to ensure autoscrolling only happens on a given
      axis if it is scrollable in that direction, according to its style.
      
      * fast/events/autoscroll-overflow-hidden-longhands-expected.txt: Added.
      * fast/events/autoscroll-overflow-hidden-longhands.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154383 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1bf1cb62
    • tonikitoo@webkit.org's avatar
      Text dragging can scroll overflow:hidden boxes https://bugs.webkit.org/show_bug.cgi?id=119760 · ce8f1831
      tonikitoo@webkit.org authored
      Reviewed by Darin Adler.
      Patch by Antonio Gomes <a1.gomes@sisa.samsung.com>
      
      Source/WebCore:
      
      Consider the case of the following HTML:
      <div style="overflow:hidden; width: 100px; height: 100px" >
        <input id="input" type="text" size=10 value="any text here!"/>
        <button style="position:relative; top: 100px; left: 100px"/>
      </div>
      
      If ones starts a text selection by dragging the mouse from within the input
      field, and continues to drag beyong the outer div boundary, the latter will
      be scrolled no matter its overflow:hidden style.
      That happens because when the autoscroll has started, it gets propagated up
      to the current layer's parent layer, instead of the to current layer's enclosing
      scrollable layer.
      
      Patch fixes the issue by hardening the way scrolling is
      propagated upwards when autoscroll is being performed.
      
      RenderLayer::enclosingScrollableLayer method also got rewritten
      in terms of RenderLayer tree traversing, instead of RenderObject tree.
      The rewrite adds support for cross frame upwards traversal.
      
      Test: fast/events/autoscroll-upwards-propagation.html
      
      * rendering/RenderLayer.cpp:
      (WebCore::parentLayerCrossFrame):
      (WebCore::RenderLayer::enclosingScrollableLayer):
      (WebCore::RenderLayer::scrollRectToVisible):
      
      LayoutTests:
      
      * fast/events/autoscroll-upwards-propagation-expected.txt: Added.
      * fast/events/autoscroll-upwards-propagation.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154382 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ce8f1831
  3. 20 Aug, 2013 12 commits
    • jer.noble@apple.com's avatar
      <https://webkit.org/b/120101> [Mac] Suspended HTMLMediaElements can still hold... · de4fcd43
      jer.noble@apple.com authored
      <https://webkit.org/b/120101> [Mac] Suspended HTMLMediaElements can still hold power assertion after playback stops.
      
      Reviewed by Eric Carlson.
      
      Call updateDisplaySleep() when we clear our MediaPlayer, as doing so may kill any in-flight
      rateChanged() notifications.
      
      * html/HTMLMediaElement.cpp:
      (WebCore::HTMLMediaElement::clearMediaPlayer):
      (WebCore::HTMLMediaElement::stop):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154378 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      de4fcd43
    • gyuyoung.kim@samsung.com's avatar
      <https://webkit.org/b/92330> [CSS] Pass an image orientation data to drawImage() · b1c9a8e5
      gyuyoung.kim@samsung.com authored
      Reviewed by Beth Dakin.
      
      In support of ongoing css3-images image-orientation implementation. This patch passes
      an imageOrientationDescription object to drawImage() function as a argument. The drawImage()
      can know information of image orientation by the argument.
      
      Spec: http://www.w3.org/TR/2012/CR-css3-images-20120417/#the-image-orientation
      
      * html/HTMLCanvasElement.cpp:
      (WebCore::HTMLCanvasElement::paint):
      * html/canvas/CanvasRenderingContext2D.cpp:
      (WebCore::CanvasRenderingContext2D::drawImage):
      (WebCore::drawImageToContext):
      * platform/graphics/ImageOrientation.h: Add setter functions.
      (WebCore::ImageOrientationDescription::setRespectImageOrientation):
      (WebCore::ImageOrientationDescription::setImageOrientationEnum):
      * platform/graphics/texmap/TextureMapperImageBuffer.cpp:
      (WebCore::BitmapTextureImageBuffer::updateContents):
      * rendering/RenderBoxModelObject.cpp:
      (WebCore::RenderBoxModelObject::paintNinePieceImage):
      * rendering/RenderImage.cpp:
      (WebCore::RenderImage::paintReplaced):
      (WebCore::RenderImage::paintIntoRect):
      * rendering/RenderSnapshottedPlugIn.cpp:
      (WebCore::RenderSnapshottedPlugIn::paintSnapshot):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154375 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b1c9a8e5
    • barraclough@apple.com's avatar
      https://bugs.webkit.org/show_bug.cgi?id=120093 · 174570f9
      barraclough@apple.com authored
      Remove getOwnPropertyDescriptor trap
      
      Reviewed by Geoff Garen.
      
      All implementations of this method are now called via the method table, and equivalent in behaviour.
      Remove all duplicate implementations (and the method table trap), and add a single member function implementation on JSObject.
      
      Source/JavaScriptCore: 
      
      * API/JSCallbackObject.h:
      * API/JSCallbackObjectFunctions.h:
      * debugger/DebuggerActivation.cpp:
      * debugger/DebuggerActivation.h:
      * runtime/Arguments.cpp:
      * runtime/Arguments.h:
      * runtime/ArrayConstructor.cpp:
      * runtime/ArrayConstructor.h:
      * runtime/ArrayPrototype.cpp:
      * runtime/ArrayPrototype.h:
      * runtime/BooleanPrototype.cpp:
      * runtime/BooleanPrototype.h:
          - remove getOwnPropertyDescriptor
      * runtime/ClassInfo.h:
          - remove getOwnPropertyDescriptor from MethodTable
      * runtime/DateConstructor.cpp:
      * runtime/DateConstructor.h:
      * runtime/DatePrototype.cpp:
      * runtime/DatePrototype.h:
      * runtime/ErrorPrototype.cpp:
      * runtime/ErrorPrototype.h:
      * runtime/JSActivation.cpp:
      * runtime/JSActivation.h:
      * runtime/JSArray.cpp:
      * runtime/JSArray.h:
      * runtime/JSArrayBuffer.cpp:
      * runtime/JSArrayBuffer.h:
      * runtime/JSArrayBufferView.cpp:
      * runtime/JSArrayBufferView.h:
      * runtime/JSCell.cpp:
      * runtime/JSCell.h:
      * runtime/JSDataView.cpp:
      * runtime/JSDataView.h:
      * runtime/JSDataViewPrototype.cpp:
      * runtime/JSDataViewPrototype.h:
      * runtime/JSFunction.cpp:
      * runtime/JSFunction.h:
      * runtime/JSGenericTypedArrayView.h:
      * runtime/JSGenericTypedArrayViewInlines.h:
      * runtime/JSGlobalObject.cpp:
      * runtime/JSGlobalObject.h:
      * runtime/JSNotAnObject.cpp:
      * runtime/JSNotAnObject.h:
      * runtime/JSONObject.cpp:
      * runtime/JSONObject.h:
          - remove getOwnPropertyDescriptor
      * runtime/JSObject.cpp:
      (JSC::JSObject::propertyIsEnumerable):
          - switch to call new getOwnPropertyDescriptor member function
      (JSC::JSObject::getOwnPropertyDescriptor):
          - new, based on imlementation from GET_OWN_PROPERTY_DESCRIPTOR_IMPL
      (JSC::JSObject::defineOwnNonIndexProperty):
          - switch to call new getOwnPropertyDescriptor member function
      * runtime/JSObject.h:
      * runtime/JSProxy.cpp:
      * runtime/JSProxy.h:
      * runtime/NamePrototype.cpp:
      * runtime/NamePrototype.h:
      * runtime/NumberConstructor.cpp:
      * runtime/NumberConstructor.h:
      * runtime/NumberPrototype.cpp:
      * runtime/NumberPrototype.h:
          - remove getOwnPropertyDescriptor
      * runtime/ObjectConstructor.cpp:
      (JSC::objectConstructorGetOwnPropertyDescriptor):
      (JSC::objectConstructorSeal):
      (JSC::objectConstructorFreeze):
      (JSC::objectConstructorIsSealed):
      (JSC::objectConstructorIsFrozen):
          - switch to call new getOwnPropertyDescriptor member function
      * runtime/ObjectConstructor.h:
          - remove getOwnPropertyDescriptor
      * runtime/PropertyDescriptor.h:
          - remove GET_OWN_PROPERTY_DESCRIPTOR_IMPL
      * runtime/RegExpConstructor.cpp:
      * runtime/RegExpConstructor.h:
      * runtime/RegExpMatchesArray.cpp:
      * runtime/RegExpMatchesArray.h:
      * runtime/RegExpObject.cpp:
      * runtime/RegExpObject.h:
      * runtime/RegExpPrototype.cpp:
      * runtime/RegExpPrototype.h:
      * runtime/StringConstructor.cpp:
      * runtime/StringConstructor.h:
      * runtime/StringObject.cpp:
      * runtime/StringObject.h:
          - remove getOwnPropertyDescriptor
      
      Source/WebCore: 
      
      * WebCore.exp.in:
      * bindings/js/JSDOMWindowCustom.cpp:
      * bindings/scripts/CodeGeneratorJS.pm:
      (GenerateHeader):
      (GenerateImplementation):
      (GenerateConstructorDeclaration):
      (GenerateConstructorHelperMethods):
      * bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:
      * bindings/scripts/test/JS/JSTestActiveDOMObject.h:
      * bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp:
      * bindings/scripts/test/JS/JSTestCustomNamedGetter.h:
      * bindings/scripts/test/JS/JSTestEventConstructor.cpp:
      * bindings/scripts/test/JS/JSTestEventConstructor.h:
      * bindings/scripts/test/JS/JSTestEventTarget.cpp:
      * bindings/scripts/test/JS/JSTestEventTarget.h:
      * bindings/scripts/test/JS/JSTestException.cpp:
      * bindings/scripts/test/JS/JSTestException.h:
      * bindings/scripts/test/JS/JSTestInterface.cpp:
      * bindings/scripts/test/JS/JSTestInterface.h:
      * bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
      * bindings/scripts/test/JS/JSTestMediaQueryListListener.h:
      * bindings/scripts/test/JS/JSTestNamedConstructor.cpp:
      * bindings/scripts/test/JS/JSTestNamedConstructor.h:
      * bindings/scripts/test/JS/JSTestNode.cpp:
      * bindings/scripts/test/JS/JSTestNode.h:
      * bindings/scripts/test/JS/JSTestObj.cpp:
      * bindings/scripts/test/JS/JSTestObj.h:
      * bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:
      * bindings/scripts/test/JS/JSTestOverloadedConstructors.h:
      * bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
      * bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h:
      * bindings/scripts/test/JS/JSTestTypedefs.cpp:
      * bindings/scripts/test/JS/JSTestTypedefs.h:
      * bridge/jsc/BridgeJSC.h:
      (JSC::Bindings::Instance::getOwnPropertySlot):
      * bridge/objc/objc_runtime.h:
      * bridge/objc/objc_runtime.mm:
      * bridge/runtime_array.cpp:
      * bridge/runtime_array.h:
      * bridge/runtime_method.cpp:
      * bridge/runtime_method.h:
      * bridge/runtime_object.cpp:
      * bridge/runtime_object.h:
          - remove getOwnPropertyDescriptor
      
      Source/WebKit2: 
      
      * WebProcess/Plugins/Netscape/JSNPObject.cpp:
      * WebProcess/Plugins/Netscape/JSNPObject.h:
          - remove getOwnPropertyDescriptor
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154373 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      174570f9
    • antti@apple.com's avatar
      <https://webkit.org/b/120071> Replace NodeRenderingContext with Node* as... · dacd6dee
      antti@apple.com authored
      <https://webkit.org/b/120071> Replace NodeRenderingContext with Node* as childShouldCreateRenderer() argument
      
      Reviewed by Darin Adler.
      
      This simplifies the code. NodeRenderingContext was basically only used for getting the Node.
      
      * dom/ContainerNode.h:
      (WebCore::ContainerNode::childShouldCreateRenderer):
      * dom/Element.cpp:
      (WebCore::Element::childShouldCreateRenderer):
      * dom/Element.h:
      * dom/NodeRenderingContext.cpp:
      (WebCore::NodeRenderingContext::shouldCreateRenderer):
      * dom/NodeRenderingContext.h:
              
          Move isOnEncapsulationBoundary() to InsertionPoint.h and call it hasShadowRootOrActiveInsertionPointParent().
          Move isOnUpperEncapsulationBoundary() to ShadowRoot.h and call it hasShadowRootParent().
      
      * dom/ShadowRoot.h:
      (WebCore::hasShadowRootParent):
      * html/HTMLDetailsElement.cpp:
      (WebCore::HTMLDetailsElement::childShouldCreateRenderer):
      * html/HTMLDetailsElement.h:
      * html/HTMLFormControlElement.cpp:
      (WebCore::HTMLFormControlElement::validationMessageShadowTreeContains):
      * html/HTMLFormControlElement.h:
      * html/HTMLMediaElement.cpp:
      (WebCore::HTMLMediaElement::childShouldCreateRenderer):
      * html/HTMLMediaElement.h:
      * html/HTMLMeterElement.cpp:
      (WebCore::HTMLMeterElement::childShouldCreateRenderer):
      * html/HTMLMeterElement.h:
      * html/HTMLOptGroupElement.h:
      (WebCore::isHTMLOptGroupElement):
      * html/HTMLOptionElement.h:
      (WebCore::isHTMLOptionElement):
      * html/HTMLProgressElement.cpp:
      (WebCore::HTMLProgressElement::childShouldCreateRenderer):
      * html/HTMLProgressElement.h:
      * html/HTMLSelectElement.cpp:
      (WebCore::HTMLSelectElement::childShouldCreateRenderer):
      * html/HTMLSelectElement.h:
      * html/HTMLSummaryElement.cpp:
      (WebCore::HTMLSummaryElement::childShouldCreateRenderer):
      * html/HTMLSummaryElement.h:
      * html/HTMLTextFormControlElement.cpp:
      (WebCore::HTMLTextFormControlElement::childShouldCreateRenderer):
      (WebCore::enclosingTextFormControl):
      * html/HTMLTextFormControlElement.h:
      * html/ValidationMessage.cpp:
      (WebCore::ValidationMessage::shadowTreeContains):
      * html/ValidationMessage.h:
      * html/shadow/InsertionPoint.cpp:
      (WebCore::InsertionPoint::rendererIsNeeded):
      * html/shadow/InsertionPoint.h:
      (WebCore::isActiveInsertionPoint):
              
          Remove isShadowBoundary() as it was equivalent to isActive(). 
          Remove isLowerEncapsulationBoundary() as it was equivalent to isActiveInsertionPoint().
      
      (WebCore::hasShadowRootOrActiveInsertionPointParent):
              
          Moved and renamed from NodeRenderingContext::isOnEncapsulationBoundary().
      
      * svg/SVGAElement.cpp:
      (WebCore::SVGAElement::childShouldCreateRenderer):
      * svg/SVGAElement.h:
      * svg/SVGAltGlyphElement.cpp:
      (WebCore::SVGAltGlyphElement::childShouldCreateRenderer):
      * svg/SVGAltGlyphElement.h:
      * svg/SVGDocument.cpp:
      (WebCore::SVGDocument::childShouldCreateRenderer):
      * svg/SVGDocument.h:
      * svg/SVGElement.cpp:
      (WebCore::SVGElement::childShouldCreateRenderer):
      * svg/SVGElement.h:
      * svg/SVGFilterElement.cpp:
      (WebCore::SVGFilterElement::childShouldCreateRenderer):
      * svg/SVGFilterElement.h:
      * svg/SVGFilterPrimitiveStandardAttributes.h:
      * svg/SVGForeignObjectElement.cpp:
      (WebCore::SVGForeignObjectElement::childShouldCreateRenderer):
      * svg/SVGForeignObjectElement.h:
      * svg/SVGSVGElement.h:
      (WebCore::toSVGSVGElement):
      * svg/SVGSwitchElement.cpp:
      (WebCore::SVGSwitchElement::childShouldCreateRenderer):
      * svg/SVGSwitchElement.h:
      * svg/SVGTRefElement.cpp:
      (WebCore::SVGTRefElement::childShouldCreateRenderer):
      * svg/SVGTRefElement.h:
      * svg/SVGTSpanElement.cpp:
      (WebCore::SVGTSpanElement::childShouldCreateRenderer):
      * svg/SVGTSpanElement.h:
      * svg/SVGTextElement.cpp:
      (WebCore::SVGTextElement::childShouldCreateRenderer):
      * svg/SVGTextElement.h:
      * svg/SVGTextPathElement.cpp:
      (WebCore::SVGTextPathElement::childShouldCreateRenderer):
      * svg/SVGTextPathElement.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154371 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dacd6dee
    • benjamin@webkit.org's avatar
      <https://webkit.org/b/120050> Don't bother using a Vector for the ouput of... · 7c754a75
      benjamin@webkit.org authored
      <https://webkit.org/b/120050> Don't bother using a Vector for the ouput of querySelector, just return the first element found
      
      Reviewed by Ryosuke Niwa.
      
      Simplify the case of querySelector. Instead of using the same output type as querySelectorAll,
      simply use a trait to define what to do in the loop.
      
      * dom/SelectorQuery.cpp:
      (WebCore::AllElementExtractorSelectorQueryTrait::appendOutputForElement):
      (WebCore::SelectorDataList::queryAll):
      (WebCore::SingleElementExtractorSelectorQueryTrait::appendOutputForElement):
      (WebCore::SelectorDataList::queryFirst):
      (WebCore::SelectorDataList::executeFastPathForIdSelector):
      (WebCore::elementsForLocalName):
      (WebCore::anyElement):
      (WebCore::SelectorDataList::executeSingleTagNameSelectorData):
      (WebCore::SelectorDataList::executeSingleClassNameSelectorData):
      (WebCore::SelectorDataList::executeSingleSelectorData):
      (WebCore::SelectorDataList::executeSingleMultiSelectorData):
      (WebCore::SelectorDataList::execute):
      * dom/SelectorQuery.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154370 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7c754a75
    • antti@apple.com's avatar
      2ccd18eb
    • zhajiang@rim.com's avatar
      013-08-20 Jacky Jiang <zhajiang@blackberry.com> · ed5c64e2
      zhajiang@rim.com authored
      <https://webkit.org/b/120082> [BlackBerry] Remove unused previousTextureRect in LayerTiler
      
      Patch by Jacky Jiang <zhajiang@blackberry.com> on 2013-08-20
      Reviewed by Rob Buis.
      Internally reviewed by Mike Lattanzio and Jakob Petsovits.
      
      * platform/graphics/blackberry/LayerTiler.cpp:
      (WebCore::LayerTiler::updateTextureContentsIfNeeded):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154364 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ed5c64e2
    • antti@apple.com's avatar
      <https://webkit.org/b/120078> Replace NodeRenderingContext with RenderStyle&... · a478fdac
      antti@apple.com authored
      <https://webkit.org/b/120078> Replace NodeRenderingContext with RenderStyle& as shouldCreateRenderer() argument
      
      Reviewed by Darin Adler.
      
      This simplifies the code. NodeRenderingContext was only used for getting the RenderStyle.
      
      * dom/Element.cpp:
      (WebCore::Element::rendererIsNeeded):
      * dom/Element.h:
      * dom/NodeRenderingContext.cpp:
      (WebCore::NodeRenderingContext::elementInsideRegionNeedsRenderer):
      (WebCore::NodeRenderingContext::createRendererForElementIfNeeded):
      * dom/PseudoElement.cpp:
      (WebCore::PseudoElement::rendererIsNeeded):
      * dom/PseudoElement.h:
      * html/HTMLAppletElement.cpp:
      (WebCore::HTMLAppletElement::rendererIsNeeded):
      * html/HTMLAppletElement.h:
      * html/HTMLElement.cpp:
      (WebCore::HTMLElement::rendererIsNeeded):
      * html/HTMLElement.h:
      * html/HTMLEmbedElement.cpp:
      (WebCore::HTMLEmbedElement::rendererIsNeeded):
      * html/HTMLEmbedElement.h:
      * html/HTMLFormElement.cpp:
      (WebCore::HTMLFormElement::rendererIsNeeded):
      * html/HTMLFormElement.h:
      * html/HTMLFrameElement.cpp:
      (WebCore::HTMLFrameElement::rendererIsNeeded):
      * html/HTMLFrameElement.h:
      * html/HTMLFrameSetElement.cpp:
      (WebCore::HTMLFrameSetElement::rendererIsNeeded):
      * html/HTMLFrameSetElement.h:
      * html/HTMLIFrameElement.cpp:
      (WebCore::HTMLIFrameElement::rendererIsNeeded):
      * html/HTMLIFrameElement.h:
      * html/HTMLInputElement.cpp:
      (WebCore::HTMLInputElement::rendererIsNeeded):
      * html/HTMLInputElement.h:
      * html/HTMLMediaElement.cpp:
      (WebCore::HTMLMediaElement::rendererIsNeeded):
      * html/HTMLMediaElement.h:
      * html/HTMLObjectElement.cpp:
      (WebCore::HTMLObjectElement::rendererIsNeeded):
      * html/HTMLObjectElement.h:
      * html/HTMLOptGroupElement.h:
      * html/HTMLOptionElement.h:
      * html/HTMLVideoElement.cpp:
      (WebCore::HTMLVideoElement::rendererIsNeeded):
      * html/HTMLVideoElement.h:
      * html/shadow/DetailsMarkerControl.cpp:
      (WebCore::DetailsMarkerControl::rendererIsNeeded):
      * html/shadow/DetailsMarkerControl.h:
      * html/shadow/InsertionPoint.cpp:
      (WebCore::InsertionPoint::rendererIsNeeded):
      * html/shadow/InsertionPoint.h:
      * html/shadow/MeterShadowElement.cpp:
      (WebCore::MeterShadowElement::rendererIsNeeded):
      (WebCore::MeterInnerElement::rendererIsNeeded):
      * html/shadow/MeterShadowElement.h:
      * html/shadow/ProgressShadowElement.cpp:
      (WebCore::ProgressShadowElement::rendererIsNeeded):
      (WebCore::ProgressInnerElement::rendererIsNeeded):
      * html/shadow/ProgressShadowElement.h:
      * svg/SVGDescElement.h:
      * svg/SVGElement.h:
      (WebCore::SVGElement::rendererIsNeeded):
      * svg/SVGFilterPrimitiveStandardAttributes.cpp:
      (WebCore::SVGFilterPrimitiveStandardAttributes::rendererIsNeeded):
      * svg/SVGFilterPrimitiveStandardAttributes.h:
      * svg/SVGFontElement.h:
      * svg/SVGForeignObjectElement.cpp:
      (WebCore::SVGForeignObjectElement::rendererIsNeeded):
      * svg/SVGForeignObjectElement.h:
      * svg/SVGGElement.cpp:
      (WebCore::SVGGElement::rendererIsNeeded):
      * svg/SVGGElement.h:
      * svg/SVGGlyphElement.h:
      * svg/SVGGlyphRefElement.h:
      * svg/SVGHKernElement.h:
      * svg/SVGMarkerElement.h:
      * svg/SVGMissingGlyphElement.h:
      * svg/SVGSVGElement.cpp:
      (WebCore::SVGSVGElement::rendererIsNeeded):
      * svg/SVGSVGElement.h:
      * svg/SVGStopElement.cpp:
      (WebCore::SVGStopElement::rendererIsNeeded):
      * svg/SVGStopElement.h:
      * svg/SVGStyledElement.cpp:
      (WebCore::SVGStyledElement::rendererIsNeeded):
      * svg/SVGStyledElement.h:
      * svg/SVGTRefElement.cpp:
      (WebCore::SVGTRefElement::rendererIsNeeded):
      * svg/SVGTRefElement.h:
      * svg/SVGTSpanElement.cpp:
      (WebCore::SVGTSpanElement::rendererIsNeeded):
      * svg/SVGTSpanElement.h:
      * svg/SVGTextPathElement.cpp:
      (WebCore::SVGTextPathElement::rendererIsNeeded):
      * svg/SVGTextPathElement.h:
      * svg/SVGTitleElement.h:
      * svg/SVGVKernElement.h:
      * svg/SVGViewElement.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154361 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a478fdac
    • dbates@webkit.org's avatar
      <https://webkit.org/b/120088> Define Clipboard::hasData() only when building with drag support · a9be5099
      dbates@webkit.org authored
      Reviewed by Darin Adler.
      
      Clipboard::hasData() is specific to drag-and-drop support. We should only define it when
      such support is enabled.
      
      * dom/Clipboard.cpp: Move hasData() to DRAG_SUPPORT section of the file.
      * dom/Clipboard.h: Ditto.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154360 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a9be5099
    • antti@apple.com's avatar
      <https://webkit.org/b/120078> Replace NodeRenderingContext with RenderStyle&... · b74dfb66
      antti@apple.com authored
      <https://webkit.org/b/120078> Replace NodeRenderingContext with RenderStyle& as shouldCreateRenderer() argument
      
      Reviewed by Darin Adler.
      
      This simplifies the code. NodeRenderingContext was only used for getting the RenderStyle.
      
      * dom/Element.cpp:
      (WebCore::Element::rendererIsNeeded):
      * dom/Element.h:
      * dom/NodeRenderingContext.cpp:
      (WebCore::NodeRenderingContext::elementInsideRegionNeedsRenderer):
      (WebCore::NodeRenderingContext::createRendererForElementIfNeeded):
      * dom/PseudoElement.cpp:
      (WebCore::PseudoElement::rendererIsNeeded):
      * dom/PseudoElement.h:
      * html/HTMLAppletElement.cpp:
      (WebCore::HTMLAppletElement::rendererIsNeeded):
      * html/HTMLAppletElement.h:
      * html/HTMLElement.cpp:
      (WebCore::HTMLElement::rendererIsNeeded):
      * html/HTMLElement.h:
      * html/HTMLEmbedElement.cpp:
      (WebCore::HTMLEmbedElement::rendererIsNeeded):
      * html/HTMLEmbedElement.h:
      * html/HTMLFormElement.cpp:
      (WebCore::HTMLFormElement::rendererIsNeeded):
      * html/HTMLFormElement.h:
      * html/HTMLFrameElement.cpp:
      (WebCore::HTMLFrameElement::rendererIsNeeded):
      * html/HTMLFrameElement.h:
      * html/HTMLFrameSetElement.cpp:
      (WebCore::HTMLFrameSetElement::rendererIsNeeded):
      * html/HTMLFrameSetElement.h:
      * html/HTMLIFrameElement.cpp:
      (WebCore::HTMLIFrameElement::rendererIsNeeded):
      * html/HTMLIFrameElement.h:
      * html/HTMLInputElement.cpp:
      (WebCore::HTMLInputElement::rendererIsNeeded):
      * html/HTMLInputElement.h:
      * html/HTMLMediaElement.cpp:
      (WebCore::HTMLMediaElement::rendererIsNeeded):
      * html/HTMLMediaElement.h:
      * html/HTMLObjectElement.cpp:
      (WebCore::HTMLObjectElement::rendererIsNeeded):
      * html/HTMLObjectElement.h:
      * html/HTMLOptGroupElement.h:
      * html/HTMLOptionElement.h:
      * html/HTMLVideoElement.cpp:
      (WebCore::HTMLVideoElement::rendererIsNeeded):
      * html/HTMLVideoElement.h:
      * html/shadow/DetailsMarkerControl.cpp:
      (WebCore::DetailsMarkerControl::rendererIsNeeded):
      * html/shadow/DetailsMarkerControl.h:
      * html/shadow/InsertionPoint.cpp:
      (WebCore::InsertionPoint::rendererIsNeeded):
      * html/shadow/InsertionPoint.h:
      * html/shadow/MeterShadowElement.cpp:
      (WebCore::MeterShadowElement::rendererIsNeeded):
      (WebCore::MeterInnerElement::rendererIsNeeded):
      * html/shadow/MeterShadowElement.h:
      * html/shadow/ProgressShadowElement.cpp:
      (WebCore::ProgressShadowElement::rendererIsNeeded):
      (WebCore::ProgressInnerElement::rendererIsNeeded):
      * html/shadow/ProgressShadowElement.h:
      * svg/SVGDescElement.h:
      * svg/SVGElement.h:
      (WebCore::SVGElement::rendererIsNeeded):
      * svg/SVGFilterPrimitiveStandardAttributes.cpp:
      (WebCore::SVGFilterPrimitiveStandardAttributes::rendererIsNeeded):
      * svg/SVGFilterPrimitiveStandardAttributes.h:
      * svg/SVGFontElement.h:
      * svg/SVGForeignObjectElement.cpp:
      (WebCore::SVGForeignObjectElement::rendererIsNeeded):
      * svg/SVGForeignObjectElement.h:
      * svg/SVGGElement.cpp:
      (WebCore::SVGGElement::rendererIsNeeded):
      * svg/SVGGElement.h:
      * svg/SVGGlyphElement.h:
      * svg/SVGGlyphRefElement.h:
      * svg/SVGHKernElement.h:
      * svg/SVGMarkerElement.h:
      * svg/SVGMissingGlyphElement.h:
      * svg/SVGSVGElement.cpp:
      (WebCore::SVGSVGElement::rendererIsNeeded):
      * svg/SVGSVGElement.h:
      * svg/SVGStopElement.cpp:
      (WebCore::SVGStopElement::rendererIsNeeded):
      * svg/SVGStopElement.h:
      * svg/SVGStyledElement.cpp:
      (WebCore::SVGStyledElement::rendererIsNeeded):
      * svg/SVGStyledElement.h:
      * svg/SVGTRefElement.cpp:
      (WebCore::SVGTRefElement::rendererIsNeeded):
      * svg/SVGTRefElement.h:
      * svg/SVGTSpanElement.cpp:
      (WebCore::SVGTSpanElement::rendererIsNeeded):
      * svg/SVGTSpanElement.h:
      * svg/SVGTextPathElement.cpp:
      (WebCore::SVGTextPathElement::rendererIsNeeded):
      * svg/SVGTextPathElement.h:
      * svg/SVGTitleElement.h:
      * svg/SVGVKernElement.h:
      * svg/SVGViewElement.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154358 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b74dfb66
    • timothy_horton@apple.com's avatar
      <https://webkit.org/b/105988> [Mac] Some inspector tests intermittently assert... · 542e8f33
      timothy_horton@apple.com authored
      <https://webkit.org/b/105988> [Mac] Some inspector tests intermittently assert in InspectorOverlay::paint
      <rdar://problem/12958038>
      
      Reviewed by Joseph Pecoraro.
      
      Update the inspector overlay's layout before painting, if it is stale.
      
      No new tests; fixes an intermittent assertion failure in some existing tests.
      
      * inspector/InspectorOverlay.cpp:
      (WebCore::InspectorOverlay::paint):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154353 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      542e8f33
    • dbates@webkit.org's avatar
      Build fix after <http://trac.webkit.org/changeset/154260> (https://webkit.org/b/119949); · 6f7f26cc
      dbates@webkit.org authored
      declare Clipboard::hasData() when building with and without drag support
      
      * dom/Clipboard.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154350 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6f7f26cc