1. 08 Jun, 2007 3 commits
    • justing's avatar
      WebCore: · 8837400f
      justing authored
              Reviewed by Tristan.
              
              <rdar://problem/5250997> A crash occurs when selecting Undo Typing for a page that has been closed in tab
      
              * WebCore.exp: Added clearUndoRedoOperations.
              * page/Page.cpp:
              (WebCore::Page::clearUndoRedoOperations): Added.
              * page/Page.h:
      
      WebKit:
      
              Reviewed by Tristan.
              
              <rdar://problem/5250997> A crash occurs when selecting Undo Typing for a page that has been closed in tab
      
              * WebView/WebView.mm:
              (-[WebView _clearUndoRedoOperations]): Added.
              * WebView/WebViewPrivate.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@22065 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8837400f
    • bdash's avatar
      2007-06-08 Mark Rowe <mrowe@apple.com> · 5afdd18f
      bdash authored
              Rubber-stamped by Hyatt.
      
              Switch to using Internet Explorer's conditional comments to target IE-specific styles rather
              than doing server-side user agent checks.  This resolves an issue some people were seeing where
              caching would lead to a page generated for an Internet Explorer user being served to a Safari
              user.  The visible symptom of this was many of the graphics were missing.
      
              * blog/wp-content/themes/webkit/header.php:
              * header.inc:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@22064 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5afdd18f
    • oliver's avatar
      Reviewed by Sam "The Intern" Weinig. · ce702828
      oliver authored
              
              Don't be overzealous with the input checks, firstRectForCharacterRange
              can be determined even when there is not an active editable region.
              
              This unbreaks editing/input/range-for-empty-document which was broken
              by aforementioned overzealousness. 
      
              * WebView/WebHTMLView.mm:
              (-[WebHTMLView firstRectForCharacterRange:]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@22063 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ce702828
  2. 07 Jun, 2007 9 commits
    • hyatt's avatar
      Fix crash. Null check layer. Bug 13984. · 42ffef16
      hyatt authored
              Reviewed by andersca
      
              * WebCore.xcodeproj/project.pbxproj:
              * page/FrameView.cpp:
              (WebCore::FrameView::windowClipRectForLayer):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@22062 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      42ffef16
    • oliver's avatar
      WebCore: · ac7f5658
      oliver authored
              Reviewed by Justin.
      
              Remove incorrect assertions.
              
              These assertions were made on the assumption that 
              TSM would always call with a range that was contained 
              by an editable region.
              
              TSM may call -[WebHTMLView characterIndexForPoint:] on a mouse
              event that is otherwise unrelated to editing, which may
              be outside the current editing region, triggering these 
              assertions.
      
              * page/mac/WebCoreFrameBridge.mm:
              (-[WebCoreFrameBridge convertToNSRange:]):
      
      WebKit:
      
              Reviewed by Justin.
              
              Add checks to make sure we don't try to create, use
              or return invalid ranges to TSM when it calls us despite
              not currently being in an editable region.
      
              * WebView/WebHTMLView.mm:
              (isTextInput):
              (-[WebHTMLView textStorage]):
              (-[WebHTMLView firstRectForCharacterRange:]):
              (-[WebHTMLView selectedRange]):
              (-[WebHTMLView attributedSubstringFromRange:]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@22058 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ac7f5658
    • justing's avatar
      LayoutTests: · 47d836d7
      justing authored
              Reviewed by John.
      
              <rdar://problem/5237074> REGRESSION: editing/unsupported-content/table-delete-003 is failing (13931)
              
              Corrected the description and added a FIXME:
              * editing/unsupported-content/table-delete-003-expected.checksum:
              * editing/unsupported-content/table-delete-003-expected.png:
              * editing/unsupported-content/table-delete-003-expected.txt:
              * editing/unsupported-content/table-delete-003.html:
      
      WebCore:
      
              Reviewed by John.
              
              <rdar://problem/5237074> REGRESSION: editing/unsupported-content/table-delete-003 is failing (13931)
              
              * editing/DeleteSelectionCommand.cpp:
              (WebCore::DeleteSelectionCommand::initializeStartEnd):
              We wouldn't expand the selection to include a special element 
              at the start of the selection unless the end of the selection 
              was at the end of a special element. Avoid a special 
              element at the start as long as it's fully selected. Ditto for 
              the end.
              * editing/htmlediting.cpp:
              (WebCore::positionBeforeContainingSpecialElement):
              (WebCore::positionAfterContainingSpecialElement):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@22057 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      47d836d7
    • andersca's avatar
      Reviewed by Geoff. · 9f2c3782
      andersca authored
              Get rid of Instance::setRootObject and pass the root object to the instance constructor instead.
              
              * bindings/c/c_instance.cpp:
              (KJS::Bindings::CInstance::CInstance):
              * bindings/c/c_instance.h:
              * bindings/jni/jni_instance.cpp:
              (JavaInstance::JavaInstance):
              * bindings/jni/jni_instance.h:
              * bindings/jni/jni_jsobject.cpp:
              (JavaJSObject::convertJObjectToValue):
              * bindings/objc/objc_instance.h:
              * bindings/objc/objc_instance.mm:
              (ObjcInstance::ObjcInstance):
              * bindings/runtime.cpp:
              (KJS::Bindings::Instance::Instance):
              (KJS::Bindings::Instance::createBindingForLanguageInstance):
              * bindings/runtime.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@22056 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9f2c3782
    • andersca's avatar
      Reviewed by Adam. · ab66911c
      andersca authored
              Don't use a JavaInstance to store the field when all we want to do is to keep the field
              from being garbage collected. Instead, use a JObjectWrapper.
              
              * bindings/jni/jni_instance.h:
              * bindings/jni/jni_runtime.cpp:
              (JavaField::JavaField):
              (JavaField::dispatchValueFromInstance):
              (JavaField::dispatchSetValueToInstance):
              * bindings/jni/jni_runtime.h:
              (KJS::Bindings::JavaField::JavaField):
              (KJS::Bindings::JavaField::operator=):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@22055 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ab66911c
    • weinig's avatar
      LayoutTests: · c0e8e2e6
      weinig authored
              Reviewed by Anders.
      
              Update test for http://bugs.webkit.org/show_bug.cgi?id=14028
              Finish autogenerating the JS bindings for Node
      
              * fast/dom/prototype-chain-expected.txt: DOMNodePrototype is no longer in the prototype chain.
      
      WebCore:
      
              Reviewed by Anders.
      
              Patch for  http://bugs.webkit.org/show_bug.cgi?id=14028
              Finish autogenerating the JS bindings for Node
      
              * DerivedSources.make:
              * WebCore.pro:
              * WebCore.xcodeproj/project.pbxproj:
              * bindings/js/JSHTMLElementWrapperFactory.cpp:
              (WebCore::createJSHTMLWrapper):
              * bindings/js/JSHTMLElementWrapperFactory.h:
              * bindings/js/JSHTMLOptionElementConstructor.cpp:
              * bindings/js/JSNamedNodeMapCustom.cpp:
              * bindings/js/JSNodeCustom.cpp:
              (WebCore::JSNode::insertBefore):
              (WebCore::JSNode::replaceChild):
              (WebCore::JSNode::removeChild):
              (WebCore::JSNode::appendChild):
              (WebCore::JSNode::mark):
              (WebCore::toJS):
              * bindings/js/JSSVGElementWrapperFactory.cpp:
              (WebCore::createJSSVGWrapper):
              * bindings/js/JSSVGElementWrapperFactory.h:
              * bindings/js/JSXSLTProcessor.cpp:
              (KJS::XSLTProcessorPrototypeFunction::callAsFunction):
              * bindings/js/kjs_binding.cpp:
              (KJS::ScriptInterpreter::getDOMNodeForDocument):
              (KJS::ScriptInterpreter::putDOMNodeForDocument):
              (KJS::ScriptInterpreter::markDOMNodesForDocument):
              (KJS::ScriptInterpreter::updateDOMNodeDocument):
              * bindings/js/kjs_binding.h:
              * bindings/js/kjs_dom.cpp:
              (WebCore::toAttr):
              * bindings/js/kjs_dom.h:
              * bindings/js/kjs_domnode.h: Removed.
              * bindings/objc/DOMUtility.mm:
              (KJS::createDOMWrapper):
              * bindings/scripts/CodeGeneratorJS.pm:
              * dom/Node.h:
              (WebCore::Node::parentElement):
              * dom/Node.idl:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@22048 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c0e8e2e6
    • adele's avatar
      · 04970ea0
      adele authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@22044 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      04970ea0
    • weinig's avatar
      Another Gdk and Qt build fix. · bf8546f6
      weinig authored
              * WebCore.pro:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@22043 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bf8546f6
    • weinig's avatar
      Gdk and Qt build fix. · 1ce48569
      weinig authored
              * WebCore.pro:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@22042 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1ce48569
  3. 06 Jun, 2007 15 commits
    • weinig's avatar
      LayoutTests: · 3843e438
      weinig authored
              Reviewed by Hyatt.
      
              Update tests for http://bugs.webkit.org/show_bug.cgi?id=13973
              Autogenerate most of the rest of kjs_dom.h/cpp
      
              * fast/dom/Window/window-properties-expected.txt:
              * fast/dom/prototype-chain-expected.txt:
      
      WebCore:
      
              Reviewed by Hyatt.
      
              Patch for http://bugs.webkit.org/show_bug.cgi?id=13973
              Autogenerate most of the rest of kjs_dom.h/cpp
      
              - Autogenerate JSNodeList and JSNamedNodeMap.
              - Move JSEventTargetNode, JSNamedNodesCollection, and JSDOMExceptionConstructor 
                into their own files.
              - Rename KJS::DOMEventTargeNode to WebCore::JSEventTargetNode to adhere
                to convention and allow easier code generation.
              - Add JS constructors for JSNodeList and JSNamedNodeMap.
              - Moved more toJS methods into the correct (corresponding) header files.
              - Cleaned up code in order for changes to work.
      
              * DerivedSources.make:
              * WebCore.xcodeproj/project.pbxproj:
              * bindings/js/JSDOMExceptionConstructor.cpp: Added.
              (WebCore::):
              (WebCore::JSDOMExceptionConstructor::JSDOMExceptionConstructor):
              (WebCore::JSDOMExceptionConstructor::getOwnPropertySlot):
              (WebCore::JSDOMExceptionConstructor::getValueProperty):
              (WebCore::getDOMExceptionConstructor):
              * bindings/js/JSDOMExceptionConstructor.h: Added.
              (WebCore::JSDOMExceptionConstructor::classInfo):
              * bindings/js/JSDOMWindowCustom.cpp: Added.
              (WebCore::JSDOMWindow::customGetOwnPropertySlot):
              * bindings/js/JSDocumentCustom.cpp:
              (WebCore::JSDocument::mark):
              (WebCore::toJS):
              * bindings/js/JSEventTargetNode.cpp: Added.
              (WebCore::JSEventTargetNode::JSEventTargetNode):
              (WebCore::JSEventTargetNode::getOwnPropertySlot):
              (WebCore::JSEventTargetNode::getValueProperty):
              (WebCore::JSEventTargetNode::put):
              (WebCore::JSEventTargetNode::putValueProperty):
              (WebCore::JSEventTargetNode::setListener):
              (WebCore::JSEventTargetNode::getListener):
              (WebCore::JSEventTargetNode::pushEventHandlerScope):
              (WebCore::JSEventTargetNodePrototypeFunction::callAsFunction):
              (WebCore::toEventTargetNode):
              * bindings/js/JSEventTargetNode.h: Added.
              (WebCore::JSEventTargetNode::):
              * bindings/js/JSHTMLElementCustom.cpp:
              * bindings/js/JSHTMLFormElementCustom.cpp:
              (WebCore::JSHTMLFormElement::nameGetter):
              * bindings/js/JSHTMLOptionElementConstructor.cpp:
              * bindings/js/JSNamedNodeMapCustom.cpp: Added.
              (WebCore::JSNamedNodeMap::canGetItemsForName):
              (WebCore::JSNamedNodeMap::nameGetter):
              * bindings/js/JSNamedNodesCollection.cpp: Added.
              (WebCore::):
              (WebCore::JSNamedNodesCollection::JSNamedNodesCollection):
              (WebCore::JSNamedNodesCollection::lengthGetter):
              (WebCore::JSNamedNodesCollection::indexGetter):
              (WebCore::JSNamedNodesCollection::getOwnPropertySlot):
              * bindings/js/JSNamedNodesCollection.h: Added.
              (WebCore::JSNamedNodesCollection::classInfo):
              * bindings/js/JSNodeCustom.cpp: Added.
              (WebCore::toJS):
              * bindings/js/JSNodeListCustom.cpp: Added.
              (WebCore::JSNodeList::callAsFunction):
              (WebCore::JSNodeList::implementsCall):
              (WebCore::JSNodeList::canGetItemsForName):
              (WebCore::JSNodeList::nameGetter):
              * bindings/js/kjs_dom.cpp:
              * bindings/js/kjs_dom.h:
              * bindings/js/kjs_domnode.h:
              * bindings/js/kjs_events.cpp:
              (KJS::JSLazyEventListener::parseCode):
              * bindings/js/kjs_html.cpp:
              (KJS::JSHTMLCollection::getNamedItems):
              * bindings/js/kjs_html.h:
              * bindings/js/kjs_window.cpp:
              (WebCore::toJS):
              * bindings/js/kjs_window.h:
              * bindings/objc/DOMInternal.mm:
              (-[WebScriptObject _initializeScriptDOMNodeImp]):
              * bindings/objc/DOMUtility.mm:
              (KJS::createDOMWrapper):
              * bindings/scripts/CodeGeneratorJS.pm:
              * bridge/mac/WebCoreAXObject.mm:
              * dom/Attr.idl:
              * dom/CharacterData.idl:
              * dom/Document.idl:
              * dom/DocumentFragment.idl:
              * dom/DocumentType.idl:
              * dom/Element.idl:
              * dom/NamedNodeMap.idl:
              * dom/Node.idl:
              * dom/NodeList.idl:
              * page/DOMWindow.idl:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@22039 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3843e438
    • justing's avatar
      LayoutTests: · c0ada391
      justing authored
              Reviewed by Oliver.
      
              * editing/pasteboard/5245519-expected.checksum: Added.
              * editing/pasteboard/5245519-expected.png: Added.
              * editing/pasteboard/5245519-expected.txt: Added.
              * editing/pasteboard/5245519.html: Added.
      
      WebCore:
      
              Reviewed by Oliver.
              
              <rdar://problem/5245519> CrashTracer: [USER] 457 crashes in Mail at WebCore::CSSComputedStyleDeclaration::copyInheritableProperties()
              
              If the user pastes something into a region that ends up being
              invisible, or if the pasted content contains style spans 
              that are render-less, we'll crash when we try to remove
              redundant styles from style spans.
      
              * css/CSSComputedStyleDeclaration.cpp:
              (WebCore::CSSComputedStyleDeclaration::copyInheritableProperties):
              Add null checks.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@22038 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c0ada391
    • justing's avatar
      LayoutTests: · 735d3b21
      justing authored
              Reviewed by Harrison.
      
              <rdar://problem/4889598> Problems with moveDown: and moveUp: in Notes with ToDos
      
              * editing/selection/4889598-expected.checksum: Added.
              * editing/selection/4889598-expected.png: Added.
              * editing/selection/4889598-expected.txt: Added.
              * editing/selection/4889598.html: Added.
      
      WebCore:
      
              Reviewed by Harrison.
      
              <rdar://problem/4889598> Problems with moveDown: and moveUp: in Notes with ToDos
              
              The caret would disappear when moving from content above or below
              a ToDo if that ToDo doesn't have any content in it with the same
              x position as the caret. That's because closestLeafChildForXPos
              would return non-editable leaves, and which turn into non-editable
              VisiblePositions, which are invisible.
      
              * editing/visible_units.cpp:
              (WebCore::previousLinePosition): Ask closestLeafForXPos to only
              return editable leaves.
              (WebCore::nextLinePosition): Ditto.
              * rendering/RootInlineBox.cpp:
              (WebCore::isEditableLeaf): Added.
              (WebCore::RootInlineBox::closestLeafChildForXPos): If requested,
              return the closest editable leaf. Removed an early return if the
              position is before the first leaf, it's not really much of an
              optimization.
              * rendering/RootInlineBox.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@22037 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      735d3b21
    • weinig's avatar
      Reviewed by Anders. · e6e4a469
      weinig authored
              Fix release build.
      
              * bindings/objc/DOM.mm:
              (-[DOMDocument createNodeIterator:whatToShow:filter:expandEntityReferences:]): Add missing null initialization.
              (-[DOMDocument createTreeWalker:whatToShow:filter:expandEntityReferences:]): Add missing null initialization.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@22036 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e6e4a469
    • weinig's avatar
      LayoutTests: · 79190704
      weinig authored
              Reviewed by Hyatt.
      
              Update results for http://bugs.webkit.org/show_bug.cgi?id=13947
              Finish autogenerating the JS DOM traversal code
      
              * fast/dom/Window/window-properties-expected.txt:
      
      WebCore:
      
              Reviewed by Hyatt.
      
              Patch for http://bugs.webkit.org/show_bug.cgi?id=13947
              Finish autogenerating the JS DOM traversal code
      
              - Completely generate JSNodeFilter.
              - Move JSNodeFilterCondition into its own file
      
              * DerivedSources.make:
              * WebCore.pro:
              * WebCore.xcodeproj/project.pbxproj:
              * bindings/js/JSNodeFilterCondition.cpp: Copied from WebCore/bindings/js/kjs_traversal.cpp.
              (WebCore::JSNodeFilterCondition::JSNodeFilterCondition):
              (WebCore::JSNodeFilterCondition::mark):
              (WebCore::JSNodeFilterCondition::acceptNode):
              * bindings/js/JSNodeFilterCondition.h: Copied from WebCore/bindings/js/kjs_traversal.h.
              * bindings/js/JSNodeFilterCustom.cpp: Added.
              (WebCore::JSNodeFilter::mark):
              (WebCore::toNodeFilter):
              * bindings/js/kjs_dom.cpp:
              * bindings/js/kjs_traversal.cpp: Removed.
              * bindings/js/kjs_traversal.h: Removed.
              * bindings/js/kjs_window.cpp:
              * bindings/objc/DOM.mm:
              (-[DOMDocument createNodeIterator:whatToShow:filter:expandEntityReferences:]):
              (-[DOMDocument createTreeWalker:whatToShow:filter:expandEntityReferences:]):
              * bindings/scripts/CodeGeneratorJS.pm:
              * dom/Document.cpp:
              (WebCore::Document::createNodeIterator):
              (WebCore::Document::createTreeWalker):
              * dom/Document.h:
              * dom/NodeFilter.idl:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@22035 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      79190704
    • hyatt's avatar
      Make sure to hand back a script object for webkit plugins (the container · c8c6c6d6
      hyatt authored
              view forwards to its plugin child).
      
              Reviewed by sullivan
      
              * Plugins/WebKitPluginContainerView.h:
              * Plugins/WebKitPluginContainerView.mm:
              (-[WebKitPluginContainerView objectForWebScript]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@22033 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c8c6c6d6
    • weinig's avatar
      Reviewed by Mark Rowe. · 46a95b6b
      weinig authored
              Fixes Bug 13996: http://bugs.webkit.org/show_bug.cgi?id=13996
              [Drosera] Items in the file list don't get un-highlighted when 
              files are selected from the file drop-down
      
              * Drosera/debugger.js: currentFile was getting modified before file in the file
              browser got un-highlighted. Changed the order in which the functions execute. 
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@22031 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      46a95b6b
    • weinig's avatar
      Reviewed by Eric Seidel. · 7b5cb637
      weinig authored
              http://bugs.webkit.org/show_bug.cgi?id=14017
              Cairo: Unwanted gradient effect for small stretched images
      
              * platform/graphics/cairo/ImageCairo.cpp: Use CAIRO_FILTER_NEAREST to
              work around the issue.
              (WebCore::BitmapImage::draw):
              (WebCore::Image::drawPattern):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@22030 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7b5cb637
    • lars's avatar
      Reviewed by Zack · 0b1e6eb6
      lars authored
              Add an API to create and load plugins.
              Don't include moc files by hand anymore, rather let
              qmake handle them.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@22027 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0b1e6eb6
    • bdash's avatar
      2007-06-06 Mark Rowe <mrowe@apple.com> · 90833852
      bdash authored
              Reviewed by Maciej.
      
              http://bugs.webkit.org/show_bug.cgi?id=13988
              Bug 13988: Colon in file path crashes WebKit Nightly
      
              The WebKit launcher makes use of two `dyld' variables to coerce Safari into running with
              the bundled WebKit framework.  Both of these variables are interpreted as containing a
              colon-delimited list of paths.  There is no escaping mechanism defined, so if we detect
              a path with a colon in it we need to bail out to prevent `dyld' from throwing an error
              when we execute Safari.
      
              * WebKitLauncher/main.m:
              (main):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@22026 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      90833852
    • bdash's avatar
      2007-06-06 Mark Rowe <mrowe@apple.com> · 914fff0f
      bdash authored
              Qt build fix.
      
              * rendering/RenderTextControl.cpp: Fix case of #include filename.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@22024 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      914fff0f
    • lars's avatar
      Reviewed by Maciej. · 40e879a9
      lars authored
              Define WTF_USE_NPOBJECT for Qt. Fix includes
              in HTMLPluginElement and add proper forwarding headers
              from JavaScriptCore.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@22023 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      40e879a9
    • hyatt's avatar
      Remove bogus assert that is hit depressingly often. · e7746464
      hyatt authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@22022 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e7746464
    • hyatt's avatar
      Bulletproof windowClipRect, since it can be called at crazy times. · 73fec6f0
      hyatt authored
              Part of fix for 13972.
      
              Reviewed by olliej
      
              * bindings/objc/DOM.mm:
              (-[DOMElement _windowClipRect]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@22020 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      73fec6f0
    • hyatt's avatar
      Fix for bug 13972, quicktime doesn't respect CSS clip and overflow properties. · e514edfd
      hyatt authored
              Make sure that calls to [NSView visibleRect] will do the right thing for both
              Netscape plugins and WebKit plugins.
      
              Reviewed by olliej
      
              * Plugins/WebBaseNetscapePluginView.mm:
              (-[WebBaseNetscapePluginView visibleRect]):
              (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]):
              (-[WebBaseNetscapePluginView isOpaque]):
              * Plugins/WebKitPluginContainerView.h: Added.
              * Plugins/WebKitPluginContainerView.mm: Added.
              (-[WebKitPluginContainerView initWithFrame:DOMElement:]):
              (-[WebKitPluginContainerView dealloc]):
              (-[WebKitPluginContainerView visibleRect]):
              * Plugins/WebPluginController.mm:
              (-[WebPluginController destroyAllPlugins]):
              * WebCoreSupport/WebFrameBridge.mm:
              (-[WebFrameBridge pluginViewWithPackage:attributeNames:attributeValues:baseURL:DOMElement:loadManually:]):
              * WebKit.xcodeproj/project.pbxproj:
              * WebView/WebHTMLView.mm:
              (-[WebHTMLView addSubview:]):
              (-[WebHTMLView willRemoveSubview:]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@22019 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e514edfd
  4. 05 Jun, 2007 6 commits
    • bdash's avatar
      2007-06-05 MorganL <morganl.webkit@yahoo.com> · 936660e9
      bdash authored
              Reviewed by Dave Hyatt.
      
              Fixes http://bugs.webkit.org/show_bug.cgi?id=14008
      
              * rendering/RenderTextControl.cpp:
              (WebCore::RenderTextControl::calcHeight):
              (WebCore::RenderTextControl::calcPrefWidths):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@22017 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      936660e9
    • kmccullo's avatar
      Reviewed by. · b69a30df
      kmccullo authored
              - Respelling Oliver's name right.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@22014 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b69a30df
    • kmccullo's avatar
      Reviewed by Mark and Olliver. · 64c93c8d
      kmccullo authored
              - http://bugs.webkit.org/show_bug.cgi?id=13352  REGRESSION: Gmail hangs on send message.
              - Now we don't hang, but we do so by avoiding certain legitimate characters, the evangelism bug for this is: <rdar://problem/5252577> gmail does not accept legal characters in the form boundary
      
              * html/HTMLFormElement.cpp:
              (WebCore::getUniqueBoundaryString):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@22013 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      64c93c8d
    • andersca's avatar
      Build fix. · d866d901
      andersca authored
              
              * xml/xmlhttprequest.cpp:
              (WebCore::isValidToken):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21982 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d866d901
    • andersca's avatar
      LayoutTests: · 8166cc05
      andersca authored
              Reviewed by Geoff.
      
              <rdar://problem/5245555> REGRESSION: HTTP header injection in XMLHttpRequest.setRequestHeader
              <rdar://problem/5246208> HTTP injection in XMLHttpRequest.open method parameter
              <rdar://problem/5246242> HTTP header injection in HXMLHttpRequest.setRequestHeader header parameter
              
              * fast/dom/xmlhttprequest-invalid-values-expected.txt: Added.
              * fast/dom/xmlhttprequest-invalid-values.html: Added.
      
      WebCore:
      
              Reviewed by Geoff.
      
              <rdar://problem/5245555> REGRESSION: HTTP header injection in XMLHttpRequest.setRequestHeader
              <rdar://problem/5246208> HTTP injection in XMLHttpRequest.open method parameter
              <rdar://problem/5246242> HTTP header injection in HXMLHttpRequest.setRequestHeader header parameter
              
              Check method names, header names and header values and throw exceptions if any of them are
              invalid. This is what the new XMLHttpRequest spec states that we should do.
              
              * xml/xmlhttprequest.cpp:
              (WebCore::isValidToken):
              (WebCore::isValidHeaderValue):
              (WebCore::XMLHttpRequest::open):
              (WebCore::XMLHttpRequest::setRequestHeader):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21981 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8166cc05
    • weinig's avatar
      Reviewed by Geoff. · 2a7587bb
      weinig authored
              Optimize JSCSSStyleDeclaration after performance regression in r21854.
      
              - Check static table before name getter in JSCSSStyleDeclaration::getOwnPropertySlot()
              - Get rid of a string allocation by keeping string as KJS::Identifier for canGetItemsForName()
                functions.
      
              * WebCore.xcodeproj/project.pbxproj:
              * bindings/js/JSCSSStyleDeclarationCustom.cpp:
              (WebCore::JSCSSStyleDeclaration::canGetItemsForName):
              * bindings/js/JSHTMLAppletElementCustom.cpp:
              (WebCore::JSHTMLAppletElement::canGetItemsForName):
              * bindings/js/JSHTMLDocumentCustom.cpp:
              (WebCore::JSHTMLDocument::canGetItemsForName):
              * bindings/js/JSHTMLEmbedElementCustom.cpp:
              (WebCore::JSHTMLEmbedElement::canGetItemsForName):
              * bindings/js/JSHTMLFormElementCustom.cpp:
              (WebCore::JSHTMLFormElement::canGetItemsForName):
              * bindings/js/JSHTMLFrameSetElementCustom.cpp:
              (WebCore::JSHTMLFrameSetElement::canGetItemsForName):
              * bindings/js/JSHTMLObjectElementCustom.cpp:
              (WebCore::JSHTMLObjectElement::canGetItemsForName):
              * bindings/scripts/CodeGeneratorJS.pm:
              * css/CSSStyleDeclaration.idl:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21979 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2a7587bb
  5. 04 Jun, 2007 7 commits
    • oliver's avatar
      Reviewed by Geoff and Justin. · dcaeba3b
      oliver authored
              Fix for <rdar://problem/5246941> Clicking URL field on 
              Safari causes halt for a minute when using input methods.
              and <rdar://problem/5245964> Safari hangs for several 
              seconds when trying to select text using mouse
              
              This is a by product of the textStorage hack used to fix 
              rdar://problem/5000470 -- TSM calls textStorage repeatedly
              when changing focus, on certain mouse events, etc.  If there
              is no selection/editable region we repeatedly create an     
              NSAttributedString from the full document.  If the document is
              sufficiently long this starts consuming an inordinate amount of 
              time.
              
              This check should really have been present in the original 
              patch.
      
              * WebKit.xcodeproj/project.pbxproj:
              * WebView/WebHTMLView.mm:
              (-[WebHTMLView textStorage]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21976 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dcaeba3b
    • andersca's avatar
      Reviewed, tweaked and landed by Anders. · ae91e640
      andersca authored
              <rdar://problem/5247178> REGRESSION: With CSS Edit 2.5, a crash occurs at WebCore::DeprecatedString::DeprecatedString when page fails to be extracted
              
              Null check the provisional document loader. If an application stops the load 
              inside of the didFailProvisionalLoad delegate method, the provisional document loader will be nulled out.
      
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21975 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ae91e640
    • bdash's avatar
      2007-06-04 Alp Toker <alp.toker@collabora.co.uk> · 406271c2
      bdash authored
              Reviewed by Anders.
      
              http://bugs.webkit.org/show_bug.cgi?id=13986
              Cairo graphics fixes and cleanups
      
              * platform/graphics/ImageBuffer.h:
              * platform/graphics/cairo/ImageBufferCairo.cpp:
              (WebCore::ImageBuffer::surface): Provide surface() accessor.
              * platform/graphics/cairo/AffineTransformCairo.cpp:
              (WebCore::AffineTransform::rotate): Convert from degrees to radians to
              fix rotation.
              * platform/graphics/cairo/GraphicsContextCairo.cpp:
              (WebCore::GraphicsContext::drawRect): Add save/restore.
              (WebCore::GraphicsContext::rotate): Rename parameter to "radians" to
              avoid further confusion.
              * platform/graphics/cairo/PathCairo.cpp:
              (WebCore::Path::boundingRect): The cairo_fill_extents() parameters do
              not describe a point/size but rather the two control points of the
              rectangular region.
              (WebCore::Path::contains): Remove needless casts.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21974 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      406271c2
    • bdash's avatar
      2007-06-05 Mark Rowe <mrowe@apple.com> · a529a725
      bdash authored
              Reviewed by Anders.
      
              * WebKitLauncher/Info.plist: Update CFBundleGetInfoString, and add CFBundleShortVersionString.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21973 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a529a725
    • weinig's avatar
      Reviewed by Adam Roben. · e323bd02
      weinig authored
              Fix the buildbot.
      
              * rendering/RenderSVGContainer.cpp:
              (WebCore::RenderSVGContainer::layout):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21969 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e323bd02
    • justing's avatar
      LayoutTests: · 32efe8c0
      justing authored
              Reviewed by Kimon Tsinteris.
              
              <rdar://problem/5241148> REGRESSION: ActivEdit can't perform operations on certain selections
      
              Demonstrates bug:
              * editing/selection/5241148-expected.txt: Added.
              * editing/selection/5241148.html: Added.
              Updated to reflect new equivalents for positions before/after tables:
              * editing/selection/click-before-and-after-table-expected.txt:
              * editing/selection/click-before-and-after-table.html:
      
      WebCore:
      
              Reviewed by Kimon Tsinteris.
      
              <rdar://problem/5241148> REGRESSION: ActivEdit can't perform operations on certain selections
              
              Return valid equivalents from these methods (no [img, 1] for 
              example). ActivEdit was using positions returned from these
              methods to create new DOM Ranges.
              
              * editing/SelectionController.cpp:
              (WebCore::SelectionController::baseNode):
              (WebCore::SelectionController::baseOffset):
              (WebCore::SelectionController::extentNode):
              (WebCore::SelectionController::extentOffset):
              (WebCore::SelectionController::anchorNode):
              (WebCore::SelectionController::anchorOffset):
              (WebCore::SelectionController::focusNode):
              (WebCore::SelectionController::focusOffset):
              * editing/SelectionController.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21968 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      32efe8c0
    • rwlbuis's avatar
      Fix the svg experimental build. · f254ed5e
      rwlbuis authored
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21967 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f254ed5e