Skip to content

GitLab

Switch branch/tag
  1. 21 May, 2007 3 commits
  3. 20 May, 2007 6 commits
    • bdash's avatar
      Fix spelling. · a17d2ac0
      bdash authored 
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21613 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a17d2ac0
    • beidson's avatar
      Reviewed by Geoose Garen · 2e037c18
      beidson authored 
              <rdar://problem/4758919> - Incorrect favicon shown for URL after going back

        When restoring a cached page, we'd try to kick off the icon load for it, which ended up causing 
        shenanigans with the icon url -> page url mapping.  

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::endIfNotLoading): Only try an icon load if we're not restoring from the page cache
        (WebCore::FrameLoader::startIconLoader): Added helpful logging that helped me track this down
        (WebCore::FrameLoader::commitIconURLToIconDatabase): Ditto (and fixed a comment typo)

        * loader/icon/IconLoader.cpp:
        (WebCore::IconLoader::stopLoading): Don't null out the ResourceLoader here, as clearLoadingState() does that
        (WebCore::IconLoader::finishLoading): Added helpful logging that helped me track this down



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21612 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2e037c18
    • darin's avatar
      Reviewed by Oliver Hunt. · 29df4b01
      darin authored 
              - fix <rdar://problem/5193416> REGRESSION: Selection on large pages extremely slow

        * dom/Document.cpp: (WebCore::Document::removeMarkers): Added an early exit for the common
        case where there are no markers. Changed code to iterate over all the nodes in the range
        instead of using TextIterator, which is more efficient.
        
        * page/Frame.cpp: (WebCore::Frame::respondToChangedSelection): Added checks for editable,
        so we don't bother doing work related to spell checking and grammar checking when changing
        the selection in non-editable text. Also rearranged the code so we only compute the old
        word boundaries and sentence boundaries when actually needed, and don't do the sentence
        range checks unless grammar checking is enabled.

        * platform/TextBreakIteratorICU.cpp:
        (WebCore::setUpIterator): Don't take a locale parameter. Always pass in currentTextBreakLocaleID.
        (WebCore::characterBreakIterator): Removed local parameter.
        (WebCore::wordBreakIterator): Ditto.
        (WebCore::lineBreakIterator): Ditto.
        (WebCore::sentenceBreakIterator): Ditto.

        * platform/mac/TextBreakIteratorInternalICUMac.mm:
        (WebCore::getTextBreakLocale): Broke out the code to actually get the locale.
        (WebCore::currentTextBreakLocaleID): This function now handles only the caching and calls
        getTextBreakLocale to actually figure it out.

        * editing/visible_units.cpp: Added lots of FIXME comments, but no code change.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21611 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      29df4b01
    • staikos's avatar
      add -f to cp for some obscure build systems. · 685241da
      staikos authored 
      
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21610 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      685241da
    • staikos's avatar
      Add missing include for auto_ptr · d3ea845a
      staikos authored 
      
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21609 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d3ea845a
    • ddkilzer's avatar
      2007-05-20 David Kilzer <ddkilzer@webkit.org> · eee812d5
      ddkilzer authored 
              Reviewed by Adam Roben.

        - fix http://bugs.webkit.org/show_bug.cgi?id=13565
          Change svn-create-patch to put LayoutTests in the end

        In addition to reordering test files under the LayoutTests directory so that they
        appear after source code files, this patch fixes an issue with prepare-ChangeLog
        if the first argument passed to it is a file name instead of a directory name.

        * Scripts/prepare-ChangeLog:
        (isGIT()): If first value in @dirs array is a file, use dirname() to get the directory.
        (isSVN()): Ditto.
        * Scripts/svn-create-patch:
        (generateFileList($\%\%\%)): Differentiate test files in the LayoutTests directory from
        source code files.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21608 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      eee812d5
  5. 19 May, 2007 9 commits
    • hyatt's avatar
      Fix for bug 13785, O(n^2) counter creation. · 3071affa
      hyatt authored 
              Reviewed by darin

        * rendering/RenderCounter.cpp:
        (WebCore::findPlaceForCounter):
        (WebCore::RenderCounter::originalText):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21606 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3071affa
    • bdash's avatar
      2007-05-19 Mitz Pettel <mitz@webkit.org> · 97b9586a
      bdash authored 
              Reviewed by Dave Hyatt.

        - fix http://bugs.webkit.org/show_bug.cgi?id=12729
          box-shadow disappears when scrolling a div that it falls on/under

        Tests: fast/repaint/box-shadow-dynamic.html
               fast/repaint/box-shadow-h.html
               fast/repaint/box-shadow-v.html

        * rendering/InlineFlowBox.cpp:
        (WebCore::InlineFlowBox::placeBoxesHorizontally): Factor in box shadow.
        (WebCore::InlineFlowBox::placeBoxesVertically): Ditto.
        (WebCore::InlineFlowBox::paint): Account for box shadow when checking if
        the damage rect intersects.
        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::overflowHeight): For overflow areas, when asked
        for the "exterior" overflow, add box shadow overflow.
        (WebCore::RenderBlock::overflowWidth): Ditto.
        (WebCore::RenderBlock::overflowLeft): Ditto.
        (WebCore::RenderBlock::overflowTop): Ditto.
        (WebCore::RenderBlock::overflowRect): Ditto.
        (WebCore::RenderBlock::layoutBlock): Factor box shadow into visual overflow.
        * rendering/RenderFlexibleBox.cpp:
        (WebCore::RenderFlexibleBox::layoutBlock): Ditto.
        * rendering/RenderFlow.cpp:
        (WebCore::RenderFlow::lowestPosition): For overflow areas, when asked for
        the "exterior" extreme position, add box shadow.
        (WebCore::RenderFlow::rightmostPosition): Ditto.
        (WebCore::RenderFlow::leftmostPosition): Ditto.
        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::calculateRects): Avoid clipping out box shadow.
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::repaintAfterLayoutIfNeeded): Make sure to paint
        the box shadow when an edge with a shadow moves.
        (WebCore::RenderObject::adjustRectForOutlineAndShadow): Helper function
        that expands a given rectangle to encompass outline and box shadow.
        (WebCore::RenderObject::absoluteOutlineBox): Changed to include box shadow.
        * rendering/RenderObject.h:

2007-05-19  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Dave Hyatt.

        - repaint tests and updated results for http://bugs.webkit.org/show_bug.cgi?id=12729
          box-shadow disappears when scrolling a div that it falls on/under

        * fast/box-shadow/basic-shadows-expected.checksum:
        * fast/box-shadow/basic-shadows-expected.png:
        * fast/box-shadow/basic-shadows-expected.txt:
        * fast/repaint/box-shadow-dynamic-expected.checksum: Added.
        * fast/repaint/box-shadow-dynamic-expected.png: Added.
        * fast/repaint/box-shadow-dynamic-expected.txt: Added.
        * fast/repaint/box-shadow-dynamic.html: Added.
        * fast/repaint/box-shadow-h-expected.checksum: Added.
        * fast/repaint/box-shadow-h-expected.png: Added.
        * fast/repaint/box-shadow-h-expected.txt: Added.
        * fast/repaint/box-shadow-h.html: Added.
        * fast/repaint/box-shadow-v-expected.checksum: Added.
        * fast/repaint/box-shadow-v-expected.png: Added.
        * fast/repaint/box-shadow-v-expected.txt: Added.
        * fast/repaint/box-shadow-v.html: Added.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21605 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      97b9586a
    • bdash's avatar
      2007-05-20 Mark Rowe <mrowe@apple.com> · 42db1e6f
      bdash authored 
              Update test results after r21597.

        * fast/frames/viewsource-attribute-expected.checksum:
        * fast/frames/viewsource-attribute-expected.png:
        * fast/frames/viewsource-attribute-expected.txt:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21604 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      42db1e6f
    • bdash's avatar
      2007-05-19 Mitz Pettel <mitz@webkit.org> · 357ba6b5
      bdash authored 
              Reviewed by Dave Hyatt.

        - fix http://bugs.webkit.org/show_bug.cgi?id=13783
          REGRESSION (r21120): Frame resizers not repainted properly when dragged

        * rendering/RenderFrameSet.cpp:
        (WebCore::RenderFrameSet::layout):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21603 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      357ba6b5
    • bdash's avatar
      2007-05-19 Mitz Pettel <mitz@webkit.org> · 7746786d
      bdash authored 
              Reviewed by Darin.

        - fix http://bugs.webkit.org/show_bug.cgi?id=13774
          REGRESSION: Crash emailing blog entry using Google Reader

        Test: fast/table/stale-grid-crash.html

        * rendering/RenderTable.cpp:
        (WebCore::RenderTable::recalcSections): Made const and replaced
        setNeedsLayout(true) with an assertion that the table is already
        marked for layout.
        (WebCore::RenderTable::sectionAbove): Added call to recalcSectionsIfNeeded().
        (WebCore::RenderTable::sectionBelow): Ditto.
        (WebCore::RenderTable::cellAbove): Ditto.
        (WebCore::RenderTable::cellBelow): Ditto.
        (WebCore::RenderTable::cellBefore): Ditto.
        (WebCore::RenderTable::cellAfter): Ditto.
        * rendering/RenderTable.h:
        Made some private member variables which are used in section recalc mutable.
        (WebCore::RenderTable::setNeedsSectionRecalc): Moved the call to
        setNeedsLayout() from recalcSections() into here, because I made
        recalcSections() const.
        (WebCore::RenderTable::recalcSectionsIfNeeded): Made const.

2007-05-19  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Darin.

        - test for http://bugs.webkit.org/show_bug.cgi?id=13774
          REGRESSION: Crash emailing blog entry using Google Reader

        * fast/table/stale-grid-crash-expected.checksum: Added.
        * fast/table/stale-grid-crash-expected.png: Added.
        * fast/table/stale-grid-crash-expected.txt: Added.
        * fast/table/stale-grid-crash.html: Added.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21602 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7746786d
    • bdash's avatar
      2007-05-19 Mitz Pettel <mitz@webkit.org> · 71b3ce0c
      bdash authored 
              Reviewed by Darin.

        - http://bugs.webkit.org/show_bug.cgi?id=13320
          rounded corners with drop shadows are really slow

        Test for a rendering bug fixed by this patch:
            fast/box-shadow/border-radius-big.html

        No test for the performance ingredient.

        * platform/graphics/GraphicsContext.cpp:
        (WebCore::GraphicsContext::addRoundedRectClip): Made cross-platform.
        Changed to use a single clipping path. If all the radii cannot be
        accommodated, clips to a rect.
        (WebCore::GraphicsContext::clipOutRoundedRect): Changed to use a single
        clipping path. If all the radii cannot be accommodated, clips out a rect.
        * platform/graphics/GraphicsContext.h: Added clipOut(const Path&).
        * platform/graphics/Path.cpp:
        (WebCore::Path::createRoundedRectangle): Added. Returns a rounded rectangle
        with the specified radii. If all the radii cannot be accommodated, returns
        a rectangular path.
        * platform/graphics/Path.h:
        * platform/graphics/cairo/GraphicsContextCairo.cpp:
        (WebCore::GraphicsContext::clipOut): Added.
        * platform/graphics/cg/GraphicsContextCG.cpp:
        (WebCore::GraphicsContext::fillRoundedRect): Changed to use a single path.
        (WebCore::GraphicsContext::clipOut): Added.
        * platform/graphics/qt/GraphicsContextQt.cpp:
        (WebCore::GraphicsContext::clipOut): Added.

2007-05-19  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Darin.

        - http://bugs.webkit.org/show_bug.cgi?id=13320
          rounded corners with drop shadows are really slow

        * fast/box-shadow/border-radius-big-expected.checksum: Added.
        * fast/box-shadow/border-radius-big-expected.png: Added.
        * fast/box-shadow/border-radius-big-expected.txt: Added.
        * fast/box-shadow/border-radius-big.html: Added.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21601 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      71b3ce0c
    • andersca's avatar
      LayoutTests: · 44b89c45
      andersca authored 
              Reviewed by Mitz.

        http://bugs.webkit.org/show_bug.cgi?id=13771
        Assertion failure ASSERT(m_layer) when running Hamachi fuzz tester
        
        * fast/frames/inline-object-inside-frameset-expected.txt: Added.
        * fast/frames/inline-object-inside-frameset.html: Added.

WebCore:

        Reviewed by Mitz.

        Test: fast/frames/inline-object-inside-frameset.html
        
        http://bugs.webkit.org/show_bug.cgi?id=13771
        Assertion failure ASSERT(m_layer) when running Hamachi fuzz tester

        Don't paint inline objects.
        
        * rendering/RenderFrameSet.cpp:
        (WebCore::RenderFrameSet::paint):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21600 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      44b89c45
    • hyatt's avatar
      Add support for plain text MIME types (CSS/JS/TXT) to view source mode. · f0935893
      hyatt authored 
              CSS/JS will eventually tokenize via their own special tokenizers so that
        they can also be syntax-highlighted, but for now just treat them as
        plain text.

        Reviewed by aroben

        * dom/DOMImplementation.cpp:
        (WebCore::DOMImplementation::createDocument):
        * html/HTMLViewSourceDocument.cpp:
        (WebCore::HTMLViewSourceDocument::HTMLViewSourceDocument):
        (WebCore::HTMLViewSourceDocument::createTokenizer):
        (WebCore::HTMLViewSourceDocument::createContainingTable):
        (WebCore::HTMLViewSourceDocument::addViewSourceText):
        (WebCore::HTMLViewSourceDocument::addViewSourceToken):
        * html/HTMLViewSourceDocument.h:
        * loader/TextDocument.cpp:
        (WebCore::TextTokenizer::TextTokenizer):
        (WebCore::TextTokenizer::write):
        * loader/TextDocument.h:
        (WebCore::TextTokenizer::checkBuffer):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21599 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f0935893
    • hyatt's avatar
      Fix a glitch in view source mode attribute names. · 9cc9ebd7
      hyatt authored 
              * html/HTMLViewSourceDocument.cpp:
        (WebCore::HTMLViewSourceDocument::addViewSourceToken):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21598 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9cc9ebd7
  7. 18 May, 2007 22 commits