- 21 May, 2007 3 commits
-
-
hyatt authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21616 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
hyatt authored
spanning colgroups. Also make sure colgroups get an actual span of 1 (instead of incorrectly giving them a span of 0). Reviewed by mitz fast/table/colgroup-spanning-groups-rules.html * html/HTMLTableColElement.cpp: (WebCore::HTMLTableColElement::HTMLTableColElement): * rendering/RenderTable.cpp: (WebCore::RenderTable::colElement): * rendering/RenderTable.h: * rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::collapsedLeftBorder): (WebCore::RenderTableCell::collapsedRightBorder): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21615 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
hyatt authored
together. Reviewed by mitz No tests added, two Mozilla table tests now pass that failed before. * html/HTMLTableElement.cpp: (WebCore::HTMLTableElement::getSharedCellDecl): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21614 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
- 20 May, 2007 6 commits
-
-
bdash authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21613 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
beidson authored
<rdar://problem/4758919> - Incorrect favicon shown for URL after going back When restoring a cached page, we'd try to kick off the icon load for it, which ended up causing shenanigans with the icon url -> page url mapping. * loader/FrameLoader.cpp: (WebCore::FrameLoader::endIfNotLoading): Only try an icon load if we're not restoring from the page cache (WebCore::FrameLoader::startIconLoader): Added helpful logging that helped me track this down (WebCore::FrameLoader::commitIconURLToIconDatabase): Ditto (and fixed a comment typo) * loader/icon/IconLoader.cpp: (WebCore::IconLoader::stopLoading): Don't null out the ResourceLoader here, as clearLoadingState() does that (WebCore::IconLoader::finishLoading): Added helpful logging that helped me track this down git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21612 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
darin authored
- fix <rdar://problem/5193416> REGRESSION: Selection on large pages extremely slow * dom/Document.cpp: (WebCore::Document::removeMarkers): Added an early exit for the common case where there are no markers. Changed code to iterate over all the nodes in the range instead of using TextIterator, which is more efficient. * page/Frame.cpp: (WebCore::Frame::respondToChangedSelection): Added checks for editable, so we don't bother doing work related to spell checking and grammar checking when changing the selection in non-editable text. Also rearranged the code so we only compute the old word boundaries and sentence boundaries when actually needed, and don't do the sentence range checks unless grammar checking is enabled. * platform/TextBreakIteratorICU.cpp: (WebCore::setUpIterator): Don't take a locale parameter. Always pass in currentTextBreakLocaleID. (WebCore::characterBreakIterator): Removed local parameter. (WebCore::wordBreakIterator): Ditto. (WebCore::lineBreakIterator): Ditto. (WebCore::sentenceBreakIterator): Ditto. * platform/mac/TextBreakIteratorInternalICUMac.mm: (WebCore::getTextBreakLocale): Broke out the code to actually get the locale. (WebCore::currentTextBreakLocaleID): This function now handles only the caching and calls getTextBreakLocale to actually figure it out. * editing/visible_units.cpp: Added lots of FIXME comments, but no code change. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21611 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
staikos authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21610 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
staikos authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21609 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ddkilzer authored
Reviewed by Adam Roben. - fix http://bugs.webkit.org/show_bug.cgi?id=13565 Change svn-create-patch to put LayoutTests in the end In addition to reordering test files under the LayoutTests directory so that they appear after source code files, this patch fixes an issue with prepare-ChangeLog if the first argument passed to it is a file name instead of a directory name. * Scripts/prepare-ChangeLog: (isGIT()): If first value in @dirs array is a file, use dirname() to get the directory. (isSVN()): Ditto. * Scripts/svn-create-patch: (generateFileList($\%\%\%)): Differentiate test files in the LayoutTests directory from source code files. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21608 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
- 19 May, 2007 9 commits
-
-
hyatt authored
Reviewed by darin * rendering/RenderCounter.cpp: (WebCore::findPlaceForCounter): (WebCore::RenderCounter::originalText): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21606 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
bdash authored
Reviewed by Dave Hyatt. - fix http://bugs.webkit.org/show_bug.cgi?id=12729 box-shadow disappears when scrolling a div that it falls on/under Tests: fast/repaint/box-shadow-dynamic.html fast/repaint/box-shadow-h.html fast/repaint/box-shadow-v.html * rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::placeBoxesHorizontally): Factor in box shadow. (WebCore::InlineFlowBox::placeBoxesVertically): Ditto. (WebCore::InlineFlowBox::paint): Account for box shadow when checking if the damage rect intersects. * rendering/RenderBlock.cpp: (WebCore::RenderBlock::overflowHeight): For overflow areas, when asked for the "exterior" overflow, add box shadow overflow. (WebCore::RenderBlock::overflowWidth): Ditto. (WebCore::RenderBlock::overflowLeft): Ditto. (WebCore::RenderBlock::overflowTop): Ditto. (WebCore::RenderBlo...
-
bdash authored
Update test results after r21597. * fast/frames/viewsource-attribute-expected.checksum: * fast/frames/viewsource-attribute-expected.png: * fast/frames/viewsource-attribute-expected.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21604 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
bdash authored
Reviewed by Dave Hyatt. - fix http://bugs.webkit.org/show_bug.cgi?id=13783 REGRESSION (r21120): Frame resizers not repainted properly when dragged * rendering/RenderFrameSet.cpp: (WebCore::RenderFrameSet::layout): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21603 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
bdash authored
Reviewed by Darin. - fix http://bugs.webkit.org/show_bug.cgi?id=13774 REGRESSION: Crash emailing blog entry using Google Reader Test: fast/table/stale-grid-crash.html * rendering/RenderTable.cpp: (WebCore::RenderTable::recalcSections): Made const and replaced setNeedsLayout(true) with an assertion that the table is already marked for layout. (WebCore::RenderTable::sectionAbove): Added call to recalcSectionsIfNeeded(). (WebCore::RenderTable::sectionBelow): Ditto. (WebCore::RenderTable::cellAbove): Ditto. (WebCore::RenderTable::cellBelow): Ditto. (WebCore::RenderTable::cellBefore): Ditto. (WebCore::RenderTable::cellAfter): Ditto. * rendering/RenderTable.h: Made some private member variables which are used in section recalc mutable. (WebCore::RenderTable::setNeedsSectionRecalc): Moved the call to setNeedsLayout() from recalcSections() into here, because I made recalcSections() const. (WebCore::RenderTable::recalcSectionsIfNeeded): Made const. 2007-05-19 Mitz Pettel <mitz@webkit.org> Reviewed by Darin. - test for http://bugs.webkit.org/show_bug.cgi?id=13774 REGRESSION: Crash emailing blog entry using Google Reader * fast/table/stale-grid-crash-expected.checksum: Added. * fast/table/stale-grid-crash-expected.png: Added. * fast/table/stale-grid-crash-expected.txt: Added. * fast/table/stale-grid-crash.html: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21602 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
bdash authored
Reviewed by Darin. - http://bugs.webkit.org/show_bug.cgi?id=13320 rounded corners with drop shadows are really slow Test for a rendering bug fixed by this patch: fast/box-shadow/border-radius-big.html No test for the performance ingredient. * platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::addRoundedRectClip): Made cross-platform. Changed to use a single clipping path. If all the radii cannot be accommodated, clips to a rect. (WebCore::GraphicsContext::clipOutRoundedRect): Changed to use a single clipping path. If all the radii cannot be accommodated, clips out a rect. * platform/graphics/GraphicsContext.h: Added clipOut(const Path&). * platform/graphics/Path.cpp: (WebCore::Path::createRoundedRectangle): Added. Returns a rounded rectangle with the specified radii. If all the radii cannot be accommodated, returns a rectangular path. * platform/graphics/Path.h: * platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::clipOut): Added. * platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::fillRoundedRect): Changed to use a single path. (WebCore::GraphicsContext::clipOut): Added. * platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::clipOut): Added. 2007-05-19 Mitz Pettel <mitz@webkit.org> Reviewed by Darin. - http://bugs.webkit.org/show_bug.cgi?id=13320 rounded corners with drop shadows are really slow * fast/box-shadow/border-radius-big-expected.checksum: Added. * fast/box-shadow/border-radius-big-expected.png: Added. * fast/box-shadow/border-radius-big-expected.txt: Added. * fast/box-shadow/border-radius-big.html: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21601 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
andersca authored
Reviewed by Mitz. http://bugs.webkit.org/show_bug.cgi?id=13771 Assertion failure ASSERT(m_layer) when running Hamachi fuzz tester * fast/frames/inline-object-inside-frameset-expected.txt: Added. * fast/frames/inline-object-inside-frameset.html: Added. WebCore: Reviewed by Mitz. Test: fast/frames/inline-object-inside-frameset.html http://bugs.webkit.org/show_bug.cgi?id=13771 Assertion failure ASSERT(m_layer) when running Hamachi fuzz tester Don't paint inline objects. * rendering/RenderFrameSet.cpp: (WebCore::RenderFrameSet::paint): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21600 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
hyatt authored
CSS/JS will eventually tokenize via their own special tokenizers so that they can also be syntax-highlighted, but for now just treat them as plain text. Reviewed by aroben * dom/DOMImplementation.cpp: (WebCore::DOMImplementation::createDocument): * html/HTMLViewSourceDocument.cpp: (WebCore::HTMLViewSourceDocument::HTMLViewSourceDocument): (WebCore::HTMLViewSourceDocument::createTokenizer): (WebCore::HTMLViewSourceDocument::createContainingTable): (WebCore::HTMLViewSourceDocument::addViewSourceText): (WebCore::HTMLViewSourceDocument::addViewSourceToken): * html/HTMLViewSourceDocument.h: * loader/TextDocument.cpp: (WebCore::TextTokenizer::TextTokenizer): (WebCore::TextTokenizer::write): * loader/TextDocument.h: (WebCore::TextTokenizer::checkBuffer): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21599 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
hyatt authored
* html/HTMLViewSourceDocument.cpp: (WebCore::HTMLViewSourceDocument::addViewSourceToken): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21598 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
- 18 May, 2007 22 commits
-
-
hyatt authored
Reviewed by andersca * css/view-source.css: * html/HTMLViewSourceDocument.cpp: (WebCore::HTMLViewSourceDocument::addViewSourceToken): (WebCore::HTMLViewSourceDocument::addSpanWithClassName): (WebCore::HTMLViewSourceDocument::addLink): * html/HTMLViewSourceDocument.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21597 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
oliver authored
WebCore: Reviewed by Sam No longer need to pass HTMLImageElement and HTMLImageLoader on to WebKit Need to expose CachedResourceClient constructor * WebCore.exp: * WebCore.xcodeproj/project.pbxproj: WebKit: Reviewed by Sam. Fix for http://bugs.webkit.org/show_bug.cgi?id=13782 REGRESSION (r21528-r21533): Failing editing/selection/drag-in-iframe in pixel mode r21533 made used a DOMElement as the source for promise data, this meant it had to clear the dragging pasteboard following the drag. In DRT a drag is non-blocking so this resulted in us prematurely clearing the pasteboard. This patch avoids this problem by referencing the source CachedImage rather than the DOMElement, so we don't need to worry about retaining an entire document forever, so we don't need to clear the dragging pasteboard following the drag. * Misc/WebNSPasteboardExtras.mm: (imageFromElement): Extract the underlying CachedImage from a DOMElement (-[NSPasteboard _web_writeImage:element:URL:title:archive:types:source:]): Use a CachedImage instead of a DOMElement * WebCoreSupport/WebDragClient.mm: (WebDragClient::startDrag): * WebKit.xcodeproj/project.pbxproj: * WebView/WebHTMLView.mm: (-[WebHTMLViewPrivate dealloc]): (-[WebHTMLViewPrivate clear]): (-[WebHTMLView pasteboardChangedOwner:]): (-[WebHTMLView pasteboard:provideDataForType:]): (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): (-[WebHTMLView WebCore::]): (-[WebHTMLView setPromisedDragTIFFDataSource:WebCore::]): Use CachedImage rather than DOMElement as promised data source * WebView/WebHTMLViewInternal.h: * WebView/WebHTMLViewPrivate.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21596 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
hyatt authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21595 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
hyatt authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21594 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
hyatt authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21593 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
hyatt authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21592 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
hyatt authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21591 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
hyatt authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21590 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
hyatt authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21589 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
hyatt authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21588 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
hyatt authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21587 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
hyatt authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21586 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
hyatt authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21585 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
hyatt authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21584 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
hyatt authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21583 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
tristan authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21582 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
rdar://problem/5214338hyatt authored
HTML tokenization (13780). Reviewed by ggaren * html/HTMLTokenizer.cpp: (WebCore::Token::addAttribute): (WebCore::HTMLTokenizer::parseTag): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21581 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
beidson authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21580 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
tristan authored
(WebFrameLoaderClient::download): asked the webframeloaderclient for its webview's history and injected the originated url into the created WebDownload git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21579 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
beidson authored
<rdar://problem/5166149> - window.open() causes server to be hit twice This regressed in http://trac.webkit.org/projects/webkit/changeset/14637 That patch was to fix broken behavior when opening an already existant window. The unfortunate side effect was to cause the server to be hit twice. Once during the call to frame->loader()->createWindow(), and again via a scheduled redirection. I decided to restore the original de-facto behavior by making the new window open via a scheduled redirection - there is a FIXME that was already here that explains the reason why we have to do it this way for now. Additionally, there were two distinct places that had their own logic to open a new window - the logic for window.open() and the logic for window.showModalDialog(). The logic was almost identical so I condensed them into one utility function that takes a flag to handle the slight difference. A layout test is not possible at this time since it would involve capturing server logs (the 1st connection does not exist long enough to result in any delegate callbacks). That task is documented in http://bugs.webkit.org/show_bug.cgi?id=13769 * bindings/js/kjs_window.cpp: (KJS::createWindow): Merged the two slightly different versions of "creating a window" logic here. For the modal dialog case the load is an immediate call to changeLocation(), which is triggered by the "immediate" flag, and the other cases load via scheduleLocationChange() (KJS::showModalDialog): Call createWindow() (KJS::WindowFunc::callAsFunction): Handle frame targets of _top or _parent immediately and call createWindow() for all others git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21578 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
weinig authored
Reviewed by Geoff. - update results to account for new JSHTMLElements that are being auto-generated and can now produce Constructors. * fast/dom/Window/element-constructors-on-window-expected.txt: * fast/dom/Window/window-properties-expected.txt: WebCore: Reviewed by Geoff. Autogenerate the JS bindings for the HTMLTableElement, HTMLTableCaptionElement, HTMLTableCellElement, HTMLTableColElement, HTMLTableRowElement, HTMLTableSectionElement. * DerivedSources.make: * WebCore.pro: * WebCore.xcodeproj/project.pbxproj: * bindings/js/JSHTMLElementWrapperFactory.cpp: (WebCore::createJSHTMLWrapper): * bindings/js/kjs_html.cpp: (KJS::): (KJS::JSHTMLElement::classInfo): (KJS::JSHTMLElement::accessors): (KJS::HTMLElementFunction::callAsFunction): * bindings/js/kjs_html.h: (KJS::JSHTMLElement::): * html/HTMLTableCaptionElement.idl: * html/HTMLTableCellElement.idl: * html/HTMLTableColElement.idl: * html/HTMLTableElement.idl: * html/HTMLTableRowElement.idl: * html/HTMLTableSectionElement.idl: * page/DOMWindow.idl: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21577 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
sullivan authored
Improvement to WebKit part of fix for 5201499 based on more modern understanding. (That is, a couple of hours more modern.) * WebView/WebUIDelegatePrivate.h: add showPanel: parameter to just-introduced delegate method webView:saveFrameView: * WebView/WebPDFView.mm: (-[WebPDFView PDFViewSavePDFToDownloadFolder:]): pass NO for new showPanel: parameter, and update comment git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21576 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-