1. 15 Mar, 2007 1 commit
  2. 16 Feb, 2007 1 commit
    • andersca's avatar
      Reviewed by Darin. · ba53ca87
      andersca authored
              <rdar://problem/4993055> auto_refcount_underflow_error: WebCore::FrameLoader::continueAfterNavigationPolicy () over-releases under GC
      
              Add ::adoptNS and ::adoptCF methods to RetainPtr to indicate what type of reference to adopt.
              
              * platform/cf/RetainPtr.h:
              (WebCore::):
              (WebCore::adoptNSReference):
              (WebCore::RetainPtr::RetainPtr):
              (WebCore::::adoptCF):
              (WebCore::::adoptNS):
              * platform/mac/FileChooserMac.mm:
              (WebCore::FileChooser::FileChooser):
              * platform/network/mac/ResourceErrorMac.mm:
              (WebCore::ResourceError::operator NSError*):
              * platform/network/mac/ResourceRequestMac.mm:
              (WebCore::ResourceRequest::doUpdatePlatformRequest):
              * platform/network/mac/ResourceResponseMac.mm:
              (WebCore::ResourceResponse::nsURLResponse):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19660 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ba53ca87
  3. 14 Feb, 2007 1 commit
    • aroben's avatar
      LayoutTests: · 39e6fb8f
      aroben authored
              Reviewed by Darin.
      
              Test for http://bugs.webkit.org/show_bug.cgi?id=12517
              <rdar://problem/4971227> REGRESSION: Tab order incorrect when input
              inside frame/iframe gets initial focus (12517)
      
              * fast/events/frame-programmatic-focus-expected.txt: Added.
              * fast/events/frame-programmatic-focus.html: Added.
              * fast/forms/focus2-expected.txt: Updated results to now-correct
              behavior.
      
      WebCore:
      
              Reviewed by Darin.
      
              Fix http://bugs.webkit.org/show_bug.cgi?id=12517
              <rdar://problem/4971227> REGRESSION: Tab order incorrect when input
              inside frame/iframe gets initial focus (12517)
      
              Test: fast/events/frame-programmatic-focus.html
      
              * dom/Element.cpp:
              (WebCore::Element::focus): Call FocusController::setFocusedNode to set
              the focus for the whole page.
              * html/HTMLInputElement.cpp:
              (WebCore::HTMLInputElement::focus): Ditto.
              * html/HTMLTextAreaElement.cpp:
              (WebCore::HTMLTextAreaElement::focus): Ditto.
              * page/EventHandler.cpp:
              (WebCore::EventHandler::handleTextInputEvent): Send the textInput
              event to the same target that was sent the keypress event before it.
              * page/FocusController.cpp:
              (WebCore::FocusController::advanceFocus): Added a FIXME.
              (WebCore::FocusController::setFocusedNode): Added. Sets the focused
              node for a whole page.
              * page/FocusController.h: Added declaration.
              * platform/cf/RetainPtr.h: Removed unused pointer_cast functions.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19636 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      39e6fb8f
  4. 26 Jan, 2007 1 commit
  5. 15 Jan, 2007 1 commit
    • eseidel's avatar
      2007-01-15 Eric Seidel <eric@webkit.org> · 8eddecf9
      eseidel authored
              Reviewed by bdash.
      
              Update header guards to follow new style guidelines using new clean-header-guards script.
      
              * bindings/js/JSHTMLElementWrapperFactory.h:
              * bindings/js/JSHTMLInputElementBase.h:
              * bindings/js/JSHTMLOptionElementConstructor.h:
              * bindings/js/JSSVGElementWrapperFactory.h:
              * bindings/js/JSSVGPODTypeWrapper.h:
              * bindings/js/JSXMLHttpRequest.h:
              * bindings/js/JSXSLTProcessor.h:
              * bindings/js/kjs_binding.h:
              * bindings/js/kjs_css.h:
              * bindings/js/kjs_dom.h:
              * bindings/js/kjs_domnode.h:
              * bindings/js/kjs_events.h:
              * bindings/js/kjs_html.h:
              * bindings/js/kjs_navigator.h:
              * bindings/js/kjs_proxy.h:
              * bindings/js/kjs_traversal.h:
              * bindings/js/kjs_window.h:
              * bridge/EditorClient.h:
              * bridge/History.h:
              * css/CSSStyleSheet.h:
              * css/CSSValue.h:
              * css/CSSValueList.h:
              * css/DashboardRegion.h:
              * css/FontFamilyValue.h:
              * css/FontValue.h:
              * css/MediaFeatureNames.h:
              * css/MediaList.h:
              * css/Pair.h:
              * css/RectImpl.h:
              * css/ShadowValue.h:
              * css/StyleBase.h:
              * css/StyleList.h:
              * css/StyleSheet.h:
              * css/StyleSheetList.h:
              * css/cssstyleselector.h:
              * dom/BeforeTextInsertedEvent.h:
              * dom/CDATASection.h:
              * dom/CharacterData.h:
              * dom/ChildNodeList.h:
              * dom/Comment.h:
              * dom/DOMImplementation.h:
              * dom/DocPtr.h:
              * dom/Document.h:
              * dom/DocumentFragment.h:
              * dom/DocumentMarker.h:
              * dom/DocumentType.h:
              * dom/EditingText.h:
              * dom/Entity.h:
              * dom/EntityReference.h:
              * dom/EventNames.h:
              * dom/EventTargetNode.h:
              * dom/NameNodeList.h:
              * dom/NamedNodeMap.h:
              * dom/Node.h:
              * dom/NodeList.h:
              * dom/Notation.h:
              * dom/Position.h:
              * dom/ProcessingInstruction.h:
              * dom/Range.h:
              * dom/StyleElement.h:
              * dom/Text.h:
              * editing/AppendNodeCommand.h:
              * editing/ApplyStyleCommand.h:
              * editing/BreakBlockquoteCommand.h:
              * editing/CommandByName.h:
              * editing/CompositeEditCommand.h:
              * editing/DeleteButton.h:
              * editing/DeleteButtonController.h:
              * editing/DeleteFromTextNodeCommand.h:
              * editing/DeleteSelectionCommand.h:
              * editing/InsertIntoTextNodeCommand.h:
              * editing/InsertLineBreakCommand.h:
              * editing/InsertNodeBeforeCommand.h:
              * editing/InsertParagraphSeparatorCommand.h:
              * editing/InsertTextCommand.h:
              * editing/JoinTextNodesCommand.h:
              * editing/MergeIdenticalElementsCommand.h:
              * editing/ModifySelectionListLevel.h:
              * editing/MoveSelectionCommand.h:
              * editing/RemoveCSSPropertyCommand.h:
              * editing/RemoveNodeAttributeCommand.h:
              * editing/RemoveNodeCommand.h:
              * editing/RemoveNodePreservingChildrenCommand.h:
              * editing/ReplaceSelectionCommand.h:
              * editing/SetNodeAttributeCommand.h:
              * editing/SplitElementCommand.h:
              * editing/SplitTextNodeCommand.h:
              * editing/SplitTextNodeContainingElementCommand.h:
              * editing/TextGranularity.h:
              * editing/TypingCommand.h:
              * editing/WrapContentsInDummySpanCommand.h:
              * history/BackForwardList.h:
              * history/HistoryItem.h:
              * history/HistoryItemTimer.h:
              * history/PageCache.h:
              * html/CanvasGradient.h:
              * html/CanvasPattern.h:
              * html/CanvasRenderingContext2D.h:
              * html/CanvasStyle.h:
              * html/FormDataList.h:
              * html/HTMLAnchorElement.h:
              * html/HTMLAppletElement.h:
              * html/HTMLAreaElement.h:
              * html/HTMLBRElement.h:
              * html/HTMLBaseElement.h:
              * html/HTMLBaseFontElement.h:
              * html/HTMLBlockquoteElement.h:
              * html/HTMLBodyElement.h:
              * html/HTMLButtonElement.h:
              * html/HTMLCanvasElement.h:
              * html/HTMLCollection.h:
              * html/HTMLDListElement.h:
              * html/HTMLDirectoryElement.h:
              * html/HTMLDivElement.h:
              * html/HTMLElement.h:
              * html/HTMLElementFactory.h:
              * html/HTMLEmbedElement.h:
              * html/HTMLFieldSetElement.h:
              * html/HTMLFontElement.h:
              * html/HTMLFormCollection.h:
              * html/HTMLFormElement.h:
              * html/HTMLFrameSetElement.h:
              * html/HTMLGenericFormElement.h:
              * html/HTMLHRElement.h:
              * html/HTMLHeadElement.h:
              * html/HTMLHeadingElement.h:
              * html/HTMLHtmlElement.h:
              * html/HTMLImageElement.h:
              * html/HTMLImageLoader.h:
              * html/HTMLInputElement.h:
              * html/HTMLIsIndexElement.h:
              * html/HTMLKeygenElement.h:
              * html/HTMLLIElement.h:
              * html/HTMLLabelElement.h:
              * html/HTMLLegendElement.h:
              * html/HTMLLinkElement.h:
              * html/HTMLMapElement.h:
              * html/HTMLMarqueeElement.h:
              * html/HTMLMenuElement.h:
              * html/HTMLMetaElement.h:
              * html/HTMLModElement.h:
              * html/HTMLNameCollection.h:
              * html/HTMLOListElement.h:
              * html/HTMLObjectElement.h:
              * html/HTMLOptGroupElement.h:
              * html/HTMLOptionElement.h:
              * html/HTMLOptionsCollection.h:
              * html/HTMLParagraphElement.h:
              * html/HTMLParamElement.h:
              * html/HTMLParser.h:
              * html/HTMLPlugInElement.h:
              * html/HTMLPreElement.h:
              * html/HTMLQuoteElement.h:
              * html/HTMLScriptElement.h:
              * html/HTMLSelectElement.h:
              * html/HTMLStyleElement.h:
              * html/HTMLTableCaptionElement.h:
              * html/HTMLTableCellElement.h:
              * html/HTMLTableColElement.h:
              * html/HTMLTableElement.h:
              * html/HTMLTablePartElement.h:
              * html/HTMLTableRowElement.h:
              * html/HTMLTableSectionElement.h:
              * html/HTMLTextAreaElement.h:
              * html/HTMLTextFieldInnerElement.h:
              * html/HTMLTitleElement.h:
              * html/HTMLUListElement.h:
              * ksvg2/css/SVGRenderStyle.h:
              * ksvg2/css/SVGRenderStyleDefs.h:
              * ksvg2/events/JSSVGLazyEventListener.h:
              * ksvg2/events/SVGZoomEvent.h:
              * ksvg2/misc/KCanvasRenderingStyle.h:
              * ksvg2/misc/PointerEventsHitRules.h:
              * ksvg2/misc/SVGDocumentExtensions.h:
              * ksvg2/misc/SVGImageLoader.h:
              * ksvg2/misc/TimeScheduler.h:
              * ksvg2/svg/GradientAttributes.h:
              * ksvg2/svg/LinearGradientAttributes.h:
              * ksvg2/svg/PatternAttributes.h:
              * ksvg2/svg/RadialGradientAttributes.h:
              * ksvg2/svg/SVGAElement.h:
              * ksvg2/svg/SVGAngle.h:
              * ksvg2/svg/SVGAnimateColorElement.h:
              * ksvg2/svg/SVGAnimateElement.h:
              * ksvg2/svg/SVGAnimateMotionElement.h:
              * ksvg2/svg/SVGAnimateTransformElement.h:
              * ksvg2/svg/SVGAnimatedPathData.h:
              * ksvg2/svg/SVGAnimatedPoints.h:
              * ksvg2/svg/SVGAnimatedTemplate.h:
              * ksvg2/svg/SVGAnimationElement.h:
              * ksvg2/svg/SVGCircleElement.h:
              * ksvg2/svg/SVGClipPathElement.h:
              * ksvg2/svg/SVGColor.h:
              * ksvg2/svg/SVGComponentTransferFunctionElement.h:
              * ksvg2/svg/SVGCursorElement.h:
              * ksvg2/svg/SVGDOMImplementation.h:
              * ksvg2/svg/SVGDefsElement.h:
              * ksvg2/svg/SVGDescElement.h:
              * ksvg2/svg/SVGDocument.h:
              * ksvg2/svg/SVGElement.h:
              * ksvg2/svg/SVGElementInstance.h:
              * ksvg2/svg/SVGElementInstanceList.h:
              * ksvg2/svg/SVGEllipseElement.h:
              * ksvg2/svg/SVGExternalResourcesRequired.h:
              * ksvg2/svg/SVGFEBlendElement.h:
              * ksvg2/svg/SVGFEColorMatrixElement.h:
              * ksvg2/svg/SVGFEComponentTransferElement.h:
              * ksvg2/svg/SVGFECompositeElement.h:
              * ksvg2/svg/SVGFEDiffuseLightingElement.h:
              * ksvg2/svg/SVGFEDisplacementMapElement.h:
              * ksvg2/svg/SVGFEDistantLightElement.h:
              * ksvg2/svg/SVGFEFloodElement.h:
              * ksvg2/svg/SVGFEFuncAElement.h:
              * ksvg2/svg/SVGFEFuncBElement.h:
              * ksvg2/svg/SVGFEFuncGElement.h:
              * ksvg2/svg/SVGFEFuncRElement.h:
              * ksvg2/svg/SVGFEGaussianBlurElement.h:
              * ksvg2/svg/SVGFEImageElement.h:
              * ksvg2/svg/SVGFELightElement.h:
              * ksvg2/svg/SVGFEMergeElement.h:
              * ksvg2/svg/SVGFEMergeNodeElement.h:
              * ksvg2/svg/SVGFEOffsetElement.h:
              * ksvg2/svg/SVGFEPointLightElement.h:
              * ksvg2/svg/SVGFESpecularLightingElement.h:
              * ksvg2/svg/SVGFESpotLightElement.h:
              * ksvg2/svg/SVGFETileElement.h:
              * ksvg2/svg/SVGFETurbulenceElement.h:
              * ksvg2/svg/SVGFilterElement.h:
              * ksvg2/svg/SVGFilterPrimitiveStandardAttributes.h:
              * ksvg2/svg/SVGFitToViewBox.h:
              * ksvg2/svg/SVGForeignObjectElement.h:
              * ksvg2/svg/SVGGElement.h:
              * ksvg2/svg/SVGGradientElement.h:
              * ksvg2/svg/SVGImageElement.h:
              * ksvg2/svg/SVGLangSpace.h:
              * ksvg2/svg/SVGLength.h:
              * ksvg2/svg/SVGLengthList.h:
              * ksvg2/svg/SVGLineElement.h:
              * ksvg2/svg/SVGLinearGradientElement.h:
              * ksvg2/svg/SVGList.h:
              * ksvg2/svg/SVGListTraits.h:
              * ksvg2/svg/SVGLocatable.h:
              * ksvg2/svg/SVGMarkerElement.h:
              * ksvg2/svg/SVGMaskElement.h:
              * ksvg2/svg/SVGMetadataElement.h:
              * ksvg2/svg/SVGNumberList.h:
              * ksvg2/svg/SVGPaint.h:
              * ksvg2/svg/SVGParserUtilities.h:
              * ksvg2/svg/SVGPathElement.h:
              * ksvg2/svg/SVGPathSeg.h:
              * ksvg2/svg/SVGPathSegArc.h:
              * ksvg2/svg/SVGPathSegClosePath.h:
              * ksvg2/svg/SVGPathSegCurvetoCubic.h:
              * ksvg2/svg/SVGPathSegCurvetoCubicSmooth.h:
              * ksvg2/svg/SVGPathSegCurvetoQuadratic.h:
              * ksvg2/svg/SVGPathSegCurvetoQuadraticSmooth.h:
              * ksvg2/svg/SVGPathSegLineto.h:
              * ksvg2/svg/SVGPathSegLinetoHorizontal.h:
              * ksvg2/svg/SVGPathSegLinetoVertical.h:
              * ksvg2/svg/SVGPathSegList.h:
              * ksvg2/svg/SVGPathSegMoveto.h:
              * ksvg2/svg/SVGPatternElement.h:
              * ksvg2/svg/SVGPointList.h:
              * ksvg2/svg/SVGPolyElement.h:
              * ksvg2/svg/SVGPolygonElement.h:
              * ksvg2/svg/SVGPolylineElement.h:
              * ksvg2/svg/SVGPreserveAspectRatio.h:
              * ksvg2/svg/SVGRadialGradientElement.h:
              * ksvg2/svg/SVGRectElement.h:
              * ksvg2/svg/SVGRenderingIntent.h:
              * ksvg2/svg/SVGSVGElement.h:
              * ksvg2/svg/SVGScriptElement.h:
              * ksvg2/svg/SVGSetElement.h:
              * ksvg2/svg/SVGStopElement.h:
              * ksvg2/svg/SVGStringList.h:
              * ksvg2/svg/SVGStylable.h:
              * ksvg2/svg/SVGStyleElement.h:
              * ksvg2/svg/SVGStyledElement.h:
              * ksvg2/svg/SVGStyledLocatableElement.h:
              * ksvg2/svg/SVGStyledTransformableElement.h:
              * ksvg2/svg/SVGSwitchElement.h:
              * ksvg2/svg/SVGSymbolElement.h:
              * ksvg2/svg/SVGTRefElement.h:
              * ksvg2/svg/SVGTSpanElement.h:
              * ksvg2/svg/SVGTests.h:
              * ksvg2/svg/SVGTextContentElement.h:
              * ksvg2/svg/SVGTextElement.h:
              * ksvg2/svg/SVGTextPositioningElement.h:
              * ksvg2/svg/SVGTitleElement.h:
              * ksvg2/svg/SVGTransform.h:
              * ksvg2/svg/SVGTransformList.h:
              * ksvg2/svg/SVGTransformable.h:
              * ksvg2/svg/SVGURIReference.h:
              * ksvg2/svg/SVGUnitTypes.h:
              * ksvg2/svg/SVGUseElement.h:
              * ksvg2/svg/SVGViewElement.h:
              * ksvg2/svg/SVGZoomAndPan.h:
              * loader/CachedCSSStyleSheet.h:
              * loader/CachedImage.h:
              * loader/CachedXSLStyleSheet.h:
              * loader/DocumentLoader.h:
              * loader/Request.h:
              * loader/SubresourceLoader.h:
              * loader/icon/IconDataCache.h:
              * loader/icon/IconDatabase.h:
              * loader/icon/IconLoader.h:
              * loader/icon/SQLDatabase.h:
              * loader/icon/SQLStatement.h:
              * loader/icon/SQLTransaction.h:
              * page/Frame.h:
              * page/FrameLoadRequest.h:
              * page/FrameTree.h:
              * page/FrameView.h:
              * page/PageState.h:
              * page/Plugin.h:
              * page/qt/FrameQt.h:
              * page/qt/FrameQtClient.h:
              * platform/Arena.h:
              * platform/ArrayImpl.h:
              * platform/Cursor.h:
              * platform/DeprecatedArray.h:
              * platform/DeprecatedCString.h:
              * platform/FileChooser.h:
              * platform/Font.h:
              * platform/FontCache.h:
              * platform/FontData.h:
              * platform/FontDescription.h:
              * platform/FontFamily.h:
              * platform/GlyphBuffer.h:
              * platform/GlyphMap.h:
              * platform/GlyphWidthMap.h:
              * platform/Logging.h:
              * platform/Pasteboard.h:
              * platform/PlatformString.h:
              * platform/PlugInInfoStore.h:
              * platform/PopupMenu.h:
              * platform/PopupMenuClient.h:
              * platform/ScrollBar.h:
              * platform/ScrollView.h:
              * platform/SearchPopupMenu.h:
              * platform/Shared.h:
              * platform/Sound.h:
              * platform/SystemTime.h:
              * platform/Timer.h:
              * platform/Widget.h:
              * platform/cf/RetainPtr.h:
              * platform/gdk/ChromeClientGdk.h:
              * platform/gdk/FontPlatformData.h:
              * platform/gdk/FrameGdk.h:
              * platform/gdk/KeyboardCodes.h:
              * platform/gdk/RenderPopupMenuGdk.h:
              * platform/gdk/RenderThemeGdk.h:
              * platform/graphics/BitmapImage.h:
              * platform/graphics/Color.h:
              * platform/graphics/FloatPoint.h:
              * platform/graphics/FloatPoint3D.h:
              * platform/graphics/FloatRect.h:
              * platform/graphics/Icon.h:
              * platform/graphics/Image.h:
              * platform/graphics/ImageAnimationObserver.h:
              * platform/graphics/ImageBuffer.h:
              * platform/graphics/ImageSource.h:
              * platform/graphics/IntPoint.h:
              * platform/graphics/IntRect.h:
              * platform/graphics/IntSize.h:
              * platform/graphics/IntSizeHash.h:
              * platform/graphics/PathTraversalState.h:
              * platform/graphics/Pen.h:
              * platform/graphics/qt/ImageDecoderQt.h:
              * platform/graphics/svg/SVGImage.h:
              * platform/graphics/svg/SVGImageEmptyClients.h:
              * platform/graphics/svg/SVGPaintServer.h:
              * platform/graphics/svg/SVGPaintServerGradient.h:
              * platform/graphics/svg/SVGPaintServerLinearGradient.h:
              * platform/graphics/svg/SVGPaintServerPattern.h:
              * platform/graphics/svg/SVGPaintServerRadialGradient.h:
              * platform/graphics/svg/SVGPaintServerSolid.h:
              * platform/graphics/svg/SVGResource.h:
              * platform/graphics/svg/SVGResourceClipper.h:
              * platform/graphics/svg/SVGResourceFilter.h:
              * platform/graphics/svg/SVGResourceMarker.h:
              * platform/graphics/svg/SVGResourceMasker.h:
              * platform/graphics/svg/cg/CgSupport.h:
              * platform/graphics/svg/filters/SVGDistantLightSource.h:
              * platform/graphics/svg/filters/SVGFEBlend.h:
              * platform/graphics/svg/filters/SVGFEColorMatrix.h:
              * platform/graphics/svg/filters/SVGFEComponentTransfer.h:
              * platform/graphics/svg/filters/SVGFEComposite.h:
              * platform/graphics/svg/filters/SVGFEConvolveMatrix.h:
              * platform/graphics/svg/filters/SVGFEDiffuseLighting.h:
              * platform/graphics/svg/filters/SVGFEDisplacementMap.h:
              * platform/graphics/svg/filters/SVGFEFlood.h:
              * platform/graphics/svg/filters/SVGFEGaussianBlur.h:
              * platform/graphics/svg/filters/SVGFEImage.h:
              * platform/graphics/svg/filters/SVGFEMerge.h:
              * platform/graphics/svg/filters/SVGFEMorphology.h:
              * platform/graphics/svg/filters/SVGFEOffset.h:
              * platform/graphics/svg/filters/SVGFESpecularLighting.h:
              * platform/graphics/svg/filters/SVGFETile.h:
              * platform/graphics/svg/filters/SVGFETurbulence.h:
              * platform/graphics/svg/filters/SVGFilterEffect.h:
              * platform/graphics/svg/filters/SVGLightSource.h:
              * platform/graphics/svg/filters/SVGPointLightSource.h:
              * platform/graphics/svg/filters/SVGSpotLightSource.h:
              * platform/mac/FontPlatformData.h:
              * platform/mac/PlatformScrollBar.h:
              * platform/network/AuthenticationChallenge.h:
              * platform/network/Credential.h:
              * platform/network/HTTPHeaderMap.h:
              * platform/network/ProtectionSpace.h:
              * platform/network/ResourceError.h:
              * platform/network/ResourceRequest.h:
              * platform/network/ResourceResponse.h:
              * platform/network/cf/FormDataStreamCFNet.h:
              * platform/network/cf/ResourceRequestCFNet.h:
              * platform/network/cf/ResourceResponseCFNet.h:
              * platform/network/gdk/ResourceHandleManager.h:
              * platform/network/mac/AuthenticationMac.h:
              * platform/network/mac/FormDataStreamMac.h:
              * platform/network/qt/ResourceHandleManagerKDE.h:
              * platform/network/qt/ResourceHandleManagerQt.h:
              * platform/network/win/ResourceHandleWin.h:
              * platform/qt/FontPlatformData.h:
              * platform/qt/KeyboardCodes.h:
              * platform/qt/PlatformScrollBar.h:
              * platform/qt/ScrollViewCanvasQt.h:
              * platform/qt/SharedTimerQt.h:
              * platform/win/FontPlatformData.h:
              * platform/win/PlatformScrollBar.h:
              * rendering/AutoTableLayout.h:
              * rendering/HitTestRequest.h:
              * rendering/HitTestResult.h:
              * rendering/InlineBox.h:
              * rendering/InlineFlowBox.h:
              * rendering/Length.h:
              * rendering/ListMarkerBox.h:
              * rendering/RenderBox.h:
              * rendering/RenderMenuList.h:
              * rendering/RenderPart.h:
              * rendering/RenderPartObject.h:
              * rendering/RenderPath.h:
              * rendering/RenderReplaced.h:
              * rendering/RenderSVGContainer.h:
              * rendering/RenderSVGImage.h:
              * rendering/RenderSVGInline.h:
              * rendering/RenderSVGInlineText.h:
              * rendering/RenderSVGTSpan.h:
              * rendering/RenderSVGText.h:
              * rendering/RenderStyle.h:
              * rendering/RenderTableCol.h:
              * rendering/RenderThemeWin.h:
              * rendering/bidi.h:
              * xml/DOMParser.h:
              * xml/XPathEvaluator.h:
              * xml/XPathExpression.h:
              * xml/XPathExpressionNode.h:
              * xml/XPathFunctions.h:
              * xml/XPathNSResolver.h:
              * xml/XPathNamespace.h:
              * xml/XPathParser.h:
              * xml/XPathPath.h:
              * xml/XPathPredicate.h:
              * xml/XPathResult.h:
              * xml/XPathStep.h:
              * xml/XPathUtil.h:
              * xml/XPathValue.h:
              * xml/XPathVariableReference.h:
              * xml/XSLImportRule.h:
              * xml/XSLStyleSheet.h:
              * xml/XSLTProcessor.h:
              * xml/xmlhttprequest.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@18874 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8eddecf9
  6. 16 Dec, 2006 1 commit
    • bdakin's avatar
      WebCore: · 6172e092
      bdakin authored
              Reviewed by Adam (and partially Geoff).
      
              Primarily, this patch gives WebCore context menus the ability to
              enable/disable and set state. It does a few other things along the
              way, though. Some of the more noticeable things:
                     -Re-architects the ContextMenuItem class a bit so that the
                      ownership model is a bit less confusing. ContextMenuItem is
                      now *purely* a wrapper for the platformDescription. There
                      are no other member variables. If you ever need the
                      platformDescription outside of the MenuItem class, you have
                      to call releasePlatformDescription(), which transfers
                      ownership of the platformDescription to the caller.
                     -Moves fontForSelection() from FrameMac into Editor.cpp.
                      Turns out I don't need to use this function for my patch
                      after all, but it doesn't seem like a terrible idea to move
                      it anyway since we seem to be moving things from FrameMac
                      into Editor these days anyway.
      WebKit:
              Reviewed by Adam.
      
              WebKit side of making WebCore context menus support state and
              enabled/disabled.
      
              * WebCoreSupport/WebContextMenuClient.h: contextMenuItemSelected
              takes a pointer to the parentMenu now since menu items no longer
              hold onto it.
              * WebCoreSupport/WebContextMenuClient.mm: Same.
              (WebContextMenuClient::contextMenuItemSelected): Same.
              * WebView/WebHTMLView.m: Must call setAutoenablesItems:NO on our
              menu.
              (-[NSArray menuForEvent:]):
              * WebView/WebUIDelegatePrivate.h: No need for if-def.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@18245 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6172e092
  7. 08 Nov, 2006 1 commit
    • mjs's avatar
      Reviewed by Geoff. · 4ad0f382
      mjs authored
              
              - added ResourceError class and didFailWithError client method
      
              * WebCore.xcodeproj/project.pbxproj:
              * loader/icon/IconLoader.cpp:
              (WebCore::IconLoader::didFailWithError):
              (WebCore::IconLoader::didFinishLoading):
              * loader/icon/IconLoader.h:
              * loader/loader.cpp:
              (WebCore::Loader::receivedAllData):
              (WebCore::Loader::didFailWithError):
              * loader/loader.h:
              * loader/mac/SubresourceLoaderMac.mm:
              (WebCore::SubresourceLoader::didFail):
              (WebCore::SubresourceLoader::didCancel):
              * platform/cf/RetainPtr.h:
              (WebCore::):
              (WebCore::adoptCFReference):
              (WebCore::RetainPtr::RetainPtr):
              (WebCore::::adopt):
              * platform/network/ResourceError.cpp: Added.
              * platform/network/ResourceError.h: Added.
              (WebCore::ResourceError::ResourceError):
              (WebCore::ResourceError::domain):
              (WebCore::ResourceError::errorCode):
              (WebCore::ResourceError::failingURL):
              (WebCore::ResourceError::localizedDescription):
              (WebCore::ResourceError::unpackPlatformErrorIfNeeded):
              * platform/network/ResourceHandle.cpp:
              * platform/network/ResourceHandle.h:
              * platform/network/ResourceHandleClient.h:
              (WebCore::ResourceHandleClient::didFailWithError):
              * platform/network/cf/ResourceHandleCFNet.cpp:
              (WebCore::didFail):
              (WebCore::ResourceHandle::cancel):
              * platform/network/mac/ResourceErrorMac.mm: Added.
              (-[NSError WebCore]):
              * platform/network/mac/ResourceHandleMac.mm:
              (WebCore::ResourceHandle::reportError):
              * xml/xmlhttprequest.cpp:
              (WebCore::XMLHttpRequest::didFailWithError):
              (WebCore::XMLHttpRequest::didFinishLoading):
              * xml/xmlhttprequest.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17682 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4ad0f382
  8. 22 Oct, 2006 1 commit
    • darin's avatar
      WebCore: · bc60feae
      darin authored
              Reviewed by Adele.
      
              - convert WebLoader and its 3 subclasses to C++ (this time with a leak fixed)
      
              Renamed WebLoader to WebCore::WebResourceLoader (should be ResourceLoader, but
              there's currently another class with that name).
              Renamed WebMainResourceLoader to WebCore::MainResourceLoader.
              Renamed WebSubresourceLoader to WebCore::SubresourceLoader.
              Renamed WebNetscapePlugInStreamLoader to WebCore::NetscapePlugInStreamLoader.
      
              Converted the classes to C++ and added Objective-C delegates to forward from
              API that still requires Objective-C.
      
              Did not yet rename the source files.
      
              * WebCore.exp: Removed WebLoader, WebNetscapePlugInStreamLoader, and WebSubresourceLoader
              classes. Added 5 functions from the WebResourceLoader and NetscapePlugInStreamLoader
              classes.
      
              * WebCore.xcodeproj/project.pbxproj: Made RetainPtr.h a private header instead of project.
      
              * platform/cf/RetainPtr.h: Put into the WebCore namespace rather than the WTF namespace.
      
              * loader/mac/WebLoader.h:
              * loader/mac/WebLoader.mm:
              * loader/mac/WebMainResourceLoader.h:
              * loader/mac/WebMainResourceLoader.mm:
              * loader/mac/WebNetscapePlugInStreamLoader.h:
              * loader/mac/WebNetscapePlugInStreamLoader.mm:
              * loader/mac/WebSubresourceLoader.h:
              * loader/mac/WebSubresourceLoader.mm:
              Translate to C++.
      
              * bridge/mac/WebCoreFrameBridge.mm:
              (-[WebCoreFrameBridge startLoadingResource:withMethod:URL:customHeaders:]):
              (-[WebCoreFrameBridge startLoadingResource:withMethod:URL:customHeaders:postData:]):
              * loader/mac/WebFrameLoader.h:
              * loader/mac/WebFrameLoader.mm:
              (isCaseInsensitiveEqual):
              (isBackForwardLoadType):
              (-[WebFrameLoader dealloc]):
              (-[WebFrameLoader addPlugInStreamLoader:]):
              (-[WebFrameLoader removePlugInStreamLoader:]):
              (-[WebFrameLoader setDefersCallbacks:]):
              (-[WebFrameLoader stopLoadingPlugIns]):
              (-[WebFrameLoader isLoadingMainResource]):
              (-[WebFrameLoader isLoadingSubresources]):
              (-[WebFrameLoader isLoadingPlugIns]):
              (-[WebFrameLoader stopLoadingSubresources]):
              (-[WebFrameLoader addSubresourceLoader:]):
              (-[WebFrameLoader removeSubresourceLoader:]):
              (-[WebFrameLoader mainResourceData]):
              (-[WebFrameLoader releaseMainResourceLoader]):
              (-[WebFrameLoader cancelMainResourceLoad]):
              (-[WebFrameLoader startLoadingMainResourceWithRequest:identifier:]):
              (-[WebFrameLoader stopLoadingWithError:]):
              (-[WebFrameLoader willUseArchiveForRequest:originalURL:loader:]):
              (-[WebFrameLoader archiveLoadPendingForLoader:]):
              (-[WebFrameLoader cancelPendingArchiveLoadForLoader:]):
              * loader/mac/WebFrameLoaderClient.h:
              Call the new C++ API.
      
      WebKit:
      
              Reviewed by Adele.
      
              - convert WebLoader and its 3 subclasses to C++
      
              * Plugins/WebNetscapePluginStream.h:
              * Plugins/WebNetscapePluginStream.m:
              (-[WebNetscapePluginStream dealloc]):
              (-[WebNetscapePluginStream finalize]):
              (-[WebNetscapePluginStream start]):
              (-[WebNetscapePluginStream cancelLoadWithError:]):
              (-[WebNetscapePluginStream stop]):
              * WebCoreSupport/WebFrameBridge.m:
              (-[WebFrameBridge canRunModalNow]):
              * WebView/WebFrame.m:
              (-[WebFramePrivate dealloc]):
              (-[WebFramePrivate finalize]):
              (frame): Changed from uppercase to lowercase so that it won't conflict
              with the WebCore class named Frame.
              (-[WebFrame _firstChildFrame]):
              (-[WebFrame _lastChildFrame]):
              (-[WebFrame _previousSiblingFrame]):
              (-[WebFrame _nextSiblingFrame]):
              (-[WebFrame _traverseNextFrameStayWithin:]):
              (-[WebFrame _immediateChildFrameNamed:]):
              (-[WebFrame _nextFrameWithWrap:]):
              (-[WebFrame _previousFrameWithWrap:]):
              (-[WebFrame findFrameNamed:]):
              (-[WebFrame parentFrame]):
              (-[WebFrame _dispatchSourceFrame:willSubmitForm:withValues:submissionDecider:]):
              (-[WebFrame _deliverArchivedResourcesAfterDelay]):
              (-[WebFrame _willUseArchiveForRequest:originalURL:loader:]):
              (-[WebFrame _archiveLoadPendingForLoader:]):
              (-[WebFrame _cancelPendingArchiveLoadForLoader:]):
              (-[WebFrame _clearArchivedResources]):
              (-[WebFrame _deliverArchivedResources]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17206 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bc60feae
  9. 20 Oct, 2006 2 commits
    • darin's avatar
      WebCore: · aaf59271
      darin authored
              - rolled out my loader change; caused world leak and possibly a plug-in crash
      
      WebKit:
      
              - rolled out my loader change; caused world leak and possibly a plug-in crash
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17175 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      aaf59271
    • darin's avatar
      WebCore: · 87f4b02c
      darin authored
              Reviewed by Adele.
      
              - convert WebLoader and its 3 subclasses to C++
      
              Renamed WebLoader to WebCore::WebResourceLoader (should be ResourceLoader, but
              there's currently another class with that name).
              Renamed WebMainResourceLoader to WebCore::MainResourceLoader.
              Renamed WebSubresourceLoader to WebCore::SubresourceLoader.
              Renamed WebNetscapePlugInStreamLoader to WebCore::NetscapePlugInStreamLoader.
      
              Converted the classes to C++ and added Objective-C delegates to forward from
              API that still requires Objective-C.
      
              Did not yet rename the source files.
      
              * WebCore.exp: Removed WebLoader, WebNetscapePlugInStreamLoader, and WebSubresourceLoader
              classes. Added 5 functions from the WebResourceLoader and NetscapePlugInStreamLoader
              classes.
      
              * WebCore.xcodeproj/project.pbxproj: Made RetainPtr.h a private header instead of project.
      
              * platform/cf/RetainPtr.h: Put into the WebCore namespace rather than the WTF namespace.
      
              * loader/mac/WebLoader.h:
              * loader/mac/WebLoader.mm:
              * loader/mac/WebMainResourceLoader.h:
              * loader/mac/WebMainResourceLoader.mm:
              * loader/mac/WebNetscapePlugInStreamLoader.h:
              * loader/mac/WebNetscapePlugInStreamLoader.mm:
              * loader/mac/WebSubresourceLoader.h:
              * loader/mac/WebSubresourceLoader.mm:
              Translate to C++.
      
              * bridge/mac/WebCoreFrameBridge.mm:
              (-[WebCoreFrameBridge startLoadingResource:withMethod:URL:customHeaders:]):
              (-[WebCoreFrameBridge startLoadingResource:withMethod:URL:customHeaders:postData:]):
              * loader/mac/WebFrameLoader.h:
              * loader/mac/WebFrameLoader.mm:
              (isCaseInsensitiveEqual):
              (isBackForwardLoadType):
              (-[WebFrameLoader dealloc]):
              (-[WebFrameLoader addPlugInStreamLoader:]):
              (-[WebFrameLoader removePlugInStreamLoader:]):
              (-[WebFrameLoader setDefersCallbacks:]):
              (-[WebFrameLoader stopLoadingPlugIns]):
              (-[WebFrameLoader isLoadingMainResource]):
              (-[WebFrameLoader isLoadingSubresources]):
              (-[WebFrameLoader isLoadingPlugIns]):
              (-[WebFrameLoader stopLoadingSubresources]):
              (-[WebFrameLoader addSubresourceLoader:]):
              (-[WebFrameLoader removeSubresourceLoader:]):
              (-[WebFrameLoader mainResourceData]):
              (-[WebFrameLoader releaseMainResourceLoader]):
              (-[WebFrameLoader cancelMainResourceLoad]):
              (-[WebFrameLoader startLoadingMainResourceWithRequest:identifier:]):
              (-[WebFrameLoader stopLoadingWithError:]):
              (-[WebFrameLoader willUseArchiveForRequest:originalURL:loader:]):
              (-[WebFrameLoader archiveLoadPendingForLoader:]):
              (-[WebFrameLoader cancelPendingArchiveLoadForLoader:]):
              * loader/mac/WebFrameLoaderClient.h:
              Call the new C++ API.
      
      WebKit:
      
              Reviewed by Adele.
      
              - convert WebLoader and its 3 subclasses to C++
      
              * Plugins/WebNetscapePluginStream.h:
              * Plugins/WebNetscapePluginStream.m:
              (-[WebNetscapePluginStream dealloc]):
              (-[WebNetscapePluginStream finalize]):
              (-[WebNetscapePluginStream start]):
              (-[WebNetscapePluginStream cancelLoadWithError:]):
              (-[WebNetscapePluginStream stop]):
              * WebCoreSupport/WebFrameBridge.m:
              (-[WebFrameBridge canRunModalNow]):
              * WebView/WebFrame.m:
              (-[WebFramePrivate dealloc]):
              (-[WebFramePrivate finalize]):
              (frame): Changed from uppercase to lowercase so that it won't conflict
              with the WebCore class named Frame.
              (-[WebFrame _firstChildFrame]):
              (-[WebFrame _lastChildFrame]):
              (-[WebFrame _previousSiblingFrame]):
              (-[WebFrame _nextSiblingFrame]):
              (-[WebFrame _traverseNextFrameStayWithin:]):
              (-[WebFrame _immediateChildFrameNamed:]):
              (-[WebFrame _nextFrameWithWrap:]):
              (-[WebFrame _previousFrameWithWrap:]):
              (-[WebFrame findFrameNamed:]):
              (-[WebFrame parentFrame]):
              (-[WebFrame _dispatchSourceFrame:willSubmitForm:withValues:submissionDecider:]):
              (-[WebFrame _deliverArchivedResourcesAfterDelay]):
              (-[WebFrame _willUseArchiveForRequest:originalURL:loader:]):
              (-[WebFrame _archiveLoadPendingForLoader:]):
              (-[WebFrame _cancelPendingArchiveLoadForLoader:]):
              (-[WebFrame _clearArchivedResources]):
              (-[WebFrame _deliverArchivedResources]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17169 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      87f4b02c
  10. 18 Oct, 2006 1 commit
    • thatcher's avatar
      Reviewed by Darin. · f6788593
      thatcher authored
              <rdar://problem/4752138> Manipulating popup in HTML page crashed Xcode
      
              - Store the Mac popup button cell as a RetainPtr to prevent GC collection.
              - Convert more ObjC local statics and member variables to use RetainPtr.
              - Convert more CFRetain/CFRelease to HardRetain/HardRelease.
      
              * bindings/objc/DOM.mm:
              (ObjCNodeFilterCondition::ObjCNodeFilterCondition): use HardRetain and not CFRetain
              (ObjCNodeFilterCondition::~ObjCNodeFilterCondition): use HardRelease and not CFRelease
              * bridge/mac/AXObjectCacheMac.mm:
              (WebCore::AXObjectCache::~AXObjectCache): use HardRelease and not CFRelease
              (WebCore::AXObjectCache::get): use HardRetain and not CFRetain
              (WebCore::AXObjectCache::remove): use HardRelease and not CFRelease
              * bridge/mac/WebCoreFrameBridge.mm:
              (+[WebCoreFrameBridge supportedImageResourceMIMETypes]): use RetainPtr
              (+[WebCoreFrameBridge supportedImageMIMETypes]): ditto
              * bridge/mac/WebCoreIconDatabaseBridge.mm:
              (+[WebCoreIconDatabaseBridge sharedInstance]): use RetainPtr
              * platform/PopupMenu.h: renamed popup to m_popup and switched to RetainPtr<NSPopUpButtonCell>
              * platform/cf/RetainPtr.h:
              (WTF::::operator): implement a missing operator= template function
              * platform/mac/PopupMenuMac.mm:
              (WebCore::PopupMenu::PopupMenu): remove nil initialization
              (WebCore::PopupMenu::~PopupMenu): use .get(), remove release message and rename to m_popup
              (WebCore::PopupMenu::clear): use .get() when sending a message and rename to m_popup
              (WebCore::PopupMenu::populate): ditto 
              (WebCore::PopupMenu::show): ditto
              (WebCore::PopupMenu::hide): ditto
              (WebCore::PopupMenu::addSeparator): ditto
              (WebCore::PopupMenu::addGroupLabel): ditto
              (WebCore::PopupMenu::addOption): ditto
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17121 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f6788593
  11. 11 Oct, 2006 1 commit
    • mjs's avatar
      Reviewed by Oliver. · b7091e47
      mjs authored
              - added RetainPtr, smart pointer for refcounted ObjC objects and CFTypes
      
              * WebCore.xcodeproj/project.pbxproj:
              * platform/cf/RetainPtr.h: Added.
              (WTF::):
              (WTF::RetainPtr::RetainPtr):
              (WTF::RetainPtr::~RetainPtr):
              (WTF::RetainPtr::get):
              (WTF::RetainPtr::operator*):
              (WTF::RetainPtr::operator->):
              (WTF::RetainPtr::operator!):
              (WTF::RetainPtr::operator UnspecifiedBoolType):
              (WTF::::operator):
              (WTF::::swap):
              (WTF::swap):
              (WTF::operator==):
              (WTF::operator!=):
              (WTF::static_pointer_cast):
              (WTF::const_pointer_cast):
              (WTF::getPtr):
              
              - use it in WidgetMac so it gets tested in at least one place
              
              * platform/mac/WidgetMac.mm:
              (WebCore::Widget::Widget):
              (WebCore::Widget::~Widget):
              (WebCore::Widget::setEnabled):
              (WebCore::Widget::isEnabled):
              (WebCore::Widget::setCursor):
              (WebCore::Widget::getView):
              (WebCore::Widget::setView):
              (WebCore::Widget::getOuterView):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16987 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b7091e47