1. 25 Jul, 2013 40 commits
    • roger_fong@apple.com's avatar
      Unreviewed. Followup to r153360. · 86886187
      roger_fong@apple.com authored
      * JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
      * JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153361 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      86886187
    • msaboff@apple.com's avatar
      [Windows] Speculative build fix. · 7bb54be7
      msaboff@apple.com authored
      Moved interpreterThrowInCaller() out of LLintExceptions.cpp into new CommonSlowPathsExceptions.cpp
      that is always compiled.  Made LLInt::returnToThrow() conditional on LLINT being enabled.
      Roger will add the new files to Windows project in another checkin.
      
      * JavaScriptCore.xcodeproj/project.pbxproj:
      * llint/LLIntExceptions.cpp:
      * llint/LLIntExceptions.h:
      * llint/LLIntSlowPaths.cpp:
      (JSC::LLInt::LLINT_SLOW_PATH_DECL):
      * runtime/CommonSlowPaths.cpp:
      (JSC::SLOW_PATH_DECL):
      * runtime/CommonSlowPathsExceptions.cpp: Added.
      (JSC::CommonSlowPaths::interpreterThrowInCaller):
      * runtime/CommonSlowPathsExceptions.h: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153360 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7bb54be7
    • bfulgham@apple.com's avatar
      [Windows] Unreviewed build fix. · e8a6a244
      bfulgham@apple.com authored
      * JavaScriptCore.vcxproj/JavaScriptCore.vcxproj: Add missing IntendedStructureChange.h,.cpp and
      parser/SourceCode.h,.cpp.
      * JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters: Ditto.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153359 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e8a6a244
    • bfulgham@apple.com's avatar
      [Windows] Unreviewed build fix. · 8fa72ab1
      bfulgham@apple.com authored
      * WTF.vcxproj/WTF.vcxproj: Add missing SixCharacterHash.h,.cpp files.
      * WTF.vcxproj/WTF.vcxproj.filters: Ditto.
      * wtf/NumberOfCores.h: Add export macro to numberOfProcessorCores.
      * wtf/PrintStream.h: Add export macro to dumpCharacter.
      * wtf/SixCharacterHash.h: Add export macro to sixCharacterHashStringToInteger
      and integerToSixCharacterHashString.
      * wtf/text/CString.h: Add export macro to hash and equal methods.
      (WTF::CStringHash::hash): Add export macro.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153358 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8fa72ab1
    • andersca@apple.com's avatar
      ASSERT(m_vm->apiLock().currentThreadIsHoldingLock()); fails for Safari on current ToT · b987aae6
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=119108
      
      Reviewed by Mark Hahnenberg.
      
      Add a currentThreadIsHoldingAPILock() function to VM that checks if the current thread is the exclusive API thread.
      
      * heap/CopiedSpace.cpp:
      (JSC::CopiedSpace::tryAllocateSlowCase):
      * heap/Heap.cpp:
      (JSC::Heap::protect):
      (JSC::Heap::unprotect):
      (JSC::Heap::collect):
      * heap/MarkedAllocator.cpp:
      (JSC::MarkedAllocator::allocateSlowCase):
      * runtime/JSGlobalObject.cpp:
      (JSC::JSGlobalObject::init):
      * runtime/VM.h:
      (JSC::VM::currentThreadIsHoldingAPILock):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153357 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b987aae6
    • akling@apple.com's avatar
      ChromeClient::focusedNodeChanged() should be focusedElementChanged(). · 96b365f0
      akling@apple.com authored
      <http://webkit.org/b/119110>
      
      Reviewed by Anders Carlsson.
      
      Source/WebCore:
      
      Because only Elements can be focused.
      
      * dom/Document.cpp:
      (WebCore::Document::setFocusedElement):
      * loader/EmptyClients.h:
      (WebCore::EmptyChromeClient::focusedElementChanged):
      * page/Chrome.cpp:
      (WebCore::Chrome::focusedElementChanged):
      * page/Chrome.h:
      * page/ChromeClient.h:
      
      Source/WebKit/blackberry:
      
      * WebCoreSupport/ChromeClientBlackBerry.cpp:
      (WebCore::ChromeClientBlackBerry::focusedElementChanged):
      * WebCoreSupport/ChromeClientBlackBerry.h:
      
      Source/WebKit/efl:
      
      * WebCoreSupport/ChromeClientEfl.cpp:
      (WebCore::ChromeClientEfl::focusedElementChanged):
      * WebCoreSupport/ChromeClientEfl.h:
      
      Source/WebKit/gtk:
      
      * WebCoreSupport/ChromeClientGtk.cpp:
      (WebKit::ChromeClient::focusedElementChanged):
      * WebCoreSupport/ChromeClientGtk.h:
      
      Source/WebKit/mac:
      
      * WebCoreSupport/WebChromeClient.h:
      * WebCoreSupport/WebChromeClient.mm:
      (WebChromeClient::focusedElementChanged):
      
      Source/WebKit/qt:
      
      * WebCoreSupport/ChromeClientQt.cpp:
      (WebCore::ChromeClientQt::focusedElementChanged):
      * WebCoreSupport/ChromeClientQt.h:
      
      Source/WebKit/win:
      
      * WebCoreSupport/WebChromeClient.cpp:
      (WebChromeClient::focusedElementChanged):
      * WebCoreSupport/WebChromeClient.h:
      
      Source/WebKit/wince:
      
      * WebCoreSupport/ChromeClientWinCE.cpp:
      (WebKit::ChromeClientWinCE::focusedElementChanged):
      * WebCoreSupport/ChromeClientWinCE.h:
      
      Source/WebKit2:
      
      * WebProcess/WebCoreSupport/WebChromeClient.cpp:
      (WebKit::WebChromeClient::focusedElementChanged):
      * WebProcess/WebCoreSupport/WebChromeClient.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153356 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      96b365f0
    • kseo@webkit.org's avatar
      [WK2][Soup] Add private browsing support · 312a6bba
      kseo@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=118657
      
      Reviewed by Gustavo Noronha Silva.
      
      Source/WebCore:
      
      Support private browsing by adding a method to create a private
      browsing soup session. This private browsing session uses a
      non-persistent cookie jar and does not use the disk cache feature.
      
      No new tests. Covered by existing private browsing tests.
      
      * platform/network/NetworkStorageSession.h:
      (WebCore::NetworkStorageSession::isPrivateBrowsingSession):
      Add USE(SOUP) guard to isPrivateBrowsingSession() and m_isPrivate.
      
      * platform/network/ResourceHandle.h:
      Add a factory method to create a private browsing session for soup.
      
      * platform/network/soup/CookieJarSoup.cpp:
      (WebCore::createPrivateBrowsingCookieJar):
      * platform/network/soup/CookieJarSoup.h:
      Add a method to create a non-persistent cookie jar for private browsing.
      
      * platform/network/soup/NetworkStorageSessionSoup.cpp:
      (WebCore::NetworkStorageSession::NetworkStorageSession):
      Initialize m_isPrivate to false.
      (WebCore::NetworkStorageSession::createPrivateBrowsingSession):
      Implement the method by invoking ResourceHandle::createPrivateBrowsingSession.
      
      * platform/network/soup/ResourceHandleSoup.cpp:
      (WebCore::createSoupSession):
      Extract common soup session creation code so that both defaultSession
      and createPrivateBrowsingSession can use this function to create a soup
      session.
      (WebCore::ResourceHandle::defaultSession):
      Change to use createSoupSession.
      (WebCore::ResourceHandle::createPrivateBrowsingSession):
      Create a session which uses a non-persistent cookie jar.
      
      Source/WebKit2:
      
      Support private browsing in WK2 by implementing private browsing
      related methods in WebFrameNetworkingContext.
      
      * WebProcess/InjectedBundle/InjectedBundle.cpp:
      (WebKit::InjectedBundle::setPrivateBrowsingEnabled):
      Add USE(SOUP) guard.
      
      * WebProcess/WebCoreSupport/soup/WebFrameNetworkingContext.cpp:
      Add private browsing support methods. Copied from the Mac port.
      (WebKit::WebFrameNetworkingContext::ensurePrivateBrowsingSession):
      (WebKit::WebFrameNetworkingContext::destroyPrivateBrowsingSession):
      (WebKit::WebFrameNetworkingContext::storageSession):
      Check if the frame enables private browsing and return the private
      browsing session.
      * WebProcess/WebCoreSupport/soup/WebFrameNetworkingContext.h:
      
      * WebProcess/WebProcess.cpp:
      (WebKit::WebProcess::ensurePrivateBrowsingSession):
      Add USE(SOUP) guard.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153355 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      312a6bba
    • zandobersek@gmail.com's avatar
      REGRESSION(FTL): Most layout tests crashes · cfed88e5
      zandobersek@gmail.com authored
      https://bugs.webkit.org/show_bug.cgi?id=119089
      
      Reviewed by Oliver Hunt.
      
      * runtime/ExecutionHarness.h:
      (JSC::prepareForExecution): Move prepareForExecutionImpl call into its own statement. This prevents the GCC-compiled
      code to create the PassOwnPtr<JSC::JITCode> (intended as a parameter to the installOptimizedCode call) from the jitCode
      RefPtr<JSC::JITCode> parameter before the latter was actually given a proper value through the prepareForExecutionImpl call.
      Currently it's created beforehand and therefor holds a null pointer before it's anchored as the JIT code in
      JSC::CodeBlock::setJITCode, which later indirectly causes assertions in JSC::CodeBlock::jitCompile.
      (JSC::prepareFunctionForExecution): Ditto for prepareFunctionForExecutionImpl.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153354 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cfed88e5
    • mrowe@apple.com's avatar
      Fix build of DumpRenderTree and WebKitTestRunner when building against an SDK. · 5353a00a
      mrowe@apple.com authored
      * DumpRenderTree/mac/Configurations/Base.xcconfig: Fix framework search path when building against an SDK.
      * WebKitTestRunner/Configurations/Base.xcconfig: Ditto. Also fix where our scripts look for WebCore.framework
      so they pull the version out of the SDK.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153353 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5353a00a
    • kseo@webkit.org's avatar
      Build fix: use of long long in CoreIPC::ArgumentEncoder and CoreIPC::ArgumentDecoder · 8bdfe220
      kseo@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=118228
      
      Reviewed by Anders Carlsson.
      
      Build fails on some platforms where int64_t and long long are different types.
      
      * Shared/FileAPI/BlobRegistrationData.cpp:
      (WebKit::BlobRegistrationData::encode):
      Add explicit casts to int64_t.
      (WebKit::BlobRegistrationData::decode):
      Use int64_t instead of long long.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153352 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8bdfe220
    • bfulgham@apple.com's avatar
      [Windows] Unreviewed build fix. · c105d4c1
      bfulgham@apple.com authored
      * JavaScriptCore.vcxproj/JavaScriptCoreCommon.props: Add missing 'ftl'
      include path.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153351 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c105d4c1
    • zoltan@webkit.org's avatar
      [CSS Shapes] Add missing includes to shape-inside polygon tests · 79f1e80c
      zoltan@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=119098
      
      Reviewed by Dirk Schulze.
      
      We need to include subpixel-utils.js for tests which use simple-polygon.js, since it uses
      SubPixelLayout, otherwise both the result/expected are generating incorrect output.
      
      * fast/shapes/shape-inside/shape-inside-regular-polygon16-expected.html:
      * fast/shapes/shape-inside/shape-inside-regular-polygon16.html:
      * fast/shapes/shape-inside/shape-inside-regular-polygon8-expected.html:
      * fast/shapes/shape-inside/shape-inside-regular-polygon8.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153350 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      79f1e80c
    • timothy_horton@apple.com's avatar
      Null check m_frame in maximum and minimumScrollPosition · 8d3fd7f8
      timothy_horton@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=119109
      <rdar://problem/14545393>
      
      Reviewed by Darin Adler.
      
      * page/FrameView.cpp:
      (WebCore::FrameView::minimumScrollPosition):
      (WebCore::FrameView::maximumScrollPosition):
      Null-check m_frame (and move the early-return after the clamp-to-0
      as the revert in r152911 should have).
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153349 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8d3fd7f8
    • andersca@apple.com's avatar
      Localizable.strings generated by extract-localizable-strings should be UTF-8 · e7207313
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=119106
      
      Reviewed by Mark Rowe.
      
      Source/WebCore:
      
      * English.lproj/Localizable.strings:
      Re-encode this as UTF-8 and remove the BOM.
      
      * WebCore.xcodeproj/project.pbxproj:
      Set the file encoding of Localizable.strings to UTF-8.
      
      Tools:
      
      Output strings as UTF-8.
      
      * Scripts/extract-localizable-strings:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153348 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e7207313
    • rniwa@webkit.org's avatar
      Don't force layout when querying a fixed or non-box margin/padding property · cfa29f07
      rniwa@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=118032
      
      Reviewed by David Hyatt.
      
      Source/WebCore: 
      
      Merge https://chromium.googlesource.com/chromium/blink/+/66427d0825fcc2975bd50220cdcaa2504d6f36e5.
      
      This patch avoids layout in ComputedStyleExtractor::propertyValue for margin and padding properties
      when they are of fixed length. According to the Blink patch's author, this improves the page load
      time of economist.com by 27%.
      
      The actual code change is significantly different from the original Blink patch since we've done
      some refactorins in r152938 and r153067 to make this change more self-contained.
      
      Test: fast/css/computed-width-without-renderer.html
      
      * css/CSSComputedStyleDeclaration.cpp:
      (WebCore::zoomAdjustedPaddingOrMarginPixelValue):
      (WebCore::paddingOrMarginIsRendererDependent):
      (WebCore::isLayoutDependent):
      (WebCore::ComputedStyleExtractor::propertyValue):
      
      LayoutTests: 
      
      Add a regression test inspired by the one added in
      https://chromium.googlesource.com/chromium/blink/+/ff234b1593b2b493d47f38f687d09a87bc42c9eb.
      
      * fast/css/computed-width-without-renderer-expected.txt: Added.
      * fast/css/computed-width-without-renderer.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153347 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cfa29f07
    • achristensen@apple.com's avatar
      Source/ThirdParty/ANGLE: Made Windows build system for ANGLE and removed... · bc181c49
      achristensen@apple.com authored
      Source/ThirdParty/ANGLE: Made Windows build system for ANGLE and removed existing broken build system.
      Removed empty src/libGLESv2/shaders directory and old README files.
      https://bugs.webkit.org/show_bug.cgi?id=119103
      
      Reviewed by Brent Fulgham.
      
      * ANGLE.vcxproj: Added.
      * ANGLE.vcxproj/ANGLEGenerated.vcxproj: Added.
      * ANGLE.vcxproj/ANGLEGenerated.vcxproj.filters: Added.
      * ANGLE.vcxproj/libEGL.vcxproj: Added.
      * ANGLE.vcxproj/libEGL.vcxproj.filters: Added.
      * ANGLE.vcxproj/libEGLCommon.props: Added.
      * ANGLE.vcxproj/libGLESv2.vcxproj: Added.
      * ANGLE.vcxproj/libGLESv2.vcxproj.filters: Added.
      * ANGLE.vcxproj/libGLESv2Common.props: Added.
      * ANGLE.vcxproj/translator.vcxproj: Added.
      * ANGLE.vcxproj/translator.vcxproj.filters: Added.
      * ANGLE.vcxproj/translatorCommon.props: Added.
      * src/ANGLE.sln: Removed.
      * src/compiler/preprocessor/preprocessor.vcxproj: Removed.
      * src/compiler/preprocessor/preprocessor.vcxproj.filters: Removed.
      * src/compiler/translator_common.vcxproj: Removed.
      * src/compiler/translator_common.vcxproj.filters: Removed.
      * src/compiler/translator_hlsl.vcxproj: Removed.
      * src/compiler/translator_hlsl.vcxproj.filters: Removed.
      * src/libEGL/README: Removed.
      * src/libEGL/libEGL.vcxproj: Removed.
      * src/libEGL/libEGL.vcxproj.filters: Removed.
      * src/libGLESv2/README: Removed.
      * src/libGLESv2/libGLESv2.vcxproj: Removed.
      * src/libGLESv2/libGLESv2.vcxproj.filters: Removed.
      * src/libGLESv2/shaders: Removed.
      
      Source/WebKit: Made Windows build system for ANGLE.
      https://bugs.webkit.org/show_bug.cgi?id=119103
      
      Reviewed by Brent Fulgham.
      
      * WebKit.vcxproj/WebKit.sln:
      Added ANGLEGenerated, libEGL, libGLESv2, and translator projects.
      These projects are currently not built.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153346 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bc181c49
    • bfulgham@apple.com's avatar
      [Windows] Provide ASM implemenation of 8-bit compare-and-swap · 7a96c0ce
      bfulgham@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=119084
      
      Patch by peavo@outlook.com <peavo@outlook.com> on 2013-07-25
      Reviewed by Brent Fulgham.
      
      * wtf/Atomics.h:
      (WTF::weakCompareAndSwap): Add a 32-bit X86 Assembly path for
      Windows build.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153345 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7a96c0ce
    • weinig@apple.com's avatar
      -[WebHTMLView attributedSubstringForProposedRange:actualRange:] does not... · 212f5170
      weinig@apple.com authored
      -[WebHTMLView attributedSubstringForProposedRange:actualRange:] does not include strikethrough attribute in the returned attributed string
      https://bugs.webkit.org/show_bug.cgi?id=119099
      <rdar://problem/13439291>
      
      Reviewed by Enrica Casucci.
      
      Source/WebCore: 
      
      Tests:
          API Test: AttributedStringTest_Strikethrough
      
      * platform/mac/HTMLConverter.mm:
      (+[WebHTMLConverter editingAttributedStringFromRange:]):
      Set the NSStrikethroughStyleAttributeName attribute when text-decoration: line-through is seen.
      
      Tools: 
      
      * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
      * TestWebKitAPI/Tests/mac/AttributedString.mm:
      (TestWebKitAPI::attributedString):
      (TestWebKitAPI::AttributedStringTest_CustomFont::didLoadURL):
      (TestWebKitAPI::AttributedStringTest_CustomFont::url):
      (TestWebKitAPI::AttributedStringTest_CustomFont::runTest):
      (TestWebKitAPI::TEST_F):
      (TestWebKitAPI::AttributedStringTest_Strikethrough::didLoadURL):
      (TestWebKitAPI::AttributedStringTest_Strikethrough::url):
      (TestWebKitAPI::AttributedStringTest_Strikethrough::runTest):
      * TestWebKitAPI/Tests/mac/attributedStringStrikethrough.html: Added.
      Add tests for attributed strings with strikethrough.  Refactor the attributed string tests
      to make adding more easier in the future.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153344 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      212f5170
    • bfulgham@apple.com's avatar
      [Windows] Unreviewed build fix. · 35f7357a
      bfulgham@apple.com authored
      * JavaScriptCore.vcxproj/JavaScriptCore.vcxproj: Add some missing files:
      runtime/VM.h,.cpp; Remove deleted JSGlobalData.h,.cpp.
      * JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters: Ditto.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153343 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      35f7357a
    • bfulgham@apple.com's avatar
      [Windows] Unreviewed build fix. · 18b73c56
      bfulgham@apple.com authored
      * WTF.vcxproj/WTF.vcxproj: Add missing CompilationThread.h,.cpp
      * WTF.vcxproj/WTF.vcxproj.filters: Ditto.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153342 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      18b73c56
    • oliver@apple.com's avatar
      Make all jit & non-jit combos build cleanly · 807e7e15
      oliver@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=119102
      
      Reviewed by Anders Carlsson.
      
      * bytecode/CodeBlock.cpp:
      (JSC::CodeBlock::counterValueForOptimizeSoon):
      * bytecode/CodeBlock.h:
      (JSC::CodeBlock::optimizeAfterWarmUp):
      (JSC::CodeBlock::numberOfDFGCompiles):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153341 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      807e7e15
    • psolanki@apple.com's avatar
      Unreviewed build fix after r153333. · e0b2fe34
      psolanki@apple.com authored
      * platform/network/cf/ResourceResponseCFNet.cpp: Remove toTimeT since it is no longer called.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153340 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e0b2fe34
    • oliver@apple.com's avatar
      32 bit portion of load validation logic · a360d163
      oliver@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=118878
      Reviewed by NOBODY (Build fix).
      * dfg/DFGSpeculativeJIT32_64.cpp:
      (JSC::DFG::SpeculativeJIT::compile):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153339 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a360d163
    • betravis@adobe.com's avatar
      [CSS Shapes] Fix typo in simple-polygon.js · d7d66eb4
      betravis@adobe.com authored
      https://bugs.webkit.org/show_bug.cgi?id=119096
      
      Reviewed by Dirk Schulze.
      
      A function name typo was preventing tests and expectations using simple-polygon.js
      from generating correct output.
      
      * fast/shapes/resources/simple-polygon.js:
      (polygonXIntercepts): Correctly camel-case function name.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153338 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d7d66eb4
    • commit-queue@webkit.org's avatar
      [CSS Shapes] New positioning model: support for circle and ellipse shape-outside · e9ad442d
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=118084
      
      Patch by Bem Jones-Bey <bjonesbe@adobe.com> on 2013-07-25
      Reviewed by Dirk Schulze.
      
      Update circle and ellipse tests to work with new positioning. These
      have been rehomed as W3C spec tests, and thus are imported from the
      CSSWG's repository.
      
      * TestExpectations: Remove skip for updated tests.
      * csswg/submitted/shapes/shape-outside/shape-outside-floats-circle-000-expected.html: Renamed from LayoutTests/fast/shapes/shape-outside-floats/shape-outside-floats-simple-circle-expected.html.
      * csswg/submitted/shapes/shape-outside/shape-outside-floats-circle-000.html: Renamed from LayoutTests/fast/shapes/shape-outside-floats/shape-outside-floats-simple-circle.html.
      * csswg/submitted/shapes/shape-outside/shape-outside-floats-ellipse-000-expected.html: Renamed from LayoutTests/fast/shapes/shape-outside-floats/shape-outside-floats-simple-ellipse-expected.html.
      * csswg/submitted/shapes/shape-outside/shape-outside-floats-ellipse-000.html: Renamed from LayoutTests/fast/shapes/shape-outside-floats/shape-outside-floats-simple-ellipse.html.
      * csswg/submitted/shapes/shape-outside/w3c-import.log:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153337 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e9ad442d
    • michael.bruning@digia.com's avatar
      Fix Windows build after r153134. · 6fded78f
      michael.bruning@digia.com authored
      https://bugs.webkit.org/show_bug.cgi?id=119090
      
      Reviewed by Oliver Hunt.
      
      Add USE(PTHREADS) guards around pthread specific code
      for now. This will cause isCompilationThread to always
      return false on non pthread platforms such as Windows.
      
      We might be able to use the Windows one-time initialization
      for this, but this is only available from Windows Vista on.
      
      * wtf/CompilationThread.cpp:
      (WTF::initializeCompilationThreads):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153336 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6fded78f
    • ch.dumez@sisa.samsung.com's avatar
      Unreviewed EFL build fix after r153315. · c4956b11
      ch.dumez@sisa.samsung.com authored
      Fix build error after we started compiling with c++0x support
      in r153315.
      
      * platform/efl/RenderThemeEfl.cpp:
      (WebCore::toEdjeGroup):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153335 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c4956b11
    • oliver@apple.com's avatar
      More 32bit build fixes · a745e206
      oliver@apple.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153334 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a745e206
    • andersca@apple.com's avatar
      Remove lastModifiedDate from ResourceResponse · 58304c96
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=119092
      
      Reviewed by Andreas Kling.
      
      Source/WebCore:
      
      Computing m_lastResponseDate is costly on some platforms and we already have a better way to
      get the last response time, so convert the two call sites that used to call ResourceresponseBase::lastModifiedDate()
      over to using lastModified() instead.
      
      * platform/network/ResourceResponseBase.cpp:
      (WebCore::ResourceResponseBase::ResourceResponseBase):
      (WebCore::ResourceResponseBase::adopt):
      (WebCore::ResourceResponseBase::copyData):
      * platform/network/ResourceResponseBase.h:
      * platform/network/cf/ResourceResponseCFNet.cpp:
      (WebCore::ResourceResponse::platformLazyInit):
      * plugins/PluginStream.cpp:
      (WebCore::lastModifiedDate):
      (WebCore::PluginStream::startStream):
      
      Source/WebKit2:
      
      Update for WebCore changes.
      
      * WebProcess/Plugins/PluginView.cpp:
      (WebKit::lastModifiedDate):
      Use ResourceResponse::lastModified() to get the last modified date.
      
      (WebKit::PluginView::Stream::didReceiveResponse):
      Call the static lastModified function.
      
      (WebKit::PluginView::manualLoadDidReceiveResponse):
      Ditto.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153333 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      58304c96
    • ch.dumez@sisa.samsung.com's avatar
      Unreviewed EFL build fix after r153315. · 233cf8a5
      ch.dumez@sisa.samsung.com authored
      Use -std=gnu++0x instead of -std=c++0x as we rely on GNU extensions such as
      typeof().
      
      * Source/cmake/WebKitHelpers.cmake:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153332 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      233cf8a5
    • commit-queue@webkit.org's avatar
      Optimize the thread locks for API Shims · a7bbb1bb
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=118573
      
      Patch by Yi Shen <max.hong.shen@gmail.com> on 2013-07-25
      Reviewed by Geoffrey Garen.
      
      Remove the thread lock from API Shims if the VM has an exclusive thread (e.g. the VM
      only used by WebCore's main thread).
      
      Source/JavaScriptCore:
      
      * API/APIShims.h:
      (JSC::APIEntryShim::APIEntryShim):
      (JSC::APICallbackShim::APICallbackShim):
      * runtime/JSLock.cpp:
      (JSC::JSLockHolder::JSLockHolder):
      (JSC::JSLockHolder::init):
      (JSC::JSLockHolder::~JSLockHolder):
      (JSC::JSLock::DropAllLocks::DropAllLocks):
      (JSC::JSLock::DropAllLocks::~DropAllLocks):
      * runtime/VM.cpp:
      (JSC::VM::VM):
      * runtime/VM.h:
      
      Source/WebCore:
      
      No new tests required since no functionality changed.
      
      * bindings/js/JSDOMWindowBase.cpp:
      (WebCore::JSDOMWindowBase::commonVM):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153331 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a7bbb1bb
    • betravis@adobe.com's avatar
      [CSS Shapes] Shape methods and member variables should be guarded with the CSS_SHAPES flag · 17694594
      betravis@adobe.com authored
      https://bugs.webkit.org/show_bug.cgi?id=117277
      
      Reviewed by Alexandru Chiculita.
      
      This patch adds some compile guards that were missing from the RenderStyle and
      StyleRareNonInheritedData files. When the compile guard caused parameters to
      not be used, the parameters were marked using UNUSED_PARAM.
      
      * css/CSSPropertyNames.in: Inserting a line to trigger build.
      * rendering/RenderBlock.cpp:
      (WebCore::shapeInfoRequiresRelayout):
      (WebCore::RenderBlock::updateRegionsAndShapesBeforeChildLayout):
      (WebCore::RenderBlock::logicalRightFloatOffsetForLine):
      * rendering/RenderBox.cpp:
      (WebCore::isCandidateForOpaquenessTest):
      * rendering/RenderBox.h:
      * rendering/RenderObject.h:
      * rendering/style/RenderStyle.cpp:
      (WebCore::RenderStyle::changeRequiresLayout):
      (WebCore::RenderStyle::changeRequiresRepaint):
      * rendering/style/RenderStyle.h:
      * rendering/style/StyleRareNonInheritedData.cpp:
      (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
      (WebCore::StyleRareNonInheritedData::operator==):
      * rendering/style/StyleRareNonInheritedData.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153330 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      17694594
    • ch.dumez@sisa.samsung.com's avatar
      Unreviewed build fix after r153218. · 147eafc9
      ch.dumez@sisa.samsung.com authored
      Broke the EFL port build with gcc 4.7.
      
      * interpreter/StackIterator.cpp:
      (JSC::printif):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153329 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      147eafc9
    • commit-queue@webkit.org's avatar
      Build fix: add missing #include. · c717b211
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=119087
      
      Patch by Julien Brianceau <jbrianceau@nds.com> on 2013-07-25
      Reviewed by Allan Sandfeld Jensen.
      
      * bytecode/ArrayProfile.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153328 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c717b211
    • carlosgc@webkit.org's avatar
      [GTK] Add support for running unit tests in the web process · 96d9dfd8
      carlosgc@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=118427
      
      Reviewed by Gustavo Noronha Silva.
      
      Some tests, like GObject DOM bindings API tests, run entirely in
      the WebProcess, so we just need to start the test from the UI
      process and wait until the test finishes running in the
      WebProcess. Tests are split in two files, one containing the
      actual test that runs in the WebProcess and another one to add the
      tests to the glib test system that works as a
      proxy. WebProcessTestRunner class starts a private DBus session
      bus and starts the tests sending a message to the WebExtension
      waiting until it finishes or fails. WebProcess tests are created
      by defining a class derived from WebProcessTest class and
      implementing the static create method and the virtual runTest
      method. The macro REGISTER_TEST is used by the web process tests
      to register their test cases. This patch includes the migration
      of the WebKitDOMNode test, all other GObject DOM bindings tests
      will be migrated in the same way in follow up patches.
      
      * UIProcess/API/gtk/tests/DOMNodeTest.cpp: Added.
      (WebKitDOMNodeTest::create): Create a new WebKitDOMNodeTest.
      (WebKitDOMNodeTest::webPageFromArgs): Get the pageID parameter
      from the arguments dictionary.
      (WebKitDOMNodeTest::testHierarchyNavigation):
      (WebKitDOMNodeTest::testInsertion):
      (WebKitDOMNodeTest::runTest): Run the given test.
      (registerTests): Register test cases.
      * UIProcess/API/gtk/tests/GNUmakefile.am: Add new files to
      compilation.
      * UIProcess/API/gtk/tests/TestDOMNode.cpp: Added.
      (testWebKitDOMNodeHierarchyNavigation):
      (testWebKitDOMNodeInsertion):
      (beforeAll):
      (afterAll):
      * UIProcess/API/gtk/tests/TestMain.cpp:
      (main): Unset DBUS_SESSION_BUS_ADDRESS environment variable to
      make sure that the GLib bus singleton is initialized by the
      private DBus session bus created by the tests.
      * UIProcess/API/gtk/tests/WebProcessTest.cpp: Added.
      (testsMap): Initialize and get the global map of tests.
      (WebProcessTest::add): Add a new test to the map, keeping a
      function to create the test.
      (WebProcessTest::create): Create a test for the given name.
      (methodCallCallback): Handle RunTest DBus method. It creates and
      runs the given test.
      (webkit_web_extension_initialize):Register the DBus service for
      this WebExtension.
      * UIProcess/API/gtk/tests/WebProcessTest.h: Added.
      * UIProcess/API/gtk/tests/WebProcessTestRunner.cpp: Added.
      (WebProcessTestRunner::WebProcessTestRunner): Start a private DBus
      session bus and get a connection to it.
      (WebProcessTestRunner::~WebProcessTestRunner): Stop the private
      DBus session bus.
      (WebProcessTestRunner::proxyCreatedCallback):
      (WebProcessTestRunner::proxy): Create a new proxy to send messages
      to the WebExtension if it doesn't exists.
      (WebProcessTestRunner::onNameAppeared): Called when the DBus
      service has been registered in the WebExtension and it's safe to
      create a proxy.
      (WebProcessTestRunner::onNameVanished): Called when the DBus
      service is unregistered. This happens when the web process crash,
      so we just exit here, because the g_asserts in the web process
      have already registered the error message.
      (WebProcessTestRunner::testFinishedCallback): Called when the
      WebProcess tests has finished.
      (WebProcessTestRunner::runTest): Send a message to the
      WebExtension to start the given test and monitor the service.
      (WebProcessTestRunner::finishTest): Save the test result and
      finish the main loop.
      * UIProcess/API/gtk/tests/WebProcessTestRunner.h: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153327 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      96d9dfd8
    • allan.jensen@digia.com's avatar
      Fix windows build after FTL upstream · bb849b5b
      allan.jensen@digia.com authored
      Unreviewed build fix.
      
      * wtf/Atomics.h:
      (WTF::weakCompareAndSwap):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153326 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bb849b5b
    • ryuan.choi@samsung.com's avatar
      Unreviewed, build fix on the EFL port. · 62965e01
      ryuan.choi@samsung.com authored
      * CMakeLists.txt: Added JSCTestRunnerUtils.cpp.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153325 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      62965e01
    • commit-queue@webkit.org's avatar
      [sh4] Add missing store8(TrustedImm32, void*) implementation in baseline JIT. · 5dc82093
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=119083
      
      Patch by Julien Brianceau <jbrianceau@nds.com> on 2013-07-25
      Reviewed by Allan Sandfeld Jensen.
      
      * assembler/MacroAssemblerSH4.h:
      (JSC::MacroAssemblerSH4::store8):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153324 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5dc82093
    • allan.jensen@digia.com's avatar
      [Qt] Fix test build after FTL upstream · e5e8cde9
      allan.jensen@digia.com authored
      Unreviewed build fix.
      
      * Target.pri:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153323 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e5e8cde9
    • allan.jensen@digia.com's avatar
      [Qt] Build fix after FTL. · 9f5c9b80
      allan.jensen@digia.com authored
      Un Reviewed build fix.
      
      * Target.pri:
      * interpreter/StackIterator.cpp:
      (JSC::StackIterator::Frame::print):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153322 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9f5c9b80