1. 12 Apr, 2011 40 commits
    • abarth@webkit.org's avatar
      Move libtess from WebCore/thirdparty to ThirdParty · 86868cc4
      abarth@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=57288
      
      Reviewed by Kenneth Russell.
      
      We're putting third party code in Source/ThirdParty these days.
      
      * Source/ThirdParty/glu: Copied from Source/WebCore/thirdparty/glu.
      * Source/ThirdParty/glu/glu.gyp: Added.
      
      Source/WebCore: 
      
      * WebCore.gyp/WebCore.gyp:
          - Add libtess as a legit dependency.
      * WebCore.gypi:
          - Remove libtess files from the gypi.
      * thirdparty/glu: Removed.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83641 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      86868cc4
    • rniwa@webkit.org's avatar
      2011-04-12 Ryosuke Niwa <rniwa@webkit.org> · 58925e8e
      rniwa@webkit.org authored
              Reviewed by David Hyatt.
      
              Bundle w and tmpW in findNextLineBreak together as a class
              https://bugs.webkit.org/show_bug.cgi?id=58362
      
              Renamed w, tempW, and width in findNextLineBreak to committedWidth, uncommittedWidth,
              and availableWidth respectively. Also bundled committedWidth and uncommittedWith as a class
              named LineWidth.
      
              * rendering/RenderBlockLineLayout.cpp:
              (WebCore::LineWidth::LineWidth): Added.
              (WebCore::LineWidth::currentWidth): Added; returns the sum of committed and uncommitted width.
              (WebCore::LineWidth::uncommittedWidth): Added.
              (WebCore::LineWidth::committedWidth): Added.
              (WebCore::LineWidth::addUncommittedWidth): Added; adds the specified width to the uncommitted width.
              (WebCore::LineWidth::commit): Added; commits the current width and clears the uncommitted width.
              (WebCore::RenderBlock::findNextLineBreak): Uses LineWidth.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83640 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      58925e8e
    • bfulgham@webkit.org's avatar
      2011-04-12 Carl Lobo <carllobo@gmail.com> and Brent Fulgham <bfulgham@webkit.org> · 78168742
      bfulgham@webkit.org authored
              Reviewed by Adam Roben.
      
              Patch to download the WinCairo dependancies as part of build-webkit.
              https://bugs.webkit.org/show_bug.cgi?id=51790
      
              This patch downloads the dependancies from 
                  http://idisk.mac.com/bfulgham-Public/WinCairoRequirements.zip 
              checking the modification timestamp etc. 
      
              * Tools/Scripts/build-webkit
              * Tools/Scripts/update-webkit: Modified to understand the --wincairo
                flag, and to update WinCairo dependencies when used.
              * Tools/Scripts/update-webkit-cairo-libs: added
              * Tools/Scripts/update-webkit-dependency: added
              * Tools/Scripts/update-webkit-auxiliary-libs
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83639 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      78168742
    • yael.aharon@nokia.com's avatar
      2011-04-12 Yael Aharon <yael.aharon@nokia.com> · 41ecbd77
      yael.aharon@nokia.com authored
              Reviewed by Eric Seidel.
      
              REGRESSION(r82419): extra border in t0805-c5519-ibrdr-r-00-a.html
              https://bugs.webkit.org/show_bug.cgi?id=57459
      
              * fast/borders/bidi-002.html: Added.
              * fast/borders/bidi-004.html: Added.
              * fast/borders/bidi-009a.html: Added.
              * platform/mac/fast/borders/bidi-002-expected.checksum: Added.
              * platform/mac/fast/borders/bidi-002-expected.png: Added.
              * platform/mac/fast/borders/bidi-002-expected.txt: Added.
              * platform/mac/fast/borders/bidi-004-expected.checksum: Added.
              * platform/mac/fast/borders/bidi-004-expected.png: Added.
              * platform/mac/fast/borders/bidi-004-expected.txt: Added.
              * platform/mac/fast/borders/bidi-009a-expected.checksum: Added.
              * platform/mac/fast/borders/bidi-009a-expected.png: Added.
              * platform/mac/fast/borders/bidi-009a-expected.txt: Added.
      2011-04-12  Yael Aharon  <yael.aharon@nokia.com>
      
              Reviewed by Eric Seidel.
      
              REGRESSION(r82419): extra border in t0805-c5519-ibrdr-r-00-a.html
              https://bugs.webkit.org/show_bug.cgi?id=57459
      
              Slightly change the way we decide if a InlineFlowBox is the last box for its renderer.
              We include the border in that box under these conditions:
              (1) The next line was not created, or it is constructed. We check the previous line for rtl.
              (2) The logicallyLastRun is not a descendant of this renderer.
              (3) The logicallyLastRun is a descendant of this renderer, but it is the last child of this renderer and it does not wrap to the next line.
              I added the tests from bug 47210, because now the draw the borders correctly.
      
              Tests: fast/borders/bidi-002.html
                     fast/borders/bidi-004.html
                     fast/borders/bidi-009a.html
      
              * rendering/InlineFlowBox.cpp:
              (WebCore::InlineFlowBox::onEndChain):
              (WebCore::isAnsectorAndWithinBlock):
              (WebCore::InlineFlowBox::determineSpacingForFlowBoxes):
              * rendering/InlineFlowBox.h:
              * rendering/RenderBlock.h:
              * rendering/RenderBlockLineLayout.cpp:
              (WebCore::RenderBlock::constructLine):
              (WebCore::RenderBlock::layoutInlineChildren):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83638 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      41ecbd77
    • ggaren@apple.com's avatar
      2011-04-12 Geoffrey Garen <ggaren@apple.com> · d9c1f256
      ggaren@apple.com authored
              Reviewed by Sam Weinig.
      
              Cleaned up some Vector traits, and added missing Vector traits for handles
              https://bugs.webkit.org/show_bug.cgi?id=58372
      
              * heap/Local.h: Inherit from SimpleClassVectorTraits to avoid duplication.
      
              * heap/Strong.h: Ditto.
      
              * heap/Weak.h: Ditto.
      
              * parser/JSParser.cpp: Fixed a traits error. No test case because this
              particular trait is not currently exercised by the parser.
      
              * runtime/UString.h: No need to override canInitializeWithMemset, since
              our base class sets it to true.
      
              * wtf/VectorTraits.h: Inherit from VectorTraitsBase to avoid duplication.
      
              * wtf/text/WTFString.h: No need to override canInitializeWithMemset, since
              our base class sets it to true.
      2011-04-12  Geoffrey Garen  <ggaren@apple.com>
      
              Reviewed by Sam Weinig.
      
              Cleaned up some Vector traits, and added missing Vector traits for handles
              https://bugs.webkit.org/show_bug.cgi?id=58372
      
              * platform/graphics/BitmapImage.h: Added a FIXME because the current
              Vector traits for FrameData are logically incorrect, but I couldn't find
              a place where this currently results in bad behavior, and it's not
              immediately obvious what the right solution is.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83637 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d9c1f256
    • dglazkov@chromium.org's avatar
      2011-04-12 Dimitri Glazkov <dglazkov@chromium.org> · 1ba41ac4
      dglazkov@chromium.org authored
              Reviewed by Eric Seidel.
      
              Move MediaControlElements to html/shadow.
              https://bugs.webkit.org/show_bug.cgi?id=58347
      
              Mechanical move of the files.
      
              * Android.mk: Updated the build file.
              * CMakeLists.txt: Ditto.
              * GNUmakefile.list.am: Ditto.
              * WebCore.gypi: Ditto.
              * WebCore.pro: Ditto.
              * WebCore.vcproj/WebCore.vcproj: Ditto.
              * WebCore.xcodeproj/project.pbxproj: Ditto, also ran sort-XCode-project-files.
              * html/shadow/MediaControlElements.cpp: Copied from Source/WebCore/rendering/MediaControlElements.cpp.
              (WebCore::MediaControlFullscreenButtonElement::defaultEventHandler):
              * html/shadow/MediaControlElements.h: Copied from Source/WebCore/rendering/MediaControlElements.h.
              * rendering/MediaControlElements.cpp: Removed.
              * rendering/MediaControlElements.h: Removed.
              * rendering/RenderingAllInOne.cpp: Removed the files that were moved.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83636 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1ba41ac4
    • dpranke@chromium.org's avatar
      2011-04-12 Dirk Pranke <dpranke@chromium.org> · a5a9f563
      dpranke@chromium.org authored
              Reviewed by Tony Chang.
      
              new-run-webkit-tests: update code to use port.results_directory() instead of options.results_directory
              https://bugs.webkit.org/show_bug.cgi?id=58290
      
              This is some preliminary refactoring for bug 58272.
      
              * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
              * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
              * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
              * Scripts/webkitpy/layout_tests/layout_package/worker_mixin.py:
              * Scripts/webkitpy/layout_tests/port/test.py:
              * Scripts/webkitpy/layout_tests/port/chromium.py:
              * Scripts/webkitpy/layout_tests/port/base.py:
              * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83635 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a5a9f563
    • luiz@webkit.org's avatar
      [Qt] QNetworkReplyHandler refactoring: signal queue · 71ecf20f
      luiz@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=57075
      
      Reviewed by Andreas Kling.
      
      The idea is to make all signals that come from the QNetworkReply to pass through a queue and to
      stop that queue when loading is deferred. This way almost all the deferred logic can be removed
      from QNetworkReplyHandler class and encapsulated in its own class.
      
      To stop the queue during wrapper methods execution avoids stacking handler methods over wrapper
      methods. Because of this there is no chance for the wrapper to be destroyed inside one of its methods.
      This together with empting the queue at wrapper destruction time makes sure that the handler will
      not receive calls from a dead wrapper.
      
      The new class is named QNetworkReplyHandlerCallQueue.
      
      * platform/network/qt/QNetworkReplyHandler.cpp:
      (WebCore::QNetworkReplyHandlerCallQueue::QNetworkReplyHandlerCallQueue):
      (WebCore::QNetworkReplyHandlerCallQueue::push):
      (WebCore::QNetworkReplyHandlerCallQueue::lock):
      (WebCore::QNetworkReplyHandlerCallQueue::unlock):
      (WebCore::QNetworkReplyHandlerCallQueue::setDeferSignals):
      (WebCore::QueueLocker::QueueLocker):
      (WebCore::QueueLocker::~QueueLocker):
      (WebCore::QNetworkReplyWrapper::QNetworkReplyWrapper):
      (WebCore::QNetworkReplyWrapper::~QNetworkReplyWrapper):
      (WebCore::QNetworkReplyWrapper::receiveMetaData):
      (WebCore::QNetworkReplyWrapper::readyRead):
      (WebCore::QNetworkReplyWrapper::didReceiveFinished):
      (WebCore::QNetworkReplyHandler::QNetworkReplyHandler):
      (WebCore::QNetworkReplyHandler::resetState):
      (WebCore::QNetworkReplyHandler::release):
      (WebCore::QNetworkReplyHandler::finish):
      (WebCore::QNetworkReplyHandler::sendResponseIfNeeded):
      (WebCore::QNetworkReplyHandler::forwardData):
      (WebCore::QNetworkReplyHandler::start):
      (WebCore::QNetworkReplyHandler::synchronousLoad):
      * platform/network/qt/QNetworkReplyHandler.h:
      (WebCore::QNetworkReplyHandlerCallQueue::deferSignals):
      (WebCore::QNetworkReplyHandlerCallQueue::clear):
      (WebCore::QNetworkReplyWrapper::synchronousLoad):
      (WebCore::QNetworkReplyHandler::setLoadingDeferred):
      * platform/network/qt/ResourceHandleQt.cpp:
      (WebCore::ResourceHandle::loadResourceSynchronously):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83634 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      71ecf20f
    • jeffm@apple.com's avatar
      2011-04-12 Jeff Miller <jeffm@apple.com> · 475004b9
      jeffm@apple.com authored
              Reviewed by Adam Roben.
      
              WebKit2: Pressing Tab in Web Inspector's console does not cycle through completion options
              https://bugs.webkit.org/show_bug.cgi?id=56020
      
              Don't call TranslateMessage() in the MiniBrowser or TestWebKitAPI for key messages destined for a WebKit2 view,
              since WebKit will do this for us.  If we didn't do this, TranslateMessage() would be called twice,
              which would generate two characters for every keypress (for example).  I didn't bother doing this for
              WebKitTestRunner, since it doesn't get any WM_KEYDOWN events.
              
              Add new WebKit2/TranslateMessageGeneratesWMChar test to test expected TranslateMessage() behavior.
      
              * MiniBrowser/win/main.cpp:
              (shouldTranslateMessage): Added.
              (_tWinMain): Don't call TranslateMessage() unless shouldTranslateMessage() says to.
              * TestWebKitAPI/PlatformUtilities.h: Added shouldTranslateMessage() on Windows.
              * TestWebKitAPI/PlatformWebView.h: Added simulateAKeyDown().
              * TestWebKitAPI/Tests/WebKit2/win/TranslateMessageGeneratesWMChar.cpp: Added.
              (TestWebKitAPI::didNotHandleKeyEventCallback): Added.
              (TestWebKitAPI::runAndWatchForWMChar): Added.
              (TestWebKitAPI::TEST): Added.
              * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
              (TestWebKitAPI::Util::run): Don't call TranslateMessage() unless shouldTranslateMessage() says to.
              (TestWebKitAPI::Util::shouldTranslateMessage): Added.
              * TestWebKitAPI/win/PlatformWebViewWin.cpp:
              (TestWebKitAPI::PlatformWebView::simulateAKeyDown): Added.
              * TestWebKitAPI/win/TestWebKitAPI.vcproj: Added TranslateMessageGeneratesWMChar.cpp.
      2011-04-12  Jeff Miller  <jeffm@apple.com>
      
              Reviewed by Adam Roben.
      
              WebKit2: Pressing Tab in Web Inspector's console does not cycle through completion options
              https://bugs.webkit.org/show_bug.cgi?id=56020
      
              Safari was always calling TranslateMessage() on key events since it has no way to know whether
              WebKit handled the event without a PageUIClient (which Safari only installs on pages inside
              a Safari window), which was generating a WM_CHAR message containing the tab in this case.  The fix
              is for Safari to never call TranslateMessage() on key events outside of a Safari window, but this
              means the WebPageProxy needs to do this for unhandled key events if there is no didNotHandleKeyEvent
              callback in the PageUIClient.
      
              * UIProcess/WebPageProxy.cpp:
              (WebKit::WebPageProxy::didReceiveEvent): Call TranslateMessage() on Windows for unhandled key events that can't be handled by the PageUIClient.
              * UIProcess/WebUIClient.cpp:
              (WebKit::WebUIClient::canNotHandleKeyEvent): Added.
              * UIProcess/WebUIClient.h: Added canNotHandleKeyEvent().
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83633 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      475004b9
    • jam@chromium.org's avatar
    • dpranke@chromium.org's avatar
      2011-04-12 Dirk Pranke <dpranke@chromium.org> · c9c2838c
      dpranke@chromium.org authored
              Reviewed by Eric Seidel.
      
              webkitpy: fix mock_filesystem abspath to handle relative paths
              and add filesystem.chdir() and filesystem.getcwd() to be able
              to test this and mock it out.
      
              https://bugs.webkit.org/show_bug.cgi?id=58288
      
              * Scripts/webkitpy/common/system/filesystem.py:
              * Scripts/webkitpy/common/system/filesystem_mock.py:
              * Scripts/webkitpy/common/system/filesystem_unittest.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83631 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c9c2838c
    • jberlin@webkit.org's avatar
      [Windows XP Debug Tests] http/tests/inspector/resource-tree-model.html failing... · 1e2ea954
      jberlin@webkit.org authored
      [Windows XP Debug Tests] http/tests/inspector/resource-tree-model.html failing since introduction in r83584
      https://bugs.webkit.org/show_bug.cgi?id=58367
      
      Add expected failing results to get the bots green.
      
      * platform/win-xp/http: Added.
      * platform/win-xp/http/tests: Added.
      * platform/win-xp/http/tests/inspector: Added.
      * platform/win-xp/http/tests/inspector/resource-tree-model-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83630 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1e2ea954
    • hyatt@apple.com's avatar
      https://bugs.webkit.org/show_bug.cgi?id=58176 · aa956109
      hyatt@apple.com authored
              
      Reviewed by Dan Bernstein.
      
      Inline replaced elements following positioned elements on lines are not rendered. Make sure the
      logic for skipping run construction in appendRunsForObject matches the new logic that I added
      to findNextLineBreak. If they don't match up, you risk confusing the run construction code and
      causing it to not make runs for objects that follow the positioned object on the line.
      
      Source/WebCore: 
      
      Added fast/inline/positioned-object-between-replaced-elements.html
              
      * rendering/RenderBlockLineLayout.cpp:
      (WebCore::RenderBlock::appendRunsForObject):
      
      LayoutTests: 
      
      * fast/inline/positioned-object-between-replaced-elements.html: Added.
      * platform/mac/fast/inline/positioned-object-between-replaced-elements-expected.checksum: Added.
      * platform/mac/fast/inline/positioned-object-between-replaced-elements-expected.png: Added.
      * platform/mac/fast/inline/positioned-object-between-replaced-elements-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83629 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      aa956109
    • alice.liu@apple.com's avatar
      https://bugs.webkit.org/show_bug.cgi?id=58292 · dc9ed39b
      alice.liu@apple.com authored
      Provide new setting to allow site icon loading despite disabling automatic image loading in general.
      
      Reviewed by Sam Weinig.
      
      Source/WebCore: 
      
      Test: http/tests/misc/favicon-loads-with-icon-loading-override.html
      
      * WebCore.exp.in: Added export symbol
      * loader/FrameLoader.cpp:
      (WebCore::FrameLoader::startIconLoader): Check new setting before deciding that site icon images shouldn't be loaded.
      * page/Settings.cpp:
      (WebCore::Settings::Settings): Add initializer for new setting
      (WebCore::Settings::setLoadsSiteIconsIgnoringImageLoadingSetting): Add setter for new setting.
      * page/Settings.h: Explain nuances regarding loadsImagesAutomatically setting.
      (WebCore::Settings::loadsSiteIconsIgnoringImageLoadingSetting): Added getter.
      
      Source/WebKit/mac: 
      
      * WebView/WebPreferenceKeysPrivate.h: Add preference key.
      * WebView/WebPreferences.mm:
      (+[WebPreferences initialize]): Initialize to false.
      (-[WebPreferences setLoadsSiteIconsIgnoringImageLoadingPreference:]): Added.
      (-[WebPreferences loadsSiteIconsIgnoringImageLoadingPreference]): Added.
      * WebView/WebPreferencesPrivate.h: Add setter/getter definitions.
      * WebView/WebView.mm:
      (-[WebView _preferencesChanged:]): Add to settings that get propagated upon changes. 
      
      Source/WebKit/win: 
      
      * Interfaces/IWebPreferencesPrivate.idl: Added prefs. 
      * Interfaces/WebKit.idl: Touch file to force autogeneration
      * WebPreferenceKeysPrivate.h: Add preference key.
      * WebPreferences.cpp:
      (WebPreferences::initializeDefaultSettings): Initialize setting to false.
      (WebPreferences::setLoadsSiteIconsIgnoringImageLoadingPreference): Added setter
      (WebPreferences::loadsSiteIconsIgnoringImageLoadingPreference): Added getter
      * WebPreferences.h:
      * WebView.cpp:
      (WebView::notifyPreferencesChanged): Add to settings that get propagated upon changes.
      
      Source/WebKit2: 
      
      * Shared/WebPreferencesStore.h: Add macro for setting default value.
      * UIProcess/API/C/WKPreferences.cpp:
      (WKPreferencesSetLoadsSiteIconsIgnoringImageLoadingPreference): Added setter.
      (WKPreferencesGetLoadsSiteIconsIgnoringImageLoadingPreference): Added getter.
      * UIProcess/API/C/WKPreferences.h:
      * WebProcess/WebPage/WebPage.cpp:
      (WebKit::WebPage::updatePreferences): Add to list of WebCore settings that get propagated to WebKit preferences.
      
      Tools: 
      
      * DumpRenderTree/mac/DumpRenderTree.mm:
      (resetDefaultsToConsistentValues): Setting should be off for most tests. Reset to false.
      
      LayoutTests: 
      
      * http/tests/misc/favicon-loads-with-icon-loading-override-expected.txt: Added.
      * http/tests/misc/favicon-loads-with-icon-loading-override.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83628 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dc9ed39b
    • jberlin@webkit.org's avatar
      WebKit2: Spelling and Grammar Checking: Make sure to remove the markings from the document · fdffcfbf
      jberlin@webkit.org authored
      when spelling and/or grammar checking is disabled.
      https://bugs.webkit.org/show_bug.cgi?id=58350
      
      Reviewed by Anders Carlsson.
      
      * UIProcess/API/mac/WKView.mm:
      (-[WKView toggleContinuousSpellChecking:]):
      Move the call to unmark the errors to the WebProcess.
      (-[WKView setGrammarCheckingEnabled:]):
      Ditto.
      (-[WKView toggleGrammarChecking:]):
      Ditto.
      
      * UIProcess/WebPageProxy.cpp:
      Remove unused functions.
      * UIProcess/WebPageProxy.h:
      Ditto.
      * WebProcess/WebPage/WebPage.messages.in:
      Ditto.
      * WebProcess/WebPage/WebPage.h:
      
      * WebProcess/WebProcess.cpp:
      (WebKit::WebProcess::setTextCheckerState):
      If grammar or spelling checking is disabled, unmark all the pages.
      Doing it here allows makes it possible to unmark all pages in a cross-platform way that is
      triggered both by selecting the the context menu items and by any other methods of updating
      the enabled / disabled state.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83627 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fdffcfbf
    • commit-queue@webkit.org's avatar
      2011-04-12 Thouraya ANDOLSI <thouraya.andolsi@st.com> · 7654a8d7
      commit-queue@webkit.org authored
              Reviewed by Eric Seidel.
      
              [QT] Enable JIT build for SH4 platforms.
              https://bugs.webkit.org/show_bug.cgi?id=58317
              add disable_uitools for SH4 platforms.
      
              * Source/WebKit.pri:
      2011-04-12  Thouraya ANDOLSI  <thouraya.andolsi@st.com>
      
              Reviewed by Eric Seidel.
      
              [Qt] Enable JIT build for SH4 platforms.
              https://bugs.webkit.org/show_bug.cgi?id=58317
              enable JIT build for QT backend  for SH4 platforms.
      
              * JavaScriptCore.pro:
              * wtf/Platform.h:
      2011-04-12  Thouraya ANDOLSI  <thouraya.andolsi@st.com>
      
              Reviewed by Eric Seidel.
      
              [Qt] Enable JIT build for SH4 platforms.
              https://bugs.webkit.org/show_bug.cgi?id=58317
      
              * DumpRenderTree/qt/DumpRenderTree.pro:
              * QtTestBrowser/QtTestBrowser.pro:
              * Scripts/webkitdirs.pm:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83626 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7654a8d7
    • andersca@apple.com's avatar
      2011-04-12 Anders Carlsson <andersca@apple.com> · 41b6ccb4
      andersca@apple.com authored
              Reviewed by Sam Weinig.
      
              Cisco Meeting Center will not download or launch from Safari
              https://bugs.webkit.org/show_bug.cgi?id=58366
              <rdar://problem/8987139>
      
              It's OK if a plug-in has less (or more) MIME type descriptions than actual MIME types.
              
              * Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm:
              (WebKit::getPluginInfoFromCarbonResources):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83625 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      41b6ccb4
    • andersca@apple.com's avatar
      2011-04-12 Anders Carlsson <andersca@apple.com> · 2f9605da
      andersca@apple.com authored
              Reviewed by Sam Weinig.
      
              Call PluginControllerProxy::platformGeometryDidChange before Plugin::geometryDidChange
              https://bugs.webkit.org/show_bug.cgi?id=58361
      
              Since Plugin::geometryDidChange ends up calling plug-in code it can resize the plug-in which causes
              platformGeometryDidChange to be called with the wrong rect.
      
              * PluginProcess/PluginControllerProxy.cpp:
              (WebKit::PluginControllerProxy::geometryDidChange):
              Call platformGeometryDidChange.
      
              * PluginProcess/PluginControllerProxy.h:
              * PluginProcess/mac/PluginControllerProxyMac.mm:
              (WebKit::PluginControllerProxy::platformGeometryDidChange):
              Remove the parameters to platformGeometryDidChange and just use m_frameRect instead.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83624 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2f9605da
    • andersca@apple.com's avatar
      Move three Mac specific functions to PluginControllerProxyMac.mm. · 966d7a7f
      andersca@apple.com authored
      Reviewed by Sam Weinig.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83623 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      966d7a7f
    • andersca@apple.com's avatar
      2011-04-12 Anders Carlsson <andersca@apple.com> · c790d70b
      andersca@apple.com authored
              Reviewed by Sam Weinig.
      
              Cache the window and plug-in element NPObjects
              https://bugs.webkit.org/show_bug.cgi?id=58355
      
              * PluginProcess/PluginControllerProxy.cpp:
              (WebKit::PluginControllerProxy::PluginControllerProxy):
              (WebKit::PluginControllerProxy::~PluginControllerProxy):
              (WebKit::PluginControllerProxy::windowScriptNPObject):
              (WebKit::PluginControllerProxy::pluginElementNPObject):
              * PluginProcess/PluginControllerProxy.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83622 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c790d70b
    • commit-queue@webkit.org's avatar
      2011-04-12 Thouraya ANDOLSI <thouraya.andolsi@st.com> · d7deb241
      commit-queue@webkit.org authored
              Reviewed by Eric Seidel.
      
              [GTK] arguments passed to build-jsc and build-webkit scripts are not taken into account
              https://bugs.webkit.org/show_bug.cgi?id=58333
      
              * Scripts/build-jsc:
              * Scripts/build-webkit:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83621 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d7deb241
    • commit-queue@webkit.org's avatar
      2011-04-12 George Guo <George.Guo@nokia.com> · 5998fd4e
      commit-queue@webkit.org authored
              Reviewed by Laszlo Gombos.
      
              [Qt] On Symbian got "Update Error" when installing QtWebkit.sis
              http://bugs.webkit.org/show_bug.cgi?id=58141
      
              If QtWebKit is already in Symbian ROM, we need package to be
              both SA and RU type
      
              * QtWebKit.pro:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83620 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5998fd4e
    • tony@chromium.org's avatar
      2011-04-12 Tony Chang <tony@chromium.org> · d849e01d
      tony@chromium.org authored
              Reviewed by Andreas Kling.
      
              [Qt] embed checksums in PNGs written by Qt-DRT
              https://bugs.webkit.org/show_bug.cgi?id=58173
      
              * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
              (WebCore::DumpRenderTree::dump):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83619 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d849e01d
    • rniwa@webkit.org's avatar
      2011-04-12 Ryosuke Niwa <rniwa@webkit.org> · a4499a52
      rniwa@webkit.org authored
              Reviewed by Eric Seidel.
      
              Move StyleChange and other global functions from ApplyStyleCommand to EditingStyle
              https://bugs.webkit.org/show_bug.cgi?id=55974
      
              Moved StyleChange, getIdentifierValue, and legacyFontSizeFromCSSValue from ApplyStyleCommand
              to EditingStyle. Also moved reconcileTextDecorationProperties, getIdentifierValue,
              setTextDecorationProperty, isCSSValueLength, legacyFontSizeFromCSSValue, extractTextStyles,
              diffTextDecorations, fontWeightIsBold, getTextAlignment, and getPropertiesNotIn.
      
              Because of this move, getPropertiesNotIn is no longer visible outside of EditingStyle.cpp
      
              * editing/ApplyStyleCommand.cpp:
              * editing/ApplyStyleCommand.h:
              * editing/EditingStyle.cpp:
              (WebCore::reconcileTextDecorationProperties):
              (WebCore::StyleChange::StyleChange):
              (WebCore::setTextDecorationProperty):
              (WebCore::getRGBAFontColor):
              (WebCore::StyleChange::extractTextStyles):
              (WebCore::diffTextDecorations):
              (WebCore::fontWeightIsBold):
              (WebCore::getTextAlignment):
              (WebCore::getPropertiesNotIn):
              (WebCore::getIdentifierValue):
              (WebCore::isCSSValueLength):
              (WebCore::legacyFontSizeFromCSSValue):
              * editing/EditingStyle.h:
              (WebCore::StyleChange::cssStyle):
              (WebCore::StyleChange::applyBold):
              (WebCore::StyleChange::applyItalic):
              (WebCore::StyleChange::applyUnderline):
              (WebCore::StyleChange::applyLineThrough):
              (WebCore::StyleChange::applySubscript):
              (WebCore::StyleChange::applySuperscript):
              (WebCore::StyleChange::applyFontColor):
              (WebCore::StyleChange::applyFontFace):
              (WebCore::StyleChange::applyFontSize):
              (WebCore::StyleChange::fontColor):
              (WebCore::StyleChange::fontFace):
              (WebCore::StyleChange::fontSize):
              (WebCore::StyleChange::operator==):
              (WebCore::StyleChange::operator!=):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83618 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a4499a52
    • jam@chromium.org's avatar
      2011-04-11 John Abd-El-Malek <jam@chromium.org> · 378bb137
      jam@chromium.org authored
              Reviewed by Darin Fisher.
      
              [chromium]: Get the list of misspelled words in the WebKit code insetad of in chromium's RenderView
              https://bugs.webkit.org/show_bug.cgi?id=58260
      
              * public/WebContextMenuData.h:
              * public/WebSpellCheckClient.h:
              (WebKit::WebSpellCheckClient::spellCheck):
              * src/ContextMenuClientImpl.cpp:
              (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
              * src/EditorClientImpl.cpp:
              (WebKit::EditorClientImpl::checkSpellingOfString):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83617 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      378bb137
    • abarth@webkit.org's avatar
      2011-04-12 Adam Barth <abarth@webkit.org> · a047249f
      abarth@webkit.org authored
              Reviewed by Eric Seidel.
      
              Review tool should work well on iPad
              https://bugs.webkit.org/show_bug.cgi?id=58351
      
              On the iPad, the toolbar ends up at some random position in the middle
              of the page because of how position:fixed interacts with scrolling on
              the iPad.  I feel a bit dirty using a user agent detect, but I'm not
              sure if there's a better way to detect whether the user agent has this
              behavior.
      
              * code-review.js:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83616 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a047249f
    • diegohcg@webkit.org's avatar
      2011-04-12 Diego Gonzalez <diegohcg@webkit.org> · ed3c224a
      diegohcg@webkit.org authored
          [Qt] Better padding for inputs and comboxes in mobile theme
          https://bugs.webkit.org/show_bug.cgi?id=58248
      
          Reviewed by Kenneth Rohde Christiansen.
      
          * platform/qt/RenderThemeQt.cpp:
          (WebCore::RenderThemeQt::setButtonPadding):
          (WebCore::RenderThemeQt::adjustTextFieldStyle):
          (WebCore::RenderThemeQt::paintTextField):
          (WebCore::RenderThemeQt::adjustMenuListStyle):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83615 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ed3c224a
    • eric@webkit.org's avatar
      2011-04-12 Eric Seidel <eric@webkit.org> · eb111cac
      eric@webkit.org authored
              Reviewed by Adam Barth.
      
              commit-queue should upload failure diffs when tests fail
              https://bugs.webkit.org/show_bug.cgi?id=58348
      
              This change was mostly just plumbing.  We were already saving
              this information for flaky test reporting.  I just made it possible
              for normal failures to report archives as well.
      
              I did a little abstraction work to try and share some code between
              flakytestreporter.py and this new code.  There is still more we could do.
      
              In making this change I also went through and updated the various
              places we have urls hard-coded in our python and pointed them at
              common.config.urls.
      
              * Scripts/webkitpy/common/checkout/scm.py:
              * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
              * Scripts/webkitpy/common/net/buildbot/buildbot.py:
              * Scripts/webkitpy/common/net/statusserver.py:
              * Scripts/webkitpy/layout_tests/port/base.py:
              * Scripts/webkitpy/tool/bot/botinfo.py: Added.
              * Scripts/webkitpy/tool/bot/botinfo_unittest.py: Added.
              * Scripts/webkitpy/tool/bot/commitqueuetask.py:
              * Scripts/webkitpy/tool/bot/flakytestreporter.py:
              * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
              * Scripts/webkitpy/tool/commands/queues.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83614 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      eb111cac
    • commit-queue@webkit.org's avatar
      2011-04-12 Bill Budge <bbudge@chromium.org> · 4b847a12
      commit-queue@webkit.org authored
              Reviewed by Darin Fisher.
      
              Move the WebURLLoaderOptions struct into its own file and rename the CrossOriginRequestPolicy enum to conform to the WebKit coding standard.
              https://bugs.webkit.org/show_bug.cgi?id=58287
      
              No new tests. No new functionality exposed.
      
              * WebKit.gyp:
              * public/WebURLLoader.h:
              * public/WebURLLoaderOptions.h: Added.
              (WebKit::WebURLLoaderOptions::WebURLLoaderOptions):
              * src/AssociatedURLLoader.cpp:
              (WebKit::AssociatedURLLoader::AssociatedURLLoader):
              * src/AssociatedURLLoader.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83613 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4b847a12
    • hyatt@apple.com's avatar
    • inferno@chromium.org's avatar
      2011-04-11 Abhishek Arya <inferno@chromium.org> · 807d9f9c
      inferno@chromium.org authored
              Reviewed by Dave Hyatt.
      
              Tests that we do not crash when reparenting a runin to a details block.
              https://bugs.webkit.org/show_bug.cgi?id=58228
      
              * fast/runin/runin-reparent-crash-expected.txt: Added.
              * fast/runin/runin-reparent-crash.html: Added.
      2011-04-11  Abhishek Arya  <inferno@chromium.org>
      
              Reviewed by Dave Hyatt.
      
              Replace insertChildNode with addChild in handleRunIn's reparenting
              of inlineRunIn to currBlock.
              https://bugs.webkit.org/show_bug.cgi?id=58228
      
              Use addChild instead of insertChildNode since it handles 
              correct placement of the children, esp where we cannot insert
              anything before the first child. e.g. details tag requires that its
              first child be a summary child and won't be able to remove child if
              that is not the case.
      
              Test: fast/runin/runin-reparent-crash.html
      
              * rendering/RenderBlock.cpp:
              (WebCore::RenderBlock::handleRunInChild):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83611 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      807d9f9c
    • senorblanco@chromium.org's avatar
      2011-04-12 Stephen White <senorblanco@chromium.org> · acb7620b
      senorblanco@chromium.org authored
              Unreviewed; new chromium layout test baselines.
      
              New baselines after r83541.  Note that these look worse, but that's
              because we went from greyscale antialiasing to ClearType antialiasing,
              but the layout tests turn off ClearType, so they don't get any AA
              at all.  It looks fine in Chrome.
      
              * platform/chromium-win/fast/multicol/shadow-breaking-expected.checksum: Removed.
              * platform/chromium-win/fast/multicol/shadow-breaking-expected.png:
              * platform/chromium-win/fast/text/shadow-translucent-fill-expected.checksum: Removed.
              * platform/chromium-win/fast/text/shadow-translucent-fill-expected.png:
              * platform/chromium-win/fast/transforms/shadows-expected.png:
              * platform/chromium-win/svg/css/composite-shadow-text-expected.checksum: Removed.
              * platform/chromium-win/svg/css/composite-shadow-text-expected.png:
              * platform/chromium-win/svg/css/shadow-changes-expected.checksum: Removed.
              * platform/chromium-win/svg/css/shadow-changes-expected.png:
              * platform/chromium-win/svg/css/text-shadow-multiple-expected.checksum: Removed.
              * platform/chromium-win/svg/css/text-shadow-multiple-expected.png:
              * platform/chromium-win/transitions/svg-text-shadow-transition-expected.checksum: Removed.
              * platform/chromium-win/transitions/svg-text-shadow-transition-expected.png:
              * platform/chromium/test_expectations.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83610 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      acb7620b
    • cfleizach@apple.com's avatar
      Unreviewed. Fixing Leopard build. · 346234dc
      cfleizach@apple.com authored
      REGRESSION: WK2: misspelled AX attributes no longer returned from text fields
      https://bugs.webkit.org/show_bug.cgi?id=58304
      
      checkTextOfParagraph is not available on Leopard. That code needs to be conditionalized with USE(UNIFIED_TEXT_CHECKING).
      
      * accessibility/mac/AccessibilityObjectWrapper.mm:
      (AXAttributeStringSetSpelling):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83609 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      346234dc
    • mario@webkit.org's avatar
      2011-04-12 Mario Sanchez Prada <msanchez@igalia.com> · f7f26f44
      mario@webkit.org authored
              Unreviewed. Added missing files to GNUmakefile.list.am.
      
              * GNUmakefile.list.am: Added IDBLevelDBBackingStore.[h|cpp].
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83608 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f7f26f44
    • cdn@chromium.org's avatar
      2011-04-12 Cris Neckar <cdn@chromium.org> · def07176
      cdn@chromium.org authored
              Reviewed by Nikolas Zimmermann.
      
              Tests for crash when non-svg inline text boxes exist in the list of text boxes.
              https://bugs.webkit.org/show_bug.cgi?id=57933
      
              * svg/text/svg-rtl-text-crash-expected.txt: Added.
              * svg/text/svg-rtl-text-crash.html: Added.
      2011-04-12  Cris Neckar  <cdn@chromium.org>
      
              Reviewed by Nikolas Zimmermann.
      
              Add handling for non-svg inline text boxes in text box lists.
              https://bugs.webkit.org/show_bug.cgi?id=57933
      
              Test: svg/text/svg-rtl-text-crash.html
      
              * rendering/svg/RenderSVGInlineText.cpp:
              (WebCore::RenderSVGInlineText::positionForPoint):
              * rendering/svg/SVGInlineFlowBox.cpp:
              (WebCore::SVGInlineFlowBox::computeTextMatchMarkerRectForRenderer):
              * rendering/svg/SVGRenderTreeAsText.cpp:
              (WebCore::writeSVGInlineTextBoxes):
              * rendering/svg/SVGRootInlineBox.cpp:
              (WebCore::SVGRootInlineBox::closestLeafChildForPosition):
              (WebCore::reverseInlineBoxRangeAndValueListsIfNeeded):
              * rendering/svg/SVGTextQuery.cpp:
              (WebCore::SVGTextQuery::collectTextBoxesInFlowBox):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83607 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      def07176
    • mario@webkit.org's avatar
      2011-04-12 Mario Sanchez Prada <msanchez@igalia.com> · 5f48d9ac
      mario@webkit.org authored
              Reviewed by Chris Fleizach.
      
              [GTK] Expose menu items and menus as children of a menu bar
              https://bugs.webkit.org/show_bug.cgi?id=56659
      
              New cross-platform test. Skipped in platforms with no results yet.
      
              * accessibility/aria-menubar-menuitems.html: Added.
              * platform/gtk/accessibility/aria-menubar-menuitems-expected.txt: Added.
              * platform/mac/Skipped: Skipped the new test.
              * platform/win/Skipped: Ditto.
      2011-04-12  Mario Sanchez Prada  <msanchez@igalia.com>
      
              Reviewed by Chris Fleizach.
      
              [GTK] Expose menu items and menus as children of a menu bar
              https://bugs.webkit.org/show_bug.cgi?id=56659
      
              Ensure menu items get exposed when they're children of menu bars.
      
              * accessibility/AccessibilityRenderObject.cpp:
              (WebCore::AccessibilityRenderObject::determineAriaRoleAttribute):
              Consider menu bars as potential parent objects for menu items.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83606 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5f48d9ac
    • jberlin@webkit.org's avatar
      [WebKit2 Release Tests] fast/dom/StyleSheet/detached-stylesheet-without-wrapper.html flakey · b8ea47ab
      jberlin@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=58337
      
      Skip the test to get the bots green.
      
      * platform/mac-wk2/Skipped:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83605 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b8ea47ab
    • jianli@chromium.org's avatar
      Unreviewed, update chromium test expectations. · dc617cff
      jianli@chromium.org authored
      Mark access-zero-sized-canvas as crash on chromium.
      
      * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83604 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dc617cff
    • dbates@webkit.org's avatar
      2011-04-12 Daniel Bates <dbates@rim.com> · 6e631dae
      dbates@webkit.org authored
              Rubber-stamped by Eric Seidel.
      
              svn-apply and/or patch(1) has trouble applying patches that makes changes to files
              with Windows line endings
              https://bugs.webkit.org/show_bug.cgi?id=53625
      
              Fixes an issue where a patch made on a SCM checkout on a Unix file system cannot be
              applied to an SCM checkout on a Windows file system and vice-versa.
      
              This issue manifests itself due to custom SCM settings as well as differences in
              gitattributes support in older versions of Git (e.g. 1.7.0.3). We implement support
              into svn-apply/unapply to compensate for differences in line endings by converting
              the line endings in a patch to match the line endings in the target file (if it exists).
      
              * Scripts/VCSUtils.pm:
                - Added parseFirstEOL(), which returns the first end-of-line character(s) that appear in the
                  content read from the specified file handle. Obviously, this heuristic will not work
                  for files with mixed line endings, but I don't envision such files to be the norm. If
                  this turns out to be an issue then we can improve the heuristic.
                - Added firstEOLInFile().
                - Modified parsePatch() and parseDiff() to take an optional hash reference to an options hash.
                  In particular, added the hash key shouldNotUseIndexPathEOL to control whether to use the line
                  endings in the diff instead of the line endings in the target file.
                - Extracted local variable $chunkRangeRegEx from fixChangeLogPatch() so that it can be
                  re-used in parseDiff().
              * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl: Modified to pass {shouldNotUseIndexPathEOL => 1}
                to parsePatch() since these unit tests don't create mock files. Instead, created unit tests that use
                mock files in file VCSUtils_unittest/parseDiffWithMockFiles.pl.
              * Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl: Added.
              * Scripts/webkitperl/VCSUtils_unittest/parseFirstEOL.pl: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83603 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6e631dae
    • weinig@apple.com's avatar
      REGRESSION (r83550): Multiple http tests crashing in the web process in SQLite... · 922560d3
      weinig@apple.com authored
      REGRESSION (r83550): Multiple http tests crashing in the web process in SQLite beneath CFNetwork on Windows 7 Release (WebKit2 Tests)
      https://bugs.webkit.org/show_bug.cgi?id=58336
      
      Reviewed by Adam Roben.
      
      * WebKitTestRunner/TestController.cpp:
      (WTR::TestController::resetStateToConsistentValues):
      Remove cache clearing as that is causing tests to crash on Windows 7.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83602 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      922560d3