1. 03 Jan, 2013 25 commits
  2. 02 Jan, 2013 15 commits
    • zhajiang@rim.com's avatar
      [BlackBerry] file:/// pages don't get correct scales after several rotations... · 041a8ae7
      zhajiang@rim.com authored
      [BlackBerry] file:/// pages don't get correct scales after several rotations and history navigations
      https://bugs.webkit.org/show_bug.cgi?id=105996
      
      Patch by Jacky Jiang <zhajiang@rim.com>.
      Reviewed by George Staikos.
      
      PR: 273541
      When navigating back to the previous page on portrait mode, we were
      trying to set virtual viewport after recalculation. However, we didn't
      change the fixed layout size so that we still layouted the contents at
      the old virtual viewport size. In this case, the old virtual viewport
      was 570 * 293 which was set in landscape mode unfortunately. There
      would be no chance for such kind of contents size to fit the portrait
      mode screen size nicely.
      This was a regression of webkit/cc31d9bad where setViewMode() was
      removed as a noop. So just get setViewMode() back to apply the fixed
      layout size with a little bit change as SVG document path was proved
      invalid in that patch. Thanks to George for the float comparison change.
      Put a FIXME as we don't have a way to save the scale precisely before
      the rotation and history navigation currently.
      
      * Api/WebPage.cpp:
      (BlackBerry::WebKit::WebPagePrivate::setLoadState):
      * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
      (WebCore::FrameLoaderClientBlackBerry::saveViewStateToItem):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@138699 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      041a8ae7
    • rniwa@webkit.org's avatar
      More Mac test expectation updates per bugs 105988 and 105987. · 515db6e2
      rniwa@webkit.org authored
      * platform/mac-wk2/TestExpectations:
      * platform/mac/TestExpectations:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@138698 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      515db6e2
    • commit-queue@webkit.org's avatar
      [EFL][WK2] Fix tooltip bugs in MiniBrowser. · aa49d1cf
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=102209
      
      Patch by Byungwoo Lee <bw80.lee@samsung.com> on 2013-01-02
      Reviewed by Gyuyoung Kim.
      
      Set tooltip on the elm_window instead of ewk_view, and add delay to
      show the tooltip window.
      
      Setting tooltip on the ewk_view makes elementary error message because
      ewk_view is not an elementary widget. To remove the error message,
      tooltip should be set on the elm_window.
      
      Most browsers show the tooltip after a mouse pointer stays on an
      element object that has tooltip text.
      But elm_tooltip widget itself doesn't have delay or handle mouse
      events to show/hide.
      
      So additional codes are added to show/hide tooltip widget along with
      mouse events.
        1) When a mouse pointer stays for a second on an element which has
           tooltip text, then tooltip widget is displayed.
        2) When a mouse pointer is moved or out of ewk_view, hide the tooltip
           widget.
      
      * MiniBrowser/efl/main.c:
      (_Tooltip_Information):
      (_Browser_Window):
      (on_tooltip_show):
      (window_tooltip_hide):
      (window_tooltip_update):
      (on_mouse_in):
      (on_mouse_move):
      (on_mouse_out):
      (window_free):
      (on_tooltip_text_set):
      (on_tooltip_text_unset):
      (window_create):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@138697 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      aa49d1cf
    • commit-queue@webkit.org's avatar
      [BlackBerry] Do not determine db quota limit using db file size · b00fe933
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=105991
      
      PR 267191
      
      Patch by Otto Derek Cheung <otcheung@rim.com> on 2013-01-02
      Reviewed by George Staikos.
      
      Passing the current quota to WebPageClientImpl::databaseQuota so we can determine a better
      quota limit without using the db file size.
      
      * Api/WebPageClient.h:
      * WebCoreSupport/ChromeClientBlackBerry.cpp:
      (WebCore::ChromeClientBlackBerry::exceededDatabaseQuota):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@138696 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b00fe933
    • commit-queue@webkit.org's avatar
      [TexMap] Remove m_size in TextureMapperLayer. · 0853fdd5
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=105781
      
      Patch by Huang Dongsung <luxtella@company100.net> on 2013-01-02
      Reviewed by Noam Rosenthal.
      
      m_size is duplicated by State::size, so this patch removes it.
      
      No new tests. Refactoring only.
      
      * platform/graphics/texmap/TextureMapperLayer.cpp:
      (WebCore::TextureMapperLayer::computeTransformsRecursive):
      (WebCore::TextureMapperLayer::paintSelf):
      (WebCore::TextureMapperLayer::isVisible):
      (WebCore::TextureMapperLayer::flushCompositingStateForThisLayerOnly):
      * platform/graphics/texmap/TextureMapperLayer.h:
      (WebCore::TextureMapperLayer::layerRect):
      (TextureMapperLayer):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@138695 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0853fdd5
    • rniwa@webkit.org's avatar
      Add flaky crash expectations for multiple tests on Mac WebKit2. · 5718f943
      rniwa@webkit.org authored
      * platform/mac-wk2/TestExpectations:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@138694 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5718f943
    • kbr@google.com's avatar
      [chromium] Creation of dedicated workers (isolates) leaks reference to HTMLDocument · 0bb6a17c
      kbr@google.com authored
      https://bugs.webkit.org/show_bug.cgi?id=105367
      
      Reviewed by Dmitry Titov.
      
      Source/WebCore:
      
      Eliminated a Chromium-specific object wrapping WorkerMessagingProxy in order to fix a
      lifetime management bug, which leaked every Document which started a dedicated worker.
      
      Test: fast/workers/worker-document-leak.html
      
      * workers/WorkerLoaderProxy.h:
      (WorkerLoaderProxy):
          Added Chromium-specific casting method to bridge two now-distinct class hierarchies.
      * workers/WorkerMessagingProxy.h:
      (WorkerMessagingProxy):
          Made destructor protected instead of private to allow subclassing.
      
      Source/WebKit/chromium:
      
      Made WebWorkerClientImpl a subclass of WorkerMessagingProxy rather than an object wrapping
      WorkerMessagingProxy. WorkerMessagingProxy manages its own lifetime and it is impossible to
      properly synchronize the lifetime of WebWorkerClientImpl separately.
      
      This allowed most of WebWorkerClientImpl to be deleted, but forced a divergence in the class
      hierarchies of WebWorkerClientImpl and WebSharedWorkerImpl. Conversion methods were added to
      WorkerLoaderProxy and WebWorkerBase to bridge the hierarchies of in-process and
      out-of-process workers.
      
      * src/DatabaseObserver.cpp:
      (WebCore::DatabaseObserver::canEstablishDatabase):
          Adjusted how WebWorkerBase is obtained from WorkerLoaderProxy.
      * src/IDBFactoryBackendProxy.cpp:
      (WebKit::AllowIndexedDBMainThreadBridge::signalCompleted):
          Adjusted how WorkerLoaderProxy's methods are called.
      (WebKit::IDBFactoryBackendProxy::allowIndexedDB):
          Adjusted how WebWorkerBase is obtained from WorkerLoaderProxy.
      * src/LocalFileSystemChromium.cpp:
      (WebCore::openFileSystemHelper):
          Adjusted how WebWorkerBase is obtained from WorkerLoaderProxy.
      * src/WebSharedWorkerImpl.cpp:
      (WebKit::WebSharedWorkerImpl::toWebWorkerBase):
          Implemented new conversion method.
      * src/WebSharedWorkerImpl.h:
      (WebSharedWorkerImpl):
          Explicitly derive from WorkerLoaderProxy now that WebWorkerBase no longer does.
      (WebKit::WebSharedWorkerImpl::workerLoaderProxy):
          Added new conversion method.
      * src/WebWorkerBase.h:
      (WebWorkerBase):
          Removed derivation from WorkerLoaderProxy. Added method to convert to WorkerLoaderProxy.
      * src/WebWorkerClientImpl.cpp:
      (WebKit):
          Adjusted comment.
      (WebKit::WebWorkerClientImpl::createWorkerContextProxy):
          Adjusted whitespace.
      (WebKit::WebWorkerClientImpl::terminateWorkerContext):
          Eliminated delegation to separate object.
      (WebKit::WebWorkerClientImpl::toWebWorkerBase):
          Implemented new conversion method.
      (WebKit::WebWorkerClientImpl::view):
      (WebKit::WebWorkerClientImpl::allowDatabase):
      (WebKit::WebWorkerClientImpl::allowFileSystem):
      (WebKit::WebWorkerClientImpl::openFileSystem):
      (WebKit::WebWorkerClientImpl::allowIndexedDB):
          Eliminated delegation to separate object.
      (WebKit::WebWorkerClientImpl::WebWorkerClientImpl):
      * src/WebWorkerClientImpl.h:
      (WebKit):
          Changed to inherit from WorkerMessagingProxy directly.
      (WebWorkerClientImpl):
          Deleted most methods previously overridden from WorkerContextProxy, etc.
      * src/WorkerAsyncFileSystemChromium.cpp:
      (WebCore::WorkerAsyncFileSystemChromium::WorkerAsyncFileSystemChromium):
      (WebCore::WorkerAsyncFileSystemChromium::createWorkerFileSystemCallbacksBridge):
          Hold on to, and use, WorkerLoaderProxy rather than WebWorkerBase.
      * src/WorkerAsyncFileSystemChromium.h:
      (WebKit):
      (WebCore):
      (WorkerAsyncFileSystemChromium):
          Hold on to WorkerLoaderProxy rather than WebWorkerBase.
      
      LayoutTests:
      
      * fast/workers/resources/empty-worker.js: Added.
      * fast/workers/resources/worker-document-leak-iframe.html: Added.
      * fast/workers/worker-document-leak-expected.txt: Added.
      * fast/workers/worker-document-leak.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@138693 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0bb6a17c
    • rniwa@webkit.org's avatar
      One more Mac rebaseline attempt for r138654. Also remove an entry for the bug 105514 · fc46198f
      rniwa@webkit.org authored
      which has been dup'ed with the bug 103663 for which we have more specific expectations.
      
      * platform/mac-lion/editing/deleting: Removed.
      * platform/mac-lion/editing/deleting/delete-to-select-table-expected.txt: Removed.
      * platform/mac-wk2/editing/deleting: Removed.
      * platform/mac-wk2/editing/deleting/delete-to-select-table-expected.txt: Removed.
      * platform/mac/TestExpectations:
      * platform/mac/editing/deleting/delete-to-select-table-expected.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@138692 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fc46198f
    • esprehn@chromium.org's avatar
      Make ClassList::reset's purpose obvious and don't keep quirks string when not needed · fbc22e53
      esprehn@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=105963
      
      Reviewed by Ojan Vafai.
      
      ClassList::reset only exists to handle updating the special SpaceSplitString
      for quirks mode documents. This adds a new method that makes this obvious and
      instead of updating the string immediately clear the value and lazily
      update it. We also clear the value whenever we're inserted into the
      document so that when moving from a quirks mode document to a non-quirks
      mode document we don't keep the SpaceSplitString around if it's not needed.
      
      No new tests, I'm not sure how to write a test that we don't keep the
      SpaceSplitString when moving between quirks and non-quirks mode documents.
      
      * dom/Element.cpp:
      (WebCore::Element::classAttributeChanged):
      (WebCore::Element::insertedInto):
      * dom/Element.h:
      (Element):
      * dom/ElementRareData.h:
      (WebCore::ElementRareData::clearClassListValueForQuirksMode):
      * html/ClassList.cpp:
      * html/ClassList.h:
      (WebCore::ClassList::clearValueForQuirksMode):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@138691 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fbc22e53
    • commit-queue@webkit.org's avatar
      [chromium] Remove unused transitional #defines from WebKit Client API · 970d83e6
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=105974
      
      Patch by James Robinson <jamesr@chromium.org> on 2013-01-02
      Reviewed by Adam Barth.
      
      The transitions these #defines helped with have completed.
      
      * public/WebFileSystemCallbacks.h:
      (WebKit):
      * public/WebKit.h:
      * public/WebRuntimeFeatures.h:
      * public/WebSettings.h:
      * public/WebWidget.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@138690 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      970d83e6
    • barraclough@apple.com's avatar
      Objective-C API for JavaScriptCore · e2c0742f
      barraclough@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=105889
      
      Reviewed by Geoff Garen.
      
      Fixes for more issues raised by Darin.
      
      * API/JSBlockAdaptor.mm:
      (BlockArgument):
      (BlockArgumentStruct::BlockArgumentStruct):
      (BlockArgumentTypeDelegate::typeStruct):
      (BlockResult):
      (BlockResultStruct::BlockResultStruct):
      (buildBlockSignature):
      (-[JSBlockAdaptor initWithBlockSignatureFromProtocol:]):
      (-[JSBlockAdaptor blockFromValue:inContext:withException:]):
          - fix * position for Objective-C types
      * API/JSContext.h:
          - fix * position for Objective-C types
      * API/JSContext.mm:
      (-[JSContext initWithVirtualMachine:]):
      (-[JSContext virtualMachine]):
      (contextInternalContext):
          - fix * position for Objective-C types
      (-[JSContext dealloc]):
      (-[JSContext protect:]):
      (-[JSContext unprotect:]):
          - HashMap<JSValueRef, size_t> -> HashCountedSet<JSValueRef>
      * API/JSContextInternal.h:
      (WeakContextRef):
          - fix * position for Objective-C types
      * API/JSValue.mm:
      (valueToString):
          - fix * position for Objective-C types
      (isNSBoolean):
          - Added helper to check for booleans.
      (objectToValueWithoutCopy):
          - Added contextRef
          - fix * position for Objective-C types
          - Remove @YES, @NO literal usage, use isNSBoolean instead
      (objectToValue):
          - Added contextRef
      (+[JSValue valueWithValue:inContext:]):
      (-[JSValue initWithValue:inContext:]):
          - fix * position for Objective-C types
      (createStructHandlerMap):
      (handerForStructTag):
          - getStructTagHandler -> handerForStructTag
          - Split out createStructHandlerMap
          - strncmp -> memcmp
          - String(type).impl() -> StringImpl::create(type)
      (+[JSValue selectorForStructToValue:]):
      (+[JSValue selectorForValueToStruct:]):
          - getStructTagHandler -> handerForStructTag
      (typeToValueInvocationFor):
      (valueToTypeInvocationFor):
          - fix * position for Objective-C types
      * API/JSValueInternal.h:
          - fix * position for Objective-C types
      * API/JSVirtualMachineInternal.h:
          - fix * position for Objective-C types
      * API/JSWrapperMap.h:
          - fix * position for Objective-C types
      * API/JSWrapperMap.mm:
      (selectorToPropertyName):
      (createObjectWithCustomBrand):
      (createRenameMap):
      (putNonEnumerable):
      (copyMethodsToObject):
      (copyPrototypeProperties):
      (-[JSObjCClassInfo initWithContext:forClass:superClassInfo:]):
      (-[JSWrapperMap initWithContext:]):
      (-[JSWrapperMap wrapperForObject:]):
      (getJSExportProtocol):
          - fix * position for Objective-C types
      * API/ObjCCallbackFunction.h:
          - fix * position for Objective-C types
      * API/ObjCCallbackFunction.mm:
      (CallbackArgument):
      (CallbackArgumentStruct::CallbackArgumentStruct):
          - fix * position for Objective-C types
      (CallbackArgumentBlockCallback::createAdoptingJSBlockAdaptor):
          - Added to make adopt explicit
      (CallbackArgumentBlockCallback):
      (CallbackArgumentBlockCallback::CallbackArgumentBlockCallback):
      (ArgumentTypeDelegate::typeBlock):
          - Call createAdoptingJSBlockAdaptor
      (ArgumentTypeDelegate::typeStruct):
      (CallbackResult):
      (CallbackResultStruct::CallbackResultStruct):
      (ResultTypeDelegate::typeStruct):
      (ObjCCallbackFunction::ObjCCallbackFunction):
      (ObjCCallbackFunction::context):
      (objCCallbackFunctionForInvocation):
      (objCCallbackFunctionForMethod):
      (objCCallbackFunctionForBlock):
          - fix * position for Objective-C types
      * API/ObjcRuntimeExtras.h:
      (protocolImplementsProtocol):
      (forEachProtocolImplementingProtocol):
      (forEachMethodInProtocol):
      (forEachPropertyInProtocol):
          - fix * position for Objective-C types
      * API/tests/testapi.m:
      (-[TestObject testArgumentTypesWithInt:double:boolean:string:number:array:dictionary:]):
      (testObjectiveCAPI):
          - fix * position for Objective-C types
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@138689 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e2c0742f
    • commit-queue@webkit.org's avatar
      [chromium] Remove unused transitional #defines from Platform API · c492380a
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=105971
      
      Patch by James Robinson <jamesr@chromium.org> on 2013-01-02
      Reviewed by Adrienne Walker.
      
      These are leftovers from multi-sided patches that landed months ago.
      
      * chromium/public/WebContentLayerClient.h:
      (WebContentLayerClient):
      * chromium/public/WebLayer.h:
      * chromium/public/WebLayerTreeView.h:
      * chromium/public/WebThread.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@138687 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c492380a
    • rniwa@webkit.org's avatar
      Mac and Chromium rebaselines after r138654. · bb2388b0
      rniwa@webkit.org authored
      * editing/deleting/delete-to-select-table-expected.txt: Added.
      * platform/chromium-mac/editing/deleting/delete-to-select-table-expected.txt: Added.
      * platform/chromium/editing/deleting/delete-to-select-table-expected.txt: Removed.
      * platform/efl/editing/deleting/delete-to-select-table-expected.txt: Removed.
      * platform/gtk/editing/deleting/delete-to-select-table-expected.txt: Removed.
      * platform/mac-lion/editing/deleting/delete-to-select-table-expected.txt: Added.
      * platform/mac-wk2/editing/deleting: Added.
      * platform/mac-wk2/editing/deleting/delete-to-select-table-expected.txt: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@138686 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bb2388b0
    • macpherson@chromium.org's avatar
      Unreviewed Chromium gardening. · 4fe87c9e
      macpherson@chromium.org authored
      Rebaseline win-xp image for svg/dynamic-updates/SVGFEComponentTransferElement-dom-tableValues-attr-expected.html.
      
      * platform/chromium-win-xp/svg/dynamic-updates/SVGFEComponentTransferElement-dom-tableValues-attr-expected.png: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@138685 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4fe87c9e
    • cdn@chromium.org's avatar
      Initialize WebInputEvent to prevent sending uninitialized bytes with IPC messages. · 189b2cf1
      cdn@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=105934
      
      Reviewed by James Robinson.
      
      * public/WebInputEvent.h:
      (WebKit::WebInputEvent::WebInputEvent):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@138684 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      189b2cf1