1. 27 Apr, 2010 40 commits
    • evan@chromium.org's avatar
      2010-04-27 Evan Martin <evan@chromium.org> · 854fd269
      evan@chromium.org authored
              Reviewed by David Levin.
      
              [chromium] update test expectations for ancient linux bug
              https://bugs.webkit.org/show_bug.cgi?id=38229
      
              According to
              http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=plugins%2Fembed-attributes-setting.html
              this hasn't crashed in a long time, so the CRASH annotation is superfluous.
      
              * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58361 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      854fd269
    • eric@webkit.org's avatar
      2010-04-27 Jochen Eisinger <jochen@chromium.org> · b32e37d0
      eric@webkit.org authored
              Reviewed by Shinichiro Hamaji.
      
              Fix gyp build on Mac OS X with enable_svg=0.
              https://bugs.webkit.org/show_bug.cgi?id=38192
      
              * WebCore.gyp/WebCore.gyp: Only generate SVG symbols if enable_svg!=0.
              * css/CSSComputedStyleDeclaration.cpp:
              (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Add missing unimplemented CSS properties to switch statement.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58360 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b32e37d0
    • eric@webkit.org's avatar
      2010-04-27 Darin Fisher <darin@chromium.org> · 30807a09
      eric@webkit.org authored
              Reviewed by Dimitri Glazkov.
      
              [Chromium] Remove deprecated form of didChangeLocationWithinPage
              https://bugs.webkit.org/show_bug.cgi?id=38178
      
              * public/WebFrameClient.h:
              * src/FrameLoaderClientImpl.cpp:
              (WebKit::FrameLoaderClientImpl::dispatchDidNavigateWithinPage):
      2010-04-27  Darin Fisher  <darin@chromium.org>
      
              Reviewed by Dimitri Glazkov.
      
              [Chromium] Remove deprecated form of didChangeLocationWithinPage
              https://bugs.webkit.org/show_bug.cgi?id=38178
      
              Switch over to implementing didNavigateWithinPage.
      
              * DumpRenderTree/chromium/WebViewHost.cpp:
              (TestWebViewDelegate::didNavigateWithinPage):
              (WebViewHost::didChangeLocationWithinPage):
              * DumpRenderTree/chromium/WebViewHost.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58358 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      30807a09
    • slewis@apple.com's avatar
      Fix Tiger build. · 03314650
      slewis@apple.com authored
      * wtf/FastMalloc.cpp:
      (WTF::TCMalloc_PageHeap::Carve):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58355 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      03314650
    • evan@chromium.org's avatar
      2010-04-27 Evan Martin <evan@chromium.org> · 8c3de606
      evan@chromium.org authored
              Unreviewed.
      
              Adding myself to commmitters list.
      
              * Scripts/webkitpy/common/config/committers.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58354 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8c3de606
    • slewis@apple.com's avatar
      Remove more files I didn't intend to commit · 40daca4a
      slewis@apple.com authored
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58353 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      40daca4a
    • kinuko@chromium.org's avatar
      2010-04-27 Kinuko Yasuda <kinuko@chromium.org> · 4855a45a
      kinuko@chromium.org authored
              Reviewed by Jian Li.
      
              [V8] Handle OR ('|') conditional in action_derivedsourcesallinone.py
              https://bugs.webkit.org/show_bug.cgi?id=38207
      
              No new tests.
      
              * WebCore.gyp/scripts/action_derivedsourcesallinone.py:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58352 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4855a45a
    • slewis@apple.com's avatar
      Revert Files I didn't intend to commit · 8792048e
      slewis@apple.com authored
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58350 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8792048e
    • eric@webkit.org's avatar
      2010-04-27 François Sausset <sausset@gmail.com> · 6dfa2fbc
      eric@webkit.org authored
              Reviewed by Kenneth Rohde Christiansen.
      
              Additional MathML mroot & msqrt tests.
              https://bugs.webkit.org/show_bug.cgi?id=37044
      
              * mathml/presentation/roots.xhtml: Added.
              * platform/mac/mathml/presentation/roots-expected.checksum: Added.
              * platform/mac/mathml/presentation/roots-expected.png: Added.
              * platform/mac/mathml/presentation/roots-expected.txt: Added.
      2010-04-27  François Sausset  <sausset@gmail.com>
      
              Reviewed by Kenneth Rohde Christiansen.
      
              Implementation of the MathML mroot & msqrt elements.
              https://bugs.webkit.org/show_bug.cgi?id=37044
      
              Test: mathml/presentation/roots.xhtml
      
              * WebCore.xcodeproj/project.pbxproj:
              * css/mathml.css:
              (mroot):
              (mroot > * + *):
              (mroot > * + mrow, mroot > * + mfenced):
              * mathml/MathMLInlineContainerElement.cpp:
              (WebCore::MathMLInlineContainerElement::createRenderer):
              * mathml/RenderMathMLRoot.cpp: Added.
              (WebCore::RenderMathMLRoot::RenderMathMLRoot):
              (WebCore::RenderMathMLRoot::addChild):
              (WebCore::RenderMathMLRoot::paint):
              (WebCore::RenderMathMLRoot::layout):
              * mathml/RenderMathMLRoot.h: Added.
              * mathml/RenderMathMLSquareRoot.cpp: Added.
              (WebCore::RenderMathMLSquareRoot::RenderMathMLSquareRoot):
              (WebCore::RenderMathMLSquareRoot::paint):
              (WebCore::RenderMathMLSquareRoot::layout):
              * mathml/RenderMathMLSquareRoot.h: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58349 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6dfa2fbc
    • eric@webkit.org's avatar
      2010-04-27 Jeremy Orlow <jorlow@chromium.org> · 14feb458
      eric@webkit.org authored
              Reviewed by Dimitri Glazkov.
      
              [Chromium] Create new baseline for caret-rtl-2
              https://bugs.webkit.org/show_bug.cgi?id=38126
      
              http://trac.webkit.org/changeset/58191/ caused the caret-rtl-2 layout
              test to start failing under Chromium.  Since we're the only ones who
              run pixel tests, it's possible that the actual baseline needs to be updated
              and not just the chromium baseline...but I'm not sure.
      
              I'm tracking the overall progress of figuring this out here:
              https://bugs.webkit.org/show_bug.cgi?id=38109
      
              * platform/chromium-mac/editing/selection/caret-rtl-2-actual.checksum: Added.
              * platform/chromium-mac/editing/selection/caret-rtl-2-actual.png: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58348 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      14feb458
    • darin@apple.com's avatar
      I noticed an unused forwarding header. · b0a502f2
      darin@apple.com authored
      Reviewed by Maciej Stachowiak.
      
      * ForwardingHeaders/runtime/PropertyMap.h: Removed.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58347 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b0a502f2
    • slewis@apple.com's avatar
      https://bugs.webkit.org/show_bug.cgi?id=38154 FastMalloc calls madvise too often. · b905986f
      slewis@apple.com authored
      <rdar://problem/7834433> REGRESSSION: 1.5% PLT regression due to 56028 (return memory quicker).  
      To save on madvise calls when recommitting memory recommit the entire span and then carve it
      instead of carving the span up and only committing the part that will be used immediately.
      
      Reviewed by Geoff Garen.
      
      * wtf/FastMalloc.cpp:
      (WTF::TCMalloc_PageHeap::New):
      (WTF::TCMalloc_PageHeap::AllocLarge):
      (WTF::TCMalloc_PageHeap::Carve):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58346 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b905986f
    • jamesr@google.com's avatar
      2010-04-27 James Robinson <jamesr@chromium.org> · 7cd53ed1
      jamesr@google.com authored
              Reviewed by Adam Barth.
      
              Fix gcc 4.4.1 warnings on Linux in the chromium V8 bindings code.
              https://bugs.webkit.org/show_bug.cgi?id=38153
      
              * bindings/scripts/CodeGeneratorV8.pm:
              * bindings/v8/V8Proxy.cpp:
              (WebCore::V8Proxy::callFunction):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58345 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7cd53ed1
    • evan@chromium.org's avatar
      2010-04-27 Evan Martin <evan@chromium.org> · b35692d3
      evan@chromium.org authored
              Unreviewed, making the bots happy.
      
              [chromium] bold bengali text not rendered properly on Linux
              https://bugs.webkit.org/show_bug.cgi?id=37904
      
              Check in a baseline for Mac pulled from the bots.
      
              * platform/mac/fast/text/international/bold-bengali-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58344 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b35692d3
    • eric@webkit.org's avatar
      2010-04-27 Eric Seidel <eric@webkit.org> · 240a9550
      eric@webkit.org authored
              Unreviewed, rolling out r58318.
              http://trac.webkit.org/changeset/58318
              https://bugs.webkit.org/show_bug.cgi?id=37215
      
              Broke test on Tiger.  Might just need updated results,
              unclear.
      
              * http/tests/inspector/console-resource-errors-expected.txt: Removed.
              * http/tests/inspector/console-resource-errors.html: Removed.
              * http/tests/inspector/console-tests.js: Removed.
              * inspector/console-clear.html:
              * inspector/console-dir.html:
              * inspector/console-dirxml.html:
              * inspector/console-format-collections-expected.txt:
              * inspector/console-format-collections.html:
              * inspector/console-format.html:
              * inspector/console-log-before-inspector-open.html:
              * inspector/console-tests.html:
              * inspector/console-tests.js: Added.
              (dumpConsoleMessages.callback):
              (dumpConsoleMessages):
              (dumpConsoleMessagesWithClasses.callback):
              (dumpConsoleMessagesWithClasses):
              (frontend_dumpConsoleMessages):
      2010-04-27  Eric Seidel  <eric@webkit.org>
      
              Unreviewed, rolling out r58318.
              http://trac.webkit.org/changeset/58318
              https://bugs.webkit.org/show_bug.cgi?id=37215
      
              Broke test on Tiger.  Might just need updated results,
              unclear.
      
              * inspector/InspectorController.cpp:
              (WebCore::InspectorController::didReceiveResponse):
              (WebCore::InspectorController::didFailLoading):
              * inspector/front-end/Resource.js:
              (WebInspector.Resource.prototype._mimeTypeIsConsistentWithType):
              * inspector/front-end/ResourcesPanel.js:
              (WebInspector.ResourcesPanel.prototype.recreateViewForResourceIfNeeded):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58342 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      240a9550
    • evan@chromium.org's avatar
      2010-04-27 Evan Martin <evan@chromium.org> · 37c59c7c
      evan@chromium.org authored
              Reviewed by David Levin.
      
              [chromium] bold bengali text not rendered properly on Linux
              https://bugs.webkit.org/show_bug.cgi?id=37904
      
              Add a layout test containing some bold Bengali text.
      
              * fast/text/international/bold-bengali.html: Added.
              * platform/chromium-linux/fast/text/international/bold-bengali-expected.checksum: Added.
              * platform/chromium-linux/fast/text/international/bold-bengali-expected.png: Added.
              * platform/chromium-linux/fast/text/international/bold-bengali-expected.txt: Added.
      2010-04-27  Evan Martin  <evan@chromium.org>
      
              Reviewed by David Levin.
      
              [chromium] bold bengali text not rendered properly on Linux
              https://bugs.webkit.org/show_bug.cgi?id=37904
      
              We must let Skia do font fallback, rather than picking a font name
              then handing that to Skia.  For example, if we have Bengali text and
              choose FreeSans + fake bold, and then later reuse the name, Skia will
              helpfully use FreeSansBold (which doesn't cover Bengali).
      
              Test: fast/text/international/bold-bengali.html
      
              * platform/graphics/chromium/FontCacheLinux.cpp:
              (WebCore::FontCache::getFontDataForCharacters):
      2010-04-27  Evan Martin  <evan@chromium.org>
      
              Reviewed by David Levin.
      
              [chromium] bold bengali text not rendered properly on Linux
              Roll forward Chrome DEPS so we get new Skia API.
      
              * DEPS: update Chrome to r45696.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58341 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      37c59c7c
    • jamesr@google.com's avatar
      2010-04-27 James Robinson <jamesr@chromium.org> · cac2e10a
      jamesr@google.com authored
              Reviewed by Darin Adler.
      
              Fix warnings emitted by gcc 4.4.1 on linux in chromium-specific platform graphics files.
              https://bugs.webkit.org/show_bug.cgi?id=38158
      
              Most of the issues are signed/unsigned mismatches, but there are a few unusued variables
              and functions mixed in.
      
              * platform/graphics/chromium/FontLinux.cpp:
              (WebCore::adjustTextRenderMode):
              (WebCore::TextRunWalker::getTextRun):
              (WebCore::TextRunWalker::getNormalizedTextRun):
              (WebCore::TextRunWalker::setGlyphXPositions):
              (WebCore::glyphIndexForXPositionInScriptRun):
              (WebCore::Font::offsetForPositionForComplexText):
              (WebCore::Font::selectionRectForComplexText):
              * platform/graphics/chromium/FontPlatformDataLinux.cpp:
              (WebCore::FontPlatformData::setupPaint):
              * platform/graphics/chromium/HarfbuzzSkia.cpp:
              (WebCore::getOutlinePoint):
              * platform/graphics/skia/GraphicsContext3DSkia.cpp:
              (WebCore::GraphicsContext3D::getImageData):
              * platform/graphics/skia/GraphicsContextSkia.cpp:
              (WebCore::isCoordinateSkiaSafe):
              (WebCore::GraphicsContext::fillRect):
              (WebCore::GraphicsContext::strokePath):
              (WebCore::GraphicsContext::strokeRect):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58340 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cac2e10a
    • abarth@webkit.org's avatar
      2010-04-27 Adam Barth <abarth@webkit.org> · b916286e
      abarth@webkit.org authored
              Reviewed by Darin Adler.
      
              Add test for NodeIterator prototype change behavior
              https://bugs.webkit.org/show_bug.cgi?id=38219
      
              In the process of remove the custom code from NodeIterator, we thought
              we fixed a subtle bug where iterating over nodes from another frame
              would get the wrong prototype chain.  This test documents that we
              didn't actually change the behavior and we still have the bug.
      
              * traversal/node-iterator-prototype-expected.txt: Added.
              * traversal/node-iterator-prototype.html: Added.
              * traversal/resources/node-iterator-prototype-frame.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58339 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b916286e
    • jhoneycutt@apple.com's avatar
      <rdar://problem/7911140> Hitting the "delete" key goes back twice · 8eadabd4
      jhoneycutt@apple.com authored
      Reviewed by Maciej Stachowiak.
      
      * WebView.cpp:
      (WebView::keyDown):
      Return true if we navigated back or forward from the key event to
      prevent the event from being propagated further.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58337 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8eadabd4
    • jianli@chromium.org's avatar
      Sending a package file using FormData crashes WebKit on Mac. · 8c5437f7
      jianli@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=37882
      
      Reviewed by Darin Adler.
      
      Can't add a layout test because DRT does not support generating the file name.
      
      * loader/FrameLoader.cpp:
      (WebCore::FrameLoader::submitForm):
      (WebCore::FrameLoader::navigateToDifferentDocument):
      * platform/network/FormData.cpp:
      (WebCore::FormData::appendDOMFormData):
      * platform/network/FormData.h:
      * xml/XMLHttpRequest.cpp:
      (WebCore::XMLHttpRequest::send):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58336 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8c5437f7
    • ojan@chromium.org's avatar
      2010-04-27 Ojan Vafai <ojan@chromium.org> · edea4c28
      ojan@chromium.org authored
              Unreviewed. Minor fix after goofup in http://trac.webkit.org/changeset/58331
      
              layoutTestController should have dumpAsMarkup
              https://bugs.webkit.org/show_bug.cgi?id=26501
      
              Forgot to reset the test results after doing the code review feedback
              of adding a newline.
      
              * editing/selection/dump-as-markup-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58335 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      edea4c28
    • abarth@webkit.org's avatar
      2010-04-27 Adam Barth <abarth@webkit.org> · e640c849
      abarth@webkit.org authored
              Reviewed by Eric Seidel.
      
              Remove custom NodeIterator bindings
              https://bugs.webkit.org/show_bug.cgi?id=38188
      
              Another example of CallWith=ScriptState.  This case shows us the right
              way to handle the interaction with exception codes.
      
              In my previous patch, I put the exception code handling after the
              ScriptState exception handling.  It turns out this was a mistake
              (although a harmless one at the time because no IDL caused us to
              generate that code).  Now that we're generating both kinds of exception
              handling, we need to generate them in the right order.
      
              * WebCore.gypi:
              * bindings/js/JSNodeIteratorCustom.cpp:
              * bindings/scripts/CodeGeneratorJS.pm:
              * bindings/scripts/CodeGeneratorV8.pm:
              * bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
              (webkit_dom_test_obj_with_script_state_void_exception):
              (webkit_dom_test_obj_with_script_state_obj_exception):
              * bindings/scripts/test/GObject/WebKitDOMTestObj.h:
              * bindings/scripts/test/JS/JSTestObj.cpp:
              (WebCore::):
              (WebCore::jsTestObjPrototypeFunctionWithScriptStateVoidException):
              (WebCore::jsTestObjPrototypeFunctionWithScriptStateObjException):
              * bindings/scripts/test/JS/JSTestObj.h:
              * bindings/scripts/test/ObjC/DOMTestObj.h:
              * bindings/scripts/test/ObjC/DOMTestObj.mm:
              (-[DOMTestObj withScriptStateVoidException]):
              (-[DOMTestObj withScriptStateObjException]):
              * bindings/scripts/test/TestObj.idl:
              * bindings/scripts/test/V8/V8TestObj.cpp:
              (WebCore::TestObjInternal::withScriptStateVoidCallback):
              (WebCore::TestObjInternal::withScriptStateObjCallback):
              (WebCore::TestObjInternal::withScriptStateVoidExceptionCallback):
              (WebCore::TestObjInternal::withScriptStateObjExceptionCallback):
              (WebCore::):
              * bindings/v8/custom/V8NodeIteratorCustom.cpp: Removed.
              * dom/NodeIterator.idl:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58333 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e640c849
    • weinig@apple.com's avatar
      Add comment about not using StringImpl::createCFString in WKStringCopyCFString. · 3c4b72e5
      weinig@apple.com authored
      Reviewed by Geoffrey Garen.
      
      * UIProcess/API/C/cf/WKStringCF.cpp:
      (WKStringCopyCFString):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58332 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3c4b72e5
    • ojan@chromium.org's avatar
      2010-04-26 Ojan Vafai <ojan@chromium.org> · 3f875805
      ojan@chromium.org authored
              Reviewed by Darin Adler.
      
              layoutTestController should have dumpAsMarkup
              https://bugs.webkit.org/show_bug.cgi?id=26501
      
              * editing/selection/dump-as-markup-expected.txt: Added.
              * editing/selection/dump-as-markup.html: Added.
              * resources/dump-as-markup.js: Added.
              (Markup.dump.get var):
              (Markup.dump.get catch):
              (Markup.dump):
              (Markup.waitUntilDone):
              (Markup.notifyDone):
              (Markup._spaces):
              (Markup._getAttributes):
              (Markup._getMarkupForTextNode):
              (Markup._getSelectionMarker):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58331 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3f875805
    • abarth@webkit.org's avatar
      2010-04-27 Adam Barth <abarth@webkit.org> · 2afb2f1a
      abarth@webkit.org authored
              Reviewed by Darin Adler.
      
              Remove copy/paste addEventListener "custom" bindings via code generation
              https://bugs.webkit.org/show_bug.cgi?id=38210
      
              It's somewhat lame to special case addEventListener and
              removeEventListener in the code generator, but it saves a large amount
              of boilerplate "custom" bindings code.
      
              Idea shamelessly stolen from the V8 code generator.
      
              This patch points to some good refactoring opportunities in
              CodeGeneratorJS.pm, but I'm going to hold off on those for a future
              patch.  By generating test coverage for the code generator, we make
              these future refactorings easier.
      
              * bindings/js/JSAbstractWorkerCustom.cpp:
              * bindings/js/JSDOMApplicationCacheCustom.cpp:
              * bindings/js/JSDesktopNotificationsCustom.cpp:
              * bindings/js/JSEventSourceCustom.cpp:
              * bindings/js/JSMessagePortCustom.cpp:
              * bindings/js/JSNodeCustom.cpp:
              * bindings/js/JSSVGElementInstanceCustom.cpp:
              * bindings/js/JSWebSocketCustom.cpp:
              * bindings/js/JSWorkerContextCustom.cpp:
              * bindings/js/JSXMLHttpRequestCustom.cpp:
              * bindings/js/JSXMLHttpRequestUploadCustom.cpp:
              * bindings/scripts/CodeGeneratorJS.pm:
              * bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
              * bindings/scripts/test/GObject/WebKitDOMTestObj.h:
              * bindings/scripts/test/JS/JSTestObj.cpp:
              (WebCore::):
              (WebCore::jsTestObjPrototypeFunctionAddEventListener):
              (WebCore::jsTestObjPrototypeFunctionRemoveEventListener):
              * bindings/scripts/test/JS/JSTestObj.h:
              * bindings/scripts/test/ObjC/DOMTestObj.h:
              * bindings/scripts/test/ObjC/DOMTestObj.mm:
              (-[DOMTestObj addEventListener:listener:useCapture:]):
              (-[DOMTestObj removeEventListener:listener:useCapture:]):
              * bindings/scripts/test/TestObj.idl:
              * bindings/scripts/test/V8/V8TestObj.cpp:
              (WebCore::TestObjInternal::addEventListenerCallback):
              (WebCore::TestObjInternal::removeEventListenerCallback):
              (WebCore::):
              * dom/MessagePort.idl:
              * dom/Node.idl:
              * loader/appcache/DOMApplicationCache.idl:
              * notifications/Notification.idl:
              * page/EventSource.idl:
              * svg/SVGElementInstance.idl:
              * websockets/WebSocket.idl:
              * workers/AbstractWorker.idl:
              * workers/WorkerContext.idl:
              * xml/XMLHttpRequest.idl:
              * xml/XMLHttpRequestUpload.idl:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58330 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2afb2f1a
    • abarth@webkit.org's avatar
      2010-04-27 Adam Barth <abarth@webkit.org> · ab0b0e59
      abarth@webkit.org authored
              Reviewed by Darin Adler.
      
              run-bindings-tests should use --reset-results instead of --overwrite
              https://bugs.webkit.org/show_bug.cgi?id=38200
      
              As requested by Ojan.
      
              * Scripts/run-bindings-tests:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58329 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ab0b0e59
    • abarth@webkit.org's avatar
      2010-04-27 Adam Barth <abarth@webkit.org> · a25b7bcb
      abarth@webkit.org authored
              Reviewed by Eric Seidel.
      
              REGRESSION(r58261): webkit-patch edit-changelogs is broken
              https://bugs.webkit.org/show_bug.cgi?id=38204
      
              In 58261, we added code to abstract step that interrogates the squash
              and git_commit options, but it doesn't declare that it uses those
              options.  That means any command that doesn't happen to declare those
              options might be broken if it uses the cached_lookup mechanism.
      
              * Scripts/webkitpy/tool/steps/abstractstep.py:
              * Scripts/webkitpy/tool/steps/applypatch.py:
              * Scripts/webkitpy/tool/steps/applypatchwithlocalcommit.py:
              * Scripts/webkitpy/tool/steps/build.py:
              * Scripts/webkitpy/tool/steps/checkstyle.py:
              * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
              * Scripts/webkitpy/tool/steps/closebug.py:
              * Scripts/webkitpy/tool/steps/closebugforlanddiff.py:
              * Scripts/webkitpy/tool/steps/commit.py:
              * Scripts/webkitpy/tool/steps/confirmdiff.py:
              * Scripts/webkitpy/tool/steps/createbug.py:
              * Scripts/webkitpy/tool/steps/ensurebuildersaregreen.py:
              * Scripts/webkitpy/tool/steps/ensurelocalcommitifneeded.py:
              * Scripts/webkitpy/tool/steps/obsoletepatches.py:
              * Scripts/webkitpy/tool/steps/postcodereview.py:
              * Scripts/webkitpy/tool/steps/postdiff.py:
              * Scripts/webkitpy/tool/steps/preparechangelog.py:
              * Scripts/webkitpy/tool/steps/runtests.py:
              * Scripts/webkitpy/tool/steps/update.py:
              * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
              * Scripts/webkitpy/tool/steps/validatereviewer.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58328 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a25b7bcb
    • eric@webkit.org's avatar
      2010-04-27 Eric Seidel <eric@webkit.org> · 92ca828d
      eric@webkit.org authored
              Reviewed by David Levin.
      
              prepare-ChangeLog --bug fails on some CYGWIN installs due to missing certs
              https://bugs.webkit.org/show_bug.cgi?id=38212
      
              * Scripts/prepare-ChangeLog:
               - Pass --insecure to curl to work around CYGWIN missing certs.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58327 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      92ca828d
    • weinig@apple.com's avatar
      Remove call to StringImpl::createCFString and instead use CFStringCreateWithCharacters · 6fe974f3
      weinig@apple.com authored
      directly. StringImpl::createCFString only an optimization when called
      from the thread that WebCore is running on, which is never the case for
      WKStringCopyCFString. We should revisit this later, perhaps adding a
      threadspecific allocator. We also now honor the passed in allocator.
      
      Reviewed by Geoffrey Garen.
      
      * UIProcess/API/C/cf/WKStringCF.cpp:
      (WKStringCopyCFString):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58325 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6fe974f3
    • weinig@apple.com's avatar
      WebCore: Remove now unnecessary EXPERIMENTAL_SINGLE_VIEW_MODE #define. · 5908dd0c
      weinig@apple.com authored
      Rubber-stamped by Beth Dakin.
      
      * page/EventHandler.cpp:
      (WebCore::EventHandler::EventHandler):
      (WebCore::EventHandler::clearDragState):
      * page/EventHandler.h:
      * page/mac/DragControllerMac.mm:
      * page/mac/EventHandlerMac.mm:
      * platform/mac/PopupMenuMac.mm:
      
      WebKitTools: It is no longer necessary to set ENABLE_EXPERIMENTAL_SINGLE_VIEW_MODE
      or WTF_USE_WEB_THREAD. Remove them.
      
      Rubber-stamped by Beth Dakin.
      
      * Scripts/build-webkit:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58324 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5908dd0c
    • eric@webkit.org's avatar
      2010-04-27 Ben Murdoch <benm@google.com> · ef70f41c
      eric@webkit.org authored
              Reviewed by Simon Hausmann.
      
              The TouchStationary state of WebCore::PlatformTouchPoint is not handled inside the touch event handler.
              https://bugs.webkit.org/show_bug.cgi?id=37609
      
              No new tests required, only updating documentation.
      
              * page/EventHandler.cpp:
              (WebCore::EventHandler::handleTouchEvent): Improve the documentation for handling
                  the TouchStationary state as a result of discussions in bug 37609.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58323 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ef70f41c
    • cjerdonek@webkit.org's avatar
      Changed Chris Jerdonek from committer to reviewer. · cf7ae686
      cjerdonek@webkit.org authored
      Reviewed by David Levin.
      
      * Scripts/webkitpy/common/config/committers.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58322 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cf7ae686
    • eric@webkit.org's avatar
      2010-04-27 Benjamin Poulain <benjamin.poulain@nokia.com> · 31018b22
      eric@webkit.org authored
              Reviewed by Kenneth Rohde Christiansen.
      
              [Qt] QGraphicsWebView: Arrow keys scroll the graphics-view instead of the web-page
              https://bugs.webkit.org/show_bug.cgi?id=35834
      
              The scene should always have the size of the web view otherwhise it is
              possible to scroll the graphics view.
      
              * QtLauncher/webview.cpp:
              (WebViewGraphicsBased::resizeEvent):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58321 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      31018b22
    • simon.fraser@apple.com's avatar
      2010-04-27 Simon Fraser <simon.fraser@apple.com> · ad796c5d
      simon.fraser@apple.com authored
              Reviewed by Darin Adler, Maciej Stachowiak.
      
              REGRESSION (r57919): Some pages opened in background tabs don't render the first time you activate their tab
              https://bugs.webkit.org/show_bug.cgi?id=38183
      
              Rather than sprinkle PLATFORM #ifdefs around, add a new method,
              RenderLayerCompositor::shouldPropagateCompositingToIFrameParent(), that indicates whether
              an iframe with composited content should trigger compositing mode in the enclosing document
              (a behavior that differs between platforms).
      
              Use this new method to determine whether to trigger a style recalc in the parent document
              when an iframe becomes composited.
      
              Move the code formerly in RenderView::compositingStateChanged() into RenderLayerCompositor().
      
              * manual-tests/compositing/accel-comp-iframe-tab-repaint.html: Added.
              * manual-tests/compositing/resources/flash-frame.html: Added.
              * manual-tests/compositing/resources/tab-repaint-part-2.html: Added.
              * rendering/RenderLayerCompositor.cpp:
              (WebCore::RenderLayerCompositor::enableCompositingMode):
              (WebCore::RenderLayerCompositor::shouldPropagateCompositingToIFrameParent):
              (WebCore::RenderLayerCompositor::requiresCompositingForIFrame):
              * rendering/RenderLayerCompositor.h:
              * rendering/RenderView.cpp:
              * rendering/RenderView.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58320 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ad796c5d
    • diegohcg@webkit.org's avatar
      Unreviewed. · 6bf96bc4
      diegohcg@webkit.org authored
      Adding myself to committers.py
      
      * Scripts/webkitpy/common/config/committers.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58319 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6bf96bc4
    • eric@webkit.org's avatar
      2010-04-27 Andrey Kosyakov <caseq@chromium.org> · 0bac08f9
      eric@webkit.org authored
              Reviewed by Yury Semikhatsky.
      
              Log error message to inspector console if a resource fails to load.
              Moved console-tests.js to http tests. Added support for sorting
              console messages, in case order may vary.
              https://bugs.webkit.org/show_bug.cgi?id=37215
      
              * http/tests/inspector/console-resource-errors-expected.txt: Added.
              * http/tests/inspector/console-resource-errors.html: Added.
              * http/tests/inspector/console-tests.js: Added.
              (dumpConsoleMessages.callback):
              (dumpConsoleMessages):
              (dumpConsoleMessagesWithClasses.callback):
              (dumpConsoleMessagesWithClasses):
              (frontend_dumpConsoleMessages):
              * inspector/console-clear.html:
              * inspector/console-dir.html:
              * inspector/console-dirxml.html:
              * inspector/console-format-collections-expected.txt:
              * inspector/console-format-collections.html:
              * inspector/console-format.html:
              * inspector/console-log-before-inspector-open.html:
              * inspector/console-tests.html:
              * inspector/console-tests.js: Removed.
      2010-04-27  Andrey Kosyakov  <caseq@chromium.org>
      
              Reviewed by Yury Semikhatsky.
      
              Log error message to inspector console if a resource fails to load.
              Disable checking of mime-type consistency for failed resources.
              https://bugs.webkit.org/show_bug.cgi?id=37215
      
              Test: http/tests/inspector/console-resource-errors.html
      
              * inspector/InspectorController.cpp:
              (WebCore::InspectorController::didReceiveResponse):
              (WebCore::InspectorController::didFailLoading):
              * inspector/front-end/Resource.js:
              (WebInspector.Resource.prototype._mimeTypeIsConsistentWithType):
              * inspector/front-end/ResourcesPanel.js:
              (WebInspector.ResourcesPanel.prototype.recreateViewForResourceIfNeeded):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58318 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0bac08f9
    • oliver@apple.com's avatar
      2010-04-26 Oliver Hunt <oliver@apple.com> · 5cdd4f8f
      oliver@apple.com authored
              Reviewed by Maciej Stachowiak.
      
              Add specialized thunks for a char code related string functions
              https://bugs.webkit.org/show_bug.cgi?id=38177
      
              This is a simple extension to my prior patch.  Basically hoist the
              existing character loading logic from the charCodeAt thunk and into
              a helper function, then add a helper to load strings from the small
              string cache.  This allows trivial implementations of fromCharCode
              and charAt.
      
              * create_hash_table:
              * jit/SpecializedThunkJIT.h:
              (JSC::SpecializedThunkJIT::returnJSCell):
              (JSC::SpecializedThunkJIT::tagReturnAsJSCell):
              * jit/ThunkGenerators.cpp:
              (JSC::stringCharLoad):
              (JSC::charToString):
              (JSC::charCodeAtThunkGenerator):
              (JSC::charAtThunkGenerator):
              (JSC::fromCharCodeThunkGenerator):
              * jit/ThunkGenerators.h:
              * runtime/SmallStrings.h:
              (JSC::SmallStrings::singleCharacterStrings):
              * runtime/StringConstructor.cpp:
              (JSC::StringConstructor::StringConstructor):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58317 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5cdd4f8f
    • vitalyr@chromium.org's avatar
      2010-04-27 Vitaly Repeshko <vitalyr@chromium.org> · 77830a3a
      vitalyr@chromium.org authored
              Reviewed by Nate Chapin.
      
              [V8] Fix XHR memory leak in GC controller.
              https://bugs.webkit.org/show_bug.cgi?id=38202
      
              http://trac.webkit.org/changeset/55798 simplified processing of
              active DOM objects but introduced a subtle bug in garbage
              collection of XHRs. ActiveDOMObject is not a direct base class of
              XHR and so upcasting changes pointer identity and breaks DOM
              maps. This leads to forever live persistent handles to XHR that
              had pending activity while V8 GC happened.
      
              * bindings/v8/V8GCController.cpp:
              (WebCore::GCEpilogueVisitor::visitDOMWrapper):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58316 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      77830a3a
    • abarth@webkit.org's avatar
      2010-04-27 Adam Barth <abarth@webkit.org> · 70b66646
      abarth@webkit.org authored
              Unreviewed.  Regenerate reference bindings code generator output.
      
              * bindings/scripts/test/V8/V8TestObj.cpp:
              (WebCore::TestObjInternal::withScriptStateVoidCallback):
              (WebCore::TestObjInternal::withScriptStateObjCallback):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58315 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      70b66646
    • eric@webkit.org's avatar
      2010-04-27 Eric Seidel <eric@webkit.org> · 36df7fe9
      eric@webkit.org authored
              Reviewed by Adam Barth.
      
              [chromium] new-run-webkit-tests hangs on Chromium Bots (OS X and Linux)
              https://bugs.webkit.org/show_bug.cgi?id=37987
      
              After further research, I believe the hang is caused by:
              http://bugs.python.org/issue2320
              Basically Popen() is not reentrant.
              The workaround is to pass close_fds=True to Popen() on Mac/Linux.
      
              I fixed our main Popen wrapper "Executive.run_command" to use close_fds=True
              when appropriate.
      
              I audited all places we call Popen() and either moved them to run_command
              or left a FIXME that they are not thread safe.  A few places I added the
              close_fds workaround there and left an explanitory note.
      
              * Scripts/webkitpy/common/checkout/scm_unittest.py:
               - Added note that this Popen use is not threadsafe.
              * Scripts/webkitpy/common/system/executive.py:
               - Fixed our Executive.run_* to workaround python bug 2320.
              * Scripts/webkitpy/common/system/user.py:
               _ Added note that this Popen use is not threadsafe.
              * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py: ditto.
              * Scripts/webkitpy/layout_tests/port/apache_http_server.py: ditto.
              * Scripts/webkitpy/layout_tests/port/base.py:
               - Change wdiff back to using run_command now that we believe it
                 to be threadsafe.
              * Scripts/webkitpy/layout_tests/port/chromium.py:
               - Fix to use Executive in places.
               - Pass self._executive down to the Driver for easier unit testing.
              * Scripts/webkitpy/layout_tests/port/chromium_win.py:
               - Re-factor to use a _kill_all method.
               - Made the _kill_all method use run_command to be threadsafe.
              * Scripts/webkitpy/layout_tests/port/http_server.py:
               - Add FIXME about using Executive.
              * Scripts/webkitpy/layout_tests/port/server_process.py:
               - Use Executive to be threadsafe.
              * Scripts/webkitpy/layout_tests/port/webkit.py:
               - Pass self._executive down to the Driver.
              * Scripts/webkitpy/layout_tests/port/websocket_server.py:
               - Add note about Popen not being threadsafe.
              * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
               - Move one caller to run_command add notes about moving others.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58314 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      36df7fe9