1. 22 Feb, 2007 15 commits
    • adele's avatar
      LayoutTests: · 85492aca
      adele authored
              Reviewed by Darin.
      
              Test for <rdar://problem/5014970> 9A374: Tabs don't work in the message body
      
              * fast/events/keypress-insert-tab-expected.txt: Added.
              * fast/events/keypress-insert-tab.html: Added.
      
      WebCore:
      
              Reviewed by Darin.
      
              Fix for <rdar://problem/5014970> 9A374: Tabs don't work in the message body
      
              Test: fast/events/keypress-insert-tab.html
      
              * page/EventHandler.cpp: (WebCore::EventHandler::defaultTextInputEventHandler):
                If the defaultTabEventHandler doesn't handle the event, then go on to the insertText case.
      
      WebKitTools:
      
              Reviewed by Darin.
      
              Added option in layoutTestController to setTabKeyCyclesThroughElements, so we
              can test <rdar://problem/5014970> 9A374: Tabs don't work in the message body
      
              * DumpRenderTree/DumpRenderTree.m:
              (+[LayoutTestController isSelectorExcludedFromWebScript:]):
              (+[LayoutTestController webScriptNameForSelector:]):
              (-[LayoutTestController setTabKeyCyclesThroughElements:]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19806 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      85492aca
    • ggaren's avatar
      Reviewed by Darin Adler. · 42d6fcd9
      ggaren authored
              
              Fixed <rdar://problem/4942528> Installer.app Stuck "Examining additional 
              volumes..."
              
              The problem was that JavaScriptGlue held a JSObject in a static pointer
              without protecting it from garbage collection. 
              
                  sUserObjectPrototypeImp  = new UserObjectPrototypeImp();
                  static ProtectedPtr<UserObjectPrototypeImp> protectPrototype; // valiant, brave, but useless
      
              Through an interesting comedy of errors, this object would be collected 
              and then assigned as the prototype of another object allocated at the 
              same address, thus becoming its own prototype. (See http://www.ziplo.com/grandpa.htm
              for further explanation of this phenomenon.) Hence the infinte loop in 
              property lookup.
              
              The solution is equally humorous: all of this code was completely useless --
              it only served to create an empty object in the prototype chain -- so
              I just removed it.
      
              * UserObjectImp.cpp:
              (UserObjectImp::UserObjectImp):
              * UserObjectImp.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19805 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      42d6fcd9
    • thatcher's avatar
      Reviewed by Darin. · 0eaad48b
      thatcher authored
              <rdar://problem/4948887> REGRESSION: Correct differences in public DOM API that inadvertently changed in Leopard
      
              * bindings/objc/PublicDOMInterfaces.h: Changes return types for two size properties, adds deprecated DOMEventTarget methods.
              * bindings/scripts/CodeGeneratorObjC.pm: Fixed public API checking for protocols, adds support for ConvertToString.
              * dom/EventTarget.idl: Marks addEventListener and removeEventListener with the OldStyleObjC attribute.
              * html/HTMLBaseFontElement.idl: Changes the size property to a DOMString for ObjC only.
              * html/HTMLInputElement.idl: Changes the size property to a DOMString for ObjC only.
              * html/HTMLOptionsCollection.idl: Changes the length property to be unsigned.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19800 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0eaad48b
    • adele's avatar
      Reviewed by John. · de31e189
      adele authored
              Fix <rdar://problem/5016969> REGRESSION: "Check Spelling As You Type" context menu item is never checked
      
              * platform/ContextMenu.cpp: (WebCore::ContextMenu::checkOrEnableIfNeeded): Set shouldCheck for ContextMenuItemTagCheckSpellingWhileTyping.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19799 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      de31e189
    • ggaren's avatar
      LayoutTests: · 2383ddfd
      ggaren authored
              Used svn merge -r19786:19785 to roll out previous SVG results produced by 
              hack to work around SVG painting issue in DRT.
              
              The new work-around preserves the old SVG results -- both text and pixel. 
              This should fix the ~400 new pixel failures introduced in r19786.
      
              * svg/W3C-SVG-1.1/animate-elem-02-t-expected.txt:
              * svg/W3C-SVG-1.1/animate-elem-03-t-expected.txt:
              * svg/W3C-SVG-1.1/animate-elem-04-t-expected.txt:
              * svg/W3C-SVG-1.1/animate-elem-05-t-expected.txt:
              * svg/W3C-SVG-1.1/animate-elem-06-t-expected.txt:
              * svg/W3C-SVG-1.1/animate-elem-07-t-expected.txt:
              * svg/W3C-SVG-1.1/animate-elem-08-t-expected.txt:
              * svg/W3C-SVG-1.1/animate-elem-13-t-expected.txt:
              * svg/W3C-SVG-1.1/animate-elem-14-t-expected.txt:
              * svg/W3C-SVG-1.1/animate-elem-15-t-expected.txt:
              * svg/W3C-SVG-1.1/animate-elem-16-t-expected.txt:
              * svg/W3C-SVG-1.1/animate-elem-17-t-expected.txt:
              * svg/W3C-SVG-1.1/animate-elem-18-t-expected.txt:
              * svg/W3C-SVG-1.1/animate-elem-19-t-expected.txt:
              * svg/W3C-SVG-1.1/animate-elem-20-t-expected.txt:
              * svg/W3C-SVG-1.1/animate-elem-21-t-expected.txt:
              * svg/W3C-SVG-1.1/animate-elem-24-t-expected.txt:
              * svg/W3C-SVG-1.1/animate-elem-29-b-expected.txt:
              * svg/W3C-SVG-1.1/animate-elem-33-t-expected.txt:
              * svg/W3C-SVG-1.1/animate-elem-36-t-expected.txt:
              * svg/W3C-SVG-1.1/animate-elem-39-t-expected.txt:
              * svg/W3C-SVG-1.1/animate-elem-40-t-expected.txt:
              * svg/W3C-SVG-1.1/animate-elem-46-t-expected.txt:
              * svg/W3C-SVG-1.1/animate-elem-77-t-expected.txt:
              * svg/W3C-SVG-1.1/filters-blend-01-b-expected.txt:
              * svg/W3C-SVG-1.1/fonts-elem-02-t-expected.txt:
              * svg/W3C-SVG-1.1/interact-cursor-01-f-expected.txt:
              * svg/W3C-SVG-1.1/interact-events-01-b-expected.txt:
              * svg/W3C-SVG-1.1/linking-uri-01-b-expected.txt:
              * svg/W3C-SVG-1.1/linking-uri-02-b-expected.txt:
              * svg/W3C-SVG-1.1/masking-mask-01-b-expected.txt:
              * svg/W3C-SVG-1.1/masking-path-04-b-expected.txt:
              * svg/W3C-SVG-1.1/metadata-example-01-b-expected.txt:
              * svg/W3C-SVG-1.1/painting-fill-02-t-expected.txt:
              * svg/W3C-SVG-1.1/painting-marker-03-f-expected.txt:
              * svg/W3C-SVG-1.1/pservers-grad-05-b-expected.txt:
              * svg/W3C-SVG-1.1/pservers-grad-08-b-expected.txt:
              * svg/W3C-SVG-1.1/pservers-grad-11-b-expected.txt:
              * svg/W3C-SVG-1.1/render-elems-06-t-expected.txt:
              * svg/W3C-SVG-1.1/render-elems-07-t-expected.txt:
              * svg/W3C-SVG-1.1/render-elems-08-t-expected.txt:
              * svg/W3C-SVG-1.1/script-handle-01-b-expected.txt:
              * svg/W3C-SVG-1.1/struct-frag-06-t-expected.txt:
              * svg/W3C-SVG-1.1/struct-use-01-t-expected.txt:
              * svg/W3C-SVG-1.1/text-align-01-b-expected.txt:
              * svg/W3C-SVG-1.1/text-align-02-b-expected.txt:
              * svg/W3C-SVG-1.1/text-align-03-b-expected.txt:
              * svg/W3C-SVG-1.1/text-align-04-b-expected.txt:
              * svg/W3C-SVG-1.1/text-align-05-b-expected.txt:
              * svg/W3C-SVG-1.1/text-align-06-b-expected.txt:
              * svg/W3C-SVG-1.1/text-altglyph-01-b-expected.txt:
              * svg/W3C-SVG-1.1/text-deco-01-b-expected.txt:
              * svg/W3C-SVG-1.1/text-fonts-01-t-expected.txt:
              * svg/W3C-SVG-1.1/text-fonts-02-t-expected.txt:
              * svg/W3C-SVG-1.1/text-text-01-b-expected.txt:
              * svg/W3C-SVG-1.1/text-text-03-b-expected.txt:
              * svg/W3C-SVG-1.1/text-text-08-b-expected.txt:
              * svg/W3C-SVG-1.1/text-tref-01-b-expected.txt:
              * svg/W3C-SVG-1.1/text-tselect-02-f-expected.txt:
              * svg/W3C-SVG-1.1/text-tspan-01-b-expected.txt:
              * svg/W3C-SVG-1.1/text-ws-01-t-expected.txt:
              * svg/W3C-SVG-1.1/text-ws-02-t-expected.txt:
              * svg/carto.net/button-expected.txt:
              * svg/carto.net/colourpicker-expected.txt:
              * svg/carto.net/combobox-expected.txt:
              * svg/carto.net/scrollbar-expected.txt:
              * svg/carto.net/selectionlist-expected.txt:
              * svg/carto.net/slider-expected.txt:
              * svg/carto.net/tabgroup-expected.txt:
              * svg/carto.net/textbox-expected.txt:
              * svg/carto.net/window-expected.txt:
              * svg/custom/gradient-stop-style-change-expected.txt:
              * svg/custom/js-late-clipPath-and-object-creation-expected.txt:
              * svg/custom/js-late-clipPath-creation-expected.txt:
              * svg/custom/js-late-gradient-and-object-creation-expected.txt:
              * svg/custom/non-opaque-filters-expected.txt:
              * svg/custom/pointer-events-text-expected.txt:
              * svg/custom/text-clip-expected.txt:
              * svg/custom/text-filter-expected.txt:
              * svg/custom/text-image-opacity-expected.txt:
              * svg/custom/text-repaint-including-stroke-expected.txt:
              * svg/custom/use-elementInstance-event-target-expected.txt:
              * svg/custom/use-on-text-expected.txt:
      
      WebKitTools:
      
              Used svn merge -r19786:19785 to roll out previous hack to work around
              SVG painting issue in DRT.
              
              Implemented new work-around, which makes --paint paint *after* dumping
              the render tree instead of before, so that painting doesn't influence
              the SVG render tree.
      
              This should fix the ~400 new pixel failures introduced in r19786.
      
              * DumpRenderTree/DumpRenderTree.m:
              (dump):
              * Scripts/run-webkit-tests:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19798 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2383ddfd
    • antti's avatar
      LayoutTests: · 7241719f
      antti authored
              Reviewed by Darin.
              
              - tests for http://bugs.webkit.org/show_bug.cgi?id=11447
              REGRESSION(NativeListBox): List not scrolled to preselected option
              <rdar://problem/4957463>
      
              * fast/forms/select-initial-position-expected.checksum: Added.
              * fast/forms/select-initial-position-expected.png: Added.
              * fast/forms/select-initial-position-expected.txt: Added.
              * fast/forms/select-initial-position.html: Added.
      
      WebCore:
      
              Reviewed by Darin.
      
              - fix http://bugs.webkit.org/show_bug.cgi?id=11447
              REGRESSION(NativeListBox): List not scrolled to preselected option
              <rdar://problem/4957463>
              
              Initiate scroll when selected <option> is added to <select>.
      
              * html/HTMLOptionElement.cpp:
              (WebCore::HTMLOptionElement::insertedIntoDocument):
              * html/HTMLOptionElement.h:
              * html/HTMLSelectElement.cpp:
              (WebCore::HTMLSelectElement::notifyOptionSelected):
              (WebCore::HTMLSelectElement::updateListBoxSelection):
              (WebCore::HTMLSelectElement::scrollToSelection):
              * html/HTMLSelectElement.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19797 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7241719f
    • zack's avatar
      Fix sites with fixed positioned backgrounds. (my blog =) ) · 4c44203c
      zack authored
      r=Lars,George
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19796 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4c44203c
    • ggaren's avatar
      Resetting --leaks mode default to run 1000 tests at a time because setting it · e647ade1
      ggaren authored
              to 750 didn't stop the stack logging related crashes, and running more tests
              at a time is faster. The crashes seem to be a real bug in stack logging, 
              not an out of memory condition.
      
              * Scripts/run-webkit-tests:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19795 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e647ade1
    • sullivan's avatar
      Reviewed by Darin · d063eb68
      sullivan authored
              
              Removed some unused keyView-related code that I happened to run across.
              Replacement code is now in WebChromeClient.
      
              * WebCoreSupport/WebFrameBridge.h:
              * WebCoreSupport/WebFrameBridge.mm:
              removed unused stuff
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19794 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d063eb68
    • zack's avatar
      Fixing the default scroll offset, cleaning · 7ef6b283
      zack authored
      up private methods and making the default
      look not use any frames.
      r=Lars
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19793 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7ef6b283
    • zack's avatar
      Properly implement canvas/scrollview's. Get · 7596eee3
      zack authored
      rid of ScrollViewCanvasQt and replace it with
      a tailor abstractscrollview (now in qwebframe).
      Scrolling of pages is finally completely smooth :)
      r=Lars
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19792 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7596eee3
    • weinig's avatar
      Reviewed by Maciej. · 1a3a6ec4
      weinig authored
              Fix ARM-specific alignment problem in FastMalloc
              http://bugs.webkit.org/show_bug.cgi?id=12841
      
              * wtf/FastMalloc.cpp:
              Modify how pageheap_memory is declared to ensure proper alignment
              on architectures such as ARM
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19791 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1a3a6ec4
    • weinig's avatar
      Reviewed by Maciej. · 25c80ac5
      weinig authored
              - fix http://bugs.webkit.org/show_bug.cgi?id=12804
                REGRESSION (r19043-r19063): suggestion popup doesn't work after pressing Option+Esc
      
              This patch also fixes a bug where using the arrow keys while
              the suggestion popup is open moves the caret instead of changing the
              selection in the popup (for up/down) or accepting the selection and
              closing the popup (for left/right).
      
              * WebView/WebHTMLView.mm:
              (-[WebHTMLView keyDown:]): Changed to close the popup only if it was open
              before the current event, so that the Option-Esc that opens the popup will
              not close it immediately.
              (-[WebHTMLView _interceptEditingKeyEvent:]): Give the completion popup a
              chance to intercept keydown events.
              (-[WebTextCompleteController popupWindowIsOpen]): Added. Returns whether the
              suggestion popup is open.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19790 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      25c80ac5
    • weinig's avatar
      Reviewed by Mark (age 21). · f616785f
      weinig authored
              - fix http://bugs.webkit.org/show_bug.cgi?id=12805
                REGRESSION: suggestion popup has a disabled scroll bar
      
              * WebView/WebHTMLView.mm:
              (-[WebTextCompleteController _buildUI]): Uncommented the call to the NSWindow
              SPI that forces the scroll bar to look active. Also replaced a call to
              the deprecated NSTableView method setAutoresizesAllColumnsToFit: with
              the new method setColumnAutoresizingStyle: to eliminate console spew.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19789 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f616785f
    • kjk's avatar
      Reviewed by Adam Roben. · 460dcc6d
      kjk authored
              Improve notImplemented() macro for gdk. Rename to notImplementedGdk() to
              give it a unique name (so that it doesn't clash with notImplemented()
              for other platforms).
              Make it print a given warning only once, so that frequently called
              functions don't clutter the output.
              Don't print the warning if DISABLE_NI_WARNING env variable is set.
      
              * loader/gdk/FrameLoaderClientGdk.cpp:
              (WebCore::FrameLoaderClientGdk::dispatchDidReceiveAuthenticationChallenge):
              (WebCore::FrameLoaderClientGdk::dispatchDidCancelAuthenticationChallenge):
              (WebCore::FrameLoaderClientGdk::dispatchWillSendRequest):
              (WebCore::FrameLoaderClientGdk::assignIdentifierToInitialRequest):
              (WebCore::FrameLoaderClientGdk::createPlugin):
              (WebCore::FrameLoaderClientGdk::createFrame):
              (WebCore::FrameLoaderClientGdk::redirectDataToPlugin):
              (WebCore::FrameLoaderClientGdk::createJavaAppletWidget):
              (WebCore::FrameLoaderClientGdk::objectContentType):
              (WebCore::FrameLoaderClientGdk::overrideMediaType):
              (WebCore::FrameLoaderClientGdk::windowObjectCleared):
              (WebCore::FrameLoaderClientGdk::hasWebView):
              (WebCore::FrameLoaderClientGdk::hasFrameView):
              (WebCore::FrameLoaderClientGdk::frameLoadCompleted):
              (WebCore::FrameLoaderClientGdk::saveViewStateToItem):
              (WebCore::FrameLoaderClientGdk::restoreViewState):
              (WebCore::FrameLoaderClientGdk::privateBrowsingEnabled):
              (WebCore::FrameLoaderClientGdk::makeDocumentView):
              (WebCore::FrameLoaderClientGdk::makeRepresentation):
              (WebCore::FrameLoaderClientGdk::forceLayout):
              (WebCore::FrameLoaderClientGdk::forceLayoutForNonHTML):
              (WebCore::FrameLoaderClientGdk::setCopiesOnScroll):
              (WebCore::FrameLoaderClientGdk::detachedFromParent1):
              (WebCore::FrameLoaderClientGdk::detachedFromParent2):
              (WebCore::FrameLoaderClientGdk::detachedFromParent3):
              (WebCore::FrameLoaderClientGdk::detachedFromParent4):
              (WebCore::FrameLoaderClientGdk::loadedFromPageCache):
              (WebCore::FrameLoaderClientGdk::dispatchDidHandleOnloadEvents):
              (WebCore::FrameLoaderClientGdk::dispatchDidReceiveServerRedirectForProvisionalLoad):
              (WebCore::FrameLoaderClientGdk::dispatchDidCancelClientRedirect):
              (WebCore::FrameLoaderClientGdk::dispatchWillPerformClientRedirect):
              (WebCore::FrameLoaderClientGdk::dispatchDidChangeLocationWithinPage):
              (WebCore::FrameLoaderClientGdk::dispatchWillClose):
              (WebCore::FrameLoaderClientGdk::dispatchDidReceiveIcon):
              (WebCore::FrameLoaderClientGdk::dispatchDidStartProvisionalLoad):
              (WebCore::FrameLoaderClientGdk::dispatchDidReceiveTitle):
              (WebCore::FrameLoaderClientGdk::dispatchDidCommitLoad):
              (WebCore::FrameLoaderClientGdk::dispatchDidFinishDocumentLoad):
              (WebCore::FrameLoaderClientGdk::dispatchDidFirstLayout):
              (WebCore::FrameLoaderClientGdk::dispatchShow):
              (WebCore::FrameLoaderClientGdk::cancelPolicyCheck):
              (WebCore::FrameLoaderClientGdk::dispatchDidLoadMainResource):
              (WebCore::FrameLoaderClientGdk::revertToProvisionalState):
              (WebCore::FrameLoaderClientGdk::clearUnarchivingState):
              (WebCore::FrameLoaderClientGdk::willChangeTitle):
              (WebCore::FrameLoaderClientGdk::finishedLoading):
              (WebCore::FrameLoaderClientGdk::finalSetupForReplace):
              (WebCore::FrameLoaderClientGdk::setDefersLoading):
              (WebCore::FrameLoaderClientGdk::isArchiveLoadPending):
              (WebCore::FrameLoaderClientGdk::cancelPendingArchiveLoad):
              (WebCore::FrameLoaderClientGdk::clearArchivedResources):
              (WebCore::FrameLoaderClientGdk::canHandleRequest):
              (WebCore::FrameLoaderClientGdk::canShowMIMEType):
              (WebCore::FrameLoaderClientGdk::representationExistsForURLScheme):
              (WebCore::FrameLoaderClientGdk::generatedMIMETypeForURLScheme):
              (WebCore::FrameLoaderClientGdk::provisionalLoadStarted):
              (WebCore::FrameLoaderClientGdk::didFinishLoad):
              (WebCore::FrameLoaderClientGdk::prepareForDataSourceReplacement):
              (WebCore::FrameLoaderClientGdk::setTitle):
              (WebCore::FrameLoaderClientGdk::setDocumentViewFromPageCache):
              (WebCore::FrameLoaderClientGdk::dispatchDidReceiveContentLength):
              (WebCore::FrameLoaderClientGdk::dispatchDidFinishLoading):
              (WebCore::FrameLoaderClientGdk::dispatchDidFailLoading):
              (WebCore::FrameLoaderClientGdk::dispatchDidLoadResourceFromMemoryCache):
              (WebCore::FrameLoaderClientGdk::dispatchDidFailProvisionalLoad):
              (WebCore::FrameLoaderClientGdk::dispatchDidFailLoad):
              (WebCore::FrameLoaderClientGdk::download):
              (WebCore::FrameLoaderClientGdk::cancelledError):
              (WebCore::FrameLoaderClientGdk::cannotShowURLError):
              (WebCore::FrameLoaderClientGdk::interruptForPolicyChangeError):
              (WebCore::FrameLoaderClientGdk::cannotShowMIMETypeError):
              (WebCore::FrameLoaderClientGdk::fileDoesNotExistError):
              (WebCore::FrameLoaderClientGdk::shouldFallBack):
              (WebCore::FrameLoaderClientGdk::willUseArchive):
              (WebCore::FrameLoaderClientGdk::saveDocumentViewToPageCache):
              (WebCore::FrameLoaderClientGdk::canCachePage):
              (WebCore::FrameLoaderClientGdk::dispatchCreatePage):
              (WebCore::FrameLoaderClientGdk::dispatchUnableToImplementPolicy):
              (WebCore::FrameLoaderClientGdk::setMainDocumentError):
              (WebCore::FrameLoaderClientGdk::startDownload):
              (WebCore::FrameLoaderClientGdk::updateGlobalHistoryForStandardLoad):
              (WebCore::FrameLoaderClientGdk::updateGlobalHistoryForReload):
              (WebCore::FrameLoaderClientGdk::shouldGoToHistoryItem):
              * page/gdk/EventHandlerGdk.cpp:
              (WebCore::EventHandler::passMouseDownEventToWidget):
              (WebCore::EventHandler::eventActivatedView):
              (WebCore::EventHandler::passSubframeEventToSubframe):
              (WebCore::EventHandler::passWheelEventToWidget):
              (WebCore::EventHandler::createDraggingClipboard):
              * platform/gdk/EditorClientGdk.cpp:
              (WebCore::EditorClientGdk::shouldDeleteRange):
              (WebCore::EditorClientGdk::isContinuousSpellCheckingEnabled):
              (WebCore::EditorClientGdk::isGrammarCheckingEnabled):
              (WebCore::EditorClientGdk::spellCheckerDocumentTag):
              (WebCore::EditorClientGdk::shouldBeginEditing):
              (WebCore::EditorClientGdk::shouldEndEditing):
              (WebCore::EditorClientGdk::shouldInsertText):
              (WebCore::EditorClientGdk::shouldChangeSelectedRange):
              (WebCore::EditorClientGdk::shouldApplyStyle):
              (WebCore::EditorClientGdk::didBeginEditing):
              (WebCore::EditorClientGdk::respondToChangedContents):
              (WebCore::EditorClientGdk::didEndEditing):
              (WebCore::EditorClientGdk::didWriteSelectionToPasteboard):
              (WebCore::EditorClientGdk::didSetSelectionTypesForPasteboard):
              (WebCore::EditorClientGdk::selectWordBeforeMenuEvent):
              (WebCore::EditorClientGdk::isEditable):
              (WebCore::EditorClientGdk::registerCommandForUndo):
              (WebCore::EditorClientGdk::registerCommandForRedo):
              (WebCore::EditorClientGdk::clearUndoRedoOperations):
              (WebCore::EditorClientGdk::canUndo):
              (WebCore::EditorClientGdk::canRedo):
              (WebCore::EditorClientGdk::undo):
              (WebCore::EditorClientGdk::redo):
              (WebCore::EditorClientGdk::shouldInsertNode):
              (WebCore::EditorClientGdk::pageDestroyed):
              (WebCore::EditorClientGdk::smartInsertDeleteEnabled):
              (WebCore::EditorClientGdk::toggleContinuousSpellChecking):
              (WebCore::EditorClientGdk::textFieldDidBeginEditing):
              (WebCore::EditorClientGdk::textFieldDidEndEditing):
              (WebCore::EditorClientGdk::textDidChangeInTextField):
              (WebCore::EditorClientGdk::doTextFieldCommandFromEvent):
              (WebCore::EditorClientGdk::textWillBeDeletedInTextField):
              (WebCore::EditorClientGdk::textDidChangeInTextArea):
              * platform/gdk/RenderThemeGdk.cpp:
              (WebCore::RenderThemeGdk::setCheckboxSize):
              (WebCore::RenderThemeGdk::setRadioSize):
              (WebCore::RenderThemeGdk::adjustTextFieldStyle):
              * platform/gdk/TemporaryLinkStubs.cpp:
              (FrameView::updateBorder):
              (Widget::setEnabled):
              (Widget::isEnabled):
              (Widget::focusPolicy):
              (Widget::enableFlushDrawing):
              (Widget::disableFlushDrawing):
              (Widget::lockDrawingFocus):
              (Widget::unlockDrawingFocus):
              (Widget::removeFromParent):
              (Widget::paint):
              (Widget::setIsSelected):
              (Widget::invalidate):
              (Widget::invalidateRect):
              (PlatformMouseEvent::PlatformMouseEvent):
              (WebCore::findNextSentenceFromIndex):
              (WebCore::findSentenceBoundary):
              (WebCore::findNextWordFromIndex):
              (ChromeClientGdk::chromeDestroyed):
              (ChromeClientGdk::windowRect):
              (ChromeClientGdk::setWindowRect):
              (ChromeClientGdk::pageRect):
              (ChromeClientGdk::scaleFactor):
              (ChromeClientGdk::focus):
              (ChromeClientGdk::unfocus):
              (ChromeClientGdk::createWindow):
              (ChromeClientGdk::createModalDialog):
              (ChromeClientGdk::show):
              (ChromeClientGdk::canRunModal):
              (ChromeClientGdk::runModal):
              (ChromeClientGdk::setToolbarsVisible):
              (ChromeClientGdk::toolbarsVisible):
              (ChromeClientGdk::setStatusbarVisible):
              (ChromeClientGdk::statusbarVisible):
              (ChromeClientGdk::setScrollbarsVisible):
              (ChromeClientGdk::scrollbarsVisible):
              (ChromeClientGdk::setMenubarVisible):
              (ChromeClientGdk::menubarVisible):
              (ChromeClientGdk::setResizable):
              (ChromeClientGdk::closeWindowSoon):
              (ChromeClientGdk::canTakeFocus):
              (ChromeClientGdk::takeFocus):
              (ChromeClientGdk::canRunBeforeUnloadConfirmPanel):
              (ChromeClientGdk::addMessageToConsole):
              (ChromeClientGdk::runBeforeUnloadConfirmPanel):
              (ChromeClientGdk::runJavaScriptAlert):
              (ChromeClientGdk::runJavaScriptConfirm):
              (ChromeClientGdk::runJavaScriptPrompt):
              (ChromeClientGdk::setStatusbarText):
              (ChromeClientGdk::shouldInterruptJavaScript):
              (ChromeClientGdk::tabsToLinks):
              (ChromeClientGdk::windowResizerRect):
              (ChromeClientGdk::addToDirtyRegion):
              (ChromeClientGdk::scrollBackingStore):
              (ChromeClientGdk::updateBackingStore):
              (PlugInInfoStore::createPluginInfoForPluginAtIndex):
              (PlugInInfoStore::pluginCount):
              (WebCore::PlugInInfoStore::supportsMIMEType):
              (WebCore::refreshPlugins):
              (SearchPopupMenu::saveRecentSearches):
              (SearchPopupMenu::loadRecentSearches):
              (SearchPopupMenu::SearchPopupMenu):
              (PlatformScrollbar::PlatformScrollbar):
              (PlatformScrollbar::~PlatformScrollbar):
              (PlatformScrollbar::setEnabled):
              (PlatformScrollbar::paint):
              (PlatformScrollbar::updateThumbPosition):
              (PlatformScrollbar::updateThumbProportion):
              (PlatformScrollbar::setRect):
              (FileChooser::FileChooser):
              (FileChooser::~FileChooser):
              (FileChooser::openFileChooser):
              (FileChooser::basenameForWidth):
              (ResourceHandle::willLoadFromCache):
              (ResourceHandle::loadsBlocked):
              (ResourceHandle::loadResourceSynchronously):
              (Icon::Icon):
              (Icon::~Icon):
              (Icon::newIconForFile):
              (Icon::paint):
              (Font::drawComplexText):
              (Font::floatWidthForComplexText):
              (Font::offsetForPositionForComplexText):
              (PageCache::close):
              (Editor::ignoreSpelling):
              (Editor::learnSpelling):
              (Editor::isSelectionUngrammatical):
              (Editor::isSelectionMisspelled):
              (Editor::guessesForMisspelledSelection):
              (Editor::guessesForUngrammaticalSelection):
              (Editor::markMisspellingsAfterTypingToPosition):
              (Editor::newGeneralClipboard):
              (Pasteboard::generalPasteboard):
              (Pasteboard::writeSelection):
              (Pasteboard::writeURL):
              (Pasteboard::writeImage):
              (Pasteboard::clear):
              (Pasteboard::canSmartReplace):
              (Pasteboard::documentFragment):
              (Pasteboard::plainText):
              (Pasteboard::Pasteboard):
              (Pasteboard::~Pasteboard):
              (ContextMenu::ContextMenu):
              (ContextMenu::~ContextMenu):
              (ContextMenu::appendItem):
              (ContextMenuItem::ContextMenuItem):
              (ContextMenuItem::~ContextMenuItem):
              (ContextMenuItem::releasePlatformDescription):
              (ContextMenuItem::type):
              (ContextMenuItem::setType):
              (ContextMenuItem::action):
              (ContextMenuItem::setAction):
              (ContextMenuItem::title):
              (ContextMenuItem::setTitle):
              (ContextMenuItem::platformSubMenu):
              (ContextMenuItem::setSubMenu):
              (ContextMenuItem::setChecked):
              (ContextMenuItem::setEnabled):
              (WebCore::supportedKeySizes):
              (WebCore::systemBeep):
              (WebCore::userIdleTime):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19788 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      460dcc6d
  2. 21 Feb, 2007 19 commits
    • staikos's avatar
      Add missing files from last commit · 8f374e18
      staikos authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19787 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8f374e18
    • ggaren's avatar
      LayoutTests: · 22950058
      ggaren authored
              Reviewed by Adam Roben.
              
              Updated results to new, more correct values produced by painting SVGs 
              before dumping their render trees.
      
              * svg/W3C-SVG-1.1/animate-elem-02-t-expected.txt:
              * svg/W3C-SVG-1.1/animate-elem-03-t-expected.txt:
              * svg/W3C-SVG-1.1/animate-elem-04-t-expected.txt:
              * svg/W3C-SVG-1.1/animate-elem-05-t-expected.txt:
              * svg/W3C-SVG-1.1/animate-elem-06-t-expected.txt:
              * svg/W3C-SVG-1.1/animate-elem-07-t-expected.txt:
              * svg/W3C-SVG-1.1/animate-elem-08-t-expected.txt:
              * svg/W3C-SVG-1.1/animate-elem-13-t-expected.txt:
              * svg/W3C-SVG-1.1/animate-elem-14-t-expected.txt:
              * svg/W3C-SVG-1.1/animate-elem-15-t-expected.txt:
              * svg/W3C-SVG-1.1/animate-elem-16-t-expected.txt:
              * svg/W3C-SVG-1.1/animate-elem-17-t-expected.txt:
              * svg/W3C-SVG-1.1/animate-elem-18-t-expected.txt:
              * svg/W3C-SVG-1.1/animate-elem-19-t-expected.txt:
              * svg/W3C-SVG-1.1/animate-elem-20-t-expected.txt:
              * svg/W3C-SVG-1.1/animate-elem-21-t-expected.txt:
              * svg/W3C-SVG-1.1/animate-elem-24-t-expected.txt:
              * svg/W3C-SVG-1.1/animate-elem-29-b-expected.txt:
              * svg/W3C-SVG-1.1/animate-elem-33-t-expected.txt:
              * svg/W3C-SVG-1.1/animate-elem-36-t-expected.txt:
              * svg/W3C-SVG-1.1/animate-elem-39-t-expected.txt:
              * svg/W3C-SVG-1.1/animate-elem-40-t-expected.txt:
              * svg/W3C-SVG-1.1/animate-elem-46-t-expected.txt:
              * svg/W3C-SVG-1.1/animate-elem-77-t-expected.txt:
              * svg/W3C-SVG-1.1/filters-blend-01-b-expected.txt:
              * svg/W3C-SVG-1.1/fonts-elem-02-t-expected.txt:
              * svg/W3C-SVG-1.1/interact-cursor-01-f-expected.txt:
              * svg/W3C-SVG-1.1/interact-events-01-b-expected.txt:
              * svg/W3C-SVG-1.1/linking-uri-01-b-expected.txt:
              * svg/W3C-SVG-1.1/linking-uri-02-b-expected.txt:
              * svg/W3C-SVG-1.1/masking-mask-01-b-expected.txt:
              * svg/W3C-SVG-1.1/masking-path-04-b-expected.txt:
              * svg/W3C-SVG-1.1/metadata-example-01-b-expected.txt:
              * svg/W3C-SVG-1.1/painting-fill-02-t-expected.txt:
              * svg/W3C-SVG-1.1/painting-marker-03-f-expected.txt:
              * svg/W3C-SVG-1.1/pservers-grad-05-b-expected.txt:
              * svg/W3C-SVG-1.1/pservers-grad-08-b-expected.txt:
              * svg/W3C-SVG-1.1/pservers-grad-11-b-expected.txt:
              * svg/W3C-SVG-1.1/render-elems-06-t-expected.txt:
              * svg/W3C-SVG-1.1/render-elems-07-t-expected.txt:
              * svg/W3C-SVG-1.1/render-elems-08-t-expected.txt:
              * svg/W3C-SVG-1.1/script-handle-01-b-expected.txt:
              * svg/W3C-SVG-1.1/struct-frag-06-t-expected.txt:
              * svg/W3C-SVG-1.1/struct-use-01-t-expected.txt:
              * svg/W3C-SVG-1.1/text-align-01-b-expected.txt:
              * svg/W3C-SVG-1.1/text-align-02-b-expected.txt:
              * svg/W3C-SVG-1.1/text-align-03-b-expected.txt:
              * svg/W3C-SVG-1.1/text-align-04-b-expected.txt:
              * svg/W3C-SVG-1.1/text-align-05-b-expected.txt:
              * svg/W3C-SVG-1.1/text-align-06-b-expected.txt:
              * svg/W3C-SVG-1.1/text-altglyph-01-b-expected.txt:
              * svg/W3C-SVG-1.1/text-deco-01-b-expected.txt:
              * svg/W3C-SVG-1.1/text-fonts-01-t-expected.txt:
              * svg/W3C-SVG-1.1/text-fonts-02-t-expected.txt:
              * svg/W3C-SVG-1.1/text-text-01-b-expected.txt:
              * svg/W3C-SVG-1.1/text-text-03-b-expected.txt:
              * svg/W3C-SVG-1.1/text-text-08-b-expected.txt:
              * svg/W3C-SVG-1.1/text-tref-01-b-expected.txt:
              * svg/W3C-SVG-1.1/text-tselect-02-f-expected.txt:
              * svg/W3C-SVG-1.1/text-tspan-01-b-expected.txt:
              * svg/W3C-SVG-1.1/text-ws-01-t-expected.txt:
              * svg/W3C-SVG-1.1/text-ws-02-t-expected.txt:
              * svg/carto.net/button-expected.txt:
              * svg/carto.net/colourpicker-expected.txt:
              * svg/carto.net/combobox-expected.txt:
              * svg/carto.net/scrollbar-expected.txt:
              * svg/carto.net/selectionlist-expected.txt:
              * svg/carto.net/slider-expected.txt:
              * svg/carto.net/tabgroup-expected.txt:
              * svg/carto.net/textbox-expected.txt:
              * svg/carto.net/window-expected.txt:
              * svg/custom/gradient-stop-style-change-expected.txt:
              * svg/custom/js-late-clipPath-and-object-creation-expected.txt:
              * svg/custom/js-late-clipPath-creation-expected.txt:
              * svg/custom/js-late-gradient-and-object-creation-expected.txt:
              * svg/custom/non-opaque-filters-expected.txt:
              * svg/custom/pointer-events-text-expected.txt:
              * svg/custom/text-clip-expected.txt:
              * svg/custom/text-filter-expected.txt:
              * svg/custom/text-image-opacity-expected.txt:
              * svg/custom/text-repaint-including-stroke-expected.txt:
              * svg/custom/use-elementInstance-event-target-expected.txt:
              * svg/custom/use-on-text-expected.txt:
      
      WebKitTools:
      
              Reviewed by Adam Roben.
              
              Added hack to force painting when running an SVG test. This is a work-around
              for http://bugs.webkit.org/show_bug.cgi?id=12849 SVG renderers update at 
              paint time instead of style resolution time.
      
              We need this so that --leaks mode, which always paints, doesn't appear to 
              fail SVG tests. We also need this if we ever want to test style application 
              in SVG, since many SVGs don't apply style to their renderers until they paint.
      
              * Scripts/run-webkit-tests:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19786 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      22950058
    • weinig's avatar
      LayoutTests: · 928874fb
      weinig authored
              Reviewed by Hyatt.
      
              http://bugs.webkit.org/show_bug.cgi?id=12820
              REGRESSION (r19706): Caret not painted after popup, failing editing/pasteboard/4641033
      
              add test for caret before <select> case too
      
              * editing/selection/caret-before-select-expected.checksum: Added.
              * editing/selection/caret-before-select-expected.png: Added.
              * editing/selection/caret-before-select-expected.txt: Added.
              * editing/selection/caret-before-select.html: Added.
      
      WebCore:
      
              Reviewed by Hyatt.
      
              - fix http://bugs.webkit.org/show_bug.cgi?id=12820
              REGRESSION (r19706): Caret not painted after popup, failing editing/pasteboard/4641033
      
              Yet another attempt to figure out exactly who should paint the caret.
      
              * editing/SelectionController.cpp:
              (WebCore::SelectionController::isInsideNode):
              * editing/SelectionController.h:
              * rendering/RenderBlock.cpp:
              (WebCore::RenderBlock::paintCaret):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19785 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      928874fb
    • weinig's avatar
      LayoutTests: · d781c107
      weinig authored
              Reviewed by Hyatt.
      
              - test for http://bugs.webkit.org/show_bug.cgi?id=12818
                REGRESSION (r19148): shacknews.com does not render completely
      
              * fast/dynamic/staticY-marking-parents-regression-expected.checksum: Added.
              * fast/dynamic/staticY-marking-parents-regression-expected.png: Added.
              * fast/dynamic/staticY-marking-parents-regression-expected.txt: Added.
              * fast/dynamic/staticY-marking-parents-regression.html: Added.
      
      WebCore:
      
              Reviewed by Hyatt.
      
              - fix http://bugs.webkit.org/show_bug.cgi?id=12818
                REGRESSION (r19148): shacknews.com does not render completely
      
              Test: fast/dynamic/staticY-marking-parents-regression.html
      
              Changed calls to setChildNeedsLayout(true) during layout to
              setChildNeedsLayout(true, false). Prior to r19148, the default behavior
              of marking containers did not matter because the caller was the container
              and was already marked, but r19148 added marking of the parent of
              objects with static Y, which can be different from the caller and not
              necessarily marked already.
      
              * rendering/RenderBlock.cpp:
              (WebCore::RenderBlock::collapseMargins):
              (WebCore::RenderBlock::clearFloatsIfNeeded):
              (WebCore::RenderBlock::layoutBlockChildren):
              * rendering/RenderBox.cpp:
              (WebCore::RenderBox::setStaticY):
              * rendering/RenderFlexibleBox.cpp:
              (WebCore::RenderFlexibleBox::layoutVerticalBox):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19784 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d781c107
    • beidson's avatar
      Reviewed by Dave Harrison · 626ae61f
      beidson authored
              <rdar://problem/5014313> - Crash in FrameLoader::restoreScrollPositionAndViewState() 
              after regaining network connection
      
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::restoreScrollPositionAndViewState):  Leave an assertion for debug
              build exploration, but gracefully handle the release build case
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19783 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      626ae61f
    • thatcher's avatar
      Rubber-stamped by Darin. · 0a8314e6
      thatcher authored
              * bindings/objc/PublicDOMInterfaces.h: Add missing classes that are really public.
              Also adds the deprecated selector for getComputedStyle: on DOMDocument.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19782 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0a8314e6
    • andersca's avatar
      Add new version with WKCGContextIsBitmapContext. · 9510ca9b
      andersca authored
              
              * WebKitSystemInterface.h:
              * libWebKitSystemInterface.a:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19781 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9510ca9b
    • justing's avatar
      LayoutTests: · e227c905
      justing authored
              Reviewed by john
      
              <rdar://problem/5012665>
              Removing indent from list moves the caret to the line below
      
              No new layout tests needed because the new results
              for these tests and the removed FIXMEs cover the bug fix:
              * editing/execCommand/indent-list-item.html:
              * editing/execCommand/indent-list-item-expected.checksum:
              * editing/execCommand/indent-list-item-expected.png:
              * editing/execCommand/indent-list-item-expected.txt:
              * editing/execCommand/remove-list-1.html:
              * editing/execCommand/remove-list-1-expected.checksum:
              * editing/execCommand/remove-list-1-expected.png:
              * editing/execCommand/remove-list-1-expected.txt:
      
      WebCore:
      
              Reviewed by john
              
              <rdar://problem/5012665>
              Removing indent from list moves the caret to the line below
      
              Selection preservation during indent, outdent and list 
              operations uses rangeFromLocationAndLength.  Ranges returned 
              by rangeFromLocationAndLength were incorrect for locations 
              just before the line breaks that are emitted after blocks.  
              This is because TextIterator emitted bad ranges for these line 
              breaks (ranges that started and ended *after* the block).  
              The fix corrects the start but not the end.  This is acceptible 
              because there is code in rangeFromLocationAndLength that corrects 
              the ends of runs using the start of the run and VisiblePosition 
              creation.
              
              * editing/TextIterator.cpp:
              (WebCore::TextIterator::exitNode): Emit a position *inside* 
              the block, after its contents.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19780 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e227c905
    • ggaren's avatar
      Reduced --leaks mode to running only 750 tests at a time, in the hopes · 42f95c9e
      ggaren authored
              of fixing intermittent crasher that may be caused by out of memory
              conditions.
      
              * Scripts/run-webkit-tests:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19779 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      42f95c9e
    • ggaren's avatar
      Reviewed by Darin Adler. · d34750b7
      ggaren authored
              Made DRT paint when running run-webkit-tests in --leaks mode, to check
              for painting leaks.
      
              * DumpRenderTree/DumpRenderTree.m: Removed some "NO" initializations, since
              that's the default for statics.
              (dumpRenderTree): Added --paint command line option, which specifies that
              DRT should paint at the end of every test.
              (displayWebView): New function, called by dump() and -[LayoutTestController display].
              * Scripts/run-webkit-tests: Use the --paint command line option when checking
              for leaks.
      
              * Scripts/run-webkit-tests: Added a new, painting leak to the ignore list. 
              Removed stale comment about THRD leaks -- we now ignore them reliably.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19778 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d34750b7
    • adele's avatar
      LayoutTests: · 4a00982c
      adele authored
              Reviewed by Darin.
      
              Test for <rdar://problem/4999030> Indexing into select element to get to items in the options collection is broken
      
              * fast/forms/select-index-setter-expected.txt: Added.
              * fast/forms/select-index-setter.html: Added.
      
      WebCore:
      
              Reviewed by Darin.
      
              Fix for <rdar://problem/4999030> Indexing into select element to get to items in the options collection is broken
      
              Test: fast/forms/select-index-setter.html
      
              Added indexSetter for HTMLSelectElement.
      
              * WebCore.xcodeproj/project.pbxproj: Added JSHTMLSelectElementCustom.h
      
              * bindings/js/JSHTMLOptionsCollectionCustom.cpp: (WebCore::JSHTMLOptionsCollection::indexSetter):
                Moved code to selectIndexSetter so it can be shared between these classes.
              * bindings/js/JSHTMLSelectElementCustom.cpp:
              (WebCore::selectIndexSetter): Added.  Moved from JSHTMLOptionsCollection::indexSetter.
              (WebCore::JSHTMLSelectElement::indexSetter): Calls selectIndexSetter.
              * bindings/js/JSHTMLSelectElementCustom.h: Added.
              * html/HTMLSelectElement.idl: Added HasCustomIndexSetter keyword.
      
              * bindings/scripts/CodeGeneratorJS.pm: When generating "put" methods, if the propertyName is a number, call the indexSetter first,
                and then call the version of lookupPut that will also try to use the parent's lookup table.  This matches the order of our
                old code, before we autogenerated the JSHTMLSelectElement class.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19777 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4a00982c
    • ggaren's avatar
      Tools tweak. No review necessary. · e33e2f52
      ggaren authored
              
              * Scripts/parse-malloc-history: Enabled multiple merge-regexp command line
              arguments. Changed command line argument variables from special implicit 
              no-op values to specific empty values that we test explicitly.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19776 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e33e2f52
    • thatcher's avatar
      Reviewed by Tim H. · bf4b6c64
      thatcher authored
              Bug 12834: Drosera should remember scroll position of open files like Xcode
              http://bugs.webkit.org/show_bug.cgi?id=12834
      
              * Drosera/debugger.js: Implemented scrolling memory 
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19775 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bf4b6c64
    • staikos's avatar
      Add undo/redo support and more editing commands. · edba9bc1
      staikos authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19773 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      edba9bc1
    • zack's avatar
      Implementing popups for the Qt platform. · 5478aa73
      zack authored
      r=Lars
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19772 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5478aa73
    • staikos's avatar
      Remove unneeded hack · 3a2f6730
      staikos authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19771 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3a2f6730
    • zack's avatar
      Fix rendering of lineedits and remove the spurious · 4baac737
      zack authored
      padding on push-buttons.
      r=Lars
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19770 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4baac737
    • zack's avatar
      fixing compilation with Qt · 0d340723
      zack authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19769 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0d340723
    • aroben's avatar
      Preemptive build fix. · a4fc72c6
      aroben authored
              * platform/mac/FontCacheMac.mm: Remove unused (and non-existent) header.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19768 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a4fc72c6
  3. 20 Feb, 2007 6 commits
    • aroben's avatar
      Fix the build the right way. · b3f0476c
      aroben authored
              * platform/StringTruncator.cpp:
              (WebCore::truncateString): Keep all widths as floats.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19765 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b3f0476c
    • bdakin's avatar
      WebCore: · ce9e5ea9
      bdakin authored
              Reviewed by Maciej.
      
              Implement writeImage() on Pasteboard so that the context menus can 
              call into the editor for the "Copy image" command instead of 
              calling across the clients.
      
              * WebCore.exp:
              * WebCore.xcodeproj/project.pbxproj:
              * editing/Editor.cpp:
              (WebCore::Editor::copyImage): Call into the Pasteboard.
              * editing/Editor.h:
              * loader/mac/LoaderNSURLExtras.h: A new NSURL extra needed inside 
              WebCore.
              * loader/mac/LoaderNSURLExtras.m: Made this file Objective-C++ 
              (from Objective-C) since the call into the MIMETypeRegistry will 
              return a Vector.
              (urlByRemovingComponent): Cast to build as Obj-C++
              (urlWithDataRelativeToURL): Same.
              (vectorContainsString): Helper.
              (suggestedFilenameWithMIMEType): New function.
              * page/ContextMenuClient.h: Remove copyImageToClipboard()
              * page/ContextMenuController.cpp:
              (WebCore::ContextMenuController::contextMenuItemSelected): Call 
              into the editor instead of the client.
              * page/mac/WebCoreViewFactory.h: New localized String.
              * platform/LocalizedStrings.h: Same.
              * platform/MimeTypeRegistry.h: Expose two additional functions for 
              MIMEType information from WebCore System Interface.
              * platform/Pasteboard.h:
              * platform/SharedBuffer.h: Make platformData() and platformDataSize
              () public since they are needed to write the image to the 
              pasteboard.
              * platform/mac/LocalizedStringsMac.mm: New localized string.
              (WebCore::copyImageUnknownFileLabel):
              * platform/mac/MimeTypeRegistryMac.mm:
              (WebCore::MimeTypeRegistry::getExtensionsForMIMEType):
              (WebCore::MimeTypeRegistry::getPreferredExtensionForMIMEType):
              * platform/mac/PasteboardMac.mm:
              (WebCore::writableTypesForImage):
              (WebCore::Pasteboard::writeURL): Write the correct types if the url 
              is for an image.
              (WebCore::fileWrapperForImage):
              (WebCore::Pasteboard::writeFileWrapperAsRTFDAttachment):
              (WebCore::Pasteboard::writeImage):
              * platform/mac/WebCoreNSStringExtras.h: Added. Some the the 
              NSStringExtras that were in WebKit are now needed by WebCore. To 
              avoid having two copies of these functions, I just moved the 
              implementations to WebCore. The WebKit functions just call into 
              WebCore.
              * platform/mac/WebCoreNSStringExtras.mm: Added.
              (hasCaseInsensitiveSuffix):
              (hasCaseInsensitiveSubstring):
              (filenameByFixingIllegalCharacters):
              * platform/mac/WebCoreSystemInterface.h: 
              wkGetPreferredExtensionForMIMEType and wkGetExtensionsForMIMEType 
              are now needed in WebCore as well as WebKit.
              * platform/mac/WebCoreSystemInterface.mm:
      
      WebKit:
              Reviewed by Maciej.
      
              WebKit changes needed to implement writeImage() in WebCore's 
              Pasteboard class.
      
              * Misc/WebKitNSStringExtras.m: Call into WebCore for these 
              implementations.
              (-[NSString _webkit_hasCaseInsensitiveSuffix:]):
              (-[NSString _webkit_hasCaseInsensitiveSubstring:]):
              (-[NSString _webkit_filenameByFixingIllegalCharacters]):
              * Misc/WebNSURLExtras.m: Same.
              (-[NSURL _webkit_suggestedFilenameWithMIMEType:]):
              * WebCoreSupport/WebContextMenuClient.h: Remove 
              copyImageToClipboard()
              * WebCoreSupport/WebContextMenuClient.mm:
              * WebCoreSupport/WebSystemInterface.m: Expose 
              GetExtensionsForMIMEType and GetPreferredExtensionForMIMEType to 
              WebCore.
              (InitWebCoreSystemInterface):
              * WebCoreSupport/WebViewFactory.mm: New localized string for 
              WebCore. 
              (-[WebViewFactory copyImageUnknownFileLabel]):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19764 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ce9e5ea9
    • aroben's avatar
      Build fix. · 4472e041
      aroben authored
              * platform/StringTruncator.cpp:
              (WebCore::truncateString): Added explicit casts.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19763 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4472e041
    • aroben's avatar
      WebCore: · 0d69a3a5
      aroben authored
              Reviewed by Darin and Anders.
      
              Fix <rdar://problem/4736215> Make WebCoreStringTruncator use WebCore types
      
              * WebCore.exp: Updated symbols.
              * WebCore.xcodeproj/project.pbxproj: Updated file names.
              * bridge/mac/WebCoreStringTruncator.h: Removed.
              * bridge/mac/WebCoreStringTruncator.mm: Removed.
              * platform/StringTruncator.cpp: Added. Moved from bridge/mac/WebCoreStringTruncator.mm.
              (WebCore::textBreakAtOrPreceding): Added.
              (WebCore::boundedTextBreakFollowing): Added.
              (WebCore::centerTruncateToBuffer):
              (WebCore::rightTruncateToBuffer):
              (WebCore::stringWidth): Now takes a const Font& instead of a Font*.
              (WebCore::truncateString):
              (WebCore::StringTruncator::centerTruncate):
              (WebCore::StringTruncator::rightTruncate):
              (WebCore::StringTruncator::width):
              * platform/StringTruncator.h: Added.
              * platform/TextBreakIterator.h: Added isTextBreak declaration.
              * platform/TextBreakIteratorICU.cpp:
              (WebCore::isTextBreak): Implemented.
              * platform/mac/FileChooserMac.mm:
              (WebCore::FileChooser::basenameForWidth): Updated for changes to WebCoreStringTruncator.
              * platform/qt/TextBreakIteratorQt.cpp:
              (WebCore::isTextBreak): Stubbed out.
      
      WebKit:
      
              Reviewed by Darin and Anders.
      
              Update WebKit for WebCore fix for <rdar://problem/4736215> Make
              WebCoreStringTruncator use WebCore types.
      
              * Misc/WebStringTruncator.m:
              (defaultMenuFont): Moved from WebCoreStringTruncator.mm.
              (core): Added.
              (+[WebStringTruncator centerTruncateString:toWidth:]):
              (+[WebStringTruncator centerTruncateString:toWidth:withFont:]):
              (+[WebStringTruncator rightTruncateString:toWidth:withFont:]):
              (+[WebStringTruncator widthOfString:font:]):
              * WebKit.xcodeproj/project.pbxproj: Changed WebStringTruncator to ObjC++.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19762 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0d69a3a5
    • justing's avatar
      LayoutTests: · f8b42635
      justing authored
              Reviewed by harrison
              
              <rdar://problem/5006779>
              REGRESSION: Paste and Match Style of quoted text onto empty line yields quoted text
      
              * editing/pasteboard/5006779-expected.checksum: Added.
              * editing/pasteboard/5006779-expected.png: Added.
              * editing/pasteboard/5006779-expected.txt: Added.
              * editing/pasteboard/5006779.html: Added.
      
      WebCore:
      
              Reviewed by harrison
      
              <rdar://problem/5006779>
              REGRESSION: Paste and Match Style of quoted text onto empty line yields quoted text
              
              We decided to change the copy/paste behavior in both
              the Paste and the Paste and Match Style cases.
      
              * editing/markup.cpp:
              (WebCore::createMarkup): Don't add mail blockquote wrappers
              unless the user selected one or more paragraphs.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19761 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f8b42635
    • thatcher's avatar
      Reviewed by Mark Rowe. · 4d74e76e
      thatcher authored
              <rdar://problem/4912899> WebCore project ObjC @property cleanup
      
              * bindings/objc/DOMObject.h: Add the new style @property
              * bindings/objc/PublicDOMInterfaces.h: Update to the new style @property
              * bindings/scripts/CodeGeneratorObjC.pm: Export both new and old style @properties
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19760 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4d74e76e