1. 16 Nov, 2006 1 commit
    • aroben's avatar
      Build fix. · 85252fc1
      aroben authored
              Rename the items in the ContextMenuAction enum so that they don't
              conflict with WebKit names.
      
              * WebCore.xcodeproj/project.pbxproj:
              * platform/ContextMenu.cpp:
              (WebCore::ContextMenu::populate):
              * platform/ContextMenu.h:
              (WebCore::):
              (WebCore::ContextMenuItem::ContextMenuItem):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17807 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      85252fc1
  2. 15 Nov, 2006 24 commits
    • aroben's avatar
      Reviewed by Anders. · d4284311
      aroben authored
              Change m_contextMenu to an OwnPtr.
      
              * WebCore.xcodeproj/project.pbxproj:
              * page/ContextMenuController.cpp:
              (WebCore::ContextMenuController::handleContextMenuEvent):
              * page/ContextMenuController.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17806 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d4284311
    • aroben's avatar
      WebCore: · 769ddd85
      aroben authored
              Reviewed by Anders.
      
              Add new ContextMenuController and ContextMenuClient classes, and move
              context menu responsibilities from Chrome and ChromeClient to them.
      
              * WebCore.exp:
              * WebCore.xcodeproj/project.pbxproj: Add new files to project, and
              alphabetize some others.
              * page/Chrome.cpp: Remove context menu-related code.
              * page/Chrome.h: Ditto.
              * page/ChromeClient.h:
              * page/ContextMenuClient.h: Added.
              * page/ContextMenuController.cpp: Added.
              (WebCore::ContextMenuController::ContextMenuController):
              (WebCore::ContextMenuController::~ContextMenuController):
              (WebCore::ContextMenuController::handleContextMenuEvent):
              (WebCore::ContextMenuController::contextMenuActionSelected):
              * page/ContextMenuController.h: Added.
              (WebCore::ContextMenuController::client):
              * page/Page.cpp: Every Page now has a ContextMenuController.
              (WebCore::Page::Page):
              * page/Page.h: Made m_dragCaretController and m_chrome objects instead
              of pointers to objects.
              (WebCore::Page::contextMenuController):
              * platform/ContextMenu.cpp:
              (WebCore::ContextMenu::populate): Removed the call to Chrome to ask the
              delegate to add its menu items, and moved the code from the static
              addDefaultItems function into this method.
              * platform/ContextMenu.h:
              (WebCore::ContextMenu::show): Added an empty method body since this
              method is now called from ContextMenuController (although no one calls
              into ContextMenuController yet, so it's OK for this to be empty).
              (WebCore::ContextMenu::hide): Ditto.
      
      WebKit:
      
              Reviewed by Anders.
      
              Added new WebContextMenuClient class to act as WebCore's ChromeClient,
              and moved context menu-related code there from WebChromeClient.
      
              * WebCoreSupport/WebChromeClient.h:
              * WebCoreSupport/WebChromeClient.mm:
              * WebCoreSupport/WebContextMenuClient.h: Added.
              (WebContextMenuClient::webView):
              * WebCoreSupport/WebContextMenuClient.mm: Added.
              (WebContextMenuClient::create):
              (WebContextMenuClient::WebContextMenuClient):
              (WebContextMenuClient::ref):
              (WebContextMenuClient::deref):
              (WebContextMenuClient::addCustomContextMenuItems):
              * WebKit.xcodeproj/project.pbxproj: Added new files.
              * WebView/WebView.mm:
              (-[WebView _commonInitializationWithFrameName:groupName:]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17805 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      769ddd85
    • thatcher's avatar
      Removing this assert until I can look into the problem further. · 2bfb171a
      thatcher authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17804 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2bfb171a
    • andersca's avatar
      Reviewed by Darin. · 10aa5f38
      andersca authored
              Add null checks on the node filter, they can be null if no filter was passed to the respective
              create functions.
              
              * bindings/js/JSNodeIteratorCustom.cpp:
              (WebCore::JSNodeIterator::mark):
              * bindings/js/JSTreeWalkerCustom.cpp:
              (WebCore::JSTreeWalker::mark):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17803 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      10aa5f38
    • oliver's avatar
      2006-11-15 Oliver Hunt <oliver@apple.com> · 4bf59f75
      oliver authored
              Reviewed by Anders.
      
              Allow <embed> and <object> tags to include non-plugin
              content when plugins are disabled
      
              Fixes <rdar://problems/4839488>
      
              * html/HTMLEmbedElement.cpp:
              (WebCore::HTMLEmbedElement::rendererIsNeeded):
              * html/HTMLObjectElement.cpp:
              (WebCore::HTMLObjectElement::rendererIsNeeded):
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::requestObject):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17802 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4bf59f75
    • adele's avatar
      Build fix. Another type problem that I don't see locally. · e8e736d9
      adele authored
              * rendering/RenderSlider.cpp: (WebCore::RenderSlider::setPositionFromValue):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17801 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e8e736d9
    • adele's avatar
      Reviewed by Adam. · a3f389cd
      adele authored
              Adding MathExtras header.
      
              * rendering/RenderSlider.cpp:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17800 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a3f389cd
    • thatcher's avatar
      Reviewed by Harrison. · 8faa90ab
      thatcher authored
              <rdar://problem/4832894> Crash deleting an element inside a list while deletion rectangle is visible (compareBoundaryPoints)
      
              * Disable and hide the deletion UI for each editing command. This prevents editing commands from being affected
                by the deletion UI elements we insert. The deletion UI is then shown after the editing commands are completely done.
      
              * Multiple calls to DeleteButtonController's disable() needed to be paired with the same number of enable() calls before
                the deletion UI is enabled again. This allows for nested editing commands to be called without thrashing the deletion UI.
      
              * Make sure the the renderers are currently reflecting the latest style changes, so call updateLayoutIgnorePendingStylesheets().
      
              * editing/DeleteButtonController.cpp:
              (WebCore::DeleteButtonController::DeleteButtonController):
              (WebCore::isDeletableElement):
              (WebCore::DeleteButtonController::respondToChangedSelection): check the enabled state
              (WebCore::DeleteButtonController::respondToChangedContents): check the enabled state
              (WebCore::DeleteButtonController::show): call isDeletableElement() to make sure the element is allowed
              (WebCore::DeleteButtonController::deleteTarget): check the enabled state
              * editing/DeleteButtonController.h:
              (WebCore::DeleteButtonController::disable):
              (WebCore::DeleteButtonController::enable):
              (WebCore::DeleteButtonController::enabled):
              * editing/EditCommand.cpp:
              (WebCore::EditCommand::apply): hide and disable the deletion UI, then show at the end
              (WebCore::EditCommand::unapply): ditto
              (WebCore::EditCommand::reapply): ditto
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17799 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8faa90ab
    • adele's avatar
      LayoutTests: · 6125f889
      adele authored
              Reviewed by Adam.
      
              Updating results for new slider implementation.
      
              * fast/forms/input-appearance-height-expected.checksum:
              * fast/forms/input-appearance-height-expected.png:
              * fast/forms/input-appearance-height-expected.txt:
      
      WebCore:
      
              Reviewed by Adam.
      
              New implementation of slider control.
      
              * WebCore.xcodeproj/project.pbxproj: Removed DeprecatedSlider and Slider classes, added RenderSlider class.
              * rendering/DeprecatedSlider.cpp: Removed.
              * rendering/DeprecatedSlider.h: Removed.
              * platform/Slider.h: Removed.
              * platform/mac/SliderMac.mm: Removed.
              * platform/win/TemporaryLinkStubs.cpp:
      
              * css/CSSSelector.h: (WebCore::CSSSelector::): Added PseudoElement for thumb, PseudoSliderThumb.
              * css/CSSSelector.cpp: (WebCore::CSSSelector::extractPseudoType): Added code for "-webkit-slider-thumb".
              * css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::checkOneSelector): 
              * rendering/RenderStyle.cpp:
              (WebCore::):
              (WebCore::pseudoBit):
              * rendering/RenderStyle.h: (WebCore::RenderStyle::):
      
              * css/html4.css: Added style for input[type="range"] and input[type="range"]::-webkit-slider-thumb
      
              * html/HTMLInputElement.cpp:
              (WebCore::HTMLInputElement::createRenderer): Create RenderSlider for input type="range" elements.
              (WebCore::HTMLInputElement::defaultEventHandler): Allow the renderer to forward events, and set thumb position when click occurs on the track.
      
              * page/EventHandler.cpp:  Added concept of a node that will capture all mouse events.  This will be used by the slider thumb, so it can
                continue to capture mouse move events during the drag, even though those events aren't directly over the slider.
              (WebCore::EventHandler::EventHandler):
              (WebCore::EventHandler::setCapturingMouseEventsNode):
              (WebCore::EventHandler::dispatchMouseEvent): If the capturingMouseEventsNode is set, then dispatch all mouse events to that node.
              * page/EventHandler.h:
      
              * rendering/RenderSlider.cpp: Added.
              (WebCore::HTMLSliderThumbElement::isShadowNode):
              (WebCore::HTMLSliderThumbElement::shadowParentNode):
              (WebCore::HTMLSliderThumbElement::inDragMode): Keeps track of whether or not the thumb is in drag mode.
              (WebCore::HTMLSliderThumbElement::HTMLSliderThumbElement):
              (WebCore::HTMLSliderThumbElement::defaultEventHandler): Handles positioning of slider thumb during drag.
              (WebCore::RenderSlider::RenderSlider):
              (WebCore::RenderSlider::~RenderSlider):
              (WebCore::RenderSlider::baselinePosition):
              (WebCore::RenderSlider::calcMinMaxWidth):
              (WebCore::RenderSlider::setStyle):
              (WebCore::RenderSlider::createThumbStyle):
              (WebCore::RenderSlider::layout): Positions the thumb to be centered on the track.
              (WebCore::RenderSlider::updateFromElement):
              (WebCore::RenderSlider::mouseEventIsInThumb):
              (WebCore::RenderSlider::setValueForPosition):
              (WebCore::RenderSlider::setPositionFromValue):
              (WebCore::RenderSlider::positionForOffset):
              (WebCore::RenderSlider::valueChanged):
              (WebCore::RenderSlider::currentPosition):
              (WebCore::RenderSlider::setCurrentPosition):
              (WebCore::RenderSlider::trackSize):
              (WebCore::RenderSlider::forwardEvent):
              (WebCore::RenderSlider::inDragMode):
              * rendering/RenderSlider.h: Added.
              (WebCore::RenderSlider::renderName):
      
               * rendering/RenderTheme.cpp: Added drawing code for slider track and thumb.
              (WebCore::RenderTheme::adjustStyle):
              (WebCore::RenderTheme::paint):
              (WebCore::RenderTheme::paintBorderOnly):
              (WebCore::RenderTheme::paintDecorations):
              (WebCore::RenderTheme::adjustSliderTrackStyle):
              (WebCore::RenderTheme::adjustSliderThumbStyle):
              * rendering/RenderTheme.h:
              (WebCore::RenderTheme::paintSliderTrack):
              (WebCore::RenderTheme::paintSliderThumb):
              * rendering/RenderThemeMac.h:
              * rendering/RenderThemeMac.mm:
              (WebCore::RenderThemeMac::RenderThemeMac):
              (WebCore::TrackGradientInterpolate):
              (WebCore::RenderThemeMac::paintSliderTrack):
              (WebCore::RenderThemeMac::paintSliderThumb):
              (WebCore::RenderThemeMac::adjustSliderTrackStyle):
              (WebCore::RenderThemeMac::adjustSliderThumbStyle):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17798 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6125f889
    • bdakin's avatar
      Reviewed by Adam. · 64433ed4
      bdakin authored
              Oops! Forgot to add this!
      
              * platform/mac/ContextMenuMac.mm: Added.
              (-[MenuTarget forwardContextMenuAction:initWithContextMenu:WebCore::]):
              (-[MenuTarget WebCore::]):
              (-[MenuTarget setMenu:WebCore::]):
              (-[MenuTarget forwardContextMenuAction:]):
              (getNSMenuItem):
              (ContextMenu::appendItem):
              (ContextMenu::itemCount):
              (ContextMenu::insertItem):
              (ContextMenu::setPlatformMenuDescription):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17797 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      64433ed4
    • bdakin's avatar
      WebCore: · e51edec3
      bdakin authored
              Reviewed by Adam and Beth.
      
              Initial cut at pushing Context Menus into WebCore. Nobody actually 
              calls this code just yet.
      
              * WebCore.exp:
              * WebCore.xcodeproj/project.pbxproj:
              * page/Chrome.cpp:
              (WebCore::Chrome::addCustomContextMenuItems): Use the chrome to 
              call into addContextMenuItems on the UIDelegate.
              * page/Chrome.h:
              * page/ChromeClient.h:
              * platform/ContextMenu.cpp: Added.
              (WebCore::addDefaultItems):
              (WebCore::ContextMenu::populate):
              * platform/ContextMenu.h: Added.
              (WebCore::):
              (WebCore::ContextMenuItem::ContextMenuItem):
              (WebCore::ContextMenu::ContextMenu):
              (WebCore::ContextMenu::hitTestResult):
              (WebCore::ContextMenu::platformMenuDescription):
      
      WebKit:
              Reviewed by Adam & Beth.
      
              WebKit side of first cut at engine context menus. Use the client to 
              call into the UIDelegate.
      
              * WebCoreSupport/WebChromeClient.h:
              * WebCoreSupport/WebChromeClient.mm:
              (WebChromeClient::addCustomContextMenuItems):
              * WebKit.xcodeproj/project.pbxproj:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17796 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e51edec3
    • beidson's avatar
      Reviewed by Maciej · 71cff20e
      beidson authored
              Quick change of files to ObjC++ for BF cache re-write
      
              * History/WebBackForwardList.m: Removed.
              * History/WebBackForwardList.mm: Added.
              * History/WebHistoryItem.m: Removed.
              * History/WebHistoryItem.mm: Added.
              * WebKit.xcodeproj/project.pbxproj:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17795 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      71cff20e
    • adele's avatar
      Reviewed by Hyatt. · 41a422e4
      adele authored
              - Fix for <rdar://problem/4780306> REGRESSION: clicking in textarea does not set selection at PunBB.org
      
              * css/html4.css: Removed "-webkit-user-select: ignore" for labels.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17794 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      41a422e4
    • beidson's avatar
      Reviewed by Sarge · 6e7b7337
      beidson authored
              SPI addition
      
              * WebView/WebFrame.mm:
              (-[WebFrame _recursive_resumeNullEventsForAllNetscapePlugins]):
              * WebView/WebFrameInternal.h:
              * WebView/WebFramePrivate.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17792 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6e7b7337
    • beidson's avatar
      Reviewed by Adele · 326a8839
      beidson authored
              <rdar://problem/4838729> - Replace mistakenly removed SPI
      
              * WebView/WebHTMLView.m:
              (-[WebHTMLView _handleAutoscrollForMouseDragged:]):
              * WebView/WebHTMLViewPrivate.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17788 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      326a8839
    • thatcher's avatar
    • harrison's avatar
      Reviewed by Darin. · 8d649c34
      harrison authored
              <rdar://problem/4836034> REGRESSION: Hang while spell-checking (advanceToNextMisspelling)
      
              Test:
              * manual-tests/keep_spelling_markers.html:
              Updated to include checking for this bug.
              
              * bridge/mac/FrameMac.mm:
              (WebCore::FrameMac::advanceToNextMisspelling):
              it.advance() even when current string is a single space.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17786 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8d649c34
    • beidson's avatar
      Reviewed by lamadio · 118a6000
      beidson authored
              Backing out macro expansion
      
              * WebCore.xcodeproj/project.pbxproj:
              * html/HTMLElement.cpp:
              (WebCore::HTMLElement::isRecognizedTagName):
              * ksvg2/scripts/make_names.pl:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17785 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      118a6000
    • harrison's avatar
      Reviewed by Darin. · 1f563446
      harrison authored
              <rdar://problem/4770453> VO not honoring secure edit fields in web pages
      
              The remaining problem was the password fields would return their contents
              even though they did not advertise that they could. Apparently, VoiceOver
              does not read the ads.
      
              * bridge/mac/WebCoreAXObject.mm:
              (isPasswordFieldElement):
              (-[WebCoreAXObject isPasswordField]):
              (-[WebCoreAXObject textMarkerForVisiblePosition:]):
              (-[WebCoreAXObject accessibilityAttributeValue:]):
              (-[WebCoreAXObject doAXStringForRange:]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17784 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1f563446
    • lamadio's avatar
      2006-11-13 Lou Amadio <lamadio@apple.com> · 4874174d
      lamadio authored
              Reviewed by Darin Adler, Maciej Stachowiak
      
              Cleanup: Expanded macros in generated files
      
              * html/HTMLElement.cpp:
              (WebCore::HTMLElement::isRecognizedTagName):
              * ksvg2/scripts/make_names.pl:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17783 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4874174d
    • andersca's avatar
      Reviewed by Geoff. · de562ef3
      andersca authored
              Use Vector instead of DeprecatedPtrList.
              
              * editing/ApplyStyleCommand.cpp:
              (WebCore::ApplyStyleCommand::applyBlockStyle):
              * editing/BreakBlockquoteCommand.cpp:
              * rendering/RenderFlow.cpp:
              (WebCore::RenderFlow::paintOutline):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17782 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      de562ef3
    • andersca's avatar
      Reviewed by Adele. · 96ef3db1
      andersca authored
              isTargetItem is used by DRT, so make it private instead of internal.
              
              * History/WebHistoryItem.m:
              (-[WebHistoryItem isTargetItem]):
              * History/WebHistoryItemInternal.h:
              * History/WebHistoryItemPrivate.h:
              * WebCoreSupport/WebFrameLoaderClient.mm:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17781 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      96ef3db1
    • aroben's avatar
      Build fix. · ffcc3860
      aroben authored
              * page/EventHandler.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17780 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ffcc3860
    • beidson's avatar
      Reviewed by Maciej · c5d05dd0
      beidson authored
              Split much of unused WebHistoryItemPrivate.h SPI into WebHistoryItemInternal.h
      
              * History/WebBackForwardList.m:
              * History/WebHistory.m:
              * History/WebHistoryItem.m:
              (-[WebHistoryItem initWithURLString:title:lastVisitedTimeInterval:]):
              (-[WebHistoryItem initWithURL:title:]):
              (-[WebHistoryItem visitCount]):
              (-[WebHistoryItem RSSFeedReferrer]):
              (-[WebHistoryItem setRSSFeedReferrer:]):
              (-[WebHistoryItem children]):
              (-[WebHistoryItem dictionaryRepresentation]):
              (-[WebHistoryItem setAlwaysAttemptToUsePageCache:]):
              (+[WebHistoryItem _releaseAllPendingPageCaches]):
              (-[WebHistoryItem URL]):
              (-[WebHistoryItem target]):
              (-[WebHistoryItem _setLastVisitedTimeInterval:]):
              (-[WebHistoryItem _lastVisitedDate]):
              (-[WebHistoryItem targetItem]):
              * History/WebHistoryItemInternal.h: Added.
              * History/WebHistoryItemPrivate.h:
              * WebCoreSupport/WebFrameBridge.mm:
              * WebCoreSupport/WebFrameLoaderClient.mm:
              * WebKit.xcodeproj/project.pbxproj:
              * WebView/WebFrame.mm:
              * WebView/WebView.mm:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17779 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c5d05dd0
  3. 14 Nov, 2006 15 commits
    • bdash's avatar
      2006-11-14 Matt Lilek <pewtermoose@gmail.com> · 5b27d268
      bdash authored
              Reviewed by Tim Hatcher.
      
              Moved the web developer page to the wiki, adding link to the Drosera page.
      
              * .htaccess: Add permanent redirect to the new page on the wiki.
              * contact.html: Trac numbers are no longer one off.
              * nav.inc:
              * webdevelopers/index.html: Removed.
              * webdevelopers/webkit_version.html: Removed.
              * webdevelopers/webkit_version.js: Removed.
              * webdevelopers/webkit_version_xl.html: Removed.
              * webdevelopers/webkit_version_xl.js: Removed.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17778 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5b27d268
    • bdakin's avatar
      WebCore: · 6c70b48d
      bdakin authored
              Reviewed by Geoff.
      
              Moving things off the bridge and onto clients.
      
              * WebCoreSupport/WebEditorClient.h:
              * WebCoreSupport/WebEditorClient.mm:
              (WebEditorClient::selectWordBeforeMenuEvent):
              (WebEditorClient::isEditable):
              * WebCoreSupport/WebFrameBridge.mm:
              * WebKit.xcodeproj/project.pbxproj:
      
      WebKit:
              Reviewed by Geoff.
      
              Move things off the bridge, and move sendContextMenuEvent() from 
              EventHandlerMac to EventHandler.
      
              * WebCore.exp:
              * WebCore.xcodeproj/project.pbxproj:
              * bridge/EditorClient.h:
              * bridge/mac/WebCoreFrameBridge.h:
              * editing/Editor.cpp:
              (WebCore::Editor::selectWordBeforeMenuEvent):
              (WebCore::Editor::clientIsEditable):
              * editing/Editor.h:
              * page/EventHandler.cpp:
              (WebCore::EventHandler::sendContextMenuEvent):
              * page/EventHandler.h:
              * page/mac/EventHandlerMac.mm:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17777 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6c70b48d
    • thatcher's avatar
      WebCore: · c5c8ec65
      thatcher authored
              Reviewed by Harrison.
      
              <rdar://problem/4766635> Safari should never follow links in editable areas (add a WebKitEditableLinkNeverLive option)
      
              Adds an EditableLinkNeverLive setting that will make links in editable areas always dead.
      
              * bridge/mac/WebCoreSettings.mm:
              (-[WebCoreSettings setEditableLinkBehavior:]):
              * html/HTMLAnchorElement.cpp:
              (WebCore::HTMLAnchorElement::defaultEventHandler):
              (WebCore::HTMLAnchorElement::setActive):
              (WebCore::HTMLAnchorElement::isLiveLink):
              * page/FrameView.cpp:
              (WebCore::selectCursor):
              * page/Settings.h:
              (WebCore::Settings::):
      
      WebKit:
      
              Reviewed by Harrison.
      
              <rdar://problem/4766635> Safari should never follow links in editable areas (add a WebKitEditableLinkNeverLive option)
      
              Adds an Open Link, Open Link in New Window and Copy Link to the editing context menu.
              Adds a new WebKitEditableLinkNeverLive preference value that maps to WebCore's EditableLinkNeverLive.
      
              * DefaultDelegates/WebDefaultContextMenuDelegate.m:
              (-[WebDefaultUIDelegate menuItemWithTag:target:representedObject:]):
              (-[WebDefaultUIDelegate contextMenuItemsForElement:defaultMenuItems:]):
              (-[WebDefaultUIDelegate editingContextMenuItemsForElement:defaultMenuItems:]):
              (-[WebDefaultUIDelegate requestWithURL:includingReferrerFromFrame:]):
              (-[WebDefaultUIDelegate openNewWindowWithURL:element:]):
              (-[WebDefaultUIDelegate openLink:]):
              * English.lproj/Localizable.strings:
              * WebKit.exp:
              * WebView/WebPreferences.m:
              (-[WebPreferences editableLinkBehavior]):
              * WebView/WebPreferencesPrivate.h:
              * WebView/WebUIDelegatePrivate.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17776 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c5c8ec65
    • oliver's avatar
      2006-11-14 Mark Rowe <bdash@webkit.org> · 70231ac7
      oliver authored
              Reviewed by Oliver.
      
              Build fix
      
              * bindings/scripts/CodeGenerator.pm:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17775 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      70231ac7
    • andersca's avatar
      WebCore: · 763bf864
      andersca authored
              Turns out I wasn't forcing DWARF on the world at all, 
              it's now the default!
      
              * WebCore.xcodeproj/project.pbxproj:
      
      WebKit:
      
              Turns out I wasn't forcing DWARF on the world at all, 
              it's now the default!
      
              * WebKit.xcodeproj/project.pbxproj:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17774 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      763bf864
    • andersca's avatar
      WebCore: · 41024cea
      andersca authored
              I must stop trying to force DWARF on the world.
              
              * WebCore.xcodeproj/project.pbxproj:
      
      WebKit:
      
              I must stop trying to force DWARF on the world.
      
              * WebKit.xcodeproj/project.pbxproj:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17773 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      41024cea
    • justing's avatar
      LayoutTests: · 34a4dd57
      justing authored
              Reviewed by harrison
              
              <rdar://problem/4806874>
              Missing background image after paste
      
              Checking in new expected results for fixes:
              * editing/inserting/insert-3851164-fix-expected.checksum:
              * editing/inserting/insert-3851164-fix-expected.png:
              * editing/selection/drag-in-iframe-expected.checksum:
              * editing/selection/drag-in-iframe-expected.png:
      
              Same, but also removing an outdated comment about a bug:
              * editing/pasteboard/paste-text-019-expected.checksum:
              * editing/pasteboard/paste-text-019-expected.png:
              * editing/pasteboard/paste-text-019-expected.txt:
              * editing/pasteboard/paste-text-019.html:
              
              Added:
              * editing/pasteboard/4806874-expected.checksum: Added.
              * editing/pasteboard/4806874-expected.png: Added.
              * editing/pasteboard/4806874-expected.txt: Added.
              * editing/pasteboard/4806874.html: Added.
              
              Equivalent render trees:        
              * editing/inserting/insert-3907422-fix-expected.txt:
              * editing/pasteboard/paste-text-011-expected.txt:
              * editing/pasteboard/paste-text-015-expected.txt:
      
      WebCore:
      
              Reviewed by harrison
              
              <rdar://problem/4806874>
              Missing background image after paste
              
              * editing/markup.cpp:
              (WebCore::createMarkup): If the body is fully selected, add a 
              div with its CSS properties to the markup.  Migrated a use of 
              enclosingBlockFlowElement to enclosingBlock to fix an infinite 
              loop when pasting <div><input></div>.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17772 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      34a4dd57
    • andersca's avatar
      2006-11-14 Anders Carlsson <acarlsson@apple.com> · e8bbc94f
      andersca authored
              Reviewed by Adam.
      
              Add Undo/Redo to execCommand.
              
              * editing/Editor.cpp:
              (WebCore::execRedo):
              (WebCore::execUndo):
              (WebCore::canRedo):
              (WebCore::canUndo):
              (WebCore::CommandEntry::):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17771 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e8bbc94f
    • darin's avatar
      WebCore: · 60e537f5
      darin authored
              Reviewed by Anders.
      
              - created EventHandler class, moved event handling code from both
                Frame and FrameView in there
      
              - added ScrollTypes.h header so you can include the scroller-related
                enums without all of Scrollbar.h
      
              * page/EventHandler.cpp: Added.
              * page/EventHandler.h: Added.
              * page/mac/EventHandlerMac.mm: Added.
      
              * platform/ScrollBarMode.h: Removed.
              * platform/ScrollTypes.h: Added.
      
              * WebCore.exp:
              * WebCore.xcodeproj/project.pbxproj:
              * bridge/mac/FrameMac.h:
              * bridge/mac/FrameMac.mm:
              (WebCore::FrameMac::FrameMac):
              (WebCore::FrameMac::~FrameMac):
              (WebCore::FrameMac::bridgeForWidget):
              (WebCore::FrameMac::imageFromRect):
              * bridge/mac/FrameViewMac.mm:
              * bridge/mac/WebCoreFrameBridge.mm:
              (-[WebCoreFrameBridge scrollOverflowInDirection:granularity:]):
              (-[WebCoreFrameBridge nextKeyView]):
              (-[WebCoreFrameBridge previousKeyView]):
              (-[WebCoreFrameBridge nextKeyViewInsideWebFrameViews]):
              (-[WebCoreFrameBridge previousKeyViewInsideWebFrameViews]):
              (-[WebCoreFrameBridge _visiblePositionForPoint:]):
              (-[WebCoreFrameBridge dragOperationForDraggingInfo:]):
              (-[WebCoreFrameBridge dragExitedWithDraggingInfo:]):
              (-[WebCoreFrameBridge concludeDragForDraggingInfo:]):
              (-[WebCoreFrameBridge dragSourceMovedTo:]):
              (-[WebCoreFrameBridge dragSourceEndedAt:operation:]):
              * dom/Document.cpp:
              (WebCore::Document::hoveredNodeDetached):
              * dom/Element.h:
              * dom/EventTargetNode.cpp:
              (WebCore::EventTargetNode::defaultEventHandler):
              * editing/SelectionController.cpp:
              (WebCore::SelectionController::SelectionController):
              * editing/SelectionController.h:
              (WebCore::SelectionController::setCaretBlinkingSuspended):
              (WebCore::SelectionController::isCaretBlinkingSuspended):
              * html/HTMLAnchorElement.cpp:
              (WebCore::HTMLAnchorElement::isKeyboardFocusable):
              * html/HTMLFrameElementBase.cpp:
              (WebCore::HTMLFrameElementBase::setFocus):
              * html/HTMLFrameElementBase.h:
              * html/HTMLGenericFormElement.cpp:
              (WebCore::HTMLGenericFormElement::isKeyboardFocusable):
              * html/HTMLInputElement.cpp:
              (WebCore::HTMLInputElement::defaultEventHandler):
              * html/HTMLSelectElement.cpp:
              (WebCore::HTMLSelectElement::listBoxDefaultEventHandler):
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::clear):
              (WebCore::FrameLoader::open):
      
              * page/Frame.cpp:
              (WebCore::Frame::caretBlinkTimerFired):
              (WebCore::Frame::frameForWidget):
              (WebCore::Frame::eventHandler):
              (WebCore::Frame::setProhibitsScrolling):
              (WebCore::FramePrivate::FramePrivate):
              * page/Frame.h:
              * page/FramePrivate.h:
              * page/FrameView.cpp:
              (WebCore::FrameViewPrivate::FrameViewPrivate):
              (WebCore::FrameViewPrivate::reset):
              (WebCore::FrameView::FrameView):
              (WebCore::FrameView::~FrameView):
              (WebCore::FrameView::clear):
              (WebCore::FrameView::adjustViewSize):
              (WebCore::FrameView::addRepaintInfo):
              (WebCore::FrameView::layout):
              (WebCore::FrameView::scrollPointRecursively):
              (WebCore::FrameView::setContentsPos):
              (WebCore::FrameView::scheduleRelayoutOfSubtree):
              (WebCore::FrameView::scheduleEvent):
              (WebCore::FrameView::updateOverflowStatus):
              (WebCore::FrameView::dispatchScheduledEvents):
              (WebCore::FrameView::windowClipRectForLayer):
              (WebCore::FrameView::handleMouseMoveEvent):
              (WebCore::FrameView::handleMouseReleaseEvent):
              * page/FrameView.h:
              * page/PageState.cpp:
              (WebCore::PageState::PageState):
              (WebCore::PageState::restore):
              * page/PageState.h:
              * platform/ScrollBar.h:
              * platform/ScrollView.h:
              * platform/mac/ClipboardMac.mm:
              * platform/mac/PopupMenuMac.mm:
              (WebCore::PopupMenu::show):
              * platform/mac/SliderMac.mm:
              (-[WebCoreSlider becomeFirstResponder]):
              (-[WebCoreSlider nextKeyView]):
              (-[WebCoreSlider previousKeyView]):
              (-[WebCoreSlider canBecomeKeyView]):
              (Slider::focusPolicy):
              * platform/mac/WebCoreTextField.mm:
              (-[WebCoreTextFieldController textView:shouldHandleEvent:]):
              (-[WebCoreTextFieldController setHasFocus:]):
              (-[WebCoreSearchField nextKeyView]):
              (-[WebCoreSearchField previousKeyView]):
              (-[WebCoreSearchFieldCell _addStringToRecentSearches:]):
              * platform/mac/WidgetMac.mm:
              (WebCore::Widget::hasFocus):
              (WebCore::Widget::clearFocus):
              * rendering/RenderFrameSet.cpp:
              (WebCore::RenderFrameSet::setResizing):
              * rendering/RenderLayer.cpp:
              (WebCore::RenderLayer::autoscroll):
              (WebCore::RenderLayer::resize):
              (WebCore::RenderLayer::updateOverflowStatus):
              * rendering/RenderLayer.h:
              * rendering/RenderListBox.cpp:
              (WebCore::RenderListBox::autoscroll):
              * rendering/RenderObject.cpp:
              (WebCore::RenderObject::draggableNode):
              (WebCore::RenderObject::destroy):
              * rendering/RenderObject.h:
              (WebCore::RenderObject::RepaintInfo::RepaintInfo):
              * rendering/RenderPartObject.cpp:
              (WebCore::RenderPartObject::viewCleared):
      
      WebKit:
      
              Reviewed by Anders.
      
              - update for creation of EventHandler
      
              * WebCoreSupport/WebFrameLoaderClient.mm:
              (WebFrameLoaderClient::actionDictionary):
              * WebView/WebHTMLView.m:
              (-[WebHTMLView _updateMouseoverWithEvent:]):
              (-[NSArray menuForEvent:]):
              (-[NSArray scrollWheel:]):
              (-[NSArray acceptsFirstMouse:]):
              (-[NSArray shouldDelayWindowOrderingForEvent:]):
              (-[NSArray mouseDown:]):
              (-[NSArray mouseDragged:]):
              (-[NSArray mouseUp:]):
              (-[NSArray keyDown:]):
              (-[NSArray keyUp:]):
              (-[NSArray performKeyEquivalent:]):
              (-[WebHTMLView elementAtPoint:allowShadowContent:]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17770 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      60e537f5
    • andersca's avatar
      Fix build for real this time. · 1d234aeb
      andersca authored
              
              * WebCoreSupport/WebEditorClient.mm:
              (-[WebEditCommand initWithEditCommand:WebCore::]):
              (-[WebEditCommand dealloc]):
              (-[WebEditCommand finalize]):
              (+[WebEditCommand commandWithEditCommand:]):
              (-[WebEditCommand command]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17769 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1d234aeb
    • andersca's avatar
      2006-11-14 Anders Carlsson <acarlsson@apple.com> · e31b6213
      andersca authored
              Try fixing the build.
              
              * WebCoreSupport/WebEditorClient.mm:
              (-[WebEditorUndoTarget undoEditing:]):
              (-[WebEditorUndoTarget redoEditing:]):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17768 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e31b6213
    • andersca's avatar
      WebCore: · f623201a
      andersca authored
              Reviewed by Darin.
      
              Let the editor client handle undo/redo.
              
              * WebCore.exp:
              * WebCore.xcodeproj/project.pbxproj:
              * bridge/EditorClient.h:
              * bridge/mac/FrameMac.h:
              * bridge/mac/FrameMac.mm:
              (WebCore::FrameMac::canUndo):
              (WebCore::FrameMac::canRedo):
              * bridge/mac/WebCoreEditCommand.h: Removed.
              * bridge/mac/WebCoreEditCommand.mm: Removed.
              * bridge/mac/WebCoreFrameBridge.h:
              * bridge/mac/WebCoreFrameBridge.mm:
              * editing/Editor.cpp:
              (WebCore::Editor::appliedEditing):
              (WebCore::Editor::unappliedEditing):
              (WebCore::Editor::reappliedEditing):
              * editing/JSEditor.cpp:
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::closeURL):
              * page/Frame.cpp:
              * page/Frame.h:
              * rendering/RenderTextControl.cpp:
              (WebCore::RenderTextControl::updateFromElement):
      
      WebKit:
      
              Reviewed by Darin.
      
              Move undo/redo handling into WebEditorClient.
              
              * WebCoreSupport/WebEditorClient.h:
              * WebCoreSupport/WebEditorClient.mm:
              (WebEditorClient::WebEditorClient):
              (WebEditorClient::~WebEditorClient):
              (-[WebEditCommand initWithEditCommand:WebCore::]):
              (-[WebEditCommand dealloc]):
              (-[WebEditCommand finalize]):
              (+[WebEditCommand commandWithEditCommand:]):
              (-[WebEditCommand command]):
              (-[WebEditorUndoTarget undoEditing:]):
              (-[WebEditorUndoTarget redoEditing:]):
              (undoNameForEditAction):
              (WebEditorClient::registerCommandForUndoOrRedo):
              (WebEditorClient::registerCommandForUndo):
              (WebEditorClient::registerCommandForRedo):
              (WebEditorClient::clearUndoRedoOperations):
              (WebEditorClient::canUndo):
              (WebEditorClient::canRedo):
              (WebEditorClient::undo):
              (WebEditorClient::redo):
              * WebCoreSupport/WebFrameBridge.mm:
              * WebKit.xcodeproj/project.pbxproj:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17767 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f623201a
    • beidson's avatar
      Reviewed and landed by Brady · 7965b895
      beidson authored
              Fix Qt/Linux build.
      
              * ChangeLog:
              * loader/qt/FrameLoaderQt.cpp:
              (WebCore::FrameLoader::submitForm):
              * platform/network/qt/ResourceHandleManager.cpp:
              (WebCore::ResourceHandleManager::add):
              * platform/qt/FrameQtClient.cpp:
              (WebCore::FrameQtClientDefault::submitForm):
              * platform/qt/FrameQtClient.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17766 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7965b895
    • thatcher's avatar
      Fixing the site. · 7a327332
      thatcher authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17765 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7a327332
    • bdash's avatar
      2006-11-14 Mark Rowe <bdash@webkit.org> · e58f0237
      bdash authored
              Reviewed by Tim Hatcher.
      
              http://bugs.webkit.org/show_bug.cgi?id=9529
              Bug 9529: Navigation HTML duplicated on webkit.org web site
      
              * blog/wp-content/themes/webkit/sidebar.php: Include navigation from nav.inc rather than duplicating it here.
              * nav.inc: Generate WordPress archive list if included from within WordPress.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17763 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e58f0237