1. 03 Apr, 2010 10 commits
    • jwieczorek@webkit.org's avatar
      2010-04-03 Jakub Wieczorek <jwieczorek@webkit.org> · 850eef27
      jwieczorek@webkit.org authored
              Unreviewed.
      
              [Qt] Skip five XMLHttpRequest tests that are timing out.
      
              * platform/qt/Skipped: Add a comment on why they are failing.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57053 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      850eef27
    • jwieczorek@webkit.org's avatar
      2010-04-03 Jakub Wieczorek <jwieczorek@webkit.org> · f492b8dc
      jwieczorek@webkit.org authored
              Rubber-stamped by Daniel Bates.
      
              Fix the fast/events/popup-allowed-from-gesture-initiated-event.html test
              failure on the Qt and GTK+ ports.
      
              Refactor it to not hardcode any metrics (in order to dispatch mouse events)
              but instead calculate them from the offset* properties.
      
              * fast/events/popup-allowed-from-gesture-initiated-event.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57052 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f492b8dc
    • eric@webkit.org's avatar
      2010-04-03 yael aharon <yael.aharon@nokia.com> · 40e6ef33
      eric@webkit.org authored
              Reviewed by Darin Adler.
      
              Enable HTMLProgressElement for Safari on OSX
              https://bugs.webkit.org/show_bug.cgi?id=36961
      
              * Configurations/FeatureDefines.xcconfig:
      2010-04-03  Kenneth Russell  <kbr@google.com>
      
              Reviewed by Darin Fisher.
      
              Inconsistent failure modes from uniform[Matrix]* with null WebGLUniformLocation
              https://bugs.webkit.org/show_bug.cgi?id=36574
      
              Fixed bugs in JavaScript bindings for uniform[Matrix]* entry
              points causing them to throw exceptions rather than synthesize GL
              errors. Fixed the implementations to synthesize INVALID_VALUE
              rather than INVALID_OPERATION to comply to the WebGL spec. Updated
              uniform-location-expected.txt to incorporate the correct error.
              Tested in Safari and Chromium.
      
              * fast/canvas/webgl/null-uniform-location-expected.txt: Added.
              * fast/canvas/webgl/null-uniform-location.html: Added.
              * fast/canvas/webgl/script-tests/null-uniform-location.js: Added.
              (callUniformFunction):
              * fast/canvas/webgl/uniform-location-expected.txt:
      2010-04-03  yael aharon  <yael.aharon@nokia.com>
      
              Reviewed by Darin Adler.
      
              Enable HTMLProgressElement for Safari on OSX
              https://bugs.webkit.org/show_bug.cgi?id=36961
      
              * Configurations/FeatureDefines.xcconfig:
              * WebCore.xcodeproj/project.pbxproj:
              * rendering/RenderThemeMac.h:
              * rendering/RenderThemeMac.mm:
              (WebCore::RenderThemeMac::animationRepeatIntervalForProgressBar):
              (WebCore::RenderThemeMac::animationDurationForProgressBar):
              (WebCore::RenderThemeMac::adjustProgressBarStyle):
              (WebCore::RenderThemeMac::paintProgressBar):
      2010-04-03  yael aharon  <yael.aharon@nokia.com>
      
              Reviewed by Darin Adler.
      
              Enable HTMLProgressElement for Safari on OSX
              https://bugs.webkit.org/show_bug.cgi?id=36961
      
              * Configurations/FeatureDefines.xcconfig:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57051 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      40e6ef33
    • jwieczorek@webkit.org's avatar
      2010-04-03 Jakub Wieczorek <jwieczorek@webkit.org> · eacf3e1f
      jwieczorek@webkit.org authored
              Unreviewed.
      
              Fix debug build with GCC >= 4.3.
      
              * platform/graphics/GraphicsLayer.cpp: Include stdio.h explicitly.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57050 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      eacf3e1f
    • eric@webkit.org's avatar
      2010-04-03 Kenneth Russell <kbr@google.com> · a4aa05f3
      eric@webkit.org authored
              Reviewed by Darin Fisher.
      
              Inconsistent failure modes from uniform[Matrix]* with null WebGLUniformLocation
              https://bugs.webkit.org/show_bug.cgi?id=36574
      
              Fixed bugs in JavaScript bindings for uniform[Matrix]* entry
              points causing them to throw exceptions rather than synthesize GL
              errors. Fixed the implementations to synthesize INVALID_VALUE
              rather than INVALID_OPERATION to comply to the WebGL spec. Updated
              uniform-location-expected.txt to incorporate the correct error.
              Tested in Safari and Chromium.
      
              * fast/canvas/webgl/null-uniform-location-expected.txt: Added.
              * fast/canvas/webgl/null-uniform-location.html: Added.
              * fast/canvas/webgl/script-tests/null-uniform-location.js: Added.
              (callUniformFunction):
              * fast/canvas/webgl/uniform-location-expected.txt:
      2010-04-03  Kenneth Russell  <kbr@google.com>
      
              Reviewed by Darin Fisher.
      
              Inconsistent failure modes from uniform[Matrix]* with null WebGLUniformLocation
              https://bugs.webkit.org/show_bug.cgi?id=36574
      
              Fixed bugs in JavaScript bindings for uniform[Matrix]* entry
              points causing them to throw exceptions rather than synthesize GL
              errors. Fixed the implementations to synthesize INVALID_VALUE
              rather than INVALID_OPERATION to comply to the WebGL spec. Updated
              uniform-location-expected.txt to incorporate the correct error.
              Tested in Safari and Chromium.
      
              Test: fast/canvas/webgl/null-uniform-location.html
      
              * bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
              (WebCore::V8WebGLRenderingContext::getUniformCallback):
              (WebCore::vertexAttribAndUniformHelperf):
              (WebCore::uniformHelperi):
              (WebCore::uniformMatrixHelper):
              * html/canvas/WebGLRenderingContext.cpp:
              (WebCore::WebGLRenderingContext::uniform1f):
              (WebCore::WebGLRenderingContext::uniform1fv):
              (WebCore::WebGLRenderingContext::uniform1i):
              (WebCore::WebGLRenderingContext::uniform1iv):
              (WebCore::WebGLRenderingContext::uniform2f):
              (WebCore::WebGLRenderingContext::uniform2fv):
              (WebCore::WebGLRenderingContext::uniform2i):
              (WebCore::WebGLRenderingContext::uniform2iv):
              (WebCore::WebGLRenderingContext::uniform3f):
              (WebCore::WebGLRenderingContext::uniform3fv):
              (WebCore::WebGLRenderingContext::uniform3i):
              (WebCore::WebGLRenderingContext::uniform3iv):
              (WebCore::WebGLRenderingContext::uniform4f):
              (WebCore::WebGLRenderingContext::uniform4fv):
              (WebCore::WebGLRenderingContext::uniform4i):
              (WebCore::WebGLRenderingContext::uniform4iv):
              (WebCore::WebGLRenderingContext::uniformMatrix2fv):
              (WebCore::WebGLRenderingContext::uniformMatrix3fv):
              (WebCore::WebGLRenderingContext::uniformMatrix4fv):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57049 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a4aa05f3
    • cjerdonek@webkit.org's avatar
      The check-webkit-style script now logs an ERROR and exits when · 39f7c329
      cjerdonek@webkit.org authored
      encountering a file path that does not exist.  Previously, it failed
      silently on such paths.
      
      Reviewed by Shinichiro Hamaji.
      
      https://bugs.webkit.org/show_bug.cgi?id=36957
      
      * Scripts/webkitpy/common/system/logtesting.py:
        - Added a FIXME to rename the LoggingTestCase class to
          LoggingTestCaseBase.
      
      * Scripts/webkitpy/style/checker.py:
        - In the StyleChecker.check_file() method:
          - Added a mock_os_path_exists parameter.
          - Renamed the process_file parameter to mock_process_file.
          - Added logic to log an error and exist if the given path does
            not exist.
      
      * Scripts/webkitpy/style/checker_unittest.py:
        - Refactored the StyleCheckerCheckFileTest class slightly to
          inherit from LoggingTestCase.
        - Added a test method to unit-test the case of a file that
          does not exist.
        - Adjusted the other test methods as necessary.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57048 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      39f7c329
    • abarth@webkit.org's avatar
      2010-04-03 Adam Barth <abarth@webkit.org> · e9cd7eb9
      abarth@webkit.org authored
              Reviewed by Eric Seidel.
      
              Add Tiger Bot to the list of "core builders" (builders which block the commit-queue when red)
              https://bugs.webkit.org/show_bug.cgi?id=33289
      
              Add Tiger and SnowLeopard Tests to the core builders.  This is a bit of
              an experiment now that the bots are green.  Hopefully we can keep them
              on the list and have the tree stay greener.
      
              * Scripts/webkitpy/common/net/buildbot.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57047 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e9cd7eb9
    • darin@chromium.org's avatar
      2010-04-03 Darin Fisher <darin@chromium.org> · 1e6727b4
      darin@chromium.org authored
              Add default implementations of WebNotificationPresenter methods to
              repair the downstream Chromium build.
      
              * public/WebNotificationPresenter.h:
              (WebKit::WebNotificationPresenter::show):
              (WebKit::WebNotificationPresenter::cancel):
              (WebKit::WebNotificationPresenter::objectDestroyed):
              (WebKit::WebNotificationPresenter::checkPermission):
              (WebKit::WebNotificationPresenter::requestPermission):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57046 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1e6727b4
    • abarth@webkit.org's avatar
      2010-04-02 Andy Estes <aestes@apple.com> · b4fefb8a
      abarth@webkit.org authored
              Reviewed by Adam Barth.
      
              Tests for https://bugs.webkit.org/show_bug.cgi?id=37008.
      
              * fast/events/popup-allowed-from-gesture-initiated-event-expected.txt: Added.
              * fast/events/popup-allowed-from-gesture-initiated-event.html: Added.
              * fast/events/popup-blocked-from-fake-button-click-expected.txt: Added.
              * fast/events/popup-blocked-from-fake-button-click.html: Added.
              * fast/events/popup-blocked-from-fake-focus-expected.txt: Added.
              * fast/events/popup-blocked-from-fake-focus.html: Added.
      2010-04-02  Andy Estes  <aestes@apple.com>
      
              Reviewed by Adam Barth.
      
              The previous mechanism for testing whether an event was due to a user
              gesture only checked the event type, not the source of the event.  This
              allowed scripts to defeat popup blocking by programatically emitting
              certain types of events.
      
              Change the user gesture detection to check for a flag that is only set
              when the event in question was generated through the platform and not
              through the DOM.
      
              https://bugs.webkit.org/show_bug.cgi?id=37008
      
              Tests: fast/events/popup-allowed-from-gesture-initiated-event.html
                     fast/events/popup-blocked-from-fake-button-click.html
                     fast/events/popup-blocked-from-fake-focus.html
      
              * Android.mk: Add UserGestureIndicator.{cpp, h}.
              * GNUmakefile.am: Same.
              * WebCore.gypi: Same.
              * WebCore.pro: Same.
              * WebCore.vcproj/WebCore.vcproj: Same.
              * WebCore.xcodeproj/project.pbxproj: Same.
              * bindings/v8/ScriptController.cpp:
              (WebCore::ScriptController::processingUserGesture): Check the value of
              UserGesureIndicator::processingUserGesture().
              * dom/Document.cpp:
              (WebCore::Document::createEvent): Remove call to
              Event::setCreatedByDOM().
              * dom/Event.cpp:
              (WebCore::Event::Event): Remove initializers for m_createdByDOM.
              (WebCore::Event::fromUserGesture): Check the value of
              UserGestureIndicator::processingUserGesture().
              * dom/Event.h: Remove m_createdByDOM.
              * dom/UserGestureIndicator.cpp: Added.
              (WebCore::UserGestureIndicator::UserGestureIndicator): Save the previous
              value of s_processingUserGesture before setting it to true.
              (WebCore::UserGestureIndicator::~UserGestureIndicator): Restore
              s_processingUserGesture to its previous value.
              * dom/UserGestureIndicator.h: Added.
              (WebCore::UserGestureIndicator::processingUserGesture): Return the value
              of s_processingUserGesture.
              * page/EventHandler.cpp:
              (WebCore::EventHandler::handleMousePressEvent): Instantiate a
              UserGestureIndicator object on the stack to indicate a user gesture is
              being processed.
              (WebCore::EventHandler::handleMouseDoubleClickEvent): Same.
              (WebCore::EventHandler::handleMouseReleaseEvent): Same.
              (WebCore::EventHandler::keyEvent): Same.
              (WebCore::EventHandler::handleTouchEvent): Same.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57045 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b4fefb8a
    • abarth@webkit.org's avatar
      2010-04-02 Adam Barth <abarth@webkit.org> · b9401be9
      abarth@webkit.org authored
              Unreviewed.
      
              REGRESSION(56394): http/tests/xmlhttprequest/xmlhttprequest-50ms-download-dispatch.html fails on Tiger
              https://bugs.webkit.org/show_bug.cgi?id=36934
      
              Attempt Alexey's solution of using a non-sniffable MIME type.
      
              * http/tests/xmlhttprequest/resources/download-with-delay.php:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57044 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b9401be9
  2. 02 Apr, 2010 30 commits
    • abarth@webkit.org's avatar
      2010-04-02 Adam Barth <abarth@webkit.org> · a19484cb
      abarth@webkit.org authored
              Unreviewed.  Disabled fast/workers/worker-terminate.html because it
              randomly fails about 25% of the time.
      
              https://bugs.webkit.org/show_bug.cgi?id=36646
      
              * platform/mac/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57043 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a19484cb
    • darin@chromium.org's avatar
      2010-04-02 Darin Fisher <darin@chromium.org> · f5cb4250
      darin@chromium.org authored
              Reviewed by Adam Barth.
      
              https://bugs.webkit.org/show_bug.cgi?id=36647
              Make replacestate-in-frame.html less insane and hopefully no longer flaky.
      
              * fast/loader/stateobjects/replacestate-in-iframe-expected.txt:
              * fast/loader/stateobjects/replacestate-in-iframe.html:
              * fast/loader/stateobjects/resources/replacestate-in-iframe-window-child.html: Added.
              * fast/loader/stateobjects/resources/replacestate-in-iframe-window.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57042 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f5cb4250
    • abarth@webkit.org's avatar
      2010-04-02 Justin Schuh <jschuh@chromium.org> · 7a8fde5a
      abarth@webkit.org authored
              Reviewed by Alexey Proskuryakov.
      
              XHR allows arbitrary XSRF across domains
              https://bugs.webkit.org/show_bug.cgi?id=36843
      
              Added a one-line change to prevent bypassing the XDC check on
              synchronous preflighted requests. Added layout tests to cover
              variations of this problem.
      
              * http/tests/xmlhttprequest/access-control-preflight-async-header-denied-expected.txt: Added.
              * http/tests/xmlhttprequest/access-control-preflight-async-header-denied.html: Added.
              * http/tests/xmlhttprequest/access-control-preflight-async-method-denied-expected.txt: Added.
              * http/tests/xmlhttprequest/access-control-preflight-async-method-denied.html: Added.
              * http/tests/xmlhttprequest/access-control-preflight-sync-header-denied-expected.txt: Added.
              * http/tests/xmlhttprequest/access-control-preflight-sync-header-denied.html: Added.
              * http/tests/xmlhttprequest/access-control-preflight-sync-method-denied-expected.txt: Added.
              * http/tests/xmlhttprequest/access-control-preflight-sync-method-denied.html: Added.
              * http/tests/xmlhttprequest/resources/access-control-preflight-denied-xsrf.php: Added.
      2010-04-02  Justin Schuh  <jschuh@chromium.org>
      
              Reviewed by Alexey Proskuryakov.
      
              XHR allows arbitrary XSRF across domains
              https://bugs.webkit.org/show_bug.cgi?id=36843
      
              Added a one-line change to prevent bypassing the XDC check on
              synchronous preflighted requests. Added layout tests to cover
              variations of this problem.
      
              Tests: http/tests/xmlhttprequest/access-control-preflight-async-header-denied.html
                     http/tests/xmlhttprequest/access-control-preflight-async-method-denied.html
                     http/tests/xmlhttprequest/access-control-preflight-sync-header-denied.html
                     http/tests/xmlhttprequest/access-control-preflight-sync-method-denied.html
      
              * loader/DocumentThreadableLoader.cpp:
              (WebCore::DocumentThreadableLoader::preflightFailure):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57041 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7a8fde5a
    • abarth@webkit.org's avatar
      2010-04-02 Adam Barth <abarth@webkit.org> · 948358ba
      abarth@webkit.org authored
              Unreviewed.
      
              Have Eric and Adam watch the SheriffBot
              https://bugs.webkit.org/show_bug.cgi?id=37054
      
              * Scripts/webkitpy/tool/bot/sheriff.py:
              * Scripts/webkitpy/tool/bot/sheriff_unittest.py:
              * Scripts/webkitpy/tool/commands/sheriffbot.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57040 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      948358ba
    • simon.fraser@apple.com's avatar
      2010-04-02 Simon Fraser <simon.fraser@apple.com> · 63b06ae8
      simon.fraser@apple.com authored
              Reviewed by Darin Adler.
      
              Very bad scrolling-performance with the Trackpad at http://www.apple.com/ipad/app-store/
              https://bugs.webkit.org/show_bug.cgi?id=36978
      
              When we update compositing layers (which can happen on scrolling, when there are fixed position elements
              on the page), we can end up redundantly setting images as layer contents if we have to color-correct
              the image. This is because we call CGImageCreateCopyWithColorSpace(), which hands back a new image
              every time.
      
              Avoid this by storing a reference to the original uncorrected image, which is used to then
              avoid work if the image does not change.
      
              * platform/graphics/mac/GraphicsLayerCA.h:
              * platform/graphics/mac/GraphicsLayerCA.mm:
              (WebCore::GraphicsLayerCA::setContentsToImage):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57039 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      63b06ae8
    • eric@webkit.org's avatar
      2010-04-02 Nayan Kumar K <nayankk@gmail.com> · 26ef9bee
      eric@webkit.org authored
              Reviewed by Eric Seidel.
      
              Fix for WML enabled build failure.
      
              https://bugs.webkit.org/show_bug.cgi?id=36648
      
              * wml/WMLOptionElement.cpp:
              (WebCore::WMLOptionElement::disabled):
              * wml/WMLOptionElement.h:
              * wml/WMLSelectElement.cpp:
              (WebCore::WMLSelectElement::listBoxSelectItem):
              * wml/WMLSelectElement.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57038 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      26ef9bee
    • eric@webkit.org's avatar
      2010-04-02 MORITA Hajime <morrita@google.com> · 663af777
      eric@webkit.org authored
              Reviewed by Alexey Proskuryakov.
      
              https://bugs.webkit.org/show_bug.cgi?id=37011
              Position::primaryDirection() should not use its own accessor.
      
              No new tests. This is small clenaup with no behaviour change.
      
              * dom/Position.cpp:
              (WebCore::Position::primaryDirection):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57037 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      663af777
    • eric@webkit.org's avatar
      2010-04-02 Eric Uhrhane <ericu@chromium.org> · dbee62b3
      eric@webkit.org authored
              Reviewed by Brady Eidson.
      
              window.openDatabase() always fails for new databases when using WebKit nightly with Safari 4.0.5.  This is caused by a SecurityOrigin pointer comparison that I should have switched to be a hash comparison in r56293 [bug 34991].
              https://bugs.webkit.org/show_bug.cgi?id=36671
      
              No new tests.  Requires testing on Safari on Windows.
      
              * storage/DatabaseTracker.cpp:
              (WebCore::DatabaseTracker::fullPathForDatabaseNoLock): Convert a pointer comparison to use SecurityOriginHash::hash() instead, and move it to the end of the clause for speed in the easy-out case.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57036 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dbee62b3
    • abarth@webkit.org's avatar
      2010-04-02 Adam Barth <abarth@webkit.org> · 575253b8
      abarth@webkit.org authored
              Reviewed by Darin Adler.
      
              commit-queue should ignore builders when landing rollouts
              https://bugs.webkit.org/show_bug.cgi?id=37051
      
              When we moved the "builders are red" check into the master process, we
              forgot about rollouts.  I thought we had a test covering this case, but
              looking at the test, it was a bit too loose.  I added a new test and
              introduced some new logging technology into MockTool to make the test
              tighter.
      
              * Scripts/webkitpy/tool/commands/queues.py:
              * Scripts/webkitpy/tool/commands/queues_unittest.py:
              * Scripts/webkitpy/tool/mocktool.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57035 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      575253b8
    • eric@webkit.org's avatar
      2010-04-02 Michael Nordman <michaeln@google.com> · 7c7b0955
      eric@webkit.org authored
              Reviewed by Nate Chapin.
      
              Set the close policy used by the DatabaseCloseTask in a constructor argument
              instead of hard coding it.
              https://bugs.webkit.org/show_bug.cgi?id=37037
      
              No new tests, new new functionality.
      
              * storage/Database.cpp: This callsite passes in DoNotRemoveFromDatabaseContext to retain its current behavior.
              (WebCore::Database::markAsDeletedAndClose):
              * storage/DatabaseTask.cpp:
              (WebCore::DatabaseCloseTask::DatabaseCloseTask):
              (WebCore::DatabaseCloseTask::doPerformTask):
              * storage/DatabaseTask.h:
              (WebCore::DatabaseCloseTask::create):
      2010-04-02  Michael Nordman  <michaeln@google.com>
      
              Reviewed by Nate Chapin.
      
              Set the close policy used by the DatabaseCloseTask at this callsite to
              RemoveDatabaseFromContext. This restores its behavior to what it was prior to
              r56293.
              https://bugs.webkit.org/show_bug.cgi?id=37037
      
              * src/WebDatabase.cpp:
              (WebKit::WebDatabase::closeDatabaseImmediately):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57034 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7c7b0955
    • jamesr@google.com's avatar
      2010-04-02 James Robinson <jamesr@chromium.org> · c43f0de4
      jamesr@google.com authored
              Reviewed by Simon Fraser.
      
              Remove an ASSERT that sometimes flakes due to time dependent animations
              https://bugs.webkit.org/show_bug.cgi?id=37048
      
              The outline repaint rectangle for a layer might change between two calls
              if there are animations involved, even if nothing in the DOM has actually
              changed between the calls.
      
              No change in behavior, no new tests.
      
              * rendering/RenderLayer.cpp:
              (WebCore::RenderLayer::updateLayerPositions):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57033 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c43f0de4
    • abarth@webkit.org's avatar
      2010-04-02 Evan Stade <estade@chromium.org> · de5779b6
      abarth@webkit.org authored
              Reviewed by Adam Barth.
      
              [chromium] need DragImage implementation
              https://bugs.webkit.org/show_bug.cgi?id=35811
      
              Add two files that failed to get added in my previous patch.
      
              * platform/chromium/DragImageChromiumMac.cpp: Added.
              (WebCore::dragImageSize):
              (WebCore::deleteDragImage):
              (WebCore::scaleDragImage):
              (WebCore::dissolveDragImageToFraction):
              (WebCore::createDragImageFromImage):
              (WebCore::createDragImageIconForCachedImage):
              * platform/chromium/DragImageChromiumSkia.cpp: Added.
              (WebCore::dragImageSize):
              (WebCore::deleteDragImage):
              (WebCore::scaleDragImage):
              (WebCore::dissolveDragImageToFraction):
              (WebCore::createDragImageFromImage):
              (WebCore::createDragImageIconForCachedImage):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57032 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      de5779b6
    • eric.carlson@apple.com's avatar
      2010-04-02 Jer Noble <jer.noble@apple.com> · ebcff5e1
      eric.carlson@apple.com authored
              Reviewed by Eric Carlson.
      
              Configure multi-language movies: when QuickTime has sufficiently loaded
              the movie, call into wkQTMovieSelectPreferredAlternates to select the
              movie's alternate tracks according to the user's language preferences.
      
              https://bugs.webkit.org/show_bug.cgi?id=36624
      
              * WebCore.base.exp:
              * platform/graphics/mac/MediaPlayerPrivateQTKit.mm: 
              (WebCore::MediaPlayerPrivate::updateStates): If the movie is sufficiently loaded,
              call wkQTMovieSelectPreferredAlternates to set up the alternate tracks.
              * platform/mac/WebCoreSystemInterface.h: Declare WKQTMovieSelectPreferredAlternates.
              * platform/mac/WebCoreSystemInterface.mm: Add WKQTMovieSelectPreferredAlternates.
      
      2010-04-02  Jer Noble  <jer.noble@apple.com>
      
              Reviewed by Eric Carlson.
              
              https://bugs.webkit.org/show_bug.cgi?id=36624
      
              Update WebKitSystemInterface
      
              * WebKitSystem...
      ebcff5e1
    • jamesr@google.com's avatar
      2010-04-02 James Robinson <jamesr@chromium.org> · 19548ad3
      jamesr@google.com authored
              Reviewed by Darin Adler.
      
              Splits RenderBlock::layoutInline into smaller functions
              https://bugs.webkit.org/show_bug.cgi?id=36921
      
              RenderBlock::layoutInlineChildren is 351 lines long and very difficult
              to comprehend or edit safely. This patch splits it up into a few
              slightly smaller functions.  Most of the code is now in the 241 line
              layoutRunsAndFloats() which is a slight improvement.
      
              Perf neutral on the page cyclers.  This doesn't introduce any function
              calls into the hottest layout paths inside layoutRunsAndFloats and
              findNextLineBreak.
      
              No change in behavior, no new tests.
      
              * rendering/RenderBlock.h:
              (WebCore::RenderBlock::FloatWithRect::FloatWithRect):
              * rendering/RenderBlockLineLayout.cpp:
              (WebCore::RenderBlock::layoutReplacedElements):
              (WebCore::RenderBlock::createLineBoxesForResolver):
              (WebCore::RenderBlock::layoutRunsAndFloats):
              (WebCore::RenderBlock::layoutInlineChildren):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57030 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      19548ad3
    • eric@webkit.org's avatar
      2010-04-02 Laszlo Gombos <laszlo.1.gombos@nokia.com> · 0cadbf82
      eric@webkit.org authored
              Reviewed by Kenneth Rohde Christiansen.
      
              [Qt] [Symbian] Rebaseline Symbian def file
              https://bugs.webkit.org/show_bug.cgi?id=37038
      
              Switch the ordinal numbers for qtwebkit_webframe_scrollRecursively
              and QWebInspector::closeEvent to match QtWebkit 4.6 branch
      
              Fix the signature for qt_drt_setFrameFlatteningEnabled
              after r56718.
      
              Add new QtWebKit API symbols introduced not listed in the file yet.
      
              * symbian/eabi/QtWebKitu.def:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57029 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0cadbf82
    • eric@webkit.org's avatar
      2010-04-02 Evan Stade <estade@chromium.org> · 6ae9603a
      eric@webkit.org authored
              Reviewed by Eric Seidel.
      
              [chromium] need DragImage implementation
              https://bugs.webkit.org/show_bug.cgi?id=35811
      
              Basic implementation using SkBitmap. Transformations are not supported
              yet. No implementation for mac.
      
              * WebCore.gyp/WebCore.gyp:
              * WebCore.gypi:
              * platform/chromium/DragImageChromium.cpp:
              * platform/chromium/DragImageRef.h:
      2010-04-02  Evan Stade  <estade@chromium.org>
      
              Reviewed by Eric Seidel.
      
              [chromium] need DragImage implementation
              https://bugs.webkit.org/show_bug.cgi?id=35811
      
              Use the DragImageRef that the DragController passes to us.
      
              * public/WebViewClient.h:
              (WebKit::WebViewClient::startDragging):
              * src/DragClientImpl.cpp:
              (WebKit::DragClientImpl::startDrag):
              * src/WebViewImpl.cpp:
              (WebKit::WebViewImpl::startDragging):
              * src/WebViewImpl.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57028 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6ae9603a
    • eric@webkit.org's avatar
      2010-04-02 Evan Martin <evan@chromium.org> · ad7819be
      eric@webkit.org authored
              Reviewed by Eric Seidel.
      
              [chromium] font fallback for generic fonts picks wrong font
              https://bugs.webkit.org/show_bug.cgi?id=37033
      
              When a page specifies the generic "monospace" font and the user's
              browser-configured monospace font doesn't exist, we previously relied
              on getLastResortFallbackFont to eventually pick a monospace font for us.
      
              But that doesn't quite work: WebKit first falls back to the user's
              "preferred standard font" before hitting the last resort code path.
              So if the above conditions hold but this font exists, we'll end up
              never hitting the last resort codepath.
      
              The fix is to allow OS-level font fallback when first attempting to
              resolve monospace.  The existing code tried to do this, but the logic
              was wrong.  We would eventually fall back to the correct font anyway
              so we didn't notice the logic was wrong.
      
              This code is all handling cases where particular fonts aren't installed,
              so I can't think of a way to test it; existing tests should still pass.
      
              * platform/graphics/chromium/FontCacheLinux.cpp:
              (WebCore::FontCache::createFontPlatformData):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57027 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ad7819be
    • eric@webkit.org's avatar
      2010-04-02 Rafael Weinstein <rafaelw@chromium.org> · 1c781715
      eric@webkit.org authored
              Reviewed by Adam Barth.
      
              Clean up unused calls after changes to checkPermission and requestPermission argument lists.
      
              * public/WebNotificationPresenter.h:
              * src/NotificationPresenterImpl.cpp:
              (WebKit::NotificationPresenterImpl::checkPermission):
              (WebKit::NotificationPresenterImpl::requestPermission):
      2010-04-02  Rafael Weinstein  <rafaelw@chromium.org>
      
              Reviewed by Adam Barth.
      
              Clean up unused calls after changes to checkPermission and requestPermission argument lists.
      
              * WebCoreSupport/WebDesktopNotificationsDelegate.cpp:
              (WebDesktopNotificationsDelegate::requestPermission):
              * WebCoreSupport/WebDesktopNotificationsDelegate.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57026 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1c781715
    • eric@webkit.org's avatar
      2010-04-02 Ruben Van Boxem <vanboxem.ruben@gmail.com> · dfe84470
      eric@webkit.org authored
              Reviewed by Eric Seidel.
      
              Mingw-w64 fixes for JavaScriptCore
              https://bugs.webkit.org/show_bug.cgi?id=35607
      
              * runtime/Collector.cpp: use the msvc code for mingw-w64 (but not mingw-w32)
              (JSC::Heap::allocateBlock):
              (JSC::Heap::freeBlockPtr):
              (JSC::currentThreadStackBase):
              (JSC::currentThreadStackBase):
              * wtf/Platform.h: added COMPILER(MINGW64) check to differentiate between mingw.org and mingw-w64 functions
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57025 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dfe84470
    • ap@apple.com's avatar
      Reviewed by Darin Adler. · 7948732e
      ap@apple.com authored
              https://bugs.webkit.org/show_bug.cgi?id=37043
              Java regression tests spam stderr about being unable to set status message
      
              With this change, there is still spam about "Attempt to access JavaScript from destroyed
              applet, type 9." I haven't investigated if that indicates a problem or not.
      
              * Plugins/WebPluginController.mm: (-[WebPluginController webPlugInContainerShowStatus:]):
              Removed check for _documentView. We don't seem to care.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57024 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7948732e
    • scherkus@chromium.org's avatar
      2010-04-02 Andrew Scherkus <scherkus@chromium.org> · e479546e
      scherkus@chromium.org authored
              Reviewed by Eric Carlson and Eric Seidel.
      
              Don't stop the playback event timer when media resource loading has suspended.
              https://bugs.webkit.org/show_bug.cgi?id=37003
      
              When a user agent decides to suspend media resource loading and enters the
              NETWORK_IDLE state we are supposed to only stop the progress event timer but
              keep the playback timer running.
      
              Test: http/tests/media/video-play-suspend.html
      
              * html/HTMLMediaElement.cpp:
              (WebCore::HTMLMediaElement::setNetworkState): Only stop the progress event timer.
      
      2010-04-02  Andrew Scherkus  <scherkus@chromium.org>
      
              Reviewed by Eric Carlson and Eric Seidel.
      
              Don't stop the playback event timer when media resource loading has suspended.
              https://bugs.webkit.org/show_bug.cgi?id=37003
      
              When a user agent decides to suspend media resource loading and enters the
              NETWORK_IDLE state we are supposed to only stop the progress event timer but
              keep the playback timer running.
      
              Currently Chromium is the only platform that fires the suspend event
              hence most platforms skipping this test.
      
              * http/tests/media/video-play-suspend-expected.txt: Added.
              * http/tests/media/video-play-suspend.html: Added.
              * platform/gtk/Skipped: Doesn't fire a suspend event.
              * platform/mac/Skipped: Ditto.
              * platform/win/Skipped: Ditto.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57023 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e479546e
    • darin@apple.com's avatar
      Fix mispelling that broke the build. · 9a7b1ead
      darin@apple.com authored
      * html/canvas/CanvasRenderingContext2D.cpp:
      * html/canvas/CanvasRenderingContext2D.h:
      Dashbard -> Dashboard.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57022 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9a7b1ead
    • ggaren@apple.com's avatar
      Build fix: updated the .def file. · 682df4a7
      ggaren@apple.com authored
      * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57021 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      682df4a7
    • levin@chromium.org's avatar
      (non-generated) code should only use CanvasRenderingContext::canvas as a CanvasSurface. · 61fc3bb1
      levin@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=36906
      
      Reviewed by Darin Adler.
      
      WebCore:
      
      * dom/CanvasSurface.cpp: Added methods for items that depended on
      CanvasRenderingContext::canvas() being an HTMLElement(), so that this usage
      can be dealt with in one place.
      (WebCore::CanvasSurface::securityOrigin): Only used by methods that are
      only run in the document context.
      (WebCore::CanvasSurface::renderBox): Will likely return 0 in a worker context.
      (WebCore::CanvasSurface::computedStyle): Used by setFont. Return value is TBD for
      the worker context.
      (WebCore::CanvasSurface::styleSelector): Ditto.
      * dom/CanvasSurface.h:
      * html/HTMLCanvasElement.cpp:
      (WebCore::HTMLCanvasElement::getContext): Passing in information into
      the CanvasRenderingContext2D constructor to eliminate some uses of document
      inside of the CanvasRenderingContext2D class.
      * html/HTMLCanvasElement.h:
      (WebCore::HTMLCanvasElement::renderBox): Added to disambiguate between the
      two parent class versions of the method.
      (WebCore::HTMLCanvasElement::computedStyle): Ditto.
      * html/canvas/CanvasRenderingContext2D.cpp: All of these changes are about
      removing document usage either by using a bool that is set in the constructor or
      by calling one of the new methods added to CanvasSurface.
      (WebCore::CanvasRenderingContext2D::CanvasRenderingContext2D):
      (WebCore::CanvasRenderingContext2D::clearPathForDashboardBackwardCompatibilityMode):
      (WebCore::CanvasRenderingContext2D::checkOrigin):
      (WebCore::CanvasRenderingContext2D::prepareGradientForDashboard):
      (WebCore::CanvasRenderingContext2D::createPattern):
      (WebCore::CanvasRenderingContext2D::setFont):
      (WebCore::CanvasRenderingContext2D::drawTextInternal):
      * html/canvas/CanvasRenderingContext2D.h:
      * html/canvas/WebGLRenderingContext.cpp: Removed some duplicate includes.
      (WebCore::WebGLRenderingContext::markContextChanged): Reduced calls to renderBox
       as it may become slightly more expensive in the future.
      (WebCore::WebGLRenderingContext::reshape): Ditto.
      
      LayoutTests:
      
      * fast/canvas/script-tests/canvas-gradient-addStop-error.js: Changed the test
      to create a new canvas after switching to dashboard compatiblity mode, which is
      needed now that the compatibility mode is cached in the canvas.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57020 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      61fc3bb1
    • ggaren@apple.com's avatar
      Inlined toThisString and toThisJSString to avoid virtual function call overhead · f2645846
      ggaren@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=37039
              
      Reviewed by Oliver Hunt.
      
      Maybe a 1% speedup on iBench JS.
      
      * JavaScriptCore.exp: New exports.
      
      * runtime/JSCell.cpp:
      * runtime/JSCell.h:
      * runtime/JSNumberCell.cpp:
      * runtime/JSNumberCell.h:
      * runtime/JSString.cpp:
      * runtime/JSString.h:
      * runtime/JSValue.h:
      * runtime/JSZombie.h:
      (JSC::JSZombie::toThisObject): Nixed the old virtual-type implementation.
      
      * runtime/JSObject.h:
      (JSC::JSValue::toThisString):
      (JSC::JSValue::toThisJSString): Added the inlined implementation.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57019 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f2645846
    • eric@webkit.org's avatar
      2010-04-02 Zhenyao Mo <zmo@google.com> · 326c1776
      eric@webkit.org authored
              Reviewed by Eric Seidel.
      
              Implement and test new framebuffer object attachment behavior.
              https://bugs.webkit.org/show_bug.cgi?id=35611
      
              * fast/canvas/webgl/framebuffer-object-attachment-expected.txt: Added, test framebuffer object attachment behavior.
              * fast/canvas/webgl/framebuffer-object-attachment.html: Added, framebuffer object attachment behavior.
              * fast/canvas/webgl/script-tests/gl-object-get-calls.js: DEPTH_COMPONENT is no longer a valid input, use DEPTH_COMPONENT16 instead.
              * platform/mac-snowleopard/Skipped: The bot does not support EXT_packed_depth_stencil, skip the framebuffer-object-attachment.html test.
      2010-04-02  Zhenyao Mo  <zmo@google.com>
      
              Reviewed by Eric Seidel.
      
              Implement and test new framebuffer object attachment behavior.
              https://bugs.webkit.org/show_bug.cgi?id=35611
      
              Test: fast/canvas/webgl/framebuffer-object-attachment.html
      
              * html/canvas/WebGLFramebuffer.cpp: Keep track of attached stencil/depth renderbuffers in WebGLFramebuffer.
              (WebCore::WebGLFramebuffer::WebGLFramebuffer):
              (WebCore::WebGLFramebuffer::setIsAttached):
              * html/canvas/WebGLFramebuffer.h: Ditto.
              (WebCore::WebGLFramebuffer::isDepthAttached):
              (WebCore::WebGLFramebuffer::isStencilAttached):
              (WebCore::WebGLFramebuffer::isDepthStencilAttached):
              * html/canvas/WebGLRenderbuffer.cpp: Keep track of internalformat.
              (WebCore::WebGLRenderbuffer::WebGLRenderbuffer):
              * html/canvas/WebGLRenderbuffer.h: Ditto.
              (WebCore::WebGLRenderbuffer::setInternalformat):
              (WebCore::WebGLRenderbuffer::getInternalformat):
              * html/canvas/WebGLRenderingContext.cpp:
              (WebCore::WebGLRenderingContext::framebufferRenderbuffer): Detect stencil/depth buffer conflicts.
              (WebCore::WebGLRenderingContext::getFramebufferAttachmentParameter): Handling DEPTH_STENCIL case.
              (WebCore::WebGLRenderingContext::getRenderbufferParameter): Get correct WebGL internalformat.
              (WebCore::WebGLRenderingContext::renderbufferStorage): Detect illegal enums.
              * html/canvas/WebGLRenderingContext.idl: Add DEPTH_STENCIL enums.
              * platform/graphics/GraphicsContext3D.h: Add DEPTH_STENCIL enums.
              (WebCore::GraphicsContext3D::):
              * platform/graphics/mac/GraphicsContext3DMac.cpp: Map to correct DEPTH_STENCIL format.
              (WebCore::GraphicsContext3D::framebufferRenderbuffer):
              (WebCore::GraphicsContext3D::renderbufferStorage):
              (WebCore::GraphicsContext3D::getFramebufferAttachmentParameteriv):
      2010-04-02  Zhenyao Mo  <zmo@google.com>
      
              Reviewed by Eric Seidel.
      
              Implement and test new framebuffer object attachment behavior.
              https://bugs.webkit.org/show_bug.cgi?id=35611
      
              Test: fast/canvas/webgl/framebuffer-object-attachment.html
      
              * src/WebGraphicsContext3DDefaultImpl.cpp: Map to correct DEPTH_STENCIL format.
              (WebKit::WebGraphicsContext3DDefaultImpl::framebufferRenderbuffer):
              (WebKit::WebGraphicsContext3DDefaultImpl::getFramebufferAttachmentParameteriv):
              (WebKit::WebGraphicsContext3DDefaultImpl::renderbufferStorage):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57018 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      326c1776
    • tonikitoo@webkit.org's avatar
      Stored focused frame and document in a vars, instead of querying for them many times. · 32b91b00
      tonikitoo@webkit.org authored
      Reviewed by Adam Treat.
      Patch by Antonio Gomes <tonikitoo@webkit.org>
      
      * Api/qwebpage.cpp:
      (QWebPagePrivate::mousePressEvent(QEvent* ev)):
      (QWebPagePrivate::mousePressEvent(QGraphicsSceneMouseEvent* ev):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57017 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      32b91b00
    • eric@webkit.org's avatar
      2010-04-02 Jeremy Moskovich <jeremy@chromium.org> · 2c66f5f9
      eric@webkit.org authored
              Reviewed by Geoffrey Garen.
      
              Beef up documentation for ASSERT* and CRASH macros a bit.
      
              https://bugs.webkit.org/show_bug.cgi?id=36527
      
              * wtf/Assertions.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57016 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2c66f5f9
    • eric@webkit.org's avatar
      2010-04-02 Zhenyao Mo <zmo@google.com> · cb3569ea
      eric@webkit.org authored
              Reviewed by Eric Seidel.
      
              fast/canvas/webgl/index-validation.html failed on Leopard Commit Bot
              https://bugs.webkit.org/show_bug.cgi?id=36908
      
              * fast/canvas/webgl/index-validation-expected.txt: Gathering more information about the cause of the failure.  It's not a fix, and it won't worse change the current test behavior either, i.e., it won't make it better or worse.
              * fast/canvas/webgl/script-tests/index-validation.js: Ditto.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57015 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cb3569ea
    • eric@webkit.org's avatar
      2010-04-02 Jay Civelli <jcivelli@chromium.org> · 9e98b622
      eric@webkit.org authored
              Reviewed by Darin Fisher.
      
              The popup type (select or suggestion) is now passed to the
              WebClient::createPopupMenu() method. This is required for
              Chromium on Linux to make the select popups work correctly.
              https://bugs.webkit.org/show_bug.cgi?id=37013
      
              * WebKit.gyp:
              * public/WebPopupType.h: Added.
              (WebKit::):
              * public/WebViewClient.h:
              (WebKit::WebViewClient::createPopupMenu):
              * src/ChromeClientImpl.cpp:
              (WebCore::convertPopupType):
              (WebKit::ChromeClientImpl::popupOpened):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57014 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9e98b622