1. 24 Sep, 2012 40 commits
    • fpizlo@apple.com's avatar
      Nested try/finally should not confuse the finally unpopper in... · 84c256c3
      fpizlo@apple.com authored
      Nested try/finally should not confuse the finally unpopper in BytecodeGenerator::emitComplexJumpScopes
      https://bugs.webkit.org/show_bug.cgi?id=97508
      <rdar://problem/12361132>
      
      Reviewed by Sam Weinig.
      
      Source/JavaScriptCore: 
      
      We're reusing some vector for multiple iterations of a loop, but we were forgetting to clear its
      contents from one iteration to the next. Hence if you did multiple iterations of finally unpopping
      (like in a nested try/finally and a jump out of both of them) then you'd get a corrupted try
      context stack afterwards.
      
      * bytecompiler/BytecodeGenerator.cpp:
      (JSC::BytecodeGenerator::emitComplexJumpScopes):
      
      LayoutTests: 
      
      * fast/js/jsc-test-list:
      * fast/js/script-tests/try-try-return-finally-finally.js: Added.
      (foo):
      * fast/js/try-try-return-finally-finally-expected.txt: Added.
      * fast/js/try-try-return-finally-finally.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129440 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      84c256c3
    • dino@apple.com's avatar
      [WebGL] Intel Mac needs built-in function emulation · 60e82368
      dino@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=96140
      
      Reviewed by Sam Weinig.
      
      Temporarily turn on built-in function emulation for Intel GPUs
      on OS X. This is a work-around for a driver bug, and
      will be removed once the driver is updated:
      https://bugs.webkit.org/show_bug.cgi?id=97503
      
      This can be tested using the Khronos WebGL conformance
      suite, in particular:
      
      conformance/glsl/functions/glsl-function-dot.html
      conformance/glsl/functions/glsl-function-length.html
      conformance/glsl/functions/glsl-function-normalize.html
      conformance/glsl/functions/glsl-function-reflect.html
      
      Note that the faceforward built-in will still cause
      problems on Intel GPUs, but this would require an unnecessary
      change in the ANGLE project (remember, we're going to
      remove this code once the driver is fixed).
      
      * platform/graphics/opengl/Extensions3DOpenGLCommon.cpp:
      (WebCore::Extensions3DOpenGLCommon::getTranslatedShaderSourceANGLE):
          Temporarily add "Intel" to the list of GPUs we do translation
          for in the shader compiler.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129439 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      60e82368
    • commit-queue@webkit.org's avatar
      There is a mistake in InspectorProfilerAgent::enable(bool skipRecompile) · 77a038f7
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=97450
      
      Patch by Peter Wang <peter.wang@torchmobile.com.cn> on 2012-09-24
      Reviewed by Yury Semikhatsky.
      
      The "InspectorProfilerAgent::enable()" should invokes "PageScriptDebugServer" in
      no-worker thread.
      
      No new test case.
      
      * inspector/InspectorProfilerAgent.cpp:
      (WebCore::PageProfilerAgent::recompileScript):
      (PageProfilerAgent):
      (WebCore::WorkerProfilerAgent::recompileScript):
      (WorkerProfilerAgent):
      (WebCore::InspectorProfilerAgent::disable):
      (WebCore::InspectorProfilerAgent::enable):
      * inspector/InspectorProfilerAgent.h:
      (InspectorProfilerAgent):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129438 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      77a038f7
    • commit-queue@webkit.org's avatar
      [EFL][WK2] TestRunner needs touch events support. · f7d366a9
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=96465
      
      Patch by Nikhil Bansal <n.bansal@samsung.com> on 2012-09-24
      Reviewed by Kenneth Rohde Christiansen.
      
      Tools:
      
      Simulate touch events in WebkitTestRunner for touch related
      layout tests. This patch uses ewk_view_feed_touch_event() to
      generate touch events.
      
      * WebKitTestRunner/EventSenderProxy.h:
      (EventSenderProxy):
      * WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
      (WTR):
      (WTR::setEvasModifiers):
      (WTR::EventSenderProxy::EventSenderProxy):
      (WTR::EventSenderProxy::~EventSenderProxy):
      (WTR::EventSenderProxy::sendTouchEvent):
      (WTR::EventSenderProxy::addTouchPoint):
      (WTR::EventSenderProxy::updateTouchPoint):
      (WTR::EventSenderProxy::setTouchModifier):
      (WTR::EventSenderProxy::touchStart):
      (WTR::EventSenderProxy::touchMove):
      (WTR::EventSenderProxy::touchEnd):
      (WTR::EventSenderProxy::touchCancel):
      (WTR::EventSenderProxy::clearTouchPoints):
      (WTR::EventSenderProxy::releaseTouchPoint):
      (WTR::EventSenderProxy::cancelTouchPoint):
      
      LayoutTests:
      
      Touch events support added in WebKitTestRunner for layout tests.
      
      * platform/efl-wk2/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129437 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f7d366a9
    • fpizlo@apple.com's avatar
      ValueToInt32 bool case does bad things to registers · 7539f5a7
      fpizlo@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=97505
      <rdar://problem/12356331>
      
      Reviewed by Mark Hahnenberg.
      
      Source/JavaScriptCore: 
      
      * dfg/DFGSpeculativeJIT.cpp:
      (JSC::DFG::SpeculativeJIT::compileValueToInt32):
      
      LayoutTests: 
      
      * fast/js/dfg-bool-to-int32-reuse-expected.txt: Added.
      * fast/js/dfg-bool-to-int32-reuse.html: Added.
      * fast/js/jsc-test-list:
      * fast/js/script-tests/dfg-bool-to-int32-reuse.js: Added.
      (foo):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129435 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7539f5a7
    • mark.lam@apple.com's avatar
      Add cloopDo instruction for debugging the llint C++ backend. · 9cc5df7d
      mark.lam@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=97502.
      
      Reviewed by Geoffrey Garen.
      
      * offlineasm/cloop.rb:
      * offlineasm/instructions.rb:
      * offlineasm/parser.rb:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129434 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9cc5df7d
    • paroga@webkit.org's avatar
      Remove String::operator+=() · e65252dc
      paroga@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=96172
      
      Reviewed by Benjamin Poulain.
      
      Source/WebCore:
      
      Replace the last usage with String::append() in Gtk.
      
      * platform/gtk/GtkInputMethodFilter.cpp:
      (WebCore::GtkInputMethodFilter::handleCommit):
      
      Source/WTF:
      
      * wtf/Platform.h:
      * wtf/text/WTFString.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129433 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e65252dc
    • fpizlo@apple.com's avatar
      JSArray::putByIndex asserts with readonly property on prototype · 44e841ff
      fpizlo@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=97435
      <rdar://problem/12357084>
      
      Reviewed by Geoffrey Garen.
      
      Source/JavaScriptCore: 
      
      Boy, there were some problems:
              
      - putDirectIndex() should know that it can set the index quickly even if it's a hole and we're
        in SlowPut mode, since that's the whole point of PutDirect.
              
      - We should have a fast path for putByIndex().
              
      - The LiteralParser should not use push(), since that may throw if we're having a bad time.
      
      * interpreter/Interpreter.cpp:
      (JSC::eval):
      * runtime/JSObject.h:
      (JSC::JSObject::putByIndexInline):
      (JSObject):
      (JSC::JSObject::putDirectIndex):
      * runtime/LiteralParser.cpp:
      (JSC::::parse):
      
      LayoutTests: 
      
      * fast/js/concat-while-having-a-bad-time.html: Added.
      * fast/js/concat-while-having-a-bad-time-expected.txt: Added.
      * fast/js/jsc-test-list:
      * fast/js/script-tests/concat-while-having-a-bad-time.js: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129432 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      44e841ff
    • roger_fong@apple.com's avatar
    • commit-queue@webkit.org's avatar
      [WK2] TestRunner does not support overridePreference with value "0" · 69fd8c41
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=97457
      
      Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-09-24
      Reviewed by Alexey Proskuryakov.
      
      Tools:
      
      testRunner.overridePreference() was marked as taking a boolean
      in argument in testRunner.idl even though the test cases are
      passing strings to it. The current code works if the test
      case wants to enable a setting and therefore passes "1" string.
      However, if the test wants to disable a setting and passes "0"
      string, the current code also evaluates this to true causing
      certain test cases to fail.
      
      The argument to testRunner.overridePreference() is now of string
      type and a function has been added to convert the string passed
      by the test to a boolean value.
      
      * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
      * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
      (WTR::toBool):
      (WTR):
      (WTR::TestRunner::overridePreference):
      * WebKitTestRunner/InjectedBundle/TestRunner.h:
      (TestRunner):
      
      LayoutTests:
      
      Unskip fast/regions/css-regions-disabled.html test case for
      WebKit2 now that WebKitTestRunner actually supports overriding
      a boolean preference with "0" value (to disable it).
      
      * platform/efl-wk2/TestExpectations:
      * platform/gtk-wk2/TestExpectations:
      * platform/mac-wk2/Skipped:
      * platform/qt-5.0-wk2/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129430 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      69fd8c41
    • pilgrim@chromium.org's avatar
      [Chromium][Mac] Remove loadFont from PlatformSupport · 32f73c9f
      pilgrim@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=97360
      
      Reviewed by Adam Barth.
      
      Part of a refactoring series. See tracking bug 82948.
      
      Source/WebCore:
      
      * platform/chromium/PlatformSupport.h:
      (PlatformSupport):
      * platform/graphics/chromium/CrossProcessFontLoading.mm:
      
      Source/WebKit/chromium:
      
      * src/PlatformSupport.cpp:
      (WebCore):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129429 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      32f73c9f
    • mark.lam@apple.com's avatar
      Added a missing "if VALUE_PROFILER" around an access to ArrayProfile record. · a39652e1
      mark.lam@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=97496.
      
      Reviewed by Filip Pizlo.
      
      * llint/LowLevelInterpreter32_64.asm:
      * llint/LowLevelInterpreter64.asm:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129428 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a39652e1
    • tony@chromium.org's avatar
      Replace 2 uses of updateLogicalHeight with computeLogicalHeight · c3853eca
      tony@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=97486
      
      Reviewed by Ojan Vafai.
      
      More work for bug 96804.  This is just a refactoring.
      
      No new tests, behavior should be the same as before.
      
      * rendering/RenderFlowThread.cpp:
      (WebCore::RenderFlowThread::computeLogicalHeight):
      * rendering/RenderFlowThread.h:
      * rendering/RenderMultiColumnFlowThread.cpp:
      (WebCore::RenderMultiColumnFlowThread::computeLogicalHeight):
      (WebCore):
      * rendering/RenderMultiColumnFlowThread.h:
      (RenderMultiColumnFlowThread):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129427 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c3853eca
    • ggaren@apple.com's avatar
      Inlined activation tear-off in the DFG · cd57a712
      ggaren@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=97487
      
      Reviewed by Filip Pizlo.
      
      * dfg/DFGOperations.cpp:
      * dfg/DFGOperations.h: Activation tear-off is always inlined now, so I
      removed its out-of-line implementation.
      
      * dfg/DFGSpeculativeJIT32_64.cpp:
      (JSC::DFG::SpeculativeJIT::compile):
      * dfg/DFGSpeculativeJIT64.cpp:
      (JSC::DFG::SpeculativeJIT::compile): Inlined the variable copy and update
      of JSVariableObject::m_registers. This usually turns into < 10 instructions,
      which is close to pure win as compared to the operation function call.
      
      * runtime/JSActivation.h:
      (JSActivation):
      (JSC::JSActivation::registersOffset):
      (JSC::JSActivation::tearOff):
      (JSC::JSActivation::isTornOff):
      (JSC):
      (JSC::JSActivation::storageOffset):
      (JSC::JSActivation::storage): Tiny bit of refactoring so the JIT can
      share the pointer math helper functions we use internally.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129426 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cd57a712
    • roger_fong@apple.com's avatar
      Unreviewed. Mark... · f923ed76
      roger_fong@apple.com authored
      Unreviewed. Mark http/tests/security/inactive-document-with-empty-security-origin.html while Geoff Garen
      investigates in https://bugs.webkit.org/show_bug.cgi?id=95530 in order to get the bots green.
      
      * platform/win/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129425 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f923ed76
    • kbr@google.com's avatar
      [V8] ArrayBuffer code should not pass a negative length to... · a188079a
      kbr@google.com authored
      [V8] ArrayBuffer code should not pass a negative length to SetIndexedPropertiesToExternalArrayData()
      https://bugs.webkit.org/show_bug.cgi?id=96703
      
      Reviewed by Adam Barth.
      
      Check length arguments that may be passed to SetIndexedPropertiesToExternalArrayData.
      
      No tests because it is not guaranteed that buffers this large can actually be allocated.
      
      * bindings/v8/custom/V8ArrayBufferViewCustom.h:
      (WebCore::wrapArrayBufferView):
      (WebCore::constructWebGLArrayWithArrayBufferArgument):
      (WebCore::constructWebGLArray):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129424 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a188079a
    • antti@apple.com's avatar
      Split stylesheet related code out from Document · e5a88a78
      antti@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=97353
      
      Reviewed by Andreas Kling.
      
      Document is big and unwieldy. The code related to tracking active stylesheets can be factored out.
              
      The patch moves stylesheet upkeep, collection and invalidation code from Document to a separate
      DocumentStyleSheetCollection class. There are no functional changes.
              
      The usesLinkRules stylesheet feature bit and the related code is removed as no one was using it.
      
      * WebCore.xcodeproj/project.pbxproj:
      * css/SelectorChecker.cpp:
      (WebCore::SelectorChecker::checkOneSelector):
      * css/StyleResolver.cpp:
      (WebCore::StyleResolver::StyleResolver):
      (WebCore::StyleResolver::Features::Features):
      (WebCore::StyleResolver::Features::add):
      (WebCore::StyleResolver::Features::clear):
      (WebCore::StyleResolver::collectMatchingRulesForList):
      * css/StyleResolver.h:
      (WebCore::StyleResolver::usesBeforeAfterRules):
      (Features):
      * dom/Document.cpp:
      (WebCore::Document::Document):
      (WebCore::Document::~Document):
      (WebCore::Document::setCompatibilityMode):
      (WebCore::Document::recalcStyle):
      (WebCore):
      (WebCore::Document::createStyleResolver):
      (WebCore::Document::seamlessParentUpdatedStylesheets):
      (WebCore::Document::didRemoveAllPendingStylesheet):
      (WebCore::Document::processHttpEquiv):
      (WebCore::Document::styleSheets):
      (WebCore::Document::preferredStylesheetSet):
      (WebCore::Document::selectedStylesheetSet):
      (WebCore::Document::setSelectedStylesheetSet):
      (WebCore::Document::styleResolverChanged):
      (WebCore::Document::reportMemoryUsage):
      (WebCore::Document::haveStylesheetsLoaded):
      * dom/Document.h:
      (WebCore):
      (Document):
      (WebCore::Document::styleSheetCollection):
      (WebCore::Document::hasNodesWithPlaceholderStyle):
      (WebCore::Document::setNeedsNotifyRemoveAllPendingStylesheet):
      (WebCore::Document::inStyleRecalc):
      * dom/DocumentStyleSheetCollection.cpp: Added.
      (WebCore):
      (WebCore::DocumentStyleSheetCollection::DocumentStyleSheetCollection):
      (WebCore::DocumentStyleSheetCollection::~DocumentStyleSheetCollection):
      (WebCore::DocumentStyleSheetCollection::pageUserSheet):
      (WebCore::DocumentStyleSheetCollection::clearPageUserSheet):
      (WebCore::DocumentStyleSheetCollection::updatePageUserSheet):
      (WebCore::DocumentStyleSheetCollection::pageGroupUserSheets):
      (WebCore::DocumentStyleSheetCollection::clearPageGroupUserSheets):
      (WebCore::DocumentStyleSheetCollection::updatePageGroupUserSheets):
      (WebCore::DocumentStyleSheetCollection::addUserSheet):
      (WebCore::DocumentStyleSheetCollection::removePendingSheet):
      (WebCore::DocumentStyleSheetCollection::addStyleSheetCandidateNode):
      (WebCore::DocumentStyleSheetCollection::removeStyleSheetCandidateNode):
      (WebCore::DocumentStyleSheetCollection::collectActiveStyleSheets):
      (WebCore::DocumentStyleSheetCollection::testAddedStyleSheetRequiresStyleRecalc):
      (WebCore::DocumentStyleSheetCollection::analyzeStyleSheetChange):
      (WebCore::styleSheetsUseRemUnits):
      (WebCore::DocumentStyleSheetCollection::updateActiveStyleSheets):
      (WebCore::DocumentStyleSheetCollection::combineCSSFeatureFlags):
      (WebCore::DocumentStyleSheetCollection::resetCSSFeatureFlags):
      (WebCore::DocumentStyleSheetCollection::reportMemoryUsage):
      * dom/DocumentStyleSheetCollection.h: Added.
      (WebCore):
      (DocumentStyleSheetCollection):
      (WebCore::DocumentStyleSheetCollection::authorStyleSheets):
      (WebCore::DocumentStyleSheetCollection::documentUserSheets):
      (WebCore::DocumentStyleSheetCollection::needsUpdateActiveStylesheetsOnStyleRecalc):
      (WebCore::DocumentStyleSheetCollection::preferredStylesheetSetName):
      (WebCore::DocumentStyleSheetCollection::selectedStylesheetSetName):
      (WebCore::DocumentStyleSheetCollection::setPreferredStylesheetSetName):
      (WebCore::DocumentStyleSheetCollection::setSelectedStylesheetSetName):
      (WebCore::DocumentStyleSheetCollection::addPendingSheet):
      (WebCore::DocumentStyleSheetCollection::hasPendingSheets):
      (WebCore::DocumentStyleSheetCollection::usesSiblingRules):
      (WebCore::DocumentStyleSheetCollection::setUsesSiblingRulesOverride):
      (WebCore::DocumentStyleSheetCollection::usesFirstLineRules):
      (WebCore::DocumentStyleSheetCollection::usesFirstLetterRules):
      (WebCore::DocumentStyleSheetCollection::setUsesFirstLetterRules):
      (WebCore::DocumentStyleSheetCollection::usesBeforeAfterRules):
      (WebCore::DocumentStyleSheetCollection::setUsesBeforeAfterRulesOverride):
      (WebCore::DocumentStyleSheetCollection::usesRemUnits):
      (WebCore::DocumentStyleSheetCollection::setUsesRemUnit):
      * dom/Element.cpp:
      (WebCore::Element::recalcStyle):
      * dom/ProcessingInstruction.cpp:
      (WebCore::ProcessingInstruction::~ProcessingInstruction):
      (WebCore::ProcessingInstruction::checkStyleSheet):
      (WebCore::ProcessingInstruction::sheetLoaded):
      (WebCore::ProcessingInstruction::insertedInto):
      (WebCore::ProcessingInstruction::removedFrom):
      * dom/StyleElement.cpp:
      (WebCore::StyleElement::insertedIntoDocument):
      (WebCore::StyleElement::removedFromDocument):
      (WebCore::StyleElement::clearDocumentData):
      (WebCore::StyleElement::createSheet):
      (WebCore::StyleElement::sheetLoaded):
      (WebCore::StyleElement::startLoadingDynamicSheet):
      * html/HTMLLinkElement.cpp:
      (WebCore::HTMLLinkElement::~HTMLLinkElement):
      (WebCore::HTMLLinkElement::insertedInto):
      (WebCore::HTMLLinkElement::removedFrom):
      (WebCore::HTMLLinkElement::addPendingSheet):
      (WebCore::HTMLLinkElement::removePendingSheet):
      * html/HTMLQuoteElement.cpp:
      (WebCore::HTMLQuoteElement::insertedInto):
      * html/HTMLViewSourceDocument.cpp:
      (WebCore::HTMLViewSourceDocument::HTMLViewSourceDocument):
      * mathml/MathMLMathElement.cpp:
      (WebCore::MathMLMathElement::insertedInto):
      * page/Page.cpp:
      (WebCore::Page::userStyleSheetLocationChanged):
      * page/PageGroup.cpp:
      (WebCore::PageGroup::resetUserStyleCacheInAllFrames):
      * rendering/RenderBR.cpp:
      (WebCore::RenderBR::lineHeight):
      * rendering/RenderBlock.cpp:
      (WebCore::RenderBlock::styleDidChange):
      (WebCore::RenderBlock::splitBlocks):
      (WebCore::RenderBlock::addChildIgnoringAnonymousColumnBlocks):
      (WebCore::RenderBlock::lineHeight):
      (WebCore::RenderBlock::updateFirstLetter):
      * rendering/RenderInline.cpp:
      (WebCore::RenderInline::styleDidChange):
      (WebCore::RenderInline::updateAlwaysCreateLineBoxes):
      (WebCore::RenderInline::addChildIgnoringContinuation):
      (WebCore::RenderInline::splitInlines):
      (WebCore::RenderInline::lineHeight):
      * rendering/RenderObject.cpp:
      (WebCore::RenderObject::uncachedFirstLineStyle):
      (WebCore::RenderObject::firstLineStyleSlowCase):
      * rendering/RenderObject.h:
      (WebCore::RenderObject::firstLineStyle):
      * rendering/RenderObjectChildList.cpp:
      (WebCore::RenderObjectChildList::updateBeforeAfterContent):
      * rendering/RenderTableRow.cpp:
      (WebCore::RenderTableRow::updateBeforeAndAfterContent):
      * rendering/RootInlineBox.cpp:
      (WebCore::RootInlineBox::verticalPositionForBox):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129423 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e5a88a78
    • roger_fong@apple.com's avatar
      Unreviewed. http/tests/security/sandboxed-iframe-form-top.html fails on Windows. · 76f40e59
      roger_fong@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=97485
      
      This test actually "passes" but is producing wrong output in whichever test proceeds it, thus causing that test to fail.
      
      * platform/win/Skipped:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129421 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      76f40e59
    • commit-queue@webkit.org's avatar
      [BlackBerry] Reverting implementation for 407 error pages · 6c65e821
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=97455
      
      Patch by Otto Derek Cheung <otcheung@rim.com> on 2012-09-24
      Reviewed by Rob Buis.
      
      Source/WebCore:
      
      Revert "[BlackBerry] Reverting implementation for 407 error pages"
      This reverts commit fda0a1b6.
      
      This revert also reverts commit 0cffe019
      due to dependency issues.
      
      * PlatformBlackBerry.cmake:
      * platform/blackberry/AuthenticationChallengeManager.cpp: Removed.
      * platform/blackberry/AuthenticationChallengeManager.h:
      * platform/blackberry/PageClientBlackBerry.h:
      * platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:
      (WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
      (WebCore::MediaPlayerPrivate::~MediaPlayerPrivate):
      (WebCore::MediaPlayerPrivate::onAuthenticationNeeded):
      (WebCore::MediaPlayerPrivate::notifyChallengeResult):
      * platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.h:
      (MediaPlayerPrivate):
      * platform/network/blackberry/NetworkJob.cpp:
      (WebCore::NetworkJob::NetworkJob):
      (WebCore::NetworkJob::handleNotifyStatusReceived):
      (WebCore::NetworkJob::notifyAuthReceived):
      (WebCore::NetworkJob::handleNotifyClose):
      (WebCore::NetworkJob::sendRequestWithCredentials):
      (WebCore::NetworkJob::notifyChallengeResult):
      * platform/network/blackberry/NetworkJob.h:
      (NetworkJob):
      
      Source/WebKit/blackberry:
      
      Revert "[BlackBerry] Really fix bug 95488 that user can get the
      authentication challenge dialog while the other tab has focus."
      https://bugs.webkit.org/show_bug.cgi?id=97348
      
      This reverts commit 0cffe019.
      
      * Api/BlackBerryGlobal.cpp:
      (BlackBerry::WebKit::globalInitialize):
      * Api/WebPage.cpp:
      (BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
      (BlackBerry::WebKit::WebPagePrivate::~WebPagePrivate):
      (BlackBerry::WebKit::WebPagePrivate::authenticationChallenge):
      (BlackBerry::WebKit::WebPage::setVisible):
      * Api/WebPage_p.h:
      (WebPagePrivate):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129419 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6c65e821
    • crogers@google.com's avatar
      [REGRESSION] Layout Test webaudio/biquad-getFrequencyResponse.html is failing · b36882e6
      crogers@google.com authored
      https://bugs.webkit.org/show_bug.cgi?id=97439
      
      Reviewed by Kenneth Russell.
      
      Fixes uninitialized member variable.
      
      This should fix flaky failing test: webaudio/biquad-getFrequencyResponse.html
      
      * Modules/webaudio/BiquadProcessor.cpp:
      (WebCore::BiquadProcessor::BiquadProcessor):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129418 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b36882e6
    • dpranke@chromium.org's avatar
      Narrow Chromium TestExpectations for some hidpi failures to be Linux-only. · a04486d8
      dpranke@chromium.org authored
      crbug.com/150682
      
      Unreviewed, expectations change.
      
      Also remove a no-longer-failing Mac expectation for
      compositing/overflow/overflow-scaled-descendant-overlapping.html
      
      * platform/chromium/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129417 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a04486d8
    • tony@chromium.org's avatar
      flex-grow should be 1 when omitted from flex shorthand · f72f3535
      tony@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=97480
      
      Reviewed by Ojan Vafai.
      
      Source/WebCore:
      
      We were using 0, based on an outdated version of the spec.
      
      Tests: css3/flexbox/flex-property-parsing.html
             css3/flexbox/flex-algorithm.html: New test case.
      
      * css/CSSParser.cpp:
      (WebCore::CSSParser::parseFlex):
      
      LayoutTests:
      
      Update tests due to default CSS value changes.
      
      * css3/flexbox/flex-algorithm-expected.txt:
      * css3/flexbox/flex-algorithm.html: Add test case using -webkit-flex: auto.
      * css3/flexbox/flex-property-parsing-expected.txt:
      * css3/flexbox/flex-property-parsing.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129414 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f72f3535
    • benjamin@webkit.org's avatar
      Add support for query encoding to WTFURL · 6aa72d8c
      benjamin@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=97422
      
      Reviewed by Adam Barth.
      
      Source/WebCore: 
      
      Add the Charset conversion on WebCore side.
      
      * platform/KURLWTFURL.cpp:
      (WebCore::KURL::KURL):
      (CharsetConverter):
      (WebCore::CharsetConverter::CharsetConverter):
      * platform/mac/KURLMac.mm:
      (WebCore::KURL::KURL):
      
      Source/WTF: 
      
      Expose character conversion through the new abstract class URLQueryCharsetConverter.
      URLQueryCharsetConverter is implemented by WebCore to expose the TextEncoding classes.
      
      Unfortunatelly that forces us to bring over URLBuffer in the public API. We may be able
      to mitigate that later when moving WTFURL to more templates.
      
      The change fixes 2 of the URL layout tests.
      
      * WTF.xcodeproj/project.pbxproj:
      * wtf/url/api/ParsedURL.cpp:
      (WTF::ParsedURL::ParsedURL):
      * wtf/url/api/ParsedURL.h:
      (ParsedURL):
      ParsedURL was using the same constructor for ParsedURLString, and URL without a base.
      That was a mistake on my part, I did not intend that, fixed it now :)
      
      * wtf/url/api/URLBuffer.h: Renamed from Source/WTF/wtf/url/src/URLBuffer.h.
      (URLBuffer):
      (WTF::URLBuffer::URLBuffer):
      (WTF::URLBuffer::~URLBuffer):
      (WTF::URLBuffer::at):
      (WTF::URLBuffer::set):
      (WTF::URLBuffer::capacity):
      (WTF::URLBuffer::length):
      (WTF::URLBuffer::data):
      (WTF::URLBuffer::setLength):
      (WTF::URLBuffer::append):
      (WTF::URLBuffer::grow):
      * wtf/url/api/URLQueryCharsetConverter.h: Added.
      (URLQueryCharsetConverter):
      (WTF::URLQueryCharsetConverter::URLQueryCharsetConverter):
      (WTF::URLQueryCharsetConverter::~URLQueryCharsetConverter):
      * wtf/url/src/URLCanon.h:
      (URLCanonicalizer):
      * wtf/url/src/URLCanonFilesystemurl.cpp:
      (WTF::URLCanonicalizer::canonicalizeFileSystemURL):
      (WTF::URLCanonicalizer::ReplaceFileSystemURL):
      * wtf/url/src/URLCanonFileurl.cpp:
      (WTF::URLCanonicalizer::CanonicalizeFileURL):
      (WTF::URLCanonicalizer::ReplaceFileURL):
      * wtf/url/src/URLCanonInternal.h:
      (URLCanonicalizer):
      * wtf/url/src/URLCanonQuery.cpp:
      (WTF::URLCanonicalizer::CanonicalizeQuery):
      (WTF::URLCanonicalizer::ConvertUTF16ToQueryEncoding):
      * wtf/url/src/URLCanonRelative.cpp:
      (WTF::URLCanonicalizer::resolveRelativeURL):
      * wtf/url/src/URLCanonStdURL.cpp:
      (WTF::URLCanonicalizer::CanonicalizeStandardURL):
      (WTF::URLCanonicalizer::ReplaceStandardURL):
      * wtf/url/src/URLUtil.cpp:
      (URLUtilities):
      (WTF::URLUtilities::canonicalize):
      (WTF::URLUtilities::resolveRelative):
      (WTF::URLUtilities::ReplaceComponents):
      * wtf/url/src/URLUtil.h:
      (URLUtilities):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129413 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6aa72d8c
    • benjamin@webkit.org's avatar
      Integrate most of GoogleURL in WTFURL · 5f163cc9
      benjamin@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=97405
      
      Reviewed by Adam Barth.
      
      Source/WebCore: 
      
      Loosen KURLWTFURL to be able to run most tests in Debug.
      
      * platform/KURLWTFURL.cpp:
      (WebCore::KURL::KURL):
      (WebCore::KURL::hasPort):
      (WebCore::KURL::user):
      (WebCore::KURL::pass):
      (WebCore::KURL::hasPath):
      (WebCore::KURL::path):
      (WebCore::KURL::query):
      (WebCore::KURL::fragmentIdentifier):
      (WebCore::KURL::fileSystemPath):
      
      Source/WTF: 
      
      This patch brings almost all of the implementatation of Google-URL in WTFURL
      with only minor changes.
      
      The changes from the original code are mostly:
      -Code cleaning.
      -Replace url_parse::Parsed by URLSegments.
      -Replace url_parse::Component by URLComponent
      -More code cleaning.
      -Adopt URLBuffer and RawURLBuffer instead of the CanonOutputT and RawCanonOutputT.
      -Use URLCharacterTypes instead of the litany of characters functions.
      -Some more code cleaning.
      -Fix the style to match WebKit as much as possible.
      -Rename the files to match WebKit style.
      
      * WTF.xcodeproj/project.pbxproj:
      * wtf/url/api/ParsedURL.cpp:
      (WTF::ParsedURL::ParsedURL):
      (WTF::ParsedURL::segment):
      * wtf/url/api/ParsedURL.h:
      (WTF::ParsedURL::isValid):
      * wtf/url/src/RawURLBuffer.h:
      * wtf/url/src/URLCanon.h: Added.
      (URLCanonicalizer):
      (CharsetConverter):
      (WTF::URLCanonicalizer::CharsetConverter::CharsetConverter):
      (WTF::URLCanonicalizer::CharsetConverter::~CharsetConverter):
      (CanonHostInfo):
      (WTF::URLCanonicalizer::CanonHostInfo::CanonHostInfo):
      (WTF::URLCanonicalizer::CanonHostInfo::IsIPAddress):
      (WTF::URLCanonicalizer::CanonHostInfo::AddressLength):
      (URLComponentSource):
      (WTF::URLCanonicalizer::URLComponentSource::URLComponentSource):
      (Replacements):
      (WTF::URLCanonicalizer::Replacements::Replacements):
      (WTF::URLCanonicalizer::Replacements::SetScheme):
      (WTF::URLCanonicalizer::Replacements::IsSchemeOverridden):
      (WTF::URLCanonicalizer::Replacements::SetUsername):
      (WTF::URLCanonicalizer::Replacements::ClearUsername):
      (WTF::URLCanonicalizer::Replacements::IsUsernameOverridden):
      (WTF::URLCanonicalizer::Replacements::SetPassword):
      (WTF::URLCanonicalizer::Replacements::ClearPassword):
      (WTF::URLCanonicalizer::Replacements::IsPasswordOverridden):
      (WTF::URLCanonicalizer::Replacements::SetHost):
      (WTF::URLCanonicalizer::Replacements::ClearHost):
      (WTF::URLCanonicalizer::Replacements::IsHostOverridden):
      (WTF::URLCanonicalizer::Replacements::SetPort):
      (WTF::URLCanonicalizer::Replacements::ClearPort):
      (WTF::URLCanonicalizer::Replacements::IsPortOverridden):
      (WTF::URLCanonicalizer::Replacements::SetPath):
      (WTF::URLCanonicalizer::Replacements::ClearPath):
      (WTF::URLCanonicalizer::Replacements::IsPathOverridden):
      (WTF::URLCanonicalizer::Replacements::SetQuery):
      (WTF::URLCanonicalizer::Replacements::ClearQuery):
      (WTF::URLCanonicalizer::Replacements::IsQueryOverridden):
      (WTF::URLCanonicalizer::Replacements::SetRef):
      (WTF::URLCanonicalizer::Replacements::ClearRef):
      (WTF::URLCanonicalizer::Replacements::IsRefOverridden):
      (WTF::URLCanonicalizer::Replacements::sources):
      (WTF::URLCanonicalizer::Replacements::components):
      (WTF::URLCanonicalizer::Replacements::Placeholder):
      * wtf/url/src/URLCanonEtc.cpp: Added.
      (WTF::URLCanonicalizer::removeURLWhitespace):
      (URLCanonicalizer):
      (WTF::URLCanonicalizer::canonicalSchemeChar):
      (WTF::URLCanonicalizer::CanonicalizeScheme):
      (WTF::URLCanonicalizer::CanonicalizeUserInfo):
      (WTF::URLCanonicalizer::CanonicalizePort):
      (WTF::URLCanonicalizer::CanonicalizeRef):
      * wtf/url/src/URLCanonFilesystemurl.cpp: Added.
      (WTF::URLCanonicalizer::CanonicalizeFileSystemURL):
      (URLCanonicalizer):
      (WTF::URLCanonicalizer::ReplaceFileSystemURL):
      * wtf/url/src/URLCanonFileurl.cpp: Added.
      (WTF::URLCanonicalizer::CanonicalizeFileURL):
      (URLCanonicalizer):
      (WTF::URLCanonicalizer::FileCanonicalizePath):
      (WTF::URLCanonicalizer::ReplaceFileURL):
      * wtf/url/src/URLCanonHost.cpp: Added.
      (WTF::URLCanonicalizer::CanonicalizeHost):
      (URLCanonicalizer):
      (WTF::URLCanonicalizer::CanonicalizeHostVerbose):
      * wtf/url/src/URLCanonICU.cpp: Added.
      (WTF::URLCanonicalizer::IDNToASCII):
      (URLCanonicalizer):
      (WTF::URLCanonicalizer::readUTFChar):
      * wtf/url/src/URLCanonIP.cpp: Added.
      (WTF::URLCanonicalizer::CanonicalizeIPAddress):
      (URLCanonicalizer):
      * wtf/url/src/URLCanonInternal.cpp: Added.
      (URLCanonicalizer):
      (WTF::URLCanonicalizer::AppendInvalidNarrowString):
      (WTF::URLCanonicalizer::ConvertUTF16ToUTF8):
      (WTF::URLCanonicalizer::ConvertUTF8ToUTF16):
      (WTF::URLCanonicalizer::SetupOverrideComponents):
      (WTF::URLCanonicalizer::SetupUTF16OverrideComponents):
      (WTF::URLCanonicalizer::_itoa_s):
      (WTF::URLCanonicalizer::_itow_s):
      * wtf/url/src/URLCanonInternal.h: Added.
      (URLCanonicalizer):
      (WTF::URLCanonicalizer::hexCharToValue):
      (WTF::URLCanonicalizer::isDot):
      (WTF::URLCanonicalizer::appendURLEscapedCharacter):
      (WTF::URLCanonicalizer::doAppendUTF8):
      (WTF::URLCanonicalizer::AppendCharToOutput):
      (WTF::URLCanonicalizer::AppendUTF8Value):
      (WTF::URLCanonicalizer::AppendUTF8EscapedValue):
      (WTF::URLCanonicalizer::AppendUTF16Value):
      (WTF::URLCanonicalizer::AppendUTF8EscapedChar):
      (WTF::URLCanonicalizer::Is8BitChar):
      (WTF::URLCanonicalizer::DecodeEscaped):
      (WTF::URLCanonicalizer::_itoa_s):
      (WTF::URLCanonicalizer::_itow_s):
      (WTF::URLCanonicalizer::_strtoui64):
      * wtf/url/src/URLCanonMailto.cpp: Added.
      (WTF::URLCanonicalizer::CanonicalizeMailtoURL):
      (URLCanonicalizer):
      (WTF::URLCanonicalizer::ReplaceMailtoURL):
      * wtf/url/src/URLCanonPath.cpp: Added.
      (WTF::URLCanonicalizer::CanonicalizePath):
      (URLCanonicalizer):
      (WTF::URLCanonicalizer::CanonicalizePartialPath):
      * wtf/url/src/URLCanonPathurl.cpp: Added.
      (WTF::URLCanonicalizer::canonicalizePathURL):
      (URLCanonicalizer):
      (WTF::URLCanonicalizer::ReplacePathURL):
      * wtf/url/src/URLCanonQuery.cpp: Added.
      (WTF::URLCanonicalizer::CanonicalizeQuery):
      (URLCanonicalizer):
      (WTF::URLCanonicalizer::ConvertUTF16ToQueryEncoding):
      * wtf/url/src/URLCanonRelative.cpp: Added.
      (WTF::URLCanonicalizer::isRelativeURL):
      (URLCanonicalizer):
      (WTF::URLCanonicalizer::resolveRelativeURL):
      * wtf/url/src/URLCanonStdURL.cpp: Added.
      (WTF::URLCanonicalizer::DefaultPortForScheme):
      (URLCanonicalizer):
      (WTF::URLCanonicalizer::CanonicalizeStandardURL):
      (WTF::URLCanonicalizer::ReplaceStandardURL):
      * wtf/url/src/URLCharacterTypes.cpp:
      * wtf/url/src/URLCharacterTypes.h:
      (WTF::URLCharacterTypes::isComponentChar):
      (WTF::URLCharacterTypes::isHexChar):
      (WTF::URLCharacterTypes::isIPv4Char):
      (WTF::URLCharacterTypes::isQueryChar):
      (WTF::URLCharacterTypes::isCharacterOfType):
      (URLCharacterTypes):
      * wtf/url/src/URLEscape.cpp: Removed.
      * wtf/url/src/URLFile.h: Added.
      (URLParser):
      (WTF::URLParser::isWindowsDriveSeparator):
      (WTF::URLParser::isWindowsDriveLetter):
      (WTF::URLParser::findNextSlash):
      (WTF::URLParser::doesBeginWindowsDriveSpec):
      (WTF::URLParser::doesBeginUNCPath):
      * wtf/url/src/URLParse.cpp: Added.
      (WTF::URLParser::ExtractScheme):
      (URLParser):
      (WTF::URLParser::IsAuthorityTerminator):
      (WTF::URLParser::ExtractFileName):
      (WTF::URLParser::ExtractQueryKeyValue):
      (WTF::URLParser::ParseAuthority):
      (WTF::URLParser::ParsePort):
      (WTF::URLParser::ParseStandardURL):
      (WTF::URLParser::ParsePathURL):
      (WTF::URLParser::ParseFileSystemURL):
      (WTF::URLParser::ParseMailtoURL):
      (WTF::URLParser::parsePathInternal):
      (WTF::URLParser::ParseAfterScheme):
      * wtf/url/src/URLParse.h: Added.
      (URLParser):
      * wtf/url/src/URLParseFile.cpp: Added.
      (WTF):
      (WTF::URLParser::ParseFileURL):
      (URLParser):
      * wtf/url/src/URLParseInternal.h: Added.
      (URLParser):
      (WTF::URLParser::isURLSlash):
      (WTF::URLParser::shouldTrimFromURL):
      (WTF::URLParser::trimURL):
      (WTF::URLParser::countConsecutiveSlashes):
      * wtf/url/src/URLParser.h: Removed.
      * wtf/url/src/URLQueryCanonicalizer.h: Removed.
      * wtf/url/src/URLSegments.cpp:
      * wtf/url/src/URLSegments.h:
      (WTF::URLSegments::URLSegments):
      (URLSegments):
      (WTF::URLSegments::operator=):
      (WTF::URLSegments::innerURLSegments):
      (WTF::URLSegments::setInnerURLSegments):
      (WTF::URLSegments::clearInnerURLSegments):
      * wtf/url/src/URLUtil.cpp: Added.
      (URLUtilities):
      (WTF::URLUtilities::IsStandard):
      (WTF::URLUtilities::FindAndCompareScheme):
      (WTF::URLUtilities::Canonicalize):
      (WTF::URLUtilities::resolveRelative):
      (WTF::URLUtilities::ReplaceComponents):
      (WTF::URLUtilities::LowerCaseEqualsASCII):
      (WTF::URLUtilities::DecodeURLEscapeSequences):
      (WTF::URLUtilities::EncodeURIComponent):
      (WTF::URLUtilities::CompareSchemeComponent):
      * wtf/url/src/URLUtil.h: Added.
      (URLUtilities):
      * wtf/url/src/URLUtilInternal.h: Renamed from Source/WTF/wtf/url/src/URLEscape.h.
      (URLUtilities):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129412 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5f163cc9
    • commit-queue@webkit.org's avatar
      [CSS Exclusions] ExclusionShape API should use logical coordinates for input/output · 5678f008
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=96156
      
      Patch by Hans Muller <hmuller@adobe.com> on 2012-09-24
      Reviewed by Dirk Schulze.
      
      Source/WebCore:
      
      Correct how ExclusionShapes deal with logical coordinates and enable
      shape-inside exclusion layout for vertical writing-modes.
      
      BasicShape's are defined in physical cooordinates, incoming line and box
      dimensions are logical coordinates, and the ExclusionShape internals assume
      that lines are aligned with the Y axis. The createExclusionShape() method
      is responsible for converting the BasicShape to the internal coordinate
      system when the writing-mode is vertical. Similarly, the getInclude,ExcludedIntervals()
      methods are responsible for converting their logical line parameters to Y
      values in the internal coordinate system. The min,maxYForLogicalLine()
      methods do the conversion, based on the WritingMode the ExclusionShape
      was created with. The getInclude,ExcludedIntervals() methods return the
      logical left and right edges of line segments. No transformation is needed for this.
      
      The ExclusionShape's internal coordinate system is essentially the
      "logical" one, except that top/bottom always map to Y, no matter what
      the writing-mode is.  This is just to simplify writing geometrical shape
      algorithms, notably the complex ones for polygons. The bug report includes a
      pair of diagrams that clarify how internal coordinates are related to logical
      and physical coordinates.
      
      Test: fast/exclusions/shape-inside/shape-inside-vertical-text.html
      
      * rendering/ExclusionRectangle.cpp:
      (WebCore::ExclusionRectangle::getExcludedIntervals): rename more accurately reflects return value
      (WebCore::ExclusionRectangle::getIncludedIntervals): rename for consistency with "excluded" version
      * rendering/ExclusionRectangle.h:
      * rendering/ExclusionShape.cpp:
      (WebCore):
      (WebCore::ExclusionShape::createExclusionShape):
      * rendering/ExclusionShape.h:
      (LineSegment):
      (WebCore::LineSegment::LineSegment): relocated from WrapShapeInfo.h
      (WebCore):
      (ExclusionShape):
      (WebCore::ExclusionShape::minYForLogicalLine):
      (WebCore::ExclusionShape::maxYForLogicalLine):
      (WebCore::ExclusionShape::internalToLogicalBoundingBox):
      * rendering/WrapShapeInfo.cpp:
      (WebCore::WrapShapeInfo::isWrapShapeInfoEnabledForRenderBlock):
      (WebCore::WrapShapeInfo::computeShapeSize): pass writingMode to createExclusionShape()
      (WebCore::WrapShapeInfo::computeSegmentsForLine): removed short-circuit for vertical writing-modes
      * rendering/WrapShapeInfo.h:
      (WebCore):
      
      LayoutTests:
      
      Verify that shape-inside respects the writing-mode, notably the vertical writing-modes.
      
      * fast/exclusions/shape-inside/shape-inside-vertical-text-expected.html: Added.
      * fast/exclusions/shape-inside/shape-inside-vertical-text.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129411 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5678f008
    • commit-queue@webkit.org's avatar
      Rebaseline for r129389 · 769514ed
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=97473
      
      Unreviewed.
      
      Patch by Alec Flett <alecflett@chromium.org> on 2012-09-24
      
      * platform/chromium-mac-snowleopard/fast/text/emphasis-expected.png:
      * platform/chromium-mac-snowleopard/fast/writing-mode/text-orientation-basic-expected.png:
      * platform/chromium-mac-snowleopard/fast/writing-mode/text-orientation-basic-expected.txt:
      * platform/chromium-mac/fast/text/emphasis-expected.png:
      * platform/chromium-mac/fast/writing-mode/text-orientation-basic-expected.png:
      * platform/chromium-mac/fast/writing-mode/text-orientation-basic-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129410 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      769514ed
    • tony@chromium.org's avatar
      Replace RenderMeter::updateLogicalHeight to RenderMeter::computeLogicalHeight · 845cf6e1
      tony@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=97475
      
      Reviewed by Ojan Vafai.
      
      Using RenderMeter::computeLogicalHeight is part of bug 96804.
      Also fix some code to be vertical writing mode aware. This doesn't actually cause
      a behavioral difference because we use percentage heights/widths which don't depend on
      updateLogicalWidth or computeLogicalHeight.  You can still see bugs if you try to set
      the min-width on a <meter> node in a vertical writing mode.
      
      No new tests, no behavioral changes.
      
      * rendering/RenderMeter.cpp:
      (WebCore::RenderMeter::updateLogicalWidth): Make vertical writing mode aware.
      (WebCore::RenderMeter::computeLogicalHeight): Switch from updateLogicalHeight and make vertical writing mode aware.
      * rendering/RenderMeter.h:
      (RenderMeter):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129409 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      845cf6e1
    • dglazkov@chromium.org's avatar
      Remove unbaked support for :scope pseudo-class. · 2f0a4c13
      dglazkov@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=97467
      
      Reviewed by Antti Koivisto.
      
      It turns out, the Selectors 4 require ":scope" to match contextual reference element set, which would be the root node in querySelector:
      http://dev.w3.org/csswg/selectors4/#the-scope-pseudo
      
      Right now, we simply make ":scope" equivalent to ":root", which is not correct. Let's remove the partial implementation until we have
      time/energy to fully implement it.
      
      Source/WebCore:
      
      No new tests, removing half-baked feature.
      
      * css/CSSSelector.cpp:
      (WebCore::CSSSelector::pseudoId): Removed all mentions of PseudoScope
      (WebCore::nameToPseudoTypeMap): Ditto.
      (WebCore::CSSSelector::extractPseudoType): Ditto.
      * css/CSSSelector.h: Ditto.
      * css/SelectorChecker.cpp:
      (WebCore::SelectorChecker::checkOneSelector): Ditto.
      
      LayoutTests:
      
      * fast/css/style-scoped/scope-pseudo-expected.txt: Removed.
      * fast/css/style-scoped/scope-pseudo.html: Removed.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129408 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2f0a4c13
    • ossy@webkit.org's avatar
      Unreviewed, rolling out r129343. · 7fa15457
      ossy@webkit.org authored
      http://trac.webkit.org/changeset/129343
      https://bugs.webkit.org/show_bug.cgi?id=97479
      
      It broke the build (Requested by Ossy_NIGHT on #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-09-24
      
      .:
      
      * Source/api.pri:
      
      Tools:
      
      * qmake/mkspecs/features/default_pre.prf:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129407 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7fa15457
    • rniwa@webkit.org's avatar
      suspend/resumeWidgetHierarchyUpdates should be a RAII object · 04ec298c
      rniwa@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=96706
      
      Reviewed by Simon Fraser.
      
      Source/WebCore: 
      
      Replaced suspendWidgetHierarchyUpdates and resumeWidgetHierarchyUpdates by WidgetHierarchyUpdatesSuspensionScope.
      
      * WebCore.exp.in: Export new symbols.
      * dom/ContainerNode.cpp:
      (WebCore::ContainerNode::removeChild):
      (WebCore::ContainerNode::removeChildren):
      * dom/Document.cpp:
      (WebCore::Document::recalcStyle):
      * dom/Element.cpp:
      (WebCore::Element::attach):
      (WebCore::Element::detach):
      * page/mac/EventHandlerMac.mm:
      (WebCore::EventHandler::passMouseDownEventToWidget):
      * rendering/RenderWidget.cpp:
      (WebCore):
      (WebCore::WidgetHierarchyUpdatesSuspensionScope::widgetNewParentMap):
      (WebCore::WidgetHierarchyUpdatesSuspensionScope::moveWidgets):
      (WebCore::moveWidgetToParentSoon):
      * rendering/RenderWidget.h:
      (WidgetHierarchyUpdatesSuspensionScope):
      (WebCore::WidgetHierarchyUpdatesSuspensionScope::WidgetHierarchyUpdatesSuspensionScope):
      (WebCore::WidgetHierarchyUpdatesSuspensionScope::~WidgetHierarchyUpdatesSuspensionScope):
      (WebCore::WidgetHierarchyUpdatesSuspensionScope::isSuspended):
      (WebCore::WidgetHierarchyUpdatesSuspensionScope::scheduleWidgetToMove):
      (WebCore):
      (RenderWidget):
      
      Source/WebKit/mac: 
      
      * WebView/WebHTMLView.mm:
      (-[WebHTMLView _invalidateGStatesForTree]):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129406 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      04ec298c
    • roger_fong@apple.com's avatar
      Unreviewed. accessibility/svg-bounds.html crashes on Windows due to use of AX... · fc7828f0
      roger_fong@apple.com authored
      Unreviewed. accessibility/svg-bounds.html crashes on Windows due to use of AX role which hasn't been properly implemented on Windows.
      
      * platform/win/Skipped:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129405 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fc7828f0
    • commit-queue@webkit.org's avatar
      [BlackBerry] Reverting implementation for 407 error pages · fda0a1b6
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=97455
      
      Patch by Otto Derek Cheung <otcheung@rim.com> on 2012-09-24
      Reviewed by Rob Buis.
      
      Revert "[BlackBerry] Show custom error page when 407 is received"
      This reverts commit e6d14529428fe47916fcb997528095b8acad2f2b.
      
      * platform/network/blackberry/NetworkJob.cpp:
      (WebCore::NetworkJob::handleNotifyStatusReceived):
      (WebCore::NetworkJob::notifyAuthReceived):
      (WebCore::NetworkJob::sendRequestWithCredentials):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129404 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fda0a1b6
    • commit-queue@webkit.org's avatar
      Unreviewed, rolling out r129388. · c4157489
      commit-queue@webkit.org authored
      http://trac.webkit.org/changeset/129388
      https://bugs.webkit.org/show_bug.cgi?id=97477
      
      Caused an assertion in a WebKit2 unit test (Requested by
      abarth on #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-09-24
      
      .:
      
      * Source/autotools/symbols.filter:
      
      Source/WebCore:
      
      * WebCore.exp.in:
      * loader/FrameLoader.cpp:
      (WebCore::FrameLoader::didBeginDocument):
      * loader/SubresourceLoader.cpp:
      (WebCore::SubresourceLoader::willSendRequest):
      * loader/cache/CachedImage.cpp:
      * loader/cache/CachedImage.h:
      (WebCore::CachedImage::stillNeedsLoad):
      (CachedImage):
      * loader/cache/CachedResource.cpp:
      (WebCore::CachedResource::didAddClient):
      * loader/cache/CachedResource.h:
      (WebCore):
      * loader/cache/CachedResourceLoader.cpp:
      (WebCore::CachedResourceLoader::CachedResourceLoader):
      (WebCore::CachedResourceLoader::requestImage):
      (WebCore::CachedResourceLoader::canRequest):
      (WebCore::CachedResourceLoader::requestResource):
      (WebCore::CachedResourceLoader::revalidateResource):
      (WebCore::CachedResourceLoader::loadResource):
      (WebCore::CachedResourceLoader::determineRevalidationPolicy):
      (WebCore::CachedResourceLoader::setAutoLoadImages):
      * loader/cache/CachedResourceLoader.h:
      (CachedResourceLoader):
      * page/Settings.cpp:
      (WebCore::setLoadsImagesAutomaticallyInAllFrames):
      (WebCore::Settings::Settings):
      (WebCore::Settings::setLoadsImagesAutomatically):
      (WebCore::Settings::loadsImagesAutomaticallyTimerFired):
      (WebCore::Settings::setImagesEnabled):
      * page/Settings.h:
      (Settings):
      * testing/InternalSettings.cpp:
      (WebCore::InternalSettings::Backup::Backup):
      (WebCore::InternalSettings::Backup::restoreTo):
      * testing/InternalSettings.h:
      (Backup):
      (InternalSettings):
      * testing/InternalSettings.idl:
      
      Source/WebKit2:
      
      * win/WebKit2.def:
      
      LayoutTests:
      
      * fast/loader/display-image-unset-allows-cached-image-load-expected.txt: Removed.
      * fast/loader/display-image-unset-allows-cached-image-load.html: Removed.
      * fast/loader/display-image-unset-can-block-image-and-can-reload-in-place-expected.txt: Removed.
      * fast/loader/display-image-unset-can-block-image-and-can-reload-in-place.html: Removed.
      * fast/loader/images-enabled-unset-can-block-image-and-can-reload-in-place-expected.txt: Removed.
      * fast/loader/images-enabled-unset-can-block-image-and-can-reload-in-place.html: Removed.
      * fast/loader/resources/image1.html: Removed.
      * fast/loader/resources/image2.html: Removed.
      * platform/chromium/permissionclient/image-permissions-expected.txt:
      * platform/chromium/permissionclient/image-permissions.html:
      * platform/chromium/permissionclient/resources/image.html:
      * platform/wk2/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129402 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c4157489
    • arv@chromium.org's avatar
      DOM4 remove method · 8b0430f0
      arv@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=73885
      
      Reviewed by Ojan Vafai.
      
      This adds the DOM 4 remove method.
      
      http://dvcs.w3.org/hg/domcore/raw-file/tip/Overview.html#dom-childnode-remove
      
      The remove method removes the node from its parent if it has a parent.
      
      Source/WebCore:
      
      Tests: fast/dom/Comment/remove.html
             fast/dom/DocumentType/remove.html
             fast/dom/Element/remove.html
             fast/dom/Text/remove.html
      
      * dom/CharacterData.idl:
      * dom/DocumentType.idl:
      * dom/Element.idl:
      * dom/Node.cpp:
      (WebCore::Node::remove): The spec says to do nothing if the node has no parent.
      * html/parser/HTMLTreeBuilder.cpp:
      (WebCore::HTMLTreeBuilder::processStartTagForInBody): Cleanup.
      * html/track/TextTrackCue.cpp:
      (WebCore::TextTrackCue::removeDisplayTree): No need to check parenNode twice.
      
      LayoutTests:
      
      * fast/dom/Comment/remove-expected.txt: Added.
      * fast/dom/Comment/remove.html: Added.
      * fast/dom/DocumentType/remove-expected.txt: Added.
      * fast/dom/DocumentType/remove.html: Added.
      * fast/dom/Element/remove-expected.txt: Added.
      * fast/dom/Element/remove.html: Added.
      * fast/dom/Text/remove-expected.txt: Added.
      * fast/dom/Text/remove.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129400 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8b0430f0
    • commit-queue@webkit.org's avatar
      [GTK] Add Select All method to WebKit2 GTK+ API · 5693f3c5
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=97460
      
      Patch by Simon Pena <spena@igalia.com> on 2012-09-24
      Reviewed by Martin Robinson.
      
      Following the same approach used when added Cut, Copy and Paste,
      the Select All method is added to the WebKit2 GTK+ API.
      
      This introduces a new macro in the WebKitEditingCommands,
      updates the documentation, and includes a new unit test.
      
      * UIProcess/API/gtk/WebKitEditingCommands.h: Add a new macro for
      the Select All command.
      * UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Include the Select All
      command in the documentation.
      * UIProcess/API/gtk/tests/TestWebViewEditor.cpp: Cover the new command
      with a unit test.
      (testWebViewEditorSelectAll):
      (beforeAll):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129399 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5693f3c5
    • roger_fong@apple.com's avatar
      Unreviewed. Removing Windows specific results for... · 1bb443f1
      roger_fong@apple.com authored
      Unreviewed. Removing Windows specific results for fast/text/international/float-as-only-child-of-isolate-crash that were added in https://bugs.webkit.org/show_bug.cgi?id=87998.
      Test now passes properly.
      
      * platform/win/fast/text/international/float-as-only-child-of-isolate-crash-expected.png: Removed.
      * platform/win/fast/text/international/float-as-only-child-of-isolate-crash-expected.txt: Removed.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129398 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1bb443f1
    • tommyw@google.com's avatar
      MediaStream API: Fix the incorrectly spelled RTCPeerConnection::onnegotiationneeded callback · 8d37900d
      tommyw@google.com authored
      https://bugs.webkit.org/show_bug.cgi?id=97456
      
      Reviewed by Adam Barth.
      
      Renamed onnegotationneeded to onnegotiationneeded.
      
      Source/WebCore:
      
      Existing test updated.
      
      * Modules/mediastream/RTCPeerConnection.cpp:
      (WebCore::RTCPeerConnection::negotiationNeeded):
      * Modules/mediastream/RTCPeerConnection.h:
      (RTCPeerConnection):
      * Modules/mediastream/RTCPeerConnection.idl:
      * dom/EventNames.h:
      (WebCore):
      
      LayoutTests:
      
      * fast/mediastream/RTCPeerConnection-onnegotiationneeded-expected.txt:
      * fast/mediastream/RTCPeerConnection-onnegotiationneeded.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129397 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8d37900d
    • tony@chromium.org's avatar
      Unreviewed. Rolled DEPS. · c42c420b
      tony@chromium.org authored
      * DEPS:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129396 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c42c420b
    • dominik.rottsches@intel.com's avatar
      [EFL][DRT] Enable Regions support · dfe84c84
      dominik.rottsches@intel.com authored
      https://bugs.webkit.org/show_bug.cgi?id=83897
      
      Reviewed by Kenneth Rohde Christiansen.
      
      .:
      
      Default build setting for CSS regions set to on.
      
      * Source/cmake/OptionsEfl.cmake:
      
      Source/WebKit/efl:
      
      Activating CSS regions by default for EWK views.
      
      * ewk/ewk_view.cpp: Switch CSS regions on by default.
      (_ewk_view_priv_new):
      
      LayoutTests:
      
      New baselines for CSS regions, some CSS regions test still in TestExpectations.
      
      * platform/efl-wk2/TestExpectations: fast/regions/css-regions-disabled.html still failing on wk2.
      * platform/efl/TestExpectations: Some remaining CSS regions cases still skipped.
      * platform/efl/fast/regions/absolute-pos-elem-in-named-flow-expected.txt: Added.
      * platform/efl/fast/regions/autoheight-regions-mark-expected.png: Added.
      * platform/efl/fast/regions/autoheight-regions-mark-expected.txt: Added.
      * platform/efl/fast/regions/autowidth-attachedinvalidregion-expected.txt: Added.
      * platform/efl/fast/regions/bottom-overflow-out-of-first-region-expected.png: Added.
      * platform/efl/fast/regions/bottom-overflow-out-of-first-region-expected.txt: Added.
      * platform/efl/fast/regions/content-flowed-into-regions-no-scroll-expected.txt: Added.
      * platform/efl/fast/regions/content-webkit-from-flow-parsing-expected.txt: Added.
      * platform/efl/fast/regions/element-region-overset-state-expected.txt: Added.
      * platform/efl/fast/regions/element-region-overset-state-negative-letter-spacing-expected.txt: Added.
      * platform/efl/fast/regions/element-region-overset-state-vertical-rl-expected.txt: Added.
      * platform/efl/fast/regions/element-region-overset-state-vertical-rl-negative-letter-spacing-expected.txt: Added.
      * platform/efl/fast/regions/fixed-pos-elem-in-named-flow-expected.txt: Added.
      * platform/efl/fast/regions/fixed-pos-elem-in-named-flow2-expected.txt: Added.
      * platform/efl/fast/regions/flexbox-in-region-crash-expected.txt: Added.
      * platform/efl/fast/regions/flow-anonymous-children-expected.txt: Added.
      * platform/efl/fast/regions/flow-content-basic-expected.png: Added.
      * platform/efl/fast/regions/flow-content-basic-expected.txt: Added.
      * platform/efl/fast/regions/flow-content-basic-vertical-expected.png: Added.
      * platform/efl/fast/regions/flow-content-basic-vertical-expected.txt: Added.
      * platform/efl/fast/regions/flow-content-basic-vertical-rl-expected.png: Added.
      * platform/efl/fast/regions/flow-content-basic-vertical-rl-expected.txt: Added.
      * platform/efl/fast/regions/flow-region-into-itself-crash-expected.txt: Added.
      * platform/efl/fast/regions/flowed-content-bounding-client-rect-expected.txt: Added.
      * platform/efl/fast/regions/flowed-content-bounding-client-rect-horizontal-bt-expected.txt: Added.
      * platform/efl/fast/regions/flowed-content-bounding-client-rect-vertical-expected.txt: Added.
      * platform/efl/fast/regions/flowed-content-bounding-client-rect-vertical-rl-expected.txt: Added.
      * platform/efl/fast/regions/flowed-content-transform-bounding-client-rect-expected.txt: Added.
      * platform/efl/fast/regions/flows-dependency-dynamic-remove-expected.png: Added.
      * platform/efl/fast/regions/flows-dependency-dynamic-remove-expected.txt: Added.
      * platform/efl/fast/regions/flows-dependency-same-flow-expected.png: Added.
      * platform/efl/fast/regions/flows-dependency-same-flow-expected.txt: Added.
      * platform/efl/fast/regions/get-region-flow-ranges-absolute-pos-expected.txt: Added.
      * platform/efl/fast/regions/get-region-flow-ranges-content-nodes-expected.txt: Added.
      * platform/efl/fast/regions/get-region-flow-ranges-display-none-expected.txt: Added.
      * platform/efl/fast/regions/get-region-flow-ranges-empty-regions-expected.txt: Added.
      * platform/efl/fast/regions/get-region-flow-ranges-expected.txt: Added.
      * platform/efl/fast/regions/get-region-flow-ranges-fixed-pos-expected.txt: Added.
      * platform/efl/fast/regions/get-region-flow-ranges-horiz-bt-expected.txt: Added.
      * platform/efl/fast/regions/get-region-flow-ranges-inline-only-expected.txt: Added.
      * platform/efl/fast/regions/get-region-flow-ranges-text-expected.txt: Added.
      * platform/efl/fast/regions/get-region-flow-ranges-text-vert-lr-expected.txt: Added.
      * platform/efl/fast/regions/get-region-flow-ranges-vert-lr-expected.txt: Added.
      * platform/efl/fast/regions/get-region-flow-ranges-vert-rl-expected.txt: Added.
      * platform/efl/fast/regions/get-region-flow-ranges-writing-modes-rl-rb-lr-expected.txt: Added.
      * platform/efl/fast/regions/get-region-flow-ranges-writing-modes-tb-rl-lr-expected.txt: Added.
      * platform/efl/fast/regions/get-regions-by-content-expected.txt: Added.
      * platform/efl/fast/regions/get-regions-by-content-horiz-bt-expected.txt: Added.
      * platform/efl/fast/regions/get-regions-by-content-horiz-tb-expected.txt: Added.
      * platform/efl/fast/regions/get-regions-by-content-vert-lr-expected.txt: Added.
      * platform/efl/fast/regions/get-regions-by-content-vert-rl-expected.txt: Added.
      * platform/efl/fast/regions/get-regions-by-content2-expected.txt: Added.
      * platform/efl/fast/regions/hit-test-float-expected.txt: Added.
      * platform/efl/fast/regions/hit-test-region-expected.txt: Added.
      * platform/efl/fast/regions/imbricated-flow-threads-crash-expected.txt: Added.
      * platform/efl/fast/regions/move-anonymous-block-inside-named-flow-crash-expected.txt: Added.
      * platform/efl/fast/regions/moved-content-node-crash-expected.txt: Added.
      * platform/efl/fast/regions/multiple-directionality-changes-in-variable-width-regions-expected.png: Added.
      * platform/efl/fast/regions/multiple-directionality-changes-in-variable-width-regions-expected.txt: Added.
      * platform/efl/fast/regions/no-split-line-box-expected.txt: Added.
      * platform/efl/fast/regions/overflow-in-uniform-regions-dynamic-expected.png: Added.
      * platform/efl/fast/regions/overflow-in-uniform-regions-dynamic-expected.txt: Added.
      * platform/efl/fast/regions/overflow-in-variable-width-regions-expected.png: Added.
      * platform/efl/fast/regions/overflow-in-variable-width-regions-expected.txt: Added.
      * platform/efl/fast/regions/overflow-moving-below-floats-in-variable-width-regions-expected.png: Added.
      * platform/efl/fast/regions/overflow-moving-below-floats-in-variable-width-regions-expected.txt: Added.
      * platform/efl/fast/regions/overflow-not-moving-below-floats-in-variable-width-regions-expected.png: Added.
      * platform/efl/fast/regions/overflow-not-moving-below-floats-in-variable-width-regions-expected.txt: Added.
      * platform/efl/fast/regions/overflow-rtl-in-variable-width-regions-expected.png: Added.
      * platform/efl/fast/regions/overflow-rtl-in-variable-width-regions-expected.txt: Added.
      * platform/efl/fast/regions/overflow-size-change-in-variable-width-regions-expected.png: Added.
      * platform/efl/fast/regions/overflow-size-change-in-variable-width-regions-expected.txt: Added.
      * platform/efl/fast/regions/overflow-size-change-with-stacking-context-expected.png: Added.
      * platform/efl/fast/regions/overflow-size-change-with-stacking-context-expected.txt: Added.
      * platform/efl/fast/regions/overflow-size-change-with-stacking-context-rtl-expected.png: Added.
      * platform/efl/fast/regions/overflow-size-change-with-stacking-context-rtl-expected.txt: Added.
      * platform/efl/fast/regions/parse-incomplete-region-rule-expected.txt: Added.
      * platform/efl/fast/regions/parsing-region-style-rule-expected.txt: Added.
      * platform/efl/fast/regions/percentage-margins-mixed-ltr-dominant-regions-expected.png: Added.
      * platform/efl/fast/regions/percentage-margins-mixed-ltr-dominant-regions-expected.txt: Added.
      * platform/efl/fast/regions/percentage-margins-mixed-rtl-dominant-regions-expected.png: Added.
      * platform/efl/fast/regions/percentage-margins-mixed-rtl-dominant-regions-expected.txt: Added.
      * platform/efl/fast/regions/percentage-margins-rtl-variable-width-regions-expected.png: Added.
      * platform/efl/fast/regions/percentage-margins-rtl-variable-width-regions-expected.txt: Added.
      * platform/efl/fast/regions/percentage-margins-variable-width-regions-expected.png: Added.
      * platform/efl/fast/regions/percentage-margins-variable-width-regions-expected.txt: Added.
      * platform/efl/fast/regions/positioned-vrl-in-named-flow-expected.txt: Added.
      * platform/efl/fast/regions/positioned-vrl-in-parent-named-flow-expected.txt: Added.
      * platform/efl/fast/regions/positioned-with-vrl-parent-in-named-flow-expected.txt: Added.
      * platform/efl/fast/regions/region-attached-wrong-flow-crash-expected.txt: Added.
      * platform/efl/fast/regions/region-element-display-change-expected.txt: Added.
      * platform/efl/fast/regions/region-element-display-restriction-expected.txt: Added.
      * platform/efl/fast/regions/region-element-dynamic-attach-flow-expected.txt: Added.
      * platform/efl/fast/regions/region-element-dynamic-detach-flow-expected.txt: Added.
      * platform/efl/fast/regions/region-flow-reattach-crash-expected.txt: Added.
      * platform/efl/fast/regions/region-overflow-auto-overflow-hidden-expected.png: Added.
      * platform/efl/fast/regions/region-overflow-auto-overflow-hidden-expected.txt: Added.
      * platform/efl/fast/regions/region-overflow-auto-overflow-visible-expected.png: Added.
      * platform/efl/fast/regions/region-overflow-auto-overflow-visible-expected.txt: Added.
      * platform/efl/fast/regions/region-range-for-box-crash-expected.txt: Added.
      * platform/efl/fast/regions/region-style-block-background-color-expected.png: Added.
      * platform/efl/fast/regions/region-style-block-background-color-expected.txt: Added.
      * platform/efl/fast/regions/region-style-block-background-color2-expected.png: Added.
      * platform/efl/fast/regions/region-style-block-background-color2-expected.txt: Added.
      * platform/efl/fast/regions/remove-flow-thread-crash-expected.txt: Added.
      * platform/efl/fast/regions/removed-element-style-in-region-crash-expected.txt: Added.
      * platform/efl/fast/regions/select-in-region-crash-expected.txt: Added.
      * platform/efl/fast/regions/set-box-style-in-region-crash-expected.txt: Added.
      * platform/efl/fast/regions/svg-root-element-collected-expected.txt: Added.
      * platform/efl/fast/regions/symbol-in-named-flow-crash-expected.txt: Added.
      * platform/efl/fast/regions/text-region-breaks-expected.txt: Added.
      * platform/efl/fast/regions/text-region-split-after-resize-expected.txt: Added.
      * platform/efl/fast/regions/text-region-split-expected.txt: Added.
      * platform/efl/fast/regions/text-region-split-horizontal-bt-expected.txt: Added.
      * platform/efl/fast/regions/text-region-split-small-pagination-expected.png: Added.
      * platform/efl/fast/regions/text-region-split-small-pagination-expected.txt: Added.
      * platform/efl/fast/regions/text-region-split-vertical-expected.txt: Added.
      * platform/efl/fast/regions/text-region-split-vertical-rl-expected.txt: Added.
      * platform/efl/fast/regions/top-overflow-out-of-second-region-expected.png: Added.
      * platform/efl/fast/regions/top-overflow-out-of-second-region-expected.txt: Added.
      * platform/efl/fast/regions/webkit-flow-double-pagination-float-push-expected.png: Added.
      * platform/efl/fast/regions/webkit-flow-double-pagination-float-push-expected.txt: Added.
      * platform/efl/fast/regions/webkit-flow-float-pushed-to-last-region-expected.png: Added.
      * platform/efl/fast/regions/webkit-flow-float-pushed-to-last-region-expected.txt: Added.
      * platform/efl/fast/regions/webkit-flow-float-unable-to-push-expected.png: Added.
      * platform/efl/fast/regions/webkit-flow-float-unable-to-push-expected.txt: Added.
      * platform/efl/fast/regions/webkit-flow-inlines-inside-regions-bounds-expected.png: Added.
      * platform/efl/fast/regions/webkit-flow-inlines-inside-regions-bounds-expected.txt: Added.
      * platform/efl/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-expected.png: Added.
      * platform/efl/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-expected.txt: Added.
      * platform/efl/fast/regions/webkit-flow-parsing-expected.txt: Added.
      * platform/efl/fast/regions/webkit-named-flow-collection-crash-expected.txt: Added.
      * platform/efl/fast/regions/webkit-named-flow-collection-expected.txt: Added.
      * platform/efl/fast/regions/webkit-named-flow-event-add-to-flow-expected.txt: Added.
      * platform/efl/fast/regions/webkit-named-flow-event-expected.txt: Added.
      * platform/efl/fast/regions/webkit-named-flow-event-no-regions-expected.txt: Added.
      * platform/efl/fast/regions/webkit-named-flow-event-remove-from-dom-expected.txt: Added.
      * platform/efl/fast/regions/webkit-named-flow-event-remove-from-flow-expected.txt: Added.
      * platform/efl/fast/regions/webkit-named-flow-event-target-expected.txt: Added.
      * platform/efl/fast/regions/webkit-named-flow-event-to-null-expected.txt: Added.
      * platform/efl/fast/regions/webkit-named-flow-existing-flow-expected.txt: Added.
      * platform/efl/fast/regions/webkit-named-flow-first-empty-region-index-expected.txt: Added.
      * platform/efl/fast/regions/webkit-named-flow-flow-added-expected.txt: Added.
      * platform/efl/fast/regions/webkit-named-flow-get-content-expected.txt: Added.
      * platform/efl/fast/regions/webkit-named-flow-get-regions-expected.txt: Added.
      * platform/efl/fast/regions/webkit-named-flow-invalid-name-expected.txt: Added.
      * platform/efl/fast/regions/webkit-named-flow-modified-flow-expected.txt: Added.
      * platform/efl/fast/regions/webkit-named-flow-name-expected.txt: Added.
      * platform/efl/fast/regions/webkit-named-flow-non-existing-flow-expected.txt: Added.
      * platform/efl/fast/regions/webkit-named-flow-overset-expected.txt: Added.
      * platform/efl/fast/regions/webkit-named-flow-removed-flow-expected.txt: Added.
      * platform/efl/fast/regions/webkit-named-flow-same-object-expected.txt: Added.
      * platform/efl/fast/regions/webkit-region-overflow-parsing-expected.txt: Added.
      * platform/efl/fast/regions/webkit-region-rule-expected.txt: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129395 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dfe84c84
    • peter@chromium.org's avatar
      Android's mock scrollbars shows up as a difference in layout test results · d59609b9
      peter@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=96382
      
      Reviewed by Adam Barth.
      
      Remove the exceptions made for layout tests in Android's scrollbar theme.
      This will make our actual scrollbars show up in layout test pixel results,
      bringing the tests closer to what we actually ship.
      
      An important difference with other platforms is that scrollbars do not
      take any width on Android, they're rendered on top of the content. Therefore
      each test that has a visible scrollbar does not just need a new pixel
      result, but will also need a new text result. This will be handled as part
      of a larger rebaselining process.
      
      Will be exercised by every layout test that has a scrollbar.
      
      * platform/chromium/ScrollbarThemeChromiumAndroid.cpp:
      (WebCore::ScrollbarThemeChromiumAndroid::scrollbarThickness):
      (WebCore::ScrollbarThemeChromiumAndroid::usesOverlayScrollbars):
      (WebCore::ScrollbarThemeChromiumAndroid::hasThumb):
      * platform/chromium/ScrollbarThemeChromiumAndroid.h:
      (ScrollbarThemeChromiumAndroid):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129394 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d59609b9