1. 17 Jan, 2013 40 commits
    • inferno@chromium.org's avatar
      Heap-use-after-free in WebCore::RenderBlock::checkFloatsInCleanLine · 845a71ce
      inferno@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=90802
      
      Reviewed by Julien Chaffraix.
      
      Source/WebCore:
      
      Test: fast/multicol/float-not-removed-crash.html
      
      * rendering/RenderBoxModelObject.cpp:
      (WebCore::RenderBoxModelObject::moveChildrenTo):
      1. When fullRemoveInsert is True, make sure to clear the
      floating objects from our list (similar to positioned objects).
      Our children are getting moved to another block and we won't
      get notified when they are going away.
      2. Remove the redundant hasPositionedObjects check since it
      is already done inside removePositionedObjects.
      
      LayoutTests:
      
      * fast/multicol/float-not-removed-crash-expected.txt: Added.
      * fast/multicol/float-not-removed-crash.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140069 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      845a71ce
    • simon.fraser@apple.com's avatar
      Make it possible for the root background to be painted into its own GraphicsLayer · ee9213cf
      simon.fraser@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=107177
      
      Source/WebCore:
      
      Reviewed by Dave Hyatt.
      
      Make it possible to paint the root background into its own GraphicsLayer, and enable
      this when the root background has background-images that are all background-attachment: fixed.
      
      This is a step towards optimizing scrolling on pages with fixed root backgrounds.
      
      Tests: platform/mac/tiled-drawing/fixed-background/fixed-body-background-body-layer.html
             platform/mac/tiled-drawing/fixed-background/fixed-body-background-opacity-html.html
             platform/mac/tiled-drawing/fixed-background/fixed-body-background-transformed-html.html
             platform/mac/tiled-drawing/fixed-background/fixed-body-background-zoomed.html
             platform/mac/tiled-drawing/fixed-background/fixed-body-background.html
             platform/mac/tiled-drawing/fixed-background/fixed-html-background.html
             platform/mac/tiled-drawing/fixed-background/fixed-non-propagated-body-background.html
      
      * rendering/PaintInfo.h:
      (WebCore::PaintInfo::skipRootBackground): Utility function to check the paintBehavior flag.
      (WebCore::PaintInfo::paintRootBackgroundOnly): Ditto.
      * rendering/PaintPhase.h: New paint behavior flags to indicate that we should skip painting
      the root background, and only paint the root background.
      * rendering/RenderBlock.cpp:
      (WebCore::RenderBlock::paint): When we're only painting the root background, avoid painting column
      rules, and bail early.
      (WebCore::RenderBlock::paintObject): Don't paint children if we're just painting the root background.
      * rendering/RenderBox.cpp:
      (WebCore::RenderBox::styleWillChange): If this box can paint the root background, tell the compositor
      when the fixedness of those backgrounds changes.
      (WebCore::RenderBox::paintRootBoxFillLayers): If the paintBehavior flag is set to skip painting the root
      background, bail. This will be true for the non-background GraphicsLayers which are painting the root.
      * rendering/RenderLayer.cpp:
      (WebCore::RenderLayer::paintLayerContents): We can bail early if we're not a root-like renderer and the
      flag is set to paint the root background only. This avoids walking the whole layer tree when just painting
      into the root background GraphicsLayer.
      Migrate layer paint flags into PaintBehavior flags, and use them.
      * rendering/RenderLayer.h: Layer painting flags that replicate the paintBehavior flags.
      * rendering/RenderLayerBacking.cpp:
      (WebCore::RenderLayerBacking::RenderLayerBacking): Init the m_backgroundLayerPaintsFixedRootBackground bit.
      (WebCore::RenderLayerBacking::~RenderLayerBacking): Clear the background layer.
      (WebCore::RenderLayerBacking::createPrimaryGraphicsLayer): No need to handle the transparent background
      stuff here. We'll do it later in updateRootLayerConfiguration().
      (WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration): Actually make a background layer now
      if the compositor says we should.
      Call updateRootLayerConfiguration() to adjust the background color and opaqueness of the background/primary layers.
      (WebCore::RenderLayerBacking::updateInternalHierarchy): Parent the m_backgroundLayer in the containment layer,
      not m_graphicsLayer (this is a bug fix).
      (WebCore::RenderLayerBacking::updateDrawsContent):
      (WebCore::RenderLayerBacking::setBackgroundLayerPaintsFixedRootBackground):
      (WebCore::RenderLayerBacking::paintingPhaseForPrimaryLayer):
      (WebCore::RenderLayerBacking::updateBackgroundColor): This no longer needs to update the tile cache
      background color; updateRootLayerConfiguration() does this now.
      (WebCore::RenderLayerBacking::updateRootLayerConfiguration): Update the opaqueness and background color
      of the background and/or main graphics layers.
      (WebCore::RenderLayerBacking::setContentsNeedDisplay): Invalidate the background layer if we have one.
      (WebCore::RenderLayerBacking::setContentsNeedDisplayInRect): Invalidate the background layer if we have one.
      This will be optimized to only repaint the background if it was the background that changed.
      (WebCore::RenderLayerBacking::paintIntoLayer): Take a GraphicsLayer, not a RenderLayer argument.
      Adjust the paintFlags if we're being asked to paint the background layer, or if we have one, but are painting the foreground.
      (WebCore::RenderLayerBacking::paintContents):
      (WebCore::RenderLayerBacking::backingStoreMemoryEstimate):
      (WebCore::RenderLayerBacking::reportMemoryUsage):
      * rendering/RenderLayerBacking.h:
      (WebCore::RenderLayerBacking::backgroundLayer):
      (WebCore::RenderLayerBacking::backgroundLayerPaintsFixedRootBackground):
      (RenderLayerBacking):
      * rendering/RenderLayerCompositor.cpp:
      (WebCore::RenderLayerCompositor::rootFixedBackgroundsChanged): If we're told that the fixed-ness of
      the root background changed and we're using a TileCache, we need to re-evaluate compositing (this could be
      optimized to only update the root layer).
      (WebCore::RenderLayerCompositor::needsFixedRootBackgroundLayer): For the root (RenderView's) layer,
      check whether the renderer that will paint the root (taking background propagation into account) has
      background images that are all fixed.
      (WebCore::RenderLayerCompositor::fixedRootBackgroundLayer): Accessor for the GraphicsLayer that paints
      the root background (will be used later).
      * rendering/RenderLayerCompositor.h:
      (RenderLayerCompositor):
      * rendering/RenderObject.cpp:
      (WebCore::RenderObject::hasEntirelyFixedBackground): Returns true there are background images
      and all are fixed.
      * rendering/RenderObject.h:
      * rendering/RenderView.cpp:
      (WebCore::RenderView::paintBoxDecorations): This function paints a solid color if we know that the root
      isn't going to fill the viewport; we want to avoid this painting if we're not painting the root background
      in this pass.
      * rendering/style/RenderStyle.cpp:
      (WebCore::allLayersAreFixed):
      (WebCore::RenderStyle::hasEntirelyFixedBackground): New helper function.
      * rendering/style/RenderStyle.h:
      
      LayoutTests:
      
      Reviewed by Dave Hyatt.
      
      New tests with results for a fixed root background layer when using tiled drawing.
      
      * platform/mac/tiled-drawing/fixed-background/fixed-body-background-body-layer-expected.png: Added.
      * platform/mac/tiled-drawing/fixed-background/fixed-body-background-body-layer-expected.txt: Added.
      * platform/mac/tiled-drawing/fixed-background/fixed-body-background-body-layer.html: Added.
      * platform/mac/tiled-drawing/fixed-background/fixed-body-background-expected.png: Added.
      * platform/mac/tiled-drawing/fixed-background/fixed-body-background-expected.txt: Added.
      * platform/mac/tiled-drawing/fixed-background/fixed-body-background-opacity-html-expected.png: Added.
      * platform/mac/tiled-drawing/fixed-background/fixed-body-background-opacity-html-expected.txt: Added.
      * platform/mac/tiled-drawing/fixed-background/fixed-body-background-opacity-html.html: Added.
      * platform/mac/tiled-drawing/fixed-background/fixed-body-background-transformed-html-expected.png: Added.
      * platform/mac/tiled-drawing/fixed-background/fixed-body-background-transformed-html-expected.txt: Added.
      * platform/mac/tiled-drawing/fixed-background/fixed-body-background-transformed-html.html: Added.
      * platform/mac/tiled-drawing/fixed-background/fixed-body-background-zoomed-expected.png: Added.
      * platform/mac/tiled-drawing/fixed-background/fixed-body-background-zoomed-expected.txt: Added.
      * platform/mac/tiled-drawing/fixed-background/fixed-body-background-zoomed.html: Added.
      * platform/mac/tiled-drawing/fixed-background/fixed-body-background.html: Added.
      * platform/mac/tiled-drawing/fixed-background/fixed-html-background-expected.png: Added.
      * platform/mac/tiled-drawing/fixed-background/fixed-html-background-expected.txt: Added.
      * platform/mac/tiled-drawing/fixed-background/fixed-html-background.html: Added.
      * platform/mac/tiled-drawing/fixed-background/fixed-non-propagated-body-background-expected.png: Added.
      * platform/mac/tiled-drawing/fixed-background/fixed-non-propagated-body-background-expected.txt: Added.
      * platform/mac/tiled-drawing/fixed-background/fixed-non-propagated-body-background.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140068 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ee9213cf
    • simon.fraser@apple.com's avatar
      Ref test images are upside-down in WebKit2 · 85008f5e
      simon.fraser@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=105457
      
      Reviewed by Sam "Speedy" Weinig.
      
      The bitmap context created in TestInvocation::dumpPixelsAndCompareWithExpected()
      from the window snapshot contained a flipped copy of the image, causing all ref
      and pixel images to be upside-down.
      
      * WebKitTestRunner/cg/TestInvocationCG.cpp:
      (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140067 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      85008f5e
    • simon.fraser@apple.com's avatar
      Allow PaintInfo to carry all PaintBehavior flags · 29865a4c
      simon.fraser@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=106980
      
      Reviewed by Beth Dakin.
      
      In r139908 I missed one instance of the PaintInfo constructor that should take PaintBehaviorNormal
      instead of "false".
      
      * rendering/RenderScrollbarPart.cpp:
      (WebCore::RenderScrollbarPart::paintIntoRect):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140066 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      29865a4c
    • hclam@chromium.org's avatar
      [chromium] Test expectations update · 1e722ec3
      hclam@chromium.org authored
      Unreviewed build fix. Update test expectations to reflect crashing tests:
      http/tests/appcache/fail-on-update.html
      http/tests/appcache/fail-on-update-2.html
      
      * platform/chromium/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140065 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1e722ec3
    • rafaelw@chromium.org's avatar
      [Template] Avoid reading beyond the end of the buffer in preload scanner when check for </template> · efa6c588
      rafaelw@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=107143
      
      Reviewed by Adam Barth.
      
      This patch corrects to use AtomicString constructor which takes an explicit size. Additionally, the logic
      for exiting early is slightly improved.
      
      No new tests.
      
      * html/parser/HTMLPreloadScanner.cpp:
      (WebCore::PreloadTask::PreloadTask):
      (WebCore::HTMLPreloadScanner::processToken):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140064 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      efa6c588
    • commit-queue@webkit.org's avatar
      [TexMap] Match initializing members in GraphicsLayerTransform to initializing... · 1445afee
      commit-queue@webkit.org authored
      [TexMap] Match initializing members in GraphicsLayerTransform to initializing members in GraphicsLayer.
      https://bugs.webkit.org/show_bug.cgi?id=107090
      
      Patch by Huang Dongsung <luxtella@company100.net> on 2013-01-17
      Reviewed by Noam Rosenthal.
      
      GraphicsLayer initializes m_anchorPoint to FloatPoint3D(0.5, 0.5, 0) and
      m_preserves3D to false, while GraphicsLayerTransform initializes m_anchorPoint
      to FloatPoint3D(0, 0, 0) and m_flattening (= !m_preserves3D) to false. It is a
      potential bug. This patch corrects initialization of GraphicsLayerTransform.
      
      Covered by existing compositing pixel tests.
      
      * platform/graphics/GraphicsLayerTransform.cpp:
      (WebCore::GraphicsLayerTransform::GraphicsLayerTransform):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140063 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1445afee
    • fpizlo@apple.com's avatar
      ScriptDebugServer::didExecuteProgram should not try to pop stack if there is no stack to pop · cc12d4f5
      fpizlo@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=107186
      
      Reviewed by Geoffrey Garen.
      
      No new tests, because I'm not sure how to test this. I can repro it on a gnarly web site,
      but I don't know how to create a reduced case that triggers it.
      
      * bindings/js/ScriptDebugServer.cpp:
      (WebCore::ScriptDebugServer::didExecuteProgram):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140062 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cc12d4f5
    • timothy@apple.com's avatar
      Build fix. Bad merge. · 2b6fc6b4
      timothy@apple.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140060 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2b6fc6b4
    • commit-queue@webkit.org's avatar
      [GTK] IndexedDB: Add LevelDB headers to include path if IndexedDB is enabled · 8262c3d0
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=107181
      
      Patch by Michael Pruett <michael@68k.org> on 2013-01-17
      Reviewed by Martin Robinson.
      
      No new tests as this is just a build change.
      
      * GNUmakefile.am:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140059 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8262c3d0
    • eric@webkit.org's avatar
      The threaded html parser hangs when parsing empty documents (and about:blank) · 6d0ccfe2
      eric@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=107160
      
      Reviewed by Tony Gentilcore.
      
      This is covered by many existing tests including the html5lib suite.
      
      * html/parser/HTMLDocumentParser.cpp:
      (WebCore::HTMLDocumentParser::finish):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140058 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6d0ccfe2
    • commit-queue@webkit.org's avatar
      imageSmoothingEnabled frequent, unpredictable crashes · 043c8b62
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=107161
      
      Patch by Alexis Hetu <sugoi@chromium.org> on 2013-01-17
      Reviewed by Stephen White.
      
      Source/WebCore:
      
      Added a NULL pointer check to fix a crash.
      
      Test: fast/canvas/canvas-imageSmoothingEnabled-zero-size.html
      
      * html/canvas/CanvasRenderingContext2D.cpp:
      (WebCore::CanvasRenderingContext2D::setWebkitImageSmoothingEnabled):
      
      LayoutTests:
      
      Added a layout test for setting image smoothing enabled on a 0 sized
      canvas.
      
      * fast/canvas/canvas-imageSmoothingEnabled-zero-size-expected.txt: Added.
      * fast/canvas/canvas-imageSmoothingEnabled-zero-size.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140057 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      043c8b62
    • commit-queue@webkit.org's avatar
      Unreviewed, rolling out r140049. · 90313da3
      commit-queue@webkit.org authored
      http://trac.webkit.org/changeset/140049
      https://bugs.webkit.org/show_bug.cgi?id=107187
      
      Breaks lots of stuff (Requested by schenney on #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-01-17
      
      Source/WebCore:
      
      * svg/SVGViewSpec.cpp:
      (WebCore::SVGViewSpec::setPreserveAspectRatioString):
      (WebCore):
      (WebCore::SVGViewSpec::viewTarget):
      (WebCore::SVGViewSpec::transform):
      (WebCore::SVGViewSpec::lookupOrCreateViewBoxWrapper):
      (WebCore::SVGViewSpec::lookupOrCreatePreserveAspectRatioWrapper):
      (WebCore::SVGViewSpec::lookupOrCreateTransformWrapper):
      * svg/SVGViewSpec.h:
      (SVGViewSpec):
      (WebCore::SVGViewSpec::viewBoxAnimated):
      (WebCore::SVGViewSpec::preserveAspectRatioAnimated):
      * svg/SVGViewSpec.idl:
      
      LayoutTests:
      
      * svg/dom/SVGViewSpec-invalid-ref-crash-expected.txt: Removed.
      * svg/dom/SVGViewSpec-invalid-ref-crash.html: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140056 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      90313da3
    • eric@webkit.org's avatar
      Threaded parser hangs when encountering an unmatched </script> tag · 8c5c85fa
      eric@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=107170
      
      Reviewed by Adam Barth.
      
      The bug was that the BackgroundHTMLParser naively yields to the
      main thread every time it encounters a </script>
      (as we may have to run script on the main thread).  However, not every
      </script> results in script execution, so the main thread needs to know
      how to tell the BackgroundHTMLParser to continue in cases where no
      script execution is needed.
      
      This whole infrastructure will be replaced when we let the BackgroundHTMLParser
      continue speculatively tokenizing after yielding.
      
      * html/parser/BackgroundHTMLParser.cpp:
      (WebCore::TokenDelivery::TokenDelivery):
      (TokenDelivery):
      (WebCore::TokenDelivery::execute):
      (WebCore::BackgroundHTMLParser::sendTokensToMainThread):
      * html/parser/HTMLDocumentParser.cpp:
      (WebCore::HTMLDocumentParser::didReceiveTokensFromBackgroundParser):
      * html/parser/HTMLDocumentParser.h:
      (HTMLDocumentParser):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140055 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8c5c85fa
    • ap@apple.com's avatar
      REGRESSION (r139516): NetworkResourceLoadScheduler::receivedRedirect is not called. · 9465ba38
      ap@apple.com authored
              Rubber-stamped by Brady Eidson.
      
              * NetworkProcess/NetworkResourceLoader.cpp:
              (WebKit::NetworkResourceLoader::willSendRequest): Reverted a small part of r139516.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140054 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9465ba38
    • commit-queue@webkit.org's avatar
      Coordinated Graphics: Remove redundant behaviors in LayerTreeRenderer. · 18ac4c73
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=107084
      
      Patch by Huang Dongsung <luxtella@company100.net> on 2013-01-17
      Reviewed by Noam Rosenthal.
      
      There are two changes.
      1. It is redundant to call GraphicsLayer::removeFromParent() or
      GraphicsLayer::removeAllChildren() before deleting GraphicsLayer, because the
      destructor of GraphicsLayerTextureMapper removes a parent and all children.
      2. LayerTreeRenderer::setRootLayerID() does not need to remove all children of
      rootLayer because this method can be called only once.
      
      * UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp:
      (WebKit::LayerTreeRenderer::deleteLayer):
      (WebKit::LayerTreeRenderer::setRootLayerID):
      (WebKit::LayerTreeRenderer::purgeGLResources):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140053 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      18ac4c73
    • timothy@apple.com's avatar
      Fix build. · 6751878d
      timothy@apple.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140052 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6751878d
    • eric@webkit.org's avatar
      Add a version of the html-parser benchmark which uses srcdoc instead of... · d6c45992
      eric@webkit.org authored
      Add a version of the html-parser benchmark which uses srcdoc instead of document.write so it tests the threaded parser
      https://bugs.webkit.org/show_bug.cgi?id=107158
      
      Reviewed by Ryosuke Niwa.
      
      Currently this test even opts-in to the threaded parser if available.
      We'll remove that line when the threaded parser becomes default or goes away.
      
      * Parser/html-parser-srcdoc.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140051 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d6c45992
    • eric@webkit.org's avatar
      Stop the background parser when canceling parsing to avoid crashing on many layout tests · 061d5809
      eric@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=107159
      
      Reviewed by Adam Barth.
      
      Covered by many existing tests.
      
      * html/parser/HTMLDocumentParser.cpp:
      (WebCore::HTMLDocumentParser::stopParsing):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140050 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      061d5809
    • schenney@chromium.org's avatar
      SVGViewSpec fails when corresponding element has been removed · 3fb82f83
      schenney@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=106957
      
      Reviewed by Dirk Schulze.
      
      Source/WebCore:
      
      When JS holds an SVGViewSpec object while deleting the object that
      defines the spec (an SVGSVGElement, or one of a few others) the
      pointer to the target is cleared in the SVGViewSpec but the methods
      that serve JS queries do not check and try to access the now null
      target. This atch fixes the prooblem, throwing JS exceptions where
      possible and returning null where necessary.
      
      Test: svg/dom/SVGViewSpec-invalid-ref-crash.html
      
      * svg/SVGViewSpec.cpp:
      (WebCore):
      (WebCore::SVGViewSpec::viewTarget): Check for null target and throw an exception.
      (WebCore::SVGViewSpec::transform): Check for null target and return
      null. It is not possible to throw an exception here because it leads
      to an invalid cast in the code generated from IDLs.
      (WebCore::SVGViewSpec::viewBoxAnimated): Check for null target and throw an exception.
      (WebCore::SVGViewSpec::preserveAspectRatioAnimated): Check for null target and throw an exception.
      (WebCore::SVGViewSpec::lookupOrCreateViewBoxWrapper): ASSERT non-null target
      (WebCore::SVGViewSpec::lookupOrCreatePreserveAspectRatioWrapper): ASSERT non-null target
      (WebCore::SVGViewSpec::lookupOrCreateTransformWrapper): ASSERT non-null target
      * svg/SVGViewSpec.h:
      (SVGViewSpec): Add Exception arguments to getter methods.
      * svg/SVGViewSpec.idl: Mark attributes as throwing exceptions.
      
      LayoutTests:
      
      Test for the situation in which the target of an SVGViewSpec is
      removed while the view spec lives on in JS.
      
      * svg/dom/SVGViewSpec-invalid-ref-crash-expected.txt: Added.
      * svg/dom/SVGViewSpec-invalid-ref-crash.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140049 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3fb82f83
    • alecflett@chromium.org's avatar
      IndexedDB: Remove unnecessary call to IDBDatabaseBackendInterface::metadata() · dda3f4e1
      alecflett@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=107142
      
      Reviewed by Kentaro Hara.
      
      This call isn't necessary, and probably slipped through an earlier review
      because of the mention of 'm_metadata'.
      
      No new tests, as this code has no side effects and all tests sill pass.
      
      * Modules/indexeddb/IDBIndex.cpp:
      (WebCore::IDBIndex::count):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140048 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dda3f4e1
    • ojan@chromium.org's avatar
      Table layout does not need to explicitly call computePreferredLogicalWidths · 8cdbcc91
      ojan@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=106931
      
      Reviewed by Julien Chaffraix.
      
      Code shouldn't need to explicitly call computePreferredLogicalWidths.
      It should only get called as a by-product of calling minPreferredLogicalWidth
      or maxPreferredLogicalWidth.
      
      Instead, make it clear that the calling code is just trying to clear
      preferred width dirty bits.
      
      * rendering/AutoTableLayout.cpp:
      (WebCore::AutoTableLayout::recalcColumn):
      The computePreferredLogicalWidths call on the table cell is redundant
      with the minPreferredLogicalWidth call on the next line.
      
      * rendering/FixedTableLayout.cpp:
      (WebCore::FixedTableLayout::calcWidthArray):
      We only need to clear the dirty bit here. Table cells don't use
      their preferred widths in fixed table layout calculations.
      
      * rendering/RenderTableCell.h:
      * rendering/RenderTableCol.cpp:
      (WebCore::RenderTableCol::clearPreferredLogicalWidthsDirtyBits):
      * rendering/RenderTableCol.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140047 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8cdbcc91
    • yoli@rim.com's avatar
      [BlackBerry] InRegionScroller should notify client before it deletes all the scrollables · a44c86b2
      yoli@rim.com authored
      https://bugs.webkit.org/show_bug.cgi?id=107162
      
      Reviewed by Rob Buis.
      Internally reviewed by Gen Mak and Mike Fenton.
      
      Move the notification code from notifyInRegionScrollStopped() to reset() as there are
      other places where reset() gets called.
      
      * Api/InRegionScroller.cpp:
      (BlackBerry::WebKit::InRegionScrollerPrivate::reset):
      * Api/WebPage.cpp:
      (BlackBerry::WebKit::WebPagePrivate::notifyInRegionScrollStopped):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140046 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a44c86b2
    • jchaffraix@webkit.org's avatar
      [CSS Grid Layout] Updating -webkit-grid-rows or -webkit-grid-columns doesn't work as expected · 67cadacb
      jchaffraix@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=107062
      
      Reviewed by Tony Chang.
      
      Source/WebCore:
      
      Tests: fast/css-grid-layout/percent-grid-item-in-percent-grid-track-update.html
             fast/css-grid-layout/percent-padding-margin-resolution-grid-item-update.html
      
      This change makes -webkit-grid-rows and -webkit-grid-columns dynamic change properly
      relayout their children, thus making them work!
      
      * rendering/RenderGrid.cpp:
      (WebCore::RenderGrid::layoutGridItems):
      Fixed the logic to force a grid item relayout if the grid area size changes. This is the
      safest approach as margins or paddings can also be a percent of the grid area's size.
      
      * rendering/style/RenderStyle.cpp:
      (WebCore::RenderStyle::diff):
      Fixed a dumb mistake.
      
      LayoutTests:
      
      * fast/css-grid-layout/percent-grid-item-in-percent-grid-track-update-expected.txt: Added.
      * fast/css-grid-layout/percent-grid-item-in-percent-grid-track-update.html: Added.
      * fast/css-grid-layout/percent-padding-margin-resolution-grid-item-update-expected.txt: Added.
      * fast/css-grid-layout/percent-padding-margin-resolution-grid-item-update.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140045 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      67cadacb
    • timothy@apple.com's avatar
      Make logging console messages to STDOUT work in WebKit2 via a new setting. · d070f9cd
      timothy@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=107157
      
      Reviewed by Joseph Pecoraro.
      
      Source/WebCore:
      
      * page/Console.cpp:
      (WebCore::Console::addMessage): Check logsPageMessagesToSystemConsoleEnabled().
      (WebCore::internalAddMessage): Ditto. Refactored to return early and drop printExceptions argument.
      (WebCore::Console::error): Removed call to shouldPrintExceptions().
      (WebCore::Console::log): Ditto.
      (WebCore::Console::warn): Ditto.
      (WebCore::Console::dir): Ditto.
      (WebCore::Console::dirxml): Ditto.
      (WebCore::Console::clear): Ditto.
      (WebCore::Console::trace): Ditto.
      (WebCore::Console::assertCondition): Ditto.
      * page/Settings.in: Added logsPageMessagesToSystemConsoleEnabled.
      
      Source/WebKit2:
      
      * Shared/WebPreferencesStore.h:
      * UIProcess/API/C/WKPreferences.cpp:
      (WKPreferencesSetLogsPageMessagesToSystemConsoleEnabled): Added.
      (WKPreferencesGetLogsPageMessagesToSystemConsoleEnabled): Added.
      * UIProcess/API/C/WKPreferencesPrivate.h:
      * UIProcess/WebInspectorProxy.cpp:
      (WebKit::createInspectorPageGroup): Enable logging in debug builds.
      * WebProcess/WebPage/WebPage.cpp:
      (WebKit::WebPage::updatePreferences): Set new setting in WebCore.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140044 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d070f9cd
    • mifenton@rim.com's avatar
      [BlackBerry] Fix selection handle appearance for RTL text. · ad11dd39
      mifenton@rim.com authored
      https://bugs.webkit.org/show_bug.cgi?id=107043
      
      Reviewed by Rob Buis.
      
      PR 263585.
      
      Invert the reported selection handle position if to match
      the visual order instead of the logical order to create the
      desired appearance for RTL text and directional selections.
      
      Reviewed Internally by Gen Mak and Nima Ghanavatian.
      
      * WebKitSupport/SelectionHandler.cpp:
      (BlackBerry::WebKit::SelectionHandler::selectionPositionChanged):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140043 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ad11dd39
    • hclam@chromium.org's avatar
      [chromium] Fix layout test expectations. · b438d6ff
      hclam@chromium.org authored
      Not reviewed. Update layout test expectations.
      
      http/tests/appcache/fail-on-update.html is crashing, mark it so.
      
      * platform/chromium/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140041 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b438d6ff
    • abarth@webkit.org's avatar
      Teach Functional.h about WeakPtr · 866b4df4
      abarth@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=107105
      
      Reviewed by Anders Carlsson.
      
      A common pattern in cross-thread communication is to call member
      functions of an object on a remote thread. If the caller's reference to
      the object on the remote thread is a WeakPtr, the caller usually wants
      to validate that the object still exists when the call actually takes
      place.
      
      It's possible to do this manually for every cross-thread call, but that
      is tiresome and error prone. Instead, we can teach bind to validate
      WeakPtr arguments when passed as the "this" parameter to a member
      function.
      
      * wtf/Functional.h:
      (WTF::ParamStorageTraits::validate):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140040 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      866b4df4
    • commit-queue@webkit.org's avatar
      Unreviewed, rolling out r140023. · 3b34ce48
      commit-queue@webkit.org authored
      http://trac.webkit.org/changeset/140023
      https://bugs.webkit.org/show_bug.cgi?id=107176
      
      Broke some tests (Requested by anttik on #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-01-17
      
      Source/WebCore:
      
      * page/FrameView.cpp:
      (WebCore::FrameView::updateScrollCorner):
      * rendering/RenderBlock.cpp:
      (WebCore::RenderBlock::createReplacementRunIn):
      (WebCore::RenderBlock::updateFirstLetterStyle):
      (WebCore::RenderBlock::createFirstLetterRenderer):
      (WebCore::RenderBlock::createAnonymousWithParentRendererAndDisplay):
      (WebCore::RenderBlock::createAnonymousColumnsWithParentRenderer):
      (WebCore::RenderBlock::createAnonymousColumnSpanWithParentRenderer):
      * rendering/RenderBlock.h:
      (RenderBlock):
      * rendering/RenderDeprecatedFlexibleBox.cpp:
      (WebCore::RenderDeprecatedFlexibleBox::RenderDeprecatedFlexibleBox):
      * rendering/RenderDeprecatedFlexibleBox.h:
      (RenderDeprecatedFlexibleBox):
      * rendering/RenderDetailsMarker.cpp:
      (WebCore::RenderDetailsMarker::RenderDetailsMarker):
      * rendering/RenderDetailsMarker.h:
      (RenderDetailsMarker):
      * rendering/RenderDialog.h:
      (WebCore::RenderDialog::RenderDialog):
      * rendering/RenderFieldset.cpp:
      (WebCore::RenderFieldset::RenderFieldset):
      * rendering/RenderFieldset.h:
      (RenderFieldset):
      * rendering/RenderFlexibleBox.cpp:
      (WebCore::RenderFlexibleBox::RenderFlexibleBox):
      * rendering/RenderFlexibleBox.h:
      (RenderFlexibleBox):
      * rendering/RenderFlowThread.cpp:
      (WebCore::RenderFlowThread::RenderFlowThread):
      * rendering/RenderFlowThread.h:
      * rendering/RenderFullScreen.cpp:
      (RenderFullScreenPlaceholder::RenderFullScreenPlaceholder):
      (RenderFullScreen::RenderFullScreen):
      (RenderFullScreen::wrapRenderer):
      * rendering/RenderFullScreen.h:
      (RenderFullScreen):
      * rendering/RenderGrid.cpp:
      (WebCore::RenderGrid::RenderGrid):
      * rendering/RenderGrid.h:
      (RenderGrid):
      * rendering/RenderImage.cpp:
      (WebCore::RenderImage::RenderImage):
      * rendering/RenderImage.h:
      (RenderImage):
      * rendering/RenderInline.cpp:
      (WebCore::RenderInline::RenderInline):
      (WebCore::RenderInline::addChildIgnoringContinuation):
      * rendering/RenderInline.h:
      (RenderInline):
      * rendering/RenderLayer.cpp:
      (WebCore::RenderLayer::updateScrollCornerStyle):
      (WebCore::RenderLayer::updateResizerStyle):
      (WebCore::RenderLayer::createReflection):
      * rendering/RenderListItem.cpp:
      (WebCore::RenderListItem::RenderListItem):
      (WebCore::RenderListItem::styleDidChange):
      * rendering/RenderListItem.h:
      (RenderListItem):
      * rendering/RenderListMarker.cpp:
      (WebCore::RenderListMarker::RenderListMarker):
      * rendering/RenderListMarker.h:
      (RenderListMarker):
      * rendering/RenderMediaControlElements.cpp:
      (WebCore::RenderMediaVolumeSliderContainer::RenderMediaVolumeSliderContainer):
      (WebCore::RenderMediaControlTimeDisplay::RenderMediaControlTimeDisplay):
      (WebCore::RenderTextTrackContainerElement::RenderTextTrackContainerElement):
      * rendering/RenderMediaControlElements.h:
      (RenderMediaVolumeSliderContainer):
      (RenderMediaControlTimeDisplay):
      (RenderTextTrackContainerElement):
      * rendering/RenderMultiColumnBlock.cpp:
      (WebCore::RenderMultiColumnBlock::RenderMultiColumnBlock):
      (WebCore::RenderMultiColumnBlock::ensureColumnSets):
      * rendering/RenderMultiColumnBlock.h:
      (RenderMultiColumnBlock):
      * rendering/RenderMultiColumnFlowThread.cpp:
      (WebCore::RenderMultiColumnFlowThread::RenderMultiColumnFlowThread):
      * rendering/RenderMultiColumnFlowThread.h:
      (RenderMultiColumnFlowThread):
      * rendering/RenderMultiColumnSet.cpp:
      (WebCore::RenderMultiColumnSet::RenderMultiColumnSet):
      * rendering/RenderMultiColumnSet.h:
      (RenderMultiColumnSet):
      * rendering/RenderNamedFlowThread.cpp:
      (WebCore::RenderNamedFlowThread::RenderNamedFlowThread):
      * rendering/RenderNamedFlowThread.h:
      (RenderNamedFlowThread):
      * rendering/RenderObject.cpp:
      (WebCore::RenderObject::RenderObject):
      * rendering/RenderObject.h:
      (WebCore::RenderObject::setIsAnonymous):
      (RenderObject):
      (WebCore::RenderObject::RenderObjectBitfields::RenderObjectBitfields):
      * rendering/RenderRegion.cpp:
      (WebCore::RenderRegion::RenderRegion):
      * rendering/RenderRegion.h:
      (RenderRegion):
      * rendering/RenderRegionSet.cpp:
      (WebCore::RenderRegionSet::RenderRegionSet):
      * rendering/RenderRegionSet.h:
      (RenderRegionSet):
      * rendering/RenderReplaced.cpp:
      (WebCore::RenderReplaced::RenderReplaced):
      * rendering/RenderReplaced.h:
      (RenderReplaced):
      * rendering/RenderReplica.cpp:
      (WebCore::RenderReplica::RenderReplica):
      * rendering/RenderReplica.h:
      (RenderReplica):
      * rendering/RenderRuby.cpp:
      (WebCore::createAnonymousRubyInlineBlock):
      (WebCore::RenderRubyAsInline::RenderRubyAsInline):
      (WebCore):
      (WebCore::RenderRubyAsBlock::RenderRubyAsBlock):
      * rendering/RenderRuby.h:
      (RenderRubyAsInline):
      (RenderRubyAsBlock):
      * rendering/RenderRubyBase.cpp:
      (WebCore::RenderRubyBase::RenderRubyBase):
      * rendering/RenderRubyBase.h:
      (RenderRubyBase):
      * rendering/RenderRubyRun.cpp:
      (WebCore::RenderRubyRun::RenderRubyRun):
      (WebCore::RenderRubyRun::createRubyBase):
      (WebCore::RenderRubyRun::staticCreateRubyRun):
      * rendering/RenderRubyRun.h:
      (RenderRubyRun):
      * rendering/RenderRubyText.cpp:
      (WebCore::RenderRubyText::RenderRubyText):
      * rendering/RenderRubyText.h:
      (RenderRubyText):
      * rendering/RenderScrollbar.cpp:
      (WebCore::RenderScrollbar::updateScrollbarPart):
      * rendering/RenderScrollbarPart.cpp:
      (WebCore::RenderScrollbarPart::RenderScrollbarPart):
      * rendering/RenderScrollbarPart.h:
      (RenderScrollbarPart):
      * rendering/RenderSearchField.cpp:
      (WebCore::RenderSearchField::RenderSearchField):
      * rendering/RenderSearchField.h:
      (RenderSearchField):
      * rendering/RenderTable.cpp:
      (WebCore::RenderTable::RenderTable):
      (WebCore::RenderTable::createAnonymousWithParentRenderer):
      * rendering/RenderTable.h:
      (RenderTable):
      * rendering/RenderTableCaption.cpp:
      (WebCore::RenderTableCaption::RenderTableCaption):
      * rendering/RenderTableCaption.h:
      (RenderTableCaption):
      * rendering/RenderTableCell.cpp:
      (WebCore::RenderTableCell::RenderTableCell):
      (WebCore::RenderTableCell::createAnonymousWithParentRenderer):
      * rendering/RenderTableCell.h:
      (RenderTableCell):
      * rendering/RenderTableCol.cpp:
      (WebCore::RenderTableCol::RenderTableCol):
      * rendering/RenderTableCol.h:
      (RenderTableCol):
      * rendering/RenderTableRow.cpp:
      (WebCore::RenderTableRow::RenderTableRow):
      (WebCore::RenderTableRow::createAnonymousWithParentRenderer):
      * rendering/RenderTableRow.h:
      (RenderTableRow):
      * rendering/RenderTableSection.cpp:
      (WebCore::RenderTableSection::RenderTableSection):
      (WebCore::RenderTableSection::createAnonymousWithParentRenderer):
      * rendering/RenderTableSection.h:
      (RenderTableSection):
      * rendering/RenderTextControl.cpp:
      (WebCore::RenderTextControl::RenderTextControl):
      * rendering/RenderTextControl.h:
      (RenderTextControl):
      * rendering/RenderTextControlMultiLine.cpp:
      (WebCore::RenderTextControlMultiLine::RenderTextControlMultiLine):
      * rendering/RenderTextControlMultiLine.h:
      (RenderTextControlMultiLine):
      * rendering/RenderTextControlSingleLine.cpp:
      (WebCore::RenderTextControlSingleLine::RenderTextControlSingleLine):
      * rendering/RenderTextControlSingleLine.h:
      (RenderTextControlSingleLine):
      (WebCore::RenderTextControlInnerBlock::RenderTextControlInnerBlock):
      * rendering/RenderTextTrackCue.cpp:
      (WebCore::RenderTextTrackCue::RenderTextTrackCue):
      * rendering/RenderView.cpp:
      (WebCore::RenderView::RenderView):
      * rendering/RenderWidget.cpp:
      (WebCore::RenderWidget::RenderWidget):
      * rendering/RenderWidget.h:
      (RenderWidget):
      * rendering/mathml/RenderMathMLBlock.cpp:
      (WebCore::RenderMathMLBlock::RenderMathMLBlock):
      (WebCore::RenderMathMLBlock::createAnonymousMathMLBlock):
      * rendering/mathml/RenderMathMLBlock.h:
      (RenderMathMLBlock):
      * rendering/mathml/RenderMathMLFenced.cpp:
      (WebCore::RenderMathMLFenced::createMathMLOperator):
      * rendering/mathml/RenderMathMLOperator.cpp:
      (WebCore::RenderMathMLOperator::RenderMathMLOperator):
      (WebCore::RenderMathMLOperator::updateFromElement):
      (WebCore::RenderMathMLOperator::createGlyph):
      * rendering/mathml/RenderMathMLOperator.h:
      (RenderMathMLOperator):
      * rendering/mathml/RenderMathMLRow.cpp:
      (WebCore::RenderMathMLRow::RenderMathMLRow):
      (WebCore::RenderMathMLRow::createAnonymousWithParentRenderer):
      * rendering/mathml/RenderMathMLRow.h:
      (RenderMathMLRow):
      * rendering/style/ContentData.cpp:
      (WebCore::ImageContentData::createRenderer):
      * rendering/svg/RenderSVGBlock.cpp:
      (WebCore::RenderSVGBlock::RenderSVGBlock):
      * rendering/svg/RenderSVGInline.cpp:
      (WebCore::RenderSVGInline::RenderSVGInline):
      * rendering/svg/RenderSVGInline.h:
      (RenderSVGInline):
      * rendering/svg/RenderSVGTSpan.cpp:
      (WebCore::RenderSVGTSpan::RenderSVGTSpan):
      * rendering/svg/RenderSVGTSpan.h:
      (RenderSVGTSpan):
      * rendering/svg/RenderSVGTextPath.cpp:
      (WebCore::RenderSVGTextPath::RenderSVGTextPath):
      * rendering/svg/RenderSVGTextPath.h:
      (RenderSVGTextPath):
      
      Source/WebKit/chromium:
      
      * tests/RenderTableCellTest.cpp:
      * tests/RenderTableRowTest.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140039 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3b34ce48
    • beidson@apple.com's avatar
      Each NetworkConnectionToWebProcess should keep its own map of NetworkResourceLoaders · fdc0247c
      beidson@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=107166
      
      Reviewed by Alexey Proskuryakov.
      
      NetworkConnectionToWebProcess now keeps its own id->loader map so it can directly address them as needed:
      * NetworkProcess/NetworkConnectionToWebProcess.cpp:
      (WebKit::NetworkConnectionToWebProcess::~NetworkConnectionToWebProcess):
      (WebKit::NetworkConnectionToWebProcess::didReceiveMessage):
      (WebKit::NetworkConnectionToWebProcess::didClose):
      (WebKit::NetworkConnectionToWebProcess::scheduleResourceLoad):
      (WebKit::NetworkConnectionToWebProcess::removeLoadIdentifier):
      * NetworkProcess/NetworkConnectionToWebProcess.h:
      
      NetworkResourceLoadScheduler no longer keeps an identifier -> loader map:
      * NetworkProcess/NetworkResourceLoadScheduler.cpp:
      (WebKit::NetworkResourceLoadScheduler::scheduleResourceLoad):
      (WebKit::NetworkResourceLoadScheduler::removeLoadIdentifier):
      * NetworkProcess/NetworkResourceLoadScheduler.h:
      
      There is no longer such a thing as NetworkConnectionToWebProcessObserver:
      * NetworkProcess/NetworkResourceLoader.cpp:
      (WebKit::NetworkResourceLoader::NetworkResourceLoader):
      (WebKit::NetworkResourceLoader::~NetworkResourceLoader):
      (WebKit::NetworkResourceLoader::connectionToWebProcessDidClose):
      * NetworkProcess/NetworkResourceLoader.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140038 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fdc0247c
    • ap@apple.com's avatar
      Fix a logic error in AuthenticationChallengeMac · 8ab71ad1
      ap@apple.com authored
              https://bugs.webkit.org/show_bug.cgi?id=107164
      
              Reviewed by Brady Eidson.
      
              No new tests, as this is not currently observable.
      
              * platform/network/cf/AuthenticationCF.cpp:
              (WebCore::createCF): Added a FIXME about making this more like Mac counterpart.
      
              * platform/network/cf/AuthenticationChallenge.h:
              (AuthenticationChallenge): Corrected an slightly misleading explanation.
      
              * platform/network/mac/AuthenticationMac.mm:
              (WebCore::AuthenticationChallenge::setAuthenticationClient): Don't create a dummy
              m_nsChallenge object in place of a nil one.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140037 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8ab71ad1
    • tonyg@chromium.org's avatar
      Remove unused finishWasCalled() method · 416a22b1
      tonyg@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=107148
      
      Reviewed by Eric Seidel.
      
      Based on patch by Eric Seidel.
      
      No new tests because no new functionality.
      
      * dom/DocumentParser.h:
      (DocumentParser):
      * dom/RawDataDocumentParser.h:
      (WebCore::RawDataDocumentParser::append):
      * html/parser/HTMLDocumentParser.cpp:
      * html/parser/HTMLDocumentParser.h:
      (HTMLDocumentParser):
      * html/parser/HTMLViewSourceParser.cpp:
      * html/parser/HTMLViewSourceParser.h:
      (HTMLViewSourceParser):
      * xml/parser/NewXMLDocumentParser.cpp:
      (WebCore::NewXMLDocumentParser::NewXMLDocumentParser):
      (WebCore::NewXMLDocumentParser::finish):
      * xml/parser/NewXMLDocumentParser.h:
      (NewXMLDocumentParser):
      * xml/parser/XMLDocumentParser.cpp:
      * xml/parser/XMLDocumentParser.h:
      (XMLDocumentParser):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140036 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      416a22b1
    • commit-queue@webkit.org's avatar
      [chromium] Double-tap zoom should take into account accessibility fontScaleFactor · 8822a767
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=107123
      
      Patch by John Mellor <johnme@chromium.org> on 2013-01-17
      Reviewed by Adam Barth.
      
      Platforms which support Text Autosizing (currently just Chrome for
      Android) may provide a textAutosizingFontScaleFactor (defaults to 1.0).
      
      This value is intended to be chosen by the user to indicate how large
      they want text to appear, for example Chrome for Android has a "Text
      scaling" slider in Settings > Accessibility that lets you choose a value
      in the range 50% - 200% (defaults to 100%*).
      
      For text in wide columns that typically gets autosized, this value is
      applied by multiplying the textAutosizingMultiplier computed for each
      cluster by the textAutosizingFontScaleFactor. Double-tap zoom will fit
      the column to the screen (ignoring the textAutosizingFontScaleFactor)
      since the column is wide. This part already works.
      
      For text in narrow columns that doesn't get autosized, the
      textAutosizingFontScaleFactor is not applied through Text Autosizing,
      and instead needs to be applied by adjusting the double-tap zoom level.
      When double-tapping on narrow columns, instead of fitting the column to
      the screen (which would often zoom in excessively far), the existing
      logic in computeScaleAndScrollForHitRect applies a maximum zoom level
      called the legibleScale. This value needs to be multiplied by the
      textAutosizingFontScaleFactor, so that we zoom in proportionately
      further on non-autosized narrow columns, hence the effective text size
      (taking into account zoom) will have increased in proportion to the
      textAutosizingFontScaleFactor as expected.
      
      * src/WebViewImpl.cpp:
      (WebKit::WebViewImpl::computeScaleAndScrollForHitRect):
          Multiplies legibleScale (the maximum zoom level) by the
          textAutosizingFontScaleFactor.
      * tests/WebFrameTest.cpp:
          Added WebFrameTest.DivAutoZoomScaleFontScaleFactorTest based on
          WebFrameTest.DivAutoZoomScaleBoundsTest to test the interaction
          between textAutosizingFontScaleFactor and the double-tap zoom logic.
          Also did minor cleanup to WebFrameTest.DivAutoZoomScaleBoundsTest.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140035 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8822a767
    • hclam@chromium.org's avatar
      [chromium] Layout test rebaselines. · 880b1a71
      hclam@chromium.org authored
      Not reviewed. Rebaselines to fix build.
      
      * platform/chromium-mac-snowleopard/svg/custom/foreign-object-skew-expected.png:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140034 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      880b1a71
    • timothy_horton@apple.com's avatar
      Remove an incorrect ASSERT() after r140002. · a7b23d3a
      timothy_horton@apple.com authored
      Reviewed by Simon Fraser.
      
      setRootCompositingLayer(null) is valid now.
      
      * WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
      (WebKit::TiledCoreAnimationDrawingArea::setRootCompositingLayer):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140033 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a7b23d3a
    • ojan@chromium.org's avatar
      MathML padding overrides only need to be on RenderMathMLRoot · e4d77874
      ojan@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=107151
      
      Reviewed by Tony Chang.
      
      RenderMathMLRoot is the only class that uses these.
      No need for them to be on the generic MathML superclass.
      
      * rendering/mathml/RenderMathMLBlock.cpp:
      (WebCore::RenderMathMLBlock::RenderMathMLBlock):
      * rendering/mathml/RenderMathMLBlock.h:
      * rendering/mathml/RenderMathMLRoot.cpp:
      (WebCore::RenderMathMLRoot::RenderMathMLRoot):
      (WebCore::RenderMathMLRoot::paddingTop):
      (WebCore::RenderMathMLRoot::paddingBottom):
      (WebCore::RenderMathMLRoot::paddingLeft):
      (WebCore::RenderMathMLRoot::paddingRight):
      (WebCore::RenderMathMLRoot::paddingBefore):
      (WebCore::RenderMathMLRoot::paddingAfter):
      (WebCore::RenderMathMLRoot::paddingStart):
      (WebCore::RenderMathMLRoot::paddingEnd):
      * rendering/mathml/RenderMathMLRoot.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140032 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e4d77874
    • mhahnenberg@apple.com's avatar
      Objective-C API: Clean up JSValue · a9e9f9d1
      mhahnenberg@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=107156
      
      Reviewed by Oliver Hunt.
      
      JSContext m_protectCounts, protect, unprotect are all now unnecessary overhead, and should all be removed.  
      These exist to handle the context going away before the value does; the context needs to be able to unprotect 
      values early.  Since the value is now keeping the context alive there is no longer any danger of this happening; 
      instead we should just protect/unprotect the value in JSValue's init/dealloc methods.
      
      * API/JSContext.mm:
      (-[JSContext dealloc]):
      * API/JSContextInternal.h:
      * API/JSValue.mm:
      (-[JSValue initWithValue:inContext:]):
      (-[JSValue dealloc]):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140031 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a9e9f9d1
    • fpizlo@apple.com's avatar
      DFG Node::ref() and Node::deref() should not return bool, and should have postfixRef variants · 78009019
      fpizlo@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=107147
      
      Reviewed by Mark Hahnenberg.
              
      This small refactoring will enable a world where ref() returns Node*, which is useful for
      https://bugs.webkit.org/show_bug.cgi?id=106868.  Also, while this refactoring does lead to
      slightly less terse code, it's also slightly more self-explanatory.  I could never quite
      remember what the meaning of the bool return from ref() and deref() was.
      
      * dfg/DFGGraph.cpp:
      (JSC::DFG::Graph::collectGarbage):
      * dfg/DFGGraph.h:
      (JSC::DFG::Graph::ref):
      (JSC::DFG::Graph::deref):
      * dfg/DFGNode.h:
      (JSC::DFG::Node::ref):
      (Node):
      (JSC::DFG::Node::postfixRef):
      (JSC::DFG::Node::deref):
      (JSC::DFG::Node::postfixDeref):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140030 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      78009019
    • commit-queue@webkit.org's avatar
      32-bit build for Qt5 on Mac OS fails. · f8b045c1
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=107094
      
      We need to define NS_BUILD_32_LIKE_64 for 32-bit build for Mac OS.
      Fixed 32-bit build detection for support Qt5.
      
      Source/WebCore:
      
      Patch by Poul Sysolyatin <psytonx@gmail.com> on 2013-01-17
      Reviewed by Benjamin Poulain.
      
      * Target.pri:
      
      Source/WebKit:
      
      Patch by Poul Sysolyatin <psytonx@gmail.com> on 2013-01-17
      Reviewed by Benjamin Poulain.
      
      * WebKit1.pro:
      
      Source/WebKit2:
      
      Patch by Poul Sysolyatin <psytonx@gmail.com> on 2013-01-17
      Reviewed by Benjamin Poulain.
      
      * Target.pri:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140029 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f8b045c1
    • schenney@chromium.org's avatar
      [Chromium] svg/custom/foreign-object-skew-expected.png differs Debug/Release on SnowLeopard · cc3f86d3
      schenney@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=99138
      
      Unreviewed test expectations update.
      
      * platform/chromium-mac-snowleopard/svg/custom/foreign-object-skew-expected.png: Use the Release result.
      * platform/chromium/TestExpectations: Mark the test as failing, and won't fix.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140028 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cc3f86d3