- 07 Oct, 2013 37 commits
-
-
andersca@apple.com authored
* wtf/StdLibExtras.h: (std::make_unique): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@157066 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
akling@apple.com authored
<https://webkit.org/b/122470> Reviewed by Anders Carlsson. Make LiveNodeListBase::m_ownerNode a Ref<Node> instead of a RefPtr and have all constructors take Node&. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@157065 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
kov@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=122230 Patch by Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> on 2013-10-07 Reviewed by Darin Adler. * UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::close): move duplicate code to resetState and call it. (WebKit::WebPageProxy::resetState): new private method for code that is shared between close and resetStateAfterProcessExited. (WebKit::WebPageProxy::resetStateAfterProcessExited): move duplicate code to resetState and call it. * UIProcess/WebPageProxy.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@157064 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
andersca@apple.com authored
* Scripts/webkitpy/port/base.py: (Port.to.start_helper): * Scripts/webkitpy/port/mock_drt.py: (MockDRTPort.start_helper): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@157063 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
fpizlo@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=116189 Reviewed by Sam Weinig. Use a RefCountedArray<int64_t> for data sections. This works out great because RefCountedArray<> knows its own size and because the reference counting makes passing it around very easy (you don't have to stress out about ownership). * ftl/FTLCompile.cpp: (JSC::FTL::mmAllocateDataSection): (JSC::FTL::compile): * ftl/FTLJITCode.cpp: (JSC::FTL::JITCode::addDataSection): * ftl/FTLJITCode.h: (JSC::FTL::JITCode::dataSections): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@157062 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
andersca@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=122469 Reviewed by Andreas Kling. * Modules/webdatabase/Database.cpp: (WebCore::DerefContextTask::DerefContextTask): (WebCore::Database::~Database): (WebCore::DeliverPendingCallbackTask::DeliverPendingCallbackTask): (WebCore::Database::scheduleTransactionCallback): * Modules/webdatabase/DatabaseManager.cpp: (WebCore::DatabaseCreationCallbackTask::DatabaseCreationCallbackTask): (WebCore::DatabaseManager::openDatabase): * Modules/webdatabase/SQLCallbackWrapper.h: (WebCore::SQLCallbackWrapper::clear): (WebCore::SQLCallbackWrapper::SafeReleaseTask::SafeReleaseTask): * Modules/websockets/ThreadableWebSocketChannelClientWrapper.cpp: (WebCore::ThreadableWebSocketChannelClientWrapper::processPendingTasks): * Modules/websockets/ThreadableWebSocketChannelClientWrapper.h: * Modules/websockets/WorkerThreadableWebSocketChannel.cpp: (WebCore::WorkerThreadableWebSocketChannel::WorkerGlobalScopeDidInitializeTask::WorkerGlobalScopeDidInitializeTask): (WebCore::WorkerThreadableWebSocketChannel::Bridge::mainThreadInitialize): * bindings/js/JSCallbackData.h: (WebCore::DeleteCallbackDataTask::DeleteCallbackDataTask): * bindings/js/JSDOMGlobalObjectTask.h: * bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBase::queueTaskToEventLoop): * bindings/js/JSWorkerGlobalScopeBase.cpp: (WebCore::JSWorkerGlobalScopeBase::queueTaskToEventLoop): * bindings/scripts/CodeGeneratorJS.pm: (GenerateCallbackImplementation): * dom/CrossThreadTask.h: (WebCore::createCallbackTask): * dom/Document.cpp: (WebCore::Document::addConsoleMessage): (WebCore::Document::addMessage): (WebCore::PerformTaskContext::PerformTaskContext): (WebCore::Document::postTask): (WebCore::Document::pendingTasksTimerFired): * dom/Document.h: * dom/ScriptExecutionContext.cpp: (WebCore::ProcessMessagesSoonTask::ProcessMessagesSoonTask): (WebCore::ScriptExecutionContext::processMessagePortMessagesSoon): * dom/ScriptExecutionContext.h: * dom/StringCallback.cpp: (WebCore::StringCallback::scheduleCallback): * loader/appcache/ApplicationCacheGroup.cpp: (WebCore::CallCacheListenerTask::CallCacheListenerTask): (WebCore::ApplicationCacheGroup::postListenerTask): * workers/DefaultSharedWorkerRepository.cpp: (WebCore::SharedWorkerProxy::postTaskToLoader): (WebCore::SharedWorkerProxy::postTaskForModeToWorkerGlobalScope): (WebCore::DefaultSharedWorkerRepository::workerScriptLoaded): (WebCore::DefaultSharedWorkerRepository::connectToWorker): * workers/WorkerEventQueue.cpp: (WebCore::WorkerEventQueue::enqueueEvent): * workers/WorkerGlobalScope.cpp: (WebCore::WorkerGlobalScope::close): (WebCore::WorkerGlobalScope::postTask): (WebCore::WorkerGlobalScope::addConsoleMessage): (WebCore::WorkerGlobalScope::addMessage): * workers/WorkerGlobalScope.h: * workers/WorkerLoaderProxy.h: * workers/WorkerMessagingProxy.cpp: (WebCore::WorkerMessagingProxy::postMessageToWorkerObject): (WebCore::WorkerMessagingProxy::postMessageToWorkerGlobalScope): (WebCore::WorkerMessagingProxy::postTaskForModeToWorkerGlobalScope): (WebCore::WorkerMessagingProxy::postTaskToLoader): (WebCore::WorkerMessagingProxy::postExceptionToWorkerObject): (WebCore::WorkerMessagingProxy::workerThreadCreated): (WebCore::WorkerMessagingProxy::notifyNetworkStateChange): (WebCore::WorkerMessagingProxy::workerGlobalScopeDestroyed): (WebCore::WorkerMessagingProxy::workerGlobalScopeClosed): (WebCore::WorkerMessagingProxy::postMessageToPageInspector): (WebCore::WorkerMessagingProxy::confirmMessageFromWorkerObject): (WebCore::WorkerMessagingProxy::reportPendingActivity): * workers/WorkerMessagingProxy.h: * workers/WorkerRunLoop.cpp: (WebCore::WorkerRunLoop::postTask): (WebCore::WorkerRunLoop::postTaskAndTerminate): (WebCore::WorkerRunLoop::postTaskForMode): (WebCore::WorkerRunLoop::Task::Task): * workers/WorkerRunLoop.h: * workers/WorkerThread.cpp: (WebCore::WorkerThreadShutdownFinishTask::WorkerThreadShutdownFinishTask): (WebCore::WorkerThreadShutdownStartTask::performTask): (WebCore::WorkerThread::stop): (WebCore::WorkerThread::releaseFastMallocFreeMemoryInAllThreads): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@157061 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
roger_fong@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=122467. <rdar://problem/15169174>. Reviewed by Brent Fulgham. * WTF.vcxproj/WTF.make: * JavaScriptCore.vcxproj/JavaScriptCore.make: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@157060 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=122363 Patch by Nadav Rotem <nrotem@apple.com> on 2013-10-07 Reviewed by Filip Pizlo. * dfg/DFGFixupPhase.cpp: (JSC::DFG::FixupPhase::fixupNode): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@157059 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=122427 Patch by Sam Weinig <sam@webkit.org> on 2013-10-07 Reviewed by Andreas Kling. Source/WebCore: Use references to indicate non-nullness of DragController related objects. Source/WebKit/efl: * WebCoreSupport/DragClientEfl.cpp: (WebCore::DragClientEfl::willPerformDragDestinationAction): (WebCore::DragClientEfl::willPerformDragSourceAction): (WebCore::DragClientEfl::actionMaskForDrag): (WebCore::DragClientEfl::startDrag): * WebCoreSupport/DragClientEfl.h: Source/WebKit/gtk: * WebCoreSupport/DragClientGtk.cpp: (WebKit::DragClient::willPerformDragDestinationAction): (WebKit::DragClient::willPerformDragSourceAction): (WebKit::DragClient::actionMaskForDrag): (WebKit::DragClient::startDrag): * WebCoreSupport/DragClientGtk.h: * webkit/webkitwebview.cpp: (dragExitedCallback): (webkit_web_view_drag_motion): (webkit_web_view_drag_data_received): (webkit_web_view_drag_drop): Source/WebKit/mac: * WebCoreSupport/WebDragClient.h: * WebCoreSupport/WebDragClient.mm: (WebDragClient::actionMaskForDrag): (WebDragClient::willPerformDragDestinationAction): (WebDragClient::willPerformDragSourceAction): (WebDragClient::startDrag): (WebDragClient::declareAndWriteDragImage): * WebView/WebFrame.mm: (-[WebFrame _replaceSelectionWithText:selectReplacement:smartReplace:]): * WebView/WebHTMLView.mm: (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]): * WebView/WebView.mm: (-[WebView draggingEntered:]): (-[WebView draggingUpdated:]): (-[WebView draggingExited:]): (-[WebView performDragOperation:]): Source/WebKit/win: * WebCoreSupport/WebDragClient.cpp: (WebDragClient::actionMaskForDrag): (WebDragClient::willPerformDragDestinationAction): (WebDragClient::willPerformDragSourceAction): (WebDragClient::startDrag): * WebCoreSupport/WebDragClient.h: Source/WebKit2: * UIProcess/API/gtk/WebKitWebViewBase.cpp: (webkitWebViewBaseDragDataReceived): (webkitWebViewBaseDragMotion): (dragExitedCallback): (webkitWebViewBaseDragDrop): * UIProcess/API/mac/WKView.mm: (-[WKView draggingEntered:]): (-[WKView draggingUpdated:]): (-[WKView draggingExited:]): (-[WKView performDragOperation:]): * UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::dragEntered): (WebKit::WebPageProxy::dragUpdated): (WebKit::WebPageProxy::dragExited): (WebKit::WebPageProxy::performDrag): (WebKit::WebPageProxy::performDragControllerAction): * UIProcess/WebPageProxy.h: * WebProcess/WebCoreSupport/WebDragClient.cpp: (WebKit::WebDragClient::willPerformDragDestinationAction): (WebKit::WebDragClient::willPerformDragSourceAction): (WebKit::WebDragClient::actionMaskForDrag): (WebKit::WebDragClient::dragSourceActionMaskForPoint): (WebKit::WebDragClient::startDrag): * WebProcess/WebCoreSupport/WebDragClient.h: * WebProcess/WebCoreSupport/gtk/WebDragClientGtk.cpp: (WebKit::WebDragClient::startDrag): * WebProcess/WebCoreSupport/mac/WebDragClientMac.mm: (WebKit::WebDragClient::startDrag): (WebKit::cachedImage): (WebKit::WebDragClient::declareAndWriteDragImage): * WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::performDragControllerAction): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@157058 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
andersca@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=122465 Reviewed by Tim Horton. This should speed up WebGL tests and hopefully prevent race conditions that may cause window server crashes from happening. * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Link with IOKit. * DumpRenderTree/mac/LayoutTestHelper.m: (installLayoutTestColorProfile): Check installColorProfile. (restoreUserColorProfile): Check installColorProfile. (lockDownDiscreteGraphics): New function to force discrete graphics. (main): Add '--install-color-profile' option. * Scripts/webkitpy/layout_tests/controllers/manager.py: (Manager._set_up_run): Always start the helper, but pass self._options.pixel_tests to it. * Scripts/webkitpy/port/mac.py: (MacPort.start_helper): Pass --install-color-profile' to the helper if pixel_tests is true. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@157057 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
timothy_horton@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=122464 <rdar://problem/14293474> Reviewed by Simon Fraser. Always kickstart animated images when the page visibility changes, which can occur via window occlusion, and which is independent of in-window state, which we were previously using to advance animation. No new tests; attempts to make a test have resulted only in a flaky, timing-dependent test. * page/Frame.cpp: (WebCore::Frame::resumeActiveDOMObjectsAndAnimations): Move this call to resumeAnimatingImages() up to Page. * page/FrameView.cpp: (WebCore::FrameView::setIsInWindow): Move this call to resumeAnimatingImages() up to Page. * WebCore.exp.in * page/FrameView.h: * page/Page.h: Move resumeAnimatingImages() itself up to Page. * page/Page.cpp: (WebCore::Page::setIsInWindow): Resume animated images when we move in-window. (WebCore::Page::setVisibilityState): Resume animated images when we become visible. This is the one we were previously missing. (WebCore::Page::resumeActiveDOMObjectsAndAnimations): Resume animated images when we're told to. (WebCore::Page::resumeAnimatingImages): Kickstart any animated images in all frames. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@157056 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
dino@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=122404 Patch by Jer Noble <jer.noble@apple.com> on 2013-10-07 Reviewed by Eric Carlson. Source/WebCore: Test: media/video-canvas-drawing.html If creating and painting from an AVPlayerItemVideoOutput fails, fall back to the (much slower) AVAssetImageGenerator path. Make sure to revert to the AVPlayerItemVideoOutput path when that object begins to have available images, however. To do so, remove the "__MAC_OS_X_VERSION_MIN_REQUIRED < 1080" check around the AVAssetImageGenerator code, and allow both the image generator and video output to exist simultaneously. * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h: * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm: (WebCore::MediaPlayerPrivateAVFoundationObjC::hasContextRenderer): (WebCore::MediaPlayerPrivateAVFoundationObjC::destroyContextVideoRenderer): (WebCore::MediaPlayerPrivateAVFoundationObjC::destroyImageGenerator): (WebCore::MediaPlayerPrivateAVFoundationObjC::paintCurrentFrameInContext): (WebCore::MediaPlayerPrivateAVFoundationObjC::videoOutputHasAvailableFrame): (WebCore::MediaPlayerPrivateAVFoundationObjC::paintWithVideoOutput): LayoutTests: * media/video-canvas-drawing-expected.png: Added. * media/video-canvas-drawing-expected.txt: Added. * media/video-canvas-drawing.html: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@157055 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
jer.noble@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=122301 Reviewed by Philippe Normand. Rename URLMediaSource and URLMediaStream to DOMURLMediaSource and DOMURLMediaStream, respectively. Update the build files: * CMakeLists.txt: Rename URL -> DOMURL. * DerivedSources.make: Ditto. * GNUmakefile.list.am: Ditto. * WebCore.xcodeproj/project.pbxproj: Ditto. Rename the .idl and implementation files: * Modules/mediasource/DOMURLMediaSource.cpp: Renamed from Source/WebCore/Modules/mediasource/URLMediaSource.cpp. (WebCore::DOMURLMediaSource::createObjectURL): * Modules/mediasource/DOMURLMediaSource.h: Renamed from Source/WebCore/Modules/mediasource/URLMediaSource.h. * Modules/mediasource/DOMURLMediaSource.idl: Renamed from Source/WebCore/Modules/mediasource/URLMediaSource.idl. * Modules/mediastream/DOMURLMediaStream.cpp: Renamed from Source/WebCore/Modules/mediastream/URLMediaStream.cpp. (WebCore::DOMURLMediaStream::createObjectURL): * Modules/mediastream/DOMURLMediaStream.h: Renamed from Source/WebCore/Modules/mediastream/URLMediaStream.h. * Modules/mediastream/DOMURLMediaStream.idl: Renamed from Source/WebCore/Modules/mediastream/URLMediaStream.idl. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@157054 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
timothy_horton@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=122456 * platform/mac-wk2/TestExpectations: Mark the test as failing for now. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@157053 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
timothy@apple.com authored
Fix the total for multiple failures in different steps too by avoiding undefined. https://bugs.webkit.org/show_bug.cgi?id=122232 Reviewed by Alexey Proskuryakov. * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js: (BuildbotTestResults): * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js: (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@157052 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
mihnea@adobe.com authored
https://bugs.webkit.org/show_bug.cgi?id=122451 Reviewed by Sam Weinig. Create region-styling folder under fast/regions and move related region styling tests. * fast/regions/region-styling/parse-incomplete-region-rule-expected.txt: Renamed from LayoutTests/fast/regions/parse-incomplete-region-rule-expected.txt. * fast/regions/region-styling/parse-incomplete-region-rule.html: Renamed from LayoutTests/fast/regions/parse-incomplete-region-rule.html. * fast/regions/region-styling/parsing-region-style-rule-expected.txt: Renamed from LayoutTests/fast/regions/parsing-region-style-rule-expected.txt. * fast/regions/region-styling/parsing-region-style-rule.html: Renamed from LayoutTests/fast/regions/parsing-region-style-rule.html. * fast/regions/region-styling/region-rule-nested-region-rule-expected.html: Renamed from LayoutTests/fast/regions/region-rule-nested-region-rule-expected.html. * fast/regions/region-styling/region-rule-nested-region-rule.html: Renamed from LayoutTests/fast/regions/region-rule-nested-region-rule.html. * fast/regions/region-styling/region-style-block-background-color-expected.html: Renamed from LayoutTests/fast/regions/region-style-block-background-color-expected.html. * fast/regions/region-styling/region-style-block-background-color.html: Renamed from LayoutTests/fast/regions/region-style-block-background-color.html. * fast/regions/region-styling/region-style-block-background-color2-expected.html: Renamed from LayoutTests/fast/regions/region-style-block-background-color2-expected.html. * fast/regions/region-styling/region-style-block-background-color2.html: Renamed from LayoutTests/fast/regions/region-style-block-background-color2.html. * fast/regions/region-styling/region-style-color-expected.html: Renamed from LayoutTests/fast/regions/region-style-color-expected.html. * fast/regions/region-styling/region-style-color.html: Renamed from LayoutTests/fast/regions/region-style-color.html. * fast/regions/region-styling/region-style-image-background-color-expected.html: Renamed from LayoutTests/fast/regions/region-style-image-background-color-expected.html. * fast/regions/region-styling/region-style-image-background-color.html: Renamed from LayoutTests/fast/regions/region-style-image-background-color.html. * fast/regions/region-styling/region-style-in-columns-expected.html: Renamed from LayoutTests/fast/regions/region-style-in-columns-expected.html. * fast/regions/region-styling/region-style-in-columns.html: Renamed from LayoutTests/fast/regions/region-style-in-columns.html. * fast/regions/region-styling/region-style-inline-background-color-expected.html: Renamed from LayoutTests/fast/regions/region-style-inline-background-color-expected.html. * fast/regions/region-styling/region-style-inline-background-color.html: Renamed from LayoutTests/fast/regions/region-style-inline-background-color.html. * fast/regions/region-styling/region-style-not-supported-properties-expected.html: Renamed from LayoutTests/fast/regions/region-style-not-supported-properties-expected.html. * fast/regions/region-styling/region-style-not-supported-properties.html: Renamed from LayoutTests/fast/regions/region-style-not-supported-properties.html. * fast/regions/region-styling/region-style-rule-position-expected.html: Renamed from LayoutTests/fast/regions/region-style-rule-position-expected.html. * fast/regions/region-styling/region-style-rule-position.html: Renamed from LayoutTests/fast/regions/region-style-rule-position.html. * fast/regions/region-styling/region-style-rule-specificity-expected.html: Renamed from LayoutTests/fast/regions/region-style-rule-specificity-expected.html. * fast/regions/region-styling/region-style-rule-specificity.html: Renamed from LayoutTests/fast/regions/region-style-rule-specificity.html. * fast/regions/region-styling/region-styling-mediaquery-expected.html: Renamed from LayoutTests/fast/regions/region-styling-mediaquery-expected.html. * fast/regions/region-styling/region-styling-mediaquery.html: Renamed from LayoutTests/fast/regions/region-styling-mediaquery.html. * fast/regions/region-styling/remove-leftover-anon-block-crash-expected.txt: Renamed from LayoutTests/fast/regions/remove-leftover-anon-block-crash-expected.txt. * fast/regions/region-styling/remove-leftover-anon-block-crash.html: Renamed from LayoutTests/fast/regions/remove-leftover-anon-block-crash.html. * fast/regions/region-styling/removed-element-style-in-region-crash-expected.txt: Renamed from LayoutTests/fast/regions/removed-element-style-in-region-crash-expected.txt. * fast/regions/region-styling/removed-element-style-in-region-crash.html: Renamed from LayoutTests/fast/regions/removed-element-style-in-region-crash.html. * fast/regions/region-styling/render-region-custom-style-mark-expected.html: Renamed from LayoutTests/fast/regions/render-region-custom-style-mark-expected.html. * fast/regions/region-styling/render-region-custom-style-mark.html: Renamed from LayoutTests/fast/regions/render-region-custom-style-mark.html. * fast/regions/region-styling/set-box-style-in-region-crash-expected.txt: Renamed from LayoutTests/fast/regions/set-box-style-in-region-crash-expected.txt. * fast/regions/region-styling/set-box-style-in-region-crash.html: Renamed from LayoutTests/fast/regions/set-box-style-in-region-crash.html. * fast/regions/region-styling/webkit-region-rule-expected.txt: Renamed from LayoutTests/fast/regions/webkit-region-rule-expected.txt. * fast/regions/region-styling/webkit-region-rule.html: Renamed from LayoutTests/fast/regions/webkit-region-rule.html. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@157051 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
msaboff@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=122289 Reviewed by Filip Pizlo. Replaced jit stubs cti_stack_check, cti_op_call_arityCheck and cti_op_construct_arityCheck with jit operations operationStackCheck, operationCallArityCheck & operationConstructArityCheck. Added new callOperationWithCallFrameRollbackOnException() in baseline and DFG JITs to call these new functions. Added code to unwind one frame in JIT::privateCompileExceptionHandlers() and JITCompiler::compileExceptionHandlers() for these cases that need to throw exceptions in their caller frame when the stack is exhausted. * assembler/MacroAssembler.h: (JSC::MacroAssembler::andPtr): Added to handle masking a pointer with a literal. * assembler/MacroAssemblerX86_64.h: (JSC::MacroAssemblerX86_64::and64): Added to handle masking a pointer with a literal. * dfg/DFGJITCompiler.cpp: (JSC::DFG::JITCompiler::compileExceptionHandlers): (JSC::DFG::JITCompiler::compileFunction): (JSC::DFG::JITCompiler::linkFunction): * dfg/DFGJITCompiler.h: (JSC::DFG::JITCompiler::exceptionCheckWithCallFrameRollback): * dfg/DFGSpeculativeJIT.h: (JSC::DFG::SpeculativeJIT::callOperationWithCallFrameRollbackOnException): (JSC::DFG::SpeculativeJIT::appendCallWithExceptionCheck): (JSC::DFG::SpeculativeJIT::appendCallWithCallFrameRollbackOnException): (JSC::DFG::SpeculativeJIT::appendCallWithExceptionCheckSetResult): (JSC::DFG::SpeculativeJIT::appendCallWithCallFrameRollbackOnExceptionSetResult): * ftl/FTLLink.cpp: (JSC::FTL::link): * interpreter/CallFrame.h: (JSC::ExecState::hostCallFrameFlag): * jit/AssemblyHelpers.cpp: (JSC::AssemblyHelpers::jitAssertIsNull): * jit/AssemblyHelpers.h: (JSC::AssemblyHelpers::jitAssertIsNull): * jit/JIT.cpp: (JSC::JIT::privateCompile): (JSC::JIT::privateCompileExceptionHandlers): * jit/JIT.h: (JSC::JIT::exceptionCheckWithCallFrameRollback): * jit/JITInlines.h: (JSC::JIT::appendCallWithCallFrameRollbackOnException): (JSC::JIT::callOperationWithCallFrameRollbackOnException): * jit/JITOperations.cpp: * jit/JITOperations.h: * jit/JITStubs.cpp: * jit/JITStubs.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@157050 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
andersca@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=122452 Reviewed by Sam Weinig. Change RefPtrHashMap to not use passOut (just like the regular HashMap) and get rid of the passIn and passOut functions and related typedefs. * wtf/HashTraits.h: * wtf/RefPtrHashMap.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@157049 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=122443 Patch by Philippe Normand <pnormand@igalia.com> on 2013-10-07 Reviewed by Darin Adler. * bindings/scripts/CodeGeneratorJS.pm: (GenerateOverloadedFunction): Generate conditional for overloaded function, if it's present in the idl. (GenerateImplementation): Close the last overloaded function conditional before generating the distpatch function. * bindings/scripts/test/JS/JSTestObj.cpp: (WebCore::jsTestObjConstructorFunctionOverloadedMethod1): Rebaseline overloaded function tests. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@157048 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
fpizlo@apple.com authored
ASSERTION FAILED: isUInt32() in jsc-layout-tests.yaml/js/script-tests/dfg-uint32-to-number-in-middle-of-copy-propagation.js.layout-dfg-eager-no-cjit https://bugs.webkit.org/show_bug.cgi?id=122419 Source/JavaScriptCore: Reviewed by Oliver Hunt. AI was using JSValue::asUInt32() incorrectly. That method presumes that the input is both a int32 and a uint32 (it's in the range [0, 2^31)). The UInt32ToNumber node is instead dealing with an input that is always represented as a int32 but that has the meaning of a uint32 - so AI should use JSValue::asInt32() and then do the cast. * dfg/DFGAbstractInterpreterInlines.h: (JSC::DFG::::executeEffects): LayoutTests: Reviewed by Oliver Hunt. * js/script-tests/dfg-uint32-to-number-in-middle-of-copy-propagation.js: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@157047 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=120007 Patch by Julien Brianceau <jbriance@cisco.com> on 2013-10-07 Reviewed by Oliver Hunt. Jump over maxJumpReplacementSize in revertJumpToMove, even if there is no constant value within the area. This patch fixes debug ASSERTs failures for sh4 architecture. * assembler/SH4Assembler.h: (JSC::SH4Assembler::revertJumpToMove): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@157046 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
timothy_horton@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=122441 <rdar://problem/13973162> Reviewed by Simon Fraser. Test: css3/images/cross-fade-svg-with-opacity.html * platform/graphics/CrossfadeGeneratedImage.cpp: (WebCore::drawCrossfadeSubimage): (WebCore::CrossfadeGeneratedImage::drawCrossfade): Factor the image painting out into a function. Conditionally use a transparency layer around painting if the image we're drawing is an SVG (SVGImage is the only Image subclass that will not respect the context's opacity). Add a test that ensures that -cross-fade with SVG images draws correctly. * css3/images/cross-fade-svg-with-opacity-expected.html: Added. * css3/images/cross-fade-svg-with-opacity.html: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@157045 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
andersca@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=122439 Reviewed by Antti Koivisto. Source/JavaScriptCore: * API/JSAPIWrapperObject.mm: * API/JSCallbackObject.h: (JSC::JSCallbackObjectData::~JSCallbackObjectData): * API/JSManagedValue.mm: * API/JSScriptRef.cpp: (OpaqueJSScript::~OpaqueJSScript): * bytecode/CodeBlock.h: * bytecode/StructureStubClearingWatchpoint.h: * dfg/DFGArrayifySlowPathGenerator.h: * dfg/DFGCallArrayAllocatorSlowPathGenerator.h: * dfg/DFGFailedFinalizer.h: * dfg/DFGJITCode.h: * dfg/DFGJITFinalizer.h: * dfg/DFGSaneStringGetByValSlowPathGenerator.h: * dfg/DFGSlowPathGenerator.h: * dfg/DFGSpeculativeJIT64.cpp: * heap/Heap.h: * heap/IncrementalSweeper.h: * heap/SuperRegion.h: * jit/ClosureCallStubRoutine.h: * jit/ExecutableAllocatorFixedVMPool.cpp: * jit/GCAwareJITStubRoutine.h: * jit/JITCode.h: * jit/JITStubs.cpp: * jit/JITToDFGDeferredCompilationCallback.h: * jit/JumpReplacementWatchpoint.h: * parser/Nodes.h: * runtime/DataView.h: * runtime/GCActivityCallback.h: * runtime/GenericTypedArrayView.h: * runtime/RegExpCache.h: * runtime/SimpleTypedArrayController.h: * runtime/WeakMapData.h: Source/WebCore: * Modules/encryptedmedia/MediaKeys.h: * Modules/webaudio/AnalyserNode.h: * Modules/webaudio/AudioBasicInspectorNode.h: * Modules/webaudio/AudioBasicProcessorNode.h: * Modules/webaudio/AudioBufferSourceNode.h: * Modules/webaudio/AudioContext.h: * Modules/webaudio/AudioDestinationNode.h: * Modules/webaudio/AudioProcessingEvent.h: * Modules/webaudio/BiquadDSPKernel.h: * Modules/webaudio/BiquadProcessor.h: * Modules/webaudio/ChannelMergerNode.h: * Modules/webaudio/ChannelSplitterNode.h: * Modules/webaudio/ConvolverNode.h: * Modules/webaudio/DelayDSPKernel.h: * Modules/webaudio/DelayProcessor.h: * Modules/webaudio/DynamicsCompressorNode.h: * Modules/webaudio/GainNode.h: * Modules/webaudio/MediaElementAudioSourceNode.h: * Modules/webaudio/OfflineAudioCompletionEvent.h: * Modules/webaudio/OfflineAudioDestinationNode.h: * Modules/webaudio/OscillatorNode.h: * Modules/webaudio/PannerNode.h: * Modules/webaudio/ScriptProcessorNode.h: * Modules/webaudio/WaveShaperProcessor.h: * accessibility/AccessibilityARIAGrid.h: * accessibility/AccessibilityARIAGridCell.h: * accessibility/AccessibilityARIAGridRow.h: * accessibility/AccessibilityImageMapLink.h: * accessibility/AccessibilityList.h: * accessibility/AccessibilityListBox.h: * accessibility/AccessibilityListBoxOption.h: * accessibility/AccessibilityMediaControls.h: * accessibility/AccessibilityMenuList.h: * accessibility/AccessibilityMenuListOption.h: * accessibility/AccessibilityMenuListPopup.h: * accessibility/AccessibilityMockObject.h: * accessibility/AccessibilityNodeObject.h: * accessibility/AccessibilityProgressIndicator.h: * accessibility/AccessibilityRenderObject.h: * accessibility/AccessibilitySVGRoot.h: * accessibility/AccessibilityScrollView.h: * accessibility/AccessibilityScrollbar.h: * accessibility/AccessibilitySlider.h: * accessibility/AccessibilitySpinButton.h: * accessibility/AccessibilityTable.h: * accessibility/AccessibilityTableCell.h: * accessibility/AccessibilityTableColumn.h: * accessibility/AccessibilityTableHeaderContainer.h: * accessibility/AccessibilityTableRow.h: * bindings/js/JSEventListener.h: * bindings/js/WebCoreTypedArrayController.h: * bridge/c/c_class.h: * bridge/c/c_instance.h: * bridge/c/c_runtime.h: * bridge/runtime_root.h: * css/CSSBasicShapes.h: * css/CSSComputedStyleDeclaration.h: * css/CSSStyleSheet.h: * dom/Attr.h: * dom/BeforeTextInsertedEvent.h: * dom/CDATASection.h: * dom/ChildNodeList.h: * dom/DatasetDOMStringMap.h: * dom/Document.h: * dom/DocumentEventQueue.h: * dom/DocumentFragment.h: * dom/Element.h: * dom/ErrorEvent.h: * dom/KeyboardEvent.h: * dom/Node.h: * dom/PageTransitionEvent.h: * dom/ProgressEvent.h: * dom/PseudoElement.h: * dom/ScriptExecutionContext.h: * dom/ShadowRoot.h: * dom/StyledElement.h: * dom/TagNodeList.h: * dom/Text.h: * dom/TextEvent.h: * dom/TransitionEvent.h: * dom/UIEvent.h: * dom/WebKitAnimationEvent.h: * dom/WebKitTransitionEvent.h: * editing/ApplyBlockElementCommand.h: * editing/ApplyStyleCommand.h: * editing/BreakBlockquoteCommand.h: * editing/CompositeEditCommand.h: * editing/SpellingCorrectionCommand.h: * fileapi/File.h: * fileapi/FileThreadTask.h: * history/BackForwardList.h: * html/BaseCheckableInputType.h: * html/HTMLAnchorElement.h: * html/HTMLAreaElement.h: * html/HTMLCanvasElement.h: * html/HTMLCollection.h: * html/HTMLElement.h: * html/HTMLFieldSetElement.h: * html/HTMLFormControlElement.h: * html/HTMLFormControlElementWithState.h: * html/HTMLFormElement.h: * html/HTMLFrameElementBase.h: * html/HTMLImageElement.h: * html/HTMLImageLoader.h: * html/HTMLInputElement.h: * html/HTMLLabelElement.h: * html/HTMLLegendElement.h: * html/HTMLMediaElement.h: * html/HTMLMeterElement.h: * html/HTMLOptGroupElement.h: * html/HTMLOptionElement.h: * html/HTMLPlugInElement.h: * html/HTMLPlugInImageElement.h: * html/HTMLProgressElement.h: * html/HTMLSelectElement.h: * html/HTMLTableElement.h: * html/HTMLTextAreaElement.h: * html/HTMLTextFormControlElement.h: * html/HTMLVideoElement.h: * html/canvas/CanvasRenderingContext2D.cpp: * html/shadow/MediaControlElementTypes.h: * html/shadow/MediaControlElements.h: * html/shadow/SpinButtonElement.h: * html/shadow/TextControlInnerElements.h: * html/track/AudioTrackList.h: * html/track/TextTrackList.h: * html/track/TrackListBase.h: * inspector/InspectorValues.h: * loader/EmptyClients.h: * loader/ImageLoader.h: * loader/ResourceLoader.h: * loader/SubresourceLoader.h: * loader/appcache/ApplicationCacheGroup.cpp: * loader/appcache/ApplicationCacheGroup.h: * loader/appcache/DOMApplicationCache.h: * loader/archive/cf/LegacyWebArchive.h: * loader/cache/CachedCSSStyleSheet.h: * loader/cache/CachedFont.h: * loader/cache/CachedFontClient.h: * loader/cache/CachedImageClient.h: * loader/cache/CachedSVGDocumentClient.h: * loader/cache/CachedStyleSheetClient.h: * loader/cache/CachedXSLStyleSheet.h: * page/Chrome.h: * page/DOMWindow.h: * page/FrameView.h: * page/animation/ImplicitAnimation.h: * platform/PODIntervalTree.h: * platform/PODRedBlackTree.h: * platform/ScrollView.h: * platform/Scrollbar.h: * platform/Timer.h: * platform/animation/TimingFunction.h: (WebCore::LinearTimingFunction::~LinearTimingFunction): (WebCore::CubicBezierTimingFunction::~CubicBezierTimingFunction): (WebCore::StepsTimingFunction::~StepsTimingFunction): * platform/audio/AudioDSPKernelProcessor.h: * platform/audio/HRTFPanner.h: * platform/audio/mac/AudioDestinationMac.h: * platform/graphics/SimpleFontData.h: * platform/graphics/avfoundation/InbandTextTrackPrivateAVF.h: * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h: * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h: * platform/graphics/filters/FilterOperation.h: * platform/network/ResourceHandle.h: * rendering/AutoTableLayout.h: * rendering/ClipPathOperation.h: * rendering/InlineFlowBox.h: * rendering/RenderBlock.h: * rendering/RenderBox.h: * rendering/RenderBoxModelObject.h: * rendering/RenderButton.h: * rendering/RenderFieldset.h: * rendering/RenderFileUploadControl.h: * rendering/RenderFlexibleBox.h: * rendering/RenderFlowThread.h: * rendering/RenderFullScreen.h: * rendering/RenderImage.h: * rendering/RenderLayer.h: * rendering/RenderLineBreak.h: * rendering/RenderListBox.h: * rendering/RenderListItem.h: * rendering/RenderListMarker.h: * rendering/RenderMenuList.h: * rendering/RenderMeter.h: * rendering/RenderObject.h: * rendering/RenderReplaced.h: * rendering/RenderSlider.h: * rendering/RenderTable.h: * rendering/RenderTableCell.h: * rendering/RenderText.h: * rendering/RenderTextControl.h: * rendering/RenderTextControlSingleLine.h: * rendering/RenderTextFragment.h: * rendering/RenderView.h: * rendering/RootInlineBox.h: * rendering/mathml/RenderMathMLBlock.h: * rendering/mathml/RenderMathMLFraction.h: * rendering/mathml/RenderMathMLOperator.h: * rendering/style/BasicShapes.h: * rendering/svg/RenderSVGModelObject.h: * rendering/svg/RenderSVGShape.h: * svg/SVGAnimatedBoolean.h: * svg/SVGAnimatedString.h: * svg/SVGAnimatedTransformList.h: * svg/SVGDocument.h: * svg/SVGElement.h: * svg/SVGElementInstance.h: * svg/SVGFontElement.h: * svg/SVGGElement.h: * svg/SVGGraphicsElement.h: * svg/SVGTransformable.h: * svg/properties/SVGAnimatedListPropertyTearOff.h: * svg/properties/SVGAnimatedPropertyMacros.h: * svg/properties/SVGAnimatedTransformListPropertyTearOff.h: * svg/properties/SVGListPropertyTearOff.h: * svg/properties/SVGPropertyTearOff.h: * workers/WorkerGlobalScope.h: Source/WTF: * wtf/Compiler.h: * wtf/FilePrintStream.h: * wtf/StringPrintStream.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@157044 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
fpizlo@apple.com authored
Trap 5 (most likely int $3) in jsc-layout-tests.yaml/js/script-tests/integer-division-neg2tothe32-by-neg1.js.layout-dfg-eager-no-cjit https://bugs.webkit.org/show_bug.cgi?id=122420 Source/JavaScriptCore: Reviewed by Michael Saboff. For the (-2^31/-1)|0 case, we were returning the left operand (i.e. -2^31) but we were failing to account for the possibility that this operand has high-bit garbage and int32Result() requires that the high bits are zero. * dfg/DFGSpeculativeJIT.cpp: (JSC::DFG::SpeculativeJIT::compileArithDiv): LayoutTests: Reviewed by Michael Saboff. * js/script-tests/integer-division-neg2tothe32-by-neg1.js: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@157043 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
philn@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=122324 Reviewed by Martin Robinson. Update UserMediaClientGtk API after changes made in the parent class in r156473. * WebCoreSupport/UserMediaClientGtk.cpp: (WebKit::UserMediaClientGtk::requestPermission): (WebKit::UserMediaClientGtk::cancelRequest): * WebCoreSupport/UserMediaClientGtk.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@157042 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
philn@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=122444 Reviewed by Martin Robinson. * Modules/mediastream/URLMediaStream.cpp: Added missing conditional guards. * Modules/mediastream/URLMediaStream.h: Ditto. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@157041 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
philn@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=122446 Reviewed by Martin Robinson. Added skeleton functions warning of removed functionality for the <style scoped> GObject DOM binding. * bindings/gobject/WebKitDOMCustom.cpp: * bindings/gobject/WebKitDOMCustom.h: * bindings/gobject/WebKitDOMCustom.symbols: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@157040 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ossy@webkit.org authored
Changed override to OVERRIDE and final to FINAL. * page/PageSerializer.cpp: * workers/AbstractWorker.h: * workers/SharedWorker.h: * workers/Worker.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@157039 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
cfleizach@apple.com authored
AX: Facebook wrapped a file upload button in an unfocusable ARIA button, which doesn't work with AXPress. https://bugs.webkit.org/show_bug.cgi?id=122252 Reviewed by Mario Sanchez Prada. Source/WebCore: When an author uses a control-type ARIA role (like button), but then hides a native control-type inside, AXPress needs to operate on the inside node if possible. Test: accessibility/axpress-on-aria-button.html * accessibility/AccessibilityNodeObject.cpp: (WebCore::isNodeActionElement): (WebCore::nativeActionElement): (WebCore::AccessibilityNodeObject::actionElement): LayoutTests: * accessibility/axpress-on-aria-button-expected.txt: Added. * accessibility/axpress-on-aria-button.html: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@157038 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
kov@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=122132 Patch by Gustavo Noronha Silva <gustavo.noronha@collabora.com> on 2013-10-07 Reviewed by Martin Robinson. Newer glib includes new symbols that some system libraries which we depend on, such as pango, have started relying on. glib is not a dependency that should change test results, and is provided in jhbuild with the intention of supporting the other bits that do, so using a newer stable release should not be an issue. * gtk/jhbuild.modules: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@157037 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
fpizlo@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=122437 Reviewed by Antoine Quint. * Scripts/run-jsc-stress-tests: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@157036 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
fpizlo@apple.com authored
ASSERTION FAILED: bitwise_cast<WriteBarrier<Unknown>*>(callFrame) == m_registers in jsc-layout-tests.yaml/js/script-tests/dfg-inline-arguments-capture-throw-exception.js.layout-dfg-eager-no-cjit https://bugs.webkit.org/show_bug.cgi?id=122418 Reviewed by Oliver Hunt. Source/JavaScriptCore: This is pretty awesome. With stack compression, Arguments created in the DFG will point their m_registers pointers into a different slab of stack than they would have in byte code. Hence OSR exit must repoint any Arguments objects' m_registers pointers. It previously neglected to do so. This patch fixes that. Fixing this unveiled another bug: the stack reversal broke the reification of inlined phantom arguments. * dfg/DFGOSRExitCompiler32_64.cpp: (JSC::DFG::OSRExitCompiler::compileExit): * dfg/DFGOSRExitCompiler64.cpp: (JSC::DFG::OSRExitCompiler::compileExit): * dfg/DFGOSRExitCompilerCommon.cpp: (JSC::DFG::reifyInlinedCallFrames): * dfg/DFGSpeculativeJIT.cpp: (JSC::DFG::SpeculativeJIT::compileGetByValOnArguments): (JSC::DFG::SpeculativeJIT::compileGetArgumentsLength): * dfg/DFGSpeculativeJIT64.cpp: (JSC::DFG::SpeculativeJIT::compile): * runtime/Arguments.h: (JSC::Arguments::offsetOfNumArguments): (JSC::Arguments::offsetOfRegisters): (JSC::Arguments::offsetOfSlowArgumentData): (JSC::Arguments::offsetOfOverrodeLength): LayoutTests: * js/script-tests/dfg-arguments-osr-exit-multiple-blocks-before-exit.js: * js/script-tests/dfg-arguments-osr-exit-multiple-blocks.js: * js/script-tests/dfg-arguments-osr-exit.js: * js/script-tests/dfg-inline-arguments-capture-throw-exception.js: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@157035 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
g.czajkowski@samsung.com authored
context-menu-suggestions-multiword-selection.html and context-menu-suggestions-subword-selection.html are flaky after r156901. https://bugs.webkit.org/show_bug.cgi?id=122414 Unreviewed gardening. * platform/mac/TestExpectations: Similarly to r156990, mark context-menu-suggestions-subword-selection.html as flaky. Change-Id: I787b1d5a5a328f747799434fd7b984eec6947cd1 git-svn-id: http://svn.webkit.org/repository/webkit/trunk@157034 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
zandobersek@gmail.com authored
* html/HTMLTagNames.in: Generate type helpers for the <template> element as they're required by the assertions in the Element type casts for HTMLTemplateElement. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@157033 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ryuan.choi@samsung.com authored
https://bugs.webkit.org/show_bug.cgi?id=122434 Reviewed by Sam Weinig. * editing/markup.cpp: Changed override to OVERRIDE. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@157032 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
philn@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=122322 Reviewed by Darin Adler. Marked the MediaStreamTrack subclasses as final. * Modules/mediastream/AudioStreamTrack.h: * Modules/mediastream/MediaStreamTrack.h: * Modules/mediastream/VideoStreamTrack.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@157030 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
gyuyoung.kim@samsung.com authored
Generate toCSSFooValue() for CSSCursorImageValue, CSSCubicBezierTimingFunctionValue, CSSStepsTimingFunctionValue and CSSUnicodeRangeValue https://bugs.webkit.org/show_bug.cgi?id=122408 Reviewed by Andreas Kling. As a step to use toCSSFooValue, this patch generates toCSSFooValue() for CSSCursorImageValue, CSSCubicBezierTimingFunctionValue, CSSStepsTimingFunctionValue and CSSUnicodeRangeValue. This will help to detect bad type cast. No new tests, no behavior changes. * css/CSSCursorImageValue.h: * css/CSSTimingFunctionValue.h: * css/CSSToStyleMap.cpp: (WebCore::CSSToStyleMap::mapAnimationTimingFunction): * css/CSSUnicodeRangeValue.h: * css/CSSValue.cpp: (WebCore::CSSValue::destroy): * css/DeprecatedStyleBuilder.cpp: (WebCore::ApplyPropertyCursor::applyValue): * css/StyleResolver.cpp: (WebCore::StyleResolver::styleImage): (WebCore::StyleResolver::styleShader): * rendering/style/StylePendingImage.h: (WebCore::StylePendingImage::cssCursorImageValue): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@157024 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
- 06 Oct, 2013 3 commits
-
-
akling@apple.com authored
* WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@157023 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
akling@apple.com authored
* WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@157022 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
timothy_horton@apple.com authored
along with the code it tested. * platform/mac/TestExpectations: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@157021 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-