1. 18 Sep, 2009 26 commits
    • simon.fraser@apple.com's avatar
      2009-09-18 Simon Fraser <simon.fraser@apple.com> · 83c45d04
      simon.fraser@apple.com authored
              Reviewed by Dave Hyatt.
      
              Compositing layers are incorrectly positioned after scrolling with position:fixed
              https://bugs.webkit.org/show_bug.cgi?id=29262
      
              When scrolling a page with compositing layers inside a position:fixed element,
              we need to update the compositing layer positions when the scroll position changes.
      
              Test: compositing/geometry/fixed-position.html
      
              * WebCore.base.exp:
              Export FrameView::scrollPositionChanged()
      
              * page/FrameView.h:
              * page/FrameView.cpp:
              (WebCore::FrameView::scrollPositionChanged):
              New method that sends the scroll event, and updates compositing layers positions if necessary.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48526 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      83c45d04
    • barraclough@apple.com's avatar
      2009-09-18 Gabor Loki <loki@inf.u-szeged.hu> · 32aaad09
      barraclough@apple.com authored
              Reviewed by Gavin Barraclough.
      
              Defines two pseudo-platforms for ARM and Thumb-2 instruction set.
              https://bugs.webkit.org/show_bug.cgi?id=29122
      
              Introduces WTF_PLATFORM_ARM_TRADITIONAL and WTF_PLATFORM_ARM_THUMB2
              macros on ARM platforms. The PLATFORM(ARM_THUMB2) should be used
              when Thumb-2 instruction set is the required target. The
              PLATFORM(ARM_TRADITIONAL) is for generic ARM instruction set. In
              case where the code is common the PLATFORM(ARM) have to be used.
      
              * assembler/ARMAssembler.cpp:
              * assembler/ARMAssembler.h:
              * assembler/ARMv7Assembler.h:
              * assembler/MacroAssembler.h:
              * assembler/MacroAssemblerARM.cpp:
              * assembler/MacroAssemblerARM.h:
              * assembler/MacroAssemblerCodeRef.h:
              (JSC::MacroAssemblerCodePtr::MacroAssemblerCodePtr):
              * jit/ExecutableAllocator.h:
              * jit/JIT.h:
              * jit/JITInlineMethods.h:
              (JSC::JIT::beginUninterruptedSequence):
              (JSC::JIT::preserveReturnAddressAfterCall):
              (JSC::JIT::restoreReturnAddressBeforeReturn):
              (JSC::JIT::restoreArgumentReference):
              (JSC::JIT::restoreArgumentReferenceForTrampoline):
              * jit/JITOpcodes.cpp:
              * jit/JITStubs.cpp:
              (JSC::JITThunks::JITThunks):
              * jit/JITStubs.h:
              * wtf/Platform.h:
              * yarr/RegexJIT.cpp:
              (JSC::Yarr::RegexGenerator::generateEnter):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48525 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      32aaad09
    • simon.fraser@apple.com's avatar
      2009-09-18 Simon Fraser <simon.fraser@apple.com> · 3c99a321
      simon.fraser@apple.com authored
              Reviewed by Dave Hyatt.
      
              Transformed elements inside position:fixed container are clipped incorrectly
              https://bugs.webkit.org/show_bug.cgi?id=29346
      
              Fix clipping and hit testing on transformed elements inside a position:fixed element.
              Previously, the code used the overflowClipRect of the parent clip rects, but
              this is not correct for fixed postion elements. Instead, share code that is
              already present in calculateRects() to get the correct rect.
      
              Test: fast/overflow/position-fixed-transform-clipping.html
      
              * rendering/RenderLayer.h:
              * rendering/RenderLayer.cpp:
              (WebCore::RenderLayer::paintLayer):
              (WebCore::RenderLayer::hitTestLayer):
              Call the new backgroundClipRect() to get the correct clipRect.
      
              (WebCore::RenderLayer::backgroundClipRect):
              New method, factored out of calculateRects(), that computes the clip rect,
              doing the right thing for fixed position elements.
      
              (WebCore::RenderLayer::calculateRects):
              Call the new backgroundClipRect() method.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48524 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3c99a321
    • mitz@apple.com's avatar
      Updated test result for <rdar://problem/7050773> · 87a5f65c
      mitz@apple.com authored
      * platform/mac/accessibility/document-attributes-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48523 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      87a5f65c
    • eric@webkit.org's avatar
      2009-09-18 Alex Milowski <alex@milowski.com> · ede36bb4
      eric@webkit.org authored
              Reviewed by Maciej Stachowiak.
      
              Added checkWebCoreMathMLSupport and hasMathMLSupport to support
              checking for whether MathML tests should be run
      
              * Scripts/run-webkit-tests:
              * Scripts/webkitdirs.pm:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48522 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ede36bb4
    • mitz@apple.com's avatar
      WebCore: Fix <rdar://problem/7050773> REGRESSION (r40098) Crash at · ca290e54
      mitz@apple.com authored
      WebCore::RenderBlock::layoutBlock()
      https://bugs.webkit.org/show_bug.cgi?id=29498
      
      Reviewed by Darin Adler.
      
      Test: accessibility/nested-layout-crash.html
      
      * accessibility/AccessibilityRenderObject.cpp:
      (WebCore::AccessibilityRenderObject::updateBackingStore): Changed to
          call Document::updateLayoutIgnorePendingStylesheets() instead of
          calling RenderObject::layoutIfNeeded(). The latter requires that
          there be no pending style recalc, which allows methods that call
          Document::updateLayout() to be called during layout without risking
          re-entry into layout.
      * accessibility/mac/AccessibilityObjectWrapper.mm:
      (-[AccessibilityObjectWrapper accessibilityActionNames]): Null-check
          m_object after calling updateBackingStore(), since style recalc may
          destroy the renderer, which destroys the accessibility object and
          detaches it from the wrapper.
      (-[AccessibilityObjectWrapper accessibilityAttributeNames]): Ditto.
      (-[AccessibilityObjectWrapper accessibilityAttributeValue:]): Ditto.
      (-[AccessibilityObjectWrapper accessibilityFocusedUIElement]): Ditto.
      (-[AccessibilityObjectWrapper accessibilityHitTest:]): Ditto.
      (-[AccessibilityObjectWrapper accessibilityIsAttributeSettable:]):
          Ditto.
      (-[AccessibilityObjectWrapper accessibilityIsIgnored]): Ditto.
      (-[AccessibilityObjectWrapper accessibilityParameterizedAttributeNames]):
           Ditto.
      (-[AccessibilityObjectWrapper accessibilityPerformPressAction]): Ditto.
      (-[AccessibilityObjectWrapper accessibilityPerformIncrementAction]):
          Ditto.
      (-[AccessibilityObjectWrapper accessibilityPerformDecrementAction]):
          Ditto.
      (-[AccessibilityObjectWrapper accessibilityPerformAction:]): Ditto.
      (-[AccessibilityObjectWrapper accessibilitySetValue:forAttribute:]):
          Ditto.
      (-[AccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]):
          Ditto.
      (-[AccessibilityObjectWrapper accessibilityIndexOfChild:]): Ditto.
      (-[AccessibilityObjectWrapper accessibilityArrayAttributeCount:]):
          Ditto.
      (-[AccessibilityObjectWrapper accessibilityArrayAttributeValues:index:maxCount:]):
          Ditto.
      
      LayoutTests: Test for <rdar://problem/7050773> REGRESSION (r40098) Crash at
      WebCore::RenderBlock::layoutBlock()
      https://bugs.webkit.org/show_bug.cgi?id=29498
      
      Reviewed by Darin Adler.
      
      * accessibility/nested-layout-crash-expected.txt: Added.
      * accessibility/nested-layout-crash.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48521 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ca290e54
    • eric@webkit.org's avatar
      2009-09-18 Fumitoshi Ukai <ukai@chromium.org> · 35738bfb
      eric@webkit.org authored
              Reviewed by Simon Hausmann.
      
              Update Qt build system for Web Socket.
              https://bugs.webkit.org/show_bug.cgi?id=29270
      
              * WebCore.pro:
              * platform/network/qt/SocketStreamError.h: Added.
              * platform/network/qt/SocketStreamHandle.h: Added.
              * platform/network/qt/SocketStreamHandleSoup.cpp: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48520 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      35738bfb
    • eric.carlson@apple.com's avatar
      2009-09-18 Eric Carlson <eric.carlson@apple.com> · b2498fa7
      eric.carlson@apple.com authored
              Reviewed by Darin Adler.
      
              NULL check HTMLMediaElement::m_playedTimeRanges.
              Fix for https://bugs.webkit.org/show_bug.cgi?id=29494
      
              * html/HTMLMediaElement.cpp:
              (WebCore::HTMLMediaElement::addPlayedRange): New. Create m_playedTimeRanges if
              necessary, add range specified.
              (WebCore::HTMLMediaElement::seek): Use addPlayedRange. 
              (WebCore::HTMLMediaElement::played): Use addPlayedRange. Change time comparison 
              to be more readable.
              (WebCore::HTMLMediaElement::updatePlayState): Ditto.
              * html/HTMLMediaElement.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48519 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b2498fa7
    • xan@webkit.org's avatar
      2009-09-18 Xan Lopez <xlopez@igalia.com> · 22471b2e
      xan@webkit.org authored
              Build fix.
      
              Add missing file to the repository.
      
              * tests/testhittestresult.c: Added.
              (test_info_new):
              (test_info_destroy):
              (hit_test_result_fixture_setup):
              (hit_test_result_fixture_teardown):
              (load_status_cb):
              (test_webkit_hit_test_result):
              (main):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48518 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      22471b2e
    • darin@apple.com's avatar
      Added bug number. · 6068b164
      darin@apple.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48517 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6068b164
    • darin@apple.com's avatar
      Some small steps toward improving run-webkit-tests. My goal is to · 9daeeca7
      darin@apple.com authored
      refactor much more of the script into functions. Later we can add
      parallel test running to the tool. But better structure may help
      even if someone decides to translate this into another scripting
      language instead.
      
      Patch by Darin Adler <darin@apple.com> on 2009-08-28
      Reviewed by Mark Rowe.
      
      * Scripts/run-webkit-tests: Break more pieces of the script into
      seprate functions. Added readSkippedFiles, findTestsToRun, and
      printResults functions. Removed custom code to skip results.html
      and instead just put it into the ignoredFiles hash. Fixed some
      indentation. Sorted function declarations, global variables,
      and options at the top of the file alphabetically so they're not
      in a semi-random order.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48516 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9daeeca7
    • weinig@apple.com's avatar
      WebCore: Follow up fix for https://bugs.webkit.org/show_bug.cgi?id=29276 · 8d13417e
      weinig@apple.com authored
      REGRESSION(r48334): WebKit crashes on file select by drag
      
      Reviewed by Adele Peterson.
      
      Don't use Document.elementFromPoint since it returns null if the point
      is outside the viewport.  Instead, just hit test ourselves.
      
      Test: fast/events/drag-file-crash.html
      
      * page/DragController.cpp:
      (WebCore::elementUnderMouse):
      (WebCore::DragController::tryDocumentDrag):
      (WebCore::DragController::concludeEditDrag):
      
      LayoutTests: Test for https://bugs.webkit.org/show_bug.cgi?id=29276
      REGRESSION(r48334): WebKit crashes on file select by drag
      
      Reviewed by Adele Peterson.
      
      * fast/events/drag-file-crash-expected.txt: Added.
      * fast/events/drag-file-crash.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48515 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8d13417e
    • darin@apple.com's avatar
      Fix date on a change log entry. · f93e081e
      darin@apple.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48514 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f93e081e
    • darin@apple.com's avatar
      Each wrapped Objective-C object should use a single RuntimeObjectImp · f55539ca
      darin@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=29351
      rdar://problem/7142294
      
      Patch by Darin Adler <darin@apple.com> on 2009-09-18
      Reviewed by Sam Weinig.
      
      * WebCore.base.exp: Added a newly-needed exported symbol.
      
      * bindings/objc/DOMInternal.h: Eliminated unused
      createWrapperCacheWithIntegerKeys; it has not been needed since the
      RGBColor wrappers were reworked.
      * bindings/objc/DOMInternal.mm: Ditto.
      
      * bridge/objc/objc_instance.h: Made the create function non-inline.
      * bridge/objc/objc_instance.mm:
      (createInstanceWrapperCache): Added. Creates an appropriate map table.
      (ObjcInstance::create): Moved here from header. Uses NSMapGet and
      NSMapInsert to cache the instance in a map table.
      (ObjcInstance::~ObjcInstance): Added a call to NSMapRemove to remove
      the instance from the map table.
      
      * bridge/qt/qt_instance.cpp:
      (JSC::Bindings::QtInstance::~QtInstance): Remove unneeded code to remove
      the instance from cachedObjects, which no longer exists.
      (JSC::Bindings::QtInstance::newRuntimeObject): Renamed to overload new
      bottleneck. Caching is now handled by the base class.
      
      * bridge/runtime.cpp:
      (JSC::Bindings::Instance::Instance): Initialize m_runtimeObject to 0.
      (JSC::Bindings::Instance::~Instance): Assert m_runtimeObject is 0.
      (JSC::Bindings::Instance::createRuntimeObject): Use m_runtimeObject
      if it's already set. Set m_runtimeObject and call addRuntimeObject
      if it's not.
      (JSC::Bindings::Instance::newRuntimeObject): Added. Virtual function,
      used only by createRuntimeObject.
      (JSC::Bindings::Instance::willDestroyRuntimeObject): Added.
      Calls removeRuntimeObject and then clears m_runtimeObject.
      (JSC::Bindings::Instance::willInvalidateRuntimeObject): Added.
      Clears m_runtimeObject.
      
      * bridge/runtime.h: Made createRuntimeObject non-virtual. Added
      willDestroyRuntimeObject, willInvalidateRuntimeObject,
      newRuntimeObject, and m_runtimeObject.
      
      * bridge/runtime_object.cpp:
      (JSC::RuntimeObjectImp::RuntimeObjectImp): Removed addRuntimeObject
      call, now handled by caller.
      (JSC::RuntimeObjectImp::~RuntimeObjectImp): Replaced removeRuntimeObject
      call with willDestroyRuntimeObject call; the latter nows calls
      removeRuntimeObject.
      (JSC::RuntimeObjectImp::invalidate): Added willInvalidateRuntimeObject
      call.
      
      * bridge/runtime_object.h: Made invalidate non-virtual.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48513 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f55539ca
    • kenneth@webkit.org's avatar
      [Gtk] Unreviewed build fix. · 44dbecd6
      kenneth@webkit.org authored
      Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-09-18
      * WebCoreSupport/ChromeClientGtk.cpp:
      (WebKit::ChromeClient::platformPageClient):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48512 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      44dbecd6
    • kenneth@webkit.org's avatar
      Make PlatformWindow return something else than PlatformWidget · e8249bf2
      kenneth@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=29085
      
      Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-09-17
      Reviewed by Simon Hausmann.
      
      WebCore:
      
      Make platformWindow return a PlatformPageClient
      (for now typedef'ed to PlatformWidget)
      
      Also, change the name of platformWindow to platformPageClient()
      
      * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
      (getPangoLayoutForAtk):
      * accessibility/win/AXObjectCacheWin.cpp:
      (WebCore::AXObjectCache::postPlatformNotification):
      (WebCore::AXObjectCache::handleFocusedUIElementChanged):
      * loader/EmptyClients.h:
      (WebCore::EmptyChromeClient::platformPageClient):
      * page/Chrome.cpp:
      (WebCore::Chrome::platformPageClient):
      * page/Chrome.h:
      * page/ChromeClient.h:
      * page/mac/EventHandlerMac.mm:
      (WebCore::EventHandler::wheelEvent):
      (WebCore::EventHandler::currentPlatformMouseEvent):
      (WebCore::EventHandler::sendContextMenuEvent):
      (WebCore::EventHandler::eventMayStartDrag):
      * platform/HostWindow.h:
      * platform/Widget.h:
      * platform/gtk/PlatformScreenGtk.cpp:
      (WebCore::getVisual):
      (WebCore::screenRect):
      (WebCore::screenAvailableRect):
      * platform/gtk/PopupMenuGtk.cpp:
      (WebCore::PopupMenu::show):
      * platform/gtk/ScrollViewGtk.cpp:
      (WebCore::ScrollView::platformAddChild):
      (WebCore::ScrollView::platformRemoveChild):
      (WebCore::ScrollView::visibleContentRect):
      * platform/gtk/WidgetGtk.cpp:
      (WebCore::Widget::setFocus):
      (WebCore::Widget::setCursor):
      * platform/qt/PlatformScreenQt.cpp:
      (WebCore::screenDepth):
      (WebCore::screenDepthPerComponent):
      (WebCore::screenIsMonochrome):
      (WebCore::screenRect):
      (WebCore::screenAvailableRect):
      * platform/qt/PopupMenuQt.cpp:
      (WebCore::PopupMenu::show):
      * platform/qt/WidgetQt.cpp:
      (WebCore::Widget::setCursor):
      * platform/win/PlatformScreenWin.cpp:
      (WebCore::monitorInfoForWidget):
      * platform/win/PopupMenuWin.cpp:
      (WebCore::PopupMenu::show):
      (WebCore::PopupMenu::calculatePositionAndSize):
      (WebCore::PopupMenu::wndProc):
      * platform/wx/RenderThemeWx.cpp:
      (WebCore::nativeWindowForRenderObject):
      * platform/wx/ScrollbarThemeWx.cpp:
      (WebCore::ScrollbarThemeWx::paint):
      * plugins/gtk/PluginViewGtk.cpp:
      (WebCore::PluginView::getValue):
      (WebCore::PluginView::forceRedraw):
      (WebCore::PluginView::platformStart):
      * plugins/mac/PluginViewMac.cpp:
      (WebCore::PluginView::platformStart):
      * plugins/qt/PluginViewQt.cpp:
      (WebCore::PluginView::handleKeyboardEvent):
      (WebCore::PluginView::getValue):
      (WebCore::PluginView::platformStart):
      * plugins/win/PluginViewWin.cpp:
      (WebCore::PluginView::getValue):
      (WebCore::PluginView::forceRedraw):
      (WebCore::PluginView::platformStart):
      
      WebKit/gtk:
      
      Reflect the rename of platformWindow and it's return type.
      
      * WebCoreSupport/ChromeClientGtk.cpp:
      (WebKit::ChromeClient::platformPageClient):
      (WebKit::ChromeClient::runOpenPanel):
      * WebCoreSupport/ChromeClientGtk.h:
      * webkit/webkitprivate.cpp:
      (currentToplevelCallback):
      * webkit/webkitwebview.cpp:
      (webkit_web_view_popup_menu_handler):
      
      WebKit/haiku:
      
      Reflect the rename of platformWindow and it's return type.
      
      * WebCoreSupport/ChromeClientHaiku.cpp:
      (WebCore::ChromeClientHaiku::platformPageClient):
      * WebCoreSupport/ChromeClientHaiku.h:
      
      WebKit/mac:
      
      Reflect the rename of platformWindow and it's return type.
      
      * WebCoreSupport/WebChromeClient.h:
      * WebCoreSupport/WebChromeClient.mm:
      (WebChromeClient::platformPageClient):
      
      WebKit/qt:
      
      Reflect the rename of platformWindow and it's return type.
      
      * WebCoreSupport/ChromeClientQt.cpp:
      (WebCore::ChromeClientQt::platformPageClient):
      * WebCoreSupport/ChromeClientQt.h:
      
      WebKit/win:
      
      Reflect the rename of platformWindow and it's return type.
      
      * AccessibleBase.cpp:
      (AccessibleBase::get_accParent):
      * WebCoreSupport/WebChromeClient.cpp:
      (WebChromeClient::platformPageClient):
      * WebCoreSupport/WebChromeClient.h:
      
      WebKit/wx:
      
      Reflect the rename of platformWindow and it's return type.
      
      * WebKitSupport/ChromeClientWx.cpp:
      (WebCore::ChromeClientWx::platformPageClient):
      * WebKitSupport/ChromeClientWx.h:
      * WebKitSupport/EditorClientWx.cpp:
      (WebCore::EditorClientWx::isEditable):
      (WebCore::EditorClientWx::registerCommandForUndo):
      (WebCore::EditorClientWx::registerCommandForRedo):
      (WebCore::EditorClientWx::clearUndoRedoOperations):
      (WebCore::EditorClientWx::canUndo):
      (WebCore::EditorClientWx::canRedo):
      (WebCore::EditorClientWx::undo):
      (WebCore::EditorClientWx::redo):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48511 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e8249bf2
    • hausmann@webkit.org's avatar
      [Qt] Web inspector UI adjustments specific to the Qt platform: · daa9f964
      hausmann@webkit.org authored
      - Hide the close button
      - Hide the dock button
      - Disable the draggable toolbar
      
      Patch by Jocelyn Turcotte <jocelyn.turcotte@nokia.com> on 2009-09-18
      Reviewed by Simon Hausmann.
      
      https://bugs.webkit.org/show_bug.cgi?id=29384
      
      * inspector/front-end/inspector.css:
      * inspector/front-end/inspector.js:
      (WebInspector.toolbarDragStart):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48510 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      daa9f964
    • hausmann@webkit.org's avatar
      Fix the Qt/Windows CE build. · fe9f3fda
      hausmann@webkit.org authored
      Patch by Joerg Bornemann <joerg.bornemann@nokia.com> on 2009-09-18
      Reviewed by Simon Hausmann.
      
      * JavaScriptCore.pri: Build the ce_time.cpp functions from
      within Qt externally.
      * wtf/DateMath.cpp: Removed unnecessary Qt #ifdef, for the
      Qt build these functions are no external, too.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48509 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fe9f3fda
    • hausmann@webkit.org's avatar
      QtWebKit Windows CE compile fixes · 7f26dc14
      hausmann@webkit.org authored
      Patch by Joerg Bornemann <joerg.bornemann@nokia.com> on 2009-09-18
      Reviewed by Simon Hausmann.
      
      Exclude certain pure-WINCE specific code paths from the Qt build.
      
      * platform/graphics/BitmapImage.h:
      * platform/graphics/FontCache.h:
      * platform/graphics/MediaPlayer.cpp:
      * platform/text/TextEncodingRegistry.cpp:
      (WebCore::buildBaseTextCodecMaps):
      (WebCore::extendTextCodecMaps):
      * plugins/PluginView.cpp:
      (WebCore::PluginView::stop): Guard this code block with NETSCAPE_PLUGIN_API as
      the corresponding PluginViewWndProc has the same guard in the header file.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48508 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7f26dc14
    • xan@webkit.org's avatar
      2009-09-18 Xan Lopez <xlopez@igalia.com> · 59eabdbb
      xan@webkit.org authored
              Reviewed by Jan Alonzo.
      
              Document webkit_web_view_stop_loading.
      
              * webkit/webkitwebview.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48507 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      59eabdbb
    • xan@webkit.org's avatar
      2009-09-18 Xan Lopez <xlopez@igalia.com> · fd4dd8e1
      xan@webkit.org authored
              Reviewed by Gustavo Noronha and Jan Alonzo.
      
              [GTK] context menu overriding API is very limited
              https://bugs.webkit.org/show_bug.cgi?id=27546
      
              Add new tests to the build.
      
              * GNUmakefile.am:
      
      WebKit/gtk:
      
      2009-09-18  Xan Lopez  <xlopez@igalia.com>
      
              Reviewed by Gustavo Noronha and Jan Alonzo.
      
              [GTK] context menu overriding API is very limited
              https://bugs.webkit.org/show_bug.cgi?id=27546
      
              Add webkit_web_view_get_hit_test_result, a function to get a hit
              test result from a GdkEventButton. Useful to let applications
              decide between several actions on button press depending on what
              is being pressed.
      
              * webkit/webkitwebview.cpp:
              (webkit_web_view_stop_loading):
              (documentPointForWindowPoint):
              (webkit_web_view_get_hit_test_result):
              * webkit/webkitwebview.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48506 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fd4dd8e1
    • xan@webkit.org's avatar
      2009-09-14 Xan Lopez <xlopez@igalia.com> · 2266a5b0
      xan@webkit.org authored
              Reviewed by Gustavo Noronha and Jan Alonzo.
      
              [GTK] context menu overriding API is very limited
              https://bugs.webkit.org/show_bug.cgi?id=27546
      
              Add WebKitHitTestResult to the build.
      
              * GNUmakefile.am:
      
      WebKit/gtk:
      
      2009-09-18  Xan Lopez  <xlopez@igalia.com>
      
              Reviewed by Gustavo Noronha and Jan Alonzo.
      
              [GTK] context menu overriding API is very limited
              https://bugs.webkit.org/show_bug.cgi?id=27546
      
              Add WebKitHitTestResult, a wrapper over HitTestResult. It contains
              context information about a point in the web page.
      
              * webkit/webkit.h:
              * webkit/webkitdefines.h:
              * webkit/webkithittestresult.cpp: Added.
              (webkit_hit_test_result_finalize):
              (webkit_hit_test_result_get_property):
              (webkit_hit_test_result_set_property):
              (webkit_hit_test_result_class_init):
              (webkit_hit_test_result_init):
              * webkit/webkithittestresult.h: Added.
              * webkit/webkitprivate.cpp:
              (WebKit::kit):
              * webkit/webkitprivate.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48505 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2266a5b0
    • hausmann@webkit.org's avatar
      [Qt] Add persistence support for configuration options in the · 9a2d46fb
      hausmann@webkit.org authored
      inspector.
      
      Patch by Jocelyn Turcotte <jocelyn.turcotte@nokia.com> on 2009-09-18
      Reviewed by Simon Hausmann.
      
      * Api/qwebinspector.cpp:
      * QtLauncher/main.cpp:
      (main):
      * WebCoreSupport/InspectorClientQt.cpp:
      (WebCore::InspectorClientQt::populateSetting):
      (WebCore::InspectorClientQt::storeSetting):
      (WebCore::variantToSetting):
      (WebCore::settingToVariant):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48504 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9a2d46fb
    • eric@webkit.org's avatar
      2009-09-18 Steve Block <steveblock@google.com> · a05aaad4
      eric@webkit.org authored
              Reviewed by Dimitri Glazkov.
      
              Geolocation does not correctly handle Infinity for PositionOptions properties.
              https://bugs.webkit.org/show_bug.cgi?id=29099
      
              * fast/dom/Geolocation/resources/argument-types.js: Modified. Test passing positive and negative Infinity to Geolocation methods.
              * fast/dom/Geolocation/argument-types-expected.txt: Modified. Expected result for above test.
      2009-09-18  Steve Block  <steveblock@google.com>
      
              Reviewed by Dimitri Glazkov.
      
              Geolocation does not correctly handle Infinity for PositionOptions properties.
              https://bugs.webkit.org/show_bug.cgi?id=29099
      
              * bindings/js/JSGeolocationCustom.cpp: Modified.
              (WebCore::createPositionOptions): Modified. If timeout or maximumAge is positive infinity, applies these values as a special case.
              * page/PositionOptions.h: Modified.
              (WebCore::PositionOptions::hasMaximumAge): Added. Determines whether the object has a maximum age.
              (WebCore::PositionOptions::maximumAge): Modified. Asserts that the object has a maximum age.
              (WebCore::PositionOptions::clearMaximumAge): Added. Clears the maximum age.
              (WebCore::PositionOptions::setMaximumAge): Modified. Registers that the maximum age has been set.
              (WebCore::PositionOptions::PositionOptions): Modified. Registers that the maximum age has been set.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48503 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a05aaad4
    • hausmann@webkit.org's avatar
      Fixed a bunch of documentation warnings. · ee26bcb7
      hausmann@webkit.org authored
      Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2009-09-18
      Reviewed by Ariya Hidayat.
      
      * Api/qwebgraphicsitem.cpp:
      * Api/qwebplugindatabase.cpp:
      * Api/qwebpluginfactory.cpp:
      * Api/qwebsecurityorigin.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48502 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ee26bcb7
    • hausmann@webkit.org's avatar
      Added a test that console output works. · ba1be41c
      hausmann@webkit.org authored
      Patch by Warwick Allison <warwick.allison@nokia.com> on 2009-09-18
      Reviewed by Simon Hausmann.
      
      * tests/qwebpage/tst_qwebpage.cpp:
      (ConsolePage::ConsolePage):
      (ConsolePage::javaScriptConsoleMessage):
      (tst_QWebPage::consoleOutput):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48501 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ba1be41c
  2. 17 Sep, 2009 14 commits
    • weinig@apple.com's avatar
      Fix for https://bugs.webkit.org/show_bug.cgi?id=29276 · 7c2f4a32
      weinig@apple.com authored
      REGRESSION(r48334): WebKit crashes on file select by drag
      
      Reviewed by Adele Peterson.
      
      Document.elementFromPoint now takes point in client space, not page space.
      
      * page/DragController.cpp:
      (WebCore::DragController::tryDocumentDrag):
      (WebCore::DragController::concludeEditDrag):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48500 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7c2f4a32
    • ajwong@chromium.org's avatar
      2009-09-17 Albert J. Wong <ajwong@chromium.org> · 85a391e1
      ajwong@chromium.org authored
              Reviewed by David Levin.
      
              Reimplement default media UI for Mac Chromium to match the style
              of the Windows and Linux versions.  Also breaks the dependency
              on the internal wk* functions that were previously used to
              render the media controller widgets.
              https://bugs.webkit.org/show_bug.cgi?id=29161
      
              No media layout tests are currently enabled in Mac Chromium, so
              nothing needs rebaselineing, etc.
      
              This is a recommit of r48438 with a compile fix and merges of
              recent changes to the file.
      
              * css/mediaControlsChromium.css:
              * rendering/RenderThemeChromiumMac.h:
              * rendering/RenderThemeChromiumMac.mm:
              (WebCore::mediaElementParent):
              (WebCore::RenderThemeChromiumMac::extraMediaControlsStyleSheet):
              (WebCore::mediaSliderThumbImage):
              (WebCore::mediaVolumeSliderThumbImage):
              (WebCore::RenderThemeChromiumMac::paintSliderTrack):
              (WebCore::RenderThemeChromiumMac::adjustSliderThumbSize):
              (WebCore::RenderThemeChromiumMac::paintMediaButtonInternal):
              (WebCore::RenderThemeChromiumMac::paintMediaPlayButton):
              (WebCore::RenderThemeChromiumMac::paintMediaMuteButton):
              (WebCore::RenderThemeChromiumMac::paintMediaSliderTrack):
              (WebCore::RenderThemeChromiumMac::paintMediaVolumeSliderTrack):
              (WebCore::RenderThemeChromiumMac::paintMediaSliderThumb):
              (WebCore::RenderThemeChromiumMac::paintMediaVolumeSliderThumb):
              (WebCore::RenderThemeChromiumMac::paintMediaControlsBackground):
              * rendering/RenderThemeChromiumSkia.cpp:
              (WebCore::RenderThemeChromiumSkia::adjustSliderThumbSize):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48499 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      85a391e1
    • bweinstein@apple.com's avatar
      2009-09-17 Brian Weinstein <bweinstein@apple.com> · 3508659c
      bweinstein@apple.com authored
              Rubber-stamped by Steve Falkenburg.
      
              Add failing test on both Windows Debug and Release to the
              Windows Skipped List.
              
              http/tests/xmlhttprequest/xmlhttprequest-missing-file-exception.html is
              being tracked by <https://bugs.webkit.org/show_bug.cgi?id=29353>.
      
              * platform/win/Skipped:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48498 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3508659c
    • bweinstein@apple.com's avatar
      2009-09-17 Brian Weinstein <bweinstein@apple.com> · e72263c6
      bweinstein@apple.com authored
              Reviewed by Timothy Hatcher.
      
              The Console scope bar should have a divider between All and the other possible
              values (Errors, Warnings, Logs). It will look something like:
              
              All | Errors Warnings Logs.
      
              * inspector/front-end/ConsoleView.js:
              (WebInspector.ConsoleView.createDividerElement):
              (WebInspector.ConsoleView):
              * inspector/front-end/inspector.css:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48497 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e72263c6
    • bweinstein@apple.com's avatar
      2009-09-17 Brian Weinstein <bweinstein@apple.com> · a7e66e1d
      bweinstein@apple.com authored
              Reviewed by Adam Roben.
      
              Remove assertions that were being hit by calls to
              m_verticalScrollbar->invalidate(). These assertions were valid,
              but they were causing tests to fail, so replacing with a FIXME 
              until we can find out the real cause/solution that is being tracked 
              by http://webkit.org/b/29350.
      
              * WebView.cpp:
              (WebView::addToDirtyRegion):
              (WebView::paintIntoBackingStore):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48496 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a7e66e1d
    • weinig@apple.com's avatar
      Remove additional references to JSVoidCallback which no longer exists. · 8911af2f
      weinig@apple.com authored
      Reviewed by Mark Rowe.
      
      * DerivedSources.cpp:
      * WebCore.vcproj/WebCore.vcproj:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48495 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8911af2f
    • eric@webkit.org's avatar
      2009-09-17 Alpha Lam <hclam@chromium.org> · 5e00a66b
      eric@webkit.org authored
              Reviewed by Eric Carlson.
      
              Media layout tests should have a way to provide test files in different formats
              https://bugs.webkit.org/show_bug.cgi?id=28327
      
              Updating 19 media layout tests to use media files based on supported codecs.
      
              * media/media-file.js: Prefer .wav over other formats as this is used the most in tests for mac port.
              Most of audio tests use media/content/test.wav as test file for mac, so this change would make sure
              findMediaFile() will return test.wav but not test.mp3 or other formats.
              (setSrcById): Fixing bug in code.
              * media/video-canvas-source.html: Use findMediaFile() to locate a media file based on supported types.
              * media/video-click-dblckick-standalone.html: ditto.
              * media/video-controls-transformed.html: ditto.
              * media/video-controls-visible-audio-only.html: ditto.
              * media/video-controls-zoomed.html: ditto.
              * media/video-controls.html: ditto.
              * media/video-currentTime-set.html: ditto.
              * media/video-currentTime-set2.html: ditto.
              * media/video-currentTime.html: ditto.
              * media/video-display-none-crash.html: ditto.
              * media/video-display-toggle.html: ditto.
              * media/video-dom-autoplay.html: ditto.
              * media/video-dom-src.html: ditto.
              * media/video-error-abort.html: ditto.
              * media/video-load-networkState.html: ditto.
              * media/video-load-readyState.html: ditto.
              * media/video-loop.html: ditto.
              * media/video-muted.html: ditto.
              * media/video-no-autoplay.html: ditto.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48494 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5e00a66b
    • weinig@apple.com's avatar
      Remove commented out onhashchange attribute now that it is implemented. · 9363f63c
      weinig@apple.com authored
      Reviewed by Brady Eidson.
      
      * page/DOMWindow.idl:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48493 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9363f63c
    • andersca@apple.com's avatar
      WebCore: <rdar://problem/7007541> · 5efc6b59
      andersca@apple.com authored
      CrashTracer: 4800+ crashes in Safari at com.apple.WebKit • WTF::HashTableIterator...
              
      Reviewed by Oliver Hunt.
      
      Make RuntimeObjectImp more robust against m_instance being a null (which can happen if an OOP plug-in
      crashes while we're calling into it).
              
      * bridge/runtime_object.cpp:
      (JSC::RuntimeObjectImp::RuntimeObjectImp):
      (JSC::RuntimeObjectImp::~RuntimeObjectImp):
      (JSC::RuntimeObjectImp::invalidate):
      (JSC::RuntimeObjectImp::fallbackObjectGetter):
      (JSC::RuntimeObjectImp::fieldGetter):
      (JSC::RuntimeObjectImp::methodGetter):
      (JSC::RuntimeObjectImp::getOwnPropertySlot):
      (JSC::RuntimeObjectImp::getOwnPropertyDescriptor):
      (JSC::RuntimeObjectImp::put):
      (JSC::RuntimeObjectImp::defaultValue):
      (JSC::RuntimeObjectImp::getCallData):
      (JSC::RuntimeObjectImp::getConstructData):
      (JSC::RuntimeObjectImp::getPropertyNames):
      * bridge/runtime_object.h:
      (JSC::RuntimeObjectImp::getInternalInstance):
      
      WebKit/mac: <rdar://problem/7007541> 
      CrashTracer: 4800+ crashes in Safari at com.apple.WebKit • WTF::HashTableIterator...
      
      Reviewed by Oliver Hunt.
      
      Add null checks for m_instanceProxy (It will be null when a plug-in has crashed).
              
      * Plugins/Hosted/ProxyInstance.mm:
      (WebKit::ProxyInstance::invoke):
      (WebKit::ProxyInstance::supportsInvokeDefaultMethod):
      (WebKit::ProxyInstance::supportsConstruct):
      (WebKit::ProxyInstance::getPropertyNames):
      (WebKit::ProxyInstance::methodsNamed):
      (WebKit::ProxyInstance::fieldNamed):
      (WebKit::ProxyInstance::fieldValue):
      (WebKit::ProxyInstance::setFieldValue):
      (WebKit::ProxyInstance::invalidate):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48492 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5efc6b59
    • eric@webkit.org's avatar
      2009-09-17 Yury Semikhatsky <yurys@chromium.org> · 703a517d
      eric@webkit.org authored
              Reviewed by Timothy Hatcher.
      
              Wrap primitive values (as objects) in InspectorController::wrap.
      
              https://bugs.webkit.org/show_bug.cgi?id=28983
      
              * inspector/InspectorController.cpp:
              (WebCore::InspectorController::wrapObject): objects of any type will be wrapped into proxies,
               only object proxies will have objectId.
              * inspector/front-end/ConsoleView.js:
              (WebInspector.ConsoleView.prototype.completions): there is InjectedScript.getCompletionsi
               that accepts an expression and returns possible completions. This way we don't need to wrap
               and unwrap the completions result into a proxy object.
              * inspector/front-end/InjectedScript.js:
              (InjectedScript.getCompletions):
              (InjectedScript.evaluate):
              (InjectedScript._evaluateOn):
              (InjectedScript.createProxyObject):
              * inspector/front-end/InjectedScriptAccess.js:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48491 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      703a517d
    • japhet@chromium.org's avatar
      2009-09-17 Nate Chapin <japhet@chromium.org> · 4404a525
      japhet@chromium.org authored
              Reviewed by Dimitri Glazkov.
      
              Wrap PageTransitionEvents properly for V8's use.
      
              https://bugs.webkit.org/show_bug.cgi?id=29340
      
              Fixes Chromium's failures for LayoutTests/fast/events/pageshow-pagehide.html.
      
              * bindings/v8/V8DOMWrapper.cpp:
              (WebCore::V8DOMWrapper::convertEventToV8Object): Wrap PageTransitionEvents properly.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48490 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4404a525
    • simon.fraser@apple.com's avatar
      2009-09-17 Simon Fraser <simon.fraser@apple.com> · f159ab01
      simon.fraser@apple.com authored
              Reviewed by Dave Hyatt.
      
              Hardware-accelerated opacity transition on inline asserts
              https://bugs.webkit.org/show_bug.cgi?id=29342
      
              Remove an erroneous toRenderBox() that could be called on a RenderInline; we can just
              pass an empty size, because the box size is only required for transform animations.
      
              Test: compositing/transitions/opacity-on-inline.html
      
              * rendering/RenderLayerBacking.cpp:
              (WebCore::RenderLayerBacking::startTransition):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48489 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f159ab01
    • eric@webkit.org's avatar
      2009-09-17 Eric Seidel <eric@webkit.org> · 97b5bb0d
      eric@webkit.org authored
              Reviewed by Darin Adler.
      
              Update contributing.html to mention recently added tools.
              https://bugs.webkit.org/show_bug.cgi?id=29318
      
              Update our contributing instructions to mention
              the new tools (check-webkit-style and commit-queue)
              recently added to make contributions easier.
      
              * coding/contributing.html:
               - Mention check-webkit-style as an optional helper tool.
               - Mention checking the 'patch' checkbox.
               - Mention the commit-queue as an optional helper tool.
               - Remove "or in email" since patch reviews are all done via bugzilla.
               - Encourage contributers to be responsible for getting their patch landed.  Provide a list of committers.
               - Mention commit-queue as an optional help in getting your patch landed.
               - Give an overview of the commit-queue process and link to the Commit Queue docs.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48488 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      97b5bb0d
    • kov@webkit.org's avatar
      2009-09-17 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> · 473997ad
      kov@webkit.org authored
              Rubber-stamped by Brady Eidson.
      
              Tiger fails test http/tests/loading/redirect-with-no-location-crash.html added in r48413
              https://bugs.webkit.org/show_bug.cgi?id=29329
      
              Skip test that fails on Tiger because of a bug in its version of
              CFNetwork.
      
              * platform/mac-tiger/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48487 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      473997ad