1. 28 Sep, 2006 9 commits
    • aliceli1's avatar
      Build fix by adding missing files for CommandByName · 82b0749c
      aliceli1 authored
              * WebCore.xcodeproj/project.pbxproj:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16629 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      82b0749c
    • aliceli1's avatar
      Adding CommandByName files to the vcproj · 42f98123
      aliceli1 authored
              * WebCore.vcproj/WebCore/WebCore.vcproj:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16628 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      42f98123
    • aliceli1's avatar
      · 0da5e09a
      aliceli1 authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16626 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0da5e09a
    • aroben's avatar
      Reviewed by Adele. · 5b965904
      aroben authored
              Remove no-longer-used PopUpButton.
      
              * WebCore.vcproj/WebCore/WebCore.vcproj: Remove PopUpButton.h
              * WebCore.xcodeproj/project.pbxproj: Remove PopUpButton.h,
      	PopUpButtonMac.mm
              * platform/PopUpButton.h: Removed.
              * platform/mac/PopUpButtonMac.mm: Removed.
              * platform/win/TemporaryLinkStubs.cpp: Remove PopUpButton:: methods
              * rendering/DeprecatedRenderSelect.cpp: Change #include of
      	PopUpButton.h to ListBox.h
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16624 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5b965904
    • darin's avatar
      JavaScriptCore: · 6138a1eb
      darin authored
              Reviewed by Alice.
      
              - support for change that should fix <rdar://problem/4733044>
                REGRESSION: XML iBench shows 10% perf. regression (copying
                strings while decoding)
      
              * wtf/Vector.h: Changed VectorBuffer so that the general case
              contains an instance of the 0 case, since deriving from it
              was violating the Liskov Substitution Principle.
              (WTF::VectorBuffer::releaseBuffer): Added. Releases the buffer so it can
              be adopted by another data structure that uses the FastMalloc.h allocator.
              Returns 0 if the internal buffer was being used.
              (WTF::Vector::releaseBuffer): Added. Releases the buffer as above or creates
              a new one in the case where the internal buffer was being used.
      
      WebCore:
      
              Reviewed by Alice.
      
              - change that should fix <rdar://problem/4733044> REGRESSION: XML iBench shows
                10% perf. regression (copying strings while decoding)
      
              Use Vector<UChar> instead of String when building up the decoded string in
              the ICU and Mac decoders. Using String leads to O(n^2) behavior because
              String grows the buffer every single time that append is called. Using
              Vector::append instead of String::append also avoids constructing a string
              each time just to append and a questionable copy that is done inside the
              String::append function which also contributed to the slowness.
      
              * platform/PlatformString.h:
              * platform/String.cpp: (WebCore::String::adopt): Added. Makes a String from a
              Vector<UChar>, adopting the buffer from the vector to avoid copying and memory
              allocation.
              * platform/StringImpl.h:
              * platform/StringImpl.cpp: (WebCore::StringImpl::adopt): Ditto.
      
              * platform/StreamingTextDecoder.h:
              * platform/StreamingTextDecoder.cpp: (WebCore::TextCodec::appendOmittingBOM):
              Change to use a Vector<UChar> instead of a String, since vectors have better
              resizing performance (they store a separate capacity).
      
              * platform/StreamingTextDecoderICU.cpp: (WebCore::TextCodecICU::decode):
              * platform/mac/StreamingTextDecoderMac.cpp: (WebCore::TextCodecMac::decode):
              Change to use Vector<UChar> instead of String and then create a string at
              the end of the process using the new adopt function.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16622 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6138a1eb
    • weinig's avatar
      Reviewed by Tim H. · f64d1354
      weinig authored
              Patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=11057
              Auto-generate more SVG Objective-C bindings
      
              - Auto-generates DOMSVGAnimatedAngle, DOMSVGAnimatedBoolean, 
                DOMSVGAnimatedEnumeration, DOMSVGAnimatedInteger, DOMSVGAnimatedLength,
                DOMSVGAnimatedLengthList, DOMSVGAnimatedNumber, DOMSVGAnimatedString,
                DOMSVGAnimatedTransformList, DOMSVGExternalResourcesRequired,
                DOMSVGLangSpace, DOMSVGLocatable, DOMSVGMetadataElement, DOMSVGRectElement,
                DOMSVGStringList, DOMSVGStylable, DOMSVGStyleElement, DOMSVGTests, 
                and DOMSVGTransformable.
      
              - Adds ability to CodeGeneratorObjC.pm to handle interfaces with mulitple
                parent interfaces and the SVG animated classes.
      
              - Corrects CodeGenerator.pm to only skip the first parent for the main 
                interface.
      
              * DerivedSources.make:
              * WebCore.xcodeproj/project.pbxproj:
              * bindings/objc/DOMInternal.h:
              * bindings/objc/DOMSVG.h:
              * bindings/scripts/CodeGenerator.pm:
              * bindings/scripts/CodeGeneratorObjC.pm:
              * ksvg2/svg/SVGAnimatedAngle.idl:
              * ksvg2/svg/SVGAnimatedBoolean.idl:
              * ksvg2/svg/SVGAnimatedEnumeration.idl:
              * ksvg2/svg/SVGAnimatedInteger.idl:
              * ksvg2/svg/SVGAnimatedLength.idl:
              * ksvg2/svg/SVGAnimatedLengthList.idl:
              * ksvg2/svg/SVGAnimatedNumber.idl:
              * ksvg2/svg/SVGAnimatedPathData.idl:
              * ksvg2/svg/SVGAnimatedString.idl:
              * ksvg2/svg/SVGAnimatedTransformList.idl:
              * ksvg2/svg/SVGExternalResourcesRequired.idl:
              * ksvg2/svg/SVGFilterPrimitiveStandardAttributes.idl:
              * ksvg2/svg/SVGFitToViewBox.idl:
              * ksvg2/svg/SVGLangSpace.idl:
              * ksvg2/svg/SVGLocatable.idl:
              * ksvg2/svg/SVGMetadataElement.idl:
              * ksvg2/svg/SVGStringList.idl:
              * ksvg2/svg/SVGStylable.idl:
              * ksvg2/svg/SVGStyleElement.idl:
              * ksvg2/svg/SVGTests.idl:
              * ksvg2/svg/SVGTransformable.idl:
              * ksvg2/svg/SVGURIReference.idl:
              * ksvg2/svg/SVGUnitTypes.idl:
              * ksvg2/svg/SVGZoomAndPan.idl:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16616 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f64d1354
    • beidson's avatar
      Reviewed by Mitz Pettel!!! · a31d0ecf
      beidson authored
              Change the error code check for common functions from SQLResultOk to SQLResultDone 
      
              * loader/icon/IconDatabase.cpp:
              (WebCore::IconDatabase::forgetPageURLQuery):
              (WebCore::IconDatabase::setIconIDForPageURLQuery):
              (WebCore::IconDatabase::addIconForIconURLQuery):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16615 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a31d0ecf
    • hyatt's avatar
      Dump the use of MapWindowPoints on Win32 and just let the outermost HWND be... · 18d2f317
      hyatt authored
      Dump the use of MapWindowPoints on Win32 and just let the outermost HWND be the viewport point of reference for events and such.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16612 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      18d2f317
    • hyatt's avatar
      Fix for bug 9222, cursor is wrong when mousing over overflow... · d6df5850
      hyatt authored
              Fix for bug 9222, cursor is wrong when mousing over overflow scrollbars in textareas.  Make sure
              selectCursor checks for whether or not a scrollbar was hit.  Also stub out a mouseMoved method for
              scrollbars to provide hover feedback if needed.
      
              Reviewed by Eric
      
              * page/FrameView.cpp:
              (WebCore::selectCursor):
              (WebCore::FrameView::handleMouseMoveEvent):
              * platform/ScrollBar.h:
              (WebCore::ScrollBar::mouseMoved):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16611 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d6df5850
  2. 27 Sep, 2006 6 commits
    • aroben's avatar
      2006-09-27 MorganL <morganl.webkit@yahoo.com> · c46cb262
      aroben authored
              Reviewed by Maciej and Adam, landed by Adam
      
              Fixes: http://bugzilla.opendarwin.org/show_bug.cgi?id=11072
              Windows build is busted
      
              * platform/win/TemporaryLinkStubs.cpp:
              (ScrollView::paint):
              (ScrollView::themeChanged):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16609 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c46cb262
    • eseidel's avatar
      2006-09-27 Eric Seidel <eric@eseidel.com> · 4eb9f842
      eseidel authored
              Reviewed by mitz.
      
              paths with no fill specified default to black but do not recieve paint-related mouse events
              http://bugzilla.opendarwin.org/show_bug.cgi?id=11069
              The default fill was being applied at the wrong place in the rendering chain, causing this problem.
      
              Test: svg/custom/hover-default-fill.svg
      
              * kcanvas/RenderPath.cpp:
              (WebCore::RenderPath::nodeAtPoint): use isFilled and isStroked
              * ksvg2/css/SVGRenderStyle.h: use defaultFill() and defaultStroke()
              * ksvg2/misc/KCanvasRenderingStyle.cpp:
              (WebCore::KSVGPainterFactory::isFilled): remove null check
              (WebCore::KSVGPainterFactory::fillPaintServer): remove null check
              (WebCore::KSVGPainterFactory::isStroked): remove null check
              (WebCore::KSVGPainterFactory::strokePaintServer): remove null check
              * ksvg2/svg/SVGPaint.cpp:
              (WebCore::SVGPaint::defaultFill): added.
              (WebCore::SVGPaint::defaultStroke): added.
              * ksvg2/svg/SVGPaint.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16604 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4eb9f842
    • rwlbuis's avatar
      Reviewed by eseidel. · 54820aa2
      rwlbuis authored
              http://bugzilla.opendarwin.org/show_bug.cgi?id=11015
              SVG handles em units incorrectly
      
              Calculate viewport coordinates at layout time, since
              at this point the font size is known and lengths depending
              on font sizes can be calculated correctly.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16601 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      54820aa2
    • eseidel's avatar
      2006-09-27 Eric Seidel <eric@eseidel.com> · 9c1a0334
      eseidel authored
              Reviewed by darin.
      
              Change our invalid-fill error behavior to match Opera (and soon Firefox)
              http://bugzilla.opendarwin.org/show_bug.cgi?id=11017
      
              * ksvg2/misc/KCanvasRenderingStyle.cpp:
              (WebCore::KSVGPainterFactory::isFilled):
              (WebCore::KSVGPainterFactory::fillPaintServer):
              (WebCore::KSVGPainterFactory::isStroked):
              (WebCore::KSVGPainterFactory::strokePaintServer):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16599 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9c1a0334
    • beidson's avatar
      Build fix · 52c4fbcc
      beidson authored
              * loader/icon/IconDatabase.cpp:
              (WebCore::readySQLStatement):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16598 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      52c4fbcc
    • beidson's avatar
      WebCore: · b8a16d03
      beidson authored
              Reviewed by Adam
      
              In very specific circumstances, prepared SQLStatements can become invalid without
              any warning.  This checks for that state and re-prepares the statement and also
              adds more aggressive error-checking everywhere these statements are used.
      
              * loader/icon/IconDatabase.cpp:
              (WebCore::readySQLStatement): Check if the statement is expired - reprepare it
              (WebCore::IconDatabase::imageDataForIconURLQuery): More thoroughly catch error cases
              (WebCore::IconDatabase::timeStampForIconURLQuery): Ditto
              (WebCore::IconDatabase::iconURLForPageURLQuery): Ditto
              (WebCore::IconDatabase::forgetPageURLQuery): Ditto
              (WebCore::IconDatabase::setIconIDForPageURLQuery): Ditto
              (WebCore::IconDatabase::getIconIDForIconURLQuery): Ditto
              (WebCore::IconDatabase::addIconForIconURLQuery): Ditto
              (WebCore::IconDatabase::hasIconForIconURLQuery): Ditto
              * loader/icon/SQLStatement.cpp:
              (WebCore::SQLStatement::isExpired): Added (accessor to sqlite3_expired())
              * loader/icon/SQLStatement.h:
              
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16595 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b8a16d03
  3. 26 Sep, 2006 12 commits
    • darin's avatar
      Reviewed by Steve. · f2b7ba53
      darin authored
              - clean up options for font code path
      
              * platform/Font.h:
              * platform/Font.cpp:
              (WebCore::Font::setCodePath): Added. Replaces boolean version.
              (WebCore::Font::canUseGlyphCache): Update to handle "never use complex" case too.
      
              * platform/mac/WebCoreTextRenderer.mm:
              (WebCoreSetAlwaysUseATSU): Change to call setCodePath.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16594 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f2b7ba53
    • sullivan's avatar
      WebCore: · caf3550b
      sullivan authored
              Reviewed by Darin
      
              * bridge/mac/WebCoreFrameBridge.h:
              * bridge/mac/WebCoreFrameBridge.mm:
              (-[WebCoreFrameBridge markAllMatchesForText:caseSensitive:limit:]):
              Added limit parameter, passed down to Frame
              
              * page/Frame.h:
              * page/Frame.cpp:
              (WebCore::Frame::markAllMatchesForText):
              Added limit parameter. Stop the search if it hits limit.
      
      WebKit:
      
              Reviewed by Darin
      
              * WebView/WebHTMLViewPrivate.h:
              * WebView/WebHTMLView.m:
              (-[WebHTMLView markAllMatchesForText:caseSensitive:limit:]):
              Added limit parameter, passed over the bridge. Stop the search if it hits limit.
      
              * WebView/WebViewPrivate.h:
              * WebView/WebView.m:
              (-[WebView markAllMatchesForText:caseSensitive:highlight:limit:]):
              Added limit parameter, passed to WebHTMLView.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16593 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      caf3550b
    • seangies's avatar
      Removed #if's. · baf40fdf
      seangies authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16592 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      baf40fdf
    • justing's avatar
      LayoutTests: · cdacf131
      justing authored
              Reviewed by john
              
              <rdar://problem/4747695> 
              Gmail Editor: Crash at WebCore::Range::startPosition() when decreasing a indent
      
              * editing/deleting/list-item-1-expected.checksum: Added.
              * editing/deleting/list-item-1-expected.png: Added.
              * editing/deleting/list-item-1-expected.txt: Added.
              * editing/deleting/list-item-1.html: Added.
              * editing/execCommand/remove-list-item-1-expected.checksum: Added.
              * editing/execCommand/remove-list-item-1-expected.png: Added.
              * editing/execCommand/remove-list-item-1-expected.txt: Added.
              * editing/execCommand/remove-list-item-1.html: Added.
      
      WebCore:
      
              Reviewed by john
              
              <rdar://problem/4747695> 
              Gmail Editor: Crash at WebCore::Range::startPosition() when decreasing a indent
              
              * editing/DeleteSelectionCommand.cpp:
              (WebCore::DeleteSelectionCommand::initializeStartEnd): Stop expanding
              to select special elements that are fully selected after expansion
              moves to positions that are visually distinct from the originals.
              * editing/InsertListCommand.cpp:
              (WebCore::InsertListCommand::doApply): If the content of the list 
              item will be moved into another list, put it in a list item.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16587 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cdacf131
    • ggaren's avatar
      Reviewed by Darin. · 41eba0bf
      ggaren authored
              
              Temporary work-around for frame lifetime issue.
      
              * page/Frame.cpp:
              (WebCore::Frame::clear):
              (WebCore::Frame::disconnectOwnerElement):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16585 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      41eba0bf
    • weinig's avatar
      Reviewed by Tim H. · 460f0156
      weinig authored
              Patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=11038
              Auto-generate DOMSVGElement for the Objective-C bindings
      
              - Auto-generates DOMSVGElement.
      
              - Make SVGExceptions work like all the other ExceptionCode
                extensions (Range, XPath, etc.) by adding SVGExceptionOffset
                and SVGExceptionMax.
      
              * DerivedSources.make:
              * WebCore.xcodeproj/project.pbxproj:
              * bindings/js/kjs_binding.cpp:
              (KJS::):
              (KJS::setDOMException):
              * bindings/objc/DOMInternal.h:
              * bindings/objc/DOMInternal.mm:
              (raiseDOMException):
              * bindings/objc/DOMSVG.h:
              * bindings/objc/DOMSVGExecption.h: Added.
              * ksvg2/ksvg.h:
              * ksvg2/svg/SVGElement.cpp:
              (WebCore::SVGElement::setId):
              (WebCore::SVGElement::setXmlbase):
              * ksvg2/svg/SVGElement.h:
              * ksvg2/svg/SVGElement.idl:
              * ksvg2/svg/SVGException.h: Added.
              (WebCore::):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16578 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      460f0156
    • eseidel's avatar
      2006-09-26 Eric Seidel <eric@eseidel.com> · be2e75ce
      eseidel authored
              Reviewed by Tim H.
              
              viewbox parser does not allow <tab> as a delimiter
              http://bugzilla.opendarwin.org/show_bug.cgi?id=11014
      
              Test: svg/hixie/viewbox/003.xml
      
              * ksvg2/svg/svgpathparser.cpp:
              (WebCore::isWhitespace): new function
              (WebCore::skipOptionalSpaces):
              (WebCore::skipOptionalSpacesOrComma):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16576 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      be2e75ce
    • eseidel's avatar
      2006-09-26 Eric Seidel <eric@eseidel.com> · 8192b622
      eseidel authored
              Reviewed by Tim H.
      
              SVGDocument::createElement does not create elements in the SVG namespace
              http://bugzilla.opendarwin.org/show_bug.cgi?id=10932
              
              Test: svg/custom/createelement.svg
      
              * ksvg2/svg/SVGDocument.cpp:
              (WebCore::SVGDocument::createElement):
              * ksvg2/svg/SVGDocument.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16575 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8192b622
    • eseidel's avatar
      2006-09-26 Eric Seidel <eric@eseidel.com> · de9f5ab7
      eseidel authored
              Reviewed by Tim H.
              
              RenderPath::nodeAtPoint does not respect stroke width
              http://bugzilla.opendarwin.org/show_bug.cgi?id=10829
      
              Test: svg/custom/stroke-width-click.svg
      
              * kcanvas/device/quartz/KCanvasItemQuartz.mm:
              (WebCore::RenderPath::strokeContains):
              * kcanvas/device/quartz/QuartzSupport.h:
              * kcanvas/device/quartz/QuartzSupport.mm:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16574 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      de9f5ab7
    • eseidel's avatar
      2006-09-26 Eric Seidel <eric@eseidel.com> · b85b2954
      eseidel authored
              Reviewed by mitz.
      
              Bring animation back to life
              http://bugzilla.opendarwin.org/show_bug.cgi?id=11021
              
              Register/unregister SVGSVGElements as time containers on insertion/removal.
              Replace uses of DeprecatedString with String in SVGAnimationElement
              Various whitespace clean-up.
      
              * ksvg2/misc/KSVGTimeScheduler.cpp:
              (WebCore::SVGTimer::notifyAll):
              * ksvg2/misc/SVGDocumentExtensions.cpp:
              (WebCore::SVGDocumentExtensions::startAnimations):
              (WebCore::SVGDocumentExtensions::pauseAnimations):
              (WebCore::SVGDocumentExtensions::unpauseAnimations):
              * ksvg2/svg/SVGAnimateTransformElement.cpp:
              (WebCore::SVGAnimateTransformElement::handleTimerEvent):
              (WebCore::SVGAnimateTransformElement::parseTransformValue):
              * ksvg2/svg/SVGAnimateTransformElement.h:
              * ksvg2/svg/SVGAnimationElement.cpp:
              (WebCore::SVGAnimationElement::SVGAnimationElement):
              (WebCore::SVGAnimationElement::parseMappedAttribute):
              (WebCore::SVGAnimationElement::parseClockValue):
              (WebCore::SVGAnimationElement::targetAttribute):
              (WebCore::SVGAnimationElement::setTargetAttribute):
              (WebCore::SVGAnimationElement::attributeName):
              * ksvg2/svg/SVGAnimationElement.h:
              (WebCore::SVGAnimationElement::rendererIsNeeded):
              * ksvg2/svg/SVGSVGElement.cpp:
              (WebCore::SVGSVGElement::getScreenCTM):
              (WebCore::SVGSVGElement::createRenderer):
              (WebCore::SVGSVGElement::insertedIntoDocument): added, calls addTimeContainer(this)
              (WebCore::SVGSVGElement::removedFromDocument): added, calls removeTimeContainer(this)
              * ksvg2/svg/SVGSVGElement.h:
              * ksvg2/svg/SVGSetElement.cpp:
              (WebCore::SVGSetElement::handleTimerEvent):
              * ksvg2/svg/SVGURIReference.cpp:
              (WebCore::SVGURIReference::getTarget):
              * ksvg2/svg/SVGURIReference.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16572 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b85b2954
    • bdash's avatar
      2006-09-26 Graham Dennis <graham.dennis@gmail.com> · faf82c6d
      bdash authored
              Reviewed by mitzpettel.
      
              - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=11020
              No-SVG build broken since r16549
              
              Change #if SVG_SUPPORT to #ifdef SVG_SUPPORT
      
              * css/cssparser.cpp:
              (WebCore::CSSParser::parseValue):
              * css/cssstyleselector.cpp:
              (WebCore::CSSStyleSelector::applyProperty):
              * page/FrameView.cpp:
              (WebCore::selectCursor):
              * platform/qt/GraphicsContextQt.cpp:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16571 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      faf82c6d
    • andersca's avatar
      2006-09-26 Anders Carlsson <acarlsson@apple.com> · 26326314
      andersca authored
              Reviewed by Maciej.
      
              http://bugzilla.opendarwin.org/show_bug.cgi?id=10820
              Add StringImpl::toDouble() and remove uses of .deprecatedString().toDouble()
              
              (Originally written by Eric Seidel).
              
              * bindings/js/kjs_window.cpp:
              (KJS::floatFeature):
              * ksvg2/svg/SVGAngle.cpp:
              (SVGAngle::setValueAsString):
              * ksvg2/svg/SVGAnimationElement.cpp:
              (SVGAnimationElement::parseMappedAttribute):
              * ksvg2/svg/SVGComponentTransferFunctionElement.cpp:
              (SVGComponentTransferFunctionElement::parseMappedAttribute):
              * ksvg2/svg/SVGFECompositeElement.cpp:
              (WebCore::SVGFECompositeElement::parseMappedAttribute):
              * ksvg2/svg/SVGFEDiffuseLightingElement.cpp:
              (WebCore::SVGFEDiffuseLightingElement::parseMappedAttribute):
              * ksvg2/svg/SVGFEDisplacementMapElement.cpp:
              (SVGFEDisplacementMapElement::parseMappedAttribute):
              * ksvg2/svg/SVGFELightElement.cpp:
              (SVGFELightElement::parseMappedAttribute):
              * ksvg2/svg/SVGFEOffsetElement.cpp:
              (WebCore::SVGFEOffsetElement::parseMappedAttribute):
              * ksvg2/svg/SVGFESpecularLightingElement.cpp:
              (SVGFESpecularLightingElement::parseMappedAttribute):
              * ksvg2/svg/SVGFETurbulenceElement.cpp:
              (WebCore::SVGFETurbulenceElement::parseMappedAttribute):
              * ksvg2/svg/SVGStopElement.cpp:
              (SVGStopElement::parseMappedAttribute):
              * platform/AtomicString.h:
              (WebCore::AtomicString::toDouble):
              * platform/PlatformString.h:
              * platform/String.cpp:
              (WebCore::String::toDouble):
              * platform/StringImpl.cpp:
              (WebCore::StringImpl::toDouble):
              * platform/StringImpl.h:
              * rendering/DeprecatedSlider.cpp:
              (WebCore::DeprecatedSlider::updateFromElement):
              * xml/XPathGrammar.y:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16568 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      26326314
  4. 25 Sep, 2006 11 commits
    • harrison's avatar
      Reviewed by Tim Omernick and Tim Hatcher. · 165ca0b9
      harrison authored
              <rdar://problem/4717965> Text Field text parameterized attributes should work
              <rdar://problem/4712111> Support NSAccessibilityInsertionPointLineNumberAttribute for AXTextArea elements
      
              * bridge/mac/WebCoreAXObject.mm:
              (-[WebCoreAXObject accessibilityAttributeValue:]):
              Use new line number support to implement NSAccessibilityInsertionPointLineNumberAttribute.
              
              (-[WebCoreAXObject accessibilityParameterizedAttributeNames]):
              Cleaned up. Added text field and text area parameterzed attributes.
              
              (-[WebCoreAXObject doAXLineForTextMarker:]):
              Fixed to be zero-based and to deal with the first position properly.
              
              (-[WebCoreAXObject doAXTextMarkerRangeForLine:]):
              Minor formatting.
              
              (-[WebCoreAXObject textMarkerForIndex:lastIndexOK:]):
              (-[WebCoreAXObject indexForTextMarker:]):
              (-[WebCoreAXObject textMarkerRangeForRange:]):
              (-[WebCoreAXObject rangeForTextMarkerRange:]):
              New utility methods.
              
              (-[WebCoreAXObject doAXLineForIndex:]):
              (-[WebCoreAXObject doAXRangeForLine:]):
              (-[WebCoreAXObject doAXStringForRange:]):
              (-[WebCoreAXObject doAXRangeForPosition:]):
              (-[WebCoreAXObject doAXRangeForIndex:]):
              (-[WebCoreAXObject doAXBoundsForRange:]):
              (-[WebCoreAXObject doAXAttributedStringForRange:]):
              (-[WebCoreAXObject doAXRTFForRange:]):
              (-[WebCoreAXObject doAXStyleRangeForIndex:]):
              Implement text field and text area parameterized attributes.
               
              (-[WebCoreAXObject accessibilityAttributeValue:forParameter:]):
              Added text field and text area parameterzed attributes.
      
              * rendering/RenderTextControl.h:
              Made indexForVisiblePosition() and visiblePositionForIndex() public.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16567 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      165ca0b9
    • aroben's avatar
      Reviewed by Brady. · 67aba1a2
      aroben authored
              Build fixes.
      
              * WebCore.vcproj/WebCore/WebCore.vcproj: Fix malformed XML.
              * platform/ResourceLoader.h: Store whether a particular job
              has received a response within the ResourceLoader object itself, since
              it's possible that we will enter the InternetReadFileExA while loop
              twice for the same job.
              * platform/ResourceLoaderInternal.h: Add private instance variable to
              store whether we've received a response.
              (WebCore::ResourceLoaderInternal::ResourceLoaderInternal):
              * platform/win/GraphicsContextWin.cpp: Fix order of preprocessor
              directives.
              * platform/win/ResourceLoaderWin.cpp: 
              (WebCore::ResourceLoader::onRequestComplete): Ask the ResourceLoader
              whether it has received a response instead of assuming it hasn't.
              (WebCore::ResourceLoader::setHasReceivedResponse): Added.
              (WebCore::ResourceLoader::hasReceivedResponse): Added.
              * platform/win/TemporaryLinkStubs.cpp: Rename setKnobProportion to
              setProportion
              (ScrollBar::setProportion):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16566 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      67aba1a2
    • beidson's avatar
      Requested by ggaren · bae38fcf
      beidson authored
              Disabled IconDatabase logging by default
      
              * platform/Logging.cpp:
              (WebCore::):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16565 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bae38fcf
    • sfalken's avatar
      2006-09-25 Steve Falkenburg <sfalken@apple.com> · abdf2da4
      sfalken authored
              Reviewed by Jeff Jenkins.
      
              Tweak CF types.
      
              * platform/cf/ResourceLoaderCFNet.cpp:
              (WebCore::willCacheResponse):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16564 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      abdf2da4
    • justing's avatar
      LayoutTests: · 3705ffd7
      justing authored
              Reviewed by john
      
              * editing/execCommand/indent-empty-root-expected.checksum: Added.
              * editing/execCommand/indent-empty-root-expected.png: Added.
              * editing/execCommand/indent-empty-root-expected.txt: Added.
              * editing/execCommand/indent-empty-root.html: Added.
      
      WebCore:
      
              Reviewed by john
              
              <http://bugzilla.opendarwin.org/show_bug.cgi?id=11002>
              Gmail Editor: Crash at WebCore::SplitElementCommand::doApply() when attempting to indent in a new message
              
              * editing/IndentOutdentCommand.cpp:
              (WebCore::IndentOutdentCommand::indentRegion): Special case
              an empty root editable element.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16563 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3705ffd7
    • beidson's avatar
      Math error in SystemTimeWin · 009098e9
      beidson authored
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16562 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      009098e9
    • ap's avatar
      Reviewed by Eric. · 1669824c
      ap authored
              Whitespace cleanup; rename *job variables to *loader.
      
              * bindings/js/JSXMLHttpRequest.cpp:
              (KJS::JSXMLHttpRequestConstructorImp::JSXMLHttpRequestConstructorImp):
              (KJS::JSXMLHttpRequestConstructorImp::implementsConstruct):
              (KJS::JSXMLHttpRequestConstructorImp::construct):
              (KJS::JSXMLHttpRequest::getOwnPropertySlot):
              (KJS::JSXMLHttpRequest::getValueProperty):
              (KJS::JSXMLHttpRequest::put):
              (KJS::JSXMLHttpRequest::putValueProperty):
              (KJS::JSXMLHttpRequest::mark):
              (KJS::JSXMLHttpRequest::JSXMLHttpRequest):
              (KJS::JSXMLHttpRequest::~JSXMLHttpRequest):
              (KJS::JSXMLHttpRequestProtoFunc::callAsFunction):
              * bindings/js/JSXMLHttpRequest.h:
              (KJS::JSXMLHttpRequest::toBoolean):
              * xml/xmlhttprequest.cpp:
              (WebCore::XMLHttpRequest::XMLHttpRequest):
              (WebCore::XMLHttpRequest::urlMatchesDocumentDomain):
              (WebCore::XMLHttpRequest::send):
              (WebCore::XMLHttpRequest::abort):
              (WebCore::XMLHttpRequest::receivedAllData):
              (WebCore::XMLHttpRequest::receivedData):
              * xml/xmlhttprequest.h:
              (WebCore::):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16560 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1669824c
    • thatcher's avatar
      WebCore: · aacdbc64
      thatcher authored
              Reviewed by Brady.
      
              - Deprecate the rest of the old-style methods that are not generated.
              - Add @property syntax to DOMRange.
      
              * WebCore.xcodeproj/project.pbxproj:
              * bindings/objc/DOM.mm:
              (-[DOMRange setStart:offset:]):
              (-[DOMRange setEnd:offset:]):
              (-[DOMRange compareBoundaryPoints:sourceRange:]):
              (-[DOMRange setStart::]):
              (-[DOMRange setEnd::]):
              (-[DOMRange compareBoundaryPoints::]):
              (-[DOMDocument createNodeIterator:whatToShow:filter:expandEntityReferences:]):
              (-[DOMDocument createTreeWalker:whatToShow:filter:expandEntityReferences:]):
              (-[DOMDocument createNodeIterator::::]):
              (-[DOMDocument createTreeWalker::::]):
              * bindings/objc/DOMCSS.h:
              * bindings/objc/DOMCSS.mm:
              (-[DOMDocument getComputedStyle:pseudoElement:]):
              (-[DOMDocument getComputedStyle::]):
              (-[DOMDocument getMatchedCSSRules:pseudoElement:]):
              * bindings/objc/DOMExtensions.h:
              * bindings/objc/DOMHTML.h:
              * bindings/objc/DOMRange.h:
              * bindings/objc/DOMTraversal.h:
      
      WebKit:
      
              Reviewed by Brady.
      
              Use the non-deprecated method names for getComputedStyle, setEnd and setStart.
      
              * WebInspector/WebInspector.m:
              (-[WebInspector _highlightNode:]):
              * WebView/WebHTMLView.m:
              (unionDOMRanges):
              (-[WebHTMLView _selectRangeInMarkedText:]):
              (-[WebTextCompleteController doCompletion]):
              * WebView/WebView.m:
              (-[WebView computedStyleForElement:pseudoElement:]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16559 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      aacdbc64
    • eseidel's avatar
      2006-09-25 Eric Seidel <eric@eseidel.com> · 2fd5ac86
      eseidel authored
              Reviewed by mjs.
              
              Outermost <svg> element should clip to viewport
              http://bugzilla.opendarwin.org/show_bug.cgi?id=11007
      
              Test: svg/custom/viewport-clip.svg
      
              * css/svg.css: change svg:root overflow: from 'visible' to 'hidden'
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16557 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2fd5ac86
    • andersca's avatar
      2006-09-25 Anders Carlsson <acarlsson@apple.com> · faf7bea9
      andersca authored
              Reviewed by Maciej.
      
              * css/MediaList.cpp:
              Remove unused header.
              
              * dom/Document.cpp:
              (WebCore::Document::clear):
              Use clear instead of iterating through the list of event listeners, removing each one.
              (Doing that causes a crash when running the layout tests with GuardMalloc turned on)
              
              * html/HTMLKeygenElement.cpp:
              (WebCore::HTMLKeygenElement::HTMLKeygenElement):
              (WebCore::HTMLKeygenElement::appendFormData):
              Update due to changes in the SSL key generator.
              
              * ksvg2/svg/SVGAngle.cpp:
              Remove unused header.
              
              * ksvg2/svg/SVGAnimationElement.cpp:
              (SVGAnimationElement::parseMappedAttribute):
              Rename methods and pass Strings instead of DeprecatedStrings to
              parseSeparatedList.
              
              * ksvg2/svg/SVGFEColorMatrixElement.cpp:
              * ksvg2/svg/SVGFEDiffuseLightingElement.cpp:
              * ksvg2/svg/SVGFEDisplacementMapElement.cpp:
              * ksvg2/svg/SVGFEMergeElement.cpp:
              * ksvg2/svg/SVGFEOffsetElement.cpp:
              Remove unused headers.
              
              * ksvg2/svg/SVGHelper.cpp:
              (WebCore::SVGHelper::parseSeparatedList):
              * ksvg2/svg/SVGHelper.h:
              Rename ParseSeperatedList to parseSeparatedList, make it take a String instead of a 
              DeprecatedString and have it use Vector<String> instead of DeprecatedStringList.
              
              * ksvg2/svg/SVGLengthList.cpp:
              (WebCore::SVGLengthList::parse):
              * ksvg2/svg/SVGLengthList.h:
              Use Vector<String> instead of DeprecatedStringList.
              
              * loader/Cache.cpp:
              (WebCore::Cache::requestImage):
              (WebCore::Cache::requestStyleSheet):
              (WebCore::Cache::requestScript):
              (WebCore::Cache::requestXSLStyleSheet):
              (WebCore::Cache::requestXBLDocument):
              (WebCore::Cache::remove):
              (WebCore::Cache::get):
              Use a String as the key in the cache set instead of a RefPtr<StringImpl>.
              
              * loader/DocLoader.cpp:
              (WebCore::DocLoader::needReload):
              * loader/DocLoader.h:
              Use a HashSet instead of DeprecatedStringList.
              
              * page/FrameView.h:
              Remove declarations that have no functions.
              
              * platform/SSLKeyGenerator.h:
              * platform/mac/SSLKeyGeneratorMac.mm:
              (WebCore::supportedKeySizes):
              (WebCore::signedPublicKeyAndChallengeString):
              Convert to use Vector<String> instead of DeprecatedStringList, and String instead of
              DeprecatedString.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16556 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      faf7bea9
    • hyatt's avatar
      Cleanup in RenderThemeWin and GraphicsContextCairo/Win · 5b1bc975
      hyatt authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16554 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5b1bc975
  5. 24 Sep, 2006 2 commits