1. 31 Jan, 2011 27 commits
  2. 30 Jan, 2011 13 commits
    • ossy@webkit.org's avatar
      2011-01-30 Csaba Osztrogonác <ossy@webkit.org> · ad0e9df1
      ossy@webkit.org authored
              Unreviewed, rolling out r77098, r77099, r77100, r77109, and
              r77111.
              http://trac.webkit.org/changeset/77098
              http://trac.webkit.org/changeset/77099
              http://trac.webkit.org/changeset/77100
              http://trac.webkit.org/changeset/77109
              http://trac.webkit.org/changeset/77111
              https://bugs.webkit.org/show_bug.cgi?id=53219
      
              Qt build is broken
      
              * API/JSCallbackObject.h:
              (JSC::JSCallbackObjectData::setPrivateProperty):
              (JSC::JSCallbackObjectData::JSPrivatePropertyMap::getPrivateProperty):
              (JSC::JSCallbackObjectData::JSPrivatePropertyMap::setPrivateProperty):
              (JSC::JSCallbackObjectData::JSPrivatePropertyMap::markChildren):
              (JSC::JSCallbackObject::setPrivateProperty):
              * API/JSCallbackObjectFunctions.h:
              (JSC::::put):
              (JSC::::staticFunctionGetter):
              * API/JSObjectRef.cpp:
              (JSObjectMakeConstructor):
              (JSObjectSetPrivateProperty):
              * API/JSWeakObjectMapRefInternal.h:
              * JavaScriptCore.exp:
              * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
              * JavaScriptCore.xcodeproj/project.pbxproj:
              * bytecode/CodeBlock.cpp:
              (JSC::CodeBlock::markAggregate):
              * bytecode/CodeBlock.h:
              (JSC::CodeBlock::globalObject):
              * bytecompiler/BytecodeGenerator.cpp:
              (JSC::BytecodeGenerator::BytecodeGenerator):
              (JSC::BytecodeGenerator::emitJumpIfNotFunctionCall):
              (JSC::BytecodeGenerator::emitJumpIfNotFunctionApply):
              (JSC::BytecodeGenerator::findScopedProperty):
              * debugger/Debugger.cpp:
              (JSC::evaluateInGlobalCallFrame):
              * debugger/DebuggerActivation.cpp:
              (JSC::DebuggerActivation::DebuggerActivation):
              (JSC::DebuggerActivation::markChildren):
              * debugger/DebuggerActivation.h:
              * debugger/DebuggerCallFrame.cpp:
              (JSC::DebuggerCallFrame::evaluate):
              * interpreter/CallFrame.h:
              (JSC::ExecState::exception):
              * interpreter/Interpreter.cpp:
              (JSC::Interpreter::resolve):
              (JSC::Interpreter::resolveSkip):
              (JSC::Interpreter::resolveGlobal):
              (JSC::Interpreter::resolveGlobalDynamic):
              (JSC::Interpreter::resolveBaseAndProperty):
              (JSC::Interpreter::unwindCallFrame):
              (JSC::appendSourceToError):
              (JSC::Interpreter::execute):
              (JSC::Interpreter::tryCacheGetByID):
              (JSC::Interpreter::privateExecute):
              * jit/JITStubs.cpp:
              (JSC::JITThunks::tryCacheGetByID):
              (JSC::DEFINE_STUB_FUNCTION):
              * jsc.cpp:
              (GlobalObject::GlobalObject):
              * runtime/ArgList.cpp:
              (JSC::MarkedArgumentBuffer::markLists):
              * runtime/Arguments.cpp:
              (JSC::Arguments::markChildren):
              (JSC::Arguments::getOwnPropertySlot):
              (JSC::Arguments::getOwnPropertyDescriptor):
              (JSC::Arguments::put):
              * runtime/Arguments.h:
              (JSC::Arguments::setActivation):
              (JSC::Arguments::Arguments):
              * runtime/ArrayConstructor.cpp:
              (JSC::ArrayConstructor::ArrayConstructor):
              (JSC::constructArrayWithSizeQuirk):
              * runtime/ArrayPrototype.cpp:
              (JSC::arrayProtoFuncSplice):
              * runtime/BatchedTransitionOptimizer.h:
              (JSC::BatchedTransitionOptimizer::BatchedTransitionOptimizer):
              (JSC::BatchedTransitionOptimizer::~BatchedTransitionOptimizer):
              * runtime/BooleanConstructor.cpp:
              (JSC::BooleanConstructor::BooleanConstructor):
              (JSC::constructBoolean):
              (JSC::constructBooleanFromImmediateBoolean):
              * runtime/BooleanPrototype.cpp:
              (JSC::BooleanPrototype::BooleanPrototype):
              * runtime/ConservativeSet.cpp:
              (JSC::ConservativeSet::grow):
              * runtime/ConservativeSet.h:
              (JSC::ConservativeSet::~ConservativeSet):
              (JSC::ConservativeSet::mark):
              * runtime/DateConstructor.cpp:
              (JSC::DateConstructor::DateConstructor):
              * runtime/DateInstance.cpp:
              (JSC::DateInstance::DateInstance):
              * runtime/DatePrototype.cpp:
              (JSC::dateProtoFuncSetTime):
              (JSC::setNewValueFromTimeArgs):
              (JSC::setNewValueFromDateArgs):
              (JSC::dateProtoFuncSetYear):
              * runtime/ErrorConstructor.cpp:
              (JSC::ErrorConstructor::ErrorConstructor):
              * runtime/ErrorInstance.cpp:
              (JSC::ErrorInstance::ErrorInstance):
              * runtime/ErrorPrototype.cpp:
              (JSC::ErrorPrototype::ErrorPrototype):
              * runtime/FunctionConstructor.cpp:
              (JSC::FunctionConstructor::FunctionConstructor):
              * runtime/FunctionPrototype.cpp:
              (JSC::FunctionPrototype::FunctionPrototype):
              * runtime/GetterSetter.cpp:
              (JSC::GetterSetter::markChildren):
              * runtime/GetterSetter.h:
              (JSC::GetterSetter::GetterSetter):
              (JSC::GetterSetter::getter):
              (JSC::GetterSetter::setGetter):
              (JSC::GetterSetter::setter):
              (JSC::GetterSetter::setSetter):
              * runtime/GlobalEvalFunction.cpp:
              (JSC::GlobalEvalFunction::GlobalEvalFunction):
              (JSC::GlobalEvalFunction::markChildren):
              * runtime/GlobalEvalFunction.h:
              (JSC::GlobalEvalFunction::cachedGlobalObject):
              * runtime/Heap.cpp:
              (JSC::Heap::markProtectedObjects):
              (JSC::Heap::markTempSortVectors):
              (JSC::Heap::markRoots):
              * runtime/InternalFunction.cpp:
              (JSC::InternalFunction::InternalFunction):
              * runtime/JSAPIValueWrapper.h:
              (JSC::JSAPIValueWrapper::value):
              (JSC::JSAPIValueWrapper::JSAPIValueWrapper):
              * runtime/JSActivation.cpp:
              (JSC::JSActivation::markChildren):
              (JSC::JSActivation::put):
              * runtime/JSArray.cpp:
              (JSC::JSArray::JSArray):
              (JSC::JSArray::getOwnPropertySlot):
              (JSC::JSArray::getOwnPropertyDescriptor):
              (JSC::JSArray::put):
              (JSC::JSArray::putSlowCase):
              (JSC::JSArray::deleteProperty):
              (JSC::JSArray::increaseVectorLength):
              (JSC::JSArray::setLength):
              (JSC::JSArray::pop):
              (JSC::JSArray::push):
              (JSC::JSArray::unshiftCount):
              (JSC::JSArray::sort):
              (JSC::JSArray::fillArgList):
              (JSC::JSArray::copyToRegisters):
              (JSC::JSArray::compactForSorting):
              * runtime/JSArray.h:
              (JSC::JSArray::getIndex):
              (JSC::JSArray::setIndex):
              (JSC::JSArray::uncheckedSetIndex):
              (JSC::JSArray::markChildrenDirect):
              * runtime/JSByteArray.cpp:
              (JSC::JSByteArray::JSByteArray):
              * runtime/JSCell.h:
              (JSC::JSCell::JSValue::toThisObject):
              (JSC::JSCell::MarkStack::append):
              * runtime/JSFunction.cpp:
              (JSC::JSFunction::JSFunction):
              (JSC::JSFunction::getOwnPropertySlot):
              * runtime/JSGlobalData.h:
              * runtime/JSGlobalObject.cpp:
              (JSC::markIfNeeded):
              (JSC::JSGlobalObject::reset):
              (JSC::JSGlobalObject::resetPrototype):
              (JSC::JSGlobalObject::markChildren):
              * runtime/JSGlobalObject.h:
              (JSC::JSGlobalObject::JSGlobalObjectData::JSGlobalObjectData):
              (JSC::JSGlobalObject::regExpConstructor):
              (JSC::JSGlobalObject::errorConstructor):
              (JSC::JSGlobalObject::evalErrorConstructor):
              (JSC::JSGlobalObject::rangeErrorConstructor):
              (JSC::JSGlobalObject::referenceErrorConstructor):
              (JSC::JSGlobalObject::syntaxErrorConstructor):
              (JSC::JSGlobalObject::typeErrorConstructor):
              (JSC::JSGlobalObject::URIErrorConstructor):
              (JSC::JSGlobalObject::evalFunction):
              (JSC::JSGlobalObject::objectPrototype):
              (JSC::JSGlobalObject::functionPrototype):
              (JSC::JSGlobalObject::arrayPrototype):
              (JSC::JSGlobalObject::booleanPrototype):
              (JSC::JSGlobalObject::stringPrototype):
              (JSC::JSGlobalObject::numberPrototype):
              (JSC::JSGlobalObject::datePrototype):
              (JSC::JSGlobalObject::regExpPrototype):
              (JSC::JSGlobalObject::methodCallDummy):
              (JSC::Structure::prototypeForLookup):
              (JSC::constructArray):
              * runtime/JSONObject.cpp:
              (JSC::Stringifier::Holder::object):
              (JSC::Stringifier::markAggregate):
              (JSC::Stringifier::stringify):
              (JSC::Stringifier::Holder::appendNextProperty):
              (JSC::Walker::callReviver):
              (JSC::Walker::walk):
              * runtime/JSObject.cpp:
              (JSC::JSObject::defineGetter):
              (JSC::JSObject::defineSetter):
              (JSC::JSObject::removeDirect):
              (JSC::JSObject::putDirectFunction):
              (JSC::JSObject::putDirectFunctionWithoutTransition):
              (JSC::putDescriptor):
              (JSC::JSObject::defineOwnProperty):
              * runtime/JSObject.h:
              (JSC::JSObject::getDirectOffset):
              (JSC::JSObject::putDirectOffset):
              (JSC::JSObject::flattenDictionaryObject):
              (JSC::JSObject::putDirectInternal):
              (JSC::JSObject::putDirect):
              (JSC::JSObject::putDirectFunction):
              (JSC::JSObject::putDirectWithoutTransition):
              (JSC::JSObject::putDirectFunctionWithoutTransition):
              (JSC::JSValue::putDirect):
              (JSC::JSObject::allocatePropertyStorageInline):
              (JSC::JSObject::markChildrenDirect):
              * runtime/JSPropertyNameIterator.cpp:
              (JSC::JSPropertyNameIterator::JSPropertyNameIterator):
              (JSC::JSPropertyNameIterator::get):
              * runtime/JSPropertyNameIterator.h:
              * runtime/JSStaticScopeObject.cpp:
              (JSC::JSStaticScopeObject::markChildren):
              * runtime/JSString.cpp:
              (JSC::StringObject::create):
              * runtime/JSValue.h:
              * runtime/JSWrapperObject.cpp:
              (JSC::JSWrapperObject::markChildren):
              * runtime/JSWrapperObject.h:
              (JSC::JSWrapperObject::internalValue):
              (JSC::JSWrapperObject::setInternalValue):
              * runtime/LiteralParser.cpp:
              (JSC::LiteralParser::parse):
              * runtime/Lookup.cpp:
              (JSC::setUpStaticFunctionSlot):
              * runtime/Lookup.h:
              (JSC::lookupPut):
              * runtime/MarkStack.h:
              (JSC::MarkStack::appendValues):
              * runtime/MathObject.cpp:
              (JSC::MathObject::MathObject):
              * runtime/NativeErrorConstructor.cpp:
              (JSC::NativeErrorConstructor::NativeErrorConstructor):
              * runtime/NativeErrorPrototype.cpp:
              (JSC::NativeErrorPrototype::NativeErrorPrototype):
              * runtime/NumberConstructor.cpp:
              (JSC::NumberConstructor::NumberConstructor):
              (JSC::constructWithNumberConstructor):
              * runtime/NumberObject.cpp:
              (JSC::constructNumber):
              * runtime/NumberPrototype.cpp:
              (JSC::NumberPrototype::NumberPrototype):
              * runtime/ObjectConstructor.cpp:
              (JSC::ObjectConstructor::ObjectConstructor):
              (JSC::objectConstructorGetOwnPropertyDescriptor):
              * runtime/Operations.h:
              (JSC::normalizePrototypeChain):
              (JSC::resolveBase):
              * runtime/PrototypeFunction.cpp:
              (JSC::PrototypeFunction::PrototypeFunction):
              * runtime/PutPropertySlot.h:
              (JSC::PutPropertySlot::setExistingProperty):
              (JSC::PutPropertySlot::setNewProperty):
              (JSC::PutPropertySlot::base):
              * runtime/RegExpConstructor.cpp:
              (JSC::RegExpConstructor::RegExpConstructor):
              * runtime/ScopeChain.cpp:
              (JSC::ScopeChainNode::print):
              * runtime/ScopeChain.h:
              (JSC::ScopeChainNode::~ScopeChainNode):
              (JSC::ScopeChainIterator::operator*):
              (JSC::ScopeChainIterator::operator->):
              (JSC::ScopeChain::top):
              * runtime/ScopeChainMark.h:
              (JSC::ScopeChain::markAggregate):
              * runtime/SmallStrings.cpp:
              (JSC::isMarked):
              (JSC::SmallStrings::markChildren):
              * runtime/SmallStrings.h:
              (JSC::SmallStrings::emptyString):
              (JSC::SmallStrings::singleCharacterString):
              (JSC::SmallStrings::singleCharacterStrings):
              * runtime/StringConstructor.cpp:
              (JSC::StringConstructor::StringConstructor):
              * runtime/StringObject.cpp:
              (JSC::StringObject::StringObject):
              * runtime/StringObject.h:
              * runtime/StringPrototype.cpp:
              (JSC::StringPrototype::StringPrototype):
              * runtime/Structure.cpp:
              (JSC::Structure::Structure):
              (JSC::Structure::addPropertyTransition):
              (JSC::Structure::toDictionaryTransition):
              (JSC::Structure::flattenDictionaryStructure):
              * runtime/Structure.h:
              (JSC::Structure::storedPrototype):
              * runtime/WeakGCMap.h:
              (JSC::WeakGCMap::uncheckedGet):
              (JSC::WeakGCMap::isValid):
              (JSC::::get):
              (JSC::::take):
              (JSC::::set):
              (JSC::::uncheckedRemove):
              * runtime/WriteBarrier.h: Removed.
      2011-01-30  Csaba Osztrogonác  <ossy@webkit.org>
      
              Unreviewed, rolling out r77098, r77099, r77100, r77109, and
              r77111.
              http://trac.webkit.org/changeset/77098
              http://trac.webkit.org/changeset/77099
              http://trac.webkit.org/changeset/77100
              http://trac.webkit.org/changeset/77109
              http://trac.webkit.org/changeset/77111
              https://bugs.webkit.org/show_bug.cgi?id=53219
      
              Qt build is broken
      
              * JSValueWrapper.cpp:
              (JSValueWrapper::JSObjectMark):
      2011-01-30  Csaba Osztrogonác  <ossy@webkit.org>
      
              Unreviewed, rolling out r77098, r77099, r77100, r77109, and
              r77111.
              http://trac.webkit.org/changeset/77098
              http://trac.webkit.org/changeset/77099
              http://trac.webkit.org/changeset/77100
              http://trac.webkit.org/changeset/77109
              http://trac.webkit.org/changeset/77111
              https://bugs.webkit.org/show_bug.cgi?id=53219
      
              Qt build is broken
      
              * ForwardingHeaders/runtime/WriteBarrier.h: Removed.
              * WebCore.exp.in:
              * bindings/js/DOMWrapperWorld.h:
              * bindings/js/JSAudioConstructor.cpp:
              (WebCore::JSAudioConstructor::JSAudioConstructor):
              * bindings/js/JSDOMBinding.cpp:
              (WebCore::markDOMNodesForDocument):
              (WebCore::markDOMObjectWrapper):
              (WebCore::markDOMNodeWrapper):
              * bindings/js/JSDOMGlobalObject.cpp:
              (WebCore::JSDOMGlobalObject::markChildren):
              (WebCore::JSDOMGlobalObject::setInjectedScript):
              (WebCore::JSDOMGlobalObject::injectedScript):
              * bindings/js/JSDOMGlobalObject.h:
              (WebCore::JSDOMGlobalObject::JSDOMGlobalObjectData::JSDOMGlobalObjectData):
              (WebCore::getDOMConstructor):
              * bindings/js/JSDOMWindowCustom.cpp:
              (WebCore::JSDOMWindow::setLocation):
              (WebCore::DialogHandler::dialogCreated):
              * bindings/js/JSDOMWindowShell.cpp:
              (WebCore::JSDOMWindowShell::JSDOMWindowShell):
              (WebCore::JSDOMWindowShell::setWindow):
              (WebCore::JSDOMWindowShell::markChildren):
              (WebCore::JSDOMWindowShell::unwrappedObject):
              * bindings/js/JSDOMWindowShell.h:
              (WebCore::JSDOMWindowShell::window):
              (WebCore::JSDOMWindowShell::setWindow):
              * bindings/js/JSDeviceMotionEventCustom.cpp:
              (WebCore::createAccelerationObject):
              (WebCore::createRotationRateObject):
              * bindings/js/JSEventListener.cpp:
              (WebCore::JSEventListener::JSEventListener):
              (WebCore::JSEventListener::markJSFunction):
              * bindings/js/JSEventListener.h:
              (WebCore::JSEventListener::jsFunction):
              * bindings/js/JSHTMLDocumentCustom.cpp:
              (WebCore::JSHTMLDocument::setAll):
              * bindings/js/JSImageConstructor.cpp:
              (WebCore::JSImageConstructor::JSImageConstructor):
              * bindings/js/JSImageDataCustom.cpp:
              (WebCore::toJS):
              * bindings/js/JSJavaScriptCallFrameCustom.cpp:
              (WebCore::JSJavaScriptCallFrame::scopeChain):
              (WebCore::JSJavaScriptCallFrame::scopeType):
              * bindings/js/JSNodeFilterCondition.cpp:
              (WebCore::JSNodeFilterCondition::markAggregate):
              (WebCore::JSNodeFilterCondition::acceptNode):
              * bindings/js/JSNodeFilterCondition.h:
              * bindings/js/JSNodeFilterCustom.cpp:
              * bindings/js/JSOptionConstructor.cpp:
              (WebCore::JSOptionConstructor::JSOptionConstructor):
              * bindings/js/JSSQLResultSetRowListCustom.cpp:
              (WebCore::JSSQLResultSetRowList::item):
              * bindings/js/ScriptCachedFrameData.cpp:
              (WebCore::ScriptCachedFrameData::restore):
              * bindings/js/ScriptObject.cpp:
              (WebCore::ScriptGlobalObject::set):
              * bindings/js/SerializedScriptValue.cpp:
              (WebCore::CloneDeserializer::putProperty):
              * bindings/scripts/CodeGeneratorJS.pm:
              * bridge/qt/qt_instance.cpp:
              (JSC::Bindings::QtInstance::QtInstance):
              (JSC::Bindings::QtInstance::removeCachedMethod):
              (JSC::Bindings::QtInstance::markAggregate):
              * bridge/qt/qt_instance.h:
              * bridge/qt/qt_runtime.cpp:
              (JSC::Bindings::QtRuntimeMetaMethod::QtRuntimeMetaMethod):
              (JSC::Bindings::QtRuntimeMetaMethod::markChildren):
              (JSC::Bindings::QtRuntimeMetaMethod::connectGetter):
              (JSC::Bindings::QtRuntimeMetaMethod::disconnectGetter):
              * bridge/qt/qt_runtime.h:
              * bridge/runtime_root.cpp:
              (JSC::Bindings::RootObject::invalidate):
              * bridge/runtime_root.h:
              * dom/Document.h:
      2011-01-30  Csaba Osztrogonác  <ossy@webkit.org>
      
              Unreviewed, rolling out r77098, r77099, r77100, r77109, and
              r77111.
              http://trac.webkit.org/changeset/77098
              http://trac.webkit.org/changeset/77099
              http://trac.webkit.org/changeset/77100
              http://trac.webkit.org/changeset/77109
              http://trac.webkit.org/changeset/77111
              https://bugs.webkit.org/show_bug.cgi?id=53219
      
              Qt build is broken
      
              * WebView/WebScriptDebugDelegate.mm:
              (-[WebScriptCallFrame scopeChain]):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77113 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ad0e9df1
    • simon.fraser@apple.com's avatar
      2011-01-30 Sheriff Bot <webkit.review.bot@gmail.com> · 60341277
      simon.fraser@apple.com authored
              Unreviewed, rolling out r77107.
              http://trac.webkit.org/changeset/77107
              https://bugs.webkit.org/show_bug.cgi?id=53412
      
              Caused 5 new form-related test crashes (Requested by smfr on
              #webkit).
      
              * css/CSSSelector.cpp:
              (WebCore::CSSSelector::pseudoId):
              (WebCore::nameToPseudoTypeMap):
              (WebCore::CSSSelector::extractPseudoType):
              * css/CSSSelector.h:
              * html/HTMLProgressElement.cpp:
              (WebCore::HTMLProgressElement::parseMappedAttribute):
              (WebCore::HTMLProgressElement::attach):
              * html/HTMLProgressElement.h:
              * rendering/RenderProgress.cpp:
              (WebCore::RenderProgress::~RenderProgress):
              (WebCore::RenderProgress::updateFromElement):
              (WebCore::RenderProgress::layoutParts):
              (WebCore::RenderProgress::shouldHaveParts):
              * rendering/RenderProgress.h:
              * rendering/style/RenderStyleConstants.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77112 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      60341277
    • simon.fraser@apple.com's avatar
      2011-01-30 Simon Fraser <simon.fraser@apple.com> · 9131cbe1
      simon.fraser@apple.com authored
              Build fix the build fix. I assume Oliver meant m_cell, not m_value.
      
              * runtime/WriteBarrier.h:
              (JSC::WriteBarrierBase::clear):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77111 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9131cbe1
    • simon.fraser@apple.com's avatar
      2011-01-30 Simon Fraser <simon.fraser@apple.com> · 36a7cc24
      simon.fraser@apple.com authored
              Reviewed by Sam Weinig.
      
              Enhance ShadowBlur to render inset box shadows
              https://bugs.webkit.org/show_bug.cgi?id=51567
      
              Use ShadowBlur for inset box-shadows with CG. It
              currently lacks a tiled version, but is still much
              faster than CG shadows.
      
              Test: fast/box-shadow/inset-box-shadow-radius.html
      
              * platform/graphics/ShadowBlur.cpp:
              * platform/graphics/ShadowBlur.h: New method for inset
              shadows.
              (WebCore::ShadowBlur::drawInsetShadow):
      
              * platform/graphics/GraphicsContext.cpp: #ifdef out
              fillRectWithRoundedHole() for CG.
      
              * platform/graphics/cg/GraphicsContextCG.cpp:
              (WebCore::GraphicsContext::fillRectWithRoundedHole): If there's
              a shadow with a radius > 0, use ShadowBlur.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77110 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      36a7cc24
    • oliver@apple.com's avatar
      More Qt build fixes · e728a61c
      oliver@apple.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77109 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e728a61c
    • kbr@google.com's avatar
      2011-01-28 Kenneth Russell <kbr@google.com> · bb1c5656
      kbr@google.com authored
              Reviewed by Chris Marrin.
      
              WebGL shows PNG Textures with indexed colors too dark
              https://bugs.webkit.org/show_bug.cgi?id=47477
      
              Added test case for upload of indexed PNG images to
              gl-teximage.html in the Khronos WebGL conformance tests.
              Synchronized this test with the Khronos repository.
      
              * fast/canvas/webgl/gl-teximage-expected.txt:
              * fast/canvas/webgl/gl-teximage.html:
              * fast/canvas/webgl/resources/red-indexed.png: Added.
      2011-01-28  Kenneth Russell  <kbr@google.com>
      
              Reviewed by Chris Marrin.
      
              WebGL shows PNG Textures with indexed colors too dark
              https://bugs.webkit.org/show_bug.cgi?id=47477
      
              Properly handle indexed PNG images by re-rendering them as RGBA
              images before upload. Verified with this layout test and the test
              cases from bugs 47477 and 53269.
      
              * platform/graphics/cg/GraphicsContext3DCG.cpp:
              (WebCore::GraphicsContext3D::getImageData):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77108 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bb1c5656
    • morrita@google.com's avatar
      2011-01-27 MORITA Hajime <morrita@google.com> · 45c6a5f4
      morrita@google.com authored
              Reviewed by Dimitri Glazkov.
      
              Convert <progress> shadow DOM to a DOM-based shadow.
              https://bugs.webkit.org/show_bug.cgi?id=50660
      
              * Removed RenderProgress::m_valuePart, moved the shadow node
                to the shadow root of HTMLProgressElement.
              * Removed hard-coded pseudo ID for -webkit-progress-bar-value.
                ProgressBarValueElement is defined only for overriding
                shadowPseudoId().
      
              No new tests. No behavioral change.
      
              * css/CSSSelector.cpp:
              (WebCore::CSSSelector::pseudoId):
              (WebCore::nameToPseudoTypeMap):
              (WebCore::CSSSelector::extractPseudoType):
              * css/CSSSelector.h:
              * html/HTMLProgressElement.cpp:
              (WebCore::ProgressBarValueElement::ProgressBarValueElement):
              (WebCore::ProgressBarValueElement::shadowPseudoId):
              (WebCore::ProgressBarValueElement::create):
              (WebCore::HTMLProgressElement::parseMappedAttribute):
              (WebCore::HTMLProgressElement::attach):
              (WebCore::HTMLProgressElement::valuePart):
              (WebCore::HTMLProgressElement::didElementStateChange):
              (WebCore::HTMLProgressElement::createShadowSubtreeIfNeeded):
              * html/HTMLProgressElement.h:
              * rendering/RenderProgress.cpp:
              (WebCore::RenderProgress::~RenderProgress):
              (WebCore::RenderProgress::updateFromElement):
              (WebCore::RenderProgress::layoutParts):
              (WebCore::RenderProgress::shouldHaveParts):
              (WebCore::RenderProgress::valuePart):
              * rendering/RenderProgress.h:
              * rendering/style/RenderStyleConstants.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77107 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      45c6a5f4
    • simon.fraser@apple.com's avatar
      2011-01-30 Simon Fraser <simon.fraser@apple.com> · 33875137
      simon.fraser@apple.com authored
              Reviewed by Ariya Hidayat.
      
              Enhance ShadowBlur to render inset box shadows; Part 1.
              https://bugs.webkit.org/show_bug.cgi?id=51567
      
              Add a new method to GraphicsContext to render a rect with a rounded hole,
              for use by inset box-shadow code. Knowledge that we're rendering a rounded
              hole will enable ShadowBlur to be used here in future.
      
              * platform/graphics/GraphicsContext.cpp:
              (WebCore::GraphicsContext::fillRectWithRoundedHole):
              * platform/graphics/GraphicsContext.h:
              * rendering/RenderBoxModelObject.cpp:
              (WebCore::RenderBoxModelObject::paintBoxShadow):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77106 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      33875137
    • morrita@google.com's avatar
      2011-01-23 MORITA Hajime <morrita@google.com> · 2d33a85b
      morrita@google.com authored
              Reviewed by Eric Seidel.
      
              REGRESSION: Inset shadow with too large border radius misses rounded corner.
              https://bugs.webkit.org/show_bug.cgi?id=52800
      
              * fast/box-shadow/inset-with-extraordinary-radii-and-border.html: Added.
              * platform/mac/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.checksum: Added.
              * platform/mac/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.png: Added.
              * platform/mac/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.txt: Added.
      2011-01-23  MORITA Hajime  <morrita@google.com>
      
              Reviewed by Eric Seidel.
      
              REGRESSION: Inset shadow with too large border radius misses rounded corner.
              https://bugs.webkit.org/show_bug.cgi?id=52800
      
              The refactoring on r76083 broke the invariant between border
              IntRect and its radii because RoundedIntRect::setRect() is called
              after getRoundedInnerBorderWithBorderWidths(), which enforces the
              invariant. Th rounded-rect clipping code verifies the invariant,
              and discard the invalid radii, that results broken paintings.
      
              This change moved setRect() before
              getRoundedInnerBorderWithBorderWidths() not to modify the valid
              RoundedIntRect value.
      
              Test: fast/box-shadow/inset-with-extraordinary-radii-and-border.html
      
              * rendering/RenderBoxModelObject.cpp:
              (WebCore::RenderBoxModelObject::paintBoxShadow):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77105 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2d33a85b
    • ggaren@apple.com's avatar
      2011-01-30 Geoffrey Garen <ggaren@apple.com> · 3d2ff16f
      ggaren@apple.com authored
              Reviewed by Sam Weinig.
      
              [Take 2!]
              Fixed crash on window close (maybe crash on launch?) due to missing frame null checks
              https://bugs.webkit.org/show_bug.cgi?id=53408
      
              * UIProcess/WebContext.cpp:
              (WebKit::WebContext::didNavigateWithNavigationData):
              (WebKit::WebContext::didPerformClientRedirect):
              (WebKit::WebContext::didPerformServerRedirect):
              (WebKit::WebContext::didUpdateHistoryTitle): Use MESSAGE_CHECK because
              we don't think we should be able to reach this state under normal conditions.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77104 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3d2ff16f
    • simon.fraser@apple.com's avatar
      2011-01-30 Simon Fraser <simon.fraser@apple.com> · e33f672b
      simon.fraser@apple.com authored
              Attempt to fix Windows build by adding ShadowBlur.cpp/h to the
              vcproj.
      
              * WebCore.vcproj/WebCore.vcproj:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77103 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e33f672b
    • ggaren@apple.com's avatar
      2011-01-30 Geoffrey Garen <ggaren@apple.com> · d2f61674
      ggaren@apple.com authored
              Reviewed by Maciej Stachowiak.
      
              Fixed crash on window close (maybe crash on launch?) due to missing
              frame null checks
              https://bugs.webkit.org/show_bug.cgi?id=53408
      
              * UIProcess/WebContext.cpp:
              (WebKit::WebContext::didNavigateWithNavigationData):
              (WebKit::WebContext::didPerformClientRedirect):
              (WebKit::WebContext::didPerformServerRedirect):
              (WebKit::WebContext::didUpdateHistoryTitle): Check for NULL, since we're
              calling a function that can return it.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77102 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d2f61674
    • simon.fraser@apple.com's avatar
      2011-01-30 Simon Fraser <simon.fraser@apple.com> · 9d92cc2a
      simon.fraser@apple.com authored
              Reviewed by Dan Bernstein.
      
              -webkit-box-shadow causes awful scroll/resize/redraw performance
              https://bugs.webkit.org/show_bug.cgi?id=22102
      
              Use ShadowBlur for CG, whe rendering shadows on rects and
              rounded rects outside of canvas.
      
              CG shadows with a radius of more than 8px do not render
              correctly. We preserve this incorrect rendering by compensating
              for it when rending -webkit-box-shadow. Calls that should use
              this deprecated radius behavior now use setLegacyShadow().
      
              Test: fast/box-shadow/box-shadow-transformed.html
      
              * html/canvas/CanvasRenderingContext2D.cpp: Use setLegacyShadow()
              for canvas, to indicate that it should use the deprecated radius
              behavior.
              (WebCore::CanvasRenderingContext2D::setAllAttributesToDefault): Ditto.
              (WebCore::CanvasRenderingContext2D::setShadow): Ditto.
              (WebCore::CanvasRenderingContext2D::applyShadow): Ditto.
      
              * platform/graphics/GraphicsContext.cpp:
              (WebCore::GraphicsContext::setLegacyShadow): Set the m_state.shadowsUseLegacyRadius bit.
      
              * platform/graphics/GraphicsContext.h:
              (WebCore::GraphicsContextState::GraphicsContextState): Add a
              shadowsUseLegacyRadius bit to the state.
      
              * platform/graphics/cg/GraphicsContextCG.cpp:
              (WebCore::radiusToLegacyRadius): Map from the actual radius to one
              that approximates CG behavior.
              (WebCore::hasBlurredShadow): Helper that returns true if we have a shadow
              with a non-zero blur radius.
              (WebCore::GraphicsContext::fillRect): Use ShadowBlur if not canvas.
              (WebCore::GraphicsContext::fillRoundedRect): Ditto.
              (WebCore::GraphicsContext::setPlatformShadow): Comment.
      
              * rendering/RenderBoxModelObject.cpp:
              (WebCore::RenderBoxModelObject::paintBoxShadow): Call setLegacyShadow()
              for -webkit-box-shadow.
      
              * platform/graphics/ShadowBlur.cpp:
              (WebCore::ShadowBlur::calculateLayerBoundingRect): Fix some pixel crack issues
              by rounding up the blur radius.
              (WebCore::ShadowBlur::drawRectShadow): Ditto
              (WebCore::ShadowBlur::drawRectShadowWithTiling): Ditto.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77101 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9d92cc2a