- 31 Jan, 2011 27 commits
-
-
inferno@chromium.org authored
Reviewed by Eric Seidel. Tests for crash when cloning elements that reference counter nodes. https://bugs.webkit.org/show_bug.cgi?id=53344 * http/tests/css/counter-crash-expected.txt: Added. * http/tests/css/counter-crash.html: Added. * http/tests/css/resources/counter-crash-frame-src.html: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77142 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
inferno@chromium.org authored
Reviewed by Dave Hyatt. Tests that we do not crash when adding a child in a table where the before child is not a table section. https://bugs.webkit.org/show_bug.cgi?id=53276 * fast/table/before-child-non-table-section-add-table-crash-expected.txt: Added. * fast/table/before-child-non-table-section-add-table-crash.html: Added. 2011-01-27 Abhishek Arya <inferno@chromium.org> Reviewed by Dave Hyatt. If beforeChild is wrapped in an anonymous table section, we need to go the parent to find it and use it before adding childs to table. https://bugs.webkit.org/show_bug.cgi?id=53276 We need to make sure that beforeChild's parent is "this" before calling RenderBox::addChild. The previous condition in while is too restrictive and fails to calculate the right beforeChild value when its display style is table caption. Test: fast/table/before-child-non-table-section-add-table-crash.html * rendering/RenderTable.cpp: (WebCore::RenderTable::addChild): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77141 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
commit-queue@webkit.org authored
Reviewed by Simon Fraser. AffineTransform::translateRight incorrectly computes a translateLeft. https://bugs.webkit.org/show_bug.cgi?id=52551 Removed translateRight and converted all uses to perform standard matrix multiplication. No new tests because patch doesn't modify functionality. * platform/graphics/transforms/AffineTransform.cpp: * platform/graphics/transforms/AffineTransform.h: (WebCore::AffineTransform::translation): * rendering/svg/RenderSVGResourceMarker.cpp: (WebCore::RenderSVGResourceMarker::localToParentTransform): * rendering/svg/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::localToRepaintContainerTransform): (WebCore::RenderSVGRoot::localToParentTransform): * rendering/svg/RenderSVGViewportContainer.cpp: (WebCore::RenderSVGViewportContainer::localToParentTransform): * rendering/svg/SVGTextLayoutEngine.cpp: (WebCore::SVGTextLayoutEngine::finalizeTransformMatrices): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77140 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
andersca@apple.com authored
Reviewed by Adam Roben. Make LayerTreeHost an abstract base class and make LayerTreeHostMac inherit from it https://bugs.webkit.org/show_bug.cgi?id=53432 * WebKit2.xcodeproj/project.pbxproj: Add LayerTreeHostMac.h. * WebProcess/WebPage/DrawingAreaImpl.cpp: * WebProcess/WebPage/DrawingAreaImpl.h: Make m_layerTreeHost an OwnPtr and initialize/destroy it appropriately. * WebProcess/WebPage/LayerTreeHost.cpp: (WebKit::LayerTreeHost::create): On Mac, create a LayerTreeHostMac instance. (WebKit::LayerTreeHost::~LayerTreeHost): No need to call platformInvalidate anymore. * WebProcess/WebPage/LayerTreeHost.h: * WebProcess/WebPage/mac/LayerTreeHostMac.h: Added. * WebProcess/WebPage/mac/LayerTreeHostMac.mm: (WebKit::LayerTreeHostMac::~LayerTreeHostMac): Invalidate the run loop observer here instead of in platformInvalidate. (WebKit::LayerTreeHostMac::scheduleLayerFlush): (WebKit::LayerTreeHostMac::flushPendingLayerChangesRunLoopObserverCallback): These are now members of LayerTreeHostMac. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77139 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
tony@chromium.org authored
Reviewed by Eric Seidel. mac DRT should report RTL scroll offset relative to top right corner https://bugs.webkit.org/show_bug.cgi?id=53324 Remove scroll offsets since these are at the origin. * platform/mac/fast/block/basic/truncation-rtl-expected.txt: * platform/mac/fast/blockflow/Kusa-Makura-background-canvas-expected.txt: * platform/mac/fast/multicol/vertical-rl/column-break-with-balancing-expected.txt: * platform/mac/fast/multicol/vertical-rl/float-paginate-complex-expected.txt: 2011-01-31 Tony Chang <tony@chromium.org> Reviewed by Eric Seidel. mac DRT should report RTL scroll offset relative to top right corner https://bugs.webkit.org/show_bug.cgi?id=53324 * DumpRenderTree/mac/DumpRenderTree.mm: (dumpFrameScrollPosition): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77138 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
mario@webkit.org authored
Reviewed by Martin Robinson. [Gtk] atk_text_set_caret_offset returns True even when it is unsuccessful https://bugs.webkit.org/show_bug.cgi?id=53389 Return FALSE when not able to set the caret at the specified offset. * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_text_set_caret_offset): Return FALSE when the range created is NULL and adjust offset to account for list markers. 2011-01-31 Mario Sanchez Prada <msanchez@igalia.com> Reviewed by Martin Robinson. [Gtk] atk_text_set_caret_offset returns True even when it is unsuccessful https://bugs.webkit.org/show_bug.cgi?id=53389 New unit test to check the fix for this bug. * tests/testatk.c: (testWebkitAtkCaretOffsets): New. (main): Add new test. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77137 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
yurys@chromium.org authored
Unreviewed. Mark some tests as having wrong image results on Mac. * platform/chromium/test_expectations.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77136 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
ager@chromium.org authored
Reviewed by Pavel Feldman. [V8] Update V8 specific layout test expectations https://bugs.webkit.org/show_bug.cgi?id=53423 Error formatting has changed in V8. Updating chromium specific layout test expectations accordingly. * platform/chromium-mac/fast/js/array-every-expected.txt: * platform/chromium-mac/fast/js/instance-of-immediates-expected.txt: * platform/chromium-mac/fast/js/property-getters-and-setters-expected.txt: * platform/chromium-mac/storage/transaction-error-callback-expected.txt: * platform/chromium-mac/svg/dom/svgpath-out-of-bounds-getPathSeg-expected.txt: * platform/chromium-win/fast/js/array-every-expected.txt: * platform/chromium-win/fast/js/instance-of-immediates-expected.txt: * platform/chromium-win/fast/js/property-getters-and-setters-expected.txt: * platform/chromium-win/storage/transaction-error-callback-expected.txt: * platform/chromium-win/svg/dom/svgpath-out-of-bounds-getPathSeg-expected.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77135 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
alex@webkit.org authored
Unreviewed skipped favicon-as-image.html test, it is flaky and it was unskipped after r76555. * platform/gtk/Skipped: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77134 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
simon.fraser@apple.com authored
Update a pixel resuls after r77101. * platform/mac/fast/css/color-correction-on-box-shadow-expected.checksum: * platform/mac/fast/css/color-correction-on-box-shadow-expected.png: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77132 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
yurys@chromium.org authored
Unreviewed. Update Chromium test expectations. * platform/chromium-mac/fast/css/color-correction-on-box-shadow-expected.checksum: Added. * platform/chromium-mac/fast/css/color-correction-on-box-shadow-expected.png: Added. * platform/chromium-mac/fast/transforms/shadows-expected.checksum: * platform/chromium-mac/fast/transforms/shadows-expected.png: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77131 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
zoltan@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=53422 Reviewed by Andreas Kling. Add Take Screen Shot action to MiniBrowser's view menu. * MiniBrowser/qt/BrowserWindow.cpp: (BrowserWindow::BrowserWindow): (BrowserWindow::screenshot): * MiniBrowser/qt/BrowserWindow.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77130 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
kbr@google.com authored
Unreviewed, test and expectations update. Stop reporting the precise pixel value for tests that are supposed to be within a certain range. Remove now-unneeded Chromium expectations. * fast/canvas/webgl/gl-teximage-expected.txt: * fast/canvas/webgl/gl-teximage.html: * platform/chromium-linux/fast/canvas/webgl/gl-teximage-expected.txt: Removed. * platform/chromium-mac/fast/canvas/webgl/gl-teximage-expected.txt: Removed. * platform/chromium-win/fast/canvas/webgl/gl-teximage-expected.txt: Removed. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77129 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
pfeldman@chromium.org authored
Reviewed by Yury Semikhatsky. Web Inspector: copy HAR to clipboard instead of saving blob on export. https://bugs.webkit.org/show_bug.cgi?id=53328 * inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel.prototype._exportAll): (WebInspector.NetworkPanel.prototype._exportResource): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77128 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
pfeldman@chromium.org authored
Reviewed by Timothy Hatcher. Web Inspector: speed up network panel rendering. https://bugs.webkit.org/show_bug.cgi?id=53397 * inspector/front-end/DataGrid.js: (WebInspector.DataGrid.prototype.get scrollContainer): * inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel.prototype.elementsToRestoreScrollPositionsFor): (WebInspector.NetworkPanel.prototype._positionSummaryBar): (WebInspector.NetworkPanel.prototype._createTable): (WebInspector.NetworkPanel.prototype._exportResource): (WebInspector.NetworkPanel.prototype._onScroll): * inspector/front-end/networkPanel.css: (.network-sidebar .data-grid.small tr.offscreen): (.network-sidebar .data-grid tr.offscreen): (.network-sidebar .data-grid tr.offscreen td): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77127 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
pvarga@webkit.org authored
Reviewed by Andreas Kling. Remove wrec from WebCore https://bugs.webkit.org/show_bug.cgi?id=53298 No new tests needed. * Android.jscbindings.mk: * ForwardingHeaders/wrec/WREC.h: Removed. * WebCore.vcproj/WebCore.vcproj: * WebCore.vcproj/copyForwardingHeaders.cmd: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77126 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
commit-queue@webkit.org authored
Unreviewed, rolling out r76969. http://trac.webkit.org/changeset/76969 https://bugs.webkit.org/show_bug.cgi?id=53418 "It is causing crashes in GTK+ and Leopard bots" (Requested by alexg__ on #webkit). * runtime/WeakGCMap.h: 2011-01-31 Sheriff Bot <webkit.review.bot@gmail.com> Unreviewed, rolling out r76969. http://trac.webkit.org/changeset/76969 https://bugs.webkit.org/show_bug.cgi?id=53418 "It is causing crashes in GTK+ and Leopard bots" (Requested by alexg__ on #webkit). * bridge/runtime_root.cpp: (JSC::Bindings::RootObject::invalidate): (JSC::Bindings::RootObject::addRuntimeObject): (JSC::Bindings::RootObject::removeRuntimeObject): * bridge/runtime_root.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77125 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
yurys@chromium.org authored
Unreviewed. Update Chromium test expectations. * platform/chromium-mac/fast/blockflow/box-shadow-horizontal-bt-expected.checksum: Added. * platform/chromium-mac/fast/blockflow/box-shadow-horizontal-bt-expected.png: Added. * platform/chromium-mac/fast/blockflow/box-shadow-vertical-lr-expected.checksum: Added. * platform/chromium-mac/fast/blockflow/box-shadow-vertical-lr-expected.png: Added. * platform/chromium-mac/fast/blockflow/box-shadow-vertical-rl-expected.checksum: Added. * platform/chromium-mac/fast/blockflow/box-shadow-vertical-rl-expected.png: Added. * platform/chromium-mac/fast/borders/border-radius-split-inline-expected.checksum: Added. * platform/chromium-mac/fast/borders/border-radius-split-inline-expected.png: Added. * platform/chromium-mac/fast/box-shadow/box-shadow-transformed-expected.checksum: Added. * platform/chromium-mac/fast/box-shadow/box-shadow-transformed-expected.png: Added. * platform/chromium-mac/fast/repaint/box-shadow-h-expected.checksum: * platform/chromium-mac/fast/repaint/box-shadow-h-expected.png: * platform/chromium-mac/fast/repaint/box-shadow-v-expected.checksum: Added. * platform/chromium-mac/fast/repaint/box-shadow-v-expected.png: Added. * platform/chromium-mac/fast/repaint/gradients-em-stops-repaint-expected.checksum: Added. * platform/chromium-mac/fast/repaint/gradients-em-stops-repaint-expected.png: Added. * platform/chromium-mac/fast/repaint/shadow-multiple-strict-horizontal-expected.checksum: Removed. * platform/chromium-mac/fast/repaint/shadow-multiple-strict-horizontal-expected.png: Removed. * platform/chromium-mac/fast/repaint/shadow-multiple-strict-vertical-expected.checksum: Removed. * platform/chromium-mac/fast/repaint/shadow-multiple-strict-vertical-expected.png: Removed. * platform/chromium-mac/fast/transforms/shadows-expected.checksum: Added. * platform/chromium-mac/fast/transforms/shadows-expected.png: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77124 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
kov@webkit.org authored
Reviewed by Xan Lopez. [GTK] REGRESSION: http/tests/media/video-{cookie,referer}.html failing https://bugs.webkit.org/show_bug.cgi?id=53379 Remove left over mentions of HAVE_SOUP_2_29_90, and apply the dependency on newer soup to efl as well. * Source/cmake/OptionsEfl.cmake: 2011-01-31 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> Reviewed by Xan Lopez. [GTK] REGRESSION: http/tests/media/video-{cookie,referer}.html failing https://bugs.webkit.org/show_bug.cgi?id=53379 Unskip tests that pass again. * platform/gtk/Skipped: 2011-01-31 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> Reviewed by Xan Lopez. [GTK] REGRESSION: http/tests/media/video-{cookie,referer}.html failing https://bugs.webkit.org/show_bug.cgi?id=53379 Remove left over #ifdef's. I thought all of the conditional code had been freed from the condition, but I forgot to check DRT. * DumpRenderTree/gtk/DumpRenderTree.cpp: (resetDefaultsToConsistentValues): * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setAlwaysAcceptCookies): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77123 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
antti@apple.com authored
Spelling. * css/CSSSelectorList.h: (WebCore::CSSSelectorList::next): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77121 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
yurys@chromium.org authored
Unreviewed. Update Chromium test expectations after r77108 * platform/chromium-linux/fast/canvas/webgl/gl-teximage-expected.txt: Added. * platform/chromium-mac/fast/canvas/webgl/gl-teximage-expected.txt: Added. * platform/chromium-win/fast/canvas/webgl/gl-teximage-expected.txt: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77120 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
yurys@chromium.org authored
Unreviewed. Fix Chromium compilation on Linux. * platform/graphics/ShadowBlur.cpp: added PLATFORM(CHROMIUM) guard * platform/graphics/ShadowBlur.h: added missing ColorSpace.h header include git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77119 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
yurys@chromium.org authored
Unreviewed. Fix Chromium compilation on Mac broken by r77101. * WebCore.gypi: add ShadowBlur.{h,cpp} to the gypi file. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77118 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
yurys@chromium.org authored
Unreviewed. Update Chromium test expectations after r77101 * platform/chromium-linux/fast/box-shadow/box-shadow-transformed-expected.checksum: Added. * platform/chromium-linux/fast/box-shadow/box-shadow-transformed-expected.png: Added. * platform/chromium-linux/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.checksum: Added. * platform/chromium-linux/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.png: Added. * platform/chromium-win/fast/box-shadow/box-shadow-radius-expected.checksum: Added. * platform/chromium-win/fast/box-shadow/box-shadow-radius-expected.png: Added. * platform/chromium-win/fast/box-shadow/box-shadow-radius-expected.txt: Added. * platform/chromium-win/fast/box-shadow/box-shadow-transformed-expected.checksum: Added. * platform/chromium-win/fast/box-shadow/box-shadow-transformed-expected.png: Added. * platform/chromium-win/fast/box-shadow/box-shadow-transformed-expected.txt: Added. * platform/chromium-win/fast/box-shadow/inset-box-shadow-radius-expected.checksum: Added. * platform/chromium-win/fast/box-shadow/inset-box-shadow-radius-expected.png: Added. * platform/chromium-win/fast/box-shadow/inset-box-shadow-radius-expected.txt: Added. * platform/chromium-win/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.checksum: Added. * platform/chromium-win/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.png: Added. * platform/chromium-win/fast/repaint/gradients-em-stops-repaint-expected.txt: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77117 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
mnaganov@chromium.org authored
Reviewed by Yury Semikhatsky. WebInspector: Change button title from "Clear CPU profiles" to "Clear all profiles". https://bugs.webkit.org/show_bug.cgi?id=53309 * English.lproj/localizedStrings.js: * inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77116 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
carlosgc@webkit.org authored
Unreviewed, fix the build with current GTK+ 3.x. * plugins/gtk/gtk2xtbin.c: * plugins/gtk/gtk2xtbin.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77115 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
tkent@chromium.org authored
Reviewed by Kent Tamura. Dangling form associated elements should not be registered on the document https://bugs.webkit.org/show_bug.cgi?id=53223 Adds insertedIntoDocument() and remvoedFromDocument() to FormAssociatedElement class to register the element on the document if and only if it actually inserted into (removed from) the document. Test: fast/forms/dangling-form-element-crash.html * html/FormAssociatedElement.cpp: (WebCore::FormAssociatedElement::insertedIntoDocument): Added. (WebCore::FormAssociatedElement::removedFromDocument): Ditto. (WebCore::FormAssociatedElement::insertedIntoTree): Don't register the element to a document. (WebCore::FormAssociatedElement::removedFromTree): Don't unregister the element from a document. * html/FormAssociatedElement.h: * html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::insertedIntoDocument): Added. (WebCore::HTMLFormControlElement::removedFromDocument): Ditto. * html/HTMLFormControlElement.h: * html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::insertedIntoDocument): Calls FormAssociatedElement::insertedIntoDocument(). (WebCore::HTMLObjectElement::removedFromDocument): Calls FormAssociatedElement::removedFromDocument(). 2011-01-30 Kenichi Ishibashi <bashi@google.com> Reviewed by Kent Tamura. Dangling form associated elements should not be registered on the document https://bugs.webkit.org/show_bug.cgi?id=53223 Adds a test that ensures dangling form associated elements are not registered on the document. * fast/forms/dangling-form-element-crash-expected.txt: Added. * fast/forms/dangling-form-element-crash.html: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77114 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
- 30 Jan, 2011 13 commits
-
-
ossy@webkit.org authored
Unreviewed, rolling out r77098, r77099, r77100, r77109, and r77111. http://trac.webkit.org/changeset/77098 http://trac.webkit.org/changeset/77099 http://trac.webkit.org/changeset/77100 http://trac.webkit.org/changeset/77109 http://trac.webkit.org/changeset/77111 https://bugs.webkit.org/show_bug.cgi?id=53219 Qt build is broken * API/JSCallbackObject.h: (JSC::JSCallbackObjectData::setPrivateProperty): (JSC::JSCallbackObjectData::JSPrivatePropertyMap::getPrivateProperty): (JSC::JSCallbackObjectData::JSPrivatePropertyMap::setPrivateProperty): (JSC::JSCallbackObjectData::JSPrivatePropertyMap::markChildren): (JSC::JSCallbackObject::setPrivateProperty): * API/JSCallbackObjectFunctions.h: (JSC::::put): (JSC::::staticFunctionGetter): * API/JSObjectRef.cpp: (JSObjectMakeConstructor): (JSObjectSetPrivateProperty): * API/JSWeakObjectMapRefInternal.h: * JavaScriptCore.exp: * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: * JavaScriptCore.xcodeproj/project.pbxproj: * bytecode/CodeBlock.cpp: (JSC::CodeBlock::markAggregate): * bytecode/CodeBlock.h: (JSC::CodeBlock::globalObject): * bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::BytecodeGenerator): (JSC::BytecodeGenerator::emitJumpIfNotFunctionCall): (JSC::BytecodeGenerator::emitJumpIfNotFunctionApply): (JSC::BytecodeGenerator::findScopedProperty): * debugger/Debugger.cpp: (JSC::evaluateInGlobalCallFrame): * debugger/DebuggerActivation.cpp: (JSC::DebuggerActivation::DebuggerActivation): (JSC::DebuggerActivation::markChildren): * debugger/DebuggerActivation.h: * debugger/DebuggerCallFrame.cpp: (JSC::DebuggerCallFrame::evaluate): * interpreter/CallFrame.h: (JSC::ExecState::exception): * interpreter/Interpreter.cpp: (JSC::Interpreter::resolve): (JSC::Interpreter::resolveSkip): (JSC::Interpreter::resolveGlobal): (JSC::Interpreter::resolveGlobalDynamic): (JSC::Interpreter::resolveBaseAndProperty): (JSC::Interpreter::unwindCallFrame): (JSC::appendSourceToError): (JSC::Interpreter::execute): (JSC::Interpreter::tryCacheGetByID): (JSC::Interpreter::privateExecute): * jit/JITStubs.cpp: (JSC::JITThunks::tryCacheGetByID): (JSC::DEFINE_STUB_FUNCTION): * jsc.cpp: (GlobalObject::GlobalObject): * runtime/ArgList.cpp: (JSC::MarkedArgumentBuffer::markLists): * runtime/Arguments.cpp: (JSC::Arguments::markChildren): (JSC::Arguments::getOwnPropertySlot): (JSC::Arguments::getOwnPropertyDescriptor): (JSC::Arguments::put): * runtime/Arguments.h: (JSC::Arguments::setActivation): (JSC::Arguments::Arguments): * runtime/ArrayConstructor.cpp: (JSC::ArrayConstructor::ArrayConstructor): (JSC::constructArrayWithSizeQuirk): * runtime/ArrayPrototype.cpp: (JSC::arrayProtoFuncSplice): * runtime/BatchedTransitionOptimizer.h: (JSC::BatchedTransitionOptimizer::BatchedTransitionOptimizer): (JSC::BatchedTransitionOptimizer::~BatchedTransitionOptimizer): * runtime/BooleanConstructor.cpp: (JSC::BooleanConstructor::BooleanConstructor): (JSC::constructBoolean): (JSC::constructBooleanFromImmediateBoolean): * runtime/BooleanPrototype.cpp: (JSC::BooleanPrototype::BooleanPrototype): * runtime/ConservativeSet.cpp: (JSC::ConservativeSet::grow): * runtime/ConservativeSet.h: (JSC::ConservativeSet::~ConservativeSet): (JSC::ConservativeSet::mark): * runtime/DateConstructor.cpp: (JSC::DateConstructor::DateConstructor): * runtime/DateInstance.cpp: (JSC::DateInstance::DateInstance): * runtime/DatePrototype.cpp: (JSC::dateProtoFuncSetTime): (JSC::setNewValueFromTimeArgs): (JSC::setNewValueFromDateArgs): (JSC::dateProtoFuncSetYear): * runtime/ErrorConstructor.cpp: (JSC::ErrorConstructor::ErrorConstructor): * runtime/ErrorInstance.cpp: (JSC::ErrorInstance::ErrorInstance): * runtime/ErrorPrototype.cpp: (JSC::ErrorPrototype::ErrorPrototype): * runtime/FunctionConstructor.cpp: (JSC::FunctionConstructor::FunctionConstructor): * runtime/FunctionPrototype.cpp: (JSC::FunctionPrototype::FunctionPrototype): * runtime/GetterSetter.cpp: (JSC::GetterSetter::markChildren): * runtime/GetterSetter.h: (JSC::GetterSetter::GetterSetter): (JSC::GetterSetter::getter): (JSC::GetterSetter::setGetter): (JSC::GetterSetter::setter): (JSC::GetterSetter::setSetter): * runtime/GlobalEvalFunction.cpp: (JSC::GlobalEvalFunction::GlobalEvalFunction): (JSC::GlobalEvalFunction::markChildren): * runtime/GlobalEvalFunction.h: (JSC::GlobalEvalFunction::cachedGlobalObject): * runtime/Heap.cpp: (JSC::Heap::markProtectedObjects): (JSC::Heap::markTempSortVectors): (JSC::Heap::markRoots): * runtime/InternalFunction.cpp: (JSC::InternalFunction::InternalFunction): * runtime/JSAPIValueWrapper.h: (JSC::JSAPIValueWrapper::value): (JSC::JSAPIValueWrapper::JSAPIValueWrapper): * runtime/JSActivation.cpp: (JSC::JSActivation::markChildren): (JSC::JSActivation::put): * runtime/JSArray.cpp: (JSC::JSArray::JSArray): (JSC::JSArray::getOwnPropertySlot): (JSC::JSArray::getOwnPropertyDescriptor): (JSC::JSArray::put): (JSC::JSArray::putSlowCase): (JSC::JSArray::deleteProperty): (JSC::JSArray::increaseVectorLength): (JSC::JSArray::setLength): (JSC::JSArray::pop): (JSC::JSArray::push): (JSC::JSArray::unshiftCount): (JSC::JSArray::sort): (JSC::JSArray::fillArgList): (JSC::JSArray::copyToRegisters): (JSC::JSArray::compactForSorting): * runtime/JSArray.h: (JSC::JSArray::getIndex): (JSC::JSArray::setIndex): (JSC::JSArray::uncheckedSetIndex): (JSC::JSArray::markChildrenDirect): * runtime/JSByteArray.cpp: (JSC::JSByteArray::JSByteArray): * runtime/JSCell.h: (JSC::JSCell::JSValue::toThisObject): (JSC::JSCell::MarkStack::append): * runtime/JSFunction.cpp: (JSC::JSFunction::JSFunction): (JSC::JSFunction::getOwnPropertySlot): * runtime/JSGlobalData.h: * runtime/JSGlobalObject.cpp: (JSC::markIfNeeded): (JSC::JSGlobalObject::reset): (JSC::JSGlobalObject::resetPrototype): (JSC::JSGlobalObject::markChildren): * runtime/JSGlobalObject.h: (JSC::JSGlobalObject::JSGlobalObjectData::JSGlobalObjectData): (JSC::JSGlobalObject::regExpConstructor): (JSC::JSGlobalObject::errorConstructor): (JSC::JSGlobalObject::evalErrorConstructor): (JSC::JSGlobalObject::rangeErrorConstructor): (JSC::JSGlobalObject::referenceErrorConstructor): (JSC::JSGlobalObject::syntaxErrorConstructor): (JSC::JSGlobalObject::typeErrorConstructor): (JSC::JSGlobalObject::URIErrorConstructor): (JSC::JSGlobalObject::evalFunction): (JSC::JSGlobalObject::objectPrototype): (JSC::JSGlobalObject::functionPrototype): (JSC::JSGlobalObject::arrayPrototype): (JSC::JSGlobalObject::booleanPrototype): (JSC::JSGlobalObject::stringPrototype): (JSC::JSGlobalObject::numberPrototype): (JSC::JSGlobalObject::datePrototype): (JSC::JSGlobalObject::regExpPrototype): (JSC::JSGlobalObject::methodCallDummy): (JSC::Structure::prototypeForLookup): (JSC::constructArray): * runtime/JSONObject.cpp: (JSC::Stringifier::Holder::object): (JSC::Stringifier::markAggregate): (JSC::Stringifier::stringify): (JSC::Stringifier::Holder::appendNextProperty): (JSC::Walker::callReviver): (JSC::Walker::walk): * runtime/JSObject.cpp: (JSC::JSObject::defineGetter): (JSC::JSObject::defineSetter): (JSC::JSObject::removeDirect): (JSC::JSObject::putDirectFunction): (JSC::JSObject::putDirectFunctionWithoutTransition): (JSC::putDescriptor): (JSC::JSObject::defineOwnProperty): * runtime/JSObject.h: (JSC::JSObject::getDirectOffset): (JSC::JSObject::putDirectOffset): (JSC::JSObject::flattenDictionaryObject): (JSC::JSObject::putDirectInternal): (JSC::JSObject::putDirect): (JSC::JSObject::putDirectFunction): (JSC::JSObject::putDirectWithoutTransition): (JSC::JSObject::putDirectFunctionWithoutTransition): (JSC::JSValue::putDirect): (JSC::JSObject::allocatePropertyStorageInline): (JSC::JSObject::markChildrenDirect): * runtime/JSPropertyNameIterator.cpp: (JSC::JSPropertyNameIterator::JSPropertyNameIterator): (JSC::JSPropertyNameIterator::get): * runtime/JSPropertyNameIterator.h: * runtime/JSStaticScopeObject.cpp: (JSC::JSStaticScopeObject::markChildren): * runtime/JSString.cpp: (JSC::StringObject::create): * runtime/JSValue.h: * runtime/JSWrapperObject.cpp: (JSC::JSWrapperObject::markChildren): * runtime/JSWrapperObject.h: (JSC::JSWrapperObject::internalValue): (JSC::JSWrapperObject::setInternalValue): * runtime/LiteralParser.cpp: (JSC::LiteralParser::parse): * runtime/Lookup.cpp: (JSC::setUpStaticFunctionSlot): * runtime/Lookup.h: (JSC::lookupPut): * runtime/MarkStack.h: (JSC::MarkStack::appendValues): * runtime/MathObject.cpp: (JSC::MathObject::MathObject): * runtime/NativeErrorConstructor.cpp: (JSC::NativeErrorConstructor::NativeErrorConstructor): * runtime/NativeErrorPrototype.cpp: (JSC::NativeErrorPrototype::NativeErrorPrototype): * runtime/NumberConstructor.cpp: (JSC::NumberConstructor::NumberConstructor): (JSC::constructWithNumberConstructor): * runtime/NumberObject.cpp: (JSC::constructNumber): * runtime/NumberPrototype.cpp: (JSC::NumberPrototype::NumberPrototype): * runtime/ObjectConstructor.cpp: (JSC::ObjectConstructor::ObjectConstructor): (JSC::objectConstructorGetOwnPropertyDescriptor): * runtime/Operations.h: (JSC::normalizePrototypeChain): (JSC::resolveBase): * runtime/PrototypeFunction.cpp: (JSC::PrototypeFunction::PrototypeFunction): * runtime/PutPropertySlot.h: (JSC::PutPropertySlot::setExistingProperty): (JSC::PutPropertySlot::setNewProperty): (JSC::PutPropertySlot::base): * runtime/RegExpConstructor.cpp: (JSC::RegExpConstructor::RegExpConstructor): * runtime/ScopeChain.cpp: (JSC::ScopeChainNode::print): * runtime/ScopeChain.h: (JSC::ScopeChainNode::~ScopeChainNode): (JSC::ScopeChainIterator::operator*): (JSC::ScopeChainIterator::operator->): (JSC::ScopeChain::top): * runtime/ScopeChainMark.h: (JSC::ScopeChain::markAggregate): * runtime/SmallStrings.cpp: (JSC::isMarked): (JSC::SmallStrings::markChildren): * runtime/SmallStrings.h: (JSC::SmallStrings::emptyString): (JSC::SmallStrings::singleCharacterString): (JSC::SmallStrings::singleCharacterStrings): * runtime/StringConstructor.cpp: (JSC::StringConstructor::StringConstructor): * runtime/StringObject.cpp: (JSC::StringObject::StringObject): * runtime/StringObject.h: * runtime/StringPrototype.cpp: (JSC::StringPrototype::StringPrototype): * runtime/Structure.cpp: (JSC::Structure::Structure): (JSC::Structure::addPropertyTransition): (JSC::Structure::toDictionaryTransition): (JSC::Structure::flattenDictionaryStructure): * runtime/Structure.h: (JSC::Structure::storedPrototype): * runtime/WeakGCMap.h: (JSC::WeakGCMap::uncheckedGet): (JSC::WeakGCMap::isValid): (JSC::::get): (JSC::::take): (JSC::::set): (JSC::::uncheckedRemove): * runtime/WriteBarrier.h: Removed. 2011-01-30 Csaba Osztrogonác <ossy@webkit.org> Unreviewed, rolling out r77098, r77099, r77100, r77109, and r77111. http://trac.webkit.org/changeset/77098 http://trac.webkit.org/changeset/77099 http://trac.webkit.org/changeset/77100 http://trac.webkit.org/changeset/77109 http://trac.webkit.org/changeset/77111 https://bugs.webkit.org/show_bug.cgi?id=53219 Qt build is broken * JSValueWrapper.cpp: (JSValueWrapper::JSObjectMark): 2011-01-30 Csaba Osztrogonác <ossy@webkit.org> Unreviewed, rolling out r77098, r77099, r77100, r77109, and r77111. http://trac.webkit.org/changeset/77098 http://trac.webkit.org/changeset/77099 http://trac.webkit.org/changeset/77100 http://trac.webkit.org/changeset/77109 http://trac.webkit.org/changeset/77111 https://bugs.webkit.org/show_bug.cgi?id=53219 Qt build is broken * ForwardingHeaders/runtime/WriteBarrier.h: Removed. * WebCore.exp.in: * bindings/js/DOMWrapperWorld.h: * bindings/js/JSAudioConstructor.cpp: (WebCore::JSAudioConstructor::JSAudioConstructor): * bindings/js/JSDOMBinding.cpp: (WebCore::markDOMNodesForDocument): (WebCore::markDOMObjectWrapper): (WebCore::markDOMNodeWrapper): * bindings/js/JSDOMGlobalObject.cpp: (WebCore::JSDOMGlobalObject::markChildren): (WebCore::JSDOMGlobalObject::setInjectedScript): (WebCore::JSDOMGlobalObject::injectedScript): * bindings/js/JSDOMGlobalObject.h: (WebCore::JSDOMGlobalObject::JSDOMGlobalObjectData::JSDOMGlobalObjectData): (WebCore::getDOMConstructor): * bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::setLocation): (WebCore::DialogHandler::dialogCreated): * bindings/js/JSDOMWindowShell.cpp: (WebCore::JSDOMWindowShell::JSDOMWindowShell): (WebCore::JSDOMWindowShell::setWindow): (WebCore::JSDOMWindowShell::markChildren): (WebCore::JSDOMWindowShell::unwrappedObject): * bindings/js/JSDOMWindowShell.h: (WebCore::JSDOMWindowShell::window): (WebCore::JSDOMWindowShell::setWindow): * bindings/js/JSDeviceMotionEventCustom.cpp: (WebCore::createAccelerationObject): (WebCore::createRotationRateObject): * bindings/js/JSEventListener.cpp: (WebCore::JSEventListener::JSEventListener): (WebCore::JSEventListener::markJSFunction): * bindings/js/JSEventListener.h: (WebCore::JSEventListener::jsFunction): * bindings/js/JSHTMLDocumentCustom.cpp: (WebCore::JSHTMLDocument::setAll): * bindings/js/JSImageConstructor.cpp: (WebCore::JSImageConstructor::JSImageConstructor): * bindings/js/JSImageDataCustom.cpp: (WebCore::toJS): * bindings/js/JSJavaScriptCallFrameCustom.cpp: (WebCore::JSJavaScriptCallFrame::scopeChain): (WebCore::JSJavaScriptCallFrame::scopeType): * bindings/js/JSNodeFilterCondition.cpp: (WebCore::JSNodeFilterCondition::markAggregate): (WebCore::JSNodeFilterCondition::acceptNode): * bindings/js/JSNodeFilterCondition.h: * bindings/js/JSNodeFilterCustom.cpp: * bindings/js/JSOptionConstructor.cpp: (WebCore::JSOptionConstructor::JSOptionConstructor): * bindings/js/JSSQLResultSetRowListCustom.cpp: (WebCore::JSSQLResultSetRowList::item): * bindings/js/ScriptCachedFrameData.cpp: (WebCore::ScriptCachedFrameData::restore): * bindings/js/ScriptObject.cpp: (WebCore::ScriptGlobalObject::set): * bindings/js/SerializedScriptValue.cpp: (WebCore::CloneDeserializer::putProperty): * bindings/scripts/CodeGeneratorJS.pm: * bridge/qt/qt_instance.cpp: (JSC::Bindings::QtInstance::QtInstance): (JSC::Bindings::QtInstance::removeCachedMethod): (JSC::Bindings::QtInstance::markAggregate): * bridge/qt/qt_instance.h: * bridge/qt/qt_runtime.cpp: (JSC::Bindings::QtRuntimeMetaMethod::QtRuntimeMetaMethod): (JSC::Bindings::QtRuntimeMetaMethod::markChildren): (JSC::Bindings::QtRuntimeMetaMethod::connectGetter): (JSC::Bindings::QtRuntimeMetaMethod::disconnectGetter): * bridge/qt/qt_runtime.h: * bridge/runtime_root.cpp: (JSC::Bindings::RootObject::invalidate): * bridge/runtime_root.h: * dom/Document.h: 2011-01-30 Csaba Osztrogonác <ossy@webkit.org> Unreviewed, rolling out r77098, r77099, r77100, r77109, and r77111. http://trac.webkit.org/changeset/77098 http://trac.webkit.org/changeset/77099 http://trac.webkit.org/changeset/77100 http://trac.webkit.org/changeset/77109 http://trac.webkit.org/changeset/77111 https://bugs.webkit.org/show_bug.cgi?id=53219 Qt build is broken * WebView/WebScriptDebugDelegate.mm: (-[WebScriptCallFrame scopeChain]): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77113 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
simon.fraser@apple.com authored
Unreviewed, rolling out r77107. http://trac.webkit.org/changeset/77107 https://bugs.webkit.org/show_bug.cgi?id=53412 Caused 5 new form-related test crashes (Requested by smfr on #webkit). * css/CSSSelector.cpp: (WebCore::CSSSelector::pseudoId): (WebCore::nameToPseudoTypeMap): (WebCore::CSSSelector::extractPseudoType): * css/CSSSelector.h: * html/HTMLProgressElement.cpp: (WebCore::HTMLProgressElement::parseMappedAttribute): (WebCore::HTMLProgressElement::attach): * html/HTMLProgressElement.h: * rendering/RenderProgress.cpp: (WebCore::RenderProgress::~RenderProgress): (WebCore::RenderProgress::updateFromElement): (WebCore::RenderProgress::layoutParts): (WebCore::RenderProgress::shouldHaveParts): * rendering/RenderProgress.h: * rendering/style/RenderStyleConstants.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77112 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
simon.fraser@apple.com authored
Build fix the build fix. I assume Oliver meant m_cell, not m_value. * runtime/WriteBarrier.h: (JSC::WriteBarrierBase::clear): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77111 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
simon.fraser@apple.com authored
Reviewed by Sam Weinig. Enhance ShadowBlur to render inset box shadows https://bugs.webkit.org/show_bug.cgi?id=51567 Use ShadowBlur for inset box-shadows with CG. It currently lacks a tiled version, but is still much faster than CG shadows. Test: fast/box-shadow/inset-box-shadow-radius.html * platform/graphics/ShadowBlur.cpp: * platform/graphics/ShadowBlur.h: New method for inset shadows. (WebCore::ShadowBlur::drawInsetShadow): * platform/graphics/GraphicsContext.cpp: #ifdef out fillRectWithRoundedHole() for CG. * platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::fillRectWithRoundedHole): If there's a shadow with a radius > 0, use ShadowBlur. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77110 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
oliver@apple.com authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77109 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
kbr@google.com authored
Reviewed by Chris Marrin. WebGL shows PNG Textures with indexed colors too dark https://bugs.webkit.org/show_bug.cgi?id=47477 Added test case for upload of indexed PNG images to gl-teximage.html in the Khronos WebGL conformance tests. Synchronized this test with the Khronos repository. * fast/canvas/webgl/gl-teximage-expected.txt: * fast/canvas/webgl/gl-teximage.html: * fast/canvas/webgl/resources/red-indexed.png: Added. 2011-01-28 Kenneth Russell <kbr@google.com> Reviewed by Chris Marrin. WebGL shows PNG Textures with indexed colors too dark https://bugs.webkit.org/show_bug.cgi?id=47477 Properly handle indexed PNG images by re-rendering them as RGBA images before upload. Verified with this layout test and the test cases from bugs 47477 and 53269. * platform/graphics/cg/GraphicsContext3DCG.cpp: (WebCore::GraphicsContext3D::getImageData): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77108 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
morrita@google.com authored
Reviewed by Dimitri Glazkov. Convert <progress> shadow DOM to a DOM-based shadow. https://bugs.webkit.org/show_bug.cgi?id=50660 * Removed RenderProgress::m_valuePart, moved the shadow node to the shadow root of HTMLProgressElement. * Removed hard-coded pseudo ID for -webkit-progress-bar-value. ProgressBarValueElement is defined only for overriding shadowPseudoId(). No new tests. No behavioral change. * css/CSSSelector.cpp: (WebCore::CSSSelector::pseudoId): (WebCore::nameToPseudoTypeMap): (WebCore::CSSSelector::extractPseudoType): * css/CSSSelector.h: * html/HTMLProgressElement.cpp: (WebCore::ProgressBarValueElement::ProgressBarValueElement): (WebCore::ProgressBarValueElement::shadowPseudoId): (WebCore::ProgressBarValueElement::create): (WebCore::HTMLProgressElement::parseMappedAttribute): (WebCore::HTMLProgressElement::attach): (WebCore::HTMLProgressElement::valuePart): (WebCore::HTMLProgressElement::didElementStateChange): (WebCore::HTMLProgressElement::createShadowSubtreeIfNeeded): * html/HTMLProgressElement.h: * rendering/RenderProgress.cpp: (WebCore::RenderProgress::~RenderProgress): (WebCore::RenderProgress::updateFromElement): (WebCore::RenderProgress::layoutParts): (WebCore::RenderProgress::shouldHaveParts): (WebCore::RenderProgress::valuePart): * rendering/RenderProgress.h: * rendering/style/RenderStyleConstants.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77107 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
simon.fraser@apple.com authored
Reviewed by Ariya Hidayat. Enhance ShadowBlur to render inset box shadows; Part 1. https://bugs.webkit.org/show_bug.cgi?id=51567 Add a new method to GraphicsContext to render a rect with a rounded hole, for use by inset box-shadow code. Knowledge that we're rendering a rounded hole will enable ShadowBlur to be used here in future. * platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::fillRectWithRoundedHole): * platform/graphics/GraphicsContext.h: * rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintBoxShadow): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77106 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
morrita@google.com authored
Reviewed by Eric Seidel. REGRESSION: Inset shadow with too large border radius misses rounded corner. https://bugs.webkit.org/show_bug.cgi?id=52800 * fast/box-shadow/inset-with-extraordinary-radii-and-border.html: Added. * platform/mac/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.checksum: Added. * platform/mac/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.png: Added. * platform/mac/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.txt: Added. 2011-01-23 MORITA Hajime <morrita@google.com> Reviewed by Eric Seidel. REGRESSION: Inset shadow with too large border radius misses rounded corner. https://bugs.webkit.org/show_bug.cgi?id=52800 The refactoring on r76083 broke the invariant between border IntRect and its radii because RoundedIntRect::setRect() is called after getRoundedInnerBorderWithBorderWidths(), which enforces the invariant. Th rounded-rect clipping code verifies the invariant, and discard the invalid radii, that results broken paintings. This change moved setRect() before getRoundedInnerBorderWithBorderWidths() not to modify the valid RoundedIntRect value. Test: fast/box-shadow/inset-with-extraordinary-radii-and-border.html * rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintBoxShadow): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77105 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
ggaren@apple.com authored
Reviewed by Sam Weinig. [Take 2!] Fixed crash on window close (maybe crash on launch?) due to missing frame null checks https://bugs.webkit.org/show_bug.cgi?id=53408 * UIProcess/WebContext.cpp: (WebKit::WebContext::didNavigateWithNavigationData): (WebKit::WebContext::didPerformClientRedirect): (WebKit::WebContext::didPerformServerRedirect): (WebKit::WebContext::didUpdateHistoryTitle): Use MESSAGE_CHECK because we don't think we should be able to reach this state under normal conditions. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77104 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
simon.fraser@apple.com authored
Attempt to fix Windows build by adding ShadowBlur.cpp/h to the vcproj. * WebCore.vcproj/WebCore.vcproj: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77103 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
ggaren@apple.com authored
Reviewed by Maciej Stachowiak. Fixed crash on window close (maybe crash on launch?) due to missing frame null checks https://bugs.webkit.org/show_bug.cgi?id=53408 * UIProcess/WebContext.cpp: (WebKit::WebContext::didNavigateWithNavigationData): (WebKit::WebContext::didPerformClientRedirect): (WebKit::WebContext::didPerformServerRedirect): (WebKit::WebContext::didUpdateHistoryTitle): Check for NULL, since we're calling a function that can return it. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77102 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
simon.fraser@apple.com authored
Reviewed by Dan Bernstein. -webkit-box-shadow causes awful scroll/resize/redraw performance https://bugs.webkit.org/show_bug.cgi?id=22102 Use ShadowBlur for CG, whe rendering shadows on rects and rounded rects outside of canvas. CG shadows with a radius of more than 8px do not render correctly. We preserve this incorrect rendering by compensating for it when rending -webkit-box-shadow. Calls that should use this deprecated radius behavior now use setLegacyShadow(). Test: fast/box-shadow/box-shadow-transformed.html * html/canvas/CanvasRenderingContext2D.cpp: Use setLegacyShadow() for canvas, to indicate that it should use the deprecated radius behavior. (WebCore::CanvasRenderingContext2D::setAllAttributesToDefault): Ditto. (WebCore::CanvasRenderingContext2D::setShadow): Ditto. (WebCore::CanvasRenderingContext2D::applyShadow): Ditto. * platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::setLegacyShadow): Set the m_state.shadowsUseLegacyRadius bit. * platform/graphics/GraphicsContext.h: (WebCore::GraphicsContextState::GraphicsContextState): Add a shadowsUseLegacyRadius bit to the state. * platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::radiusToLegacyRadius): Map from the actual radius to one that approximates CG behavior. (WebCore::hasBlurredShadow): Helper that returns true if we have a shadow with a non-zero blur radius. (WebCore::GraphicsContext::fillRect): Use ShadowBlur if not canvas. (WebCore::GraphicsContext::fillRoundedRect): Ditto. (WebCore::GraphicsContext::setPlatformShadow): Comment. * rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintBoxShadow): Call setLegacyShadow() for -webkit-box-shadow. * platform/graphics/ShadowBlur.cpp: (WebCore::ShadowBlur::calculateLayerBoundingRect): Fix some pixel crack issues by rounding up the blur radius. (WebCore::ShadowBlur::drawRectShadow): Ditto (WebCore::ShadowBlur::drawRectShadowWithTiling): Ditto. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77101 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
