1. 19 Feb, 2007 18 commits
    • hyatt's avatar
      Fix for Radar 4981605, regression where button grows randomly when a select is · 81b2976c
      hyatt authored
              opened.  With the new form controls, the WinIE quirk for using line width
              ended up being used for them more.
      
              This patch removes the quirk after verifying that Firefox doesn't implement
              the quirk at all.  usesLineWidth is being renamed to shrinksToAvoidFloats to
              make it clear that the new method only applies to block objects that avoid floats
              and that have auto width.
      
              Also fixed a regression where whitespace after a floating <select> at the start
              of a block got incorrectly rendered.  Make sure skipWhitespace always skips
              through floating/positioned elements regardless of the whitespace setting (this
              way the white-space:pre value on floating <select>s doesn't cause trouble).
      
              Reviewed by darin
      
              fast/block/float/float-avoidance.html
      
              * rendering/RenderBlock.cpp:
              (WebCore::RenderBlock::collapseMargins):
              (WebCore::RenderBlock::clearFloatsIfNeeded):
              (WebCore::RenderBlock::layoutBlockChildren):
              (WebCore::RenderBlock::markAllDescendantsWithFloatsForLayout):
              * rendering/RenderBox.cpp:
              (WebCore::RenderBox::containingBlockWidth):
              * rendering/RenderObject.cpp:
              (WebCore::RenderObject::shrinkToAvoidFloats):
              * rendering/RenderObject.h:
              * rendering/bidi.cpp:
              (WebCore::RenderBlock::skipWhitespace):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19717 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      81b2976c
    • weinig's avatar
      LayoutTests: · d1f53f0a
      weinig authored
              Reviewed by Darin.
      
              1. Test for background image with relative url, when base url element 
              is present. .html has a base url, which according to the html spec is supposed 
              to be absolute, is actually a relative url. Absolute url would not work with file:// scheme. 
              2. Test for base element and @import with relative url.
              http://bugs.webkit.org/show_bug.cgi?id=12214
              
              * fast/css/background-image-with-baseurl-expected.checksum: Added.
              * fast/css/background-image-with-baseurl-expected.png: Added.
              * fast/css/background-image-with-baseurl-expected.txt: Added.
              * fast/css/background-image-with-baseurl.html: Added.
              * fast/css/import_with_baseurl-expected.checksum: Added.
              * fast/css/import_with_baseurl-expected.png: Added.
              * fast/css/import_with_baseurl-expected.txt: Added.
              * fast/css/import_with_baseurl.html: Added.
              * fast/css/resources/background_image.css: Added.
      
      WebCore:
      
              Reviewed by Darin.
      
              Update stylesheet href, when document's baseUrl changes. It needs
              update when the stylesheet is constructed before the parser hits the base tag.
              http://bugs.webkit.org/show_bug.cgi?id=12214
      
              * css/StyleSheet.h:
              (WebCore::StyleSheet::setHref):
              * dom/Document.cpp:
              (WebCore::Document::setBaseURL):
              * dom/Document.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19716 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d1f53f0a
    • weinig's avatar
      Reviewed by Adam. · 9288333e
      weinig authored
              - fix http://bugs.webkit.org/show_bug.cgi?id=11518
                REGRESSION (r14376): View Source not available after Back navigation from a non-HTML page
      
              The FrameLoader's responseMIMEType was not being updated when a page was
              brought back from the page cache.
              
              Moved the line that updates the MIME type from commitProvisionalLoad() to
              transitionToCommitted().
      
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::commitProvisionalLoad):
              (WebCore::FrameLoader::transitionToCommitted):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19715 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9288333e
    • ggaren's avatar
      Build fix. · 980ceda7
      ggaren authored
              
              * Scripts/check-for-global-initializers: Ignore the global counter I added
              for SubresourceLoaders.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19714 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      980ceda7
    • andersca's avatar
      Reviewed by Oliver. · f74b393e
      andersca authored
              Make DragController::maxDragImageSize a function to get rid of the global initializer.
              
              * page/DragController.cpp:
              (WebCore::DragController::doImageDrag):
              * page/DragController.h:
              * page/mac/DragControllerMac.mm:
              (WebCore::DragController::maxDragImageSize):
              * page/qt/DragControllerQt.cpp:
              (WebCore::DragController::maxDragImageSize):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19713 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f74b393e
    • darin's avatar
      Reviewed by Tim Hatcher. · 7b6a8875
      darin authored
              * Scripts/check-for-global-initializers: Delete the linked executable if the check fails.
              Without this, you only see the global initializer error once, which makes it very easy
              to miss them.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19712 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7b6a8875
    • thatcher's avatar
      Reviewed by Darin Adler. · ddff15de
      thatcher authored
              <rdar://problem/4841078> Remove the Mail.app editable link clicking behavior workaround when it is no longer needed
      
              * WebKit.xcodeproj/project.pbxproj:
              * WebView/WebView.mm:
              (-[WebView setPreferences:]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19711 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ddff15de
    • darin's avatar
      Reviewed by Hyatt. · 9f56924a
      darin authored
              - <rdar://problem/5006414> REGRESSION: Crash occurs at WebCore::Frame::loader()
                when loading AFL Ladder widget
      
              * html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::openURL):
              Add missing null check so this fails without crashing when called on an element
              that's no longer in a frame.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19710 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9f56924a
    • andersca's avatar
      Reviewed by Adam. · ee0de541
      andersca authored
              <rdar://problem/4868242>
              http://bugs.webkit.org/show_bug.cgi?id=12670
              REGRESSION: Many 3rd Party Apps crash in WebCore::DocumentLoader::frameLoader() (12670)
              
              Bring back the semantic we had that a web view should be retained for as long as something is loading. Use the identifier
              to object hash map for this.
      
              * WebView/WebView.mm:
              (-[WebView _addObject:forIdentifier:]):
              (-[WebView _removeObjectForIdentifier:]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19709 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ee0de541
    • thatcher's avatar
      Remove two imports of FrameMac.h, fixes clean Mac builds. · 1ef9d8f9
      thatcher authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19708 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1ef9d8f9
    • antti's avatar
      LayoutTests: · b7648156
      antti authored
              Reviewed by Mitz.
              
              - test for http://bugs.webkit.org/show_bug.cgi?id=10990
                REGRESSION: Pressing a pop-up's access key doesn't focus it
                <rdar://problem/4823138>
      
              * fast/forms/select-accesskey-expected.checksum: Added.
              * fast/forms/select-accesskey-expected.png: Added.
              * fast/forms/select-accesskey-expected.txt: Added.
              * fast/forms/select-accesskey.html: Added.
      
      WebCore:
      
              Reviewed by Mitz.
      
              - fix for http://bugs.webkit.org/show_bug.cgi?id=10990
                REGRESSION: Pressing a pop-up's access key doesn't focus it
                <rdar://problem/4823138>
                
              Focus the select element too in accessKeyAction.
      
              * html/HTMLSelectElement.cpp:
              (WebCore::HTMLSelectElement::accessKeyAction):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19707 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b7648156
    • antti's avatar
      Reviewed by Hyatt. · 72b883ef
      antti authored
              - really fix http://bugs.webkit.org/show_bug.cgi?id=11974
              REGRESSION: Caret drawn over input when smaller than font size on initial focus
              <rdar://problem/4960258>
              
              Avoid double painting caret when it is on a block element.
              
              Layout test for this already went in previous try (it only fails in pixel mode) in r19626.
      
              * rendering/RenderBlock.cpp:
              (WebCore::RenderBlock::paintCaret):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19706 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      72b883ef
    • lars's avatar
      Added a one line patch from Olliej to create the · e7e3e13a
      lars authored
              clipboard on demand (to stop things from crashing), 
              and added lots of notImplemented() warnings all 
              over the place.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19705 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e7e3e13a
    • beidson's avatar
      Reviewed by Oliver · 70cc1d3a
      beidson authored
              <rdar://problem/4985321> - Can't edit templates for Web Gallery/Web Page Export in Aperture
      
              * Misc/WebKitVersionChecks.h: Add a #define for this APERTURE quirk
              * WebView/WebView.mm:
              (-[WebView _shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
               If the current app is Aperture and it was linked against Tiger WebKit, always allow selection change
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19704 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      70cc1d3a
    • lars's avatar
      fix compilation. · bc38ff4d
      lars authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19703 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bc38ff4d
    • mjs's avatar
      WebCore: · c13fa54c
      mjs authored
              Reviewed by Maciej.
              
              Additional coding by Maciej, additional review by Oliver.
      
              Get rid of the FrameMac and FrameQt classes. Instead
              move all methods into Frame directly, and implement
              some platform specific methods in foo/FrameFoo.cpp.
      
              Some general cleanup in Frame:
              * Move some methods out of Frame, to the place where they 
              belong.
              * Unify the different ways of creating the JavaScript wrappers
              for <object>, <embed> and <applet>
              * Some cleanup of the WebCoreFrameBridge
      
              * ForwardingHeaders/bindings/NP_jsobject.h: Added.
              * ForwardingHeaders/bindings/npruntime_impl.h: Added.
              * ForwardingHeaders/bindings/runtime_root.h: Added.
              * WebCore.exp:
              * WebCore.xcodeproj/project.pbxproj:
              * bindings/js/kjs_binding.cpp:
              (KJS::ScriptInterpreter::shouldInterruptScript):
              * bindings/objc/DOM.mm:
              (-[DOMNode KJS::Bindings::]):
              * bindings/objc/DOMInternal.mm:
              (-[WebScriptObject _initializeScriptDOMNodeImp]):
              * bridge/EditorClient.h:
              * bridge/mac/FrameViewMac.mm:
              (WebCore::FrameView::updateBorder):
              (WebCore::FrameView::updateDashboardRegions):
              * bridge/mac/WebCoreAXObject.mm:
              (-[WebCoreAXObject rendererForView:]):
              * dom/Position.cpp:
              (WebCore::Position::next):
              * editing/CommandByName.cpp:
              (WebCore::Frame::execCopy):
              (WebCore::Frame::execCut):
              (WebCore::Frame::execPaste):
              * editing/Editor.cpp:
              (WebCore::Editor::canEdit):
              (WebCore::Editor::pasteWithPasteboard):
              (WebCore::Editor::paste):
              (WebCore::Editor::pasteAsPlainText):
              * editing/Editor.h:
              * editing/JSEditor.cpp:
              * html/HTMLAppletElement.cpp:
              (WebCore::HTMLAppletElement::getInstance):
              * html/HTMLEmbedElement.cpp:
              (WebCore::HTMLEmbedElement::getInstance):
              * html/HTMLFormElement.cpp:
              (WebCore::HTMLFormElement::formData):
              * html/HTMLObjectElement.cpp:
              (WebCore::HTMLObjectElement::getInstance):
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::clear):
              (WebCore::FrameLoader::detachFromParent):
              * loader/mac/ImageDocumentMac.mm:
              (WebCore::finishImageLoad):
              * loader/qt/DocumentLoaderQt.cpp:
              * page/Chrome.cpp:
              (WebCore::Chrome::shouldInterruptJavaScript):
              * page/Chrome.h:
              * page/ChromeClient.h:
              * page/Frame.cpp:
              (WebCore::Frame::~Frame):
              (WebCore::Frame::markedTextRange):
              (WebCore::Frame::shouldChangeSelection):
              (WebCore::Frame::shouldDeleteSelection):
              (WebCore::Frame::isContentEditable):
              (WebCore::Frame::setSecureKeyboardEntry):
              (WebCore::Frame::isSecureKeyboardEntry):
              (WebCore::Frame::bindingRootObject):
              (WebCore::Frame::createRootObject):
              (WebCore::Frame::windowScriptNPObject):
              (WebCore::Frame::cleanupScriptObjects):
              (WebCore::FramePrivate::FramePrivate):
              * page/Frame.h:
              * page/FramePrivate.h:
              * page/FrameView.h:
              * page/mac/EventHandlerMac.mm:
              (WebCore::EventHandler::tabsToLinks):
              (WebCore::EventHandler::tabsToAllControls):
              (WebCore::EventHandler::focusDocumentView):
              (WebCore::EventHandler::passMouseDownEventToWidget):
              (WebCore::EventHandler::handleDrag):
              (WebCore::EventHandler::sendFakeEventsAfterWidgetTracking):
              (WebCore::EventHandler::keyboardUIMode):
              * page/mac/FrameMac.h: Removed.
              * page/mac/FrameMac.mm:
              (WebCore::Frame::setBridge):
              (WebCore::Frame::bridge):
              (WebCore::Frame::searchForLabelsAboveCell):
              (WebCore::Frame::searchForLabelsBeforeElement):
              (WebCore::Frame::matchLabelsAgainstElement):
              (WebCore::Frame::focusWindow):
              (WebCore::Frame::unfocusWindow):
              (WebCore::Frame::imageFromRect):
              (WebCore::Frame::selectionImage):
              (WebCore::Frame::snapshotDragImage):
              (WebCore::Frame::fontAttributesForSelectionStart):
              (WebCore::Frame::baseWritingDirectionForSelectionStart):
              (WebCore::Frame::print):
              (WebCore::Frame::issuePasteCommand):
              (WebCore::Frame::issueTransposeCommand):
              (WebCore::Frame::respondToChangedSelection):
              (WebCore::Frame::textFieldDidBeginEditing):
              (WebCore::Frame::textFieldDidEndEditing):
              (WebCore::Frame::textDidChangeInTextField):
              (WebCore::Frame::textDidChangeInTextArea):
              (WebCore::Frame::doTextFieldCommandFromEvent):
              (WebCore::Frame::textWillBeDeletedInTextField):
              (WebCore::Frame::setSecureKeyboardEntry):
              (WebCore::Frame::isSecureKeyboardEntry):
              (WebCore::Frame::setMarkedTextRange):
              (WebCore::Frame::dashboardRegionsDictionary):
              (WebCore::Frame::dashboardRegionsChanged):
              (WebCore::Frame::willPopupMenu):
              (WebCore::Frame::isCharacterSmartReplaceExempt):
              (WebCore::Frame::setNeedsReapplyStyles):
              (WebCore::Frame::customHighlightLineRect):
              (WebCore::Frame::paintCustomHighlight):
              (WebCore::Frame::createScriptInstanceForWidget):
              (WebCore::Frame::windowScriptObject):
              (WebCore::Frame::cleanupPlatformScriptObjects):
              * page/mac/WebCoreFrameBridge.h:
              * page/mac/WebCoreFrameBridge.mm:
              (createRootObject):
              (bridge):
              (-[WebCoreFrameBridge _frame]):
              * page/qt/EventHandlerQt.cpp:
              * page/qt/FrameQt.cpp:
              (WebCore::Frame::unfocusWindow):
              (WebCore::Frame::focusWindow):
              (WebCore::Frame::issueTransposeCommand):
              (WebCore::Frame::respondToChangedSelection):
              (WebCore::Frame::print):
              (WebCore::Frame::createScriptInstanceForWidget):
              (WebCore::Frame::cleanupPlatformScriptObjects):
              (WebCore::Frame::isCharacterSmartReplaceExempt):
              * page/qt/FrameQt.h: Removed.
              * platform/MimeTypeRegistry.h:
              * platform/graphics/svg/SVGImage.cpp:
              (WebCore::SVGImage::setData):
              * platform/graphics/svg/SVGImageEmptyClients.h:
              (WebCore::SVGEmptyChromeClient::shouldInterruptJavaScript):
              (WebCore::SVGEmptyEditorClient::shouldChangeSelectedRange):
              * platform/mac/ClipboardMac.h:
              * platform/mac/ClipboardMac.mm:
              (WebCore::ClipboardMac::ClipboardMac):
              * platform/mac/FileChooserMac.mm:
              (-[OpenPanelController beginSheetWithFrame:]):
              * platform/mac/MimeTypeRegistryMac.mm:
              (WebCore::MimeTypeRegistry::getMIMETypeForPath):
              * platform/mac/PopupMenuMac.mm:
              (WebCore::PopupMenu::show):
              * platform/mac/WidgetMac.mm:
              (WebCore::Widget::setFocus):
              (WebCore::Widget::setIsSelected):
              * platform/network/mac/ResourceHandleMac.mm:
              * platform/network/qt/ResourceHandleManagerQt.cpp:
              * platform/network/qt/ResourceHandleQt.cpp:
              (WebCore::ResourceHandle::start):
              * platform/qt/MimeTypeRegistryQt.cpp:
              (WebCore::MimeTypeRegistry::getMIMETypeForPath):
              * platform/qt/PopupMenuQt.cpp:
              * platform/qt/ScrollViewCanvasQt.cpp:
              * platform/qt/ScrollViewQt.cpp:
              * platform/win/TemporaryLinkStubs.cpp:
              * rendering/InlineTextBox.cpp:
              (WebCore::InlineTextBox::paintCustomHighlight):
              * rendering/RenderBox.cpp:
              (WebCore::RenderBox::paintCustomHighlight):
              * rendering/RootInlineBox.cpp:
              (WebCore::RootInlineBox::addHighlightOverflow):
              (WebCore::RootInlineBox::paintCustomHighlight):
      
      WebKit:
      
              Reviewed by Maciej.
      
              Additional coding by Maciej, additional review by Oliver.
      
              Added implementations for the new callbacks in EditorClient
              and ChromeClient (basically moved from WebFrameBridge).
              Cleaned up some code paths that are not called anymore
              and done fully inside WebCore now.
      
              * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
              * Misc/WebElementDictionary.mm:
              * Misc/WebNSAttributedStringExtras.mm:
              * Plugins/WebBaseNetscapePluginView.mm:
              (-[WebBaseNetscapePluginView getVariable:value:]):
              * Plugins/WebNetscapePluginEmbeddedView.mm:
              * Plugins/WebNetscapePluginStream.mm:
              * Plugins/WebPluginContainerCheck.mm:
              * WebCoreSupport/WebChromeClient.h:
              * WebCoreSupport/WebChromeClient.mm:
              (WebChromeClient::shouldInterruptJavaScript):
              * WebCoreSupport/WebEditorClient.h:
              * WebCoreSupport/WebEditorClient.mm:
              (WebEditorClient::shouldChangeSelectedRange):
              * WebCoreSupport/WebFrameBridge.mm:
              (-[WebFrameBridge finishInitializingWithPage:frameName:frameView:ownerElement:]):
              (-[WebFrameBridge fini]):
              * WebCoreSupport/WebFrameLoaderClient.mm:
              * WebView/WebArchiver.mm:
              * WebView/WebFrame.mm:
              (core):
              (kit):
              (-[WebFrame _updateBackground]):
              * WebView/WebFrameInternal.h:
              * WebView/WebFrameView.mm:
              * WebView/WebHTMLRepresentation.mm:
              * WebView/WebHTMLView.mm:
              (-[WebHTMLView _updateMouseoverWithEvent:]):
              (-[WebHTMLView _isEditable]):
              (-[WebHTMLView validateUserInterfaceItem:]):
              (-[WebHTMLView maintainsInactiveSelection]):
              (-[WebHTMLView scrollWheel:]):
              (-[WebHTMLView acceptsFirstMouse:]):
              (-[WebHTMLView shouldDelayWindowOrderingForEvent:]):
              (-[WebHTMLView cut:]):
              (-[WebHTMLView paste:]):
              (-[WebHTMLView selectedAttributedString]):
              * WebView/WebScriptDebugDelegate.mm:
              * WebView/WebView.mm:
              (-[WebView _dashboardRegions]):
              (-[WebView setProhibitsMainFrameScrolling:]):
              (-[WebView _setInViewSourceMode:]):
              (-[WebView _inViewSourceMode]):
              (-[WebView shouldClose]):
              (-[WebView setEditable:]):
      
      WebKitQt:
      
              Reviewed by Maciej.
      
              Additional coding by Maciej, additional review by Oliver.
      
              Add stubs for the new methods in ChormeClient and EditorClient,
              remove all references to FrameQt.
      
              * Api/qwebframe.cpp:
              (QWebFrame::QWebFrame):
              * Api/qwebframe_p.h:
              * Api/qwebpage.cpp:
              * WebCoreSupport/ChromeClientQt.cpp:
              (WebCore::ChromeClientQt::shouldInterruptJavaScript):
              * WebCoreSupport/ChromeClientQt.h:
              * WebCoreSupport/EditorClientQt.cpp:
              (WebCore::EditorClientQt::shouldChangeSelectedRange):
              (WebCore::EditorClientQt::isEditable):
              * WebCoreSupport/EditorClientQt.h:
              * WebCoreSupport/FrameLoaderClientQt.cpp:
              (WebCore::FrameLoaderClientQt::setFrame):
              (WebCore::FrameLoaderClientQt::webFrame):
              * WebCoreSupport/FrameLoaderClientQt.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19702 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c13fa54c
    • oliver's avatar
      2007-02-18 Oliver Hunt <oliver@apple.com> · 88d990ba
      oliver authored
              Reviewed by NOBODY (Buildfix).
      
              Oops, missed a 'const'
      
              * platform/qt/ClipboardQt.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19701 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      88d990ba
    • oliver's avatar
      2007-02-18 Oliver Hunt <oliver@apple.com> · 8032a699
      oliver authored
              Reviewed by Adam.
      
              Adding stubbed out implementation of Clipboard for Qt to stop
              it crashing whenever someone drags the mouse.
      
              * WebCore.pro:
              * page/qt/EventHandlerQt.cpp:
              (WebCore::EventHandler::createDraggingClipboard):
              * platform/qt/ClipboardQt.cpp: Added.
              (WebCore::ClipboardQt::ClipboardQt):
              (WebCore::ClipboardQt::clearData):
              (WebCore::ClipboardQt::clearAllData):
              (WebCore::ClipboardQt::getData):
              (WebCore::ClipboardQt::setData):
              (WebCore::ClipboardQt::types):
              (WebCore::ClipboardQt::dragLocation):
              (WebCore::ClipboardQt::dragImage):
              (WebCore::ClipboardQt::setDragImage):
              (WebCore::ClipboardQt::dragImageElement):
              (WebCore::ClipboardQt::setDragImageElement):
              (WebCore::ClipboardQt::createDragImage):
              (WebCore::ClipboardQt::declareAndWriteDragImage):
              (WebCore::ClipboardQt::writeURL):
              (WebCore::ClipboardQt::writeRange):
              (WebCore::ClipboardQt::hasData):
              * platform/qt/ClipboardQt.h: Added.
              (WebCore::ClipboardQt::~ClipboardQt):
              (WebCore::ClipboardQt::isForDragging): 
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19700 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8032a699
  2. 18 Feb, 2007 12 commits
    • oliver's avatar
      2007-02-18 Oliver Hunt <oliver@apple.com> · fc36a0a5
      oliver authored
              Reviewed by Adam.
      
              Don't even attempt to do a document based drag if there isn't a document
              Fixes rdar://problem/4960109
      
              * page/DragController.cpp:
              (WebCore::DragController::tryDocumentDrag):  
                 Null check m_document
              (WebCore::DragController::tryDHTMLDrag):
                 ASSERT(m_document) -- tryDocumentDrag is the only 
                 thing that will ever call us, but lets play it safe
                                        
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19699 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fc36a0a5
    • aroben's avatar
      Reviewed by Hyatt. · 9ecccef0
      aroben authored
              A little preparation for <rdar://problem/5006872>.
      
              * platform/PopupMenu.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19698 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9ecccef0
    • ap's avatar
      Reviewed by Adele. · 24fee341
      ap authored
              http://bugs.webkit.org/show_bug.cgi?id=12807
              XPath incorrectly converts NaN to boolean
      
              Test: fast/xpath/nan-to-boolean.html
      
              * xml/XPathValue.cpp:
              (WebCore::XPath::Value::toBoolean): Convert NaN to false.
              * xml/XPathFunctions.cpp:
              (WebCore::XPath::FunSubstringAfter::doEvaluate): Fix substring-after to actually work.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19697 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      24fee341
    • ap's avatar
      2007-02-18 Mitz Pettel <mitz@webkit.org> · 292f4dff
      ap authored
              Reviewed by Hyatt.
      
              - fix http://bugs.webkit.org/show_bug.cgi?id=12123
                REGRESSION: Incomplete repaint of floats' overflows
      
              Tests: fast/repaint/float-overflow.html
                     fast/repaint/float-overflow-right.html
                     fast/repaint/table-cell-vertical-overflow.html
      
              - fix http://bugs.webkit.org/show_bug.cgi?id=10116
                REGRESSION: Menu item drawn 2 pixels short on WWDC 2006 Attendee Site
      
              Reflected in existing test results.
      
              Unified floats and overflow for the purposes of painting and hit-testing.
              Overhanging and overflowing floats are now factored into a block's overflow
              unless their painting has been propagated to an ancestor.
      
              Changed table cells to no longer expand to enclose overflow, thus making
              it purely "visual overflow", having no effect on layout in WebCore. It
              still determines scrolling dimensions.
      
              * rendering/InlineFlowBox.cpp:
              (WebCore::InlineFlowBox::placeBoxesHorizontally): Include inline blocks'
              horizontal overflow in the inline box's dimensions.
              * rendering/RenderBlock.cpp:
              (WebCore::RenderBlock::layoutBlock): Removed the expand to enclose overflows
              behavior. Added code to add this block's floats (and their overflow) to its
              overflow rect if it is not in a block formatting context. Otherwise, the
              inclusion of floats in the overflow is deferred until this block's parent
              examines its floats and possibly adopts overhanging floats.
              (WebCore::RenderBlock::layoutBlockChildren):
              (WebCore::RenderBlock::paint): 
              (WebCore::RenderBlock::floatRect): Made non-virtual and changed to return an empty
              rect if there are no floats or the floats are clipped, instead of returning the border
              box.
              (WebCore::RenderBlock::addOverhangingFloats): Any floats of the child that
              are not to be painted by the parent are added to the child's overflow rect.
              (WebCore::RenderBlock::addVisualOverflow): Added. Adjusts the overflow
              bounds to include the given rect.
              (WebCore::RenderBlock::nodeAtPoint):
              * rendering/RenderBlock.h:
              * rendering/RenderFlexibleBox.cpp:
              (WebCore::RenderFlexibleBox::layoutBlock): 
              (WebCore::RenderFlexibleBox::layoutHorizontalBox): After placing a normal
              child, add its floats to its overflow, since painting of floats does not
              propagate to flexible boxes. 
              (WebCore::RenderFlexibleBox::layoutVerticalBox): Ditto.
              * rendering/RenderForeignObject.cpp:
              (WebCore::RenderForeignObject::layout):
              * rendering/RenderHTMLCanvas.cpp:
              (WebCore::RenderHTMLCanvas::layout):
              * rendering/RenderImage.cpp:
              (WebCore::RenderImage::layout):
              * rendering/RenderLayer.cpp:
              (WebCore::RenderLayer::updateLayerPositions):
              (WebCore::RenderLayer::absoluteBoundingBox):
              * rendering/RenderLayer.h:
              * rendering/RenderObject.cpp:
              (WebCore::RenderObject::repaintAfterLayoutIfNeeded):
              * rendering/RenderObject.h:
              (WebCore::RenderObject::expandsToEncloseOverhangingFloats):
              * rendering/RenderPath.cpp:
              (WebCore::RenderPath::layout):
              * rendering/RenderSVGContainer.cpp:
              (WebCore::RenderSVGContainer::layout):
              * rendering/RenderSVGText.cpp:
              (WebCore::RenderSVGText::layout):
              * rendering/RenderTable.h: Removed the override of overflowHeight() since now tables can have
              vertical overflow.
              * rendering/RenderTableCell.cpp:
              (WebCore::RenderTableCell::paint): Made sure that overflow is repainted.
              * rendering/RenderTableCell.h:
              (WebCore::RenderTableCell::expandsToEncloseOverhangingFloats): Removed.
              * rendering/RenderTableSection.cpp:
              (WebCore::RenderTableSection::RenderTableSection):
              (WebCore::RenderTableSection::layoutRows): Factor in vertical overflow from cells.
              (WebCore::RenderTableSection::paint):
              * rendering/RenderTableSection.h:
              (WebCore::RenderTableSection::overflowHeight):
              (WebCore::RenderTableSection::overflowTop):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19696 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      292f4dff
    • oliver's avatar
      2007-02-18 Oliver Hunt <oliver@apple.com> · 25027ebf
      oliver authored
              Reviewed by NOBODY (Buildfix).
      
              Build fix for the build fix -- can't call something that isn't a function
      
              * platform/qt/CursorQt.cpp:
              (WebCore::notAllowedCursor):
      
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19695 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      25027ebf
    • oliver's avatar
      2007-02-18 Oliver Hunt <oliver@apple.com> · 51f09bfa
      oliver authored
              Reviewed by NOBODY (Build fix).
      
              Adding platform/DragImage.cpp and platform/qt/DragImageQt.cpp to the Qt
              project files
      
              Stubbed method for WebCore::notAllowedCursor -- not sure what it should return, 
              have returned blank cursor, possibly needs to return something else
      
              * WebCore.pro:
              * platform/qt/CursorQt.cpp:
              (WebCore::notAllowedCursor):
      
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19694 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      51f09bfa
    • oliver's avatar
      2007-02-18 Oliver Hunt <oliver@apple.com> · 33cb99ee
      oliver authored
              Reviewed by NOBODY (Buildfix).
      
              Build fix -- adding DragClientQt method stubs
      
              * WebCoreSupport/DragClientQt.cpp:
              (WebCore::DragClientQt::willPerformDragSourceAction):
              (WebCore::DragClientQt::startDrag):
              (WebCore::DragClientQt::createDragImageForLink):
              * WebCoreSupport/DragClientQt.h:
      
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19693 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      33cb99ee
    • oliver's avatar
      2007-02-18 Oliver Hunt <oliver@apple.com> · f9779fce
      oliver authored
              Reviewed by NOBODY (Buildfix).
      
              Sigh, obnoxious occasional auto conversion from float to int
      
              * platform/mac/ClipboardMac.mm:
              (WebCore::ClipboardMac::createDragImage):
                                                        
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19692 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f9779fce
    • ap's avatar
      Reviewed by Hyatt. · e74d7f9e
      ap authored
              http://bugs.webkit.org/show_bug.cgi?id=12799
              REGRESSION: Webpage doesn't load correctly (www.cincinnati.com
              redirects to the wrong URL)
      
              Test: http/tests/misc/refresh-meta-with-newline.html
      
              * platform/network/HTTPParsers.cpp:
              (WebCore::skipWhiteSpace):
              (WebCore::parseHTTPRefresh):
              * platform/network/HTTPParsers.h:
              In HTML, all characters with codes <= 0x20 are whitespace, while in
              HTTP, only space and tab are such.
      
              * dom/Document.cpp:
              (WebCore::Document::processHttpEquiv):
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::receivedFirstData):
              Pass parseHTTPRefresh() a flag telling about the source of data.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19691 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e74d7f9e
    • oliver's avatar
      2007-02-18 Oliver Hunt <oliver@apple.com> · e587d104
      oliver authored
              Reviewed by NOBODY (Build fix).
      
              Buld fix -- surprisingly RetainPtr doesn't exist on Qt
      
              * platform/DragImage.h:
                                        
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19690 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e587d104
    • oliver's avatar
      2007-02-18 Oliver Hunt <oliver@apple.com> · cd54bad1
      oliver authored
              Reviewed by Adam.
      WebCore:
              More drag and drop migration, now the entirety of the
              drag initiation logic has been rendered platform independent
              This has required a number of new interfaces, and a reasonable
              amount of logic migration.
      
              As a side effect, this patch also fixes rdar://problem/4945341
      
              There are some basic Qt stubs that should stop the build from failing,
              however the absence of ClipboardQt means any attempt to initiate a drag 
              may cause a crash.
      
              * WebCore.exp:
                 Exporting new symbols
      
              * WebCore.xcodeproj/project.pbxproj:
                 New files
      
              * dom/Clipboard.cpp:
              (WebCore::Clipboard::canSaveAsWebArchive):
                Migrated from WebKit
      
              * dom/Clipboard.h:
                Added more methods to allow Clipboard to be used as a 
                platform independent container for drag and drop
      
              * page/DragClient.h:
              (WebCore::DragClient::declareAndWriteDragImage):
                This is a mac only helper function, so i've made it have an empty implementation,
                that way we won't need a PLATFORM(MAC) block in SVGImageEmptyClients
      
              * page/DragController.cpp:
              (WebCore::DragController::dragExited):
              (WebCore::DragController::performDrag):
              (WebCore::DragController::tryDocumentDrag): 
              (WebCore::DragController::tryDHTMLDrag):
                Using RefPtrs now
              (WebCore::getCachedImage):
              (WebCore::getImage):
                Helper functions                   
              (WebCore::dragLocForDHTMLDrag):
              (WebCore::dragLocForSelectionDrag):
              (WebCore::DragController::startDrag):
              (WebCore::DragController::doImageDrag):
              (WebCore::DragController::doSystemDrag):
                Logic that generates drag images and clipboard content, and
                initiates the actual system drag operation
      
              * page/DragController.h:
                Method and variable declarations
      
              * page/EventHandler.cpp:
              (WebCore::EventHandler::handleDrag):
                handleDrag is now platform independent
              (WebCore::EventHandler::handleTextInputEvent):
                 formatting
      
              * page/EventHandler.h:
              (WebCore::EventHandler::eventLoopHandleMouseDragged):
                Forgot to define this stub function 
      
              * page/Frame.h:
                Declaring dragImageForSelection to provide drag image for selected content
      
              * page/mac/DragControllerMac.mm:
                Defining drag images control vars
      
              * page/mac/EventHandlerMac.mm:
              (WebCore::EventHandler::createDraggingClipboard):
                Migrated old clipboard creation to here
      
              * page/mac/FrameMac.mm:
              (WebCore::Frame::dragImageForSelection):
                Wrap FrameMac::selectionImage
      
              * page/qt/DragControllerQt.cpp:
                Defining drag images control vars
      
              * page/qt/EventHandlerQt.cpp:
              (WebCore::EventHandler::createDraggingClipboard):
                stub
      
              * page/qt/FrameQt.cpp:
              (WebCore::Frame::dragImageForSelection):
                stub
      
              * platform/DragImage.cpp: Added.
              (WebCore::fitDragImageToMaxSize):
              (WebCore::createDragImageForSelection):
                 Platform independent processing for drag images
      
              * platform/DragImage.h: Added.
                 Declaring typedefs and wrapper functions to abstract the handling
                 of drag images 
      
              * platform/Pasteboard.h:
                Declaring extracted writeURL and writeSelection methods
      
              * platform/graphics/svg/SVGImageEmptyClients.h:
              (WebCore::SVGEmptyDragClient::willPerformDragSourceAction):
              (WebCore::SVGEmptyDragClient::startDrag):
              (WebCore::SVGEmptyDragClient::createDragImageForLink):
                Stubs FTW!
      
              * platform/mac/ClipboardMac.h:
              (WebCore::ClipboardMac::pasteboard):
                Provide accessor for underlying NSPasteboard
      
              * platform/mac/ClipboardMac.mm:
              (WebCore::ClipboardMac::hasData):
              (WebCore::ClipboardMac::writeRange):
              (WebCore::ClipboardMac::writeURL):
              (WebCore::ClipboardMac::declareAndWriteDragImage):
              (WebCore::ClipboardMac::createDragImage):
                 Implemented new Clipboarid functionality.
              (WebCore::ClipboardMac::dragNSImage):
                 Made this a const method
      
              * platform/mac/DragImageMac.mm: Added.
              (WebCore::dragImageSize):
              (WebCore::deleteDragImage):
              (WebCore::scaleDragImage):
              (WebCore::dissolveDragImageToFraction):
              (WebCore::createDragImageFromImage):
              (WebCore::createDragImageIconForCachedImage):
                 Implemented platform specific DragImage functions
      
              * platform/mac/PasteboardMac.mm:
              (WebCore::writeSelection):
              (WebCore::Pasteboard::writeSelection):
              (WebCore::writeURL):
              (WebCore::Pasteboard::writeURL):
                 Extracted member implementations of these functions, so that
                 Clipboard could also make use of this functionality.
                 Pasteboard methods now call the new non-member implementations.
                 Also fixed implementations to respect the list of requested types.
      
              * platform/qt/DragImageQt.cpp: Added.
              (WebCore::dragImageSize):
              (WebCore::deleteDragImage):
              (WebCore::scaleDragImage):
              (WebCore::dissolveDragImageToFraction):
              (WebCore::createDragImageFromImage):
              (WebCore::createDragImageIconForCachedImage):  
                Stubs
      
      WebKit:
              Moving the drag initiation logic to WebCore.
              The redundant code in webkit will be moved out in a later patch.
      
              * WebCoreSupport/WebDragClient.h:
              * WebCoreSupport/WebDragClient.mm:
              (getTopHTMLView):
                Helper function
              (WebDragClient::willPerformDragSourceAction):
              (WebDragClient::startDrag):
              (WebDragClient::createDragImageForLink):
                Implemented new DragClient methods
              (WebDragClient::declareAndWriteDragImage):
                Helper function for the Mac to allow new drag and drop
                code to match behaviour
                
              * WebView/WebHTMLView.mm:
              (-[WebHTMLView _dragImageForURL:withLabel:]):
              (-[WebHTMLView _dragImageForLinkElement:]):
                Refactoring old _dragImageForLinkElement function so that 
                the link drag image can be created with just a URL and label, 
                rather than requiring the original element
              (-[WebHTMLView dragImage:at:offset:event:pasteboard:source:slideBack:]):
                Removed logic that is no longer necessary                 
              (-[WebHTMLView _mouseDownEvent]):
                The WebDragClient may need the original mouseDownEvent of a drag when initiating
                a drag
              * WebView/WebHTMLViewInternal.h:
                Declaring _mouseDownEvent
      
              * WebView/WebHTMLViewPrivate.h:
                Declaring _dragImageForURL
                                              
            
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19689 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cd54bad1
    • ap's avatar
      2007-02-18 Kevin Ollivier <kevino@theolliviers.com> · d309cc7e
      ap authored
              Reviewed by Adam Roben.
      
              Fix cases where MSVC-specific code was identified as Win32 platform
              code. (as it should be compiled for e.g. wx port when using MSVC too)
              
              * wtf/Assertions.h: 
              * wtf/MathExtras.h:
              * wtf/StringExtras.h:
              changed PLATFORM(WIN) sections to COMPILER(MSVC) as necessary
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19688 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d309cc7e
  3. 17 Feb, 2007 10 commits
    • hyatt's avatar
      Fix textarea resizers to not fill with black by making sure the fill color starts off as · 7f6829ee
      hyatt authored
              transparent instead of black.
      
              Reviewed by aroben
      
              * platform/graphics/GraphicsContext.cpp:
              (WebCore::GraphicsContextState::GraphicsContextState):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19687 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7f6829ee
    • aroben's avatar
      Added missing Radar references to ChangeLogs. · a90311f4
      aroben authored
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19686 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a90311f4
    • aroben's avatar
      2007-02-17 Lars Knoll <lars@trolltech.com> · ed43c0aa
      aroben authored
      LayoutTests:
      
              Reviewed by Adam.
      
              test for http://bugs.webkit.org/show_bug.cgi?id=11476
              <img> tags nested inside <map> where not showing up
      
              * fast/images/image-in-map-expected.checksum: Added.
              * fast/images/image-in-map-expected.png: Added.
              * fast/images/image-in-map-expected.txt: Added.
              * fast/images/image-in-map.html: Added.
      
      WebCore:
      
              Reviewed by Adam.
      
              fix http://bugs.webkit.org/show_bug.cgi?id=11476
              <img> tags nested inside <map> where not showing up
      
              Test: fast/images/image-in-map.html
      
              * html/HTMLMapElement.cpp:
              (WebCore::HTMLMapElement::checkDTD):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19685 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ed43c0aa
    • weinig's avatar
      LayoutTests: · e2750b3c
      weinig authored
              Reviewed by Maciej.
      
              http://bugs.webkit.org/show_bug.cgi?id=12733
              XPath namespace is attached to a wrong step
      
              * fast/xpath/namespace-vs-predicate-expected.txt: Added.
              * fast/xpath/namespace-vs-predicate.xhtml: Added.
      
      WebCore:
      
              Reviewed by Maciej.
      
              http://bugs.webkit.org/show_bug.cgi?id=12733
              XPath namespace is attached to a wrong step
      
              * xml/XPathGrammar.y: NAMETEST is different from other NodeTests in that its
              resulting type is an expanded name, rather than a string. It is not really possible 
              to store the namespace inside Parser, because it gets used in wrong steps then.
      
              * xml/XPathParser.cpp:
              (WebCore::XPath::Parser::expandQName):
              * xml/XPathParser.h:
              Moved code that expands a QName from XPathGrammar.y. Removed m_currentNamespaceURI.
      
              * xml/XPathStep.cpp:
              (WebCore::XPath::Step::Step):
              * xml/XPathStep.h:
              Added a constructor that takes a namespace.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19684 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e2750b3c
    • adele's avatar
      LayoutTests: · 24f01150
      adele authored
              Reviewed by Maciej.
      
              - test for http://bugs.webkit.org/show_bug.cgi?id=12479
                ASSERTION FAILURE: resource->inCache() in WebCore::Cache::remove
      
              * fast/loader/resources/simultaneous-reloads-assert-frame.html: Added.
              * fast/loader/simultaneous-reloads-assert-expected.txt: Added.
              * fast/loader/simultaneous-reloads-assert.html: Added.
      
      WebCore:
      
              Reviewed by Maciej.
      
              - fix http://bugs.webkit.org/show_bug.cgi?id=12479
                ASSERTION FAILURE: resource->inCache() in WebCore::Cache::remove
      
              Test: fast/loader/simultaneous-reloads-assert.html
      
              * loader/Cache.cpp:
              (WebCore::Cache::remove): Replaced the assertion with a check whether the
              resource is in the cache. The resource could have been removed from the cache
              as a result of a reload occurring simultaneously in a different document.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19683 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      24f01150
    • adele's avatar
      Reviewed by Adam. · 44dd43b3
      adele authored
              Fix for http://bugs.webkit.org/show_bug.cgi?id=12711
              Prettier and more distinct cursors
      
              * Resources/crossHairCursor.png: Added.
              * Resources/northEastSouthWestResizeCursor.png:
              * Resources/northWestSouthEastResizeCursor.png:
              * Resources/notAllowedCursor.png: Added.
              * page/EventHandler.cpp: (WebCore::selectCursor):
              * platform/Cursor.h:
              * platform/mac/CursorMac.mm:
              (WebCore::crossCursor):
              (WebCore::notAllowedCursor):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19682 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      44dd43b3
    • adele's avatar
      LayoutTests: · 8c494ab4
      adele authored
              Reviewed by Darin.
      
              - test for http://bugs.webkit.org/show_bug.cgi?id=12780
                REGRESSION (r19341-r19385): Reproducible crash in "onselectstart" event
      
              * fast/events/shadow-boundary-crossing-expected.txt: Added.
              * fast/events/shadow-boundary-crossing.html: Added.
      
      WebCore:
      
              Reviewed by Darin.
      
              - fix http://bugs.webkit.org/show_bug.cgi?id=12780
                REGRESSION (r19341-r19385): Reproducible crash in "onselectstart" event
      
              Test: fast/events/shadow-boundary-crossing.html
      
              * dom/EventTargetNode.cpp:
              (WebCore::EventTargetNode::dispatchGenericEvent): Changed to use the new
              eventParentNode() function for constructing the chain of ancestors for
              capture and bubbling.
              * dom/Node.h:
              (WebCore::Node::eventParentNode): Added. Returns the node's parent for the
              purpose of of event capture and bubbling. The base class implementation is
              to return the parent node.
              * ksvg2/svg/SVGElement.h:
              (WebCore::SVGElement::eventParentNode): Added. Since in SVG events bubble
              to and can be captured across the shadow DOM boundary, returns the shadow parent
              for shadow nodes.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19681 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8c494ab4
    • hyatt's avatar
      Improve textarea resizer painting. · 82c49cb6
      hyatt authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19680 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      82c49cb6
    • kjk's avatar
      JavaScriptCore: · 67f5d5a8
      kjk authored
              Reviewed by Adam Roben.
      
              Fix crashes on ARM due to different struct packing. Based on a patch
              by Mike Emmel.
              * kjs/ustring.cpp: compile-time assert to make sure sizeof(UChar) == 2
              * kjs/ustring.h: pack UChar struct to ensure that sizeof(UChar) == 2
              * wtf/Assertions.h: add COMPILE_ASSERT macro for compile-time assertions
      
        WebCore:
      
              Reviewed by Adam Roben.
      
              Fix crashes on ARM due to different struct packing. Based on a patch
              from Mike Emmel.
      
              * platform/DeprecatedString.cpp: compile-time assert to make sure sizeof(DeprecatedChar) == 2
              * platform/DeprecatedString.h: pack DeprecatedChar struct to ensure that
              sizeof(DeprecatedChar) == 2. Move _internalBuffer in DeprecatedStringData
              to the end, to avoid crashes on ARM due to different struct packing.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19679 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      67f5d5a8
    • adele's avatar
      LayoutTests: · 81f23c3f
      adele authored
              Reviewed by Mitz.
      
              Fix for http://bugs.webkit.org/show_bug.cgi?id=11534
              <rdar://problem/4946947> REGRESSION: Readonly text fields don't scroll when selecting content
      
              * fast/forms/input-readonly-autoscroll-expected.checksum: Added.
              * fast/forms/input-readonly-autoscroll-expected.png: Added.
              * fast/forms/input-readonly-autoscroll-expected.txt: Added.
              * fast/forms/input-readonly-autoscroll.html: Added.
      
      WebCore:
      
              Reviewed by Mitz.
      
              Fix for http://bugs.webkit.org/show_bug.cgi?id=11534
              <rdar://problem/4946947> REGRESSION: Readonly text fields don't scroll when selecting content
      
              Test: fast/forms/input-readonly-autoscroll.html
      
              Implemented autoscroll methods for RenderTextControl, so this works on non-editable text controls.
      
              * rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::autoscroll):
              * rendering/RenderTextControl.h: (WebCore::RenderTextControl::shouldAutoscroll):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19678 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      81f23c3f