1. 28 Mar, 2008 15 commits
    • beidson@apple.com's avatar
      2008-03-28 Brady Eidson <beidson@apple.com> · 81a1e201
      beidson@apple.com authored
              Reviewed by Sam Weinig
      
              Fold [WebArchiver archiveFrame:] into WebDataSource - the last remaining caller
      
              * WebView/WebArchiver.h:
              * WebView/WebArchiver.mm:
              * WebView/WebDataSource.mm:
              (-[WebDataSource webArchive]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31402 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      81a1e201
    • beidson@apple.com's avatar
      2008-03-28 Brady Eidson <beidson@apple.com> · 788bbfa3
      beidson@apple.com authored
              Reviewed by Sam Weinig
      
              Remove unused [WebArchiver archiveNode:], made obsolete in r31400
      
              * WebView/WebArchiver.h:
              * WebView/WebArchiver.mm:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31401 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      788bbfa3
    • beidson@apple.com's avatar
      WebCore: · f4058d68
      beidson@apple.com authored
      2008-03-28  Brady Eidson  <beidson@apple.com>
      
              Reviewed by Darin
      
              "Yet another transitional step" to empty out WebKit-based code for archiving.
      
              With this patch, the key operation of "Creating a WebArchive rooted at a single Node" takes place
              entirely within WebCore, and opens the door to saving WebArchives on Windows.
      
              This is another "zero behavior change" patch, and current editing/ and webarchive/ layout tests
              covered the relevant code
      
              * WebCore.base.exp:
              * loader/archive/cf/LegacyWebArchive.cpp:
              (WebCore::LegacyWebArchive::create):
              * loader/archive/cf/LegacyWebArchive.h:
      
      WebKit/mac:
      
      2008-03-28  Brady Eidson  <beidson@apple.com>
      
              Reviewed by Darin
      
              "Yet another transitional step" to empty out WebKit-based code for archiving.
      
              With this patch, the key operation of "Creating a WebArchive rooted at a single Node" takes place
              entirely within WebCore, and opens the door to saving WebArchives on Windows.
      
              * DOM/WebDOMOperations.mm:
              * WebView/WebArchiver.mm:
              (+[WebArchiver _archiveWithMarkupString:fromFrame:nodes:]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31400 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f4058d68
    • alp@webkit.org's avatar
      2008-03-28 Jasper Bryant-Greene <jasper@unix.geek.nz> · 9df404ab
      alp@webkit.org authored
              Reviewed by Alp Toker.
      
              http://bugs.webkit.org/show_bug.cgi?id=18061
              PlatformScrollBarGtk attempts to allocate negative width and/or height for widgets
      
              Missing clampNegativeToZero() call meant that we tried to allocate widgets with negative width and/or height.
      
              * platform/gtk/PlatformScrollBarGtk.cpp:
              (PlatformScrollbar::geometryChanged):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31399 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9df404ab
    • beidson@apple.com's avatar
      JavaScriptCore: · 347c0326
      beidson@apple.com authored
      2008-03-28  Brady Eidson  <beidson@apple.com>
      
              Reviewed by Darin
      
              Export Unicode/UTF8.h and convertUTF16ToUTF8() for more flexible conversion in WebCore
      
              * JavaScriptCore.exp:
              * JavaScriptCore.xcodeproj/project.pbxproj:
      
      WebCore:
      
      2008-03-28  Brady Eidson  <beidson@apple.com>
      
              Reviewed by Darin
      
              Using convertUTF16ToUTF8() from WTF, add a helper function that gives you a UTF8 SharedBuffer
              created from a String.
      
              * ForwardingHeaders/wtf/unicode/UTF8.h: Added.
              * platform/text/PlatformString.h:
              * platform/text/String.cpp:
              (WebCore::utf8Buffer):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31398 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      347c0326
    • darin@apple.com's avatar
      2008-03-28 Darin Adler <darin@apple.com> · 3cd8ef7a
      darin@apple.com authored
              Reviewed by Adam.
      
              - eliminate a tiny bit of unnecessary refcount churn
      
              * bindings/js/JSEventTargetBase.cpp:
              (WebCore::eventNameForPropertyToken): Return const AtomicString&.
              * bindings/js/JSEventTargetBase.h:
              (WebCore::JSEventTargetBase::getValueProperty): Update for above change.
              (WebCore::JSEventTargetBase::putValueProperty): Ditto.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31397 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3cd8ef7a
    • darin@apple.com's avatar
      2008-03-28 Darin Adler <darin@apple.com> · 7e31bd16
      darin@apple.com authored
              Reviewed by Sam.
      
              * fast/encoding/invalid-xml-expected.txt: Update to reflect a true success.
              * fast/encoding/resources/invalid-xml.js: Eliminate race condition by not ending
              the test until the js-test-post.js script has loaded.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31396 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7e31bd16
    • ap@webkit.org's avatar
      Rubber-stamped by Brady. · 3f861464
      ap@webkit.org authored
              Enable server-side includes via AddHandler, hopefully making Apache 1.3 happy.
      
              * http/tests/misc/.htaccess:
              * http/tests/misc/resources/acid3/.htaccess:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31395 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3f861464
    • darin@apple.com's avatar
      2008-03-28 Darin Adler <darin@apple.com> · a083ef71
      darin@apple.com authored
              * building/build.html: Add another mention of using the Cygwin shell.
              * building/tools.html: Fix a typo on the name Cygwin.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31394 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a083ef71
    • ap@webkit.org's avatar
      Not reviewed. · 552ba9a2
      ap@webkit.org authored
              Enable mod_include for acid3.html - the previous check-in only had it in resources
              subdirectory.
      
              * http/tests/misc/.htaccess: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31393 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      552ba9a2
    • hausmann@webkit.org's avatar
      Fix the Qt build. · cfc1c913
      hausmann@webkit.org authored
      * rendering/Length.h: Include wtf/MathExtras.h for round().
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31392 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cfc1c913
    • eric@webkit.org's avatar
      Reviewed by mjs. · a7f130f8
      eric@webkit.org authored
              Add Acid3 test as an http test
              http://bugs.webkit.org/show_bug.cgi?id=18176
      
              * http/tests/misc/acid3-expected.checksum: Added.
              * http/tests/misc/acid3-expected.png: Added.
              * http/tests/misc/acid3-expected.txt: Added.
              * http/tests/misc/acid3.html: Added.
              * http/tests/misc/resources/acid3/.htaccess: Added.
              * http/tests/misc/resources/acid3/empty.css: Added.
              * http/tests/misc/resources/acid3/empty.html: Added.
              * http/tests/misc/resources/acid3/empty.png: Added.
              * http/tests/misc/resources/acid3/empty.txt: Added.
              * http/tests/misc/resources/acid3/empty.xml: Added.
              * http/tests/misc/resources/acid3/font.svg: Added.
              * http/tests/misc/resources/acid3/font.ttf: Added.
              * http/tests/misc/resources/acid3/instructions.inc: Added.
              * http/tests/misc/resources/acid3/reference.html: Added.
              * http/tests/misc/resources/acid3/reference.png: Added.
              * http/tests/misc/resources/acid3/support-a.png.404: Added.
              * http/tests/misc/resources/acid3/support-b.png: Added.
              * http/tests/misc/resources/acid3/support-c.png: Added.
              * http/tests/misc/resources/acid3/svg.xml: Added.
              * http/tests/misc/resources/acid3/xhtml.1: Added.
              * http/tests/misc/resources/acid3/xhtml.2: Added.
              * http/tests/misc/resources/acid3/xhtml.3: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31391 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a7f130f8
    • hyatt@apple.com's avatar
      Add layout tests for background position rounding. · 2cef50d4
      hyatt@apple.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31390 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2cef50d4
    • hyatt@apple.com's avatar
      2008-03-28 David Hyatt <hyatt@apple.com> · 4cac53aa
      hyatt@apple.com authored
              Fix a bug where background-position truncates instead of rounding when it evaluates to fractional
              pixel values.  This matches other browsers.
      
              Reviewed by maciej
      
              Added fast/backgrounds/background-position-rounding.html
      
              * rendering/Length.h:
              (WebCore::Length::calcValue):
              (WebCore::Length::calcMinValue):
              * rendering/RenderBox.cpp:
              (WebCore::RenderBox::calculateBackgroundImageGeometry):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31389 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4cac53aa
    • mrowe@apple.com's avatar
      2008-03-27 Darin Adler <darin@apple.com> · cb17bd09
      mrowe@apple.com authored
              Reviewed by Mark Rowe.
      
              <rdar://problem/5826236> Regular expressions with large nested repetition counts can have their
              compiled length calculated incorrectly.
      
              * pcre/pcre_compile.cpp:
              (multiplyWithOverflowCheck):
              (calculateCompiledPatternLength): Check for overflow when dealing with nested repetition counts
              and bail with an error rather than returning incorrect results.
      
      2008-03-27  Mark Rowe  <mrowe@apple.com>
      
              Reviewed by Adam Roben.
      
              Tests for <rdar://problem/5826236> Regular expressions with large nested repetition counts can have their
              compiled length calculated incorrectly.
      
              * fast/js/regexp-overflow-expected.txt:
              * fast/js/resources/regexp-overflow.js:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31388 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cb17bd09
  2. 27 Mar, 2008 14 commits
  3. 26 Mar, 2008 11 commits
    • beidson@apple.com's avatar
      2008-03-26 Brady Eidson <beidson@apple.com> · 587de2f4
      beidson@apple.com authored
              Build fix - accidentally checked in this change which was work in progress
      
              * DOM/WebDOMOperations.mm:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31365 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      587de2f4
    • mrowe@apple.com's avatar
      Mac build fix. · af2d5c36
      mrowe@apple.com authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31363 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      af2d5c36
    • mjs@apple.com's avatar
      2008-03-26 Maciej Stachowiak <mjs@apple.com> · 8a60bfe8
      mjs@apple.com authored
              More screenshots for teh blog.
      
              * blog-files/acid3-full-rendering-pass.png: Added.
              * blog-files/acid3-rendering-reference.png: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31360 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8a60bfe8
    • weinig@apple.com's avatar
      2008-03-26 Sam Weinig <sam@webkit.org> · 44787447
      weinig@apple.com authored
              Try and fix Gtk+ again.
      
              * GNUmakefile.am:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31359 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      44787447
    • mitz@apple.com's avatar
      Reviewed by Dave Hyatt. · 812d9e3e
      mitz@apple.com authored
              - fix <rdar://problem/5816522> REGRESSION (r30111-30112): Tahoe web cam website has some text in Chinese or japanese
      
              * html/HTMLParser.cpp:
              (WebCore::HTMLParser::insertNode): Added call to beginParsingChildren()
              on the new node.
              (WebCore::HTMLParser::handleError): Ditto.
              (WebCore::HTMLParser::reopenResidualStyleTags): Ditto.
              (WebCore::HTMLParser::pushBlock): Removed incorrect call to
              beginParsingChildren() on the current node.
              * manual-tests/applet-finish-parsing-children.html: Added.
              * manual-tests/resources/DrawMessage.class: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31358 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      812d9e3e
    • beidson@apple.com's avatar
      WebCore: · a4fb38f9
      beidson@apple.com authored
      2008-03-26  Brady Eidson  <beidson@apple.com>
      
              Reviewed by Darin
      
              When we create a WebArchive, we walk every node from some starting point, asking each node
              along the way "What are your subresource URLs?"
      
              That logic is currently in DOMNode in WebKitMac - this patch moves that ability down into
              WebCore::Node
      
              * WebCore.base.exp:
              
              * dom/Node.cpp:
              (WebCore::Node::getSubresourceURLs):
              (WebCore::Node::getSubresourceAttributeStrings):  Virtual and empty.  Subclasses of Node that have 
                subresources will override it.
      
              * dom/ProcessingInstruction.cpp:
              (WebCore::ProcessingInstruction::getSubresourceAttributeStrings):
              * dom/ProcessingInstruction.h:
              * html/HTMLBodyElement.cpp:
              (WebCore::HTMLBodyElement::getSubresourceAttributeStrings):
              * html/HTMLBodyElement.h:
              * html/HTMLEmbedElement.cpp:
              (WebCore::HTMLEmbedElement::getSubresourceAttributeStrings):
              * html/HTMLEmbedElement.h:
              * html/HTMLImageElement.cpp:
              (WebCore::HTMLImageElement::getSubresourceAttributeStrings):
              * html/HTMLImageElement.h:
              * html/HTMLInputElement.cpp:
              (WebCore::HTMLInputElement::getSubresourceAttributeStrings):
              * html/HTMLInputElement.h:
              * html/HTMLLinkElement.cpp:
              (WebCore::HTMLLinkElement::getSubresourceAttributeStrings):
              * html/HTMLLinkElement.h:
              * html/HTMLObjectElement.cpp:
              (WebCore::HTMLObjectElement::getSubresourceAttributeStrings):
              * html/HTMLObjectElement.h:
              * html/HTMLParamElement.cpp:
              (WebCore::HTMLParamElement::getSubresourceAttributeStrings):
              * html/HTMLParamElement.h:
              * html/HTMLScriptElement.cpp:
              (WebCore::HTMLScriptElement::getSubresourceAttributeStrings):
              * html/HTMLScriptElement.h:
              * html/HTMLTableCellElement.cpp:
              (WebCore::HTMLTableCellElement::getSubresourceAttributeStrings):
              * html/HTMLTableCellElement.h:
              * html/HTMLTableElement.cpp:
              (WebCore::HTMLTableElement::getSubresourceAttributeStrings):
              * html/HTMLTableElement.h:
              * svg/SVGCursorElement.cpp:
              (WebCore::SVGCursorElement::getSubresourceAttributeStrings):
              * svg/SVGCursorElement.h:
              * svg/SVGFEImageElement.cpp:
              (WebCore::SVGFEImageElement::getSubresourceAttributeStrings):
              * svg/SVGFEImageElement.h:
              * svg/SVGImageElement.cpp:
              (WebCore::SVGImageElement::getSubresourceAttributeStrings):
              * svg/SVGImageElement.h:
              * svg/SVGScriptElement.cpp:
              (WebCore::SVGScriptElement::getSubresourceAttributeStrings):
              * svg/SVGScriptElement.h:
      
      WebKit/mac:
      
      2008-03-26  Brady Eidson  <beidson@apple.com>
      
              Reviewed by Darin
      
              When we create a WebArchive, we walk every node from some starting point, asking each node
              along the way "What are your subresource URLs?"
      
              That logic is currently in DOMNode in WebKitMac - this patch moves that ability down into
              WebCore::Node
      
              * DOM/WebDOMOperations.mm:
              (-[DOMNode _subresourceURLs]): One generic DOMNode method can now handle all DOMNodes by
                calling into individual WebCore::Node implementations
              * DOM/WebDOMOperationsPrivate.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31357 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a4fb38f9
    • mitz@apple.com's avatar
      Reviewed by Dave Hyatt. · 0f1089e8
      mitz@apple.com authored
              - maintain subpixel-antialiasing when drawing text with a simple shadow
      
              * platform/graphics/mac/FontMac.mm:
              (WebCore::Font::drawComplexText): If the shadow has a zero blur radius,
              draw the shadow by drawing the text at an offset instead of relying on
              Core Graphics shadows.
              (WebCore::Font::drawGlyphs): Ditto.
              * platform/graphics/win/FontCGWin.cpp:
              (WebCore::Font::drawGlyphs): Ditto.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31356 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0f1089e8
    • beidson@apple.com's avatar
      WebCore: · b00be861
      beidson@apple.com authored
      2008-03-26  Brady Eidson  <beidson@apple.com>
      
              Reviewed by Mark Rowe
      
              Part of the continued push to move WebArchive-related code down to WebCore, this
              moves [WebDataSource subresourceForURL:] down to DocumentLoader->subresource()
      
              * WebCore.base.exp:
              * loader/DocumentLoader.cpp:
              (WebCore::DocumentLoader::subresource): Create an ArchiveResource from a CachedResource if it exists
                Otherwise, fallback to an ArchiveResource from the current Archive if any.  Otherwise, return null
              * loader/DocumentLoader.h:
      
              * loader/archive/ArchiveResource.cpp:
              (WebCore::ArchiveResource::create):
              (WebCore::ArchiveResource::ArchiveResource):
              * loader/archive/ArchiveResource.h:
      
      WebKit/mac:
      
      2008-03-26  Brady Eidson  <beidson@apple.com>
      
              Reviewed by Mark Rowe
      
              Part of the continued push to move WebArchive-related code down to WebCore, this
              moves [WebDataSource subresourceForURL:] down to DocumentLoader->subresource()
      
              * WebView/WebDataSource.mm:
              (-[WebDataSource subresourceForURL:]): Call through to the DocumentLoader 
      
              * WebView/WebFrame.mm: Remove [WebFrame _getData:andResponse:forURL:], as its only use
                has now been ported down to WebCore
              * WebView/WebFrameInternal.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31355 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b00be861
    • weinig@apple.com's avatar
      2008-03-26 Sam Weinig <sam@webkit.org> · d668403d
      weinig@apple.com authored
              Fix Gtk+ build.
      
              * GNUmakefile.am:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31354 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d668403d
    • mrowe@apple.com's avatar
      Update FEATURE_DEFINES to be consistent with the other locations in which it is defined. · 3ad3f4ac
      mrowe@apple.com authored
      Rubber-stamped by Brady Eidson.
      
      * Configurations/JavaScriptCore.xcconfig:
      * Configurations/WebCore.xcconfig:
      * Configurations/WebKit.xcconfig:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31353 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3ad3f4ac
    • pewtermoose@webkit.org's avatar
      WebCore: · 7b026990
      pewtermoose@webkit.org authored
      2008-03-26  Brent Fulgham  <bfulgham@gmail.com>
      
              Reviewed by Adam Roben.
      
              Add necessary files and build commands to vcproj files to
              build a Curl-based Windows WebKit.  For details, see
              http://bugs.webkit.org/show_bug.cgi?id=17985
      
              * WebCore.vcproj/WebCore.vcproj:
      
      WebKit/win:
      
      2008-03-26  Brent Fulgham  <bfulgham@gmail.com>
      
              Reviewed by Adam Roben.
      
              Add necessary files and build commands to vcproj files to
              build a Curl-based Windows WebKit.  For details, see
              http://bugs.webkit.org/show_bug.cgi?id=17985
      
              * WebKit.vcproj/WebKit.vcproj:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31352 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7b026990