1. 12 Nov, 2007 1 commit
  2. 11 Nov, 2007 4 commits
    • mitz@apple.com's avatar
      WebCore: · cb71b59e
      mitz@apple.com authored
              Reviewed by Adam Roben.
      
              - fix http://bugs.webkit.org/show_bug.cgi?id=15942
                REGRESSION: Selecting "Edit Html" tab in Blogger causes crash (Assertion failed: isRange())
      
              Test: editing/selection/cleared-by-relayout.html
      
              * editing/Selection.cpp:
              (WebCore::Selection::toRange): Check if the selection has been cleared
              by updating layout.
      
      LayoutTests:
      
              Reviewed by Adam Roben.
      
              - test for http://bugs.webkit.org/show_bug.cgi?id=15942
                REGRESSION: Selecting "Edit Html" tab in Blogger causes crash (Assertion failed: isRange())
      
              * editing/selection/cleared-by-relayout-expected.txt: Added.
              * editing/selection/cleared-by-relayout.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27706 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cb71b59e
    • antti's avatar
      WebCore: · 2e25dae5
      antti authored
              Reviewed by Darin.
              
              - Update play() and pause() to match current HTML5 draft
                  - send events asynchronously
                  - add timeupdate event to pause
                  - rethrow load() exception, not others
              - Use list for async events to get ordering right
      
              Tests: media/video-pause-empty-events.html
                     media/video-play-empty-events.html
                     media/video-play-pause-events.html
                     media/video-play-pause-exception.html
      
              * html/HTMLMediaElement.cpp:
              (WebCore::HTMLMediaElement::dispatchEventAsync): 
              (WebCore::HTMLMediaElement::asyncEventTimerFired):
              (WebCore::HTMLMediaElement::play):
              (WebCore::HTMLMediaElement::pause):
              * html/HTMLMediaElement.h:
      
      LayoutTests:
      
              Reviewed by Darin.
              
              Add tests for play() and pause() events. 
              Update one test to match new behavior.
      
              * media/video-currentTime-expected.txt:
              * media/video-currentTime.html:
              * media/video-pause-empty-events-expected.txt: Added.
              * media/video-pause-empty-events.html: Added.
              * media/video-play-empty-events-expected.txt: Added.
              * media/video-play-empty-events.html: Added.
              * media/video-play-pause-events-expected.txt: Added.
              * media/video-play-pause-events.html: Added.
              * media/video-play-pause-exception-expected.txt: Added
              * media/video-play-pause-exception.html: Added
              * media/video-test.js:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27696 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2e25dae5
    • zimmermann@webkit.org's avatar
      Reviewed by Eric. · de7e844e
      zimmermann@webkit.org authored
      Fixes: http://bugs.webkit.org/show_bug.cgi?id=6424 (<text>, <tspan> dominant-baseline attribute is not respected)
      
      Add (basic) support for dominant-baseline / alignment-baseline text properties.
      Note: there are no official testcases, and no-one implemented it before. Only ASV3
            supported dominant-baseline, but not correct it seems.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27692 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      de7e844e
    • aroben@apple.com's avatar
      Fix <rdar://5133816> keepWebHistory is not implemented · 4c6a0a37
      aroben@apple.com authored
       WebCore:
      
               Add wrappers around CoCreateInstance to COMPtr
      
               I followed the example of the Query constructor and query method by
               adding a Create constructor and create method.
      
               Reviewed by Darin.
      
               * platform/win/COMPtr.h:
               (COMPtr::COMPtr): Added a new constructor that calls
               CoCreateInstance.
               (COMPtr::create): Added.
               (COMPtr::createInstance): Added.
      
       WebKitTools:
      
               Fix <rdar://5133816> keepWebHistory is not implemented
      
               Fixes fast/history/clicked-link-is-visited.html.
      
               Reviewed by Darin.
      
               * DumpRenderTree/win/DumpRenderTree.cpp:
               (runTest): Clear the optionalSharedHistory.
               * DumpRenderTree/win/LayoutTestControllerWin.cpp:
               (LayoutTestController::keepWebHistory): Set the optionalSharedHistory.
      
       LayoutTests:
      
               Remove a now-passing test from the Windows Skipped file
      
               Reviewed by Darin.
      
               * platform/win/Skipped:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27691 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4c6a0a37
  3. 10 Nov, 2007 7 commits
    • darin@apple.com's avatar
    • zimmermann@webkit.org's avatar
      Reviewed by Eric. · d5ab4fa9
      zimmermann@webkit.org authored
      Fixes: http://bugs.webkit.org/show_bug.cgi?id=15937 (Add glyph-orientation-horizontal/vertical support)
      Fixes: http://bugs.webkit.org/show_bug.cgi?id=13971 (text-anchor support on vertical text seems slightly off)
      
      Add glyph-orientation-* support for text & textPath. (90/180/270 and 'auto')
      Also fix all vertical text handling - for text & textPath! (especially latin1 characters auto orientation in vertical writing modes)
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27680 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d5ab4fa9
    • zimmermann@webkit.org's avatar
      Rubberstamped by Eric. · 436422be
      zimmermann@webkit.org authored
      Update some SVG pixel test results - which show changes lately -> repainting fixes.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27679 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      436422be
    • darin@apple.com's avatar
      JavaScriptCore: · 42667586
      darin@apple.com authored
              Reviewed by Sam.
      
              - fix http://bugs.webkit.org/show_bug.cgi?id=15927
                REGRESSION(r27487): delete a.c followed by __defineGetter__("c", ...) incorrectly deletes another property
                and <rdar://problem/5586384> REGRESSION (r27487): Can't switch out of Edit HTML Source mode on Leopard Wiki
      
              Test: fast/js/delete-then-put.html
      
              * kjs/property_map.cpp:
              (KJS::PropertyMap::put): Added a missing "- 1"; code to find an empty slot was not working.
              (KJS::PropertyMap::checkConsistency): Added a missing range check that would have caught this
              problem before.
      
              - roll out a last-minute change to my evaluateToBoolean patch that was incorrect.
      
              * kjs/nodes.h: (KJS::ExprStatementNode::ExprStatementNode): Take out call to
              optimizeForUnnecessaryResult, since the result is used in some cases.
      
      LayoutTests:
      
              Reviewed by Sam.
      
              - test for http://bugs.webkit.org/show_bug.cgi?id=15927
                delete a.c followed by __defineGetter__("c", ...) incorrectly deletes another property
      
              * fast/js/delete-then-put-expected.txt: Added.
              * fast/js/delete-then-put.html: Added.
              * fast/js/resources/delete-then-put.js: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27678 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      42667586
    • weinig@apple.com's avatar
      WebKitTools: · 0be8d5fe
      weinig@apple.com authored
              Reviewed by Tim Hatcher.
      
              Follow up to <rdar://problem/5394877> Safari should not log unsafe JavaScript 
              attempts when in private browsing mode (only an issue if Log JavaScript Exceptions 
              is turned on)
      
              - Add LayoutTestController.setPrivateBrowsingEnabled(bool) (stub out implementation for windows)
      
              Added test: http/tests/security/cross-frame-access-private-browsing.html
      
              * DumpRenderTree/LayoutTestController.cpp:
              (setPrivateBrowsingEnabledCallback):
              (LayoutTestController::staticFunctions):
              * DumpRenderTree/LayoutTestController.h:
              * DumpRenderTree/mac/DumpRenderTree.mm:
              (runTest): Default to private browsing disabled.
              * DumpRenderTree/mac/LayoutTestControllerMac.mm:
              (LayoutTestController::setPrivateBrowsingEnabled):
              * DumpRenderTree/win/LayoutTestControllerWin.cpp:
              (LayoutTestController::setPrivateBrowsingEnabled):
      
      LayoutTests:
      
              Reviewed by Tim Hatcher.
      
              Follow up to <rdar://problem/5394877> Safari should not log unsafe JavaScript 
              attempts when in private browsing mode (only an issue if Log JavaScript Exceptions 
              is turned on)
      
              Test using the new LayoutTestController.setPrivateBrowsingEnabled(bool)
      
              * http/tests/security/cross-frame-access-private-browsing-expected.txt: Added.
              * http/tests/security/cross-frame-access-private-browsing.html: Added.
              * platform/win/Skipped: Add new test to windows skip list until we have an
              implementation of LayoutTestController.setPrivateBrowsingEnabled(bool) for it.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27676 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0be8d5fe
    • ap@webkit.org's avatar
      Reviewed by Darin. · e962e996
      ap@webkit.org authored
              http://bugs.webkit.org/show_bug.cgi?id=15922
              Implement more of Mozilla Selection API
      
              Tests: editing/selection/containsNode.html
                     editing/selection/deleteFromDocument.html
                     editing/selection/extend.html
                     editing/selection/selectAllChildren.html
      
              * editing/SelectionController.cpp:
              (WebCore::SelectionController::deleteFromDocument):
              (WebCore::SelectionController::containsNode):
              (WebCore::SelectionController::selectAllChildren):
              (WebCore::SelectionController::extend):
              * editing/SelectionController.h:
              Added deleteFromDocument(), containsNode(), and selectAllChildren(). Reimplemented extend(),
              which existed, but didn't match Firefox behavior and wasn't exposed via bindings.
              Removed a comment mentioning removeRange(), as this method makes no sense without multiple
              selection range support.
      
              * page/DOMSelection.cpp:
              (WebCore::DOMSelection::extend):
              (WebCore::DOMSelection::deleteFromDocument):
              (WebCore::DOMSelection::containsNode):
              (WebCore::DOMSelection::selectAllChildren):
              * page/DOMSelection.h:
              * page/DOMSelection.idl:
              Exposed the new methods.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27666 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e962e996
    • ap@webkit.org's avatar
      Reviewed by Darin. · fa296d6a
      ap@webkit.org authored
              http://bugs.webkit.org/show_bug.cgi?id=15892
              DOM Range operations are not implemented for ProcessingInstruction nodes
      
              Test: fast/dom/Range/range-processing-instructions.html
      
              * dom/Range.cpp:
              (WebCore::Range::processContents): Implemented ProcessingInstruction cases.
              (WebCore::Range::checkNodeWOffset): Removed a FIXME - yes, I think that we are supposed
              to use ProcessingInstruction.data.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27665 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fa296d6a
  4. 09 Nov, 2007 4 commits
    • tristan's avatar
      Reviewed by Sam Weinig. · 5decd396
      tristan authored
              * fast/dom/Window/window-resize-nan.html: Removed.
              * fast/dom/Window/window-resize-nan.html-disabled: Copied from fast/dom/Window/window-resize-nan.html.
              
              Disabled nan test until window resize issues can be resolved.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27657 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5decd396
    • aroben@apple.com's avatar
      Fix <rdar://5483519> Pressing Enter on selected buttons should fire onclick · 745cedc5
      aroben@apple.com authored
       LayoutTests:
      
               Add a test for <rdar://5483519> Pressing Enter on selected buttons should fire onclick
      
               Reviewed by Adele.
      
               * fast/forms/enter-clicks-buttons-expected.txt: Added.
               * fast/forms/enter-clicks-buttons.html: Added.
      
       WebCore:
      
               Fix <rdar://5483519> Pressing Enter on selected buttons should fire onclick
      
               We now match the behavior of Firefox and IE, which is to always just
               send a click event to the focused button when the Enter key is pressed
               (previously we were submitting forms directly in some cases).
      
               Reviewed by Adele.
      
               Test: fast/forms/enter-clicks-buttons.html
      
               * html/HTMLButtonElement.cpp:
               (WebCore::HTMLButtonElement::defaultEventHandler): Don't do anything
               fancy when Enter is pressed on a <button type=button> -- just send a
               click event like we do for other button types.
               * html/HTMLInputElement.cpp:
               (WebCore::HTMLInputElement::defaultEventHandler): Treat type=button
               the same way we treat type=submit and type=reset: just send a click
               event when Enter is pressed.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27652 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      745cedc5
    • mitz@apple.com's avatar
      WebCore: · 5a4bdf3e
      mitz@apple.com authored
              Reviewed by Antti Koivisto.
      
              - fix a bug in invisible layer culling: dynamically changing a 
                descendant of an invisible layer to be visible did not work
      
              Test: fast/layers/layer-content-visibility-change.html
      
              * rendering/RenderLayer.cpp:
              (WebCore::RenderLayer::setHasVisibleContent): If we got visible content,
              make sure that our stacking context rebuilds its z-order lists to
              include us.
      
      LayoutTests:
      
              Reviewed by Antti Koivisto.
      
              - test that dynamically changing a descendant of an invisible layer to
                be visible works
      
              * fast/layers/layer-content-visibility-change.html: Added.
              * platform/mac/fast/layers/layer-content-visibility-change-expected.checksum: Added.
              * platform/mac/fast/layers/layer-content-visibility-change-expected.png: Added.
              * platform/mac/fast/layers/layer-content-visibility-change-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27651 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5a4bdf3e
    • bdakin@apple.com's avatar
      WebCore: · 58730d7c
      bdakin@apple.com authored
              Reviewed by Oliver.
      
              Fix for <rdar://problem/5586370> CSS Transform - incorrect matrix 
              math leads to crazy problems
      
              Transform matrices accept the first four parameters as CSS lengths. 
              CSS lengths get mapped into WebCore::Lengths as percents by 
              WebCore::convertToLength(). Percent lengths cannot call value(). It 
              does not yield a correct result and it asserts on Debug builds. 
      
              * rendering/RenderStyle.h:
              (WebCore::MatrixTransformOperation::apply): Instead of calling 
              value() on the lengths, call calcValue. This fixes the assert and 
              the bad rendering. 
      
      LayoutTests:
      
              Reviewed by Oliver.
      
              Test for <rdar://problem/5586370> CSS Transform - incorrect matrix 
              math leads to crazy problems
      
              * fast/transforms/identity-matrix.html: Added.
              * platform/mac/fast/transforms/identity-matrix-expected.checksum: Added.
              * platform/mac/fast/transforms/identity-matrix-expected.png: Added.
              * platform/mac/fast/transforms/identity-matrix-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27649 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      58730d7c
  5. 08 Nov, 2007 3 commits
    • oliver's avatar
      Fix regression caused by earlier bitwise and optimisation. 1 & undefined != 1. · e7f10a33
      oliver authored
      Reviewed by Maciej.
      
      The implementation of JSImmediate::areBothImmediateNumbers relies on
      (JSImmediate::getTag(immediate1) & JSImmediate::getTag(immediate2)) having
      a unique result when both immediate values are numbers.
      
      The regression was due to UndefinedType & NumberType returning NumberType (3 & 1).
      By swapping the value of NumberType and UndefinedType this ceases to be a problem.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27630 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e7f10a33
    • mitz@apple.com's avatar
      WebCore: · 4a05631a
      mitz@apple.com authored
              Reviewed by Beth Dakin.
      
              - fix <rdar://problem/5491922> REGRESSION (Safari 2-3): Flash-based "Cash Optimizer" on etrade.com does not draw completely
      
              Test: fast/dom/length-attribute-mapping.html
      
              * dom/StyledElement.cpp:
              (WebCore::StyledElement::addCSSLength): Changed the garbage-stripping
              logic to stop after the first "%" or "*" in the string. This allows for
              "100%25" to be mapped to "100%" like it is in Firefox and WinIE.
      
      LayoutTests:
      
              Reviewed by Beth Dakin.
      
              - test for <rdar://problem/5491922> REGRESSION (Safari 2-3): Flash-based "Cash Optimizer" on etrade.com does not draw completely
      
              * fast/dom/length-attribute-mapping-expected.txt: Added.
              * fast/dom/length-attribute-mapping.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27617 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4a05631a
    • darin@apple.com's avatar
      WebCore: · 568b8655
      darin@apple.com authored
              Reviewed by Adam.
      
              - fix <rdar://problem/5552943> accesskey does not focus <button> elements
      
              Test: fast/forms/access-key.html
      
              * html/HTMLButtonElement.cpp: (WebCore::HTMLButtonElement::accessKeyAction):
              Added a call to focus.
      
      LayoutTests:
      
              Reviewed by Adam.
      
              - test changes for <rdar://problem/5552943> accesskey does not focus <button> elements
      
              * fast/forms/access-key.html: Check for both focus and click events on all elements, but
              resisted the urge to switch to the American spelling for "focused".
      
              * fast/forms/access-key-expected.txt: Updated to reflect the bug fix ("1 button focussed"),
              the fact that <input type=button>, <input type=checkbox>, <input type=submit>, and
              <input type=reset> are all both focused and clicked ("2 input type button clicked",
              "3 input type checkbox clicked", "5 input type submit focussed", and
              "6 input type reset focussed"). Unfortunately this now also demonstrates that we don't
              send a click to <input type=text> and Gecko does. And there are still quite a few types
              that are not covered.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27599 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      568b8655
  6. 07 Nov, 2007 12 commits
    • ddkilzer's avatar
      WebCore: · 8b549c4c
      ddkilzer authored
              WebKit confuses width/height for Media Queries device-aspect-ratio evaluation
              <http://bugs.webkit.org/show_bug.cgi?id=14893>
              <rdar://problem/5380295>
      
              Reviewed by Darin.
      
              Tests: fast/css/device-aspect-ratio.html
                     fast/css/max-device-aspect-ratio.html
                     fast/css/min-device-aspect-ratio.html
      
              * css/MediaQueryEvaluator.cpp:
              (WebCore::parseAspectRatio): Renamed method parameters from a/b to h/v.
              (WebCore::device_aspect_ratioMediaFeatureEval): Renamed local variables from
              a/b to h/v.  Switched first two arguments of the call to cmpvalue() to fix
              the bug.
      
      LayoutTests:
      
              WebKit confuses width/height for Media Queries device-aspect-ratio evaluation
              <http://bugs.webkit.org/show_bug.cgi?id=14893>
              <rdar://problem/5380295>
      
              Reviewed by Darin.
      
              Each of the following tests creates a <link> element and dynamically sets its
              media query based on the aspect ratio (width/height) of the current screen.
              When the <link> element is attached to the <head> node, the test expects the
              stylesheet to be loaded for the test to pass.
      
              * fast/css/device-aspect-ratio-expected.txt: Added.
              * fast/css/device-aspect-ratio.html: Added.
      
              This test sets the device-aspect-ratio to the current size of the screen.
              NOTE: This test passed before the fix.
      
              * fast/css/max-device-aspect-ratio-expected.txt: Added.
              * fast/css/max-device-aspect-ratio.html: Added.
      
              This test sets the max-device-aspect ratio to 100/1 for landscape monitors or
              1/1 for portrait (or square) monitors.
              NOTE: This test failed before the fix.
      
              * fast/css/min-device-aspect-ratio-expected.txt: Added.
              * fast/css/min-device-aspect-ratio.html: Added.
      
              This test sets the min-device-aspect ratio to 1/1 for landscape monitors or
              1/100 for portrait (or square) monitors.
              NOTE: This test failed before the fix.
      
              * fast/css/resources/device-aspect-ratio.css: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27581 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8b549c4c
    • mitz@apple.com's avatar
      WebCore: · 6201fc44
      mitz@apple.com authored
              Reviewed by Dave Hyatt.
      
              - fix http://bugs.webkit.org/show_bug.cgi?id=15887
                REGRESSION (r27576): Crash in RenderStyle::affectedByHoverRules clicking link on Digg
      
              Test: fast/css/display-none-inline-style-change-crash.html
      
              * dom/Element.cpp:
              (WebCore::Element::recalcStyle): Fixed the crash by null-checking
              the current style and removed other checks that are not strictly
              necessary.
      
      LayoutTests:
      
              Reviewed by Dave Hyatt.
      
              - test for http://bugs.webkit.org/show_bug.cgi?id=15887
                REGRESSION (r27576): Crash in RenderStyle::affectedByHoverRules clicking link on Digg
      
              * fast/css/display-none-inline-style-change-crash-expected.txt: Added.
              * fast/css/display-none-inline-style-change-crash.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27579 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6201fc44
    • mitz@apple.com's avatar
      WebCore: · 9e8a8657
      mitz@apple.com authored
              Reviewed by Darin Adler.
      
              - fix a bug where CSS rules with :hover in the ancestor chain stopped
                working after changing the inline style declaration of the ancestor
      
              Test: fast/css/affected-by-hover-after-style-change.html
      
              * dom/Element.cpp:
              (WebCore::Element::recalcStyle): If we are not forcing style
              recalculation for all descendants, preserve any "affected by
              {hover|active|drag} bits that we may have acquired from them.
              Also renamed _style to currentStyle.
      
      WebKitSite:
      
              Reviewed by Darin Adler.
      
              - removed a workaround for the bug fixed in the WebCore part of this
                patch
      
              * misc/DatabaseExample.html:
      
      LayoutTests:
      
              Reviewed by Darin Adler.
      
              - test that CSS rules with :hover in the ancestor chain continue to work
                after changing the inline style declaration of the ancestor
      
              * fast/css/affected-by-hover-after-style-change.html: Added.
              * platform/mac/fast/css/affected-by-hover-after-style-change-expected.checksum: Added.
              * platform/mac/fast/css/affected-by-hover-after-style-change-expected.png: Added.
              * platform/mac/fast/css/affected-by-hover-after-style-change-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27576 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9e8a8657
    • ggaren@apple.com's avatar
      JavaScriptCore: · 8a50ec54
      ggaren@apple.com authored
              Reviewed by Darin Adler.
              
              Fixed part of http://bugs.webkit.org/show_bug.cgi?id=15861 
              15% of string-validate-input.js is spent compiling the same regular expression.
      
              Put RegExpImp properties into a static hashtable to avoid a slew of
              PropertyMap churn when creating a RegExpImp.
              
              Factored important bits of regular expression implementation out of
              RegExpImp (the JS object) and into RegExp (the PCRE wrapper class), 
              making RegExp a ref-counted class. (This will help later.)
      
              Removed PCRE_POSIX support because I didn't quite know how to test it 
              and keep it working with these changes.
              
              1.1% SunSpider speedup. 5.8% speedup on string-validate-input.js.
      
              * kjs/regexp.h: A few interface changes:
              1. Renamed "subpatterns()" => "numSubpatterns()"
              2. Made flag enumeration private and replaced it with public getters for
              specific flags.
              3. Made RegExp ref-counted so RegExps can be shared by RegExpImps.
              4. Made RegExp take a string of flags instead of an int, eliminating 
              duplicated flag parsing code elsewhere.
      
              * kjs/regexp_object.cpp:
              (KJS::RegExpProtoFunc::callAsFunction): For RegExp.compile: 
              - Fixed a bug where compile(undefined) would throw an exception. 
              - Removed some now-redundant code.
              - Used RegExp sharing to eliminate an allocation and a bunch of 
              PropertyMap thrash. (Not a big win since compile is a deprecated 
              function. I mainly did this to test the plubming.)
      
      LayoutTests:
      
              Reviewed by Darin Adler.
              
              Beefed up the RegExp.compile testcase to cover a mistake in the 
              original check-in and a mistake I made while developing my new patch.
      
              * fast/js/resources/regexp-compile.js:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27571 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8a50ec54
    • hausmann's avatar
      don't put nbsp's into the plan text paste · b5e98fee
      hausmann authored
      Fix both ClipboardQt and PasteboardQt to replace
      nbsp's with spaces before putting the text onto the
      native clipboard. This is consistent with Mac and Win
      and fixes at least editing/pasteboard/4076267-3.html
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27524 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b5e98fee
    • hausmann's avatar
      update test results after the last commit. · d4ac7ebc
      hausmann authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27522 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d4ac7ebc
    • hausmann's avatar
      Update the list of skipped tests. · ca817b49
      hausmann authored
      Three more tests are passing.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27520 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ca817b49
    • hausmann's avatar
      add more passing test cases. · 77d77dc7
      hausmann authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27513 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      77d77dc7
    • ap@webkit.org's avatar
      Corrected ChangeLog grammar. · b327e11c
      ap@webkit.org authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27506 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b327e11c
    • ap@webkit.org's avatar
      Finished moving editing/pasteboard/5583362.html to platform/mac (this... · 39435836
      ap@webkit.org authored
              Finished moving editing/pasteboard/5583362.html to platform/mac (this test was crashing in ObjC test plugin,
              because it couldn't find its resources.
      
              * editing/resources/plaintext-pasteboard-data.dat: Removed.
              * platform/mac/editing/resources: Added.
              * platform/mac/editing/resources/plaintext-pasteboard-data.dat: Copied from editing/resources/plaintext-pasteboard-data.dat.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27505 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      39435836
    • mitz@apple.com's avatar
      WebCore: · f189f829
      mitz@apple.com authored
              Reviewed by Brady Eidson.
      
              - fix http://bugs.webkit.org/show_bug.cgi?id=15877
                REGRESSION: r27486 caused a layout regression at my bank's website
      
              Test: fast/block/float/overhanging-after-height-decrease-offsets.html
      
              * rendering/RenderBlock.cpp:
              (WebCore::RenderBlock::layoutBlock):
      
      LayoutTests:
      
              Reviewed by Brady Eidson.
      
              - test for http://bugs.webkit.org/show_bug.cgi?id=15877
                REGRESSION: r27486 caused a layout regression at my bank's website
      
              * fast/block/float/overhanging-after-height-decrease-offsets.html: Added.
              * platform/mac-leopard/fast/block/float/overhanging-after-height-decrease-offsets-expected.checksum: Added.
              * platform/mac-leopard/fast/block/float/overhanging-after-height-decrease-offsets-expected.png: Added.
              * platform/mac/fast/block/float/overhanging-after-height-decrease-offsets-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27504 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f189f829
    • aroben's avatar
      Move a Mac-specific test to platform/mac · 8ce08389
      aroben authored
              * editing/pasteboard/5583362.html: Removed.
              * platform/mac/editing/pasteboard/5583362.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27502 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8ce08389
  7. 06 Nov, 2007 9 commits
    • bdakin's avatar
      WebCore: · b76a6905
      bdakin authored
              Reviewed by Sam.
      
              <rdar://problem/5575812> REGRESSION:When using absolute positioning 
              with overflow:auto div, WebKit seems to add an additional 15px
      
              * rendering/RenderBox.cpp:
              (WebCore::RenderBox::containingBlockWidthForPositioned): We need to 
              subtract off the vertical scrollbar width too.
      
      LayoutTests:
      
              Reviewed by Sam.
      
              New test for <rdar://problem/5575812> REGRESSION:When using 
              absolute positioning with overflow:auto div, WebKit seems to add an 
              additional 15px
              * fast/overflow/overflow-auto-position-absolute.html: Added.
              * platform/mac/fast/overflow/overflow-auto-position-absolute-expected.checksum: Added.
              * platform/mac/fast/overflow/overflow-auto-position-absolute-expected.png: Added.
              * platform/mac/fast/overflow/overflow-auto-position-absolute-expected.txt: Added.
              
              Test with changed results. The measurements in the rtl example now 
              more closely mirror the ltr example.
              * platform/mac/fast/overflow/unreachable-overflow-rtl-bug-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27499 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b76a6905
    • justing's avatar
      WebCore: · 50fa2ccf
      justing authored
              Reviewed by Dan Bernstein.
              
              <rdar://problem/5583387> ASSERTION FAILED: !refChild->hasTagName(bodyTag) when pasting newline in plain text into rich text Mail
              <rdar://problem/5583362> REGRESSION (5523.10.3-TOT): Newlines stripped when pasting plain text in Mail
      
              * editing/markup.cpp:
              (WebCore::createFragmentFromText): Put paragraphs of text into clones of the block
              that encloses the input context, unless that block is the body, which shouldn't
              be cloned.  In that case, use regular divs, as we did before r27369.
      
      LayoutTests:
      
              Reviewed by Dan Bernstein.
      
              <rdar://problem/5583387> ASSERTION FAILED: !refChild->hasTagName(bodyTag) when pasting newline in plain text into rich text Mail
              <rdar://problem/5583362> REGRESSION (5523.10.3-TOT): Newlines stripped when pasting plain text in Mail
      
              * editing/pasteboard/5583362.html: Added.
              * editing/resources/plaintext-pasteboard-data.dat: Added.
              * platform/mac/editing/pasteboard/5583362-expected.checksum: Added.
              * platform/mac/editing/pasteboard/5583362-expected.png: Added.
              * platform/mac/editing/pasteboard/5583362-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27495 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      50fa2ccf
    • antti's avatar
      Correct test results. · b8f33948
      antti authored
              * platform/mac/fast/layers/layer-visibility-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27490 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b8f33948
    • antti's avatar
      Reviewed by Hyatt. · 6e9dffaa
      antti authored
              
              Update test to cover
              <rdar://problem/5521068>
              Visibility not propagated correctly for children of a layer with z-index
              
              The fix for this was (accidentally) already checked in with r27277, 
              with retroactive r=hyatt.
      
              * fast/layers/layer-visibility.html:
              * platform/mac/fast/layers/layer-visibility-expected.checksum:
              * platform/mac/fast/layers/layer-visibility-expected.png:
              * platform/mac/fast/layers/layer-visibility-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27489 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6e9dffaa
    • justing's avatar
      WebCore: · dccc7043
      justing authored
              Reviewed by Darin Adler.
              
              <rdar://problem/5576619> 
              REGRESSION: Caret disappears after deleting the last character in inline hole (15714)
      
              * editing/TypingCommand.cpp:
              (WebCore::TypingCommand::deleteSelection): Like the other TypingCommands, including
              both of the other deletion commands, call typingAddedToOpenCommand(), which takes 
              the command's endingSelection and sets it as selection.
      
      LayoutTests:
      
              Reviewed by Darin Adler.
              
              <rdar://problem/5576619> REGRESSION: Caret disappears after deleting the last character in inline hole (15714)
      
              * platform/mac/editing/input/5576619-expected.checksum: Added.
              * platform/mac/editing/input/5576619-expected.png: Added.
              * platform/mac/editing/input/5576619-expected.txt: Added.
              * platform/mac/editing/input/5576619.html: Added.
              * platform/mac/editing/input/text-input-controller-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27488 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dccc7043
    • mitz@apple.com's avatar
      WebCore: · 0652c894
      mitz@apple.com authored
              Reviewed by Antti Koivisto and Dave Hyatt.
      
              - fix <rdar://problem/5582961> Incorrect layout and floating object list corruption when CSS decreases a block's height
      
              Test: fast/block/float/overhanging-after-height-decrease.html
      
              * rendering/RenderBlock.cpp:
              (WebCore::RenderBlock::layoutBlock): If after calculating the height
              it turns out that there are overhanging floats that were not overhanging
              before, rescan children with overhanging floats and add them. 
              (WebCore::RenderBlock::layoutBlockChildren): Added a parameter that
              returns the lowest float bottom of any of the children.
              (WebCore::RenderBlock::addOverhangingFloats): Changed to return the
              lowest float bottom.
              * rendering/RenderBlock.h:
      
      LayoutTests:
      
              Reviewed by Antti Koivisto and Dave Hyatt.
      
              - test for <rdar://problem/5582961> Incorrect layout and floating object list corruption when CSS decreases a block's height
      
              * fast/block/float/overhanging-after-height-decrease.html: Added.
              * platform/mac-leopard/fast/block: Added.
              * platform/mac-leopard/fast/block/float: Added.
              * platform/mac-leopard/fast/block/float/overhanging-after-height-decrease-expected.checksum: Added.
              * platform/mac-leopard/fast/block/float/overhanging-after-height-decrease-expected.png: Added.
              * platform/mac/fast/block/float/overhanging-after-height-decrease-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27486 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0652c894
    • adele's avatar
      WebCore: · b11ea64c
      adele authored
              Reviewed by Darin.
      
              Switched all uses of HTMLImageLoader to use OwnPtrs.
      
              * html/HTMLInputElement.h:
              * html/HTMLInputElement.cpp:
              (WebCore::HTMLInputElement::init):
              (WebCore::HTMLInputElement::~HTMLInputElement):
              (WebCore::HTMLInputElement::setInputType):
              (WebCore::HTMLInputElement::parseMappedAttribute):
              (WebCore::HTMLInputElement::attach):
              * html/HTMLObjectElement.h:
              * html/HTMLObjectElement.cpp:
              (WebCore::HTMLObjectElement::HTMLObjectElement):
              (WebCore::HTMLObjectElement::~HTMLObjectElement):
              (WebCore::HTMLObjectElement::parseMappedAttribute):
              (WebCore::HTMLObjectElement::attach):
              * html/HTMLVideoElement.h:
              * html/HTMLVideoElement.cpp:
              (WebCore::HTMLVideoElement::HTMLVideoElement):
              (WebCore::HTMLVideoElement::attach):
              (WebCore::HTMLVideoElement::detach):
              (WebCore::HTMLVideoElement::parseMappedAttribute):
      
      LayoutTests:
      
              Reviewed by Darin.
      
              Added test for poster attribute.
      
              * media/content/abe.png: Added.
              * media/content/greenbox.png: Added.
              * media/video-poster-expected.txt: Added.
              * media/video-poster.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27485 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b11ea64c
    • antti's avatar
      WebCore: · 61bd1055
      antti authored
              Reviewed by Darin.
              
              Trigger media load on on src attribute changes as specified in new HTML5 draft.
      
              Tests: media/video-src-change.html
                     media/video-src-remove.html
                     media/video-src-set.html
      
              * html/HTMLMediaElement.cpp:
              (WebCore::HTMLMediaElement::attributeChanged):
              * html/HTMLMediaElement.h:
      
      LayoutTests:
      
              Reviewed by Darin.
              
              Tests for media src attribute changes.
      
              * media/video-src-change-expected.txt: Added.
              * media/video-src-change.html: Added.
              * media/video-src-remove-expected.txt: Added.
              * media/video-src-remove.html: Added.
              * media/video-src-set-expected.txt: Added.
              * media/video-src-set.html: Added.
              * media/video-test.js:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27480 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      61bd1055
    • mitz@apple.com's avatar
      WebCore: · 13455a10
      mitz@apple.com authored
              Reviewed by Darin Adler.
      
              - fix http://bugs.webkit.org/show_bug.cgi?id=15838
                Incomplete repaint toggling "How you know this person" on Facebook
      
              Test: fast/repaint/make-children-non-inline.html
      
              * rendering/RenderBlock.cpp:
              (WebCore::RenderBlock::makeChildrenNonInline): Repaint the block. This
              is needed because the inline children may be repositioned as they move
              into new anonymous blocks, but those blocks have no knowledge of where
              their children used to be, so they cannot invalidate those areas.
      
      LayoutTests:
      
              Reviewed by Darin Adler.
      
              - repaint test for http://bugs.webkit.org/show_bug.cgi?id=15838
                Incomplete repaint toggling "How you know this person" on Facebook
      
              * fast/repaint/make-children-non-inline.html: Added.
              * platform/mac/fast/repaint/make-children-non-inline-expected.txt: Added.
              * platform/mac-leopard/fast/repaint: Added.
              * platform/mac-leopard/fast/repaint/make-children-non-inline-expected.checksum: Added.
              * platform/mac-leopard/fast/repaint/make-children-non-inline-expected.png: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27478 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      13455a10