- 22 Aug, 2013 28 commits
-
-
https://webkit.org/b/120180aestes@apple.com authored
Reviewed by David Kilzer. Source/WebKit2: Adding ld flags for ASAN overwrote the unexported symbol flags we were previously specifying. Since the unexported symbol ld flags are only needed for the framework target, move them to WebKit2.xcconfig where we can add them to OTHER_LDFLAGS along with the ASAN values inherited from DebugRelease.xcconfig (and other values). * Configurations/Base.xcconfig: Removed the unexported symbol ld flags. * Configurations/WebKit2.xcconfig: ... and moved them here. Tools: * TestWebKitAPI/Configurations/Base.xcconfig: Removed the definition of OTHER_CPLUSPLUSFLAGS since -ftemplate-depth=256 is already set in DebugRelease.xcconfig and TestWebKitAPI isn't built in Production. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154467 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
barraclough@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=120174 Reviewed by Geoff Garen. We currently always allocate registers for new global variables, but these are wasted when the variable is being redeclared. Only allocate new registers when necessary. No performance impact. * interpreter/Interpreter.cpp: (JSC::Interpreter::execute): * runtime/Executable.cpp: (JSC::ProgramExecutable::initializeGlobalProperties): - Don't allocate the register here. * runtime/JSGlobalObject.cpp: (JSC::JSGlobalObject::addGlobalVar): - Allocate the register here instead. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154466 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
timothy_horton@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=120177 <rdar://problem/14811951> Reviewed by Kevin Decker. Move the unavailable plug-in indicator text up one pixel. * rendering/RenderEmbeddedObject.cpp: (WebCore::RenderEmbeddedObject::paintReplaced): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154464 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ch.dumez@sisa.samsung.com authored
https://bugs.webkit.org/show_bug.cgi?id=107386 Reviewed by Andreas Kling. Source/WebCore: Merge SVGStyledElement into SVGElement to simplify the SVG inheritance model and match the SVG2 specification: https://svgwg.org/svg2-draft/single-page.html#types-InterfaceSVGElement Test: svg/dom/svg2-inheritance.html * CMakeLists.txt: * DerivedSources.cpp: * DerivedSources.make: * DerivedSources.pri: * GNUmakefile.list.am: * Target.pri: * WebCore.order: * WebCore.vcxproj/WebCore.vcxproj: * WebCore.vcxproj/WebCore.vcxproj.filters: * WebCore.xcodeproj/project.pbxproj: * accessibility/AccessibilityNodeObject.cpp: (WebCore::AccessibilityNodeObject::alternativeText): (WebCore::AccessibilityNodeObject::accessibilityDescription): * css/SVGCSSStyleSelector.cpp: * rendering/style/SVGRenderStyle.cpp: * rendering/svg/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::RenderSVGContainer): * rendering/svg/RenderSVGContainer.h: * rendering/svg/RenderSVGHiddenContainer.cpp: (WebCore::RenderSVGHiddenContainer::RenderSVGHiddenContainer): * rendering/svg/RenderSVGHiddenContainer.h: * rendering/svg/RenderSVGModelObject.cpp: (WebCore::RenderSVGModelObject::RenderSVGModelObject): (WebCore::getElementCTM): * rendering/svg/RenderSVGModelObject.h: * rendering/svg/RenderSVGResourceClipper.cpp: (WebCore::RenderSVGResourceClipper::drawContentIntoMaskImage): (WebCore::RenderSVGResourceClipper::calculateClipContentRepaintRect): (WebCore::RenderSVGResourceClipper::hitTestClipContent): * rendering/svg/RenderSVGResourceContainer.cpp: (WebCore::RenderSVGResourceContainer::RenderSVGResourceContainer): * rendering/svg/RenderSVGResourceContainer.h: * rendering/svg/RenderSVGResourceFilter.cpp: * rendering/svg/RenderSVGResourceFilterPrimitive.h: * rendering/svg/RenderSVGResourceMarker.cpp: * rendering/svg/RenderSVGResourceMarker.h: * rendering/svg/RenderSVGResourceMasker.cpp: (WebCore::RenderSVGResourceMasker::drawContentIntoMaskImage): (WebCore::RenderSVGResourceMasker::calculateMaskContentRepaintRect): * rendering/svg/RenderSVGResourcePattern.cpp: (WebCore::RenderSVGResourcePattern::createTileImage): * rendering/svg/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::RenderSVGRoot): * rendering/svg/RenderSVGRoot.h: * rendering/svg/RenderSVGViewportContainer.cpp: (WebCore::RenderSVGViewportContainer::RenderSVGViewportContainer): * rendering/svg/RenderSVGViewportContainer.h: * rendering/svg/SVGRenderSupport.cpp: (WebCore::SVGRenderSupport::layoutChildren): * rendering/svg/SVGRenderTreeAsText.cpp: * rendering/svg/SVGResources.cpp: (WebCore::registerPendingResource): * rendering/svg/SVGResourcesCache.cpp: * svg/SVGAElement.cpp: (WebCore::SVGAElement::title): * svg/SVGAllInOne.cpp: * svg/SVGAltGlyphDefElement.h: * svg/SVGAltGlyphItemElement.h: * svg/SVGAnimateElement.cpp: * svg/SVGAnimatedType.cpp: (WebCore::SVGAnimatedType::valueAsString): (WebCore::SVGAnimatedType::setValueAsString): * svg/SVGAnimationElement.cpp: (WebCore::SVGAnimationElement::isTargetAttributeCSSProperty): (WebCore::SVGAnimationElement::computeCSSPropertyValue): (WebCore::SVGAnimationElement::adjustForInheritance): (WebCore::inheritsFromProperty): * svg/SVGComponentTransferFunctionElement.h: * svg/SVGCursorElement.h: * svg/SVGDescElement.cpp: (WebCore::SVGDescElement::SVGDescElement): * svg/SVGDescElement.h: * svg/SVGDescElement.idl: * svg/SVGElement.cpp: (WebCore::mapAttributeToCSSProperty): (WebCore::cssPropertyToTypeMap): (WebCore::SVGElement::SVGElement): (WebCore::SVGElement::~SVGElement): (WebCore::SVGElement::removedFrom): (WebCore::SVGElement::parseAttribute): (WebCore::SVGElement::animatedPropertyTypeForAttribute): (WebCore::collectInstancesForSVGElement): (WebCore::SVGElement::isAnimatableAttribute): (WebCore::SVGElement::title): (WebCore::SVGElement::rendererIsNeeded): (WebCore::SVGElement::cssPropertyIdForSVGAttributeName): (WebCore::SVGElement::isAnimatableCSSProperty): (WebCore::SVGElement::isPresentationAttribute): (WebCore::SVGElement::collectStyleForPresentationAttribute): (WebCore::SVGElement::isKnownAttribute): (WebCore::SVGElement::svgAttributeChanged): (WebCore::SVGElement::insertedInto): (WebCore::SVGElement::buildPendingResourcesIfNeeded): (WebCore::SVGElement::childrenChanged): (WebCore::SVGElement::getPresentationAttribute): (WebCore::SVGElement::instanceUpdatesBlocked): (WebCore::SVGElement::setInstanceUpdatesBlocked): (WebCore::SVGElement::localCoordinateSpaceTransform): (WebCore::SVGElement::updateRelativeLengthsInformation): (WebCore::SVGElement::isMouseFocusable): (WebCore::SVGElement::isKeyboardFocusable): * svg/SVGElement.h: (WebCore::SVGElement::supportsMarkers): (WebCore::SVGElement::hasRelativeLengths): (WebCore::SVGElement::needsPendingResourceHandling): (WebCore::SVGElement::selfHasRelativeLengths): (WebCore::SVGElement::updateRelativeLengthsInformation): * svg/SVGElement.idl: * svg/SVGElementInstance.cpp: (WebCore::SVGElementInstance::invalidateAllInstancesOfElement): (WebCore::SVGElementInstance::InstanceUpdateBlocker::InstanceUpdateBlocker): * svg/SVGElementInstance.h: * svg/SVGFEBlendElement.idl: * svg/SVGFEColorMatrixElement.idl: * svg/SVGFEComponentTransferElement.idl: * svg/SVGFECompositeElement.idl: * svg/SVGFEConvolveMatrixElement.idl: * svg/SVGFEDiffuseLightingElement.idl: * svg/SVGFEDisplacementMapElement.idl: * svg/SVGFEDropShadowElement.idl: * svg/SVGFEFloodElement.idl: * svg/SVGFEGaussianBlurElement.idl: * svg/SVGFEImageElement.idl: * svg/SVGFELightElement.h: * svg/SVGFEMergeElement.idl: * svg/SVGFEMergeNodeElement.h: * svg/SVGFEMorphologyElement.idl: * svg/SVGFEOffsetElement.idl: * svg/SVGFESpecularLightingElement.idl: * svg/SVGFETileElement.idl: * svg/SVGFETurbulenceElement.idl: * svg/SVGFilterElement.cpp: (WebCore::SVGFilterElement::SVGFilterElement): (WebCore::SVGFilterElement::parseAttribute): (WebCore::SVGFilterElement::svgAttributeChanged): (WebCore::SVGFilterElement::childrenChanged): * svg/SVGFilterElement.h: * svg/SVGFilterElement.idl: * svg/SVGFilterPrimitiveStandardAttributes.cpp: (WebCore::SVGFilterPrimitiveStandardAttributes::SVGFilterPrimitiveStandardAttributes): (WebCore::SVGFilterPrimitiveStandardAttributes::parseAttribute): (WebCore::SVGFilterPrimitiveStandardAttributes::svgAttributeChanged): (WebCore::SVGFilterPrimitiveStandardAttributes::childrenChanged): (WebCore::SVGFilterPrimitiveStandardAttributes::rendererIsNeeded): * svg/SVGFilterPrimitiveStandardAttributes.h: * svg/SVGFontElement.cpp: (WebCore::SVGFontElement::SVGFontElement): * svg/SVGFontElement.h: * svg/SVGFontFaceElement.cpp: * svg/SVGFontFaceElement.h: * svg/SVGFontFaceFormatElement.h: * svg/SVGFontFaceNameElement.h: * svg/SVGFontFaceSrcElement.h: * svg/SVGFontFaceUriElement.h: * svg/SVGGElement.cpp: (WebCore::SVGGElement::rendererIsNeeded): * svg/SVGGlyphElement.cpp: (WebCore::SVGGlyphElement::SVGGlyphElement): (WebCore::SVGGlyphElement::parseAttribute): (WebCore::SVGGlyphElement::insertedInto): (WebCore::SVGGlyphElement::removedFrom): * svg/SVGGlyphElement.h: * svg/SVGGlyphRefElement.cpp: (WebCore::SVGGlyphRefElement::SVGGlyphRefElement): (WebCore::SVGGlyphRefElement::parseAttribute): * svg/SVGGlyphRefElement.h: * svg/SVGGlyphRefElement.idl: * svg/SVGGradientElement.cpp: (WebCore::SVGGradientElement::SVGGradientElement): (WebCore::SVGGradientElement::parseAttribute): (WebCore::SVGGradientElement::svgAttributeChanged): (WebCore::SVGGradientElement::childrenChanged): * svg/SVGGradientElement.h: * svg/SVGGradientElement.idl: * svg/SVGGraphicsElement.cpp: (WebCore::SVGGraphicsElement::SVGGraphicsElement): (WebCore::SVGGraphicsElement::parseAttribute): (WebCore::SVGGraphicsElement::svgAttributeChanged): * svg/SVGGraphicsElement.h: * svg/SVGGraphicsElement.idl: * svg/SVGLocatable.cpp: (WebCore::SVGLocatable::computeCTM): * svg/SVGMPathElement.h: * svg/SVGMarkerElement.cpp: (WebCore::SVGMarkerElement::SVGMarkerElement): (WebCore::SVGMarkerElement::parseAttribute): (WebCore::SVGMarkerElement::svgAttributeChanged): (WebCore::SVGMarkerElement::childrenChanged): * svg/SVGMarkerElement.h: * svg/SVGMarkerElement.idl: * svg/SVGMaskElement.cpp: (WebCore::SVGMaskElement::SVGMaskElement): (WebCore::SVGMaskElement::parseAttribute): (WebCore::SVGMaskElement::svgAttributeChanged): (WebCore::SVGMaskElement::childrenChanged): * svg/SVGMaskElement.h: * svg/SVGMaskElement.idl: * svg/SVGMetadataElement.h: * svg/SVGMissingGlyphElement.cpp: (WebCore::SVGMissingGlyphElement::SVGMissingGlyphElement): * svg/SVGMissingGlyphElement.h: * svg/SVGMissingGlyphElement.idl: * svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::SVGPatternElement): (WebCore::SVGPatternElement::parseAttribute): (WebCore::SVGPatternElement::svgAttributeChanged): (WebCore::SVGPatternElement::childrenChanged): * svg/SVGPatternElement.h: * svg/SVGPatternElement.idl: * svg/SVGScriptElement.h: * svg/SVGStopElement.cpp: (WebCore::SVGStopElement::SVGStopElement): (WebCore::SVGStopElement::parseAttribute): (WebCore::SVGStopElement::svgAttributeChanged): * svg/SVGStopElement.h: * svg/SVGStopElement.idl: * svg/SVGStyleElement.h: * svg/SVGStyledElement.cpp: Removed. * svg/SVGStyledElement.h: Removed. * svg/SVGStyledElement.idl: Removed. * svg/SVGSymbolElement.cpp: (WebCore::SVGSymbolElement::SVGSymbolElement): (WebCore::SVGSymbolElement::parseAttribute): (WebCore::SVGSymbolElement::svgAttributeChanged): * svg/SVGSymbolElement.h: * svg/SVGSymbolElement.idl: * svg/SVGTRefElement.cpp: (WebCore::SVGTRefElement::insertedInto): (WebCore::SVGTRefElement::removedFrom): * svg/SVGTitleElement.cpp: (WebCore::SVGTitleElement::SVGTitleElement): (WebCore::SVGTitleElement::insertedInto): * svg/SVGTitleElement.h: * svg/SVGTitleElement.idl: * svg/SVGTransformable.cpp: * svg/SVGUseElement.cpp: (WebCore::SVGUseElement::selfHasRelativeLengths): * svg/SVGViewElement.cpp: (WebCore::SVGViewElement::SVGViewElement): (WebCore::SVGViewElement::parseAttribute): * svg/SVGViewElement.h: * svg/animation/SVGSMILElement.h: * svg/graphics/filters/SVGFEImage.cpp: (WebCore::FEImage::platformApplySoftware): LayoutTests: Add layout test to validate the SVG2 inheritance model. * svg/dom/svg2-inheritance-expected.txt: Added. * svg/dom/svg2-inheritance.html: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154462 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
barraclough@apple.com authored
Remove putDirectVirtual Unreviewed, checked in commented out code. :-( * interpreter/Interpreter.cpp: (JSC::Interpreter::execute): - delete commented out code git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154461 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
barraclough@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=120171 Reviewed by Oliver Hunt. Breaks ECMA tests. Source/JavaScriptCore: * runtime/ErrorInstance.cpp: (JSC::ErrorInstance::finishCreation): - None -> DontEnum LayoutTests: * fast/js/exception-properties-expected.txt: * fast/js/script-tests/exception-properties.js: - Update test expectations. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154460 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
barraclough@apple.com authored
Remove putDirectVirtual Reviewed by Sam Weinig. This could most generously be described as 'vestigial'. No performance impact. * API/JSObjectRef.cpp: (JSObjectSetProperty): - changed to use defineOwnProperty * debugger/DebuggerActivation.cpp: * debugger/DebuggerActivation.h: - remove putDirectVirtual * interpreter/Interpreter.cpp: (JSC::Interpreter::execute): - changed to use defineOwnProperty * runtime/ClassInfo.h: * runtime/JSActivation.cpp: * runtime/JSActivation.h: * runtime/JSCell.cpp: * runtime/JSCell.h: * runtime/JSGlobalObject.cpp: * runtime/JSGlobalObject.h: * runtime/JSObject.cpp: * runtime/JSObject.h: * runtime/JSProxy.cpp: * runtime/JSProxy.h: * runtime/JSSymbolTableObject.cpp: * runtime/JSSymbolTableObject.h: - remove putDirectVirtual * runtime/PropertyDescriptor.h: (JSC::PropertyDescriptor::PropertyDescriptor): - added constructor for convenience git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154459 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
akling@apple.com authored
<https://webkit.org/b/120163> Reviewed by Anders Carlsson. Rehued by Anders Carlsson. FrameLoader::m_history is never null, so make history() return a reference. Also made HistoryController::m_frame a reference, since HistoryController's lifetime is tied to FrameLoader, which is tied to the Frame. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154458 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=119812 Patch by Chris Curtis <chris_curtis@apple.com> on 2013-08-22 Reviewed by Geoffrey Garen. Added a check to make sure that the JSValue was an object before casting it as an object. Also, in case the parameterized JSValue has no type, the function now returns the empty string. * runtime/ExceptionHelpers.cpp: (JSC::errorDescriptionForValue): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154457 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
https://webkit.org/b/120165commit-queue@webkit.org authored
Patch by Joseph Pecoraro <pecoraro@apple.com> on 2013-08-22 Reviewed by Andy Estes. * Tools/PrettyPrinting/codemirror.css: * Tools/PrettyPrinting/codemirror.js: * Tools/PrettyPrinting/css.js: * Tools/PrettyPrinting/javascript.js: * UserInterface/External/CodeMirror/codemirror.css: * UserInterface/External/CodeMirror/codemirror.js: * UserInterface/External/CodeMirror/css.js: * UserInterface/External/CodeMirror/javascript.js: * UserInterface/External/CodeMirror/xml.js: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154456 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
simon.fraser@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=119377 Reviewed by Anders Carlson. RenderVideo should not claim that it's foreground is opaque unless it has a video frame to display. * rendering/RenderVideo.cpp: (WebCore::RenderVideo::foregroundIsKnownToBeOpaqueInRect): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154455 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
akling@apple.com authored
* WebDataSource.cpp: (WebDataSource::subresourceForURL): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154454 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=115248 Patch by Anton Obzhirov <a.obzhirov@samsung.com> on 2013-08-22 Reviewed by Alexandru Chiculita. * fast/regions/region-min-max-width-support-expected.txt: Added. * fast/regions/region-min-max-width-support.html: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154453 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
akling@apple.com authored
* rendering/RenderWidget.cpp: (WebCore::RenderWidget::destroy): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154452 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
akling@apple.com authored
* WebCoreSupport/ChromeClientEfl.cpp: (kit): Source/WebKit/win: Windows build juice. * WebDataSource.cpp: (WebDataSource::representation): (WebDataSource::webFrame): * WebElementPropertyBag.cpp: (WebElementPropertyBag::Read): * WebFramePolicyListener.cpp: (WebFramePolicyListener::receivedPolicyDecision): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154451 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
rniwa@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=120146 Reviewed by Andreas Kling. For the upcoming replacement for webkit-test-results.appspot.com, new-run-webkit-tests needs to use a new JSON format that contains the full summary of the test run including information about passed tests. Add this ability to NRWT so that I can start testing this feature. This patch adds the following optoins to NRWT: --build-slave --got-revision --results-server-host The last option is somewhat ambigious with --test-results-server but we're intending to deprecate the old server so we should be able to delete --test-results-server in time. * Scripts/webkitpy/layout_tests/controllers/manager.py: (Manager.run): (Manager._upload_json_files): (Manager): (Manager.upload_results): * Scripts/webkitpy/layout_tests/models/test_run_results.py: (summarize_results): * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py: (summarized_results): (SummarizedResultsTest.test_summarized_results_wontfix): (SummarizedResultsTest): (SummarizedResultsTest.test_summarized_results_include_passes): * Scripts/webkitpy/layout_tests/run_webkit_tests.py: (parse_args): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154450 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
akling@apple.com authored
<https://webkit.org/b/120158> Reviewed by Anders Carlsson. These two are never null so change them to return references. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154449 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
rniwa@webkit.org authored
* Scripts/webkitpy/tool/bot/irc_command.py: (Hi.execute): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154448 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
abucur@adobe.com authored
https://bugs.webkit.org/show_bug.cgi?id=119923 Reviewed by Antti Koivisto. Port of https://chromium.googlesource.com/chromium/blink/+/949d7d7e7b8685454742a55cf0ca912bb9a7b177. Original patch by Elliott Sprehn. RenderNamedFlowThread should not create NodeRenderingContext objects RenderNamedFlowThread is using NodeRenderingContext to get the original parent renderer, but should just be using NodeRenderingTraversal::parent instead (which is what NodeRenderingContext does internally anyway). Tests: No change in functionality. No new tests. * rendering/RenderNamedFlowThread.cpp: (WebCore::RenderNamedFlowThread::isChildAllowed): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154447 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
rniwa@webkit.org authored
Update the test expectation accordingly. * platform/mac-wk2/TestExpectations: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154446 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
rniwa@webkit.org authored
Add the failing test expectation to webaudio/codec-tests/mp3/128kbps-44khz.html on Lion Release WK2. The failure is tracked by the bug 120161. * platform/mac-wk2/TestExpectations: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154445 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
allan.jensen@digia.com authored
https://bugs.webkit.org/show_bug.cgi?id=120151 Reviewed by Simon Hausmann. Since QtInstance had an implementation of getOwnPropertySlot and not getOwnPropertyDescriptor, the behavior of getOwnPropertyDescriptor changed when it got implemented using getOwnPropertySlot in r154300. DRT relied on getOwnPropertyDescriptor returning undefined for JS set properties to distinguish between native Qt methods and JSC bound methods. This patch changes the check to see if the property is writable since the Qt methods are ReadOnly. * DumpRenderTree/qt/DumpRenderTreeQt.cpp: (DumpRenderTree::initJSObjects): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154444 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ch.dumez@sisa.samsung.com authored
https://bugs.webkit.org/show_bug.cgi?id=120155 Reviewed by Andreas Kling. Introduce a SVGUnknownElement class and have it override rendererIsNeeded() to return false. We now use SVGUnknownElement type (instead of SVGElement) for unknown SVG elements: - Unknown Elements in SVG namespace - Registered custom tag elements in SVG namespace: http://www.w3.org/TR/2013/WD-custom-elements-20130514/#registering-custom-elements As a consequence, SVGElement::rendererIsNeeded() is not longer required to return false and it will be able to behave as SVGStyledElement::rendererIsNeeded() once we merge SVGStyledElement into SVGElement. This is a pre-requirement to merging SVGStyledElement into SVGElement. No new tests, no behavior change. * GNUmakefile.list.am: * Target.pri: * WebCore.vcxproj/WebCore.vcxproj: * WebCore.vcxproj/WebCore.vcxproj.filters: * dom/CustomElementConstructor.cpp: (WebCore::CustomElementConstructor::createElementInternal): * dom/make_names.pl: (defaultParametersHash): (printJSElementIncludes): (printWrapperFunctions): (printWrapperFactoryCppFile): * svg/SVGElement.cpp: * svg/SVGElement.h: * svg/SVGUnknownElement.h: Added. (WebCore::SVGUnknownElement::create): (WebCore::SVGUnknownElement::SVGUnknownElement): * svg/svgtags.in: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154443 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=120107 Patch by Julien Brianceau <jbrianceau@nds.com> on 2013-08-22 Reviewed by Yong Li. EncodedJSValue parameters must be aligned to even registers for MIPS and ARM EABI. * dfg/DFGSpeculativeJIT.h: (JSC::DFG::SpeculativeJIT::callOperation): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154442 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
rwlbuis@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=118056 Reviewed by Ryosuke Niwa. Source/WebCore: The assert is hit in Debug mode because the DocumentOrderedMap in HTMLDocument::m_windowNamedItem includes matched SVG elements, but the WindowNameCollection used to collect the elements does not. This means the HTMLCollection stripped of SVG elements could end up hitting the empty or single item assertion, which the testcase verifies. To fix this change WindowNameCollection to include both SVG and HTML elements so it matches DocumentOrderedMap. Tests: svg/custom/document-all-includes-svg.html svg/custom/window-named-item-lookup.html * html/HTMLCollection.cpp: (WebCore::isMatchingElement): (WebCore::HTMLCollection::updateNameCache): LayoutTests: Add test to verify that SVG and HTML elements with id's are both found when using document.all or named properties. * svg/custom/document-all-includes-svg-expected.txt: Added. * svg/custom/document-all-includes-svg.html: Added. * svg/custom/window-named-item-lookup-expected.txt: Added. * svg/custom/window-named-item-lookup.html: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154441 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
gyuyoung.kim@samsung.com authored
https://bugs.webkit.org/show_bug.cgi?id=120153 Reviewed by Andreas Kling. As a step to clean-up static_cast<SVGXXX>, toSVGRadialGradientElement() is added to clean-up static_cast<SVGRadialGradientElement*>. * rendering/svg/RenderSVGResourceRadialGradient.cpp: (WebCore::RenderSVGResourceRadialGradient::collectGradientAttributes): * rendering/svg/SVGRenderTreeAsText.cpp: (WebCore::writeSVGResourceContainer): * svg/SVGRadialGradientElement.cpp: (WebCore::SVGRadialGradientElement::collectGradientAttributes): * svg/SVGRadialGradientElement.h: (WebCore::toSVGRadialGradientElement): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154440 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
reni@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=119672 Reviewed by Darin Adler. Source/WebCore: The last extractedStyle parameter of removeInlineStyleFromElement() is not mandatory and it's set to default 0. This way we have to check its existence before the usage. Test: editing/execCommand/extracted_style_assert.html * editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::removeInlineStyleFromElement): LayoutTests: Test with NULL extractedStyle. * editing/execCommand/extracted_style_assert-expected.txt: Added. * editing/execCommand/extracted_style_assert.html: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154439 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
sergio@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=119552 Reviewed by Darin Adler. Based on Blink r148922 & r149060 by <jchaffraix@chromium.org> The old testing code was a huge copy&paste of big testing code blocks. Refactor it in some new utility functions so that we could reduce the size of the layout test file and ease the maintenance. * fast/css-grid-layout/grid-item-column-row-get-set-expected.txt: * fast/css-grid-layout/grid-item-column-row-get-set.html: * fast/css-grid-layout/grid-item-end-after-get-set-expected.txt: * fast/css-grid-layout/grid-item-end-after-get-set.html: * fast/css-grid-layout/grid-item-start-before-get-set-expected.txt: * fast/css-grid-layout/grid-item-start-before-get-set.html: * fast/css-grid-layout/resources/grid-item-column-row-parsing-utils.js: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154438 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
- 21 Aug, 2013 12 commits
-
-
rniwa@webkit.org authored
* platform/mac-wk2/TestExpectations: * platform/mac/TestExpectations: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154437 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
http://trac.webkit.org/changeset/154416 https://bugs.webkit.org/show_bug.cgi?id=120147 Broke Windows builds (Requested by rniwa on #webkit). Source/JavaScriptCore: * JavaScriptCore.vcxproj/JavaScriptCoreGenerated.make: * JavaScriptCore.vcxproj/LLInt/LLIntAssembly/LLIntAssembly.make: * JavaScriptCore.vcxproj/LLInt/LLIntAssembly/build-LLIntAssembly.sh: * JavaScriptCore.vcxproj/LLInt/LLIntDesiredOffsets/LLIntDesiredOffsets.make: * JavaScriptCore.vcxproj/LLInt/LLIntDesiredOffsets/build-LLIntDesiredOffsets.sh: * JavaScriptCore.vcxproj/build-generated-files.sh: Source/WebCore: * WebCore.vcxproj/WebCoreGenerated.make: * WebCore.vcxproj/WebCoreGeneratedWinCairo.make: * WebCore.vcxproj/WebCoreGeneratedWinCairoCommon.props: * WebCore.vcxproj/build-generated-files.sh: * WebCore.vcxproj/copyForwardingHeaders.cmd: * WebCore.vcxproj/copyWebCoreResourceFiles.cmd: Source/WebKit: * WebKit.vcxproj/WebKit/WebKitPostBuild.cmd: * WebKit.vcxproj/WebKitExportGenerator/WebKitExportGeneratorBuildCmd.cmd: * WebKit.vcxproj/WebKitExportGenerator/WebKitExportGeneratorPostBuild.cmd: * WebKit.vcxproj/WebKitExportGenerator/WebKitExportGeneratorPreBuild.cmd: Source/WTF: * WTF.vcxproj/WTFGenerated.make: * WTF.vcxproj/build-generated-files.sh: WebKitLibraries: * win/tools/vsprops/common.props: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154436 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ryuan.choi@samsung.com authored
* rendering/style/StyleRareNonInheritedData.cpp: (WebCore::StyleRareNonInheritedData::hasFilters): Added CSS_FILTERS guard. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154435 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
barraclough@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=120144 Reviewed by Sam Weinig. Add methods to JSGlobalObject to declare vars, consts, and functions. * runtime/Executable.cpp: (JSC::ProgramExecutable::initializeGlobalProperties): * runtime/Executable.h: - Moved declaration code to JSGlobalObject * runtime/JSGlobalObject.cpp: (JSC::JSGlobalObject::addGlobalVar): - internal implementation of addVar, addConst, addFunction * runtime/JSGlobalObject.h: (JSC::JSGlobalObject::addVar): (JSC::JSGlobalObject::addConst): (JSC::JSGlobalObject::addFunction): - Added methods to declare vars, consts, and functions git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154434 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
timothy_horton@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=120145 <rdar://problem/14650652> Reviewed by Simon Fraser. convertImageToBitmap can legitimately return null, so don't dereference it. * WebProcess/WebCoreSupport/mac/WebDragClientMac.mm: (WebKit::WebDragClient::startDrag): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154433 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
simon.fraser@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=120135 Source/WebCore: Reviewed by Jer Noble. When removing a filter on an inline child of a compositing layer, the inline loses its RenderLayer and compositing layer, but we fail to repaint the compositing layer that the inline is now painting into. This worked correctly for opacity, because opacity toggles cause layouts (which then paint the correct layer), so do the same for filters. Test: css3/filters/remove-filter-repaint.html * rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::changeRequiresLayout): Return true if we toggled between having filters and not. Drive-by cleanup, making use of new convenience function for hasOpacity(). * rendering/style/StyleRareNonInheritedData.cpp: (WebCore::StyleRareNonInheritedData::hasFilters): Returns true if we have any filters. * rendering/style/StyleRareNonInheritedData.h: (WebCore::StyleRareNonInheritedData::hasOpacity): Convenience function that returns true if opacity is < 1. LayoutTests: Reviewed by Jer Noble. Ref test for removing a filter on an inline. * css3/filters/remove-filter-repaint-expected.html: Added. * css3/filters/remove-filter-repaint.html: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154430 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
Exception in global setter doesn't unwind correctly Patch by Yi Shen <max.hong.shen@gmail.com> on 2013-08-21 Reviewed by Geoffrey Garen. Source/JavaScriptCore: Call VM_THROW_EXCEPTION_AT_END in op_put_to_scope if the setter throws exception. * jit/JITStubs.cpp: (JSC::DEFINE_STUB_FUNCTION): LayoutTests: Add test for calling global setter which throws exception. * fast/js/script-tests/throw-exception-in-global-setter.js: Added. (g): * fast/js/throw-exception-in-global-setter-expected.txt: Added. * fast/js/throw-exception-in-global-setter.html: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154429 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
https://webkit.org/b/120140bdakin@apple.com authored
happen before didLayout Reviewed by Anders Carlsson. * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::dispatchDidLayout): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154428 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
bfulgham@apple.com authored
* WebInspectorUI.vcxproj/WebInspectorUI.vcxproj: Remove hard-coded settings covered by our configuration files. * WebInspectorUI.vcxproj/WebInspectorUIPostBuild.cmd: Use the %PlatformArchitecture% macro to support 32- and 64-bit builds. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154427 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
mhahnenberg@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=120138 Reviewed by Geoffrey Garen. setButterfly becomes setStructureAndButterfly. Also removed the Butterfly* argument from setStructure and just implicitly used m_butterfly internally since that's what every single client of setStructure was doing already. * jit/JITStubs.cpp: (JSC::DEFINE_STUB_FUNCTION): * runtime/JSObject.cpp: (JSC::JSObject::notifyPresenceOfIndexedAccessors): (JSC::JSObject::createInitialUndecided): (JSC::JSObject::createInitialInt32): (JSC::JSObject::createInitialDouble): (JSC::JSObject::createInitialContiguous): (JSC::JSObject::createArrayStorage): (JSC::JSObject::convertUndecidedToInt32): (JSC::JSObject::convertUndecidedToDouble): (JSC::JSObject::convertUndecidedToContiguous): (JSC::JSObject::convertUndecidedToArrayStorage): (JSC::JSObject::convertInt32ToDouble): (JSC::JSObject::convertInt32ToContiguous): (JSC::JSObject::convertInt32ToArrayStorage): (JSC::JSObject::genericConvertDoubleToContiguous): (JSC::JSObject::convertDoubleToArrayStorage): (JSC::JSObject::convertContiguousToArrayStorage): (JSC::JSObject::switchToSlowPutArrayStorage): (JSC::JSObject::setPrototype): (JSC::JSObject::putDirectAccessor): (JSC::JSObject::seal): (JSC::JSObject::freeze): (JSC::JSObject::preventExtensions): (JSC::JSObject::reifyStaticFunctionsForDelete): (JSC::JSObject::removeDirect): * runtime/JSObject.h: (JSC::JSObject::setStructureAndButterfly): (JSC::JSObject::setStructure): (JSC::JSObject::putDirectInternal): (JSC::JSObject::setStructureAndReallocateStorageIfNecessary): (JSC::JSObject::putDirectWithoutTransition): * runtime/Structure.cpp: (JSC::Structure::flattenDictionaryStructure): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154426 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ap@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=73694 http/tests/cookies/simple-cookies-max-age.html sometimes fails on Lion Intel Release (Tests) https://bugs.webkit.org/show_bug.cgi?id=73695 http/tests/cookies/single-quoted-value.html intermittently fails on Mac https://bugs.webkit.org/show_bug.cgi?id=105603 Reviewed by Dan Bernstein. Woark around a CFNetwork issue by using Max-Age=-1 instead of Max-Age=0. Since it's WebKit that we are testing and not the lower level networking, this does not change test coverage. * http/tests/cookies/resources/clearCookies.cgi: * http/tests/cookies/resources/cookies-test-pre.js: * http/tests/cookies/simple-cookies-max-age.html: * http/tests/websocket/tests/hybi/httponly-cookie.pl: * platform/mac-wk2/TestExpectations: * platform/mac/TestExpectations: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154425 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
bfulgham@apple.com authored
* platform/win/TestExpectations: Renable some tests git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154424 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-