Commits · 8027278e0b260b56744abc5357f75997aaa4010e · App_Technologies / webkit

28 Mar, 2008 17 commits

ap@webkit.org authored Mar 28, 2008

        Fix a dtoa thread safety issue.

        WebCore can call kjs_strtod without holding JS lock, but we didn't have thread safety
        compiled in for dtoa.

        This is a 0.5% regression on SunSpider, which Sam Weinig has volunteered to cover with
        his recent improvement.

        * kjs/dtoa.cpp:
        (Bigint::Balloc):
        (Bigint::Bfree):
        Changed to use fastMalloc/fastDelete - they are much faster than the dtoa custom version was
        in the presence of locking (but somewhat slower in single-threaded case).
        (Bigint::pow5mult): Got rid of the dreaded double-checked locking anti-pattern (had to
        restructure the code to avoid significant performance implications).
        (Bigint::lshift): Rewrote to avoid an allocation, if possible.

        (Bigint::rv_alloc):
        (Bigint::kjs_freedtoa):
        (Bigint::kjs_dtoa):
        Check for USE(MULTIPLE_THREADS), not dtoa legacy MULTIPLE_THREADS.

        * kjs/InitializeThreading.cpp: Added.
        (KJS::initializeThreading):
        * kjs/InitializeThreading.h: Added.
        Initialize threading at KJS level, if enabled.

        * kjs/dtoa.h: Expose dtoa mutex for KJS::initializeThreading.

        * kjs/testkjs.cpp: (kjsmain): Call initializeThreading.

        * JavaScriptCore.exp: Export KJS::initializeThreading.

        * GNUmakefile.am:
        * JavaScriptCore.exp:
        * JavaScriptCore.pri:
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
        * JavaScriptCoreSources.bkl:
        * JavaScriptCore.xcodeproj/project.pbxproj:
        Added InitializeThreading.{h,cpp}.

        * wtf/Threading.h: Removed a using directive for WTF::initializeThreading - it is only
        to be called from KJS::initializeThreading, and having it in the global namespace is useless.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31404 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8027278e

2008-03-28 Brent Fulgham <bfulgham@gmail.com> · e852058d

beidson@apple.com authored Mar 28, 2008

        Reviewed by Maciej, landed by Brady

        Correct build regression (http://bugs.webkit.org/show_bug.cgi?id=18148)

        * platform/graphics/win/GraphicsContextCairoWin.cpp:
        (WebCore::GraphicsContext::getWindowsContext):
        (WebCore::GraphicsContext::releaseWindowsContext):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31403 268f45cc-cd09-0410-ab3c-d52691b4dbfc

e852058d

2008-03-28 Brady Eidson <beidson@apple.com> · 81a1e201

beidson@apple.com authored Mar 28, 2008

        Reviewed by Sam Weinig

        Fold [WebArchiver archiveFrame:] into WebDataSource - the last remaining caller

        * WebView/WebArchiver.h:
        * WebView/WebArchiver.mm:
        * WebView/WebDataSource.mm:
        (-[WebDataSource webArchive]):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31402 268f45cc-cd09-0410-ab3c-d52691b4dbfc

81a1e201

2008-03-28 Brady Eidson <beidson@apple.com> · 788bbfa3

beidson@apple.com authored Mar 28, 2008

        Reviewed by Sam Weinig

        Remove unused [WebArchiver archiveNode:], made obsolete in r31400

        * WebView/WebArchiver.h:
        * WebView/WebArchiver.mm:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31401 268f45cc-cd09-0410-ab3c-d52691b4dbfc

788bbfa3

WebCore: · f4058d68

beidson@apple.com authored Mar 28, 2008

2008-03-28  Brady Eidson  <beidson@apple.com>

        Reviewed by Darin

        "Yet another transitional step" to empty out WebKit-based code for archiving.

        With this patch, the key operation of "Creating a WebArchive rooted at a single Node" takes place
        entirely within WebCore, and opens the door to saving WebArchives on Windows.

        This is another "zero behavior change" patch, and current editing/ and webarchive/ layout tests
        covered the relevant code

        * WebCore.base.exp:
        * loader/archive/cf/LegacyWebArchive.cpp:
        (WebCore::LegacyWebArchive::create):
        * loader/archive/cf/LegacyWebArchive.h:

WebKit/mac:

2008-03-28  Brady Eidson  <beidson@apple.com>

        Reviewed by Darin

        "Yet another transitional step" to empty out WebKit-based code for archiving.

        With this patch, the key operation of "Creating a WebArchive rooted at a single Node" takes place
        entirely within WebCore, and opens the door to saving WebArchives on Windows.

        * DOM/WebDOMOperations.mm:
        * WebView/WebArchiver.mm:
        (+[WebArchiver _archiveWithMarkupString:fromFrame:nodes:]):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31400 268f45cc-cd09-0410-ab3c-d52691b4dbfc

f4058d68

2008-03-28 Jasper Bryant-Greene <jasper@unix.geek.nz> · 9df404ab

alp@webkit.org authored Mar 28, 2008

        Reviewed by Alp Toker.

        http://bugs.webkit.org/show_bug.cgi?id=18061
        PlatformScrollBarGtk attempts to allocate negative width and/or height for widgets

        Missing clampNegativeToZero() call meant that we tried to allocate widgets with negative width and/or height.

        * platform/gtk/PlatformScrollBarGtk.cpp:
        (PlatformScrollbar::geometryChanged):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31399 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9df404ab

JavaScriptCore: · 347c0326

beidson@apple.com authored Mar 28, 2008

2008-03-28  Brady Eidson  <beidson@apple.com>

        Reviewed by Darin

        Export Unicode/UTF8.h and convertUTF16ToUTF8() for more flexible conversion in WebCore

        * JavaScriptCore.exp:
        * JavaScriptCore.xcodeproj/project.pbxproj:

WebCore:

2008-03-28  Brady Eidson  <beidson@apple.com>

        Reviewed by Darin

        Using convertUTF16ToUTF8() from WTF, add a helper function that gives you a UTF8 SharedBuffer
        created from a String.

        * ForwardingHeaders/wtf/unicode/UTF8.h: Added.
        * platform/text/PlatformString.h:
        * platform/text/String.cpp:
        (WebCore::utf8Buffer):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31398 268f45cc-cd09-0410-ab3c-d52691b4dbfc

347c0326

2008-03-28 Darin Adler <darin@apple.com> · 3cd8ef7a

darin@apple.com authored Mar 28, 2008

        Reviewed by Adam.

        - eliminate a tiny bit of unnecessary refcount churn

        * bindings/js/JSEventTargetBase.cpp:
        (WebCore::eventNameForPropertyToken): Return const AtomicString&.
        * bindings/js/JSEventTargetBase.h:
        (WebCore::JSEventTargetBase::getValueProperty): Update for above change.
        (WebCore::JSEventTargetBase::putValueProperty): Ditto.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31397 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3cd8ef7a

2008-03-28 Darin Adler <darin@apple.com> · 7e31bd16

darin@apple.com authored Mar 28, 2008

        Reviewed by Sam.

        * fast/encoding/invalid-xml-expected.txt: Update to reflect a true success.
        * fast/encoding/resources/invalid-xml.js: Eliminate race condition by not ending
        the test until the js-test-post.js script has loaded.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31396 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7e31bd16

Rubber-stamped by Brady. · 3f861464

ap@webkit.org authored Mar 28, 2008

        Enable server-side includes via AddHandler, hopefully making Apache 1.3 happy.

        * http/tests/misc/.htaccess:
        * http/tests/misc/resources/acid3/.htaccess:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31395 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3f861464

2008-03-28 Darin Adler <darin@apple.com> · a083ef71

darin@apple.com authored Mar 28, 2008

        * building/build.html: Add another mention of using the Cygwin shell.
        * building/tools.html: Fix a typo on the name Cygwin.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31394 268f45cc-cd09-0410-ab3c-d52691b4dbfc

a083ef71

Not reviewed. · 552ba9a2

ap@webkit.org authored Mar 28, 2008

        Enable mod_include for acid3.html - the previous check-in only had it in resources
        subdirectory.

        * http/tests/misc/.htaccess: Added.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31393 268f45cc-cd09-0410-ab3c-d52691b4dbfc

552ba9a2

Fix the Qt build. · cfc1c913

hausmann@webkit.org authored Mar 28, 2008

* rendering/Length.h: Include wtf/MathExtras.h for round().


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31392 268f45cc-cd09-0410-ab3c-d52691b4dbfc

cfc1c913

Reviewed by mjs. · a7f130f8

eric@webkit.org authored Mar 28, 2008

        Add Acid3 test as an http test
        http://bugs.webkit.org/show_bug.cgi?id=18176

        * http/tests/misc/acid3-expected.checksum: Added.
        * http/tests/misc/acid3-expected.png: Added.
        * http/tests/misc/acid3-expected.txt: Added.
        * http/tests/misc/acid3.html: Added.
        * http/tests/misc/resources/acid3/.htaccess: Added.
        * http/tests/misc/resources/acid3/empty.css: Added.
        * http/tests/misc/resources/acid3/empty.html: Added.
        * http/tests/misc/resources/acid3/empty.png: Added.
        * http/tests/misc/resources/acid3/empty.txt: Added.
        * http/tests/misc/resources/acid3/empty.xml: Added.
        * http/tests/misc/resources/acid3/font.svg: Added.
        * http/tests/misc/resources/acid3/font.ttf: Added.
        * http/tests/misc/resources/acid3/instructions.inc: Added.
        * http/tests/misc/resources/acid3/reference.html: Added.
        * http/tests/misc/resources/acid3/reference.png: Added.
        * http/tests/misc/resources/acid3/support-a.png.404: Added.
        * http/tests/misc/resources/acid3/support-b.png: Added.
        * http/tests/misc/resources/acid3/support-c.png: Added.
        * http/tests/misc/resources/acid3/svg.xml: Added.
        * http/tests/misc/resources/acid3/xhtml.1: Added.
        * http/tests/misc/resources/acid3/xhtml.2: Added.
        * http/tests/misc/resources/acid3/xhtml.3: Added.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31391 268f45cc-cd09-0410-ab3c-d52691b4dbfc

a7f130f8

Add layout tests for background position rounding. · 2cef50d4
hyatt@apple.com authored Mar 28, 2008
```
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31390 268f45cc-cd09-0410-ab3c-d52691b4dbfc
```
2cef50d4

2008-03-28 David Hyatt <hyatt@apple.com> · 4cac53aa

hyatt@apple.com authored Mar 28, 2008

        Fix a bug where background-position truncates instead of rounding when it evaluates to fractional
        pixel values.  This matches other browsers.

        Reviewed by maciej

        Added fast/backgrounds/background-position-rounding.html

        * rendering/Length.h:
        (WebCore::Length::calcValue):
        (WebCore::Length::calcMinValue):
        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::calculateBackgroundImageGeometry):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31389 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4cac53aa

2008-03-27 Darin Adler <darin@apple.com> · cb17bd09

mrowe@apple.com authored Mar 28, 2008

        Reviewed by Mark Rowe.

        <rdar://problem/5826236> Regular expressions with large nested repetition counts can have their
        compiled length calculated incorrectly.

        * pcre/pcre_compile.cpp:
        (multiplyWithOverflowCheck):
        (calculateCompiledPatternLength): Check for overflow when dealing with nested repetition counts
        and bail with an error rather than returning incorrect results.

2008-03-27  Mark Rowe  <mrowe@apple.com>

        Reviewed by Adam Roben.

        Tests for <rdar://problem/5826236> Regular expressions with large nested repetition counts can have their
        compiled length calculated incorrectly.

        * fast/js/regexp-overflow-expected.txt:
        * fast/js/resources/regexp-overflow.js:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31388 268f45cc-cd09-0410-ab3c-d52691b4dbfc

cb17bd09

27 Mar, 2008 14 commits

wx build fix. Return a default value for operator == when !USE(WXGC) (not... · 0ff3b99b

kevino@webkit.org authored Mar 28, 2008

wx build fix. Return a default value for operator ==  when !USE(WXGC) (not implemented in that case).


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31387 268f45cc-cd09-0410-ab3c-d52691b4dbfc

0ff3b99b

2008-03-27 Maciej Stachowiak <mjs@apple.com> · 79c36cf0

mjs@apple.com authored Mar 28, 2008

        - fix build

        * svg/SVGGlyphMap.h:
        (WebCore::GlyphMapNode::create):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31386 268f45cc-cd09-0410-ab3c-d52691b4dbfc

79c36cf0

2008-03-27 Brady Eidson <beidson@apple.com> · f5e39048

beidson@apple.com authored Mar 28, 2008

        Forgot a small requested change before committing

        * loader/DocumentLoader.cpp:
        (WebCore::DocumentLoader::mainResource):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31385 268f45cc-cd09-0410-ab3c-d52691b4dbfc

f5e39048

WebCore: · 59712ce1

beidson@apple.com authored Mar 28, 2008

2008-03-27 Brady Eidson <beidson@apple.com>

Reviewed by Adam Roben

Move [WebDataSource mainResource] and [WebDataSource subresources] down into WebCore
as the push to core-ify WebArchives continues.

This patch also introduces a behavior change. WebCore allows ArchiveResources with null or empty data.
WebKit has had the inexplicable distinction of allowing empty Data in a WebResource, but not null.
Since WebResource is API, I decided to leave it be to avoid a behavior change. But internally created resources
(as in "while archiving a page") are accepting of null or empty data.

This actually fixes a bug where not all subframes are archived, and resulted in a layout test change.

* WebCore.base.exp:
* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::archiveResourceForURL): Make this const
(WebCore::DocumentLoader::mainResource):
(WebCore::DocumentLoader::subresource): Make this const and relocate
(WebCore::DocumentLoader::getSubresources):
* loader/DocumentLoader.h:

WebKit/mac:

2008-03-27 Brady Eidson <beidson@apple.com>

Reviewed by Adam Roben

Move [WebDataSource mainResource] and [WebDataSource subresources] down into WebCore
as the push to core-ify WebArchives continues.

This actually fixes a bug where not all subframes are archived, and resulted in a layout test change.

* WebView/WebDataSource.mm:
(-[WebDataSource mainResource]): Call DocumentLoader implementation
(-[WebDataSource subresources]): Ditto
* WebView/WebFrame.mm: Remove [WebFrame _getAllResourceDatas:andResponses:] as its only caller is obsolete
* WebView/WebFrameInternal.h:

LayoutTests:

2008-03-27 Brady Eidson <beidson@apple.com>

Reviewed by Adam Roben

Updated results, as we now more consistently archive empty frames/empty resources

* webarchive/archive-empty-frame-source-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31384 268f45cc-cd09-0410-ab3c-d52691b4dbfc

59712ce1

2008-03-27 Maciej Stachowiak <mjs@apple.com> · 7f759692

mjs@apple.com authored Mar 28, 2008

        Reviewed by Darin.

        - fixed many buildbot leaks in glyph map code

        * svg/SVGGlyphMap.h:
        (WebCore::GlyphMapNode::create): Use explicit create pattern, to avoid overreffing and therefore leaking
        these objects.
        (WebCore::SVGGlyphMap::add): Call create instead of using new.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31383 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7f759692

2008-03-27 Maciej Stachowiak <mjs@apple.com> · 0741a509

mjs@apple.com authored Mar 28, 2008

        Rubber stamped by Oliver.

        - re-fix Acid3, some code was incorrectly moved when fixing the Qt build

        * rendering/SVGRootInlineBox.cpp:
        (WebCore::SVGRootInlineBox::buildLayoutInformationForTextBox):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31381 268f45cc-cd09-0410-ab3c-d52691b4dbfc

0741a509

2008-03-27 Brady Eidson <beidson@apple.com> · f4e03f7c

beidson@apple.com authored Mar 28, 2008

        Reviewed by Adam

        Change the "init from WebCore resource" version of WebResource to take PassRefPtr
        (more efficient)

        * WebView/WebResource.mm:
        (-[WebResource _initWithCoreResource:]):
        * WebView/WebResourceInternal.h:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31377 268f45cc-cd09-0410-ab3c-d52691b4dbfc

f4e03f7c

Fix compilation against Qt 4.4 and one missing SVG_FONTS #ifdef. · 613193b7
hausmann@webkit.org authored Mar 27, 2008
```
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31376 268f45cc-cd09-0410-ab3c-d52691b4dbfc
```
613193b7
Fix the Qt build and the build without ENABLE(SVG_FONTS) · af1cc00a
hausmann@webkit.org authored Mar 27, 2008
```
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31374 268f45cc-cd09-0410-ab3c-d52691b4dbfc
```
af1cc00a

Removed whitespace that crept in from r31357. · 66deecf1

ddkilzer@apple.com authored Mar 27, 2008

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31371 268f45cc-cd09-0410-ab3c-d52691b4dbfc

66deecf1

2008-03-26 Timothy Hatcher <timothy@apple.com> · 3a521b51

timothy@apple.com authored Mar 27, 2008

        Rename some Inspector files to facilitate the up-coming UI refresh changes.

        http://bugs.webkit.org/show_bug.cgi?id=17773

        Rubber-stamped by Adam Roben.

        * WebCore.vcproj/WebCore.vcproj:
        * page/inspector/Console.js: Copied from page/inspector/ConsolePanel.js.
        * page/inspector/ConsolePanel.js: Removed.
        * page/inspector/DocumentPanel.js: Removed.
        * page/inspector/ElementsPanel.js: Copied from page/inspector/DocumentPanel.js.
        * page/inspector/FontPanel.js: Removed.
        * page/inspector/FontView.js: Copied from page/inspector/FontPanel.js.
        * page/inspector/ImagePanel.js: Removed.
        * page/inspector/ImageView.js: Copied from page/inspector/ImagePanel.js.
        * page/inspector/NetworkPanel.js: Removed.
        * page/inspector/ResourcePanel.js: Removed.
        * page/inspector/ResourceView.js: Copied from page/inspector/ResourcePanel.js.
        * page/inspector/ResourcesPanel.js: Copied from page/inspector/NetworkPanel.js.
        * page/inspector/SourcePanel.js: Removed.
        * page/inspector/SourceView.js: Copied from page/inspector/SourcePanel.js.
        * page/inspector/WebKit.qrc:
        * page/inspector/inspector.html:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31370 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3a521b51

2008-03-26 Steve Falkenburg <sfalken@apple.com> · e2b1f18c

sfalken@apple.com authored Mar 27, 2008

        Enable LTCG on css, dom files in WebCore

        Reviewed by Stephanie.

        * WebCore.vcproj/WebCore.vcproj:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31369 268f45cc-cd09-0410-ab3c-d52691b4dbfc

e2b1f18c

2008-03-26 Stephanie Lewis <slewis@apple.com> · 11b8a3d4

slewis@apple.com authored Mar 27, 2008

         Fix Windows Build

         * WebCore.vcproj/WebCore.vcproj:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31368 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11b8a3d4

Speculative GTK build fix. · e968208f

mrowe@apple.com authored Mar 27, 2008


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31366 268f45cc-cd09-0410-ab3c-d52691b4dbfc

e968208f

26 Mar, 2008 9 commits

2008-03-26 Brady Eidson <beidson@apple.com> · 587de2f4

beidson@apple.com authored Mar 27, 2008

        Build fix - accidentally checked in this change which was work in progress

        * DOM/WebDOMOperations.mm:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31365 268f45cc-cd09-0410-ab3c-d52691b4dbfc

587de2f4

Mac build fix. · af2d5c36

mrowe@apple.com authored Mar 27, 2008


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31363 268f45cc-cd09-0410-ab3c-d52691b4dbfc

af2d5c36

2008-03-26 Maciej Stachowiak <mjs@apple.com> · 8a60bfe8

mjs@apple.com authored Mar 27, 2008

        More screenshots for teh blog.

        * blog-files/acid3-full-rendering-pass.png: Added.
        * blog-files/acid3-rendering-reference.png: Added.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31360 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8a60bfe8

2008-03-26 Sam Weinig <sam@webkit.org> · 44787447

weinig@apple.com authored Mar 27, 2008

        Try and fix Gtk+ again.

        * GNUmakefile.am:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31359 268f45cc-cd09-0410-ab3c-d52691b4dbfc

44787447

Reviewed by Dave Hyatt. · 812d9e3e

mitz@apple.com authored Mar 27, 2008

        - fix <rdar://problem/5816522> REGRESSION (r30111-30112): Tahoe web cam website has some text in Chinese or japanese

        * html/HTMLParser.cpp:
        (WebCore::HTMLParser::insertNode): Added call to beginParsingChildren()
        on the new node.
        (WebCore::HTMLParser::handleError): Ditto.
        (WebCore::HTMLParser::reopenResidualStyleTags): Ditto.
        (WebCore::HTMLParser::pushBlock): Removed incorrect call to
        beginParsingChildren() on the current node.
        * manual-tests/applet-finish-parsing-children.html: Added.
        * manual-tests/resources/DrawMessage.class: Added.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31358 268f45cc-cd09-0410-ab3c-d52691b4dbfc

812d9e3e

WebCore: · a4fb38f9

beidson@apple.com authored Mar 27, 2008

2008-03-26  Brady Eidson  <beidson@apple.com>

        Reviewed by Darin

        When we create a WebArchive, we walk every node from some starting point, asking each node
        along the way "What are your subresource URLs?"

        That logic is currently in DOMNode in WebKitMac - this patch moves that ability down into
        WebCore::Node

        * WebCore.base.exp:
        
        * dom/Node.cpp:
        (WebCore::Node::getSubresourceURLs):
        (WebCore::Node::getSubresourceAttributeStrings):  Virtual and empty.  Subclasses of Node that have 
          subresources will override it.

        * dom/ProcessingInstruction.cpp:
        (WebCore::ProcessingInstruction::getSubresourceAttributeStrings):
        * dom/ProcessingInstruction.h:
        * html/HTMLBodyElement.cpp:
        (WebCore::HTMLBodyElement::getSubresourceAttributeStrings):
        * html/HTMLBodyElement.h:
        * html/HTMLEmbedElement.cpp:
        (WebCore::HTMLEmbedElement::getSubresourceAttributeStrings):
        * html/HTMLEmbedElement.h:
        * html/HTMLImageElement.cpp:
        (WebCore::HTMLImageElement::getSubresourceAttributeStrings):
        * html/HTMLImageElement.h:
        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::getSubresourceAttributeStrings):
        * html/HTMLInputElement.h:
        * html/HTMLLinkElement.cpp:
        (WebCore::HTMLLinkElement::getSubresourceAttributeStrings):
        * html/HTMLLinkElement.h:
        * html/HTMLObjectElement.cpp:
        (WebCore::HTMLObjectElement::getSubresourceAttributeStrings):
        * html/HTMLObjectElement.h:
        * html/HTMLParamElement.cpp:
        (WebCore::HTMLParamElement::getSubresourceAttributeStrings):
        * html/HTMLParamElement.h:
        * html/HTMLScriptElement.cpp:
        (WebCore::HTMLScriptElement::getSubresourceAttributeStrings):
        * html/HTMLScriptElement.h:
        * html/HTMLTableCellElement.cpp:
        (WebCore::HTMLTableCellElement::getSubresourceAttributeStrings):
        * html/HTMLTableCellElement.h:
        * html/HTMLTableElement.cpp:
        (WebCore::HTMLTableElement::getSubresourceAttributeStrings):
        * html/HTMLTableElement.h:
        * svg/SVGCursorElement.cpp:
        (WebCore::SVGCursorElement::getSubresourceAttributeStrings):
        * svg/SVGCursorElement.h:
        * svg/SVGFEImageElement.cpp:
        (WebCore::SVGFEImageElement::getSubresourceAttributeStrings):
        * svg/SVGFEImageElement.h:
        * svg/SVGImageElement.cpp:
        (WebCore::SVGImageElement::getSubresourceAttributeStrings):
        * svg/SVGImageElement.h:
        * svg/SVGScriptElement.cpp:
        (WebCore::SVGScriptElement::getSubresourceAttributeStrings):
        * svg/SVGScriptElement.h:

WebKit/mac:

2008-03-26  Brady Eidson  <beidson@apple.com>

        Reviewed by Darin

        When we create a WebArchive, we walk every node from some starting point, asking each node
        along the way "What are your subresource URLs?"

        That logic is currently in DOMNode in WebKitMac - this patch moves that ability down into
        WebCore::Node

        * DOM/WebDOMOperations.mm:
        (-[DOMNode _subresourceURLs]): One generic DOMNode method can now handle all DOMNodes by
          calling into individual WebCore::Node implementations
        * DOM/WebDOMOperationsPrivate.h:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31357 268f45cc-cd09-0410-ab3c-d52691b4dbfc

a4fb38f9

Reviewed by Dave Hyatt. · 0f1089e8

mitz@apple.com authored Mar 27, 2008

        - maintain subpixel-antialiasing when drawing text with a simple shadow

        * platform/graphics/mac/FontMac.mm:
        (WebCore::Font::drawComplexText): If the shadow has a zero blur radius,
        draw the shadow by drawing the text at an offset instead of relying on
        Core Graphics shadows.
        (WebCore::Font::drawGlyphs): Ditto.
        * platform/graphics/win/FontCGWin.cpp:
        (WebCore::Font::drawGlyphs): Ditto.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31356 268f45cc-cd09-0410-ab3c-d52691b4dbfc

0f1089e8

WebCore: · b00be861

beidson@apple.com authored Mar 27, 2008

2008-03-26  Brady Eidson  <beidson@apple.com>

        Reviewed by Mark Rowe

        Part of the continued push to move WebArchive-related code down to WebCore, this
        moves [WebDataSource subresourceForURL:] down to DocumentLoader->subresource()

        * WebCore.base.exp:
        * loader/DocumentLoader.cpp:
        (WebCore::DocumentLoader::subresource): Create an ArchiveResource from a CachedResource if it exists
          Otherwise, fallback to an ArchiveResource from the current Archive if any.  Otherwise, return null
        * loader/DocumentLoader.h:

        * loader/archive/ArchiveResource.cpp:
        (WebCore::ArchiveResource::create):
        (WebCore::ArchiveResource::ArchiveResource):
        * loader/archive/ArchiveResource.h:

WebKit/mac:

2008-03-26  Brady Eidson  <beidson@apple.com>

        Reviewed by Mark Rowe

        Part of the continued push to move WebArchive-related code down to WebCore, this
        moves [WebDataSource subresourceForURL:] down to DocumentLoader->subresource()

        * WebView/WebDataSource.mm:
        (-[WebDataSource subresourceForURL:]): Call through to the DocumentLoader 

        * WebView/WebFrame.mm: Remove [WebFrame _getData:andResponse:forURL:], as its only use
          has now been ported down to WebCore
        * WebView/WebFrameInternal.h:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31355 268f45cc-cd09-0410-ab3c-d52691b4dbfc

b00be861

2008-03-26 Sam Weinig <sam@webkit.org> · d668403d

weinig@apple.com authored Mar 27, 2008

        Fix Gtk+ build.

        * GNUmakefile.am:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31354 268f45cc-cd09-0410-ab3c-d52691b4dbfc

d668403d