1. 15 Apr, 2013 28 commits
    • mrobinson@webkit.org's avatar
      [GTK] REGRESSION(r147499): HTTP auth dialog doesn't remember passwords anymore · 7f8011db
      mrobinson@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=114613
      
      Reviewed by Carlos Garcia Campos.
      
      * Source/autotools/SetupAutoconfHeader.m4: Correct definition of ENABLE_CREDENTIAL_STORAGE
      so that the ENABLE(CREDENTIAL_STORAGE) macro work properly.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148445 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7f8011db
    • zandobersek@gmail.com's avatar
      Unreviewed GTK gardening. · c4ccae31
      zandobersek@gmail.com authored
      * platform/gtk/TestExpectations: Adding failure expectations for tests introduced in r147829 and r148136.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148444 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c4ccae31
    • zandobersek@gmail.com's avatar
      Unreviewed GTK gardening. · 90d40338
      zandobersek@gmail.com authored
      * platform/gtk/fast/js/global-constructors-expected.txt: Rebaselining after r148236.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148443 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      90d40338
    • rwlbuis@webkit.org's avatar
      Fix some compiler warnings (miscellaneous) · 0c753099
      rwlbuis@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=80790
      
      Patch by Rob Buis <rbuis@rim.com> on 2013-04-15
      Reviewed by Darin Adler.
      
      It does not seem needed to initialize jpeg_create_compress struct to zero,
      all that is needed is set the err field. See for instance SkImageDecoder_libjpeg.cpp.
      
      * platform/image-encoders/JPEGImageEncoder.cpp:
      (WebCore::compressRGBABigEndianToJPEG):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148442 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0c753099
    • zandobersek@gmail.com's avatar
      Deprecate land-cowboy in favor of land-cowhand · a466e806
      zandobersek@gmail.com authored
      https://bugs.webkit.org/show_bug.cgi?id=104470
      
      Patch by Zan Dobersek <zandobersek@gmail.com> on 2013-04-15
      Reviewed by Darin Adler.
      
      Move the LandCowboy command implementation under the LandCowhand command and deprecate the former.
      
      * Scripts/webkitpy/tool/commands/download.py:
      (LandCowhand):
      (LandCowboy):
      (LandCowboy._prepare_state):
      * Scripts/webkitpy/tool/commands/download_unittest.py:
      (test_land_cowhand): Adjust the unit tests by testing both LandCowhand and LandCowboy,
      also checking the deprecation message in the output of the latter.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148441 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a466e806
    • paroga@webkit.org's avatar
      [GTK] Remove platform specific implementation of KURL::fileSystemPath() · b0a057ea
      paroga@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=114133
      
      Reviewed by Martin Robinson.
      
      r147883 added a generic implementation of this function,
      which can be used by all ports to share the code.
      
      * GNUmakefile.list.am:
      * platform/KURL.cpp:
      (WebCore):
      * platform/gtk/KURLGtk.cpp: Removed.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148440 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b0a057ea
    • commit-queue@webkit.org's avatar
      Schedule rendering at regular interval (60fps) · 3b83585f
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=114617
      
      Patch by Seulgi Kim <seulgikim@company100.net> on 2013-04-15
      Reviewed by Martin Robinson.
      
      Schedule rendering reguarly regardless of the time taken to render a
      frame. Otherwise, next flush delayed by the amount of the rendering
      time.
      
      * WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp:
      (WebKit::LayerTreeHostGtk::LayerTreeHostGtk):
      (WebKit::LayerTreeHostGtk::layerFlushTimerFired):
      (WebKit::LayerTreeHostGtk::flushAndRenderLayers):
      * WebProcess/WebPage/gtk/LayerTreeHostGtk.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148439 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3b83585f
    • paroga@webkit.org's avatar
      Unreviewed WinCE build fix after r148373. · 7f50d685
      paroga@webkit.org authored
      * WebCoreSupport/EditorClientWinCE.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148438 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7f50d685
    • ossy@webkit.org's avatar
      Debug buildfix after r148433. · 144bde60
      ossy@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=108295
      
      Reviewed by Allan Sandfeld Jensen.
      
      * platform/graphics/texmap/TextureMapperLayer.h:
      (WebCore::TextureMapperLayer::children): Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148437 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      144bde60
    • zarvai@inf.u-szeged.hu's avatar
      [Qt] Unreviewed gardening. · bf163a4a
      zarvai@inf.u-szeged.hu authored
      * platform/qt-5.0-wk1/TestExpectations:
      * platform/qt/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148436 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bf163a4a
    • commit-queue@webkit.org's avatar
      Improve Windows cmd.exe detection · 12c83769
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=114620
      
      Patch by Jonathan Liu <net147@gmail.com> on 2013-04-15
      Reviewed by Jocelyn Turcotte.
      
      The current detection code handles Windows cmd.exe and Cygwin shell
      but not does not handle MSYS shell correctly. Simplify and improve the
      detection by checking MINGW_IN_SHELL instead as used in other places
      (e.g. qt_functions.prf).
      
      * qmake/mkspecs/features/default_pre.prf:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148435 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      12c83769
    • commit-queue@webkit.org's avatar
      [EFL][WK2] Use C API in ewk_context_menu · e48eb1c9
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=109698
      
      Patch by Michał Pakuła vel Rutka <m.pakula@samsung.com> on 2013-04-15
      Reviewed by Andreas Kling.
      
      EFL port unlike others does not handle context menus inside WebKit but exposes an API:
      ewk_context_menu and ewk_context_menu_item, and leaves context menu to application.
      Currently EFL port's context menu API uses internal C++ classes, while it should use WK2 C API,
      to avoid violating layering.
      This patch changes EFL context menu API to use only WK2 C API.
      
      * UIProcess/API/efl/EwkView.cpp:
      (EwkView::showContextMenu):
      * UIProcess/API/efl/EwkView.h:
      (WebKit):
      (EwkView):
      * UIProcess/API/efl/ewk_context_menu.cpp:
      (EwkContextMenu::EwkContextMenu):
      (EwkContextMenu::contextMenuItemSelected):
      (ewk_context_menu_item_select):
      (getWKTagFromEwkAction):
      * UIProcess/API/efl/ewk_context_menu_item.cpp:
      (EwkContextMenuItem::EwkContextMenuItem):
      (getEwkActionFromWKTag):
      * UIProcess/API/efl/ewk_context_menu_item.h:
      * UIProcess/API/efl/ewk_context_menu_item_private.h:
      (EwkContextMenuItem::create):
      (EwkContextMenuItem):
      * UIProcess/API/efl/ewk_context_menu_private.h:
      (EwkContextMenu::create):
      (EwkContextMenu):
      * UIProcess/efl/ContextMenuClientEfl.cpp:
      (showContextMenu):
      (hideContextMenu):
      (ContextMenuClientEfl::ContextMenuClientEfl):
      * UIProcess/efl/ContextMenuClientEfl.h:
      (WebKit::ContextMenuClientEfl::view):
      * UIProcess/efl/WebContextMenuProxyEfl.cpp:
      (WebKit::WebContextMenuProxyEfl::showContextMenu):
      (WebKit::WebContextMenuProxyEfl::hideContextMenu):
      * UIProcess/efl/WebContextMenuProxyEfl.h:
      (WebContextMenuProxyEfl):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148434 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e48eb1c9
    • commit-queue@webkit.org's avatar
      Coordinated Graphics: Remove GraphicsLayerTextureMapper dependency from CoordinatedGraphicsScene. · 4578d0d9
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=108295
      
      Since all the changes to the TextureMapperLayer tree now come in a single IPC message via
      CoordinatedGraphicsState, we don't need the additional buffering done in GraphicsLayerTextureMapper.
      
      This reduces unnecessary function calls, and also streamlines GraphicsLayerTextureMapper to be used
      only in WebKit1 (without CoordinatedGraphics).
      
      Patch by Noam Rosenthal <noam@webkit.org> on 2013-04-15
      Reviewed by Allan Sandfeld Jensen.
      
      No new tests, refactor only.
      
      * platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:
      (WebCore::GraphicsLayerTextureMapper::GraphicsLayerTextureMapper):
      (WebCore::GraphicsLayerTextureMapper::setNeedsDisplay):
      (WebCore::GraphicsLayerTextureMapper::setNeedsDisplayInRect):
      (WebCore::GraphicsLayerTextureMapper::setDrawsContent):
      (WebCore::GraphicsLayerTextureMapper::prepareBackingStoreIfNeeded):
      (WebCore::GraphicsLayerTextureMapper::updateDebugBorderAndRepaintCount):
      (WebCore::GraphicsLayerTextureMapper::updateBackingStoreIfNeeded):
      (WebCore):
      * platform/graphics/texmap/GraphicsLayerTextureMapper.h:
      (GraphicsLayerTextureMapper):
          Removed references to m_hasOwnBackingStore, which was done to separate the CoordinatedGraphics
          path from the WK1 path.
      
      * platform/graphics/texmap/TextureMapperLayer.h:
      (WebCore::TextureMapperLayer::drawsContent):
      (WebCore::TextureMapperLayer::contentsAreVisible):
      (WebCore::TextureMapperLayer::size):
      (WebCore::TextureMapperLayer::opacity):
      (WebCore::TextureMapperLayer::transform):
      (WebCore::TextureMapperLayer::isShowingRepaintCounter):
      (WebCore::TextureMapperLayer::fixedToViewport):
      (TextureMapperLayer):
          Added a few public functions needed by CoordinatedGraphicsScene.
      
      * platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.cpp:
      (WebCore::layerShouldHaveBackingStore):
      (WebCore::CoordinatedGraphicsScene::paintToCurrentGLContext):
      (WebCore::CoordinatedGraphicsScene::paintToGraphicsContext):
      (WebCore::CoordinatedGraphicsScene::adjustPositionForFixedLayers):
      (WebCore::CoordinatedGraphicsScene::createCanvasIfNeeded):
      (WebCore::CoordinatedGraphicsScene::syncCanvasIfNeeded):
      (WebCore::CoordinatedGraphicsScene::destroyCanvasIfNeeded):
      (WebCore::CoordinatedGraphicsScene::setLayerRepaintCountIfNeeded):
      (WebCore::CoordinatedGraphicsScene::setLayerChildrenIfNeeded):
      (WebCore::CoordinatedGraphicsScene::setLayerFiltersIfNeeded):
      (WebCore::CoordinatedGraphicsScene::setLayerState):
      (WebCore::CoordinatedGraphicsScene::getLayerByIDIfExists):
      (WebCore::CoordinatedGraphicsScene::createLayer):
      (WebCore::CoordinatedGraphicsScene::deleteLayer):
      (WebCore::CoordinatedGraphicsScene::setRootLayerID):
      (WebCore::CoordinatedGraphicsScene::prepareContentBackingStore):
      (WebCore::CoordinatedGraphicsScene::createBackingStoreIfNeeded):
      (WebCore::CoordinatedGraphicsScene::removeBackingStoreIfNeeded):
      (WebCore::CoordinatedGraphicsScene::resetBackingStoreSizeToLayerSize):
      (WebCore::CoordinatedGraphicsScene::createTilesIfNeeded):
      (WebCore::CoordinatedGraphicsScene::removeTilesIfNeeded):
      (WebCore::CoordinatedGraphicsScene::updateTilesIfNeeded):
      (WebCore::CoordinatedGraphicsScene::assignImageBackingToLayer):
      (WebCore::CoordinatedGraphicsScene::commitSceneState):
      (WebCore::CoordinatedGraphicsScene::ensureRootLayer):
      (WebCore::CoordinatedGraphicsScene::setLayerAnimationsIfNeeded):
      (WebCore::CoordinatedGraphicsScene::findScrollableContentsLayerAt):
      * platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.h:
      (CoordinatedGraphicsScene):
      (WebCore::CoordinatedGraphicsScene::layerByID):
      (WebCore::CoordinatedGraphicsScene::rootLayer):
          Use TextureMapperLayer instead of GraphicsLayer and GraphicsLayerTextureMapper.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148433 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4578d0d9
    • antti@apple.com's avatar
      Dynamically triggered subframe loads are causing tile churn · 4d3b2178
      antti@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=114440
              
      Reviewed by Andreas Kling.
              
      In some cases we switch in and out of minimal tiles multiple times during page loading. This
      creates tile churn where we create speculative tiles and then throw them out. This can be
      caused by various reasons including dynamically created subframes.
      
      * page/FrameView.cpp:
      (WebCore::FrameView::setIsVisuallyNonEmpty):
              
          Stay in minimal tiles modes until there is some visual contents. This avoids switching out from minimal
          tiles while awaiting response for the initial requests.
      
      * page/FrameView.h:
      * rendering/RenderLayerBacking.cpp:
      (WebCore::RenderLayerBacking::RenderLayerBacking):
      (WebCore::computeTileCoverage):
      * rendering/RenderLayerBacking.h:
      (WebCore::RenderLayerBacking::didSwitchToFullTileCoverageDuringLoading):
      (WebCore::RenderLayerBacking::setDidSwitchToFullTileCoverageDuringLoading):
              
          Only switch into minimal coverage mode once per page load.
      
      (RenderLayerBacking):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148432 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4d3b2178
    • commit-queue@webkit.org's avatar
      color-index media feature not supported · 53473ee6
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=114468
      
      Patch by Rune Lillesveen <rune@opera.com> on 2013-04-15
      Reviewed by Kenneth Rohde Christiansen.
      
      Source/WebCore:
      
      Support the color-index media feature. Currently assumes that no WebKit
      browser will have an output device that uses a color lookup table.
      
      Tests: fast/media/mq-color-index-01.html
             fast/media/mq-color-index-02.html
      
      * css/MediaFeatureNames.h:
      (MediaFeatureNames):
      * css/MediaQueryEvaluator.cpp:
      (WebCore::color_indexMediaFeatureEval):
      (WebCore):
      (WebCore::min_color_indexMediaFeatureEval):
      (WebCore::max_color_indexMediaFeatureEval):
      * css/MediaQueryExp.cpp:
      (WebCore::featureWithPositiveInteger):
      (WebCore::featureWithoutValue):
      
      LayoutTests:
      
      Added testcases for checking support and handling invalid values for
      the color-index media feature.
      
      * fast/media/mq-color-index-01-expected.html: Added.
      * fast/media/mq-color-index-01.html: Added.
      * fast/media/mq-color-index-02-expected.txt: Added.
      * fast/media/mq-color-index-02.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148431 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      53473ee6
    • kbalazs@webkit.org's avatar
      [CoordGfx] Background color should not be part of GraphicsLayerState · 1283cf3b
      kbalazs@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113785
      
      Source/WebCore:
      
      Page background is independent from layer state, send it to the UI
      as soon as possible.
      
      Should not cause observable change in behavior so no new tests.
      
      * platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.cpp:
      (WebCore::CoordinatedGraphicsScene::commitSceneState):
      * platform/graphics/texmap/coordinated/CoordinatedGraphicsState.h:
      
      Source/WebKit2:
      
      Reviewed by Andreas Kling.
      
      Page background is independent from layer state, send it to the UI
      as soon as possible.
      
      * Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp:
      (CoreIPC::::encode):
      (CoreIPC::::decode):
      * WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:
      (WebKit::CoordinatedLayerTreeHost::setBackgroundColor):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148430 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1283cf3b
    • commit-queue@webkit.org's avatar
      [webkitpy] Use $NUMBER_OF_PROCESSORS in Executive.cpu_count() · 446e6fdc
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=114506
      
      Patch by Manuel Rego Casasnovas <rego@igalia.com> on 2013-04-15
      Reviewed by Philippe Normand.
      
      * Scripts/webkitpy/common/system/executive.py:
      (Executive.cpu_count): Modify function in order to use the environment
      variable $NUMBER_OF_PROCESSORS if it is defined and it is an integer
      greater than 0.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148429 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      446e6fdc
    • commit-queue@webkit.org's avatar
      [BlackBerry] ASSERT in StyleResolver::ensureScopeResolver() · bd4b4ce5
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=114615
      
      Patch by Xan Lopez <xlopez@igalia.com> on 2013-04-15
      Reviewed by Carlos Garcia Campos.
      
      Source/WebKit/blackberry:
      
      Add a method to enable the style scoped feature to our
      DumpRenderTreeSupport class.
      
      * WebKitSupport/DumpRenderTreeSupport.cpp:
      (DumpRenderTreeSupport::setStyleScopedEnabled):
      * WebKitSupport/DumpRenderTreeSupport.h:
      (DumpRenderTreeSupport):
      
      Tools:
      
      Enable the style scoped feature if we have support for it.
      
      * DumpRenderTree/blackberry/DumpRenderTree.cpp:
      (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148427 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bd4b4ce5
    • commit-queue@webkit.org's avatar
      [EFL] Unskip some inspector tests related to styles · 3ea1a0e1
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=114609
      
      Unreviewed gardening.
      
      Patch by Seokju Kwon <seokju.kwon@gmail.com> on 2013-04-15
      
      * platform/efl-wk2/TestExpectations: Old issues. Fixed on the latest codebase.
      * platform/efl/TestExpectations: Fixed by r128637.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148426 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3ea1a0e1
    • commit-queue@webkit.org's avatar
      [BlackBerry] Filesystem callback notifyCreateSnapshotFileAndReadMetadata can... · 1f10e0c1
      commit-queue@webkit.org authored
      [BlackBerry] Filesystem callback notifyCreateSnapshotFileAndReadMetadata can be called on the wring thread
      https://bugs.webkit.org/show_bug.cgi?id=114610
      
      Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2013-04-15
      Reviewed by Xan Lopez.
      
      Override notifyCreateSnapshotFileAndReadMetadata to make sure the
      callback is called on the right thread.
      
      Fixes a crash in several fast/filesystem test in debug builds.
      
      * platform/blackberry/WorkerPlatformAsyncFileSystemCallbacks.cpp:
      (WebCore::WorkerPlatformAsyncFileSystemCallbacks::notifyCreateSnapshotFileAndReadMetadata):
      (WebCore::WorkerPlatformAsyncFileSystemCallbacks::notifyCreateSnapshotFileAndReadMetadataOnWorkerThread):
      * platform/blackberry/WorkerPlatformAsyncFileSystemCallbacks.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148425 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1f10e0c1
    • anilsson@rim.com's avatar
      [BlackBerry][CSS Filters] Non-image content disappears when filter applied · d393aae0
      anilsson@rim.com authored
      https://bugs.webkit.org/show_bug.cgi?id=114498
      
      Reviewed by Carlos Garcia Campos.
      
      Applying a filter to a div with simple text content caused the div to
      disappear.
      
      In https://bugs.webkit.org/show_bug.cgi?id=114276, we added some GL
      state save/restore code for vertex attributes to make sure the state
      changes done by BlackBerry::Platform::Graphics don't interfere with
      GL code executing in WebKit. However, saving and restoring vertex
      attribute state won't do much good if those attributes were never
      enabled to begin with. Fixed by enabling vertex attributes
      appropriately when setting them, so that state can be saved and
      restored.
      
      All the CSS Filters layout tests apply the filters to simple rectangles
      or images, there's nothing sufficiently complex that we manage to
      trigger this GL state conflict in the BlackBerry port. This suggests
      adding a new platform-specific layout test would be appropriate, but
      since we don't use pixel tests yet, such a test would not help detect
      regressions. Ultimately we decided against adding a layout test for
      this bug at this time.
      
      * platform/graphics/blackberry/LayerFilterRenderer.cpp:
      (WebCore::LayerFilterRenderer::applyActions):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148423 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d393aae0
    • allan.jensen@digia.com's avatar
      [Qt] QtMultimedia not used when GStreamer is not found · 4687af25
      allan.jensen@digia.com authored
      https://bugs.webkit.org/show_bug.cgi?id=111842
      
      Reviewed by Philippe Normand.
      
      Fallback to using QtMultimedia when native libraries are not found.
      
      * qmake/mkspecs/features/features.prf:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148422 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4687af25
    • g.czajkowski@samsung.com's avatar
      Unreviewed EFL gardening. · 08009eb2
      g.czajkowski@samsung.com authored
      spelling-with-whitespace-selection.html passes after r148282.
      
      * platform/efl-wk2/TestExpectations:
      * platform/efl/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148421 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      08009eb2
    • commit-queue@webkit.org's avatar
      [WK2] Add new callbacks and a function for WebKit2 context menu API · 7c44c3f1
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=111552
      
      Patch by Michał Pakuła vel Rutka <m.pakula@samsung.com> on 2013-04-15
      Reviewed by Anders Carlsson.
      
      Add contextMenuHide and contextMenuShow callbacks to WKPageContextMenuClient
      and WKPageContextMenuSelected API so context menus can be handled outside
      WebKit. API version of this client was bumped so older client version still
       can be used
      
      * Shared/APIClientTraits.cpp:
      (WebKit):
      * Shared/APIClientTraits.h:
      * UIProcess/API/C/WKPage.cpp:
      (WKPageSelectContextMenuItem):
      * UIProcess/API/C/WKPage.h:
      * UIProcess/API/gtk/WebKitContextMenuClient.cpp:
      (attachContextMenuClientToView):
      * UIProcess/WebPageContextMenuClient.cpp:
      (WebKit::WebPageContextMenuClient::getContextMenuFromProposedMenu):
      (WebKit::WebPageContextMenuClient::showContextMenu):
      (WebKit):
      (WebKit::WebPageContextMenuClient::hideContextMenu):
      * UIProcess/WebPageContextMenuClient.h:
      (WebPageContextMenuClient):
      * UIProcess/WebPageProxy.cpp:
      (WebKit::WebPageProxy::internalShowContextMenu):
      * UIProcess/efl/ContextMenuClientEfl.cpp:
      (ContextMenuClientEfl::ContextMenuClientEfl):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148420 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7c44c3f1
    • commit-queue@webkit.org's avatar
      [EFL] inspector/styles/styles-history.html is flaky · 61ddf2ba
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=98777
      
      Unreviewed gardening.
      
      Unskip inspector/styles/styles-history.html as it was fixed by r131895.
      
      Patch by Seokju Kwon <seokju.kwon@gmail.com> on 2013-04-15
      
      * platform/efl/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148419 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      61ddf2ba
    • commit-queue@webkit.org's avatar
      [EFL] Remove inspector/styles/paste-property-expected.txt from efl-wk2 · 580bc724
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=114604
      
      Unreviewed gardening.
      
      Remove an improper file after r147420.
      
      Patch by Seokju Kwon <seokju.kwon@gmail.com> on 2013-04-15
      
      * platform/efl-wk2/inspector/styles/paste-property-expected.txt: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148418 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      580bc724
    • ch.dumez@sisa.samsung.com's avatar
      Unreviewed EFL gardening. · 32afd1fd
      ch.dumez@sisa.samsung.com authored
      Rebaseline fast/js/global-constructors.html for EFL port due to
      addition of MutationRecordConstructor.
      
      * platform/efl/fast/js/global-constructors-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148417 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      32afd1fd
    • ch.dumez@sisa.samsung.com's avatar
      Unreviewed EFL gardening. · 8452a1a8
      ch.dumez@sisa.samsung.com authored
      Rebaseline several SVG tests for EFL port.
      
      * platform/efl-wk2/svg/css/group-with-shadow-expected.png:
      * platform/efl-wk2/svg/filters/shadow-on-rect-with-filter-expected.png:
      * platform/efl/svg/css/arrow-with-shadow-expected.png:
      * platform/efl/svg/css/arrow-with-shadow-expected.txt: Removed.
      * platform/efl/svg/css/circle-in-mask-with-shadow-expected.txt: Removed.
      * platform/efl/svg/css/clippath-with-shadow-expected.txt: Removed.
      * platform/efl/svg/css/composite-shadow-example-expected.png:
      * platform/efl/svg/css/composite-shadow-example-expected.txt:
      * platform/efl/svg/css/composite-shadow-with-opacity-expected.png:
      * platform/efl/svg/css/composite-shadow-with-opacity-expected.txt:
      * platform/efl/svg/css/group-with-shadow-expected.txt:
      * platform/efl/svg/css/path-with-shadow-expected.txt:
      * platform/efl/svg/css/shadow-and-opacity-expected.txt:
      * platform/efl/svg/css/shadow-with-large-radius-expected.txt: Removed.
      * platform/efl/svg/css/shadow-with-negative-offset-expected.txt: Removed.
      * platform/efl/svg/css/text-gradient-shadow-expected.txt:
      * platform/efl/svg/css/text-shadow-multiple-expected.txt:
      * platform/efl/svg/filters/shadow-on-rect-with-filter-expected.txt: Removed.
      * platform/efl/transitions/svg-text-shadow-transition-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148416 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8452a1a8
  2. 14 Apr, 2013 12 commits
    • commit-queue@webkit.org's avatar
      [css3-text] Parsing -webkit-hanging value for text-indent from css3-text · 32ebd47b
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113680
      
      Source/WebCore:
      
      Patch by Jaehun Lim <ljaehun.lim@samsung.com> on 2013-04-14
      Reviewed by Andreas Kling.
      
      This patch is the parsing part to support hanging value for text-indent.
      "hanging" means "Inverts which lines are affected."
      It's prefixed and guarded by CSS3_TEXT flag.
      
      No new tests, this patch updates existing tests.
      
      * css/CSSComputedStyleDeclaration.cpp:
      (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
      * css/CSSParser.cpp:
      (WebCore::CSSParser::parseTextIndent): Parsed "-webkit-hanging" with "-webkit-each-line".
      * css/CSSValueKeywords.in: Added "-webkit-hanging" keyword.
      * css/DeprecatedStyleBuilder.cpp:
      (WebCore::ApplyPropertyTextIndent::applyInheritValue):
      (WebCore::ApplyPropertyTextIndent::applyInitialValue):
      (WebCore::ApplyPropertyTextIndent::applyValue):
      * rendering/style/RenderStyle.h:
      * rendering/style/RenderStyleConstants.h: Added enum TextIndentType.
      * rendering/style/StyleRareInheritedData.cpp:
      (WebCore::StyleRareInheritedData::StyleRareInheritedData):
      (WebCore::StyleRareInheritedData::operator==):
      * rendering/style/StyleRareInheritedData.h: Added m_textIndentType.
      (StyleRareInheritedData):
          Added the usual getter / setter / initial methods for m_textIndentType.
      
      LayoutTests:
      
      "hanging" is added for text-indent in CSS3.
      http://dev.w3.org/csswg/css3-text/#hanging
      
      Patch by Jaehun Lim <ljaehun.lim@samsung.com> on 2013-04-14
      Reviewed by Andreas Kling.
      
      * fast/css3-text/css3-text-indent/getComputedStyle/getComputedStyle-text-indent-expected.txt:
      * fast/css3-text/css3-text-indent/getComputedStyle/script-tests/getComputedStyle-text-indent.js:
      (valueSettingTest):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148414 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      32ebd47b
    • weinig@apple.com's avatar
      Move Mac specific snapshotting code into its own file · 197a9e18
      weinig@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=114597
      
      Reviewed by Andreas Kling.
      
      Source/WebCore: 
      
      * WebCore.exp.in:
      * WebCore.xcodeproj/project.pbxproj:
      * bindings/objc/DOM.mm:
      (-[DOMRange renderedImageForcingBlackText:]):
      * page/Frame.h:
      * page/mac/FrameMac.mm:
      (WebCore::Frame::nodeImage):
      (WebCore::Frame::dragImageForSelection):
      * page/mac/FrameSnapshottingMac.h: Added.
      * page/mac/FrameSnapshottingMac.mm: Added.
      (WebCore::imageFromRect):
      (WebCore::selectionImage):
      (WebCore::rangeImage):
      (WebCore::snapshotDragImage):
      * platform/mac/ClipboardMac.mm:
      (WebCore::ClipboardMac::dragNSImage):
      Move the four Mac specific snapshotting functions in Frame.h into FrameSnapshottingMac.h/mm and turn
      them into free standing functions.
      
      Source/WebKit/mac: 
      
      * WebView/WebHTMLView.mm:
      (-[WebHTMLView _selectionDraggingImage]):
      (-[WebHTMLView selectionImageForcingBlackText:]):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148413 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      197a9e18
    • akling@apple.com's avatar
      Re-skip editing/spelling/spelling-changed-text.html on Mac/WK1. · 5ffcf3ee
      akling@apple.com authored
      * platform/mac/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148412 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5ffcf3ee
    • akling@apple.com's avatar
      Hawtfix Mac build. · 2b103758
      akling@apple.com authored
      * WebCore.exp.in:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148411 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2b103758
    • akling@apple.com's avatar
      Only MutableStylePropertySets should be able to have CSSOM wrappers. · 0add35c4
      akling@apple.com authored
      <http://webkit.org/b/114595>
      
      Reviewed by Antti Koivisto.
      
      Tighten typing so that only MutableStylePropertySets can have CSSOM wrappers associated.
      This allows us to get rid of the out-of-line base class destructor.
      
      * WebCore.exp.in:
      * css/StylePropertySet.cpp:
      (WebCore::MutableStylePropertySet::~MutableStylePropertySet):
      (WebCore::MutableStylePropertySet::cssStyleDeclaration):
      (WebCore::MutableStylePropertySet::ensureInlineCSSStyleDeclaration):
      * css/StylePropertySet.h:
      (StylePropertySet):
      (MutableStylePropertySet):
      * dom/StyledElement.cpp:
      (WebCore::StyledElement::inlineStyleCSSOMWrapper):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148410 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0add35c4
    • akling@apple.com's avatar
      Remove unused function declaration StylePropertySet::setNeedsStyleRecalc(). · 79d3d4a7
      akling@apple.com authored
      Rubber-stamped by Antti Koivisto.
      
      * css/StylePropertySet.h:
      (StylePropertySet):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148408 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      79d3d4a7
    • ch.dumez@sisa.samsung.com's avatar
      [EFL][WK2] Regression(r148274): Broke rendering in the browser · 3f0c705f
      ch.dumez@sisa.samsung.com authored
      https://bugs.webkit.org/show_bug.cgi?id=114593
      
      Reviewed by Anders Carlsson.
      
      r148274 added a new "didChangeViewportAttributes" callback to
      WKView but did not hook it up in ViewClientEfl. This patch
      fixes this and makes rendering work again in the browser.
      
      * UIProcess/efl/ViewClientEfl.cpp:
      (WebKit::ViewClientEfl::ViewClientEfl):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148407 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3f0c705f
    • akling@apple.com's avatar
      Move StylePropertySet internal storage access helpers to subclass. · e1e9bca7
      akling@apple.com authored
      <http://webkit.org/b/114592>
      
      Reviewed by Antti Koivisto.
      
      Removed mutablePropertyVector() since most call sites are inside MutableStylePropertySet
      and can access m_propertyVector directly. The few ones that aren't can just cast.
      
      For ImmutableStylePropertySet, moved value/metadata array accessors to the subclass
      and remove "immutable" from their names.
      
      * css/StylePropertySet.cpp:
      (WebCore::StylePropertySet::immutableCopyIfNeeded):
      (WebCore::ImmutableStylePropertySet::ImmutableStylePropertySet):
      (WebCore::ImmutableStylePropertySet::~ImmutableStylePropertySet):
      (WebCore::MutableStylePropertySet::MutableStylePropertySet):
      (WebCore::MutableStylePropertySet::removeProperty):
      (WebCore::MutableStylePropertySet::removePrefixedOrUnprefixedProperty):
      (WebCore::MutableStylePropertySet::setProperty):
      (WebCore::MutableStylePropertySet::appendPrefixingVariantProperty):
      (WebCore::MutableStylePropertySet::parseDeclaration):
      (WebCore::MutableStylePropertySet::addParsedProperties):
      (WebCore::MutableStylePropertySet::clear):
      (WebCore::MutableStylePropertySet::removePropertiesInSet):
      (WebCore::MutableStylePropertySet::findCSSPropertyWithID):
      (WebCore::MutableStylePropertySet::removeEquivalentProperties):
      (WebCore::StylePropertySet::reportMemoryUsage):
      * css/StylePropertySet.h:
      (PropertyReference):
      (StylePropertySet):
      (ImmutableStylePropertySet):
      (WebCore::ImmutableStylePropertySet::valueArray):
      (WebCore::ImmutableStylePropertySet::metadataArray):
      (WebCore::StylePropertySet::PropertyReference::propertyMetadata):
      (WebCore::StylePropertySet::PropertyReference::propertyValue):
      (WebCore::StylePropertySet::propertyCount):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148406 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e1e9bca7
    • oliver@apple.com's avatar
      Try to fix non-apple windows builds · b7afa273
      oliver@apple.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148405 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b7afa273
    • akling@apple.com's avatar
      Specialize propertyCount() in StylePropertySet subclasses. · 6d56932a
      akling@apple.com authored
      <http://webkit.org/b/114590>
      
      Reviewed by Antti Koivisto.
      
      Avoid branching on m_isMutable in code that already knows which type of set it is.
      
      * css/StylePropertySet.h:
      (WebCore::ImmutableStylePropertySet::propertyCount):
      (ImmutableStylePropertySet):
      (WebCore::MutableStylePropertySet::propertyCount):
      (MutableStylePropertySet):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148404 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6d56932a
    • akling@apple.com's avatar
      Move property setting/removing functions to MutableStylePropertySet. · 0b60d79a
      akling@apple.com authored
      <http://webkit.org/b/114589>
      
      Reviewed by Antti Koivisto.
      
      Move all functions for setting/removing properties from StylePropertySet to MutableStylePropertySet.
      Had to change SVGElement::animatedSMILStyleProperties() & friends to hand out MutableStylePropertySet*
      which was always the internal type anyway.
      
      * css/StylePropertySet.cpp:
      (WebCore::MutableStylePropertySet::removeShorthandProperty):
      (WebCore::MutableStylePropertySet::removeProperty):
      (WebCore::MutableStylePropertySet::removePrefixedOrUnprefixedProperty):
      (WebCore::MutableStylePropertySet::setProperty):
      (WebCore::MutableStylePropertySet::appendPrefixingVariantProperty):
      (WebCore::MutableStylePropertySet::setPrefixingVariantProperty):
      (WebCore::MutableStylePropertySet::mergeAndOverrideOnConflict):
      (WebCore::MutableStylePropertySet::removeBlockProperties):
      (WebCore::MutableStylePropertySet::removePropertiesInSet):
      (WebCore::MutableStylePropertySet::findCSSPropertyWithID):
      (WebCore::MutableStylePropertySet::removeEquivalentProperties):
      * css/StylePropertySet.h:
      (StylePropertySet):
      (MutableStylePropertySet):
      * editing/ApplyStyleCommand.cpp:
      (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
      (WebCore::ApplyStyleCommand::removeEmbeddingUpToEnclosingBlock):
      (WebCore::ApplyStyleCommand::applyInlineStyleToNodeRange):
      * editing/EditingStyle.cpp:
      (WebCore::EditingStyle::triStateOfStyle):
      (WebCore::removePropertiesInStyle):
      (WebCore::reconcileTextDecorationProperties):
      * svg/SVGAnimateElement.cpp:
      (WebCore::applyCSSPropertyToTarget):
      * svg/SVGElement.cpp:
      (WebCore::SVGElement::animatedSMILStyleProperties):
      (WebCore::SVGElement::ensureAnimatedSMILStyleProperties):
      * svg/SVGElement.h:
      (SVGElement):
      * svg/SVGElementRareData.h:
      (WebCore::SVGElementRareData::animatedSMILStyleProperties):
      (WebCore::SVGElementRareData::ensureAnimatedSMILStyleProperties):
      (SVGElementRareData):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148403 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0b60d79a
    • akling@apple.com's avatar
      EditingStyle should have a MutableStylePropertySet internally. · dd624e17
      akling@apple.com authored
      <http://webkit.org/b/114588>
      
      Reviewed by Anders Carlsson.
      
      Switch EditingStyle::m_mutableStyle to a RefPtr<MutableStylePropertySet>.
      
      * css/StylePropertySet.cpp:
      (WebCore::StylePropertySet::copyBlockProperties):
      * css/StylePropertySet.h:
      (StylePropertySet):
      * editing/EditingStyle.cpp:
      (WebCore::EditingStyle::setStyle):
      (WebCore::EditingStyle::mergeStyleFromRules):
      (WebCore::StyleChange::StyleChange):
      (WebCore::setTextDecorationProperty):
      (WebCore::StyleChange::extractTextStyles):
      (WebCore::diffTextDecorations):
      (WebCore::getPropertiesNotIn):
      * editing/EditingStyle.h:
      (WebCore::EditingStyle::style):
      (EditingStyle):
      (StyleChange):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@148402 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dd624e17