1. 09 Nov, 2011 40 commits
    • mhahnenberg@apple.com's avatar
      De-virtualize JSObject::getOwnPropertyDescriptor · 7f2f7e53
      mhahnenberg@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=71523
      
      Reviewed by Sam Weinig.
      
      Source/JavaScriptCore: 
      
      Added getOwnPropertyDescriptor to the MethodTable, changed all of the 
      virtual versions of getOwnPropertyDescriptor to static ones, and 
      changed all of the call sites to the corresponding lookup in the MethodTable.
      
      * API/JSCallbackObject.h:
      * API/JSCallbackObjectFunctions.h:
      (JSC::::getOwnPropertyDescriptor):
      * JavaScriptCore.exp:
      * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
      * debugger/DebuggerActivation.cpp:
      (JSC::DebuggerActivation::getOwnPropertyDescriptor):
      * debugger/DebuggerActivation.h:
      * runtime/Arguments.cpp:
      (JSC::Arguments::getOwnPropertyDescriptor):
      * runtime/Arguments.h:
      * runtime/ArrayConstructor.cpp:
      (JSC::ArrayConstructor::getOwnPropertyDescriptor):
      * runtime/ArrayConstructor.h:
      * runtime/ArrayPrototype.cpp:
      (JSC::ArrayPrototype::getOwnPropertyDescriptor):
      * runtime/ArrayPrototype.h:
      * runtime/BooleanPrototype.cpp:
      (JSC::BooleanPrototype::getOwnPropertyDescriptor):
      * runtime/BooleanPrototype.h:
      * runtime/ClassInfo.h:
      * runtime/DateConstructor.cpp:
      (JSC::DateConstructor::getOwnPropertyDescriptor):
      * runtime/DateConstructor.h:
      * runtime/DatePrototype.cpp:
      (JSC::DatePrototype::getOwnPropertyDescriptor):
      * runtime/DatePrototype.h:
      * runtime/ErrorPrototype.cpp:
      (JSC::ErrorPrototype::getOwnPropertyDescriptor):
      * runtime/ErrorPrototype.h:
      * runtime/JSArray.cpp:
      (JSC::JSArray::getOwnPropertyDescriptor):
      * runtime/JSArray.h:
      * runtime/JSByteArray.cpp:
      (JSC::JSByteArray::getOwnPropertyDescriptor):
      * runtime/JSByteArray.h:
      * runtime/JSCell.cpp:
      (JSC::JSCell::getOwnPropertyDescriptor):
      * runtime/JSCell.h:
      * runtime/JSFunction.cpp:
      (JSC::JSFunction::getOwnPropertyDescriptor):
      * runtime/JSFunction.h:
      * runtime/JSGlobalObject.cpp:
      (JSC::JSGlobalObject::getOwnPropertyDescriptor):
      * runtime/JSGlobalObject.h:
      * runtime/JSNotAnObject.cpp:
      (JSC::JSNotAnObject::getOwnPropertyDescriptor):
      * runtime/JSNotAnObject.h:
      * runtime/JSONObject.cpp:
      (JSC::JSONObject::getOwnPropertyDescriptor):
      * runtime/JSONObject.h:
      * runtime/JSObject.cpp:
      (JSC::JSObject::vtableAnchor):
      (JSC::JSObject::propertyIsEnumerable):
      (JSC::JSObject::getOwnPropertyDescriptor):
      (JSC::JSObject::getPropertyDescriptor):
      (JSC::JSObject::defineOwnProperty):
      * runtime/JSObject.h:
      * runtime/JSString.cpp: Removed getOwnPropertyDescriptor, since this seems to be a relic from a 
      bygone era when getOwnPropertyDescriptor was rooted in JSCell rather than JSObject.  There were 
      no call sites for this version of getOwnPropertyDescriptor in the entire project.
      * runtime/JSString.h:
      * runtime/Lookup.h:
      (JSC::getStaticPropertyDescriptor):
      (JSC::getStaticFunctionDescriptor):
      (JSC::getStaticValueDescriptor):
      * runtime/MathObject.cpp:
      (JSC::MathObject::getOwnPropertyDescriptor):
      * runtime/MathObject.h:
      * runtime/NumberConstructor.cpp:
      (JSC::NumberConstructor::getOwnPropertyDescriptor):
      * runtime/NumberConstructor.h:
      * runtime/NumberPrototype.cpp:
      (JSC::NumberPrototype::getOwnPropertyDescriptor):
      * runtime/NumberPrototype.h:
      * runtime/ObjectConstructor.cpp:
      (JSC::ObjectConstructor::getOwnPropertyDescriptor):
      (JSC::objectConstructorGetOwnPropertyDescriptor):
      * runtime/ObjectConstructor.h:
      * runtime/ObjectPrototype.cpp:
      (JSC::ObjectPrototype::getOwnPropertyDescriptor):
      * runtime/ObjectPrototype.h:
      * runtime/RegExpConstructor.cpp:
      (JSC::RegExpConstructor::getOwnPropertyDescriptor):
      * runtime/RegExpConstructor.h:
      * runtime/RegExpMatchesArray.h:
      (JSC::RegExpMatchesArray::getOwnPropertyDescriptor):
      * runtime/RegExpObject.cpp:
      (JSC::RegExpObject::getOwnPropertyDescriptor):
      * runtime/RegExpObject.h:
      * runtime/RegExpPrototype.cpp:
      (JSC::RegExpPrototype::getOwnPropertyDescriptor):
      * runtime/RegExpPrototype.h:
      * runtime/StringConstructor.cpp:
      (JSC::StringConstructor::getOwnPropertyDescriptor):
      * runtime/StringConstructor.h:
      * runtime/StringObject.cpp:
      (JSC::StringObject::vtableAnchor): Added to prevent a weak vtable.
      (JSC::StringObject::getOwnPropertyDescriptor):
      * runtime/StringObject.h:
      * runtime/StringPrototype.cpp:
      (JSC::StringPrototype::getOwnPropertyDescriptor):
      * runtime/StringPrototype.h:
      
      Source/WebCore: 
      
      No new tests.
      
      Added getOwnPropertyDescriptor to the MethodTable, changed all of the 
      virtual versions of getOwnPropertyDescriptor to static ones, and 
      changed all of the call sites to the corresponding lookup in the MethodTable.
      
      * WebCore.exp.in:
      * bindings/js/JSDOMWindowCustom.cpp:
      (WebCore::JSDOMWindow::getOwnPropertyDescriptor):
      * bindings/js/JSDOMWindowShell.cpp:
      (WebCore::JSDOMWindowShell::getOwnPropertyDescriptor):
      * bindings/js/JSDOMWindowShell.h:
      * bindings/js/JSWorkerContextCustom.cpp:
      (WebCore::JSWorkerContext::getOwnPropertyDescriptorDelegate):
      * bindings/scripts/CodeGeneratorJS.pm:
      (GenerateGetOwnPropertyDescriptorBody):
      (GenerateHeader):
      (GenerateImplementation):
      (GenerateConstructorDeclaration):
      (GenerateConstructorDefinition):
      * bindings/scripts/test/JS/JSTestInterface.cpp:
      (WebCore::JSTestInterfaceConstructor::getOwnPropertyDescriptor):
      (WebCore::JSTestInterface::getOwnPropertyDescriptor):
      * bindings/scripts/test/JS/JSTestInterface.h:
      * bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
      (WebCore::JSTestMediaQueryListListenerConstructor::getOwnPropertyDescriptor):
      (WebCore::JSTestMediaQueryListListenerPrototype::getOwnPropertyDescriptor):
      (WebCore::JSTestMediaQueryListListener::getOwnPropertyDescriptor):
      * bindings/scripts/test/JS/JSTestMediaQueryListListener.h:
      * bindings/scripts/test/JS/JSTestObj.cpp:
      (WebCore::JSTestObjConstructor::getOwnPropertyDescriptor):
      (WebCore::JSTestObjPrototype::getOwnPropertyDescriptor):
      (WebCore::JSTestObj::getOwnPropertyDescriptor):
      * bindings/scripts/test/JS/JSTestObj.h:
      * bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
      (WebCore::JSTestSerializedScriptValueInterfaceConstructor::getOwnPropertyDescriptor):
      (WebCore::JSTestSerializedScriptValueInterface::getOwnPropertyDescriptor):
      * bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h:
      * bridge/objc/objc_runtime.h:
      * bridge/objc/objc_runtime.mm:
      (JSC::Bindings::ObjcFallbackObjectImp::getOwnPropertyDescriptor):
      * bridge/qt/qt_runtime.cpp:
      (JSC::Bindings::QtRuntimeMetaMethod::getOwnPropertyDescriptor):
      (JSC::Bindings::QtRuntimeConnectionMethod::getOwnPropertyDescriptor):
      * bridge/qt/qt_runtime.h:
      * bridge/runtime_array.cpp:
      (JSC::RuntimeArray::getOwnPropertyDescriptor):
      * bridge/runtime_array.h:
      * bridge/runtime_method.cpp:
      (JSC::RuntimeMethod::vtableAnchor): Added to prevent a weak vtable.
      (JSC::RuntimeMethod::getOwnPropertyDescriptor):
      * bridge/runtime_method.h: Changed getOwnPropertyDescriptor from private to protected to allow 
      subclasses to use it in their MethodTables.
      * bridge/runtime_object.cpp:
      (JSC::Bindings::RuntimeObject::getOwnPropertyDescriptor):
      * bridge/runtime_object.h:
      
      Source/WebKit2: 
      
      Added getOwnPropertyDescriptor to the MethodTable, changed all of the 
      virtual versions of getOwnPropertyDescriptor to static ones, and 
      changed all of the call sites to the corresponding lookup in the MethodTable.
      
      * WebProcess/Plugins/Netscape/JSNPObject.cpp:
      (WebKit::JSNPObject::getOwnPropertyDescriptor):
      * WebProcess/Plugins/Netscape/JSNPObject.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@99754 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7f2f7e53
    • xji@chromium.org's avatar
      Rebaseline after r99616 and r99736. · 2172b954
      xji@chromium.org authored
      Delete platform/chromium/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.txt
      so that cr-mac failed for text too.
      
      * platform/chromium/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.txt: Removed.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@99753 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2172b954
    • jchaffraix@webkit.org's avatar
      REGRESSION (r93614): Content remains despite parent element being scrolled off... · c6365021
      jchaffraix@webkit.org authored
      REGRESSION (r93614): Content remains despite parent element being scrolled off page using javascript.
      https://bugs.webkit.org/show_bug.cgi?id=71550
      
      Reviewed by Simon Fraser.
      
      Source/WebCore:
      
      Tests: fast/repaint/overflow-auto-in-overflow-auto-scrolled.html
             fast/repaint/overflow-hidden-in-overflow-hidden-scrolled.html
             fast/repaint/overflow-scroll-in-overflow-scroll-scrolled.html
             fast/repaint/scroll-inside-table-cell.html
             fast/repaint/scroll-relative-table-inside-table-cell.html
             fast/repaint/table-overflow-auto-in-overflow-auto-scrolled.html
             fast/repaint/table-overflow-hidden-in-overflow-hidden-scrolled.html
             fast/repaint/table-overflow-scroll-in-overflow-scroll-scrolled.html
      
      The issue was that updateLayerPositionsAfterScroll would not update some layer's
      repaint rectangles. Thus we would not properly repaint (if at all).
      
      The optimization added in 93614 was short-sighted and missed the fact that tables are a
      special case when it comes to updating the repaint rectangles. When we scroll a layer
      with an overflow clip, most layers *do* need to update their repaint rectangles.
      
      This changes keeps the optimization for cells as this is the hotest case for tables
      with overflow: hidden on cells but is much more conservative: if we encounter an
      overflow clip, we update the descendant's repaint rectangles.
      
      * rendering/RenderLayer.cpp:
      (WebCore::RenderLayer::RenderLayer):
      (WebCore::RenderLayer::updateLayerPositionsAfterScroll):
      Refactored the code to use some flags (HasSeenFixedPositionedAncestor and
      HasSeenAncestorWithOverflowClip). Also added an exception if
      m_canSkipRepaintRectsUpdateOnScroll is set.
      
      * rendering/RenderLayer.h:
      Added a new field when it is fine to not update our repaint rects on scroll.
      
      LayoutTests:
      
      Added some repaint tests on the same idea (overflow: scroll / auto / hidden +/- table).
      
      * fast/repaint/overflow-auto-in-overflow-auto-scrolled-expected.txt: Added.
      * fast/repaint/overflow-auto-in-overflow-auto-scrolled.html: Added.
      * fast/repaint/overflow-hidden-in-overflow-hidden-scrolled-expected.png: Added.
      * fast/repaint/overflow-hidden-in-overflow-hidden-scrolled-expected.txt: Added.
      * fast/repaint/overflow-hidden-in-overflow-hidden-scrolled.html: Added.
      * fast/repaint/overflow-scroll-in-overflow-scroll-scrolled-expected.txt: Added.
      * fast/repaint/overflow-scroll-in-overflow-scroll-scrolled.html: Added.
      * fast/repaint/scroll-inside-table-cell-expected.txt: Added.
      * fast/repaint/scroll-inside-table-cell.html: Added.
      * fast/repaint/scroll-relative-table-inside-table-cell-expected.txt: Added.
      * fast/repaint/scroll-relative-table-inside-table-cell.html: Added.
      * fast/repaint/table-overflow-auto-in-overflow-auto-scrolled-expected.txt: Added.
      * fast/repaint/table-overflow-auto-in-overflow-auto-scrolled.html: Added.
      * fast/repaint/table-overflow-hidden-in-overflow-hidden-scrolled-expected.txt: Added.
      * fast/repaint/table-overflow-hidden-in-overflow-hidden-scrolled.html: Added.
      * fast/repaint/table-overflow-scroll-in-overflow-scroll-scrolled-expected.txt: Added.
      * fast/repaint/table-overflow-scroll-in-overflow-scroll-scrolled.html: Added.
      * platform/chromium-linux/fast/repaint/overflow-auto-in-overflow-auto-scrolled-expected.png: Added.
      * platform/chromium-linux/fast/repaint/overflow-scroll-in-overflow-scroll-scrolled-expected.png: Added.
      * platform/chromium-linux/fast/repaint/scroll-inside-table-cell-expected.png: Added.
      * platform/chromium-linux/fast/repaint/scroll-relative-table-inside-table-cell-expected.png: Added.
      * platform/chromium-linux/fast/repaint/table-overflow-auto-in-overflow-auto-scrolled-expected.png: Added.
      * platform/chromium-linux/fast/repaint/table-overflow-hidden-in-overflow-hidden-scrolled-expected.png: Added.
      * platform/chromium-linux/fast/repaint/table-overflow-scroll-in-overflow-scroll-scrolled-expected.png: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@99752 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c6365021
    • scherkus@chromium.org's avatar
      Tests depending on video-paint-test.js can run non-deterministically · ac96e8a4
      scherkus@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=71878
      
      Reviewed by Darin Adler.
      
      * media/video-frame-accurate-seek.html: changed init() to initAndSeeked()
      * media/video-paint-test.js:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@99751 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ac96e8a4
    • haraken@chromium.org's avatar
      Generate the HTMLAudioElement constructor using [NamedConstructor] IDL · eab3ca92
      haraken@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=71924
      
      Reviewed by Adam Barth.
      
      This patch removes a custom constructor of HTMLAudioElement
      and generates it using [NamedConstructor] IDL.
      
      Tests:  fast/js/custom-constructors.html
              media/audio-constructor.html
              media/audio-constructor-src.html
              media/audio-constructor-preload.html
              media/audio-controls-do-not-fade-out.html
              media/audio-controls-rendering.html
      
      * Target.pri: Removed V8HTMLAudioElementConstructor.{h,cpp}
      * WebCore.gypi: Ditto.
      * bindings/v8/custom/V8HTMLAudioElementConstructor.cpp: Removed.
      * bindings/v8/custom/V8HTMLAudioElementConstructor.h: Removed.
      * html/HTMLAudioElement.idl: Added [NamedConstructor] IDL.
      * page/DOMWindow.idl: Removed [V8CustomConstructor] IDL.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@99750 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      eab3ca92
    • antti@apple.com's avatar
      Eliminate CSSMutableValue · 1af9ae44
      antti@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=71811
      
      Source/WebCore: 
      
      Reviewed by Darin Adler, Andreas Kling and Nikolas Zimmerman.
      
      Remove the implementations of setter functions in SVGColor and SVGPaint. These interfaces are
      deprecated in SVG 1.1 (2nd edition) and are not really used by anybody. This allows
      removal of CSSMutableValue and the associated (rather broken) code.
              
      The setters now throw NO_MODIFICATION_ALLOWED_ERR. 
      
      * GNUmakefile.list.am:
      * WebCore.gypi:
      * WebCore.xcodeproj/project.pbxproj:
      * css/CSSMutableStyleDeclaration.cpp:
      (WebCore::CSSMutableStyleDeclaration::~CSSMutableStyleDeclaration):
      * css/CSSMutableValue.h: Removed.
      * css/CSSStyleDeclaration.cpp:
      (WebCore::CSSStyleDeclaration::getPropertyCSSValue):
      * css/CSSValue.h:
      (WebCore::CSSValue::CSSValue):
      * svg/SVGColor.cpp:
      (WebCore::SVGColor::SVGColor):
      (WebCore::SVGColor::setRGBColor):
      (WebCore::SVGColor::setRGBColorICCColor):
      (WebCore::SVGColor::setColor):
      * svg/SVGColor.h:
      * svg/SVGPaint.cpp:
      (WebCore::SVGPaint::setUri):
      (WebCore::SVGPaint::setPaint):
      * svg/SVGPaint.h:
      
      LayoutTests: 
      
      Reviewed by Darin Adler, Andreas Kling and Nikolas Zimmerman.
              
      SVGColor and SVGPaint setter function are deprecated and throw exception.
          
      - Remove (mostly render tree dump based) tests for SVGColor mutations that have little useful
        coverage otherwise.
      - Fix some other tests to work without the feature.
      - Update rgb-color-parser.html to also cover the cases from rgbcolor-syntax.svg (which is removed).
        They test the same thing but the former uses a better mechanism.
      - Update the test results to capture the new behavior.
      
      * fast/css/parse-color-int-or-percent-crash.html:
      * platform/gtk/svg/custom/SVGPaint-mutate-attribute-expected.png: Removed.
      * platform/gtk/svg/custom/SVGPaint-mutate-attribute-expected.txt: Removed.
      * platform/gtk/svg/custom/SVGPaint-mutate-inline-style-expected.png: Removed.
      * platform/gtk/svg/custom/SVGPaint-mutate-inline-style-expected.txt: Removed.
      * platform/gtk/svg/custom/rgbcolor-syntax-expected.png: Removed.
      * platform/gtk/svg/custom/rgbcolor-syntax-expected.txt: Removed.
      * platform/mac/svg/custom/SVGPaint-mutate-attribute-expected.png: Removed.
      * platform/mac/svg/custom/SVGPaint-mutate-attribute-expected.txt: Removed.
      * platform/mac/svg/custom/SVGPaint-mutate-inline-style-expected.png: Removed.
      * platform/mac/svg/custom/SVGPaint-mutate-inline-style-expected.txt: Removed.
      * platform/mac/svg/custom/rgbcolor-syntax-expected.png: Removed.
      * platform/mac/svg/custom/rgbcolor-syntax-expected.txt: Removed.
      * platform/qt/svg/custom/SVGPaint-mutate-attribute-expected.png: Removed.
      * platform/qt/svg/custom/SVGPaint-mutate-attribute-expected.txt: Removed.
      * platform/qt/svg/custom/SVGPaint-mutate-inline-style-expected.png: Removed.
      * platform/qt/svg/custom/SVGPaint-mutate-inline-style-expected.txt: Removed.
      * platform/qt/svg/custom/rgbcolor-syntax-expected.png: Removed.
      * platform/qt/svg/custom/rgbcolor-syntax-expected.txt: Removed.
      * svg/custom/SVGPaint-mutate-attribute.svg: Removed.
      * svg/custom/SVGPaint-mutate-inline-style.svg: Removed.
      * svg/custom/fill-SVGPaint-interface.svg:
      * svg/custom/getPresentationAttribute-modify-expected.txt: Removed.
      * svg/custom/getPresentationAttribute-modify.svg: Removed.
      * svg/custom/getPresentationAttribute.svg:
      * svg/custom/rgbcolor-syntax.svg: Removed.
      * svg/dom/SVGColor-expected.txt:
      * svg/dom/SVGPaint-expected.txt:
      * svg/dom/getPresentationAttribute-cache-corruption-expected.txt: Removed.
      * svg/dom/getPresentationAttribute-cache-corruption.svg: Removed.
      * svg/dom/rgb-color-parser-expected.txt:
      * svg/dom/rgb-color-parser.html:
      * svg/dom/script-tests/SVGColor.js:
      * svg/dom/script-tests/SVGPaint.js:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@99749 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1af9ae44
    • philn@webkit.org's avatar
      [GTK][DRT] window internals object is not reset after each test · d457390c
      philn@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=71890
      
      Reviewed by Martin Robinson.
      
      .:
      
      * Source/autotools/symbols.filter: Revert un-needed symbol.
      
      Source/WebKit/gtk:
      
      * WebCoreSupport/DumpRenderTreeSupportGtk.cpp: Remove problematic
      calls to WebCoreSupport which belongs to libWebCoreInternals, not libwebkitgtk.
      * WebCoreSupport/DumpRenderTreeSupportGtk.h:
      
      Tools:
      
      Call WebCoreTestSupport::resetInternalsObject without going
      through DumpRenderTreeSupport.
      
      * DumpRenderTree/gtk/DumpRenderTree.cpp:
      (runTest):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@99748 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d457390c
    • haraken@chromium.org's avatar
      Generate the HTMLOptionElement constructor using [NamedConstructor] IDL · 4c580c7f
      haraken@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=71925
      
      Reviewed by Adam Barth.
      
      This patch removes a custom constructor of HTMLOptionElement,
      and generates it using [NamedConstructor] IDL.
      
      Tests: fast/js/custom-constructors.html
             fast/forms/option-index.html
             fast/forms/add-and-remove-option.html
             fast/dom/dom-add-optionelement.html
      
      * Target.pri: Removed V8HTMLOptionElementConstructor.{h,cpp}
      * WebCore.gypi: Ditto.
      * bindings/v8/custom/V8HTMLOptionElementConstructor.cpp: Removed.
      * bindings/v8/custom/V8HTMLOptionElementConstructor.h: Removed.
      * html/HTMLOptionElement.idl: Added [NamedConstructor] IDL.
      * page/DOMWindow.idl: Removed [V8CustomConstructor] IDL.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@99747 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4c580c7f
    • bdakin@apple.com's avatar
      Build fix. · d0acf542
      bdakin@apple.com authored
      * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
      (AccessibilityUIElement::uiElementAttributeValue):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@99746 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d0acf542
    • barraclough@apple.com's avatar
      https://bugs.webkit.org/show_bug.cgi?id=71873 · 2326f425
      barraclough@apple.com authored
      Reviewed by Geoff Garen.
      
      Incrementally re-landing these changes, trying to determine what went wrong.
      (The whole patch failed tests on the build bot but worked locally.
      
      * assembler/MacroAssemblerARM.h:
      (JSC::MacroAssemblerARM::supportsFloatingPoint):
      (JSC::MacroAssemblerARM::supportsFloatingPointTruncate):
      (JSC::MacroAssemblerARM::supportsFloatingPointSqrt):
      (JSC::MacroAssemblerARM::supportsFloatingPointAbs):
      * assembler/MacroAssemblerARMv7.h:
      (JSC::MacroAssemblerARMv7::supportsFloatingPoint):
      (JSC::MacroAssemblerARMv7::supportsFloatingPointTruncate):
      (JSC::MacroAssemblerARMv7::supportsFloatingPointSqrt):
      (JSC::MacroAssemblerARMv7::supportsFloatingPointAbs):
      * assembler/MacroAssemblerMIPS.h:
      (JSC::MacroAssemblerMIPS::supportsFloatingPoint):
      (JSC::MacroAssemblerMIPS::supportsFloatingPointTruncate):
      (JSC::MacroAssemblerMIPS::supportsFloatingPointSqrt):
      (JSC::MacroAssemblerMIPS::supportsFloatingPointAbs):
      * assembler/MacroAssemblerSH4.h:
      (JSC::MacroAssemblerSH4::supportsFloatingPoint):
      (JSC::MacroAssemblerSH4::supportsFloatingPointTruncate):
      (JSC::MacroAssemblerSH4::supportsFloatingPointSqrt):
      (JSC::MacroAssemblerSH4::supportsFloatingPointAbs):
      * assembler/MacroAssemblerX86.h:
      (JSC::MacroAssemblerX86::supportsFloatingPoint):
      (JSC::MacroAssemblerX86::supportsFloatingPointTruncate):
      (JSC::MacroAssemblerX86::supportsFloatingPointSqrt):
      (JSC::MacroAssemblerX86::supportsFloatingPointAbs):
      * assembler/MacroAssemblerX86_64.h:
      (JSC::MacroAssemblerX86_64::supportsFloatingPoint):
      (JSC::MacroAssemblerX86_64::supportsFloatingPointTruncate):
      (JSC::MacroAssemblerX86_64::supportsFloatingPointSqrt):
      (JSC::MacroAssemblerX86_64::supportsFloatingPointAbs):
      * jit/ThunkGenerators.cpp:
      (JSC::absThunkGenerator):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@99745 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2326f425
    • jchaffraix@webkit.org's avatar
      Crash in RenderTableSection::splitColumn · d01277df
      jchaffraix@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=70171
      
      Reviewed by David Hyatt.
      
      Source/WebCore:
      
      Tests: fast/table/crash-splitColumn-2.html
             fast/table/crash-splitColumn-3.html
             fast/table/crash-splitColumn.html
      
      The old code would not take into account the fact that each RenderTableSection
      can set its m_needsCellRecalc flag independently of the rest.
      
      This means that you cannot assume that you can always split or append columns to
      all the sections. Our approach is to skip sections needing cell recalc in several
      parts of the code as they will be properly reset to the table's representations
      during a cell recalc.
      
      * rendering/RenderTable.cpp:
      (WebCore::RenderTable::splitColumn):
      (WebCore::RenderTable::appendColumn):
      Skip sections needing cell recalc as they will be properly updated later.
      
      * rendering/RenderTableSection.cpp:
      (WebCore::RenderTableSection::addCell):
      Ignore a section needing cell recalc as addCell will be called after sync'ing
      the internal column representation in recalcCells.
      
      (WebCore::RenderTableSection::recalcCells):
      Clear the flag at the beginning of the function to activate the previous functions.
      Added a comment as to why this is fine.
      
      (WebCore::RenderTableSection::appendColumn):
      Added an ASSERT. If we need cell recalc, we should NEVER update m_grid outside
      of recalcCells().
      
      LayoutTests:
      
      Added a couple of tests where different sections get their
      m_needsCellRecalc set independently.
      
      * fast/table/crash-splitColumn-2-expected.txt: Added.
      * fast/table/crash-splitColumn-2.html: Added.
      * fast/table/crash-splitColumn-3-expected.txt: Added.
      * fast/table/crash-splitColumn-3.html: Added.
      * fast/table/crash-splitColumn-expected.txt: Added.
      * fast/table/crash-splitColumn.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@99744 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d01277df
    • bdakin@apple.com's avatar
      Speculative build fix. · 06671d55
      bdakin@apple.com authored
      * DumpRenderTree/AccessibilityUIElement.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@99743 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      06671d55
    • commit-queue@webkit.org's avatar
      Microdata: fast/dom/MicroData/itemid-attribute-test.html assertion failure in... · 08a0bbe6
      commit-queue@webkit.org authored
      Microdata: fast/dom/MicroData/itemid-attribute-test.html assertion failure in Element::getURLAttribute().
      https://bugs.webkit.org/show_bug.cgi?id=71510
      
      Patch by Arko Saha <arko@motorola.com> on 2011-11-09
      Reviewed by Darin Adler.
      
      Source/WebCore:
      
      Override isURLAttribute() for HTMLElement and return true if attribute is itemidAttr.
      All the classes derived from HTMLElement overrides this function should return true if attribute is itemidAttr.
      Removed HTMLIFrameElement::isURLAttribute() method as HTMLFrameElementBase already takes care of it.
      
      Test: fast/dom/MicroData/itemid-attribute-test-001.html
      
      * html/HTMLAnchorElement.cpp:
      (WebCore::HTMLAnchorElement::isURLAttribute):
      * html/HTMLBaseElement.cpp:
      (WebCore::HTMLBaseElement::isURLAttribute):
      * html/HTMLBodyElement.cpp:
      (WebCore::HTMLBodyElement::isURLAttribute):
      * html/HTMLButtonElement.cpp:
      (WebCore::HTMLButtonElement::isURLAttribute):
      * html/HTMLElement.cpp:
      (WebCore::HTMLElement::isURLAttribute):
      * html/HTMLElement.h:
      * html/HTMLEmbedElement.cpp:
      (WebCore::HTMLEmbedElement::isURLAttribute):
      * html/HTMLFormElement.cpp:
      (WebCore::HTMLFormElement::isURLAttribute):
      * html/HTMLFrameElementBase.cpp:
      (WebCore::HTMLFrameElementBase::isURLAttribute):
      * html/HTMLHtmlElement.cpp:
      (WebCore::HTMLHtmlElement::isURLAttribute):
      * html/HTMLIFrameElement.cpp:
      * html/HTMLIFrameElement.h:
      * html/HTMLImageElement.cpp:
      (WebCore::HTMLImageElement::isURLAttribute):
      * html/HTMLInputElement.cpp:
      (WebCore::HTMLInputElement::isURLAttribute):
      * html/HTMLLinkElement.cpp:
      (WebCore::HTMLLinkElement::isURLAttribute):
      * html/HTMLMediaElement.cpp:
      (WebCore::HTMLMediaElement::isURLAttribute):
      * html/HTMLModElement.cpp:
      (WebCore::HTMLModElement::isURLAttribute):
      * html/HTMLObjectElement.cpp:
      (WebCore::HTMLObjectElement::isURLAttribute):
      * html/HTMLParamElement.cpp:
      (WebCore::HTMLParamElement::isURLAttribute):
      * html/HTMLQuoteElement.cpp:
      (WebCore::HTMLQuoteElement::isURLAttribute):
      * html/HTMLScriptElement.cpp:
      (WebCore::HTMLScriptElement::isURLAttribute):
      * html/HTMLSourceElement.cpp:
      (WebCore::HTMLSourceElement::isURLAttribute):
      * html/HTMLTableCellElement.cpp:
      (WebCore::HTMLTableCellElement::isURLAttribute):
      * html/HTMLTableElement.cpp:
      (WebCore::HTMLTableElement::isURLAttribute):
      * html/HTMLTrackElement.cpp:
      (WebCore::HTMLTrackElement::isURLAttribute):
      
      LayoutTests:
      
      * fast/dom/MicroData/itemid-attribute-test-001-expected.txt: Added.
      * fast/dom/MicroData/itemid-attribute-test-001.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@99742 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      08a0bbe6
    • jchaffraix@webkit.org's avatar
      Unreviewed build fix. · 405f33af
      jchaffraix@webkit.org authored
      * DumpRenderTree/AccessibilityUIElement.cpp:
      (AccessibilityUIElement::makeJSAccessibilityUIElement):
      A bad merge added this check that is making the bots sad.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@99741 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      405f33af
    • cfleizach@apple.com's avatar
      AX: crash when accessing selectedTab in a tab list · 798114f8
      cfleizach@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=70938
      
      Reviewed by Beth Dakin.
      
      Source/WebCore: 
      
      There were a few methods accessing m_children directly without first validating that those elements
      needed to be updated (because the layout changed). Changing those to call children() ensures
      that they will have the correct children.
      
      Test: platform/mac/accessibility/selected-tab-crash.html
      
      * accessibility/AccessibilityRenderObject.cpp:
      (WebCore::AccessibilityRenderObject::isChecked):
      (WebCore::AccessibilityRenderObject::selectedRadioButton):
      (WebCore::AccessibilityRenderObject::selectedTabItem):
      (WebCore::AccessibilityRenderObject::ariaListboxVisibleChildren):
      (WebCore::AccessibilityRenderObject::tabChildren):
      
      Tools: 
      
      Add the ability to retrieve an element through an arbitrary attribute.
      
      * DumpRenderTree/AccessibilityUIElement.cpp:
      (uiElementAttributeValueCallback):
      (AccessibilityUIElement::uiElementAttributeValue):
      (AccessibilityUIElement::getJSClass):
      * DumpRenderTree/AccessibilityUIElement.h:
      * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
      (AccessibilityUIElement::uiElementAttributeValue):
      
      LayoutTests: 
      
      * platform/mac/accessibility/selected-tab-crash-expected.txt: Added.
      * platform/mac/accessibility/selected-tab-crash.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@99740 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      798114f8
    • ojan@chromium.org's avatar
      Remove failures fixed with r99630. · 571a6cf8
      ojan@chromium.org authored
      * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@99739 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      571a6cf8
    • philn@webkit.org's avatar
      Unreviewed, GTK new baselines for 2 svg tests and skip a crashing · ef619d41
      philn@webkit.org authored
      test that needs investigation.
      
      * platform/gtk/Skipped:
      * platform/gtk/svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size-expected.txt: Added.
      * platform/gtk/svg/as-image/animated-svg-as-image-same-image-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@99737 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ef619d41
    • xji@chromium.org's avatar
      Rebaseline after r99616. · 4a9f7c08
      xji@chromium.org authored
      * platform/chromium-linux/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.png: Added.
      * platform/chromium-win/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.png: Added.
      * platform/chromium-win/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.txt: Added.
      * platform/chromium/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.txt: Added.
      * platform/chromium/test_expectations.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@99736 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4a9f7c08
    • achicu@adobe.com's avatar
      Fixing build on MacOSX SL after 71838 · fb7ddde1
      achicu@adobe.com authored
      https://bugs.webkit.org/show_bug.cgi?id=71912
      
      Reviewed by Anders Carlsson.
      
      * WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
      (WebKit::TiledCoreAnimationDrawingArea::TiledCoreAnimationDrawingArea):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@99735 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fb7ddde1
    • andreas.kling@nokia.com's avatar
      Shrink HTMLCollection. · c84be3e9
      andreas.kling@nokia.com authored
      <http://webkit.org/b/71928>
      
      Reviewed by Darin Adler.
      
      Rearrange the members of HTMLCollection, effectively shrinking
      it by 16 bytes on 64-bit. This reduces memory consumption
      by 531 kB when loading the full HTML5 spec.
      
      On 32-bit it shrinks by 8 bytes, saving 265 kB.
      
      * html/HTMLCollection.cpp:
      (WebCore::HTMLCollection::HTMLCollection):
      * html/HTMLCollection.h:
      (WebCore::HTMLCollection::type):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@99734 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c84be3e9
    • darin@apple.com's avatar
      Add code path in HashTable for emptyValueIsZero that does not require copying the empty value · 2b419862
      darin@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=71875
      
      Reviewed by Anders Carlsson.
      
      This is a step along the path of making OwnPtr work as HashMap value types.
      
      * wtf/Alignment.h: Moved the AlignedBufferChar and AlignedBuffer types from Vector.h here.
      Also fixed include style. To include other WTF headers inside WTF, we use "" includes.
      I did not change the code to fix style checker complaints.
      
      * wtf/HashTable.h: Added includes as needed and fixed include style.
      (WTF::doubleHash): Removed the uneeeded and inappropriate "static" in this function, which
      gave it internal linkage for no good reason.
      (WTF::HashTable::checkKey): Made this use AlignedBuffer for the deleted value check to avoid
      construction/destruction problems instead of doing the trick where we construct and destroy
      an empty value twice. It's cleaner and simpler and avoids copying the empty value.
      (WTF::HashTable::initializeBucket): Specialized initializeBucket to use memset when the
      empty value is zero rather than copying an empty value.
      
      * wtf/Vector.h: Moved the AlignedBufferChar and AlignedBuffer types into Alignment.h.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@99733 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2b419862
    • haraken@chromium.org's avatar
      Remove redundant [CanBeConstructed] IDLs · 53232c76
      haraken@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=71868
      
      Reviewed by Adam Barth.
      
      If a class has [Constructor] or [CustomConstructor],
      then [CanBeConstructed] is not necessary.
      This patch just removes [CanBeConstructed] from all the classes
      that already have [Constructor] or [CustomConstructor].
      
      No tests. No change in behavior.
      
      * bindings/scripts/CodeGeneratorV8.pm: Corrected typo. This correction is required for this patch.
      * bindings/scripts/test/V8/V8TestObj.cpp: Updated a run-bindings-tests result.
      (WebCore::ConfigureV8TestObjTemplate):
      * css/WebKitCSSMatrix.idl:
      * dom/BeforeLoadEvent.idl:
      * dom/CustomEvent.idl:
      * dom/ErrorEvent.idl:
      * dom/Event.idl:
      * dom/HashChangeEvent.idl:
      * dom/MessageChannel.idl:
      * dom/MessageEvent.idl:
      * dom/OverflowEvent.idl:
      * dom/PageTransitionEvent.idl:
      * dom/PopStateEvent.idl:
      * dom/ProgressEvent.idl:
      * dom/WebKitAnimationEvent.idl:
      * dom/WebKitMutationObserver.idl:
      * dom/WebKitTransitionEvent.idl:
      * fileapi/FileReader.idl:
      * html/DOMFormData.idl:
      * html/TextTrackCue.idl:
      * html/canvas/ArrayBuffer.idl:
      * html/canvas/DataView.idl:
      * html/canvas/Float32Array.idl:
      * html/canvas/Float64Array.idl:
      * html/canvas/Int16Array.idl:
      * html/canvas/Int32Array.idl:
      * html/canvas/Int8Array.idl:
      * html/canvas/Uint16Array.idl:
      * html/canvas/Uint32Array.idl:
      * html/canvas/Uint8Array.idl:
      * html/track/TrackEvent.idl:
      * mediastream/PeerConnection.idl:
      * page/EventSource.idl:
      * page/WebKitPoint.idl:
      * webaudio/AudioContext.idl:
      * websockets/CloseEvent.idl:
      * websockets/WebSocket.idl:
      * workers/SharedWorker.idl:
      * workers/Worker.idl:
      * xml/XMLHttpRequest.idl:
      * xml/XSLTProcessor.idl:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@99732 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      53232c76
    • commit-queue@webkit.org's avatar
      SVG foreignObject wrong container · f7e06e3d
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=64780
      
      Patch by Ken Buchanan <kenrb@chromium.org> on 2011-11-09
      Reviewed by Simon Fraser.
      
      Source/WebCore:
      
      Resubmitting a patch originally by scottmg@chromium.org.
      In determining where to add to m_positionedObjects during a repaint,
      containingBlock is used, which adds the absolute positioned object to
      the containing foreignObject. But, when the contained object is
      dirtied, container() was used to dirty up the tree, which skipped over
      the foreignObject causing the wrong parent to needsLayout(). This fix
      makes container() and containingBlock() handle svg foreignObject's in
      the same way.
      
      This patch will cause svg/overflow/overflow-on-foreignObject.svg to
      require rebaselined results on qt and gtk ports.
      
      * rendering/RenderObject.cpp:
      (WebCore::RenderObject::container):
      
      LayoutTests:
      
      Added layout test for 64780 fix, rebaselined a test that it broke.
      This will cause gtk and qt ports to also need rebaseline.
      
      * platform/mac/svg/overflow/overflow-on-foreignObject-expected.png: Rebaseline
      * platform/mac/svg/overflow/overflow-on-foreignObject-expected.txt: Rebaseline
      * svg/foreignObject/absolute-position-foreign-object-child-crash.html: Added
      * svg/foreignObject/absolute-position-foreign-object-child-crash-expected.txt: Added
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@99731 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f7e06e3d
    • andreas.kling@nokia.com's avatar
      Shrink StyleSheet on 64-bit. · 8907ad45
      andreas.kling@nokia.com authored
      <http://webkit.org/b/71923>
      
      Reviewed by Darin Adler.
      
      Move m_disabled to the top so it folds into the padding at
      the end of RefCounted on 64-bit, shrinking StyleSheet by 8 bytes.
      
      * css/StyleSheet.cpp:
      (WebCore::StyleSheet::StyleSheet):
      * css/StyleSheet.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@99730 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8907ad45
    • commit-queue@webkit.org's avatar
      Add webkitdirs.pm:getArchitecture implementation for GTK · fc63a3c0
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=71370
      
      Patch by Andy Wingo <wingo@igalia.com> on 2011-11-09
      Reviewed by Xan Lopez.
      
      * Scripts/webkitdirs.pm (determineArchitecture): Add an
      implementation for ports using autotools, so that a vanilla
      `run-javascriptcore-tests --gtk' invocation doesn't pass --32-bit
      to build-jsc on x86-64 machines.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@99729 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fc63a3c0
    • commit-queue@webkit.org's avatar
      [EFL] Remove unnecessary casts when creating the WebCoreSupport objects in ewk_view. · 0bf88e5c
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=71891
      
      Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-11-09
      Reviewed by Antonio Gomes.
      
      This is C++ code, there is no need to cast the new objects to their
      parents when creating them.
      
      * ewk/ewk_view.cpp:
      (_ewk_view_priv_new):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@99728 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0bf88e5c
    • philn@webkit.org's avatar
      Unreviewed, attempt to fix GTK 32-bits Release build after r99691. · 16c59835
      philn@webkit.org authored
      * Source/autotools/symbols.filter: Add the missing symbol for resetInternalsObject.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@99727 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      16c59835
    • commit-queue@webkit.org's avatar
      Adding missing implementation of WebMediaStreamDescriptor::label(). · 8f3bc761
      commit-queue@webkit.org authored
      [Chromium] Missing WebMediaStreamDescriptor::label() implementation
      https://bugs.webkit.org/show_bug.cgi?id=71657
      
      Patch by Henrik Grunell <grunell@chromium.org> on 2011-11-09
      Reviewed by Adam Barth.
      
      * src/WebMediaStreamDescriptor.cpp:
      (WebKit::WebMediaStreamDescriptor::label):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@99726 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8f3bc761
    • kenneth@webkit.org's avatar
      [WebKit2] Prepare viewport meta handling for desktop usage · b2850f55
      kenneth@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=71907
      
      Reviewed by Simon Hausmann.
      
      This is only used by Qt so far. Now we don't always layout pages
      without the viewport meta tag, using 980 as the layout width, but
      instead we use that value (it is a setting) as a minimum value, or
      else we use the viewport width.
      
      * UIProcess/API/qt/qtouchwebview.cpp:
      (QTouchWebViewPrivate::updateViewportSize):
      (QTouchWebViewPrivate::updateViewportConstraints):
      * WebProcess/WebCoreSupport/WebChromeClient.cpp:
      (WebKit::WebChromeClient::dispatchViewportPropertiesDidChange):
      * WebProcess/WebPage/WebPage.cpp:
      (WebKit::WebPage::setViewportSize):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@99725 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b2850f55
    • pfeldman@chromium.org's avatar
      2011-11-09 Pavel Feldman <pfeldman@google.com> · b29685e5
      pfeldman@chromium.org authored
              Not reviewed: make new inspector test pass on Qt.
      
              * http/tests/inspector-enabled/injected-script-discard.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@99724 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b29685e5
    • commit-queue@webkit.org's avatar
      Esperanto-translation · e764d476
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=69760
      
      Unreviewed.
      Patch by Kristjan SCHMIDT <kristjan.schmidt@googlemail.com>
      
      Patch by Philippe Normand <pnormand@igalia.com> on 2011-11-09
      
      * eo.po: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@99723 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e764d476
    • andreas.kling@nokia.com's avatar
      StyleSheet: Devirtualize styleSheetChanged(). · 11b6acb2
      andreas.kling@nokia.com authored
      <http://webkit.org/b/71913>
      
      Reviewed by Antti Koivisto.
      
      Since this mechanism is only used by CSSStyleSheet, move it there.
      Out-of-lined StyleSheet::setDisabled() so we can do a type check
      before invoking it from there.
      
      * css/CSSStyleSheet.h:
      * css/StyleSheet.cpp:
      (WebCore::StyleSheet::setDisabled):
      * css/StyleSheet.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@99722 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      11b6acb2
    • kbalazs@webkit.org's avatar
      [Qt] Unreviewed gardening. · 1ab5650e
      kbalazs@webkit.org authored
      Add platform results for Qt5.
      
      * platform/qt-5.0/svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size-expected.txt: Added.
      * platform/qt-5.0/svg/as-image/animated-svg-as-image-same-image.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@99721 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1ab5650e
    • hausmann@webkit.org's avatar
      Unreviewed, rolling out r99707. · 4fa1bc04
      hausmann@webkit.org authored
      http://trac.webkit.org/changeset/99707
      
      Re-enable until we can disable it together with tests in one
      shot.
      
      * qmake/mkspecs/features/features.prf:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@99720 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4fa1bc04
    • vestbo@webkit.org's avatar
      [Qt] Disable use of QtUiTools if the library/module is not found · 1ee1d505
      vestbo@webkit.org authored
      We rely on the lookup order of prf files to inject our own uitools.prf
      that will verify that QtUiTools is in fact present before allowing the
      CONFIG += uitools to have any effect.
      
      Reviewed by Simon Hausmann.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@99719 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1ee1d505
    • hausmann@webkit.org's avatar
      [Qt] Unreviewed, adding missing files to the build. · faf9a6f2
      hausmann@webkit.org authored
      * Target.pri: Add ContentTypeParser.cpp/h
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@99718 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      faf9a6f2
    • caseq@chromium.org's avatar
      Web Inspector: [refactoring] remove a bunch of methods from JavaScriptSourceFrameDelegate · cb8baa80
      caseq@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=71826
      
      Reviewed by Pavel Feldman.
      
      Source/WebCore:
      
      * inspector/front-end/JavaScriptSourceFrame.js:
      (WebInspector.JavaScriptSourceFrame):
      (WebInspector.JavaScriptSourceFrame.prototype.requestContent):
      (WebInspector.JavaScriptSourceFrame.prototype.canEditSource):
      (WebInspector.JavaScriptSourceFrame.prototype.editContent):
      (WebInspector.JavaScriptSourceFrame.prototype.populateLineGutterContextMenu.else.editBreakpointCondition.didEditBreakpointCondition):
      (WebInspector.JavaScriptSourceFrame.prototype.populateLineGutterContextMenu.else):
      (WebInspector.JavaScriptSourceFrame.prototype.populateLineGutterContextMenu):
      (WebInspector.JavaScriptSourceFrame.prototype.didEditContent):
      (WebInspector.JavaScriptSourceFrame.prototype._onMouseDown):
      * inspector/front-end/ScriptsPanel.js:
      
      LayoutTests:
      
      * http/tests/inspector/debugger-test.js:
      (initialize_DebuggerTest):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@99717 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cb8baa80
    • pfeldman@chromium.org's avatar
      2011-11-09 Pavel Feldman <pfeldman@google.com> · 81b1bc50
      pfeldman@chromium.org authored
              Not reviewed: annotate inspector front-end javascript so that it compiled again.
      
              * inspector/front-end/ShortcutsScreen.js:
              * inspector/front-end/WorkerManager.js:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@99716 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      81b1bc50
    • andreas.kling@nokia.com's avatar
      Unreviewed build fix after r99711. (Signed/unsigned compare.) · c6fbe3ff
      andreas.kling@nokia.com authored
      * css/CSSPrimitiveValue.cpp:
      (WebCore::CSSPrimitiveValue::getDoubleValueInternal):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@99715 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c6fbe3ff
    • pfeldman@chromium.org's avatar
      Chromium: Add plumbing to enable dragging dev tools via the empty space on the toolbar. · 10faea9b
      pfeldman@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=71842
      
      These are the only WebKit-side changes needed. The rest will be done on the Chromium side.
      
      Chromium bug: http://crbug.com/44350
      
      Patch by Alexei Svitkine <asvitkine@chromium.org> on 2011-11-09
      Reviewed by Pavel Feldman.
      
      * public/WebDevToolsFrontendClient.h:
      (WebKit::WebDevToolsFrontendClient::moveWindowBy):
      * src/InspectorFrontendClientImpl.cpp:
      (WebKit::InspectorFrontendClientImpl::moveWindowBy):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@99714 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      10faea9b