1. 05 Jan, 2006 3 commits
    • ggaren's avatar
      LayoutTests: · 7dd73f87
      ggaren authored
              Layout test for http://bugzilla.opendarwin.org/show_bug.cgi?id=6318
              REGRESSION: Repro crash in JS called from Flash on bdash.net.nz
      
              * fast/plugins/netscape-back-forward-expected.txt: Added.
              * fast/plugins/netscape-back-forward.html: Added.
              * fast/plugins/resources/go-back.html: Added.
      
      WebKit:
      
              Reviewed by Darin.
      
              - Fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=6361
              Add plugin support to DumpRenderTree
      
              * WebKit.exp: export WebPluginDatabase class, which DumpRenderTree
              needs to add plugins to the runtime.
      
      WebKitTools:
      
              Reviewed by darin.
      
              - Fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=6361
              Add plugin support to DumpRenderTree
      
              Also wrote first test plugin.
      
              * DumpRenderTree/DumpRenderTree.m:
              (main):
              (1) Put the WebView in an invisible window, because PlugIns are
              optimized not to load if there's no parent window.
              (2) Tell WebKit to load any PlugIns in the directory from which we
              loaded. This means we can build nasty PlugIns alongside DumpRenderTree
              and they'll load automagically during layout testing, but they won't be
              added to the user's system, hosing apps like Safari.
      
              * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added new
              test PlugIn to project.
      
              PlugIn added to project:
      
              * DumpRenderTree/TestNetscapePlugIn.subproj/Info.plist: Added.
              * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c: Added.
              (getPluginClass):
              (initializeIdentifiers):
              (pluginHasProperty):
              (pluginHasMethod):
              (pluginGetProperty):
              (pluginSetProperty):
              (pluginInvoke):
              (pluginInvokeDefault):
              (pluginInvalidate):
              (pluginAllocate):
              (pluginDeallocate):
              * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h: Added.
              * DumpRenderTree/TestNetscapePlugIn.subproj/main.c: Added.
              (NP_Initialize):
              (NP_GetEntryPoints):
              (NP_Shutdown):
              (NPP_New):
              (NPP_Destroy):
              (NPP_SetWindow):
              (NPP_NewStream):
              (NPP_DestroyStream):
              (NPP_WriteReady):
              (NPP_Write):
              (NPP_StreamAsFile):
              (NPP_Print):
              (NPP_HandleEvent):
              (NPP_URLNotify):
              (NPP_GetValue):
              (NPP_SetValue):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11885 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7dd73f87
    • ap's avatar
      Reviewed by Darin. · 9cd074c5
      ap authored
              Added UTF-8 BOMs to css2.1 tests.
              http://bugzilla.opendarwin.org/show_bug.cgi?id=6312
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11884 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9cd074c5
    • darin's avatar
      Move log message to top of file where it belongs. · c0859509
      darin authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11883 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c0859509
  2. 04 Jan, 2006 11 commits
    • mjs's avatar
      WebCore: · 22c193be
      mjs authored
              Reviewed by Eric.
      
              Based on a patch by Eric.
      
              - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6180
              "text" output in fragment produced by XSLTProccessor is wrong (has xhtml garbage)
      
              * khtml/xsl/xslt_processorimpl.cpp:
              (DOM::xsltParamArrayFromParameterMap):
              (DOM::freeXsltParamArray):
              Use fastMalloc/fastFree.
      
              (DOM::createFragmentFromSource):
              If the output is "text", just create a text node and add
              it to the fragment.
      
      WebKit:
      
              Reviewed by Darin.
      
      	- move frame management and finding code from WebKit to WebCore
      	http://bugzilla.opendarwin.org/show_bug.cgi?id=6368
      
              * Plugins.subproj/WebBaseNetscapePluginView.m:
              (-[WebBaseNetscapePluginView loadPluginRequest:]): Set frame name straight on the bridge,
      	instead of having it bubble through the view and frame.
              * WebCoreSupport.subproj/WebBridge.m:
              (-[WebBridge initWithFrameName:view:]): don't pass name to frame, we own it now; set it
      	on ourselves directly
      	(-[WebBridge findFrameNamed:]): removed
              (-[WebBridge createWindowWithURL:frameName:]): set name on bridge, not webview
              (-[WebBridge createChildFrameNamed:withURL:referrer:renderPart:allowsScrolling:marginWidth:marginHeight:]):
              (-[WebBridge runModal]): remove excess braces
              * WebKit.xcodeproj/project.pbxproj:
              * WebView.subproj/WebControllerSets.h: Removed.
              * WebView.subproj/WebControllerSets.m: Removed.
              * WebView.subproj/WebFrame.m:
              (-[WebFramePrivate name]): removed
              (-[WebFramePrivate setName:]): removed
              (-[WebFramePrivate dealloc]): don't release name, we no longer have one
              (-[WebFrame _appendChild:]): removed
              (-[WebFrame _removeChild:]): removed
              (-[WebFrame _createItem:]): removed stray space
              (-[WebFrame _immediateChildFrameNamed:]): Just call the bridge
              (-[WebFrame _setName:]): removed
              (-[WebFrame _detachFromParent]): remove bridge from parent note self
              (-[WebFrame _continueLoadRequestAfterNewWindowPolicy:frameName:formState:]):
              (-[WebFrame _addChild:]): Call appendChild: on bridge, not self
              (-[WebFrame _nextFrameWithWrap:]): just call bridge (and moved helpers there)
              (-[WebFrame _previousFrameWithWrap:]): just call bridge (and moved helpers there)
              (-[WebFrame _initWithWebFrameView:webView:bridge:]): don't take a name any more
              (-[WebFrame _setFrameNamespace:]): just call bridge
              (-[WebFrame _frameNamespace]): just call bridge
              (-[WebFrame _hasSelection]): remove excess braces
              (-[WebFrame _clearSelection]): ditto
              (-[WebFrame initWithName:webFrameView:webView:]): no more name
              (-[WebFrame name]): just call bridge
              (-[WebFrame findFrameNamed:]): just call bridge (and moved helpers there)
              (-[WebFrame parentFrame]): fixed for new style
              * WebView.subproj/WebFrameInternal.h:
              * WebView.subproj/WebFramePrivate.h:
              * WebView.subproj/WebView.m:
              * WebView.subproj/WebViewPrivate.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11882 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      22c193be
    • ggaren's avatar
      Patch by kimmo.t.kinnunen@nokia.com, reviewed by darin, tweaked by me. · a5089b89
      ggaren authored
              - Fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=4921
              \u escape sequences in JavaScript identifiers
      
              * kjs/function_object.cpp:
              (FunctionObjectImp::construct):
              * kjs/lexer.cpp:
              (Lexer::shift):
              (Lexer::lex):
              (Lexer::isWhiteSpace):
              (Lexer::isLineTerminator):
              (Lexer::isIdentStart):
              (Lexer::isIdentPart):
              (isDecimalDigit):
              (Lexer::scanRegExp):
              * kjs/lexer.h:
              (KJS::Lexer::):
      
              * tests/mozilla/expected.html: Updated test results.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11879 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a5089b89
    • darin's avatar
      - added a missing test result · f74bd050
      darin authored
              * svg/custom/fractional-rects-expected.png: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11878 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f74bd050
    • andersca's avatar
      2006-01-04 Anders Carlsson <andersca@mac.com> · d3dc2cbe
      andersca authored
              Reviewed by Eric.
      
              - update tests for http://bugzilla.opendarwin.org/show_bug.cgi?id=6180
              "text" output in fragment produced by XSLTProccessor is wrong (has xhtml garbage)
      
              * fast/xsl/xslt-processer-expected.txt:
              Update.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11877 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d3dc2cbe
    • andersca's avatar
      2006-01-04 Anders Carlsson <andersca@mac.com> · 67b87d0b
      andersca authored
              Reviewed by Eric.
      
              Based on a patch by Eric.
      
              - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6180
              "text" output in fragment produced by XSLTProccessor is wrong (has xhtml garbage)
      
              * khtml/xsl/xslt_processorimpl.cpp:
              (DOM::xsltParamArrayFromParameterMap):
              (DOM::freeXsltParamArray):
              Use fastMalloc/fastFree.
      
              (DOM::createFragmentFromSource):
              If the output is "text", just create a text node and add
              it to the fragment.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11876 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      67b87d0b
    • thatcher's avatar
      Reviewed by Darin. · 021e4c94
      thatcher authored
              Created by Eric.
              Tweaked and tested by me.
      
              New scripts to work with Subversion when the switch happens.
              These will replace cvs-apply, cvs-unapply, and cvs-create-patch.
      
              * Scripts/svn-apply: Added.
              * Scripts/svn-create-patch: Added.
              * Scripts/svn-unapply: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11875 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      021e4c94
    • ggaren's avatar
      LayoutTests: · 3685676f
      ggaren authored
              Layout test for http://bugzilla.opendarwin.org/show_bug.cgi?id=6311
              document.plugins doesn't exist
      
              * fast/dom/HTMLDocument/document-plugins-expected.txt: Added.
              * fast/dom/HTMLDocument/document-plugins.html: Added.
      
      WebCore:
      
              Reviewed by darin.
      
              - Fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=6311
              document.plugins doesn't exist
      
              * khtml/ecma/kjs_html.cpp: Added 'plugins' as synonym for 'embeds'
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11874 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3685676f
    • ggaren's avatar
      LayoutTests: · 8cc96fbd
      ggaren authored
               Layout test for <rdar://problem/4214080> document.embeds:
               embeds[0].Play() undefined at languageguide.org prevents audio playing
               on mouseover
      
               * fast/dom/object-embed-plugin-scripting-expected.txt: Added.
               * fast/dom/object-embed-plugin-scripting.html: Added.
               * fast/dom/resources/articles.m4a: Added.
      
      WebCore:
      
               Reviewed by darin.
      
               - Fixed <rdar://problem/4214080> document.embeds: embeds[0].Play()
               undefined at languageguide.org prevents audio playing on mouseover
      
               - Layout test: fast/dom/object-embed-plugin-scripting.html
      
               A common idiom the kids like to use these days for plugins is to nest
               an <embed> inside an <object>, and assume that IE will honor the first,
               Mozilla the second. We happen to honor both, but the rules dictate that
               only the outer <object> gets a plugin/renderer. (A plugin is a
              renderer.) This is a problem because sites ID us as Mozilla and
              therefore attempt to script their plugins through the <embed>, which
              has no plugin/renderer. The fix here is to have an <embed> return its
              parent node's plugin/renderer when queried, if and only if it has no
              renderer of its own and its parent node is an <object>. We may decide
              to restrict this further in the future.
      
              One happy consequence of this patch is that all the apple.com Quicktime
              websites we had previously broken with TOT are now fixed.
      
              * khtml/html/html_objectimpl.cpp:
              (DOM::HTMLEmbedElementImpl::getEmbedInstance): The "if (!r)" clause
              implements the logic I just described. The code below it I changed
              just for style, to match the style in getObjectInstance().
      
              (DOM::HTMLEmbedElementImpl::rendererIsNeeded): Assert that an <object>
              parent has a renderer because we're going to use it later.
      
              (DOM::HTMLObjectElementImpl::rendererIsNeeded): Changed to match style
              of HTMLEmbedElementImpl counterpart.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11873 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8cc96fbd
    • ap's avatar
      Reviewed by Darin, landed by ap. · 1c7fa276
      ap authored
              - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6301
                REGRESSION: Border repaint glitch
      
              * khtml/rendering/render_object.cpp:
              (RenderObject::repaintAfterLayoutIfNeeded): Repaint parts of the
              border that moved.
              * manual-tests/border-repaint-glitch.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11872 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1c7fa276
    • eseidel's avatar
      Bug #: 4462 · 3c9880fc
      eseidel authored
      Submitted by: kimmo
      Reviewed by: eseidel
              Updated layout tests after QRect (size & point) to Q*F change
              http://bugzilla.opendarwin.org/show_bug.cgi?id=4462
      
              * svg/W3C-SVG-1.1/animate-elem-02-t-expected.txt:
              * svg/W3C-SVG-1.1/animate-elem-03-t-expected.txt:
              * svg/W3C-SVG-1.1/animate-elem-04-t-expected.txt:
              * svg/W3C-SVG-1.1/animate-elem-05-t-expected.txt:
              * svg/W3C-SVG-1.1/animate-elem-06-t-expected.txt:
              * svg/W3C-SVG-1.1/animate-elem-07-t-expected.txt:
              * svg/W3C-SVG-1.1/animate-elem-08-t-expected.txt:
              * svg/W3C-SVG-1.1/animate-elem-09-t-expected.txt:
              * svg/W3C-SVG-1.1/animate-elem-10-t-expected.txt:
              * svg/W3C-SVG-1.1/animate-elem-11-t-expected.txt:
              * svg/W3C-SVG-1.1/animate-elem-12-t-expected.txt:
              * svg/W3C-SVG-1.1/animate-elem-13-t-expected.txt:
              * svg/W3C-SVG-1.1/animate-elem-14-t-expected.txt:
              * svg/W3C-SVG-1.1/animate-elem-15-t-expected.txt:
              * svg/W3C-SVG-1.1/animate-elem-16-t-expected.txt:
              * svg/W3C-SVG-1.1/animate-elem-17-t-expected.txt:
              * svg/W3C-SVG-1.1/animate-elem-18-t-expected.txt:
              * svg/W3C-SVG-1.1/animate-elem-19-t-expected.txt:
              * svg/W3C-SVG-1.1/animate-elem-20-t-expected.txt:
              * svg/W3C-SVG-1.1/animate-elem-21-t-expected.txt:
              * svg/W3C-SVG-1.1/animate-elem-22-b-expected.txt:
              * svg/W3C-SVG-1.1/animate-elem-23-t-expected.txt:
              * svg/W3C-SVG-1.1/animate-elem-24-t-expected.txt:
              * svg/W3C-SVG-1.1/animate-elem-25-t-expected.txt:
              * svg/W3C-SVG-1.1/animate-elem-26-t-expected.txt:
              * svg/W3C-SVG-1.1/animate-elem-27-t-expected.txt:
              * svg/W3C-SVG-1.1/animate-elem-28-t-expected.txt:
              * svg/W3C-SVG-1.1/animate-elem-29-b-expected.txt:
              * svg/W3C-SVG-1.1/color-prof-01-f-expected.txt:
              * svg/W3C-SVG-1.1/color-prop-01-b-expected.txt:
              * svg/W3C-SVG-1.1/color-prop-02-f-expected.txt:
              * svg/W3C-SVG-1.1/color-prop-03-t-expected.txt:
              * svg/W3C-SVG-1.1/coords-trans-01-b-expected.txt:
              * svg/W3C-SVG-1.1/coords-trans-02-t-expected.txt:
              * svg/W3C-SVG-1.1/coords-trans-03-t-expected.txt:
              * svg/W3C-SVG-1.1/coords-trans-04-t-expected.txt:
              * svg/W3C-SVG-1.1/coords-trans-05-t-expected.txt:
              * svg/W3C-SVG-1.1/coords-trans-06-t-expected.txt:
              * svg/W3C-SVG-1.1/coords-units-01-b-expected.txt:
              * svg/W3C-SVG-1.1/coords-units-02-b-expected.txt:
              * svg/W3C-SVG-1.1/coords-units-03-b-expected.txt:
              * svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.checksum:
              * svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.txt:
              * svg/W3C-SVG-1.1/extend-namespace-01-f-expected.txt:
              * svg/W3C-SVG-1.1/filters-blend-01-b-expected.txt:
              * svg/W3C-SVG-1.1/filters-color-01-b-expected.txt:
              * svg/W3C-SVG-1.1/filters-composite-02-b-expected.txt:
              * svg/W3C-SVG-1.1/filters-comptran-01-b-expected.txt:
              * svg/W3C-SVG-1.1/filters-conv-01-f-expected.txt:
              * svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.txt:
              * svg/W3C-SVG-1.1/filters-displace-01-f-expected.txt:
              * svg/W3C-SVG-1.1/filters-example-01-b-expected.checksum:
              * svg/W3C-SVG-1.1/filters-example-01-b-expected.png:
              * svg/W3C-SVG-1.1/filters-example-01-b-expected.txt:
              * svg/W3C-SVG-1.1/filters-gauss-01-b-expected.txt:
              * svg/W3C-SVG-1.1/filters-image-01-b-expected.checksum:
              * svg/W3C-SVG-1.1/filters-image-01-b-expected.txt:
              * svg/W3C-SVG-1.1/filters-light-01-f-expected.checksum:
              * svg/W3C-SVG-1.1/filters-light-01-f-expected.txt:
              * svg/W3C-SVG-1.1/filters-morph-01-f-expected.txt:
              * svg/W3C-SVG-1.1/filters-offset-01-b-expected.txt:
              * svg/W3C-SVG-1.1/filters-specular-01-f-expected.checksum:
              * svg/W3C-SVG-1.1/filters-specular-01-f-expected.txt:
              * svg/W3C-SVG-1.1/filters-tile-01-b-expected.txt:
              * svg/W3C-SVG-1.1/filters-turb-01-f-expected.txt:
              * svg/W3C-SVG-1.1/fonts-elem-01-t-expected.txt:
              * svg/W3C-SVG-1.1/fonts-elem-02-t-expected.txt:
              * svg/W3C-SVG-1.1/fonts-elem-03-b-expected.txt:
              * svg/W3C-SVG-1.1/fonts-elem-04-b-expected.txt:
              * svg/W3C-SVG-1.1/interact-cursor-01-f-expected.txt:
              * svg/W3C-SVG-1.1/interact-dom-01-b-expected.txt:
              * svg/W3C-SVG-1.1/interact-events-01-b-expected.txt:
              * svg/W3C-SVG-1.1/interact-order-01-b-expected.txt:
              * svg/W3C-SVG-1.1/interact-order-02-b-expected.txt:
              * svg/W3C-SVG-1.1/interact-order-03-b-expected.txt:
              * svg/W3C-SVG-1.1/interact-zoom-01-t-expected.txt:
              * svg/W3C-SVG-1.1/linking-a-01-b-expected.txt:
              * svg/W3C-SVG-1.1/linking-a-02-b-expected.txt:
              * svg/W3C-SVG-1.1/linking-a-03-b-expected.txt:
              * svg/W3C-SVG-1.1/linking-a-04-t-expected.txt:
              * svg/W3C-SVG-1.1/linking-uri-01-b-expected.txt:
              * svg/W3C-SVG-1.1/linking-uri-02-b-expected.txt:
              * svg/W3C-SVG-1.1/linking-uri-03-t-expected.txt:
              * svg/W3C-SVG-1.1/masking-mask-01-b-expected.txt:
              * svg/W3C-SVG-1.1/masking-opacity-01-b-expected.txt:
              * svg/W3C-SVG-1.1/masking-path-01-b-expected.txt:
              * svg/W3C-SVG-1.1/masking-path-02-b-expected.txt:
              * svg/W3C-SVG-1.1/masking-path-03-b-expected.txt:
              * svg/W3C-SVG-1.1/masking-path-04-b-expected.txt:
              * svg/W3C-SVG-1.1/masking-path-05-f-expected.txt:
              * svg/W3C-SVG-1.1/metadata-example-01-b-expected.txt:
              * svg/W3C-SVG-1.1/painting-fill-01-t-expected.txt:
              * svg/W3C-SVG-1.1/painting-fill-02-t-expected.txt:
              * svg/W3C-SVG-1.1/painting-fill-03-t-expected.txt:
              * svg/W3C-SVG-1.1/painting-fill-04-t-expected.txt:
              * svg/W3C-SVG-1.1/painting-marker-01-f-expected.txt:
              * svg/W3C-SVG-1.1/painting-marker-02-f-expected.txt:
              * svg/W3C-SVG-1.1/painting-render-01-b-expected.txt:
              * svg/W3C-SVG-1.1/painting-stroke-01-t-expected.txt:
              * svg/W3C-SVG-1.1/painting-stroke-02-t-expected.txt:
              * svg/W3C-SVG-1.1/painting-stroke-03-t-expected.txt:
              * svg/W3C-SVG-1.1/painting-stroke-04-t-expected.txt:
              * svg/W3C-SVG-1.1/paths-data-01-t-expected.txt:
              * svg/W3C-SVG-1.1/paths-data-02-t-expected.txt:
              * svg/W3C-SVG-1.1/paths-data-03-f-expected.txt:
              * svg/W3C-SVG-1.1/paths-data-04-t-expected.txt:
              * svg/W3C-SVG-1.1/paths-data-05-t-expected.txt:
              * svg/W3C-SVG-1.1/paths-data-06-t-expected.txt:
              * svg/W3C-SVG-1.1/paths-data-07-t-expected.txt:
              * svg/W3C-SVG-1.1/pservers-grad-01-b-expected.txt:
              * svg/W3C-SVG-1.1/pservers-grad-02-b-expected.txt:
              * svg/W3C-SVG-1.1/pservers-grad-03-b-expected.txt:
              * svg/W3C-SVG-1.1/pservers-grad-04-b-expected.txt:
              * svg/W3C-SVG-1.1/pservers-grad-05-b-expected.txt:
              * svg/W3C-SVG-1.1/pservers-grad-06-b-expected.txt:
              * svg/W3C-SVG-1.1/pservers-grad-07-b-expected.txt:
              * svg/W3C-SVG-1.1/pservers-grad-08-b-expected.txt:
              * svg/W3C-SVG-1.1/pservers-grad-09-b-expected.txt:
              * svg/W3C-SVG-1.1/pservers-grad-10-b-expected.txt:
              * svg/W3C-SVG-1.1/pservers-grad-11-b-expected.txt:
              * svg/W3C-SVG-1.1/pservers-grad-12-b-expected.txt:
              * svg/W3C-SVG-1.1/pservers-pattern-01-b-expected.txt:
              * svg/W3C-SVG-1.1/render-elems-01-t-expected.txt:
              * svg/W3C-SVG-1.1/render-elems-02-t-expected.txt:
              * svg/W3C-SVG-1.1/render-elems-06-t-expected.txt:
              * svg/W3C-SVG-1.1/render-elems-07-t-expected.txt:
              * svg/W3C-SVG-1.1/render-elems-08-t-expected.txt:
              * svg/W3C-SVG-1.1/render-groups-01-b-expected.txt:
              * svg/W3C-SVG-1.1/render-groups-03-t-expected.txt:
              * svg/W3C-SVG-1.1/script-handle-01-b-expected.txt:
              * svg/W3C-SVG-1.1/script-handle-02-b-expected.txt:
              * svg/W3C-SVG-1.1/script-handle-03-b-expected.txt:
              * svg/W3C-SVG-1.1/script-handle-04-b-expected.txt:
              * svg/W3C-SVG-1.1/shapes-circle-01-t-expected.txt:
              * svg/W3C-SVG-1.1/shapes-ellipse-01-t-expected.txt:
              * svg/W3C-SVG-1.1/shapes-line-01-t-expected.txt:
              * svg/W3C-SVG-1.1/shapes-polygon-01-t-expected.txt:
              * svg/W3C-SVG-1.1/shapes-polyline-01-t-expected.txt:
              * svg/W3C-SVG-1.1/shapes-rect-01-t-expected.txt:
              * svg/W3C-SVG-1.1/struct-cond-01-t-expected.txt:
              * svg/W3C-SVG-1.1/struct-cond-02-t-expected.txt:
              * svg/W3C-SVG-1.1/struct-defs-01-t-expected.txt:
              * svg/W3C-SVG-1.1/struct-dom-01-b-expected.txt:
              * svg/W3C-SVG-1.1/struct-dom-02-b-expected.txt:
              * svg/W3C-SVG-1.1/struct-dom-03-b-expected.txt:
              * svg/W3C-SVG-1.1/struct-dom-04-b-expected.txt:
              * svg/W3C-SVG-1.1/struct-dom-05-b-expected.txt:
              * svg/W3C-SVG-1.1/struct-dom-06-b-expected.txt:
              * svg/W3C-SVG-1.1/struct-group-01-t-expected.txt:
              * svg/W3C-SVG-1.1/struct-group-02-b-expected.txt:
              * svg/W3C-SVG-1.1/struct-image-01-t-expected.txt:
              * svg/W3C-SVG-1.1/struct-image-02-b-expected.checksum:
              * svg/W3C-SVG-1.1/struct-image-02-b-expected.txt:
              * svg/W3C-SVG-1.1/struct-image-03-t-expected.txt:
              * svg/W3C-SVG-1.1/struct-image-04-t-expected.txt:
              * svg/W3C-SVG-1.1/struct-image-05-b-expected.txt:
              * svg/W3C-SVG-1.1/struct-symbol-01-b-expected.txt:
              * svg/W3C-SVG-1.1/styling-css-01-b-expected.txt:
              * svg/W3C-SVG-1.1/styling-css-02-b-expected.txt:
              * svg/W3C-SVG-1.1/styling-css-03-b-expected.txt:
              * svg/W3C-SVG-1.1/styling-inherit-01-b-expected.txt:
              * svg/W3C-SVG-1.1/styling-pres-01-t-expected.txt:
              * svg/W3C-SVG-1.1/text-align-01-b-expected.txt:
              * svg/W3C-SVG-1.1/text-align-02-b-expected.txt:
              * svg/W3C-SVG-1.1/text-align-03-b-expected.txt:
              * svg/W3C-SVG-1.1/text-align-04-b-expected.txt:
              * svg/W3C-SVG-1.1/text-align-05-b-expected.txt:
              * svg/W3C-SVG-1.1/text-align-06-b-expected.txt:
              * svg/W3C-SVG-1.1/text-altglyph-01-b-expected.txt:
              * svg/W3C-SVG-1.1/text-deco-01-b-expected.txt:
              * svg/W3C-SVG-1.1/text-fonts-01-t-expected.txt:
              * svg/W3C-SVG-1.1/text-fonts-02-t-expected.txt:
              * svg/W3C-SVG-1.1/text-intro-01-t-expected.txt:
              * svg/W3C-SVG-1.1/text-intro-02-b-expected.txt:
              * svg/W3C-SVG-1.1/text-intro-03-b-expected.txt:
              * svg/W3C-SVG-1.1/text-intro-04-t-expected.txt:
              * svg/W3C-SVG-1.1/text-path-01-b-expected.txt:
              * svg/W3C-SVG-1.1/text-spacing-01-b-expected.txt:
              * svg/W3C-SVG-1.1/text-text-01-b-expected.txt:
              * svg/W3C-SVG-1.1/text-text-03-b-expected.txt:
              * svg/W3C-SVG-1.1/text-tref-01-b-expected.txt:
              * svg/W3C-SVG-1.1/text-tselect-01-b-expected.txt:
              * svg/W3C-SVG-1.1/text-tspan-01-b-expected.txt:
              * svg/W3C-SVG-1.1/text-ws-01-t-expected.txt:
              * svg/W3C-SVG-1.1/text-ws-02-t-expected.txt:
              * svg/custom/control-points-for-S-and-T-expected.txt:
              * svg/custom/fractional-rects-expected.checksum: Added.
              * svg/custom/fractional-rects-expected.txt: Added.
              * svg/custom/fractional-rects.svg: Added.
              * svg/custom/path-bad-data-expected.txt:
              * svg/custom/path-update-expected.txt:
              * svg/custom/use-forward-refs-expected.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11871 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3c9880fc
    • eseidel's avatar
      Bug #: 4462 · e4b1e1c5
      eseidel authored
      Submitted by: kimmo
      Reviewed by: eseidel
      	Changed use of QRect to QRectF in the points where SVG can have
      	fractional numbers
              http://bugzilla.opendarwin.org/show_bug.cgi?id=4462
      
              Added test cases:
      	* svg/custom/fractional-rects.svg: copy of rounded-rects.svg with
      	fractional coordinates.
      
              * WebCore.xcodeproj/project.pbxproj:
              * kwq/KWQWMatrix.h:
              * kwq/KWQWMatrix.mm:
              (QWMatrix::mapRect): mapRect for QRectF
              * kwq/KWQRectF.h:
              * kwq/KWQRectF.mm:  Added. QRectF impl
              * kwq/KWQSizeF.h:
              * kwq/KWQSizeF.mm:  Added.QSizeF impl
              * kwq/KWQPointF.h:
              * kwq/KWQPointF.mm: Added. QPointF impl
              * kcanvas/KCanvasContainer.cpp:
              (KCanvasContainer::fillContains):
              (KCanvasContainer::strokeContains):
              (KCanvasContainer::relativeBBox):
              (KCanvasContainer::getAspectRatio): QRect -> QRectF
              * kcanvas/KCanvasContainer.h:
              * kcanvas/KCanvasFilters.cpp:
              (KCanvasFilterEffect::subRegion):
              (KCanvasFilterEffect::setSubRegion): QRect -> QRectF
              * kcanvas/KCanvasFilters.h:
              (KCanvasFilter::filterRect):
              (KCanvasFilter::setFilterRect):	QRect -> QRectF
              (KCanvasFEConvolveMatrix::kernelSize):
              (KCanvasFEConvolveMatrix::setKernelSize):
              (KCanvasFEConvolveMatrix::targetOffset):
              (KCanvasFEConvolveMatrix::setTargetOffset): QSize -> QSizeF
              * kcanvas/KCanvasItem.cpp:
              (RenderPath::fillContains):
              (RenderPath::strokeContains):
              (RenderPath::relativeBBox): QRect -> QRectF
              * kcanvas/KCanvasItem.h:
              * kcanvas/KCanvasResources.cpp:
              (KCanvasMarker::draw): QRect -> QRectF
              * kcanvas/KCanvasResources.h:
              * kcanvas/KCanvasTreeDebug.cpp:
              (hasFractions): helper function
              (operator<<): QSizeF operator, QRectF operator
              * kcanvas/KCanvasTreeDebug.h:
              * kcanvas/device/KRenderingPaintServerGradient.cpp:
              (KRenderingPaintServerLinearGradient::gradientStart):
              (KRenderingPaintServerLinearGradient::setGradientStart):
              (KRenderingPaintServerLinearGradient::gradientEnd):
              (KRenderingPaintServerLinearGradient::setGradientEnd):
              (KRenderingPaintServerRadialGradient::gradientCenter):
              (KRenderingPaintServerRadialGradient::setGradientCenter):
              (KRenderingPaintServerRadialGradient::gradientFocal):
              (KRenderingPaintServerRadialGradient::setGradientFocal): QPoint -> QPointF
              * kcanvas/device/KRenderingPaintServerGradient.h:
              * kcanvas/device/KRenderingPaintServerPattern.cpp:
              (KRenderingPaintServerPattern::Private::Private): x, y, width, height -> QRectF
              (KRenderingPaintServerPattern::setBbox): replaced get/set methods
              (KRenderingPaintServerPattern::bbox): replaced get/set methods
              (KRenderingPaintServerPattern::externalRepresentation):
              * kcanvas/device/KRenderingPaintServerPattern.h:
              * kcanvas/device/quartz/KCanvasFilterQuartz.h:
              * kcanvas/device/quartz/KCanvasFilterQuartz.mm:
              (KCanvasFilterQuartz::prepareFilter):
              (KCanvasFilterQuartz::applyFilter): QRect -> QRectF
              * kcanvas/device/quartz/KCanvasItemQuartz.h:
              (KCanvasItemQuartz::getAbsoluteRepaintRect): QRect -> QRectF
              * kcanvas/device/quartz/KCanvasItemQuartz.mm:
              (drawMarkerWithData):
              (KCanvasItemQuartz::drawMarkersIfNeeded):
              (KCanvasItemQuartz::paint): QRect -> QRectF
              (KCanvasItemQuartz::nodeAtPoint): QPoint -> QPointF
              (KCanvasItemQuartz::bboxForPath) :QRect -> QRectF
              (KCanvasItemQuartz::hitsPath):
              * kcanvas/device/quartz/KCanvasResourcesQuartz.h:
              (KCanvasContainerQuartz::getAbsoluteRepaintRect): QRect -> QRectF
              * kcanvas/device/quartz/KRenderingPaintServerQuartz.mm:
              (KRenderingPaintServerPatternQuartz::draw): QRect -> QRectF
              * khtml/rendering/render_object.h:
              (khtml::RenderObject::relativeBBox):QRect -> QRectF
              * ksvg2/svg/SVGFilterElementImpl.cpp:
              (SVGFilterElementImpl::canvasResource): QRect -> QRectF
              * ksvg2/svg/SVGFilterPrimitiveStandardAttributesImpl.cpp:
              (SVGFilterPrimitiveStandardAttributesImpl::setStandardAttributes):
              * ksvg2/svg/SVGLengthImpl.cpp:
              (SVGLengthImpl::value): QRect -> QRectF
              * ksvg2/svg/SVGLinearGradientElementImpl.cpp:
              (SVGLinearGradientElementImpl::buildGradient): QPoint -> QPointF, removed integer conversions
              * ksvg2/svg/SVGLocatableImpl.cpp:
              (SVGLocatableImpl::getBBox): Rect -> QRectF
              * ksvg2/svg/SVGPatternElementImpl.cpp:
              (SVGPatternElementImpl::drawPatternContentIntoTile): QRect -> QRectF
              * ksvg2/svg/SVGRadialGradientElementImpl.cpp:
              (SVGRadialGradientElementImpl::buildGradient): QPoint -> QPointF, removed integer conversions
              * ksvg2/svg/SVGSVGElementImpl.cpp:
              (SVGSVGElementImpl::checkIntersection): QRect -> QRectF, removed integer conversions
              (SVGSVGElementImpl::checkEnclosure): QRect -> QRectF, removed integer conversions
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11870 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e4b1e1c5
  3. 03 Jan, 2006 18 commits
    • bdakin's avatar
      Bug #: · 1011d862
      bdakin authored
      Submitted by:
      Reviewed by:
      Bug #:
      Submitted by:
      Reviewed by:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11869 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1011d862
    • mjs's avatar
      WebCore: · 4b76feb4
      mjs authored
              Reviewed by Vicki.
      
              - moved frame traversal code across from bridge, also dropped the children
      	array
      
              * kwq/WebCoreBridge.h:
              * kwq/WebCoreBridge.mm:
              (-[WebCoreBridge firstChild]): Moved from WebBridge. Use new _firstChild
      	pointer.
              (-[WebCoreBridge lastChild]): Moved from WebBridge. Use new _lastChild pointer.
              (-[WebCoreBridge childCount]): Moved from WebBridge. Use _childCount variable.
              (-[WebCoreBridge previousSibling]): Moved from WebBridge.
              (-[WebCoreBridge nextSibling]): ditt
              (-[WebCoreBridge isDescendantOfFrame:]): ditto
              (-[WebCoreBridge traverseNextFrameStayWithin:]): ditto
              (-[WebCoreBridge appendChild:]): Moved from WebBridge, maintain count and first/last
      	pointers.
              (-[WebCoreBridge removeChild:]): Moved from WebBridge, maintain count and first/last
      	pointers.
      
      WebKit:
      
              Reviewed by Vicki.
      
              - moved frame traversal code across from bridge, also dropped the children
      	array
      
              * WebCoreSupport.subproj/WebBridge.h:
              * WebCoreSupport.subproj/WebBridge.m:
              (-[WebBridge dealloc]): Don't release children array, that was moved
      	down to WebCore.
              (-[WebBridge saveDocumentState:]):
      	- many methods moved to WebCore.
              * WebView.subproj/WebFrame.m:
              (Frame): New convenience method to get a WebFrame * from a method that
      	returns WebCoreBridge *.
              (-[WebFrame _firstChildFrame]): use Frame()
              (-[WebFrame _lastChildFrame]): ditto
              (-[WebFrame _previousSiblingFrame]): ditto
              (-[WebFrame _nextSiblingFrame]): ditto
              (-[WebFrame _traverseNextFrameStayWithin:]): ditto
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11868 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4b76feb4
    • justing's avatar
      Reviewed by harrison · 89cd84ca
      justing authored
              <http://bugzilla.opendarwin.org/show_bug.cgi?id=4609>
              window.getSelection().toString() is undefined (range object
              returned from window.getSelection() is useless)
      
              toString was defined as a method on the JS Selection object,
              but it didn't return anything.
      
              Added layout test:
              * editing/selection/toString.html
      
              * khtml/ecma/kjs_window.cpp:
              (KJS::SelectionFunc::callAsFunction):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11867 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      89cd84ca
    • justing's avatar
      Reviewed by harrison · 679a34fa
      justing authored
              Layout test for:
              <http://bugzilla.opendarwin.org/show_bug.cgi?id=4609>
              window.getSelection().toString() is undefined (range object
              returned from window.getSelection() is useless)
      
              * editing/selection/toString-expected.txt: Added.
              * editing/selection/toString.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11866 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      679a34fa
    • eseidel's avatar
      Bug #: 6345 · 2d592013
      eseidel authored
      Submitted by: eseidel
      Reviewed by: darin
              REGRESSION: repro crash w/ invalid charset attribute on <script>
              http://bugzilla.opendarwin.org/show_bug.cgi?id=6345
      
              * fast/loader/invalid-charset-on-script-crashes-loader-expected.txt: Added.
              * fast/loader/invalid-charset-on-script-crashes-loader.html: Added.
              * fast/loader/resources/invalid-charset-on-script-crashes-loader.js: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11865 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2d592013
    • ggaren's avatar
      Reviewed by timo. · 99a1718a
      ggaren authored
              - Fixed: http://bugzilla.opendarwin.org/show_bug.cgi?id=6318
              REGRESSION: Repro crash in JS called from Flash on bdash.net.nz
      
              Since we clear all the plugin data structures in setView, we need to
              clear the windowScriptObject as well. I had already done this in my
              previous patch, but I didn't realize there are two windowScriptObjects
              -- one for Netscape PlugIns, and one for WebKit PlugIns.
      
              * kwq/KWQKHTMLPart.mm:
              (KWQKHTMLPart::setView): Clear the Netscape PlugIn windowScriptObject
              as well.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11864 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      99a1718a
    • andersca's avatar
      2006-01-03 Anders Carlsson <andersca@mac.com> · f676d912
      andersca authored
              Reviewed by Eric.
      
              - add tests for http://bugzilla.opendarwin.org/show_bug.cgi?id=6358
              JS objects missing "prototype" properties
      
              * fast/js/test-prototypes-expected.txt: Added.
              * fast/js/test-prototypes.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11863 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f676d912
    • andersca's avatar
      2006-01-03 Anders Carlsson <andersca@mac.com> · 6ab8a185
      andersca authored
              Reviewed by Eric.
      
              - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6358
              JS objects missing "prototype" properties
      
              * khtml/ecma/XSLTProcessor.cpp:
              (KJS::XSLTProcessorConstructorImp::XSLTProcessorConstructorImp):
              * khtml/ecma/XSLTProcessor.h:
              * khtml/ecma/domparser.cpp:
              (KJS::DOMParserConstructorImp::DOMParserConstructorImp):
              * khtml/ecma/xmlhttprequest.cpp:
              (KJS::XMLHttpRequestConstructorImp::XMLHttpRequestConstructorImp):
              * khtml/ecma/xmlserializer.cpp:
              (KJS::XMLSerializerConstructorImp::XMLSerializerConstructorImp):
              Add "prototype" property in constructors.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11862 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6ab8a185
    • eseidel's avatar
      Bug #: 6345 · 75691022
      eseidel authored
      Submitted by: eseidel
      Reviewed by: darin
              REGRESSION: repro crash w/ invalid charset attribute on <script>
              http://bugzilla.opendarwin.org/show_bug.cgi?id=6345
              I also made some small spacing cleanup here.
              I did *not* fix the usage in formData, as the move from KCharSet to
              QTextCodec actually fixed a bug whereby if the first listed charset
              in accept-charsets was invalid, we would assume latin1 instead of
              checking for the next valid one before assuming system encoding.
      
              * khtml/html/html_formimpl.cpp:
              (DOM::HTMLFormElementImpl::formData): cleanup
              * khtml/misc/loader.cpp:
              (CachedCSSStyleSheet::CachedCSSStyleSheet): null check
              (CachedScript::CachedScript): cleanup
              (CachedXSLStyleSheet::CachedXSLStyleSheet): null check
              (CachedXBLDocument::CachedXBLDocument): cleanup
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11861 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      75691022
    • andersca's avatar
      2006-01-03 Anders Carlsson <andersca@mac.com> · 07bc085c
      andersca authored
              Reviewed by Darin.
      
              - Add test for http://bugzilla.opendarwin.org/show_bug.cgi?id=6357
              REGRESSION: iframe and target is broken
      
              * fast/frames/iframe-target-expected.txt: Added.
              * fast/frames/iframe-target.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11860 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      07bc085c
    • andersca's avatar
      2006-01-03 Anders Carlsson <andersca@mac.com> · 64991bef
      andersca authored
              Reviewed by Darin.
      
              - Fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6357
              REGRESSION: iframe and target is broken
      
              * WebView.subproj/WebFrame.m:
              (-[WebFrame _descendantFrameNamed:sourceFrame:]):
              Return the correct frame.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11859 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      64991bef
    • justing's avatar
      New/updated layout tests for: · b267f90b
      justing authored
              <http://bugzilla.opendarwin.org/show_bug.cgi?id=4904>
              Bug with baseOffset and extentOffset in selections (for writely.com)
              <rdar://problem/4259818>
              selection object incorrect after double-clicking a word
      
              * editing/selection/anchor-focus1-expected.txt: Added.
              * editing/selection/anchor-focus1.html: Added.
              * editing/selection/anchor-focus2-expected.txt: Added.
              * editing/selection/anchor-focus2.html: Added.
              * editing/selection/anchor-focus3-expected.txt: Added.
              * editing/selection/anchor-focus3.html: Added.
              * editing/selection/getRangeAt-expected.txt: Added.
              * editing/selection/getRangeAt.html: Added.
              * editing/selection/unrendered-001-expected.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11858 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b267f90b
    • justing's avatar
      <http://bugzilla.opendarwin.org/show_bug.cgi?id=4904> · 02ba5929
      justing authored
              Bug with baseOffset and extentOffset in selections (for writely.com)
              <rdar://problem/4259818>
              selection object incorrect after double-clicking a word
      
              Reviewed by harrison
      
              Changed the Selection object's anchor/focus properties to match
              Mozilla's Selection object API, added getRangeAt and outlined the
              rest of the API.
              Cleaned up the JS Selection object (to do less work in the DOM binding).
              Added an updateLayout call to VisiblePosition::init and removed some
              updateLayout calls from other parts of the editing code.
      
              Added layout tests:
              * editing/selection/getRangeAt.html
              * editing/selection/anchor-focus1.html
              * editing/selection/anchor-focus2.html
              * editing/selection/anchor-focus3.html
              Updated expected results:
              * editing/selection/unrendered-001-expected.txt
      
              * khtml/ecma/kjs_window.cpp:
              (KJS::Selection::getValueProperty):
              (KJS::Selection::toString):
              (KJS::SelectionFunc::callAsFunction):
              * khtml/ecma/kjs_window.h:
              (KJS::Selection::):
              * khtml/editing/SelectionController.cpp:
              (khtml::SelectionController::modify):
              (khtml::SelectionController::type):
              (khtml::SelectionController::toString):
              (khtml::SelectionController::getRangeAt):
              (khtml::SelectionController::setBaseAndExtent):
              (khtml::SelectionController::setPosition):
              (khtml::SelectionController::collapse):
              (khtml::SelectionController::collapseToEnd):
              (khtml::SelectionController::collapseToStart):
              (khtml::SelectionController::empty):
              (khtml::SelectionController::extend):
              (khtml::SelectionController::validate):
              * khtml/editing/SelectionController.h:
              (khtml::SelectionController::part):
              (khtml::SelectionController::baseNode):
              (khtml::SelectionController::extentNode):
              (khtml::SelectionController::baseOffset):
              (khtml::SelectionController::extentOffset):
              (khtml::SelectionController::anchorNode):
              (khtml::SelectionController::anchorOffset):
              (khtml::SelectionController::focusNode):
              (khtml::SelectionController::focusOffset):
              (khtml::SelectionController::isCollapsed):
              * khtml/editing/visible_position.cpp:
              (khtml::VisiblePosition::init):
              (khtml::VisiblePosition::isCandidate):
              * khtml/khtml_part.cpp:
              (KHTMLPart::handleMousePressEventSingleClick):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11857 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      02ba5929
    • andersca's avatar
      2006-01-03 Anders Carlsson <andersca@mac.com> · 91734bd8
      andersca authored
              Reviewed by Maciej.
      
              - Add test for http://bugzilla.opendarwin.org/show_bug.cgi?id=5378
              createDocument fails with DOM Exception 5 when passed empty qname
      
              * dom/html/level2/core/createDocument08-expected.txt:
              * dom/xhtml/level2/core/createDocument08-expected.txt:
              These now fail.
      
              * fast/dom/createDocument-empty-expected.txt: Added.
              * fast/dom/createDocument-empty.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11856 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      91734bd8
    • andersca's avatar
      2006-01-03 Anders Carlsson <andersca@mac.com> · a75a29b0
      andersca authored
              Reviewed by Maciej.
      
              - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=5378
              createDocument fails with DOM Exception 5 when passed empty qname
      
              * khtml/ecma/kjs_dom.cpp:
              (KJS::DOMDOMImplementationProtoFunc::callAsFunction):
              When passing null to createDocument, pass a null DOMString, and not
              a DOMString containing the text "null".
      
              * khtml/xml/dom_docimpl.cpp:
              (DOMImplementationImpl::createDocument):
              Only validate the qualifiedName if it's not null or empty. Also, do not
              create the document element if the qualifiedName is null or empty.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11855 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a75a29b0
    • eseidel's avatar
      Bug #: 6109 · ef508986
      eseidel authored
      Submitted by: eseidel
      Reviewed by: darin
              No functionality changes, no tests possible.
      
              khtml/editing should use RefPtr instead of manual ref/deref
              http://bugzilla.opendarwin.org/show_bug.cgi?id=6109
      
              Results in a slight performance gain < 1% on the PLT.
      
              * khtml/editing/SelectionController.cpp:
              (khtml::SelectionController::toRange):
              * khtml/editing/SelectionController.h:
              * khtml/editing/append_node_command.cpp:
              (khtml::AppendNodeCommand::AppendNodeCommand):
              (khtml::AppendNodeCommand::doApply):
              (khtml::AppendNodeCommand::doUnapply):
              * khtml/editing/append_node_command.h:
              (khtml::AppendNodeCommand::~AppendNodeCommand):
              (khtml::AppendNodeCommand::appendChild):
              (khtml::AppendNodeCommand::parentNode):
              * khtml/editing/apply_style_command.cpp:
              (khtml::StyleChange::init):
              (khtml::ApplyStyleCommand::removeInlineStyle):
              * khtml/editing/apply_style_command.h:
              * khtml/editing/composite_edit_command.cpp:
              (khtml::CompositeEditCommand::deleteInsignificantText):
              * khtml/editing/delete_from_text_node_command.cpp:
              (khtml::DeleteFromTextNodeCommand::DeleteFromTextNodeCommand):
              * khtml/editing/delete_from_text_node_command.h:
              (khtml::DeleteFromTextNodeCommand::~DeleteFromTextNodeCommand):
              (khtml::DeleteFromTextNodeCommand::node):
              * khtml/editing/delete_selection_command.cpp:
              (khtml::DeleteSelectionCommand::initializePositionData):
              (khtml::DeleteSelectionCommand::saveTypingStyleState):
              (khtml::DeleteSelectionCommand::handleGeneralDelete):
              (khtml::DeleteSelectionCommand::calculateEndingPosition):
              (khtml::DeleteSelectionCommand::calculateTypingStyleAfterDelete):
              (khtml::DeleteSelectionCommand::clearTransientState):
              * khtml/editing/delete_selection_command.h:
              * khtml/editing/edit_command.cpp:
              (khtml::EditCommand::EditCommand):
              (khtml::EditCommand::~EditCommand):
              (khtml::EditCommand::setTypingStyle):
              (khtml::EditCommand::styleAtPosition):
              * khtml/editing/edit_command.h:
              (khtml::EditCommand::document):
              (khtml::EditCommand::typingStyle):
              * khtml/editing/insert_into_text_node_command.cpp:
              (khtml::InsertIntoTextNodeCommand::InsertIntoTextNodeCommand):
              * khtml/editing/insert_into_text_node_command.h:
              (khtml::InsertIntoTextNodeCommand::~InsertIntoTextNodeCommand):
              (khtml::InsertIntoTextNodeCommand::node):
              * khtml/editing/insert_node_before_command.cpp:
              (khtml::InsertNodeBeforeCommand::InsertNodeBeforeCommand):
              (khtml::InsertNodeBeforeCommand::doApply):
              (khtml::InsertNodeBeforeCommand::doUnapply):
              * khtml/editing/insert_node_before_command.h:
              (khtml::InsertNodeBeforeCommand::~InsertNodeBeforeCommand):
              (khtml::InsertNodeBeforeCommand::insertChild):
              (khtml::InsertNodeBeforeCommand::refChild):
              * khtml/editing/insert_paragraph_separator_command.cpp:
              (khtml::InsertParagraphSeparatorCommand::InsertParagraphSeparatorCommand):
              (khtml::InsertParagraphSeparatorCommand::~InsertParagraphSeparatorCommand):
              (khtml::InsertParagraphSeparatorCommand::calculateStyleBeforeInsertion):
              (khtml::InsertParagraphSeparatorCommand::applyStyleAfterInsertion):
              * khtml/editing/insert_paragraph_separator_command.h:
              * khtml/editing/join_text_nodes_command.cpp:
              (khtml::JoinTextNodesCommand::JoinTextNodesCommand):
              (khtml::JoinTextNodesCommand::doApply):
              (khtml::JoinTextNodesCommand::doUnapply):
              * khtml/editing/join_text_nodes_command.h:
              (khtml::JoinTextNodesCommand::~JoinTextNodesCommand):
              (khtml::JoinTextNodesCommand::firstNode):
              (khtml::JoinTextNodesCommand::secondNode):
              * khtml/editing/jsediting.cpp:
              * khtml/editing/markup.cpp:
              (khtml::createMarkup):
              (khtml::createFragmentFromMarkup):
              (khtml::createFragmentFromText):
              (khtml::createFragmentFromNodeList):
              * khtml/editing/markup.h:
              * khtml/editing/merge_identical_elements_command.cpp:
              (khtml::MergeIdenticalElementsCommand::MergeIdenticalElementsCommand):
              (khtml::MergeIdenticalElementsCommand::doApply):
              (khtml::MergeIdenticalElementsCommand::doUnapply):
              * khtml/editing/merge_identical_elements_command.h:
              (khtml::MergeIdenticalElementsCommand::~MergeIdenticalElementsCommand):
              * khtml/editing/move_selection_command.cpp:
              (khtml::MoveSelectionCommand::MoveSelectionCommand):
              (khtml::MoveSelectionCommand::~MoveSelectionCommand):
              (khtml::MoveSelectionCommand::doApply):
              * khtml/editing/move_selection_command.h:
              * khtml/editing/rebalance_whitespace_command.cpp:
              * khtml/editing/rebalance_whitespace_command.h:
              (khtml::RebalanceWhitespaceCommand::~RebalanceWhitespaceCommand):
              * khtml/editing/remove_css_property_command.cpp:
              (khtml::RemoveCSSPropertyCommand::RemoveCSSPropertyCommand):
              * khtml/editing/remove_css_property_command.h:
              (khtml::RemoveCSSPropertyCommand::~RemoveCSSPropertyCommand):
              (khtml::RemoveCSSPropertyCommand::styleDeclaration):
              * khtml/editing/remove_node_attribute_command.cpp:
              (khtml::RemoveNodeAttributeCommand::RemoveNodeAttributeCommand):
              * khtml/editing/remove_node_attribute_command.h:
              (khtml::RemoveNodeAttributeCommand::~RemoveNodeAttributeCommand):
              (khtml::RemoveNodeAttributeCommand::element):
              * khtml/editing/remove_node_command.cpp:
              (khtml::RemoveNodeCommand::RemoveNodeCommand):
              (khtml::RemoveNodeCommand::doApply):
              (khtml::RemoveNodeCommand::doUnapply):
              * khtml/editing/remove_node_command.h:
              (khtml::RemoveNodeCommand::~RemoveNodeCommand):
              (khtml::RemoveNodeCommand::node):
              * khtml/editing/remove_node_preserving_children_command.cpp:
              (khtml::RemoveNodePreservingChildrenCommand::RemoveNodePreservingChildrenCommand):
              * khtml/editing/remove_node_preserving_children_command.h:
              (khtml::RemoveNodePreservingChildrenCommand::~RemoveNodePreservingChildrenCommand):
              (khtml::RemoveNodePreservingChildrenCommand::node):
              * khtml/editing/replace_selection_command.cpp:
              (khtml::ReplacementFragment::ReplacementFragment):
              (khtml::ReplacementFragment::~ReplacementFragment):
              (khtml::ReplacementFragment::enclosingBlock):
              (khtml::ReplacementFragment::removeNodePreservingChildren):
              (khtml::ReplacementFragment::removeNode):
              (khtml::ReplacementFragment::insertFragmentForTestRendering):
              (khtml::ReplacementFragment::restoreTestRenderingNodesToFragment):
              (khtml::ReplaceSelectionCommand::fixupNodeStyles):
              (khtml::computeAndStoreNodeDesiredStyle):
              (khtml::NodeDesiredStyle::NodeDesiredStyle):
              (khtml::ReplaceSelectionCommand::ReplaceSelectionCommand):
              (khtml::ReplaceSelectionCommand::~ReplaceSelectionCommand):
              (khtml::ReplaceSelectionCommand::doApply):
              (khtml::ReplaceSelectionCommand::completeHTMLReplacement):
              (khtml::ReplaceSelectionCommand::updateNodesInserted):
              * khtml/editing/replace_selection_command.h:
              (khtml::NodeDesiredStyle::node):
              (khtml::NodeDesiredStyle::style):
              (khtml::ReplacementFragment::root):
              * khtml/editing/set_node_attribute_command.cpp:
              (khtml::SetNodeAttributeCommand::SetNodeAttributeCommand):
              * khtml/editing/set_node_attribute_command.h:
              (khtml::SetNodeAttributeCommand::~SetNodeAttributeCommand):
              (khtml::SetNodeAttributeCommand::element):
              * khtml/editing/split_element_command.cpp:
              (khtml::SplitElementCommand::SplitElementCommand):
              (khtml::SplitElementCommand::doApply):
              (khtml::SplitElementCommand::doUnapply):
              * khtml/editing/split_element_command.h:
              (khtml::SplitElementCommand::~SplitElementCommand):
              * khtml/editing/split_text_node_command.cpp:
              (khtml::SplitTextNodeCommand::SplitTextNodeCommand):
              (khtml::SplitTextNodeCommand::doApply):
              (khtml::SplitTextNodeCommand::doUnapply):
              * khtml/editing/split_text_node_command.h:
              (khtml::SplitTextNodeCommand::~SplitTextNodeCommand):
              (khtml::SplitTextNodeCommand::node):
              * khtml/editing/split_text_node_containing_element.cpp:
              (khtml::SplitTextNodeContainingElementCommand::SplitTextNodeContainingElementCommand):
              (khtml::SplitTextNodeContainingElementCommand::doApply):
              * khtml/editing/split_text_node_containing_element_command.h:
              (khtml::SplitTextNodeContainingElementCommand::~SplitTextNodeContainingElementCommand):
              * khtml/editing/visible_position.cpp:
              (khtml::makeRange):
              * khtml/editing/visible_position.h:
              * khtml/editing/visible_text.cpp:
              (khtml::TextIterator::range):
              (khtml::SimplifiedBackwardsTextIterator::range):
              (khtml::CharacterIterator::range):
              (khtml::findPlainText):
              * khtml/editing/visible_text.h:
              (khtml::WordAwareIterator::range):
              * khtml/editing/wrap_contents_in_dummy_span_command.cpp:
              (khtml::WrapContentsInDummySpanCommand::WrapContentsInDummySpanCommand):
              (khtml::WrapContentsInDummySpanCommand::doApply):
              (khtml::WrapContentsInDummySpanCommand::doUnapply):
              * khtml/editing/wrap_contents_in_dummy_span_command.h:
              (khtml::WrapContentsInDummySpanCommand::~WrapContentsInDummySpanCommand):
              * kwq/DOMHTML.mm:
              (-[DOMHTMLDocument _createDocumentFragmentWithMarkupString:baseURLString:]):
              (-[DOMHTMLDocument _createDocumentFragmentWithText:]):
              * kwq/WebCoreBridge.mm:
              (-[WebCoreBridge documentFragmentWithMarkupString:baseURLString:]):
              (-[WebCoreBridge documentFragmentWithText:]):
              (-[WebCoreBridge documentFragmentWithNodesAsParagraphs:]):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11854 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ef508986
    • andersca's avatar
      2006-01-03 Anders Carlsson <andersca@mac.com> · 1fb63eff
      andersca authored
              Reviewed by Darin.
      
              - Add tests for http://bugzilla.opendarwin.org/show_bug.cgi?id=5177
              Javascript cloneNode(deep) does not clone form elements correctly
      
              * fast/dom/clone-node-form-elements-expected.txt: Added.
              * fast/dom/clone-node-form-elements.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11853 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1fb63eff
    • andersca's avatar
      2006-01-03 Anders Carlsson <andersca@mac.com> · c70d1c6a
      andersca authored
              Reviewed by Darin.
      
              - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=5177
              Javascript cloneNode(deep) does not clone form elements correctly
      
              * khtml/html/html_elementimpl.cpp:
              (HTMLElementImpl::cloneNode):
              Call copyNonAttributeProperties on the new node.
      
              * khtml/html/html_formimpl.cpp:
              (DOM::HTMLInputElementImpl::copyNonAttributeProperties):
              * khtml/html/html_formimpl.h:
              Copy m_value, m_checked and m_indeterminate here.
      
              * khtml/xml/dom_docimpl.cpp:
              (DocumentImpl::importNode):
              Call copyNonAttributeProperties on the new node.
      
              * khtml/xml/dom_elementimpl.cpp:
              (ElementImpl::cloneNode):
              Call copyNonAttributeProperties on the new node.
      
              * khtml/xml/dom_elementimpl.h:
              (DOM::ElementImpl::copyNonAttributeProperties):
              Add function declaration.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11852 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c70d1c6a
  4. 02 Jan, 2006 4 commits
    • mjs's avatar
      Reviewed by Eric. · 7c79e17d
      mjs authored
      	- moved frame traversal logic from WebFrame to WebBridge
      	http://bugzilla.opendarwin.org/show_bug.cgi?id=6341
      
      	To do this, I had to invert the ownership so that WebBridge now
      	owns WebFrame instead of vice versa. As a result, WebView now owns
      	a WebBridge pointer and does not have a direct WebFrame pointer.
      
              * WebCoreSupport.subproj/WebBridge.h:
              * WebCoreSupport.subproj/WebBridge.m:
              (-[WebBridge initWithFrameName:view:]): The initializer is now responsible for creating
      	the frame, so pass it what it needs to do that.
              (-[WebBridge dealloc]): The bridge now owns the frame, so release it.
              (-[WebBridge close]): ditto
              (-[WebBridge firstChild]): Moved from WebFrame
              (-[WebBridge lastChild]): ditto
              (-[WebBridge childCount]): ditto
              (-[WebBridge previousSibling]): ditto
              (-[WebBridge nextSibling]): ditto
              (-[WebBridge isDescendantOfFrame:]): ditto
              (-[WebBridge traverseNextFrameStayWithin:]): ditto
              (-[WebBridge appendChild:]): ditto
              (-[WebBridge removeChild:]): ditto
              * WebView.subproj/WebFrame.m:
              (-[WebFrame _removeChild::]): Call WebBridge version
              (-[WebFramePrivate dealloc]): ditto
              (-[WebFrame _firstChildFrame]): ditto
              (-[WebFrame _lastChildFrame]): ditto
              (-[WebFrame _childFrameCount]): ditto
              (-[WebFrame _previousSiblingFrame]): ditto
              (-[WebFrame _nextSiblingFrame]): ditto
              (-[WebFrame _traverseNextFrameStayWithin:]): ditto
              (-[WebFrame _appendChild:]): ditto
              (-[WebFrame _removeChild:]): ditto
              (-[WebFrame _isDescendantOfFrame:]): ditto,
              (-[WebFrame _detachFromParent]): reorder a bit to avoid losing our bridge
      	pointer before the bridge is due to release us, and don't release the
      	bridge any more since it now owns us
              (-[WebFrame _initWithName:webFrameView:webView:bridge:]): new initializer,
      	we no longer create the bridge, instead it is passed in
              (-[WebFrame initWithName:webFrameView:webView:]): Call the new designated
      	initializer, but this method is no longer viable and should be deprecated.
              * WebView.subproj/WebFrameInternal.h:
      
      	* WebView.subproj/WebView.m: WebView was changed to hold onto
      	the WebBridge for the main frame instead of the WebFrame.
      
              (-[WebViewPrivate dealloc]): update for the fact that we hold
      	a bridge now, not a frame.
              (-[WebView _close]): ditto
              (-[WebView _createFrameNamed:inParent:allowsScrolling:]): Create
      	a bridge, not a frame.
              (-[WebView _commonInitializationWithFrameName:groupName:]): ditto.
              (-[WebView setDefersCallbacks:]): get mainFrame via method
              (-[WebView mainFrame]): Update to get the main frame properly
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11851 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7c79e17d
    • mjs's avatar
      Rubber stamped by Eric. · bf2dc456
      mjs authored
              - remove the no longer used QIntDict
      
              * kwq/KWQIntDict.h: Removed.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11850 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bf2dc456
    • ap's avatar
      Reviewed by Eric. · 658b4df8
      ap authored
              - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=5609
                XSLT document() doesn't handle relative paths
      
              Test case: fast/xsl/xslt-relative-path.xml
      
              * khtml/xsl/xslt_processorimpl.cpp:
              (DOM::docLoaderFunc): Renamed from stylesheetLoadFunc. Use base URL when constructing URLs.
              (DOM::XSLTProcessorImpl::transformToString):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11849 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      658b4df8
    • vicki's avatar
      Reviewed by Maciej. · 07d08035
      vicki authored
      	- fix for <rdar://problem/4389622> *Pan EU2* iframe swallows events for overlapping elements (part 2)
      
      	We originally added a call to passSubframeEventToSubframe here to fix the hand cursor updating problem
      	reported in <rdar://problem/4316201> REGRESSION: cursor and text in status bar is not updated when
      	mousing over links in a frame (5509). However, when we return early after passSubframeEventToSubframe,
      	we fail to fire onmouseout events.  Since the call to passSubframeEventToSubframe was originally added
      	to fix the hand cursor updating problem, remove the early return and make cursor updating conditional
      	on passSubframeEventToSubframe.
      
              * khtml/khtmlview.cpp:
              (KHTMLView::viewportMouseMoveEvent):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11848 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      07d08035
  5. 30 Dec, 2005 4 commits
    • darin's avatar
      Reviewed by Maciej. · 7baeccde
      darin authored
              - http://bugzilla.opendarwin.org/show_bug.cgi?id=4557
                rename unusual strcmp and strcasecmp for DOMString family
      
              Added new functions named equal and equalIgnoringCase.
      
              * khtml/xml/dom_stringimpl.h: Changed the type of the length parameter to computeHash to unsigned
              to match the rest of the interface. Added equal and equalIgnoringCase functions. Added a
              version of the hash function that works on char* to CaseInsensitiveHash as preparation for an
              atomic string change.
              * khtml/xml/dom_stringimpl.cpp: Moved the QT_ALLOC_QCHAR_VEC and QT_DELETE_QCHAR_VEC macros
              here, and changed them into inline functions.
              (DOM::equal): Implemented.
              (DOM::equalIgnoringCase): Implemented.
              (DOM::DOMStringImpl::computeHash): Changed parameter type to unsigned to match other similar
              functions.
      
              * khtml/dom/dom_string.h: Removed unnecessary friend declarations. Changed operator
              overloads for == and != to call through inline to DOMStringImpl. Replaced strcasecmp
              with equalIgnoringCase, overloaded for one more combination of parameters. Removed strcmp.
              * khtml/dom/dom_string.cpp: Removed functions that are now implemented in DOMStringImpl*.
      
              * khtml/xml/dom_atomicstring.h: Removed a redundant const. Removed unnecessary
              friend declarations. Removed AtomicString::equal. Filled out a larger set of == and
              != operator implementations, mostly with inlines calling through to DOMStringImpl.
              Renamed equalsIgnoreCase to equalIgnoringCase and filled out a larger set as above.
              * khtml/xml/dom_atomicstring.cpp: Renamed AtomicString::equal to just ==.
              Removed some implementation of == and equalsIgnoreCase that are replaced by inlines.
      
              * khtml/html/html_listimpl.cpp:
              (DOM::HTMLOListElementImpl::parseMappedAttribute):
              (DOM::HTMLLIElementImpl::parseMappedAttribute):
              Use the "==" operator instead of strcmp.
      
              * khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::checkOneSelector):
              Use equalIgnoringCase instead of equalsIgnoreCase.
      
              * khtml/rendering/render_form.cpp:
              (RenderSlider::updateFromElement): Fixed bug where a temporary DOMString was put into
              a const DOMString&. Changed some DOMString to AtomicString as appropriate, and also
              used equalIgnoringCase instead of strcasecmp.
              (RenderSlider::slotSliderValueChanged): More of the same.
      
              * khtml/xml/dom_docimpl.cpp: (DocumentImpl::processHttpEquiv): Replaced use of strcasecmp
              with equalIgnoringCase. Added parentheses to fix incorrect operator precedence in one case
              (&& binds tighter than ||) which fixes a crash when using a http-equiv pragma when there
              is no part (not sure how to reproduce that).
      
              * khtml/khtml_part.cpp:
              (updateState):
              (KHTMLPart::selectionStartHasStyle):
              * khtml/ecma/kjs_html.cpp: (KJS::KJS::HTMLDocument::putValueProperty):
              * khtml/editing/apply_style_command.cpp:
              (khtml::StyleChange::checkForLegacyHTMLStyleChange):
              (khtml::StyleChange::currentlyHasStyle):
              (khtml::hasTextDecorationProperty):
              (khtml::ApplyStyleCommand::extractTextDecorationStyle):
              (khtml::ApplyStyleCommand::extractAndNegateTextDecorationStyle):
              * khtml/html/html_baseimpl.cpp:
              (HTMLBodyElementImpl::parseMappedAttribute):
              (HTMLFrameElementImpl::parseMappedAttribute):
              * khtml/html/html_blockimpl.cpp:
              (HTMLDivElementImpl::parseMappedAttribute):
              (HTMLHRElementImpl::parseMappedAttribute):
              (HTMLParagraphElementImpl::parseMappedAttribute):
              (HTMLMarqueeElementImpl::parseMappedAttribute):
              * khtml/html/html_elementimpl.cpp:
              (HTMLElementImpl::parseMappedAttribute):
              (HTMLElementImpl::addHTMLAlignment):
              (HTMLElementImpl::setContentEditable):
              * khtml/html/html_formimpl.cpp:
              (DOM::HTMLFormElementImpl::parseMappedAttribute):
              (DOM::HTMLButtonElementImpl::parseMappedAttribute):
              (DOM::HTMLInputElementImpl::setInputType):
              (DOM::HTMLInputElementImpl::parseMappedAttribute):
              (DOM::HTMLKeygenElementImpl::appendFormData):
              (DOM::HTMLTextAreaElementImpl::parseMappedAttribute):
              * khtml/html/html_imageimpl.cpp: (DOM::HTMLAreaElementImpl::parseMappedAttribute):
              * khtml/html/html_inlineimpl.cpp: (DOM::HTMLBRElementImpl::parseMappedAttribute):
              * khtml/html/html_tableimpl.cpp: (DOM::HTMLTablePartElementImpl::parseMappedAttribute):
              * khtml/html/htmlparser.cpp: (HTMLParser::handleError):
              Use equalIgnoringCase instead of strcasecmp.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11847 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7baeccde
    • ap's avatar
      Reviewed by Darin, landed by ap. · 2734996c
      ap authored
              - fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=5461
                Text width measured incorrectly when text-align: justify
      
      WebCore:
              * khtml/rendering/font.h:
              * khtml/rendering/font.cpp:
              (khtml::Font::selectionRectForText): Added.
              * khtml/rendering/render_text.cpp:
              (kthml::InlineTextBox::selectionRect): Use selectionRectForText. This
              works for justified text as well, and avoids intermediate rounding which
              resulted in selection rects narrower than AppKit's.
              (khtml::InlineTextBox::positionForOffset): Use selectionRectForText,
              which works for justified text as well.
              * kwq/KWQFontMetrics.h:
              * kwq/KWQFontMetrics.mm:
              (QFontMetrics::selectionRectForText): Added.
              * kwq/WebCoreTextRenderer.h:
      
      WebKit:
              * WebCoreSupport.subproj/WebTextRenderer.m:
              (-[WebTextRenderer selectionRectForRun:style:geometry:]): Added.
              (CG_drawHighlight): Use new function CG_selectionRect.
              (CG_selectionRect): New function to compute the selection rect.
              Eliminated rounding hackery that was required for keeping the highlight
              rect within the selection rect computed by
              InlineTextBox::selectionRect, since the latter uses this function now.
              The new selection rect is wider and matches AppKit more closely,
              although the right hand side is roundf()ed instead of cielf()ed for
              optimal caret positioning.
              (ATSU_drawHighlight): Use new function ATSU_selectionRect.
              (ATSU_selectionRect): New function to compute the selection rect.
              Much like CG_selectionRect.
      LayoutTests:
              * fast/text/justified-text-rect-expected.checksum: Added.
              * fast/text/justified-text-rect-expected.png: Added.
              * fast/text/justified-text-rect-expected.txt: Added.
              * fast/text/justified-text-rect.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11846 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2734996c
    • ap's avatar
      - Fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6289 · 9bbc4e38
      ap authored
              REGRESSION: firstCharacterForRange(0, 0) returns a 0x0 rect
      
              * khtml/editing/visible_text.cpp:
              (khtml::TextIterator::rangeFromLocationAndLength):
              Only special-case (0, 0) ranges for empty documents.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11845 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9bbc4e38
    • andersca's avatar
      Forgot to commit this · d166e7a8
      andersca authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@11844 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d166e7a8