- 27 Mar, 2007 16 commits
-
-
justing authored
Reviewed by darin <rdar://problem/5091898> REGRESSION: GMail Editor: A line of underlined text copied with Select All pastes with wrong font family Demonstrates the bug fixed: * editing/style/5091898-expected.checksum: Added. * editing/style/5091898-expected.png: Added. * editing/style/5091898-expected.txt: Added. * editing/style/5091898.html: Added. Demonstrates a related bug fixed (deleting the line break before a paragraph could remove its underlining): * editing/deleting/5091898-expected.checksum: Added. * editing/deleting/5091898-expected.png: Added. * editing/deleting/5091898-expected.txt: Added. * editing/deleting/5091898.html: Added. Demonstrates that a link now (correctly) exists, instead of just underlined text: * editing/pasteboard/4840662-expected.txt: WebCore: Reviewed by darin <rdar://problem/5091898> REGRESSION: GMail Editor: A line of underlined text copied with Select All pastes with wrong font family createMarkup skipped elements if they were blocks when called from moveParagraphs (because that function must receive only inline content). This patch adds code to inline these blocks instead of skipping them so that we don't lose any of the style that they contribute to the copied markup. * editing/markup.cpp: (WebCore::startMarkup): Add an inlineBlocks option. Make sure to overwrite display:block coming from a style sheet or the inline style declaration. (WebCore::createMarkup): Don't refuse to include a specialCommonAncestor that's a block if we were asked to include only inline content, since we can now inline block elements in startMarkup. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20542 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
adele authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20541 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
adele authored
* DumpRenderTree/DumpRenderTree.m: (-[WaitUntilDoneDelegate webView:didFinishLoadForFrame:]): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20540 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
adele authored
* DumpRenderTree/DumpRenderTree.m: (-[WaitUntilDoneDelegate webView:didFinishLoadForFrame:]): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20539 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
sullivan authored
- fixed <rdar://problem/5092556> Default UA spoofing is always off until explicitly toggled * WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:]): initialize the cached value of _private->useSiteSpecificSpoofing here; formerly it would not be initialized correctly in the common case of WebViews that use [WebPreferences standardPreferences] git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20537 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
adele authored
Fix for <rdar://problem/5026141> REGRESSION: Aperture Viewer Flashes when switching from Index Page to Detail page in Web Gallery This disables the paint that occurs after WebCore finishes loading the document. We should reenable this when we move the dispatchDidFinishLoad delegate callback to happen around the same time as the JS onload call. See <rdar://problem/5092361>. * dom/Document.cpp: (WebCore::Document::implicitClose): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20535 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
justing authored
Reviewed by darin <rdar://problem/5065910> REGRESSION: In Mail and GMail, Can't apply color to pasted line of text <rdar://problem/5084241> After deleting a paragraph of colored text, can't change text color <rdar://problem/5065605> REGRESSION: Text copied with Select All + Copy loses color on Paste <rdar://problem/4916887> GMAIL: Can't apply color to text once it becomes indented * editing/pasteboard/5065605-expected.checksum: Added. * editing/pasteboard/5065605-expected.png: Added. * editing/pasteboard/5065605-expected.txt: Added. * editing/pasteboard/5065605.html: Added. * editing/style/4916887-expected.checksum: Added. * editing/style/4916887-expected.png: Added. * editing/style/4916887-expected.txt: Added. * editing/style/4916887.html: Added. * editing/style/5065910-expected.checksum: Added. * editing/style/5065910-expected.png: Added. * editing/style/5065910-expected.txt: Added. * editing/style/5065910.html: Added. * editing/style/5084241-expected.checksum: Added. * editing/style/5084241-expected.png: Added. * editing/style/5084241-expected.txt: Added. * editing/style/5084241.html: Added. WebCore: Reviewed by darin <rdar://problem/5065910> REGRESSION: In Mail and GMail, Can't apply color to pasted line of text <rdar://problem/5084241> After deleting a paragraph of colored text, can't change text color <rdar://problem/5065605> REGRESSION: Text copied with Select All + Copy loses color on Paste <rdar://problem/4916887> GMAIL: Can't apply color to text once it becomes indented * css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::copyInheritableProperties): If a node's text fill color is invalid, then its children use their font-color as their text fill color (they don't inherit it). Likewise for stroke color. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20520 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
andersca authored
Use wtf/MathExtras.h instead of math.h git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20518 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
bdash authored
Reviewed by Dave Harrison. * Configurations/WebKit.xcconfig: Include UMBRELLA_FRAMEWORKS_DIR in framework search path. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20513 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
zack authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20512 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
oliver authored
Reviewed by Maciej. The WebArchiver needs all the subresources of a document to be accessible through the DocLoader, so we can't remove a CachedResource simultaneously from the global Cache and all DocLoaders, just because it needs to be reloaded in one. Fixes rdar://problem/5044366 * loader/Cache.cpp: (WebCore::Cache::remove): Don't evict the resource from all DocLoaders * manual-tests/test-iframes-loading-the-same-resource.html: Added. Alas it wasn't possible to make a nice layout test, even this manual test is not entirely deterministic git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20511 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
bdash authored
Build fix. * platform/GlyphBuffer.h: (WebCore::GlyphBuffer::clear): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20510 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
zack authored
asserts and improve a bit the layout scheduling in the Qt port git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20509 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
hyatt authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20508 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
antti authored
* platform/mac/PlatformScrollBarMac.mm: (WebCore::PlatformScrollbar::scrollbarHit): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20507 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
antti authored
Reviewed by Darin. On Mac, support fine grained wheel events generated by trackpad and Mighty Mouse. http://bugs.webkit.org/show_bug.cgi?id=13134 <rdar://problem/5076249? * WebCore.exp: Export _wkGetWheelEventDeltas * page/EventHandler.cpp: (WebCore::EventHandler::handleWheelEvent): Remove (0, 0) scroll event hack, it is not needed anymore. Do per-pixel scrolling for fine grained events. * platform/PlatformWheelEvent.h: (WebCore::PlatformWheelEvent::isContinuous): Add new m_isContinuous boolean to indicate fine grained wheel events. * platform/ScrollBar.cpp: (WebCore::Scrollbar::Scrollbar): (WebCore::Scrollbar::setValue): (WebCore::Scrollbar::setSteps): (WebCore::Scrollbar::scroll): * platform/ScrollBar.h: (WebCore::Scrollbar::value): Use float to represent current position to support finer grained scrolling. Add ScrollByPixel, remove ScrollByWheel (which was same as ScrollByLine anyway) * platform/ScrollTypes.h: (WebCore::): * platform/gdk/WheelEventGdk.cpp: (WebCore::PlatformWheelEvent::PlatformWheelEvent): Initalize m_isContinuous * platform/mac/WebCoreSystemInterface.h: * platform/mac/WebCoreSystemInterface.mm: Add wkGetWheelEventDeltas for getting fine grained wheel events * platform/mac/WheelEventMac.mm: (WebCore::PlatformWheelEvent::PlatformWheelEvent): Get the wheel deltas using new wkGetWheelEventDeltas interface * platform/qt/WheelEventQt.cpp: (WebCore::PlatformWheelEvent::PlatformWheelEvent): Initalize m_isContinuous * rendering/RenderListBox.cpp: (WebCore::RenderListBox::calcHeight): Pass item height to scrollbar WebKit: Reviewed by Darin. On Mac, support fine grained wheel events generated by trackpad and Mighty Mouse. http://bugs.webkit.org/show_bug.cgi?id=13134 <rdar://problem/5076249? * WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface): Expose GetWheelEventDeltas() WebKitLibraries: Reviewed by Darin. Added wkGetWheelEventDeltas * WebKitSystemInterface.h: * libWebKitSystemInterface.a: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20506 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
- 26 Mar, 2007 12 commits
-
-
ddkilzer authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20505 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ggaren authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20504 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ggaren authored
Reviewed by Darin Adler. Layout tests for <rdar://problem/5088234> REGRESSION: Crash occurs at WebCore::Node::createRendererIfNeeded() when changing map views with MS Virtual Earth (http://www.ziprealty.com/) * fast/dom/mutation-event-remove-inserted-node-expected.txt: Added. * fast/dom/mutation-event-remove-inserted-node.html: Added. * fast/dom/script-element-remove-self-expected.txt: Added. * fast/dom/script-element-remove-self.html: Added. WebCore: Reviewed by Darin, landed by Anders. Manual test case for http://bugs.webkit.org/show_bug.cgi?id=13142 * manual-tests/liveconnect-applet-get-boolean.html: Added. * manual-tests/resources/CheckerApplet.class: Added. * manual-tests/resources/CheckerApplet.java: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20503 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
andersca authored
Reviewed by Darin, landed by Anders. Fix for: http://bugs.webkit.org/show_bug.cgi?id=13142 The previous fix http://bugs.webkit.org/show_bug.cgi?id=12636 introduced new JNIType to enum in jni_utility.h This is a problem on the Mac as it seems that the JNIType enum is also used in the JVM, it is used to specify the return type in jni_objc.mm Corrected the fix by moving type to the end, and changing jni_objc.mm to convert the new type to an old compatible type. * bindings/jni/jni_objc.mm: (KJS::Bindings::dispatchJNICall): * bindings/jni/jni_utility.h: WebCore: Reviewed by Darin, landed by Anders. Manual test case for http://bugs.webkit.org/show_bug.cgi?id=13142 * manual-tests/liveconnect-applet-get-boolean.html: Added. * manual-tests/resources/CheckerApplet.class: Added. * manual-tests/resources/CheckerApplet.java: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20502 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
aroben authored
Bug 13198: Move build settings from project file to xcconfig file for apollo port JSCore http://bugs.webkit.org/show_bug.cgi?id=13198 - Moving build settings from xcode project file to xcconfig files. * JavaScriptCore.apolloproj/mac/JavaScriptCore/JavaScriptCore.Debug.xcconfig: * JavaScriptCore.apolloproj/mac/JavaScriptCore/JavaScriptCore.Release.xcconfig: * JavaScriptCore.apolloproj/mac/JavaScriptCore/JavaScriptCore.xcconfig: * JavaScriptCore.apolloproj/mac/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20501 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
beidson authored
Since CFTypeRef is really void*, a RetainPtr couldn't be used. RefType was "void", which doesn't actually exist as a type. Since RefType only existed for operator*(), and since that operator doesn't make any sense for RetainPtr, I removed them! * kjs/nodes.cpp: Touch this to force a rebuild and (hopefully) help the compiler with dependencies * wtf/RetainPtr.h: Nuke RefType and operator*() git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20500 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
darin authored
Reviewed and landed by Darin. - pixel test for http://bugs.webkit.org/show_bug.cgi?id=13194 REGRESSION: Selection rects are wrong for images in search results from images.google.com * fast/replaced/selection-rect-in-table-cell-expected.checksum: Added. * fast/replaced/selection-rect-in-table-cell-expected.png: Added. * fast/replaced/selection-rect-in-table-cell-expected.txt: Added. * fast/replaced/selection-rect-in-table-cell.html: Added. WebCore: Reviewed and landed by Darin. - fix http://bugs.webkit.org/show_bug.cgi?id=13194 <rdar://problem/5087738> REGRESSION: Selection rects are wrong for images in search results from images.google.com Test: fast/replaced/selection-rect-in-table-cell.html * rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::selectionRect): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20499 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
sullivan authored
- fixed <rdar://problem/4769772> Problem with Find on certain PDF page * WebView/WebPDFView.mm: (-[WebPDFView _scaledAttributedString:]): We were hitting an exception trying to set the font attribute to nil, which was happening because the result of -[PDFSelection attributedString] had no attributes. That PDFSelection bug is now filed separately, but this works around the exception. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20498 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ggaren authored
* kjs/nodes.cpp: (Node::deref): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20497 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ggaren authored
* WebCorePrefix.h: * config.h: * css/CSSGrammar.y: * platform/Arena.cpp: * platform/KURL.cpp: * platform/SegmentedString.h: * rendering/DataRef.h: * rendering/RenderArena.cpp: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20496 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ggaren authored
Global replace of "assert(" with "ASSERT(" to assist debugging. Removed one instance of commented-out code containing "assert(" instead of replacing it. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20495 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
darin authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20494 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
- 25 Mar, 2007 12 commits
-
-
darin authored
green color that comes from the green.css stylesheet. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20493 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
darin authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20492 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
darin authored
* coding/RefPtr.html: Put the operator name "new" in the oblique style as with other identifiers. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20491 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
antti authored
Reviewed by Adam. Test for <rdar://problem/5049842> Gmail Editor: Dragging message text in the message body results in a crash at WebCore::Frame::eventHandler() * editing/pasteboard/drag-drop-dead-frame-expected.checksum: Added. * editing/pasteboard/drag-drop-dead-frame-expected.png: Added. * editing/pasteboard/drag-drop-dead-frame-expected.txt: Added. * editing/pasteboard/drag-drop-dead-frame.html: Added. WebCore: Reviewed by Adam. Fix <rdar://problem/5049842> Gmail Editor: Dragging message text in the message body results in a crash at WebCore::Frame::eventHandler() Null check frame in m_dragTarget, it might be gone already. * page/EventHandler.cpp: (WebCore::EventHandler::updateDragAndDrop): (WebCore::EventHandler::cancelDragAndDrop): (WebCore::EventHandler::performDragAndDrop): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20490 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
bdash authored
Reviewed by Sam Weinig. Upload crash logs from DumpRenderTree as part of the test results to ease debugging of hard-to-reproduce crashes. * BuildSlaveSupport/build.webkit.org-config/webkit/steps.py: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20489 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
bdash authored
Fix grammar error that Mitz pointed out. Replace raw ampersands in hyperlink URL with named entity. * coding/RefPtr.html: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20488 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ap authored
A partial fix for http://bugs.webkit.org/show_bug.cgi?id=13021 XPath can be very slow * xml/XPathExpression.cpp: (WebCore::XPathExpression::evaluate): Reset a reference to the context node, as this may prevent the whole document from being destroyed in time. * dom/Attr.cpp: (WebCore::Attr::createTextChild): Instead of calling appendChild(), just do the few operations it really needs to perform. * dom/ContainerNode.h: (WebCore::ContainerNode::fastSetFirstChild): (WebCore::ContainerNode::fastSetLastChild): Added operations that let Attr hack internal ContainerNode data (evil, but fast!). * xml/XPathStep.cpp: (WebCore::XPath::Step::evaluate): (WebCore::XPath::Step::nodesInAxis): (WebCore::XPath::Step::nodeMatches): * xml/XPathStep.h: Merged node testing into axis enumeration. This saves a lot of Vector resizing and passing, and is necessary for future optimizations (sometimes, we can just pick the single result node instead of enumerating and filtering the whole axis). git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20487 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
darin authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20486 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
darin authored
suggested by Anders. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20485 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
darin authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20484 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
darin authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20483 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
darin authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20482 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-