Skip to content

GitLab

Switch branch/tag
  1. 27 Mar, 2007 16 commits
    • justing's avatar
      LayoutTests: · 7d3dbfed
      justing authored 
              Reviewed by darin
        
        <rdar://problem/5091898> REGRESSION: GMail Editor: A line of underlined text copied with Select All pastes with wrong font family

        Demonstrates the bug fixed:
        * editing/style/5091898-expected.checksum: Added.
        * editing/style/5091898-expected.png: Added.
        * editing/style/5091898-expected.txt: Added.
        * editing/style/5091898.html: Added.
        Demonstrates a related bug fixed (deleting
        the line break before a paragraph could remove
        its underlining):
        * editing/deleting/5091898-expected.checksum: Added.
        * editing/deleting/5091898-expected.png: Added.
        * editing/deleting/5091898-expected.txt: Added.
        * editing/deleting/5091898.html: Added.
        Demonstrates that a link now (correctly) exists, 
        instead of just underlined text:
        * editing/pasteboard/4840662-expected.txt:

WebCore:

        Reviewed by darin
        
        <rdar://problem/5091898> REGRESSION: GMail Editor: A line of underlined text copied with Select All pastes with wrong font family
        
        createMarkup skipped elements if they were blocks
        when called from moveParagraphs (because that function 
        must receive only inline content).  This patch adds 
        code to inline these blocks instead of skipping them 
        so that we don't lose any of the style that they 
        contribute to the copied markup.

        * editing/markup.cpp:
        (WebCore::startMarkup): Add an inlineBlocks option.
        Make sure to overwrite display:block coming from
        a style sheet or the inline style declaration.
        (WebCore::createMarkup): Don't refuse to include a 
        specialCommonAncestor that's a block if we were asked 
        to include only inline content, since we can now inline 
        block elements in startMarkup.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20542 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7d3dbfed
    • adele's avatar
      Oops- my comment was missing a word. · 97ab9364
      adele authored 
      
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20541 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      97ab9364
    • adele's avatar
      Adding comment. · ad634f59
      adele authored 
              * DumpRenderTree/DumpRenderTree.m:
        (-[WaitUntilDoneDelegate webView:didFinishLoadForFrame:]):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20540 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ad634f59
    • adele's avatar
      Fix svg tests by calling displayIfNeeded. · 37405f5e
      adele authored 
              * DumpRenderTree/DumpRenderTree.m:
        (-[WaitUntilDoneDelegate webView:didFinishLoadForFrame:]):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20539 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      37405f5e
    • sullivan's avatar
      Reviewed by Tim · 93cf3a55
      sullivan authored 
              
        - fixed <rdar://problem/5092556> Default UA spoofing is always off until explicitly toggled

        * WebView/WebView.mm:
        (-[WebView _commonInitializationWithFrameName:groupName:]):
        initialize the cached value of _private->useSiteSpecificSpoofing here; formerly it would not
        be initialized correctly in the common case of WebViews that use [WebPreferences standardPreferences]



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20537 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      93cf3a55
    • adele's avatar
      Reviewed by Hyatt. · 7c2f10dc
      adele authored 
              Fix for <rdar://problem/5026141> REGRESSION: Aperture Viewer Flashes when switching from Index Page to Detail page in Web Gallery

        This disables the paint that occurs after WebCore finishes loading the document.  We should reenable this when we
        move the dispatchDidFinishLoad delegate callback to happen around the same time as the JS onload call.  See <rdar://problem/5092361>.

        * dom/Document.cpp: (WebCore::Document::implicitClose):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20535 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7c2f10dc
    • justing's avatar
      LayoutTests: · dcdb2794
      justing authored 
              Reviewed by darin
        
        <rdar://problem/5065910> REGRESSION: In Mail and GMail, Can't apply color to pasted line of text
        <rdar://problem/5084241> After deleting a paragraph of colored text, can't change text color
        <rdar://problem/5065605> REGRESSION: Text copied with Select All + Copy loses color on Paste
        <rdar://problem/4916887> GMAIL: Can't apply color to text once it becomes indented

        * editing/pasteboard/5065605-expected.checksum: Added.
        * editing/pasteboard/5065605-expected.png: Added.
        * editing/pasteboard/5065605-expected.txt: Added.
        * editing/pasteboard/5065605.html: Added.
        * editing/style/4916887-expected.checksum: Added.
        * editing/style/4916887-expected.png: Added.
        * editing/style/4916887-expected.txt: Added.
        * editing/style/4916887.html: Added.
        * editing/style/5065910-expected.checksum: Added.
        * editing/style/5065910-expected.png: Added.
        * editing/style/5065910-expected.txt: Added.
        * editing/style/5065910.html: Added.
        * editing/style/5084241-expected.checksum: Added.
        * editing/style/5084241-expected.png: Added.
        * editing/style/5084241-expected.txt: Added.
        * editing/style/5084241.html: Added.

WebCore:

        Reviewed by darin
        
        <rdar://problem/5065910> REGRESSION: In Mail and GMail, Can't apply color to pasted line of text
        <rdar://problem/5084241> After deleting a paragraph of colored text, can't change text color
        <rdar://problem/5065605> REGRESSION: Text copied with Select All + Copy loses color on Paste
        <rdar://problem/4916887> GMAIL: Can't apply color to text once it becomes indented

        * css/CSSComputedStyleDeclaration.cpp:
        (WebCore::CSSComputedStyleDeclaration::copyInheritableProperties):
        If a node's text fill color is invalid, then its children use 
        their font-color as their text fill color (they don't inherit 
        it).  Likewise for stroke color.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20520 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dcdb2794
    • andersca's avatar
      * platform/ScrollBar.h: · c3c0159f
      andersca authored 
              Use wtf/MathExtras.h instead of math.h



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20518 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c3c0159f
    • bdash's avatar
      2007-03-27 Mark Rowe <mrowe@apple.com> · 68cd801b
      bdash authored 
              Reviewed by Dave Harrison.

        * Configurations/WebKit.xcconfig: Include UMBRELLA_FRAMEWORKS_DIR in framework search path.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20513 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      68cd801b
    • zack's avatar
      Fix the build · ad1986b4
      zack authored 
      
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20512 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ad1986b4
    • oliver's avatar
      2007-03-27 Oliver Hunt <oliver@apple.com> · 93990f86
      oliver authored 
              Reviewed by Maciej.

        The WebArchiver needs all the subresources of a document to be accessible
        through the DocLoader, so we can't remove a CachedResource simultaneously
        from the global Cache and all DocLoaders, just because it needs to be 
        reloaded in one.

        Fixes rdar://problem/5044366

        * loader/Cache.cpp:
        (WebCore::Cache::remove):
           Don't evict the resource from all DocLoaders
        * manual-tests/test-iframes-loading-the-same-resource.html: Added.
           Alas it wasn't possible to make a nice layout test, even this manual test
           is not entirely deterministic



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20511 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      93990f86
    • bdash's avatar
      2007-03-27 Mark Rowe <mrowe@apple.com> · 0b93c7ef
      bdash authored 
              Build fix.

        * platform/GlyphBuffer.h:
        (WebCore::GlyphBuffer::clear):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20510 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0b93c7ef
    • zack's avatar
      Fix the rendering crashes due to triggered · e44b3300
      zack authored 
      asserts and improve a bit the layout scheduling in the
Qt port


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20509 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e44b3300
    • hyatt's avatar
      Add support for glyph offsets to the GlyphBuffer. · 701900a4
      hyatt authored 
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20508 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      701900a4
    • antti's avatar
      Keep buildbot happy. · 4e73c473
      antti authored 
              * platform/mac/PlatformScrollBarMac.mm:
        (WebCore::PlatformScrollbar::scrollbarHit):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20507 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4e73c473
    • antti's avatar
      WebCore: · 8a4614cf
      antti authored 
              Reviewed by Darin.
        
        On Mac, support fine grained wheel events generated by trackpad and Mighty Mouse.
        http://bugs.webkit.org/show_bug.cgi?id=13134
        <rdar://problem/5076249?

        * WebCore.exp:
            Export _wkGetWheelEventDeltas
        * page/EventHandler.cpp:
        (WebCore::EventHandler::handleWheelEvent):
            Remove (0, 0) scroll event hack, it is not needed anymore.
            Do per-pixel scrolling for fine grained events.
        * platform/PlatformWheelEvent.h:
        (WebCore::PlatformWheelEvent::isContinuous):
            Add new m_isContinuous boolean to indicate fine grained wheel events.
        * platform/ScrollBar.cpp:
        (WebCore::Scrollbar::Scrollbar):
        (WebCore::Scrollbar::setValue):
        (WebCore::Scrollbar::setSteps):
        (WebCore::Scrollbar::scroll):
        * platform/ScrollBar.h:
        (WebCore::Scrollbar::value):
            Use float to represent current position to support finer grained scrolling.
            Add ScrollByPixel, remove ScrollByWheel (which was same as ScrollByLine anyway)
        * platform/ScrollTypes.h:
        (WebCore::):
        * platform/gdk/WheelEventGdk.cpp:
        (WebCore::PlatformWheelEvent::PlatformWheelEvent):
            Initalize m_isContinuous
        * platform/mac/WebCoreSystemInterface.h:
        * platform/mac/WebCoreSystemInterface.mm:
            Add wkGetWheelEventDeltas for getting fine grained wheel events
        * platform/mac/WheelEventMac.mm:
        (WebCore::PlatformWheelEvent::PlatformWheelEvent):
            Get the wheel deltas using new wkGetWheelEventDeltas interface
        * platform/qt/WheelEventQt.cpp:
        (WebCore::PlatformWheelEvent::PlatformWheelEvent):
            Initalize m_isContinuous
        * rendering/RenderListBox.cpp:
        (WebCore::RenderListBox::calcHeight):
            Pass item height to scrollbar

WebKit:

        Reviewed by Darin.
        
        On Mac, support fine grained wheel events generated by trackpad and Mighty Mouse.
        http://bugs.webkit.org/show_bug.cgi?id=13134
        <rdar://problem/5076249?

        * WebCoreSupport/WebSystemInterface.m:
        (InitWebCoreSystemInterface): Expose GetWheelEventDeltas()

WebKitLibraries:

        Reviewed by Darin.
        
        Added wkGetWheelEventDeltas

        * WebKitSystemInterface.h:
        * libWebKitSystemInterface.a:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20506 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8a4614cf
  3. 26 Mar, 2007 12 commits
  5. 25 Mar, 2007 12 commits