Skip to content

GitLab

Switch branch/tag
  1. 12 Nov, 2013 2 commits
  3. 31 Oct, 2013 1 commit
  5. 30 Oct, 2013 1 commit
  7. 29 Oct, 2013 3 commits
  9. 28 Oct, 2013 4 commits
  11. 21 Oct, 2013 1 commit
    • commit-queue@webkit.org's avatar
      [CSS Regions] The layers from the flow thread should be collected under the regions' layers. · 83e19482
      commit-queue@webkit.org authored 
      https://bugs.webkit.org/show_bug.cgi?id=120457

Patch by Mihai Maerean <mmaerean@adobe.com> on 2013-10-21
Reviewed by David Hyatt.

Source/WebCore:

This patch is based on the work of Alexandru Chiculita at https://bugs.webkit.org/attachment.cgi?id=203872&action=review

The composited layers inside the named flow threads are collected as part of the regions (as children of the
GraphicsLayer of the layer that corresponds to the region (which is attached to the parent renderer of
RenderNameFlowFragment)).
When a region displays a layer that needs accelerated compositing we activate the accelerated compositing for
that region too (inside RenderLayerCompositor::computeRegionCompositingRequirements).

This patch has landed before (as http://trac.webkit.org/changeset/156451), but was reverted because
fast/multicol/mixed-positioning-stacking-order.html failed. The fix is inside RenderLayerCompositor::canBeComposited
that only enables compositing for layers inside flow threads that collect the graphics layers under the regions.

Another change from changeset #156451 is that now the region renderers are created as anonymous renderers under
the element that has the flow-from property. When a composited layer is needed for the region, it sits in it's
parent renderer, not in the region renderer (RenderNamedFlowFragment).

Tests: compositing/regions/crash-transform-inside-region.html
       compositing/regions/floated-region-with-transformed-child.html
       compositing/regions/move-layer-from-one-region-to-another.html
       compositing/regions/propagate-region-box-shadow-border-padding-for-video.html
       compositing/regions/propagate-region-box-shadow-border-padding.html
       compositing/regions/region-as-layer-in-another-flowthread.html
       compositing/regions/transform-transparent-positioned-video-inside-region.html
       compositing/regions/transformed-layer-inside-transformed-layer.html
       compositing/regions/z-index-update.html
       compositing/regions/z-index.html

* rendering/FlowThreadController.cpp:
(WebCore::FlowThreadController::updateRenderFlowThreadLayersIfNeeded):
* rendering/RenderElement.cpp:
(WebCore::RenderElement::propagateStyleToAnonymousChildren): Not for RenderFlowThreads, as they are updated
through the RenderView::styleDidChange function.
* rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::layout): When the layout of the flow thread is over (including the 2 phase layout),
we update all the mappings between the layers inside the flow thread and the regions where those layers will be
painted.
(WebCore::RenderFlowThread::hasCompositingRegionDescendant): Whether any of the regions has a compositing descendant.
(WebCore::RenderFlowThread::getLayerListForRegion):
(WebCore::RenderFlowThread::regionForCompositedLayer):
(WebCore::RenderFlowThread::cachedRegionForCompositedLayer):
(WebCore::RenderFlowThread::collectsGraphicsLayersUnderRegions):
(WebCore::RenderFlowThread::updateLayerToRegionMappings): Triggers an update of the layers if a layer has moved
from a region to another since the last update.
(WebCore::RenderFlowThread::updateAllLayerToRegionMappings):
* rendering/RenderFlowThread.h:
* rendering/RenderGeometryMap.cpp:
(WebCore::RenderGeometryMap::pushRenderFlowThread):
* rendering/RenderGeometryMap.h:
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paintList):
(WebCore::RenderLayer::enclosingFlowThreadAncestor):
(WebCore::RenderLayer::isFlowThreadCollectingGraphicsLayersUnderRegions):
(WebCore::RenderLayer::hitTestList):
(WebCore::RenderLayer::calculateLayerBounds): When we calculate the bounds of the RenderView, we ignore those
flow threads that collect the graphics layers under the regions.
(WebCore::RenderLayer::dirtyZOrderLists):
(WebCore::RenderLayer::dirtyNormalFlowList):
* rendering/RenderLayer.h:
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::shouldClipCompositedBounds): Not if it's a flow thread that collects the graphics
layers under the regions
(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry): Now adjusts the ancestorCompositingBounds for the FlowThread.
(WebCore::RenderLayerBacking::adjustAncestorCompositingBoundsForFlowThread): Make sure that the region propagates
its borders, paddings, outlines or box-shadows to layers inside it.
(WebCore::RenderLayerBacking::isSimpleContainerCompositingLayer):
* rendering/RenderLayerBacking.h:
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::computeCompositingRequirements): Now calls computeRegionCompositingRequirements.
(WebCore::RenderLayerCompositor::computeRegionCompositingRequirements):
(WebCore::RenderLayerCompositor::rebuildCompositingLayerTree): Do not iterate the RenderFlowThread directly if
we are going to collect the composited layers as part of regions.
(WebCore::RenderLayerCompositor::rebuildRegionCompositingLayerTree):
(WebCore::RenderLayerCompositor::canBeComposited): CSS Regions flow threads do not need to be composited as we
use composited RenderRegions to render the background of the RenderFlowThread.
(WebCore::RenderLayerCompositor::requiresCompositingForIndirectReason): If it's a container of a css region.
* rendering/RenderLayerCompositor.h:
* rendering/RenderMultiColumnSet.cpp:
(WebCore::RenderMultiColumnSet::adjustRegionBoundsFromFlowThreadPortionRect):
* rendering/RenderMultiColumnSet.h:
* rendering/RenderNamedFlowFragment.h:
(WebCore::RenderNamedFlowFragment::layerOwner): When the content inside the region requires the region to have a
layer, the layer will be created on the region's parent renderer instead. This method returns that renderer
holding the layer. The return value may be null.
* rendering/RenderNamedFlowThread.cpp:
(WebCore::RenderNamedFlowThread::RenderNamedFlowThread):
(WebCore::RenderNamedFlowThread::nextRendererForNode):
(WebCore::RenderNamedFlowThread::previousRendererForNode):
(WebCore::RenderNamedFlowThread::addFlowChild):
(WebCore::RenderNamedFlowThread::removeFlowChild):
(WebCore::RenderNamedFlowThread::collectsGraphicsLayersUnderRegions):
* rendering/RenderNamedFlowThread.h: m_flowThreadChildList is now allocated through an OwnPtr to keep the render
arena under the size limit.
* rendering/RenderRegion.cpp:
(WebCore::RenderRegion::adjustRegionBoundsFromFlowThreadPortionRect):
* rendering/RenderRegion.h:
(WebCore::toRenderRegion):
* rendering/RenderTreeAsText.cpp:
(WebCore::writeLayers):
* WebCore.exp.in: WebCore::RenderLayer::isFlowThreadCollectingGraphicsLayersUnderRegions

LayoutTests:

* compositing/regions/crash-transform-inside-region-expected.html: Added.
* compositing/regions/crash-transform-inside-region.html: Added.
* compositing/regions/floated-region-with-transformed-child-expected.html: Added.
* compositing/regions/floated-region-with-transformed-child.html: Added.
* compositing/regions/move-layer-from-one-region-to-another-expected.html: Added.
* compositing/regions/move-layer-from-one-region-to-another.html: Added.
* compositing/regions/propagate-region-box-shadow-border-padding-expected.html: Added.
* compositing/regions/propagate-region-box-shadow-border-padding-for-video-expected.html: Added.
* compositing/regions/propagate-region-box-shadow-border-padding-for-video.html: Added.
* compositing/regions/propagate-region-box-shadow-border-padding.html: Added.
* compositing/regions/region-as-layer-in-another-flowthread-expected.html: Added.
* compositing/regions/region-as-layer-in-another-flowthread.html: Added.
* compositing/regions/transform-transparent-positioned-video-inside-region-expected.html: Added.
* compositing/regions/transform-transparent-positioned-video-inside-region.html: Added.
* compositing/regions/transformed-layer-inside-transformed-layer-expected.html: Added.
* compositing/regions/transformed-layer-inside-transformed-layer.html: Added.
* compositing/regions/webkit-flow-renderer-layer-compositing-expected.html:
* compositing/regions/webkit-flow-renderer-layer-compositing.html:
* compositing/regions/z-index-expected.html: Added.
* compositing/regions/z-index-update-expected.html: Added.
* compositing/regions/z-index-update.html: Added.
* compositing/regions/z-index.html: Added.
* fast/multicol/mixed-positioning-stacking-order-expected.html:
* fast/multicol/mixed-positioning-stacking-order.html:
* fast/repaint/region-painting-composited-element-expected.html:
* fast/repaint/region-painting-composited-element.html:
* platform/mac-wk2/TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@157725 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      83e19482
  13. 19 Oct, 2013 1 commit
    • ap@apple.com's avatar
      Enable webaudio/ tests on DRT/Mac · bafddf47
      ap@apple.com authored 
      https://bugs.webkit.org/show_bug.cgi?id=86914

Reviewed by Darin Adler.

Tools: 

* DumpRenderTree/ForwardingHeaders/runtime/ArrayBufferView.h: Copied from Source/WebCore/ForwardingHeaders/runtime/ArrayBufferView.h.
* DumpRenderTree/ForwardingHeaders/runtime/JSArrayBufferView.h: Copied from Source/WebCore/ForwardingHeaders/runtime/JSArrayBufferView.h.
* DumpRenderTree/ForwardingHeaders/runtime/TypedArrayInlines.h: Copied from Source/WebCore/ForwardingHeaders/runtime/TypedArrayInlines.h.
There is no way to efficiently get TypedArray buffer using API, so we need some internal headers.

* DumpRenderTree/TestRunner.cpp:
(setAudioResultCallback): 
(TestRunner::staticFunctions):
* DumpRenderTree/TestRunner.h:
(TestRunner::audioResult):
(TestRunner::setAudioResult):
The function has a different name and argument type now, updated accordingly.
Changed buffer from std::string to std::vector<char>, because it's more idiomatic.

* DumpRenderTree/mac/DumpRenderTree.mm:
(dumpAudio): Updated for the new name of audioResult accessor.
(dump): Print the result in the format webkitpy currently expects.

* WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::dumpAudio): fwrite the whole block at once, splitting into
chunks made no sense.

* WebKitTestRunner/InjectedBundle/TestRunner.cpp:
(WTR::TestRunner::setAudioResult): Added a FIXME about getting off WKBundle SPI.

* DumpRenderTree/CMakeLists.txt: Added JavaScriptCore/parser to include search list,
so that "SourceProvider.h" can be found.

LayoutTests: 

* TestExpectations: Moved webaudio/javascriptaudionode here, as garbage collection
issues with it are cross-platform.

* platform/mac-wk2/TestExpectations: Moved out everything, as there is nothing
WK2 specific about WebAudio.

* platform/mac/TestExpectations: WebAudio expectations here were just ignored. Replaced
with slightly updated expectations from WK2.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@157691 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bafddf47
  15. 10 Oct, 2013 1 commit
    • commit-queue@webkit.org's avatar
      Web Inspector: Remove the old front-end from WebKit · ff84fc40
      commit-queue@webkit.org authored 
      https://bugs.webkit.org/show_bug.cgi?id=122295

Patch by Marcelo Morais <m.morais@samsung.com> on 2013-10-10
Reviewed by Timothy Hatcher.

Skipping the tests of the old Inspector UI for all ports.

* TestExpectations:
* platform/efl-wk1/TestExpectations:
* platform/efl-wk2/TestExpectations:
* platform/efl/TestExpectations:
* platform/gtk-wk1/TestExpectations:
* platform/gtk/TestExpectations:
* platform/mac-lion/TestExpectations:
* platform/mac-wk2/TestExpectations:
* platform/mac/TestExpectations:
* platform/win-xp/TestExpectations:
* platform/win/TestExpectations:
* platform/wincairo/TestExpectations:
* platform/wk2/TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@157246 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ff84fc40
  17. 08 Oct, 2013 2 commits
  19. 07 Oct, 2013 1 commit
  21. 04 Oct, 2013 1 commit
    • g.czajkowski@samsung.com's avatar
      Tests added in r141354 erroneously assume correction suggestion to be in the context menu · d1836068
      g.czajkowski@samsung.com authored 
      https://bugs.webkit.org/show_bug.cgi?id=113742

Reviewed by Ryosuke Niwa.

Tests from r141354 erroneously assume that all WebKit ports populate
spell checking suggestion in the context menu.

Remove verification of spell checking suggestion and all context menu stuff from tests
that do that unnecessarily. Instead of that check whether spelling markers behave correctly,
for example, after deleting a text, double click or selecting a misspellings.

However, two tests are adapted to verify spell checking suggestions (their availability
rather than correctness, similarly to context-menu-suggestions.html).
Those are useful for ports which populate spelling suggestion in the context menu.

* editing/spelling/resources/util.js:
(initSpellTest):
Do not assume that the tests are running with "Windows" editing behavior.
Unix ports do not make a selection for the misspelled word and they don't
require selection to get spell checking suggestions.

* editing/spelling/spelling-changed-text-expected.txt:
* editing/spelling/spelling-changed-text.html:
* editing/spelling/spelling-double-clicked-word-expected.txt:
* editing/spelling/spelling-double-clicked-word.html:
* editing/spelling/spelling-exactly-selected-word-expected.txt:
* editing/spelling/spelling-exactly-selected-word.html:
Remove verification of correction suggestion.
Instead of that check whether the spelling markers behave correctly.

* editing/spelling/context-menu-suggestions-multiword-selection-expected.txt: Renamed from LayoutTests/editing/spelling/spelling-multiword-selection-expected.txt.
* editing/spelling/context-menu-suggestions-multiword-selection.html: Renamed from LayoutTests/editing/spelling/spelling-multiword-selection.html.
* editing/spelling/context-menu-suggestions-subword-selection-expected.txt: Renamed from LayoutTests/editing/spelling/spelling-subword-selection-expected.txt.
* editing/spelling/context-menu-suggestions-subword-selection.html: Renamed from LayoutTests/editing/spelling/spelling-subword-selection.html.
Adapt those tests for platforms which populate spell check suggestion
in the context menu.

* platform/efl-wk2/TestExpectations:
Now context-menu-suggestions-multiword-selection.html and
context-menu-suggestions-subword-selection.html are passing for EFL.

* platform/gtk-wk2/TestExpectations:
* platform/gtk/TestExpectations:
* platform/mac-wk2/TestExpectations:
* platform/win/TestExpectations:
* platform/wincairo/TestExpectations:
Update tests path due to rename.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156901 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d1836068
  23. 03 Oct, 2013 1 commit
  25. 02 Oct, 2013 2 commits
    • timothy_horton@apple.com's avatar
      [mac] Stop using DrawingAreaImpl on PLATFORM(MAC) · 5251cbd5
      timothy_horton@apple.com authored 
      https://bugs.webkit.org/show_bug.cgi?id=121859
<rdar://problem/15069359>

Reviewed by Anders Carlsson.

The Mac port will now use tiled drawing for all WebKit2 views.

* Shared/DrawingAreaInfo.h:
Don't include DrawingAreaTypeImpl as a valid DrawingAreaType on Mac.

* UIProcess/API/mac/WKView.mm:
(-[WKView drawRect:]):
Remove our implementation of drawRect that paints from DrawingAreaImpl's backing store.

(-[WKView _shouldUseTiledDrawingArea]):
Removed. Always treated as if it were true, now.

(-[WKView _createDrawingAreaProxy]):
Always create a TiledCoreAnimationDrawingAreaProxy now.

(-[WKView initWithFrame:contextRef:pageGroupRef:relatedToPage:]):
(-[WKView wantsUpdateLayer]):
WKView always wants a layer, etc.

* UIProcess/BackingStore.h:
Remove Mac-specific BackingStore code, only used for DrawingAreaImpl on Mac.

* UIProcess/DrawingAreaProxy.h:
Remove an unneeded include.

* UIProcess/mac/BackingStoreMac.mm: Removed.
* WebKit2.xcodeproj/project.pbxproj:
Remove a bunch of files we don't need to build anymore.

* WebProcess/WebPage/DrawingArea.cpp:
(WebKit::DrawingArea::create):
Never create a DrawingAreaImpl on Mac.

* WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::updatePreferences):
(WebKit::DrawingAreaImpl::resumePainting):
* WebProcess/WebPage/DrawingAreaImpl.h:
Remove Mac-specific DrawingAreaImpl code.

* WebProcess/WebPage/LayerTreeHost.cpp:
(WebKit::LayerTreeHost::create):
* WebProcess/WebPage/mac/LayerTreeHostMac.h: Removed.
* WebProcess/WebPage/mac/LayerTreeHostMac.mm: Removed.

* page/FrameView.cpp:
(WebCore::FrameView::addTrackedRepaintRect):
(WebCore::FrameView::repaintContentRectangle):
* page/FrameView.h:
Factor out the coordinate conversion and appending of new repaint rects on FrameView.

* platform/graphics/GraphicsLayer.cpp:
(WebCore::GraphicsLayer::dumpProperties):
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::shouldDumpPropertyForLayer):
Don't dump repaint rects on the root tile cache, they'll be included at the top,
where FrameView's repaints are normally included.

* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::setContentsNeedDisplay):
(WebCore::RenderLayerBacking::setContentsNeedDisplayInRect):
Push the root tile cache's tracked repaint rects to FrameView instead.

* WebKitTestRunner/TestInvocation.cpp:
(WTR::shouldUseThreadedScrolling):
(WTR::updateThreadedScrollingForCurrentTest):
(WTR::TestInvocation::invoke):
* WebKitTestRunner/mac/PlatformWebViewMac.mm:
(-[TestRunnerWKView initWithFrame:contextRef:pageGroupRef:relatedToPage:useThreadedScrolling:]):
(WTR::PlatformWebView::PlatformWebView):
(WTR::PlatformWebView::viewSupportsOptions):
Rename the tiled drawing switch to threaded scrolling, since that's really
all it switches now that we use tiled drawing everywhere.

Use an unbuffered window, as well, to avoid snapshotting issues on some platforms
and to more closely match the case we're interested in testing.

* platform/mac-wk2/TestExpectations:

* platform/mac-wk2/compositing/contents-opaque/body-background-painted-expected.txt: Added.
* platform/mac-wk2/compositing/contents-opaque/body-background-skipped-expected.txt: Added.
* platform/mac-wk2/compositing/rtl/rtl-absolute-expected.txt: Added.
* platform/mac-wk2/compositing/rtl/rtl-absolute-overflow-expected.txt: Added.
* platform/mac-wk2/compositing/rtl/rtl-absolute-overflow-scrolled-expected.txt: Added.
Add WebKit2 results, because we dump non-white background color on the root layer now.

* platform/mac-wk2/compositing/repaint/fixed-background-scroll-expected.txt: Added.
New WebKit2 result; repaint rects are showing up now.

* platform/mac-wk2/compositing/rtl/rtl-fixed-expected.txt:
* platform/mac-wk2/compositing/rtl/rtl-fixed-overflow-expected.txt:
Slightly adjusted results.

* platform/mac-wk2/compositing/tiling/rotated-tiled-clamped-expected.txt: Added.
* platform/mac-wk2/compositing/tiling/rotated-tiled-preserve3d-clamped-expected.txt: Added.
* platform/mac-wk2/compositing/tiling/tile-cache-zoomed-expected.txt: Added.
* platform/mac-wk2/compositing/tiling/tiled-layer-resize-expected.txt: Added.
New WebKit2 results; we show the root tile cache if layerTreeAsText is asked to dump tile caches.

* platform/mac-wk2/editing/input/caret-at-the-edge-of-contenteditable-expected.txt: Added.
* platform/mac-wk2/editing/input/reveal-caret-of-multiline-contenteditable-expected.txt: Added.
* platform/mac-wk2/fast/block/basic/020-expected.txt: Added.
* platform/mac-wk2/fast/dynamic/012-expected.txt: Added.
* platform/mac-wk2/fast/dynamic/layer-hit-test-crash-expected.txt: Added.
* platform/mac-wk2/fast/repaint/layer-hide-when-needs-layout-expected.txt: Added.
* platform/mac-wk2/fast/text/whitespace/028-expected.txt: Added.
* platform/mac-wk2/fast/layers/layer-visibility-expected.txt: Added.
* platform/mac-wk2/fast/layers/layer-visibility-sublayer-expected.txt: Added.
* platform/mac-wk2/fast/repaint/invisible-objects-expected.txt: Added.
New WebKit2 results; additional compositing layers.

* platform/mac-wk2/tiled-drawing/window-server-snapshots-work-expected-mismatch.html: Added.
* platform/mac-wk2/tiled-drawing/window-server-snapshots-work.html: Added.
New test to ensure that window-server snapshots work with tiled drawing.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156793 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5251cbd5
    • commit-queue@webkit.org's avatar
      [CSS Regions] Activate all regions to have layers, as CSS Regions create a new stacking context · df35f20a
      commit-queue@webkit.org authored 
      https://bugs.webkit.org/show_bug.cgi?id=121828

Patch by Mihai Maerean <mmaerean@adobe.com> on 2013-10-02
Reviewed by Darin Adler.

Source/WebCore:

The CSS Regions specification says "CSS Regions create a new stacking context." (http://dev.w3.org/csswg/css-regions/).

Divs that create stacking contexts are painted after the divs that don't create stacking contexts.

Test: fast/regions/layers/stacking-context-paint-order.html: While the existing region-sibling-paint-order.html
test verifies that regions paint correctly when the next sibling also creates a stacking context, this new test
verifies that regions paint correctly when the next sibling doesn't create a stacking context.

* rendering/RenderBlock.cpp: Remove code that is not needed now that all regions have layers.
* rendering/RenderBlock.h: Remove code that is not needed now that all regions have layers.
* rendering/RenderBox.cpp: Remove code that is not needed now that all regions have layers.
* rendering/RenderBox.h: Remove code that is not needed now that all regions have layers.
* rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::updateLayerToRegionMappings): Remove code that is not needed now that all regions have layers.
* rendering/RenderRegion.cpp:
(WebCore::RenderRegion::RenderRegion):
* rendering/RenderRegion.h:
(WebCore::RenderRegion::requiresLayer): Always. CSS Regions create Stacking Contexts. RenderMultiColumnSet
implements its own behaviour so the behaviour of each class is contained within its own files.
* rendering/RenderMultiColumnSet.h:
(WebCore::RenderMultiColumnSet::requiresLayer): RenderMultiColumnSet derives from RenderRegion, but unlike the
CSS Regions specification, the Multi-Columns CSS specification states that the column boxes do not establish new
Stacking Contexts.
* rendering/RenderTreeAsText.cpp:
(WebCore::writeRenderRegionList): There's no need to output " hasLayer" since all regions now have layers.

LayoutTests:

For the ref tests, the divs in the expected results coresponding to the regions now have a CSS style causing
them to also create Stacking Contexts.

Most of the tests in fast/regions/layers/ have been deleted because they aren't relevant anymore.

The change in most of the *-expected.txt files is that the " hasLayer" part has been removed (since all regions
now have layers).

Platform (efl, efl-wk2, gtk, mac-lion, mac-wk2, qt, qt-wk2) specific expectated results need to be generated again.

* fast/regions/autoheight-regions-mark-expected.txt:
* fast/regions/flow-content-basic-expected.html: Added. The test is now a ref test.
* fast/regions/flow-content-basic-vertical-expected.html: Added. The test is now a ref test.
* fast/regions/flow-content-basic-vertical-rl-expected.html: Added.The test is now a ref test.
* fast/regions/flow-content-basic-vertical-rl.html:
* fast/regions/flow-content-basic-vertical.html:
* fast/regions/flow-content-basic.html:
* fast/regions/flows-dependency-dynamic-remove-expected.txt:
* fast/regions/flows-dependency-same-flow-expected.txt:
* fast/regions/layers/dynamic-layer-added-with-no-layout-expected.png: Removed.
* fast/regions/layers/dynamic-layer-added-with-no-layout-expected.txt: Removed.
* fast/regions/layers/dynamic-layer-added-with-no-layout.html: Removed.
* fast/regions/layers/dynamic-layer-removed-with-no-layout-expected.png: Removed.
* fast/regions/layers/dynamic-layer-removed-with-no-layout-expected.txt: Removed.
* fast/regions/layers/dynamic-layer-removed-with-no-layout.html: Removed.
* fast/regions/layers/regions-promoted-to-layers-expected.png: Removed.
* fast/regions/layers/regions-promoted-to-layers-expected.txt: Removed.
* fast/regions/layers/regions-promoted-to-layers-horizontal-bt-expected.png: Removed.
* fast/regions/layers/regions-promoted-to-layers-horizontal-bt-expected.txt: Removed.
* fast/regions/layers/regions-promoted-to-layers-horizontal-bt.html: Removed.
* fast/regions/layers/regions-promoted-to-layers-vertical-lr-expected.png: Removed.
* fast/regions/layers/regions-promoted-to-layers-vertical-lr-expected.txt: Removed.
* fast/regions/layers/regions-promoted-to-layers-vertical-lr.html: Removed.
* fast/regions/layers/regions-promoted-to-layers-vertical-rl-expected.png: Removed.
* fast/regions/layers/regions-promoted-to-layers-vertical-rl-expected.txt: Removed.
* fast/regions/layers/regions-promoted-to-layers-vertical-rl.html: Removed.
* fast/regions/layers/regions-promoted-to-layers.html: Removed.
* fast/regions/layers/stacking-context-paint-order-expected.html: Added.
* fast/regions/layers/stacking-context-paint-order.html: Added. While the existing region-sibling-paint-order.html
test verifies that regions paint correctly when the next sibling also creates a stacking context, this new test
verifies that regions paint correctly when the next sibling doesn't create a stacking context.
* fast/regions/region-sibling-paint-order-expected.html:
* fast/regions/region-sibling-paint-order.html:
* fast/repaint/overflow-flipped-writing-mode-block-in-regions-expected.txt:
* fast/repaint/region-painting-composited-element-expected.html:
* fast/repaint/region-painting-in-composited-view-expected.html:
* fast/repaint/region-painting-in-composited-view.html:
* fast/repaint/region-painting-via-layout-expected.txt:
* platform/efl-wk2/TestExpectations:
* platform/efl-wk2/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png: Removed.
* platform/efl-wk2/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt: Removed.
* platform/efl/TestExpectations:
* platform/efl/fast/regions/autoheight-regions-mark-expected.png: Removed.
* platform/efl/fast/regions/autoheight-regions-mark-expected.txt: Removed.
* platform/efl/fast/regions/flow-content-basic-expected.png: Removed. The test is now a ref test.
* platform/efl/fast/regions/flow-content-basic-expected.txt: Removed.
* platform/efl/fast/regions/flow-content-basic-vertical-expected.png: Removed.
* platform/efl/fast/regions/flow-content-basic-vertical-expected.txt: Removed.
* platform/efl/fast/regions/flow-content-basic-vertical-rl-expected.png: Removed.
* platform/efl/fast/regions/flow-content-basic-vertical-rl-expected.txt: Removed.
* platform/efl/fast/regions/flows-dependency-dynamic-remove-expected.png: Removed.
* platform/efl/fast/regions/flows-dependency-dynamic-remove-expected.txt: Removed.
* platform/efl/fast/regions/multiple-directionality-changes-in-variable-width-regions-expected.png: Removed.
* platform/efl/fast/regions/multiple-directionality-changes-in-variable-width-regions-expected.txt: Removed.
* platform/efl/fast/regions/region-dynamic-after-before-expected.txt:
* platform/efl/fast/regions/region-generated-content-before-after-expected.txt:
* platform/efl/fast/regions/text-region-split-small-pagination-expected.png: Removed.
* platform/efl/fast/regions/text-region-split-small-pagination-expected.txt: Removed.
* platform/efl/fast/regions/top-overflow-out-of-second-region-expected.png: Removed.
* platform/efl/fast/regions/top-overflow-out-of-second-region-expected.txt: Removed.
* platform/efl/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png: Removed.
* platform/efl/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt: Removed.
* platform/efl/fast/repaint/region-painting-invalidation-expected.png: Removed.
* platform/efl/fast/repaint/region-painting-invalidation-expected.txt: Removed.
* platform/efl/fast/repaint/region-painting-via-layout-expected.png: Removed.
* platform/efl/fast/repaint/region-painting-via-layout-expected.txt: Removed.
* platform/gtk/TestExpectations:
* platform/gtk/fast/regions/autoheight-regions-mark-expected.png: Removed.
* platform/gtk/fast/regions/autoheight-regions-mark-expected.txt: Removed.
* platform/gtk/fast/regions/flow-content-basic-expected.png: Removed.
* platform/gtk/fast/regions/flow-content-basic-expected.txt: Removed.
* platform/gtk/fast/regions/flow-content-basic-vertical-expected.png: Removed.
* platform/gtk/fast/regions/flow-content-basic-vertical-expected.txt: Removed.
* platform/gtk/fast/regions/flow-content-basic-vertical-rl-expected.png: Removed.
* platform/gtk/fast/regions/flow-content-basic-vertical-rl-expected.txt: Removed.
* platform/gtk/fast/regions/flows-dependency-dynamic-remove-expected.png: Removed.
* platform/gtk/fast/regions/flows-dependency-dynamic-remove-expected.txt: Removed.
* platform/gtk/fast/regions/multiple-directionality-changes-in-variable-width-regions-expected.png: Removed.
* platform/gtk/fast/regions/multiple-directionality-changes-in-variable-width-regions-expected.txt: Removed.
* platform/gtk/fast/regions/region-dynamic-after-before-expected.txt:
* platform/gtk/fast/regions/region-generated-content-before-after-expected.txt:
* platform/gtk/fast/regions/text-region-split-small-pagination-expected.png: Removed.
* platform/gtk/fast/regions/text-region-split-small-pagination-expected.txt: Removed.
* platform/gtk/fast/regions/top-overflow-out-of-second-region-expected.png: Removed.
* platform/gtk/fast/regions/top-overflow-out-of-second-region-expected.txt: Removed.
* platform/gtk/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png: Removed.
* platform/gtk/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt: Removed.
* platform/gtk/fast/repaint/line-flow-with-floats-in-regions-expected.txt:
* platform/gtk/fast/repaint/overflow-flipped-writing-mode-block-in-regions-expected.txt:
* platform/gtk/fast/repaint/region-painting-invalidation-expected.png: Removed.
* platform/gtk/fast/repaint/region-painting-invalidation-expected.txt: Removed.
* platform/gtk/fast/repaint/region-painting-via-layout-expected.png: Removed.
* platform/gtk/fast/repaint/region-painting-via-layout-expected.txt: Removed.
* platform/mac-lion/TestExpectations:
* platform/mac-lion/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png: Removed.
* platform/mac-lion/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt: Removed.
* platform/mac-wk2/TestExpectations:
* platform/mac/fast/regions/flow-content-basic-expected.png: Removed.
* platform/mac/fast/regions/flow-content-basic-expected.txt: Removed.
* platform/mac/fast/regions/flow-content-basic-vertical-expected.png: Removed.
* platform/mac/fast/regions/flow-content-basic-vertical-expected.txt: Removed.
* platform/mac/fast/regions/flow-content-basic-vertical-rl-expected.png: Removed.
* platform/mac/fast/regions/flow-content-basic-vertical-rl-expected.txt: Removed.
* platform/mac/fast/regions/multiple-directionality-changes-in-variable-width-regions-expected.txt:
* platform/mac/fast/regions/region-dynamic-after-before-expected.txt:
* platform/mac/fast/regions/region-generated-content-before-after-expected.txt:
* platform/mac/fast/regions/text-region-split-small-pagination-expected.txt:
* platform/mac/fast/regions/top-overflow-out-of-second-region-expected.txt:
* platform/mac/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png: Removed.
* platform/mac/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt:
* platform/mac/fast/repaint/line-flow-with-floats-in-regions-expected.txt:
* platform/mac/fast/repaint/region-painting-invalidation-expected.txt:
* platform/qt-wk2/TestExpectations:
* platform/qt-wk2/fast/regions/flow-content-basic-expected.png: Removed.
* platform/qt-wk2/fast/regions/flow-content-basic-vertical-expected.png: Removed.
* platform/qt-wk2/fast/regions/flow-content-basic-vertical-rl-expected.png: Removed.
* platform/qt-wk2/fast/regions/multiple-directionality-changes-in-variable-width-regions-expected.png: Removed.
* platform/qt-wk2/fast/regions/text-region-split-small-pagination-expected.png: Removed.
* platform/qt-wk2/fast/regions/top-overflow-out-of-second-region-expected.png: Removed.
* platform/qt-wk2/fast/repaint/region-painting-invalidation-expected.png: Removed.
* platform/qt-wk2/fast/repaint/region-painting-invalidation-expected.txt: Removed.
* platform/qt-wk2/fast/repaint/region-painting-via-layout-expected.png: Removed.
* platform/qt/TestExpectations:
* platform/qt/fast/regions/autoheight-regions-mark-expected.png: Removed.
* platform/qt/fast/regions/autoheight-regions-mark-expected.txt: Removed.
* platform/qt/fast/regions/flow-content-basic-expected.png: Removed.
* platform/qt/fast/regions/flow-content-basic-expected.txt: Removed.
* platform/qt/fast/regions/flow-content-basic-vertical-expected.png: Removed.
* platform/qt/fast/regions/flow-content-basic-vertical-expected.txt: Removed.
* platform/qt/fast/regions/flow-content-basic-vertical-rl-expected.png: Removed.
* platform/qt/fast/regions/flow-content-basic-vertical-rl-expected.txt: Removed.
* platform/qt/fast/regions/flows-dependency-dynamic-remove-expected.png: Removed.
* platform/qt/fast/regions/flows-dependency-dynamic-remove-expected.txt: Removed.
* platform/qt/fast/regions/multiple-directionality-changes-in-variable-width-regions-expected.png: Removed.
* platform/qt/fast/regions/multiple-directionality-changes-in-variable-width-regions-expected.txt: Removed.
* platform/qt/fast/regions/text-region-split-small-pagination-expected.png: Removed.
* platform/qt/fast/regions/text-region-split-small-pagination-expected.txt: Removed.
* platform/qt/fast/regions/top-overflow-out-of-second-region-expected.png: Removed.
* platform/qt/fast/regions/top-overflow-out-of-second-region-expected.txt: Removed.
* platform/qt/fast/repaint/line-flow-with-floats-in-regions-expected.txt:
* platform/qt/fast/repaint/overflow-flipped-writing-mode-block-in-regions-expected.txt:
* platform/qt/fast/repaint/region-painting-invalidation-expected.png: Removed.
* platform/qt/fast/repaint/region-painting-invalidation-expected.txt: Removed.
* platform/qt/fast/repaint/region-painting-via-layout-expected.png: Removed.
* platform/qt/fast/repaint/region-painting-via-layout-expected.txt: Removed.
* platform/win/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png: Removed.
* platform/win/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156767 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      df35f20a
  27. 24 Sep, 2013 1 commit
  29. 18 Sep, 2013 1 commit
  31. 17 Sep, 2013 1 commit
  33. 28 Aug, 2013 1 commit
    • rniwa@webkit.org's avatar
      <https://webkit.org/b/119806> [Mac] Add a way to easily test attributed string generation · cb1d0344
      rniwa@webkit.org authored 
      Reviewed by Darin Adler.

Tools: 

Add textInputController.legacyAttributedString to retrieve the attributed string for copy & paste.

We can't use textInputController.attributedSubstringFromRange as it uses WebHTMLConverter's static
editingAttributedStringFromRange function, which doesn't implement the full converter at the moment.

Also NSMutableAttributedString.ranges and WebNSRange so that JavaScript can get a list of all
ranges in a given attributed string.

* DumpRenderTree/mac/TextInputController.m:
(-[WebNSRange initWithNSRange:]):
(-[WebNSRange location]):
(-[WebNSRange length]):
(+[WebNSRange isSelectorExcludedFromWebScript:]):
(+[NSMutableAttributedString isSelectorExcludedFromWebScript:]):
(+[NSMutableAttributedString webScriptNameForSelector:]):
(-[NSMutableAttributedString ranges]): Added.
(+[TextInputController isSelectorExcludedFromWebScript:]):
(+[TextInputController webScriptNameForSelector:]):
(-[TextInputController legacyAttributedString:]):

LayoutTests: 

Add basic tests for textInputController.legacyAttributedString.

* platform/mac-wk2/TestExpectations:
* platform/mac/editing/attributed-string: Added.
* platform/mac/editing/attributed-string/anchor-element-expected.txt: Added.
* platform/mac/editing/attributed-string/anchor-element.html: Added.
* platform/mac/editing/attributed-string/basic-expected.txt: Added.
* platform/mac/editing/attributed-string/basic.html: Added.
* platform/mac/editing/attributed-string/font-size-expected.txt: Added.
* platform/mac/editing/attributed-string/font-size.html: Added.
* platform/mac/editing/attributed-string/font-style-variant-effect-expected.txt: Added.
* platform/mac/editing/attributed-string/font-style-variant-effect.html: Added.
* platform/mac/editing/attributed-string/font-weight-expected.txt: Added.
* platform/mac/editing/attributed-string/font-weight.html: Added.
* platform/mac/editing/attributed-string/letter-spacing-expected.txt: Added.
* platform/mac/editing/attributed-string/letter-spacing.html: Added.
* platform/mac/editing/attributed-string/resources: Added.
* platform/mac/editing/attributed-string/resources/dump-attributed-string.js: Added.
(.):
* platform/mac/editing/attributed-string/text-decorations-expected.txt: Added.
* platform/mac/editing/attributed-string/text-decorations.html: Added.
* platform/mac/editing/attributed-string/vertical-align-expected.txt: Added.
* platform/mac/editing/attributed-string/vertical-align.html: Added.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154803 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cb1d0344
  35. 26 Aug, 2013 1 commit
  37. 22 Aug, 2013 2 commits
  39. 21 Aug, 2013 2 commits
  41. 19 Aug, 2013 1 commit
    • ap@apple.com's avatar
      https://bugs.webkit.org/show_bug.cgi?id=119915 · 3503443f
      ap@apple.com authored 
      REGRESSION(r154144): ASSERTION FAILED: m_history->provisionalItem() == m_requestedHistoryItem.get()

Reviewed by Darin Adler.

Tools:

The issue was that we ended up having no CFNetwork cache in the testing session due
to an incorrect cache model. There is a number of things not implemented when it
comes to dynamically changing cache model as attempted by WebKitTestRunner, but
the easiest way to get this going is to initialize it to correct value upfront.

* WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):

LayoutTests:

* platform/mac-wk2/TestExpectations: Unskipping the failing test.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154301 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3503443f
  43. 16 Aug, 2013 2 commits
  45. 12 Aug, 2013 1 commit
  47. 03 Aug, 2013 1 commit
  49. 02 Aug, 2013 1 commit
  51. 01 Aug, 2013 1 commit
  53. 30 Jul, 2013 2 commits
  55. 23 Jul, 2013 1 commit
    • timothy_horton@apple.com's avatar
      Add a test for plug-in unavailability indicator obscurity detection · b0aa0e2d
      timothy_horton@apple.com authored 
      https://bugs.webkit.org/show_bug.cgi?id=119007

Reviewed by Anders Carlsson.

Test: plugins/unavailable-plugin-indicator-obscurity.html

Expose the ability to test whether the unavailable plugin indicator
is obscured via the internals object.

* testing/Internals.cpp:
(WebCore::Internals::isPluginUnavailabilityIndicatorObscured):
* testing/Internals.h:
* testing/Internals.idl:
Expose RenderEmbeddedObject::isReplacementObscured as
internals.isPluginUnavailabilityIndicatorObscured for testing purposes.

Expose the ability to block plug-ins via pluginLoadPolicy to testRunner.

* WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
* WebKitTestRunner/InjectedBundle/TestRunner.cpp:
(WTR::TestRunner::setBlockAllPlugins):
* WebKitTestRunner/InjectedBundle/TestRunner.h:
* WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
Add testRunner.setBlockAllPlugins function (and corresponding message to
forward it through to TestController).

* WebKitTestRunner/TestController.cpp:
Initialize m_shouldBlockAllPlugins to false (and drive-by initialize m_handlesAuthenticationChallenges).

(WTR::TestController::createWebViewWithOptions):
Register our pluginLoadPolicy callback.

(WTR::TestController::resetStateToConsistentValues):
Reset m_shouldBlockAllPlugins to false.

(WTR::TestController::pluginLoadPolicy):
Return the existing plugin load policy, unless setBlockAllPlugins(true)
was called, in which case we reject all plugins with kWKPluginLoadPolicyBlocked.

* WebKitTestRunner/TestController.h:
(WTR::TestController::setBlockAllPlugins):

Add a test that ensures that RenderEmbeddedObject accurately detects the
various different ways the unavailable plugin dialog can be obscured.

* platform/mac-wk2/TestExpectations:
* platform/mac/TestExpectations:
* plugins/unavailable-plugin-indicator-obscurity-expected.txt: Added.
* plugins/unavailable-plugin-indicator-obscurity.html: Added.

* Source/autotools/symbols.filter:
Expose RenderEmbeddedObject::isReplacementObscured to internals.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153054 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b0aa0e2d