- 15 Feb, 2011 40 commits
-
-
mrobinson@webkit.org authored
Continue importing GTK+ SVG test results. * platform/gtk/Skipped: Unskip tests which now have results. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78583 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
mnaganov@chromium.org authored
[Chromium] Unreviewed test expectations update. SKIP two Inspector tests (by pfeldman's request). git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78582 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
pfeldman@chromium.org authored
Reviewed by Yury Semikhatsky. Web Inspector: test whether inspector gets populated with databases and storages upon opening. https://bugs.webkit.org/show_bug.cgi?id=54469 * http/tests/inspector-enabled/database-open-expected.txt: Added. * http/tests/inspector-enabled/database-open.html: Added. * http/tests/inspector-enabled/dom-storage-open-expected.txt: Added. * http/tests/inspector-enabled/dom-storage-open.html: Added. 2011-02-15 Pavel Feldman <pfeldman@chromium.org> Reviewed by Yury Semikhatsky. Web Inspector: test whether inspector gets populated with databases and storages upon opening. https://bugs.webkit.org/show_bug.cgi?id=54469 Tests: http/tests/inspector-enabled/database-open.html http/tests/inspector-enabled/dom-storage-open.html * inspector/front-end/DOMStorage.js: * inspector/front-end/Database.js: (WebInspector.DatabaseDispatcher.prototype.addDatabase): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78581 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
andreas.kling@nokia.com authored
Reviewed by Darin Adler. Share the helper functions used by Latin-1 and UTF-8 text codecs https://bugs.webkit.org/show_bug.cgi?id=54446 Move MachineWord, UCharByteFiller and the other helper functions into TextCodecASCIIFastPath.h where they can be used by both TextCodecUTF8 and TextCodecLatin1. * GNUmakefile.am: * WebCore.gypi: * WebCore.pro: * WebCore.vcproj/WebCore.vcproj: * WebCore.xcodeproj/project.pbxproj: * platform/text/TextCodecASCIIFastPath.h: Added. (WebCore::isAllASCII): (WebCore::copyASCIIMachineWord): (WebCore::isAlignedToMachineWord): (WebCore::alignToMachineWord): * platform/text/TextCodecLatin1.cpp: (WebCore::TextCodecLatin1::decode): * platform/text/TextCodecUTF8.cpp: (WebCore::TextCodecUTF8::decode): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78580 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
mario@webkit.org authored
Unreviewed, rebaseline of Gtk result. * platform/gtk/fast/block/float/marquee-shrink-to-avoid-floats-expected.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78579 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
weinig@apple.com authored
Reviewed by Anders Carlsson. * Platform/mac/SharedMemoryMac.cpp: (WebKit::SharedMemory::create): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78578 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
mnaganov@chromium.org authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78577 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
pfeldman@chromium.org authored
Reviewed by Yury Semikhatsky. Web Inspector: implement DOM agent tests. https://bugs.webkit.org/show_bug.cgi?id=54459 * http/tests/inspector/elements-test.js: (initialize_ElementTest.InspectorTest.expandedNodeWithId.callback): (initialize_ElementTest.InspectorTest.expandedNodeWithId): (initialize_ElementTest.InspectorTest.dumpElementsTree): (initialize_ElementTest.InspectorTest.dumpElementsTree.print): (initialize_ElementTest.InspectorTest.expandElementsTree): (initialize_ElementTest.InspectorTest.expandElementsTree.mycallback): (initialize_ElementTest.InspectorTest.dumpDOMAgentTree): (initialize_ElementTest): * http/tests/inspector/extensions-resources-redirect-expected.txt: * http/tests/inspector/inspector-test.js: (initialize_InspectorTest.InspectorTest.addResult.clearResults): (initialize_InspectorTest.InspectorTest.runTestSuite.runner): (initialize_InspectorTest.InspectorTest.runTestSuite): (output): (clearOutput): * inspector/debugger/dom-breakpoints.html: * inspector/elements/elements-panel-limited-children-expected.txt: * inspector/elements/elements-panel-rewrite-href.html: * inspector/elements/elements-panel-structure-expected.txt: * inspector/elements/elements-panel-structure.html: * inspector/elements/elements-panel-xhtml-structure-expected.txt: * inspector/elements/elements-panel-xhtml-structure.xhtml: * inspector/elements/insert-node-collapsed-expected.txt: Added. * inspector/elements/insert-node-collapsed.html: Added. * inspector/elements/insert-node-expected.txt: Added. * inspector/elements/insert-node.html: Added. * inspector/elements/modify-chardata-expected.txt: Added. * inspector/elements/modify-chardata.html: Added. * inspector/elements/mutate-unknown-node-expected.txt: Added. * inspector/elements/mutate-unknown-node.html: Added. * inspector/elements/remove-node-expected.txt: Added. * inspector/elements/remove-node.html: Added. * inspector/elements/set-attribute.html: Added. * inspector/extensions/extensions-expected.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78576 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
Reviewed by Kent Tamura. Code style issue in WebCore/dom/InputElement.cpp https://bugs.webkit.org/show_bug.cgi?id=54428 Remove 2 extra spaces in InputElement.cpp line 221. Code style fix, No new tests. * dom/InputElement.cpp: (WebCore::InputElement::handleBeforeTextInsertedEvent): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78575 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
mnaganov@chromium.org authored
[Chromium] Unreviewed test expectations update. Mark svg/custom/use-css-no-effect-on-shadow-tree.svg as passing. Mark media/audio-delete-while-slider-thumb-clicked.html as timing out. https://bugs.webkit.org/show_bug.cgi?id=54472 git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78574 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
xan@webkit.org authored
Reviewed by Martin Robinson. Remove some dead code in ARMv7 https://bugs.webkit.org/show_bug.cgi?id=54461 * assembler/ARMv7Assembler.h: remove dead code. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78573 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
mario@webkit.org authored
Unreviewed, test crashing because of failing ASSERT on GTK 64-bit debug bot. [GTK] svg/text/select-textLength-spacing-squeeze-1.svg crashes due to ASSERT failing https://bugs.webkit.org/show_bug.cgi?id=54470 * platform/gtk/Skipped: Skipped test. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78572 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
philn@webkit.org authored
Reviewed by Martin Robinson. [GStreamer] Video player sets system volume to 100% https://bugs.webkit.org/show_bug.cgi?id=54140 Don't explicitely set volume at startup and use the GstStreamVolume interface with cubic volume scale when updating/retrieving the volume value. This gives a much better user-experience. * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78571 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
Reviewed by Andreas Kling. [Gtk] Cleanup in the canvas tests https://bugs.webkit.org/show_bug.cgi?id=54458 Unskip canvas tests that already pass. * platform/gtk/Skipped: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78570 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
abarth@webkit.org authored
Reviewed by Eric Seidel. Sketch script-src for Content Security Policy https://bugs.webkit.org/show_bug.cgi?id=54381 * http/tests/security/contentSecurityPolicy/script-loads-with-img-src-expected.txt: Added. * http/tests/security/contentSecurityPolicy/script-loads-with-img-src.html: Added. - Test that we don't block scripts when the policy is just img-src. * http/tests/security/contentSecurityPolicy/script-src-in-iframe.html: * http/tests/security/contentSecurityPolicy/script-src-none.html: * http/tests/security/contentSecurityPolicy/script-src-redirect.html: - Turns out we need to escape the ; character in order for it to be echoed back correctly in the header. 2011-02-15 Adam Barth <abarth@webkit.org> Reviewed by Eric Seidel. Sketch script-src for Content Security Policy https://bugs.webkit.org/show_bug.cgi?id=54381 This patch provides a sketch of the script-src directive. We still do not parse the value of the directive, and the wiring into the rest of WebCore is incorrect, but those are things we can fix in future patches. For the momemnt, this patch lets us test what we're doing. Test: http/tests/security/contentSecurityPolicy/script-loads-with-img-src.html * page/ContentSecurityPolicy.cpp: (WebCore::CSPDirective::CSPDirective): (WebCore::CSPDirective::allows): (WebCore::ContentSecurityPolicy::didReceiveHeader): (WebCore::ContentSecurityPolicy::canLoadExternalScriptFromSrc): (WebCore::ContentSecurityPolicy::parse): (WebCore::ContentSecurityPolicy::emitDirective): * page/ContentSecurityPolicy.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78569 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
antti@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=54460 Reviewed by Andreas Kling. Don't use fast path for SVG. There are some additional rules for shadow trees that are not implemented on fast path. * css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::checkSelector): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78568 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
mario@webkit.org authored
Unreviewed, skipping flaky test on GTK 64-bit debug bot. editing/selection/end-of-document.html is failing in the GTK 64-bit debug bot https://bugs.webkit.org/show_bug.cgi?id=53995 * platform/gtk/Skipped: Skipped flaky test. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78567 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
abecsi@webkit.org authored
Reviewed by Csaba Osztrogonác. [Qt] Redesign the build system https://bugs.webkit.org/show_bug.cgi?id=51339 Part 1. Introduce CodeGenerators.pri and add common includepaths to WebCore.pri, thus unnecessary duplications can be removed from project files. No new tests needed. * CodeGenerators.pri: Copied from Source/WebCore/WebCore.pri. Don't add non-source generated files to SOURCES. * DerivedSources.pro: Change WebCore.pri to CodeGenerators.pri. * WebCore.pri: Move code generation rules to CodeGenerators.pri. * WebCore.pro: Move common options to WebCore.pri. 2011-02-15 Andras Becsi <abecsi@webkit.org> Reviewed by NOBODY Csaba Osztrogonác. [Qt] Redesign the build system https://bugs.webkit.org/show_bug.cgi?id=51339 Part 1. Introduce CodeGenerators.pri and add common includepaths to WebCore.pri, thus unnecessary duplications can be removed from project files. * WebKit2.pro: Simplify and deduplicate includepaths. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78566 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
kalman@chromium.org authored
Reviewed by Ryosuke Niwa. Refactor the extend-selection tests to be clearer what they're doing https://bugs.webkit.org/show_bug.cgi?id=54429 This is essentially a cleanup to extend-selection.js and propagation of those changes to the affected tests. * editing/selection/extend-selection-character.html: * editing/selection/extend-selection-enclosing-block.html: * editing/selection/extend-selection-home-end.html: * editing/selection/extend-selection-word.html: * editing/selection/resources/extend-selection.js: (getSerializedSelection): (extendSelectionWithinBlock): (extendSelectionToEnd): (fold): (logMismatchingPositions): (extendAndLogSelection): (extendAndLogSelectionWithinBlock): (extendAndLogSelectionToEnd): (runSelectionTestsWithGranularity): (getTestNodeContainer): (createNode): (createCharAndWordNodes): (createEnclosingBlockNodes): (createHomeEndNodes): (createAllNodes): (.window.onload): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78565 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
mnaganov@chromium.org authored
[Chromium] Unreviewed test expectations update. Mark svg/custom/use-css-no-effect-on-shadow-tree.svg as failing. https://bugs.webkit.org/show_bug.cgi?id=54460 git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78563 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
philn@webkit.org authored
Reviewed by Eric Carlson. [GTK] media/audio-delete-while-slider-thumb-clicked.html is flaky https://bugs.webkit.org/show_bug.cgi?id=53247 Refactored the test to use the seeking event instead of timeupdate and avoid flakyness. * media/audio-delete-while-slider-thumb-clicked-expected.txt: * media/audio-delete-while-slider-thumb-clicked.html: * platform/gtk/Skipped: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78562 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
Reviewed by Mihai Parparita. Crash in WebCore::FrameLoader::continueLoadAfterNavigationPolicy https://bugs.webkit.org/show_bug.cgi?id=54219 Ensures we do not start a new navigation while we are in the process of stopping a navigation. Also adds a manual test, since the crash can only be reproduced using the back button and not history.back(). * loader/FrameLoader.cpp: * manual-tests/navigation-during-onload-triggered-by-back.html: Added. * manual-tests/resources/navigation-during-onload-container.html: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78561 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
krit@webkit.org authored
Unreviewed rebaseline. SVG animation doesn't support attribute value 'inherit' https://bugs.webkit.org/show_bug.cgi?id=54410 Rebaseline of Gtk result. * platform/gtk/svg/W3C-SVG-1.1/animate-elem-31-t-expected.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78560 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
jeffm@apple.com authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78559 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
Reviewed by David Levin. SubresourceLoader should expose finish time https://bugs.webkit.org/show_bug.cgi?id=54287 No tests needed, exposes no new functionality * loader/DocumentThreadableLoader.cpp: (WebCore::DocumentThreadableLoader::didFinishLoading): * loader/DocumentThreadableLoader.h: * loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::didFinishLoading): * loader/SubresourceLoaderClient.h: (WebCore::SubresourceLoaderClient::didFinishLoading): * loader/cache/CachedResourceRequest.cpp: (WebCore::CachedResourceRequest::didFinishLoading): * loader/cache/CachedResourceRequest.h: * loader/icon/IconLoader.cpp: (WebCore::IconLoader::didFinishLoading): * loader/icon/IconLoader.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78558 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
mnaganov@chromium.org authored
[Chromium] Unreviewed test expectations update. Update test results for xmlhttprequest/cache-override.html after r78541. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78557 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
antti@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=54360 Reviewed by Darin Adler. * css/CSSStyleSelector.cpp: (WebCore::isFastCheckableSelector): (WebCore::fastCheckSingleSelector): (WebCore::checkClassValue): (WebCore::checkIdValue): (WebCore::checkTagValue): (WebCore::CSSStyleSelector::SelectorChecker::fastCheckSelector): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78556 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
mnaganov@chromium.org authored
[Chromium] Unreviewed test expectations update. Add test results for animate-elem-31-t.svg after r78543, r78552. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78555 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
yurys@chromium.org authored
Reviewed by Pavel Feldman. Web Inspector: console auto-scroll is broken when there are both scrollers. https://bugs.webkit.org/show_bug.cgi?id=54273 * inspector/front-end/utilities.js: (Element.prototype.isScrolledToBottom): use clientHeight instead of offsetHeight to determine whether the element is scrolled to the bottom. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78554 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
apavlov@chromium.org authored
Reviewed by Yury Semikhatsky. Web Inspector: highlighter works incorrect at build.chromium.org WebKit cells https://bugs.webkit.org/show_bug.cgi?id=53910 Use enclosingBoundingBox for the absolute margin quad as the reference box for a tooltip. * inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::drawNodeHighlight): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78553 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
krit@webkit.org authored
Rubber-stamped by Nikolas Zimmermann. SVG animation doesn't support attribute value 'inherit' https://bugs.webkit.org/show_bug.cgi?id=54410 Accidently replaced start value RegularPropertyValue for m_fromPropertyValueType and m_toPropertyValueType by CurrentColorValue before landing. Check for property value type 'inherit' on color validation was missing. * svg/SVGAnimateElement.cpp: (WebCore::SVGAnimateElement::calculateFromAndToValues): (WebCore::SVGAnimateElement::calculateFromAndByValues): 2011-02-15 Dirk Schulze <krit@webkit.org> Rubber-stamped by Nikolas Zimmermann. SVG animation doesn't support attribute value 'inherit' https://bugs.webkit.org/show_bug.cgi?id=54410 We have support for 'inherit' in SVG animations now. This means the cyan circles are invisible at the beginning. The test itself is still broken, since calcMode gets handled incorrectly. * platform/mac-wk2/Skipped: * platform/mac/svg/W3C-SVG-1.1/animate-elem-31-t-expected.checksum: * platform/mac/svg/W3C-SVG-1.1/animate-elem-31-t-expected.png: * platform/mac/svg/W3C-SVG-1.1/animate-elem-31-t-expected.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78552 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
christian@webkit.org authored
acces*s*ibility with two s. Rubber-stamped by Gustavo Noronha Silva. Source/WebKit/gtk/po: * *.po: Correct a typo in acces*s*ibility. Rubber-stamped by Gustavo Noronha Silva. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78551 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
aroben@apple.com authored
* WebCore.vcproj/WebCore.vcproj: Fix bad XML syntax. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78550 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
christian@webkit.org authored
Brazilian Portuguese Translation Update https://bugs.webkit.org/show_bug.cgi?id=42833 * pt_BR.po: Updated. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78549 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
Reviewed by Antti Koivisto. SharedBuffer::buffer() does not do what you think. https://bugs.webkit.org/show_bug.cgi?id=54420 No new tests. * inspector/InspectorResourceAgent.cpp: (WebCore::InspectorResourceAgent::resourceContentBase64): * platform/SharedBuffer.h: * platform/image-decoders/jpeg/JPEGImageDecoder.cpp: (WebCore::JPEGImageReader::decode): (WebCore::JPEGImageDecoder::decode): * platform/image-decoders/webp/WEBPImageDecoder.cpp: (WebCore::WEBPImageDecoder::decode): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78548 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
mario@webkit.org authored
Unreviewed, unskip passing test after r78541. r78499 causes assertion failure in http/tests/xmlhttprequest/cache-override.html https://bugs.webkit.org/show_bug.cgi?id=54418 * platform/gtk/Skipped: Unskip passing test. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78547 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
mario@webkit.org authored
Unreviewed, GTK baselines for 4 new tests added in r78396. * platform/gtk/fast/inline/inline-box-background-expected.checksum: Added. * platform/gtk/fast/inline/inline-box-background-expected.png: Added. * platform/gtk/fast/inline/inline-box-background-expected.txt: Added. * platform/gtk/fast/inline/inline-box-background-long-image-expected.checksum: Added. * platform/gtk/fast/inline/inline-box-background-long-image-expected.png: Added. * platform/gtk/fast/inline/inline-box-background-long-image-expected.txt: Added. * platform/gtk/fast/inline/inline-box-background-repeat-x-expected.checksum: Added. * platform/gtk/fast/inline/inline-box-background-repeat-x-expected.png: Added. * platform/gtk/fast/inline/inline-box-background-repeat-x-expected.txt: Added. * platform/gtk/fast/inline/inline-box-background-repeat-y-expected.checksum: Added. * platform/gtk/fast/inline/inline-box-background-repeat-y-expected.png: Added. * platform/gtk/fast/inline/inline-box-background-repeat-y-expected.txt: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78546 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
levin@chromium.org authored
Reviewed by Shinichiro Hamaji. check-webkit-style should do some detection for valid uses of WEBKIT_API (in chromium public api). https://bugs.webkit.org/show_bug.cgi?id=52271 * Scripts/webkitpy/style/checkers/cpp.py: Added the check for WEBKIT_API usage. * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78545 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
pfeldman@chromium.org authored
Not reviewed: update inspector expectation path for mac-leopard. * platform/mac-leopard/inspector/extensions/extensions-resources-expected.txt: Renamed from LayoutTests/platform/mac-leopard/inspector/extensions-resources-expected.txt. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78544 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
krit@webkit.org authored
Reviewed by Nikolas Zimmermann. SVG animation doesn't support attribute value 'inherit' https://bugs.webkit.org/show_bug.cgi?id=54410 Check support for 'inherit' and 'currentColor' on SVG animations. * svg/animations/animate-currentColor-expected.txt: Added. * svg/animations/animate-currentColor.html: Added. * svg/animations/animate-inherit-css-property-expected.txt: Added. * svg/animations/animate-inherit-css-property.html: Added. * svg/animations/script-tests/animate-currentColor.js: Added. (sample1): (sample2): (sample3): (executeTest): * svg/animations/script-tests/animate-inherit-css-property.js: Added. (sample1): (sample2): (sample3): (executeTest): 2011-02-15 Dirk Schulze <krit@webkit.org> Reviewed by Nikolas Zimmermann. SVG animation doesn't support attribute value 'inherit' https://bugs.webkit.org/show_bug.cgi?id=54410 SVG animation does not support 'inherit' as value for CSS property animations. With the patch, SVG determines if the attribute of the target element is an animatable CSS Property and computes the style during the animation. This fixes the following tests on the W3C test suite: * animate-elem-84-t.svg * animate-elem-85-t.svg Tests: svg/animations/animate-currentColor.html svg/animations/animate-inherit-css-property.html * svg/SVGAnimateElement.cpp: (WebCore::adjustForCurrentColor): (WebCore::adjustForInheritance): (WebCore::SVGAnimateElement::calculateAnimatedValue): When a property value is 'inherit' or 'currentColor' during the animation, get the computed style of the property since the values could be animated themselves. (WebCore::inheritsFromProperty): (WebCore::attributeValueIsCurrentColor): (WebCore::SVGAnimateElement::calculateFromAndToValues): Check if 'from', 'by' or 'to' value has the string 'inherit' or 'currentColor' and if the attribute supports one of these values. (WebCore::SVGAnimateElement::calculateFromAndByValues): Ditto. * svg/SVGAnimateElement.h: * svg/SVGAnimationElement.cpp: (WebCore::SVGAnimationElement::isTargetAttributeCSSProperty): Check if target element is stylable and the attribute is an animatable CSS property by using the CSS property map in SVGStyledElement. (WebCore::SVGAnimationElement::setTargetAttributeAnimatedValue): s/target/targetElement/ for consistency. * svg/SVGAnimationElement.h: * svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::isAnimatableCSSProperty): Checks if the CSS property is animatable. * svg/SVGStyledElement.h: * svg/animation/SMILTimeContainer.cpp: Use the new function isTargetAttributeCSSProperty to determine if the target element is stylable and the attribute is an animatable CSS property. (WebCore::SMILTimeContainer::baseValueFor): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78543 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-