1. 25 Jan, 2007 22 commits
    • darin's avatar
      Reviewed by Beth. · 7cc9cd3f
      darin authored
              - fix <rdar://problem/4952766> Safari has a top secret color picker that can be used to... uhh... I don't know
      
              * Panels/English.lproj/WebAuthenticationPanel.nib/info.nib: Let Interface Builder have its way.
              * Panels/English.lproj/WebAuthenticationPanel.nib/objects.nib: Remove the NSColorWell that was
              in here (for no good reason).
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19132 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7cc9cd3f
    • kdecker's avatar
      Reviewed by andersca. · 80bc776a
      kdecker authored
              A few tweaks with of a fix done by Steve Gehrman.
      
              Fixed: <rdar://problem/4946922> WebBaseNetscapePluginView leaks memory
                     http://bugs.webkit.org/show_bug.cgi?id=11523
      
              * Plugins/WebBaseNetscapePluginStream.m:
              (-[WebBaseNetscapePluginStream setPlugin:]): Calls -[WebBaseNetscapePluginView streamIsDead:]
              * Plugins/WebBaseNetscapePluginView.h: Added streamIsDead to header.
              * Plugins/WebBaseNetscapePluginView.mm:
              (-[WebBaseNetscapePluginView streamIsDead:]): Added. Removes the stream from the streams collection.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19131 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      80bc776a
    • ggaren's avatar
      LayoutTests: · 7984531e
      ggaren authored
              Reviewed by Geoffrey Garen.
              
              Added tests for http://bugs.webkit.org/show_bug.cgi?id=12342
              REGRESSION: destroying a frame from its own script causes various crashes
              
              Thanks to Alexey Proskuryakov for the original versions of these tests.
      
              * fast/dom/exception-no-frame-inline-script-crash-expected.txt: Added.
              * fast/dom/exception-no-frame-inline-script-crash.html: Added.
              * fast/dom/exception-no-frame-timeout-crash-expected.txt: Added.
              * fast/dom/exception-no-frame-timeout-crash.html: Added.
      
      WebCore:
      
              Reviewed and landed by Geoffrey Garen.
      
              - fix http://bugs.webkit.org/show_bug.cgi?id=12342
                REGRESSION: destroying a frame from its own script causes various crashes
      
              * bindings/js/kjs_window.cpp: (KJS::ScheduledAction::execute):
              Use RefPtr for the frame and the interpreter object so they don't get deleted
              out from underneath us.
      
              * bindings/js/kjs_proxy.cpp: (WebCore::KJSProxy::evaluate):
              Add a check for a page of 0. This was the only call site for the
              addMessageToConsole function that did not have a check for a page of 0.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19130 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7984531e
    • lars's avatar
      Add the next 100 test cases. · 1b0b0ca2
      lars authored
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19129 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1b0b0ca2
    • lars's avatar
      Add more test cases that pass on the Qt build. · 88c1d298
      lars authored
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19128 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      88c1d298
    • lars's avatar
      The tests in dom/svg and dom/xhtml as well as · 1ceabb53
      lars authored
              most of the remaining tests in tables/ pass now as
              well, so lets run the test suite over them.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19127 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1ceabb53
    • bdakin's avatar
      WebCore: · 36cca87f
      bdakin authored
              Reviewed and merged by Beth.
      
              Fix for <rdar://problem/4921692> not processing comments inside a 
              title element leads to XSS (for at least BlogSpot)
      
              This is equivalent to commit 626791 in the KDE tree. Basically, the 
              patch allows comment parsing in titles to avoid capturing a 
              <script> tag by accident.
      
              * html/HTMLTokenizer.cpp:
              (WebCore::HTMLTokenizer::parseSpecial):
              (WebCore::HTMLTokenizer::parseComment):
      
      LayoutTests:
              Test for <rdar://problem/4921692> not processing comments inside a 
              title element leads to XSS (for at least BlogSpot)
      
              * fast/parser/parseCommentsInTitles-expected.checksum: Added.
              * fast/parser/parseCommentsInTitles-expected.png: Added.
              * fast/parser/parseCommentsInTitles-expected.txt: Added.
              * fast/parser/parseCommentsInTitles.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19126 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      36cca87f
    • darin's avatar
      * ksvg2/svg/SVGPreserveAspectRatio.cpp: Add a couple of comments. · f8a358cf
      darin authored
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19122 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f8a358cf
    • darin's avatar
      LayoutTests: · d60ec151
      darin authored
              Reviewed by Maciej.
      
              - test for bugs found by code inspection in the SVGPreserveAspectRatio parser
      
              * svg/dom/preserve-aspect-ratio-parser-expected.txt: Added.
              * svg/dom/preserve-aspect-ratio-parser.html: Added.
      
      WebCore:
      
              Reviewed by Maciej.
      
              - fix http://bugs.webkit.org/show_bug.cgi?id=12365
                Reproducible crash in WebCore::SVGPreserveAspectRatio::parsePreserveAspectRatio
                in svg/W3C-SVG-1.1/animate-elem-40-t.svg under guard malloc
              - fix bug where the parser accepts "meet" or "slice" as an entire string
              - fix bug where "slice" is ignored if the old alignment was "none"
                even if the newly-parsed alignment is something other than "none", and
                "slice" is not ignored if the old alignment was not "none", but the
                newly-parsed alignment is "none"
              - optimize to only call notifyAttributeChange if the attribute actually changed
      
              Test: svg/dom/preserve-aspect-ratio-parser-test.html
      
              * ksvg2/svg/SVGPreserveAspectRatio.cpp:
              (WebCore::checkString): Added an overload for using char* constants which is
              much simpler than the old one, and almost as fast.
              (WebCore::SVGPreserveAspectRatio::parsePreserveAspectRatio): Fail if there's no
              more text after "defer". Fail if there's neither "none" nor an x/y specified.
              Check that there's more text before looking at the "m" and "s" for "meet" and
              "slice". Merged the failure and success cases. Only call notifyAttributeChange
              if something changed.
      
              I think all the "optimized" code where we check the first character before
              calling checkString isn't really helpful, but I decided to leave it as-is
              for now.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19121 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d60ec151
    • lars's avatar
      Reviewed by Zack · 0313d9b0
      lars authored
              Trivial implementation of getMIMETypeForExtension.
              Use the above method in the ResourceHandleManager to set
              a mimetype on Resources that don't have one set (which
              includes everything loaded from local disk).
      
              Should fix quite a few test cases :)
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19120 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0313d9b0
    • sullivan's avatar
      Reviewed by Kevin, Geoff, Brady, and Darin · caedbca5
      sullivan authored
              
              - fixed <rdar://problem/4918446> Safari's temp files (PDF's) should be in a sub-folder when calling Preview
              
              * WebView/WebPDFView.mm:
              (-[WebPDFView _path]):
              use _temporaryPDFDirectoryPath method instead of #defines for hardwiring strings; stop bad practice
              of modifying the const char* returned by fileSystemRepresentation
              (-[WebPDFView _temporaryPDFDirectoryPath]):
              new method, lazily creates and returns a secure temporary directory created with NSTemporaryDirectory()
              and mkdtemp
      
              * English.lproj/StringsNotToBeLocalized.txt:
              Updated for these and other recent changes
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19119 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      caedbca5
    • lars's avatar
      Add more test results for the Qt build. · a1d13737
      lars authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19118 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a1d13737
    • zack's avatar
      Path from Harald Fernengel to fix compile on platforms · db76667d
      zack authored
      where qreal is not a double.
      r=me
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19117 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      db76667d
    • zack's avatar
      implement wheel event handling and use eventhandler explictly. · 70f930db
      zack authored
      r=lars
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19116 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      70f930db
    • rwlbuis's avatar
      Reviewed by Maciej. · 1b394020
      rwlbuis authored
              http://bugs.webkit.org/show_bug.cgi?id=12391
              SVG containers with viewports should respect overflow when hit testing 
              Take into account the overflow property when hit testing <svg>.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19115 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1b394020
    • lars's avatar
      Reviewed by Zack · 4171ff6b
      lars authored
              Emit the loadDone() signal from teh onload event callback
              again. This hangs on one or two test cases, but removes
              hundreds of failures elsewhere.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19114 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4171ff6b
    • lars's avatar
      remove dom/html/level2/html from skipped tests. · e5ddebc8
      lars authored
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19113 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e5ddebc8
    • lars's avatar
      Add css1 and css2.1 test results for the Qt build · 9554a1ab
      lars authored
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19112 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9554a1ab
    • lars's avatar
      Reviewed by Darin and Zack · f62c465e
      lars authored
              Fix http://bugs.webkit.org/show_bug.cgi?id=12398
              
              Move the test results for Qt into a directory of it's own
              (WebKit/LayoutTestResults/qt). Leave the Mac results where
              they are for now and share the text only results between 
              Mac and Qt.
      
              Add support for a LayoutTestResults/platform/Skipped file
              to run-webkit-tests to be able to ignore certain tests
      
              Remove the old tests-skipped.txt from Qts DumpRenderTree
              implementation. 
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19111 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f62c465e
    • aliceli1's avatar
      LayoutTests: · c28351ee
      aliceli1 authored
              Reviewed by Maciej.
      
              added test for 
              <rdar://problem/4808039> REGRESSION: eBay ID check never completes
              also known as
              http://bugs.webkit.org/show_bug.cgi?id=11230
      
              * http/tests/misc/location-replace-crossdomain-expected.txt: Added.
              * http/tests/misc/location-replace-crossdomain.html: Added.
              * http/tests/misc/resources/failure.html: Added.
              * http/tests/misc/resources/success.html: Added.
      
      WebCore:
      
              Reviewed by Maciej.
      
              fixed <rdar://problem/4808039> REGRESSION: eBay ID check never completes
              Also known as http://bugs.webkit.org/show_bug.cgi?id=11230
      
              * bindings/js/kjs_window.cpp:
              It's not necessary to check safeScript when doing a location.replace, .reload, or .assign
              (KJS::Location::getOwnPropertySlot):
              (KJS::LocationFunc::callAsFunction):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19110 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c28351ee
    • aliceli1's avatar
      LayoutTests: · 2c828868
      aliceli1 authored
              Reviewed by Geoff and Adele
      
              added test for <rdar://problem/4866655> REGRESSION: Copying out of Calculator & CIFIlterWidget is broken on 9A320
      
              * editing/execCommand/copy-without-selection-expected.txt: Added.
              * editing/execCommand/copy-without-selection.html: Added.
      
      WebCore:
      
              Reviewed by Geoff and Adele.
      
              fixed <rdar://problem/4866655> REGRESSION: Copying out of Calculator & CIFIlterWidget is broken on 9A320
      
              * editing/Editor.cpp:
              (WebCore::Editor::canDHTMLCut):
              (WebCore::Editor::canDHTMLCopy):
              (WebCore::Editor::tryDHTMLCopy):
              (WebCore::Editor::tryDHTMLCut):
              Reverting some mistakes made in r17504:
              Anything in r17503 that used to call mayDHTML* still calls canDHTML* as it was changed in r17504, where canDHTML* now calls !selectionController::isInPasswordField instead of editor::canCopy
              Anything else in r17503 that used to call mayCopy now calls (!)selectionController::isInPasswordField.
      
              * editing/JSEditor.cpp:
              copy via JS should be enabled as long as selection is not in a password field.  a range selection shouldn't be required. 
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19109 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2c828868
    • adele's avatar
      LayoutTests: · f62337c5
      adele authored
              Reviewed by Brady and Oliver.
      
              Test for <rdar://problem/4953504> When the keydown event changes focus, the keypress event should go to the new focused node
      
              * fast/events/keydown-keypress-focus-change-expected.txt: Added.
              * fast/events/keydown-keypress-focus-change.html: Added.
      
      WebCore:
      
              Reviewed by Brady and Oliver.
      
              Fix for <rdar://problem/4953504> When the keydown event changes focus, the keypress event should go to the new focused node
      
              Test: fast/events/keydown-keypress-focus-change.html
      
              * page/EventHandler.cpp:
              (WebCore::eventTargetNodeForDocument): Added for convenience.
              (WebCore::EventHandler::keyEvent): Moved from EventHandlerMac.mm.  After dispatching the keyDown event,
               recheck the target node for the keyPress event in case its changed.
              * page/EventHandler.h:
              * page/mac/EventHandlerMac.mm: (WebCore::EventHandler::keyEvent):
                Moved the bulk of this code to EventHandler.cpp.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19108 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f62337c5
  2. 24 Jan, 2007 18 commits
    • darin's avatar
      Reviewed by Oliver. · 43ba9a1b
      darin authored
              - fix crash seen in layout tests
      
              * DumpRenderTree/EventSendingController.m: (-[EventSendingController dealloc]):
              Add back the line of code that sets savedMouseEvents to nil. I thought it was
              a field of the EventSendingController, but it's actually a global.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19107 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      43ba9a1b
    • oliver's avatar
      2007-01-24 Oliver Hunt <oliver@apple.com> · 08050918
      oliver authored
              Build fix 
      
              * WebView/WebHTMLView.mm:
              (-[WebHTMLView _startDraggingImage:at:operation:event:sourceIsDHTML:DHTMLWroteData:]):
              (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19106 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      08050918
    • ggaren's avatar
      JavaScriptCore: · 949b412f
      ggaren authored
              Fixed up #include order for style. No review necessary.
      
              * API/JSStringRef.cpp:
      
      WebCore:
      
              New forwarding header. No review necessary.
      
              * ForwardingHeaders/kjs/ustring.h: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19105 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      949b412f
    • oliver's avatar
      Oliver Hunt <oliver@apple.com> · e3c60694
      oliver authored
      WebCore:
              Reviewed by Maciej.
      
              Migrating more drag state information to WebCore
      
              * page/DragController.cpp:
              * page/DragController.h:
              (WebCore::DragController::dragOperation):
              (WebCore::DragController::setDraggingImageURL):
              (WebCore::DragController::draggingImageURL):
              (WebCore::DragController::setDragOffset):
              (WebCore::DragController::dragOffset): 
      WebKit:
              Reviewed by Maciej.
      
              Migrating more drag state information to WebCore
      
              * WebKit.xcodeproj/project.pbxproj:
              * WebView/WebHTMLView.mm:
              (-[WebHTMLViewPrivate dealloc]):
              (-[WebHTMLViewPrivate clear]):
              (-[WebHTMLView _startDraggingImage:at:operation:event:sourceIsDHTML:DHTMLWroteData:]):
              (-[WebHTMLView _mayStartDragAtEventLocation:]):
              (-[WebHTMLView close]):
              (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]):
              (-[WebHTMLView _delegateDragSourceActionMask]):
              * WebView/WebHTMLViewInternal.h:         
                                                  
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19104 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e3c60694
    • ggaren's avatar
      Reviewed by Maciej Stachowiak. · f7c1146b
      ggaren authored
              * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
              Copy JSStringRefCF, in case anybody wants to use it. (I just added
              it recently.)
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19103 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f7c1146b
    • darin's avatar
      LayoutTests: · 2dd48f53
      darin authored
              Reviewed by Adele.
      
              - test for one of the symptoms of http://bugs.webkit.org/show_bug.cgi?id=12331
                REGRESSION(r18951): Selecting text in a textarea makes the page scroll
      
              * fast/events/autoscroll-expected.checksum: Added.
              * fast/events/autoscroll-expected.png: Added.
              * fast/events/autoscroll-expected.txt: Added.
              * fast/events/autoscroll.html: Added.
      
      WebCore:
      
              Reviewed by Adele.
      
              - fix http://bugs.webkit.org/show_bug.cgi?id=12331
                REGRESSION(r18951): Selecting text in a textarea makes the page scroll
      
              Test: fast/events/autoscroll.html
      
              * rendering/RenderLayer.cpp: (WebCore::RenderLayer::autoscroll):
              Adjust position to be relative to the object's corner for the hit test, but not for the
              scrollRectToVisible call. The previous version accidentally re-used the version that was
              adjusted for the hit test.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19102 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2dd48f53
    • darin's avatar
      Reviewed by Maciej. · 4d291cf2
      darin authored
              - changed dragMode to be a property instead of a function
      
              * DumpRenderTree/EventSendingController.h: Renamed inDragMode to dragMode.
              * DumpRenderTree/EventSendingController.m:
              (+[EventSendingController isSelectorExcludedFromWebScript:]): Removed setDragMode.
              (+[EventSendingController isKeyExcludedFromWebScript:]): Added dragMode.
              (-[EventSendingController init]): Updated for name change.
              (-[EventSendingController leapForward:]): Ditto.
              (-[EventSendingController mouseUp]): Ditto.
              (-[EventSendingController mouseMoveToX:Y:]): Ditto.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19101 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4d291cf2
    • bdakin's avatar
      WebCore: · 06de9c41
      bdakin authored
              Reviewed by Geoff.
      
              Fix for <rdar://problem/4948128> REGRESSION: A crash occurs at 
              WebCore::Frame::view() after completing a query at mapquest.com 
              then switching to Bookmarks view
      
              This is just a null-check. If you are in strict mode and ask for 
              the clientWidth or clientHeight after the document was removed from 
              it's parent, we no longer have a frameView, so we have to null-
              check it. I added null checks for the FrameView in some other 
              places where it seems like we could potentially run into this 
              issue.
      
      LayoutTests:
              Reviewed by Geoff.
      
              Test for <rdar://problem/4948128> REGRESSION: A crash occurs at 
              WebCore::Frame::view() after completing a query at mapquest.com 
              then switching to Bookmarks view
      
              * fast/dom/clientWidthAfterDocumentIsRemoved-expected.checksum: Added.
              * fast/dom/clientWidthAfterDocumentIsRemoved-expected.png: Added.
              * fast/dom/clientWidthAfterDocumentIsRemoved-expected.txt: Added.
              * fast/dom/clientWidthAfterDocumentIsRemoved.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19100 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      06de9c41
    • darin's avatar
      Reviewed by Maciej. · 9c8695eb
      darin authored
              - made the deferral of mouse events until drag completes conditional
                it's needed for drag testing, and harmful for selection testing
      
              * DumpRenderTree/EventSendingController.h: Added inDragMode boolean.
              * DumpRenderTree/EventSendingController.m:
              (+[EventSendingController isSelectorExcludedFromWebScript:]): Added setDragMode:.
              (+[EventSendingController webScriptNameForSelector:]): Added name for setDragMode,
              and remove unneeded clearKillRing name.
              (-[EventSendingController init]): Initialize inDragMode to true.
              (-[EventSendingController dealloc]): Removed overzealous assertions -- we should
              not be asserting things that are dependent on the test content!
              (-[EventSendingController leapForward:]): Only queue events in drag mode.
              (-[EventSendingController setDragMode:]): Added.
              (-[EventSendingController mouseDown]): Removed overzealous assertion.
              (-[EventSendingController mouseUp]): Removed overzealous assertions.
              Only queue events in drag mode.
              (-[EventSendingController mouseMoveToX:Y:]): Only queue events in drag mode.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19099 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9c8695eb
    • mjs's avatar
      Not reviewed, just removing accidentally committed file. · 2dd45a7a
      mjs authored
              - removed file that shouldn't be there
      
              * Image Viewer/Image Viewer.aps: Removed.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19097 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2dd45a7a
    • mjs's avatar
      Not reviewed, trivial property change. · 6a576c7a
      mjs authored
              
              * JavaScriptCore.vcproj/JavaScriptCore.sln: remove svn:mime-type
              property which made this binary.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19096 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6a576c7a
    • adele's avatar
      Updating with correct bug number · c9b4f451
      adele authored
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19095 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c9b4f451
    • andersca's avatar
      LayoutTests: · 08448fbb
      andersca authored
              Reviewed by Geoff and Adam.
      
              <rdar://problem/4922655>
              http://galeri.milliyet.com.tr/ reproducibly crashes Safari
      
              * fast/dom/resources/set-frame-src-while-running-script-in-frame.html: Added.
              * fast/dom/set-frame-src-while-running-script-in-frame-expected.txt: Added.
              * fast/dom/set-frame-src-while-running-script-in-frame.html: Added.
      
      WebCore:
      
              Reviewed by Geoff and Adam.
      
              <rdar://problem/4922655>
              http://galeri.milliyet.com.tr/ reproducibly crashes Safari
              
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::requestFrame):
              If the frame already exists, defer the navigation so that we won't end up replacing the document
              while we're parsing it. This is similar to what setting window.location ends up doing.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19094 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      08448fbb
    • adele's avatar
      Reviewed by Darin. · e82eab06
      adele authored
              Small improvement to my last checkin to prevent the keyEventWasInterpreted bool from
              being overwritten by reentrancy.
      
              * WebView/WebHTMLView.mm:
              (-[WebHTMLView _interceptEditingKeyEvent:]): Point keyEventWasInterpreted pointer to local variable.
              (-[WebHTMLView doCommandBySelector:]):
              (-[WebHTMLView insertText:]):
              * WebView/WebHTMLViewInternal.h: Added BOOL pointer that will point to the local variable on the stack in _interceptEditingKeyEvent
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19093 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e82eab06
    • justing's avatar
      Reviewed by harrison · aebbed3a
      justing authored
              
              Adding this layout test for a bug fixed by the changes
              in r19088.
      
              * editing/execCommand/4916402-expected.checksum: Added.
              * editing/execCommand/4916402-expected.png: Added.
              * editing/execCommand/4916402-expected.txt: Added.
              * editing/execCommand/4916402.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19092 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      aebbed3a
    • adele's avatar
      LayoutTests: · 0c2957ce
      adele authored
              Reviewed by Darin.
      
              Test for <rdar://problem/4943650> REGRESSION: insertion point blink in form field redraws entire web page, making everything slow
      
              * fast/events/arrow-navigation-expected.txt: Added.
              * fast/events/arrow-navigation.html: Added.
      
      WebKit:
      
              Reviewed by Darin.
      
              - Fix for <rdar://problem/4943650> REGRESSION: insertion point blink in form field redraws entire web page, making everything slow
      
              Keep track of whether interpretKeyEvents handles the key event based on whether or not we get
              called in insertText or doCommandBySelector.
      
              Test: fast/events/arrow-navigation.html
      
              * WebView/WebHTMLView.mm:
              (-[WebHTMLView performKeyEquivalent:]):
              (-[WebHTMLView _interceptEditingKeyEvent:]):
              (-[WebHTMLView doCommandBySelector:]):
              (-[WebHTMLView insertText:]):
              * WebView/WebHTMLViewInternal.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19091 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0c2957ce
    • bdash's avatar
      2007-01-25 Mark Rowe <mrowe@apple.com> · 19897573
      bdash authored
              Reviewed by Maciej.
      
              * Info.plist: Update copyright string.
      
      2007-01-25  Mark Rowe  <mrowe@apple.com>
      
              Reviewed by Darin.
      
              * Info.plist: Update copyright string.
      
      2007-01-25  Mark Rowe  <mrowe@apple.com>
      
              Reviewed by Maciej.
      
              * Info.plist: Update copyright string.
      
      2007-01-25  Mark Rowe  <mrowe@apple.com>
      
              Reviewed by Darin.
      
              * Info.plist: Update copyright string.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19090 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      19897573
    • andersca's avatar
      Reviewed by Maciej. · 5fd122a2
      andersca authored
              Fix tests and update test results.
              
              * fast/dom/gc-6-expected.txt:
              * fast/dom/gc-6.html:
              * fast/dom/gc-7-expected.txt:
              * fast/dom/gc-7.html:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19089 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5fd122a2