1. 19 Dec, 2002 1 commit
  2. 18 Dec, 2002 2 commits
    • sheridan's avatar
      Alexander-40 stamp · a5f80239
      sheridan authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3129 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • mjs's avatar
      Tools: · cc196b5c
      mjs authored
      	Reviewed by John.
      	- fixed 3131171 - Change Alex versions to satisfy both marketing and B&I requirements
              * Scripts/set-alex-version: New the script takes 3 different
      	versions, source version, marketing version and internal version.
      	Reviewed by John.
      	- fixed 3131171 - Change Alex versions to satisfy both marketing and B&I requirements
              * English.lproj/InfoPlist.strings:
              * JavaScriptCore.pbproj/project.pbxproj:
      	Reviewed by John.
      	- fixed 3131171 - Change Alex versions to satisfy both marketing and B&I requirements
              * English.lproj/InfoPlist.strings:
              * WebFoundation.pbproj/project.pbxproj:
      	Reviewed by John.
      	- fixed 3131171 - Change Alex versions to satisfy both marketing and B&I requirements
              * English.lproj/InfoPlist.strings:
      	Reviewed by John.
      	- fixed 3131171 - Change Alex versions to satisfy both marketing and B&I requirements
              * English.lproj/InfoPlist.strings:
      	Reviewed by John.
      	- fixed 3131171 - Change Alex versions to satisfy both marketing and B&I requirements
              * English.lproj/InfoPlist.strings:
              * WebBrowser.pbproj/project.pbxproj:
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3126 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  3. 17 Dec, 2002 4 commits
    • darin's avatar
      JavaScriptCore: · 7894002d
      darin authored
              Reviewed by Trey.
              * JavaScriptCore.pbproj/project.pbxproj: Removed signature.
              Reviewed by Trey.
              * WebFoundation.pbproj/project.pbxproj: Remove signature.
              Reviewed by Trey.
              * WebCore.pbproj/project.pbxproj: Remove signature.
              * kwq/KWQColor.mm: Turn off inlining so we can build even on the
      	compiler that warns about static data in inline functions.
              Reviewed by Trey.
              * WebKit.pbproj/project.pbxproj: Remove signature.
              * WebView.subproj/WebController.m: Turn off inlining so we can build even on the
      	compiler that warns about static data in inline functions.
              Reviewed by Trey.
              * Scripting.subproj/Safari.scriptSuite: Change signature to sfri.
              * WebBrowser.pbproj/project.pbxproj: Change signature to sfri.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3115 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • sheridan's avatar
      Alexander-39, submitting to B&I · 7146c87d
      sheridan authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3110 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • sheridan's avatar
      Alex-38 · 6535a5fe
      sheridan authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3107 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • darin's avatar
      top level: · fc4fd1d0
      darin authored
              Reviewed by Don and Maciej.
              * force-clean-timestamp: Trigger a full build since we are setting
      	MACOSX_DEPLOYMENT_TARGET to 10.2, which requires remaking all PFEs.
              * Scripts/check-copyright: Added.
              Reviewed by Don and Maciej.
      	- fixed 3129115 -- need Apple copyright added to open source documents
      	* tons of files: Added our copyright to files we modified, and updated all to standard format.
      	- other changes
              * JavaScriptCore.pbproj/project.pbxproj: Set MACOSX_DEPLOYMENT_TARGET to 10.2.
      	Also removed completion.cpp.
              * kjs/completion.cpp: Removed.
              * kjs/completion.h: Made the Completion constructor inline.
              * kjs/grammar.y: Removed an obsolete "pretend ifdef". No need to put these in APPLE_CHANGES now.
              Reviewed by Don and Maciej.
              * English.lproj/StringsNotToBeLocalized.txt: Updated for recent changes.
              * WebFoundation.pbproj/project.pbxproj: Set MACOSX_DEPLOYMENT_TARGET to 10.2.
              Reviewed by Don and Maciej.
      	- fixed 3129115 -- need Apple copyright added to open source documents
      	* tons of files: Added copyright message to files we modified and
      	standardized format of copyrights too.
      	- fixed 3129235 -- assert in LRUList visiting apple.com if "Display images" preference is off
              * khtml/misc/loader.cpp:
              (Cache::getLRUListFor): Use the first list for 0-sized objects.
              (Cache::removeFromLRUList): Allow 0-sized objects.
      	- other changes
              * khtml/rendering/render_style.h: Remove bogus unused private constructor.
              * kwq/KWQFont.h: Added copy constructor and assignment operator.
              * kwq/KWQFont.mm:
              (QFont::QFont): Copy constructor now retains the NSFont. The old version didn't which could
      	cause retain/release problems.
              (QFont::operator=): Retain the new NSFont and release the old one.
              * WebCore.pbproj/project.pbxproj: Set MACOSX_DEPLOYMENT_TARGET to 10.2.
              Reviewed by Don and Maciej.
              * WebView.subproj/WebUserAgentSpoofTable.gperf: Added a couple of new domains to the list we
      	spoof as Mac IE, and added comments.
              * WebView.subproj/WebUserAgentSpoofTable.c: Regenerated.
              * WebKit.pbproj/project.pbxproj: Set MACOSX_DEPLOYMENT_TARGET to 10.2
              Reviewed by Don and Maciej.
      	- fixed 3106686 -- Remove "world leak" debugging window before beta
              * Test/PageLoadTestController.m:
              (-[PageLoadTestController windowDidLoad]): (Not part of the bug fix.) Changed the combo
      	box so it automatically sizes to the number of pltsuite files so we don't have to edit
      	the nib all the time.
              (-[PageLoadTestController anyWindowWillClose:]): Don't do any world leak test when the
      	window closes. The one in the page load test window is still there.
              * Debug/DebugUtilities.m: (-[NSApplication validate_toggleAlwaysCheckForWorldLeaks:]):
      	Don't enable or check the debug menu item at all. Put an ifdef in so we can turn it on later.
      	- fixed 3124310 -- remove "app refuses to launch" code before shipping
              * main.m: (main): Remove all the licensing code.
      	- other changes
              * BrowserNSNetServiceExtras.m: Made all locally-defined-and used functions static
      	so we would know if any were unused and for cleanliness.
              (-[NSNetService hostName:andPort:]): Remove some silly assertions.
              (decode_name): Change printf for errors to ERROR.
              (decode_srv): Ditto.
      	(decode_txt): Removed because it's unused.
              (skip_question): Ditto.
              (MyDictionaryKeyHashCallBack): Removed silly assertion.
              (MyCreateCFDictionaryFromTXT): Ditto.
              * WebBrowser.pbproj/project.pbxproj: Set MACOSX_DEPLOYMENT_TARGET to 10.2
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3098 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  4. 16 Dec, 2002 3 commits
  5. 15 Dec, 2002 2 commits
    • mjs's avatar
      Tools: · fcbad401
      mjs authored
              Reviewed by Darin.
              * Scripts/set-module-version: Accept `u' in source version.
              Reviewed by Darin.
              * WebCore.pbproj/project.pbxproj: Updated source version to 37u2.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3072 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • darin's avatar
      JavaScriptCore: · 107c53d2
      darin authored
              Reviewed by Maciej.
              * JavaScriptCore.pbproj/project.pbxproj: Make dtoa.h visible as an SPI so I can
      	use it inside QString.
              Reviewed by Maciej.
              * English.lproj/StringsNotToBeLocalized.txt: Updated for recent changes.
              Reviewed by Maciej and Dave.
      	- optimizations that improve speed; total is 13.8% on cached cvs-base on my machine
              * khtml/css/css_valueimpl.h: Add isKonqBody() and genericFamilyType() to find out if
      	a font is a standard one. This is much faster than doing string comparisons all the time.
              * khtml/css/css_valueimpl.cpp: (FontFamilyValueImpl::FontFamilyValueImpl):
      	Check the font names against the standard ones on time when the FontFamilyValueImpl
      	object is constructed rather than every time the stuff is matched.
              * khtml/css/cssparser.h: Add pseudoType() and extractPseudoType() to CSSSelector so we
      	don't have to do string compares all the time.
              * khtml/css/cssparser.cpp:
              (StyleBaseImpl::parseValue): Use QConstString in a way that's effective (with an
      	object that has a long enough lifetime), or don't use it at all.
              (StyleBaseImpl::parseContent): Ditto.
              (StyleBaseImpl::preprocess): Preprocess into a buffer, usually on the stack, rather than
      	using QString += QChar over and over again.
              (CSSSelector::extractPseudoType): Convert the value string into a type, and get rid of it.
      	Saves memory because the string goes away. And doing it once is much faster than string
      	comparing each time.
              * khtml/css/cssstyleselector.cpp:
      	(cleanPath): Restructure to save one find() in the common case.
      	(checkPseudoState): Restructure to avoid some DOMString creation/destruction in the case
      	where the tag is not an <A>. Also use QConstString correctly.
      	(CSSStyleSelector::checkOneSelector): Use the new pseudoType() instead of string compares.
      	(CSSStyleSelector::applyRule): Use isKonqBody() and genericFamilyType() instead of string
              * khtml/dom/dom_string.h: Make the destructor non-virtual. This was a big win, and a mistake
      	the way it was before. Also make the DOMString constructor with no parameters inline.
              * khtml/dom/dom_string.cpp:
              (DOMString::string): Don't use QConstString here, since it does no good.
              (DOM::operator==): Rewrite to do things faster and avoid calling strlen.
              * khtml/html/html_objectimpl.h: Don't use QConstString in places where it does harm and no good.
              * khtml/html/html_objectimpl.cpp: (HTMLEmbedElementImpl::parseAttribute): Use QConstString properly.
              * khtml/html/htmltokenizer.cpp:
              (tagMatch): Added.
              (HTMLTokenizer::parseSpecial): Change tokenizing so it doesn't construct temporary strings (with
      	QConstString) just to compare small substrings.
              * khtml/khtml_part.cpp: (KHTMLPart::write): Don't use a decoder object when source is all ASCII.
              * kwq/KWQColor.mm:
              (hex2int): Don't bother with uppercase hex since we always lowercase anyway.
              (QColor::setNamedColor): Use a new gperf-based table instead of an NSDictionary to look up colors.
              * kwq/KWQColorData.c: Added this autogenerated file.
              * kwq/KWQColorData.gperf: Added. Source file with list of colors and color values.
              * kwq/Makefile.am: Build KWQColorData.c from KWQColorData.gperf.
              * WebCore.pbproj/project.pbxproj: Added KWQColorData.gperf.
              * khtml/misc/helper.cpp: (khtml::setNamedColor): Don't call setNamedColor again with the lowercased
      	color name, since our QColor::setNamedColor already has to lowercase the name (because it has to check
      	all names before checking any hex values).
              * khtml/rendering/font.h: Don't initialize the QFontMetrics since in every case we end up changing
      	the font later anyway. Also remove unused field.
              * khtml/rendering/font.cpp: (Font::update): Use the new QFontMetrics::setFont for speed.
              * khtml/rendering/render_object.cpp: (RenderObject::enclosingLayer): Change it so it doesn't get
      	the layer twice. This function showed up on the sample so we know it's hot.
              * khtml/xml/dom_stringimpl.cpp: (DOMStringImpl::containsOnlyWhitespace): Did a faster implementation
      	that doesn't call QChar::direction() except for non-ASCII characters.
              * kwq/KWQFontMetrics.h: Add empty constructor for use in font.cpp. Add accessor and setter for the
      	font too. Made baselineOffset() inline since it's trivial.
              * kwq/KWQFontMetrics.mm:
      	(QFontMetricsPrivate::QFontMetricsPrivate): Don't make the renderer until we use it.
      	(QFontMetricsPrivate::getRenderer): Make it here.
      	(QFontMetricsPrivate::font): Added.
      	(QFontMetricsPrivate::setFont): Added. Dumps the renderer if the font is different.
              (QFontMetrics::QFontMetrics): Added empty constructor.
              (QFontMetrics::setFont): Added.
              * kwq/KWQKURL.mm: (KURL::parse): Avoid function call overhead calling strncasecmp and strncmp.
      	Also made the check for localhost case insensitive.
              * kwq/KWQString.h: Remove _isUnicodeInternal and _isAsciiInternal, since they are trivially
      	computed, and it saves time to not have that extra field to manipulate. Removed private
      	data() function since it's the same as *dataHandle and not really more clear. Made ascii()
      	and unicode() simpler and inline. Also made latin1() and getCFString() inline. Renamed
      	QStringData to KWQStringData.
              * kwq/KWQString.mm:
              (QStringData::QStringData): Remove initializers for the xxxInternal.
              (QStringData::initialize): Removed some unnecessary if statements, and made a slight improvement
      	in the case of a 0-length string that comes with a pointer for Unicode (can't do it in the
              char * case because it's a feature that's used).
              (QString::makeSharedNull): No need to set _isUnicodeInternal.
              (QStringData::~QStringData): Use the new functions instead of the old bits.
              (QStringData::increaseAsciiSize): Grow faster when we get to larger sizes where the "good size"
      	call doesn't have as much of an effect. Simplified by removing unneeded code.
              (QStringData::increaseUnicodeSize): Ditto.
              (QStringData::makeAscii): Update for removal of _isAsciiInternal.
              (QStringData::makeUnicode): Update for removal of _isUnicodeInternal.
              (QString::detachIfInternal): Add this new inline to speed things up for the common case where
      	there's no detaching needed.
              (QString::at): Simplify, there were excess if branches here.
              (QString::toDouble): Use kjs_strtod and don't copy the string using QCString for additional speed.
              (QString::lower): Don't detach if the string is already all lowercase. Added a FIXME about the
      	code that assumes all "ASCII" bytes are truly ASCII. This code blurs the distinction between Latin-1
      	and ASCII in a way that will not work right for Latin-1 characters in an 8-byte character QString.
              (QString::detachInternal): Update for removal of _isUnicodeInternal.
              (QString::detach): Removed a special case for shared_null that was dead code since shared_null has
      	the _isUnicodeValid flag set.
              (operator==): Rewrote the comparison with char * to avoid the costly call to strlen.
              * Makefile.am: Updated the rules here so the force clean timestamp works right.
              * force-clean-timestamp: Touched this since the header dependencies don't seem right
      	for the DOMString constructor change, at least.
      	* WebCore-tests.exp: Exported a symbol now needed by tests since QString does more inlining.
      	* WebCore-combined.exp: Re-generated.
              Reviewed by Maciej.
              * English.lproj/StringsNotToBeLocalized.txt: Updated for recent changes.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3058 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  6. 13 Dec, 2002 1 commit
    • darin's avatar
      Reviewed by Trey. · bdd26c11
      darin authored
      	- moved KWQFontFamily and KWQPageState to new homes
              * kwq/KWQFontFamily.h: Added.
              * kwq/KWQFontFamily.mm: Added.
              * kwq/KWQPageState.h: Added.
              * kwq/KWQPageState.mm: Added.
              * WebCore.pbproj/project.pbxproj: Added new source files.
              * kwq/KWQFont.h: Removed KWQFontFamily.
              * kwq/KWQFont.mm:  Removed KWQFontFamily.
              * kwq/WebCoreBridge.mm: Removed KWQPageState.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3038 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  7. 12 Dec, 2002 3 commits
    • sheridan's avatar
      version 37u ... tree is open · c1f231f6
      sheridan authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3027 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • sheridan's avatar
      Alex-36 versions · 626b54bf
      sheridan authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3025 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • darin's avatar
      WebCore: · c9a8d22b
      darin authored
              Reviewed by Maciej and Richard.
      	- fixed 3125497 -- REGRESSION: Infinite recursion with mouseUp: events
      	The problem was that events could end up back at the same part due to the responder chain.
              * kwq/KWQKHTMLPart.h: Added mouseDown, mouseDragged, mouseUp, mouseMoved, buttonForCurrentEvent,
      	and stateForCurrentEvent. Remove setCurrentEvent and currentEvent. Renamed handleMouseDownEventForWidget
      	to passWidgetMouseDownEventToWidget. John and I had agreed to this name change before the last commit,
      	but I forgot.
              * kwq/KWQKHTMLPart.mm:
              (KWQKHTMLPart::KWQKHTMLPart): Initialize _sendingEventToSubview to false. No need to initialize
      	_mouseDownWasInSubframe at all since it's only looked at when _mouseDownView is non-nil.
              (KWQKHTMLPart::keyEvent): Save and restore _currentEvent instead of setting to nil.
      	Use stateForCurrentEvent instead of stateForEvent:.
              (KWQKHTMLPart::khtmlMousePressEvent): Name change.
              (KWQKHTMLPart::khtmlMouseDoubleClickEvent): Name change.
              (KWQKHTMLPart::passWidgetMouseDownEventToWidget): Name change. Set _sendingEventToSubview when
              sending event to subview.
              (KWQKHTMLPart::khtmlMouseReleaseEvent): Name change. Set _sendingEventToSubview when sending
      	event to subview.
              (KWQKHTMLPart::passSubframeEventToSubframe): Name change. Set _sendingEventToSubview when
      	sending event to subview.
              (KWQKHTMLPart::buttonForCurrentEvent): Added. Similar to code I moved here from WebCoreBridge.
              (KWQKHTMLPart::stateForCurrentEvent): Added. Similar to code I moved here from WebCoreBridge.
              (KWQKHTMLPart::mouseDown): Added. Similar to code I moved here from WebCoreBridge, except returns
      	and does nothing if _sendingEventToSubview is set.
              (KWQKHTMLPart::mouseDragged): Ditto.
              (KWQKHTMLPart::mouseUp): Ditto.
              (KWQKHTMLPart::mouseMoved): Added. Similar to code I moved here from WebCoreBridge.
              * kwq/WebCoreBridge.mm:
              (-[WebCoreBridge mouseDown:]): Just call _part->mouseDown().
              (-[WebCoreBridge mouseDragged:]): Just call _part->mouseDragged().
              (-[WebCoreBridge mouseUp:]): Just call _part->mouseUp().
              (-[WebCoreBridge mouseMoved:]): Just call _part->mouseMoved().
              * kwq/WebCoreBridgePrivate.h: Removed.
              * WebCore.pbproj/project.pbxproj: Removed WebCoreBridgePrivate.h.
              Reviewed by Maciej and Richard.
              - fixed reentrancy crash I ran into while debugging infinite recursion bugs
              * WebView.subproj/WebHTMLViewPrivate.m:
              (-[WebHTMLView _updateMouseoverWithFakeEvent]): Added. Does part of what _frameOrBoundsChanged did.
              (-[WebHTMLView _frameOrBoundsChanged]): Schedule the mouseover update to happen soon, rather than
              doing it right away. If we do it right away, we might reenter because sending a mouse moved event
              can result in another layout since mouse moved events are the same as mouse dragged events in KHTML.
              * WebView.subproj/WebHTMLView.m:
              (-[WebHTMLView viewWillMoveToWindow:]): Cancel the scheduled mouseover update.
              * WebKit.pbproj/project.pbxproj: Electron uber alles.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3016 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  8. 09 Dec, 2002 3 commits
    • darin's avatar
      Tools: · 030cad4c
      darin authored
              Reviewed by Maciej.
              * Scripts/set-alex-version: Make it bump the source version and marketing version
      	of all our subprojects, because that's what we need up until Alex 1.0.
              Reviewed by Maciej.
              * JavaScriptCore.pbproj/project.pbxproj: Bump versions to 0.8 and 35u.
      	* English.lproj/InfoPlist.strings: In here too.
              Reviewed by Maciej.
      	- fixed problems I noticed in my review of Chris's change (which came in too late)
              * CacheLoader.subproj/WebResourceLoad.m: (_guessMIMEType): Fix && vs. || confusion that
      	will make CR, LF, and tab not qualify as text characters. Also take end of loop check
      	out of the loop.
      	- added a method for use in user-agent computations
              * Misc.subproj/WebNSUserDefaultsExtras.h: Added _web_preferredLanguageCode.
              * Misc.subproj/WebNSUserDefaultsExtras.m:
              (+[NSUserDefaults _web_preferredLanguageCode]): Use _web_HTTPStyleLanguageCode on the
      	first element of the AppleLanguages array.
              * WebFoundation.pbproj/project.pbxproj: Bump versions to 0.8 and 35u.
      	Make WebNSUserDefaultsExtras.h SPI so we can use it in WebKit. Re-sort things a bit.
      	* English.lproj/InfoPlist.strings: Bump versions in here too.
              * English.lproj/StringsNotToBeLocalized.txt: Updated for these and other recent changes.
              Reviewed by Maciej.
              * WebCore.pbproj/project.pbxproj: Bump versions to 0.8 and 35u.
              Reviewed by Maciej.
      	- fixed 3028664 -- change user agent string to include application name and version
              * WebView.subproj/WebController.m:
              (-[WebController setApplicationNameForUserAgent:]): Remove locking, unneeded since we changed
      	how WebFoundation handles user agent.
              (-[WebController setCustomUserAgent:]): Ditto.
              (-[WebController resetUserAgent]): Ditto.
              (-[WebController userAgentForURL:]): Remove locking. Also add new algorithm for computing the
      	user agent which takes the preferred language into account, and incorporates the WebKit version
      	and the application name.
              * WebView.subproj/WebControllerPrivate.h: No need for a lock.
              * WebView.subproj/WebControllerPrivate.m:
              (-[WebControllerPrivate init]): Don't create a lock.
              (-[WebControllerPrivate dealloc]): Don't release a lock.
              * WebKit.pbproj/project.pbxproj: Bump versions to 0.8 and 35u.
      	* English.lproj/InfoPlist.strings: In here too.
              * English.lproj/StringsNotToBeLocalized.txt: Updated for these and other recent changes.
              Reviewed by Maciej.
      	- pass properly-formatted application name string to WebKit so it can make a good user-agent
              * BrowserWebController.m: (-[BrowserWebController initWithBrowserDocument:]):
      	Instead of passing "Mr. Poopypants", pass Sherlock, augmented with version strings,
      	to setApplicationNameForUserAgent:. Later we will pass Safari instead.
              * WebBrowser.pbproj/project.pbxproj: Bump version to 35u (we won't use " unofficial" any more).
              * English.lproj/StringsNotToBeLocalized.txt: Updated for these changes.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2985 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • darin's avatar
      Reviewed by Trey. · b45dd6a2
      darin authored
      	- made KWQKHTMLPart a subclass of KHTMLPart so we can override virtual functions
              * khtml/khtml_part.h: Get rid of kwq pointer.
              * khtml/khtml_part.cpp:
              (KHTMLPart::init): No need to make a KWQKHTMLPart any more.
              (KHTMLPart::~KHTMLPart): No need to delete a KWQKHTMLPart any more.
              (KHTMLPart::closeURL): KWQKHTMLPart does saveDocumentState in an override now.
              (KHTMLPart::begin): KWQ() instead of ->kwq.
              (KHTMLPart::checkCompleted): KWQ() instead of ->kwq, and ifdef out some unneeded code.
              (KHTMLPart::urlSelected): KWQ() instead of ->kwq.
              (KHTMLPart::requestFrameName): KWQ() instead of ->kwq.
              (KHTMLPart::processObjectRequest): Just call openURL, since we are now KWQKHTMLPart.
              (KHTMLPart::submitForm): KWQ() instead of ->kwq.
              (KHTMLPart::popupMenu): Did a bit more ifdef'int out here.
              * kwq/KWQKHTMLPart.h: Include "khtml_part.h" and remove includes we don't need any more.
      	Inherit from KHTMLPart instead of QObject. Remove KHTMLPart parameter from constructor.
      	Override openURL and closeURL. Remove part and d pointers. Add KWQ() inline to avoid casting.
              * kwq/KWQKHTMLPart.mm:
              (KHTMLPart::completed): KWQ() instead of ->kwq.
              (KHTMLPart::openURL): Never reached now, since we override.
              (KHTMLPart::setStatusBarText): KWQ() instead of ->kwq.
              (KHTMLPart::started): KWQ() instead of ->kwq.
              (KWQKHTMLPart::KWQKHTMLPart): No need to deal with separate part.
              (KWQKHTMLPart::bridgeForFrameName): KWQ() instead of ->kwq.
              (KWQKHTMLPart::openURL): Add bool return value so we can override the existing openURL.
              (KWQKHTMLPart::slotData): Remove unneeded part->.
              (KWQKHTMLPart::setView): Remove unneeded part->.
              (KWQKHTMLPart::document): Remove unneeded part->.
              (KWQKHTMLPart::renderer): Remove unneeded part->.
              (KWQKHTMLPart::userAgent): Remove unneeded part->.
              (KWQKHTMLPart::nextKeyViewInFrame): KWQ() instead of ->kwq.
              (KWQKHTMLPart::nextKeyViewInFrameHierarchy): KWQ() instead of ->kwq.
              (KWQKHTMLPart::canCachePage): Remove unneeded part->.
              (KWQKHTMLPart::saveWindowProperties): Use this instead of part.
              (KWQKHTMLPart::saveLocationProperties): Use this instead of part.
              (KWQKHTMLPart::restoreWindowProperties): Use this instead of part.
              (KWQKHTMLPart::restoreLocationProperties): Use this instead of part.
              (KWQKHTMLPart::openURLFromPageCache): Remove unneeded part->.
              (KWQKHTMLPart::partForNode): KWQ() instead of ->kwq.
              (KWQKHTMLPart::updatePolicyBaseURL): Remove unneeded part->.
              (KWQKHTMLPart::setPolicyBaseURL): Remove unneeded part->.
              (KWQKHTMLPart::createDummyDocument): Use this instead of part.
              (KWQKHTMLPart::scrollToAnchor): Remove unneeded part->.
              (KWQKHTMLPart::closeURL): Added. Calls saveDocumentState().
              * kwq/WebCoreBridge.h: Use KWQKHTMLPart instead of KHTMLPart.
              * kwq/WebCoreBridge.mm: (-[WebCoreBridge init]): Make a KWQKHTMLPart.
      	Use _part instead of _part->kwq in the rest of the file.
              * kwq/KWQSignal.mm: (KWQSignal::disconnect): Add the names of a few signals that are
      	disconnected after the KWQKHTMLPart part of the KHTMLPart is destroyed, to avoid noise.
              * khtml/ecma/kjs_navigator.cpp: (Navigator::getValueProperty): KWQ() instead of ->kwq.
              * khtml/ecma/kjs_proxy.cpp: (KJSProxyImpl::initScript): KWQ() instead of ->kwq.
              * khtml/ecma/kjs_window.cpp:
              (Window::scheduleClose): KWQ() instead of ->kwq.
              (WindowFunc::tryCall): KWQ() instead of ->kwq.
              * khtml/xml/dom_docimpl.cpp: (DocumentImpl::setTitle): KWQ() instead of ->kwq.
              * kwq/KWQKHTMLPartBrowserExtension.mm:
              (KHTMLPartBrowserExtension::openURLRequest): KWQ() instead of ->kwq.
              (KHTMLPartBrowserExtension::createNewWindow): KWQ() instead of ->kwq.
              (KHTMLPartBrowserExtension::setIconURL): KWQ() instead of ->kwq.
              (KHTMLPartBrowserExtension::setTypedIconURL): KWQ() instead of ->kwq.
              * kwq/KWQKJavaAppletWidget.mm: (KJavaAppletWidget::showApplet): KWQ() instead of ->kwq.
              * kwq/KWQLoader.mm:
              (KWQServeRequest): Cast to KWQKHTMLPart instead of casting to KHTMLPart and doing ->kwq.
              (KWQCheckIfReloading): Ditto.
              (KWQCheckCacheObjectStatus): Ditto.
              * WebCore.pbproj/project.pbxproj: Let Electron punish the wicked.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2982 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • trey's avatar
      Fixed 3115903 - exchangehomes.com sometimes has form state poorly restored · 14525a90
      trey authored
      	KHTML is much smarter about restoring form state now, taking into account element names and
      	types instead of blindly blasting data by simple element ordering.  We encode the name
      	and type at the front of the "state" strings that previously just held the value of the
      	QString::endsWith() was just plain wrong.  Looks like it had some copied code, but was
      	never really implemented.
              Reviewed by: Darin Adler
              * WebCore.pbproj/project.pbxproj:  PB is hellbent on adding "shouldUseHeadermap = 0;"
              * khtml/html/html_formimpl.cpp:
              (encodedElementName):  Utility func to encode an element name, escaping amp and lt
              (HTMLGenericFormElementImpl::state):  Build the prefix of an element's state string,
              (HTMLGenericFormElementImpl::findMatchingState):  Find a matching piece of state out of
      	the list of state strings that were previously saved.
              (HTMLFieldSetElementImpl::type):  Return our element type.
              (HTMLInputElementImpl::state):  Call super as part of building state string.
              (HTMLInputElementImpl::restoreState):  Use findMatchingState.
              (HTMLLegendElementImpl::type):  Return our element type.
              (HTMLSelectElementImpl::state):  Call super as part of building state string.
              (HTMLSelectElementImpl::restoreState):  Use findMatchingState.
              (HTMLKeygenElementImpl::type):  Return our element type.
              (HTMLOptGroupElementImpl::type):  Return our element type.
              (HTMLOptionElementImpl::type):  Return our element type.
              (HTMLTextAreaElementImpl::state):  Call super as part of building state string.
              (HTMLTextAreaElementImpl::restoreState):  Use findMatchingState.
              * khtml/html/html_formimpl.h:  type() is moved up to HTMLGenericFormElementImpl
              * khtml/html/htmlparser.cpp:
              (KHTMLParser::insertNode):  Pass list of states to restoreState.
              (KHTMLParser::popOneBlock):  Pass list of states to restoreState.
              * khtml/xml/dom_docimpl.h:  Add method to return the whole list of form states.
              * khtml/xml/dom_nodeimpl.cpp:
              (NodeImpl::restoreState):    Nodes receive the whole list of form states to restore from,
      	not just a single state that has already been chosen.
              * khtml/xml/dom_nodeimpl.h:
              * kwq/KWQString.mm:
              (QString::endsWith):  Walk the search string correctly.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2977 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  9. 08 Dec, 2002 1 commit
    • darin's avatar
      WebFoundation: · 70b6438f
      darin authored
              Reviewed by Don and Dave.
              * English.lproj/StringsNotToBeLocalized.txt: Updated for recent changes.
              * WebFoundation.pbproj/project.pbxproj: Let Electron be Electron.
              Reviewed by Don and Dave.
      	- fixed 3115845 -- bad-pointer crash destroying DOM tree reproducible at a particular site
      	All hail libgmalloc, without which this would just be another bug I can't reproduce!
      	This memory trasher bug was caused bug calling setChildrenLoaded after casting a node to
      	HTMLObjectElementImpl, when the node wasn't always an object element. It turns out that this
              fix was made obsolete a while back when I changed close on renderers to be delivered even for
              cases where the renderer is not created yet at close time.
              * khtml/html/htmlparser.cpp: (KHTMLParser::processCloseTag): Remove the special case for
      	</object>. Now that this is fixed another way we don't need this at all.
              * khtml/html/html_objectimpl.h: Remove setChildrenLoaded and m_childrenLoaded.
              * khtml/html/html_objectimpl.cpp: (HTMLObjectElementImpl::HTMLObjectElementImpl):
      	Remove code that sets m_childrenLoaded to false.
              (HTMLObjectElementImpl::attach): Remove code that looks at m_childrenLoaded, since we don't
      	need it any more (and in fact there's no way to set it any more).
      	- fixed 3120578 -- REGRESSION: going to about:blank creates null view
      	If no tokens are ever sent to the parser, then we end up without a render tree.
              * khtml/html/htmlparser.h: Add finished() function.
              * khtml/html/htmlparser.cpp: (KHTMLParser::finished): Make an HTML element if the document is still
      	empty at this point. This is identical to what KHTMLParser::insertNode does when you insert any kind
      	of element other than an HTML element.
              * khtml/html/htmltokenizer.cpp: (HTMLTokenizer::end): Call finished() to let the parser know.
              * kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::paint): Turn on the "paint red" feature in development builds.
      	Null view problems are particularly hard to debug without something like this, and we don't care
      	if development builds are ever-so-slightly slower. No change in deployment.
      	- fixed 3121527 -- crash in WebCoreBridge frameBorderStyle
              * kwq/WebCoreBridge.mm: (-[WebCoreBridge frameBorderStyle]): Handle case where this is called and
      	we don't have a KHTMLView yet.
      	- other changes
              * WebCore.pbproj/project.pbxproj: Electron is doing his thing.
              Reviewed by Don and Dave.
      	- fixed 3120578 -- REGRESSION: going to about:blank creates null view
      	This part of the fix makes sure that a renderer is created, even when there are no bytes
      	of data passed through. This makes the empty document about:blank case work just like the
      	"document with just whitespace in it case". There's another part of the fix in WebCore that
      	takes care of the remaining problem.
              * WebView.subproj/WebHTMLRepresentation.m:
              (-[WebHTMLRepresentation finishedLoadingWithDataSource:]):
      	Call receivedData:withDataSource: on the bridge with nil for the data. It would be even more
      	elegant to add a new call for the case where we finish, but it's not necessary, since the
      	existing receivedData: call does all the right things if passed nil.
              * WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _finishedLoading]):
      	Call finishedLoadingWithDataSource: here, to make sure it's done after committing.
      	This parallels what we already do for the didReceiveData call.
              * WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient handleDidFinishLoading:]):
      	Remove the call to finishedLoadingWithDataSource: because it's handled by _finishedLoading now.
      	This parallels what we already do for the didReceiveData call.
      	- fixed long standing problem where resizing could make you see a "null view"
              * WebView.subproj/WebView.m:
              (-[WebView drawRect:]): Add a "paint cyan" feature in development builds.
      	Null view problems are particularly hard to debug without something like this,
      	and we don't care if development builds are slightly slower. No change in deployment.
              (-[WebView setFrameSize:]): Tell the scroll view to draw the background if we are
      	resized. We can't do our "let the old bits show through" thing any more if we have to
      	redraw because of resizing.
      	- other changes
              * WebKit.pbproj/project.pbxproj: Remove the old -DAPPLE_CHANGES and -DHAVE_CONFIG_H that we
              once needed when WebKit used to compile  C++ headers from the KHTML part of WebCore.
              We haven't needed those for ages. Also sort things a bit, using the new Electron feature for
      	sorting lists of files alphabetically, and some by hand.
              * English.lproj/StringsNotToBeLocalized.txt: Update for recent changes.
      	Reviewed by Don and Dave.
              * English.lproj/StringsNotToBeLocalized.txt: Update for recent changes.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2970 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  10. 06 Dec, 2002 1 commit
    • mjs's avatar
      JavaScriptCore: · 7c2d8083
      mjs authored
              Reviewed by: Darin Adler
      	- made framework embedding work correctly with buildit
              * JavaScriptCore.pbproj/project.pbxproj: Give framework a relative
      	install path, don't install it the normal way, and copy it
      	manually to /AppleInternal/Library/Frameworks if installing.
              Reviewed by: Darin Adler
      	- made framework embedding work correctly with buildit
              * WebFoundation.pbproj/project.pbxproj: Give framework a relative
      	install path, don't install it the normal way, and copy it
      	manually to /AppleInternal/Library/Frameworks if installing.
              Reviewed by: Darin Adler
      	- made framework embedding work correctly with buildit
              * WebCore.pbproj/project.pbxproj: Give framework a relative
      	install path, don't install it the normal way, and copy it
      	manually to /AppleInternal/Library/Frameworks if installing. Also
      	look for other frameworks in
              Reviewed by: Darin Adler
      	- made framework embedding work correctly with buildit
              * WebKit.pbproj/project.pbxproj: Give framework a relative
      	install path, don't install it the normal way, and copy it
      	manually to /AppleInternal/Library/Frameworks if installing. Also
      	look for other frameworks in
              Reviewed by: Darin Adler
      	- made framework embedding work correctly with buildit
              * copy-frameworks-to-dstroot.sh: Copy frameworks from
              * embed-frameworks.sh: Fixed typo.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2958 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  11. 17 Nov, 2002 1 commit
    • mjs's avatar
      WebCore: · bb798fe2
      mjs authored
      	- fixed 2949193 - implement onKeyDown, onKeyPress, and onKeyUp event handlers
              * khtml/html/html_formimpl.cpp:
              * kwq/KWQEvent.h:
              * kwq/KWQEvent.mm:
              (QKeyEvent::QKeyEvent): Implemented.
              (QKeyEvent::key): Likewise.
              (QKeyEvent::state): Likewise.
              (QKeyEvent::accept): Likewise.
              (QKeyEvent::ignore): Likewise.
              (QKeyEvent::isAutoRepeat): Likewise.
              (QKeyEvent::text): Likewise.
              (QKeyEvent::ascii): Likewise.
              (QKeyEvent::count): Likewise.
              (QKeyEvent::isAccepted): Likewise.
              * kwq/KWQKHTMLPart.h:
              * kwq/KWQKHTMLPart.mm:
              (KWQKHTMLPart::keyEvent): Translate the event to a QEvent and send
      	it through the DOM event mechanism.
              * kwq/WebCoreBridge.h:
              * kwq/WebCoreBridge.mm:
              (-[WebCoreBridge interceptKeyEvent:toView:]): Pass event to the
      	KWQ part.
      	* kwq/WebCoreBridgePrivate.h: Added.
              * WebCore.pbproj/project.pbxproj: Added new file.
      	- fixed 2949193 - implement onKeyDown, onKeyPress, and onKeyUp event handlers
              * WebView.subproj/WebHTMLViewPrivate.h:
              * WebView.subproj/WebHTMLViewPrivate.m:
              (+[WebHTMLView load]): Pose as NSWindow too now.
              (-[WebHTMLView _interceptKeyEvent:toView:]): Pass event to WebCore and
      	see if WebCore wants to block it.
              (-[WebNSWindow sendEvent:]): For all key events that would go to a
      	subview of a WebHTMLView, let the WebHTMLView take a first crack
      	at it.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2718 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  12. 15 Nov, 2002 1 commit
    • darin's avatar
      Tools: · 56fdc7dc
      darin authored
              * Scripts/update-alex-localizable-strings: Fix it so that the line
      	numbers in error messages will be accurate.
      	- fixed 3027460 -- text areas don't have focus rectangles
      	- fixed 2937204 -- text areas have solid black borders
              * kwq/KWQSignal.mm: (KWQSignal::disconnect):
      	Add a special case so we don't hear about finishedParsing all the time.
              * kwq/KWQTextArea.mm:
              (-[KWQTextArea initWithFrame:]): Use a bezel border, not a line border.
              (-[KWQTextArea getCursorPositionAsIndex:inParagraph:]): Fix bug where it would
      	return a bogus value for an empty text area.
              (-[KWQTextArea setCursorPositionToIndex:inParagraph:]): Use setSelectedRange:
      	ratherr than setMarkedText:selectedRange:.
              (-[KWQTextArea drawRect:]): Draw a focus ring if our text view is first responder.
              (-[KWQTextArea _KWQ_setKeyboardFocusRingNeedsDisplay]): Added.
              (-[KWQTextAreaTextView becomeFirstResponder]): Call _KWQ_setKeyboardFocusRingNeedsDisplay.
              (-[KWQTextAreaTextView resignFirstResponder]): Call _KWQ_setKeyboardFocusRingNeedsDisplay.
              (-[NSView _KWQ_setKeyboardFocusRingNeedsDisplay]): Calls the same thing on parent.
              * WebCore.pbproj/project.pbxproj: PB is a cruel master.
      	- fixed problem I introduced where text would get too close to the right button
              * LocationTextField.m: (-[LocationTextField didShowOrHideRightButton]):
      	Add back logic to adjust the right border. I removed this because it was incompatible
      	with my changes, but now I made a new compatible version by adding a new method.
              * TextFieldWithControls.h: Rename showRightButton: to setIsShowingRightButton:,
      	and added isShowingRightButton, and didShowOrHideRightButton methods.
              * TextFieldWithControls.m:
              (-[TextFieldWithControls isShowingRightButton]): Added.
              (-[TextFieldWithControls didShowOrHideRightButton]): Added.
              (-[TextFieldWithControls setIsShowingRightButton:]): Call didShowOrHideRightButton at
      	the right moment so we can properly respond to any changes it makes to the cell.
              * BrowserWindowController.m: (-[BrowserWindowController updateSnapBackButtons]):
      	Update for method name change.
              * WebBrowser.pbproj/project.pbxproj: PB is a cruel master.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2691 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  13. 14 Nov, 2002 2 commits
    • darin's avatar
      WebCore: · bd6a1fde
      darin authored
      	- fixed most of the problems with OPTGROUP
              * khtml/html/htmlparser.cpp: (KHTMLParser::insertNode):
      	Make OPTGROUPs pop out of other unclosed OPTGROUPs, not just out of options.
              * kwq/KWQListBox.h: Add private member function.
              * kwq/KWQListBox.mm:
              (QListBox::insertItem): Use shared insertItem function.
              (QListBox::insertGroupLabel): Create an attributed string for the group label,
      	with bold font.
              (-[KWQListBoxTableViewDelegate tableView:shouldSelectRow:]): Return YES only
      	for the plain strings, that way you can't select the group labels.
              * WebCore.pbproj/project.pbxproj: Let PB do its thing.
              * BrowserDocument.h: Remove unused BrowserDocumentPageTitleChangedNotification.
              * BrowserDocument.m:
              (-[BrowserDocument _pageTitleHasChanged]): Remove unused notification.
              (-[BrowserDocument goToBugReportingPage:]): Escape URL so it works in the form parameters.
              * PoofAnimator.m: (-[PoofAnimator init]): Remove use of private _setHasShadow:
      	which is just the same thing as the public setHasShadow:.
              * BrowserWindowController.m: Tweak formatting.
              * Preferences.subproj/GeneralPreferences.m: Tweak.
              * WebBrowser.pbproj/project.pbxproj: Let PB do its thing.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2685 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • darin's avatar
      WebCore: · 3866e312
      darin authored
      	- fixed 3100235 -- nil-deference in khtml::RenderTable at money.cnn.com
              * kwq/WebCoreBridge.h: Add needsLayout.
              * kwq/WebCoreBridge.mm: (-[WebCoreBridge needsLayout]): Return true if the render
      	tree root says "layouted" is false. It would be more elegant to use more of this
      	WebCore layout logic and have less of our own on the WebKit side.
              * WebCore.pbproj/project.pbxproj: Oh, that Project Builder.
      	- fixed 3100235 -- nil-deference in khtml::RenderTable at money.cnn.com
              * WebView.subproj/WebHTMLView.m: (-[WebHTMLView drawRect:]):
      	If the WebCore side needs layout, then do layout before trying to draw.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2669 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  14. 13 Nov, 2002 2 commits
    • darin's avatar
      WebFoundation: · 82240090
      darin authored
              * Misc.subproj/WebAssertions.m: (vprintf_stderr_objc):
      	Don't use displayableString. Makes us able to build on Panther.
              * WebFoundation.pbproj/project.pbxproj: Project Builder wanted to touch this.
      	- fixed another crash on http://www.w3.org/Style/CSS/, but still not done
              * khtml/rendering/render_box.cpp: (RenderBox::setStyle): Call renderArena()
      	from RenderObject rather than going at the document directly. Safer because
      	it works even when we don't have a node yet.
              * khtml/rendering/render_flow.cpp: (RenderFlow::addChild): Ditto.
              * khtml/rendering/render_layer.cpp:
              (RenderLayer::paint): Ditto.
              (RenderLayer::nodeAtPoint): Ditto.
              (RenderLayer::constructZTree): Ditto.
              * khtml/rendering/render_list.cpp:
              (RenderListItem::setStyle): Ditto.
              * khtml/rendering/render_text.cpp:
              (RenderText::deleteSlaves): Ditto.
              (RenderText::position): Ditto. This is the one that actually crashed.
              * khtml/misc/makeattrs: Fixed handling of failure case.
              * khtml/misc/maketags: Ditto.
              * WebCore.pbproj/project.pbxproj: Project Builder wanted to touch this.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2666 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • darin's avatar
      WebCore: · 9aa61f37
      darin authored
              * kwq/KWQLineEdit.mm: (QLineEdit::sizeForCharacterWidth):
      	Use the "0" instead of the "x" as the canonical character for width.
      	This is slightly wider and is better for credit card numbers, for example.
              * WebCore.pbproj/project.pbxproj: Tweak.
              * English.lproj/StringsNotToBeLocalized.txt: Let the script sort this file.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2664 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  15. 12 Nov, 2002 1 commit
    • hyatt's avatar
      This patch lands a rewrite of whitespace-handling in the · 33f8d493
      hyatt authored
      	layout engine and adds support for the CSS2 white-space
      	It also includes a rewrite of inlines' min/max width
      	calculations (for both flow inlines and raw text).
      	A problem with <form> margins has been fixed (this is a
      	regression I caused with my collapsing margin checkin).
              * WebCore.pbproj/project.pbxproj:
              * khtml/css/html4.css:
              * khtml/html/dtd.cpp:
              * khtml/html/html_baseimpl.cpp:
              * khtml/html/html_formimpl.cpp:
              * khtml/html/html_formimpl.h:
              * khtml/html/html_imageimpl.cpp:
              * khtml/html/html_inlineimpl.cpp:
              * khtml/html/html_objectimpl.cpp:
              * khtml/html/htmlparser.cpp:
              * khtml/html/htmlparser.h:
              * khtml/html/htmltokenizer.cpp:
              * khtml/misc/arena.cpp: Added.
              * khtml/misc/arena.h: Added.
              * khtml/rendering/bidi.cpp:
              (BidiIterator::operator delete):
              * khtml/rendering/bidi.h:
              * khtml/rendering/render_arena.cpp: Added.
              * khtml/rendering/render_arena.h: Added.
              * khtml/rendering/render_box.cpp:
              * khtml/rendering/render_box.h:
              * khtml/rendering/render_br.cpp:
              * khtml/rendering/render_container.cpp:
              * khtml/rendering/render_container.h:
              * khtml/rendering/render_flow.cpp:
              * khtml/rendering/render_flow.h:
              * khtml/rendering/render_html.cpp:
              * khtml/rendering/render_layer.cpp:
              (RenderLayer::operator delete):
              (RenderLayer::RenderLayerElement::operator delete):
              (RenderLayer::RenderZTreeNode::operator delete):
              * khtml/rendering/render_layer.h:
              * khtml/rendering/render_list.cpp:
              * khtml/rendering/render_object.cpp:
              (RenderObject::operator delete):
              * khtml/rendering/render_object.h:
              * khtml/rendering/render_replaced.cpp:
              * khtml/rendering/render_replaced.h:
              * khtml/rendering/render_root.cpp:
              * khtml/rendering/render_table.cpp:
              * khtml/rendering/render_text.cpp:
              (TextSlave::operator delete):
              * khtml/rendering/render_text.h:
              * khtml/xml/dom_docimpl.cpp:
              * khtml/xml/dom_docimpl.h:
              * khtml/xml/dom_nodeimpl.cpp:
              * khtml/xml/dom_nodeimpl.h:
              * khtml/xml/dom_stringimpl.cpp:
              * khtml/xml/dom_stringimpl.h:
              * khtml/xml/dom_textimpl.cpp:
              * khtml/xml/dom_textimpl.h:
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2635 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  16. 11 Nov, 2002 1 commit
    • darin's avatar
      - fixed 3092421 -- javascript: URL that opens window crashes Alex if typed into empty window · 0e8c0cec
      darin authored
              * kwq/KWQKHTMLPart.h:
              * kwq/KWQKHTMLPart.mm:
              (KWQKHTMLPart::KWQKHTMLPart): Set _ownsView to false.
              (KWQKHTMLPart::~KWQKHTMLPart): Delete the view if we own it. Also release
      	_currentEvent to fix a leak.
              (KWQKHTMLPart::setView): Delete the old view if we own it. Also, set the
      	_ownsView flag.
              (KWQKHTMLPart::createDummyDocument): Create a dummy view too.
              * kwq/KWQDummyView.h: Added.
              * kwq/KWQDummyView.m: Added.
              * WebCore.pbproj/project.pbxproj: Added KWQDummyView.
              * kwq/WebCoreBridge.h: Remove bridgeOwnsKHTMLView and currentEvent.
              * kwq/WebCoreBridge.mm:
              (-[WebCoreBridge createKHTMLViewWithNSView:marginWidth:marginHeight:]):
      	Pass true to setView instead of setting bridgeOwnsKHTMLView.
              (-[WebCoreBridge removeFromFrame]): Just call setView on the part. It
      	knows how to handle ownership now.
              (-[WebCoreBridge installInFrame:]): Call setOwnsView instead of setting
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2625 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  17. 30 Oct, 2002 2 commits
    • rjw's avatar
      More work on bidi and contextual forms. · 412938f8
      rjw authored
              Table lookup code for unicode characters attributes.
              * Misc.subproj/WebUnicode.h: Added.
              * Misc.subproj/WebUnicode.m: Added.
              * Misc.subproj/WebUnicodeTables.m: Added.
              * WebKit.pbproj/project.pbxproj:
              Additional logging parameter.
              * Misc.subproj/WebKitLogging.h:
              * Misc.subproj/WebKitLogging.m:
              More work on bidi and contextual forms.
              Table lookup code is up in WebKit. Function
              pointers are used to isolate WebCore from private
              implementation in WebKit.  Needs to be fast, so
              the usual ObjC abstraction won't work.
              * WebCore.exp:
              * WebCore.pbproj/project.pbxproj:
              * kwq/KWQChar.mm:
              * kwq/KWQString.h:
              * kwq/WebCoreUnicode.cpp: Added.
              * kwq/WebCoreUnicode.h: Added.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2515 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • darin's avatar
      - fixed 3083982 -- Logging into AOL gives null view, crash · ae96c6c8
      darin authored
      	I fixed the crash part. Not the "gives null view" part.
      	The key was to disentangle the references and lifetimes of the transfer job class,
      	and the resource loader object that KWQ uses to connect it with WebKit.
              * kwq/KWQKJobClasses.h: Change the job to keep a loader reference, not a
      	handle reference. The job needs to inform the loader when it's being deallocated.
              * kwq/KWQKJobClasses.mm: Use jobWillBeDeallocated instead of cancel when the
      	job is deallocated.
              * kwq/KWQLoader.mm: (KWQServeRequest): Use KWQResourceLoader, now with a home in
      	a separate file.
              * kwq/KWQResourceLoader.h: Added.
              * kwq/KWQResourceLoader.mm: Added.
              * WebCore.pbproj/project.pbxproj: Added KWQResourceLoader files.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2508 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  18. 26 Oct, 2002 4 commits
    • darin's avatar
      - fixed a couple of files accidentally checked in with KWQQ names · c1390c8a
      darin authored
              * ForwardingHeaders/qasyncio.h: Change names.
              * ForwardingHeaders/qstylesheet.h: Ditto.
              * WebCore.pbproj/project.pbxproj: Ditto.
              * kwq/KWQMovie.h: Ditto.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2481 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • darin's avatar
      - changed naming scheme in KWQ for files like qstring.h · b381a87d
      darin authored
              Now use names like KWQString.h and make a forwarding header called qstring.h.
              * tons of files
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2478 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • darin's avatar
      WebCore: · a8052be3
      darin authored
      	- fixed 3068404 -- eliminate all user-visible messages from WebCore
              * khtml/ecma/kjs_window.cpp: (WindowFunc::tryCall): Use runJavaScriptPrompt
      	function instead of the more generic QInputDialog.
              * khtml/html/html_formimpl.cpp: (HTMLInputElementImpl::altText): Get
      	submit alt text for input element from the view factory, rather than using
      	i18n, since we don't support that.
              * khtml/html/htmlparser.cpp: (KHTMLParser::handleIsindex): Ditto, for the
      	intro that says "This is a searchable index".
              * khtml/rendering/render_form.cpp:
              (RenderSubmitButton::defaultLabel): Ditto, for "Submit".
              (RenderResetButton::defaultLabel): Ditto, for "Reset".
              (RenderFileButton::slotClicked): Ifdef'd out this unused code that had i18n text in it.
              * khtml/xml/xml_tokenizer.cpp:
              (XMLHandler::errorString): Put in an ifdef and a FIXME to avoid i18n.
              (XMLHandler::fatalError): Ditto.
              (XMLTokenizer::finish): Ditto.
              * khtml/misc/decoder.cpp: (Decoder::decode): Ifdef'd the check for the first
      	language being "ja", since that's not how we're going to trigger Japanese
              * khtml/rendering/render_applet.cpp: (RenderEmptyApplet::RenderEmptyApplet):
      	Turned off the code that does the empty applet label. I don't think it worked,
      	and it used i18n. We'll have to tackle this eventually.
              * kwq/KWQKHTMLPartImpl.h: Added runJavaScriptPrompt.
              * kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::runJavaScriptPrompt): Moved the code
      	here that used to be in KWQInputDialog.
              * kwq/kdecore/klocale.h: Remove i18n() and KLocale::languageList(), added the functions
      	that are listed below.
              * kwq/KWQKLocale.mm:
              (inputElementAltText): Added specific function for getting one of the very few
      	translated strings that we need in WebCore.
              (resetButtonDefaultLabel): Ditto.
              (searchableIndexIntroduction): Ditto.
              (submitButtonDefaultLabel): Ditto.
              (KLocale::language): Use the view factory to ask for the language code, since there's no
      	public API to get it that WebCore can use.
              * kwq/WebCoreViewFactory.h: Add new API for above.
              * ForwardingHeaders/qinputdialog.h: Added empty file.
              * kwq/qt/qinputdialog.h: Removed.
              * kwq/KWQInputDialog.mm: Removed.
              * WebCore.pbproj/project.pbxproj: Removed QInputDialog files.
              * WebCoreSupport.subproj/WebViewFactory.m:
              (-[WebViewFactory inputElementAltText]): Added.
              (-[WebViewFactory resetButtonDefaultLabel]): Added.
              (-[WebViewFactory searchableIndexIntroduction]): Added.
              (-[WebViewFactory submitButtonDefaultLabel]): Added.
              (-[WebViewFactory defaultLanguageCode]): Added.
              * English.lproj/Localizable.strings: Update.
              * English.lproj/StringsNotToBeLocalized.txt: Update.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2477 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • darin's avatar
      WebCore: · db9d82e2
      darin authored
      	Remove some user-visible strings. We can't have any strings that need
      	localization in WebCore, given our translation strategy.
              * khtml/html/html_formimpl.cpp: (HTMLInputElementImpl::encoding):
      	Put APPLE_CHANGES around some i18n dialog code.
              * khtml/khtml_part.cpp: (KHTMLPart::submitForm): Ditto.
              * khtml/rendering/render_frames.cpp:
              (RenderPartObject::slotPartLoadingErrorNotify): Ditto.
              * khtml/ecma/kjs_window.cpp:
              (Window::get): Ditto.
              (Window::scheduleClose): Ditto.
              (WindowFunc::tryCall): Put APPLE_CHANGES in to use JavaScript-specific methods
              in the part of calling the generic ones from KMessageBox.
              * ForwardingHeaders/kmessagebox.h: Added (empty file).
              * kwq/KWQKHTMLPartImpl.h: Added new runJavaScript functions.
              * kwq/KWQKHTMLPartImpl.mm:
              (KWQKHTMLPartImpl::runJavaScriptAlert): Added.
              (KWQKHTMLPartImpl::runJavaScriptConfirm): Added.
              * kwq/WebCoreViewFactory.h: Added runJavaScriptAlertPanelWithMessage and
              * kwq/kdeui/kmessagebox.h: Removed.
              * kwq/KWQKMessageBox.mm: Removed.
              * WebCore.pbproj/project.pbxproj: Removed the KMessageBox files.
              * WebCoreSupport.subproj/WebViewFactory.m:
              (-[WebViewFactory runJavaScriptAlertPanelWithMessage:]): Added.
              (-[WebViewFactory runJavaScriptConfirmPanelWithMessage:]): Added.
              * English.lproj/Localizable.strings: Update.
              * English.lproj/StringsNotToBeLocalized.txt: Update.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2476 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  19. 24 Oct, 2002 1 commit
    • darin's avatar
      A step in the direction of making KWQ headers much nicer. · 00a2a76d
      darin authored
      	Move all empty headers out of kwq, and into ForwardingHeaders.
              * ForwardingHeaders/kcmdlineargs.h: Added.
              * ForwardingHeaders/kdatastream.h: Added.
              * ForwardingHeaders/khtml_iface.h: Added.
              * ForwardingHeaders/khtml_printsettings.h: Added.
              * ForwardingHeaders/khtml_run.h: Added.
              * ForwardingHeaders/kio/kprinter.h: Added.
              * ForwardingHeaders/kio/kprotocolmanager.h:
              * ForwardingHeaders/kio/ktrader.h: Added.
              * ForwardingHeaders/kio/scheduler.h: Added.
              * ForwardingHeaders/kmultipledrag.h: Added.
              * ForwardingHeaders/kprinter.h: Added.
              * ForwardingHeaders/kprotocolmanager.h: Added.
              * ForwardingHeaders/ksslcertchain.h: Added.
              * ForwardingHeaders/ksslinfodlg.h: Added.
              * ForwardingHeaders/kstdaction.h: Added.
              * ForwardingHeaders/ktempfile.h: Added.
              * ForwardingHeaders/ktrader.h: Added.
              * ForwardingHeaders/kurldrag.h: Added.
              * ForwardingHeaders/kxmlguifactory.h: Added.
              * ForwardingHeaders/qasyncimageio.h: Added.
              * ForwardingHeaders/qbitmap.h: Added.
              * ForwardingHeaders/qclipboard.h: Added.
              * ForwardingHeaders/qfontdatabase.h: Added.
              * ForwardingHeaders/qglobal.h: Added.
              * ForwardingHeaders/qhbox.h: Added.
              * ForwardingHeaders/qintcache.h: Added.
              * ForwardingHeaders/qintdict.h: Added.
              * ForwardingHeaders/qmetaobject.h: Added.
              * ForwardingHeaders/qobjectlist.h: Added.
              * ForwardingHeaders/scheduler.h: Added.
              * kwq/dcop/kdatastream.h: Removed.
              * kwq/kdecore/kcmdlineargs.h: Removed.
              * kwq/kdecore/kmultipledrag.h: Removed.
              * kwq/kdecore/ktempfile.h: Removed.
              * kwq/kdecore/kurldrag.h: Removed.
              * kwq/kdeui/kstdaction.h: Removed.
              * kwq/kdeui/kxmlguifactory.h: Removed.
              * kwq/khtml/khtml_iface.h: Removed.
              * kwq/khtml/khtml_printsettings.h: Removed.
              * kwq/khtml/khtml_run.h: Removed.
              * kwq/kio/kprinter.h: Removed.
              * kwq/kio/kprotocolmanager.h: Removed.
              * kwq/kio/kssl/ksslcertchain.h: Removed.
              * kwq/kio/kssl/ksslinfodlg.h: Removed.
              * kwq/kio/ktrader.h: Removed.
              * kwq/kio/scheduler.h: Removed.
              * kwq/qt/qasyncimageio.h: Removed.
              * kwq/qt/qbitmap.h: Removed.
              * kwq/qt/qclipboard.h: Removed.
              * kwq/qt/qfontdatabase.h: Removed.
              * kwq/qt/qglobal.h: Removed.
              * kwq/qt/qhbox.h: Removed.
              * kwq/qt/qintcache.h: Removed.
              * kwq/qt/qintdict.h: Removed.
              * kwq/qt/qmetaobject.h: Removed.
              * kwq/qt/qobjectlist.h: Removed.
              * WebCore.pbproj/project.pbxproj: Removed all the above headers from
      	the project.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2457 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  20. 21 Oct, 2002 1 commit
    • darin's avatar
      WebCore: · d9650806
      darin authored
              * kwq/KWQInputDialog.mm: (QInputDialog::getText): Call the view factory to do the
      	heavy lifting.
              * kwq/WebCoreViewFactory.h: Add runJavaScriptTextInputPanelWithPrompt:defaultText:returningText:.
      	Use a protocol for the subclass responsibility.
              * kwq/WebCoreViewFactory.m: Remove stub methods not needed because of the subclass responsibility
      	technique we are using.
              * kwq/qt/qstylesheet.h: Made this inline, since it does nothing.
              * kwq/KWQStyleSheet.mm: Removed.
              * WebCore.pbproj/project.pbxproj: Removed KWQStyleSheet.mm.
              * WebCoreSupport.subproj/WebViewFactory.h: Changed to use new protocol scheme so we
      	get an error if we forget to implement something.
              * WebCoreSupport.subproj/WebViewFactory.m:
              (-[WebViewFactory runJavaScriptTextInputPanelWithPrompt:defaultText:returningText:]): Stub.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2405 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  21. 08 Oct, 2002 2 commits
    • darin's avatar
      * WebCore.pbproj/project.pbxproj: Project Builder wanted to set encodings · a888fe35
      darin authored
      	for new files. Maybe Richard is not using the new Project Builder on all
      	his machines?
              * kwq/KWQString.mm: (_allocateNode): Fix typo in comment.
              * kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::bridgeForFrameName): Tweak.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2287 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • rjw's avatar
      Fixes to the DOM API. · ff90f422
      rjw authored
              * DOM.subproj/WebDOMDocument.h:
              * DOM.subproj/WebDOMDocument.m:
              * DOM.subproj/WebDOMNode.h:
              * DOM.subproj/WebDOMNode.m:
              * DOM.subproj/WebDOMNamedNodeMap.h: Removed.
              * DOM.subproj/WebDOMNamedNodeMap.m: Removed.
              * WebKit.pbproj/project.pbxproj:
              First cut at ObjC stubs for DOM API.  Finished the
              main classes.  Need to finish
              WebDOMElement, WebDOMElement, WebDOMElement,
              WebDOMCDATASection, WebDOMText, WebDOMComment,
              WebDOMCharacterData and
              * WebCore.pbproj/project.pbxproj:
              * khtml/dom/dom_doc.h:
              * khtml/dom/dom_element.h:
              * khtml/dom/dom_node.h:
              * khtml/xml/dom_docimpl.h:
              * khtml/xml/dom_elementimpl.h:
              * khtml/xml/dom_nodeimpl.h:
              * kwq/WebCoreDOM.h: Added.
              * kwq/WebCoreDOMDocument.mm: Added.
              (+[WebCoreDOMDocumentType documentTypeWithImpl:DOM::]):
              (-[WebCoreDOMDocumentType initWithImpl:DOM::]):
              (-[WebCoreDOMDocumentType dealloc]):
              (-[WebCoreDOMDocumentType DOM::]):
              (-[WebCoreDOMDocumentType name]):
              (-[WebCoreDOMDocumentType entities]):
              (-[WebCoreDOMDocumentType notations]):
              (-[WebCoreDOMDocumentType publicId]):
              (-[WebCoreDOMDocumentType systemId]):
              (-[WebCoreDOMDocumentType internalSubset]):
              (+[WebCoreDOMImplementation implementionatWithImpl:DOM::]):
              (-[WebCoreDOMImplementation initWithImpl:DOM::]):
              (-[WebCoreDOMImplementation dealloc]):
              (-[WebCoreDOMImplementation DOM::]):
              (-[WebCoreDOMImplementation hasFeature::]):
              (-[WebCoreDOMImplementation createDocument:::]):
              (+[WebCoreDOMDocument documentWithImpl:DOM::]):
              (-[WebCoreDOMDocument initWithImpl:DOM::]):
              (-[WebCoreDOMDocument dealloc]):
              (-[WebCoreDOMDocument DOM::]):
              (-[WebCoreDOMDocument doctype]):
              (-[WebCoreDOMDocument implementation]):
              (-[WebCoreDOMDocument documentElement]):
              (-[WebCoreDOMDocument createElement:]):
              (-[WebCoreDOMDocument createElementNS::]):
              (-[WebCoreDOMDocument createDocumentFragment]):
              (-[WebCoreDOMDocument createTextNode:]):
              (-[WebCoreDOMDocument createComment:]):
              (-[WebCoreDOMDocument createCDATASection:]):
              (-[WebCoreDOMDocument createProcessingInstruction::]):
              (-[WebCoreDOMDocument createAttribute:]):
              (-[WebCoreDOMDocument createAttributeNS::]):
              (-[WebCoreDOMDocument createEntityReference:]):
              (-[WebCoreDOMDocument getElementById:]):
              (-[WebCoreDOMDocument getElementsByTagName:]):
              (-[WebCoreDOMDocument getElementsByTagNameNS::]):
              (-[WebCoreDOMDocument importNode::]):
              * kwq/WebCoreDOMNode.mm: Added.
              (+[WebCoreDOMNode nodeWithImpl:DOM::]):
              (-[WebCoreDOMNode initWithImpl:DOM::]):
              (-[WebCoreDOMNode DOM::]):
              (-[WebCoreDOMNode dealloc]):
              (-[WebCoreDOMNode nodeName]):
              (-[WebCoreDOMNode nodeValue]):
              (-[WebCoreDOMNode setNodeValue:]):
              (-[WebCoreDOMNode nodeType]):
              (-[WebCoreDOMNode parentNode]):
              (-[WebCoreDOMNode firstChild]):
              (-[WebCoreDOMNode lastChild]):
              (-[WebCoreDOMNode previousSibling]):
              (-[WebCoreDOMNode nextSibling]):
              (-[WebCoreDOMNode ownerDocument]):
              (-[WebCoreDOMNode insert:before:]):
              (-[WebCoreDOMNode replace:child:]):
              (-[WebCoreDOMNode removeChild:]):
              (-[WebCoreDOMNode hasChildNodes]):
              (-[WebCoreDOMNode cloneNode:]):
              (-[WebCoreDOMNode normalize]):
              (-[WebCoreDOMNode isSupported::]):
              (-[WebCoreDOMNode namespaceURI]):
              (-[WebCoreDOMNode prefix]):
              (-[WebCoreDOMNode setPrefix:]):
              (-[WebCoreDOMNode localName]):
              (+[WebCoreDOMNodeList nodeListWithImpl:DOM::]):
              (-[WebCoreDOMNodeList initWithImpl:DOM::]):
              (-[WebCoreDOMNodeList DOM::]):
              (-[WebCoreDOMNodeList dealloc]):
              (+[WebCoreDOMNamedNodeMap namedNodeMapWithImpl:DOM::]):
              (-[WebCoreDOMNamedNodeMap initWithImpl:DOM::]):
              (-[WebCoreDOMNamedNodeMap DOM::]):
              (-[WebCoreDOMNamedNodeMap dealloc]):
              (-[WebCoreDOMNamedNodeMap length]):
              (-[WebCoreDOMNamedNodeMap getNamedItem:]):
              (-[WebCoreDOMNamedNodeMap setNamedItem:]):
              (+[WebCoreDOMAttr attrWithImpl:DOM::]):
              (-[WebCoreDOMAttr initWithImpl:DOM::]):
              (-[WebCoreDOMAttr DOM::]):
              (-[WebCoreDOMAttr dealloc]):
              (-[WebCoreDOMAttr name]):
              (-[WebCoreDOMAttr specified]):
              (-[WebCoreDOMAttr value]):
              (-[WebCoreDOMAttr ownerElement]):
              (+[WebCoreDOMCDATASection CDATASectionWithImpl:DOM::]):
              (-[WebCoreDOMCDATASection initWithImpl:DOM::]):
              (-[WebCoreDOMCDATASection DOM::]):
              (-[WebCoreDOMCDATASection dealloc]):
              * kwq/WebCoreDOMPrivate.h: Added.
              * kwq/WebDOMDocument.h: Added.
              * kwq/WebDOMElement.h: Added.
              * kwq/WebDOMNode.h: Added.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2277 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  22. 28 Sep, 2002 1 commit