GitLab

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3137 268f45cc-cd09-0410-ab3c-d52691b4dbfc

	- probably fixed 3129395 -- Reproducible crash when running a javascript at www.scenespot.org

        * WebCoreSupport.subproj/WebViewFactory.m:
        (-[WebViewFactory runJavaScriptTextInputPanelWithPrompt:defaultText:returningText:]):
        Close the window. Before we relied on it being released which was bad. But it's not clear this
        actually was the cause of the bug.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3136 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        * Plugins.subproj/WebBaseNetscapePluginView.m:
        (-[WebBaseNetscapePluginView sendEvent:]): Added an assert.
        (-[WebBaseNetscapePluginView setWindow]): Added an assert.
        (-[WebBaseNetscapePluginView stop]): Cancel perform requests, now that we are using them for
	URL navigation.
        (-[WebBaseNetscapePluginView frameStateChanged:]): Only notify if the plugin is still running.
        (-[WebBaseNetscapePluginView loadPluginRequest:]): Added. Does the actual load at idle time.
	Also fixed to only notify if plugin is loaded. Added a number of FIXMEs for other problems here.
	Also send JavaScript to the appropriate frame, not always the top level.
        (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:]): Use loadPluginRequest:
	to do the request after a delay. Also remove the special cases for special frame names; they
	were trying to avoid calling a plugin that has gone away, but we do that a better way now.
        (-[WebBaseNetscapePluginView getURLNotify:target:notifyData:]): Added logging.
        (-[WebBaseNetscapePluginView status:]): Use Windows Latin-1 rather than MacRoman for messages.
	I guess we should test later to find out which is used by MacIE and conform to that, but for now
	this seems like a better default.
        (-[WebPluginRequest initWithRequest:frame:notifyData:]): Added.
        (-[WebPluginRequest dealloc]): Added.
        (-[WebPluginRequest request]): Added.
        (-[WebPluginRequest webFrame]): Added.
        (-[WebPluginRequest notifyData]): Added.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3135 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        This bug should have been fixed be earlier changes.

        Reviewed by darin.

        * kwq/KWQPageState.mm:
        (-[KWQPageState dealloc]):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3134 268f45cc-cd09-0410-ab3c-d52691b4dbfc

	Fixed: 3131244 - REGRESSION: Java 1.4.1 Multiple Copies of Applet Started When Window is Resized

	Dave recently patched khtml with a fix for media content inside of table cells. The patch causes the java widget to get the layout call more than once. Calling layout more than once is perfectly allowed, but the java widget wasn't prepared for that and would create a new java view for each layout. We now only create a java view when the java view hasn't already been created.

        Reviewed by darin.

        * kwq/KWQKJavaAppletWidget.mm:
        (KJavaAppletWidget::showApplet): If the view of the widget is still a KWQView, we haven't replaced it with the Java view. This stops multiple view from being created.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3133 268f45cc-cd09-0410-ab3c-d52691b4dbfc

	- fixed fix for 3132056 -- Supply Finder bits for decoded BinHex files

        * Downloads.subproj/WebBinHexDecoder.m: (-[WebBinHexDecoder decodeHeader]):
	Mask off fewer Finder flag bits. Use the same mask as for MacBinary, in fact.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3132 268f45cc-cd09-0410-ab3c-d52691b4dbfc

	- fixed 3127490 -- pages w/frames sometimes show up blank

        * WebView.subproj/WebHTMLView.m: (-[WebHTMLView drawRect:]):
	Updated the optimization where we draw the entire view if we did a layout
	so that it works properly for the case where the clip is narrower because of
	the parent WebHTMLView.

        * English.lproj/StringsNotToBeLocalized.txt: Updated for recent changes.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3131 268f45cc-cd09-0410-ab3c-d52691b4dbfc

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3129 268f45cc-cd09-0410-ab3c-d52691b4dbfc

	3098388 - Pressing the back button goes back two levels at allmusic.com

	In support of the fix for this bug, WebCore passes khtml's lockHistory setting
	up through the bridge.

        Reviewed by Darin

        * kwq/KWQKHTMLPart.mm:
        (KWQKHTMLPart::redirectionTimerStartedOrStopped):  Pass it along.
        * kwq/WebCoreBridge.h:

WebKit:

	3098388 - Pressing the back button goes back two levels at allmusic.com

	I rewrote the logic we use to decide whether a given redirect should be
	treated as part of the previous navigation.  We make use of WebCore's
	lockHistory setting, the delay time and the frame state.

        Reviewed by Darin.

        * WebCoreSupport.subproj/WebBridge.m:
        (-[WebBridge reportClientRedirectToURL:delay:fireDate:lockHistory:]):
	Pass lockHistory up to the frame.
        * WebView.subproj/WebFramePrivate.h:
        * WebView.subproj/WebFramePrivate.m:
        (-[WebFrame _clientRedirectedTo:delay:fireDate:lockHistory:]):
	New logic.  No quick summary, best to read the code.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3128 268f45cc-cd09-0410-ab3c-d52691b4dbfc

	Reject the RealPlayer plug-in because we know it doesn't work.

        Reviewed by sullivan.

        * English.lproj/StringsNotToBeLocalized.txt:
        * Plugins.subproj/WebNetscapePluginPackage.m:
        (-[WebNetscapePluginPackage initWithPath:]): reject the RealPlayer plug-in

WebBrowser:

	Fixed: 3103603 - Safari becomes unresponsive while launching DiskCopy
	Special case RealPlayer and WMP plug-ins. Provide the option to open the content in the apps.

        Reviewed by sullivan.

        * BrowserNSWorkspaceExtras.m:
        (-[NSWorkspace launchApplicationAtPath:processSerialNumber:makeFrontmost:event:]): enable async launching of DiskCopy
        * English.lproj/Localizable.strings:
        * English.lproj/StringsNotToBeLocalized.txt:
        * LoadProgressMonitor.m:
        (-[LoadProgressMonitor pluginFailedWithError:dataSource:]): special case RealPlayer and WMP plug-ins. Provide the option to open the content in the apps.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3127 268f45cc-cd09-0410-ab3c-d52691b4dbfc

	Reviewed by John.

	- fixed 3131171 - Change Alex versions to satisfy both marketing and B&I requirements

        * Scripts/set-alex-version: New the script takes 3 different
	versions, source version, marketing version and internal version.

JavaScriptCore:

	Reviewed by John.

	- fixed 3131171 - Change Alex versions to satisfy both marketing and B&I requirements

        * English.lproj/InfoPlist.strings:
        * JavaScriptCore.pbproj/project.pbxproj:

WebFoundation:

	Reviewed by John.

	- fixed 3131171 - Change Alex versions to satisfy both marketing and B&I requirements

        * English.lproj/InfoPlist.strings:
        * WebFoundation.pbproj/project.pbxproj:

WebCore:

	Reviewed by John.

	- fixed 3131171 - Change Alex versions to satisfy both marketing and B&I requirements

        * English.lproj/InfoPlist.strings:

WebKit:

	Reviewed by John.

	- fixed 3131171 - Change Alex versions to satisfy both marketing and B&I requirements

        * English.lproj/InfoPlist.strings:

WebBrowser:

	Reviewed by John.

	- fixed 3131171 - Change Alex versions to satisfy both marketing and B&I requirements

        * English.lproj/InfoPlist.strings:
        * WebBrowser.pbproj/project.pbxproj:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3126 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        (Fixed yesterday, forgot to checkin.)

        Reviewed by trey.

        * WebView.subproj/WebFramePrivate.m:
        (-[WebFrame _setState:]):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3125 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Trey and Darin.

	Minor fixes required to fix these bugs:

	3124933 - abcnews.com leads to empty window with sheet complaining about javascript: URL
	3091248 - picture does not show up in window from epinions

	* CacheLoader.subproj/WebResourceResponse.h: Don't include uninstalled headers
	in this private but installed header.
        * ProtocolHandlers.subproj/WebAboutProtocolHandler.m:
        (-[WebAboutProtocolHandler setResponseMetadata:]): "about:blank"
	should be a blank html document, not a blank plain text document.
        * Misc.subproj/WebNSURLExtras.h:
        * Misc.subproj/WebNSURLExtras.m:
        (-[NSString _web_shouldLoadAsEmptyDocument]): New method.
	* English.lproj/StringsNotToBeLocalized.txt: Updated.

WebCore:

        Reviewed by Trey and Darin.

	- fixed 3124933 - abcnews.com leads to empty window with sheet complaining about javascript: URL
	- fixed 3091248 - picture does not show up in window from epinions


        * khtml/ecma/kjs_window.cpp:
        (Window::get): Put back document-creating code that was in #if
	!APPLE_CHANGES.
	(Window::isSafeScript): Extend access to a window that was opened
	to no URL or to about:blank by the active window.
        (shouldLoadAsEmptyDocument): Helper for the above.
        (WindowFunc::tryCall): Update APPLE_CHANGES comments - now it's
	clear we don't need to create a document in a fresh window
	(accessing document will take care of that), and that it will be
	counter-productive, possibly adding a useless entry to the
	back/forward list.
        * khtml/khtml_part.cpp:
        (KHTMLPart::begin): If we're not loading a URL, make a dummy
	document (the call will check if we have a dummy document
	already).
        * kwq/KWQKHTMLPart.mm:
	(KWQKHTMLPart::createEmptyDocument): Isntead of setting up a
	half-assed document, ask bridge to synchronously load a fully
	assed (but empty) document. Renamed from createDummyDocument.
        * kwq/KWQKHTMLPartBrowserExtension.mm:
        (KHTMLPartBrowserExtension::openURLRequest): Decode script. Also,
	check if return value is a string - if so, write it into the
	document. Maybe we want this to be more general.
        * kwq/KWQKURL.mm:
        (KURL::KURL): Changed to successfully resolve absolute URLs
	against an empty base URL.
        * kwq/WebCoreBridge.h: prototyped new
	loadEmptyDocumentSynchronously method.

WebKit:

        Reviewed by Darin and Trey.

	- fixed 3124933 - abcnews.com leads to empty window with sheet complaining about javascript: URL
	- fixed 3091248 - picture does not show up in window from epinions
	- made "about:blank" load synchronously, which I'm told is required by some sites.

        * WebCoreSupport.subproj/WebBridge.m:
        (-[WebBridge createWindowWithURL:frameName:]): If the URL is nil
	or empty, pass a nil request - otherwise WebBrowser will try to
	load it, resulting in an extra back/forward list entry.
        (-[WebBridge loadEmptyDocumentSynchronously]): Tell the frame to
	load a request with an empty URL - this will cause a synchronous
	load of an empty html document
        * WebView.subproj/WebBaseResourceHandleDelegate.h:
        * WebView.subproj/WebBaseResourceHandleDelegate.m:
	(-[WebBaseResourceHandleDelegate loadWithRequest:]): Split off
	startLoading: part of method to allow behavior to be subclassed.
        (-[WebBaseResourceHandleDelegate startLoading:]):
        * WebView.subproj/WebDataSourcePrivate.m:
        (-[WebDataSource _commitIfReady:]): Lie and claim the URL is
	"about:blank" if it's really empty to avoid confusing WebCore.
        * WebView.subproj/WebFramePrivate.m:
        (-[WebFrame _transitionToCommitted:]): Don't put the empty URL in
	global history.
        (-[WebFrame
	_checkNavigationPolicyForRequest:dataSource:andCall:withSelector:]):
	Don't check policy if URL is empty - this is likely to confuse the
	client and we know what the right behavior here is.
        * WebView.subproj/WebMainResourceClient.m:
	(-[WebMainResourceClient startLoading:]): Try to load
	"about:blank" and the empty URL synchronously, bypassing
	WebFoundation.
        (-[WebMainResourceClient continueAfterContentPolicy:response:]): Ditto.
        (-[WebMainResourceClient setDefersCallbacks:]): Ditto.
        * English.lproj/StringsNotToBeLocalized.txt: Updated.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3124 268f45cc-cd09-0410-ab3c-d52691b4dbfc

	Fixed: 3052731 - qt file complains about lack of active-x handler
	Fixed: 3025872 - Black square where lion should be on mgm.com

	3052731: The page has a syntax error. Notice the missing ">"? He treat this as an OBJECT without an EMBED. khtml actually has a fallback for this. They check the classid and map a mime type to it. They currently map for  realaudio and flash, but not quicktime. I added a quicktime mapping as well as a mapping for shockwave.

	3025872: khtml was unable to parse the EMBED tag within the OBJECT tag (similar to 3052731). When this happens, it looks at the classid and maps it to a mime type. This part was successful because it has a classid->mime type mapping for flash. The strange thing was that it was setting the main URL of the plug-in to "dummy". The code has this comment:

	url = "dummy"; // Not needed, but KHTMLPart aborts the request if empty

	It does this even if the url is valid. It even handles the invalid url case before even calling the part. The fix is to disable this line of code.

        Reviewed by trey.

        * khtml/rendering/render_frames.cpp:
        (RenderPartObject::updateWidget):

WebKit:

	Fixed: 2862385 - need to pass browser's user agent and version to plug-ins
	Added some more error checking to the plug-in code

        Reviewed by trey.

        * Plugins.subproj/WebBaseNetscapePluginView.h:
        * Plugins.subproj/WebBaseNetscapePluginView.m:
        (+[WebBaseNetscapePluginView setCurrentPluginView:]): new, sets a global variable for the current plug-in
        (+[WebBaseNetscapePluginView currentPluginView]): new, returns the current plug-in
        (-[WebBaseNetscapePluginView start]): check if NPP_New fails, return NO if it does, set the current plug-in view. Currently, this is the only place we need to do this.
        (-[WebBaseNetscapePluginView userAgent]): made instance-specific because it depends on the plug-in view's WebController
        * Plugins.subproj/WebBaseNetscapePluginViewPrivate.h:
        * Plugins.subproj/WebNetscapePluginEmbeddedView.m:
        (-[WebNetscapePluginEmbeddedView viewDidMoveToWindow]): don't start the stream is start fails
        * Plugins.subproj/npapi.m:
        (NPN_MemAlloc): tweak
        (NPN_RequestRead): tweak
        (pluginViewForInstance): returns the instance's plug-in view if it has one, if not, return the current plug-in view
        (NPN_GetURLNotify): get the instance from pluginViewForInstance
        (NPN_GetURL):
        (NPN_PostURLNotify):
        (NPN_PostURL):
        (NPN_NewStream):
        (NPN_Write):
        (NPN_DestroyStream):
        (NPN_UserAgent):
        (NPN_Status):
        (NPN_InvalidateRect):
        (NPN_InvalidateRegion):
        (NPN_ForceRedraw):
        (NPN_GetValue):
        (NPN_SetValue):
        (NPN_GetJavaEnv):
        (NPN_GetJavaPeer):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3123 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        contents of the frame changes as a result of user action.  The site mentioned
        is this bug branded a service by wrapping it in their own frameset.  That frameset
        had a different domain than the service, so our cookie policy prevented cookies
        from being set.

        Reviewed by trey.

        * WebView.subproj/WebDataSourcePrivate.m:
        (-[WebDataSource _startLoading:]):
        * WebView.subproj/WebFrame.m:
        (-[WebFrame loadRequest:]):
        * WebView.subproj/WebFramePrivate.h:
        * WebView.subproj/WebFramePrivate.m:
        (-[WebFrame _loadItem:fromItem:withLoadType:]):
        (-[WebFrame _addExtraFieldsToRequest:alwaysFromRequest:]):
        (-[WebFrame _loadURL:loadType:triggeringEvent:isFormSubmission:]):
        (-[WebFrame _postWithURL:data:contentType:triggeringEvent:]):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3122 268f45cc-cd09-0410-ab3c-d52691b4dbfc

	While downloading a file, Safari and the Finder take up 30%-40% of the CPU each. This is happening because for every chunk of data we write to disk, we call -[NSWorkspace noteFileSystemChanged:]. noteFileSystemChanged is inefficient. It sends 2 AppleEvents each with 60 timeouts. The event also causes the Finder to do a lot of work.

	We should:
	- Send 1 AppleEvent ourselves with no timeout since we don't care about the reply
	- Call the notification/event less often. The only benefit of sending the event for every chunk written is that the file size updates in the Finder. Not worth the performance impact.

        Reviewed by kocienda.

        * Downloads.subproj/WebDownloadHandler.m:
        (-[WebDownloadHandler cleanUpAfterFailure]): call _web_noteFileChangedAtPath
        (-[WebDownloadHandler createFileIfNecessary]): call _web_noteFileChangedAtPath
        (-[WebDownloadHandler writeDataForkData:resourceForkData:]): don't call noteFileSystemChanged
        (-[WebDownloadHandler finishedLoading]): call _web_noteFileChangedAtPath
        * Misc.subproj/WebNSWorkspaceExtras.h: Added.
        * Misc.subproj/WebNSWorkspaceExtras.m: Added.
        (-[NSWorkspace _web_noteFileChangedAtPath:]): Notifies the Finder (or any other app that cares) that we added, removed or changed the attributes of a file. This method is better than calling noteFileSystemChanged: because noteFileSystemChanged: sends 2 apple events both with a 60 second timeout. This method returns immediately.
        * WebKit.pbproj/project.pbxproj:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3121 268f45cc-cd09-0410-ab3c-d52691b4dbfc

	- fixed 3098293 -- Shockwave plug-in doesn't work

	The problem is that the Shockwave plug-in depends on being able to do LMGetCurApRefNum
	and then do a PBGetFCBInfoSync on the result, and if it gets an error it will refuse
	to initialize.

        * Plugins.subproj/WebNetscapePluginPackage.m: (+[WebNetscapePluginPackage initialize]):
	Supply a bogus CurApRefNum. Do it only if CurApRefNum is -1, so we don't screw things
	up if we are used in a Carbon application.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3120 268f45cc-cd09-0410-ab3c-d52691b4dbfc

	The problem was on c/r khtml would not pick a submit button to add to the
	form state that is sent.  We now "activate" the first submit button that meets the
	criteria for being a "successful" form element, if no button was already
	activated by being clicked on.

        Reviewed by Darin.

        * khtml/html/html_formimpl.cpp:
        (HTMLFormElementImpl::submit):  Pick a submit button to use, if none was already
	chosen by virtue of being clicked.
        (HTMLButtonElementImpl::isSuccessfulSubmitButton):  New getter to support
	submit button selection.
        (HTMLButtonElementImpl::isActivatedSubmit):  New getter on existing prop.
        (HTMLButtonElementImpl::setActivatedSubmit):  New setter on existing prop.
        (HTMLInputElementImpl::isSuccessfulSubmitButton):  New getter to support
	submit button selection.
        (HTMLInputElementImpl::isActivatedSubmit):  New getter on existing prop.
        (HTMLInputElementImpl::setActivatedSubmit):  New setter on existing prop.
        * khtml/html/html_formimpl.h:  Add new methods to common superclass.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3119 268f45cc-cd09-0410-ab3c-d52691b4dbfc

* khtml/misc/arena.cpp:
* khtml/misc/arena.h:
* khtml/rendering/render_arena.cpp:
* khtml/rendering/render_arena.h:
* khtml/rendering/render_layer.cpp:
* khtml/rendering/render_layer.h:

Changed copyright and licensing.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3118 268f45cc-cd09-0410-ab3c-d52691b4dbfc

	and makes porsche.com look ok again.

	Bug #3131287.

        Reviewed by gramps

        * khtml/rendering/bidi.cpp:
        (RenderFlow::findNextLineBreak):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3117 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Trey.

        * JavaScriptCore.pbproj/project.pbxproj: Removed signature.

WebFoundation:

        Reviewed by Trey.

        * WebFoundation.pbproj/project.pbxproj: Remove signature.

WebCore:

        Reviewed by Trey.

        * WebCore.pbproj/project.pbxproj: Remove signature.
        * kwq/KWQColor.mm: Turn off inlining so we can build even on the
	compiler that warns about static data in inline functions.

WebKit:

        Reviewed by Trey.

        * WebKit.pbproj/project.pbxproj: Remove signature.
        * WebView.subproj/WebController.m: Turn off inlining so we can build even on the
	compiler that warns about static data in inline functions.

WebBrowser:

        Reviewed by Trey.

        * Scripting.subproj/Safari.scriptSuite: Change signature to sfri.
        * WebBrowser.pbproj/project.pbxproj: Change signature to sfri.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3115 268f45cc-cd09-0410-ab3c-d52691b4dbfc

	- fixed 2895826 -- ICON: Need a "no plug-in" icon

        * Resources/nullplugin.tiff:
	new plug-in icon. Blue 3-D lego with question marks.

WebBrowser:

	- fixed 312965 -- SJ: Need Home button art with thinner lines
	- also added an all-purpose document icon with a compass instead
	of a spider, and a tweaked version of the app icon

        * Resources/Images/Home.tif:
        * Resources/Images/HomeDisabled.tif:
        * Resources/Images/HomePressed.tif:
        * Resources/compass.icns:
	new versions

        * document.icns: Removed.
	this was the spider, he's gone now but his name remains.

        * Resources/document.icns: Added.
	put it in here with the app icon.

        * WebBrowser.pbproj/project.pbxproj: updated for new/removed files


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3114 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        done with a horrible hack and should be removed when 3129490
        is fixed.

        Reviewed by hyatt.

        * WebCoreSupport.subproj/WebTextRenderer.m:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3113 268f45cc-cd09-0410-ab3c-d52691b4dbfc

	- fixed 3120729 - HOMEPAGE: Can't set a DIV innerHTML property
	with html content starting with <html><head><head/><body>

        * khtml/html/html_elementimpl.cpp:
        (HTMLElementImpl::createContextualFragment): Pop <html> and
	<body>, and remove <head> to allow a full HTML document to be made
	and inserted as a contextual fragment.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3112 268f45cc-cd09-0410-ab3c-d52691b4dbfc

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3110 268f45cc-cd09-0410-ab3c-d52691b4dbfc

	when you try to insert a block in between two inlines that
	have already been wrapped in an anonymous block.

        Reviewed by mjs

        * khtml/rendering/render_flow.cpp:
        (RenderFlow::addChildToFlow):
        (RenderFlow::makeChildrenNonInline):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3109 268f45cc-cd09-0410-ab3c-d52691b4dbfc

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3107 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        get cached in the b/f cache.

        Reviewed by trey.

        * WebView.subproj/WebFramePrivate.m:
        (-[WebFrame _setState:]):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3106 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        has a bug that sometimes causes line height to be 20% too large.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3105 268f45cc-cd09-0410-ab3c-d52691b4dbfc

	Reworking the code to update the page icon led me to roll the WebIconDB API
	for URL to NSString.  In addition, the vestigial "Site" was removed.

	Everything below is renaming, except where noted.

        Reviewed by Darin

        * English.lproj/StringsNotToBeLocalized.txt:
        * History.subproj/WebHistoryItem.m:
        (-[WebHistoryItem _retainIconInDatabase:]):
        (-[WebHistoryItem icon]):
        * Misc.subproj/WebIconDatabase.h:
        * Misc.subproj/WebIconDatabase.m:
        (-[WebIconDatabase init]):
        (-[WebIconDatabase iconForURL:withSize:cache:]):  Use _web_isFileURL.
        (-[WebIconDatabase iconForURL:withSize:]):
        (-[WebIconDatabase retainIconForURL:]):
        (-[WebIconDatabase releaseIconForURL:]):
        (-[WebIconDatabase _iconDictionariesAreGood]):
        (-[WebIconDatabase _loadIconDictionaries]):
        (-[WebIconDatabase _updateFileDatabase]):
        (-[WebIconDatabase _iconForFileURL:withSize:]):  Cons up a NSURL to get the path.
	Test explicitly for .htm and .html suffixes.
        (-[WebIconDatabase _setIcon:forIconURL:]):
        (-[WebIconDatabase _setIconURL:forURL:]):
        (-[WebIconDatabase _releaseIconForIconURLString:]):
        (-[WebIconDatabase _retainFutureIconForURL:]):
        (-[WebIconDatabase _releaseFutureIconForURL:]):
        (-[WebIconDatabase _sendNotificationForURL:]):
        * Misc.subproj/WebIconDatabasePrivate.h:
        * Misc.subproj/WebIconLoader.m:
        (-[WebIconLoader handleDidFinishLoading:]):
        * WebKit.exp:
        * WebView.subproj/WebDataSourcePrivate.m:
        (-[WebDataSource _updateIconDatabaseWithURL:]):
        (-[WebDataSource _loadIcon]):

WebBrowser:

	3127109 - REGRESSION: generic favicon shown while page from same domain is loading

	We now avoid jumping to the generic icon when we're loading and are moving
	to a URL within the same domain as the current one.

	In addition, some name changes for the URL->NSString changes in the WebIconDB API.

        Reviewed by John

        * BookmarkSource.m:
        (-[BookmarkSource imageForContentItem:]):  Adopt API change.
        * BrowserWindowController.h:  New ivar, _acceptsGenericIcon.
        * BrowserWindowController.m:
        (-[BrowserWindowController windowDidLoad]):  Init new ivar.
        (-[BrowserWindowController acceptsGenericIcon]):  New getter.
        (-[BrowserWindowController setAcceptsGenericIcon:]):  New setter.
        (-[BrowserWindowController updateLocationFieldIcon]):  Obey new ivar as to
	we will accept a generic icon when updating.
        * LocationChangeHandler.m:
        (-[LocationChangeHandler locationChangeStartedForDataSource:]):  If the new URL
	is in the same site as the old one, avoid accepting a generic icon.
        (-[LocationChangeHandler locationChangeDone:forDataSource:]):  Reset _acceptsGenericIcon
        * NewBookmarksController.m:
        (-[NewBookmarksController awakeFromNib]):  Adopt API change.
        * TitleBarButton.m:
        (-[TitleBarButton drawPathRepresentingPopUpMenuForEvent:URL:]):  Adopt API change.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3104 268f45cc-cd09-0410-ab3c-d52691b4dbfc

	Fixed: 3113073 - link on http://studio.adobe.com/explore/ redirects to not found page in Alex

        Reviewed by darin.

        * Misc.subproj/WebNSStringExtras.m:
        (-[NSString _web_looksLikeAbsoluteURL]): trim whitespace because _web_URLWithString allows whitespace
        * Misc.subproj/WebNSURLExtras.m:
        (+[NSURL _web_URLWithString:]): trim whitespace because we shouldn't replace spaces with escape characters
        (+[NSURL _web_URLWithString:relativeToURL:]): trim whitespace because we shouldn't replace spaces with escape characters

WebKit:

	Fixed: 3113073 - link on http://studio.adobe.com/explore/ redirects to not found page in Alex

        Reviewed by darin.

        * Misc.subproj/WebNSPasteboardExtras.m:
        (-[NSPasteboard _web_bestURL]): don't trim whitespace because _web_URLWithString does this for us
        * Plugins.subproj/WebBaseNetscapePluginView.m:
        (-[WebBaseNetscapePluginView pluginURLFromCString:]): tweak


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3103 268f45cc-cd09-0410-ab3c-d52691b4dbfc

	- fixed build; WebFileDatabase was importing a file that is internal

        * Database.subproj/WebFileDatabase.h: Don't import WebLRUFileList.h.
        * Database.subproj/WebFileDatabase.m: Do import WebLRUFileList.h.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3102 268f45cc-cd09-0410-ab3c-d52691b4dbfc

	- to help with performance of various bookmark operations,
	added a call that returns the internal array of children,
	to complement the safer call that returns a copy.

        Reviewed by Darin

        * Bookmarks.subproj/WebBookmark.h:
	commented -children and new -rawChildren
        * Bookmarks.subproj/WebBookmark.m:
        (-[WebBookmark rawChildren]):
	new method, returns nil at this level.
        (-[WebBookmark contentMatches:]):
	use -rawChildren instead of -children

        * Bookmarks.subproj/WebBookmarkList.m:
        (-[WebBookmarkList rawChildren]):
	new method, returns internal array without copying

WebBrowser:

	- fixed 3129823 -- displaying many bookmarks in outline view is very slow

	Deployed new rawChildren call everywhere appropriate in WebBrowser. This
	prevents a lot of array-creation. On my machine, the time it takes to
	display a folder containing 1000 items went from 0.96 sec to 0.0084 sec.

        Reviewed by Darin

        * BookmarksController.m:
        (-[BookmarksController addChildrenOfBookmark:toMenu:]):
        (-[BookmarksController goToNthFavoriteLeaf:]):
        (-[BookmarksController _addBookmarksToMenu]):
        (-[BookmarksController mergeBookmarksFrom:to:]):
        (-[BookmarksController mergeBuiltInBookmarksIfNecessary]):
        (-[BookmarksController importInternetExplorerFavorites]):
        (-[BookmarksController updateBookmarkSources]):
        (-[BookmarksController favoriteBookmarks]):
        (-[BookmarksController addFavoriteBookmark:atIndex:]):
        (-[BookmarksController recursivelyAddChildFoldersOf:toMenu:withIndentationLevel:]):
	use -rawChildren instead of -children

        * BookmarksViewController.m:
        (-[BookmarksViewController newContentItemWithTitle:URLString:type:positionIgnoresSelection:]):
	use -rawChildren instead of -children
        (-[BookmarksViewController bookmarkSources]):
	use -rawChildren instead of -children
        (-[BookmarksViewController refreshContents]):
	log timing
        (-[BookmarksViewController canRemoveBookmarkSource:]):
	use -rawChildren instead of -children
        (-[BookmarksViewController deleteSelectedContentItems]):
	log timing
        (-[BookmarksViewController child:ofContentItem:usingSource:]):
	use -rawChildren instead of -children
        (-[BookmarksViewController outlineView:validateDrop:proposedItem:proposedChildIndex:]):
	use -rawChildren instead of -children
        (-[BookmarksViewController paste:]):
	log timing; use -rawChildren instead of -children
        (-[BookmarksViewController initWithBookmark:bookmark:]):
	use -rawChildren instead of -children

        (+[CompletionController _addBookmarkTree:]):
	use -rawChildren instead of -children
        (+[CompletionController _removeBookmarkTree:]):
	use -rawChildren instead of -children

        * FavoriteButton.m:
        (-[FavoriteButton _contentsMenu]):
	use -rawChildren instead of -children

        * WebBrowser.pbproj/project.pbxproj: version wars


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3101 268f45cc-cd09-0410-ab3c-d52691b4dbfc

	Fix for this bug:

	Radar 3128631 (WebFileDatabase walks its whole directory tree to expire files)

	Complete reworking of the way in which the disk cache database keeps track
	of the files on disk. This should result in fewer I/O operations, and
	should fix the extremely bad behavior that involved walking the entire
	disk cache tree evey time a single file needed to be deleted.

        * Database.subproj/WebFileDatabase.h: Use new WebLRUFileList code.
        * Database.subproj/WebFileDatabase.m: Ditto.
        * Database.subproj/WebLRUFileList.h: Added.
        * Database.subproj/WebLRUFileList.m: Ditto.
        * Misc.subproj/WebFoundationLogging.h: Added WebFoundationLogWebFileDatabaseActivity channel
        * Misc.subproj/WebFoundationLogging.m: Ditto
        * WebFoundation.pbproj/project.pbxproj: Added WebLRUFileList.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3100 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Maciej.

	- remove leftover bits of NO_LICENSE

        * acconfig.h: Remove NO_LICENSE.
        * configure.in: Remove all the NO_LICENSE-related bits.

WebBrowser:

        Reviewed by Maciej.

	- remove leftover bits of NO_LICENSE

        * WebBrowser.pbproj/project.pbxproj: Remove build styles setting HAVE_CONFIG_H and also
	INCLUDE_TEST_SUITE too, because that hasn't been used anywhere for like forever.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3099 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Don and Maciej.

        * force-clean-timestamp: Trigger a full build since we are setting
	MACOSX_DEPLOYMENT_TARGET to 10.2, which requires remaking all PFEs.

Tools:

        * Scripts/check-copyright: Added.

JavaScriptCore:

        Reviewed by Don and Maciej.

	- fixed 3129115 -- need Apple copyright added to open source documents

	* tons of files: Added our copyright to files we modified, and updated all to standard format.

	- other changes

        * JavaScriptCore.pbproj/project.pbxproj: Set MACOSX_DEPLOYMENT_TARGET to 10.2.
	Also removed completion.cpp.
        * kjs/completion.cpp: Removed.
        * kjs/completion.h: Made the Completion constructor inline.

        * kjs/grammar.y: Removed an obsolete "pretend ifdef". No need to put these in APPLE_CHANGES now.

WebFoundation:

        Reviewed by Don and Maciej.

        * English.lproj/StringsNotToBeLocalized.txt: Updated for recent changes.
        * WebFoundation.pbproj/project.pbxproj: Set MACOSX_DEPLOYMENT_TARGET to 10.2.

WebCore:

        Reviewed by Don and Maciej.

	- fixed 3129115 -- need Apple copyright added to open source documents

	* tons of files: Added copyright message to files we modified and
	standardized format of copyrights too.

	- fixed 3129235 -- assert in LRUList visiting apple.com if "Display images" preference is off

        * khtml/misc/loader.cpp:
        (Cache::getLRUListFor): Use the first list for 0-sized objects.
        (Cache::removeFromLRUList): Allow 0-sized objects.

	- other changes

        * khtml/rendering/render_style.h: Remove bogus unused private constructor.

        * kwq/KWQFont.h: Added copy constructor and assignment operator.
        * kwq/KWQFont.mm:
        (QFont::QFont): Copy constructor now retains the NSFont. The old version didn't which could
	cause retain/release problems.
        (QFont::operator=): Retain the new NSFont and release the old one.

        * WebCore.pbproj/project.pbxproj: Set MACOSX_DEPLOYMENT_TARGET to 10.2.

WebKit:

        Reviewed by Don and Maciej.

        * WebView.subproj/WebUserAgentSpoofTable.gperf: Added a couple of new domains to the list we
	spoof as Mac IE, and added comments.
        * WebView.subproj/WebUserAgentSpoofTable.c: Regenerated.

        * WebKit.pbproj/project.pbxproj: Set MACOSX_DEPLOYMENT_TARGET to 10.2

WebBrowser:

        Reviewed by Don and Maciej.

	- fixed 3106686 -- Remove "world leak" debugging window before beta

        * Test/PageLoadTestController.m:
        (-[PageLoadTestController windowDidLoad]): (Not part of the bug fix.) Changed the combo
	box so it automatically sizes to the number of pltsuite files so we don't have to edit
	the nib all the time.
        (-[PageLoadTestController anyWindowWillClose:]): Don't do any world leak test when the
	window closes. The one in the page load test window is still there.

        * Debug/DebugUtilities.m: (-[NSApplication validate_toggleAlwaysCheckForWorldLeaks:]):
	Don't enable or check the debug menu item at all. Put an ifdef in so we can turn it on later.

	- fixed 3124310 -- remove "app refuses to launch" code before shipping

        * main.m: (main): Remove all the licensing code.

	- other changes

        * BrowserNSNetServiceExtras.m: Made all locally-defined-and used functions static
	so we would know if any were unused and for cleanliness.
        (-[NSNetService hostName:andPort:]): Remove some silly assertions.
        (decode_name): Change printf for errors to ERROR.
        (decode_srv): Ditto.
	(decode_txt): Removed because it's unused.
        (skip_question): Ditto.
        (MyDictionaryKeyHashCallBack): Removed silly assertion.
        (MyCreateCFDictionaryFromTXT): Ditto.

        * WebBrowser.pbproj/project.pbxproj: Set MACOSX_DEPLOYMENT_TARGET to 10.2


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3098 268f45cc-cd09-0410-ab3c-d52691b4dbfc

	- fixed 3125283 - HOMEPAGE: in onload of an IMG, the width and height are equal to zero

	There were two problems here. First, the calls to get image width
	and height didn't force a layout in all the cases where it was
	required. Second, layout wouldn't lay out images at all until
	parsing was done, due to a hack to block inline layout until that
	point. I'm not sure if this will have other bad consquences, but
	nearly every page I tried, including Hebrew and Japanese pages as
	well as every page on the base PLT laid out properly.

        * khtml/html/html_imageimpl.cpp:
        (HTMLImageElementImpl::width): Force a layout if not laid out.
        (HTMLImageElementImpl::height): Likewise.
        * khtml/html/htmlparser.cpp:
	(KHTMLParser::insertNode): Remove setBlockBidi hack - this was
	preventing images from getting laid out until the document was
	totally done parsing.
        * khtml/rendering/render_flow.cpp:
        (RenderFlow::RenderFlow): More setBLockBidi removal.
        (RenderFlow::layout): Likewise.
        (RenderFlow::close): Likewise.
        (RenderFlow::addChildToFlow): Likewise.
        (RenderFlow::printTree): Likewise.
        * khtml/rendering/render_flow.h:
        * khtml/rendering/render_object.h:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3097 268f45cc-cd09-0410-ab3c-d52691b4dbfc

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3096 268f45cc-cd09-0410-ab3c-d52691b4dbfc

	a float), make sure the block gets a fresh layout, so that it
	can readjust its contents now that they don't have to flow
	around the float.

        Reviewed by darin

        * khtml/rendering/render_flow.cpp:
        (RenderFlow::layoutBlockChildren):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3095 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by rjw.

        * WebView.subproj/WebDataSourcePrivate.m:
        (-[WebDataSource _setLoading:]): Added comment about our tragic dependence on a non-retained reference to the controller.
        (-[WebDataSource _recursiveStopLoading]): Call webFrame before calling _stopLoading because we release the controller in _stopLoading and we depend on it in webFrame.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@3094 268f45cc-cd09-0410-ab3c-d52691b4dbfc