1. 01 Nov, 2010 40 commits
    • mihaip@chromium.org's avatar
      2010-11-01 Mihai Parparita <mihaip@chromium.org> · 7b8604d2
      mihaip@chromium.org authored
              Update the pixel expectations for editing/ for the Mac port.
      
              For the tests that currently fail on Snow Leopard with --pixel-tests
              --tolerance 0, this moves the current pixel results to mac-leopard and
              adds new Snow Leopard-specific results to platform/mac.
      
              List of files omitted due to length but composed entirely of moves from
              platform/mac to platform/mac-leopard and newly added files in
              platform/mac.
      
              Some tests had differences due to spell correction underlining, those
              were skipped since it's not clear what the correct dictionary state is.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71084 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7b8604d2
    • ojan@chromium.org's avatar
      2010-11-01 Ojan Vafai <ojan@chromium.org> · c116e3b2
      ojan@chromium.org authored
              Reviewed by Dimitri Glazkov.
      
              remove debug code from run_webkit_tests.py
              https://bugs.webkit.org/show_bug.cgi?id=48800
      
              Remove temporary debug code and make --master-name required
              if --test-results-server is set now that all clients set
              --master-name.
      
              * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71083 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c116e3b2
    • dimich@chromium.org's avatar
      [Chromium] Unreviewed update of test expectations. · 9981c96d
      dimich@chromium.org authored
      Temporarily disable new test added by http://trac.webkit.org/changeset/71066
      Need to convert it to dumpAsText().
      
      * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71082 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9981c96d
    • andersca@apple.com's avatar
      Make NPRemoteObjectMap a ref counted object · 65406d98
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=48808
      
      Reviewed by Oliver Hunt.
      
      * PluginProcess/PluginControllerProxy.cpp:
      (WebKit::PluginControllerProxy::windowScriptNPObject):
      * PluginProcess/WebProcessConnection.cpp:
      (WebKit::WebProcessConnection::WebProcessConnection):
      (WebKit::WebProcessConnection::didReceiveSyncMessage):
      * PluginProcess/WebProcessConnection.h:
      (WebKit::WebProcessConnection::npRemoteObjectMap):
      * Shared/Plugins/NPRemoteObjectMap.cpp:
      (WebKit::NPRemoteObjectMap::create):
      (WebKit::NPRemoteObjectMap::~NPRemoteObjectMap):
      (WebKit::NPRemoteObjectMap::createNPObjectProxy):
      * Shared/Plugins/NPRemoteObjectMap.h:
      * WebProcess/Plugins/PluginProcessConnection.cpp:
      (WebKit::PluginProcessConnection::PluginProcessConnection):
      (WebKit::PluginProcessConnection::didReceiveSyncMessage):
      * WebProcess/Plugins/PluginProcessConnection.h:
      (WebKit::PluginProcessConnection::npRemoteObjectMap):
      * WebProcess/Plugins/PluginProxy.cpp:
      (WebKit::PluginProxy::getWindowScriptNPObject):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71081 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      65406d98
    • mrobinson@webkit.org's avatar
      2010-11-01 Martin Robinson <mrobinson@igalia.com> · 5d5350cd
      mrobinson@webkit.org authored
              Reviewed by Xan Lopez.
      
              [Soup] Random crashes in http/tests/websocket/tests/workers/worker-handshake-challenge-randomness.html
              https://bugs.webkit.org/show_bug.cgi?id=48805
      
              Track active WebSocket handles via a sequential id. This ensures
              that when a handle is reallocated into a recently used segment of
              memory, it doesn't trigger a false positive in the code which ensures
              the original handle is active.
      
              No new tests. This test should stop crashing on the bots, proving the fix.
      
              * platform/network/soup/SocketStreamHandle.h:
              (WebCore::SocketStreamHandle::id): Added an m_id member and accessor
              to SocketStreamHandle.
              * platform/network/soup/SocketStreamHandleSoup.cpp:
              (WebCore::getHandleFromId): Updated to work with HashMap of handle ids to
              SocketStreamHandle*.
              (WebCore::deactivateHandle): Ditto.
              (WebCore::activateHandle): Ditto.
              (WebCore::SocketStreamHandle::SocketStreamHandle): Ditto.
              (WebCore::SocketStreamHandle::connected): Ditto.
              (WebCore::SocketStreamHandle::readBytes): Ditto.
              (WebCore::SocketStreamHandle::beginWaitingForSocketWritability): Ditto.
              (WebCore::connectedCallback): Ditto.
              (WebCore::readReadyCallback): Ditto.
              (WebCore::writeReadyCallback): Ditto.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71080 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5d5350cd
    • tkent@chromium.org's avatar
      2010-11-01 Kent Tamura <tkent@chromium.org> · ba5dfe51
      tkent@chromium.org authored
              Unreviewed. Run sort-Xcode-project-file.
      
              * WebCore.xcodeproj/project.pbxproj:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71079 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ba5dfe51
    • tony@chromium.org's avatar
      2010-11-01 Tony Chang <tony@chromium.org> · 6c5e19b1
      tony@chromium.org authored
              Reviewed by Kent Tamura.
      
              add plugin event logging for linux
              https://bugs.webkit.org/show_bug.cgi?id=48779
      
              This is taken from Chromium's fork of the layout test plugin:
              http://git.chromium.org/gitweb/?p=chromium.git/.git;a=blob;f=webkit/tools/npapi_layout_test_plugin/main.cpp;h=3ebdada2f049b3624756438cff852364f86a2ede;hb=HEAD#l348
      
              * DumpRenderTree/TestNetscapePlugIn/main.cpp:
              (handleEventX11):
              (NPP_HandleEvent):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71078 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6c5e19b1
    • tony@chromium.org's avatar
      2010-11-01 Tony Chang <tony@chromium.org> · 03fd20e1
      tony@chromium.org authored
              Reviewed by Kent Tamura.
      
              [chromium] Compile TestNetscapePlugin on chromium win
              https://bugs.webkit.org/show_bug.cgi?id=48802
      
              It creates npTestNetscapePlugin.dll in the build directory, so
              it's not yet loaded by DRT or test_shell.
      
              * WebKit.gyp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71077 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      03fd20e1
    • andersca@apple.com's avatar
      Remove duplicate ChangeLog entry. · 9fd1e375
      andersca@apple.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71076 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9fd1e375
    • andersca@apple.com's avatar
      Respond to NP_GetProperty by sending a GetProperty message · 271e702d
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=48797
      
      Reviewed by John Sullivan.
      
      * Platform/CoreIPC/HandleMessage.h:
      (CoreIPC::callMemberFunction):
      Add new sync message overload.
      
      * PluginProcess/WebProcessConnection.cpp:
      (WebKit::WebProcessConnection::didReceiveSyncMessage):
      If the message class is MessageClassNPObjectMessageReceiver, pass it to the NPRemoteObjectMap.
      
      * Shared/Plugins/NPIdentifierData.cpp:
      * Shared/Plugins/NPIdentifierData.h:
      Add NPIdentifierData, a CoreIPC representation of an NPIdentifier.
      
      * Shared/Plugins/NPObjectMessageReceiver.cpp:
      (WebKit::NPObjectMessageReceiver::getProperty):
      Add stub.
      
      * Shared/Plugins/NPObjectMessageReceiver.messages.in:
      Add GetProperty.
      
      * Shared/Plugins/NPObjectProxy.cpp:
      (WebKit::NPObjectProxy::create):
      (WebKit::NPObjectProxy::NPObjectProxy):
      (WebKit::NPObjectProxy::initialize):
      NPObjectProxy now takes an NPRemoteObjectMap in its create function.
      
      (WebKit::NPObjectProxy::getProperty):
      Send a GetProperty message.
      
      (WebKit::NPObjectProxy::NP_GetProperty):
      Call getProperty.
      
      * Shared/Plugins/NPRemoteObjectMap.cpp:
      (WebKit::NPRemoteObjectMap::createNPObjectProxy):
      Pass the NPRemoteObjectMap.
      
      (WebKit::NPRemoteObjectMap::didReceiveSyncMessage):
      Find the right message receiver and dispatch the message to it.
      
      * Shared/Plugins/NPVariantData.cpp:
      * Shared/Plugins/NPVariantData.h:
      Add NPVariantData, which will be a CoreIPC representation of an NPVariant.
      
      * WebKit2.xcodeproj/project.pbxproj:
      Add new files.
      
      * WebProcess/Plugins/PluginProcessConnection.cpp:
      (WebKit::PluginProcessConnection::didReceiveSyncMessage):
      If the message class is MessageClassNPObjectMessageReceiver, pass it to the NPRemoteObjectMap.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71075 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      271e702d
    • simon.fraser@apple.com's avatar
      2010-11-01 Simon Fraser <simon.fraser@apple.com> · 3e7f5aa3
      simon.fraser@apple.com authored
              Reviewed by Dan Bernstein.
      
              Assertion failure in FrameView::layout when clicking on a YouTube video on youtube.com front page
              https://bugs.webkit.org/show_bug.cgi?id=44287
      
              When removing subframes, it's possible for layout() to get called on a FrameView
              for a Frame that has been removed from the frame tree. This can happen if the parent
              document happens to do a layout() while RenderView still has a reference to the widget
              for the removed frame; updateWidgetPosition() will try to force a layout() on the
              subframe.
      
              Fix by checking that the FrameView's Frame still has a reference to the page before
              calling layout() on the subframe.
      
              Test: fast/frames/layout-after-destruction.html
      
              * rendering/RenderWidget.cpp:
              (WebCore::RenderWidget::updateWidgetPosition):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71074 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3e7f5aa3
    • mihaip@chromium.org's avatar
      2010-11-01 Mihai Parparita <mihaip@chromium.org> · a1090d94
      mihaip@chromium.org authored
              Update the pixel expectations for fast/dom, fast/dynamic, fast/encoding, fast/events, and fast/gradients for the Mac port.
      
              For the tests that currently fail on Snow Leopard with --pixel-tests
              --tolerance 0, this moves the current pixel results to mac-leopard and
              adds new Snow Leopard-specific results to platform/mac.
      
              List of files omitted due to length but composed entirely of moves from
              platform/mac to platform/mac-leopard and newly added files in
              platform/mac.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71073 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a1090d94
    • mihaip@chromium.org's avatar
      2010-11-01 Mihai Parparita <mihaip@chromium.org> · 351766b7
      mihaip@chromium.org authored
              Update the pixel expectations for fast/dom, fast/dynamic, fast/encoding, fast/events, and fast/gradients for the Mac port.
      
              For the tests that currently fail on Snow Leopard with --pixel-tests
              --tolerance 0, this moves the current pixel results to mac-leopard and
              adds new Snow Leopard-specific results to platform/mac.
      
              List of files omitted due to length but composed entirely of moves from
              platform/mac to platform/mac-leopard and newly added files in
              platform/mac.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71072 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      351766b7
    • dimich@chromium.org's avatar
      2010-11-01 Sheriff Bot <webkit.review.bot@gmail.com> · 55372123
      dimich@chromium.org authored
              Unreviewed, rolling out r71065.
              http://trac.webkit.org/changeset/71065
              https://bugs.webkit.org/show_bug.cgi?id=48801
      
              Seem to breake a lot of tests on Chromium bots (Requested by
              dimich on #webkit).
      
              * platform/image-decoders/ImageDecoder.cpp:
              * platform/image-decoders/ImageDecoder.h:
              * platform/image-decoders/cg/ImageDecoderCG.cpp:
              (WebCore::RGBA32Buffer::asNewNativeImage):
              * platform/image-decoders/png/PNGImageDecoder.cpp:
              (WebCore::PNGImageDecoder::headerAvailable):
              (WebCore::PNGImageDecoder::rowAvailable):
              * platform/image-decoders/qt/RGBA32BufferQt.cpp:
              * platform/image-decoders/skia/ImageDecoderSkia.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71071 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      55372123
    • jamesr@google.com's avatar
      2010-11-01 James Robinson <jamesr@chromium.org> · be845c7c
      jamesr@google.com authored
              Update chromium baselines for a few tests.
      
              * platform/chromium-linux/fast/repaint/iframe-scroll-repaint-expected.checksum: Added.
              * platform/chromium-linux/fast/repaint/iframe-scroll-repaint-expected.png: Added.
              * platform/chromium-linux/svg/custom/resource-invalidate-on-target-update-expected.checksum: Added.
              * platform/chromium-linux/svg/custom/resource-invalidate-on-target-update-expected.png: Added.
              * platform/chromium-mac/fast/repaint/iframe-scroll-repaint-expected.checksum: Added.
              * platform/chromium-mac/fast/repaint/iframe-scroll-repaint-expected.png: Added.
              * platform/chromium-mac/svg/custom/resource-invalidate-on-target-update-expected.checksum: Removed.
              * platform/chromium-mac/svg/custom/resource-invalidate-on-target-update-expected.png: Removed.
              * platform/chromium-win/fast/repaint/iframe-scroll-repaint-expected.checksum: Added.
              * platform/chromium-win/fast/repaint/iframe-scroll-repaint-expected.png: Added.
              * platform/chromium-win/fast/repaint/iframe-scroll-repaint-expected.txt: Added.
              * platform/chromium-win/svg/custom/resource-invalidate-on-target-update-expected.checksum:
              * platform/chromium-win/svg/custom/resource-invalidate-on-target-update-expected.png:
              * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71070 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      be845c7c
    • andersca@apple.com's avatar
      Add ArgumentCoder specialization for WTF::CString · 734aad70
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=48796
      
      Reviewed by Sam Weinig.
      
      * Platform/CoreIPC/ArgumentCoders.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71069 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      734aad70
    • dpranke@chromium.org's avatar
      2010-11-01 Dirk Pranke <dpranke@chromium.org> · af1b8a2a
      dpranke@chromium.org authored
              Reviewed by James Robinson.
      
              new-run-webkit-tests: use DRT, child-processes=1 for GPU tests by default
              https://bugs.webkit.org/show_bug.cgi?id=48790
      
              * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
              * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71068 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      af1b8a2a
    • hyatt@apple.com's avatar
      Fix SVG bustage. · 0cf2782f
      hyatt@apple.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71067 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0cf2782f
    • mdelaney@apple.com's avatar
      2010-11-01 Matthew Delaney <mdelaney@apple.com> · 069db487
      mdelaney@apple.com authored
              Reviewed by Simon Fraser.
      
              Setting attr repeatDur=0 on SVG element causes hang
              https://bugs.webkit.org/show_bug.cgi?id=48785
      
              Test: svg/animations/repeatDur-zero.xhtml
      
              * svg/animation/SVGSMILElement.cpp: Fixing bound checking for legal repeatDur values.
      2010-11-01  Matthew Delaney  <mdelaney@apple.com>
      
              Reviewed by Simon Fraser.
      
              Setting attr repeatDur=0 on SVG element causes hang
              https://bugs.webkit.org/show_bug.cgi?id=48785
      
              * svg/animations/repeatDur-zero.xhtml: Added. Tests if setting attr repeatDur=0 causes a hang or not.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71066 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      069db487
    • abarth@webkit.org's avatar
      2010-10-31 Adam Barth <abarth@webkit.org> · 6e06aa03
      abarth@webkit.org authored
              Reviewed by Eric Seidel.
      
              [Chromium] Add ICC support for PNG on Mac
              https://bugs.webkit.org/show_bug.cgi?id=48170
      
              This just pipes the ICC profile from libpng to CoreGraphics.  This
              patch would have been a lot prettier on Snow Leopard, but we have to
              use a somewhat ugly API to get this to work on Leopard.
      
              This is covered by about infinite tests.
      
              * platform/image-decoders/ImageDecoder.cpp:
              (WebCore::RGBA32Buffer::setColorProfile):
              * platform/image-decoders/ImageDecoder.h:
              * platform/image-decoders/cg/ImageDecoderCG.cpp:
              (WebCore::RGBA32Buffer::asNewNativeImage):
              * platform/image-decoders/png/PNGImageDecoder.cpp:
              (WebCore::PNGImageDecoder::headerAvailable):
              (WebCore::PNGImageDecoder::rowAvailable):
              * platform/image-decoders/qt/RGBA32BufferQt.cpp:
              (WebCore::RGBA32Buffer::setColorProfile):
              * platform/image-decoders/skia/ImageDecoderSkia.cpp:
              (WebCore::RGBA32Buffer::setColorProfile):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71065 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6e06aa03
    • abarth@webkit.org's avatar
      2010-11-01 Adam Barth <abarth@webkit.org> · 30777845
      abarth@webkit.org authored
              Reviewed by Eric Seidel.
      
              Teach check-webkit-style how to accept a list of files to diff on the
              command line
              https://bugs.webkit.org/show_bug.cgi?id=48784
      
              In a future patch, webkit-patch will use this option to improve
              performance.  I'm landing this in two pieces to avoid causing a version
              skew problem for the style-bot.
      
              * Scripts/check-webkit-style:
              * Scripts/webkitpy/style/optparser.py:
              * Scripts/webkitpy/style/optparser_unittest.py:
              * Scripts/webkitpy/style_references.py:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71064 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      30777845
    • dimich@chromium.org's avatar
      [Chromium] Unreviewed test rebaseline. · b8e20db6
      dimich@chromium.org authored
      * platform/chromium-linux/svg/custom/gradient-userSpaceOnUse-with-percentage-expected.checksum: Removed.
      * platform/chromium-linux/svg/custom/gradient-userSpaceOnUse-with-percentage-expected.png: Removed.
      * platform/chromium-mac/fast/blockflow/border-vertical-lr-expected.checksum:
      * platform/chromium-mac/fast/repaint/inline-horizontal-bt-overflow-expected.checksum: Added.
      * platform/chromium-mac/fast/repaint/inline-horizontal-bt-overflow-expected.png: Added.
      * platform/chromium-mac/fast/repaint/inline-vertical-lr-overflow-expected.checksum: Added.
      * platform/chromium-mac/fast/repaint/inline-vertical-lr-overflow-expected.png: Added.
      * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71063 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b8e20db6
    • mihaip@chromium.org's avatar
      2010-11-01 Mihai Parparita <mihaip@chromium.org> · 0022f454
      mihaip@chromium.org authored
              Update the pixel expectations for fast/body-propagation, fast/borders, fast/box-shadow, fast/box-sizing, fast/clip, and fast/compact for the Mac port.
      
              For the tests that currently fail on Snow Leopard with --pixel-tests
              --tolerance 0, this moves the current pixel results to mac-leopard and
              adds new Snow Leopard-specific results to platform/mac.
      
              List of files omitted due to length but composed entirely of moves from
              platform/mac to platform/mac-leopard and newly added files in
              platform/mac.
      
              platform/mac/test_expectations.txt was also modified to remove two
              now-passing tests.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71062 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0022f454
    • senorblanco@chromium.org's avatar
      2010-11-01 Stephen White <senorblanco@chromium.org> · ca1b66c6
      senorblanco@chromium.org authored
              Unreviewed; test expectations update.
      
              Update chromium-gpu test expectations to reflect test_shell
              timeouts on ~35 tests.
      
              * platform/chromium-gpu/test_expectations.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71061 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ca1b66c6
    • andersca@apple.com's avatar
      Fix build. · 647698af
      andersca@apple.com authored
      * WebKit2.xcodeproj/project.pbxproj:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71060 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      647698af
    • simon.fraser@apple.com's avatar
      2010-11-01 Simon Fraser <simon.fraser@apple.com> · 578ea6f8
      simon.fraser@apple.com authored
              Fix test failures on Qt by avoiding references to external image files.
      
              * fast/backgrounds/multiple-backgrounds-computed-style-expected.txt:
              * fast/backgrounds/script-tests/multiple-backgrounds-computed-style.js:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71058 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      578ea6f8
    • andersca@apple.com's avatar
      Add NPObjectMessageReceiver.messages.in · 8ae9316e
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=48782
      
      Reviewed by Adam Roben.
      
      * DerivedSources.make:
      Add NPObjectMessageReceiver.
      
      * Platform/CoreIPC/MessageID.h:
      Add MessageClassNPObjectMessageReceiver message class.
      
      * Shared/Plugins/NPObjectMessageReceiver.cpp:
      (WebKit::NPObjectMessageReceiver::deallocate):
      Add stubbed out deallocate member function.
      
      * Shared/Plugins/NPObjectMessageReceiver.messages.in: Added.
      
      * WebKit2.xcodeproj/project.pbxproj:
      Add NPObjectMessageReceiver.messages.in.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71057 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8ae9316e
    • mihaip@chromium.org's avatar
      2010-11-01 Mihai Parparita <mihaip@chromium.org> · 77225896
      mihaip@chromium.org authored
              Update the pixel expectations for fast/selectors for the Mac port.
      
              For the tests that currently fail on Snow Leopard with --pixel-tests
              --tolerance 0, this moves the current pixel results to mac-leopard and
              adds new Snow Leopard-specific results to platform/mac.
      
              List of files omitted due to length but composed entirely of moves from
              platform/mac to platform/mac-leopard and newly added files in
              platform/mac.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71056 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      77225896
    • hyatt@apple.com's avatar
      https://bugs.webkit.org/show_bug.cgi?id=48776 · 6bd34681
      hyatt@apple.com authored
              
      Reviewed by Dan Bernstein.
      
      Change isVertical() on InlineBox to isHorizontal() instead.  This makes the horizontal code path come
      first if you branch on isHorizontal() and makes the code read better (since that's the more common code
      path).
      
      * rendering/InlineBox.cpp:
      (WebCore::InlineBox::logicalHeight):
      * rendering/InlineBox.h:
      (WebCore::InlineBox::InlineBox):
      (WebCore::InlineBox::isHorizontal):
      (WebCore::InlineBox::setIsHorizontal):
      (WebCore::InlineBox::width):
      (WebCore::InlineBox::height):
      (WebCore::InlineBox::logicalLeft):
      (WebCore::InlineBox::setLogicalLeft):
      (WebCore::InlineBox::logicalTop):
      (WebCore::InlineBox::setLogicalTop):
      (WebCore::InlineBox::baselinePosition):
      (WebCore::InlineBox::lineHeight):
      * rendering/InlineFlowBox.cpp:
      (WebCore::InlineFlowBox::addToLine):
      (WebCore::InlineFlowBox::placeBoxesInInlineDirection):
      (WebCore::InlineFlowBox::computeBlockDirectionOverflow):
      (WebCore::InlineFlowBox::paintFillLayer):
      (WebCore::InlineFlowBox::paintBoxDecorations):
      (WebCore::InlineFlowBox::paintMask):
      * rendering/InlineFlowBox.h:
      (WebCore::InlineFlowBox::marginLogicalLeft):
      (WebCore::InlineFlowBox::marginLogicalRight):
      (WebCore::InlineFlowBox::borderLogicalLeft):
      (WebCore::InlineFlowBox::borderLogicalRight):
      (WebCore::InlineFlowBox::paddingLogicalLeft):
      (WebCore::InlineFlowBox::paddingLogicalRight):
      (WebCore::InlineFlowBox::setInlineDirectionOverflowPositions):
      (WebCore::InlineFlowBox::setBlockDirectionOverflowPositions):
      * rendering/InlineTextBox.cpp:
      (WebCore::InlineTextBox::selectionRect):
      (WebCore::InlineTextBox::applyShadowToGraphicsContext):
      (WebCore::paintTextWithShadows):
      (WebCore::InlineTextBox::paint):
      (WebCore::InlineTextBox::paintDecoration):
      * rendering/InlineTextBox.h:
      * rendering/RenderBlockLineLayout.cpp:
      (WebCore::RenderBlock::createLineBoxes):
      * rendering/RenderBox.cpp:
      (WebCore::RenderBox::blockDirectionOverflow):
      * rendering/RenderBox.h:
      * rendering/RenderBoxModelObject.cpp:
      (WebCore::RenderBoxModelObject::paintFillLayerExtended):
      * rendering/RenderLineBoxList.cpp:
      (WebCore::RenderLineBoxList::hitTest):
      * rendering/RootInlineBox.cpp:
      (WebCore::RootInlineBox::RootInlineBox):
      (WebCore::RootInlineBox::placeEllipsis):
      * rendering/RootInlineBox.h:
      (WebCore::RootInlineBox::baselinePosition):
      (WebCore::RootInlineBox::lineHeight):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71055 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6bd34681
    • andersca@apple.com's avatar
      Start stubbing out NPClass functions in NPObjectProxy · 004117f4
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=48778
      
      Reviewed by Adam Roben.
      
      * PluginProcess/PluginControllerProxy.cpp:
      (WebKit::PluginControllerProxy::windowScriptNPObject):
      getOrCreateNPObjectProxy is now createNPObjectProxy.
      
      * Shared/Plugins/NPObjectProxy.cpp:
      (WebKit::NPObjectProxy::create):
      Allocate and initialize an NPObjectProxy object.
      
      (WebKit::NPObjectProxy::NPObjectProxy):
      Initialize m_npObjectID to 0.
      
      (WebKit::NPObjectProxy::isNPObjectProxy):
      Check the class.
      
      (WebKit::NPObjectProxy::initialize):
      Set m_npObjectID.
      
      (WebKit::NPObjectProxy::npClass):
      Return the NPClass with all functions filled in.
      
      (WebKit::NPObjectProxy::NP_Allocate):
      Create a new NPObjectProxy object.
      
      (WebKit::NPObjectProxy::NP_Deallocate):
      Deallocate the NPObjectProxy object.
      
      (WebKit::NPObjectProxy::NP_HasMethod):
      (WebKit::NPObjectProxy::NP_Invoke):
      (WebKit::NPObjectProxy::NP_InvokeDefault):
      (WebKit::NPObjectProxy::NP_HasProperty):
      (WebKit::NPObjectProxy::NP_GetProperty):
      (WebKit::NPObjectProxy::NP_SetProperty):
      (WebKit::NPObjectProxy::NP_RemoveProperty):
      (WebKit::NPObjectProxy::NP_Enumerate):
      (WebKit::NPObjectProxy::NP_Construct):
      Add stubs.
      
      * Shared/Plugins/NPRemoteObjectMap.cpp:
      (WebKit::NPRemoteObjectMap::createNPObjectProxy):
      * Shared/Plugins/NPRemoteObjectMap.h:
      Rename getOrCreateNPObjectProxy to createNPObjectProxy.
      
      * WebProcess/Plugins/Netscape/NPJSObject.cpp:
      (WebKit::NPJSObject::NP_Allocate):
      Remove unused parameter.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71054 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      004117f4
    • dimich@chromium.org's avatar
      [Chromium] Unreviewed update of test expectations. · 5cd79318
      dimich@chromium.org authored
      Add baseline for a new test added in http://trac.webkit.org/changeset/71043
      
      * platform/chromium-mac/fast/repaint/inline-vertical-rl-overflow-expected.checksum: Added.
      * platform/chromium-mac/fast/repaint/inline-vertical-rl-overflow-expected.png: Added.
      * platform/chromium-mac/fast/repaint/inline-vertical-rl-overflow-expected.txt: Added.
      * platform/chromium-win/fast/repaint/inline-vertical-rl-overflow-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71053 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5cd79318
    • mario@webkit.org's avatar
      2010-11-01 Mario Sanchez Prada <msanchez@igalia.com> · 8e3dca8d
      mario@webkit.org authored
              Reviewed by Martin Robinson.
      
              [GTK] Cleanup needed in testatk.c file
              https://bugs.webkit.org/show_bug.cgi?id=48759
      
              Cleanup done in testatk.c, mainly addressing the following issues:
      
              - Removed any trace of extra main loops in tests, so now we just
              spin the original main loop in all of them to get the a11y
              objects.
      
              - As we no longer use the extra main loops, removed the bail_out
              function, used along with g_idle_add() to stop those extra loops.
      
              - As we now spin the loop in every test, created a new function
              waitForAccessibilityObjects() to write the loop just once.
      
              - Fixed name in incorrectly named test testWekitAtkTextSelections.
      
              - Alphabetically sorted the list of includes.
      
              - Renamed all identifiers to camel Case notation.
      
              - Declare variables when needed only (instead of declaring all of
              them at the beginning of the function).
      
              - Don't declare two variables of the same type in the same line.
      
              - No more short names like 'obj', 'textObj' or 'alloc'. Use names
              like 'object', 'textObject' and 'allocation' instead.
      
              - Fixed indentation.
      
              - Make sure all comments finish with '.'
      
              - Replace NULL's with 0's.
      
              * tests/testatk.c:
              (waitForAccessibleObjects): New, manually spins the main context
              to make sure accessible objects are created before continuing.
              (testGetTextFunction): Fixed this function to be compliant with
              the WebKit's coding style.
              (runGetTextTests): Ditto.
              (testWebkitAtkGetTextAtOffsetForms): Ditto.
              (testWebkitAtkGetTextAtOffset): Ditto.
              (testWebkitAtkGetTextAtOffsetNewlines): Ditto.
              (testWebkitAtkGetTextAtOffsetTextarea): Ditto.
              (testWebkitAtkGetTextAtOffsetTextInput): Ditto.
              (testWebkitAtkGetTextInParagraphAndBodySimple): Ditto.
              (testWebkitAtkGetTextInParagraphAndBodyModerate): Ditto.
              (testWebkitAtkGetTextInTable): Ditto.
              (testWebkitAtkGetHeadersInTable): Ditto.
              (compAtkAttribute): Ditto.
              (atkAttributeSetAttributeNameHasValue): Ditto.
              (testWebkitAtkTextAttributes): Ditto.
              (testWebkitAtkTextSelections): Ditto.
              (testWebkitAtkGetExtents): Ditto.
              (testWebkitAtkLayoutAndDataTables): Ditto.
              (testWebkitAtkLinksWithInlineImages): Ditto.
              (testWebkitAtkHypertextAndHyperlinks): Ditto.
              (testWebkitAtkListsOfItems): Ditto.
              (testWebkitAtkTextChangedNotifications): Ditto.
              (main): Ditto.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71052 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8e3dca8d
    • andersca@apple.com's avatar
      Both the WebProcessConnection and PluginProcessConnection should have NPRemoteObjectMaps · e8573036
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=48775
      
      Reviewed by Adam Roben.
      
      * PluginProcess/PluginControllerProxy.cpp:
      (WebKit::PluginControllerProxy::windowScriptNPObject):
      Ask for an NPObjectProxy for the window script NPObject.
      
      * PluginProcess/WebProcessConnection.cpp:
      (WebKit::WebProcessConnection::WebProcessConnection):
      Initialize m_npRemoteObjectMap.
      
      * Shared/Plugins/NPObjectMessageReceiver.cpp:
      (WebKit::NPObjectMessageReceiver::create):
      Add a create member function that takes an NPObject.
      
      (WebKit::NPObjectMessageReceiver::NPObjectMessageReceiver):
      Retain the NPObject.
      
      (WebKit::NPObjectMessageReceiver::~NPObjectMessageReceiver):
      Release the NPObject.
      
      * Shared/Plugins/NPRemoteObjectMap.cpp:
      (WebKit::generateNPObjectID):
      Generate a unique 64-bit NPObject ID.
      
      (WebKit::NPRemoteObjectMap::getOrCreateNPObjectProxy):
      Add stub.
      
      (WebKit::NPRemoteObjectMap::registerNPObject):
      Create a NPObjectMessageReceiver and add it to the map.
      
      * WebKit2.xcodeproj/project.pbxproj:
      Set the correct target for NPRuntime related files.
      
      * WebProcess/Plugins/PluginProcessConnection.cpp:
      (WebKit::PluginProcessConnection::PluginProcessConnection):
      Initialize m_npRemoteObjectMap
      
      * WebProcess/Plugins/PluginProxy.cpp:
      (WebKit::PluginProxy::getWindowScriptNPObject):
      Ask the real plug-in controller for the window script NPObject and register it.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71051 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e8573036
    • dimich@chromium.org's avatar
      [Chromium] Unreviewed, update test expectations. · 8ae96912
      dimich@chromium.org authored
      Updated render tree dumps after http://trac.webkit.org/changeset/71043.
      
      * platform/chromium-linux/fast/blockflow/japanese-lr-text-expected.txt:
      * platform/chromium-linux/fast/blockflow/japanese-rl-text-expected.txt:
      * platform/chromium-win/fast/blockflow/basic-vertical-line-expected.txt:
      * platform/chromium-win/fast/blockflow/border-radius-clipping-vertical-lr-expected.txt:
      * platform/chromium-win/fast/blockflow/box-shadow-vertical-lr-expected.txt:
      * platform/chromium-win/fast/blockflow/box-shadow-vertical-rl-expected.txt:
      * platform/chromium-win/fast/blockflow/english-lr-text-expected.txt:
      * platform/chromium-win/fast/blockflow/english-rl-text-expected.txt:
      * platform/chromium-win/fast/blockflow/japanese-lr-text-expected.txt:
      * platform/chromium-win/fast/blockflow/japanese-rl-text-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71050 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8ae96912
    • simon.fraser@apple.com's avatar
      2010-11-01 Simon Fraser <simon.fraser@apple.com> · 8987f0b7
      simon.fraser@apple.com authored
              Reviewed by Dave Hyatt.
      
              Multiple background properties are not retrievable via DOM method getComputedStyle
              https://bugs.webkit.org/show_bug.cgi?id=23203
      
              Return lists of values from getComputedStyle() for multiple backgrounds,
              and multiple masks.
      
              Test: fast/backgrounds/multiple-backgrounds-computed-style.html
      
              * css/CSSComputedStyleDeclaration.cpp:
              (WebCore::fillSizeToCSSValue):
              (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71049 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8987f0b7
    • sullivan@apple.com's avatar
      https://bugs.webkit.org/show_bug.cgi?id=48774 · 87cddddd
      sullivan@apple.com authored
      minimFontSize preference needs to be exposed in WebKit2
      
      Reviewed by Anders Carlsson.
      
      * UIProcess/WebPreferences.cpp:
      (WebKit::WebPreferences::setMinimumFontSize):
      New function, parallel to existing functions for other preferences.
      (WebKit::WebPreferences::minimumFontSize):
      Ditto.
      
      * UIProcess/WebPreferences.h:
      Declared new function.
      
      * UIProcess/API/C/WKPreferences.cpp:
      (WKPreferencesSetMinimumFontSize):
      New UI process wrapper for new function.
      (WKPreferencesGetMinimumFontSize):
      Ditto.
      
      * UIProcess/API/C/WKPreferences.h:
      Declared new functions.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71048 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      87cddddd
    • mihaip@chromium.org's avatar
      2010-11-01 Mihai Parparita <mihaip@chromium.org> · 75d12309
      mihaip@chromium.org authored
              Update the pixel expectations for fast/block/positioning for the Mac port.
      
              For the tests that currently fail on Snow Leopard with --pixel-tests
              --tolerance 0, this moves the current pixel results to mac-leopard and
              adds new Snow Leopard-specific results to platform/mac.
      
              List of files omitted due to length but composed entirely of moves from
              platform/mac to platform/mac-leopard and newly added files in
              platform/mac.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71047 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      75d12309
    • dimich@chromium.org's avatar
      [Chromium] Unreviewed update of test expectations. · ce8fb8d3
      dimich@chromium.org authored
      svg-as-background.html now fails on debug mac 10.5 bots.
      
      * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71046 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ce8fb8d3
    • andersca@apple.com's avatar
      Tear down the related WebProcessProxy when a WebContext is deallocated · c207acf1
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=48769
      
      Reviewed by John Sullivan.
      
      WebKit2:
      
      * UIProcess/WebContext.cpp:
      (WebKit::WebContext::~WebContext):
      Call WebProcessManager::contextWasDestroyed.
      
      (WebKit::WebContext::didNavigateWithNavigationData):
      (WebKit::WebContext::didPerformClientRedirect):
      (WebKit::WebContext::didPerformServerRedirect):
      (WebKit::WebContext::didUpdateHistoryTitle):
      It is valid for a frame to have a null page here, if the frame has outlived
      its page.
      
      * UIProcess/WebProcessManager.cpp:
      (WebKit::WebProcessManager::contextWasDestroyed):
      Remove the context from the map.
      
      * UIProcess/WebProcessProxy.cpp:
      (WebKit::WebProcessProxy::~WebProcessProxy):
      It's OK for the connection to be non-null here if the process goes away because
      the context has been deallocated.
      
      WebKitTools:
      
      * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
      (TestWebKitAPI::didFailProvisionalLoadWithErrorForFrame):
      We don't support empty URLs anymore, update test to expect a null URL instead.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71044 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c207acf1
    • hyatt@apple.com's avatar
      https://bugs.webkit.org/show_bug.cgi?id=48663 · 46ed5559
      hyatt@apple.com authored
      Reviewed by Dan Bernstein.
      
      Make repaint invalidation work with vertical lines.  Rewrite linesBoundingBox for RenderText and
      RenderInline to give the correct rectangle back for vertical lines.  Also patch linesVisibleOverflowBoundingBox
      to give back the correct rectangle for vertical lines.
      
      Fix bugs in the overflow accessors of InlineFlowBox when m_overflow was 0.
              
      Patch hit testing to also account for "rt" and "bt" blocks.
      
      WebCore: 
      
      * rendering/InlineBox.cpp:
      (WebCore::InlineBox::adjustForFlippedBlocksWritingMode):
      * rendering/InlineFlowBox.cpp:
      (WebCore::InlineFlowBox::nodeAtPoint):
      * rendering/InlineFlowBox.h:
      (WebCore::InlineFlowBox::logicalLeftVisibleOverflow):
      (WebCore::InlineFlowBox::logicalRightVisibleOverflow):
      (WebCore::InlineFlowBox::bottomLayoutOverflow):
      (WebCore::InlineFlowBox::rightLayoutOverflow):
      (WebCore::InlineFlowBox::bottomVisualOverflow):
      (WebCore::InlineFlowBox::rightVisualOverflow):
      * rendering/InlineTextBox.cpp:
      (WebCore::InlineTextBox::nodeAtPoint):
      * rendering/RenderBlock.cpp:
      (WebCore::RenderBlock::hitTestFloats):
      (WebCore::RenderBlock::hitTestContents):
      * rendering/RenderBox.cpp:
      (WebCore::RenderBox::computeRectForRepaint):
      (WebCore::RenderBox::adjustForFlippedBlocksWritingMode):
      * rendering/RenderBox.h:
      * rendering/RenderInline.cpp:
      (WebCore::RenderInline::linesBoundingBox):
      (WebCore::RenderInline::linesVisibleOverflowBoundingBox):
      (WebCore::RenderInline::clippedOverflowRectForRepaint):
      * rendering/RenderText.cpp:
      (WebCore::RenderText::linesBoundingBox):
      
      LayoutTests: 
      
      * fast/repaint/inline-horizontal-bt-overflow.html: Added.
      * fast/repaint/inline-vertical-lr-overflow.html: Added.
      * fast/repaint/inline-vertical-rl-overflow.html: Copied from fast/repaint/inline-vertical-rl-overflow.html.
      * platform/mac/fast/blockflow/background-vertical-lr-expected.txt:
      * platform/mac/fast/blockflow/background-vertical-rl-expected.txt:
      * platform/mac/fast/blockflow/basic-vertical-line-expected.txt:
      * platform/mac/fast/blockflow/border-image-vertical-lr-expected.txt:
      * platform/mac/fast/blockflow/border-image-vertical-rl-expected.txt:
      * platform/mac/fast/blockflow/border-radius-clipping-vertical-lr-expected.txt:
      * platform/mac/fast/blockflow/border-vertical-lr-expected.checksum:
      * platform/mac/fast/blockflow/border-vertical-lr-expected.png:
      * platform/mac/fast/blockflow/border-vertical-lr-expected.txt:
      * platform/mac/fast/blockflow/box-shadow-vertical-lr-expected.txt:
      * platform/mac/fast/blockflow/box-shadow-vertical-rl-expected.txt:
      * platform/mac/fast/blockflow/english-lr-text-expected.txt:
      * platform/mac/fast/blockflow/english-rl-text-expected.txt:
      * platform/mac/fast/blockflow/japanese-lr-text-expected.txt:
      * platform/mac/fast/blockflow/japanese-rl-text-expected.txt:
      * platform/mac/fast/repaint/inline-horizontal-bt-overflow-expected.checksum: Added.
      * platform/mac/fast/repaint/inline-horizontal-bt-overflow-expected.png: Added.
      * platform/mac/fast/repaint/inline-horizontal-bt-overflow-expected.txt: Added.
      * platform/mac/fast/repaint/inline-vertical-lr-overflow-expected.checksum: Added.
      * platform/mac/fast/repaint/inline-vertical-lr-overflow-expected.png: Added.
      * platform/mac/fast/repaint/inline-vertical-lr-overflow-expected.txt: Added.
      * platform/mac/fast/repaint/inline-vertical-rl-overflow-expected.checksum: Copied from platform/mac/fast/repaint/inline-vertical-rl-overflow-expected.checksum.
      * platform/mac/fast/repaint/inline-vertical-rl-overflow-expected.png: Copied from platform/mac/fast/repaint/inline-vertical-rl-overflow-expected.png.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71043 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      46ed5559